commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
e82995f03cc199f9a1c8aac3f2597420e65d0211
Trevor Elliott
2023-01-31T22:26:10
Add a convenience function for displaying a BlockCall (#5677) Add a display method to BlockCall that returns a std::fmt::Displayable result. Rework the display code in the write module of cranelift-codegen to use this method instead.
diff --git a/cranelift/codegen/src/ir/instructions.rs b/cranelift/codegen/src/ir/instructions.rs index 0edb2daf3..dec1e8728 100644 --- a/cranelift/codegen/src/ir/instructions.rs +++ b/cranelift/codegen/src/ir/instructions.rs @@ -118,6 +118,35 @@ impl BlockCall { { self.values.extend(elements, pool) }...
2
32
15
7f2c8e6344572393434f88cc2d21777ff9634178
Alex Crichton
2023-01-31T20:54:58
Fix some warnings on nightly Rust (#5668) * Fix some warnings on nightly Rust Cargo is warning about the usage of workspace dependencies where the workspace declaration does not mention `default-features` but the dependency mentions `default-features`, so this explicitly turns off default features for `cranelift...
diff --git a/cranelift/frontend/Cargo.toml b/cranelift/frontend/Cargo.toml index bb68f5e8d..eafcf74e9 100644 --- a/cranelift/frontend/Cargo.toml +++ b/cranelift/frontend/Cargo.toml @@ -11,7 +11,7 @@ readme = "README.md" edition.workspace = true [dependencies] -cranelift-codegen = { workspace = true, default-feature...
6
8
8
10fcd14287f8c145ec19511838f573abe3ebafb0
Trevor Elliott
2023-01-31T19:45:59
Remove unused code from the write module (#5674) The DisplayValuesWithDelimiter struct is no longer used.
diff --git a/cranelift/codegen/src/write.rs b/cranelift/codegen/src/write.rs index bd9167284..1eaa78d63 100644 --- a/cranelift/codegen/src/write.rs +++ b/cranelift/codegen/src/write.rs @@ -525,21 +525,6 @@ impl<'a> fmt::Display for DisplayValues<'a> { } } -struct DisplayValuesWithDelimiter<'a>(&'a [Value], char...
1
0
15
f110bd98d107997d72152999b3295f435af9a3a7
Kevin Rizzo
2023-01-31T19:22:11
Making sure that new files in the winch filetests directory will cause a rebuild (#5672)
diff --git a/winch/filetests/build.rs b/winch/filetests/build.rs new file mode 100644 index 000000000..bd0f62b29 --- /dev/null +++ b/winch/filetests/build.rs @@ -0,0 +1,4 @@ +fn main() { + // Ensure that new files in the filetests directory cause a rebuild. + println!("cargo:rerun-if-changed=filetests"); +}
1
4
0
bf4d0e92125c4d8b666703f36506ea1f6328026c
Nick Fitzgerald
2023-01-31T05:25:14
Cranelift: Fix `select` condition harvesting (#5662) Souper requires an `i1` condition value, we don't and will implicitly check against 0. We were truncating conditions but should actually be doing the comparison against `0`.
diff --git a/cranelift/codegen/src/souper_harvest.rs b/cranelift/codegen/src/souper_harvest.rs index a690fa726..d818eee9f 100644 --- a/cranelift/codegen/src/souper_harvest.rs +++ b/cranelift/codegen/src/souper_harvest.rs @@ -387,7 +387,8 @@ fn harvest_candidate_lhs( let a = arg(allocs, 0); ...
1
10
2
b5692db7ced95869b96701af5864041bd6fc43d3
Trevor Elliott
2023-01-31T00:12:05
Remove boolean parameters from instruction builder functions (#5658) Remove the boolean parameters from the instruction builder functions, as they were only ever used with true. Additionally, change the returns and branches functions to imply terminates_block.
diff --git a/cranelift/codegen/meta/src/cdsl/instructions.rs b/cranelift/codegen/meta/src/cdsl/instructions.rs index 11025921c..da5657ae8 100644 --- a/cranelift/codegen/meta/src/cdsl/instructions.rs +++ b/cranelift/codegen/meta/src/cdsl/instructions.rs @@ -171,52 +171,59 @@ impl InstructionBuilder { self ...
2
96
93
e4fa35586654675297aaa502f7b6e1f504a01d8b
Nick Fitzgerald
2023-01-30T23:32:47
cranelift: Generate the correct souper size for comparisons in LHSes (#5659)
diff --git a/cranelift/codegen/src/souper_harvest.rs b/cranelift/codegen/src/souper_harvest.rs index d24b58b99..a690fa726 100644 --- a/cranelift/codegen/src/souper_harvest.rs +++ b/cranelift/codegen/src/souper_harvest.rs @@ -528,9 +528,16 @@ fn souper_type_of(dfg: &ir::DataFlowGraph, val: ir::Value) -> Option<ast::Type...
1
10
3
56048d445805c5b82a1a35531dc680d35b9efe84
Dan Gohman
2023-01-30T19:17:44
Rename `wasi-future` to `waitable`. (#70) * Rename `wasi-future` to `waitable`. You can wait on `waitable`s multiple times, which differs from proper futures, which you can only wait on once. * Rename `waitable` to `pollable`. Because the function they're passed to is `poll-oneoff`.
diff --git a/src/lib.rs b/src/lib.rs index fe62d1958..973ff6f70 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -13,7 +13,7 @@ use core::mem::{align_of, forget, replace, size_of, ManuallyDrop, MaybeUninit}; use core::ptr::{self, null_mut}; use core::slice; use wasi::*; -use wasi_poll::{WasiFuture, WasiStream}; +use wasi...
1
24
22
7711ed80e32845dea922d89e4678813f5a1749e3
Dan Gohman
2023-01-30T19:17:44
Rename `wasi-future` to `waitable`. (#70) * Rename `wasi-future` to `waitable`. You can wait on `waitable`s multiple times, which differs from proper futures, which you can only wait on once. * Rename `waitable` to `pollable`. Because the function they're passed to is `poll-oneoff`.
diff --git a/host/src/poll.rs b/host/src/poll.rs index 70dad61bc..02313b563 100644 --- a/host/src/poll.rs +++ b/host/src/poll.rs @@ -1,6 +1,6 @@ use crate::{ wasi_clocks, - wasi_poll::{self, Size, StreamError, WasiFuture, WasiPoll, WasiStream}, + wasi_poll::{self, Pollable, Size, StreamError, WasiPoll, Wasi...
1
23
15
20a216923b5d6bc129935ad56de1ca9ccea38949
Trevor Elliott
2023-01-28T01:46:11
Fix an assertion failure with an empty Switch (#5650) Fix an error introduced in #5644, where an unsigned subtraction from zero was possible with an empty Switch structure. Additionally, missing the empty case caused us to not emit a branch to the default block. This PR fixes the issue by detecting the empty Switch ca...
diff --git a/cranelift/frontend/src/switch.rs b/cranelift/frontend/src/switch.rs index 3920ba853..1e6c3d930 100644 --- a/cranelift/frontend/src/switch.rs +++ b/cranelift/frontend/src/switch.rs @@ -114,6 +114,12 @@ impl Switch { otherwise: Block, contiguous_case_ranges: &'a [ContiguousCaseRange], ...
1
28
12
ffbcc67eb37f202d4fb9f15fc1c25505027f5957
Nick Fitzgerald
2023-01-28T00:30:42
Cranelift: Consider shifts as "simple" arithmetic in egraph cost model (#5646)
diff --git a/cranelift/codegen/src/egraph/cost.rs b/cranelift/codegen/src/egraph/cost.rs index 8a9f85281..fd9a22ee2 100644 --- a/cranelift/codegen/src/egraph/cost.rs +++ b/cranelift/codegen/src/egraph/cost.rs @@ -90,7 +90,10 @@ pub(crate) fn pure_op_cost(op: Opcode) -> Cost { | Opcode::BorNot | Opcode...
1
4
1
b47006d43268e6416fdef8b931602a683176d569
Trevor Elliott
2023-01-28T00:00:40
Rework the switch module in cranelift-frontend in terms of brif (#5644) Rework the compilation strategy for switch to: * use brif instead of brz and brnz * generate tables inline, rather than delyaing them to after the decision tree has been generated * avoid allocating new vectors by using slices into the sorted c...
diff --git a/Cargo.lock b/Cargo.lock index a5c941a1b..6780b4cfc 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -622,6 +622,7 @@ dependencies = [ "cranelift-codegen", "hashbrown", "log", + "similar", "smallvec", "target-lexicon", ] diff --git a/cranelift/frontend/Cargo.toml b/cranelift/frontend/Cargo.toml index ...
3
153
185
0f8393508a3bd5b3c71046b3d4fa003bf1a174cc
Saúl Cabrera
2023-01-27T19:36:26
cranelift-codegen: Expose `EmitState` and `EmitInfo` from aarch64 (#5640) This commit exposes `EmitState` and `EmitInfo` so that they can be consumed by Winch. This is a follow up to https://github.com/bytecodealliance/wasmtime/pull/5570, in which this should've been included.
diff --git a/cranelift/codegen/src/isa/aarch64/inst/mod.rs b/cranelift/codegen/src/isa/aarch64/inst/mod.rs index 7ad3e1f0b..3ab227a1b 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/mod.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/mod.rs @@ -21,7 +21,7 @@ pub mod imms; pub use self::imms::*; pub mod args; pub...
1
1
1
058d93bc64ad9114e8f4971d3752e71be136c45b
Trevor Elliott
2023-01-27T18:34:41
Migrate cranelift-wasm to brif (#5638) Incrementally working towards removing brz and brnz completely.
diff --git a/cranelift/frontend/src/frontend.rs b/cranelift/frontend/src/frontend.rs index dbef386f8..21320d8cb 100644 --- a/cranelift/frontend/src/frontend.rs +++ b/cranelift/frontend/src/frontend.rs @@ -680,14 +680,14 @@ impl<'a> FunctionBuilder<'a> { /// /// **Note:** You are responsible for maintaining th...
3
76
42
a25f3f6ba85e53b92d6362cddffdef64835c2604
Alex Crichton
2023-01-26T19:54:18
Fix the non-command build (#72) This commit fixes the non-command build of the WASI adapter by adding a new `wasi.wit` which only has the imports and nothing else.
diff --git a/src/lib.rs b/src/lib.rs index 12f3f276b..fe62d1958 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -19,6 +19,7 @@ use wasi_poll::{WasiFuture, WasiStream}; mod macros; mod bindings { + #[cfg(feature = "command")] wit_bindgen_guest_rust::generate!({ world: "wasi-command", no_std, @@...
1
10
7
556cea39e680335ef3d2d7a7fb69fe95fadc3be5
Alex Crichton
2023-01-26T19:54:03
Use a more targeted means of specifying link flags (#71) * Use a more targeted means of specifying link flags I had forgotten earlier that this could be done with build scripts so do that in the adapter's build script rather than as auxiliary rust flags. * Remove `.cargo/config.toml` file This now only serv...
diff --git a/build.rs b/build.rs index 0f3884b4b..b5f7ccd30 100644 --- a/build.rs +++ b/build.rs @@ -13,6 +13,13 @@ fn main() { "cargo:rustc-link-search=native={}", out_dir.to_str().unwrap() ); + + // Some specific flags to `wasm-ld` to inform the shape of this adapter. + // Notably we're i...
1
7
0
4ad86752de2c5353183364593d6c37ca43ec2a9d
Alex Crichton
2023-01-25T18:09:15
Fix libcall relocations for precompiled modules (#5608) * Fix libcall relocations for precompiled modules This commit fixes some asserts and support for relocation libcalls in precompiled modules loaded from disk. In doing so this reworks how mmaps are managed for files from disk. All non-file-backed `Mmap` entri...
diff --git a/crates/jit/src/code_memory.rs b/crates/jit/src/code_memory.rs index 01365a42a..f4bd18a2d 100644 --- a/crates/jit/src/code_memory.rs +++ b/crates/jit/src/code_memory.rs @@ -237,8 +237,22 @@ impl CodeMemory { // both the actual unwinding tables as well as the validity of the // pointers...
4
124
79
38bf38c514372fc532b4737a7e33cab5af0eb60e
Alex Crichton
2023-01-25T17:00:34
Flag to rustdoc component support requires a feature (#5632) This helps render the information "officially" in documentation.
diff --git a/crates/wasmtime/src/component/mod.rs b/crates/wasmtime/src/component/mod.rs index c795d2f70..3ff3e6e7b 100644 --- a/crates/wasmtime/src/component/mod.rs +++ b/crates/wasmtime/src/component/mod.rs @@ -3,6 +3,8 @@ //! This module is a work-in-progress and currently represents an incomplete and //! probably...
1
2
0
7a1082058026be42ac179ccff332d5258c6c0848
Alex Crichton
2023-01-25T16:25:21
Update wasmtime and wit-bindgen (#68) * Update wasmtime and wit-bindgen This commit updates the `wasmtime` dependency and the `wit-bindgen-guest-rust` dependencies to namely update the `wit-parser` and component underlying implementations. This pulls in bytecodealliance/wasm-tools#867 which is the implementatio...
diff --git a/host/src/lib.rs b/host/src/lib.rs index 8d6dd1007..37421bbc6 100644 --- a/host/src/lib.rs +++ b/host/src/lib.rs @@ -11,7 +11,8 @@ pub use wasi_common::{table::Table, WasiCtx}; type HostResult<T, E> = anyhow::Result<Result<T, E>>; wasmtime::component::bindgen!({ - path: "../wit/wasi.wit", + path: ...
3
46
78
710cc4ce82fa91ae44c9d022fcca99d5b3d83080
Alex Crichton
2023-01-25T16:25:21
Update wasmtime and wit-bindgen (#68) * Update wasmtime and wit-bindgen This commit updates the `wasmtime` dependency and the `wit-bindgen-guest-rust` dependencies to namely update the `wit-parser` and component underlying implementations. This pulls in bytecodealliance/wasm-tools#867 which is the implementatio...
diff --git a/src/lib.rs b/src/lib.rs index d10befa44..12f3f276b 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -20,7 +20,7 @@ mod macros; mod bindings { wit_bindgen_guest_rust::generate!({ - path: "wit/wasi.wit", + world: "wasi-command", no_std, raw_strings, unchecked,
1
1
1
ec6922ff2407bb81f148bd8b14ee66642ea38a5f
bjorn3
2023-01-24T19:17:28
Produce an error at runtime rather than at compile time for unsupported architectures in cranelift-native (#5627)
diff --git a/cranelift/native/src/lib.rs b/cranelift/native/src/lib.rs index 8d2a3ca1c..653b2dc3a 100644 --- a/cranelift/native/src/lib.rs +++ b/cranelift/native/src/lib.rs @@ -46,11 +46,6 @@ pub fn builder_with_options(infer_native_flags: bool) -> Result<isa::Builder, &' isa::LookupError::Unsupported => "unsu...
1
0
5
d238f9a6624eb9a85b51e3ffa82a9a326dd1bdf4
Dan Gohman
2023-01-24T00:06:55
Rename the `wasi` world to `wasi-command`. (#61) There will be other worlds in WASI, so rename the `wasi-command` world to accomodate them.
diff --git a/host/src/main.rs b/host/src/main.rs index e1cb69187..26ab3d64e 100644 --- a/host/src/main.rs +++ b/host/src/main.rs @@ -1,5 +1,5 @@ use anyhow::{Context, Result}; -use host::{add_to_linker, Wasi}; +use host::{add_to_linker, WasiCommand}; use std::path::PathBuf; use wasi_cap_std_sync::WasiCtxBuilder; us...
2
75
66
479661dab524141a50543fd0f16c95689abc0c92
Dan Gohman
2023-01-23T23:07:52
On Windows, ignore access-denied errors from `sync_all`. (#67) * On Windows, ignore access-denied errors from `sync_all`. On Windows `sync_all` does `FlushFileBuffers` which fails with an access-denied error if the file not opened for writing. Ignore this error, for compatibility with POSIX-style APIs. Fixes #...
diff --git a/test-programs/Cargo.toml b/test-programs/Cargo.toml index d19c28e99..5f40f537f 100644 --- a/test-programs/Cargo.toml +++ b/test-programs/Cargo.toml @@ -7,4 +7,5 @@ publish = false [dependencies] getrandom = "0.2.8" rustix = "0.36.6" +cap-std = "1.0.3" wit-bindgen-guest-rust = { git = "https://github.co...
3
30
5
ae441c50b6f7c76455a3d7a5d2d733187189b230
Afonso Bordado
2023-01-23T17:03:07
fuzzgen: Reenable some RISCV instructions (#5615)
diff --git a/cranelift/fuzzgen/src/function_generator.rs b/cranelift/fuzzgen/src/function_generator.rs index f98212c9c..1de8f15c6 100644 --- a/cranelift/fuzzgen/src/function_generator.rs +++ b/cranelift/fuzzgen/src/function_generator.rs @@ -556,11 +556,6 @@ fn valid_for_target(triple: &Triple, op: Opcode, args: &[Type]...
1
0
24
0e6e802c34d4d283c63af62483171105ce0a3034
Saúl Cabrera
2023-01-23T15:05:33
docs: Fix typo (#5620)
diff --git a/cranelift/codegen/src/isa/aarch64/abi.rs b/cranelift/codegen/src/isa/aarch64/abi.rs index 180fd22f2..8d8074177 100644 --- a/cranelift/codegen/src/isa/aarch64/abi.rs +++ b/cranelift/codegen/src/isa/aarch64/abi.rs @@ -430,7 +430,7 @@ impl ABIMachineSpec for AArch64MachineDeps { } else { ...
1
1
1
9b10c0b90a78a638ba0d70aa5291deda0af0f6f7
Dan Gohman
2023-01-21T00:58:28
Change the filesystem timestamp to seconds+nanoseconds. (#55) This corresponds to https://github.com/WebAssembly/wasi-filesystem/pull/76.
diff --git a/src/lib.rs b/src/lib.rs index 966247679..d10befa44 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -548,9 +548,9 @@ pub unsafe extern "C" fn fd_filestat_get(fd: Fd, buf: *mut Filestat) -> Errno { filetype, nlink: stat.nlink, size: stat.size, - atim: stat.atim, ...
1
26
10
af3b2a032d655d00b6885ec6e6f1fad784b48f00
Dan Gohman
2023-01-21T00:58:28
Change the filesystem timestamp to seconds+nanoseconds. (#55) This corresponds to https://github.com/WebAssembly/wasi-filesystem/pull/76.
diff --git a/host/src/filesystem.rs b/host/src/filesystem.rs index e6f192ca0..b5fc9e509 100644 --- a/host/src/filesystem.rs +++ b/host/src/filesystem.rs @@ -179,15 +179,18 @@ impl From<wasi_common::file::FileType> for wasi_filesystem::DescriptorType { impl From<wasi_common::file::Filestat> for wasi_filesystem::Descr...
1
10
7
528f095d337a6a480b15b5f8d85b732e304bb9e5
Dan Gohman
2023-01-21T00:58:10
Use the `wasi-stderr` API for stderr (#59) Use the dedicated `wasi-stderr` API for stderr, instead of `wasi-logging`. Fixes #57.
diff --git a/src/lib.rs b/src/lib.rs index 334d1bebd..966247679 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -2,7 +2,7 @@ use crate::bindings::{ wasi_clocks, wasi_default_clocks, wasi_exit, wasi_filesystem, wasi_logging, wasi_poll, - wasi_random, wasi_tcp, + wasi_random, wasi_stderr, wasi_tcp, }; use cor...
1
17
25
69cd0a6b1a78c9c793b549256d76c879b48cb3db
Chris Fallin
2023-01-20T22:52:49
Add deprecation notice to `cranelift_use_egraphs` option. (#5610) After #5587, this is on by default. We are retaining the traditional (no-egraphs) path for now, selected by setting this option to `false`, but we eventually plan to delete it assuming that we don't find serious regressions or issues. This PR adds a ...
diff --git a/crates/fuzzing/src/generators/config.rs b/crates/fuzzing/src/generators/config.rs index aaf435c01..c3016fa6c 100644 --- a/crates/fuzzing/src/generators/config.rs +++ b/crates/fuzzing/src/generators/config.rs @@ -141,6 +141,7 @@ impl Config { } /// Converts this to a `wasmtime::Config` object + ...
2
5
0
5e8c6c9117c92d4af507344c8178002d1ea7d466
Alex Crichton
2023-01-20T18:10:00
Fix multi-memory condition when spectest fuzzing (#5609) The check needs to verify that the maximum number of memories is precisely one to ensure that multi-memory is disabled yet modules can still have up to one memory as configured in the pooling allocator.
diff --git a/crates/fuzzing/src/generators/config.rs b/crates/fuzzing/src/generators/config.rs index f673421dd..aaf435c01 100644 --- a/crates/fuzzing/src/generators/config.rs +++ b/crates/fuzzing/src/generators/config.rs @@ -116,8 +116,10 @@ impl Config { } // Make sure the runtime limits allow for ...
1
4
2
92de180d7d93b05b9171498c88978ea90745af93
Pat Hickey
2023-01-20T15:53:04
component bindgen: accept strs as well as identifiers for wit identifiers (#5600) This is required because not all wit identifiers are Rust identifiers, so we can smuggle the invalid ones inside quotes.
diff --git a/crates/component-macro/src/bindgen.rs b/crates/component-macro/src/bindgen.rs index 435abbb42..d9caff8f3 100644 --- a/crates/component-macro/src/bindgen.rs +++ b/crates/component-macro/src/bindgen.rs @@ -226,9 +226,23 @@ impl Parse for Opt { } fn trappable_error_field_parse(input: ParseStream<'_>) -> R...
2
19
3
457ae4d1ffdc522a8946d6c4d6d971b4a26f632b
Pat Hickey
2023-01-19T22:43:55
implement some filesystem primitives (#65) * implement some host filesystem operations: create_directory_at stat remove_directory_at symlink_at unlink_file_at * host filesystem tests: some new ones pass, others use EXPECT_FAIL constant by using `if EXPECT_FAIL` instead of `if true` its now easier to find ...
diff --git a/host/src/filesystem.rs b/host/src/filesystem.rs index ce8422f0f..e6f192ca0 100644 --- a/host/src/filesystem.rs +++ b/host/src/filesystem.rs @@ -14,6 +14,7 @@ use wasi_common::{ WasiDir, WasiFile, }; +// FIXME: guest rust bindgen should add this method to all flags. fn contains<T: BitAnd<Output = T...
3
81
63
1f534c579988c7b88b3f917ba72987fd0757d990
Alex Crichton
2023-01-19T18:48:45
Change spectest fuzzing to throw out some fuzz inputs (#5597) A fuzz bug came in last night from #5567 where spectest fuzzing will first generate a config, possibly with SSE features for SIMD disabled, only to have SIMD later enabled by `set_spectest_compliant`. This commit fixes the issue by changing to `is_specte...
diff --git a/crates/fuzzing/src/generators/config.rs b/crates/fuzzing/src/generators/config.rs index 6b0d69eef..f673421dd 100644 --- a/crates/fuzzing/src/generators/config.rs +++ b/crates/fuzzing/src/generators/config.rs @@ -97,31 +97,45 @@ impl Config { self.module_config.generate(input, default_fuel) } ...
2
41
25
56a981bdd80dc1919407b07555187cba6c7554b4
Dan Gohman
2023-01-19T17:27:42
Add `contains` and `intersects` to the component-macro bindings for flags. (#5598) In component-macro, when expanding the bindings for flags types, add `contains` and `intersects` methods, for convenience.
diff --git a/crates/component-macro/src/component.rs b/crates/component-macro/src/component.rs index b87fb6cb3..b054f993c 100644 --- a/crates/component-macro/src/component.rs +++ b/crates/component-macro/src/component.rs @@ -1114,6 +1114,14 @@ pub fn expand_flags(flags: &Flags) -> Result<TokenStream> { ...
1
8
0
7cea73a81da4ac86b1188676a89b4d99a8349d04
Trevor Elliott
2023-01-19T01:17:03
Refactor BranchInfo::Table to no longer have an optional default branch (#5593)
diff --git a/cranelift/codegen/src/dominator_tree.rs b/cranelift/codegen/src/dominator_tree.rs index 175dad5f8..0d1200db7 100644 --- a/cranelift/codegen/src/dominator_tree.rs +++ b/cranelift/codegen/src/dominator_tree.rs @@ -360,9 +360,7 @@ impl DominatorTree { for succ in func.jump_tables[jt].iter...
6
22
28
d24c2fe48c4e72dc4e17cd23bc317c0c7236b808
Alex Crichton
2023-01-19T00:39:35
Detect components in `wasmtime compile` more robustly (#5592) The binary version of component is going to change over time so use a more robust method than checking for a fixed 8 bytes.
diff --git a/Cargo.lock b/Cargo.lock index 2ae1764cf..9de93d645 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3491,6 +3491,7 @@ dependencies = [ "tempfile", "test-programs", "tokio", + "wasmparser", "wasmtime", "wasmtime-cache", "wasmtime-cli-flags", diff --git a/Cargo.toml b/Cargo.toml index 55e238f04..b2b4...
3
11
1
66e39bb34c54b0a2a411767cbd4b5d865dd03fcc
Dan Gohman
2023-01-19T00:18:52
Add `eprintln`, `unreachable`, and other macros. (#62) Add a `byte-array` proc-macro crate for converting strings into byte arrays that don't use static initializers, and use it to implement `eprintln`, an `unreachable` that prints the line number, and other macros.
diff --git a/src/lib.rs b/src/lib.rs index 5fffd8441..334d1bebd 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -4,7 +4,7 @@ use crate::bindings::{ wasi_clocks, wasi_default_clocks, wasi_exit, wasi_filesystem, wasi_logging, wasi_poll, wasi_random, wasi_tcp, }; -use core::arch::wasm32::{self, unreachable}; +use c...
2
113
49
f724bb1587534d9622ab3c946e95ad16ce5dcdc8
Dan Gohman
2023-01-18T22:24:35
Remove a redundant check.
diff --git a/host/src/filesystem.rs b/host/src/filesystem.rs index b21c970b1..ce8422f0f 100644 --- a/host/src/filesystem.rs +++ b/host/src/filesystem.rs @@ -495,9 +495,6 @@ impl wasi_filesystem::WasiFilesystem for WasiCtx { _mode: wasi_filesystem::Mode, ) -> HostResult<wasi_filesystem::Descriptor, wasi_fi...
1
0
3
940747c59932dd02f79aaf1c2cd988eae455bb5d
Dan Gohman
2023-01-18T19:04:36
Fix directory opening on Windows.
diff --git a/host/tests/runtime.rs b/host/tests/runtime.rs index b48c7ad75..0f9f05c0e 100644 --- a/host/tests/runtime.rs +++ b/host/tests/runtime.rs @@ -298,11 +298,12 @@ async fn run_file_dir_sync(mut store: Store<WasiCtx>, wasi: Wasi) -> Result<()> std::fs::File::create(dir.path().join("bar.txt"))? .wri...
1
2
1
902ca94d7595e816051e103d9962c3cf06effcee
Dan Gohman
2023-01-11T01:41:15
Implement `sync` and `datasync` on files and directories. On Windows, there doesn't appear to be a way to sync a directory, to ensure that the directory entry for a file is sync'd. So for now, just silently succeed. I've opened WebAssembly/wasi-filesystem#79 to track this at the spec level.
diff --git a/src/lib.rs b/src/lib.rs index 93bdc3468..5fffd8441 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -847,14 +847,14 @@ pub unsafe extern "C" fn fd_readdir( let dir = state.get_dir(fd)?; iter = DirEntryIterator { state, - cookie: 0, + ...
1
3
3
5946561f9333d6e3ec3936ab08ed50a4231c3e77
Dan Gohman
2023-01-11T01:41:15
Implement `sync` and `datasync` on files and directories. On Windows, there doesn't appear to be a way to sync a directory, to ensure that the directory entry for a file is sync'd. So for now, just silently succeed. I've opened WebAssembly/wasi-filesystem#79 to track this at the spec level.
diff --git a/host/src/filesystem.rs b/host/src/filesystem.rs index 2e7a7be0f..b21c970b1 100644 --- a/host/src/filesystem.rs +++ b/host/src/filesystem.rs @@ -218,7 +218,24 @@ impl wasi_filesystem::WasiFilesystem for WasiCtx { &mut self, fd: wasi_filesystem::Descriptor, ) -> HostResult<(), wasi_fil...
8
118
17
6a41baf306168ca46a91d99be1326344874b372d
Dan Gohman
2023-01-18T14:13:52
Don't fail poll for per-fd failures. When a fd is not pollable, report it as an immediately-ready future, rather than as a poll failure.
diff --git a/src/lib.rs b/src/lib.rs index e3ffcdda3..93bdc3468 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -1552,13 +1552,35 @@ pub unsafe extern "C" fn poll_oneoff( } } - EVENTTYPE_FD_READ => wasi_poll::subscribe_read( - state.get_read_stream(s...
1
28
6
266effeef22c4efc9886ff9b4236916d690fae49
Dan Gohman
2023-01-18T14:27:08
Remove eager num_ready_bytes call.
diff --git a/wasi-common/cap-std-sync/src/sched.rs b/wasi-common/cap-std-sync/src/sched.rs index 8db8aae65..58f3e7010 100644 --- a/wasi-common/cap-std-sync/src/sched.rs +++ b/wasi-common/cap-std-sync/src/sched.rs @@ -36,7 +36,7 @@ pub async fn poll_oneoff<'a>(poll: &mut Poll<'a>) -> Result<(), Error> { ...
2
9
18
e5ee34fada96d965055f45ad69c20c00a030ab19
Dan Gohman
2023-01-18T14:13:43
Allocate bool results at the end of the events buffer.
diff --git a/src/lib.rs b/src/lib.rs index f10a05f42..e3ffcdda3 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -1474,8 +1474,10 @@ pub unsafe extern "C" fn poll_oneoff( ) ); + // Store the future handles at the beginning, and the bool results at the + // end, so that we don't clobber the bool res...
1
3
1
ba9e428b057f4e14c81f0a36e9c6b8c4284c4520
Dan Gohman
2023-01-18T14:13:28
Make `subscribe_monotonic_clock` infallible.
diff --git a/host/src/poll.rs b/host/src/poll.rs index ac07ef1bc..70dad61bc 100644 --- a/host/src/poll.rs +++ b/host/src/poll.rs @@ -57,7 +57,7 @@ impl WasiPoll for WasiCtx { when, absolute, Userdata::from(index as u64), - )?;...
2
2
3
934ba0e4e59300d7458161b8420178a9e232ae0a
Dan Gohman
2023-01-09T18:49:44
Install the wasm targets for nightly.
diff --git a/test-programs/macros/build.rs b/test-programs/macros/build.rs index d050df5de..adc55ce93 100644 --- a/test-programs/macros/build.rs +++ b/test-programs/macros/build.rs @@ -26,10 +26,7 @@ fn main() { let wasi_adapter = fs::read(&wasi_adapter).unwrap(); let mut cmd = Command::new("cargo"); - /...
1
1
4
09692b01a7d68c00927c5a7570007752c3601173
Dan Gohman
2023-01-09T16:00:20
Teach poll_oneoff how to poll for immediately-available I/O When a `ReadPipe` is reading from a memory buffer, there is no host file descriptor to poll with, but there doesn't need to be because the contents are immediately available. Teach the `poll_oneoff` function to use system-interface's `ReadReady` trait, which ...
diff --git a/host/tests/runtime.rs b/host/tests/runtime.rs index be2b8a265..1b0e54cc8 100644 --- a/host/tests/runtime.rs +++ b/host/tests/runtime.rs @@ -199,6 +199,25 @@ async fn run_stdin(mut store: Store<WasiCtx>, wasi: Wasi) -> Result<()> { .map_err(|()| anyhow::anyhow!("command returned with failing exit statu...
6
36
7
9b896d2a708d314e151849dd1243e56b500c9b02
Alex Crichton
2023-01-18T15:04:10
Resolve libcall relocations for older CPUs (#5567) * Resolve libcall relocations for older CPUs Long ago Wasmtime used to have logic for resolving relocations post-compilation for libcalls which I ended up removing during refactorings last year. As #5563 points out, however, it's possible to get Wasmtime to pani...
diff --git a/crates/cranelift/src/obj.rs b/crates/cranelift/src/obj.rs index 757b4705d..a596a1a75 100644 --- a/crates/cranelift/src/obj.rs +++ b/crates/cranelift/src/obj.rs @@ -15,6 +15,8 @@ use crate::{CompiledFunction, RelocationTarget}; use anyhow::Result; +use cranelift_codegen::binemit::Reloc; +use cranelift_c...
7
298
14
94b51cdb179d08dbedd2934a3dc11e2c5aef481a
Saúl Cabrera
2023-01-18T11:58:13
winch: Use cranelift-codegen x64 backend for emission. (#5581) This change substitutes the string based emission mechanism with cranelift-codegen's x64 backend. This change _does not_: * Introduce new functionality in terms of supported instructions. * Change the semantics of the assembler/macroassembler in te...
diff --git a/Cargo.lock b/Cargo.lock index e63f27df4..44a54b450 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3783,6 +3783,7 @@ name = "wasmtime-winch" version = "6.0.0" dependencies = [ "anyhow", + "cranelift-codegen", "object", "target-lexicon", "wasmtime-environ", @@ -3951,7 +3952,9 @@ name = "winch-tools" ...
22
533
383
e34b6d90fdd5c73f17d40a8a1e4d8fe77803ce14
Dan Gohman
2022-12-27T23:56:14
Fix some bugs turned up in the Wasmtime testsuite.
diff --git a/src/lib.rs b/src/lib.rs index 9714469bb..f10a05f42 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -1468,7 +1468,7 @@ pub unsafe extern "C" fn poll_oneoff( assert!(align_of::<WasiFuture>() >= align_of::<u8>()); assert!( unwrap(nsubscriptions.checked_mul(size_of::<Event>())) - > un...
1
92
33
02ae36eae8c2b50f3139b8d3c12fe1250448d19a
Dan Gohman
2023-01-17T19:19:46
Use `Dir::open_ambient_dir` to open directories.
diff --git a/host/tests/runtime.rs b/host/tests/runtime.rs index 1372d91ba..be2b8a265 100644 --- a/host/tests/runtime.rs +++ b/host/tests/runtime.rs @@ -217,10 +217,13 @@ async fn run_file_read(mut store: Store<WasiCtx>, wasi: Wasi) -> Result<()> { std::fs::File::create(dir.path().join("bar.txt"))?.write_all(b"A...
1
11
6
68f8fb3ff74f472178a4f1ef53d459aa60171d68
Dan Gohman
2022-12-28T00:46:30
Fix a test to open a directory handle in a way that works on Windows.
diff --git a/host/tests/runtime.rs b/host/tests/runtime.rs index ce38ad668..1372d91ba 100644 --- a/host/tests/runtime.rs +++ b/host/tests/runtime.rs @@ -1,6 +1,6 @@ use anyhow::Result; use cap_rand::RngCore; -use cap_std::{fs::Dir, time::Duration}; +use cap_std::{ambient_authority, fs::Dir, time::Duration}; use host...
1
5
7
d27d9f077c1392e2232965a54cee4cc478d13fb9
Dan Gohman
2022-12-27T23:56:14
Fix some bugs turned up in the Wasmtime testsuite.
diff --git a/wasi-common/cap-std-sync/src/sched.rs b/wasi-common/cap-std-sync/src/sched.rs index c756d9ea1..015649996 100644 --- a/wasi-common/cap-std-sync/src/sched.rs +++ b/wasi-common/cap-std-sync/src/sched.rs @@ -72,13 +72,11 @@ pub async fn poll_oneoff<'a>(poll: &mut Poll<'a>) -> Result<(), Error> { if !ready...
1
1
3
1cd14743ca6bc75a830639e5668cd728e4d09e2d
Dan Gohman
2022-12-27T18:46:16
Add the ability to `poll` on non-OS-stream objects. Use `num_ready_bytes()` on objects which don't contain pollable handles.
diff --git a/wasi-common/Cargo.toml b/wasi-common/Cargo.toml index a82e1e003..e95506896 100644 --- a/wasi-common/Cargo.toml +++ b/wasi-common/Cargo.toml @@ -27,6 +27,7 @@ cap-rand = { workspace = true } cap-fs-ext = { workspace = true } bitflags = { workspace = true } async-trait = { workspace = true } +system-inter...
7
155
93
1fe86b44494b5773e69294485b6644a239fde1fe
Dan Gohman
2022-12-27T18:09:51
Merge the Windows and Unix `poll_oneoff` implementations. This deletes the old unmaintained Windows `poll_oneoff` implementation and replaces it with one based on `WSAPoll`, which rustix is able to present via a compatible API with Unix `poll`, so it can share the same implementation.
diff --git a/wasi-common/cap-std-sync/src/sched.rs b/wasi-common/cap-std-sync/src/sched.rs index df8622f07..647868527 100644 --- a/wasi-common/cap-std-sync/src/sched.rs +++ b/wasi-common/cap-std-sync/src/sched.rs @@ -1,19 +1,119 @@ -#[cfg(unix)] -pub mod unix; -#[cfg(unix)] -pub use unix::poll_oneoff; - -#[cfg(windows)...
3
111
191
08150fef0c11f82223083d5b6473a43c2e7f29ff
Dan Gohman
2022-12-27T18:03:38
Fix compilation on Windows.
diff --git a/wasi-common/cap-std-sync/Cargo.toml b/wasi-common/cap-std-sync/Cargo.toml index 758992930..e10d35841 100644 --- a/wasi-common/cap-std-sync/Cargo.toml +++ b/wasi-common/cap-std-sync/Cargo.toml @@ -24,13 +24,13 @@ system-interface = { version = "0.25.0", features = ["cap_std_impls"] } tracing = { workspace ...
3
6
5
ac3f305e88771d9bf107031fa1b34a2817cb4578
Dan Gohman
2022-12-24T06:55:13
Update to cap-std 1.0.3.
diff --git a/wasi-common/Cargo.toml b/wasi-common/Cargo.toml index 25982a63f..a82e1e003 100644 --- a/wasi-common/Cargo.toml +++ b/wasi-common/Cargo.toml @@ -32,7 +32,7 @@ async-trait = { workspace = true } rustix = { workspace = true, features = ["fs"] } [target.'cfg(windows)'.dependencies] -io-extras = "0.17.0" +i...
4
74
202
0a10f44c1318e83de272fa93dfb654612ca286cf
Dan Gohman
2022-12-27T17:49:39
Remove the `get_nonblocking` method, which is no longer needed.
diff --git a/wasi-common/cap-std-sync/src/net.rs b/wasi-common/cap-std-sync/src/net.rs index a5b95039c..079979394 100644 --- a/wasi-common/cap-std-sync/src/net.rs +++ b/wasi-common/cap-std-sync/src/net.rs @@ -8,7 +8,6 @@ use io_lifetimes::{AsSocket, BorrowedSocket}; use std::any::Any; use std::convert::TryInto; use ...
3
0
15
7721c2b3a122c2e4e27f4a87c6e52e789b16c52d
Dan Gohman
2022-12-24T06:10:08
Rename AsBorrowedHandleOrSocket to AsHandleOrSocket.
diff --git a/wasi-common/cap-std-sync/src/file.rs b/wasi-common/cap-std-sync/src/file.rs index e7e98355e..74ae373e7 100644 --- a/wasi-common/cap-std-sync/src/file.rs +++ b/wasi-common/cap-std-sync/src/file.rs @@ -205,9 +205,9 @@ impl AsHandle for File { } #[cfg(windows)] -use io_extras::os::windows::{AsBorrowedHand...
4
10
10
8eaa35c2205c308eb5a01e76301f5358691da19e
Dan Gohman
2022-12-24T05:11:48
Add CI tests for Windows and start tidying up Windows support. Replace `AsRawHandleOrSocket` with `AsBorrowedHandleOrSocket`, to make the Windows code work more like the Unix code. And add CI tests for macOS too.
diff --git a/wasi-common/cap-std-sync/src/file.rs b/wasi-common/cap-std-sync/src/file.rs index 42b27a90b..e7e98355e 100644 --- a/wasi-common/cap-std-sync/src/file.rs +++ b/wasi-common/cap-std-sync/src/file.rs @@ -31,8 +31,8 @@ impl WasiFile for File { } #[cfg(windows)] - fn pollable(&self) -> Option<io_e...
6
39
39
3a2ca675702fb6855d75ea32a6d59b9cf85ed626
Jamey Sharp
2023-01-17T22:17:17
Generalize iterator types in compute_use_states (#5586) This is a cleanup to help prepare for #5464. Most of the diff is inlining the closure for `mark_all_uses_as_multiple` which was only called once. That avoids some borrow-checker challenges. The key change is that the former `push_args_on_stack` closure no ...
diff --git a/cranelift/codegen/src/machinst/lower.rs b/cranelift/codegen/src/machinst/lower.rs index 3ef581c0b..790a5208a 100644 --- a/cranelift/codegen/src/machinst/lower.rs +++ b/cranelift/codegen/src/machinst/lower.rs @@ -465,56 +465,25 @@ impl<'func, I: VCodeInst> Lower<'func, I> { // Once, Multiple} is pa...
1
42
45
138a76df5d2b43556705bb2e4a2b26e24beb568d
Alex Crichton
2023-01-17T19:14:06
Fix a debug assert with `wasm_backtrace(false)` (#5580) This commit fixes an issue where when backtraces were disabled but a host function returned an error it would trigger a debug assertion within Wasmtime. The fix here is to update the condition of the debug assertion and add a test doing this behavior to ensure...
diff --git a/crates/wasmtime/src/config.rs b/crates/wasmtime/src/config.rs index dbd5f47a7..b3c32f2bc 100644 --- a/crates/wasmtime/src/config.rs +++ b/crates/wasmtime/src/config.rs @@ -365,8 +365,6 @@ impl Config { /// This option is `true` by default. /// /// [`WasmBacktrace`]: crate::WasmBacktrace - ...
3
28
3
b86cba98a975bfd5823916fa46fde81307db3b38
Daniel Marin
2023-01-17T02:02:23
fixed typo in examples/memory.rs (#5576)
diff --git a/examples/memory.rs b/examples/memory.rs index 93c712cf1..5d57a7321 100644 --- a/examples/memory.rs +++ b/examples/memory.rs @@ -4,7 +4,7 @@ //! read and write memory through the `Memory` object, and how wasm functions //! can trap when dealing with out-of-bounds addresses. -// You can execute this exam...
1
1
1
e4dc9c79443259e40f3e93b9c7815b0645ebd5c4
Ayomide Bamidele
2023-01-13T21:02:36
Update Intel x86 CPU presets to match LLVM (#5490) * Update Intel x86 CPU presets * Add LLVM reference * Remove 32bit CPU architectures * Rename silvermont to slm * Fix haswell presets * Add icelake alias * Group streaming simd presets * Add slm silvermont preset * Remove duplicate alderlake de...
diff --git a/cranelift/codegen/meta/src/cdsl/settings.rs b/cranelift/codegen/meta/src/cdsl/settings.rs index c4eb54e57..358c0879e 100644 --- a/cranelift/codegen/meta/src/cdsl/settings.rs +++ b/cranelift/codegen/meta/src/cdsl/settings.rs @@ -66,7 +66,7 @@ impl Setting { } } -#[derive(Hash, PartialEq, Eq)] +#[der...
2
155
18
f0979af157741e32fb71e5720a5250e85a91d7ed
Saúl Cabrera
2023-01-13T19:46:25
cranelift-codegen: Prepare aarch64 for usage from Winch (#5570) This commit exposes the necessary aarch64 pieces to be used by Winch for binary emission.
diff --git a/cranelift/codegen/src/isa/aarch64/inst/args.rs b/cranelift/codegen/src/isa/aarch64/inst/args.rs index 22a7d17ac..69eb7e525 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/args.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/args.rs @@ -14,12 +14,13 @@ use std::string::String; #[derive(Clone, Copy, Deb...
7
98
18
cbeec5ddb929e1c6e77f19731e4e3cf1bc9817d0
Alex Crichton
2023-01-12T21:49:56
Optimize some functions in the `wiggle` crate (#5566) * wiggle: Inline some trivial functions This commit marks a number of functions in wiggle as `#[inline]` as they're otherwise trivial, mostly returning constants. This comes out of some work I looked at recently with Andrew where some of these functions showe...
diff --git a/crates/wiggle/generate/src/types/flags.rs b/crates/wiggle/generate/src/types/flags.rs index a55d3f002..16ccd1d4c 100644 --- a/crates/wiggle/generate/src/types/flags.rs +++ b/crates/wiggle/generate/src/types/flags.rs @@ -42,6 +42,7 @@ pub(super) fn define_flags( impl TryFrom<#repr> for #ident { ...
7
68
7
d3e6b7bd2a1e847a1280c1591d20a241b4340bfd
Afonso Bordado
2023-01-12T16:46:37
fuzzgen: Enable riscv64 and disable unimplemented ops (#5502)
diff --git a/cranelift/fuzzgen/src/function_generator.rs b/cranelift/fuzzgen/src/function_generator.rs index 3e2af2e91..a31ff0a6c 100644 --- a/cranelift/fuzzgen/src/function_generator.rs +++ b/cranelift/fuzzgen/src/function_generator.rs @@ -502,6 +502,125 @@ fn valid_for_target(triple: &Triple, op: Opcode, args: &[Type...
2
120
1
6a20ca5512f8055845aca9f0fcb30504a151560a
Dan Gohman
2023-01-12T00:24:39
Treat `wasmtime::component::Val::Float{32,64}` zero and negative zero as inequal (#5562) Following up on #5535, treat positive and negative zero as inequal in wasmtime::component::Val::Float{32,64}'s `PartialEq` logic. IEEE 754 equality considers these values equal, but they are semantically distinct values, and te...
diff --git a/crates/wasmtime/src/component/values.rs b/crates/wasmtime/src/component/values.rs index 4816ac956..81f0b70e1 100644 --- a/crates/wasmtime/src/component/values.rs +++ b/crates/wasmtime/src/component/values.rs @@ -1007,10 +1007,22 @@ impl Val { impl PartialEq for Val { fn eq(&self, other: &Self) -> boo...
1
15
3
6cb68f3287b9b2867946cb568eff713e89b21e47
Saúl Cabrera
2023-01-11T23:33:03
cranelift-codegen: Expose x64 settings (#5561) Exposes x64 settings so that they can be consumed from Winch for binary emission.
diff --git a/cranelift/codegen/src/isa/x64/mod.rs b/cranelift/codegen/src/isa/x64/mod.rs index 30483df67..27053ef2d 100644 --- a/cranelift/codegen/src/isa/x64/mod.rs +++ b/cranelift/codegen/src/isa/x64/mod.rs @@ -23,7 +23,7 @@ mod abi; pub mod encoding; mod inst; mod lower; -mod settings; +pub mod settings; /// A...
1
1
1
963d73a83b8297087301a3d7a8653618b60b6aa5
Kyle Brown
2023-01-11T16:42:18
Add component model wasmtime feature to Docs.rs (#5558)
diff --git a/crates/wasmtime/Cargo.toml b/crates/wasmtime/Cargo.toml index 20fc5a79d..ad07fa396 100644 --- a/crates/wasmtime/Cargo.toml +++ b/crates/wasmtime/Cargo.toml @@ -12,6 +12,7 @@ rust-version.workspace = true [package.metadata.docs.rs] rustdoc-args = ["--cfg", "nightlydoc"] +features = ["component-model"] ...
1
1
0
4f0445b9e803dacfce6527e5f380724c91bfd669
Dan Gohman
2023-01-11T01:46:23
Update the documentation for `Caller::get_export`. (#5556) Update the documentation for `Caller::get_export` to clarify that it's not expected to be removed in the future. Components do offer an alternative to `Caller::get_export`, so add a brief note mentioning that. Also, as of #4431 `get_export` now works for...
diff --git a/crates/wasmtime/src/func.rs b/crates/wasmtime/src/func.rs index 43cc546e3..388005fb1 100644 --- a/crates/wasmtime/src/func.rs +++ b/crates/wasmtime/src/func.rs @@ -1726,24 +1726,23 @@ impl<T> Caller<'_, T> { /// Looks up an export from the caller's module by the `name` given. /// - /// Note ...
1
12
13
23ea435a91362126496966e9500c21ca2d38175c
Afonso Bordado
2023-01-09T20:30:57
fuzzgen: Reenable `srem.i8` on x86 (#5545)
diff --git a/cranelift/fuzzgen/src/function_generator.rs b/cranelift/fuzzgen/src/function_generator.rs index 38bacdec3..2888cbca9 100644 --- a/cranelift/fuzzgen/src/function_generator.rs +++ b/cranelift/fuzzgen/src/function_generator.rs @@ -288,8 +288,6 @@ fn valid_for_target(triple: &Triple, op: Opcode, args: &[Type],...
1
0
2
49cd5e4efb628fca8eaf2e27d516f23ab489c857
Dan Gohman
2023-01-09T20:22:56
Implement file append functionality. (#50) * Implement file append functionality. - In the preview1-to-preview2 polyfill, using `append_via_stream`. - In the host implementation, using a new system-interface `FileIoExt::append` function. * Add a basic testcase.
diff --git a/src/lib.rs b/src/lib.rs index 9626de8fd..9714469bb 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -76,6 +76,7 @@ pub unsafe extern "C" fn command( type_: StreamType::File(File { fd: preopen.descriptor, position: Cell::new(0), + appe...
1
18
3
2d61276c1d90c2d0d5015bcd8b02d6cbfb9eb5ad
Dan Gohman
2023-01-09T20:22:56
Implement file append functionality. (#50) * Implement file append functionality. - In the preview1-to-preview2 polyfill, using `append_via_stream`. - In the host implementation, using a new system-interface `FileIoExt::append` function. * Add a basic testcase.
diff --git a/host/tests/runtime.rs b/host/tests/runtime.rs index cbe7badde..ce38ad668 100644 --- a/host/tests/runtime.rs +++ b/host/tests/runtime.rs @@ -236,6 +236,41 @@ async fn run_file_read(mut store: Store<WasiCtx>, wasi: Wasi) -> Result<()> { .map_err(|()| anyhow::anyhow!("command returned with failing exit s...
4
170
79
8ac04612ae5b4bb22a9359da6c595840ba10edb6
Afonso Bordado
2023-01-09T20:19:30
cranelift: Remove predicate not macro branch (#5552)
diff --git a/cranelift/codegen/meta/src/cdsl/mod.rs b/cranelift/codegen/meta/src/cdsl/mod.rs index fa5f62562..565783ad1 100644 --- a/cranelift/codegen/meta/src/cdsl/mod.rs +++ b/cranelift/codegen/meta/src/cdsl/mod.rs @@ -17,15 +17,6 @@ macro_rules! predicate { ($a:ident && $($b:tt)*) => { PredicateNode::A...
1
0
9
f85e3f85170bd2c8378977879f4fdf2c6b64de55
Andrew Brown
2023-01-09T19:28:09
wasi: avoid buffer underflow with shared memory (#5543) * wasi: avoid buffer underflow with shared memory This change fixes an issue identified when using wasi-threads to perform file reads. In order to maintain Rust safety guarantees in the presence of WebAssembly shared memory, which can be modified concurrentl...
diff --git a/crates/wasi-common/src/snapshots/preview_0.rs b/crates/wasi-common/src/snapshots/preview_0.rs index 0295777da..763f685fc 100644 --- a/crates/wasi-common/src/snapshots/preview_0.rs +++ b/crates/wasi-common/src/snapshots/preview_0.rs @@ -533,12 +533,12 @@ impl wasi_unstable::WasiUnstable for WasiCtx { ...
2
81
101
f845ebb450033d13fb7deb06b464f7253bea2a4b
Afonso Bordado
2023-01-09T18:04:45
cranelift: Remove `is_pic` predicate from x86 backend (#5548) This is still present as shared flags and we don't use the predicate anywhere.
diff --git a/cranelift/codegen/meta/src/cdsl/settings.rs b/cranelift/codegen/meta/src/cdsl/settings.rs index 6b4179034..c4eb54e57 100644 --- a/cranelift/codegen/meta/src/cdsl/settings.rs +++ b/cranelift/codegen/meta/src/cdsl/settings.rs @@ -181,7 +181,6 @@ struct ProtoSetting { pub(crate) enum PredicateNode { Own...
2
0
11
a091d614765811076e40683deb5e10ec25f2d638
Joel Dice
2023-01-09T17:14:29
fix a couple of host/src/main.rs issues (#51) 1. It needed a `config.async_support(true)` to actually work at all. 2. Add `inherit_stdin` and `inherit_stdout` calls when building WasiCtx to make stdio useful. 3. Set stdout descriptor to 1. Signed-off-by: Joel Dice <joel.dice@fermyon.com> Signed-off-by: Joel Di...
diff --git a/host/src/main.rs b/host/src/main.rs index 35aa68b32..e1cb69187 100644 --- a/host/src/main.rs +++ b/host/src/main.rs @@ -19,17 +19,24 @@ async fn main() -> Result<()> { let mut config = Config::new(); config.wasm_backtrace_details(wasmtime::WasmBacktraceDetails::Enable); config.wasm_component...
1
9
2
72feade7d9234e6848ee1ca79959f548aa9398f8
Alex Crichton
2023-01-09T17:13:03
Try to detect memory corruption with "magic" canaries (#52) After two separate rounds of memory corruption now happening it's probably best to place some protections in place to try to detect when this happens earlier rather than much later after the fact.
diff --git a/src/lib.rs b/src/lib.rs index 4cf4a8289..9626de8fd 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -35,7 +35,7 @@ pub unsafe extern "C" fn command( args_len: usize, env_vars: StrTupleList, preopens: PreopenList, -) -> Result<(), ()> { +) -> u32 { // TODO: ideally turning off `command` would...
1
21
3
e65a2c928022297ebb31c1b73624da54f04ff21b
Jamey Sharp
2023-01-06T22:00:50
cranelift-isle: Record all binding names (#5538) ...not just the ones at the outer scope of a rule. Thanks to @avanhatt for pointing out that #5221 didn't capture as much information as I intended it to.
diff --git a/cranelift/isle/isle/src/sema.rs b/cranelift/isle/isle/src/sema.rs index cd467c7f8..95481f106 100644 --- a/cranelift/isle/isle/src/sema.rs +++ b/cranelift/isle/isle/src/sema.rs @@ -484,6 +484,9 @@ pub struct BoundVar { pub name: Sym, /// The type of the value this variable is bound to. pub ty...
1
38
5
a491eaca0fecd6f081c448c2ce1d17a88f01404a
Nick Fitzgerald
2023-01-06T21:12:59
Ability to disable cache after it's been configured on `Config` (#5542) * Wasmtime: Add `Config::disable_cache` * bench-api: Always disable the cache * bench-api: Always get a `Config` from CLI flags This commit fixes an issue that I ran into just now where benchmarking one `*.so` with `--engine-flags` was g...
diff --git a/Cargo.lock b/Cargo.lock index 7861f8ecf..e63f27df4 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3405,6 +3405,7 @@ version = "6.0.0" dependencies = [ "anyhow", "cap-std", + "clap 3.2.8", "shuffling-allocator", "target-lexicon", "wasi-cap-std-sync", diff --git a/crates/bench-api/Cargo.toml b/crate...
5
45
62
1efa3d6f8bad059953cb6a8726bf74d2ee7fa3a0
Sam Sartor
2023-01-06T20:53:48
Add `clif-util compile` option to output object file (#5493) * add clif-util compile option to output object file * switch from a box to a borrow * update objectmodule tests to use borrowed isa * put targetisa into an arc
diff --git a/cranelift/codegen/src/isa/aarch64/mod.rs b/cranelift/codegen/src/isa/aarch64/mod.rs index a8a94c23b..b68fda166 100644 --- a/cranelift/codegen/src/isa/aarch64/mod.rs +++ b/cranelift/codegen/src/isa/aarch64/mod.rs @@ -216,7 +216,7 @@ pub fn isa_builder(triple: Triple) -> IsaBuilder { constructor: |t...
15
117
65
44eebc5f463cd841722e59e92c0620797899a119
Dan Gohman
2023-01-06T16:52:53
Minor cleanups (#49) * Use `use` imports consistently. * Rename `flags_from_descriptor_flags` to `descriptor_flags_from_flags`. * Rename `black_box` to `obscure`. * Make some comments be doc comments. * Use a hyphen for compound adjectives. * Delete an unused variable. * Update the name of `change-fi...
diff --git a/host/src/filesystem.rs b/host/src/filesystem.rs index 03364a42f..2e7a7be0f 100644 --- a/host/src/filesystem.rs +++ b/host/src/filesystem.rs @@ -611,7 +611,7 @@ impl wasi_filesystem::WasiFilesystem for WasiCtx { async fn read_via_stream( &mut self, fd: wasi_filesystem::Descriptor, - ...
2
6
6
3a49d68588ea3d5d7b3cf1862842840643a11edc
Dan Gohman
2023-01-06T16:52:53
Minor cleanups (#49) * Use `use` imports consistently. * Rename `flags_from_descriptor_flags` to `descriptor_flags_from_flags`. * Rename `black_box` to `obscure`. * Make some comments be doc comments. * Use a hyphen for compound adjectives. * Delete an unused variable. * Update the name of `change-fi...
diff --git a/src/lib.rs b/src/lib.rs index d6c0a085f..4cf4a8289 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -4,11 +4,13 @@ use crate::bindings::{ wasi_clocks, wasi_default_clocks, wasi_exit, wasi_filesystem, wasi_logging, wasi_poll, wasi_random, wasi_tcp, }; -use core::arch::wasm32::unreachable; +use core::a...
1
38
43
d833bc6fbf7de638441e35b07a518812fa2b5ac2
Dan Gohman
2023-01-06T16:43:56
Add `close` functions for clock handles. (#39) Many users won't need these, because they'll just grab one default clock handle and reuse it for the rest of the program. But it should still be possible to close a clock handle. Also, add a simple test for the clock APIs.
diff --git a/host/src/clocks.rs b/host/src/clocks.rs index 0012d9fe6..528b49162 100644 --- a/host/src/clocks.rs +++ b/host/src/clocks.rs @@ -70,4 +70,15 @@ impl wasi_clocks::WasiClocks for WasiCtx { nanoseconds: res.subsec_nanos(), }) } + + async fn close_monotonic_clock( + &mut sel...
4
44
0
9156cca8ca3feaf48af428d4a38042b9c4e5d9be
Lann
2023-01-06T16:40:19
Treat `wasmtime::component::Val::Float{32,64}` NaNs as equal (#5535) In #5510 we changed the value types of these variants from u{32,64} to f{32,64}. One side effect of this change was that two NaN values would no longer compare equal. While this is behavior complies with IEEE-754 floating point operations, it brok...
diff --git a/crates/wasmtime/src/component/values.rs b/crates/wasmtime/src/component/values.rs index 41c41c124..4816ac956 100644 --- a/crates/wasmtime/src/component/values.rs +++ b/crates/wasmtime/src/component/values.rs @@ -11,7 +11,7 @@ use std::ops::Deref; use wasmtime_component_util::{DiscriminantSize, FlagsSize};...
1
63
8
d5b8da6eeafc3c99d0404ca764349ec691c72062
Nick Fitzgerald
2023-01-05T21:49:37
Wasmtime: Avoid a multiplication overflow when given 64-bit memories whose minimum size is the maximum memory64 size (#5533)
diff --git a/crates/cranelift/src/func_environ.rs b/crates/cranelift/src/func_environ.rs index 1d41644b9..70483111c 100644 --- a/crates/cranelift/src/func_environ.rs +++ b/crates/cranelift/src/func_environ.rs @@ -1381,6 +1381,20 @@ impl<'module_environment> cranelift_wasm::FuncEnvironment for FuncEnvironment<'m fn...
1
15
1
36e5bdfd0ec207bbfb1da79725ac37c7cbc331d0
Trevor Elliott
2023-01-05T18:49:23
Fuzz multiple targets in cranelift-icache (#5482) Fuzz additional targets in the cranelift-icache target. The list of targets fuzzed is controlled by the targets enabled in fuzz/Cargo.toml. This PR also reworks how instruction disabling is done in function generator, moving the deny-list to a function to make the d...
diff --git a/Cargo.lock b/Cargo.lock index 07bfaffb2..7861f8ecf 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -635,6 +635,7 @@ dependencies = [ "arbitrary", "cranelift", "cranelift-native", + "target-lexicon", ] [[package]] diff --git a/cranelift/codegen/src/isa/mod.rs b/cranelift/codegen/src/isa/mod.rs index 6...
8
341
242
b46ad1b54da9910d2dda232b1e8e4c89257ea2ec
Nick Fitzgerald
2023-01-05T01:18:46
Wasmtime: set the `cranelift_wasm::Heap`'s min size (#5522) This unlocks certain bounds checking optimizations in some configurations. Wasn't able to measure any delta in sightglass, but still worth doing anyways.
diff --git a/crates/cranelift/src/func_environ.rs b/crates/cranelift/src/func_environ.rs index f938d7dab..1d41644b9 100644 --- a/crates/cranelift/src/func_environ.rs +++ b/crates/cranelift/src/func_environ.rs @@ -1471,7 +1471,7 @@ impl<'module_environment> cranelift_wasm::FuncEnvironment for FuncEnvironment<'m ...
1
1
1
e2e98f694f9ca03ead4028a94e74479a7d96c3bd
Trevor Elliott
2023-01-04T22:22:35
Remove lower_br_fcmp from the riscv64 backend (#5519) Remove the lower_br_fcmp function from the riscv64 backend. This PR only affects the emit implementation for FloatRound, replacing the uses of lower_br_fcmp with direct uses of FpuRRR and CondBr. Any changes in behavior here should be already covered by the runt...
diff --git a/cranelift/codegen/src/isa/riscv64/inst/emit.rs b/cranelift/codegen/src/isa/riscv64/inst/emit.rs index 5f5dbd66c..36bdc2aa7 100644 --- a/cranelift/codegen/src/isa/riscv64/inst/emit.rs +++ b/cranelift/codegen/src/isa/riscv64/inst/emit.rs @@ -270,163 +270,6 @@ impl Inst { } } - pub(crate) f...
1
25
169
b2fb8b9e9f60639fa76d878f560212358ad24c87
Joel Dice
2023-01-04T21:08:31
update `readdir` etc to use new error handling scheme (#47) Signed-off-by: Joel Dice <joel.dice@fermyon.com> Signed-off-by: Joel Dice <joel.dice@fermyon.com>
diff --git a/host/src/filesystem.rs b/host/src/filesystem.rs index 52bf362d1..03364a42f 100644 --- a/host/src/filesystem.rs +++ b/host/src/filesystem.rs @@ -342,6 +342,7 @@ impl wasi_filesystem::WasiFilesystem for WasiCtx { self.table_mut() .push(Box::new(Mutex::new(iterator))) + .map...
1
3
2
7387d3a2a3995087ba2297e8baba6da3e07c515e
FuXiaoHei
2023-01-04T19:08:06
fix compile failed by wasmtime::component::Error dropped (#46)
diff --git a/host/src/filesystem.rs b/host/src/filesystem.rs index 13b584736..52bf362d1 100644 --- a/host/src/filesystem.rs +++ b/host/src/filesystem.rs @@ -18,12 +18,12 @@ fn contains<T: BitAnd<Output = T> + Eq + Copy>(flags: T, flag: T) -> bool { (flags & flag) == flag } -fn convert(error: wasi_common::Error)...
3
32
31
359a7964f9d1957e8463944fed2c58a46964d403
Joel Dice
2023-01-04T17:27:29
implement `wasi-filesystem::readdir` and related functions (#45) * implement `wasi-filesystem::readdir` and related functions This adds a `directory_list` test and provides the required host implementation. I've also added a file length check to the `file_read` test, just to cover a bit more of the API. Sign...
diff --git a/src/lib.rs b/src/lib.rs index 5ad723e77..d6c0a085f 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -911,8 +911,8 @@ pub unsafe extern "C" fn fd_readdir( state.dirent_cache.cookie.set(cookie - 1); state.dirent_cache.cached_dirent.set(dirent); std::ptr::copy( - ...
1
2
2
3dabe07241deaf4e4b40d87f4ad3575babfe067a
Joel Dice
2023-01-04T17:27:29
implement `wasi-filesystem::readdir` and related functions (#45) * implement `wasi-filesystem::readdir` and related functions This adds a `directory_list` test and provides the required host implementation. I've also added a file length check to the `file_read` test, just to cover a bit more of the API. Sign...
diff --git a/host/src/filesystem.rs b/host/src/filesystem.rs index ae50e6de9..13b584736 100644 --- a/host/src/filesystem.rs +++ b/host/src/filesystem.rs @@ -5,10 +5,11 @@ use crate::{wasi_filesystem, HostResult, WasiCtx}; use std::{ io::{IoSlice, IoSliceMut}, ops::BitAnd, + sync::Mutex, time::SystemT...
7
112
21
7c67378ab6c3348743f313b7aa78cc17f20d1640
Andrew Brown
2023-01-04T16:10:00
wiggle: copy guest strings from shared memory (#5475) * wiggle: copy guest strings from shared memory Along the same lines as #5471, this change adds a new smart pointer, `GuestStrCow`, to copy the string bytes over from Wasm memory to the host when the string is found in shared memory. This is necessary to mai...
diff --git a/crates/wasi-common/src/snapshots/preview_1.rs b/crates/wasi-common/src/snapshots/preview_1.rs index c3cb00352..0eee1df3a 100644 --- a/crates/wasi-common/src/snapshots/preview_1.rs +++ b/crates/wasi-common/src/snapshots/preview_1.rs @@ -663,7 +663,7 @@ impl wasi_snapshot_preview1::WasiSnapshotPreview1 for W...
6
96
54
276bc6ad2e903844c2914d35a3c3c037930aec3b
Nick Fitzgerald
2023-01-03T22:04:18
cranelift-wasm: Better track reachability after translating loads (#5511) We can sometimes statically determine that a given load will unconditionally trap. When this happens, we emit an unconditional trap, and we need to stop adding new instructions to the block. This commit introduces a `Reachability<T>` type tha...
diff --git a/cranelift/wasm/src/code_translator.rs b/cranelift/wasm/src/code_translator.rs index 2250fb3cf..0d86ffa7b 100644 --- a/cranelift/wasm/src/code_translator.rs +++ b/cranelift/wasm/src/code_translator.rs @@ -97,8 +97,8 @@ use std::convert::TryFrom; use std::vec::Vec; use wasmparser::{FuncValidator, MemArg, O...
2
141
67
0029ff95acf4a2582c82ed082d07af8b9f457b8d
Lann
2023-01-03T20:23:38
Use floats for `wasmtime::component::Val::Float*` (#5510) The definitions of `wasmtime::component::Val::Float{32,64}` mirrored `wasmtime::Val::F{32,64}` by using integers as their wrapped types, storing the bit representation of their floating point values. This was necessary for the core Wasm `f32`/`f64` types bec...
diff --git a/crates/fuzzing/src/generators/component_types.rs b/crates/fuzzing/src/generators/component_types.rs index 0c83bf10c..05a008ab3 100644 --- a/crates/fuzzing/src/generators/component_types.rs +++ b/crates/fuzzing/src/generators/component_types.rs @@ -34,8 +34,8 @@ pub fn arbitrary_val(ty: &component::Type, in...
4
33
41
f9118556126b33c551974241792ea01379279767
Andrew Brown
2023-01-03T19:51:34
wiggle: copy guest slices back to shared memory (#5471) This change upgrades `UnsafeGuestSlice` in Wiggle to expose more functionality to be able to use `std::ptr::copy` for writing bytes into Wasm shared memory. Additionally, it adds a new `GuestCow` type for delineating between Wasm memory regions that can be bor...
diff --git a/crates/wasi-common/src/snapshots/preview_0.rs b/crates/wasi-common/src/snapshots/preview_0.rs index a155bad76..0295777da 100644 --- a/crates/wasi-common/src/snapshots/preview_0.rs +++ b/crates/wasi-common/src/snapshots/preview_0.rs @@ -5,6 +5,7 @@ use crate::sched::{ }; use crate::snapshots::preview_1::t...
3
465
157
69b7ecf90ee70d86f7cd739aa263a3d71a6a4351
Lann
2023-01-03T19:01:57
Add `wasmtime::UnknownImportError` (#5509) This adds a new error type `UnknownImportError` which will be returned (wrapped in an `anyhow::Error`) by `Linker::instantiate{,_async,_pre}` if a module has an unresolvable import. This error type is also used by `Linker::define_unknown_imports_as_traps`; any resulting...
diff --git a/crates/wasmtime/src/linker.rs b/crates/wasmtime/src/linker.rs index c1891ff80..3f4782434 100644 --- a/crates/wasmtime/src/linker.rs +++ b/crates/wasmtime/src/linker.rs @@ -5,7 +5,7 @@ use crate::{ AsContextMut, Caller, Engine, Extern, ExternType, Func, FuncType, ImportType, Instance, IntoFunc, Mo...
2
85
25
320d67fe8d039e88c6f32c3ac758c514d76bdd46
KarelPeeters
2023-01-03T17:06:47
Cranelift: include return values in instruction pretty print output. (#5489)
diff --git a/cranelift/codegen/src/isa/aarch64/inst/mod.rs b/cranelift/codegen/src/isa/aarch64/inst/mod.rs index 518de54d2..06c1f26d8 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/mod.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/mod.rs @@ -2657,7 +2657,16 @@ impl Inst { } s ...
4
39
6