commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
78ecc17d0f22a0e0690dd734b28f776fe1fd582f
Pat Hickey
2022-10-18T14:24:14
unsplat component::Linker::func_wrap args (#5065) * component::Linker::func_wrap: replace IntoComponentFunc with directly accepting a closure We find that this makes the Linker::func_wrap type signature much easier to read. The IntoComponentFunc abstraction was adding a lot of weight to "splat" a set of arguments...
diff --git a/crates/fuzzing/src/generators/component_types.rs b/crates/fuzzing/src/generators/component_types.rs index 133b990fc..0c83bf10c 100644 --- a/crates/fuzzing/src/generators/component_types.rs +++ b/crates/fuzzing/src/generators/component_types.rs @@ -158,7 +158,7 @@ macro_rules! define_static_api_test { ...
10
102
171
766ecb561eda7227614768cdfd6d7ff1f560b6b0
Afonso Bordado
2022-10-17T19:51:20
fuzzgen: Always generate reachable blocks (#5034) * fuzzgen: Always reachable blocks * fuzzgen: Rename BlockTerminator * fuzzgen: Rename `finalize_block` * fuzzgen: Use `cloned` instead of map clone Thanks @jameysharp! Co-authored-by: Jamey Sharp <jamey@minilop.net> * fuzzgen: `rustfmt` * fuzzgen:...
diff --git a/cranelift/codegen/src/ir/jumptable.rs b/cranelift/codegen/src/ir/jumptable.rs index 7897dff84..3f2cdb8fb 100644 --- a/cranelift/codegen/src/ir/jumptable.rs +++ b/cranelift/codegen/src/ir/jumptable.rs @@ -33,6 +33,10 @@ impl JumpTableData { table: Vec::with_capacity(capacity), } }...
3
235
245
ff0c45b4a069a84b131c8265d8d14c2f7d0566d7
Alex Crichton
2022-10-13T17:11:34
Minor changes for components related to wit-bindgen support (#5053) * Plumb type exports in components around more This commit adds some more plumbing for type exports to ensure that they show up in the final compiled representation of a component. For now they continued to be ignored for all purposes in the embe...
diff --git a/crates/environ/src/component/dfg.rs b/crates/environ/src/component/dfg.rs index ae986b55a..bd7ee9658 100644 --- a/crates/environ/src/component/dfg.rs +++ b/crates/environ/src/component/dfg.rs @@ -152,6 +152,7 @@ pub enum Export { ModuleStatic(StaticModuleIndex), ModuleImport(RuntimeImportIndex), ...
6
32
15
a2f846f1248505350ab3017a9a5ce487b6d26236
Nick Fitzgerald
2022-10-13T14:22:46
Don't re-capture backtraces when propagating traps through host frames (#5049) * Add a benchmark for traps with many Wasm<-->host calls on the stack * Add a test for expected Wasm stack traces with Wasm<--host calls on the stack when we trap * Don't re-capture backtraces when propagating traps through host frame...
diff --git a/benches/trap.rs b/benches/trap.rs index 00a23759c..933c77e16 100644 --- a/benches/trap.rs +++ b/benches/trap.rs @@ -9,6 +9,7 @@ fn bench_traps(c: &mut Criterion) { bench_multi_threaded_traps(c); bench_many_modules_registered_traps(c); bench_many_stack_frames_traps(c); + bench_host_wasm_fr...
9
221
25
4639e85c4e9a084ff442e2ff7924b5d753e63be5
Afonso Bordado
2022-10-12T18:15:38
Flush Icache on AArch64 Windows (#4997) * cranelift: Add FlushInstructionCache for AArch64 on Windows This was previously done on #3426 for linux. * wasmtime: Add FlushInstructionCache for AArch64 on Windows This was previously done on #3426 for linux. * cranelift: Add MemoryUse flag to JIT Memory Manager ...
diff --git a/Cargo.lock b/Cargo.lock index 48b84a3b1..e63d0c7f2 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -667,6 +667,7 @@ dependencies = [ "memmap2", "region", "target-lexicon", + "wasmtime-jit-icache-coherence", "windows-sys", ] @@ -3665,12 +3666,12 @@ dependencies = [ "log", "object", "rustc-deman...
12
335
88
03d77d4d6b1160a6be07c518d816b083443bc7b4
Nick Fitzgerald
2022-10-12T14:58:27
Cranelift: Derive `Copy` for `InstructionData` (#5043) * Cranelift: Derive `Copy` for `InstructionData` And update `clone` calls to be copies. * Add a test for `InstructionData`'s size
diff --git a/cranelift/codegen/meta/src/gen_inst.rs b/cranelift/codegen/meta/src/gen_inst.rs index 3ff454d46..581297a40 100644 --- a/cranelift/codegen/meta/src/gen_inst.rs +++ b/cranelift/codegen/meta/src/gen_inst.rs @@ -71,17 +71,16 @@ fn gen_formats(formats: &[&InstructionFormat], fmt: &mut Formatter) { /// the SSA ...
5
22
10
1d8f982fe52887db100dbfbfd8d6159117710b4f
Afonso Bordado
2022-10-12T12:52:48
fuzzgen: Add bitops (#5040) * cranelift: Implement some bitops for i128 values * fuzzgen: Add bitops
diff --git a/cranelift/fuzzgen/src/function_generator.rs b/cranelift/fuzzgen/src/function_generator.rs index c99d6a959..8af3784d7 100644 --- a/cranelift/fuzzgen/src/function_generator.rs +++ b/cranelift/fuzzgen/src/function_generator.rs @@ -435,6 +435,108 @@ const OPCODE_SIGNATURES: &'static [( (Opcode::Isplit, &[...
2
106
4
629231e93932cf4ed8de45cd076969936d4be5e8
Dan Gohman
2022-10-10T19:21:50
Remove an unneeded `register_buffer`.
diff --git a/src/lib.rs b/src/lib.rs index 8c8117016..261df1427 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -501,8 +501,6 @@ pub unsafe extern "C" fn fd_write( match Descriptor::get(fd) { Descriptor::File(file) => { - register_buffer(ptr as *mut _, len); - let result = file ...
1
0
2
0e29983b115147fac8e5e1424d9a682fd0a87d1f
Dan Gohman
2022-10-10T19:21:46
Multiply memory.grow's result by the page size, and handle failure.
diff --git a/src/lib.rs b/src/lib.rs index 62da938f7..8c8117016 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -918,15 +918,21 @@ pub struct File { position: u64, } +const PAGE_SIZE: usize = 65536; + impl Descriptor { fn get(fd: Fd) -> &'static mut Descriptor { unsafe { let mut fds = re...
1
8
2
ac64e345b47f0309b91811b4263ce4370cef2dfa
Dan Gohman
2022-10-07T23:30:54
Simplify a few casts.
diff --git a/src/lib.rs b/src/lib.rs index 90ef42fb8..62da938f7 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -362,10 +362,8 @@ pub unsafe extern "C" fn fd_read( register_buffer(ptr, len); - let read_len: u32 = match len.try_into() { - Ok(len) => len, - Err(_) => ...
1
6
18
a30558aa3e4a9c6be27874d861df992c4c8923d7
Dan Gohman
2022-10-07T23:28:18
Add a file descriptor bounds check.
diff --git a/src/lib.rs b/src/lib.rs index 3ee156a08..90ef42fb8 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -14,7 +14,7 @@ wit_bindgen_guest_rust::import!({ }); use core::arch::wasm32::unreachable; -use core::mem::forget; +use core::mem::{forget, size_of}; use core::ptr::{copy_nonoverlapping, null_mut}; use core:...
1
5
1
3cc7342a5fc34806e768bfc13656d6b1cef72d9d
Dan Gohman
2022-10-07T23:13:53
Fixes to avoid static inits.
diff --git a/src/lib.rs b/src/lib.rs index d4cde1296..3ee156a08 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -81,7 +81,12 @@ pub unsafe extern "C" fn cabi_realloc( #[no_mangle] pub unsafe extern "C" fn args_get(argv: *mut *mut u8, argv_buf: *mut u8) -> Errno { // TODO: Use real arguments. - copy_nonoverlapping...
1
15
7
ab9a1ac6bdd2cc528096be9e7c35d9de6d8d4d9a
Dan Gohman
2022-10-07T22:45:15
Implement more functions.
diff --git a/src/lib.rs b/src/lib.rs index 19d8a7ca2..d4cde1296 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -168,14 +168,86 @@ pub unsafe extern "C" fn fd_close(fd: Fd) -> Errno { /// Note: This is similar to `fdatasync` in POSIX. #[no_mangle] pub unsafe extern "C" fn fd_datasync(fd: Fd) -> Errno { - unreachable(...
1
124
5
c0551ad504c6c0d275991dd991899f8d5b6130e2
Dan Gohman
2022-10-07T21:57:40
Implement more stuff.
diff --git a/src/lib.rs b/src/lib.rs index 117dc273d..19d8a7ca2 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -15,7 +15,7 @@ wit_bindgen_guest_rust::import!({ use core::arch::wasm32::unreachable; use core::mem::forget; -use core::ptr::null_mut; +use core::ptr::{copy_nonoverlapping, null_mut}; use core::slice; use w...
1
32
7
cd71cd1cd5d72f55ae3a5df3e3395a430058fcd1
Dan Gohman
2022-10-07T21:57:25
Implement file descriptors.
diff --git a/build.rs b/build.rs index 4cfa12c20..bc39d5c2d 100644 --- a/build.rs +++ b/build.rs @@ -1,13 +1,21 @@ use std::env; use std::path::PathBuf; -const REPLACE_REALLOC_GLOBAL_PTR: &str = "replace_realloc_global_ptr"; -const REPLACE_REALLOC_GLOBAL_LEN: &str = "replace_realloc_global_len"; - fn main() { ...
2
186
83
e2f1ced0b6ce36f25c44f4854f4355a358691f78
Nick Fitzgerald
2022-10-11T19:57:12
Cranelift: Make `Opcode` represented as a `u8` instead of `u16` and remove vestigial conversion impls (#5042) * Cranelift: Make `Opcode` represented as a `u8` instead of `u16` * Cranelift: Remove unused conversion impls for `Opcode` These are vestigial, left over from Peepmatic.
diff --git a/cranelift/codegen/meta/src/gen_inst.rs b/cranelift/codegen/meta/src/gen_inst.rs index 819b553ce..1d2fefc2b 100644 --- a/cranelift/codegen/meta/src/gen_inst.rs +++ b/cranelift/codegen/meta/src/gen_inst.rs @@ -405,7 +405,7 @@ fn gen_opcodes(all_inst: &AllInstructions, fmt: &mut Formatter) { All inst...
2
1
41
86331b9b3793078b87e90f38acb721ee32906e49
Afonso Bordado
2022-10-11T19:29:03
cranelift: Native feature detection for RISC-V (#5044) * cranelift: Native feature detection for RISC-V * cranelift: Typo fix Thanks @cfallin
diff --git a/cranelift/filetests/src/test_run.rs b/cranelift/filetests/src/test_run.rs index 3b03470c0..9af1a9622 100644 --- a/cranelift/filetests/src/test_run.rs +++ b/cranelift/filetests/src/test_run.rs @@ -47,30 +47,6 @@ fn build_host_isa( builder.finish(flags).unwrap() } -fn is_riscv64_compatible( - host...
3
54
27
42d460f3a67ef5fdcf072d30a7751c1bd975272e
Pat Hickey
2022-10-07T23:36:27
wasmtime-component-macro: struct and consts created for flags! must be pub (#5030) * wasmtime-component-macro: struct and consts created for flags! must be pub * addd empty and all constructors to flags
diff --git a/crates/component-macro/src/lib.rs b/crates/component-macro/src/lib.rs index 77b9aa993..0524ef260 100644 --- a/crates/component-macro/src/lib.rs +++ b/crates/component-macro/src/lib.rs @@ -1081,7 +1081,7 @@ fn expand_flags(flags: &Flags) -> Result<TokenStream> { let name = format_ident!("{}", nam...
1
12
3
bec95fa51a187c3827290d4f5d4403638b8d145a
Dan Gohman
2022-10-06T21:38:15
Remove `unregister_buffer`. When `cabi_realloc` uses the buffer pointer, it sets the stored buffer pointer to null, so we don't need a separate `unregister_buffer` call.
diff --git a/src/lib.rs b/src/lib.rs index 972a86187..8c4da415c 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -54,14 +54,6 @@ unsafe fn register_buffer(buf: *mut u8, buf_len: usize) { assert_eq!(old_len, 0); } -/// Unregister `buf` and `buf_len`, which should have been used exactly once. -unsafe fn unregister_buf...
1
0
12
22def1791a3ee25f97ccc97f4782b04ed97b69ad
Dan Gohman
2022-10-05T23:11:49
Minor cleanups.
diff --git a/src/lib.rs b/src/lib.rs index 62ab73be7..972a86187 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -24,10 +24,8 @@ use wasi::*; /// polyfill. const PATH_MAX: usize = 4096; -extern crate alloc; - // We're avoiding static initializers, so replace the standard assert macros -// with simpler implementation. +...
1
1
3
533bd312910c089a2e5683800eb551a327f2b830
Dan Gohman
2022-10-05T21:08:45
Mark `path_readlink_slow` as inline(never).
diff --git a/src/lib.rs b/src/lib.rs index f72650335..62ab73be7 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -460,8 +460,9 @@ pub unsafe extern "C" fn path_readlink( return_value } -// Slow-path for `path_readlink` that allocates a buffer on the stack to -// ensure that it has a big enough buffer. +/// Slow-path...
1
3
2
f27cb005474c00e4c9182a53f3ef72c9961bf35a
Dan Gohman
2022-10-05T20:57:12
Remove the code that disabled the global allocator.
diff --git a/src/lib.rs b/src/lib.rs index b861643f4..f72650335 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -41,19 +41,6 @@ macro_rules! assert_eq { }; } -// We're avoiding static initializers, so don't link in the default allocator. -struct Alloc {} -unsafe impl alloc::alloc::GlobalAlloc for Alloc { - unsaf...
1
0
13
b02371bc1083358b87eec4a5333e9c315cd73ec7
Dan Gohman
2022-10-05T20:56:56
Properly forget returned buffers.
diff --git a/src/lib.rs b/src/lib.rs index a70981655..b861643f4 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -14,6 +14,7 @@ wit_bindgen_guest_rust::import!({ }); use core::arch::wasm32::unreachable; +use core::mem::forget; use core::ptr::null_mut; use core::slice; use wasi::*; @@ -454,16 +455,22 @@ pub unsafe ext...
1
21
8
105914e24588e4b01a580dbc913302589e4c0fd1
Dan Gohman
2022-10-05T20:52:24
These `forget`s aren't needed because they just have references.
diff --git a/src/lib.rs b/src/lib.rs index 9e3b9fa92..a70981655 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -14,7 +14,6 @@ wit_bindgen_guest_rust::import!({ }); use core::arch::wasm32::unreachable; -use core::mem::forget; use core::ptr::null_mut; use core::slice; use wasi::*; @@ -461,7 +460,6 @@ pub unsafe exter...
1
0
3
7823878a41381b33d7e5fbd77e79e94fded1ab3a
Dan Gohman
2022-10-05T20:40:17
Add a slow-path to handle smaller buffers passed to `path_readlink`.
diff --git a/src/lib.rs b/src/lib.rs index bd7f44a1a..9e3b9fa92 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -19,6 +19,11 @@ use core::ptr::null_mut; use core::slice; use wasi::*; +/// The maximum path length. WASI doesn't explicitly guarantee this, but all +/// popular OS's have a `PATH_MAX` of at most 4096, so tha...
1
47
0
394847a9dda9622932c053884b520d998041644c
Dan Gohman
2022-10-05T20:18:22
Use a compiler_fence.
diff --git a/src/lib.rs b/src/lib.rs index c5fcb1fff..bd7f44a1a 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -658,7 +658,7 @@ fn errno_from_wasi_filesystem(err: wasi_filesystem::Errno) -> Errno { // A black box to prevent the optimizer from generating a lookup table // from the match above, which would require a sta...
1
2
2
541eba9b3b829d8311ba93cb160b21e33a729a46
Dan Gohman
2022-10-05T00:49:41
Use raw_strings, disable integer overflow checks, and suppress jump tables. This also updates the verifier to accept the new wasi imports.
diff --git a/src/lib.rs b/src/lib.rs index bda7bfa26..c5fcb1fff 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -1,18 +1,55 @@ #![allow(unused_variables)] // TODO: remove this when more things are implemented -wit_bindgen_guest_rust::import!("wit/wasi-clocks.wit.md"); -wit_bindgen_guest_rust::import!("wit/wasi-default-c...
1
54
12
2b14421dc7c197ec30c45d7b48e74c6a5d737d12
Dan Gohman
2022-10-05T16:06:53
Implement a polyfill for `path_readlink`. Implement a polyfill for `path_readlink` in terms of the preview2 `readlink_at` function. This involves adding a second wasm global, to hold the buffer size.
diff --git a/build.rs b/build.rs index 1fc8cabe4..4cfa12c20 100644 --- a/build.rs +++ b/build.rs @@ -1,7 +1,8 @@ use std::env; use std::path::PathBuf; -const SYMBOL: &str = "replace_realloc_global"; +const REPLACE_REALLOC_GLOBAL_PTR: &str = "replace_realloc_global_ptr"; +const REPLACE_REALLOC_GLOBAL_LEN: &str = "re...
2
207
34
e45577e097b064797def3554468cffa5fdd443d3
Adam C. Foltzer
2022-10-07T03:20:17
feat(wasi) add `push_file` and `push_dir` methods to `WasiCtx` (#5027) These are useful when we don't want to collide with an existing file descriptor.
diff --git a/crates/wasi-common/src/ctx.rs b/crates/wasi-common/src/ctx.rs index f99a9f7ed..b4b3a5532 100644 --- a/crates/wasi-common/src/ctx.rs +++ b/crates/wasi-common/src/ctx.rs @@ -43,6 +43,10 @@ impl WasiCtx { .insert_at(fd, Box::new(FileEntry::new(caps, file))); } + pub fn push_file(&mut se...
1
15
0
b454110ac7fa027150e020cb2db1bb363a90061b
Jimmy Bourassa
2022-10-05T23:01:05
Fix broken WASI ABI link (#5024) The file has been moved.
diff --git a/crates/wasmtime/src/linker.rs b/crates/wasmtime/src/linker.rs index fd5230d1f..2c269c1d2 100644 --- a/crates/wasmtime/src/linker.rs +++ b/crates/wasmtime/src/linker.rs @@ -572,7 +572,7 @@ impl<T> Linker<T> { /// Ordinary modules which don't declare themselves to be either Commands /// or Reactors...
1
1
1
04b30acad984ffacafcbfa9ad3be2eba1409092a
Jamey Sharp
2022-10-05T17:35:59
Misc cleanups (#5014) * Replace resize+copy_from_slice with extend_from_slice Vec::resize initializes the new space, which is wasted effort if we're just going to call `copy_from_slice` on it immediately afterward. Using `extend_from_slice` is simpler, and very slightly faster. If the new size were bigger than...
diff --git a/cranelift/codegen/src/context.rs b/cranelift/codegen/src/context.rs index 1003e5733..b136d220d 100644 --- a/cranelift/codegen/src/context.rs +++ b/cranelift/codegen/src/context.rs @@ -119,10 +119,7 @@ impl Context { mem: &mut Vec<u8>, ) -> CompileResult<&CompiledCode> { let compiled_...
11
86
93
bbdafaf5cef54b2ad2ad4ecc3b4cb97d74de0c34
Nathaniel McCallum
2022-10-05T15:58:24
feat: provide default methods for WasiDir (#5019) When implementing custom WasiDir instances, there is a lot of boilerplate. These default methods should reduce code for implementors who want to provide only a subset of functionality. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com> Signed-off-by: Na...
diff --git a/crates/wasi-common/src/dir.rs b/crates/wasi-common/src/dir.rs index 18818763f..56a8849db 100644 --- a/crates/wasi-common/src/dir.rs +++ b/crates/wasi-common/src/dir.rs @@ -7,48 +7,94 @@ use std::path::PathBuf; #[wiggle::async_trait] pub trait WasiDir: Send + Sync { fn as_any(&self) -> &dyn Any; + ...
1
77
31
3a9d47613819687b0df03eae998d152fc5f84935
Dan Gohman
2022-10-05T15:08:37
Fix the inline asm comment to match the code.
diff --git a/build.rs b/build.rs index 4368e1fa8..1fc8cabe4 100644 --- a/build.rs +++ b/build.rs @@ -34,7 +34,6 @@ fn main() { /// std::arch::asm!( /// " /// global.get internal_realloc_global -/// local.set {} /// local.get {} /// ...
1
0
1
1b3377011e3085be05323b0756614de790050b89
Dan Gohman
2022-10-05T13:51:15
Mark the WASI functions `unsafe`.
diff --git a/src/lib.rs b/src/lib.rs index 3d745b4e5..84c658f74 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -35,26 +35,29 @@ pub unsafe extern "C" fn cabi_realloc( /// Read command-line argument data. /// The size of the array should match that returned by `args_sizes_get` #[no_mangle] -pub extern "C" fn args_get(ar...
1
66
46
7ad3b586b3e52d81a09e6e2fe50cf0e38bb32333
Dan Gohman
2022-10-05T14:19:31
Use `*mut u8` instead of `usize` to hold pointers. This will reduce casting, and better preserve pointer provenance.
diff --git a/build.rs b/build.rs index 6fcea1bbe..4368e1fa8 100644 --- a/build.rs +++ b/build.rs @@ -28,9 +28,9 @@ fn main() { /// ); /// /// #[no_mangle] -/// extern "C" fn replace_realloc_global(val: usize) -> usize { +/// extern "C" fn replace_realloc_global(val: *mut u8) -> *mut u8 { /// unsafe { -/// ...
2
6
5
3c9e371737933876d3fa19a9f6e852ce1ea4bce1
Dan Gohman
2022-10-05T14:19:29
Add an `extern "C"` to the Rust code comment.
diff --git a/build.rs b/build.rs index 0c12e7f94..6fcea1bbe 100644 --- a/build.rs +++ b/build.rs @@ -28,7 +28,7 @@ fn main() { /// ); /// /// #[no_mangle] -/// fn replace_realloc_global(val: usize) -> usize { +/// extern "C" fn replace_realloc_global(val: usize) -> usize { /// unsafe { /// let ret: usi...
1
1
1
77cfc4d6ec39f00cbbf44c5aa2b6f68578b0efe2
Dan Gohman
2022-10-05T14:19:24
Add a comment about a disabled lint.
diff --git a/src/lib.rs b/src/lib.rs index 4771fa09e..770dfa1cb 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -1,4 +1,4 @@ -#![allow(unused_variables)] +#![allow(unused_variables)] // TODO: remove this when more things are implemented wit_bindgen_guest_rust::import!("wit/wasi-clocks.wit.md"); wit_bindgen_guest_rust::...
1
1
1
24da5f7787cfb733d45a359269b4a75af99c590f
Dan Gohman
2022-10-05T14:29:49
Tidy up the WASI `ErrorKind` enum. (#5015) * Tidy up the WASI `ErrorKind` enum. `ErrorKind` is an internal enum used in wasi-libc to represent WASI errors that aren't precisely represened by `std::io::ErrorKind` errors. Add a descriptive comment, and remove some codes that are no longer needed: - Remove `Not...
diff --git a/crates/wasi-common/src/error.rs b/crates/wasi-common/src/error.rs index b5731643f..eed892ed0 100644 --- a/crates/wasi-common/src/error.rs +++ b/crates/wasi-common/src/error.rs @@ -26,32 +26,27 @@ pub use anyhow::{Context, Error}; /// Internal error type for the `wasi-common` crate. -/// Contains varian...
2
13
26
6d1bce9c64ef1bd14c21af32c616a77604c45b85
Rainy Sinclair
2022-10-05T14:25:31
Adjust fuel consumption to be empty when fuel is 0 (#5013) Co-authored-by: Jamey Sharp <jsharp@fastly.com> Co-authored-by: Jamey Sharp <jsharp@fastly.com>
diff --git a/crates/fuzzing/src/oracles.rs b/crates/fuzzing/src/oracles.rs index a49d086a2..21e35723f 100644 --- a/crates/fuzzing/src/oracles.rs +++ b/crates/fuzzing/src/oracles.rs @@ -787,7 +787,8 @@ impl Drop for SignalOnDrop { } } -fn set_fuel<T>(store: &mut Store<T>, fuel: u64) { +/// Set the amount of fuel...
3
7
7
9f317d0d431acf872ada52f9fdb07f6d93f70f7a
Alex Crichton
2022-10-05T12:54:30
Add test on CI and infrastructure for wasm globals (#1) * Updates * Add a verification test to CI * Produce a global-referencing object on stable * Restrict CI again
diff --git a/build.rs b/build.rs new file mode 100644 index 000000000..0c12e7f94 --- /dev/null +++ b/build.rs @@ -0,0 +1,235 @@ +use std::env; +use std::path::PathBuf; + +const SYMBOL: &str = "replace_realloc_global"; + +fn main() { + let out_dir = PathBuf::from(env::var("OUT_DIR").unwrap()); + let wasm = build_r...
2
302
45
e63771f2d921cdce440620dbf38bd3e186747b1e
Trevor Elliott
2022-10-04T22:59:30
More consistent use of `add_inst` (#5012) Use the InstId returned by add_inst rather than creating it eagerly, when possible.
diff --git a/cranelift/isle/isle/src/ir.rs b/cranelift/isle/isle/src/ir.rs index 4eb23f044..ae89b8955 100644 --- a/cranelift/isle/isle/src/ir.rs +++ b/cranelift/isle/isle/src/ir.rs @@ -262,8 +262,7 @@ impl PatternSequence { } fn add_arg(&mut self, index: usize, ty: TypeId) -> Value { - let inst = Ins...
1
5
10
d986b3cbc200c8dae8d16d98f9df44de5f0fb355
Nathaniel McCallum
2022-10-04T21:00:42
feat: improve wasi_common::ErrorKind derives (#5006) Besides the standard traits (Copy, Clone, PartialEq and Eq), we also mark the trait as non-exhaustive so that we can add errors in the future without breaking API. Signed-off-by: Nathaniel McCallum <nathaniel@profian.com> Signed-off-by: Nathaniel McCallum <n...
diff --git a/crates/wasi-common/src/error.rs b/crates/wasi-common/src/error.rs index 0d50ab213..b5731643f 100644 --- a/crates/wasi-common/src/error.rs +++ b/crates/wasi-common/src/error.rs @@ -28,7 +28,8 @@ pub use anyhow::{Context, Error}; /// Internal error type for the `wasi-common` crate. /// Contains variants of...
1
2
1
d35c5084364b12998031339cf426eb3ca9df0a29
Jamey Sharp
2022-10-03T21:29:12
cranelift-frontend: Replace Vecs with ListPools (#5001) * Elide redundant sentinel values The `undef_variables` lists were a binding from Variable to Value, but the Values were always equal to a suffix of the block's parameters. So instead of storing another copy, we can just get them back from the block paramet...
diff --git a/cranelift/entity/src/list.rs b/cranelift/entity/src/list.rs index 4efed334f..3434380ac 100644 --- a/cranelift/entity/src/list.rs +++ b/cranelift/entity/src/list.rs @@ -104,6 +104,12 @@ impl<T: core::hash::Hash + EntityRef + ReservedValue> core::hash::Hash for ListP } } +impl<T: EntityRef + Reserved...
5
171
171
c3c806d1426982ba0570b7e72efcfa8be4be3e43
Dan Gohman
2022-10-03T20:34:43
An initial preview1 polyfill stub.
diff --git a/src/lib.rs b/src/lib.rs new file mode 100644 index 000000000..6abd502cc --- /dev/null +++ b/src/lib.rs @@ -0,0 +1,460 @@ +#![allow(unused_variables)] + +wit_bindgen_guest_rust::import!("wit/wasi-clocks.wit.md"); +wit_bindgen_guest_rust::import!("wit/wasi-default-clocks.wit.md"); +wit_bindgen_guest_rust::im...
1
460
0
f1fce6c60dd4eef9b009e62fcf7e599ebb973f65
bjorn3
2022-10-03T17:27:07
Support writing riscv64 object files (#4995)
diff --git a/cranelift/object/src/backend.rs b/cranelift/object/src/backend.rs index 3ab22d67d..f40a75822 100644 --- a/cranelift/object/src/backend.rs +++ b/cranelift/object/src/backend.rs @@ -29,6 +29,7 @@ pub struct ObjectBuilder { isa: Box<dyn TargetIsa>, binary_format: object::BinaryFormat, architect...
1
31
1
7bab5c1b283f718dd93ac4f7765035e75d53f905
Alex Crichton
2022-10-03T16:04:07
Consolidate module definition in `wasmtime-jit` (#5000) Minor thing I noticed from #4990 but I stylistically prefer to keep the `mod foo;` definitions canonicalized to one location to emphasize how multiple targets can use the same definition.
diff --git a/crates/jit/src/unwind.rs b/crates/jit/src/unwind.rs index 3de307420..feb37c50f 100644 --- a/crates/jit/src/unwind.rs +++ b/crates/jit/src/unwind.rs @@ -1,13 +1,10 @@ cfg_if::cfg_if! { - if #[cfg(all(windows, target_arch = "x86_64"))] { + if #[cfg(all(windows, any(target_arch = "x86_64", target_arch ...
1
1
4
3fa545bd89d6e18e6e85eab57499ee9c9f5032f2
Jamey Sharp
2022-09-30T21:11:19
Cleanup cranelift-frontend (#4989) * cranelift-wasm: Assume block is reachable In handling the WebAssembly "end" operator, cranelift-wasm had logic to skip generating a jump instruction if the block was both unreachable and "pristine", meaning no instructions had been added. However, `translate_operator` check...
diff --git a/cranelift/frontend/src/frontend.rs b/cranelift/frontend/src/frontend.rs index 8c84b7a00..8cde7cbe0 100644 --- a/cranelift/frontend/src/frontend.rs +++ b/cranelift/frontend/src/frontend.rs @@ -24,7 +24,7 @@ use cranelift_codegen::packed_option::PackedOption; #[derive(Default)] pub struct FunctionBuilderCo...
2
71
69
77ab99d3b030fcb331ff26198bcbc03aabed9f28
Jamey Sharp
2022-09-29T23:59:47
cranelift-frontend: SSA-building cleanup (#4984) * Cleanups to cranelift-frontend SSA construction * Encode sealed/undef_variables relationship in type A block can't have any undef_variables if it is sealed. It's useful to make that fact explicit in the types so that any time either value is used, it's clear t...
diff --git a/cranelift/entity/src/set.rs b/cranelift/entity/src/set.rs index ac8b156be..4b64d79f4 100644 --- a/cranelift/entity/src/set.rs +++ b/cranelift/entity/src/set.rs @@ -19,6 +19,16 @@ where unused: PhantomData<K>, } +impl<K: EntityRef> Default for EntitySet<K> { + fn default() -> Self { + Self...
3
151
232
bf2fa40e4efe5fa48b861f365f9adf6e9bfc1838
Trevor Elliott
2022-09-29T00:23:54
Stabilize the error output order (#4976)
diff --git a/cranelift/isle/isle/src/overlap.rs b/cranelift/isle/isle/src/overlap.rs index 96f324f16..1c8542c53 100644 --- a/cranelift/isle/isle/src/overlap.rs +++ b/cranelift/isle/isle/src/overlap.rs @@ -65,7 +65,11 @@ impl Errors { (src, span) }; - while let Some((&id, _)) = self.nodes....
1
5
1
6c8620b68802cc4094c40569a7c6a229b78b31e8
Jamey Sharp
2022-09-29T00:05:08
Bypass state machine for single-predecessor chains (#4955) In the common case where there is a chain of sealed blocks that each have exactly one predecessor, we can keep track of any sub-sequence of those blocks in O(1) space. So there's no need to use the state machine stack to propagate variable definitions back ...
diff --git a/cranelift/frontend/src/ssa.rs b/cranelift/frontend/src/ssa.rs index 6c05f3f00..7cace36df 100644 --- a/cranelift/frontend/src/ssa.rs +++ b/cranelift/frontend/src/ssa.rs @@ -12,7 +12,7 @@ use alloc::vec::Vec; use core::convert::TryInto; use core::mem; use cranelift_codegen::cursor::{Cursor, FuncCursor}; -...
1
97
172
2e954668c713c51aa8ac9c0865561f6b6e4331e6
Trevor Elliott
2022-09-28T20:23:31
Sort overlap errors by position (#4975)
diff --git a/cranelift/isle/isle/src/overlap.rs b/cranelift/isle/isle/src/overlap.rs index fb826f68f..96f324f16 100644 --- a/cranelift/isle/isle/src/overlap.rs +++ b/cranelift/isle/isle/src/overlap.rs @@ -5,12 +5,17 @@ use std::collections::hash_map::Entry; use std::collections::{HashMap, HashSet}; use crate::error...
1
5
0
83bb6fd4c81ad49d3217584337824e69702f909e
Ulrich Weigand
2022-09-28T15:25:23
s390x: Fix regalloc checker error (#4973) For ShiftRR and VecShiftRR, if shift_reg is zero_reg(), the instruction does not actually use any register value. Fixes #4969
diff --git a/cranelift/codegen/src/isa/s390x/inst/mod.rs b/cranelift/codegen/src/isa/s390x/inst/mod.rs index 68cc20af9..a28c8913e 100644 --- a/cranelift/codegen/src/isa/s390x/inst/mod.rs +++ b/cranelift/codegen/src/isa/s390x/inst/mod.rs @@ -539,7 +539,9 @@ fn s390x_get_operands<F: Fn(VReg) -> VReg>(inst: &Inst, collect...
1
6
2
9715d91c509df2ae9537693c93c6c349f231e056
Jamey Sharp
2022-09-27T20:59:37
Resolve aliases before checking for unique values (#4966) At control-flow join points, cranelift-frontend's SSA builder currently checks to see if only one definition of a variable reaches the current block. If so, it can eliminate the corresponding block parameter and use the original def directly. It implements t...
diff --git a/cranelift/frontend/src/ssa.rs b/cranelift/frontend/src/ssa.rs index b72637855..6c05f3f00 100644 --- a/cranelift/frontend/src/ssa.rs +++ b/cranelift/frontend/src/ssa.rs @@ -600,9 +600,20 @@ impl SSABuilder { ) { let mut pred_values: ZeroOneOrMore<Value> = ZeroOneOrMore::Zero; - // Det...
1
15
14
10deb9b7fe19c845e5ea0f6ba154037380dc5567
Afonso Bordado
2022-09-27T16:52:58
fuzzgen: Add `fcvt_*` ops (#4958)
diff --git a/cranelift/fuzzgen/src/config.rs b/cranelift/fuzzgen/src/config.rs index 7ac7412ed..1213a89db 100644 --- a/cranelift/fuzzgen/src/config.rs +++ b/cranelift/fuzzgen/src/config.rs @@ -47,6 +47,13 @@ pub struct Config { /// that avoids these issues. However we can allow some `int_divz` traps /// by co...
6
232
2
65a3af72c7cc2ec6403d15e98a1a883db8675247
Afonso Bordado
2022-09-27T16:04:57
fuzzgen: Statistics framework (#4868) * cranelift: Add non user trap codes function * cranelift: Add Fuzzgen stats * cranelift: Use `once_cell` and cleanup some stuff * fuzzgen: Remove total_inputs metric * fuzzgen: Filter empty trap codes
diff --git a/Cargo.lock b/Cargo.lock index 7dc3628f4..8ae585749 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3591,6 +3591,7 @@ dependencies = [ "cranelift-reader", "cranelift-wasm", "libfuzzer-sys", + "once_cell", "proc-macro2", "quote", "rand 0.8.5", diff --git a/cranelift/codegen/src/ir/trapcode.rs b/cran...
5
125
20
ee2ef5bdd02ac75eff284e84dc9a8dcdf3d6e2c6
Alex Crichton
2022-09-27T00:27:35
Tidy up some more deps with workspace dependencies (#4965) I missed these in #4905 and noticed just now but wanted to handle them to ensure we uniformly handle deps in the workspace.
diff --git a/cranelift/bforest/Cargo.toml b/cranelift/bforest/Cargo.toml index b989ccec1..a29f78097 100644 --- a/cranelift/bforest/Cargo.toml +++ b/cranelift/bforest/Cargo.toml @@ -12,7 +12,7 @@ keywords = ["btree", "forest", "set", "map"] edition.workspace = true [dependencies] -cranelift-entity = { path = "../ent...
5
9
9
84994203a165e4e869ccdd4b7917b26ce88488bc
Alex Crichton
2022-09-26T22:48:26
Increase the `sigaltstack` stack size (#4964) This commit updates the `MIN_STACK_SIZE` constant for Unix platforms when allocating a sigaltstack from 16k to 64k. The signal handler captures a wasm `Backtrace` which involves memory allocations and it was recently discovered that, at least in debug mode, jemalloc can...
diff --git a/crates/runtime/src/traphandlers/unix.rs b/crates/runtime/src/traphandlers/unix.rs index ef40b8c2c..445646e6a 100644 --- a/crates/runtime/src/traphandlers/unix.rs +++ b/crates/runtime/src/traphandlers/unix.rs @@ -286,7 +286,14 @@ pub fn lazy_per_thread_init() { /// The size of the sigaltstack (not in...
1
8
1
f12ef84cdc88aa6be44117e4dc26886dccc8b91f
Alex Crichton
2022-09-26T22:41:47
Remove `handling_trap` variable (#4963) This historically was used to guard against recursive faults but later refactorings have made this variable somewhat obsolete. The code that it still protects is not the "meat" of trap handling. Instead the `jmp_buf_if_trap` is changed to be more like "take" so once a "take" ...
diff --git a/crates/runtime/src/traphandlers.rs b/crates/runtime/src/traphandlers.rs index a08a0507f..3a24db44a 100644 --- a/crates/runtime/src/traphandlers.rs +++ b/crates/runtime/src/traphandlers.rs @@ -216,7 +216,6 @@ mod call_thread_state { pub struct CallThreadState { pub(super) unwind: UnsafeCell<Ma...
3
4
16
11e90049d2d465d062acfb53926db7ee94f19e55
Jamey Sharp
2022-09-26T03:39:26
Fix wasmtime-bench-api build (#4956) This fixes a compile-time error introduced in #4207. The `?` operator doesn't work inside `Option::map` because it tries to return from the inner closure, not the outer function. Apparently our CI doesn't build wasmtime-bench-api so it didn't catch this issue.
diff --git a/crates/bench-api/src/lib.rs b/crates/bench-api/src/lib.rs index 82a53dda2..a946fdb6b 100644 --- a/crates/bench-api/src/lib.rs +++ b/crates/bench-api/src/lib.rs @@ -430,9 +430,11 @@ impl BenchState { execution_end: extern "C" fn(*mut u8), make_wasi_cx: impl FnMut() -> Result<WasiCtx> + 'st...
1
5
3
bd870a9d6c8382e83672cb9b8a294a819757cfb8
Jamey Sharp
2022-09-23T23:32:13
Shrink all SmallVecs by 8 bytes (#4951) We weren't using the "union" cargo feature for the smallvec crate, which reduces the size of a SmallVec by one machine word. This feature requires Rust 1.49 but we already require much newer versions. When using Wasmtime to compile pulldown-cmark from Sightglass, this save...
diff --git a/cranelift/codegen/Cargo.toml b/cranelift/codegen/Cargo.toml index c5f58f908..dfb127767 100644 --- a/cranelift/codegen/Cargo.toml +++ b/cranelift/codegen/Cargo.toml @@ -24,7 +24,7 @@ log = { version = "0.4.6", default-features = false } serde = { version = "1.0.94", features = ["derive"], optional = true }...
7
7
7
95c74ef246ec1e5521ce6d86e187de7d3a5dc004
Roman Volosatovs
2022-09-23T22:10:00
feat: rely on `tracing-subscriber` in tests (#4950) `tracing` crate is already used within the codebase, this change allows developers to benefit from that functionality when running and debugging tests Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net> Signed-off-by: Roman Volosatovs <rvolosatovs@riseup...
diff --git a/Cargo.lock b/Cargo.lock index 64d110175..349e88b5b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2846,10 +2846,10 @@ dependencies = [ "cap-std", "cfg-if", "os_pipe", - "pretty_env_logger", "target-lexicon", "tempfile", "tokio", + "tracing-subscriber", "wasi-cap-std-sync", "wasi-common", "w...
3
3
5
5a288c2c4029084ab4f44e60481dee1d10d625d2
Andrew Brown
2022-09-23T18:35:59
bench-api: configure WASI modules based on passed flags (#4207) * bench-api: configure WASI modules based on passed flags When benchmarking in Sightglass, @brianjjones has found it necessary to enable the wasi-nn module. The current way to do so is to alter the engine build script to pass `--features wasi-nn` so ...
diff --git a/crates/bench-api/Cargo.toml b/crates/bench-api/Cargo.toml index ac2e858b5..0139c9055 100644 --- a/crates/bench-api/Cargo.toml +++ b/crates/bench-api/Cargo.toml @@ -31,6 +31,6 @@ cap-std = "0.26.0" wat = "1.0.45" [features] -default = ["shuffling-allocator"] +default = ["shuffling-allocator", "wasi-nn"]...
2
25
13
bb6a8a717ab9dcf0594a577893fb31a6528ada1b
Afonso Bordado
2022-09-23T17:19:42
fuzzgen: Avoid `int_divz` traps (#4932) * fuzzgen: Insert `int_divz` sequence * fuzzgen: matches!
diff --git a/cranelift/fuzzgen/src/config.rs b/cranelift/fuzzgen/src/config.rs index 1cf204b77..7ac7412ed 100644 --- a/cranelift/fuzzgen/src/config.rs +++ b/cranelift/fuzzgen/src/config.rs @@ -39,6 +39,14 @@ pub struct Config { /// Determines how often we generate a backwards branch /// Backwards branches are...
3
96
3
6e76e925f47238ffd4a486ab9e0659e998d8f4bb
Jamey Sharp
2022-09-23T16:41:22
Avoid quadratic behavior in `can_optimize_var_lookup` (#4939) * cranelift-frontend: Avoid quadratic behavior Fixes #4923. * Improve comments and debug assertions * Improve comments One thing that's especially neat about this PR is that, unlike the `can_optimize_var_lookup` graph traversal, `update_predece...
diff --git a/cranelift/frontend/src/ssa.rs b/cranelift/frontend/src/ssa.rs index 086a44cc2..b72637855 100644 --- a/cranelift/frontend/src/ssa.rs +++ b/cranelift/frontend/src/ssa.rs @@ -21,7 +21,6 @@ use cranelift_codegen::ir::{ }; use cranelift_codegen::packed_option::PackedOption; use smallvec::SmallVec; -use std::...
1
120
57
be690a468d1aee92f8ec072d97decc45278b1529
Tobias Bradtke
2022-09-23T00:19:56
Fix typo (#4946)
diff --git a/examples/wasi/main.rs b/examples/wasi/main.rs index 9e34630b4..8ffd98d78 100644 --- a/examples/wasi/main.rs +++ b/examples/wasi/main.rs @@ -1,5 +1,4 @@ -//! Example of instantiating of instantiating a wasm module which uses WASI -//! imports. +//! Example of instantiating a wasm module which uses WASI impo...
1
1
2
b167172715c54334237ba5ff13cc50608bc9bcc2
Trevor Elliott
2022-09-21T21:07:59
Add an overlap checker to ISLE (#4906) https://github.com/bytecodealliance/wasmtime/pull/4906 Co-authored-by: Jamey Sharp <jsharp@fastly.com>
diff --git a/Cargo.lock b/Cargo.lock index ba59d0586..597d04903 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -628,6 +628,7 @@ version = "0.89.0" dependencies = [ "log", "miette", + "rayon", "tempfile", ] diff --git a/cranelift/isle/isle/Cargo.toml b/cranelift/isle/isle/Cargo.toml index 09cff1d75..6052fb567 100...
6
380
0
b2d13ebd464c1d36914c41194053770df86c3730
Nick Fitzgerald
2022-09-21T17:30:18
Revert "Memoize `can_optimize_var_lookup` (#4924)" (#4937) This reverts commit 562bb25360a2f366a482e15fc148bab7267a9266.
diff --git a/cranelift/frontend/src/ssa.rs b/cranelift/frontend/src/ssa.rs index 50c3ea5fb..086a44cc2 100644 --- a/cranelift/frontend/src/ssa.rs +++ b/cranelift/frontend/src/ssa.rs @@ -21,6 +21,7 @@ use cranelift_codegen::ir::{ }; use cranelift_codegen::packed_option::PackedOption; use smallvec::SmallVec; +use std::...
1
3
23
562bb25360a2f366a482e15fc148bab7267a9266
Adam Bratschi-Kaye
2022-09-19T17:18:11
Memoize `can_optimize_var_lookup` (#4924) * Memoize `can_optimize_var_lookup` `can_optimize_var_lookup` can have quadratic behavior if there is a chain of blocks each containing a `local.get` instruction because each run can walk up the entire chain. This change memoizes the results of `can_optimize_var_lookup` ...
diff --git a/cranelift/frontend/src/ssa.rs b/cranelift/frontend/src/ssa.rs index 086a44cc2..50c3ea5fb 100644 --- a/cranelift/frontend/src/ssa.rs +++ b/cranelift/frontend/src/ssa.rs @@ -21,7 +21,6 @@ use cranelift_codegen::ir::{ }; use cranelift_codegen::packed_option::PackedOption; use smallvec::SmallVec; -use std::...
1
23
3
b8fa068ca8a3ab4b0750f5eceba72c20caabb5cf
Alex Crichton
2022-09-16T18:50:49
Limit linear memories when fuzzing with pooling (#4918) This commit limits the maximum number of linear memories when the pooling allocator is used to ensure that the virtual memory mapping for the pooling allocator itself can succeed. Currently there are a number of crashes in the differential fuzzer where the poo...
diff --git a/crates/fuzzing/src/generators/config.rs b/crates/fuzzing/src/generators/config.rs index bbea237c3..4b94f278b 100644 --- a/crates/fuzzing/src/generators/config.rs +++ b/crates/fuzzing/src/generators/config.rs @@ -349,6 +349,11 @@ impl<'a> Arbitrary<'a> for Config { } }; + ...
1
5
0
f5580954af6eab4eb697ca426b410c16c7f6a5e3
Cheng Shao
2022-09-16T15:33:20
Add --disable-parallel-compilation CLI flag (#4911)
diff --git a/crates/cli-flags/Cargo.toml b/crates/cli-flags/Cargo.toml index 1c27f3528..2b406c318 100644 --- a/crates/cli-flags/Cargo.toml +++ b/crates/cli-flags/Cargo.toml @@ -22,6 +22,7 @@ default = [ "wasmtime/cranelift", "wasmtime/jitdump", "wasmtime/vtune", + "wasmtime/parallel-compilation", ] ...
2
9
0
09f46e351ebad9867b854a8be2a81c7f2860b1e4
Afonso Bordado
2022-09-15T18:29:50
fuzzgen: Mostly Forward Branching (#4894) * cranelift: Test Forward branching * fuzzgen: Separate terminators * fuzzgen: Avoid generating jumptables if we have no valid targets * fuzzgen: Forward Jump Tables * fuzzgen: Cleanup some feedback Thanks @jameysharp! * fuzzgen: Cleanup block generation T...
diff --git a/cranelift/fuzzgen/src/config.rs b/cranelift/fuzzgen/src/config.rs index abc3b330a..1cf204b77 100644 --- a/cranelift/fuzzgen/src/config.rs +++ b/cranelift/fuzzgen/src/config.rs @@ -35,6 +35,10 @@ pub struct Config { pub static_stack_slots_per_function: RangeInclusive<usize>, /// Size in bytes ...
2
272
141
9d99eff6f90522a838551326e651bb6b660ca624
Trevor Elliott
2022-09-15T17:40:37
Flatten `and` patterns in ISLE (#4915) Flatten nested and patterns into a single vector in the ISLE front-end.
diff --git a/cranelift/isle/isle/src/sema.rs b/cranelift/isle/isle/src/sema.rs index 3da2441ed..68c20097c 100644 --- a/cranelift/isle/isle/src/sema.rs +++ b/cranelift/isle/isle/src/sema.rs @@ -1514,7 +1514,12 @@ impl TermEnv { /* is_root = */ false, )); ...
1
6
1
2db7d7a8e077fa9600c6d75f9bf482b2ecf754f9
Afonso Bordado
2022-09-15T17:18:15
fuzzgen: Disable verifier after NaN Canonicalization (#4914) * fuzzgen: Disable verifier after NaN Canonicalization We are currently running the verifier twice, once after the nan canonicalization pass, and again when JIT compiling the code. The verifier first runs in the NaN Canonicalization pass. If it fails i...
diff --git a/cranelift/fuzzgen/src/lib.rs b/cranelift/fuzzgen/src/lib.rs index 6f0d0f64d..91f425be6 100644 --- a/cranelift/fuzzgen/src/lib.rs +++ b/cranelift/fuzzgen/src/lib.rs @@ -183,17 +183,23 @@ where // the interpreter won't get that version, so call that pass manually here. let mut ctx = Conte...
3
19
5
d0b98aa25f2f9dab722cc266c3bcee129b3a83ad
Afonso Bordado
2022-09-14T19:23:25
cranelift: Prepare fuzzgen for AArch64 (#4867) * cranelift: Re-enable some shift operations * fuzzgen: Disable Some FloatCC's for AArch64 * cranelift: Disable i128 divs on aarch64 * cranelift: Centralize IntCC selection
diff --git a/cranelift/fuzzgen/src/function_generator.rs b/cranelift/fuzzgen/src/function_generator.rs index 4175a2ac5..ee0e9c07f 100644 --- a/cranelift/fuzzgen/src/function_generator.rs +++ b/cranelift/fuzzgen/src/function_generator.rs @@ -135,7 +135,24 @@ fn insert_cmp( let rhs = builder.use_var(rhs); let...
1
33
16
76c93a390626899b8ce6a87d87d580ce3718fe90
Alex Crichton
2022-09-13T16:34:53
Remove a debug utility in the publish script (#4904) This was something I used for a one-time bump to 2.0, but is no longer necessary. I didn't mean to commit this but I forgot to back it out.
diff --git a/scripts/publish.rs b/scripts/publish.rs index ff6d099bd..30e699b3c 100644 --- a/scripts/publish.rs +++ b/scripts/publish.rs @@ -323,9 +323,6 @@ fn bump_version(krate: &Crate, crates: &[Crate], patch: bool) { /// releases. This may end up getting tweaked as we stabilize crates and start /// doing more min...
1
0
3
024cad7e3dfd2d29281be63a1040528fbfa4728c
Trevor Elliott
2022-09-12T17:15:21
Remove function_alignment from ObjectBuilder (#4888) Removes the function_alignment field from ObjectBuilder and ObjectModule. Alignment information is now provided either by the Module trait for minimum function alignment requirements, or on FunctionInfo for fucntion specific alignment requirements.
diff --git a/cranelift/object/src/backend.rs b/cranelift/object/src/backend.rs index 8f44b2cc2..e73f583d7 100644 --- a/cranelift/object/src/backend.rs +++ b/cranelift/object/src/backend.rs @@ -32,7 +32,6 @@ pub struct ObjectBuilder { endian: object::Endianness, name: Vec<u8>, libcall_names: Box<dyn Fn(ir...
1
3
14
555309a480f0f211a49da6429acc41aa37bad08d
Afonso Bordado
2022-09-12T16:10:49
fuzzgen: Continue execution on traps (#4895)
diff --git a/fuzz/fuzz_targets/cranelift-fuzzgen.rs b/fuzz/fuzz_targets/cranelift-fuzzgen.rs index 859007c3a..c0d2a2418 100644 --- a/fuzz/fuzz_targets/cranelift-fuzzgen.rs +++ b/fuzz/fuzz_targets/cranelift-fuzzgen.rs @@ -104,15 +104,18 @@ fuzz_target!(|testcase: TestCase| { match int_res { RunResu...
1
6
3
bb3aae740a93f9d60aed1c2f6acf09b88f5dfdcc
Afonso Bordado
2022-09-12T16:08:48
fuzzgen: Panic on failed NaN Canonicalization pass (#4896) This should never fail anyway, but it's good to know that we aren't accidentally ignoring an input
diff --git a/cranelift/fuzzgen/src/lib.rs b/cranelift/fuzzgen/src/lib.rs index 515abe974..6f0d0f64d 100644 --- a/cranelift/fuzzgen/src/lib.rs +++ b/cranelift/fuzzgen/src/lib.rs @@ -166,7 +166,7 @@ where Ok(inputs) } - fn run_func_passes(&self, func: Function) -> Result<Function> { + fn run_func_pa...
1
7
5
13c78468159033c637323801d2dc09460bbd71e2
Chris Fallin
2022-09-08T17:04:59
Cranelift: add a vreg limit check to correctly return an error on too-large inputs. (#4882) Previously, Cranelift panicked (via a a panic in regalloc2) when the virtual-register limit of 2M (2^21) was reached. This resulted in a perplexing and unhelpful failure when the user provided a too-large input (such as the ...
diff --git a/cranelift/codegen/src/machinst/lower.rs b/cranelift/codegen/src/machinst/lower.rs index 5e9276cda..8c21dbb24 100644 --- a/cranelift/codegen/src/machinst/lower.rs +++ b/cranelift/codegen/src/machinst/lower.rs @@ -19,7 +19,7 @@ use crate::machinst::{ LoweredBlock, MachLabel, Reg, SigSet, VCode, VCodeBui...
1
5
1
e694a6f5d47fdfe8692d5dd9a8bfe2e60505a31c
Jamey Sharp
2022-09-07T19:19:55
Allocate less while constructing cranelift-fuzzgen tests (#4863) * Improve panic message if typevar_operand is None * cranelift-fuzzgen: Don't allocate for each choice I don't think the performance of test-case generation is at all important here. I'm actually doing this in preparation for a bigger refactor wh...
diff --git a/cranelift/codegen/src/ir/dfg.rs b/cranelift/codegen/src/ir/dfg.rs index 9173c5fed..930816b29 100644 --- a/cranelift/codegen/src/ir/dfg.rs +++ b/cranelift/codegen/src/ir/dfg.rs @@ -864,7 +864,12 @@ impl DataFlowGraph { self.value_type( self[inst] .typevar_o...
2
77
88
e977f6a79dca8aa89937de25d53537597185bd03
Afonso Bordado
2022-09-07T18:00:19
cranelift: Generate Store and Loads in fuzzgen (#4824)
diff --git a/cranelift/fuzzgen/src/function_generator.rs b/cranelift/fuzzgen/src/function_generator.rs index 2b5f7ca79..f088f9485 100644 --- a/cranelift/fuzzgen/src/function_generator.rs +++ b/cranelift/fuzzgen/src/function_generator.rs @@ -2,7 +2,9 @@ use crate::codegen::ir::{ArgumentExtension, ArgumentPurpose}; use ...
1
127
8
b8b2fadea8581763f94013a7c84e5ce66eba2392
Jamey Sharp
2022-09-07T15:46:39
cranelift-fuzzgen: Consume all trailing fuzz input (#4862) But don't keep going once we've consumed it all.
diff --git a/cranelift/fuzzgen/src/lib.rs b/cranelift/fuzzgen/src/lib.rs index cde0d8ab7..515abe974 100644 --- a/cranelift/fuzzgen/src/lib.rs +++ b/cranelift/fuzzgen/src/lib.rs @@ -137,11 +137,12 @@ where }) } - fn generate_test_inputs(&mut self, signature: &Signature) -> Result<Vec<TestCaseInput>> {...
1
16
4
cd982c5a3f3826face686b90ea22456efcd42046
Andrew Brown
2022-09-06T21:54:39
[fuzz] Add SIMD to single-instruction generator (#4778) * [fuzz] Add SIMD to single-instruction generator This change extends the single-instruction generator with most of the SIMD instructions. Examples of instructions that were excluded are: all memory-related instructions, any instruction with an immediate. ...
diff --git a/crates/fuzzing/src/generators/single_inst_module.rs b/crates/fuzzing/src/generators/single_inst_module.rs index 8f77d24f4..317592b18 100644 --- a/crates/fuzzing/src/generators/single_inst_module.rs +++ b/crates/fuzzing/src/generators/single_inst_module.rs @@ -20,6 +20,23 @@ pub struct SingleInstModule<'a> ...
2
412
3
a0e4bb0190de91395d1ec95a5a51fa6b220f1758
Alex Crichton
2022-09-06T18:38:09
Prevent virtual memory OOM in spectest fuzzing (#4872) This commit hard-codes the pooling allocator's limit of linear memories to 1 when used with fuzzing the spec tests themselves. This prevents the number from being set too high and hitting a virtual-memory-based OOM due to the virtual memory reservation of the p...
diff --git a/crates/fuzzing/src/generators/config.rs b/crates/fuzzing/src/generators/config.rs index 6da42fb78..bbea237c3 100644 --- a/crates/fuzzing/src/generators/config.rs +++ b/crates/fuzzing/src/generators/config.rs @@ -131,7 +131,7 @@ impl Config { // required to actually run the spec tests. Fuzz-gen...
1
1
1
543a487939effcb9d43eb912e1ecf8e7348cce08
Alex Crichton
2022-09-06T17:41:23
Throw out fewer fuzz inputs with differential fuzzer (#4859) * Throw out fewer fuzz inputs with differential fuzzer Prior to this commit the differential fuzzer would generate a module and then select an engine to execute the module against Wasmtime. This meant, however, that the candidate list of engines were fi...
diff --git a/crates/fuzzing/src/generators/config.rs b/crates/fuzzing/src/generators/config.rs index 6ee459a7a..6da42fb78 100644 --- a/crates/fuzzing/src/generators/config.rs +++ b/crates/fuzzing/src/generators/config.rs @@ -38,11 +38,11 @@ impl Config { // Make it more likely that there are types available ...
8
142
182
7e45cff45974b1b2f5020054fcf59ff093991d09
Afonso Bordado
2022-09-02T19:34:16
cranelift: Bitwise compare fuzzgen results (#4855)
diff --git a/cranelift/codegen/src/data_value.rs b/cranelift/codegen/src/data_value.rs index fd9bcab13..affc5b711 100644 --- a/cranelift/codegen/src/data_value.rs +++ b/cranelift/codegen/src/data_value.rs @@ -154,6 +154,25 @@ impl DataValue { ty, ) } + + /// Performs a bitwise comparison o...
3
31
20
10dbb19983cf77b5d8c92ca93fa9b4ede3c94fc9
Alex Crichton
2022-09-02T19:16:02
Various improvements to differential fuzzing (#4845) * Improve wasmi differential fuzzer * Support modules with a `start` function * Implement trap-matching to ensure that wasmi and Wasmtime both report the same flavor of trap. * Support differential fuzzing where no engines match Locally I was attempting...
diff --git a/crates/fuzzing/src/generators/config.rs b/crates/fuzzing/src/generators/config.rs index 14463dfa7..6ee459a7a 100644 --- a/crates/fuzzing/src/generators/config.rs +++ b/crates/fuzzing/src/generators/config.rs @@ -36,12 +36,6 @@ impl Config { pub fn set_differential_config(&mut self) { let conf...
9
192
55
3afb711a5135f6d2bf61a2533db4483f397fe1c0
Afonso Bordado
2022-09-02T19:02:22
cranelift: Document Ieee{32,64} implementation (#4854)
diff --git a/cranelift/codegen/src/ir/immediates.rs b/cranelift/codegen/src/ir/immediates.rs index ad09b1b65..445e3f9ae 100644 --- a/cranelift/codegen/src/ir/immediates.rs +++ b/cranelift/codegen/src/ir/immediates.rs @@ -472,6 +472,9 @@ impl FromStr for Offset32 { /// An IEEE binary32 immediate floating point value, r...
1
6
0
b8a68ff86d14aa70cc51960bf1b8676233110f5e
Alex Crichton
2022-09-02T18:11:48
Tweak adapter cost of lists (#4853) I noticed an oss-fuzz-based timeout that was reported for the `component_api` fuzzer where the adapter module generated takes 1.5 seconds to compile the singular function in release mode (no fuzzing enabled). The test case in question was a deeply recursive list-of-list-of-etc a...
diff --git a/crates/environ/src/fact/trampoline.rs b/crates/environ/src/fact/trampoline.rs index 70255f990..84e690320 100644 --- a/crates/environ/src/fact/trampoline.rs +++ b/crates/environ/src/fact/trampoline.rs @@ -514,12 +514,12 @@ impl Compiler<'_, '_> { InterfaceType::Char => 1, // This...
1
3
3
84ac24c23d859af4c788ef4abaa57450cc69a210
Jamey Sharp
2022-09-01T21:57:37
cranelift: Remove const_addr instruction (fixes #2398) (#4843)
diff --git a/cranelift/codegen/meta/src/shared/instructions.rs b/cranelift/codegen/meta/src/shared/instructions.rs index 1d126f4ee..16c8799f1 100644 --- a/cranelift/codegen/meta/src/shared/instructions.rs +++ b/cranelift/codegen/meta/src/shared/instructions.rs @@ -1455,21 +1455,6 @@ pub(crate) fn define( .oper...
5
2
21
bca4dae8b0e118785455099102b95ff4089cc9ec
Xuran
2022-09-01T16:09:46
feat: add a knob for reset stack (#4813) * feat: add a knob for reset stack * Touch up documentation of `async_stack_zeroing` Co-authored-by: Alex Crichton <alex@alexcrichton.com>
diff --git a/crates/fuzzing/src/generators/config.rs b/crates/fuzzing/src/generators/config.rs index 47ed2ebb6..14463dfa7 100644 --- a/crates/fuzzing/src/generators/config.rs +++ b/crates/fuzzing/src/generators/config.rs @@ -181,7 +181,8 @@ impl Config { self.wasmtime.memory_guaranteed_dense_image_size...
4
92
8
dde2c5a3b6ee6caa1d597da0885613d2ce6a406a
Trevor Elliott
2022-08-31T21:41:44
Align functions according to their ISA's requirements (#4826) Add a function_alignment function to the TargetIsa trait, and use it to align functions when generating objects. Additionally, collect the maximum alignment required for pc-relative constants in functions and pass that value out. Use the max of these two va...
diff --git a/cranelift/codegen/src/isa/aarch64/mod.rs b/cranelift/codegen/src/isa/aarch64/mod.rs index 9e6918d01..0498875f2 100644 --- a/cranelift/codegen/src/isa/aarch64/mod.rs +++ b/cranelift/codegen/src/isa/aarch64/mod.rs @@ -95,6 +95,7 @@ impl TargetIsa for AArch64Backend { dynamic_stackslot_offsets, ...
13
81
15
99c6d7c083d9817eb77670651434e08d14300c4a
Alex Crichton
2022-08-31T17:09:45
components: Improve heuristic for splitting adapters (#4827) This commit is a (second?) attempt at improving the generation of adapter modules to avoid excessively large functions for fuzz-generated inputs. The first iteration of adapters simply translated an entire type inline per-function. This proved problema...
diff --git a/crates/environ/src/fact.rs b/crates/environ/src/fact.rs index 2827b2124..6bf598c99 100644 --- a/crates/environ/src/fact.rs +++ b/crates/environ/src/fact.rs @@ -20,7 +20,7 @@ use crate::component::dfg::CoreDef; use crate::component::{ - Adapter, AdapterOptions as AdapterOptionsDfg, ComponentTypesBuil...
3
395
197
ff0e84ecf449cf89d970457fd6206e1c06429980
Nick Fitzgerald
2022-08-30T18:28:00
Wasmtime: fix stack walking across frames from different stores (#4779) We were previously implicitly assuming that all Wasm frames in a stack used the same `VMRuntimeLimits` as the previous frame we walked, but this is not true when Wasm in store A calls into the host which then calls into Wasm in store B: |...
diff --git a/Cargo.lock b/Cargo.lock index 82cd18897..450592994 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3443,6 +3443,7 @@ dependencies = [ "humantime 2.1.0", "libc", "listenfd", + "log", "memchr", "num_cpus", "once_cell", diff --git a/Cargo.toml b/Cargo.toml index 70410df76..8f9a3df1e 100644 --- a/Carg...
7
492
94
5d05d7676f60ac36e7fb3153240f7ddd31063f6e
Trevor Elliott
2022-08-30T00:09:19
Improve the `fmt` output of the instantiate fuzz target (#4804) Add an Arbitrary instance for the input to the instantiate fuzz target, so that cargo fuzz fmt instantiate <file> produces more meaningful output.
diff --git a/fuzz/fuzz_targets/instantiate.rs b/fuzz/fuzz_targets/instantiate.rs index cd1df275a..028e9d6be 100644 --- a/fuzz/fuzz_targets/instantiate.rs +++ b/fuzz/fuzz_targets/instantiate.rs @@ -1,38 +1,48 @@ #![no_main] -use libfuzzer_sys::arbitrary::{Result, Unstructured}; +use libfuzzer_sys::arbitrary::{Arbitra...
1
39
29
dd81e5a64f3e5dedba6884929073bd65d736e8be
Jamey Sharp
2022-08-29T23:06:41
Don't let fuzz targets import `arbitrary` directly (#4806) The version of the `arbitrary` crate used in fuzz targets needs to be the same as the version used in `libfuzzer-sys`. That's why the latter crate re-exports the former. But we need to make sure to consistently use the re-exported version. That's most ea...
diff --git a/crates/misc/component-fuzz-util/src/lib.rs b/crates/misc/component-fuzz-util/src/lib.rs index 7c6509d40..db963e200 100644 --- a/crates/misc/component-fuzz-util/src/lib.rs +++ b/crates/misc/component-fuzz-util/src/lib.rs @@ -575,8 +575,8 @@ pub fn rust_type(ty: &Type, name_counter: &mut u32, declarations: &...
5
9
10
488234786853cbcadd1341325fea8499e955331c
Jamey Sharp
2022-08-29T21:30:26
Disable funcref generation for fuzz tests with inputs (#4797) This fixes #4757, fixes #4758, and fixes new fuzzbugs that are probably coming after we merged #4667.
diff --git a/cranelift/fuzzgen/src/lib.rs b/cranelift/fuzzgen/src/lib.rs index 8dce6e021..cde0d8ab7 100644 --- a/cranelift/fuzzgen/src/lib.rs +++ b/cranelift/fuzzgen/src/lib.rs @@ -190,6 +190,11 @@ where } pub fn generate_test(mut self) -> Result<TestCase> { + // If we're generating test inputs as we...
1
5
0
07767c3d4ac4a17fe4cf3fcfdf0157c655f16b5b
Afonso Bordado
2022-08-29T21:30:03
cranelift: Enable i128 shifts (#4783)
diff --git a/cranelift/fuzzgen/src/function_generator.rs b/cranelift/fuzzgen/src/function_generator.rs index 5819be04a..031d1b358 100644 --- a/cranelift/fuzzgen/src/function_generator.rs +++ b/cranelift/fuzzgen/src/function_generator.rs @@ -289,17 +289,16 @@ const OPCODE_SIGNATURES: &'static [( (Opcode::Ishl, &[I1...
1
4
6
7663cc1c3df7049515db1c96f99ddfaee2e4bb81
Afonso Bordado
2022-08-29T21:29:51
cranelift: Disable i128 divs on fuzzgen (#4771)
diff --git a/cranelift/fuzzgen/src/function_generator.rs b/cranelift/fuzzgen/src/function_generator.rs index f454f912d..5819be04a 100644 --- a/cranelift/fuzzgen/src/function_generator.rs +++ b/cranelift/fuzzgen/src/function_generator.rs @@ -196,17 +196,19 @@ const OPCODE_SIGNATURES: &'static [( (Opcode::Imul, &[I6...
1
4
2
9a8bd5be0238be68310516c7fc58c3a99a8c7910
Afonso Bordado
2022-08-29T20:36:33
cranelift: Add LibCalls to the interpreter (#4782) * cranelift: Add libcall handlers to interpreter * cranelift: Fuzz IshlI64 libcall * cranelift: Revert back to fuzzing udivi64 * cranelift: Use sdiv as a fuzz libcall * cranelift: Register Sdiv in fuzzgen * cranelift: Add multiple libcalls to fuzzer ...
diff --git a/Cargo.lock b/Cargo.lock index bf4830f6e..936c14ade 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3605,6 +3605,7 @@ dependencies = [ "proc-macro2", "quote", "rand 0.8.5", + "smallvec", "target-lexicon", "wasmtime", "wasmtime-fuzzing", diff --git a/cranelift/codegen/src/ir/libcall.rs b/cranelift/c...
9
177
108