commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
9b9e46abd821178b9b7e5b416fdd0b2e98ff0a39
Ulrich Weigand
2020-11-20T19:33:13
Update to backtrace version 0.3.55 (#2436) This fixes a bug in the get_sp function on s390x, which caused crashed during garbage collection.
diff --git a/Cargo.lock b/Cargo.lock index f1d0c04bf..2ad268c14 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -94,9 +94,9 @@ checksum = "cdb031dd78e28731d87d56cc8ffef4a8f36ca26c38fe2de700543e627f8a464a" [[package]] name = "backtrace" -version = "0.3.54" +version = "0.3.55" source = "registry+https://github.com/rust-...
2
3
3
6681e6786e24e8a32ba2c53915e89b8da47279d4
Pat Hickey
2020-11-20T19:18:56
debug assert could catch double-free
diff --git a/crates/wiggle/borrow/src/lib.rs b/crates/wiggle/borrow/src/lib.rs index 086f350d2..9502ba017 100644 --- a/crates/wiggle/borrow/src/lib.rs +++ b/crates/wiggle/borrow/src/lib.rs @@ -118,11 +118,13 @@ impl InnerBorrowChecker { } fn shared_unborrow(&mut self, h: BorrowHandle) { - let _ = sel...
1
4
2
f5f180a8fe74231697a4a7d2ae90a735ef4118e9
Pat Hickey
2020-11-19T23:29:12
refactor is_borrowed/unborrow into shared/mut variants
diff --git a/crates/wiggle/borrow/src/lib.rs b/crates/wiggle/borrow/src/lib.rs index 288c50f93..086f350d2 100644 --- a/crates/wiggle/borrow/src/lib.rs +++ b/crates/wiggle/borrow/src/lib.rs @@ -31,11 +31,17 @@ impl BorrowChecker { pub fn mut_borrow(&self, r: Region) -> Result<BorrowHandle, GuestError> { se...
5
120
64
224e8b0e88f4179deb38813bef02e2e98c1b5c04
Pat Hickey
2020-11-19T23:28:53
wasi-nn: fix mutable guestslice borrow
diff --git a/crates/wasi-nn/src/impl.rs b/crates/wasi-nn/src/impl.rs index a8828c1fe..fb8e781dd 100644 --- a/crates/wasi-nn/src/impl.rs +++ b/crates/wasi-nn/src/impl.rs @@ -158,7 +158,7 @@ impl<'a> WasiEphemeralNn for WasiNnCtx { }; // Copy the tensor data over to the `out_buffer`. - let ...
1
1
1
f9de1d3e5ce9b76e9b792553cf7594ebabf895de
Pat Hickey
2020-11-19T22:42:31
rename immutable borrows to shared borrows
diff --git a/crates/wiggle/borrow/src/lib.rs b/crates/wiggle/borrow/src/lib.rs index ff712e3d1..288c50f93 100644 --- a/crates/wiggle/borrow/src/lib.rs +++ b/crates/wiggle/borrow/src/lib.rs @@ -25,8 +25,8 @@ impl BorrowChecker { pub fn has_outstanding_borrows(&self) -> bool { self.bc.borrow().has_outstandi...
4
50
50
e34b41038122e9547a84f0513600fc97af4ab531
Yury Delendik
2020-11-19T20:08:10
Update wasmparser for exception handling (#2431)
diff --git a/Cargo.lock b/Cargo.lock index 46384b2d6..f1d0c04bf 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -586,7 +586,7 @@ dependencies = [ "smallvec", "target-lexicon", "thiserror", - "wasmparser 0.67.0", + "wasmparser 0.68.0", "wat", ] @@ -1150,7 +1150,7 @@ dependencies = [ "smallvec", "thiserror", ...
16
131
41
4d64c68b05b2f416aa7b7bcbaa8e9c51faa46b12
Alex Crichton
2020-11-19T19:12:30
Run rustfmt 1.48 Run rustfmt over wasmtime with the new stable release which looks like it wants to reformat a few lines.
diff --git a/cranelift/codegen/src/isa/aarch64/inst/mod.rs b/cranelift/codegen/src/isa/aarch64/inst/mod.rs index 627a02bda..29debb9fb 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/mod.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/mod.rs @@ -3045,41 +3045,13 @@ impl Inst { let rn = show_ireg_siz...
2
137
104
3509883f2da9e3c1adb94618200cbed409b529f9
Pat Hickey
2020-11-18T23:02:02
wiggle: add test of overlapping immutable borrows
diff --git a/crates/wiggle/tests/strings.rs b/crates/wiggle/tests/strings.rs index cff55d92d..ed176f6f6 100644 --- a/crates/wiggle/tests/strings.rs +++ b/crates/wiggle/tests/strings.rs @@ -34,9 +34,12 @@ impl<'a> strings::Strings for WasiCtx<'a> { } } -fn test_string_strategy() -> impl Strategy<Value = String> ...
1
90
5
26192d67602e43b883ae0a2b6882476401501434
Pat Hickey
2020-11-18T22:43:47
wasi-common: opt in to mutable borrowing
diff --git a/crates/wasi-common/src/snapshots/wasi_snapshot_preview1.rs b/crates/wasi-common/src/snapshots/wasi_snapshot_preview1.rs index 15dc7e310..4002a58d4 100644 --- a/crates/wasi-common/src/snapshots/wasi_snapshot_preview1.rs +++ b/crates/wasi-common/src/snapshots/wasi_snapshot_preview1.rs @@ -8,7 +8,7 @@ use std...
1
6
6
fc608e392b1a4b011673606abe2a07d50c0dca10
Pat Hickey
2020-11-18T20:32:21
wiggle: make Mut variants of GuestStr, GuestPtr
diff --git a/crates/wiggle/src/lib.rs b/crates/wiggle/src/lib.rs index a625a4890..f28fdb804 100644 --- a/crates/wiggle/src/lib.rs +++ b/crates/wiggle/src/lib.rs @@ -301,12 +301,14 @@ unsafe impl<T: ?Sized + GuestMemory> GuestMemory for Arc<T> { /// Note that the type parameter does not need to implement the `Sized` tr...
1
143
22
78db3ff13bbb7be9f9c54c0f85447d8f2e80fe2c
Pat Hickey
2020-11-18T20:19:47
wiggle: borrow checker lives in own crate, and supports both mut/immut
diff --git a/Cargo.lock b/Cargo.lock index 46384b2d6..542b28795 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2680,6 +2680,7 @@ dependencies = [ "wasmtime", "wasmtime-wiggle-macro", "wiggle", + "wiggle-borrow", "witx", ] @@ -2752,6 +2753,13 @@ dependencies = [ "witx", ] +[[package]] +name = "wiggle-borro...
9
154
246
3d606a01e50517de50adab7d1161c4057fb20aed
Andrew Brown
2020-11-18T15:21:51
wasi-nn: remove unused functions (#2427)
diff --git a/crates/wasi-nn/src/ctx.rs b/crates/wasi-nn/src/ctx.rs index 2857f2cf9..f180f113f 100644 --- a/crates/wasi-nn/src/ctx.rs +++ b/crates/wasi-nn/src/ctx.rs @@ -9,7 +9,7 @@ use std::hash::Hash; use thiserror::Error; use wiggle::GuestError; -/// Possible errors for interacting with [WasiNnCtx]. +/// Possible...
1
1
9
02156eaef3006c687aa9e972463b3a60db80c671
Nick Fitzgerald
2020-11-12T21:44:16
wasmtime: Remove typo in doc comment
diff --git a/crates/wasmtime/src/ref.rs b/crates/wasmtime/src/ref.rs index 88c5e47f8..6ea86655a 100644 --- a/crates/wasmtime/src/ref.rs +++ b/crates/wasmtime/src/ref.rs @@ -29,7 +29,7 @@ impl ExternRef { self.inner.strong_count() } - /// Does this `ExternRef` point to the same inner value as `other`?...
1
1
1
39b57367270360d81ceee6e1ce71cdb59afb8650
Chris Fallin
2020-11-06T00:42:34
Remove LoadSplat opcode, in preparation for pattern-matching Load+Splat. This was added as an incremental step to improve AArch64 code quality in PR #2278. At the time, we did not have a way to pattern-match the load + splat opcode sequence that the relevant Wasm opcodes lowered to. However, now with PR #2366, we can ...
diff --git a/cranelift/codegen/meta/src/isa/x86/legalize.rs b/cranelift/codegen/meta/src/isa/x86/legalize.rs index 681b3104d..de78c3b3b 100644 --- a/cranelift/codegen/meta/src/isa/x86/legalize.rs +++ b/cranelift/codegen/meta/src/isa/x86/legalize.rs @@ -396,7 +396,6 @@ fn define_simd( let insertlane = insts.by_name...
6
8
57
3c8cb7b908b6bffb39218863d2ebdbfedcf4ce46
Chris Fallin
2020-11-05T08:01:56
MachInst lowering logic: allow effectful instructions to merge. This PR updates the "coloring" scheme that accounts for side-effects in the MachInst lowering logic. As a result, the new backends will now be able to merge effectful operations (such as memory loads) *into* other operations; previously, only the other wa...
diff --git a/cranelift/codegen/src/isa/aarch64/lower.rs b/cranelift/codegen/src/isa/aarch64/lower.rs index 8c94aad5f..11dc4de79 100644 --- a/cranelift/codegen/src/isa/aarch64/lower.rs +++ b/cranelift/codegen/src/isa/aarch64/lower.rs @@ -111,7 +111,7 @@ pub(crate) enum ResultRegImmShift { /// Lower an instruction inp...
6
270
185
ffca0fc908639d4c176245b51557a57555794b7d
Alex Crichton
2020-11-16T19:54:57
Fix assertion with cross-store values in `Func::new` If a host-defined `Func::new` closure returns values from the wrong store, this currently trips a debug assertion and causes other issues elsewhere in release mode. This commit adds the same dynamic checks found in `Func::wrap` in the `Func::new` case today.
diff --git a/crates/wasmtime/src/func.rs b/crates/wasmtime/src/func.rs index a4de5209e..4225823ad 100644 --- a/crates/wasmtime/src/func.rs +++ b/crates/wasmtime/src/func.rs @@ -295,14 +295,19 @@ impl Func { // Unlike our arguments we need to dynamically check that the return // values produc...
2
39
2
8675fa5aa76c107183e56c236c67e9609af4fae2
Alex Crichton
2020-11-16T20:26:48
Fix a memory leak on returning incompatible values (#2424) This fixes an issue where if a store-incompatible value is returned from a host-defined function then that value is leaked. Practically this means that it's possible to accidentally leak `Func` values, but a simple insertion of a `drop` does the trick!
diff --git a/crates/wasmtime/src/func.rs b/crates/wasmtime/src/func.rs index 216ef6279..a4de5209e 100644 --- a/crates/wasmtime/src/func.rs +++ b/crates/wasmtime/src/func.rs @@ -1611,6 +1611,14 @@ macro_rules! impl_into_func { ) })) }; + + ...
2
36
0
61a0bcbdc68f3670669746e2c7e4769a17918797
Ivan Zvonimir Horvat
2020-11-16T17:48:49
examples: threads.rs; fixed eun typo -> run (#2422)
diff --git a/examples/threads.rs b/examples/threads.rs index 5bef1f954..b83a1da3b 100644 --- a/examples/threads.rs +++ b/examples/threads.rs @@ -28,7 +28,7 @@ fn run(engine: &Engine, module: Module, id: i32) -> Result<()> { println!("Extracting export..."); let g = instance .get_func("run") - ...
1
1
1
5995c3774f8718710a0fa62072ddbb58d9df867f
Ivan Zvonimir Horvat
2020-11-13T13:28:27
Command: config; fix message typo (#2412)
diff --git a/src/commands/config.rs b/src/commands/config.rs index 14184bd8e..5cafac4e7 100644 --- a/src/commands/config.rs +++ b/src/commands/config.rs @@ -39,7 +39,7 @@ impl ConfigNewCommand { let path = wasmtime_cache::create_new_config(self.path.as_ref())?; println!( - "Successfully c...
1
1
1
d777ec675ca77463f6a04320e76d5026e2bd6bc4
bjorn3
2020-11-13T08:28:51
Transparently change non-PLT libcall relocations to PLT relocations
diff --git a/cranelift/simplejit/src/backend.rs b/cranelift/simplejit/src/backend.rs index 71dd5c07d..eb6610907 100644 --- a/cranelift/simplejit/src/backend.rs +++ b/cranelift/simplejit/src/backend.rs @@ -595,7 +595,18 @@ impl<'simple_jit_backend> Module for SimpleJITModule { .as_ref() .unwrap...
1
12
1
0d703c12edec9940662ce73d47ba6e6306c5d832
Chris Fallin
2020-11-13T04:40:54
Don't run old x86 backend-specific tests with new x64 backend. Some of the test failures tracked by #2079 are in unwind tests that are specific to the old x86 backend: namely, these tests invoke the unwind implementation that is paired with the old backend, rather than generic over all backends. It thus doesn't make s...
diff --git a/cranelift/codegen/src/isa/mod.rs b/cranelift/codegen/src/isa/mod.rs index 2e56c025d..a1a4c3c39 100644 --- a/cranelift/codegen/src/isa/mod.rs +++ b/cranelift/codegen/src/isa/mod.rs @@ -75,7 +75,10 @@ use thiserror::Error; #[cfg(feature = "riscv")] mod riscv; -#[cfg(feature = "x86")] +// Exclude the old ...
4
12
18
01b60e81b03b8ea3642c38d9d6ce228e82e20438
Chris Fallin
2020-11-13T00:55:18
Fix and enable GC on new x64 backend. One critical bit of plumbing was missing: the `StackMapSink` passed to `compile_and_emit` was not actually receiving stackmaps. This seemingly very basic issue was not caught because the other major user of reftype support, SpiderMonkey, extracts stackmaps with a lower-level API. ...
diff --git a/cranelift/codegen/src/context.rs b/cranelift/codegen/src/context.rs index 4eb0c3b12..ef092fb81 100644 --- a/cranelift/codegen/src/context.rs +++ b/cranelift/codegen/src/context.rs @@ -22,7 +22,7 @@ use crate::legalize_function; use crate::legalizer::simple_legalize; use crate::licm::do_licm; use crate::...
2
15
5
f4c3622dab04c6938e91fb2fc6c159f642cc5fe4
Alex Crichton
2020-11-12T20:54:07
Fix a use-after-free of trampoline code This commit fixes an issue with wasmtime where it was possible for a trampoline from one module to get used for another module after it was freed. This issue arises because we register a module's native trampolines *before* it's fully instantiated, which is a fallible process. S...
diff --git a/crates/wasmtime/src/instance.rs b/crates/wasmtime/src/instance.rs index 32a77e1f9..26a1776cd 100644 --- a/crates/wasmtime/src/instance.rs +++ b/crates/wasmtime/src/instance.rs @@ -16,6 +16,11 @@ fn instantiate( imports: Imports<'_>, host: Box<dyn Any>, ) -> Result<StoreInstanceHandle, Error> { +...
3
62
9
243ab3b542dbf5addd3c676a1e56c1f00eef8ac7
Alex Crichton
2020-11-12T20:54:02
Remove the global variable associated with traps This commit removes the global variable associated with wasm traps which stores frame information. The only purpose of this global is to help symbolicate `Trap`s created since we support creating a `Trap` without a `Store`. The global, however, is only used for wasm fra...
diff --git a/Cargo.lock b/Cargo.lock index 156fd62c9..1403ccac7 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2247,7 +2247,6 @@ dependencies = [ "backtrace", "bincode", "cfg-if 1.0.0", - "lazy_static", "libc", "log", "region", diff --git a/crates/jit/src/lib.rs b/crates/jit/src/lib.rs index 12afa4184..94f268...
14
240
240
ad61eb4eb991690fd07cd2fbf0de33487ef47552
Andrew Brown
2020-11-11T23:47:20
[machinst x64]: enable more SIMD spec tests
diff --git a/build.rs b/build.rs index b1dda8abf..da9822e71 100644 --- a/build.rs +++ b/build.rs @@ -182,6 +182,7 @@ fn experimental_x64_should_panic(testsuite: &str, testname: &str, strategy: &str match (testsuite, testname) { ("simd", "simd_address") => return false, ("simd", "simd_bitwise") =>...
1
3
0
8ba92853beefcd7b13d27e5928d8a089df4ea11b
Andrew Brown
2020-11-11T18:05:14
[machinst x64]: add punpack[hl]bw instructions
diff --git a/cranelift/codegen/src/isa/x64/inst/args.rs b/cranelift/codegen/src/isa/x64/inst/args.rs index 0050a0a41..bf209919b 100644 --- a/cranelift/codegen/src/isa/x64/inst/args.rs +++ b/cranelift/codegen/src/isa/x64/inst/args.rs @@ -482,6 +482,8 @@ pub enum SseOpcode { Psubusb, Psubusw, Ptest, + P...
3
20
0
8131b1592107304e0865f8674ce70ccff45d4eeb
Andrew Brown
2020-11-11T17:46:47
[machinst x64]: allow addressing of constants
diff --git a/cranelift/codegen/src/isa/x64/inst/args.rs b/cranelift/codegen/src/isa/x64/inst/args.rs index 708e52f36..0050a0a41 100644 --- a/cranelift/codegen/src/isa/x64/inst/args.rs +++ b/cranelift/codegen/src/isa/x64/inst/args.rs @@ -3,6 +3,7 @@ use super::regs::{self, show_ireg_sized}; use super::EmitState; use ...
2
34
24
01b7d88641c7f97544e1590fa5ff80143e261731
Alex Crichton
2020-11-12T21:50:56
Split up `src/runtime.rs` in `wasmtime` (#2404) This file has grown quite a lot with `Store` over time so this splits it up into three separate files, one for each of the main types defined in it: `Config`, `Engine`, and `Store`.
diff --git a/crates/wasmtime/src/runtime.rs b/crates/wasmtime/src/config.rs similarity index 58% rename from crates/wasmtime/src/runtime.rs rename to crates/wasmtime/src/config.rs index 79a4bdcca..0cb776ffd 100644 --- a/crates/wasmtime/src/runtime.rs +++ b/crates/wasmtime/src/config.rs @@ -1,38 +1,25 @@ use crate::ext...
5
596
587
8a35cbaf0d5c99dd408b0b8b51af26a800a509c4
bjorn3
2020-11-12T18:49:42
Enable PIC in SimpleJITBuilder::new
diff --git a/cranelift/simplejit/src/backend.rs b/cranelift/simplejit/src/backend.rs index 2c9015787..71dd5c07d 100644 --- a/cranelift/simplejit/src/backend.rs +++ b/cranelift/simplejit/src/backend.rs @@ -51,6 +51,7 @@ impl SimpleJITBuilder { // which might not reach all definitions; we can't handle that here,...
1
1
0
86d3dc9510bd98de6bd9cc6793d2fc8ee5d17fa1
bjorn3
2020-11-12T18:29:05
Add prepare_for_function_redefine
diff --git a/Cargo.lock b/Cargo.lock index 7e22a7d85..36dc8c161 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -477,6 +477,7 @@ dependencies = [ name = "cranelift-simplejit" version = "0.68.0" dependencies = [ + "anyhow", "cranelift", "cranelift-codegen", "cranelift-entity", diff --git a/cranelift/module/src/modu...
4
118
0
cdbbcf7e13dd3a29993158847a9204a96d389ff2
bjorn3
2020-11-12T17:58:28
Add plt entries to perf jit map
diff --git a/cranelift/simplejit/src/backend.rs b/cranelift/simplejit/src/backend.rs index 97abd744f..38b61c04d 100644 --- a/cranelift/simplejit/src/backend.rs +++ b/cranelift/simplejit/src/backend.rs @@ -435,6 +435,11 @@ impl<'simple_jit_backend> Module for SimpleJITModule { .allocate(std::mem::size_o...
1
5
0
cbce34af0a3dae454fb557ac9f168feac692bc7f
Julian Seward
2020-11-12T16:01:30
aarch64/inst/unwind.rs: handle zero-length prologues correctly.
diff --git a/cranelift/codegen/src/isa/aarch64/inst/unwind.rs b/cranelift/codegen/src/isa/aarch64/inst/unwind.rs index 265dd3fb6..ff6634ad4 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/unwind.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/unwind.rs @@ -102,7 +102,12 @@ impl UnwindInfoGenerator<Inst> for AArch64...
1
6
1
bf9e5d94480c085bb7c8d6165ade1ccd1a4444f0
bjorn3
2020-11-12T15:41:23
Use a PLT reference for function relocations in data objects This ensures that all functions can be replaced without having to perform relocations again.
diff --git a/cranelift/simplejit/src/backend.rs b/cranelift/simplejit/src/backend.rs index e5f90e9db..97abd744f 100644 --- a/cranelift/simplejit/src/backend.rs +++ b/cranelift/simplejit/src/backend.rs @@ -188,14 +188,7 @@ impl SimpleJITModule { match *name { ir::ExternalName::User { .. } => { ...
1
1
8
8a4749af51273dde8b38ee60c583774260edbda2
bjorn3
2020-11-12T15:33:04
Immediately perform relocations when defining a function
diff --git a/cranelift/simplejit/src/backend.rs b/cranelift/simplejit/src/backend.rs index e7a5d72e9..e5f90e9db 100644 --- a/cranelift/simplejit/src/backend.rs +++ b/cranelift/simplejit/src/backend.rs @@ -137,7 +137,6 @@ pub struct SimpleJITModule { libcall_plt_entries: HashMap<ir::LibCall, NonNull<[u8; 16]>>, ...
1
14
22
5458473765bd044da013e8ad08a2018ec4733b9b
bjorn3
2020-11-12T15:19:16
Implement PLT relocations for SimpleJIT
diff --git a/cranelift/simplejit/src/backend.rs b/cranelift/simplejit/src/backend.rs index 5ed2e3fce..e7a5d72e9 100644 --- a/cranelift/simplejit/src/backend.rs +++ b/cranelift/simplejit/src/backend.rs @@ -18,7 +18,7 @@ use cranelift_native; use libc; use log::info; use std::collections::HashMap; -use std::convert::T...
2
79
6
eaa2c5b3c25accd1a46fb9bb5bf10ee9a7ae02ac
bjorn3
2020-11-12T14:06:52
Implement GOT relocations in SimpleJIT
diff --git a/cranelift/codegen/src/ir/libcall.rs b/cranelift/codegen/src/ir/libcall.rs index 9dc134e48..632b04a4c 100644 --- a/cranelift/codegen/src/ir/libcall.rs +++ b/cranelift/codegen/src/ir/libcall.rs @@ -63,6 +63,7 @@ pub enum LibCall { /// Elf __tls_get_addr ElfTlsGetAddr, + // When adding a new va...
3
207
14
11a3bdfc6ad8e0987630519e401ffcefe5a62109
bjorn3
2020-11-12T13:13:06
Catch overflows when performing relocations
diff --git a/cranelift/simplejit/src/compiled_blob.rs b/cranelift/simplejit/src/compiled_blob.rs index dc8563dab..e00fbeecf 100644 --- a/cranelift/simplejit/src/compiled_blob.rs +++ b/cranelift/simplejit/src/compiled_blob.rs @@ -21,27 +21,24 @@ impl CompiledBlob { } in &self.relocs { debu...
1
5
8
35da24adfd33102929c08f094f98568f7d583343
Matthieu Felix
2020-11-12T04:27:25
Specify unsealed / unfilled blocks
diff --git a/cranelift/frontend/src/frontend.rs b/cranelift/frontend/src/frontend.rs index 3b9263301..c44f2d11b 100644 --- a/cranelift/frontend/src/frontend.rs +++ b/cranelift/frontend/src/frontend.rs @@ -459,19 +459,23 @@ impl<'a> FunctionBuilder<'a> { /// for another function. pub fn finalize(&mut self) { ...
1
17
13
5e5e520654b3b7e3bbf99a5161398fff412e9c40
Chris Fallin
2020-11-11T21:47:36
Remove size-of-struct asserts that break with some Rust versions. The asserts on the sizes of the VCode constant-table data structures introduced in PR #2328 are dependent on the size of data structures such as `HashMap` in the standard library, which can change. In particular, on Rust 1.46 (which is not current, but ...
diff --git a/cranelift/codegen/src/machinst/vcode.rs b/cranelift/codegen/src/machinst/vcode.rs index 1ca1b25ce..c57f018e3 100644 --- a/cranelift/codegen/src/machinst/vcode.rs +++ b/cranelift/codegen/src/machinst/vcode.rs @@ -876,7 +876,7 @@ impl VCodeConstantData { #[cfg(test)] mod test { use super::*; - use ...
1
4
7
b7a93c2321c3eff101f22e426fae8b81bd21c39e
bjorn3
2020-11-11T11:25:36
Remove reloc_block It isn't called and all reloc sinks either ignore it or panic when it is called.
diff --git a/cranelift/codegen/src/binemit/memorysink.rs b/cranelift/codegen/src/binemit/memorysink.rs index 151983933..d50d1c10e 100644 --- a/cranelift/codegen/src/binemit/memorysink.rs +++ b/cranelift/codegen/src/binemit/memorysink.rs @@ -74,9 +74,6 @@ impl<'a> MemoryCodeSink<'a> { /// A trait for receiving reloca...
14
0
75
1dc27c93a4aa09eda18b54ffbf92f5e6955dd047
bjorn3
2020-11-11T11:19:37
Introduce DataDescription::all_relocs to dedup some code
diff --git a/cranelift/module/src/data_context.rs b/cranelift/module/src/data_context.rs index ca490a09e..ce9536b1b 100644 --- a/cranelift/module/src/data_context.rs +++ b/cranelift/module/src/data_context.rs @@ -1,6 +1,6 @@ //! Defines `DataContext`. -use cranelift_codegen::binemit::{Addend, CodeOffset}; +use crane...
3
111
116
a5501e12a65dd1a732a0a4648b31128d8f32716e
bjorn3
2020-11-11T10:56:41
Rename functions and data_objects fields
diff --git a/cranelift/simplejit/src/backend.rs b/cranelift/simplejit/src/backend.rs index 727fecd10..febee43b2 100644 --- a/cranelift/simplejit/src/backend.rs +++ b/cranelift/simplejit/src/backend.rs @@ -129,8 +129,8 @@ pub struct SimpleJITModule { libcall_names: Box<dyn Fn(ir::LibCall) -> String>, memory: M...
1
17
18
844a52e96acc6a02f88e4368b2e8be94f45308bb
bjorn3
2020-11-09T13:53:15
Don't unnecessarily take &self for some ModuleDeclarations methods
diff --git a/cranelift/module/src/module.rs b/cranelift/module/src/module.rs index 7112c1e86..eb4e668b9 100644 --- a/cranelift/module/src/module.rs +++ b/cranelift/module/src/module.rs @@ -29,6 +29,18 @@ impl From<FuncId> for ir::ExternalName { } } +impl FuncId { + /// Get the `FuncId` for the function named...
3
34
30
79f6f72e78612f5ec59b76866f44e28584e422a7
bjorn3
2020-11-09T09:27:59
Remove StackMapSink from SimpleJIT The stack maps are discarded anyway
diff --git a/cranelift/simplejit/src/backend.rs b/cranelift/simplejit/src/backend.rs index 72e49bd02..a436a3cd2 100644 --- a/cranelift/simplejit/src/backend.rs +++ b/cranelift/simplejit/src/backend.rs @@ -5,7 +5,7 @@ use cranelift_codegen::isa::TargetIsa; use cranelift_codegen::settings::Configurable; use cranelift_c...
1
2
20
ffe9de15fc7b8ec273b55161cf995f3d8548ff07
bjorn3
2020-11-09T09:18:43
Enable unreachable_pub lint
diff --git a/cranelift/simplejit/src/lib.rs b/cranelift/simplejit/src/lib.rs index de4509fca..d558b4439 100644 --- a/cranelift/simplejit/src/lib.rs +++ b/cranelift/simplejit/src/lib.rs @@ -4,7 +4,8 @@ missing_docs, trivial_numeric_casts, unused_extern_crates, - unstable_features + unstable_features...
2
8
7
d5d5cba8b252e26933adddb9bf6a235ec67074ad
bjorn3
2020-11-09T09:11:19
Remove SimpleJITProduct All of it's methods now have an equivalent on SimpleJitModule
diff --git a/cranelift/simplejit/examples/simplejit-minimal.rs b/cranelift/simplejit/examples/simplejit-minimal.rs index 7c5df36ee..ae06c07b9 100644 --- a/cranelift/simplejit/examples/simplejit-minimal.rs +++ b/cranelift/simplejit/examples/simplejit-minimal.rs @@ -70,10 +70,10 @@ fn main() { module.clear_context(&...
4
7
59
856f799adef59bfa3cfacab70f316da4088149ad
bjorn3
2020-11-09T09:07:18
Make some things more consistent between define_function and define_function_bytes
diff --git a/cranelift/module/src/module.rs b/cranelift/module/src/module.rs index b1ef1024a..7112c1e86 100644 --- a/cranelift/module/src/module.rs +++ b/cranelift/module/src/module.rs @@ -162,9 +162,6 @@ pub enum ModuleError { /// Indicates an identifier was defined, but was declared as an import #[error("In...
3
22
25
2ca2255a4a5947c7c903896aecc57e1dffde8aeb
bjorn3
2020-11-09T08:51:49
Move CompiledBlob to a new file
diff --git a/cranelift/simplejit/src/backend.rs b/cranelift/simplejit/src/backend.rs index bfde77aa6..8d2b5dd0c 100644 --- a/cranelift/simplejit/src/backend.rs +++ b/cranelift/simplejit/src/backend.rs @@ -1,6 +1,6 @@ //! Defines `SimpleJITModule`. -use crate::memory::Memory; +use crate::{compiled_blob::CompiledBlob,...
3
59
53
d0706e6f715949305f5bf55385a18598b13ceb18
bjorn3
2020-11-09T08:39:36
Merge finalize_function and perform_relocations
diff --git a/cranelift/simplejit/src/backend.rs b/cranelift/simplejit/src/backend.rs index 527aadf0c..bfde77aa6 100644 --- a/cranelift/simplejit/src/backend.rs +++ b/cranelift/simplejit/src/backend.rs @@ -291,13 +291,9 @@ impl SimpleJITModule { } } - fn finalize_function(&mut self, id: FuncId) { + ...
1
11
51
0568f4fb02f68b577653f81f7a62cb6881c67121
Ulrich Weigand
2020-11-09T17:19:33
Support building big-endian objects (#2382) The JIT build_object routine currently rejects building object files for any big-endian platform. However, most of the object builder code works fine for either byte order, with the exception of a small change in the ObjectBuilderTarget::new routine. This patch adds t...
diff --git a/crates/jit/src/object.rs b/crates/jit/src/object.rs index 0f83a8482..f492d645f 100644 --- a/crates/jit/src/object.rs +++ b/crates/jit/src/object.rs @@ -28,10 +28,6 @@ pub(crate) fn build_object( dwarf_sections: Vec<DwarfSection>, ) -> Result<(Object, Vec<ObjectUnwindInfo>), anyhow::Error> { cons...
2
4
9
b326f29885ec0f530230bf550164f805ffb04e41
Ulrich Weigand
2020-11-09T17:14:52
Fix WasmTy/WasmRet on big-endian hosts (#2384) When invoking a WebAssembly routine from Rust code, arguments are stored into an array of u128, and read from a piece of generated trampoline code before calling the compiled target function using the platform ABI calling convention. The WasmTy/WasmRet routines hand...
diff --git a/crates/wasmtime/src/func.rs b/crates/wasmtime/src/func.rs index c053432a3..30c15ab09 100644 --- a/crates/wasmtime/src/func.rs +++ b/crates/wasmtime/src/func.rs @@ -1001,14 +1001,14 @@ unsafe impl WasmTy for i32 { #[inline] unsafe fn load_from_args(ptr: &mut *const u128) -> Self::Abi { - ...
1
12
12
a9d8abbf5357ee0f176af3e1985a6425fb3ffda4
Ulrich Weigand
2020-11-09T16:59:30
Support big-endian hosts with GuestType (#2383) The GuestType trait is used to access data elements in guest memory. According to the WebAssembly spec, those are always stored in little-endian byte order, even on big-endian hosts. Accessing such elements on big-endian hosts therefore requires byte swapping. Fix...
diff --git a/crates/wiggle/src/guest_type.rs b/crates/wiggle/src/guest_type.rs index 7eabd0f02..422c3f239 100644 --- a/crates/wiggle/src/guest_type.rs +++ b/crates/wiggle/src/guest_type.rs @@ -88,7 +88,7 @@ macro_rules! primitives { if ptr.mem().is_borrowed(region) { return Err(Gue...
1
2
2
8dd091219a17a8c6a6e044d9e5500a313e298da5
Alex Crichton
2020-11-09T15:03:36
Update wasm-tools dependencies Brings in fixes for some assorted wast issues.
diff --git a/Cargo.lock b/Cargo.lock index 138db2143..7e22a7d85 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -340,7 +340,7 @@ dependencies = [ "souper-ir", "target-lexicon", "thiserror", - "wast 26.0.1", + "wast 27.0.0", ] [[package]] @@ -542,7 +542,7 @@ dependencies = [ "smallvec", "target-lexicon", "th...
18
48
48
5df5bbbdca53a7a8eb0e6611cf330724a57c8289
bjorn3
2020-11-09T16:33:56
Fix usage of default_libcall_names (#2378) * Fix usage of default_libcall_names * Add basic cranelift-object test It is based on a test with the same name in cranelift-simplejit
diff --git a/Cargo.lock b/Cargo.lock index b9441fb68..138db2143 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -435,6 +435,8 @@ version = "0.68.0" dependencies = [ "anyhow", "cranelift-codegen", + "cranelift-entity", + "cranelift-frontend", "cranelift-module", "log", "object", diff --git a/cranelift/module/src/...
5
209
4
c9e8889d477d12f5373d3f7a0adae61d7487fcff
Andrew Brown
2020-11-09T15:24:59
Update clippy annotation to use latest version (#2375)
diff --git a/cranelift/bforest/src/lib.rs b/cranelift/bforest/src/lib.rs index bc79ffc7d..dc44eabc3 100644 --- a/cranelift/bforest/src/lib.rs +++ b/cranelift/bforest/src/lib.rs @@ -23,8 +23,7 @@ clippy::float_arithmetic, clippy::mut_mut, clippy::nonminimal_bool, - clippy::option_map_un...
24
44
68
12e658a1ef344ccacf872accb0cadd7ef6e8cf4a
Alex Crichton
2020-11-06T22:16:47
Remove an `Arc` holding module code from `InstanceHandle` (#2374) We've generally moved to a model where `InstanceHandle` doesn't hold ownership of its internals, instead relying on the caller to manage that. This removes an allocation on the `Func::wrap` path but otherwise shouldn't have much impact.
diff --git a/crates/jit/src/instantiate.rs b/crates/jit/src/instantiate.rs index 7807c80c3..0d27918f5 100644 --- a/crates/jit/src/instantiate.rs +++ b/crates/jit/src/instantiate.rs @@ -246,7 +246,6 @@ impl CompiledModule { ) -> Result<InstanceHandle, InstantiationError> { InstanceHandle::new( ...
4
6
10
77827a48a924337b3b690d8f35aef0f601af6dde
Alex Crichton
2020-11-06T19:32:30
Start compiling module-linking modules (#2093) This commit is intended to be the first of many in implementing the module linking proposal. At this time this builds on #2059 so it shouldn't land yet. The goal of this commit is to compile bare-bones modules which use module linking, e.g. those with nested modules. ...
diff --git a/cranelift/wasm/src/environ/spec.rs b/cranelift/wasm/src/environ/spec.rs index 06e207e4f..b01cd4376 100644 --- a/cranelift/wasm/src/environ/spec.rs +++ b/cranelift/wasm/src/environ/spec.rs @@ -847,4 +847,31 @@ pub trait ModuleEnvironment<'data>: TargetEnvironment { fn wasm_features(&self) -> WasmFeatur...
17
410
253
8af2dbfbaca499c2453956843dadc849fb583b27
Alex Crichton
2020-11-06T15:56:44
Allow offloading compilation in cranelift-object (#2371) This commit is a slight refactoring of the `Module` trait and backend in `cranelift-object`. The goal is to enable parallelization of compilation when using `cranelift-object`. Currently this is difficult because `ObjectModule::define_function` requires `&mut...
diff --git a/cranelift/module/src/lib.rs b/cranelift/module/src/lib.rs index 9292a9b18..dc16198d5 100644 --- a/cranelift/module/src/lib.rs +++ b/cranelift/module/src/lib.rs @@ -44,7 +44,7 @@ mod traps; pub use crate::data_context::{DataContext, DataDescription, Init}; pub use crate::module::{ DataId, FuncId, Fun...
4
113
125
b2b7bc10e2a6297f85ac0da17384e1f6c09ee111
Yury Delendik
2020-11-06T14:02:45
machinst aarch64: New backend unwind (#2313) * Unwind information for aarch64 backend.
diff --git a/cranelift/codegen/src/isa/aarch64/inst/unwind.rs b/cranelift/codegen/src/isa/aarch64/inst/unwind.rs index 9ea2cb29c..265dd3fb6 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/unwind.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/unwind.rs @@ -1,14 +1,194 @@ use super::*; -use crate::isa::unwind::inpu...
5
381
17
df59ffb1b6ed8688e2fde63678c88dac8058a56a
Andrew Brown
2020-11-05T21:15:24
Align island's worst case size
diff --git a/cranelift/codegen/src/machinst/buffer.rs b/cranelift/codegen/src/machinst/buffer.rs index 1a049250b..0cc9d240b 100644 --- a/cranelift/codegen/src/machinst/buffer.rs +++ b/cranelift/codegen/src/machinst/buffer.rs @@ -1035,7 +1035,8 @@ impl<I: VCodeInst> MachBuffer<I> { ); let deadline = se...
1
2
1
a277cf5ee44ff539bed66fbbb6eecbdc06c8ebde
Alex Crichton
2020-11-05T14:49:03
Store `WasmFuncType` in `FuncType` (#2365) This commit updates `wasmtime::FuncType` to exactly store an internal `WasmFuncType` from the cranelift crates. This allows us to remove a translation layer when we are given a `FuncType` and want to get an internal cranelift type out as a result. The other major change...
diff --git a/crates/c-api/src/types/func.rs b/crates/c-api/src/types/func.rs index 0417e3ac3..1b4ca752f 100644 --- a/crates/c-api/src/types/func.rs +++ b/crates/c-api/src/types/func.rs @@ -54,17 +54,9 @@ pub extern "C" fn wasm_functype_new( params: &mut wasm_valtype_vec_t, results: &mut wasm_valtype_vec_t, )...
13
118
150
ea3306e74c482caf377e1f4e7208e609e3710b60
Alex Crichton
2020-11-05T13:29:04
Use the `psm` crate to figure out the current stack pointer (#2358) Currently the runtime needs to acquire the current stack pointer so it can set a limit for where if the wasm stack goes below that point it will abort the wasm code. Acquiring the stack pointer is done in a brittle way right now which involves look...
diff --git a/Cargo.lock b/Cargo.lock index 6186063dc..24c4b1eb5 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1397,6 +1397,15 @@ dependencies = [ "tempfile", ] +[[package]] +name = "psm" +version = "0.1.11" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "96e0536f6528466dbbbbe6b986c341...
3
23
3
6b137c2a3d35f4fb4602d87ed6a3d7c136e83827
Alex Crichton
2020-11-04T20:22:37
Move native signatures out of `Module` (#2362) After compilation there's actually no need to hold onto the native signature for a wasm function type, so this commit moves out the `ir::Signature` value from a `Module` into a separate field that's deallocated when compilation is finished. This simplifies the `Signat...
diff --git a/crates/cranelift/src/func_environ.rs b/crates/cranelift/src/func_environ.rs index 99ebd0314..1e296015f 100644 --- a/crates/cranelift/src/func_environ.rs +++ b/crates/cranelift/src/func_environ.rs @@ -5,7 +5,7 @@ use cranelift_codegen::ir::immediates::{Offset32, Uimm64}; use cranelift_codegen::ir::types::*...
13
65
66
dd5974654c419466c9b5e7d32c7a35ddc7e691ae
Nick Fitzgerald
2020-11-04T20:00:54
peepmatic: Make the test-we-can-get-and-rebuild peephole optimizers test work on arm64 This change means that running cargo test --features "enable-peepmatic rebuild-peephole-optimizers" inside `cranelift/codegen` will rebuild peephole optimizers on not only x86_64 but also aarch64.
diff --git a/cranelift/codegen/src/peepmatic.rs b/cranelift/codegen/src/peepmatic.rs index bf0f44086..d676dbad9 100644 --- a/cranelift/codegen/src/peepmatic.rs +++ b/cranelift/codegen/src/peepmatic.rs @@ -1312,19 +1312,31 @@ unsafe impl<'a, 'b> InstructionSet<'b> for &'a dyn TargetIsa { } #[cfg(test)] -#[cfg(featur...
1
17
5
0223cb2f8c339cc5e333f6330a9acd047d4c6278
Joey Gouly
2020-11-04T16:53:25
aarch64: Fix aarch64_map_regs for FpuRRI This was wrong since I added it in 02c3f238f. Copyright (c) 2020, Arm Limited.
diff --git a/cranelift/codegen/src/isa/aarch64/inst/mod.rs b/cranelift/codegen/src/isa/aarch64/inst/mod.rs index d18b07c9f..2fef19d57 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/mod.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/mod.rs @@ -2311,11 +2311,15 @@ fn aarch64_map_regs<RUM: RegUsageMapper>(inst: &mut...
1
5
1
fa9c2a51725c60895f7eaef40f00e3b3e3c32933
Ulrich Weigand
2020-11-03T19:54:27
Fix off-by-one error looking up frame info for a function (#2349) The ModuleFrameInfo and FunctionInfo data structures maintain a list of ranges via a BTreeMap. The key to that map is one past the end of the module/function in question. This causes a problem in the case of immediately adjacent ranges. For examp...
diff --git a/crates/wasmtime/src/frame_info.rs b/crates/wasmtime/src/frame_info.rs index 28e7b88d7..d12464be1 100644 --- a/crates/wasmtime/src/frame_info.rs +++ b/crates/wasmtime/src/frame_info.rs @@ -145,8 +145,13 @@ pub fn register(module: &CompiledModule) -> Option<GlobalFrameInfoRegistration> let (start, e...
1
41
1
80c2d70d2d700c39c95398a390abbc9517a5a8f0
Ulrich Weigand
2020-11-03T17:37:51
machinst ABI: Support for accumulating outgoing args When performing a function call, the platform ABI may require space on the stack to hold outgoing arguments and/or return values. Currently, this is supported via decrementing the stack pointer before the call and incrementing it afterwards, using the emit_stack_pr...
diff --git a/cranelift/codegen/src/isa/aarch64/abi.rs b/cranelift/codegen/src/isa/aarch64/abi.rs index 287b570ef..ba9abc5cb 100644 --- a/cranelift/codegen/src/isa/aarch64/abi.rs +++ b/cranelift/codegen/src/isa/aarch64/abi.rs @@ -513,6 +513,7 @@ impl ABIMachineSpec for AArch64MachineDeps { _: &settings::Flags, ...
6
42
4
56caf1b29a9896570463002ca805d72c6a1a593d
Ulrich Weigand
2020-11-03T15:22:20
Add extension marker to i32 arguments of builtin functions Some platform ABIs require i32 values to be zero- or sign-extended to the full register width. The extension is implemented by the cranelift codegen backend, but this happens only if the appropriate "uext" or "sext" attribute is present in the cranelift IR. ...
diff --git a/crates/cranelift/src/func_environ.rs b/crates/cranelift/src/func_environ.rs index efe1e5beb..88d37ab77 100644 --- a/crates/cranelift/src/func_environ.rs +++ b/crates/cranelift/src/func_environ.rs @@ -69,7 +69,16 @@ macro_rules! declare_function_signatures { } fn i32(&self) -> Ab...
1
10
1
c9bc4edd082f21cb3a4b53cdc2ed51531d7f2268
Ulrich Weigand
2020-11-02T12:14:57
machinst ABI: Pass fixed frame size to gen_clobber_restore The ABI common code currently passes the fixed frame size to the gen_clobber_save back-end routine, which is required to emit code to allocate the required stack space in the prologue. Similarly, the back-end needs to emit code to de-allocate the stack in the...
diff --git a/cranelift/codegen/src/isa/aarch64/abi.rs b/cranelift/codegen/src/isa/aarch64/abi.rs index b897352eb..acd8cc88e 100644 --- a/cranelift/codegen/src/isa/aarch64/abi.rs +++ b/cranelift/codegen/src/isa/aarch64/abi.rs @@ -559,6 +559,7 @@ impl ABIMachineSpec for AArch64MachineDeps { call_conv: isa::CallC...
4
12
4
d02ae3940c9c744d59d7cbf14d004d934676e1cd
Ulrich Weigand
2020-11-02T12:07:49
machinst ABI: Allow back-end to define stack alignment The common gen_prologue code currently assumes that the stack pointer has to be aligned to twice the word size. While this is true for many ABIs, it does not hold universally. This patch adds a new callback stack_align that back-ends can provide to define the sp...
diff --git a/cranelift/codegen/src/isa/aarch64/abi.rs b/cranelift/codegen/src/isa/aarch64/abi.rs index b897352eb..6dc3deea4 100644 --- a/cranelift/codegen/src/isa/aarch64/abi.rs +++ b/cranelift/codegen/src/isa/aarch64/abi.rs @@ -152,6 +152,11 @@ impl ABIMachineSpec for AArch64MachineDeps { 64 } + ///...
4
19
1
10b5cc50c37be393c0b8bb20dc68fb8ea6b750e1
Alex Crichton
2020-11-03T02:37:18
Further compress the in-memory representation of address maps (#2324) This commit reduces the size of `InstructionAddressMap` from 24 bytes to 8 bytes by dropping the `code_len` field and reducing `code_offset` to `u32` instead of `usize`. The intention is to primarily make the in-memory version take up less space,...
diff --git a/crates/cranelift/src/lib.rs b/crates/cranelift/src/lib.rs index 8d8df744c..5afb14eb9 100644 --- a/crates/cranelift/src/lib.rs +++ b/crates/cranelift/src/lib.rs @@ -229,19 +229,28 @@ impl StackMapSink { fn get_function_address_map<'data>( context: &Context, data: &FunctionBodyData<'data>, - bo...
5
115
72
bfbe6ea34882a3e4e676070f5970f261f6a37fdf
Nick Fitzgerald
2020-11-02T18:54:03
peepmatic: Update to z3 version 0.7.1 This fixes a memory leak related to custom datatypes: https://github.com/prove-rs/z3.rs/pull/104
diff --git a/Cargo.lock b/Cargo.lock index cde673458..30fca096e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2791,9 +2791,9 @@ dependencies = [ [[package]] name = "z3" -version = "0.7.0" +version = "0.7.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "dbb8ef9d11f50b64327c8a5906b53d3...
2
3
3
38878818005e33a965625da8ab8661ea54ccf818
Alex Crichton
2020-10-25T22:54:21
Refactor how signatures/trampolines are stored in `Store` This commit refactors where trampolines and signature information is stored within a `Store`, namely moving them from `wasmtime_runtime::Instance` instead to `Store` itself. The goal here is to remove an allocation inside of an `Instance` and make them a bit ch...
diff --git a/crates/jit/src/instantiate.rs b/crates/jit/src/instantiate.rs index efc312614..e8b224ebe 100644 --- a/crates/jit/src/instantiate.rs +++ b/crates/jit/src/instantiate.rs @@ -10,7 +10,6 @@ use crate::object::ObjectUnwindInfo; use object::File as ObjectFile; use serde::{Deserialize, Serialize}; use std::any...
14
159
181
35327ed4d7957ac7d93afefd66e24bc3f7883369
Alex Crichton
2020-11-02T14:52:01
Print a message in `log_wat` while fuzzing Similar to `log_wasm`, just indicates that a file was written.
diff --git a/crates/fuzzing/src/oracles.rs b/crates/fuzzing/src/oracles.rs index 550ef77d1..cbd0d9710 100644 --- a/crates/fuzzing/src/oracles.rs +++ b/crates/fuzzing/src/oracles.rs @@ -44,6 +44,7 @@ fn log_wat(wat: &str) { let i = CNT.fetch_add(1, SeqCst); let name = format!("testcase{}.wat", i); + log::...
1
1
0
c32740ffcd44f72d4327be43b44ee565ddd353e5
Johnnie Birch
2020-10-30T23:49:30
Updates comments on Int to Float conversion Int to float for unsigned ints has merged, but there were some comments on a different PR for the same pull request that are addressed in this PR
diff --git a/cranelift/codegen/src/isa/x64/lower.rs b/cranelift/codegen/src/isa/x64/lower.rs index d7c21d292..977011ec5 100644 --- a/cranelift/codegen/src/isa/x64/lower.rs +++ b/cranelift/codegen/src/isa/x64/lower.rs @@ -2298,13 +2298,24 @@ fn lower_insn_to_regs<C: LowerCtx<I = Inst>>( } else { ...
1
12
1
5a09e47e384858f22fbd587900a0229c4dab43cd
Nick Fitzgerald
2020-10-29T17:58:05
peepmatic: update z3 dependency to version 0.7.0
diff --git a/Cargo.lock b/Cargo.lock index 77aff5b00..cde673458 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2791,9 +2791,9 @@ dependencies = [ [[package]] name = "z3" -version = "0.6.0" +version = "0.7.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f0354c65dfe00e08c4ab30581732906...
3
13
13
3cd9d52d32011384ef4cadfd389574c427edcb73
Qinxuan Chen
2020-10-29T14:59:56
Update the hashbrown to use the same version (#2338) Signed-off-by: koushiro <koushiro.cqx@gmail.com>
diff --git a/Cargo.lock b/Cargo.lock index 31e3f5961..0ad42fbdb 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -17,18 +17,9 @@ checksum = "ee2a4ec343196209d6594e19543ae87a39f96d5534d7174822a3ad825dd6ed7e" [[package]] name = "ahash" -version = "0.2.18" -source = "registry+https://github.com/rust-lang/crates.io-index" -...
6
13
61
61f0b8fc56b2399078e3922ebf984c797fe319a7
Alex Crichton
2020-10-27T03:10:57
Remove Windows-specific code for static memory bounds Added in c4e10227de1358d009cf8fb7df55a1c9dfb675d5 I think the original reason (which I'm not entirely knowledgeable of) may no longer be applicable? In any case this is a significant difference on Windows from other platforms because it makes loads/stores of wasm c...
diff --git a/crates/wasmtime/src/runtime.rs b/crates/wasmtime/src/runtime.rs index a72ac18b0..84276484a 100644 --- a/crates/wasmtime/src/runtime.rs +++ b/crates/wasmtime/src/runtime.rs @@ -52,15 +52,6 @@ impl Config { /// Creates a new configuration object with the default configuration /// specified. pu...
1
1
10
6c6d958f38f7c3920e1fe5682bfb3d9345bf6ecf
Andrew Brown
2020-10-28T18:19:41
[machinst x64]: implement packed pmin/pmax
diff --git a/build.rs b/build.rs index 9864d4457..b1dda8abf 100644 --- a/build.rs +++ b/build.rs @@ -199,9 +199,11 @@ fn experimental_x64_should_panic(testsuite: &str, testname: &str, strategy: &str ("simd", "simd_f32x4") => return false, ("simd", "simd_f32x4_arith") => return false, ("simd",...
2
22
5
6725b6b129d2a61a44a8c3d4a79bbc111e8420b2
Andrew Brown
2020-10-28T20:18:20
[machinst x64]: implement bitmask
diff --git a/build.rs b/build.rs index 49f9f81db..9864d4457 100644 --- a/build.rs +++ b/build.rs @@ -182,6 +182,7 @@ fn experimental_x64_should_panic(testsuite: &str, testname: &str, strategy: &str match (testsuite, testname) { ("simd", "simd_address") => return false, ("simd", "simd_bitwise") =>...
5
100
4
5b9a21e0995dc58c010ce38da1c14036c6bef58a
Andrew Brown
2020-10-28T20:43:34
Add missing `SourceLoc` to newly-emitted instructions The changes in https://github.com/bytecodealliance/wasmtime/pull/2278 added `SourceLoc`s to several x64 `Inst` variants; between when that PR was last run in CI and when it was merged, new instructions were added that require this new parameter. This change adds th...
diff --git a/cranelift/codegen/src/isa/x64/inst/emit_tests.rs b/cranelift/codegen/src/isa/x64/inst/emit_tests.rs index 41f4f40a4..728bc09c9 100644 --- a/cranelift/codegen/src/isa/x64/inst/emit_tests.rs +++ b/cranelift/codegen/src/isa/x64/inst/emit_tests.rs @@ -3295,13 +3295,13 @@ fn test_x64_emit() { // ==========...
2
29
6
8bbe6a25a9c62d232c879a69fcbd03b5d95eda58
Johnnie Birch
2020-10-25T18:35:51
Add support for packed float to signed int conversion Implements i32x4.trunc_sat_f32x4_s
diff --git a/cranelift/codegen/src/isa/x64/inst/args.rs b/cranelift/codegen/src/isa/x64/inst/args.rs index 0810bdd90..48bd822d4 100644 --- a/cranelift/codegen/src/isa/x64/inst/args.rs +++ b/cranelift/codegen/src/isa/x64/inst/args.rs @@ -371,6 +371,7 @@ pub enum SseOpcode { Cvtsi2sd, Cvtss2si, Cvtss2sd, +...
4
104
27
97392eae3d2b5e1fed483e737bdf9aa391acf45d
Johnnie Birch
2020-10-16T19:12:07
Adds support for converting packed unsigned integer to packed float
diff --git a/cranelift/codegen/src/isa/x64/lower.rs b/cranelift/codegen/src/isa/x64/lower.rs index 202773b53..237213993 100644 --- a/cranelift/codegen/src/isa/x64/lower.rs +++ b/cranelift/codegen/src/isa/x64/lower.rs @@ -2241,41 +2241,93 @@ fn lower_insn_to_regs<C: LowerCtx<I = Inst>>( let ty = ty.unwrap()...
1
82
30
3461ffa563e635cd7dec00ea5ea46265dfec5537
Alex Crichton
2020-10-28T18:05:05
Remove `source_loc` from `TrapInformation` (#2325) Turns out this wasn't needed anywhere! Additionally we can construct it from `InstructionAddressMap` anyway. There's so many pieces of trap information that it's best to keep these structures small as well.
diff --git a/crates/cranelift/src/lib.rs b/crates/cranelift/src/lib.rs index 58d7d2250..8d8df744c 100644 --- a/crates/cranelift/src/lib.rs +++ b/crates/cranelift/src/lib.rs @@ -195,12 +195,11 @@ impl binemit::TrapSink for TrapSink { fn trap( &mut self, code_offset: binemit::CodeOffset, - s...
3
2
6
bde955579336e124b2c01b3164314bf2d6eec378
Leonardo Yvens
2020-10-27T21:30:45
Add Trap::trap_code (#2309) * add Trap::trap_code * Add non-exhaustive wasmtime::TrapCode * wasmtime: Better document TrapCode * move and refactor test
diff --git a/cranelift/codegen/src/ir/trapcode.rs b/cranelift/codegen/src/ir/trapcode.rs index 612c979a0..3114114f6 100644 --- a/cranelift/codegen/src/ir/trapcode.rs +++ b/cranelift/codegen/src/ir/trapcode.rs @@ -12,9 +12,6 @@ use serde::{Deserialize, Serialize}; #[cfg_attr(feature = "enable-serde", derive(Serialize, ...
4
141
27
f6d5b8772c90d40e0a7a1e0c0885935a04faf2ca
Alex Crichton
2020-10-26T18:22:25
Compress in-memory representation of `FunctionAddressMap` (#2321) This commit compresses `FunctionAddressMap` by performing a simple coalescing of adjacent `InstructionAddressMap` descriptors if they describe the same source location. This is intended to handle the common case where a sequene of machine instruction...
diff --git a/crates/cranelift/src/lib.rs b/crates/cranelift/src/lib.rs index 2da7461cb..58d7d2250 100644 --- a/crates/cranelift/src/lib.rs +++ b/crates/cranelift/src/lib.rs @@ -233,18 +233,16 @@ fn get_function_address_map<'data>( body_len: usize, isa: &dyn isa::TargetIsa, ) -> FunctionAddressMap { - let ...
1
38
16
27233857c534a3ae3e9f8fa3a7a3a0fb563e1f4d
Alex Crichton
2020-10-26T14:52:29
Encode modules with variable-length integers (#2322) Update `Module::{serialize,deserialize}` to use variable-length integers with `bincode` to make the output artifacts smaller. Locally this reduces the size of #2318 from 160 to 110 MB, a 30% decrease in size! Deserialization performance is slightly slower, but se...
diff --git a/crates/wasmtime/src/module.rs b/crates/wasmtime/src/module.rs index 89c4c1288..1b4967dfd 100644 --- a/crates/wasmtime/src/module.rs +++ b/crates/wasmtime/src/module.rs @@ -2,6 +2,7 @@ use crate::frame_info::GlobalFrameInfoRegistration; use crate::runtime::{Config, Engine}; use crate::types::{EntityType, ...
1
16
6
6ebbab61b92de0d79b263469a163cfb88c7e4ae6
Andrew Brown
2020-10-23T16:27:13
Update cfg-if dependency
diff --git a/Cargo.lock b/Cargo.lock index 3a659590e..31e3f5961 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -555,7 +555,7 @@ version = "0.66.0" dependencies = [ "anyhow", "capstone", - "cfg-if 0.1.10", + "cfg-if 1.0.0", "cranelift", "cranelift-codegen", "cranelift-entity", @@ -2092,7 +2092,7 @@ name = "test-...
10
18
18
de4af90af661e4c186c181aeeed41b8b7d60a1ec
Yury Delendik
2020-10-23T20:19:41
machinst x64: New backend unwind (#2266) Addresses unwind for experimental x64 backend. The preliminary code enables backtrace on SystemV call convension.
diff --git a/cranelift/codegen/src/context.rs b/cranelift/codegen/src/context.rs index 842a48ab2..eb4cdf26f 100644 --- a/cranelift/codegen/src/context.rs +++ b/cranelift/codegen/src/context.rs @@ -253,6 +253,14 @@ impl Context { &self, isa: &dyn TargetIsa, ) -> CodegenResult<Option<crate::isa::un...
25
554
29
461ed42772d198cc4c6741d5abc8ce2715e816ce
Alex Crichton
2020-10-21T05:43:47
Remove the `finished_functions` field in `Instance` Turns out we don't actually need it anywhere any more! This removes an allocation when instantiating.
diff --git a/crates/jit/src/instantiate.rs b/crates/jit/src/instantiate.rs index 3320fec25..1062e5127 100644 --- a/crates/jit/src/instantiate.rs +++ b/crates/jit/src/instantiate.rs @@ -14,7 +14,7 @@ use std::collections::HashMap; use std::sync::Arc; use thiserror::Error; use wasmtime_debug::create_gdbjit_image; -use...
3
8
14
04e85b044e395f11b7774d72156f7ec5ba0aa8ba
Alex Crichton
2020-10-21T05:23:35
Don't store `Arc<VMInterrupts>` in instances Similar to other data structures owned by the `Store` there's no need for `Instance` to have a strong `Arc` reference, instead it's sufficient for `Store` to have the owning reference.
diff --git a/crates/jit/src/instantiate.rs b/crates/jit/src/instantiate.rs index 3320fec25..5dfe60313 100644 --- a/crates/jit/src/instantiate.rs +++ b/crates/jit/src/instantiate.rs @@ -250,7 +250,7 @@ impl CompiledModule { imports: Imports<'_>, signature_registry: &mut SignatureRegistry, mem_...
6
9
14
b8794448b01c8e3d2f54fc893dd990c2f398f5e0
Alex Crichton
2020-10-16T15:22:13
Avoid allocations in trampoline shims There's no need to name each export since each synthetic instance we're creating only has one export, so let's use the empty string which doesn't require any allocations.
diff --git a/crates/wasmtime/src/trampoline/func.rs b/crates/wasmtime/src/trampoline/func.rs index 29bf5af08..27545e66e 100644 --- a/crates/wasmtime/src/trampoline/func.rs +++ b/crates/wasmtime/src/trampoline/func.rs @@ -230,7 +230,7 @@ pub fn create_handle_with_function( let func_id = module.functions.push(sig_id...
5
11
11
9820c5c3dd0cdc40163927494c1e82aee79bb927
Johan Andersson
2020-10-17T11:08:59
Replace unmaintained directories crate Fixes RUSTSEC-2020-0054 warning from cargo-audit/cargo-deny, follows the recommendation to switch to the new maintained `directories-next` crate fork Only affects the cache directory determination for the environment and was a simple search'n'replace to this fork so don't think ...
diff --git a/Cargo.lock b/Cargo.lock index 7709f8329..1333da68d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -105,7 +105,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "46254cf2fdcdf1badb5934448c1bcbe046a56537b3987d96c51a7afc5d03f293" dependencies = [ "addr2line", - "cfg-if", + "cfg...
3
46
29
f27c0f3434ee2697d6fce4b28eb351e8f7c9baef
Johnnie Birch
2020-10-14T01:45:27
Adds support for signed packed integer conversion to float f32x4.convert_i32x4_s
diff --git a/cranelift/codegen/src/isa/x64/inst/args.rs b/cranelift/codegen/src/isa/x64/inst/args.rs index 3a2dd0de0..0810bdd90 100644 --- a/cranelift/codegen/src/isa/x64/inst/args.rs +++ b/cranelift/codegen/src/isa/x64/inst/args.rs @@ -364,6 +364,7 @@ pub enum SseOpcode { Cmppd, Cmpss, Cmpsd, + Cvtdq...
4
44
19
4a82f17d91978ba6739d00740f54a3285ccf97f9
Alex Crichton
2020-10-16T15:21:32
Don't allocate a new ISA for each `Func::wrap` Instead we can reuse the existing one in `Store`.
diff --git a/crates/wasmtime/src/trampoline/func.rs b/crates/wasmtime/src/trampoline/func.rs index 29bf5af08..604fe5f37 100644 --- a/crates/wasmtime/src/trampoline/func.rs +++ b/crates/wasmtime/src/trampoline/func.rs @@ -11,14 +11,14 @@ use std::mem; use std::panic::{self, AssertUnwindSafe}; use wasmtime_environ::ent...
1
3
9
f36ceac010cea21fcf6aab96aec4924349e229f7
Andrew Brown
2020-10-15T18:31:04
Fix typo
diff --git a/crates/wasmtime/src/module.rs b/crates/wasmtime/src/module.rs index e51b3bc98..89c4c1288 100644 --- a/crates/wasmtime/src/module.rs +++ b/crates/wasmtime/src/module.rs @@ -299,7 +299,7 @@ impl Module { Ok(buffer) } - /// Deserializes and creates a module from the compilatio nartifacts. +...
1
1
1
3c688458139ff23e51a91bbcf830d1f14a49a612
Yury Delendik
2020-10-15T13:34:50
Cranelift: refactoring of unwind info (#2289) * factor common code * move fde/unwind emit to more abstract level * code_len -> function_size * speedup block scanning * better function_size calciulation * Rename UnwindCode enums
diff --git a/cranelift/codegen/src/ir/function.rs b/cranelift/codegen/src/ir/function.rs index f425eb669..92911c8a5 100644 --- a/cranelift/codegen/src/ir/function.rs +++ b/cranelift/codegen/src/ir/function.rs @@ -94,7 +94,7 @@ pub struct Function { /// The instructions that mark the start (inclusive) of an epilogu...
8
814
392
a26e9e9a20be9e22fb6ab60befd25abde7ae46b8
Andrew Brown
2020-10-13T17:02:50
[machinst x64]: lower load_splat using memory addressing
diff --git a/cranelift/codegen/src/isa/x64/lower.rs b/cranelift/codegen/src/isa/x64/lower.rs index 576b87551..614589d16 100644 --- a/cranelift/codegen/src/isa/x64/lower.rs +++ b/cranelift/codegen/src/isa/x64/lower.rs @@ -3380,18 +3380,30 @@ fn lower_insn_to_regs<C: LowerCtx<I = Inst>>( } } - ...
1
14
2
e0b911a4dfda7fe1d16da1fb1d9ee8eaed97acd7
Anton Kirilov
2020-10-07T10:29:55
Introduce the Cranelift IR instruction `LoadSplat` It corresponds to WebAssembly's `load*_splat` operations, which were previously represented as a combination of `Load` and `Splat` instructions. However, there are architectures such as Armv8-A that have a single machine instruction equivalent to the Wasm operations. ...
diff --git a/cranelift/codegen/meta/src/isa/x86/legalize.rs b/cranelift/codegen/meta/src/isa/x86/legalize.rs index de78c3b3b..681b3104d 100644 --- a/cranelift/codegen/meta/src/isa/x86/legalize.rs +++ b/cranelift/codegen/meta/src/isa/x86/legalize.rs @@ -396,6 +396,7 @@ fn define_simd( let insertlane = insts.by_name...
9
237
75
cb2d180f2a8266477ded2a7de0fc0e8a758f0dc4
bjorn3
2020-10-12T12:06:38
Remove SimpleJIT prefix from some private types
diff --git a/cranelift/simplejit/src/backend.rs b/cranelift/simplejit/src/backend.rs index 06d22dbf1..d14d2cc29 100644 --- a/cranelift/simplejit/src/backend.rs +++ b/cranelift/simplejit/src/backend.rs @@ -126,10 +126,10 @@ pub struct SimpleJITModule { isa: Box<dyn TargetIsa>, symbols: HashMap<String, *const u...
1
12
16