commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
8fce8ddefc975a6cff2d6bdef57665582f620376
Andrew Brown
2020-05-28T03:41:22
[cranelift-interpreter] Add basic floating point arithmetic
diff --git a/cranelift/interpreter/src/interpreter.rs b/cranelift/interpreter/src/interpreter.rs index 3b30c1b15..3d4988096 100644 --- a/cranelift/interpreter/src/interpreter.rs +++ b/cranelift/interpreter/src/interpreter.rs @@ -12,7 +12,7 @@ use cranelift_codegen::ir::{ }; use cranelift_reader::{DataValue, DataValue...
1
5
1
660c45fe34fc0ec8ca5ce899feae368da773bff9
Andrew Brown
2020-05-28T03:34:52
[cranelift-interpreter] Add integer multiplication
diff --git a/cranelift/interpreter/src/interpreter.rs b/cranelift/interpreter/src/interpreter.rs index e2a1d5a8d..3b30c1b15 100644 --- a/cranelift/interpreter/src/interpreter.rs +++ b/cranelift/interpreter/src/interpreter.rs @@ -12,7 +12,7 @@ use cranelift_codegen::ir::{ }; use cranelift_reader::{DataValue, DataValue...
1
3
1
a4e0327128c392dd89c6eac2fea75357cbc7c5c4
Andrew Brown
2020-05-28T03:33:25
[cranelift-interpreter] Remove float types from integer instructions
diff --git a/cranelift/interpreter/src/interpreter.rs b/cranelift/interpreter/src/interpreter.rs index 2a13a0c4c..e2a1d5a8d 100644 --- a/cranelift/interpreter/src/interpreter.rs +++ b/cranelift/interpreter/src/interpreter.rs @@ -150,8 +150,8 @@ impl Interpreter { let arg1 = frame.get(&args[0]); ...
1
4
4
9038f91696c1de8147ad7ea4ab0ef2acdd85456b
Pat Hickey
2020-05-29T19:55:57
wiggle: allow user-configurable error transformations
diff --git a/crates/wiggle/generate/src/config.rs b/crates/wiggle/generate/src/config.rs index 0d4ada640..5b09f9dee 100644 --- a/crates/wiggle/generate/src/config.rs +++ b/crates/wiggle/generate/src/config.rs @@ -1,3 +1,4 @@ +use std::collections::HashMap; use std::path::{Path, PathBuf}; use proc_macro2::Span; @@ -...
8
275
32
ce757f12d12423b42869874f14d810dbe3994166
Dan Gohman
2020-05-28T20:28:05
Linker refactoring (#1773) * Minor code tidying. * Document that `Linker::iter`'s iteration order is arbitrary. * Add a few more tests for `wasmtime::Linker`. * Refactor `Linker::compute_imports`. - Extract the error message generation into a separate function. - In the error message, sort the candidate...
diff --git a/Cargo.lock b/Cargo.lock index 0859dec9b..be772cc0e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2170,6 +2170,7 @@ dependencies = [ "cfg-if", "lazy_static", "libc", + "log", "region", "rustc-demangle", "target-lexicon", diff --git a/crates/wasmtime/Cargo.toml b/crates/wasmtime/Cargo.toml index 8...
5
116
49
2e7b3ba8de3a3349711092526915bd86fd518ce3
Nick Fitzgerald
2020-05-27T19:06:35
cranelift: Implement serialize/deserialize for stack maps When the `enable-serde` feature is set.
diff --git a/cranelift/codegen/src/binemit/stackmap.rs b/cranelift/codegen/src/binemit/stackmap.rs index 10ae96a7c..27d87f896 100644 --- a/cranelift/codegen/src/binemit/stackmap.rs +++ b/cranelift/codegen/src/binemit/stackmap.rs @@ -15,7 +15,8 @@ const NUM_BITS: usize = core::mem::size_of::<Num>() * 8; /// The first v...
2
4
1
caada922e8a272187d31e0cc6af743f27ad0f392
Alex Crichton
2020-05-28T14:06:52
Disable tests for the peepmatic-macro crate I'm not actually sure that it's possible to write `#[test]` in a `proc-macro` crate. Regardless I don't think it's too too conventional, so let's disable this for now. Closes #1775
diff --git a/cranelift/peepmatic/crates/macro/Cargo.toml b/cranelift/peepmatic/crates/macro/Cargo.toml index e13cffd98..560953e0d 100644 --- a/cranelift/peepmatic/crates/macro/Cargo.toml +++ b/cranelift/peepmatic/crates/macro/Cargo.toml @@ -13,3 +13,5 @@ syn = { version = "1.0.16", features = ['extra-traits'] } [lib...
1
2
0
628a9f0eaa8f4302d4ec61f8b944b3c3e08e5265
Andrew Brown
2020-05-27T14:04:46
Print more detailed `test run` failures (#1764)
diff --git a/cranelift/filetests/src/test_run.rs b/cranelift/filetests/src/test_run.rs index 0044779ba..58888bf0f 100644 --- a/cranelift/filetests/src/test_run.rs +++ b/cranelift/filetests/src/test_run.rs @@ -58,7 +58,7 @@ impl SubTest for TestRun { // running x86_64 code on aarch64 platforms. ...
1
1
1
4e016afca37b008c1f4ce15f62a119bbdf74a5d7
Andrew Brown
2020-05-26T15:20:36
Add trace-level logging to interpreter
diff --git a/cranelift/interpreter/src/interpreter.rs b/cranelift/interpreter/src/interpreter.rs index 3caf6e560..3dbbe1d69 100644 --- a/cranelift/interpreter/src/interpreter.rs +++ b/cranelift/interpreter/src/interpreter.rs @@ -11,7 +11,7 @@ use cranelift_codegen::ir::{ Value as ValueRef, ValueList, }; use cran...
1
5
5
ca0c24e346df1b078220bddf840d8abf6b1d0543
Andrew Brown
2020-05-24T03:55:47
Avoid recursion in `Interpreter::block`
diff --git a/cranelift/interpreter/src/interpreter.rs b/cranelift/interpreter/src/interpreter.rs index 2790a78d7..3caf6e560 100644 --- a/cranelift/interpreter/src/interpreter.rs +++ b/cranelift/interpreter/src/interpreter.rs @@ -117,16 +117,20 @@ impl Interpreter { self.block(&mut frame, first_block) } ...
1
8
4
c6191367529b9ccafadcd277ff1297ff8439279c
Ömer Sinan Ağacan
2020-05-24T12:07:50
Remove Eq bound of ReservedValue trait A full Eq implementation is no needed for ReservedValue, as we only need to check whether a value is the reserved one. For entities (defined with `entity_impl!`) this doesn't make much difference, but for more complicated types this avoids generating redundant `Eq`s.
diff --git a/cranelift/entity/src/lib.rs b/cranelift/entity/src/lib.rs index f9062a8c5..4adf4a42c 100644 --- a/cranelift/entity/src/lib.rs +++ b/cranelift/entity/src/lib.rs @@ -85,6 +85,10 @@ macro_rules! entity_impl { fn reserved_value() -> $entity { $entity($crate::__core::u32::MAX) ...
2
18
4
eeb1e141ba36b5470c9ac5bc2d433b7936f241af
bjorn3
2020-05-24T14:53:27
Add some assertions to cranelift_frontend
diff --git a/cranelift/frontend/src/frontend.rs b/cranelift/frontend/src/frontend.rs index bfc0fd232..b45166b38 100644 --- a/cranelift/frontend/src/frontend.rs +++ b/cranelift/frontend/src/frontend.rs @@ -272,6 +272,12 @@ impl<'a> FunctionBuilder<'a> { /// In order to use a variable in a `use_var`, you need to d...
1
12
0
6e7276e48da4763deb67ca288625dffa4110b9dd
Andrew Brown
2020-05-26T03:25:43
Replace single use of `Frame::with_parameters` with `Frame::set_all`
diff --git a/cranelift/interpreter/src/frame.rs b/cranelift/interpreter/src/frame.rs index 21c41c996..367c797c2 100644 --- a/cranelift/interpreter/src/frame.rs +++ b/cranelift/interpreter/src/frame.rs @@ -30,16 +30,6 @@ impl<'a> Frame<'a> { } } - /// Construct a new [Frame] with the given `values` as...
2
2
11
d73cb48c29fa2796553eaf65bfd5aa3b6ef1d35b
Andrew Brown
2020-05-26T03:25:13
Add logging to frame operations
diff --git a/cranelift/interpreter/src/frame.rs b/cranelift/interpreter/src/frame.rs index 751882a32..21c41c996 100644 --- a/cranelift/interpreter/src/frame.rs +++ b/cranelift/interpreter/src/frame.rs @@ -2,6 +2,7 @@ use cranelift_codegen::ir::{Function, Value as ValueRef}; use cranelift_reader::DataValue; +use log...
1
5
0
c92917de15d95d51f931a5d5b7d8abfbe416ba9f
Andrew Brown
2020-05-26T03:36:58
Fix typo in sadd_sat instruction definition
diff --git a/cranelift/codegen/meta/src/shared/instructions.rs b/cranelift/codegen/meta/src/shared/instructions.rs index e5919ff96..3a85f8059 100644 --- a/cranelift/codegen/meta/src/shared/instructions.rs +++ b/cranelift/codegen/meta/src/shared/instructions.rs @@ -2265,7 +2265,7 @@ pub(crate) fn define( This i...
1
1
1
8a928830ac15a608a922e3ba91e785ed7dd110ac
Anton Kirilov
2020-05-01T23:14:24
Enable the wast::Cranelift::spec::simd::simd_store test for AArch64 Copyright (c) 2020, Arm Limited.
diff --git a/build.rs b/build.rs index a6e2b7d8b..28b1ca363 100644 --- a/build.rs +++ b/build.rs @@ -179,7 +179,8 @@ fn ignore(testsuite: &str, testname: &str, strategy: &str) -> bool { _ => (), }, "Cranelift" => match (testsuite, testname) { - // All simd tests are known to fa...
10
168
17
ce5f3e153b117e1aee1832c6e6e0a698f030e57f
Peter Huene
2020-05-21T23:46:30
Only update XMM save unwind operation offsets when using a FP. This commit prevents updating the XMM save unwind operation offsets when a frame pointer is not used, even though currently Cranelift always uses a frame pointer. This will prevent incorrect unwind information in the future when we start omitting frame po...
diff --git a/cranelift/codegen/src/isa/x86/unwind/winx64.rs b/cranelift/codegen/src/isa/x86/unwind/winx64.rs index af7d7b12f..de35fc696 100644 --- a/cranelift/codegen/src/isa/x86/unwind/winx64.rs +++ b/cranelift/codegen/src/isa/x86/unwind/winx64.rs @@ -136,9 +136,12 @@ pub(crate) fn create_unwind_info( assert!(f...
1
5
2
54f9cd255f17a2c212967ca6fc1dfe2d7330b13a
Peter Huene
2020-05-21T22:53:47
Re-enable tests that were excluded due to the previous limitation.
diff --git a/build.rs b/build.rs index 5f9231f3b..a6e2b7d8b 100644 --- a/build.rs +++ b/build.rs @@ -206,18 +206,6 @@ fn ignore(testsuite: &str, testname: &str, strategy: &str) -> bool { ("reference_types", "table_copy_on_imported_tables") => return false, ("reference_types", _) => return true...
1
0
12
2cd5ed1880a2c63a833b8943164c7069c506837b
Peter Huene
2020-05-21T22:51:55
Address code review feedback.
diff --git a/cranelift/codegen/src/isa/x86/abi.rs b/cranelift/codegen/src/isa/x86/abi.rs index bc7eb94f0..c072594b6 100644 --- a/cranelift/codegen/src/isa/x86/abi.rs +++ b/cranelift/codegen/src/isa/x86/abi.rs @@ -537,7 +537,7 @@ fn fastcall_prologue_epilogue(func: &mut ir::Function, isa: &dyn TargetIsa) -> C // ...
2
7
22
bc1f538385aa1f910e22cdd6ead4542ae423fb28
Pat Hickey
2020-05-21T22:47:48
wiggle: fix tests
diff --git a/crates/wiggle/test-helpers/src/lib.rs b/crates/wiggle/test-helpers/src/lib.rs index dfb20f799..40d468a43 100644 --- a/crates/wiggle/test-helpers/src/lib.rs +++ b/crates/wiggle/test-helpers/src/lib.rs @@ -43,14 +43,20 @@ impl Into<Vec<MemArea>> for MemAreas { } #[repr(align(4096))] +struct HostBuffer { ...
1
9
3
561f9e084a01395f84b534c44f98ddf70affcae2
Pat Hickey
2020-05-21T21:21:47
wig: bugfixes (sorry, thought i had tested before committimg)
diff --git a/crates/wasi-common/wig/src/wasi.rs b/crates/wasi-common/wig/src/wasi.rs index ca113250e..579e6f3ca 100644 --- a/crates/wasi-common/wig/src/wasi.rs +++ b/crates/wasi-common/wig/src/wasi.rs @@ -473,7 +473,7 @@ pub fn define_struct_for_wiggle(args: TokenStream) -> TokenStream { //...
1
3
3
26ee986c2f99bb339f171267731f9108890044ab
whitequark
2020-05-21T20:07:05
runtime: handle traps on Windows x32. (#1740)
diff --git a/crates/jit/src/unwind.rs b/crates/jit/src/unwind.rs index 8bb655137..eedb52e14 100644 --- a/crates/jit/src/unwind.rs +++ b/crates/jit/src/unwind.rs @@ -2,6 +2,9 @@ cfg_if::cfg_if! { if #[cfg(all(windows, target_arch = "x86_64"))] { mod winx64; pub use self::winx64::*; + } else if ...
3
33
4
036c8ec8c506c190d7fbf3890d668c950e2493fd
Alex Crichton
2020-05-21T20:06:30
Fix assertion about length/capacity in C API (#1736) I recently saw some [errors] crop up in wasmtime-go's CI, so let's be sure to convert to `Box<[T]>` which guarantees the length/capacity of the vector are equal. [errors]: https://github.com/bytecodealliance/wasmtime-go/runs/694744570
diff --git a/crates/c-api/src/vec.rs b/crates/c-api/src/vec.rs index 8a7d7395a..2952e6553 100644 --- a/crates/c-api/src/vec.rs +++ b/crates/c-api/src/vec.rs @@ -67,8 +67,8 @@ macro_rules! declare_vecs { } impl From<Vec<$elem_ty>> for $name { - fn from(mut vec: Vec<$elem_ty>) -> Self { - ...
1
2
2
d19a09a4be7a244297f5264340812a76f9e73593
Pat Hickey
2020-05-21T19:40:39
wig: wiggle now puts BorrowChecker inside GuestMemory
diff --git a/crates/wasi-common/wig/src/wasi.rs b/crates/wasi-common/wig/src/wasi.rs index 243334c5b..ca113250e 100644 --- a/crates/wasi-common/wig/src/wasi.rs +++ b/crates/wasi-common/wig/src/wasi.rs @@ -467,16 +467,16 @@ pub fn define_struct_for_wiggle(args: TokenStream) -> TokenStream { ...
1
13
13
9f763375deb6b81df81b71f64f50f6bf02853a61
Pat Hickey
2020-05-21T19:38:06
error name change fixup
diff --git a/crates/wasi-common/src/wasi.rs b/crates/wasi-common/src/wasi.rs index 4ab77ec3b..f35055ffa 100644 --- a/crates/wasi-common/src/wasi.rs +++ b/crates/wasi-common/src/wasi.rs @@ -40,7 +40,7 @@ impl From<wiggle::GuestError> for Errno { InFunc { .. } => Self::Inval, InDataField { .. } ...
1
1
1
96d6884d33e39858aa72f275a20c1a6e066c51f8
Pat Hickey
2020-05-21T19:37:14
wiggle: get BorrowChecker from GuestMemory method
diff --git a/crates/wiggle/generate/src/funcs.rs b/crates/wiggle/generate/src/funcs.rs index 2a11a3d49..690ced551 100644 --- a/crates/wiggle/generate/src/funcs.rs +++ b/crates/wiggle/generate/src/funcs.rs @@ -26,7 +26,6 @@ pub fn define_func( let abi_args = quote!( ctx: &#ctx_type, memory...
13
112
128
3920d8c1f3b414884179eae5fc4295d409b02d87
Pat Hickey
2020-05-21T19:22:47
code review fix
diff --git a/crates/wasi-common/src/path.rs b/crates/wasi-common/src/path.rs index 1f27b7a20..fdce7b481 100644 --- a/crates/wasi-common/src/path.rs +++ b/crates/wasi-common/src/path.rs @@ -47,9 +47,6 @@ pub(crate) fn get( // any symlinks we encounter are processed by pushing them on the stack. let mut path_st...
1
0
3
ba82ddcf379012f804f377958526bcb2912b617a
Pat Hickey
2020-05-21T19:14:53
borrow out of handles: change error name and describe behavior in comment
diff --git a/crates/wiggle/src/borrow.rs b/crates/wiggle/src/borrow.rs index 2519f44da..83d96c344 100644 --- a/crates/wiggle/src/borrow.rs +++ b/crates/wiggle/src/borrow.rs @@ -44,8 +44,17 @@ impl BorrowChecker { } #[derive(Debug)] +/// This is a pretty naive way to account for borrows. This datastructure +/// coul...
2
17
3
e5635f4bc98367f68e2d17d37907163ee0c05ee1
whitequark
2020-05-21T18:56:20
winx: do not link directly to ntdll.dll. (#1739) The documentation for RtlNtStatusToDosError explicitly tells to call it via GetProcAddress. The documentation for NtQueryInformationFile does not, but similar considerations apply because there is normally no import library for ntdll. The main reason to use GetPro...
diff --git a/crates/wasi-common/winx/src/ntdll.rs b/crates/wasi-common/winx/src/ntdll.rs index 2948aee79..110c80fa3 100644 --- a/crates/wasi-common/winx/src/ntdll.rs +++ b/crates/wasi-common/winx/src/ntdll.rs @@ -6,7 +6,9 @@ use std::ffi::c_void; use std::os::raw::c_ulong; use std::os::windows::prelude::RawHandle; +...
1
31
6
68f0d2f6d0c84c090b590d3bda60369e7e45eac7
Alex Crichton
2020-05-21T16:02:49
Enable `env_logger` in the C API (#1737) This commit ensures that `env_logger` and `RUST_LOG` are configured to work with the C API.
diff --git a/Cargo.lock b/Cargo.lock index 33dc454f5..0859dec9b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2188,6 +2188,7 @@ name = "wasmtime-c-api" version = "0.16.0" dependencies = [ "anyhow", + "env_logger 0.7.1", "once_cell", "wasi-common", "wasmtime", diff --git a/crates/c-api/Cargo.toml b/crates/c-api...
3
12
0
13e12908a6012b174df15dffbcc075af18e174a6
Chris Fallin
2020-05-20T21:10:56
MachBuffer branch opts: comments approximating a semi-formal correctness proof.
diff --git a/cranelift/codegen/src/machinst/buffer.rs b/cranelift/codegen/src/machinst/buffer.rs index 44fa53045..03b4ab075 100644 --- a/cranelift/codegen/src/machinst/buffer.rs +++ b/cranelift/codegen/src/machinst/buffer.rs @@ -105,6 +105,40 @@ //! (fixups happen at island emission time, at which point latest-branc...
1
319
12
37514b730f154d1ff48d00d458a42956fa22b3ba
Pat Hickey
2020-05-20T19:29:00
wig: alex has convinced me that this BorrowChecker creation is correct
diff --git a/crates/wasi-common/wig/src/wasi.rs b/crates/wasi-common/wig/src/wasi.rs index 0a0acf60f..243334c5b 100644 --- a/crates/wasi-common/wig/src/wasi.rs +++ b/crates/wasi-common/wig/src/wasi.rs @@ -468,12 +468,10 @@ pub fn define_struct_for_wiggle(args: TokenStream) -> TokenStream { ...
1
4
6
b130a64d195e2d2970766aecd279fc6dfdb327a5
Pat Hickey
2020-05-20T16:43:49
wasi-common fixes
diff --git a/crates/wasi-common/src/snapshots/wasi_snapshot_preview1.rs b/crates/wasi-common/src/snapshots/wasi_snapshot_preview1.rs index 8de648de5..49ae8270e 100644 --- a/crates/wasi-common/src/snapshots/wasi_snapshot_preview1.rs +++ b/crates/wasi-common/src/snapshots/wasi_snapshot_preview1.rs @@ -215,7 +215,7 @@ imp...
2
36
26
04fb4acc6a0850ab51fc6d1b4d7d1623ce078092
Pat Hickey
2020-05-20T01:13:20
wasi-common: WIP translating to use automated borrow checking
diff --git a/crates/wasi-common/src/path.rs b/crates/wasi-common/src/path.rs index f5399a7b7..1f27b7a20 100644 --- a/crates/wasi-common/src/path.rs +++ b/crates/wasi-common/src/path.rs @@ -3,7 +3,7 @@ use crate::handle::{Handle, HandleRights}; use crate::wasi::{types, Errno, Result}; use std::path::{Component, Path};...
2
34
67
3643f2d164ff56ed5ff514e781771152cbe58448
Pat Hickey
2020-05-20T01:13:02
wig: create a BorrowChecker just to get things compiling. Needs fixing.
diff --git a/crates/wasi-common/wig/src/wasi.rs b/crates/wasi-common/wig/src/wasi.rs index 39e263c7a..0a0acf60f 100644 --- a/crates/wasi-common/wig/src/wasi.rs +++ b/crates/wasi-common/wig/src/wasi.rs @@ -468,9 +468,17 @@ pub fn define_struct_for_wiggle(args: TokenStream) -> TokenStream { ...
1
8
0
056a7d07298f85121a57f78fbe028e816ad97801
Pat Hickey
2020-05-20T00:35:16
wiggle: redo docs for auto borrow checking
diff --git a/crates/wiggle/src/lib.rs b/crates/wiggle/src/lib.rs index 1901bfa9d..45479c864 100644 --- a/crates/wiggle/src/lib.rs +++ b/crates/wiggle/src/lib.rs @@ -53,37 +53,24 @@ pub use region::Region; /// must be "somehow nonzero in length" to allow users of `GuestMemory` and /// `GuestPtr` to safely read and wri...
1
51
73
c30194dfa1f49036fe9b95517b85bf0062bdba55
Pat Hickey
2020-05-19T20:27:43
document BorrowChecker, make creation unsafe
diff --git a/crates/wiggle/src/borrow.rs b/crates/wiggle/src/borrow.rs index 992ecddeb..2519f44da 100644 --- a/crates/wiggle/src/borrow.rs +++ b/crates/wiggle/src/borrow.rs @@ -11,23 +11,36 @@ pub struct BorrowChecker { } impl BorrowChecker { - pub fn new() -> Self { + /// A `BorrowChecker` manages run-time v...
10
49
27
a4c1079b50c7a66aac1e4bb03d4c652365774549
Pat Hickey
2020-05-19T02:15:04
borrow checker: add method to check that its empty
diff --git a/crates/wiggle/src/borrow.rs b/crates/wiggle/src/borrow.rs index 61851e8f5..992ecddeb 100644 --- a/crates/wiggle/src/borrow.rs +++ b/crates/wiggle/src/borrow.rs @@ -25,6 +25,9 @@ impl BorrowChecker { pub fn is_borrowed(&self, r: Region) -> bool { self.bc.borrow().is_borrowed(r) } + pub...
1
7
0
d221a3a3469ba7a4776ebd4e0ba6144e550d6943
Pat Hickey
2020-05-19T02:12:55
faster path for borrow-checking GuestPtr::{read, write}
diff --git a/crates/wiggle/src/borrow.rs b/crates/wiggle/src/borrow.rs index c08ffea17..61851e8f5 100644 --- a/crates/wiggle/src/borrow.rs +++ b/crates/wiggle/src/borrow.rs @@ -22,6 +22,9 @@ impl BorrowChecker { pub fn unborrow(&self, h: BorrowHandle) { self.bc.borrow_mut().unborrow(h) } + pub fn ...
2
14
8
be1df80c1b95dbbf2facfaa963b87e0d0a03c213
Pat Hickey
2020-05-19T02:08:23
wasi test: update explanation of safety
diff --git a/crates/wiggle/tests/wasi.rs b/crates/wiggle/tests/wasi.rs index 6e0442862..823d5f84d 100644 --- a/crates/wiggle/tests/wasi.rs +++ b/crates/wiggle/tests/wasi.rs @@ -142,17 +142,16 @@ impl<'a> crate::wasi_snapshot_preview1::WasiSnapshotPreview1 for WasiCtx<'a> { // for efficient implementation of th...
1
3
4
478cc68082ae4f69581315e129637d3f95ad1327
Pat Hickey
2020-05-19T02:03:51
wiggle: GuestType read and write must borrow
diff --git a/crates/wiggle/src/guest_type.rs b/crates/wiggle/src/guest_type.rs index 6cc1a877a..a4a497c02 100644 --- a/crates/wiggle/src/guest_type.rs +++ b/crates/wiggle/src/guest_type.rs @@ -1,4 +1,4 @@ -use crate::{GuestError, GuestPtr}; +use crate::{region::Region, GuestError, GuestPtr}; use std::mem; /// A tra...
1
21
9
73602c6bfe2922052e436a208e276e1f4ef8ead3
Pat Hickey
2020-05-19T01:56:30
borrow checker: reset index when empty, handle oom
diff --git a/crates/wiggle/src/borrow.rs b/crates/wiggle/src/borrow.rs index dddf86391..c08ffea17 100644 --- a/crates/wiggle/src/borrow.rs +++ b/crates/wiggle/src/borrow.rs @@ -17,10 +17,7 @@ impl BorrowChecker { } } pub fn borrow(&self, r: Region) -> Result<BorrowHandle, GuestError> { - self....
2
23
17
52e8300f01e890b407f12ecc4cd669111fc14909
Pat Hickey
2020-05-18T18:45:12
wiggle: automate borrow checking, explicitly passing borrow checker throughout
diff --git a/crates/wiggle/generate/src/funcs.rs b/crates/wiggle/generate/src/funcs.rs index 6bb5beed4..2a11a3d49 100644 --- a/crates/wiggle/generate/src/funcs.rs +++ b/crates/wiggle/generate/src/funcs.rs @@ -24,7 +24,9 @@ pub fn define_func( }); let abi_args = quote!( - ctx: &#ctx_type, memory: ...
14
312
190
80ab154d04527a4df9b5ccb88250a24e349a4b00
Chris Fallin
2020-05-20T19:35:36
Update from review comments.
diff --git a/cranelift/codegen/src/machinst/buffer.rs b/cranelift/codegen/src/machinst/buffer.rs index 695e13c4f..44fa53045 100644 --- a/cranelift/codegen/src/machinst/buffer.rs +++ b/cranelift/codegen/src/machinst/buffer.rs @@ -162,10 +162,20 @@ pub struct MachBuffer<I: VCodeInst> { /// Latest branches, to facili...
1
39
12
348be6f3ed7c52bf9038e49a04da3aa89d0f56f7
Jakub Konka
2020-05-20T19:02:24
Revert fstatat on *nix and test symlinks in path_filestat calls (#1725) * Revert fstatat on *nix and test symlinks in path_filestat calls This commit effectively reverts too eager refactoring on my part which resulted in incorrect `path_filestat_{get, set_times}` behaviour on *nix hosts. In the presence of symlin...
diff --git a/crates/test-programs/wasi-tests/src/bin/path_filestat.rs b/crates/test-programs/wasi-tests/src/bin/path_filestat.rs index af9d19621..bef9ff029 100644 --- a/crates/test-programs/wasi-tests/src/bin/path_filestat.rs +++ b/crates/test-programs/wasi-tests/src/bin/path_filestat.rs @@ -55,31 +55,20 @@ unsafe fn t...
7
202
42
f28b3738ee23850d18696bd7230a6eee7da283ac
Nick Fitzgerald
2020-05-20T18:55:30
Rename `anyref` to `externref` across the board
diff --git a/crates/c-api/macros/src/lib.rs b/crates/c-api/macros/src/lib.rs index 91ec70253..304b95c4e 100644 --- a/crates/c-api/macros/src/lib.rs +++ b/crates/c-api/macros/src/lib.rs @@ -72,17 +72,17 @@ pub fn declare_ref(input: proc_macro::TokenStream) -> proc_macro::TokenStream { #[no_mangle] pu...
25
151
130
1f620e1b465c09a7d7bfd22288d454ef81e35e08
Benjamin Bouvier
2020-05-20T11:31:02
cranelift: bump regalloc.rs to 0.0.24 and adapt to latest API changes;
diff --git a/Cargo.lock b/Cargo.lock index 4be5e4c19..33dc454f5 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1640,9 +1640,9 @@ dependencies = [ [[package]] name = "regalloc" -version = "0.0.23" +version = "0.0.24" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "b36727ea09f6e363ddebb29...
6
21
21
e11094b28bad41ddc6dd3832e85afe4dd16a3578
Chris Fallin
2020-05-20T01:01:53
Fix MachBuffer branch optimization. This patch fixes a subtle bug that occurred in the MachBuffer branch optimization: in tracking labels at the current buffer tail using a sorted-by-offset array, the code did not update this array properly when redirecting labels. As a result, the dead-branch removal was unsafe, beca...
diff --git a/cranelift/codegen/src/isa/aarch64/inst/emit.rs b/cranelift/codegen/src/isa/aarch64/inst/emit.rs index aa6727b97..0e6dcdb1f 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/emit.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/emit.rs @@ -1163,17 +1163,13 @@ impl MachInstEmit for Inst { } ...
3
103
71
9d2100e54a137c79943cf991a9f7b07b011177e2
Nick Fitzgerald
2020-05-19T16:09:07
Limit the size of automaton keys in the `peepmatic_simple_automata` fuzz target Fixes https://oss-fuzz.com/testcase-detail/5742905129172992
diff --git a/cranelift/peepmatic/crates/fuzzing/src/automata.rs b/cranelift/peepmatic/crates/fuzzing/src/automata.rs index b4f88c44b..21fe5c5fd 100644 --- a/cranelift/peepmatic/crates/fuzzing/src/automata.rs +++ b/cranelift/peepmatic/crates/fuzzing/src/automata.rs @@ -17,6 +17,8 @@ where bincode::deserialize(&enco...
1
15
5
28d6df0db6df0dc083eaea6b29b8fe1773eef5ff
Nick Fitzgerald
2020-05-19T02:27:00
Limit the size of automaton keys in the `peepmatic_fst_diff` fuzz target (#1724) This should avoid timeouts caused by large keys. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22251
diff --git a/cranelift/peepmatic/crates/fuzzing/src/automata.rs b/cranelift/peepmatic/crates/fuzzing/src/automata.rs index c399da037..b4f88c44b 100644 --- a/cranelift/peepmatic/crates/fuzzing/src/automata.rs +++ b/cranelift/peepmatic/crates/fuzzing/src/automata.rs @@ -109,7 +109,11 @@ pub fn simple_automata(input_outpu...
1
5
1
bdd2873c8ce3eb48caf58c2f4921537e270e0dc9
Chris Fallin
2020-05-18T22:40:17
Address review comments.
diff --git a/cranelift/codegen/src/isa/aarch64/inst/emit.rs b/cranelift/codegen/src/isa/aarch64/inst/emit.rs index 2d5ecd406..aa6727b97 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/emit.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/emit.rs @@ -352,6 +352,13 @@ impl MachInstEmit for Inst { type State = Emi...
7
313
89
687aca00fe77fb657de05299df4e422d99f0b2c5
Chris Fallin
2020-05-17T23:22:35
Update x64 backend to use new lowering APIs.
diff --git a/cranelift/codegen/src/isa/mod.rs b/cranelift/codegen/src/isa/mod.rs index d193936a9..f7f033965 100644 --- a/cranelift/codegen/src/isa/mod.rs +++ b/cranelift/codegen/src/isa/mod.rs @@ -77,8 +77,8 @@ mod riscv; #[cfg(feature = "x86")] mod x86; -//#[cfg(feature = "x64")] -//mod x64; +#[cfg(feature = "x64"...
8
201
299
e9ef8ea3d59eac0123c727cd6f666b0c7c1b06ce
Nick Fitzgerald
2020-05-14T18:08:59
peepmatic: remove unused member from `PeepholeOptimizer` This is dead code, left over from an earlier design.
diff --git a/cranelift/peepmatic/crates/runtime/src/optimizations.rs b/cranelift/peepmatic/crates/runtime/src/optimizations.rs index ff838ff72..50cf93184 100644 --- a/cranelift/peepmatic/crates/runtime/src/optimizations.rs +++ b/cranelift/peepmatic/crates/runtime/src/optimizations.rs @@ -65,7 +65,6 @@ impl PeepholeOpti...
2
0
5
1e3a1fa372abdaf70af15e64ea3219e3ec801105
Alex Crichton
2020-05-14T15:26:09
Remove stray debugging printlns (#1698) Forgot to do this earlier!
diff --git a/crates/c-api/src/table.rs b/crates/c-api/src/table.rs index 21fe1a7ae..ab4ae3ff2 100644 --- a/crates/c-api/src/table.rs +++ b/crates/c-api/src/table.rs @@ -70,7 +70,6 @@ pub extern "C" fn wasmtime_funcref_table_new( which: ExternHost::Table(HostRef::new(table)), }, ...
1
0
2
c093dee79e1f2f035e7f1251d565a1cd2fd03ad0
Nick Fitzgerald
2020-05-14T14:49:56
cranelift: Let lifetime elision elide lifetimes
diff --git a/cranelift/codegen/src/simple_preopt.rs b/cranelift/codegen/src/simple_preopt.rs index 7413b01e9..2f47c7d91 100644 --- a/cranelift/codegen/src/simple_preopt.rs +++ b/cranelift/codegen/src/simple_preopt.rs @@ -1019,11 +1019,7 @@ mod simplify { } /// The main pre-opt pass. -pub fn do_preopt<'func, 'isa>( ...
1
1
5
923a73be7b6f9107cb0258fb53f731aaf44dd1f6
Nick Fitzgerald
2020-05-12T19:22:40
deps: Bump `z3` to 0.5.1 This fixes Windows builds.
diff --git a/Cargo.lock b/Cargo.lock index f9509a257..0a9e38fd6 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2589,9 +2589,9 @@ dependencies = [ [[package]] name = "z3" -version = "0.5.0" +version = "0.5.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "afd636f549e919f8058567000156e19...
2
5
5
8d7ed0fd139a8905efd94d891cb087d77222834d
Nick Fitzgerald
2020-05-08T22:12:39
deps: Update `wast` to 15.0.0 This also updates `wat` in the lockfile so that the SIMD spec tests are passing again.
diff --git a/Cargo.lock b/Cargo.lock index 99373b1fa..f9509a257 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1262,7 +1262,7 @@ dependencies = [ "peepmatic-automata", "peepmatic-macro", "peepmatic-runtime", - "wast 13.0.0", + "wast 15.0.0", "z3", ] @@ -1288,7 +1288,7 @@ dependencies = [ "peepmatic-test", ...
4
9
18
22a070ed4f2b893ee21f01552bd7affe380fecf1
Nick Fitzgerald
2020-05-08T20:47:14
peepmatic: Apply some review suggestions from @bjorn3
diff --git a/cranelift/codegen/src/peepmatic.rs b/cranelift/codegen/src/peepmatic.rs index ba9aeb38d..1ea2031bf 100644 --- a/cranelift/codegen/src/peepmatic.rs +++ b/cranelift/codegen/src/peepmatic.rs @@ -196,7 +196,7 @@ fn const_to_value<'a>(builder: impl InstBuilder<'a>, c: Constant, root: Inst) -> Constant:...
4
181
219
fd4f08e75f6dd68a629fd4ac0d6375b6a0930446
Nick Fitzgerald
2020-05-08T19:24:53
peepmatic: rustfmt
diff --git a/cranelift/peepmatic/crates/automata/src/serde_impls.rs b/cranelift/peepmatic/crates/automata/src/serde_impls.rs index f7543626e..8a5d79214 100644 --- a/cranelift/peepmatic/crates/automata/src/serde_impls.rs +++ b/cranelift/peepmatic/crates/automata/src/serde_impls.rs @@ -155,27 +155,52 @@ where ...
2
33
6
eb2dab0aa4eefb42f863928f1c56196ac265ca12
Nick Fitzgerald
2020-05-07T21:14:21
peepmatic: Save RHS actions as a boxed slice, not vec A boxed slice is only two words, while a vec is three words. This should cut down on the memory size of our automata and improve cache usage.
diff --git a/cranelift/peepmatic/crates/automata/src/output_impls.rs b/cranelift/peepmatic/crates/automata/src/output_impls.rs index 6701f7d86..308c466d5 100644 --- a/cranelift/peepmatic/crates/automata/src/output_impls.rs +++ b/cranelift/peepmatic/crates/automata/src/output_impls.rs @@ -57,6 +57,43 @@ where } } ...
4
44
7
4b16a4ad85588124022dcaa11a93be93e6edf17b
Nick Fitzgerald
2020-05-01T23:17:43
peepmatic: Define fuzz targets for various parts of `peepmatic`
diff --git a/fuzz/Cargo.toml b/fuzz/Cargo.toml index 38fa092d5..f6ed67ac8 100644 --- a/fuzz/Cargo.toml +++ b/fuzz/Cargo.toml @@ -14,6 +14,7 @@ cranelift-reader = { path = "../cranelift/reader" } cranelift-wasm = { path = "../cranelift/wasm" } libfuzzer-sys = "0.3.2" target-lexicon = "0.10" +peepmatic-fuzzing = { pat...
6
70
0
1a7670f964afe763c285110d544ccdadd083136f
Nick Fitzgerald
2020-05-01T22:47:47
peepmatic: Introduce the `peepmatic-fuzzing` crate This crate contains oracles, generators, and fuzz targets for use with fuzzing engines (e.g. libFuzzer). This doesn't contain the actual `libfuzzer_sys::fuzz_target!` definitions (those are in the `peepmatic-fuzz` crate) but does those definitions are one liners calli...
diff --git a/cranelift/peepmatic/crates/fuzzing/Cargo.toml b/cranelift/peepmatic/crates/fuzzing/Cargo.toml new file mode 100644 index 000000000..5e36dcc6a --- /dev/null +++ b/cranelift/peepmatic/crates/fuzzing/Cargo.toml @@ -0,0 +1,22 @@ +[package] +name = "peepmatic-fuzzing" +version = "0.1.0" +authors = ["Nick Fitzge...
6
802
0
2828da1f5603e226345c82ec540d01d518d1572f
Nick Fitzgerald
2020-05-01T22:45:01
peepmatic: Introduce the `peepmatic-test` crate This crate provides testing utilities for `peepmatic`, and a test-only instruction set we can use to check that various optimizations do or don't apply.
diff --git a/cranelift/peepmatic/crates/test/Cargo.toml b/cranelift/peepmatic/crates/test/Cargo.toml new file mode 100644 index 000000000..bca85f8bf --- /dev/null +++ b/cranelift/peepmatic/crates/test/Cargo.toml @@ -0,0 +1,14 @@ +[package] +name = "peepmatic-test" +version = "0.1.0" +authors = ["Nick Fitzgerald <fitzge...
3
938
0
0f03a974759a866eea9994262e0170f51f2ed241
Nick Fitzgerald
2020-05-01T22:33:55
peepmatic: Introduce the `peepmatic-macro` crate This crate provides the derive macros used by `peepmatic`, notable AST-related derives that enumerate child AST nodes, and operator-related derives that provide helpers for type checking.
diff --git a/cranelift/peepmatic/crates/macro/Cargo.toml b/cranelift/peepmatic/crates/macro/Cargo.toml new file mode 100644 index 000000000..e13cffd98 --- /dev/null +++ b/cranelift/peepmatic/crates/macro/Cargo.toml @@ -0,0 +1,15 @@ +[package] +name = "peepmatic-macro" +version = "0.1.0" +authors = ["Nick Fitzgerald <fi...
6
679
0
f418b7a7006842437e75a584e353cdd6fc59d93d
Joey Gouly
2020-05-14T14:45:55
Reduce arm64 Inst enum size This reduces the size of the Inst enum from 112 bytes to 48 bytes. Using DHAT on a regex-rs.wasm benchmark, `valgrind --tool=dhat clif-util compile --target aarch64` The total number of allocated bytes, drops by around 170 MB. At t-gmax drops by 3 MB. Using `perf stat clif-util compile -...
diff --git a/cranelift/codegen/src/isa/aarch64/abi.rs b/cranelift/codegen/src/isa/aarch64/abi.rs index e58a7d989..d90c23421 100644 --- a/cranelift/codegen/src/isa/aarch64/abi.rs +++ b/cranelift/codegen/src/isa/aarch64/abi.rs @@ -68,6 +68,7 @@ use crate::isa::aarch64::{self, inst::*}; use crate::machinst::*; use crate...
5
41
31
5987cf5cda3d80f269d6a6ff8f722129d591f816
Benjamin Bouvier
2020-05-12T12:37:54
machinst: add a linear-scan checked variant too;
diff --git a/cranelift/codegen/meta/src/shared/settings.rs b/cranelift/codegen/meta/src/shared/settings.rs index becfbd245..3d1538789 100644 --- a/cranelift/codegen/meta/src/shared/settings.rs +++ b/cranelift/codegen/meta/src/shared/settings.rs @@ -25,11 +25,14 @@ pub(crate) fn define() -> SettingGroup { - `ex...
2
6
0
07c55fa50f214258817ec924a79404370a8321c8
Benjamin Bouvier
2020-05-12T12:22:53
aarch64: suggest a scratch register that's not caller-saved; If the scratch register is caller-saved, then it might appear in fixed ranges because of call clobbers. Instead, use a register that's not caller-saved and has no predefined use in the ABI.
diff --git a/cranelift/codegen/src/isa/aarch64/inst/regs.rs b/cranelift/codegen/src/isa/aarch64/inst/regs.rs index 3a10231ed..099d81626 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/regs.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/regs.rs @@ -206,7 +206,7 @@ pub fn create_reg_universe(flags: &settings::Flags)...
1
1
1
5394b6c72e23384da775fcf561f5c27b7e7fc915
SlightlyOutOfPhase
2020-05-11T14:22:06
Update staticvec dependency from 0.8 to 0.9 (#1676) * Update staticvec dependency from 0.8 to 0.9 * Update lockfile also
diff --git a/Cargo.lock b/Cargo.lock index 71798731d..e9d45ebf0 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1759,9 +1759,9 @@ checksum = "dba1a27d3efae4351c8051072d619e3ade2820635c3958d826bfea39d59b54c8" [[package]] name = "staticvec" -version = "0.8.9" +version = "0.9.2" source = "registry+https://github.com/rus...
2
3
3
94190d57244b26baf36629c88104b0ba516510cf
Julian Seward
2020-05-11T09:09:40
cranelift/reader/src/parser.rs: fn parse_inst_resuts: produce the results as a SmallVec<[Value; 1]>, not as a Vec<Value>. This isn't a useful change for any non-developer use of Cranelift, but it does significantly reduce the amount of allocation "noise" seen when tuning the new backend pipeline as driven by clif-util...
diff --git a/Cargo.lock b/Cargo.lock index 52c8ef1b8..71798731d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -489,6 +489,7 @@ name = "cranelift-reader" version = "0.63.0" dependencies = [ "cranelift-codegen", + "smallvec", "target-lexicon", "thiserror", ] diff --git a/cranelift/reader/Cargo.toml b/cranelift/rea...
3
5
2
23314037416a77456f2519320d76f2ec4869224b
whitequark
2020-04-28T13:08:01
Extend X86 ABI to cover stack overflow checking on X86-32. In stark contrast with every reasonable architecture, X86-32 does not pass any parameters in registers. Because of that we have to resort to reading arguments from stack without being able to use the stack slot machinery. (This wouldn't have been avoidable ev...
diff --git a/cranelift/codegen/src/isa/x86/abi.rs b/cranelift/codegen/src/isa/x86/abi.rs index 3e353229c..85ecb0c2a 100644 --- a/cranelift/codegen/src/isa/x86/abi.rs +++ b/cranelift/codegen/src/isa/x86/abi.rs @@ -649,6 +649,14 @@ fn system_v_prologue_epilogue(func: &mut ir::Function, isa: &dyn TargetIsa) -> C //...
1
62
7
a1dbeee062b922e044c859bfb1f227fa568828df
whitequark
2020-04-28T13:11:34
Implement X86CallPCRel4 relocations in the JIT linker. All calls inside a module are relocated with these.
diff --git a/crates/jit/src/link.rs b/crates/jit/src/link.rs index 770d61ea7..6918b2d4b 100644 --- a/crates/jit/src/link.rs +++ b/crates/jit/src/link.rs @@ -94,9 +94,14 @@ fn apply_reloc( write_unaligned(reloc_address as *mut u32, reloc_delta_u32); }, #[cfg(target_pointer_width = "32")] -...
1
8
3
736766397e08c33881a4c45b33085ae293f39f40
whitequark
2020-04-28T13:10:48
Remove the last hardcoded instance of I64 pointers, in wasmtime-api.
diff --git a/crates/api/src/types.rs b/crates/api/src/types.rs index 5b3513f6b..8bf966a04 100644 --- a/crates/api/src/types.rs +++ b/crates/api/src/types.rs @@ -222,7 +222,7 @@ impl FuncType { /// or `None` if one of the types/results wasn't supported or compatible /// with cranelift. pub(crate) fn get_w...
1
5
2
b3a98824664b62d2f3faf2cb2146cfa176090377
whitequark
2020-04-28T13:13:42
Add X86-32 support to wasm-runtime trap handler.
diff --git a/crates/runtime/src/traphandlers.rs b/crates/runtime/src/traphandlers.rs index 9ec38ba87..aaf6f8a58 100644 --- a/crates/runtime/src/traphandlers.rs +++ b/crates/runtime/src/traphandlers.rs @@ -158,6 +158,9 @@ cfg_if::cfg_if! { if #[cfg(all(target_os = "linux", target_arch = "x86_64"))] { ...
1
3
0
17cef9140c8510bdeb1f09d5bc46bb340c0fc9e3
Chris Fallin
2020-05-08T20:36:39
MachInst backend: don't reallocate RealRegUniverses for each function compilation. This saves ~0.14% instruction count, ~0.18% allocated bytes, and ~1.5% allocated blocks on a `clif-util wasm` compilation of `bz2.wasm` for aarch64.
diff --git a/cranelift/codegen/src/isa/aarch64/inst/mod.rs b/cranelift/codegen/src/isa/aarch64/inst/mod.rs index 14a9a7b6b..d852d81f5 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/mod.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/mod.rs @@ -1903,10 +1903,6 @@ impl MachInst for Inst { _ => {} ...
6
28
26
0bc0503f3f6c6cfe8dfc7c46e185db26f8ac494f
Julian Seward
2020-05-06T07:08:14
Add a transformation pass which removes phi nodes to which it can demonstrate that only one value ever flows. Has been observed to improve generated code run times by up to 8%. Compilation cost increases by about 0.6%, but up to 7% total cost has been observed to be saved; iow it can be a significant win in terms of ...
diff --git a/cranelift/codegen/src/context.rs b/cranelift/codegen/src/context.rs index d233946a6..2c4ce6b49 100644 --- a/cranelift/codegen/src/context.rs +++ b/cranelift/codegen/src/context.rs @@ -27,6 +27,7 @@ use crate::nan_canonicalization::do_nan_canonicalization; use crate::postopt::do_postopt; use crate::redund...
4
408
0
b65bd1c8a25039ebe932f6199314954c4e6f75a9
Andrew Brown
2020-04-21T19:02:44
Add an `interpret` command to clif-util
diff --git a/Cargo.lock b/Cargo.lock index 9b920dfae..52c8ef1b8 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -536,6 +536,7 @@ dependencies = [ "cranelift-faerie", "cranelift-filetests", "cranelift-frontend", + "cranelift-interpreter", "cranelift-module", "cranelift-native", "cranelift-object", @@ -547,10 +54...
4
185
0
9cf90b836b294c37e812edc21b561c55c5d83783
Andrew Brown
2020-04-21T19:02:18
Move `iterate_files` to the utils module
diff --git a/cranelift/src/run.rs b/cranelift/src/run.rs index 45c9d00c2..e54d56ed2 100644 --- a/cranelift/src/run.rs +++ b/cranelift/src/run.rs @@ -1,13 +1,12 @@ //! CLI tool to compile Cranelift IR files to native code in memory and execute them. -use crate::utils::read_to_string; +use crate::utils::{iterate_files...
2
26
26
b4238229c2b163b9de5bd16483d7a3842a41e3c5
Andrew Brown
2020-04-21T18:53:50
Cast DataValues to and from native types Also, returns a `Result` in the `RunCommand::run` helper.
diff --git a/Cargo.lock b/Cargo.lock index e775b2511..0a4594c3c 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -474,6 +474,7 @@ version = "0.63.0" dependencies = [ "cranelift-codegen", "target-lexicon", + "thiserror", ] [[package]] diff --git a/cranelift/filetests/src/test_run.rs b/cranelift/filetests/src/test_ru...
6
91
26
528d3c135594e59197a8d38acd201d13f5762084
Benjamin Bouvier
2020-05-06T17:10:24
machinst: Steal the used/defs Sets when emitting a call in ABICall;
diff --git a/cranelift/codegen/src/isa/aarch64/abi.rs b/cranelift/codegen/src/isa/aarch64/abi.rs index afdab0d2a..e58a7d989 100644 --- a/cranelift/codegen/src/isa/aarch64/abi.rs +++ b/cranelift/codegen/src/isa/aarch64/abi.rs @@ -72,6 +72,7 @@ use alloc::vec::Vec; use regalloc::{RealReg, Reg, RegClass, Set, SpillSlot...
3
8
4
19d8a7f1fb94f005466420d4c92add876196bd52
Benjamin Bouvier
2020-05-06T16:59:24
machinst: Reuse memory accross loop iterations in lowering;
diff --git a/cranelift/codegen/src/machinst/lower.rs b/cranelift/codegen/src/machinst/lower.rs index e7a124169..47384f462 100644 --- a/cranelift/codegen/src/machinst/lower.rs +++ b/cranelift/codegen/src/machinst/lower.rs @@ -327,6 +327,10 @@ impl<'func, I: VCodeInst> Lower<'func, I> { } } + ...
1
11
8
b24b711c16ca32966850e6c1f0f61a69fe83e692
Benjamin Bouvier
2020-05-06T16:47:12
machinst: Reduce the number of vec allocations for edge blocks;
diff --git a/cranelift/codegen/src/machinst/lower.rs b/cranelift/codegen/src/machinst/lower.rs index 8a1791aa8..e7a124169 100644 --- a/cranelift/codegen/src/machinst/lower.rs +++ b/cranelift/codegen/src/machinst/lower.rs @@ -260,7 +260,7 @@ impl<'func, I: VCodeInst> Lower<'func, I> { let b = queue.pop_...
1
19
14
9215b610efbc169c66c7ce36387d449a0b32afa7
Benjamin Bouvier
2020-05-06T16:05:14
machinst: Avoid a lot of short-lived allocations in ABICall;
diff --git a/cranelift/codegen/src/isa/aarch64/abi.rs b/cranelift/codegen/src/isa/aarch64/abi.rs index c71096d48..afdab0d2a 100644 --- a/cranelift/codegen/src/isa/aarch64/abi.rs +++ b/cranelift/codegen/src/isa/aarch64/abi.rs @@ -1179,44 +1179,40 @@ impl AArch64ABICall { } } -fn adjust_stack(amount: u64, is_sub:...
3
96
80
4f919c64602169fef9481fa5d1188befbbe327ed
Benjamin Bouvier
2020-05-06T15:34:27
machinst: bump regalloc to 0.0.23 and return a slice on the successor indexes, in block_succs;
diff --git a/Cargo.lock b/Cargo.lock index 62459c4e9..e775b2511 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1525,9 +1525,9 @@ dependencies = [ [[package]] name = "regalloc" -version = "0.0.22" +version = "0.0.23" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "9993953f6481fe355c490a0...
4
18
22
48521393ae6b6e014902fac8fe70ac2c1b221880
Julian Seward
2020-05-06T15:08:20
Update to regalloc.rs version 0.22.
diff --git a/Cargo.lock b/Cargo.lock index 9fc0d489e..62459c4e9 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1525,9 +1525,9 @@ dependencies = [ [[package]] name = "regalloc" -version = "0.0.21" +version = "0.0.22" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "b27b256b41986ac5141b37b...
3
19
10
1d90751ba93b737f3e9a2e530500f486b7e5fd17
Benjamin Bouvier
2020-05-05T16:58:47
machinst: Avoid a full instructions traversal of all the blocks when computing the final block ordering;
diff --git a/cranelift/codegen/src/machinst/blockorder.rs b/cranelift/codegen/src/machinst/blockorder.rs index 847f2a6b6..9c5060bc4 100644 --- a/cranelift/codegen/src/machinst/blockorder.rs +++ b/cranelift/codegen/src/machinst/blockorder.rs @@ -1,7 +1,6 @@ //! Computation of basic block order in emitted code. use c...
3
22
18
a7d90af19d5eb37ffd1abc1cd289f73ede78f657
Alex Crichton
2020-05-05T21:13:14
Update wasmparser and wast dependencies (#1663) Brings in updates to SIMD spec ops renumbering.
diff --git a/Cargo.lock b/Cargo.lock index b3bb74d7c..38e17a29b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1,11 +1,5 @@ # This file is automatically @generated by Cargo. # It is not intended for manual editing. -[[package]] -name = "adler32" -version = "1.0.4" -source = "registry+https://github.com/rust-lang/crates...
12
30
49
176b3a8382a8f6fa8e307560070efb9ace3c79c9
Graham✈️✈️
2020-05-05T19:57:19
add the _set suffix to static_memory_guard_size and dynamic_memory_guard_size properties in c-api (#1662)
diff --git a/crates/c-api/src/config.rs b/crates/c-api/src/config.rs index c78fdaa19..aaee8c4b3 100644 --- a/crates/c-api/src/config.rs +++ b/crates/c-api/src/config.rs @@ -153,11 +153,11 @@ pub extern "C" fn wasmtime_config_static_memory_maximum_size_set(c: &mut wasm_co } #[no_mangle] -pub extern "C" fn wasmtime_c...
1
2
2
cb47611c44c383f0c0acb2f3b5ed75394fc9eb44
Andrew Brown
2020-05-02T22:21:21
Enable SIMD bit shift spec tests
diff --git a/build.rs b/build.rs index af52789fc..bcf81cce5 100644 --- a/build.rs +++ b/build.rs @@ -183,7 +183,6 @@ fn ignore(testsuite: &str, testname: &str, strategy: &str) -> bool { // to be a big chunk of work to implement them all there! ("simd", _) if target.contains("aarch64") => retur...
1
0
1
4155d15e69eb4f5fbf39758560283f5a0362d12a
Andrew Brown
2020-05-02T22:03:40
Fix masking of vector shift values Previously, the logic was wrong on two counts: - It used the bits of the entire vector (e.g. i32x4 -> 128) instead of just the lane bits (e.g. i32x4 -> 32). - It used the type of the first operand before it was bitcast to its correct type. Remember that, by default, vectors are han...
diff --git a/cranelift/wasm/src/code_translator.rs b/cranelift/wasm/src/code_translator.rs index f98dee023..7513e456e 100644 --- a/cranelift/wasm/src/code_translator.rs +++ b/cranelift/wasm/src/code_translator.rs @@ -1402,7 +1402,7 @@ pub fn translate_operator<FE: FuncEnvironment + ?Sized>( Operator::I8x16Shl ...
1
4
5
8e934e6762ec22fb7e0c873564660bbc2c91d305
Alex Crichton
2020-05-05T17:03:31
Update `Table::grow`'s return to be the previous size (#1653) * Update `Table::grow`'s return to be the previous size This brings it in line with `Memory::grow` and the `table.grow` instruction which return the size of the table previously, not the size of the table currently. * Comment successful return
diff --git a/crates/api/src/externals.rs b/crates/api/src/externals.rs index 987219d9c..6536f017f 100644 --- a/crates/api/src/externals.rs +++ b/crates/api/src/externals.rs @@ -371,6 +371,8 @@ impl Table { /// Grows the size of this table by `delta` more elements, initialization /// all new elements to `init`...
2
8
5
6bee767129b4eaf6d62684e7761c2fbe2bfdfc9c
Benjamin Bouvier
2020-04-27T16:35:43
clif-util: try both global and target-dependent settings when parsing --set flags;
diff --git a/cranelift/reader/src/isaspec.rs b/cranelift/reader/src/isaspec.rs index ed16fd441..be05f3511 100644 --- a/cranelift/reader/src/isaspec.rs +++ b/cranelift/reader/src/isaspec.rs @@ -6,7 +6,7 @@ //! If a test case file contains `isa` commands, the tests will only be run against the specified //! ISAs. If th...
4
83
14
6ef106fee9df8678911b685cad5d88540f364025
Alex Crichton
2020-05-04T20:19:37
Fix a missing early-return in `Table::get` (#1652) Turns out this was a typo from #1016!
diff --git a/crates/api/src/values.rs b/crates/api/src/values.rs index 8d1d7f55b..6eb8004d9 100644 --- a/crates/api/src/values.rs +++ b/crates/api/src/values.rs @@ -216,7 +216,7 @@ pub(crate) fn from_checked_anyfunc( store: &Store, ) -> Val { if item.type_index == wasmtime_runtime::VMSharedSignatureIndex::de...
3
15
1
c284ffe6c036b8058228d576c46688968629b48c
Alex Crichton
2020-05-02T00:55:35
Move trap handler initialization to per-`Store` (#1644) Previously we initialized trap handling (signals/etc) once-per-instance but that's a bit too granular since we only need to do this as one-time per-program initialization. This moves the initialization to `Store` instead which means that we'll call this at lea...
diff --git a/crates/api/src/runtime.rs b/crates/api/src/runtime.rs index 2fef4af81..b9218f2c7 100644 --- a/crates/api/src/runtime.rs +++ b/crates/api/src/runtime.rs @@ -743,6 +743,13 @@ pub(crate) struct StoreInner { impl Store { /// Creates a new store to be associated with the given [`Engine`]. pub fn new(...
4
9
7
db92dcd990561de1f192f1a8dd73572b0798f525
Alex Crichton
2020-05-01T16:24:53
Update test ignore annotations for aarch64 (#1643) Looks like everything is in general passing now so it's probably time to close #1521 and all other remaining tests that are failing are classified under new more focused issues. Closes #1521
diff --git a/crates/api/src/runtime.rs b/crates/api/src/runtime.rs index 0d46acc77..2fef4af81 100644 --- a/crates/api/src/runtime.rs +++ b/crates/api/src/runtime.rs @@ -970,7 +970,6 @@ mod tests { use tempfile::TempDir; #[test] - #[cfg_attr(target_arch = "aarch64", ignore)] // FIXME(#1521) fn cache_...
5
24
24
964c6087bdc58c082c15426aad8b7ad4e3ae2c67
Chris Fallin
2020-04-29T18:00:28
MachInst backend: attach SourceLoc span information to all ranges. Previously, the SourceLoc information transferred in `VCode` only included PC-spans for non-default SourceLocs. I realized that the invariant we're supposed to keep here is that every PC is covered; if no source information, just use `SourceLoc::defaul...
diff --git a/cranelift/codegen/src/machinst/vcode.rs b/cranelift/codegen/src/machinst/vcode.rs index 6b77411d3..fe1678db6 100644 --- a/cranelift/codegen/src/machinst/vcode.rs +++ b/cranelift/codegen/src/machinst/vcode.rs @@ -550,7 +550,7 @@ impl<I: VCodeInst> VCode<I> { let code_section = sections.get_section(...
2
8
14
d88a147b4d9f398c306ea2262e566c136374bb6b
Alex Crichton
2020-04-30T19:25:06
Add some debugging assistance to spectest oracle Basically just log what's happening so if you're running the fuzzer you can see what test is being run.
diff --git a/crates/fuzzing/src/oracles.rs b/crates/fuzzing/src/oracles.rs index 29736ca19..a6df5a56c 100644 --- a/crates/fuzzing/src/oracles.rs +++ b/crates/fuzzing/src/oracles.rs @@ -393,6 +393,8 @@ pub fn make_api_calls(api: crate::generators::api::ApiCalls) { /// /// Ensures that spec tests pass regardless of the...
1
2
0
49622bde586deeb8400529fd61bf5bf1abab38e3
Andrew Brown
2020-04-30T17:22:25
Use complex load-extend instructions in `optimize_complex_addresses`; fixes #1186
diff --git a/cranelift/codegen/src/postopt.rs b/cranelift/codegen/src/postopt.rs index 9e2179982..3e27c90a3 100644 --- a/cranelift/codegen/src/postopt.rs +++ b/cranelift/codegen/src/postopt.rs @@ -271,6 +271,42 @@ fn optimize_complex_addresses(pos: &mut EncCursor, inst: Inst, isa: &dyn TargetI ...
2
37
6
a31250626204b67d87780444dbf308d4e43b4688
Andrew Brown
2020-04-30T17:20:59
Add x86 complex encodings for SIMD load-extend instructions
diff --git a/cranelift/codegen/meta/src/isa/x86/encodings.rs b/cranelift/codegen/meta/src/isa/x86/encodings.rs index 807935b80..937df6830 100644 --- a/cranelift/codegen/meta/src/isa/x86/encodings.rs +++ b/cranelift/codegen/meta/src/isa/x86/encodings.rs @@ -1607,8 +1607,11 @@ fn define_simd( let sadd_sat = shared.b...
3
127
2
38dff291790eae67f671b93b38e88b44e80d38e3
Andrew Brown
2020-04-15T20:50:51
Add ability to call CLIF functions with arbitrary arguments in filetests This resolves the work started in https://github.com/bytecodealliance/cranelift/pull/1231 and https://github.com/bytecodealliance/wasmtime/pull/1436. Cranelift filetests currently have the ability to run CLIF functions with a signature like `() -...
diff --git a/Cargo.lock b/Cargo.lock index 77f89ed9e..b3bb74d7c 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -409,6 +409,7 @@ version = "0.63.0" dependencies = [ "byteorder", "cranelift-codegen", + "cranelift-frontend", "cranelift-native", "cranelift-preopt", "cranelift-reader", @@ -420,6 +421,7 @@ dependenci...
8
514
97
2048d3d30c006e280b9369e1af035040363c31f3
Andrew Brown
2020-04-18T22:07:53
Add x86 encodings for same-size bint conversions up to 64 bits
diff --git a/cranelift/codegen/meta/src/isa/x86/encodings.rs b/cranelift/codegen/meta/src/isa/x86/encodings.rs index 7aee35bdb..807935b80 100644 --- a/cranelift/codegen/meta/src/isa/x86/encodings.rs +++ b/cranelift/codegen/meta/src/isa/x86/encodings.rs @@ -689,6 +689,12 @@ fn define_moves(e: &mut PerCpuModeEncodings, s...
1
6
0