commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
8b3f57ecece17ee6f14ccda2f2b03d0fa3a11850 | Parth Agrawal | 2026-02-11T10:25:13 | fix(normalizer): Add missing backticks to doc comment (#7633)
Fixes #7632. This PR suppresses `clippy::doc-markdown` warnings in
`components/normalizer/src/lib.rs` by wrapping `icu_properties` and
`CanonicalCombiningClass` in backticks.
---------
Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.gi... | diff --git a/components/normalizer/src/lib.rs b/components/normalizer/src/lib.rs
index 6155ae35ed..c12d657f5e 100644
--- a/components/normalizer/src/lib.rs
+++ b/components/normalizer/src/lib.rs
@@ -170,8 +170,8 @@ fn likely(b: bool) -> bool {
b
}
-/// This type exists as a shim for icu_properties CanonicalComb... | 1 | 2 | 2 |
99980308fa376791e7fe2ec9b5411717333d3f94 | Swarnit | 2026-02-11T10:21:20 | fix: overflow from_epoch_milliseconds_and_utc_offset … (#6512) (#7604)
Added tests confirming integer overflow when combining `i64::MAX/MIN`
with non-zero UTC offsets. Function panics at
`components/time/src/types.rs:378:40` during
addition operation.
Fixes #6512
---------
Co-authored-by: Robert Bastian <4706271+... | diff --git a/components/time/src/types.rs b/components/time/src/types.rs
index b0553fe902..172750326f 100644
--- a/components/time/src/types.rs
+++ b/components/time/src/types.rs
@@ -370,23 +370,46 @@ impl ZonedDateTime<Iso, UtcOffset> {
/// ZonedDateTime::try_offset_only_from_str(iso_str, Iso).unwrap();
... | 1 | 33 | 10 |
41800dacd6bdcff845712655fcd0e35327718157 | Pratush Shyam Gupt | 2026-02-11T10:12:02 | Improve performance of property name lookup (#7623)
Fixes #5599
Summary :-
- made `step()` function to return `bool`.
- removed `whitespace characters` and `hyphen` check from the
trie-skipping loop
- made the `original case` and `other case` recurse only if `step`
returned `true` instead of using `or_else`
- added... | diff --git a/components/properties/src/names.rs b/components/properties/src/names.rs
index c9864a5dac..e711454738 100644
--- a/components/properties/src/names.rs
+++ b/components/properties/src/names.rs
@@ -309,13 +309,11 @@ fn get_loose_u16(payload: &PropertyValueNameToEnumMap<'_>, name: &[u8]) -> Optio
r... | 2 | 42 | 16 |
7bb5349bf331de6accf268738136a0e08627afbe | Robert Bastian | 2026-02-11T09:43:59 | Add missing error variant conversion (#7628)
This would have been caught by
https://github.com/rust-lang/rust/issues/89554.
Unfortunately, because this conversion was missing, the change from
`AnyCalendarKind` to `CalendarAlgorithm` in `icu_calendar::ParseError`
was not applied to `icu_time::ParseError`. | diff --git a/components/time/src/ixdtf.rs b/components/time/src/ixdtf.rs
index 77bed0476f..54c2cb5768 100644
--- a/components/time/src/ixdtf.rs
+++ b/components/time/src/ixdtf.rs
@@ -105,6 +105,10 @@ impl From<icu_calendar::ParseError> for ParseError {
icu_calendar::ParseError::Range(r) => Self::Range(r),
... | 1 | 4 | 0 |
e1253add3138b924fe88f05214fe115e80b86e0e | Robert Bastian | 2026-02-10T23:56:27 | Update date ranges (#7629) | diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs
index 9f6df62c11..b7dda0557e 100644
--- a/components/calendar/src/any_calendar.rs
+++ b/components/calendar/src/any_calendar.rs
@@ -1698,7 +1698,7 @@ mod tests {
single_test_error(
korean_traditional,
... | 6 | 20 | 68 |
83a2abb9142b48e052d5f7453ea0b89b4f1239c2 | Robert Bastian | 2026-02-10T22:52:04 | Use `Date::from_raw` in `Date::try_from_str` (#7627)
This saves a RD round-trip for Gregorian calendars. | diff --git a/components/calendar/src/ixdtf.rs b/components/calendar/src/ixdtf.rs
index 2affbf7dd6..becbdcf63a 100644
--- a/components/calendar/src/ixdtf.rs
+++ b/components/calendar/src/ixdtf.rs
@@ -4,8 +4,9 @@
use core::str::FromStr;
-use crate::calendar_arithmetic::VALID_RD_RANGE;
-use crate::{AsCalendar, Calend... | 3 | 25 | 20 |
006f7053746903ad06d2fc3d234f2dd2f229d091 | Robert Bastian | 2026-02-10T22:30:42 | Actually reject date strings with invalid calendar annotations (#7626)
The current code is buggy because it only performs this check if the
annotation parses into a `CalendarAlgorithm`. That is stupid. | diff --git a/components/calendar/src/ixdtf.rs b/components/calendar/src/ixdtf.rs
index dbefbe3777..2affbf7dd6 100644
--- a/components/calendar/src/ixdtf.rs
+++ b/components/calendar/src/ixdtf.rs
@@ -55,7 +55,7 @@ impl<A: AsCalendar> Date<A> {
/// Creates a [`Date`] in the given calendar from an RFC 9557 string.
... | 2 | 19 | 17 |
3637abd0d035f8db64356699520c16c26ad91e6a | Robert Bastian | 2026-02-10T10:56:05 | Add methods to load LSTM or dictionary data for existing segmenters (#7590)
Clients want to do custom dictinoary/lstm loading, without doing full
custom data loading for segmenters. We can extend
`Segmenter::new_for_non_complex_scripts` with methods `load_lstm` and
`load_dictionary` so that the non-complex script data... | diff --git a/components/segmenter/src/complex/mod.rs b/components/segmenter/src/complex/mod.rs
index f10be37704..88b7fccf8d 100644
--- a/components/segmenter/src/complex/mod.rs
+++ b/components/segmenter/src/complex/mod.rs
@@ -158,80 +158,53 @@ impl<'data> ComplexPayloadsBorrowed<'data> {
impl ComplexPayloadsBorrowed<... | 4 | 277 | 245 |
acbeac4547d20ce90edea973ce6109b015c94ef5 | Pratush Shyam Gupt | 2026-02-09T09:36:57 | added error codes for compile_fail (#7611)
Fixes #5752 | diff --git a/components/datetime/src/neo.rs b/components/datetime/src/neo.rs
index e18b0d08a0..24686e70fe 100644
--- a/components/datetime/src/neo.rs
+++ b/components/datetime/src/neo.rs
@@ -163,7 +163,7 @@ size_test!(FixedCalendarDateTimeFormatter<icu_calendar::Gregorian, crate::fields
///
/// Mismatched calendars w... | 4 | 17 | 17 |
55cd3ba62e1ca3774972b35ade72629ad86bb739 | Shane F. Carr | 2026-02-06T17:58:50 | Add DateFromFieldsError::TooManyFields error variant (#7596)
#7161 | diff --git a/components/calendar/src/calendar_arithmetic.rs b/components/calendar/src/calendar_arithmetic.rs
index f889d9f433..18c8b8bb20 100644
--- a/components/calendar/src/calendar_arithmetic.rs
+++ b/components/calendar/src/calendar_arithmetic.rs
@@ -311,7 +311,7 @@ impl<C: DateFieldsResolver> ArithmeticDate<C> {
... | 3 | 36 | 13 |
c4d85c6df6e11b2e2372709c8cbb877cf1bc628e | Shane F. Carr | 2026-02-06T08:47:41 | Add more docs test to DateFields and DateFromFieldsError (#7597)
#7161 | diff --git a/components/calendar/src/error.rs b/components/calendar/src/error.rs
index 595573bbaf..a85b71e72f 100644
--- a/components/calendar/src/error.rs
+++ b/components/calendar/src/error.rs
@@ -154,6 +154,26 @@ mod unstable {
#[displaydoc("{0}")]
Range(RangeError),
/// The era code is in... | 2 | 58 | 1 |
b040abb3771da25530955227b48bd6e30860f866 | Shane F. Carr | 2026-02-06T05:07:54 | Fix icu4x-datagen error messages and inconsistencies (#7598) | diff --git a/provider/icu4x-datagen/src/main.rs b/provider/icu4x-datagen/src/main.rs
index a3038cdaa4..79f3702fb6 100644
--- a/provider/icu4x-datagen/src/main.rs
+++ b/provider/icu4x-datagen/src/main.rs
@@ -428,20 +428,20 @@ fn run(cli: Cli) -> eyre::Result<()> {
fn missing_data_message<T>(e: DataError) -> Result<... | 2 | 5 | 5 |
885242624d3785d27130e687752525f7c707a350 | yqaty | 2026-02-04T20:37:32 | Fix swapped new/try_new in WordSegmenter comments (#7554)
The documentation for `WordSegmenter` appeared to have the `new` and
`try_new` constructors swapped.
- `WordBreakOptions` (with locale) typically involves fallible data
loading (`try_new`).
- `WordBreakInvariantOptions` implies infallible/const construction
(`... | diff --git a/components/segmenter/src/word.rs b/components/segmenter/src/word.rs
index 6955f9b9d5..1547b8d293 100644
--- a/components/segmenter/src/word.rs
+++ b/components/segmenter/src/word.rs
@@ -174,9 +174,9 @@ impl<Y: RuleBreakType> Iterator for WordBreakIteratorWithWordType<'_, '_, Y> {
/// have information on t... | 1 | 2 | 2 |
f9790c9efdb3f0bbc255bf28476a382cb1c70634 | Robert Bastian | 2026-02-04T17:32:53 | Consider numbering system in compact formatter (#7543) | diff --git a/components/decimal/src/compact_formatter.rs b/components/decimal/src/compact_formatter.rs
index 49a9109b05..4dd06769cf 100644
--- a/components/decimal/src/compact_formatter.rs
+++ b/components/decimal/src/compact_formatter.rs
@@ -5,8 +5,11 @@
use core::fmt::Display;
use crate::{
- error::ExponentErr... | 3 | 116 | 97 |
e13702799455bdd91cc990fcaec64418b883c6ed | Robert Bastian | 2026-02-03T21:34:49 | Use month number instead of ordinal month in formatting (#7574)
This is not a behaviour change but only because we don't have a test for
these field lengths with calendars that use leap months. We should never
display the ordinal month. | diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs
index 5822a4aeb6..c99103438c 100644
--- a/components/datetime/src/format/datetime.rs
+++ b/components/datetime/src/format/datetime.rs
@@ -244,7 +244,7 @@ where
(FieldSymbol::Month(_), l @ (FieldLength::One | Fi... | 1 | 4 | 4 |
edd1e00ac216112c461787deeb5cebe33c8e0f9f | Robert Bastian | 2026-02-03T19:06:22 | Replace `Date::try_new_from_codes` where possible (#7572) | diff --git a/components/calendar/benches/date.rs b/components/calendar/benches/date.rs
index 12819162a4..19a8d79388 100644
--- a/components/calendar/benches/date.rs
+++ b/components/calendar/benches/date.rs
@@ -152,7 +152,7 @@ fn date_benches(c: &mut Criterion) {
"calendar/chinese_cached",
&fxs,
... | 6 | 39 | 53 |
358b00427c8b6d439dbc0cbcbad2edc69f956cd7 | Robert Bastian | 2026-02-03T15:47:40 | Encapsulate Date fields (#7556)
All construction should go through `Date::from_raw`, and `Date.inner`
should not be mutable. This gives more peace of mind wrt to calendar
bounds. | diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs
index db369a3cef..2d55b47f24 100644
--- a/components/calendar/src/any_calendar.rs
+++ b/components/calendar/src/any_calendar.rs
@@ -1411,8 +1411,8 @@ impl<C: IntoAnyCalendar> Date<C> {
/// Type-erase the date, converting... | 4 | 16 | 14 |
8cc9cfcaffa287ea7dfc078bffe90d5382d3a1af | Robert Bastian | 2026-02-03T15:46:07 | Add `Month` field to `DateFields` (#7486)
#7149 | diff --git a/components/calendar/fuzz/fuzz_targets/common.rs b/components/calendar/fuzz/fuzz_targets/common.rs
index ae9fa166f2..0f7bbf6401 100644
--- a/components/calendar/fuzz/fuzz_targets/common.rs
+++ b/components/calendar/fuzz/fuzz_targets/common.rs
@@ -38,12 +38,10 @@ impl Ymd {
fields.ordinal_mo... | 10 | 98 | 72 |
2db3c5f489a8e0723e172d8213c6d41c5169be71 | Robert Bastian | 2026-02-03T15:27:14 | `try_new_hebrew_fixed` -> `try_new_hebrew_v2` (#7561)
Fixes #7043 | diff --git a/components/calendar/src/cal/hebrew.rs b/components/calendar/src/cal/hebrew.rs
index 90bfa271c7..4b6e304e78 100644
--- a/components/calendar/src/cal/hebrew.rs
+++ b/components/calendar/src/cal/hebrew.rs
@@ -357,7 +357,7 @@ impl Date<Hebrew> {
/// use icu::calendar::Date;
/// use icu::calendar::typ... | 5 | 15 | 15 |
aef85fc55e703ee9c84dad3c1e503313b718f9b0 | rusat | 2026-02-03T15:05:58 | Add shared helper to assert consistency across collator comparison paths (#7499)
Fixes #6855 | diff --git a/components/collator/tests/tests.rs b/components/collator/tests/tests.rs
index 5bf4e54ae8..2ad358123d 100644
--- a/components/collator/tests/tests.rs
+++ b/components/collator/tests/tests.rs
@@ -41,6 +41,37 @@ const _: () = {
type StackString = arraystring::ArrayString<arraystring::typenum::U32>;
+fn a... | 1 | 81 | 56 |
df593410954c9285b9216b7151dd240fa3c1b777 | Pratush Shyam Gupt | 2026-02-03T08:20:17 | chore: follow-up to #7502 (#7553)
Follow up PR for #7502 - adds requested comments | diff --git a/components/plurals/src/operands.rs b/components/plurals/src/operands.rs
index 6fb2961d54..35ed0b1b2d 100644
--- a/components/plurals/src/operands.rs
+++ b/components/plurals/src/operands.rs
@@ -242,6 +242,8 @@ impl From<u128> for PluralOperands {
let i = if input < LIMIT_18_DIGITS as u128 {
... | 1 | 2 | 0 |
54119f3ab18bbdb8ffb5365a3151360276f1519a | Robert Bastian | 2026-02-03T07:55:42 | Remove range checks from `Date::try_from_str` (#7545)
They're still there, in the IXDTF parser. | diff --git a/components/calendar/src/ixdtf.rs b/components/calendar/src/ixdtf.rs
index 5cfa675a06..dbefbe3777 100644
--- a/components/calendar/src/ixdtf.rs
+++ b/components/calendar/src/ixdtf.rs
@@ -4,7 +4,9 @@
use core::str::FromStr;
+use crate::calendar_arithmetic::VALID_RD_RANGE;
use crate::{AsCalendar, Calend... | 1 | 14 | 2 |
31b4cda0ac77fd9be062d45b54f61754dbcd3601 | Shane F. Carr | 2026-02-03T07:51:53 | Fix docs to say --ucd-tag (#7551)
https://github.com/unicode-org/icu4x/pull/7504#discussion_r2753973704 | diff --git a/provider/icu4x-datagen/src/main.rs b/provider/icu4x-datagen/src/main.rs
index ea9b5f3ee0..071b90ca8a 100644
--- a/provider/icu4x-datagen/src/main.rs
+++ b/provider/icu4x-datagen/src/main.rs
@@ -437,7 +437,7 @@ fn run(cli: Cli) -> eyre::Result<()> {
eyre::bail!("Segmentation LSTM data is requir... | 1 | 1 | 1 |
32301f1f66668a50613f13e98e23b7255ca8c4d7 | Robert Bastian | 2026-02-03T02:43:18 | Make `UtcOffset::try_from_str` const without unnecessary AI changes (#7536)
#7534 | diff --git a/components/time/src/zone/offset.rs b/components/time/src/zone/offset.rs
index 205e324e1b..beb54c973b 100644
--- a/components/time/src/zone/offset.rs
+++ b/components/time/src/zone/offset.rs
@@ -31,7 +31,7 @@ impl UtcOffset {
/// Attempt to create a [`UtcOffset`] from a seconds input.
///
///... | 1 | 21 | 12 |
5c7c6ab11f4a5281e50e73b7fdf6bff5f24244eb | Shane F. Carr | 2026-02-03T02:37:15 | Use try_new_hebrew_fixed in arithmetic test (#7549) | diff --git a/components/calendar/tests/arithmetic.rs b/components/calendar/tests/arithmetic.rs
index 761e4b510e..240ca9f509 100644
--- a/components/calendar/tests/arithmetic.rs
+++ b/components/calendar/tests/arithmetic.rs
@@ -203,17 +203,16 @@ fn test_tricky_leap_months() {
let mut until_options = DateDifferenceO... | 1 | 17 | 9 |
1c544f255e70ad8db1034aecbc22027f191dc259 | Shane F. Carr | 2026-02-03T02:14:08 | Use try_new_chinese_traditional in arithmetic test (#7548) | diff --git a/components/calendar/tests/arithmetic.rs b/components/calendar/tests/arithmetic.rs
index 5cc839c120..761e4b510e 100644
--- a/components/calendar/tests/arithmetic.rs
+++ b/components/calendar/tests/arithmetic.rs
@@ -5,7 +5,7 @@
use std::convert::Infallible;
use icu_calendar::{
- cal::{ChineseTradition... | 1 | 3 | 7 |
50912ea1d660faded388fd77dd5db87c98774554 | Robert Bastian | 2026-02-02T20:40:28 | Add more variants to `CodePointTrieBuilderData` (#7541)
Avoids creating the massive vector of all code points. | diff --git a/components/collections/codepointtrie_builder/src/common.rs b/components/collections/codepointtrie_builder/src/common.rs
index e1fc93f4b6..5ec4116c97 100644
--- a/components/collections/codepointtrie_builder/src/common.rs
+++ b/components/collections/codepointtrie_builder/src/common.rs
@@ -2,7 +2,9 @@
// c... | 5 | 115 | 56 |
931c7c158cbf46f967ef19ef2015f387792f553d | Parth Agrawal | 2026-02-02T15:41:16 | Add date arithmetic tests (#7527)
Implementation of comprehensive date arithmetic coverage tests as
suggested in #7215. | diff --git a/components/calendar/src/tests/arithmetic.rs b/components/calendar/src/tests/arithmetic.rs
new file mode 100644
index 0000000000..a19dcc442c
--- /dev/null
+++ b/components/calendar/src/tests/arithmetic.rs
@@ -0,0 +1,126 @@
+// This file is part of ICU4X. For terms of use, please see the file
+// called LICE... | 2 | 127 | 0 |
346927b5b156cff26461c354972963610d5ec89b | Robert Bastian | 2026-02-02T14:19:54 | Fix WASM data types (#7539)
We need to cast `i32` to `u32` if C++ returns a `uint32_t` to
reinterpret the bits, instead of (fallibly) reinterpreting the numeric
value. | diff --git a/components/collections/codepointtrie_builder/src/wasm.rs b/components/collections/codepointtrie_builder/src/wasm.rs
index 6ec35b1a14..10bebc6420 100644
--- a/components/collections/codepointtrie_builder/src/wasm.rs
+++ b/components/collections/codepointtrie_builder/src/wasm.rs
@@ -26,7 +26,7 @@ impl Wasmi3... | 1 | 17 | 22 |
e61f25aa586116fc6d9ec77b95f68662c7c89e2d | Robert Bastian | 2026-02-02T11:01:18 | Match preferences on full value (#7477)
Currently it's only a prefix match, i.e. `-u-ca-gregorian-backward` will
still parse as `CalendarAlgorithm::Gregorian`, which is probably not
intended. | diff --git a/components/calendar/src/preferences.rs b/components/calendar/src/preferences.rs
index c7be26411e..598fa29246 100644
--- a/components/calendar/src/preferences.rs
+++ b/components/calendar/src/preferences.rs
@@ -62,10 +62,10 @@ impl CalendarPreferences {
/// # CalendarAlgorithm::Hijri(Some(HijriCale... | 3 | 17 | 13 |
60319414f46fdc090e1871f4cf977cae2ec27488 | Shane F. Carr | 2026-01-30T22:49:12 | Say "Cargo feature" in buffer provider docs (#7530)
Another item in #6242 | diff --git a/provider/core/src/constructors.rs b/provider/core/src/constructors.rs
index e320c1b4d1..83a6134e3f 100644
--- a/provider/core/src/constructors.rs
+++ b/provider/core/src/constructors.rs
@@ -106,7 +106,7 @@ macro_rules! gen_buffer_unstable_docs {
concat!(
"A version of [`", stringify!(... | 1 | 1 | 1 |
fd535f333e4320e143adadc623e610768b1200b2 | Eric Sheppard | 2026-01-30T22:08:32 | calendrical_calculations: change functions to const (#7524)
Thank you for the excellent crate, I'm making use of
`calendrical_calculations` in another library but I was wanting have my
functions be `const`. Upon investigation it was possible to convert the
functions I was relying upon to `const` also
Co-authored-by: ... | diff --git a/utils/calendrical_calculations/src/gregorian.rs b/utils/calendrical_calculations/src/gregorian.rs
index 18b1d7d803..3359846b62 100644
--- a/utils/calendrical_calculations/src/gregorian.rs
+++ b/utils/calendrical_calculations/src/gregorian.rs
@@ -100,7 +100,7 @@ pub const fn day_before_year(year: i32) -> Ra... | 1 | 11 | 6 |
68dc82045950ad4f009d9b3ad8d21f2796ad32b6 | Robert Bastian | 2026-01-29T17:22:17 | Enable `clippy::unnecessary-wraps` (#7492)
Lints non-pub functions that unnecessarily return `Result`. This is
something that often comes up in code reviews, and makes the fallibility
of our code harder to follow. | diff --git a/Cargo.toml b/Cargo.toml
index b58ed5f31d..1b954d0a95 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -358,6 +358,7 @@ clippy.or-fun-call = "warn"
clippy.same_functions_in_if_condition = "warn"
clippy.todo = "warn"
clippy.trivially_copy_pass_by_ref = "deny"
+clippy.unnecessary-wraps = "warn"
clippy.wildcard... | 17 | 67 | 72 |
73db3ceb12eec5fbd0b672846f1813d467ef94f3 | Robert Bastian | 2026-01-29T17:00:05 | Enable `clippy::alloc-instead-of-core` (#7490)
Require `core` items to be imported from `core`, not `alloc`. This makes
it easier to review our usage of `alloc`, and easier to disable it in
the future. | diff --git a/Cargo.toml b/Cargo.toml
index 9412699e1e..b58ed5f31d 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -340,6 +340,7 @@ inherits = "bench"
debug = true
[workspace.lints]
+clippy.alloc-instead-of-core = "warn"
clippy.branches-sharing-code = "warn"
clippy.collection_is_never_read = "warn"
clippy.dbg_macro =... | 17 | 23 | 18 |
b5a033726411154c49cf14e3cbdd955075b12e3c | Robert Bastian | 2026-01-29T16:35:12 | Add constructors with `Month` for lunisolar calendars (#7485)
#7043
Need to discuss naming. | diff --git a/components/calendar/src/cal/east_asian_traditional.rs b/components/calendar/src/cal/east_asian_traditional.rs
index 12a8cb11ad..d5e71262b5 100644
--- a/components/calendar/src/cal/east_asian_traditional.rs
+++ b/components/calendar/src/cal/east_asian_traditional.rs
@@ -5,7 +5,8 @@
use crate::calendar_arit... | 7 | 218 | 27 |
c85ddda2cab98775a7546626662c6b888ff3dcd1 | Robert Bastian | 2026-01-29T16:26:26 | Enable `clippy::or-fun-call` (#7488)
Don't accidentally execute code in error paths. | diff --git a/Cargo.toml b/Cargo.toml
index e1bf0755cf..9412699e1e 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -353,6 +353,7 @@ clippy.large_stack_arrays = "warn"
clippy.mismatching_type_param_order = "warn"
clippy.missing_fields_in_debug = "warn"
clippy.negative_feature_names = "warn"
+clippy.or-fun-call = "warn"
c... | 28 | 190 | 155 |
7f7a6f6b8f6689c67b83d36a0dc6c5bdba8453e2 | Robert Bastian | 2026-01-29T16:26:10 | Enable `clippy::branches-sharing-code` (#7489)
Keeps our code more readable. Barely any violations anyway. | diff --git a/Cargo.toml b/Cargo.toml
index abc0ba16bd..e1bf0755cf 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -340,6 +340,7 @@ inherits = "bench"
debug = true
[workspace.lints]
+clippy.branches-sharing-code = "warn"
clippy.collection_is_never_read = "warn"
clippy.dbg_macro = "warn"
clippy.debug_assert_with_mut_c... | 4 | 13 | 23 |
8bbeb0935f2edc56ba58da3c8a4ba4c3480b0e32 | Ishaan Kesarwani | 2026-01-28T20:21:20 | Add tests for low-frequency suffixes in Dense ZeroTrie (#7439) | diff --git a/utils/zerotrie/tests/dense_test.rs b/utils/zerotrie/tests/dense_test.rs
index 4cc645e609..b62c7ed486 100644
--- a/utils/zerotrie/tests/dense_test.rs
+++ b/utils/zerotrie/tests/dense_test.rs
@@ -168,6 +168,11 @@ fn test_dense_sparse_window_selection() {
let dense = ZeroAsciiDenseSparse2dTrieOwned::try_... | 1 | 139 | 0 |
5fb31d7ae061d304088f1e79897f7435f1846da6 | Manish Goregaokar | 2026-01-28T18:40:51 | Start producing Meiji era only after Meiji 6 (#7503)
See https://github.com/tc39/proposal-intl-era-monthcode/pull/102
We already have a note about this in our docs, but the calendar
switchover happened in Meiji 6, which means dates specified as Meiji 1-5
are unambiguously lunisolar. We're already liberal in accepting... | diff --git a/components/calendar/src/cal/japanese.rs b/components/calendar/src/cal/japanese.rs
index 0cacbd257b..0811a49186 100644
--- a/components/calendar/src/cal/japanese.rs
+++ b/components/calendar/src/cal/japanese.rs
@@ -20,8 +20,7 @@ use tinystr::{tinystr, TinyAsciiStr};
/// is uses Japanese eras instead of the... | 2 | 99 | 40 |
cb6d7a01fdf0fca77ed87cb70dab606bc170dd75 | Shane F. Carr | 2026-01-28T16:30:45 | Implement spec behavior around date arithmetic (#7514)
Fixes #7454 | diff --git a/components/calendar/src/calendar_arithmetic.rs b/components/calendar/src/calendar_arithmetic.rs
index b427478409..254c118a2f 100644
--- a/components/calendar/src/calendar_arithmetic.rs
+++ b/components/calendar/src/calendar_arithmetic.rs
@@ -501,6 +501,90 @@ impl<C: DateFieldsResolver> ArithmeticDate<C> {
... | 3 | 203 | 67 |
417ad23792722a8709f50b1b8fcdd309679e7b9e | Younies Mahmoud | 2026-01-28T11:10:11 | chore(locale): improvage the locale grouping naming and testing for clarification (#7437) | diff --git a/provider/source/src/cldr_cache.rs b/provider/source/src/cldr_cache.rs
index 82be9584d1..0568a1f2e3 100644
--- a/provider/source/src/cldr_cache.rs
+++ b/provider/source/src/cldr_cache.rs
@@ -11,6 +11,7 @@ use crate::CoverageLevel;
use icu::locale::provider::{
LocaleLikelySubtagsExtendedV1, LocaleLikel... | 2 | 77 | 7 |
19d8bb91b9b575125650c4ebf695a2cf97c222bd | Pratush Shyam Gupt | 2026-01-28T06:54:44 | Optimized get_u8 by avoiding char->u32 conversion (#7509)
Fixes #7506
Summary :-
In `CanonicalCombiningClassMapBorrowed::get_u8()`, it was converting a
`char` to `<u32>` and then calling `get32_u8()`, which throws away range
information that the trie can use for optimization.
This PR changes `get_u8()` to query the... | diff --git a/components/normalizer/src/properties.rs b/components/normalizer/src/properties.rs
index 94919a5a5f..77228303b1 100644
--- a/components/normalizer/src/properties.rs
+++ b/components/normalizer/src/properties.rs
@@ -571,7 +571,12 @@ impl CanonicalCombiningClassMapBorrowed<'_> {
/// `CanonicalCombiningCl... | 1 | 6 | 1 |
8857c63c5d1e9c9ccef380acb2e5fa746f50eb6e | Manish Goregaokar | 2026-01-28T02:21:40 | Reorder DateDuration methods to group related methods (no API change) (#7497)
Don't know why it was arranged like that, but this makes the docs look
neater.
I think this fixes https://github.com/unicode-org/icu4x/issues/7059 as
it was the only issue I found during API review. WG members are
encouraged to do their own... | diff --git a/components/calendar/src/duration.rs b/components/calendar/src/duration.rs
index 7c6b8ce04e..9e00f802ee 100644
--- a/components/calendar/src/duration.rs
+++ b/components/calendar/src/duration.rs
@@ -159,17 +159,6 @@ pub enum DateDurationUnit {
Days,
}
-impl DateDuration {
- /// Returns a new [`Da... | 1 | 9 | 11 |
ec44ce0fa4b88c8703d99dbcdc2f2f192b70d9be | WaterWhisperer | 2026-01-27T22:13:27 | Add the AM/PM getters on FixedCalendarDateTimeNames (#7127)
Co-authored-by: Manish Goregaokar <manishsmail@gmail.com> | diff --git a/components/datetime/Cargo.toml b/components/datetime/Cargo.toml
index b81ae8664f..37672e19fe 100644
--- a/components/datetime/Cargo.toml
+++ b/components/datetime/Cargo.toml
@@ -89,6 +89,7 @@ datagen = [
]
logging = ["icu_calendar/logging"]
experimental = []
+unstable = []
compiled_data = ["dep:icu_dat... | 2 | 95 | 0 |
32a2b0298a51168fc075eebe957a10969ac6eeeb | Henri Sivonen | 2026-01-27T20:59:33 | Expose the UTS 46 virama check using UTS 46 data (#7507)
This reduces the optimized wasm size of dependents that don't use
icu_normalizer or icu_collator for other purposes by 16.7 KB.
This does not break compat with the current `idna_adapter` but this
allows for a new version of `idna_adapter` that uses this and the... | diff --git a/components/normalizer/src/lib.rs b/components/normalizer/src/lib.rs
index c56abab7bf..6155ae35ed 100644
--- a/components/normalizer/src/lib.rs
+++ b/components/normalizer/src/lib.rs
@@ -234,6 +234,7 @@ const LOW_ZEROS_MASK: u32 = 0xFFE0;
/// combining class.
///
/// See trie-value-format.md
+#[inline]
... | 2 | 20 | 0 |
cd1030e114bd08c3c85bf836bb5d557037bb0a29 | Robert Bastian | 2026-01-23T20:17:36 | Followup #7416 (#7483) | diff --git a/provider/source/src/cldr_serde/ca.rs b/provider/source/src/cldr_serde/ca.rs
index 992e4caf89..0cb0480c2c 100644
--- a/provider/source/src/cldr_serde/ca.rs
+++ b/provider/source/src/cldr_serde/ca.rs
@@ -10,6 +10,7 @@
//! <https://github.com/unicode-org/cldr-json/blob/main/cldr-json/cldr-dates-full/main/en/... | 2 | 3 | 6 |
4287d260b5f2a1f9f74db4bafb657c4e53bd2f01 | Robert Bastian | 2026-01-23T14:48:36 | Move a test to `calendrical_calculations` (#7487)
It tests `calendrical_calculations` code | diff --git a/components/calendar/src/cal/east_asian_traditional.rs b/components/calendar/src/cal/east_asian_traditional.rs
index daa8ee2af3..12a8cb11ad 100644
--- a/components/calendar/src/cal/east_asian_traditional.rs
+++ b/components/calendar/src/cal/east_asian_traditional.rs
@@ -1389,36 +1389,6 @@ mod test {
... | 2 | 23 | 30 |
d948800473efd37feb85e7cee85726a548376e2e | Robert Bastian | 2026-01-23T05:37:26 | Don't allow pushing a `true` tag into `Value` (#7476) | diff --git a/components/locale_core/src/extensions/unicode/value.rs b/components/locale_core/src/extensions/unicode/value.rs
index 41beb43915..7eb9023e52 100644
--- a/components/locale_core/src/extensions/unicode/value.rs
+++ b/components/locale_core/src/extensions/unicode/value.rs
@@ -139,12 +139,16 @@ impl Value {
... | 1 | 5 | 1 |
12e68e69029f0e3caf67b500095d4c3fdbe0ac20 | Robert Bastian | 2026-01-22T21:20:41 | Disallow `true` in multi-level preference values (#7471)
This disallows the strawman from #6698, which doesn't make sense under
canonical equivalence. | diff --git a/components/locale_core/src/preferences/extensions/unicode/macros/enum_keyword.rs b/components/locale_core/src/preferences/extensions/unicode/macros/enum_keyword.rs
index 400ad0bf33..03fbfb4a48 100644
--- a/components/locale_core/src/preferences/extensions/unicode/macros/enum_keyword.rs
+++ b/components/loc... | 1 | 34 | 25 |
ae5e3ab18cd84c919136e9d84d90e287d417d152 | Manish Goregaokar | 2026-01-22T17:57:46 | Fix lints after merge (#7474)
https://github.com/unicode-org/icu4x/pull/7384 was made before the
`unnecessary_qualifications` PR. | diff --git a/components/properties/src/code_point_map.rs b/components/properties/src/code_point_map.rs
index dbc3810e81..cfb930cc07 100644
--- a/components/properties/src/code_point_map.rs
+++ b/components/properties/src/code_point_map.rs
@@ -43,7 +43,7 @@ impl<T: TrieValue> CodePointMapData<T> {
#[cfg(feature = "... | 3 | 3 | 3 |
8fdeaa8c96a14cbeaf4867cac86d99dd1c75944b | Manish Goregaokar | 2026-01-22T17:23:12 | Add buffer ctors for properties APIs (#7384)
Fixes the issue found in
https://github.com/unicode-org/icu4x/discussions/7374
This was an oversight when we did new properties. | diff --git a/components/properties/src/code_point_map.rs b/components/properties/src/code_point_map.rs
index f60a69dcd7..dbc3810e81 100644
--- a/components/properties/src/code_point_map.rs
+++ b/components/properties/src/code_point_map.rs
@@ -40,6 +40,18 @@ impl<T: TrieValue> CodePointMapData<T> {
CodePointMap... | 3 | 30 | 0 |
2ac7eae5268864f884f2e99173d39923da383766 | Ishaan Kesarwani | 2026-01-22T14:30:02 | Use checked arithmetic in dense ZeroTrie (#7443)
Closes #7442
Adds overflow protection to `ZeroAsciiDenseSparse2dTrieBorrowed::get()`
using checked arithmetic operations.
### Changes
**File**: utils/zerotrie/src/dense.rs
1. **Matrix indexing** now uses `checked_mul()` and `checked_add()`
2. **Final value calculati... | diff --git a/utils/zerotrie/src/dense.rs b/utils/zerotrie/src/dense.rs
index 0135208cff..723501d99d 100644
--- a/utils/zerotrie/src/dense.rs
+++ b/utils/zerotrie/src/dense.rs
@@ -193,16 +193,31 @@ impl<'a> ZeroAsciiDenseSparse2dTrieBorrowed<'a> {
return None;
};
let suffix_count = usize::... | 1 | 19 | 4 |
01af63aa143b78e2255c0f4ddfff6db0f793ec91 | Pratush Shyam Gupt | 2026-01-22T14:23:07 | ZeroTrie const builder now use mut pointers (#7444)
Fixes #7084
Previously, the const builder used a functional style where every
modification returned a new instance of the builder. This change allows
for in place mutation, significantly improving efficiency and
compile-time performance for large tries by avoiding ... | diff --git a/utils/zerotrie/src/builder/konst/builder.rs b/utils/zerotrie/src/builder/konst/builder.rs
index 9cb87131c6..09e6e43c0a 100644
--- a/utils/zerotrie/src/builder/konst/builder.rs
+++ b/utils/zerotrie/src/builder/konst/builder.rs
@@ -39,73 +39,63 @@ impl<const N: usize> ZeroTrieBuilderConst<N> {
/// Pre... | 4 | 45 | 73 |
4b7d4e42db5967c6339598fe4415bc3e76a78350 | Linus Groh | 2026-01-22T14:04:07 | Use consistent naming for {Composing,Decomposing}Normalizer FFI (#7183)
`DecomposingNormalizer`'s `is_normalized{,_up_to}` is the odd one out:
```console
$ git grep is_normalized ffi/capi/bindings/c/
ffi/capi/bindings/c/ComposingNormalizer.h:bool icu4x_ComposingNormalizer_is_normalized_utf8_mv1(const ComposingNormali... | diff --git a/ffi/capi/src/normalizer.rs b/ffi/capi/src/normalizer.rs
index 0c51af7687..c3b8921b15 100644
--- a/ffi/capi/src/normalizer.rs
+++ b/ffi/capi/src/normalizer.rs
@@ -285,7 +285,8 @@ pub mod ffi {
)]
#[diplomat::attr(not(supports = utf8_strings), disable)]
#[diplomat::attr(*, rename =... | 1 | 4 | 2 |
10258904e815de7877ef1c6b809636b926cebd10 | Shane F. Carr | 2026-01-22T13:54:34 | Add better docs on the relationship between Locale and DataLocale (#7382)
Extracted from #7346
We want these docs to be good especially with #7348
3.0 follow-up: #7381 | diff --git a/components/locale_core/src/data.rs b/components/locale_core/src/data.rs
index fc16d2825a..922d1a36b1 100644
--- a/components/locale_core/src/data.rs
+++ b/components/locale_core/src/data.rs
@@ -21,16 +21,32 @@ use core::str::FromStr;
/// [`LanguageIdentifier`] for better size and performance while still m... | 1 | 23 | 5 |
c989223a195ecdbd9c4a98085dce8bbbcc106bb2 | Kevin Ness | 2026-01-22T13:53:19 | Create encoding module and exposing EncodingType (#7316)
This PR creates a proper encoding module in `ixdtf` and exposes the
`EncodingType` trait to allow wrapping parsers to be generic on
`EncodingType`. | diff --git a/utils/ixdtf/src/core.rs b/utils/ixdtf/src/core.rs
index f6c4cf3513..a24a04cb34 100644
--- a/utils/ixdtf/src/core.rs
+++ b/utils/ixdtf/src/core.rs
@@ -4,82 +4,9 @@
//! Core functionality for `ixdtf`'s parsers
+use crate::encoding::EncodingType;
use crate::{ParseError, ParserResult};
-mod private {
-... | 11 | 100 | 89 |
3127f33b31e4978065c87271536fb44f41224226 | Shane F. Carr | 2026-01-22T11:07:53 | Add a few more Hijri docs (#7467)
Last bit from #7325 | diff --git a/components/calendar/src/cal/hijri.rs b/components/calendar/src/cal/hijri.rs
index 22f0bbdc37..0ac2a83351 100644
--- a/components/calendar/src/cal/hijri.rs
+++ b/components/calendar/src/cal/hijri.rs
@@ -71,6 +71,8 @@ mod ummalqura_data;
/// 2. [`TabularAlgorithm`] is based on a proleptic approximation of t... | 1 | 7 | 2 |
eaeb5316710b36f51eb888896e9ce03d85793dae | Robert Bastian | 2026-01-20T20:28:15 | Deprecate `AstronomicalSimulation` (#7455)
#7320 | diff --git a/components/calendar/benches/convert.rs b/components/calendar/benches/convert.rs
index 7e84fb364f..3a24ef65d9 100644
--- a/components/calendar/benches/convert.rs
+++ b/components/calendar/benches/convert.rs
@@ -61,6 +61,7 @@ fn convert_benches(c: &mut Criterion) {
bench_calendar(&mut group, "calendar... | 7 | 52 | 13 |
64284d042d4eaa0b950c169bfae4f63d0e7f955c | Shane F. Carr | 2026-01-20T20:15:24 | Add Clock12 and Clock24 hour cycles (#7414)
#3881
https://unicode-org.atlassian.net/browse/CLDR-18894 | diff --git a/components/datetime/src/fieldsets.rs b/components/datetime/src/fieldsets.rs
index d7a2d6821e..1bbd83e855 100644
--- a/components/datetime/src/fieldsets.rs
+++ b/components/datetime/src/fieldsets.rs
@@ -1146,62 +1146,85 @@ impl_calendar_period_marker!(
option_alignment = yes,
);
+#[cfg(doc)]
+use cr... | 8 | 215 | 43 |
1b6ff8eba134ae327a9f1ddb78a749f2f2034d97 | Robert Bastian | 2026-01-20T19:45:18 | Improve Iran sightings example (#7449)
Use a `LazyLock` to source the data from
https://github.com/roozbehp/qamari
I dropped the invariant that a `HijriYear` is 354 or 355 days long -
this invariant was not used by our code, and some years in
https://github.com/roozbehp/qamari have 353 days. | diff --git a/Cargo.lock b/Cargo.lock
index f4bc4551ff..e9d0f94ee8 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1389,6 +1389,7 @@ dependencies = [
"serde_json",
"smallvec",
"tinystr",
+ "ureq",
"writeable",
"zerotrie",
"zerovec",
diff --git a/components/calendar/src/cal/east_asian_traditional.rs b/components... | 7 | 208 | 201 |
9b2c929e195da504e1ea97c307769596d352cc52 | Shane F. Carr | 2026-01-20T19:41:29 | Pattern should always be VarULE (#7440)
Follow-up from #7411 | diff --git a/components/experimental/src/compactdecimal/formatter.rs b/components/experimental/src/compactdecimal/formatter.rs
index a8656b03a1..88d6088e73 100644
--- a/components/experimental/src/compactdecimal/formatter.rs
+++ b/components/experimental/src/compactdecimal/formatter.rs
@@ -592,7 +592,7 @@ impl CompactD... | 3 | 15 | 15 |
2571b8b442526a8808e3a4d11c4b6f088dc68dd8 | Robert Bastian | 2026-01-20T17:46:25 | Don't use `Arc` with `AnyCalendar` (#7434) | diff --git a/ffi/capi/src/calendar.rs b/ffi/capi/src/calendar.rs
index 130499f718..883bfa11e5 100644
--- a/ffi/capi/src/calendar.rs
+++ b/ffi/capi/src/calendar.rs
@@ -6,7 +6,6 @@
#[diplomat::abi_rename = "icu4x_{0}_mv1"]
pub mod ffi {
use alloc::boxed::Box;
- use alloc::sync::Arc;
#[cfg(feature = "buff... | 2 | 7 | 11 |
ce96b802c7ec8111598142d14e4aa1b84e8bbab1 | Robert Bastian | 2026-01-20T16:51:38 | Optimise the `Japanese` calendar (#7323)
With the Japanese calendars split (#7334 ), there is some optimisation
potential:
* For `Japanese`, we don't need to store the `DataPayload` with the full
map anymore. The five known eras are hardcoded in code anyway, so all we
have to store in the calendar object is the poten... | diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs
index 1d1e9216d9..461123db52 100644
--- a/components/calendar/src/any_calendar.rs
+++ b/components/calendar/src/any_calendar.rs
@@ -688,6 +688,52 @@ impl AnyCalendar {
})
}
+ #[cfg(feature = "datagen")]
+ ... | 7 | 308 | 152 |
a02234062fd8c9372cfc1bf98405061a2d471fcb | Robert Bastian | 2026-01-18T09:49:00 | Deprecate `LanguagePreferences` field accessors (#7401)
Callers should convert to `DataLocale` (choosing the fallback mode) and
then access the fields. | diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs
index 157798aed6..d0db9a8a7d 100644
--- a/components/calendar/src/any_calendar.rs
+++ b/components/calendar/src/any_calendar.rs
@@ -9,22 +9,11 @@
use crate::cal::*;
use crate::{AsCalendar, Calendar, Date, Ref};
-use crate... | 10 | 127 | 94 |
e5a29a7d591157e8906bbd3f00021f164031f7cd | Robert Bastian | 2026-01-15T21:50:10 | Add more ULE `const` constructors for integers and floats (#7433)
Split from #7323 | diff --git a/components/collator/src/provider.rs b/components/collator/src/provider.rs
index a6bcb4f05e..ee9384d26c 100644
--- a/components/collator/src/provider.rs
+++ b/components/collator/src/provider.rs
@@ -21,7 +21,7 @@
use icu_collections::char16trie::Char16TrieIterator;
use icu_collections::codepointtrie::Code... | 3 | 82 | 108 |
30c187f4b7dbb6df3a0ca936481461f8ac5a53a2 | Robert Bastian | 2026-01-14T21:10:21 | FIx overflow in `PluralOperands` constructor (#7425)
Split from #7411 | diff --git a/components/plurals/src/operands.rs b/components/plurals/src/operands.rs
index ab86288f99..78b0dd3e2f 100644
--- a/components/plurals/src/operands.rs
+++ b/components/plurals/src/operands.rs
@@ -238,8 +238,8 @@ impl PluralOperands {
let exp_i16 = i16::from(exp);
let mag_range = dec.absol... | 1 | 2 | 2 |
c5947970da934171c8dcece53151a7171fda59a8 | Younies Mahmoud | 2026-01-14T18:00:28 | Move script-based locale grouping helper (#7426) | diff --git a/provider/source/src/cldr_cache.rs b/provider/source/src/cldr_cache.rs
index 28dcd44525..90c09823ef 100644
--- a/provider/source/src/cldr_cache.rs
+++ b/provider/source/src/cldr_cache.rs
@@ -226,6 +226,39 @@ impl CldrCache {
langid.region = locale.region;
Ok(Some(langid.into()))
}
+
+... | 2 | 34 | 15 |
5de88e25e31ebec20dc5236640c8e655e3825284 | Manish Goregaokar | 2026-01-13T17:46:41 | Correctly parse ethiopic-amete-alem alias (#7413)
`ethiopic-amete-alem` currently parses to `CalendarAlgorithm::Ethiopic`,
which is incorrect and causes V8 to fail a test262 test. This is because
our subtag parsing ignores subtags after the first for enum keywords,
unless we have explicitly defined the enum keyword as... | diff --git a/components/locale_core/src/preferences/extensions/unicode/keywords/calendar.rs b/components/locale_core/src/preferences/extensions/unicode/keywords/calendar.rs
index 2f65e4e4dc..0c18baf0b7 100644
--- a/components/locale_core/src/preferences/extensions/unicode/keywords/calendar.rs
+++ b/components/locale_co... | 1 | 43 | 1 |
4e08c56f6e49b40b5c4844d2c1c240a0eb729ca3 | Pratush Shyam Gupt | 2026-01-13T17:43:18 | yoke: impl common traits (Display, PartialEq/Eq, PartialOrd/Ord) (#7400)
Addreses #7063
Implemented several standard traits for `Yoke<Y, C>` by forwarding to
the borrowed view returned by `Yoke::get()`
Added:
- `Display`
- `PartialEq` and `Eq`
- `PartialOrd` and `Ord`
Also added unit tests for the above | diff --git a/utils/yoke/src/yoke.rs b/utils/yoke/src/yoke.rs
index df4a7b85c2..b3d3e61bb0 100644
--- a/utils/yoke/src/yoke.rs
+++ b/utils/yoke/src/yoke.rs
@@ -106,6 +106,53 @@ where
}
}
+impl<Y, C> core::fmt::Display for Yoke<Y, C>
+where
+ Y: for<'a> Yokeable<'a>,
+ for<'a> <Y as Yokeable<'a>>::Output: c... | 1 | 93 | 0 |
a2fb87f91fbd5f97458e1f6418be05a0c41137c0 | Younies Mahmoud | 2026-01-12T22:31:18 | polish: Update comments for currency data structures to enhance clarity (#7405) | diff --git a/components/experimental/src/dimension/provider/currency/essentials.rs b/components/experimental/src/dimension/provider/currency/essentials.rs
index 6c20b881a6..0cc9260341 100644
--- a/components/experimental/src/dimension/provider/currency/essentials.rs
+++ b/components/experimental/src/dimension/provider/... | 2 | 16 | 12 |
934ead625722d1dd93cc677fd1dbdf4cee11603d | Shane F. Carr | 2026-01-12T20:18:42 | Add serde cargo feature comments to icu_provider buf/serde.rs (#7408)
#7374 | diff --git a/provider/core/src/buf/serde.rs b/provider/core/src/buf/serde.rs
index 6e3b3823b7..86bf303ff8 100644
--- a/provider/core/src/buf/serde.rs
+++ b/provider/core/src/buf/serde.rs
@@ -24,6 +24,8 @@ use yoke::Yokeable;
pub struct DeserializingBufferProvider<'a, P: ?Sized>(&'a P);
/// Blanket-implemented trait... | 1 | 12 | 0 |
5f9fec132f5742891e544e3bf5f595bcd9d5946f | Robert Bastian | 2026-01-12T19:48:05 | Adapt `UnicodeSet` builder warning (#7407)
Currently the set `[^ [i ɪ e {e̞}] j ʝ]` triggers this warning. However,
the "e̞" string is excluded from the inverted set because the 'e' code
point is as well, so that's fine. | diff --git a/components/collections/src/codepointinvlist/builder.rs b/components/collections/src/codepointinvlist/builder.rs
index d12cba3862..3600a06b22 100644
--- a/components/collections/src/codepointinvlist/builder.rs
+++ b/components/collections/src/codepointinvlist/builder.rs
@@ -13,7 +13,7 @@ use zerovec::{ule::... | 2 | 13 | 5 |
0f1a323f085450267f8393b938f5abb40b3d75d7 | Shane F. Carr | 2026-01-12T18:27:05 | Add writeable::adapters::Concat and writeable::concat_writeable! (#6929) | diff --git a/utils/writeable/src/cmp.rs b/utils/writeable/src/cmp.rs
index 5f0050e268..1f8814b164 100644
--- a/utils/writeable/src/cmp.rs
+++ b/utils/writeable/src/cmp.rs
@@ -97,6 +97,26 @@ pub fn cmp_utf8(writeable: &impl Writeable, other: &[u8]) -> Ordering {
/// assert_eq!(Ordering::Less, writeable::cmp_str(&messag... | 3 | 171 | 0 |
fe4607ced3f1fc64faab6b84e39bd2aa82fa616e | Robert Bastian | 2026-01-10T14:29:58 | Fix imports (#7397) | diff --git a/provider/source/src/datetime/semantic_skeletons/tests.rs b/provider/source/src/datetime/semantic_skeletons/tests.rs
index 0d7889b7db..59f7d01674 100644
--- a/provider/source/src/datetime/semantic_skeletons/tests.rs
+++ b/provider/source/src/datetime/semantic_skeletons/tests.rs
@@ -4,12 +4,6 @@
use super... | 1 | 4 | 9 |
ddcf86b51196ae7e59dbe129f8cce108774b4552 | Shane F. Carr | 2026-01-10T00:03:18 | FourBitMetadata should be checked against 0x10 or 0x0F, not 0x80 (#7395)
Split from #7394 | diff --git a/components/plurals/src/provider.rs b/components/plurals/src/provider.rs
index d9b9f6ff6c..149dd5d619 100644
--- a/components/plurals/src/provider.rs
+++ b/components/plurals/src/provider.rs
@@ -637,7 +637,7 @@ pub struct FourBitMetadata(u8);
impl FourBitMetadata {
/// Creates a [`FourBitMetadata`] if... | 1 | 3 | 3 |
0647cf4266ab0671d93f873b340173cc392fd572 | Shane F. Carr | 2026-01-09T22:27:19 | Create SinglePlaceholderPattern::PASS_THROUGH (#7393) | diff --git a/components/experimental/src/compactdecimal/provider.rs b/components/experimental/src/compactdecimal/provider.rs
index a47d7c6a9d..1da8a835d6 100644
--- a/components/experimental/src/compactdecimal/provider.rs
+++ b/components/experimental/src/compactdecimal/provider.rs
@@ -97,9 +97,7 @@ fn validate_plural_... | 2 | 25 | 3 |
9d626e19778961cd2b0855ee614247ea35ffb6a3 | Shane F. Carr | 2026-01-09T21:53:43 | Change doc comment language to "this type" (#7392)
Follow-up to
https://github.com/unicode-org/icu4x/pull/7330#discussion_r2677216188 | diff --git a/components/calendar/src/cal/hijri.rs b/components/calendar/src/cal/hijri.rs
index d0a9048607..9c859d2317 100644
--- a/components/calendar/src/cal/hijri.rs
+++ b/components/calendar/src/cal/hijri.rs
@@ -283,7 +283,7 @@ impl Rules for UmmAlQura {
/// The most common version of these rules uses [`TabularAlgo... | 1 | 1 | 1 |
1de244a4d8caf7c8d1d960a0f965b2b725273f52 | Shane F. Carr | 2026-01-09T21:36:58 | Improve safety comment and test for PLURAL_PATTERN_0 (#7391) | diff --git a/components/experimental/src/compactdecimal/provider.rs b/components/experimental/src/compactdecimal/provider.rs
index 4da8a07220..a47d7c6a9d 100644
--- a/components/experimental/src/compactdecimal/provider.rs
+++ b/components/experimental/src/compactdecimal/provider.rs
@@ -71,6 +71,7 @@ pub struct CompactD... | 1 | 5 | 3 |
31f0b44365d8207827635b90603992a17ffa560c | Robert Bastian | 2026-01-09T18:40:13 | Round fractional compact decimals to two significant digits (#7389)
#4241 | diff --git a/components/experimental/src/compactdecimal/formatter.rs b/components/experimental/src/compactdecimal/formatter.rs
index 0a9ebba7cf..d39d8e8bcd 100644
--- a/components/experimental/src/compactdecimal/formatter.rs
+++ b/components/experimental/src/compactdecimal/formatter.rs
@@ -467,6 +467,10 @@ impl Compact... | 1 | 10 | 7 |
40c74020d50784d692d83b31dc94f9c5a1846200 | Shane F. Carr | 2026-01-09T18:34:48 | Add paragraphs about crescent moon visibility to Hijri docs (#7330) | diff --git a/components/calendar/src/cal/hijri.rs b/components/calendar/src/cal/hijri.rs
index ae0c86ecce..d0a9048607 100644
--- a/components/calendar/src/cal/hijri.rs
+++ b/components/calendar/src/cal/hijri.rs
@@ -57,6 +57,22 @@ mod ummalqura_data;
///
/// There are either 6 or 7 30-day months, so the length of the ... | 1 | 20 | 0 |
e83a3e4a0c5c7453ecff749625731b9d9e77b3bc | Manish Goregaokar | 2026-01-09T18:25:54 | Clean up neo datagen (#7386)
I found the code organization to be pretty straightforward, I mostly
just renamed it into names.rs and skeletons.rs.
There is some glue pattern code in names.rs, which was proving a bit
more involved to move around.
There are no changes here other than code being moved around and
reforma... | diff --git a/provider/source/src/datetime/skeletons.rs b/provider/source/src/datetime/available_formats.rs
similarity index 99%
rename from provider/source/src/datetime/skeletons.rs
rename to provider/source/src/datetime/available_formats.rs
index 196cd8cb3c..4d635ac241 100644
--- a/provider/source/src/datetime/skeleto... | 5 | 559 | 544 |
705de57bde52c0b02721c0215a971ca4f28fc98d | Robert Bastian | 2026-01-07T20:55:49 | Clean up `FormattableAnyCalendar` (#7318) | diff --git a/components/datetime/src/external_loaders.rs b/components/datetime/src/external_loaders.rs
index 4a536e5913..2e6cbd541a 100644
--- a/components/datetime/src/external_loaders.rs
+++ b/components/datetime/src/external_loaders.rs
@@ -4,11 +4,12 @@
//! Internal traits and structs for loading data from other ... | 5 | 106 | 191 |
28f125cdbff7274aad743021dd7396ee2815cae5 | Shane F. Carr | 2026-01-07T20:09:53 | Add docs tests for SubdivisionId and preferences types (#7347)
Split from #7335 | diff --git a/components/locale_core/src/extensions/unicode/subdivision.rs b/components/locale_core/src/extensions/unicode/subdivision.rs
index c4c39414e7..eb1708b7b0 100644
--- a/components/locale_core/src/extensions/unicode/subdivision.rs
+++ b/components/locale_core/src/extensions/unicode/subdivision.rs
@@ -74,6 +74,... | 3 | 97 | 0 |
844910b18d3fb1d1d64c357ec95fc091f473c920 | Caleb Koo | 2026-01-07T03:55:38 | Dense zero trie Out of Range handling #7303 (#7305)
Working on https://github.com/unicode-org/icu4x/issues/7303.
When creating a dense sparse zerotrie, if the incoming values are too
spread out for a dense matrix:
- Select the row offset that gets the greatest number of values into the
dense matrix.
- Put all out-of-... | diff --git a/utils/zerotrie/src/builder/dense.rs b/utils/zerotrie/src/builder/dense.rs
index fb5128b957..28b26ea1db 100644
--- a/utils/zerotrie/src/builder/dense.rs
+++ b/utils/zerotrie/src/builder/dense.rs
@@ -28,6 +28,32 @@ pub(crate) struct DenseSparse2dAsciiWithFixedDelimiterBuilder<'a> {
}
impl<'a> DenseSparse... | 2 | 70 | 8 |
9725af9f6a903fdc943d67091eaa9245a9e34bab | Manish Goregaokar | 2026-01-07T03:49:02 | Remove legacy datetime datagen code, preserving still-relevant tests (#7383)
Progress on #5613
The only thing left was tests. There were only a few tests:
- `test_basic_symbols`: preserved
- `unalias_symbols`: Names deduplication is handled by our data infra,
not by datetime-specific Option-ing
- `test_missing_app... | diff --git a/provider/source/src/datetime/legacy.rs b/provider/source/src/datetime/legacy.rs
deleted file mode 100644
index 788d1fe260..0000000000
--- a/provider/source/src/datetime/legacy.rs
+++ /dev/null
@@ -1,654 +0,0 @@
-// This file is part of ICU4X. For terms of use, please see the file
-// called LICENSE at the ... | 3 | 43 | 656 |
d4bc3f6905c104a0d6aac320b22d851e171a34bc | Robert Bastian | 2026-01-06T20:02:23 | Add `LocalePreferences::from_locale_strict` (#7377)
We already have this on preferences generate by the macro.
#6628
#7362 | diff --git a/components/datetime/src/pattern/names.rs b/components/datetime/src/pattern/names.rs
index 9cd1cc4d24..5a0e206039 100644
--- a/components/datetime/src/pattern/names.rs
+++ b/components/datetime/src/pattern/names.rs
@@ -371,7 +371,7 @@ where
size_test!(
FixedCalendarDateTimeNames<icu_calendar::Gregoria... | 3 | 142 | 69 |
f49d832749347ff4381765f7cb132077a35ebb5b | Robert Bastian | 2026-01-06T16:11:28 | Respect `-u-rg` in calendar resolution (#7376)
#4413
Should respect `-u-rg` per
https://github.com/unicode-org/cldr/blob/main/common/supplemental/rgScope.xml | diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs
index 83904adade..8b8c8ab414 100644
--- a/components/calendar/src/any_calendar.rs
+++ b/components/calendar/src/any_calendar.rs
@@ -711,6 +711,18 @@ pub enum AnyCalendarKind {
impl CalendarPreferences {
/// Selects th... | 2 | 20 | 1 |
9a6930f96e7e43a72afd508ff71e238a0b309818 | Robert Bastian | 2026-01-05T20:56:48 | Add `CodePointInversionListAndStringList::contains_utf8` (#7363)
For #7358 | diff --git a/Cargo.lock b/Cargo.lock
index 9806f4265e..7f887b691b 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1346,6 +1346,7 @@ dependencies = [
"serde",
"serde_json",
"toml",
+ "utf8_iter",
"yoke",
"zerofrom",
"zerovec",
diff --git a/components/collections/Cargo.toml b/components/collections/Cargo.toml
in... | 8 | 37 | 8 |
51836a8aefe1d0166bb9faec14ef113c98be79b5 | Robert Bastian | 2026-01-05T20:53:03 | Fix `LanguageIdentifier::normalize_utf8` example (#7372) | diff --git a/components/locale_core/src/langid.rs b/components/locale_core/src/langid.rs
index 0f8001c012..3a8a4d99ba 100644
--- a/components/locale_core/src/langid.rs
+++ b/components/locale_core/src/langid.rs
@@ -190,7 +190,7 @@ impl LanguageIdentifier {
/// use icu::locale::LanguageIdentifier;
///
///... | 1 | 1 | 1 |
04a93b1b2dc6c0503cdc63f04b4e415a4012103c | Shane F. Carr | 2025-12-31T08:43:02 | Improve the WeekInformation test (#7350)
Feedback from #7335
Demonstrates that #4413 is fixed | diff --git a/components/calendar/src/week.rs b/components/calendar/src/week.rs
index 00c1efef29..9c428e07d5 100644
--- a/components/calendar/src/week.rs
+++ b/components/calendar/src/week.rs
@@ -28,7 +28,7 @@ define_preferences!(
/// ```
/// use icu::calendar::week::WeekInformation;
/// use icu::calendar::types::Wee... | 1 | 6 | 2 |
884fe8537431f35cb8eea9a4564f6aae33832e8f | Robert Bastian | 2025-12-30T12:01:19 | Use better types in `LocalePreferences` (#7360)
Split off from #7341
The existing types `RegionalSubdivision` and `RegionOverride` already
have functionality to convert from/to `Value`s, so we don't need to
duplicate that. | diff --git a/components/locale_core/src/data.rs b/components/locale_core/src/data.rs
index 5143bf23b1..e0ef281cdd 100644
--- a/components/locale_core/src/data.rs
+++ b/components/locale_core/src/data.rs
@@ -3,6 +3,7 @@
// (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ).
use crate::extensions::u... | 4 | 68 | 66 |
685d6ace2d399c9aeadf8e464f7db61f4ad48ad2 | Shane F. Carr | 2025-12-29T19:50:39 | Resolve TODO in fallback code by adding docs (#7348)
Split from #7335 | diff --git a/components/locale/src/fallback/algorithms.rs b/components/locale/src/fallback/algorithms.rs
index 7e9e5f0419..955b69c6c9 100644
--- a/components/locale/src/fallback/algorithms.rs
+++ b/components/locale/src/fallback/algorithms.rs
@@ -127,7 +127,6 @@ impl LocaleFallbackIteratorInner<'_> {
}
fn s... | 2 | 4 | 2 |
3bd88a95ab4cf8e251d74641bbe97bfb4552ac86 | Shane F. Carr | 2025-12-27T00:26:09 | Prefer DataLocale::default over locale!("und") (#7349)
Split from #7346 | diff --git a/components/decimal/src/lib.rs b/components/decimal/src/lib.rs
index 107df93671..61503a4be1 100644
--- a/components/decimal/src/lib.rs
+++ b/components/decimal/src/lib.rs
@@ -103,7 +103,6 @@ pub(crate) mod size_test_macro;
pub use format::FormattedDecimal;
use fixed_decimal::Decimal;
-use icu_locale_cor... | 1 | 4 | 4 |
9844a298e11a26b0e0e174b9d004142357f52585 | Robert Bastian | 2025-12-23T09:20:08 | Add full support for `U` datetime symbol (#7328) | diff --git a/components/datetime/src/format/datetime.rs b/components/datetime/src/format/datetime.rs
index 7ea60e32c6..041d3a6ab3 100644
--- a/components/datetime/src/format/datetime.rs
+++ b/components/datetime/src/format/datetime.rs
@@ -175,21 +175,35 @@ where
(FieldSymbol::Year(Year::Cyclic), l) => {
... | 2 | 69 | 11 |
f16ea510216a4f5a1f184c6db4aaed2e6ed60d8c | Robert Bastian | 2025-12-22T18:29:43 | Fix locale region override (#7337)
Simpler version of #7335 | diff --git a/components/calendar/src/week.rs b/components/calendar/src/week.rs
index 9414b4bb65..00c1efef29 100644
--- a/components/calendar/src/week.rs
+++ b/components/calendar/src/week.rs
@@ -22,6 +22,26 @@ define_preferences!(
);
/// Information about the first day of the week and the weekend.
+///
+/// # Examp... | 5 | 109 | 30 |
b0aa6a0e9b31baa6fa4769f3e413b00d0f390ae3 | Shane F. Carr | 2025-12-19T23:05:20 | Fix error handling and add more tests for FieldSetBuilder (#7245)
Fixes #6374 | diff --git a/components/datetime/src/builder.rs b/components/datetime/src/builder.rs
index 58bccb3c18..bfc7f8ba8c 100644
--- a/components/datetime/src/builder.rs
+++ b/components/datetime/src/builder.rs
@@ -272,6 +272,25 @@ pub enum BuilderError {
/// assert!(superfluous_options.year_style.is_some());
/// ass... | 1 | 382 | 13 |
2060b8494604d7882ca9dade0ce7254097d97fa8 | Robert Bastian | 2025-12-19T19:30:44 | Untangle Japanese calendars (#7334) | diff --git a/components/calendar/src/cal/japanese.rs b/components/calendar/src/cal/japanese.rs
index 7bf82229d8..6923b3ef95 100644
--- a/components/calendar/src/cal/japanese.rs
+++ b/components/calendar/src/cal/japanese.rs
@@ -73,7 +73,9 @@ pub struct Japanese {
/// These eras are loaded from data, requiring a data pr... | 6 | 297 | 211 |
94adc4134432b4a99435d49576863294f27fd15b | Shane F. Carr | 2025-12-19T18:27:08 | Replace obsolete floating-point claim with a specific year range (#7333)
Split from #7325 | diff --git a/components/calendar/src/cal/hijri.rs b/components/calendar/src/cal/hijri.rs
index 8d0b6e8b7c..ae0c86ecce 100644
--- a/components/calendar/src/cal/hijri.rs
+++ b/components/calendar/src/cal/hijri.rs
@@ -134,8 +134,8 @@ pub trait Rules: Clone + Debug + crate::cal::scaffold::UnstableSealed {
/// on the groun... | 1 | 2 | 2 |
6dbf1701483540c0d9e68c7a89d8a037930f09a1 | Shane F. Carr | 2025-12-19T18:26:56 | Cite Reingold and Shaukat in the AstronomicalSimulation docs (#7332)
Split from #7325
Depends on #7331 | diff --git a/components/calendar/src/cal/hijri.rs b/components/calendar/src/cal/hijri.rs
index 032e7b73b7..8d0b6e8b7c 100644
--- a/components/calendar/src/cal/hijri.rs
+++ b/components/calendar/src/cal/hijri.rs
@@ -129,7 +129,8 @@ pub trait Rules: Clone + Debug + crate::cal::scaffold::UnstableSealed {
/// [`Hijri`] ... | 1 | 4 | 1 |
2d0ff9162db03178b8f767b0e17c4e4f6425c43b | Shane F. Carr | 2025-12-19T18:26:42 | Add docs about the Skaukat criterion to calendrical_calculations (#7331)
Split from #7325 | diff --git a/utils/calendrical_calculations/src/islamic.rs b/utils/calendrical_calculations/src/islamic.rs
index b14e542a24..53f93f1eba 100644
--- a/utils/calendrical_calculations/src/islamic.rs
+++ b/utils/calendrical_calculations/src/islamic.rs
@@ -55,7 +55,13 @@ pub fn fixed_from_observational_islamic(
- 1
... | 1 | 6 | 0 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.