commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
81baebaf9a8b0796c535cc392c1f9d932da310de
Robert Bastian
2023-02-08T22:49:54
Make crlify work on CRLF files. (#3095)
diff --git a/utils/crlify/src/lib.rs b/utils/crlify/src/lib.rs index 1df5298259..3bf882eb99 100644 --- a/utils/crlify/src/lib.rs +++ b/utils/crlify/src/lib.rs @@ -8,43 +8,48 @@ use std::io::{BufWriter, Result, Write}; /// A small helper class to convert LF to CRLF on Windows. /// Workaround for <https://github.com/...
1
24
19
79e2bcdccb09f92e6f76890b03150c10eb52d2b7
Manish Goregaokar
2023-02-08T03:11:36
Remove all dependencies on `spin`, bump icu_testdata to 1.1.2 (#3091) * Remove lazy_static dep of testdata * Bump icu_testdata to 1.1.2
diff --git a/Cargo.lock b/Cargo.lock index 6f70aee6b2..0612060395 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1217,7 +1217,7 @@ dependencies = [ "hash32", "rustc_version 0.4.0", "serde", - "spin 0.9.4", + "spin", "stable_deref_trait", ] @@ -1937,7 +1937,7 @@ dependencies = [ [[package]] name = "icu_test...
4
19
30
aac86065741fcedb8ada9464983390c7516ac489
Robert Bastian
2023-02-03T19:37:02
Fix certain nightlies (#3076)
diff --git a/utils/writeable/src/impls.rs b/utils/writeable/src/impls.rs index a2b5201e08..a165242769 100644 --- a/utils/writeable/src/impls.rs +++ b/utils/writeable/src/impls.rs @@ -29,6 +29,7 @@ macro_rules! impl_write_num { } fn writeable_length_hint(&self) -> $crate::LengthHint { + ...
1
1
0
af55f9a72a9cbf21215f5ce479bc1b138712ded6
Zibi Braniecki
2023-02-02T19:01:22
[locid_transform] Do not allocate vectors in bench (#2933)
diff --git a/components/locid_transform/benches/locale_canonicalizer.rs b/components/locid_transform/benches/locale_canonicalizer.rs index 0560bb2dba..97e8f65469 100644 --- a/components/locid_transform/benches/locale_canonicalizer.rs +++ b/components/locid_transform/benches/locale_canonicalizer.rs @@ -4,7 +4,7 @@ mo...
1
24
18
4d2ef77cc6992bcab036f1df2ccf0e0f4021fe22
Robert Bastian
2023-02-01T18:49:58
Update tutorials-test (#3061)
diff --git a/tools/tutorials-test/src/lib.rs b/tools/tutorials-test/src/lib.rs index 99c73127d3..84df8d1494 100644 --- a/tools/tutorials-test/src/lib.rs +++ b/tools/tutorials-test/src/lib.rs @@ -2,11 +2,19 @@ // called LICENSE at the top level of the ICU4X source tree // (online at: https://github.com/unicode-org/icu...
1
16
8
5676590e48db3ccf3691c957a06fa8c476a40420
Robert Bastian
2023-01-31T15:45:47
Fixing old-style databake (#3050)
diff --git a/Cargo.lock b/Cargo.lock index 6a2b7e4de7..cc5ded8eeb 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1553,7 +1553,7 @@ dependencies = [ [[package]] name = "icu_datagen" -version = "1.1.0" +version = "1.1.1" dependencies = [ "cached-path", "clap", diff --git a/provider/datagen/Cargo.toml b/provider/da...
4
4
4
68a8aa88a799b4cd2078bfedc41ebc27f7c3d35f
Ting-Yu Lin
2023-01-25T22:50:30
Remove redundant blocks in complex.rs (#3029)
diff --git a/experimental/segmenter/src/complex.rs b/experimental/segmenter/src/complex.rs index 985d0963d7..97a2189d60 100644 --- a/experimental/segmenter/src/complex.rs +++ b/experimental/segmenter/src/complex.rs @@ -70,16 +70,14 @@ pub fn complex_language_segment_utf16( for str_per_lang in lang_iter { ...
1
16
20
78e6a90cd62261d237029e48415511429bb26998
Manish Goregaokar
2023-01-23T20:07:23
Fix soundness issue in Yoke::attach_to_cart() around implied bounds (#2949) * Fix soundness issue * rm IsCovariant
diff --git a/utils/yoke/derive/src/lib.rs b/utils/yoke/derive/src/lib.rs index 4b638e6b9c..4c53bef684 100644 --- a/utils/yoke/derive/src/lib.rs +++ b/utils/yoke/derive/src/lib.rs @@ -81,8 +81,6 @@ fn yokeable_derive_impl(input: &DeriveInput) -> TokenStream2 { f(self) } ...
6
166
159
2705d20d28e06b1d616b646fe4b92528c2c937e2
Robert Bastian
2023-01-23T19:30:47
Using `core` integer log when available (#3015)
diff --git a/utils/writeable/src/impls.rs b/utils/writeable/src/impls.rs index 88613eb8da..a2b5201e08 100644 --- a/utils/writeable/src/impls.rs +++ b/utils/writeable/src/impls.rs @@ -7,12 +7,12 @@ use alloc::borrow::Cow; use core::fmt; macro_rules! impl_write_num { - ($u:ty, $i:ty, $test:ident, $log10:ident) => ...
1
52
47
bd7c1bbbe68c8417e713313611e1b2fed1391ae9
Robert Bastian
2023-01-23T18:06:39
Removing `slice::from_raw_parts` canaries (#3016)
diff --git a/provider/core/src/key.rs b/provider/core/src/key.rs index e9cb330504..d4d6905c9f 100644 --- a/provider/core/src/key.rs +++ b/provider/core/src/key.rs @@ -140,12 +140,6 @@ impl DataKeyPath { /// Gets the path as a static string slice. #[inline] pub const fn get(self) -> &'static str { - ...
5
6
45
5ba22c9d6ed287c8195c45a6bc2e6430cf574791
bheylin
2023-01-21T20:18:31
Add `std` feature to `tinystr` and std:*:Error impl (#3009)
diff --git a/utils/tinystr/Cargo.toml b/utils/tinystr/Cargo.toml index b05f900775..e7b0eeb42b 100644 --- a/utils/tinystr/Cargo.toml +++ b/utils/tinystr/Cargo.toml @@ -44,6 +44,7 @@ tinystr_old = { version = "0.4", package = "tinystr", features = ["serde"] } default = ["alloc"] alloc = [] bench = [] +std = [] [pac...
3
5
1
20b636b12b7a277685d0369f3c5874c9bb444b65
Ting-Yu Lin
2023-01-20T10:07:04
Fix allow attribute in test_bake macro (#3011) Without this patch, running `cargo +nightly check --all-features --all-targets` locally generates the following warning. ``` warning: unknown lint: `unused_variable` ```
diff --git a/utils/databake/src/lib.rs b/utils/databake/src/lib.rs index 9586ecbd32..bb5431d194 100644 --- a/utils/databake/src/lib.rs +++ b/utils/databake/src/lib.rs @@ -179,7 +179,7 @@ macro_rules! test_bake { )? assert_eq!(bake, expected_bake); - #[allow(unused_variable)] + #[allow(...
1
1
1
9c25bbd04e4c9de8a77cc1e1cfae6c82ea690962
Robert Bastian
2023-01-19T18:04:01
Not allocating `Writeable`s for regex evaluation (#2991)
diff --git a/components/list/src/lazy_automaton.rs b/components/list/src/lazy_automaton.rs new file mode 100644 index 0000000000..3431b3c9da --- /dev/null +++ b/components/list/src/lazy_automaton.rs @@ -0,0 +1,79 @@ +// This file is part of ICU4X. For terms of use, please see the file +// called LICENSE at the top leve...
3
82
7
53fdca1a8ee4a1cfaed254511983ca8492e33fef
Robert Bastian
2023-01-18T19:02:40
Fix datagen test (#3000)
diff --git a/provider/datagen/Cargo.toml b/provider/datagen/Cargo.toml index 41af0a3cbe..2b1f1d75cb 100644 --- a/provider/datagen/Cargo.toml +++ b/provider/datagen/Cargo.toml @@ -92,7 +92,7 @@ simple_logger = { version = "1.12", optional = true, default-features = false } [dev-dependencies] dhat = "0.3.0" -icu_test...
1
1
1
b9de68adb05fc8a23ce5475ab640807b55b9ba5b
Robert Bastian
2023-01-17T16:09:03
Setting correct DataError for .as_deserializing(), .as_downcasting() (#2993)
diff --git a/provider/core/src/any.rs b/provider/core/src/any.rs index 3d41e50625..989438c6b9 100644 --- a/provider/core/src/any.rs +++ b/provider/core/src/any.rs @@ -391,7 +391,10 @@ where { #[inline] fn load(&self, req: DataRequest) -> Result<DataResponse<M>, DataError> { - self.0.load_any(M::KEY, r...
2
13
7
30522939382516dcc6a632ea277e58302954c578
Shane F. Carr
2023-01-16T14:02:12
Add more inner_mut functions in icu_provider_adapters (#2987)
diff --git a/ffi/diplomat/ffi_coverage/src/main.rs b/ffi/diplomat/ffi_coverage/src/main.rs index 3ad18a2c4d..f2db65da43 100644 --- a/ffi/diplomat/ffi_coverage/src/main.rs +++ b/ffi/diplomat/ffi_coverage/src/main.rs @@ -470,6 +470,7 @@ lazy_static::lazy_static! { // Decompositions of providers is tricky to do o...
3
11
0
65bd1954115544f2f49b89737238bf337ccd0284
Shane F. Carr
2023-01-14T05:52:43
Fix error propagation in MultiForkByErrorProvider (#2986)
diff --git a/provider/adapters/src/fork/by_error.rs b/provider/adapters/src/fork/by_error.rs index 81f60c872e..4d6337b3ed 100644 --- a/provider/adapters/src/fork/by_error.rs +++ b/provider/adapters/src/fork/by_error.rs @@ -168,15 +168,16 @@ where key: DataKey, req: DataRequest, ) -> Result<DataRe...
1
15
9
6b572258d79b7d6fa5fbd44808017015c3b0f88f
Shane F. Carr
2023-01-12T08:48:02
Restore docs from PR #2278 (#2979)
diff --git a/utils/zerovec/src/ule/mod.rs b/utils/zerovec/src/ule/mod.rs index 29c7d0ecdb..e8ecd26e51 100644 --- a/utils/zerovec/src/ule/mod.rs +++ b/utils/zerovec/src/ule/mod.rs @@ -283,6 +283,12 @@ where /// "12.3e3" are logically equal, but not byte-for-byte equal, so we could define a canonical form /// where onl...
3
22
2
0c0b3985d8a71e521cb8e438097a43bdb08aa0d9
Shane F. Carr
2023-01-12T08:05:20
Change the signature of newly added inner_mut function (#2977) Changes 323ecbe8c1ba9092ae323ee069a5e0f090ecac8f
diff --git a/provider/adapters/src/fork/by_error.rs b/provider/adapters/src/fork/by_error.rs index 7a5cfafa06..81f60c872e 100644 --- a/provider/adapters/src/fork/by_error.rs +++ b/provider/adapters/src/fork/by_error.rs @@ -142,9 +142,9 @@ impl<P, F> MultiForkByErrorProvider<P, F> { &self.providers } - ...
1
3
3
5ca97abd20541fcdd5ae2dff41cf4a4b76addc67
Shane F. Carr
2023-01-12T01:37:17
Fix cargo check --all-targets --no-default-features (#2978)
diff --git a/components/datetime/benches/datetime.rs b/components/datetime/benches/datetime.rs index 85fb4b1518..1fddeb4e43 100644 --- a/components/datetime/benches/datetime.rs +++ b/components/datetime/benches/datetime.rs @@ -11,9 +11,11 @@ use icu_calendar::{DateTime, Gregorian}; use icu_datetime::TypedDateTimeForma...
2
4
2
323ecbe8c1ba9092ae323ee069a5e0f090ecac8f
Shane F. Carr
2023-01-10T20:40:07
Add mutation methods to MultiForkByErrorProvider (#2972)
diff --git a/provider/adapters/src/fork/by_error.rs b/provider/adapters/src/fork/by_error.rs index 5069229fa2..7a5cfafa06 100644 --- a/provider/adapters/src/fork/by_error.rs +++ b/provider/adapters/src/fork/by_error.rs @@ -142,10 +142,20 @@ impl<P, F> MultiForkByErrorProvider<P, F> { &self.providers } +...
1
10
0
6d17b9a9e93732ed9c3910676b4e1551a9630537
Robert Bastian
2023-01-10T19:12:34
Fix tz offset bounds (#2955)
diff --git a/components/timezone/src/error.rs b/components/timezone/src/error.rs index 0c692af839..5d281bddaf 100644 --- a/components/timezone/src/error.rs +++ b/components/timezone/src/error.rs @@ -15,7 +15,7 @@ impl std::error::Error for TimeZoneError {} #[non_exhaustive] pub enum TimeZoneError { /// An input ...
3
20
29
7617802eb321af3693382c88e5a9503a9bbe9bb3
Robert Bastian
2023-01-10T10:06:37
Unstable doc for provider modules (#2968)
diff --git a/components/calendar/src/provider.rs b/components/calendar/src/provider.rs index a5b53db413..df1956850b 100644 --- a/components/calendar/src/provider.rs +++ b/components/calendar/src/provider.rs @@ -2,7 +2,13 @@ // called LICENSE at the top level of the ICU4X source tree // (online at: https://github.com/...
17
399
12
d290e203f14e2d76c3fa1764cbddf5815b6ad256
Shane F. Carr
2023-01-06T01:17:11
Make metacrate features more specific (#2932)
diff --git a/components/icu/Cargo.toml b/components/icu/Cargo.toml index 3ad94fb155..ef64a55f8a 100644 --- a/components/icu/Cargo.toml +++ b/components/icu/Cargo.toml @@ -40,6 +40,7 @@ icu_plurals = { version = "1.0.0", path = "../plurals", default-features = false icu_properties = { version = "1.0.0", path = "../prop...
4
17
7
bc553debe5ace69b3a1681c889518d68943b3c33
Erick Guan
2023-01-05T19:41:30
Adds a bytes parsing API for GMTOffset for CustomTimeZone and FFI (#2943)
diff --git a/components/timezone/src/time_zone.rs b/components/timezone/src/time_zone.rs index 6744bd1c3e..4702e9bb16 100644 --- a/components/timezone/src/time_zone.rs +++ b/components/timezone/src/time_zone.rs @@ -80,6 +80,40 @@ impl CustomTimeZone { } } + /// Parse a [`CustomTimeZone`] from a UTF-8...
3
135
79
cfe1f7138da5ece82a69e63c35dd73e2213bc659
Manish Goregaokar
2022-12-30T05:39:13
Treat strings starting with a decimal point as valid in FixedDecimal::from_str() (#2937) * Add ability for test_from_str to have non roundtripping tests * Add ability to parse numbers without a leading 0 * fix test * fmt
diff --git a/utils/fixed_decimal/src/decimal.rs b/utils/fixed_decimal/src/decimal.rs index ddddf9aa4f..241a6c4c0f 100644 --- a/utils/fixed_decimal/src/decimal.rs +++ b/utils/fixed_decimal/src/decimal.rs @@ -1798,7 +1798,9 @@ impl TryFrom<&[u8]> for FixedDecimal { } dot_index = i; ...
1
48
11
7e42488426493b4cdd57824e190fab52bedcffee
Manish Goregaokar
2022-12-29T07:51:49
Add prove_covariance_manually guard for CoerceUnsized (#2936) * Add prove_covariance_manually guard for CoerceUnsized * better name ftys * fmt
diff --git a/utils/yoke/derive/src/lib.rs b/utils/yoke/derive/src/lib.rs index 2c7622da6d..4b638e6b9c 100644 --- a/utils/yoke/derive/src/lib.rs +++ b/utils/yoke/derive/src/lib.rs @@ -110,11 +110,11 @@ fn yokeable_derive_impl(input: &DeriveInput) -> TokenStream2 { .collect(); let mut yoke_b...
1
41
8
b9a0221c397c5d8f714656ffe777fb8f81ceabcc
Zibi Braniecki
2022-12-26T10:39:26
[locid] Make SubtagIterator::new infallible. (#2930)
diff --git a/components/locid/src/extensions/mod.rs b/components/locid/src/extensions/mod.rs index 2e57dc393e..a6a189b11a 100644 --- a/components/locid/src/extensions/mod.rs +++ b/components/locid/src/extensions/mod.rs @@ -244,7 +244,6 @@ impl Extensions { return Err(ParserError::InvalidExtensi...
8
40
49
92e5d5970d8db1559ede339860e6887bf9e6559e
Shane F. Carr
2022-12-26T07:13:09
DisplayNames fixes (#2918) * DisplayNames fixes * Cleanups
diff --git a/experimental/displaynames/Cargo.toml b/experimental/displaynames/Cargo.toml index cedfe13570..99d7e92a7c 100644 --- a/experimental/displaynames/Cargo.toml +++ b/experimental/displaynames/Cargo.toml @@ -41,5 +41,5 @@ bench = false # This option is required for Benchmark CI [features] std = ["icu_provider...
3
18
9
346d1a23a009d0e1fb28baf9386fceecf11db690
Shane F. Carr
2022-12-16T13:10:15
Make ZVCursor2d public and add iter1_copied (#2897)
diff --git a/provider/blob/src/blob_schema.rs b/provider/blob/src/blob_schema.rs index b788d7e6dd..8dfb6d2405 100644 --- a/provider/blob/src/blob_schema.rs +++ b/provider/blob/src/blob_schema.rs @@ -71,7 +71,6 @@ impl<'data> BlobSchemaV1<'data> { /// Verifies the weak invariants using debug assertions #[cfg(d...
3
62
35
67f08879dfb219e2b429d89e9d91bd90da54a5da
Pawan Dogra
2022-12-15T10:46:46
fix missing 10 from tests (#2891)
diff --git a/experimental/relativetime/tests/tests.rs b/experimental/relativetime/tests/tests.rs index dfc2163495..5bac1aa093 100644 --- a/experimental/relativetime/tests/tests.rs +++ b/experimental/relativetime/tests/tests.rs @@ -56,7 +56,7 @@ generate_test!( (0, "in 0 seconds"), (1, "in 1 second"), ...
1
96
96
da92c61b191261b26e40eda310662600f54fce9a
samchen
2022-12-13T22:53:40
Create DateParser and TimeParser in ixdtf (#2837) * Split into DateParser and TimeParser * cargo fmt * get rid of iterator * fix lint * address comments * add comments * fix errors * fix doc error
diff --git a/experimental/ixdtf/src/lib.rs b/experimental/ixdtf/src/lib.rs index 573317a58f..ee53e2e01f 100644 --- a/experimental/ixdtf/src/lib.rs +++ b/experimental/ixdtf/src/lib.rs @@ -20,4 +20,4 @@ ) )] -mod parser; +pub mod parser; diff --git a/experimental/ixdtf/src/parser.rs b/experimental/ixdtf/src/parse...
2
257
243
b67b11be05cfaebb8465b0467ada3acd165a6d41
José Julián Espina
2022-12-13T11:12:39
Derive `Clone` for `LocaleFallbackProvider` (#2881)
diff --git a/provider/adapters/src/fallback/adapter.rs b/provider/adapters/src/fallback/adapter.rs index a2347f6513..b480ded193 100644 --- a/provider/adapters/src/fallback/adapter.rs +++ b/provider/adapters/src/fallback/adapter.rs @@ -43,6 +43,7 @@ use crate::helpers::result_is_err_missing_data_options; /// "こんにちは...
1
1
0
1d4684e162ec2e0d3bdab7f2a4ad76830150f295
Ting-Yu Lin
2022-12-06T03:10:11
Simplify construction of grapheme cluster break iterators (#2870) We can simply a bit with the newly added helpers `new_and_segment_str` and `new_and_segment_utf16`.
diff --git a/experimental/segmenter/src/grapheme.rs b/experimental/segmenter/src/grapheme.rs index 73899df138..a03bd765a1 100644 --- a/experimental/segmenter/src/grapheme.rs +++ b/experimental/segmenter/src/grapheme.rs @@ -86,19 +86,10 @@ impl GraphemeClusterSegmenter { &'l self, input: &'s str, ...
1
4
22
40835f7721d3c60aa751b9910bfcded6a0ea5103
Makoto Kato
2022-12-05T19:16:36
Store grapheme cluster payload instead of grapheme cluster segmenter. (#2864)
diff --git a/experimental/segmenter/src/complex.rs b/experimental/segmenter/src/complex.rs index 489c687291..985d0963d7 100644 --- a/experimental/segmenter/src/complex.rs +++ b/experimental/segmenter/src/complex.rs @@ -3,7 +3,6 @@ // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ). use crate::d...
9
207
150
583207162d72f50365234e14a80863da1dd372d8
Manish Goregaokar
2022-12-05T13:52:23
Use rustup run instead of +nightly in ffi-coverage (#2865)
diff --git a/ffi/diplomat/ffi_coverage/src/main.rs b/ffi/diplomat/ffi_coverage/src/main.rs index 84df37dc26..3ad18a2c4d 100644 --- a/ffi/diplomat/ffi_coverage/src/main.rs +++ b/ffi/diplomat/ffi_coverage/src/main.rs @@ -489,9 +489,11 @@ fn collect_public_types(krate: &str) -> impl Iterator<Item = (Vec<String>, ast:: ...
1
4
2
d474a7997a9a408a45791e29a9308feb63043689
Oleksii Tkachuk
2022-12-03T16:01:30
Address last for/vec.push case in favor of vec.extend (#2861)
diff --git a/components/normalizer/src/lib.rs b/components/normalizer/src/lib.rs index b00e73209f..c846c91422 100644 --- a/components/normalizer/src/lib.rs +++ b/components/normalizer/src/lib.rs @@ -617,10 +617,10 @@ where ); if low & 0x1000 != 0 { // All the rest are combining - ...
1
4
4
2c94820406ddc22989c9bf054af474df9b8cbd7e
Robert Bastian
2022-12-02T17:03:43
Fix sv_reformed warning (#2859)
diff --git a/provider/datagen/src/transform/icuexport/collator/mod.rs b/provider/datagen/src/transform/icuexport/collator/mod.rs index eec200130b..8f0ad0f136 100644 --- a/provider/datagen/src/transform/icuexport/collator/mod.rs +++ b/provider/datagen/src/transform/icuexport/collator/mod.rs @@ -27,26 +27,17 @@ static DE...
1
62
75
ee8f0aba420561083ce345e9979aadfc009c1983
Robert Bastian
2022-12-01T10:44:52
`#[no_std]` for LSTM segmenter (#2845)
diff --git a/experimental/segmenter/Cargo.toml b/experimental/segmenter/Cargo.toml index f7560ec14a..cb51122cd7 100644 --- a/experimental/segmenter/Cargo.toml +++ b/experimental/segmenter/Cargo.toml @@ -35,7 +35,7 @@ serde_json = { version = "1.0", default-features = false, features = ["alloc"] } zerovec = { version =...
4
8
2
889dc290744dea36f77beaaa20229121811b654e
Makoto Kato
2022-11-28T07:53:36
icu_segmenter: enforce clippy::indexing_slicing. (#2325) * icu_segmenter denies the clippy::indexing_slicing. * Fix clippy error
diff --git a/experimental/segmenter/src/complex.rs b/experimental/segmenter/src/complex.rs index aaee61e55c..489c687291 100644 --- a/experimental/segmenter/src/complex.rs +++ b/experimental/segmenter/src/complex.rs @@ -69,32 +69,35 @@ pub fn complex_language_segment_utf16( let lang_iter = LanguageIteratorUtf16::ne...
4
51
62
b82dfd315bd17f50d23f721090e3efc837542a8f
samchen
2022-11-23T02:06:28
Error handling in IXDTF parser (#2821) * Error handling and support time zone * error handling only
diff --git a/experimental/ixdtf/src/parser.rs b/experimental/ixdtf/src/parser.rs index 6ef8805deb..505b40dfa5 100644 --- a/experimental/ixdtf/src/parser.rs +++ b/experimental/ixdtf/src/parser.rs @@ -2,6 +2,21 @@ // called LICENSE at the top level of the ICU4X source tree // (online at: https://github.com/unicode-org/...
1
165
235
54876538f561785449efea762411259f49e4f404
Ralf Jung
2022-11-18T21:16:11
FlexZeroSlize: implement Eq and PartialEq by hand (#2834)
diff --git a/utils/zerovec/src/flexzerovec/slice.rs b/utils/zerovec/src/flexzerovec/slice.rs index 7cc6f12fa7..ee164d05bd 100644 --- a/utils/zerovec/src/flexzerovec/slice.rs +++ b/utils/zerovec/src/flexzerovec/slice.rs @@ -14,7 +14,6 @@ const USIZE_WIDTH: usize = mem::size_of::<usize>(); /// A zero-copy "slice" that...
1
7
1
d418731826aea10cbc72d6a3b73789a981e425bd
Shane F. Carr
2022-11-14T23:29:45
Add example for iterating over the windows of a VarZeroVec (#2797)
diff --git a/utils/zerovec/src/varzerovec/slice.rs b/utils/zerovec/src/varzerovec/slice.rs index 59e8da03f2..afdbe80d92 100644 --- a/utils/zerovec/src/varzerovec/slice.rs +++ b/utils/zerovec/src/varzerovec/slice.rs @@ -29,8 +29,13 @@ use core::ops::Range; /// The `F` type parameter is a [`VarZeroVecFormat`] (see its d...
1
26
2
b6ec7663d15696b567fa5dd3d525f1aaf3541d24
Ting-Yu Lin
2022-11-09T17:22:40
Remove allow(clippy::expect_used) annotations in segmenter (#2817) * Refactor common pattern to implement iterators We can share code between some of the word, grapheme clusters, and sentence iterators since their differences are only the payload. * Remove allow(clippy::expect_used) annotations Make segmente...
diff --git a/experimental/segmenter/src/grapheme.rs b/experimental/segmenter/src/grapheme.rs index fbbb4dce29..fda6997434 100644 --- a/experimental/segmenter/src/grapheme.rs +++ b/experimental/segmenter/src/grapheme.rs @@ -3,7 +3,6 @@ // (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ). use allo...
5
212
291
3762f06ab850c54b629c0d9a7e2f29bda7b4614d
Shane F. Carr
2022-11-07T22:19:49
Add tests for zh fallback (#2818)
diff --git a/provider/adapters/src/fallback/algorithms.rs b/provider/adapters/src/fallback/algorithms.rs index 370ad03631..0edc593040 100644 --- a/provider/adapters/src/fallback/algorithms.rs +++ b/provider/adapters/src/fallback/algorithms.rs @@ -355,6 +355,25 @@ mod tests { expected_language_chain: &["hi-...
1
19
0
7d4a5983e0303ff9e8ea87efae0f33ea8da4eeba
Ting-Yu Lin
2022-11-07T07:13:40
Enable more clippy lints in segmenter (#2804) * Enable clippy::expect_used lint This patch introduces helper methods in rule segementer and line segmenter to eliminates a lot of `unwrap()` usage. This commit shouldn't change behavior. * Enable clippy::unwrap_used lint * Enable clippy::panic lint
diff --git a/experimental/segmenter/src/grapheme.rs b/experimental/segmenter/src/grapheme.rs index 0aa0501fae..fbbb4dce29 100644 --- a/experimental/segmenter/src/grapheme.rs +++ b/experimental/segmenter/src/grapheme.rs @@ -170,14 +170,14 @@ impl<'l, 's> RuleBreakType<'l, 's> for GraphemeClusterBreakTypeUtf8 { type...
10
167
118
ba676cb7ffb9975fffa698f02f458ee5ca0bc75f
Ting-Yu Lin
2022-11-03T00:56:06
Enable experimental feature in icu in segmenter's Cargo.toml (#2803) This patch fixed the following doc test error when running `cargo test --all-features` under `experimental/segmenter`. ``` ---- src/lib.rs - (line 54) stdout ---- error[E0432]: unresolved import `icu::segmenter` --> src/lib.rs:55:10 | 3 |...
diff --git a/experimental/segmenter/Cargo.toml b/experimental/segmenter/Cargo.toml index 1141d907f5..f7560ec14a 100644 --- a/experimental/segmenter/Cargo.toml +++ b/experimental/segmenter/Cargo.toml @@ -44,7 +44,7 @@ displaydoc = { version = "0.2.3", default-features = false } criterion = "0.3" icu_testdata = { path ...
1
1
1
6bf69ba0a5bb6504a18a95829d3ffdbbca414a51
Manish Goregaokar
2022-10-28T15:44:56
Don't use std postcard in tests (#2795) * Don't use std postcard in tests * Bump deduplicating_array * lock
diff --git a/Cargo.lock b/Cargo.lock index 64225f3e2c..690d4efeb5 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -685,7 +685,7 @@ dependencies = [ [[package]] name = "deduplicating_array" -version = "0.1.2" +version = "0.1.3" dependencies = [ "postcard", "serde", diff --git a/utils/deduplicating_array/Cargo.toml ...
4
6
6
2db2c5f3b1ee2a44ff8d9356fd4044844bd91564
Elango Cheran
2022-10-27T18:05:15
Update Script property value enums (#2787)
diff --git a/components/properties/src/props.rs b/components/properties/src/props.rs index 66d9a1c70f..78fa80cd88 100644 --- a/components/properties/src/props.rs +++ b/components/properties/src/props.rs @@ -468,6 +468,7 @@ impl Script { pub const Kaithi: Script = Script(120); pub const Kannada: Script = Scrip...
1
2
0
6e748569e3c408cd5b59938d4629af9bfff32cae
Shane F. Carr
2022-10-26T00:00:41
Add ixdtf to CI (#2786)
diff --git a/Cargo.lock b/Cargo.lock index e73594aaec..64225f3e2c 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2032,6 +2032,15 @@ version = "1.0.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "112c678d4050afce233f4f2852bb2eb519230b3cf12f33585275537d7e41578d" +[[package]] +name = "ixd...
5
210
186
0acdb50f0726616c5d689890b0321bceb0a519bc
Christopher Durham
2022-10-20T04:58:31
Allow clippy::forget_copy in derive(Yokeable) impl (#2775) The attribute was already emitted when proving covariance manually, but not in the normal case.
diff --git a/utils/yoke/derive/src/lib.rs b/utils/yoke/derive/src/lib.rs index 615669d840..2c7622da6d 100644 --- a/utils/yoke/derive/src/lib.rs +++ b/utils/yoke/derive/src/lib.rs @@ -206,6 +206,7 @@ fn yokeable_derive_impl(input: &DeriveInput) -> TokenStream2 { // are the same ...
1
1
0
9c99640979e6f943f72162b876587a6bb05bcb54
Manish Goregaokar
2022-10-20T00:36:48
Remove static_assertions dep from fixed-decimal, bump version (#2773) * Remove static_assertions dep from fixed_decimal * Bump fixed-decimal to 0.5.1 * remove devdep too * fmt
diff --git a/Cargo.lock b/Cargo.lock index cea28c80f3..e73594aaec 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -942,7 +942,7 @@ dependencies = [ [[package]] name = "fixed_decimal" -version = "0.5.0" +version = "0.5.1" dependencies = [ "criterion", "displaydoc", @@ -953,7 +953,6 @@ dependencies = [ "rand_pcg",...
4
8
15
5faf121440aa6c0701487c2de925a52763745246
Shane F. Carr
2022-10-19T01:21:07
Improve collation datagen test assertions (#2766)
diff --git a/provider/datagen/src/lib.rs b/provider/datagen/src/lib.rs index cb5beedb61..aabdb270b0 100644 --- a/provider/datagen/src/lib.rs +++ b/provider/datagen/src/lib.rs @@ -61,6 +61,8 @@ mod databake; mod error; mod registry; mod source; +#[cfg(test)] +mod testutil; mod transform; pub use error::*; diff --...
3
79
7
48457f5ce2a775094cda3b6431667da14c430ee2
Robert Bastian
2022-10-15T04:08:14
More borrow in list JSON deserialization (#2751)
diff --git a/components/list/src/provider.rs b/components/list/src/provider.rs index 27f3e4fecd..a3633225ef 100644 --- a/components/list/src/provider.rs +++ b/components/list/src/provider.rs @@ -370,7 +370,11 @@ pub(crate) mod test { ]) .unwrap(); patterns - .make_conditional("{0}....
3
15
16
d5116379029a0e20aa50843503337cc6199ad889
Henri Sivonen
2022-10-10T06:18:10
Add notes about collation index generation (#2728)
diff --git a/components/collator/src/docs.rs b/components/collator/src/docs.rs index c093a93f9c..ed11b47375 100644 --- a/components/collator/src/docs.rs +++ b/components/collator/src/docs.rs @@ -113,3 +113,39 @@ //! "searchjl" is even more problematic than "search", since "searchjl" uses //! prefixes matches ...
1
36
0
728d3891e37be6256e2c2fc604e50f8f0865fb66
Robert Bastian
2022-10-08T01:01:18
`icu_provider@1.0.1` (#2732)
diff --git a/Cargo.lock b/Cargo.lock index bedff8c8a2..d1b4948936 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1771,7 +1771,7 @@ dependencies = [ [[package]] name = "icu_provider" -version = "1.0.0" +version = "1.0.1" dependencies = [ "bincode", "databake", diff --git a/provider/core/Cargo.toml b/provider/core...
2
2
2
bc907e68ae7fe7933a01195f31a9377326cfe8b5
Robert Bastian
2022-10-07T23:55:42
Allowing no keys in datagen CLI (#2731)
diff --git a/Cargo.lock b/Cargo.lock index 57ec6ae1ee..0ede3ae3b2 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1495,7 +1495,7 @@ dependencies = [ [[package]] name = "icu_datagen" -version = "1.0.1" +version = "1.0.2" dependencies = [ "cached-path", "clap", diff --git a/provider/datagen/Cargo.toml b/provider/da...
3
3
3
f0592c39779594403fd7704a8911d44f8315c251
Manish Goregaokar
2022-10-05T15:53:35
Fix spelling in docs (#2720)
diff --git a/utils/databake/src/lib.rs b/utils/databake/src/lib.rs index 69554f2373..987c4b6d0b 100644 --- a/utils/databake/src/lib.rs +++ b/utils/databake/src/lib.rs @@ -111,7 +111,7 @@ impl IntoIterator for CrateEnv { /// /// This can be used to generate files with hardcoded data. pub trait Bake { - /// Returns...
1
1
1
c33971f8d8516eb9bd3cc12a229e815fb76c3af9
Manish Goregaokar
2022-10-03T21:32:04
Fix math in calendar (#2714) * Tests and initial work on ISO with negative years * Fix coptic division issue * fix test * add missing test Co-authored-by: Shane F. Carr <shane@unicode.org>
diff --git a/components/calendar/Cargo.toml b/components/calendar/Cargo.toml index 8aa62fd9e5..9967975f00 100644 --- a/components/calendar/Cargo.toml +++ b/components/calendar/Cargo.toml @@ -63,6 +63,10 @@ harness = false name = "datetime" harness = false +[[bench]] +name = "iso" +harness = false + [[example]] na...
7
164
17
06c352982e941ca8cdb64ffa47f500f68c80dab1
Manish Goregaokar
2022-10-03T21:02:58
Clean up dependency specifications so serde isn't pulled in by default (#2696) * Mark optional deps as optional * Make dep optional * Rm dep from locid_transform * serde feature * unconditional litemap
diff --git a/components/collator/Cargo.toml b/components/collator/Cargo.toml index a94d6cd074..9bc96d15d9 100644 --- a/components/collator/Cargo.toml +++ b/components/collator/Cargo.toml @@ -40,7 +40,7 @@ icu_locid = { version = "1.0.0", path = "../../components/locid" } icu_normalizer = { version = "1.0.0", path = "....
4
6
3
359f09b3d99864163bf1c80dd3a42fd002bfa174
Robert Bastian
2022-10-03T20:53:19
More borrowing in locid's `write_to_string` (#2693)
diff --git a/components/locid/src/extensions/mod.rs b/components/locid/src/extensions/mod.rs index 42bfcd3c96..67817a70fe 100644 --- a/components/locid/src/extensions/mod.rs +++ b/components/locid/src/extensions/mod.rs @@ -283,7 +283,7 @@ impl_writeable_for_each_subtag_str_no_test!(Extensions); fn test_writeable() { ...
12
111
61
9b9d14d32d185fadacd2a3847ff6a965728e3698
Shane F. Carr
2022-10-03T17:17:34
Add div_rem_euclid and use it in icu_calendar (#2704) * Add div_rem_euclid and use it in icu_calendar * Don't need helper function when dividend is positive
diff --git a/components/calendar/src/helpers.rs b/components/calendar/src/helpers.rs new file mode 100644 index 0000000000..44e98d4a61 --- /dev/null +++ b/components/calendar/src/helpers.rs @@ -0,0 +1,69 @@ +// This file is part of ICU4X. For terms of use, please see the file +// called LICENSE at the top level of the ...
3
73
17
774b734dd4993ff4faa77898c584ecc657ab5712
Makoto Kato
2022-10-03T08:02:52
Remove unnecessary langauge check for East Asian languagne (SA property) (#2705)
diff --git a/experimental/segmenter/src/line.rs b/experimental/segmenter/src/line.rs index bb08e5b151..8e456ebfde 100644 --- a/experimental/segmenter/src/line.rs +++ b/experimental/segmenter/src/line.rs @@ -4,7 +4,6 @@ use crate::complex::*; use crate::indices::*; -use crate::language::*; use crate::provider::*; ...
1
0
2
5a8c31a80ce2a774a1b07f6bb21a79087f92a6c1
Prat
2022-10-02T23:28:56
Fix Time::from_minute_with_remainder_days to handle negatives (#2643) (#2702) Co-authored-by: Prat T <pt2121@users.noreply.github.com>
diff --git a/components/calendar/src/types.rs b/components/calendar/src/types.rs index 47548e1d83..bb462b0382 100644 --- a/components/calendar/src/types.rs +++ b/components/calendar/src/types.rs @@ -482,14 +482,25 @@ impl Time { let minutes_a_hour = 60; let hours_a_day = 24; let minutes_a_day...
1
56
26
926e2208597f78017fa6fed477640a348d5d81e3
Manish Goregaokar
2022-09-30T19:45:16
mention that we support multiple unsized fields in varule (#2695) * mention that we support multiple unsized fields in varule * Update utils/zerovec/src/lib.rs Co-authored-by: Robert Bastian <robertbastian@users.noreply.github.com> Co-authored-by: Robert Bastian <robertbastian@users.noreply.github.com>
diff --git a/utils/zerovec/src/lib.rs b/utils/zerovec/src/lib.rs index 9a37c762ec..613a9183be 100644 --- a/utils/zerovec/src/lib.rs +++ b/utils/zerovec/src/lib.rs @@ -395,8 +395,9 @@ pub use zerovec_derive::make_ule; /// Generate a corresponding [`VarULE`] type and the relevant [`EncodeAsVarULE`]/[`zerofrom::ZeroFrom`...
1
3
2
ee2751298384ddf1ea7da566df541f2962c8f067
Robert Bastian
2022-09-27T18:12:38
fix ecma402 (#2658)
diff --git a/ffi/ecma402/Cargo.lock b/ffi/ecma402/Cargo.lock index 4dd7e2e787..5603cc36f5 100644 --- a/ffi/ecma402/Cargo.lock +++ b/ffi/ecma402/Cargo.lock @@ -690,7 +690,7 @@ dependencies = [ [[package]] name = "fixed_decimal" -version = "0.4.0" +version = "0.5.0" dependencies = [ "displaydoc", "smallvec", @@ ...
3
45
59
7a471b7e4584bfc165d9e593295742c880369bf7
Manish Goregaokar
2022-09-27T16:58:32
Update yoke (#2655)
diff --git a/Cargo.lock b/Cargo.lock index f8e06259f7..ef8b6ccff5 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4149,7 +4149,7 @@ dependencies = [ [[package]] name = "yoke" -version = "0.6.1" +version = "0.6.2" dependencies = [ "bincode", "serde", diff --git a/provider/core/Cargo.toml b/provider/core/Cargo.toml...
3
3
3
936082ff14b8d247dd35eca863f1b32cacda4ccb
Robert Bastian
2022-09-27T15:56:20
Less cloning in `BlobDataProvider` (#2608)
diff --git a/experimental/segmenter/src/lstm_bies.rs b/experimental/segmenter/src/lstm_bies.rs index 543d8b61e1..fa8b2d31eb 100644 --- a/experimental/segmenter/src/lstm_bies.rs +++ b/experimental/segmenter/src/lstm_bies.rs @@ -253,13 +253,12 @@ mod tests { } fn load_lstm_data(filename: &str) -> DataPayload<...
15
227
350
897c0a36c42ef211769eef570924124793c963fe
Shane F. Carr
2022-09-27T08:01:56
More Copy arguments (#2654)
diff --git a/components/timezone/src/time_zone.rs b/components/timezone/src/time_zone.rs index 94238d76af..b0c431364d 100644 --- a/components/timezone/src/time_zone.rs +++ b/components/timezone/src/time_zone.rs @@ -148,10 +148,10 @@ impl FromStr for CustomTimeZone { /// let tz3: CustomTimeZone = /// "+02:...
3
19
19
38f41b6e170c432e88d684ebd6b546e4ca837ebf
Manish Goregaokar
2022-09-27T00:51:08
Remaining utils bumps (writeable, fixed_decimal) (#2652) * remove version from devdep * Bump writeable to 0.5.0
diff --git a/Cargo.lock b/Cargo.lock index 08456c330d..cf7b75ebc7 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4129,7 +4129,7 @@ dependencies = [ [[package]] name = "writeable" -version = "0.4.1" +version = "0.5.0" dependencies = [ "criterion", "icu_benchmark_macros", diff --git a/components/calendar/Cargo.tom...
18
18
18
7929b6e0cd392cbe9026740ee9ad83bcf1f392c5
Zibi Braniecki
2022-09-26T20:53:40
Document inline clippy lints for datetime and plurals (#2572)
diff --git a/components/datetime/src/pattern/reference/parser.rs b/components/datetime/src/pattern/reference/parser.rs index 48fa213067..d8385760b0 100644 --- a/components/datetime/src/pattern/reference/parser.rs +++ b/components/datetime/src/pattern/reference/parser.rs @@ -103,8 +103,7 @@ impl<'p> Parser<'p> { ...
5
54
39
0eaff6f63ad74ec7184bad089dd7a67de071ab8c
Manish Goregaokar
2022-09-26T19:57:29
Make expect_pattern GIGO (#2650)
diff --git a/components/datetime/src/pattern/runtime/plural.rs b/components/datetime/src/pattern/runtime/plural.rs index bf8e912971..879ccbd581 100644 --- a/components/datetime/src/pattern/runtime/plural.rs +++ b/components/datetime/src/pattern/runtime/plural.rs @@ -204,8 +204,16 @@ impl<'data> PatternPlurals<'data> { ...
1
10
2
d7f9ce3cfcd390ce811bb244a217b61661b3bb18
Manish Goregaokar
2022-09-26T18:22:00
Update Diplomat to 0.4.0 (#2642)
diff --git a/Cargo.lock b/Cargo.lock index 369d9f17aa..58344d66e7 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -734,8 +734,8 @@ dependencies = [ [[package]] name = "diplomat" -version = "0.3.0" -source = "git+https://github.com/rust-diplomat/diplomat?rev=82e2e74c1f3c04b0360529aa7c019b2c56f3216d#82e2e74c1f3c04b036052...
3
9
9
944c31975137dd2dffea2d2a2fa2ed0abd11bd8a
Shane F. Carr
2022-09-26T16:43:41
private::Key and other::Key to ::Subtag (#2632)
diff --git a/components/locid/src/extensions/other/mod.rs b/components/locid/src/extensions/other/mod.rs index 9380004b64..e2cfcacd05 100644 --- a/components/locid/src/extensions/other/mod.rs +++ b/components/locid/src/extensions/other/mod.rs @@ -8,7 +8,7 @@ //! Those extensions are treated as a pass-through, and no U...
6
59
63
e5ee9caff26dea38275ad49065eb1b42f3818276
Shane F. Carr
2022-09-25T19:19:53
Copy types by value (#2638)
diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs index 31f01c256c..ef749c4878 100644 --- a/components/calendar/src/any_calendar.rs +++ b/components/calendar/src/any_calendar.rs @@ -662,8 +662,8 @@ impl AnyCalendarKind { } /// Convert to a BCP-47 string - pub ...
6
21
21
f9e307b8ad5de785184bba12558790602e4970d4
Shane F. Carr
2022-09-25T19:19:41
Remove re-export of icu_calendar types (#2636)
diff --git a/components/calendar/src/types.rs b/components/calendar/src/types.rs index 33b3e91608..09f5ba763d 100644 --- a/components/calendar/src/types.rs +++ b/components/calendar/src/types.rs @@ -479,7 +479,7 @@ impl Time { /// # Examples /// /// ``` -/// use icu::datetime::input::IsoWeekday; +/// use icu::calend...
2
7
7
139e795cc84df7c5adc166beff851052554716e4
Shane F. Carr
2022-09-25T05:13:13
Don't export utils functions from codepointinvlist (#2629)
diff --git a/components/collections/src/codepointinvlist/mod.rs b/components/collections/src/codepointinvlist/mod.rs index 779224d29f..55a0789fa7 100644 --- a/components/collections/src/codepointinvlist/mod.rs +++ b/components/collections/src/codepointinvlist/mod.rs @@ -62,7 +62,6 @@ pub use builder::CodePointInversion...
1
0
1
ee45dc4f3e4cbee4a07f92020434d28e63959fe4
Shane F. Carr
2022-09-25T05:12:27
Fix "help choosing a constructor" docs (#2631)
diff --git a/Cargo.lock b/Cargo.lock index 11e6f9c9db..56ca1b2108 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1313,6 +1313,7 @@ dependencies = [ "icu_normalizer", "icu_plurals", "icu_properties", + "icu_provider", "icu_segmenter", "icu_testdata", "icu_timezone", diff --git a/components/icu/Cargo.toml b/com...
3
8
4
463c3e6ad24c0764e49d80d06e418bac596d63d1
Shane F. Carr
2022-09-24T17:31:21
Propagate "help choosing" docs to all unstable constructors (#2634)
diff --git a/components/calendar/src/any_calendar.rs b/components/calendar/src/any_calendar.rs index fa6e8663fa..be8666a48b 100644 --- a/components/calendar/src/any_calendar.rs +++ b/components/calendar/src/any_calendar.rs @@ -447,6 +447,11 @@ impl AnyCalendar { /// fallbacking. If this is desired, use [`Self::try...
16
130
1
2ec486db756badb05f08e85818211437ee0fe6cc
Manish Goregaokar
2022-09-24T01:17:00
Post-review zerovec fixes (#2622) * dtor * docs and tests * may_dangle * Add EyepatchHackVector * Update utils/zerovec/src/zerovec/mod.rs Co-authored-by: Shane F. Carr <shane@unicode.org> * review Co-authored-by: Shane F. Carr <shane@unicode.org>
diff --git a/utils/zerovec/src/zerovec/mod.rs b/utils/zerovec/src/zerovec/mod.rs index dc7e83752c..a3f6650813 100644 --- a/utils/zerovec/src/zerovec/mod.rs +++ b/utils/zerovec/src/zerovec/mod.rs @@ -87,36 +87,100 @@ pub struct ZeroVec<'a, T> where T: AsULE, { - /// Pointer to data - buf: *mut [T::ULE], - ...
1
103
24
c2e29bd30a695d032bc82fb8606e3f6439991613
Younies Mahmoud
2022-09-23T23:11:20
Fixes the bidi documentation (#2621) Fix bidi documentation
diff --git a/components/properties/src/bidi.rs b/components/properties/src/bidi.rs index 0e173da3f1..76f946dd6f 100644 --- a/components/properties/src/bidi.rs +++ b/components/properties/src/bidi.rs @@ -4,20 +4,24 @@ //! This module exposes tooling for running the [unicode bidi algorithm](https://unicode.org/reports...
1
17
7
4cb5ed130c8a7557c310a4fa0fa7ebf4d8e5270c
Henri Sivonen
2022-09-23T22:44:56
Add module declaration-level notes about special-casing in Pernosco (#2619)
diff --git a/components/collator/src/lib.rs b/components/collator/src/lib.rs index b8aad01c1e..c822982f78 100644 --- a/components/collator/src/lib.rs +++ b/components/collator/src/lib.rs @@ -278,7 +278,13 @@ mod comparison; #[cfg(doc)] pub mod docs; + +// NOTE: The Pernosco debugger has special knowledge +// of the ...
2
12
0
531b59e7f50157f0b6d8242966d726dfe868e4a6
Younies Mahmoud
2022-09-23T20:40:13
fixed_decimal::Sign should be exhaustive (#2620)
diff --git a/components/decimal/src/format.rs b/components/decimal/src/format.rs index 82a11b78df..301527463e 100644 --- a/components/decimal/src/format.rs +++ b/components/decimal/src/format.rs @@ -26,7 +26,6 @@ impl<'l> FormattedFixedDecimal<'l> { Sign::None => None, Sign::Negative => Some(&...
3
2
3
ff1d4b370b834281e3524118fb41883341a7e2bd
Henri Sivonen
2022-09-23T06:11:25
Warn against breaking the Pernosco integration of CharacterAndClass (#2604)
diff --git a/components/collator/src/elements.rs b/components/collator/src/elements.rs index f57fecef0e..f1ec885b1f 100644 --- a/components/collator/src/elements.rs +++ b/components/collator/src/elements.rs @@ -716,6 +716,11 @@ impl CharacterAndClassAndTrieValue { /// Note that 0xFF is won't be assigned to an actual ...
3
15
0
a9e2ba4d54db7a3718f7bb849941c6f871c1ecbc
Shane F. Carr
2022-09-22T22:53:08
Plurals: Use From instead of TryFrom for signed integers (#2593)
diff --git a/components/plurals/src/operands.rs b/components/plurals/src/operands.rs index bd20e18294..14696f13a2 100644 --- a/components/plurals/src/operands.rs +++ b/components/plurals/src/operands.rs @@ -2,7 +2,6 @@ // called LICENSE at the top level of the ICU4X source tree // (online at: https://github.com/unico...
1
5
13
ab02aade03ce68ec53f90fe4eeb140e5e97b2e01
Manish Goregaokar
2022-09-22T17:30:15
fix ci (#2610)
diff --git a/provider/testdata/benches/providers.rs b/provider/testdata/benches/providers.rs index 24a9e1221a..f251e08429 100644 --- a/provider/testdata/benches/providers.rs +++ b/provider/testdata/benches/providers.rs @@ -10,7 +10,6 @@ use icu_provider::hello_world::HelloWorldV1Marker; use icu_provider::prelude::*; ...
1
2
4
3d80f0da848636527c6749f510865e14622abc61
Shane F. Carr
2022-09-21T21:22:18
Improve performance of VarZeroVec::deserialize and add provider benches (#2603)
diff --git a/Cargo.lock b/Cargo.lock index 27bfa129ee..521b412693 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1839,6 +1839,7 @@ dependencies = [ "bytes", "cargo_metadata", "clap", + "criterion", "displaydoc", "eyre", "futures", diff --git a/provider/testdata/Cargo.toml b/provider/testdata/Cargo.toml index ...
4
142
24
fbd829c8ad0094db44af41a1b32cea38ee540c5b
Robert Bastian
2022-09-21T12:08:10
Add permutation to ZVL containers (#2605)
diff --git a/utils/zerovec/src/map/kv.rs b/utils/zerovec/src/map/kv.rs index d9b2b1c7a6..1923ed9911 100644 --- a/utils/zerovec/src/map/kv.rs +++ b/utils/zerovec/src/map/kv.rs @@ -52,10 +52,12 @@ macro_rules! impl_sized_kv { }; } +impl_sized_kv!(u8); impl_sized_kv!(u16); impl_sized_kv!(u32); impl_sized_kv!(u6...
2
69
0
871bcd5d744bcf9ec752df7f84f4be058817b9c8
Shane F. Carr
2022-09-21T06:13:35
Normalizer: Mark function as experimental and fix feature (#2594)
diff --git a/components/normalizer/Cargo.toml b/components/normalizer/Cargo.toml index 1c576924de..3a739b9f98 100644 --- a/components/normalizer/Cargo.toml +++ b/components/normalizer/Cargo.toml @@ -46,7 +46,7 @@ databake = { version = "0.1.0", path = "../../utils/databake", optional = true, zerofrom = { version = "0....
2
9
14
7bffd2fd4299b98f2a1c614587569d2f622ba152
Shane F. Carr
2022-09-20T23:36:50
Improve docs for enum properties without changing API (#2597)
diff --git a/components/properties/src/maps.rs b/components/properties/src/maps.rs index 898702fb15..27c49720fd 100644 --- a/components/properties/src/maps.rs +++ b/components/properties/src/maps.rs @@ -334,6 +334,11 @@ make_map_property! { func: /// Return a [`CodePointMapData`] for the Script Unicode enumer...
1
16
1
a2efa18f7b05c00e9947044e4ceaf86af433f43b
Shane F. Carr
2022-09-20T22:28:52
DateTime: Change default length to medium and add tests for Default (#2596)
diff --git a/components/datetime/src/any/datetime.rs b/components/datetime/src/any/datetime.rs index 7ab00ce9b0..fffaea28a7 100644 --- a/components/datetime/src/any/datetime.rs +++ b/components/datetime/src/any/datetime.rs @@ -581,4 +581,24 @@ mod tests { "5 เมษายน ค.ศ. 2022 12:33", ); } + + ...
4
53
11
e8a90e4b8273e098f75a0dc6d0510f9c32bafb13
Shane F. Carr
2022-09-20T22:28:35
Remove re-export of FormattedFixedDecimal (#2595)
diff --git a/components/decimal/src/lib.rs b/components/decimal/src/lib.rs index e6c87b2f11..9da1cdfc74 100644 --- a/components/decimal/src/lib.rs +++ b/components/decimal/src/lib.rs @@ -96,7 +96,7 @@ extern crate alloc; mod error; -pub mod format; +mod format; mod grouper; pub mod options; pub mod provider; dif...
2
1
2
16c90be4247f0d35852ee6cd55c63e5c4c2680a6
Pawan Dogra
2022-09-20T20:27:15
Add NicheBytes trait and NichedOptionULE (#2501) * Add NicheBytes trait, NichedOption, NichedOptionULE * Add ULE types for NonZeroU8, NonZeroI8
diff --git a/utils/zerovec/src/map/kv.rs b/utils/zerovec/src/map/kv.rs index b3e650fc76..d9b2b1c7a6 100644 --- a/utils/zerovec/src/map/kv.rs +++ b/utils/zerovec/src/map/kv.rs @@ -73,7 +73,7 @@ impl<'a> ZeroMapKV<'a> for usize { impl<'a, T> ZeroMapKV<'a> for Option<T> where - T: AsULE + 'static, + Option<T>: A...
4
231
2
4ee18e9da5834190f7c5648fd3c7e9504541951c
Robert Bastian
2022-09-20T14:46:26
Rename postcard feature for 1.0 (#2584)
diff --git a/provider/blob/Cargo.toml b/provider/blob/Cargo.toml index d45ba147cf..a4e24d2b2f 100644 --- a/provider/blob/Cargo.toml +++ b/provider/blob/Cargo.toml @@ -27,7 +27,7 @@ include = [ all-features = true [dependencies] -icu_provider = { version = "1.0.0-beta1", path = "../core", features = ["deserialize_po...
5
6
6
3cfc9cdb1e186b14aeeeef8d180237232f510c2c
Makoto Kato
2022-09-19T14:00:07
Avoid testdata dependency from icu_capi (#2578)
diff --git a/ffi/diplomat/Cargo.toml b/ffi/diplomat/Cargo.toml index c9159e38e2..95eda5ca2d 100644 --- a/ffi/diplomat/Cargo.toml +++ b/ffi/diplomat/Cargo.toml @@ -54,7 +54,7 @@ serde = [ "icu_provider/serde", "icu_segmenter/serde", ] -buffer_provider = ["serde", "icu_testdata/buffer"] +buffer_provider = ["se...
1
1
1
a89f542d698bb96fbfd5d5f9064975a8de05404e
Pawan Dogra
2022-09-19T13:59:14
Add ExactSizeIterator (#2580)
diff --git a/utils/zerovec/src/flexzerovec/slice.rs b/utils/zerovec/src/flexzerovec/slice.rs index 3a3c3d33c2..958c0b5cf2 100644 --- a/utils/zerovec/src/flexzerovec/slice.rs +++ b/utils/zerovec/src/flexzerovec/slice.rs @@ -256,7 +256,9 @@ impl FlexZeroSlice { /// Gets an iterator over the elements of the slice a...
2
10
4
c25e0e47b4ae3a9379734ab60b492df31ec90228
Ting-Yu Lin
2022-09-16T22:39:34
Add boilerplate to segmenter (#2566) * Update boilerplate for segmenter * Enable clippy::exhaustive_enums Mark both enum non_exhaustive in case that CSSWG adds new values to the corresponding CSS properties in the future. * Enable clippy::exhaustive_structs Ignore clippy::exhaustive_structs, clippy::exhau...
diff --git a/experimental/segmenter/src/lib.rs b/experimental/segmenter/src/lib.rs index 6b43bbf88b..87a7d7422c 100644 --- a/experimental/segmenter/src/lib.rs +++ b/experimental/segmenter/src/lib.rs @@ -67,7 +67,20 @@ //! //! See [`SentenceBreakSegmenter`] for examples. +// https://github.com/unicode-org/icu4x/blob...
3
18
0
9b1bc61c69752892c33594011751c0df522ab198
Oleksii Tkachuk
2022-09-16T16:10:10
Remove more for push usages in favor of extend (#2539)
diff --git a/components/datetime/src/pattern/reference/parser.rs b/components/datetime/src/pattern/reference/parser.rs index 49f8a43c90..48fa213067 100644 --- a/components/datetime/src/pattern/reference/parser.rs +++ b/components/datetime/src/pattern/reference/parser.rs @@ -128,9 +128,7 @@ impl<'p> Parser<'p> { ...
4
21
25
add4a2b9256ab5905bde14902708b5191fcc2f7c
Shane F. Carr
2022-09-15T22:29:36
Add some useful data provider impls; refactor AnyPayloadProvider (#2564)
diff --git a/components/datetime/tests/datetime.rs b/components/datetime/tests/datetime.rs index bbba1378f1..c2ca7cd2ad 100644 --- a/components/datetime/tests/datetime.rs +++ b/components/datetime/tests/datetime.rs @@ -468,35 +468,28 @@ fn test_dayperiod_patterns() { data.time_h23_h24.long ...
7
143
92
e88803860b3c07db8bc60c8f8118ca1ad652256b
Steven R. Loomis
2022-09-15T20:51:19
chore(license): fix license in collections/Cargo.toml, others (#2562) - also the two fuzz components didn’t have a license Fixes #2559
diff --git a/components/collator/fuzz/Cargo.toml b/components/collator/fuzz/Cargo.toml index c1e16b19a1..3ba4871d8a 100644 --- a/components/collator/fuzz/Cargo.toml +++ b/components/collator/fuzz/Cargo.toml @@ -8,6 +8,7 @@ version = "0.0.0" authors = ["Automatically generated"] publish = false edition = "2018" +lice...
3
4
2