Title stringclasses 3
values | Function_Vulnerability stringclasses 3
values | Description stringclasses 3
values | Severity stringclasses 2
values | POC_Foundry_Hardhat stringclasses 2
values | Recommended stringclasses 3
values |
|---|---|---|---|---|---|
User could withdraw more than supposed to, forcing last user withdraw to fail | function _executeWithdrawal( MarketState memory state, address accountAddress, uint32 expiry, uint baseCalldataSize ) internal returns (uint256) { WithdrawalBatch memory batch = _withdrawalData.batches[expiry]; // If the market is closed, allow withdrawal prior to expiry. if (expiry >= block.timestamp && !state.isClose... | Within Wildcat, withdraw requests are put into batches. Users first queue their withdraws and whenever there’s sufficient liquidity, they’re filled at the current rate. Usually, withdraw requests are only executable after the expiry passes and then all users within the batch get a cut from the batch.normalizedAmountPai... | High | function test_deadrosesxyzissue() external { parameters.annualInterestBips = 3650; _deposit(alice, 1e18); _deposit(bob, 0.5e18); address laurence = address(1337); _deposit(laurence, 0.5e18); fastForward(200 weeks); vm.startPrank(borrower); asset.approve(address(market), 10e18); asset.mint(borrower, 10e18); vm.stopPrank... | Although it’s not a clean fix, consider adding a addNormalizedUnclaimedRewards function which can only be called after a market is closed. It takes token from the user and increases the global variable state.normalizedUnclaimedRewards. The invariant would remain broken, but it will make sure no funds are permanently st... |
Users are incentivized to not withdraw immediately after the market is closed | function _applyWithdrawalBatchPayment( WithdrawalBatch memory batch, MarketState memory state, uint32 expiry, uint256 availableLiquidity ) internal returns (uint104 scaledAmountBurned, uint128 normalizedAmountPaid) { uint104 scaledAmountOwed = batch.scaledTotalAmount - batch.scaledAmountBurned; // Do nothing if batch i... | Within a withdraw batch, all users within said batch are paid equally - at the same rate, despite what exactly was the rate when each individual one created their withdraw. While this usually is not a problem as it is a way to reward users who queue the withdrawal and start the expiry cooldown, it creates a problematic... | Medium | After closing a market and filling the current expiry, delete it from pendingWithdrawalExpiry. Introduce a closedExpiry variable so you later make sure a future expiry is not made at that same timestamp to avoid collision. | |
FixedTermLoanHooks allow Borrower to update Annual Interest before end of the “Fixed Term Period” | function onQueueWithdrawal( address lender, uint32 /* expiry */, uint /* scaledAmount */, MarketState calldata /* state */, bytes calldata hooksData ) external override { HookedMarket memory market = _hookedMarkets[msg.sender]; if (!market.isHooked) revert NotHookedMarket(); if (market.fixedTermEndTime > block.timestam... | While the documentation states that in case of ‘fixed term’ market the APR cannot be changed until the term ends, nothing prevents this in FixedTermLoanHooks. In Wildcat markets, lenders know in advance how much APR the borrower will pay them. In order to allow lenders to exit the market swiftly, the market must always... | Medium | When FixedTermLoanHooks::onSetAnnualInterestAndReserveRatioBips is called, revert if market.fixedTermEndTime > block.timestamp. |
No dataset card yet
- Downloads last month
- 7