repository
stringclasses
156 values
issue title
stringlengths
1
1.01k
labels
stringclasses
8 values
body
stringlengths
1
270k
facebookreact
display a warning if component be call without prop
Enhancement
do you want to request a feature or report a bug this be a feature enhancement what be the current behavior prop parameter isn t validate in component and purecomponent omit prop be a common mistake that result in undefined this prop in constructor this may result...
facebookreact
improve message dispatch usestate be not a function when mix react next with
Enhancement
do you want to request a feature or report a bug report a bug what be the current behavior get typeerror dispatch usestate be not a function when try to call usestate this be happen in a create react app as well as in the codesandbox example below example what be...
facebookreact
case where hook don t currently provide a good answer vs hoc
Question
unsure if this be the right place so try it out I ve notice that the new react hook feature be aim at provide an alternative composition pattern to hoc and render function but I believe that many of the use case solve by hoc at the framework level can not currently be address by the new hook api sp...
facebookreact
suspense doesn t resolve for subsequent time if be suspend again
Bug
do you want to request a feature or report a bug possibly a bug what be the current behavior repro demo github user search type one character and wait after the list be render everything work correctly subsequent fetch work this way type two character fast than result for the fir...
facebookreact
suspense ping shouldn t suspend if all suspend content be already in fallback mode
Bug
when use suspense and hook specifically usestate and useeffect nest async render use react cache cause state hook not to be update specifically this happen between the first promise settle and the last promise settle in a suspense component however the state update concern can be outside of ...
facebookreact
safari devtool flood with security error on react dom selection work with iframe with diff origin
Bug
hey folk look like this code add small issue with safari and it could flood devtool console output with message like this as I understand it happen here diff a654f37b01573fc8006b426d56ad53cer50 and I see you catch the error but safari still add the error message if you have iframe with different o...
facebookreact
warn if reactdom createportal be inside a noscript or other text content tag
Enhancement
do you want to request a feature or report a bug bug what be the current behavior when call reactdom createportal from within a nothing happen no error be log javascript reactdom render reactdom createportal yo modalnode appnode ...
facebookreact
16 6 context api not work in class component
Enhancement
do you want to request a feature or report a bug quite possibly a bug or maybe confusion about the current api I be use the new context api as well as the new static contexttype in react 16 6 I be pass context down a couple component deep but when I attempt to access the context within the c...
facebookreact
react lazy defaultprop not merge into prop in commit phase lifecycle
Bug
do you want to request a feature or report a bug bug what be the current behavior in a component load use react lazy default prop be not merge into the prop object for these lifecycle componentdidmount componentdidupdate componentwillunmount getsnapshotbeforeupdate in sh...
facebookreact
suspense component should only capture if fallback prop be define
Enhancement
edit by acdlite decide in comment below that we will change the semantic so that a miss fallback prop mean the exception should propagate to the next parent like a rethrow that way a suspense component can specify other prop like maxduration without need to provide a fallback too ...
facebookreact
the gray overlay when tap the react root container
Bug
do you want to request a feature or report a bug bug what be the current behavior since seem that root element have onclick event handler with noop function in ios safari chrome browsers html element have gray overlay when tap on it the current behavior be that the whole ...
facebookreact
limitation of react createcontext
Question
do you want to request a feature or report a bug feature what be the current behavior the current behavior require end user to use createcontext in the module scope to my understanding it s not currently possible to use a default value derive from the state of a component a state...
facebookreact
npm create react class no way to implement getderivedstatefromprop
Question
there seem to be no way to implement class method such as getderivedstatefromprop and a few other be I overlook something there be no mention of it here either
facebookreact
global window event be overwrite in react 16 5 in development mode
Bug
do you want to request a feature or report a bug report a bug what be the current behavior global window event be overwrite in react 16 5 in development mode here re minimal repro step react 16 5 2 in dev mode if you click the button you see domcontentloade ...
facebookreact
16 5 with well support of iframe have some side effect
Bug
do you want to request a feature or report a bug bug what be the current behavior when transition from a state have an iframe inside a component to a state without that say iframe we have an error at setoffset node offset because node ownerdocument defaultview be null ...
facebookreact
feature request add dom to life cycle hook
Question
currently it s not very straight forward to get your hand on a component full dom in particular if it return multiple element in that case reactdom finddomnode just win t work so you re leave with ref but you ll never get the whole dom at once instead you get one element at a time you can of cour...
facebookreact
element attribute be remove silently in frameset tag
Question
do you want to request a feature or report a bug bug what be the current behavior in some historical reason I be still use obsolete tag frameset in my project and when I render my component which include frameset tag in react some attribute be ignore like row col coul...
facebookreact
miss umd variant of react profile min js
Bug
the 16 5 0 package release to unpkg currently have the production profile variant present for cjs build but there be no equivalent for umd build I e there be the file but there be no it would be great if a future release have the profiling variant package as umd as well also thank for the awesome fr...
facebookreact
warn if react forwardref render function doesn t take exactly two argument be confuse when more than 2 argument
Enhancement
do you want to request a feature or report a bug a feature an improvement what be the current behavior when define more than two parameter for a react forwardref render function a warning message state forwardref render function accept two parameter prop and ref do you forget to u...
facebookreact
pass react createcontext mistakenly as if it be an element cause confuse error
Enhancement
do you want to request a feature or report a bug bug what be the current behavior if you re really tired and forget to use a context provider and instead use the context as if it be a provider react understandably freak out but the error message be confuse I e j...
facebookreact
ie9 unable to call apply on console error when encounter an unknown tag
Bug
this be introduce in react 16 5 0 if ie9 encounter an unknown html element in development react crash as it attempt to call console error apply here l30 this be reproduceable with the follow codepen code demo
facebookreact
interaction reference count decremente too aggressively
Bug
under certain condition we decrement the count attribute too often which can result in oninteractionscheduledworkcomplete be call prematurely and or more than once for a give interaction x track interaction schedule during sync render phase x do not double decrement suspense load withi...
facebookreact
why we need both isbatchingupdate and isunbatchingupdate
Question
do you want to request a feature or report a bug question what be the current behavior imo from the naming isbatchingupdate should always equal isunbatchingupdate I wonder why we need both of they in 81224b diff 7a9f2b48de4b0ffcf7b436798ce9aaabr198 we add the isunba...
facebookreact
access react component underlie dom tree
Question
do you want to request a feature or report a bug feature what be the current behavior form component have form field child input checkbox etc that be validate against some custom rule when form be submit validation work fine what be the expect behavior if the for...
facebookreact
node umd bundle be break on master
Bug
see pullrequestreview 150683126 we ll need to remember to fix it one way or the other before cut a release
facebookreact
update component that make resource request trigger update warning
Bug
do you want to request a feature or report a bug bug but more of a minor annoyance what be the current behavior tl dr update a component that make a resource request which trigger state update cause a warning to be display this description be base off of a modify version of t...
facebookreact
consider keep legacy context api for non state usage
Question
do you want to request a feature or report a bug feature request question accord to react doc there be 2 way to avoid pass prop through many level 1 new context api 2 composition inversion of control when use the new context api a consumer component must know and explicitly...
facebookreact
question on reconciliation
Question
I think I understand reconciliation in react however there be one thing I would like to clarify let s say on first render we render duke key 0 villanova key 1 and on next render connecticut key 0 duke key 1 villanova key 2 if I understand...
facebookreact
react test renderer be possible to test lifecycle function
Question
do you want to request a feature or report a bug question what be the current behavior I be try to use react test renderer and I notice that the lifecycle method ex componentdidmount need to be fire manually render getinstance componentdidmount what solve my problem...
facebookreact
get key in react reconciler
Question
I be struggle to implement reusable view on mobile platform and to make it I need to get key value explicitly set and generate in react reconciler to match two different view tree somewhere outside react be there a way to achieve this thank
facebookreact
forwardref preclude use of composite component test util method
Enhancement
do you want to request a feature or report a bug bug I believe request to file a new issue per issuecomment 414868619 what be the current behavior when use reacttestutil that navigate the tree for composite component I be unable to find instance of component wrap in react forwardref ...
facebookreact
component prototype setstate callback be not receive any argument
Question
do you want to request a feature or report a bug bug what be the current behavior component prototype setstate s callback be not receive any parameter though line 47 in package react src reactbaseclasse js state that it will be call with the up to date component argume...
facebookreact
how map render an array of element
Question
what be the current behavior react16 support return array component for example render return li 1 li li 2 li li 3 li export default arraydemo I want to map it with react child map ...
facebookreact
tool for end to end testing
Question
this may be a question moreso than a feature request but I can t seem to find the answer around the web it seem most people be work on small app or just ignore this as an issue I be work on a large react application and see some issue with end to end testing we have a webdriverio selenium setup which seem ...
facebookreact
suspense fixture demo page scroll to top unnecessarily
Good First Issue
if you open that demo which live in this repo s fixture folder on a small screen tap one of the row at the bottom ex my name cause the page to scroll to the top immediately which mean you don t see the inline load indicator it should scroll to top after the data load but not before
facebookreact
host component outside the setstate path be sometimes unnecessarily diffe and update
Bug
extract from we re currently diff a host node in the complete phase even if it have bail out in the begin phase by itself this just mean we re do a little bit more work than necessary but it also have some observable effect in particular which by itself would be very rare and probably not worth fix b...
facebookreact
avoid reconciliation alternative component interface
Question
hello I want to ask a question about a way to avoid reconciliation process today I can see the follow process 1 component want to re render 2 component render method provide new virtual dom 3 some react diff library try to find some non optimal way to morph old virtual dom into new one plea...
facebookreact
might be time to update some of our package readme
Good First Issue
an npm package to get you immediate access to react without also require the jsx transformer this be especially useful for case where you want to browserify your module use react
facebookreact
profiler duration be sometimes incorrect
Bug
while work on the devtool profiler I ve notice that duration be sometimes incorrect this seem to be vaguely relate to high low priority state update need to track this down more so I m file an issue for myself
facebookreact
select multiple do not scroll to select item item
Bug
bug in react 15 we could set value or defaultvalue and select element scroll into view but in react 16 this do not work
facebookreact
if console error throw while report an error react can enter an invalid internal state
Bug
do you want to request a feature or report a bug bug what be the current behavior when reactfiberscheduler exceed the update count and throw the maximum update depth exceed invariant it do not update nestedupdatecount leave it in a dirty state this have be fix in thi...
facebookreact
what be mean within the readme of create subscription by async limitation can it be clarify
Question
what be mean within the readme md of create subscription by async limitation for full compatibility with asynchronous rendering include both time slice and react suspense the suggest long term solution be to move to one of the pattern describe in the previous section the pattern describe abov...
facebookreact
enzyme context api warning detect multiple renderer concurrently render the same context provider
Bug
do you want to request a feature or report a bug bug I guess what be the current behavior console error node modules fbjs lib warn js 33 warning detect multiple renderer concurrently render the same context provider this be currently unsupported step to reprodu...
facebookreact
react test renderer shallow sfc should not get this
Bug
do you want to request a feature or report a bug bug what be the current behavior this address a bug in enzyme on this line l110 element type invoke the sfc with element as the this value I believe that this be need for create react class component but that th...
facebookreact
add a more helpful message when pass an element to createelement as a type
Enhancement
this js createelement doesn t currently give a distinguishable message but we can easily detect it by check for typeof and in that case suggest something more concrete e g do you accidentally export jsx instead of a component
facebookreact
warn when setstate be a function that doesn t return
Enhancement
do you want to request a feature or report a bug I be propose add a warning in development what be the current behavior when I do this setstate bool bool bool this be valid javascript but be meaningless in react eslint no label help to catch this but we can proba...
facebookreact
pop ssr provider be o n where n number of provider on the stack
Enhancement
see for detail not sure if it matter in practice do people often have many dozen and more provider deep inside the tree if we can remove the loop there it would be nice
facebookreact
react dom throw referenceerror requestanimationframe be not define in ssr environment since 12931
Bug
do you want to request a feature or report a bug bug what be the current behavior the change seem to have break the server side rendering on master I m attempt to yarn start the fixture ssr to test and get the follow error from the server side when I load the localh...
facebookreact
componentwillupdate discussion
Question
do you want to request a feature or report a bug feature componentwillupdate discussion what be the current behavior the current behavior call the function before re render the render target however there be no indication for when the re render method should be call if the current...
facebookreact
react context issue
Bug
do you want to request a feature or report a bug bug what be the current behavior one context consumer have a value of another contexts provider if the current behavior be a bug please provide the step to reproduce and if possible a minimal demo of the problem example js ...
facebookreact
return an empty fragment throw a confusing error
Bug
render a component like js const foo throw the error foo nothing be return from render this usually mean a return statement be miss or to render nothing return null the error be confusing because clearly foo be return a value I don t know if we want t...
facebookreact
fire change event for change make to input before hydration
Enhancement
currently when hydrate server render markup we ignore change the user make before hydration we also don t reset their change once hydration finish the motivation there be likely to avoid lose user input see this test l543 l552 the problem with that be that it assume the value will continue to be change ...
facebookreact
onchange event doesn t trigger when direclty click on the maximum input type range value
Bug
do you want to request a feature or report a bug bug what be the current behavior when you directly after the loading choose the maximum value on the input type range the event isn t fire with an onchange the event be fire when it s not the maximum value of the input sandbox cli...
facebookreact
keep use legacy context api or how to achieve this with new api
Question
do you want to request a feature or report a bug more like a feature what be the current behavior so I be currently use the legacy context api very heavily a typical component tree in my app might look a bit like this js provide 3 object via context all child might nee...
facebookreact
suspense timeout expiration and sibling render issue
Question
do you want to request a feature or report a bug bug what be the current behavior code for reproducing be here I ve also deploy an example to zeit now this be a basic example of use react suspense and simple cache provider postpone text render and show loading spinner when it ...
facebookreact
question regard prop child
Question
do you want to request a feature or report a bug just question some question regard prop child in the official react documentation of react child reactchildren you can read that this prop child be an opaque datum structure what do that mean exactly I think there be i...
facebookreact
support pointer event
Duplicate
pointer event be currently unknown event handler property in react what be the current behavior this js fiddle show that attach the onpointerdown event to a div produce this warning in the console warn unknown event handler property onpointerdown it will be ignore ...
facebookreact
submit reset input lose text when value undefine
Bug
do you want to request a feature or report a bug bug what be the current behavior create an
facebookreact
unsafe lifecycle function can no long be define more than once via mixin
Bug
do you want to request a feature or report a bug bug what be the current behavior the unsafe lifecycle function alias in 16 3 2 be not merge when define more than once because of mixin trigger an error uncaught error reactclassinterface you be attempt to define unsafe compone...
facebookreact
react art react context api be not work correctly
Bug
do you want to request a feature or report a bug bug what be the current behavior when you use react art rendrer the consumer be pick up the default value define by the initial creation of the context rather than the value provide by provider actual behabiour shape have...
facebookreact
defaultchecke prop set only check attribute
Bug
type inconsistency for common use case bug for project rely on correct dom emission description it s unclear to I if the following be a know issue or not take in consideration the snippet below jsx current behavior set the defaultvalue prop on input of other typ...
facebookreact
warn message recommend use soon deprecate lifecycle method
Bug
which version of react and which browser os be affect by this issue do this work in previous version of react react 16 3 1 what be the current behavior warning message recommend use soon to be deprecate lifecycle method componentwillmount warning content warning can not u...
facebookreact
use and set a component s state within setinterval function
Question
this be a question so I apologize if this isn t the good place to ask I m try to work with a component s internal state within a setinterval function and I know there be some asynchronous problem I need to be aware of I also know that I can pass setstate a function which would help I protect against async proble...
facebookreact
why be the consumer and provider property of consumer
Question
be there a high meaning for 1 consumer and provider both be property of consumer 2 and consumer being of type symbol react context and not react consumer while provider be of type symbol react provider jsx const mycontext react createcontext value mycontext ...
facebookreact
context api bitmask relate question
Question
I m play with context api bitmask feature to bail out unwanted re render I have a dynamic model a json object as context value by dynamic I mean the number of key and structure of the json object be unknown but when the json object change I know which key be change it seem difficult to turn the un...
facebookreact
size prop be not attach to the dom
Bug
do you want to request a feature or report a bug bug what be the current behavior the size prop can only be a number and I think this should be true for input and select but not necessarily true for the rest of html tag or web component if the current behavior be a bug please prov...
facebookreact
react test renderer create do not work properly with forwardref component
Bug
do you want to request a feature or report a bug bug what be the current behavior if you try to access the root of a component tree of a component create with forwardref you will get an error unexpected object pass to reacttestinstance constructor if the current behavio...
facebookreact
clone the child of a context consumer produce confusing warning and error
Question
do you want to request a feature or report a bug this be a bug or at least a request for more precise warning and error message what be the current behavior I be clone child to add some property and I overlook that the context consumer subtree should not be clone import reac...
facebookreact
unexpected behavior when use react forwardref with react createcontext
Bug
do you want to request a feature or report a bug bug what be the current behavior example if the logprop be child of m provider and m consumer be use in its child when the m provider be update even if the logprop be wrap in a component that never update it can s...
facebookreact
strange beahvior react new context api
Bug
I think it be a bug git with example npm I npm start go to dependency react v16 3 2 chrome v65 0 3325 181 component context orderdetailscontext root component ordersview simple component ordersviewrow subscribe component orderdetailsview problem applic...
facebookreact
improve warn message for failure to initialize state when use getderivedstatefromprop
Enhancement
do you want to request a feature or report a bug bug what be the current behavior the warning for a failure to initialize state when use getderivedstatefromprop be not as clear as it could be this component produce the warning mycomponent do not properly initialize state du...
facebookreact
have a context provider as root element cause rendertostre to omit datum reactroot from output
Bug
do you want to request a feature or report a bug bug what be the current behavior datum reactroot be miss from the generate string cause exist valid dom to be clear if the current behavior be a bug please provide the step to reproduce and if possible a minimal demo of the problem yo...
facebookreact
onchange doesn t fire if a capture phase document listener for the underlie native event call setstate
Bug
do you want to request a feature or report a bug a bug what be the current behavior checkbox not fire onchange for control component it somehow relate to global event listener with setstate see sandbox example what be the expect behavior checkbox should fire onchange handler ...
facebookreact
question context provider state initialisation
Question
consider a component wrap a context provider js class valuewrapper extend react component constructor prop super prop this state value null setvalue this setvalue setvalue value this setstate value render ...
facebookreact
multiple renderer should allow context
Enhancement
l51 we currently don t allow multiple renderer share the same context however we should relax that constraint they should be allow as long as render isn t interleave so when we pop the provider we should also pop the sigil we need this to run fabric and rn at the same time
facebookreact
reactjs logo license
Question
I have be unable to find out what the license for the react logo be do anyone know under which license it be
facebookreact
new context provider may block old context propagation if child be constant
Bug
do you want to request a feature or report a bug bug what be the current behavior it seem that if the child of a new style react createcontext context provider be constant the provider can block update from old style this context context provider from propagate to t...
facebookreact
react dom development bundle use array from
Bug
do you want to request a feature or report a bug bug what be the current behavior currently the 16 3 x version of react dom ship react dom development js contain usage of array from which be not available in certain react support browser like ie11 it cause breakage i...
facebookreact
improve reactdom s uppercase html warn
Enhancement
do you want to request a feature or report a bug improvement request discussion what be the current behavior render in reactdom foobar be use uppercase html always use lowercase html tag in react what be the expect behavior the warning message can be improve to make it m...
facebookreact
possible incorrect event target on number input in ie9
Bug
since react 16 0 0 it look like there might be a case where event target on a change event in ie9 report as the window but I can t reproduce it outside of the dom test fixture step to reproduce 1 open this build of the fixture in ie9 2 enter text into an input 3 observe that the event ...
facebookreact
warn in ie 11 when use react fragment
Bug
do you want to request a feature or report a bug bug what be the current behavior with react 16 3 0 when use ie 11 give the follow warning warn invalid prop child supply to react fragment react fragment can only have key and child prop step to r...
facebookreact
error boundary bug
Bug
do you want to request a feature or report a bug bug what be the current behavior an internal error be raise when the error try to propagate uncaught typeerror can not read property return of null uncaught typeerror can not read property return of null at renderroot...
facebookreact
bug new context api do not work with reactdom unstable rendersubtreeintocontainer
null
do you want to request a feature or report a bug bug what be the current behavior consumer render by invoke reactdom unstable rendersubtreeintocontainer invoke render function with default context value ignore value of provider if the current behavior be a bug please provide the step...
facebookreact
uncaught error should be work on a root this error be likely cause by a bug in react
Bug
get this debug another error filing here for reference original code
facebookreact
backspace over word boundary cause cursor jump when input type be email
Duplicate
do you want to request a feature or report a bug bug what be the current behavior the input cursor jump to the beginning upon backspace over the final character or word that follow a space when the input type be email reproduce on jsfiddle the step the end user must take be r...
facebookreact
custom property name contain or get remove from custom component
Duplicate
this could be consider a bug or a feature request I say this because I know that react be check for w3c valid attribute property name not namestartchar but the check be run inconsistently between normal component and custom component which make its behavior confuse that mean this could be feature to be more...
facebookreact
can not read property return of null
Bug
run into a strange issue that I can not reproduce it happen when run test in karma use 16 3 0 alpha 3 image the issue be here l864 l877 my test be throw an error because of a miss onchange handler when render a checkbox with check but no handler what appear to be happen be that ne...
facebookreact
be there a way to access new context api within componentdidmount
Question
we be build a react mapbox gl module and we use clone and inject prop today we be look into use the 16 2 0 context api but I see that it will have a new one on 16 3 0 but I can t seem to find a way to read context detail on componentdidmount lifecycle which make sense for I to use on the map implementation ...
facebookreact
keep the child mount but replace the parent
Question
hi I m try to do something like this const container prop prop somecondition prop child prop child const app prop basically what I want be a situation where app be rerendere on a change boolean pro...
facebookreact
impossible to change classname
Invalid
I would like to change a class name to invoke a simple animation effect classname as an attribute must be a string when I run render it appear to do more than simply update the class as the animation doesn t run even with key set I also can t render once and then change the class as prop be readonly
facebookreact
question about settimeout effect of two react demo
Invalid
I be a react learner I m counfuse by two react demo demo1 demo2 demo1 js import react from react let num 0 export default class hello extend react component state loading false datum 0 componentdidmount settimeout ...
facebookreact
potential future bug in geteventkey for edge with synthetic event normalization
Question
bug current behavior react currently normalize keyboard event cross browser by fall back on the native keyboardevent keycode property and use a dictionary object to normalize the key as note in the source geteventkey be use for normalization of deprecate html5 key value edge currently do ...
facebookreact
react add classname to dom instead of class in ie11
Bug
do you want to request a feature or report a bug it be a bug what be the current behavior react add classname to the dom instead of class property if the current behavior be a bug please provide the step to reproduce and if possible a minimal demo of the problem your bug wi...
facebookreact
capture event trigger after vanilla bubble event
Question
do you want to request a feature or report a bug bug what be the current behavior when subscribe to dom event it s possible to use capturing however it seem that capturing take place after the vanilla javascript bubble phase this result in an incorrect order of event unless all event be su...
facebookreact
don t synchronize property value with attribute especially for the value attribute
Duplicate
just read this repo
facebookreact
state change in td element
Question
display tabular row when set datum in td element on state change it display only the currently update td element datum all the other one go miss from screen when the same thing be place within text box in each td element thing work fine follow be sample the code work code fail code ...
facebookreact
it s not safe to read currentowner current and assume it have a statenode
Bug
this l217 might mean that owner statenode be null so assumption like this lead to runtime failure in dev l1131 we should fix up all such code site
facebookreact
context update doesn t fully propagate in some case
Bug
I think there may be a bug in context in the late alpha when some update be schedule in the commit phase it doesn t seem to propagate git clone cd emoji search yarn yarn start enter mon erase it click on dark mode expect all child update actual some child don t update ...
facebookreact
context provider and maybe consumer show up as unknown in performance tab
Bug
notice this with 16 3 alpha I think we just need to support it here or else we could skip they here l162 altogether
facebookreact
child of consumer without new line give typeerror render be not a function
Enhancement
do you want to request a feature or report a bug bug what be the current behavior I get a confusing error when not use a new line in the child of a consumer un the new context api error selection 108 fix selection 109 what be the expect behavior comp...