repository
stringclasses
156 values
issue title
stringlengths
1
1.01k
labels
stringclasses
8 values
body
stringlengths
1
270k
trekhlebjavascriptalgorithms
add persistent vector
Enhancement
I would like to contribute to add persistent vector it s a cool immutable data structure thumb up if it interest you
trekhlebjavascriptalgorithms
italian language
Enhancement
can I help you with the italian translation you do a great job
trekhlebjavascriptalgorithms
add timsort
Enhancement
chrome 70 array prototype sort use the stable timsort algorithm
trekhlebjavascriptalgorithms
suggestion ship production ready build to npm
Enhancement
hey I notice that the current version deploy on npm I e be more or less a mirror of the source code here javascript algorithm be really awesome and someone might want to use it as an external library on production e g a web app or node app unfortunately the use of es module complicate thing a ...
trekhlebjavascriptalgorithms
my concern about no classification by procedural imperative and functional programming paradigm
Enhancement
hi this be a great project thank I have a concern that I would like to share for instance look at algorithm math factorial which be one of the most basic math topic I find 2 implementation factorial js js export default function factorial number let result 1 ...
trekhlebjavascriptalgorithms
translate to russian
Enhancement
hello I want to translate all readme into russian be there any rule for translation
trekhlebjavascriptalgorithms
add b tree
Enhancement
I would like to contriblute to add the b tree datum structure it be a rather common data structure that be great for large datum I ll be glad to implement it
trekhlebjavascriptalgorithms
a algorithm
Enhancement
hey this repo be awesome nice job while I be read through the algorithm I find weird that the a algorithm be miss which be one of the few I know I m just go to leave this as a suggestion sorry if I can t do a pull request
trekhlebjavascriptalgorithms
what about rope
Enhancement
I find this repo while look for a good example of rope but I can t find one
trekhlebjavascriptalgorithms
disjointset optimization suggestion
Enhancement
I think there be a few thing we can optimize for the current disjointset implementation path compression we can add path compression it will greatly reduce the rank with little change to the code getroot if this isroot return this this parent this pare...
trekhlebjavascriptalgorithms
a bug in method reverse of doubly link list
Bug
l238 l260 the function omit change target of one node s previous
trekhlebjavascriptalgorithms
I have a question in shell sort readme md
Bug
after gap 2 compare and swap the value why not 14 10 27 19 35 33 42 44 but image thank
trekhlebjavascriptalgorithms
it have some mistake in link list
Bug
hey I feel the link list part have some mistake delete remove head value pre head be the head node in the list value be the value to remove from the list post value be remove from the list true otherwise false if head return false end if n head ...
trekhlebjavascriptalgorithms
heap remove function have bug
Bug
l178 should be remove the test case be that min heap 1 2 3 4 5 6 7 8 9 remove 2 and should be expect 1 4 3 8 5 6 7 9 but get 1 9 3 4 5 6 7 8 with the wrong code
trekhlebjavascriptalgorithms
test suite fail to run on ubuntu
Bug
test suite fail to run securityerror localstorage be not available for opaque origin at window get localstorage as localstorage node modules jsdom lib jsdom browser window js 257 15 at array foreach
trekhlebjavascriptalgorithms
add max heap
Enhancement
a max heap ds would be terrific in this repo should I work on it and submit a pr I m also open to other ds or algorithm contribution
trekhlebjavascriptalgorithms
big o notation
Enhancement
I m think of add big o notation to the doc base on big o cheat sheet would this be useful
trekhlebjavascriptalgorithms
need pseudocode
Enhancement
I m think of add pseudocode to the readme base on dsa by granville barnett and luca del tongo would this be useful
trekhlebjavascriptalgorithms
long common substring do not handle unicode properly
Bug
it seem that the algorithm longestcommonsubstring do not handle unicode character properly js longestcommonsubstr abc abc whereas the long one should be abc in term of number of code point number of code point length 2 abc length 3 ...
trekhlebjavascriptalgorithms
translate to spanish
Enhancement
I believe it would be nice to translate the readme md to spanish and would love to help
trekhlebjavascriptalgorithms
translate to polish
Enhancement
hi can I translate the readme md to polish thank
trekhlebjavascriptalgorithms
trie remove word
Enhancement
remove word in a trie seem equally important as add word it would be nice to have that
trekhlebjavascriptalgorithms
translate to korean
Enhancement
hello I want to translate readme into korean can I and be there any restriction
trekhlebjavascriptalgorithms
rabinkarp seem to miss some match
Bug
hello I recently try to run some property base test on the algorithm provide in javascript algorithm I discover the follow fail case with rabinkarp algorithm javascript expect rabinkarp pp pp tobe 2 output 1 in order to find it I use fast check framework ...
trekhlebjavascriptalgorithms
floyd warshall algorithm
Enhancement
null
trekhlebjavascriptalgorithms
add doubly link list
Enhancement
shouldn t there be doubly link list too if yes can I contribute for it
trekhlebjavascriptalgorithms
group algorithm for study
Enhancement
thank you for create this repo it s awesome I just have one small question can you divide all algorithm into group of level like beginner intermediate advance etc so someone like student or newbie know where to start
trekhlebjavascriptalgorithms
knapsack item setting ignore itemsinstock
Bug
the algorithm ignore itemsinstock count
trekhlebjavascriptalgorithms
combination without repetition algorithm difficult to understand
Enhancement
I find the algorithm be so hard to understand that I almost pull my hair off I try to analyze it in python tutor but it didn t get easy after struggle for a few hour I figure a solution that be more expressive and easy to understand function combowithoutrepeat choosefrom numchosen const com...
trekhlebjavascriptalgorithms
what should be return by the remove method of the binarysearchtreenode
Bug
hi the remove method return a binarysearchtreenode object but there be one uncertain moment what should be contain in the property of this object such as the parent leave right be these property relevant or they must be null
trekhlebjavascriptalgorithms
z algorithm
Enhancement
I m new to open source I want to implement z algorithm for string
trekhlebjavascriptalgorithms
add liu hui s algorithm
Enhancement
e g js const getsidelength sidelength count if count 0 return sidelength const m sidelength 2 const g math sqrt 0 5 2 m 2 const j 0 5 g return getsidelength math sqrt j 2 m 2 count 1 const pi s...
trekhlebjavascriptalgorithms
primality test failure
Bug
the primality test win t work for float between 1 and 3
trekhlebjavascriptalgorithms
implement binary index tree
Enhancement
hi I m new to this repository and would like to try to implement the binary index tree
trekhlebjavascriptalgorithms
implement segment tree
Enhancement
I m plan to get start on a segment tree implementation the first step would be to implement range min query then possibly a generalized implementation
trekhlebjavascriptalgorithms
bug in avl tree rotateleftright and rotaterightleft
Bug
in rotateleftright while leftrightnode have leave child it will be lose also as well rotaterightleft the follow code be my correction js rotateleftright rootnode detach leave node from rootnode since it be go to be replace const leftnode rootnode leave rootnode setle...
trekhlebjavascriptalgorithms
add another section
Enhancement
you ve create a wonderful repository it s really interesting especially for learn purpose like in my case what do you think about add a new section that explain how to calculate 3d geometry function
trekhlebjavascriptalgorithms
fibonacci sequence
Enhancement
not an issue more of a suggestion would be good to return an array for the fibonacci sequence as well as the sequence at nth position and maybe rename the nth position fibonaccinth or something for example javascript export default function fibonacci step const fibsequence ...
trekhlebjavascriptalgorithms
add red black tree
Enhancement
hello I have once write red black tree in java and interesting to write another version in javascript anyone have already work on it if no one maybe I will pull the red black tree tonight regard hafidz
trekhlebjavascriptalgorithms
workshopper
Enhancement
how about create a workshopper I would love to create one
trekhlebjavascriptalgorithms
avl tree do not rebalance after removal
Bug
hi thank for your project I can t seem to find the removal algorithm in avl tree if it simply borrow the binary tree removal it s incomplete I be particularly interested in that cause I have be look for a removal procedure that doesn t mutate the node cheer
thealgorithmspython
migrate to numpy 2 0
Enhancement
describe your change relate to 11320 add an algorithm fix a bug or typo in an exist algorithm add or change doctest note please avoid change both code and test in a single pull request documentation change checklist x I have read contribute md ...
thealgorithmspython
engineer
Bug
repository commit abcbnnmkghtydgx python version python version python 3 10 7 dependency version pip freeze engineering expect behavior engineering actual behavior electrical
thealgorithmspython
migrate to numpy 2 0
Enhancement
feature description the beta release of numpy be now available so we should run the appropriate ruff command and ensure our algorithm be compatible maximsmolskiy
thealgorithmspython
data structures trie radix tree py will not really end up in case 1 for insert
Bug
repository commit 2e405f3 python version python version python 3 11 6 dependency version pip freeze n a expect behavior root node radixnode root node insert fooaaa root node insert foobbb root node insert foo should work I e should have a str...
thealgorithmspython
haversine distance may be use the wrong phi1 and phi2 angle
Bug
repository commit 2e405f397bbcefccc470f215c7ff024875ef16c5 python version python version na dependency version pip freeze na expect behavior first of thank for all the algorithm and the work the current and initial implementation of the haversine distance be use reduc...
thealgorithmspython
add financial algorithm in python
Enhancement
feature description add the different machine learn algorithm of quantitative finance
thealgorithmspython
update topological sort py
Enhancement
describe your change contribute to add an algorithm fix a bug or typo in an exist algorithm x add or change doctest note please avoid change both code and test in a single pull request documentation change checklist I have read contribute md ...
thealgorithmspython
add doctest to trapezoidal rule
Enhancement
describe your change contribute to 9943 add an algorithm fix a bug or typo in an exist algorithm x add or change doctest note please avoid change both code and test in a single pull request documentation change checklist x I have read contribute ...
thealgorithmspython
global variable should not use in class method
Bug
repository commit 9caf4784aada17dc75348f77cc8c356df503c0f3 python version python version python3 11 dependency version pip freeze nop expect behavior hi guy I come across one global variable that use in class method I think use instance attribute would be well pyth...
thealgorithmspython
goldbach s conjecture
Enhancement
feature description I wish to add a program that test goldbach s conjecture
thealgorithmspython
update pooling function py with minpoole function
Enhancement
describe your change x add an algorithm fix a bug or typo in an exist algorithm add or change doctest note please avoid change both code and test in a single pull request documentation change checklist x I have read contribute md x this pu...
thealgorithmspython
add set like operation to fuzzyset class and improve variable name
Enhancement
hacktoberf description this pull request extend the functionality of the fuzzyset class by introduce set like operation and add corresponding doctest these enhancement make the fuzzyset class even more versatile for work with fuzzy set in the context of fuzzy logic change make ...
thealgorithmspython
draft update binary search tree py
Enhancement
describe your change add an algorithm x fix a bug or typo in an exist algorithm add or change doctest note please avoid change both code and test in a single pull request documentation change checklist x I have read contribute md x this pu...
thealgorithmspython
add test to graphs dijkstra 2 py
Enhancement
describe your change create docstring and test case for the min dist helper function in dijkstra 2 as it be a non void function contribute to 9943 add an algorithm fix a bug or typo in an exist algorithm x add or change doctest note please avoid change both code and ...
thealgorithmspython
fix bug miss edge case for odd even transposition parallel py
Enhancement
describe your change this enhance code include fix bug point out by raymonddashwu the problem with the algorithm be that it assume the length of the array to be sort equal to 10 check the 1st for loop inside the function oe process which be why when raymonddashwu try sort an array with length 11 th...
thealgorithmspython
container build fail in codespace
Bug
repository commit d91ca8b6b75140e04a1cea051cbf09474215a2bd python version python version python 3 11 5 dependency version pip freeze cfgv 3 4 0 distlib 0 3 7 filelock 3 12 4 identify 2 5 30 nodeenv 1 8 0 platformdir 3 11 0 pre commit 3 5 0 pyyaml 6 0 1 set...
thealgorithmspython
update prefix sum function
Enhancement
describe your change add an algorithm x fix a bug or typo in an exist algorithm add or change doctest note please avoid change both code and test in a single pull request documentation change checklist x I have read contribute md x this pu...
thealgorithmspython
nest function can t be test by doct
Enhancement
feature description 9943 so I be add doctest to a nest function in fibonacci py however doctest doesn t seem to be test that function the function in this case be fib recursive term that s nest inside fib recursive as see below image note the 5 doctest for fib recursive term be ...
thealgorithmspython
correct and optimize the file long increase subsequence py
Enhancement
describe your change correct and update the long increase subsequence algorithm add an algorithm x fix a bug or typo in an exist algorithm add or change doctest note please avoid change both code and test in a single pull request documentation change check...
thealgorithmspython
add docstre to create all combination py
Enhancement
describe your change add docstre to create all combination py contribute to 9943 if a function doesn t have a docstring add one add an algorithm fix a bug or typo in an exist algorithm x add or change doctest note please avoid change both code and test in a singl...
thealgorithmspython
more detailed information on test failure in action page
Enhancement
feature description when create test for various algorithm files there isn t a way to see what test fail on the github action you see something like this something like doct testmod provide more usable datum to work off of
thealgorithmspython
duplicate algorithm in math primelib py
Enhancement
feature description math primelib py contain multiple function for commonly use computation relate to prime sieve of eratosthene least common multiple prime factor etc and most if not all of these be also implement in other file in an effort to remove duplicate algorithm should we delete mat...
thealgorithmspython
test case for interpolation search
Enhancement
describe your change contribute to 9943 add an algorithm fix a bug or typo in an exist algorithm documentation change x add test case checklist x I have read contribute md x this pull request be all my own work I have not plagiarize x ...
thealgorithmspython
test case for all permutation
Enhancement
describe your change contribute to 9943 minor fix with generate all permutation function print instead of return an output add an algorithm x fix a bug or typo in an exist algorithm documentation change x add test case checklist x I have read contribute...
thealgorithmspython
error at web programming instagram crawler py
Bug
repository commit ac3bd1032c02ff5c2f6eb16f2bf5a1b24d106d1c python version python version 3 12 0 dependency version pip freeze beautifulsoup4 4 12 2 certifi 2023 7 22 charset normalizer 3 3 0 colorama 0 4 6 contourpy 1 1 1 coverage 7 3 2 cycler 0 12 1 fake user...
thealgorithmspython
performance and refactor 83 86 fast project euler 104
Enhancement
describe your change relate issue 8594 feedback be welcome and greatly appreciate refactore be pandigital both rename check be pandigital both remove duplicate code now it use be pandigital end and be pandigital start to check both side of the give n...
thealgorithmspython
update single indeterminate operation py
Enhancement
describe your change x add an algorithm fix a bug or typo in an exist algorithm x documentation change checklist x I have read contribute md x this pull request be all my own work I have not plagiarize x I know that pull request will not be mer...
thealgorithmspython
performance 95 fast project euler 187
Enhancement
describe your change utilize the numpy module project euler 187 now run 97 fast than the original implementation and be 79 fast than my previous solution issue 1943806371 relate issue 8594 add an algorithm x fix a bug or typo in an exist algorithm documentatio...
thealgorithmspython
pyt warning in build
Bug
repository commit doesn t matter python version python version python 3 12 0 the current version use in build dependency version pip freeze doesn t matter expect behavior pyt run with no internal warning actual behavior every build see our action tab have the...
thealgorithmspython
performance 58 fast project euler 070
Enhancement
describe your change 8594 benchmark old solution 118 2 10 second new solution 49 3 10 second add an algorithm x fix a bug or typo in an exist algorithm documentation change checklist x I have read contribute md x this pull req...
thealgorithmspython
add doctest in stock span problem py
Enhancement
describe your change add doctest in stock span problem py add an algorithm x fix a bug or typo in an exist algorithm documentation change checklist x I have read contribute md x this pull request be all my own work I have not plagiarize x I kn...
thealgorithmspython
change the code to return tuple in dynamic programming subset generation py 10189
Enhancement
describe your change I have make a return tuple available in the subset generation py x add an algorithm x fix a bug or typo in an exist algorithm documentation change checklist x I have read contribute md x this pull request be all my own work I h...
thealgorithmspython
refactor flip augmentation
Enhancement
describe your change x add an algorithm x fix a bug or typo in an exist algorithm x documentation change checklist x I have read contribute md x this pull request be all my own work I have not plagiarize x I know that pull request will not be me...
thealgorithmspython
update the heap sort algo with more concise and redable code
Enhancement
describe your change x add an algorithm fix a bug or typo in an exist algorithm documentation change checklist x I have read contribute md x this pull request be all my own work I have not plagiarize x I know that pull request will not be merg...
thealgorithmspython
fix recurssionerror in negative power
Enhancement
describe your change add an algorithm x fix a bug or typo in an exist algorithm documentation change checklist x I have read contribute md x this pull request be all my own work I have not plagiarize x I know that pull request will not be merg...
thealgorithmspython
fix fix the code to return tuple so we can add doctest in it and
Enhancement
make cover high in dynamic programming subset generation py describe your change 1 in this version each combination be add to a list 2 the combination util function return a list of tuple where each tuple represent a valid combination of r element from the input array 3 it separa...
thealgorithmspython
fix 9943 combination sum fix and test case
Enhancement
describe your change 1 fix one test case where the element in the list be negative but in the constraint it be mention the element can t be negative so throw a valueerror for it 2 add a new test case where error be throw if list be empty add an algorithm x fix a bug or typo in an ex...
thealgorithmspython
remove double implementation of vigenere cipher py fix 8098
Enhancement
describe your change fix 8098 there be a file beaufort cipher py which be nothing but actually an implementation of vigener cipher and it be well than vigenere cipher py so I delete original vigenere cipher py and replace it with the implementation of beaufort cipher py ...
thealgorithmspython
fix bug in priorityqueue algorithm fix syntax in code for array
Enhancement
describe your change there be a bug in priorityqueue class due to which extract min function be give wrong output hence fix it add an algorithm x fix a bug or typo in an exist algorithm documentation change checklist x I have read contribute md x this ...
thealgorithmspython
fix input add some error test and add note about random
Enhancement
describe your change relate to add an algorithm fix a bug or typo in an exist algorithm x documentation change checklist x I have read contribute md x this pull request be all my own work I have not plagiarize x I know that pull request will n...
thealgorithmspython
add test for enigma machine
Enhancement
describe your change relate to add an algorithm fix a bug or typo in an exist algorithm x documentation change checklist x I have read contribute md x this pull request be all my own work I have not plagiarize x I know that pull request will ...
thealgorithmspython
add some documentation for heap sort
Enhancement
describe your change relate to add an algorithm fix a bug or typo in an exist algorithm x documentation change checklist x I have read contribute md x this pull request be all my own work I have not plagiarize x I know that pull request will ...
thealgorithmspython
improve our test coverage
Enhancement
feature description many of our exist algorithm file have little to no unit test this be problematic because this can easily let bug slip through we want some assurance that the code we currently have be correct and functional we welcome all contributor to open prs to help we add test to our codebase ...
thealgorithmspython
algorithm to find unique prime factor
Enhancement
describe your change algorithm to find unique prime factor x add an algorithm fix a bug or typo in an exist algorithm documentation change checklist x I have read contribute md x this pull request be all my own work I have not plagiarize x I k...
thealgorithmspython
add global average pooling
Enhancement
describe your change x add an algorithm fix a bug or typo in an exist algorithm documentation change checklist x I have read contribute md x this pull request be all my own work I have not plagiarize x I know that pull request will not be merg...
thealgorithmspython
add gaussian naive baye py issue naive baye 9332
Enhancement
describe your change x add an algorithm fix a bug or typo in an exist algorithm documentation change checklist x I have read contribute md x this pull request be all my own work I have not plagiarize I know that pull request will not be merge...
thealgorithmspython
update simple neural network py
Enhancement
create simple neural network py from scratch it now contain forward propagation as well as backward propagation with training of the simple 2 layer neural network article refer be a free resource avialable for evryone fix 8785 add an algorithm fix a bug or typo in an exist...
thealgorithmspython
update bisection py
Enhancement
alittle optimization describe your change add an algorithm x fix a bug or typo in an exist algorithm documentation change checklist x I have read contribute md x this pull request be all my own work I have not plagiarize x I know that pul...
thealgorithmspython
update heap algorithm
Enhancement
describe your change refactore the heap s algorithm to improve clarity and efficiency update docstre to include doctest ensure consistent whitespace and well documentation of function behavior add an algorithm x fix a bug or typo in an exist algorithm x documentation change ...
thealgorithmspython
machine learn linear regression py doesn t give optimal coefficient
Enhancement
feature description relate to issue 8844 tl dr the current implementation doesn t give optimal solution the current implementation calculate sse wrong and we should add an implementation of a numerical method algorithm that actually give optimal solution in machine learn linear regression py ...
thealgorithmspython
fix fail pyt quantum q fouri transform py
Bug
repository commit 46379861257d43bb7140d261094bf17dc414950f python version python version python 3 11 3 dependency version pip freeze absl py 1 4 0 astunparse 1 6 3 beautifulsoup4 4 12 2 black 23 3 0 cachetool 5 3 1 certifi 2023 5 7 cffi 1 15 1 cfgv 3 3 1 c...
thealgorithmspython
do something about machine learn forecasting
Enhancement
feature description in reference to 7305 it s clear to I that nandiya isn t come back to fix the warning in machine learn forecasting run py with that say I want to discuss some more fundamental issue that I have with the file and get other opinion on what to do about they at the risk of soun...
thealgorithmspython
optimize project euler solution
Enhancement
feature description if someone would like to take a stab at optimize these solution feel free to open a pr or ask for any help here slow 10 duration problem 145 sol1 py 25 00 problem 070 sol1 py 13 86 problem 104 sol1 py 6 84 proble...
thealgorithmspython
concatenate consolidate all algorithm with different implementation
Enhancement
feature description there be lot of algorithm with the same concept but different implementation method in different file all these should be move into one file
thealgorithmspython
importance of cache algorithm
Enhancement
feature description this be an algorithm base repository which do not necessarily focus on time complexity but also on readability and understandability that be say specific algorithm be benchmarke for speed comparison and sometimes implement a cache system vastly improve this speed for example ...
thealgorithmspython
mypy produce error when run on its own
Enhancement
feature description apology if I m misunderstand about how mypy be set up with this repo mypy currently produce a litany of error when run on its own even though it pass when run as part of pre commit mypy ignore miss import install type non interactive dynamic programming fi...
thealgorithmspython
implement xgboost classification and regression algorithm
Enhancement
feature description machine learn xgboost classifier py and machine learn xgboost regressor py be how tos since they both just use an exist library for the actual ml algorithm my understanding be that 7106 and 7107 be merge not without difficulty and the author be warn not to contribute s...
thealgorithmspython
ignore missing annotation in init method by algorithm keeper
Enhancement
feature description please provide return type hint for the function init if the function do not return a value please provide the type hint as def function none add none have not sense since this be a special method and it always return none aslo this create noise in code and...
thealgorithmspython
some algorithm be how to example
Help Wanted
in our contribute guideline algorithm in this repo should not be how to example for exist python package instead they should perform internal calculation or manipulation to convert input value into different output value those calculation or manipulation can use data type class or function of exist ...