repository stringclasses 156 values | issue title stringlengths 1 1.01k ⌀ | labels stringclasses 8 values | body stringlengths 1 270k ⌀ |
|---|---|---|---|
facebookfresco | heif image rotation issue | Enhancement | description I have some problem when display heif format image the image rotation be wrong I find some code with the issue the method parsemetadata of encodedimage class when it handle heif imageformat value it jump fetch orientation infomation but the file s fileextension be jpg and the format be heif public void parsemetadata final imageformat imageformat imageformatchecker getimageformat wrapioexception getinputstream mimageformat imageformat bitmaputil decodedimension have a bug where it will return 100x100 for some webps even though those be not its actual dimension final pair dimension if defaultimageformat iswebpformat imageformat dimension readwebpimagesize else dimension readimagesize if imageformat defaultimageformat jpeg mrotationangle unknown rotation angle load the jpeg rotation angle only if we have the dimension if dimension null mexiforientation jfifutil getorientation getinputstream mrotationangle jfifutil getautorotateanglefromorientation mexiforientation else mrotationangle 0 solution additional information fresco version 1 10 0 platform version android 8 0 |
facebookfresco | local thumbnail not work for avi mpg mpeg or wmv thumbnailutil java io ioexception fail to create thumbnail | Help Wanted | description I m try to load some thumbnail from video file but I notice that some video format throw a runtime exception w thumbnailutil java io ioexception fail to create thumbnail at android medium thumbnailutil createvideothumbnail thumbnailutil java 331 at android medium thumbnailutil createvideothumbnail thumbnailutil java 286 at com facebook imagepipeline producers localvideothumbnailproducer 1 getresult localvideothumbnailproducer java 81 at com facebook imagepipeline producers localvideothumbnailproducer 1 getresult localvideothumbnailproducer java 61 at com facebook common executor statefulrunnable run statefulrunnable java 43 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1167 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 641 at com facebook imagepipeline core prioritythreadfactory 1 run prioritythreadfactory java 51 at java lang thread run thread java 919 cause by java lang runtimeexception setdatasource fail status 0x80000000 at android medium mediametadataretriever setdatasource native method at android media mediametadataretriever setdatasource mediametadataretriever java 75 at android medium thumbnailutil createvideothumbnail thumbnailutil java 309 at android medium thumbnailutil createvideothumbnail thumbnailutil java 286 at com facebook imagepipeline producers localvideothumbnailproducer 1 getresult localvideothumbnailproducer java 81 at com facebook imagepipeline producers localvideothumbnailproducer 1 getresult localvideothumbnailproducer java 61 at com facebook common executor statefulrunnable run statefulrunnable java 43 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1167 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 641 at com facebook imagepipeline core prioritythreadfactory 1 run prioritythreadfactory java 51 at java lang thread run thread java 919 so I have to dig deeply to test with different video format and for I avi mpg mpeg and wmv throw this exception every time reproduction load a thumbnail from the follow video file format avi mpg mpeg or wmv additional information fresco version 1 13 0 platform version api q on android studio emulator |
facebookfresco | java lang unsatisfiedlinkerror couldn t find dso to load libgifimage so | Bug | we use github issue for bug description crashlytic report this issue in android version 8 1 0 and 9 in vivo device only after deploy app on play store use app bundle I be use builder experiment setnativecodedisable true while initialise fresco fatal exception java lang unsatisfiedlinkerror couldn t find dso to load libgifimage so at com facebook soloader soloader doloadlibrarybysoname 738 soloader java 738 at com facebook soloader soloader loadlibrarybysoname 591 soloader java 591 at com facebook soloader soloader loadlibrary 529 soloader java 529 at com facebook soloader soloader loadlibrary 484 soloader java 484 at com facebook animate gif gifimage ensure 42 gifimage java 42 at com facebook animate gif gifimage create 70 gifimage java 70 at com facebook animate gif gifimage decode 89 gifimage java 89 at com facebook imagepipeline animate factory animatedimagefactoryimpl decodegif 86 animatedimagefactoryimpl java 86 at com facebook fresco animation factory animatedfactoryv2impl 1 decode 89 animatedfactoryv2impl java 89 at com facebook imagepipeline decoder defaultimagedecoder decodegif 140 defaultimagedecoder java 140 at com facebook imagepipeline decoder defaultimagedecoder 1 decode 60 defaultimagedecoder java 60 at com facebook imagepipeline decoder defaultimagedecoder decode 121 defaultimagedecoder java 121 at com facebook imagepipeline producer decodeproducer progressivedecoder dodecode 281 decodeproducer java 281 at com facebook imagepipeline producer decodeproducer progressivedecoder getintermediateimageendoffset decodeproducer java 1 at com facebook imagepipeline producer decodeproducer progressivedecoder access 200 128 decodeproducer java 128 at com facebook imagepipeline producer decodeproducer progressivedecoder 1 run 170 decodeproducer java 170 at com facebook imagepipeline producers jobscheduler dojob 202 jobscheduler java 202 at com facebook imagepipeline producers jobscheduler access 000 22 jobscheduler java 22 at com facebook imagepipeline producers jobscheduler 1 run 73 jobscheduler java 73 at java util concurrent threadpoolexecutor runworker 1167 threadpoolexecutor java 1167 at java util concurrent threadpoolexecutor worker run 641 threadpoolexecutor java 641 at com facebook imagepipeline core prioritythreadfactory 1 run 51 prioritythreadfactory java 51 at java lang thread run 764 thread java 764 additional information fresco version com facebook fresco fresco 2 0 0 com facebook fresco animate gif 2 0 0 platform version vivo 1807 on android version 8 1 0 vivo 1901 on android version 9 |
facebookfresco | occasionally throw filenotfoundexception by read file after insert to main disk cache concurrently | Bug | for more detail please refer to this repo include a detailed readme and a runnable android app description this be an issue on this situation massively and concurrently fetch image from network and insert they into disk cache immediately and then read the file on the same thread by say massively and concurrently I mean do the work on every 50ms please refer to mainactivity for more detail the issue be that sometimes it throw java io filenotfoundexception on read save file by open a fileinputstream even if the file do exist the file can still be find use android studio s device file explorer can of course be open furthermore if you try to open the file export by content by other app or do a thread sleep before access they it will work reproduction please refer to this repo solution please refer to this repo additional information fresco version 2 0 0 platform version no device or os version specify test on android p q pixel 2 and oneplus 7 pro |
facebookfresco | the right way of initialize fresco not bug | Question | description I call fresco init in baseapplication s oncreate method but my app initialize some necessary thing on main thread synchronously and asynchronously initialize some lib or unnecessary heavy thing on other thread additionally this crash always happen in background seem like user didn t use it so system kill it s main process after that user come back to my app I find initialize fresco need 300ms so I determine to initialize fresco asynchronously but some activity or fragment need use fresco immediately such as simpledraweeview in xml that s lead to I get the exception of simpledraweeview be not initialize at sometimes the rate of user crash be 0 13 question which be the right good way to initialize fresco if I initial fresco in synchronously it ll increase load time of my app can I accept it normally thank you for any answer |
facebookfresco | after change density set scaletype and roundedcornerradius scaletype do not work | Enhancement | hi after change displaymetric density value from 2 to 3 I find that scaletype not work properly this be the simpledraweeview attribute it be before change density the simpledraweeview look like this before change density it be after change density the simpledraweeview look like this after change density it be after change density the simpledraweeview round corner not work properly like this round corner seem like the round corner be not change with density change and the scaletype of fitcenter be also not work properly if remove roundedcornerradius attribute scaletype work properly like this remove roundedcornerradius attribute |
facebookfresco | not load image from url in custom infowindow on google map | Enhancement | description I m use a custom infowindow and cluster its marker on google map and I have to show an image from an url use simpledraweeview when the infowindow appear but it didn t work I ve try class custominfowindow private val context activity googlemap infowindowadapter override fun getinfocontent p0 marker view val minfoview context layoutinflat inflate r layout view custom info window null val datum p0 tag as datum minfoview sdvimage setimageuri data imageurl return minfoview class custominfowindow private val context activity googlemap infowindowadapter override fun getinfocontent p0 marker view val minfoview context layoutinflat inflate r layout view custom info window null val datum p0 tag as datum build control listener for marker image val controllerlistener object basecontrollerlistener fun onfinalimageset i d string nullable imageinfo imageinfo nullable anim animatable if marker isinfowindowshown marker hideinfowindow marker showinfowindow val controller fresco newdraweecontrollerbuilder setcontrollerlistener controllerlistener seturi data imageurl build minfoview sdvimage controller controller return minfoview override fun getinfowindow p0 marker view return null fresco version 2 0 0 platform version android update testing on huawei p30 android 9 emui 9 1 0 huawei mate 20 android 9 and nokia 3 android 8 doesn t work but on moto c plus android 7 work partially because it doesn t do as circle but it show the correct image update 2 when open an infowindow with both code the log be v unknown abstractdraweecontroller controller 2eaab39 null null initialize v unknown abstractdraweecontroller controller 2eaab39 null 69 initialize v unknown abstractdraweecontroller controller 2eaab39 69 sethierarchy com facebook drawee generic genericdraweehierarchy 52c757e anyone |
facebookfresco | java lang unsatisfiedlinkerror couldn t find dso to load libimagepipeline so | Bug | fatal exception java lang unsatisfiedlinkerror couldn t find dso to load libimagepipeline so at com facebook soloader soloader doloadlibrarybysoname 738 soloader java 738 at com facebook soloader soloader loadlibrarybysoname 591 soloader java 591 at com facebook soloader soloader loadlibrary 529 soloader java 529 at com facebook soloader soloader loadlibrary 484 soloader java 484 at com facebook imagepipeline nativecode imagepipelinenativeloader load 40 imagepipelinenativeloader java 40 at com facebook imagepipeline memory nativememorychunk 31 nativememorychunk java 31 at com facebook imagepipeline memory nativememorychunkpool alloc 25 nativememorychunkpool java 25 at com facebook imagepipeline memory nativememorychunkpool alloc 13 nativememorychunkpool java 13 at com facebook imagepipeline memory basepool get 266 basepool java 266 at com facebook imagepipeline memory memorypooledbytebufferoutputstream 51 memorypooledbytebufferoutputstream java 51 at com facebook imagepipeline memory memorypooledbytebufferfactory newbytebuffer 73 memorypooledbytebufferfactory java 73 at com facebook imagepipeline memory memorypooledbytebufferfactory newbytebuffer 24 memorypooledbytebufferfactory java 24 at com facebook imagepipeline producers localfetchproducer getbytebufferbackedencodedimage 85 localfetchproducer java 85 at com facebook imagepipeline producer localfetchproducer getencodedimage 97 localfetchproducer java 97 at com facebook imagepipeline producer localassetfetchproducer getencodedimage 37 localassetfetchproducer java 37 at com facebook imagepipeline producer localfetchproducer 1 getresult 50 localfetchproducer java 50 at com facebook imagepipeline producer localfetchproducer 1 getresult 46 localfetchproducer java 46 at com facebook common executor statefulrunnable run 43 statefulrunnable java 43 description ndk abifilter armeabi v7a abifilter arm64 v8a google play submit need arm64 can t remove it fresco version implementation com facebook fresco fresco 2 0 0 platform version image |
facebookfresco | how can I store the number of frame play by the previous piece of datum during the progressive animate webp download process | Enhancement | description I want to add animate webp progressive loading to fresco so that I can play the animation during the download process but there be a problem that have be bother I for a long time how can I store the number of frame play by the previous piece of datum during the download process each piece of datum will continue to play from the last frame of the previous piece of datum but each piece of datum will generate a separate encodeimage and closeableanimatedimage these datum structure do not have uri field so I can t map the number of frame to the datum source be add uri to these datum structure elegant or be there any other well way |
facebookfresco | round image corner drop its quality | Bug | description set the roundincircle mode on simpledraweeview cause the image to drop in quality dramatically I ve read the article but it doesn t provide the reasoning of why the image get malforme reproduction the image itself be be set as fallowe solution glide library and the android internal method of round drawable bitmapdrawable cornerradius be somehow deal with the issue see the screenshot with example additional information fresco version 1 13 0 platform version android 9 google pixel 3 example |
facebookfresco | on some device image be rotate after resize | Bug | description on some device some image be rotate but it isn t expect reproduction need android v7 1 1 image exif orientation orientation rotate 90 image request with reduce resolution of image in 8 32 time create image request with resize image image resolution need to reduce by resize in 8 32 time result image show without apply orientation from exif rotate solution because of it s android bug I guess and it never change for this android version your team need to implement some walkaround to fix it I look at code and first time when it get wrong width height swap be bitmapfactory decodebytearray byte int int option maybe possible to rotate image correctly after this method call if reproduce condition be meet additional information 1 rotate 2 rotate fresco version 1 13 0 platform version android 7 1 1 htc nexus 9 sony xperia z3 |
facebookfresco | fatal exception java lang unsatisfiedlinkerror | Bug | description I ve see similar issue but the solution didn t work there be lot of unsatisfiedlinkerror issue but I think my problem be not soloader or relinker problem my stacktrace fatal exception java lang unsatisfiedlinkerror com facebook imagepipeline memory nativememorychunk at com facebook imagepipeline memory nativememorychunkpool alloc nativememorychunkpool java 25 at com facebook imagepipeline memory nativememorychunkpool alloc nativememorychunkpool java 13 at com facebook imagepipeline memory basepool get basepool java 267 at com facebook imagepipeline memory memorypooledbytebufferoutputstream memorypooledbytebufferoutputstream java 51 at com facebook imagepipeline memory memorypooledbytebufferfactory newbytebuffer memorypooledbytebufferfactory java 73 at com facebook imagepipeline memory memorypooledbytebufferfactory newbytebuffer memorypooledbytebufferfactory java 24 at com facebook imagepipeline producers localfetchproducer getbytebufferbackedencodedimage localfetchproducer java 85 at com facebook imagepipeline producer localfetchproducer getencodedimage localfetchproducer java 97 at com facebook imagepipeline producers localresourcefetchproducer getencodedimage localresourcefetchproducer java 37 at com facebook imagepipeline producer localfetchproducer 1 getresult localfetchproducer java 50 at com facebook imagepipeline producer localfetchproducer 1 getresult localfetchproducer java 46 at com facebook common executor statefulrunnable run statefulrunnable java 43 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1112 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 587 at com facebook imagepipeline core prioritythreadfactory 1 run prioritythreadfactory java 51 at java lang thread run thread java 818 reproduction no reproduction step because it happen on rare device lenovo htc oppo meizu additional information fresco version 1 13 0 platform version lenovo htc oppo meizu lollipop and marshmallow and I migrate androidx so my targetsdk be 28 |
facebookfresco | feature request explicit color management | Enhancement | description right now imagepipeline allow to specify whether to transform to srgb and there be some apis that use this bit a more future proof approach would be explicitly pass a target color space before api level 26 android only recognize all image as srgb right now it look like old apis just simply pass a false to its new variant to not decode to srgb which mean the encoded color space of the image would likely be the target color space application that use the new version of fresco and run on new os might end up not get what they want if they don t do color management maybe consider only decode image to srgb color space for old apis solution just some thought 1 consider update imagedecodeoption to have a colorspace and use it instead of transformtosrgb 2 update current apis that accept transformtosrgb to accept a colorspace instead 3 update old apis introduce before api level 26 that don t accept transformtosrgb to explicit decode image to srgb |
facebookfresco | fresco use the framework exifinterface instead of the support library | Enhancement | it seem that fresco be still use the framework exifinterface class instead of the androidx support library equivalent androidx exifinterface exifinterface 1 1 0 alpha01 it would be well if migrate to use the support library variant instead as this one have the late bug fix include the new constructor add in api 24 and be backward compatible all the way back to the first android version this way it wouldn t be necessary to have helper class such as heifexifutil or other type of fragmented source |
facebookfresco | svgs scaletype and color filter not work | Enhancement | description I follow this code example to implement svg in my android app along with the help of androidsvg 1 3 I m experience the follow 1 the scaling of image in my draweeview be all mess up the svg be either cut off on the left side or appear in the top left corner I ve try multiple scaletype use gethierarchy setactualimagescaletype 2 depend on the device the svg can either be big or small 3 color filter aren t work for I on the svg gethierarchy setactualimagecolorfilt 4 on api 21 22 svgs don t appear at all this be how I initialize fresco imageformat formatchecker svgformatchecker new frescosvgimageformatchecker imagedecod svgdecoder new frescosvgdecoder imagedecoderconfig svgdecoderconfig new imagedecoderconfig builder adddecodingcapability frescosvgimageformatchecker companion getsvgformat svgformatchecker svgdecoder build imagepipelineconfig config imagepipelineconfig newbuilder this setimagedecoderconfig svgdecoderconfig setdownsampleenable true build drawablefactory svgdrawablefactory new frescosvgdrawablefactory draweeconfig draweeconfig draweeconfig newbuild addcustomdrawablefactory svgdrawablefactory build fresco svg issue 1 fresco svg issue 2 fresco version 1 7 1 platform version happen on every single device |
facebookfresco | unable to load libimagepipeline so | Bug | description get fatal issue on the production version of the application withe the soloader please find the stacktrace below fatal exception java lang noclassdeffounderror com facebook imagepipeline memory nativememorychunk at com facebook imagepipeline memory nativememorychunkpool alloc nativememorychunkpool java 25 at com facebook imagepipeline memory nativememorychunkpool alloc nativememorychunkpool java 13 at com facebook imagepipeline memory basepool get basepool java 267 at com facebook imagepipeline memory memorypooledbytebufferoutputstream memorypooledbytebufferoutputstream java 51 at com facebook imagepipeline memory memorypooledbytebufferfactory newoutputstream memorypooledbytebufferfactory java 106 at com facebook imagepipeline memory memorypooledbytebufferfactory newoutputstream memorypooledbytebufferfactory java 24 at com facebook imagepipeline producer networkfetchproducer onresponse networkfetchproducer java 96 at com facebook imagepipeline producer networkfetchproducer 1 onresponse networkfetchproducer java 73 at com facebook imagepipeline backends okhttp3 okhttpnetworkfetcher 2 onresponse okhttpnetworkfetcher java 193 at okhttp3 realcall asynccall execute realcall java 206 at okhttp3 internal namedrunnable run namedrunnable java 32 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1162 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 636 at java lang thread run thread java 784 cause by java lang unsatisfiedlinkerror couldn t find dso to load libimagepipeline so cause by dlopen fail couldn t map datum data appname lib 0 libimagepipeline so segment 0 permission deny at com facebook soloader soloader doloadlibrarybysoname soloader java 738 at com facebook soloader soloader loadlibrarybysoname soloader java 591 at com facebook soloader soloader loadlibrary soloader java 529 at com facebook soloader soloader loadlibrary soloader java 484 at com facebook imagepipeline nativecode imagepipelinenativeloader load imagepipelinenativeloader java 40 at com facebook imagepipeline memory nativememorychunk nativememorychunk java 31 at com facebook imagepipeline memory nativememorychunkpool alloc nativememorychunkpool java 25 at com facebook imagepipeline memory nativememorychunkpool alloc nativememorychunkpool java 13 at com facebook imagepipeline memory basepool get basepool java 267 at com facebook imagepipeline memory memorypooledbytebufferoutputstream memorypooledbytebufferoutputstream java 51 at com facebook imagepipeline memory memorypooledbytebufferfactory newoutputstream memorypooledbytebufferfactory java 106 at com facebook imagepipeline memory memorypooledbytebufferfactory newoutputstream memorypooledbytebufferfactory java 24 at com facebook imagepipeline producer networkfetchproducer onresponse networkfetchproducer java 96 at com facebook imagepipeline producer networkfetchproducer 1 onresponse networkfetchproducer java 73 at com facebook imagepipeline backends okhttp3 okhttpnetworkfetcher 2 onresponse okhttpnetworkfetcher java 193 at okhttp3 realcall asynccall execute realcall java 206 at okhttp3 internal namedrunnable run namedrunnable java 32 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1162 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 636 at java lang thread run thread java 784 additional information fresco version 1 12 0 platform version android 8 0 htc huwaei |
facebookfresco | renderimagesupportsscale in animateddrawablebackendimpl might be use wrong param | Bug | description as report at renderimagesupportsscale param look suspicious l216 solution need to verify and change to frame width and height or make comment clear if not confirm additional information fresco version 1 11 |
facebookfresco | fatal exception java lang illegalstateexception fail to decode frame | Bug | description stop on this page for about 30 second and the app will crash all device only android 4 4 edit gradle to use fresco dependency v 1 3 0 and it be work 1545819584544 image image reproduction guide translation webp zip additional information fresco version implementation com facebook fresco fresco 1 9 0 implementation com facebook fresco animate webp 1 9 0 implementation com facebook fresco webpsupport 1 9 0 platform version fill this out specific to a particular android version device htc one m8 android 4 4 4 galaxy note 8 0 android 4 4 2 lenovo a6000 android 4 4 4 galaxy s4 android 4 4 2 |
facebookfresco | native crash on android p | Bug | hi we find some native crash on android p with fresco 1 9 0 crash stack show below 00 lr 00411fb4 system lib libhwui so armeabi v7a java android graphic bitmapfactory nativedecodestream native method android graphic bitmapfactory decodestreaminternal bitmapfactory java 961 android graphic bitmapfactory decodestream bitmapfactory java 908 com facebook imagepipeline platform artdecoder com facebook common reference closeablereference decodestaticimagefromstream java io inputstream android graphic bitmapfactory option android graphic rect sourcefile 175 com facebook imagepipeline platform artdecoder com facebook common reference closeablereference decodefromencodedimage com facebook imagepipeline image encodedimage android graphic bitmap config android graphics rect sourcefile 85 com facebook imagepipeline decoder defaultimagedecoder com facebook imagepipeline image closeablestaticbitmap decodestaticimage com facebook imagepipeline image encodedimage com facebook imagepipeline common imagedecodeoption sourcefile 147 com facebook imagepipeline decoder defaultimagedecoder 1 com facebook imagepipeline image closeableimage decode com facebook imagepipeline image encodedimage int com facebook imagepipeline image qualityinfo com facebook imagepipeline common imagedecodeoption sourcefile 64 com facebook imagepipeline decoder defaultimagedecoder com facebook imagepipeline image closeableimage decode com facebook imagepipeline image encodedimage int com facebook imagepipeline image qualityinfo com facebook imagepipeline common imagedecodeoption sourcefile 119 com facebook imagepipeline producer decodeproducer progressivedecoder void dodecode com facebook imagepipeline image encodedimage int sourcefile 254 com facebook imagepipeline producer decodeproducer progressivedecoder access 300 sourcefile 113 com facebook imagepipeline producer decodeproducer progressivedecoder 1 void run com facebook imagepipeline image encodedimage int sourcefile 152 com facebook imagepipeline producers jobscheduler void dojob sourcefile 202 com facebook imagepipeline producers jobscheduler access 000 sourcefile 22 com facebook imagepipeline producers jobscheduler 1 void run sourcefile 73 java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1167 java util concurrent threadpoolexecutor worker run threadpoolexecutor java 641 java lang thread run thread java 784 |
facebookfresco | update bolt dependency to late mit license version | Enhancement | description bolt android be recently update to mit but it be not publish and fresco still depend on bsd patent license version of bolt reproduction this be not a technical issue additional information fresco version any platform version any relate issue |
facebookfresco | draweeview could not play view animation when it be not show | Bug | animation be name slide top out there be a controllor bar at the top of the window which should hide with animation so I write the follow code val anim animationutil loadanimation context r anim slide top out topbar startanimation anim topbar visibility view go when the layout have a simpledraweeview it can not work well which be like this leave image be load by simpledraweeview right be imageview 39nmh b2moe |
facebookfresco | why do image display aliasing of one app on different device | Bug | description an image of 484x504 pixel be layout by 364x379 pixel of simpledraweeview by dynamic calculate on different device and it layout by simpledraweeview getlayoutparam width and simpledraweeview getlayoutparam height when it display on xiaomi note android 6 0 1 and xiaomi mix 2s android 9 0 have different effect they have same screen width 1080 pixel here be the screen shoot xiaomi mix 2s xiaomi note compare image can it show clear |
facebookfresco | android react native incorrect image width and height closeableimage getwidth getheight | Bug | description on react native image getsize use fresco here l71 to return the width and height of a give image as explane in this react native issue the return width and height be inconsistent in android the ratio between width and height be correct but the value of width and height be not reproduction see example in additional information react 16 5 0 16 5 0 react native 0 57 1 0 57 1 fresco version com facebook fresco fresco 1 10 0 platform version android 6 0 1 one plus one android 7 0 huawei mediapad t3 10 |
facebookfresco | fresco not work for get mov file thumb android | Enhancement | public void image loaderforuri uri uri simpledraweeview imageview imagerequ request imagerequestbuilder newbuilderwithsource uri setresizeoption new resizeoption 150 150 build draweecontroller controller fresco newdraweecontrollerbuilder setimagerequ request setoldcontroller imageview getcontroller build imageview setcontroller controller here only for mov file fresco not work in low version device please suggest your thought |
facebookfresco | improve bytearray handle | Help Wanted | newbytearray can fail and return null consider check before use the return value as array l135 |
facebookfresco | when apply roundwithoverlaycolor to gif image the border of the gif image be visible even when there be a view cover it | Bug | description please see screen shoot the blue view be cover the imageview reproduction create a layout like this in activity just load any gif string url uri uri uri parse url simpledraweeview fresco findviewbyid r i d fresco draweecontroller controller fresco newdraweecontrollerbuilder seturi uri setautoplayanimation true build fresco setcontroller controller if you remove fresco roundwithoverlaycolor ffffff it work fine additional information fresco version 1 9 0 platform version only happen to android 7 |
facebookfresco | simpledraweeview not show video thumbnail | Enhancement | hi all I m develop a gallery app for android device I create a private encrypted field for user to hide their medium I use simpledraweeview in the whole project to display the image on the screen I do not do anything extra to view the hide medium in this case the thumbnail of the video be not display when the image be display although both type be the same as the extension imagerequestbuilder can not show video thumbnail my code jvmstatic bindingadapter app newimagepath spancount fun newimagepath imageview simpledraweeview newimagepath string spancount int if newimagepath isnotempty val screenwidthsize imageview context windowmanager defaultdisplay width val spanpixel screenwidthsize spancount val uri uri fromfile file newimagepath val request imagerequestbuilder newbuilderwithsource uri setresizeoption resizeoption spanpixel spanpixel build imageview setimagerequest request else imageview setimagebitmap null whatsapp image 2018 09 12 at 15 25 40 |
facebookfresco | I be test the new feature of android p and find that the footprint of fresco display on android p have be deform | Bug | description I be test the new feature of android p and find that the footprint of fresco display on android p have be deform reproduction solution I hope that you can provide a solution that will make the image appear on android p the same as the previous version additional information fresco version 1 10 0 platform version 28 image image |
facebookfresco | java lang runtimeexception could not initialize soloader | Bug | description when initialize fresco on app start cause by java io filenotfoundexception datum user 0 com remind101 lib main dso lock open fail eacce permission deny at libcore io iobridge open iobridge java 452 at java io fileoutputstream fileoutputstream java 87 at java io fileoutputstream fileoutputstream java 72 at com facebook soloader filelocker filelocker java 28 at com facebook soloader filelocker lock filelocker java 24 at com facebook soloader unpackingsosource prepare unpackingsosource java 393 at com facebook soloader soloader initimpl soloader java 211 at com facebook soloader soloader init soloader java 120 at com facebook soloader soloader init soloader java 104 at com facebook drawee backends pipeline fresco initialize fresco java 63 at com facebook drawee backends pipeline fresco initialize fresco java 46 cause by android system errnoexception open fail eacce permission deny at libcore io posix open posix java at libcore io blockguardo open blockguardo java 186 at libcore io iobridge open iobridge java 438 at java io fileoutputstream fileoutputstream java 87 at java io fileoutputstream fileoutputstream java 72 at com facebook soloader filelocker filelocker java 28 at com facebook soloader filelocker lock filelocker java 24 at com facebook soloader unpackingsosource prepare unpackingsosource java 393 at com facebook soloader soloader initimpl soloader java 211 at com facebook soloader soloader init soloader java 120 at com facebook soloader soloader init soloader java 104 at com facebook drawee backends pipeline fresco initialize fresco java 63 at com facebook drawee backends pipeline fresco initialize fresco java 46 reproduction this be happen in production but we have not be able to reproduce this ourselves with the emulator crashlytic be catch this crash on exactly one device zte grand x max 2 it happen when the application be first open additional information fresco version 1 8 1 platform version zte grand x max 2 api level 23 |
facebookfresco | can not load adaptive icon progressivedecoder unknown image format | Enhancement | description try to load the uri identifier for instal application icon fail for some app system and non system and throw some log d skia skandroidcodec newfromstream return null w unknown progressivedecoder unknown image format uri android resource com sonymobile synchub 2131427328 firstencodedbyte 03000800840100000100 length 388 d skia skandroidcodec newfromstream return null w unknown progressivedecoder unknown image format uri android resource com google android calendar 2130903042 firstencodedbyte 03000800480200000100 length 584 d skia skandroidcodec newfromstream return null w unknown progressivedecoder unknown image format uri android resource com android chrome 2131231050 firstencodedbyte 03000800540100000100 length 340 d skia skandroidcodec newfromstream return null w unknown progressivedecoder unknown image format uri android resource com sonyericsson organizer 2130903043 firstencodedbyte 03000800c80100000100 length 456 d skia skandroidcodec newfromstream return null d skia skandroidcodec newfromstream return null w unknown progressivedecoder unknown image format uri android resource com google android app doc editor doc 2130838355 firstencodedbyte 030008008c0200000100 length 652 d skia skandroidcodec newfromstream return null d skia skandroidcodec newfromstream return null w unknown progressivedecoder unknown image format uri android resource com google android app doc 2130837900 firstencodedbyte 03000800280200000100 length 552 d skia skandroidcodec newfromstream return null d skia skandroidcodec newfromstream return null w unknown progressivedecoder unknown image format uri android resource com sonymobile email 2130903040 firstencodedbyte 03000800280200000100 length 552 d skia skandroidcodec newfromstream return null d skia skandroidcodec newfromstream return null w unknown progressivedecoder unknown image format uri android resource flar2 exkernelmanager 2131558401 firstencodedbyte 03000800f40100000100 length 500 d skia skandroidcodec newfromstream return null d skia skandroidcodec newfromstream return null w unknown progressivedecoder unknown image format uri android resource com google android inputmethod latin 2130903043 firstencodedbyte 03000800280200000100 length 552 d skia skandroidcodec newfromstream return null d skia skandroidcodec newfromstream return null w unknown progressivedecoder unknown image format uri android resource com google android gm 2130903042 firstencodedbyte 03000800280200000100 length 552 d skia skandroidcodec newfromstream return null d skia skandroidcodec newfromstream return null w unknown progressivedecoder unknown image format uri android resource com google android googlequicksearchbox 2130903051 firstencodedbyte 03000800c80100000100 length 456 as see in log it fail for application like chrome browser doc gmail google calendar or even system keyboard reproduction just retrieve applicationinfo to access applicationinfo icon class field then parse the uri for such icon identifier and try to load loader list appinfos mpackagemanager getinstalledapplication 0 list recycler view adapter applicationinfo info appinfos get position if info icon 0 uri uri uri parse android resource packagename info icon holder appiconsimpledraweeview setimageuri uri additional information fresco version 1 10 0 platform version 1 sony xperia x compact android oreo 8 0 0 2 samsung galaxy s8 android oreo 8 0 0 |
facebookfresco | tell fresco to use disk cache for thumbnail of local video | Enhancement | description I m use version 1 10 0 in root application I call fresco initialize getapplicationcontext in other ui control I pass uri fromfile file sdcard example video mp4 to simpledraweeview the view generate in memory thumbnail and display it correctly I check datum datum my app i d cache image cache in emulator no file or directory be in there which mean for local video fresco do not use disk cache additional information fresco version 1 10 0 platform version emulator api 23 may I ask if you could consider add option to tell fresco to use disk cache for local video normally generate thumbnail take time like 1 2 second per video on my real device so disk cache would help a lot thank you p s if someone could tell I how to do this hack then it would also help a lot would it be possible to force fresco to flush the in memory generate thumbnail to disk cache then next time it check for cache it can use the cache file |
facebookfresco | how can I get the callback which mean the image be really in diskcache | Question | I wanner use fresco do something about prefetch it mean without a simpledraweeview target so it seem that pipelinedraweecontrollerbuilder be useless I use basedatasubscriber and its onnewresultimpl but it just stand for memorycache exist and I want to know the file exist in diskcache timely and guarantee therefore I can tell the webview the local file path and so on question two closeablereference imagereference datasource getresult final closeablereference closeablereference imagereference clone I use the above code in order to get the download inputstream for the purpose of not affect fresco cache logic I use clone fortunately it work but I be worried about whether it affect memory look forward to your reply thank |
facebookfresco | fresco do not work after grant permission | Bug | I have a problem when use fresco to show an external uri open app and enter an activity without read storage permission ask for that permission with activitycompat after get the result the permission grant I collect all image from external content uri and get the uris like this content medium external image medium 125 but fresco give error abstractdraweecontroller controller e65ea68 1 final fail onfailure failure java io filenotfoundexception storage emulate 0 dcim camera img 20180717 182941 jpg permission deny force close app and open again now app have permission the image I collect display normally fresco version 1 9 0 on gradle platform version android target 28 emulator selectimageactivity kt zip package com zody import android manifest import android content contenturis import android content pm packagemanag import android os bundle import android provider mediastore import androidx appcompat app appcompatactivity import androidx core app activitycompat import androidx core content contextcompat import com facebook common log flog import com facebook drawee backend pipeline fresco import com facebook drawee view simpledraweeview import timber log timber create by vinhnguyen it vn on 2018 july 19 class selectimageactivity appcompatactivity private val imageview simpledraweeview by lazy simpledraweeview this override fun oncreate savedinstancestate bundle super oncreate savedinstancestate fresco initialize this applicationcontext flog setminimumlogginglevel flog verbose setcontentview imageview if contextcompat checkselfpermission this manif permission read external storage packagemanag permission grant activitycompat requestpermission this arrayof manifest permission read external storage 1 else queryimageandshow override fun onrequestpermissionsresult requestcode int permission array grantresult intarray super onrequestpermissionsresult requestcode permission grantresult if requestcode 1 grantresult 0 packagemanag permission grant queryimageandshow private fun queryimageandshow val what arrayof mediastore image medium i d val cursor mediastore image medium query contentresolver mediastore image medium external content uri what null null null if cursor movetofirst val i d cursor getlong cursor getcolumnindex mediastore image medium i d val uri contenturis withappendedid mediastore image medium external content uri i d timber tag fresco d the uri we get be uri imageview setimageuri uri null cursor close there be the logcat fresco the uri we get be content medium external image medium 103 unknown abstractdraweecontroller controller 68ea53f 0 final fail onfailure failure java io filenotfoundexception storage emulate 0 dcim camera img 20180717 115110 jpg permission deny note permission not grant when launch force close app and launch again now the app have permission it work normally |
facebookfresco | wide color gamut support for postprocessor | Enhancement | description I want to load facebook logo image with fresco but when I be set post processor image not show look to source code tell that fresco can not handle 16 bit png image but this only happen when use post processor reproduction simpledraweeview image findviewbyid r i d your simple drawee view string url imagerequ imagerequ imagerequestbuilder newbuilderwithsource uri parse url setpostprocessor new roundascirclepostprocessor build pipelinedraweecontroller controller pipelinedraweecontroller fresco newdraweecontrollerbuilder setimagerequest imagerequ setoldcontroller image getcontroller build image setcontroller controller additional information fresco version 1 9 0 platform version android 8 0 one plus 5 t |
facebookfresco | graphic memory leak | Bug | description graphic memory leak occur on my device here be my code the code above be item view of recycleview which load datum page by page when I scroll to end to load next page then graphic memory leak occur when not use round corner leak would not happen I can fix it by set activity android hardwareaccelerate false but list scroll less smoothly 20180425172052 additional information fresco version any platform version lemobile le x820 android 6 0 1 api 23 |
facebookfresco | request same url several time | Enhancement | I encounter a problem when the image be download I close the activity then reopen it the image will download twice also in recyclerview when I scroll the list up and down quickly some image will download several time this be a demo for this bug this be issue be the same as but can t reopen that issue so open a new one initialization kotlin class demoapp application override fun oncreate super oncreate fresco initialize this set image url kotlin class secondactivity activity override fun oncreate savedinstancestate bundle super oncreate savedinstancestate setcontentview r layout activity second val draweeview simpledraweeview findviewbyid r i d image view draweeview setimageuri constant url request in charles image |
facebookfresco | round corner circular rounding not work for gif animate webps | Enhancement | description hi there be gif image at first item in recycler view but roundascircle be not work only gif image url be there any solution or can I get sample code about this issue thank kakaotalk photo 2018 04 03 16 00 49 44 additional information fresco version 1 8 1 platform version nexus 6p 8 1 0 |
facebookfresco | create simpledraweespanedittext like simpledraweespantextview draweespanstringbuilder add delete clear support | Enhancement | please create simpledraweespanedittext look like simpledraweespantextview add draweespanstringbuilder support for delete clear |
facebookfresco | add fresco source into a react native map project to debug it | Help Wanted | description image component of react native can be use in react native map project when add custom marker however it can not render custom marker on android api 25 and later it mean that marker image component be render on android 7 0 and connot be render on android 7 1 I realize that onerror onload and onloadend event be never fire on android 7 1 although they be fire on android 7 0 the event be emit in com facebook drawee controller class to track these clue I need to add fresco source on a react native map project and to build it however I get stick at this step when try to build from source it throw the follow exception failure build fail with an exception what go wrong a problem occur configure project reactandroid fail to notify project evaluation listener could not resolve all dependency for configuration reactandroid debugpublish configuration with name default not find could not resolve all dependency for configuration reactandroid compile configuration with name default not find I wonder that be there any chance to overcome this issue original react native map issue be over here also a question have be open on stackoverflow day ago I m really not good at gradle reproduction 1 download fresco 1 3 0 repo into the root directory of the project 2 add fresco into a react native map project by follow step modifiye setting gradle file include fresco project fresco projectdir new file rootproject projectdir fresco add fresco project into dependency section of the project s build gradle file compile project fresco modify react native reactandroid build gradle file also try to add sub project of fresco directly as be in sample l70 l72 dependency compile com facebook fresco fresco 1 3 0 compile com facebook fresco imagepipeline okhttp3 1 3 0 compile project fresco the line below show how sub project be be add directly but I could not manage include drawee project drawee projectdir new file rootproject projectdir fresco drawee include fbcore project fbcore projectdir new file rootproject projectdir fresco fbcore include imagepipeline project imagepipeline projectdir new file rootproject projectdir fresco imagepipeline include imagepipeline base project imagepipeline base projectdir new file rootproject projectdir fresco imagepipeline base include imagepipeline okhttp3 project imagepipeline okhttp3 projectdir new file rootproject projectdir fresco imagepipeline backends imagepipeline okhttp3 3 build the project by use the command of react native run android failure build fail with an exception what go wrong a problem occur configure project reactandroid fail to notify project evaluation listener could not resolve all dependency for configuration reactandroid debugpublish configuration with name default not find could not resolve all dependency for configuration reactandroid compile configuration with name default not find solution optional do you know what need to be do to address this issue ideally provide a pull request which fix this issue additional information fresco version 1 3 0 fresco 1 3 0 gradle version 2 3 0 the project gradle plugin version 2 2 3 platform version android 7 1 on samsung j5 6 and android emulator |
facebookfresco | fatal exception java lang unsatisfiedlinkerror couldn t find dso to load libimagepipeline so com facebook imagepipeline memory nativememorychunk | Bug | description update to version 1 8 0 crashlytic report these issue fatal exception java lang unsatisfiedlinkerror couldn t find dso to load libimagepipeline so at com facebook soloader soloader doloadlibrarybysoname soloader java 522 at com facebook soloader soloader loadlibrarybysoname soloader java 420 at com facebook soloader soloader loadlibrary soloader java 370 at com facebook soloader soloader loadlibrary soloader java 335 at com facebook imagepipeline nativecode imagepipelinenativeloader load imagepipelinenativeloader java 42 at com facebook imagepipeline memory nativememorychunk nativememorychunk java 33 at com facebook imagepipeline memory nativememorychunkpool alloc nativememorychunkpool java 58 at com facebook imagepipeline memory nativememorychunkpool alloc nativememorychunkpool java 20 at com facebook imagepipeline memory basepool get basepool java 257 at com facebook imagepipeline memory nativepooledbytebufferoutputstream nativepooledbytebufferoutputstream java 51 at com facebook imagepipeline memory nativepooledbytebufferfactory newbytebuffer nativepooledbytebufferfactory java 98 at com facebook imagepipeline memory nativepooledbytebufferfactory newbytebuffer nativepooledbytebufferfactory java 26 at com facebook imagepipeline producers localfetchproducer getbytebufferbackedencodedimage localfetchproducer java 89 at com facebook imagepipeline producer localfetchproducer getencodedimage localfetchproducer java 101 at com facebook imagepipeline producers localresourcefetchproducer getencodedimage localresourcefetchproducer java 39 at com facebook imagepipeline producer localfetchproducer 1 getresult localfetchproducer java 54 at com facebook imagepipeline producer localfetchproducer 1 getresult localfetchproducer java 50 at com facebook common executor statefulrunnable run statefulrunnable java 45 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1115 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 590 at com facebook imagepipeline core prioritythreadfactory 1 run prioritythreadfactory java 53 at java lang thread run thread java 818 fatal exception java lang unsatisfiedlinkerror com facebook imagepipeline memory nativememorychunk at com facebook imagepipeline memory nativememorychunkpool alloc nativememorychunkpool java 58 at com facebook imagepipeline memory nativememorychunkpool alloc nativememorychunkpool java 20 at com facebook imagepipeline memory basepool get basepool java 257 at com facebook imagepipeline memory nativepooledbytebufferoutputstream nativepooledbytebufferoutputstream java 51 at com facebook imagepipeline memory nativepooledbytebufferfactory newbytebuffer nativepooledbytebufferfactory java 98 at com facebook imagepipeline memory nativepooledbytebufferfactory newbytebuffer nativepooledbytebufferfactory java 26 at com facebook imagepipeline producers localfetchproducer getbytebufferbackedencodedimage localfetchproducer java 89 at com facebook imagepipeline producer localfetchproducer getencodedimage localfetchproducer java 101 at com facebook imagepipeline producers localresourcefetchproducer getencodedimage localresourcefetchproducer java 39 at com facebook imagepipeline producer localfetchproducer 1 getresult localfetchproducer java 54 at com facebook imagepipeline producer localfetchproducer 1 getresult localfetchproducer java 50 at com facebook common executor statefulrunnable run statefulrunnable java 45 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1112 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 587 at com facebook imagepipeline core prioritythreadfactory 1 run prioritythreadfactory java 53 at java lang thread run thread java 818 reproduction solution I want to know if update to 1 8 1 can fix these issue or I need add compile com facebook soloader soloader 0 1 0 to build gradle additional information fresco version compile com facebook fresco fresco 1 8 0 compile com facebook fresco animate gif 1 8 10 platform version oppo os android 5 1 1 device r7sfg r7 g a51fa |
facebookfresco | tool attribute do not work with fresco it become hard to use in xml editor | Enhancement | e g tool src or any other to mock the view of an image be there a work around additional information fresco version 1 8 0 |
facebookfresco | retainingdatasourcesupplier ignore fadeduration | Enhancement | description we ve use the retainingdatasourcesupplier for replace blurred thumb image with good quality image when a user click a download button we ve set the fadeduration of draweehierarchy to 300 ms the first blur thumb show up with a fade animation but the second image show up immediately without any animation we ve also try to replace image set the lowre and highre image when user click on download button but we ve get the same result the second image show up without any animation be there any solution for replace image with animation reproduction solution additional information fresco version 1 7 1 platform version android 7 0 |
facebookfresco | http error response when load image result in leak connection | Bug | description I notice a bunch of log line like this throughout logcat as I use my app 19098 19147 w okhttpclient a connection to be leak do you forget to close a response body I eventually narrow it down to a single simpledraweeview that be cause it when I try to set its image uri use imagepipeline okhttp3 I add an okhttp client and interceptor so I could inspect what be go on with the http request response it turn out that the response be not 200 rather a 401 error this prevent the image from loading as expect and also lead to the above log line I be able to fix this particular 401 error by use an interceptor to add the necessary authentication header I be miss however I be wonder if there be different http error in the future be there a general way to catch error in such a way that it doesn t leak a connection reproduction set an image uri on a simpledraweeview that result in a 401 http error code response additional information fresco version 1 5 0 imagepipeline okhttp3 version 1 5 0 |
facebookfresco | set file uri in simpledraweeview when use context mode private | Enhancement | description bug with add simpledraweeview object use setimageuri when uri fromfile and save file use openfileoutput filename context mode private context mode private make the file inaccessible to other app but for fresco be problem to read and set file in simpledraweeview simpledraweeview work only with uri when fileoutputstream object outputstream new fileoutputstream file additional information compile com facebook fresco fresco 1 5 0 compilesdkversion 25 |
facebookfresco | downscale resizing not support for animate gif webps | Bug | gif and jpg be in recyclerview I want to do fitxy but gif be small git cap recyclerview item layout xml recyclerview adapter java override public void onbindviewholder gallaryadapter viewholder holder int position final characterdata datum characterdata get position if datum gettype characterdata type gif holder imageview setcontroller fresco newdraweecontrollerbuilder seturi data geturi setautoplayanimation true build else holder imageview setimageuri data geturi thank you for your help |
facebookfresco | image flash upon loading | Enhancement | description upon load an image gif jpg webp png the image flash the background color then load the image I expect that the image would just load and only have a placeholder when the image take a while to load this problem be irrelevant to the size of the image img size 10 kb even if the image load immediately the background color flash reproduction essentially just load an image and replace it with another image on the same scene I have a git project with the issue where it flash red ezgif com video to gif additional information fresco version 1 5 0 platform version nexus 6 api 25 but have be try on numerous android device |
facebookfresco | for infinitely animate webp the animationlistener be not correct | Bug | we use github issue for bug if you have a non bug question please ask on stack overflow please use this template and delete everything above this line before submit your issue description I use a infinitely animate webp with fresco I add a listener to check when it repeat I find that onanimationstart and onanimationrepeat be bean call more than once in the beginning like log below 10 20 16 41 15 916 25214 25214 xx e webp onanimationstart 10 20 16 41 15 932 25214 25214 xx e webp onanimationrepeat 10 20 16 41 15 934 25214 25214 xx e webp onanimationframe 0 10 20 16 41 15 966 25214 25214 xx e webp onanimationrepeat 10 20 16 41 15 967 25214 25214 xx e webp onanimationframe 0 10 20 16 41 15 980 25214 25214 xx e webp onanimationrepeat 10 20 16 41 15 983 25214 25214 xx e webp onanimationframe 0 10 20 16 41 15 993 25214 25214 xx e webp onanimationrepeat 10 20 16 41 15 995 25214 25214 xx e webp onanimationframe 0 10 20 16 41 16 010 25214 25214 xx e webp onanimationframe 1 10 20 16 41 16 030 25214 25214 xx e webp onanimationframe 1 10 20 16 41 16 043 25214 25214 xx e webp onanimationframe 1 10 20 16 41 16 059 25214 25214 xx e webp onanimationframe 1 10 20 16 41 16 080 25214 25214 xx e webp onanimationframe 1 10 20 16 41 16 111 25214 25214 xx e webp onanimationframe 2 10 20 16 41 16 129 25214 25214 xx e webp onanimationframe 2 10 20 16 41 16 149 25214 25214 xx e webp onanimationframe 2 10 20 16 41 16 181 25214 25214 xx e webp onanimationframe 3 10 20 16 41 16 206 25214 25214 xx e webp onanimationframe 3 10 20 16 41 16 212 25214 25214 xx e webp onanimationframe 3 10 20 16 41 16 230 25214 25214 xx e webp onanimationframe 3 reproduction use a infinitely animate webp in fresco and add a animationlistener solution additional information fresco version 1 5 0 platform version all android device code draweecontroller webpcontroller fresco newdraweecontrollerbuilder seturi animatedwebpuri setoldcontroller image getcontroller setcontrollerlistener new basecontrollerlistener override public void onfinalimageset string i d imageinfo imageinfo animatable anim if anim null anim instanceof animateddrawable2 animateddrawable2 anim setanimationlistener new animatedwebplisten override public void onanimationstart animateddrawable2 drawable slog e webp onanimationstart override public void onanimationstop animateddrawable2 drawable slog e webp onanimationstop override public void onanimationreset animateddrawable2 drawable slog e webp onanimationreset override public void onanimationrepeat animateddrawable2 drawable slog e webp onanimationrepeat override public void onanimationframe animateddrawable2 drawable int framenumber slog e webp onanimationframe framenumber anim start build log 10 20 16 41 15 916 25214 25214 xx e webp onanimationstart 10 20 16 41 15 932 25214 25214 xx e webp onanimationrepeat 10 20 16 41 15 934 25214 25214 xx e webp onanimationframe 0 10 20 16 41 15 966 25214 25214 xx e webp onanimationrepeat 10 20 16 41 15 967 25214 25214 xx e webp onanimationframe 0 10 20 16 41 15 980 25214 25214 xx e webp onanimationrepeat 10 20 16 41 15 983 25214 25214 xx e webp onanimationframe 0 10 20 16 41 15 993 25214 25214 xx e webp onanimationrepeat 10 20 16 41 15 995 25214 25214 xx e webp onanimationframe 0 10 20 16 41 16 010 25214 25214 xx e webp onanimationframe 1 10 20 16 41 16 030 25214 25214 xx e webp onanimationframe 1 10 20 16 41 16 043 25214 25214 xx e webp onanimationframe 1 10 20 16 41 16 059 25214 25214 xx e webp onanimationframe 1 10 20 16 41 16 080 25214 25214 xx e webp onanimationframe 1 10 20 16 41 16 111 25214 25214 xx e webp onanimationframe 2 10 20 16 41 16 129 25214 25214 xx e webp onanimationframe 2 10 20 16 41 16 149 25214 25214 xx e webp onanimationframe 2 10 20 16 41 16 181 25214 25214 xx e webp onanimationframe 3 10 20 16 41 16 206 25214 25214 xx e webp onanimationframe 3 10 20 16 41 16 212 25214 25214 xx e webp onanimationframe 3 10 20 16 41 16 230 25214 25214 xx e webp onanimationframe 3 10 20 16 41 16 264 25214 25214 xx e webp onanimationframe 4 10 20 16 41 16 335 25214 25214 xx e webp onanimationframe 5 10 20 16 41 16 415 25214 25214 xx e webp onanimationframe 6 10 20 16 41 16 500 25214 25214 xx e webp onanimationframe 7 10 20 16 41 16 583 25214 25214 xx e webp onanimationframe 8 10 20 16 41 16 669 25214 25214 xx e webp onanimationframe 9 10 20 16 41 16 753 25214 25214 xx e webp onanimationframe 10 10 20 16 41 16 838 25214 25214 xx e webp onanimationframe 11 10 20 16 41 16 923 25214 25214 xx e webp onanimationframe 12 10 20 16 41 17 006 25214 25214 xx e webp onanimationframe 13 10 20 16 41 17 090 25214 25214 xx e webp onanimationframe 14 10 20 16 41 17 175 25214 25214 xx e webp onanimationframe 15 10 20 16 41 17 251 25214 25214 xx e webp onanimationframe 16 10 20 16 41 17 329 25214 25214 xx e webp onanimationframe 17 10 20 16 41 17 421 25214 25214 xx e webp onanimationframe 18 10 20 16 41 17 498 25214 25214 xx e webp onanimationframe 19 10 20 16 41 17 587 25214 25214 xx e webp onanimationframe 20 10 20 16 41 17 671 25214 25214 xx e webp onanimationframe 21 10 20 16 41 17 750 25214 25214 xx e webp onanimationframe 22 10 20 16 41 17 840 25214 25214 xx e webp onanimationframe 23 10 20 16 41 17 920 25214 25214 xx e webp onanimationframe 24 10 20 16 41 18 012 25214 25214 xx e webp onanimationframe 25 10 20 16 41 18 090 25214 25214 xx e webp onanimationframe 26 10 20 16 41 18 158 25214 25214 xx e webp onanimationframe 26 10 20 16 41 18 244 25214 25214 xx e webp onanimationframe 28 10 20 16 41 18 327 25214 25214 xx e webp onanimationframe 29 10 20 16 41 18 422 25214 25214 xx e webp onanimationframe 30 10 20 16 41 18 496 25214 25214 xx e webp onanimationframe 31 10 20 16 41 18 581 25214 25214 xx e webp onanimationframe 32 10 20 16 41 18 668 25214 25214 xx e webp onanimationframe 33 10 20 16 41 18 749 25214 25214 xx e webp onanimationframe 34 10 20 16 41 18 835 25214 25214 xx e webp onanimationframe 35 10 20 16 41 18 923 25214 25214 xx e webp onanimationframe 36 10 20 16 41 18 988 25214 25214 xx e webp onanimationframe 37 10 20 16 41 19 074 25214 25214 xx e webp onanimationframe 37 10 20 16 41 19 158 25214 25214 xx e webp onanimationframe 39 10 20 16 41 19 239 25214 25214 xx e webp onanimationframe 40 10 20 16 41 19 327 25214 25214 xx e webp onanimationframe 41 10 20 16 41 19 417 25214 25214 xx e webp onanimationframe 42 10 20 16 41 19 499 25214 25214 xx e webp onanimationframe 43 10 20 16 41 19 579 25214 25214 xx e webp onanimationframe 44 10 20 16 41 19 666 25214 25214 xx e webp onanimationframe 45 10 20 16 41 19 749 25214 25214 xx e webp onanimationframe 46 10 20 16 41 19 836 25214 25214 xx e webp onanimationframe 47 10 20 16 41 19 917 25214 25214 xx e webp onanimationframe 48 10 20 16 41 19 994 25214 25214 xx e webp onanimationframe 49 10 20 16 41 20 068 25214 25214 xx e webp onanimationframe 50 10 20 16 41 20 152 25214 25214 xx e webp onanimationframe 51 10 20 16 41 20 238 25214 25214 xx e webp onanimationframe 52 10 20 16 41 20 324 25214 25214 xx e webp onanimationframe 53 10 20 16 41 20 407 25214 25214 xx e webp onanimationframe 54 10 20 16 41 20 490 25214 25214 xx e webp onanimationframe 55 10 20 16 41 20 577 25214 25214 xx e webp onanimationframe 56 10 20 16 41 20 660 25214 25214 xx e webp onanimationframe 57 10 20 16 41 20 754 25214 25214 xx e webp onanimationframe 58 10 20 16 41 20 836 25214 25214 xx e webp onanimationframe 59 10 20 16 41 20 899 25214 25214 xx e webp onanimationframe 60 10 20 16 41 20 981 25214 25214 xx e webp onanimationframe 61 10 20 16 41 21 066 25214 25214 xx e webp onanimationframe 62 10 20 16 41 21 162 25214 25214 xx e webp onanimationframe 63 10 20 16 41 21 240 25214 25214 xx e webp onanimationframe 64 10 20 16 41 21 327 25214 25214 xx e webp onanimationframe 65 10 20 16 41 21 407 25214 25214 xx e webp onanimationframe 66 10 20 16 41 21 488 25214 25214 xx e webp onanimationframe 67 10 20 16 41 21 579 25214 25214 xx e webp onanimationframe 68 10 20 16 41 21 657 25214 25214 xx e webp onanimationframe 69 10 20 16 41 21 742 25214 25214 xx e webp onanimationframe 70 10 20 16 41 21 812 25214 25214 xx e webp onanimationframe 71 10 20 16 41 21 894 25214 25214 xx e webp onanimationframe 72 10 20 16 41 21 979 25214 25214 xx e webp onanimationframe 73 10 20 16 41 22 063 25214 25214 xx e webp onanimationframe 74 10 20 16 41 22 147 25214 25214 xx e webp onanimationframe 75 10 20 16 41 22 232 25214 25214 xx e webp onanimationframe 76 10 20 16 41 22 325 25214 25214 xx e webp onanimationframe 77 10 20 16 41 22 411 25214 25214 xx e webp onanimationframe 78 10 20 16 41 22 493 25214 25214 xx e webp onanimationframe 79 10 20 16 41 22 558 25214 25214 xx e webp onanimationframe 80 10 20 16 41 22 650 25214 25214 xx e webp onanimationframe 81 10 20 16 41 22 722 25214 25214 xx e webp onanimationframe 81 10 20 16 41 22 817 25214 25214 xx e webp onanimationframe 83 10 20 16 41 22 891 25214 25214 xx e webp onanimationframe 84 10 20 16 41 22 974 25214 25214 xx e webp onanimationrepeat 10 20 16 41 22 977 25214 25214 xx e webp onanimationframe 0 10 20 16 41 23 069 25214 25214 xx e webp onanimationframe 1 10 20 16 41 23 152 25214 25214 xx e webp onanimationframe 2 10 20 16 41 23 234 25214 25214 xx e webp onanimationframe 3 10 20 16 41 23 323 25214 25214 xx e webp onanimationframe 4 10 20 16 41 23 390 25214 25214 xx e webp onanimationframe 5 10 20 16 41 23 491 25214 25214 xx e webp onanimationframe 6 10 20 16 41 23 568 25214 25214 xx e webp onanimationframe 7 10 20 16 41 23 638 25214 25214 xx e webp onanimationframe 7 10 20 16 41 23 722 25214 25214 xx e webp onanimationframe 9 10 20 16 41 23 804 25214 25214 xx e webp onanimationframe 10 10 20 16 41 23 897 25214 25214 xx e webp onanimationframe 11 10 20 16 41 23 979 25214 25214 xx e webp onanimationframe 12 10 20 16 41 24 057 25214 25214 xx e webp onanimationframe 13 10 20 16 41 24 143 25214 25214 xx e webp onanimationframe 14 10 20 16 41 24 227 25214 25214 xx e webp onanimationframe 15 10 20 16 41 24 318 25214 25214 xx e webp onanimationframe 16 |
facebookfresco | gif animation be very slow and crash with oom in 1 5 0 | Bug | we use github issue for bug if you have a non bug question please ask on stack overflow please use this template and delete everything above this line before submit your issue description fill this out explain what you do what you expect to happen and what actually happen we have a photo shop create gif file and it always crash in our app run on old device reproduction fill this out how can we reproduce the bug provide url to relevant image if possible or a sample project run on android device 5 0 who get upgrade from old version solution optional do you know what need to be do to address this issue ideally provide a pull request which fix this issue I think the gc in those device be very different I have no idea how fresco internally do it additional information fresco version fill this out 1 5 0 platform version fill this out specific to a particular android version device any upgrade android device to 22 or 24 |
facebookfresco | bad performance on swap buffer for gif image | Enhancement | we analyze the profile gpu rendering but the performance so bad when play gif image after upgrade fresco version form 1 3 0 to 1 5 0 especial use in recyclerview under be the gpu perform when play gif image in recyclerview there be about 8 gif on the screen as we all know the good performance be cost less than 16ms for each frame render but it cost more than 32ms when play gif image it be more than double of the standard so I hope it could be optimize for batter performance |
facebookfresco | overlay drawable alpha value not respect | Bug | description report via stackoverflow if you set an overlay drawable the alpha value will always be set to 255 no matter what the actual alpha value be reproduction drawable drawable drawable setalpha 50 draweeview gethierarchy setoverlayimage drawable the alpha value of the drawable will be 255 instead of 50 solution the reason for this be that a fadedrawable hold all drawable of the drawee hierarchy and fade between they as need but do not respect initial alpha value additional information fresco version 1 5 0 platform version all platform |
facebookfresco | unsupported marker type 0x4f throw when transcodejpeg | Bug | description I catch an exception when decode a large jpeg image take with samsung galaxy s8 here be the exception java lang runtimeexception unsupported marker type 0x4f at com facebook imagepipeline nativecode jpegtranscoder nativetranscodejpeg native method at com facebook imagepipeline nativecode jpegtranscoder transcodejpeg jpegtranscoder java 66 at com facebook imagepipeline producers resizeandrotateproducer transformingconsumer dotransform resizeandrotateproducer java 198 at com facebook imagepipeline producers resizeandrotateproducer transformingconsumer access 000 resizeandrotateproducer java 85 at com facebook imagepipeline producer resizeandrotateproducer transformingconsumer 1 run resizeandrotateproducer java 102 at com facebook imagepipeline producers jobscheduler dojob jobscheduler java 207 at com facebook imagepipeline producers jobscheduler access 000 jobscheduler java 27 at com facebook imagepipeline producers jobscheduler 1 run jobscheduler java 78 reproduction 1 download the photo file click to download 67 2 mb 2 enable setdownsampleenable true if not work fine 3 show image with simpledrawee java imagerequ imagerequ imagerequestbuilder newbuilderwithsource uri parse imguri setresizeoption new resizeoption 200 200 setrotationoption rotationoption autorotate build img setcontroller fresco newdraweecontrollerbuilder setimagerequest imagerequ setoldcontroller img getcontroller build additional information fresco version 1 4 0 platform version android 7 0 samsung galaxy s8 |
facebookfresco | sigsegv crash on android 4 4 | Bug | description we ve start receive native sigsegv crash after scroll through image for a couple of minute on android 4 4 app be crash we can not identify what cause it but use glide in the same way work fine we don t want to move our whole app to glide so we want to figure out what be the problem here reproduction we could steadily reproduce it on android 4 4 4 additional information fresco version 1 5 0 platform version android 4 4 4 |
facebookfresco | color space in android o be not handle properly by some feature | Enhancement | description o be the first android release that introduce a proper color management system into the os and platform framework this addition doesn t require any change for simple decoding and display of bitmap but some of fresco s more advanced feature seem to drop colorspace information I go through the fresco showcase sample app modify as describe below and find bad color reproduction in these part of the app drawee rotation image pipeline post processor image pipeline resize thing that I ve not test yet progressive jpeg gif webps svg image from data uris reproduction check out 3194ad2 add whack jpg and whack png to res drawable nodpi in the showcase module I create these file from this image by use the match to profile feature of the macos colorsync utility app with the popular whackedrgb icc c4 and intent set to automatic replace jpg url with re r drawable whack jpg and png url with re r drawable whack png in imageuriprovider play around with the sample additional information fresco version 3194ad2 platform version android o rev 5 of the emulator image |
facebookfresco | animate picture problem after version 1 4 0 | Bug | when those animate picture play in the screen the scrollable ui lag and memory jitter seriously this dose not happen on version 1 3 0 but after version 1 4 0 image fresco version 1 4 0 and 1 5 0 platform version all android device |
facebookfresco | how can I deal with the fail to decode frame exception | Enhancement | I see the abnormal information display be decode frame problem but I don t know which frame have the problem and what be the problem such as picture be invalid picture format info wrong or other question about the frame if my app have this problem how can I solve it and then avoid this problem fatal exception java lang illegalstateexception fail to decode frame at com facebook animate webp webpframe nativerenderframe sourcefile at com facebook animate webp webpframe renderframe sourcefile 50 at com facebook imagepipeline animate impl animateddrawablebackendimpl renderimagesupportsscale sourcefile 203 at com facebook imagepipeline animate impl animateddrawablebackendimpl renderframe sourcefile 177 at com facebook imagepipeline animate impl animatedimagecompositor renderframe sourcefile 120 at com facebook fresco animation bitmap wrapper animateddrawablebackendframerenderer renderframe sourcefile 74 at com facebook fresco animation bitmap preparation defaultbitmapframepreparer framedecoderunnable renderframeandcache sourcefile 175 at com facebook fresco animation bitmap preparation defaultbitmapframepreparer framedecoderunnable prepareframeandcache sourcefile 154 at com facebook fresco animation bitmap preparation defaultbitmapframepreparer framedecoderunnable prepareframeandcache sourcefile 162 at com facebook fresco animation bitmap preparation defaultbitmapframepreparer framedecoderunnable run sourcefile 112 at com facebook common executor constrainedexecutorservice worker run sourcefile 177 at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1113 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 588 at com facebook imagepipeline core prioritythreadfactory 1 run sourcefile 42 at java lang thread run thread java 818 fresco version 1 5 0 |
facebookfresco | jpeg datastream contain no image | Bug | description the first time I try to load a picture onfailure method be call and I have an exception like jpeg datastream contain no image I reproduce this issue only with android n the second time I try to load the same picture it actually work additional information galaxy s6 android 7 0 fresco 1 3 0 |
facebookfresco | vector drawable do not work as placeholder image on api 17 and probably below api 21 | Enhancement | description I have a simpledraweeview and a vector drawable xml I try to use the said xml as a placeholder in the drawee but on api 17 so probably below api 21 could not inflate the view and crash the app appcompatdelegate setcompatvectorfromresourcesenable true setcompatvectorfromresourcesenable boolean do not seem to be a viable option as this feature default to disabled since enable it can cause issue with memory usage and problem update configuration instance reproduction define the layout xml for the drawee xml where drawable ic image white 24dp be ic image white 24dp xml xml note that the simpledraweeview have an app imageuri attribute this be here because the datum bind would not work otherwise the implementation be pretty simple it be not relevant to the bug though java bindingadapter imageuri public static void loadimage simpledraweeview view uri imageurl view setimageuri imageurl the layout get inflate by databindingutil from a recyclerview adapter locate in a support fragment that be attach to the parent appcompatactivity the gradle file contain the necessary line for support vector drawable on low api level gradle android defaultconfig vectordrawable usesupportlibrary true additional information fresco version 1 3 0 platform version api 17 htc one x support lib version 25 3 1 |
facebookfresco | use bitmap preparetodraw to upload bitmap to gpu in advance | Enhancement | description hey I work on ui toolkit graphic in android want to pass on an optimization you can enable for display bitmap android display bitmap as opengl texture and the first time a bitmap be display in a frame it s upload to the gpu that can take several millisecond but it s necessary to display the image with the gpu in android n we add behavior to bitmap preparetodraw to send an async message to renderthread to pre upload renderthread upload these to the gpu when it expect to be idle between frame instead of while draw the first frame that use the bitmap if you can do this after decode you can make it much less likely that frame be drop due to upload reproduction in systrace you can see the problem when any bitmap be display by look for section label upload x texture if those be happen in drawframe on the renderthread inside syncframestate they haven t be pre upload and be on the critical path for the frame solution call bitmap preparetodraw as early as possible when you think a bitmap will be display soon the most aggressive way to do this be any time you decode an image especially any immutable image the drawback be that if you call it on a bitmap before you modify it or if it doesn t get draw you ll be waste the time spend upload if you re reasonably sure the bitmap in question will be display it s still a great way to prefetch the upload work on renderthread additional information behavior add in android n for reference glide implement this here it s safe to call on old version so you don t need a version check the method exist prior to n but be a noop for normal bitmap |
facebookfresco | preload gif store locally into memory and retain it | Enhancement | I want to preload gif store in raw folder into memory and retain it so that whenever I be show gif I don t have to again load it as gif load with some delay I be show gif in loading progress so it will be good if I already have the instance of previously load gif and it load fast next time |
facebookfresco | progressive jpeg in not load when use a post processor with request | Enhancement | not able to process progressive image with post process its not setting on imageview at all be there any solution to do the same I really want to replicate this io library with fresco as fresco be the only way to load progressive jpeg in android for now |
facebookfresco | fresco not use gingerbreadpurgeabledecoder without static webp library | Enhancement | I ve find out that fresco be not use gingerbreadpurgeabledecoder on pre kitkat device without static webp library and webpsupportenabled experimental flag enable there be another flag decodememoryfileenable remove in this commit which allow to use this decoder with android default bitmapfactory why it be remove and do it make sense to use gingerbreadpurgeabledecoder with android bitmapfactory on pre kitkat device |
facebookfresco | should support vectordrawable resource i d | Enhancement | tag need support v21 and appcompat already support v9 and up api level |
facebookfresco | share element go after do sharedelementreturntransition in android n | Bug | I use the new fresco code for do sharedelement transition work it run well in android l m but on android n it go wrong before transition screenshot0 after transition screenshot0 |
facebookfresco | crash a jni crash recycle bitmap on android 4 4 4 rarely | Bug | a jni crash recycle bitmap which allocate on ashmem by pinbitmap it be just find on android 4 4 4 rarely crash on android 4 4 4 jni crash log as follow signal 11 sigsegv code 1 segv maperr fault addr 00000013 r0 ffffffff r1 88d6f788 r2 ffffffff r3 00007020 r4 88d69270 r5 7c8d9450 r6 401839dc r7 7e0976f8 r8 84b95af0 r9 7e0976f0 10 00000000 fp 84b95b04 ip 890f60fc sp 84b95a18 lr 890f60fc pc 401315fc cpsr a0000010 00 pc 000155fc system lib libc so dlfree 01 pc 000ce798 system lib libskia so zn6skdatad0ev 02 pc 00118fd8 system lib libskia so zn14skmemorystreamd0ev 03 pc 00174b7c system lib libskia so zn10skimagerefd2ev 04 pc 001754fc system lib libskia so zn17skimageref ashmemd2ev 05 pc 00175528 system lib libskia so zn17skimageref ashmemd0ev 06 pc 000aa094 system lib libskia so zn8skbitmap10freepixelsev 07 pc 000aa328 system lib libskia so zn8skbitmap11setpixelrefep10skpixelrefj 08 pc 000aa3e4 system lib libskia so zn8skbitmap9setpixelsepvp12skcolortable 09 pc 0002cf2c system lib libhwui so zn7android10uirenderer13resourcecache13recyclelockedep8skbitmap 10 pc 0002cf6e system lib libhwui so zn7android10uirenderer13resourcecache7recycleep8skbitmap 11 pc 0001ee8c system lib libdvm so dvmplatforminvoke 12 pc 000503b6 system lib libdvm so z16dvmcalljnimethodpkjp6jvaluepk6methodp6thread 13 pc 00028268 system lib libdvm so 14 pc 0002f738 system lib libdvm so z11dvmmterpstdp6thread 15 pc 0002cda8 system lib libdvm so z12dvminterpretp6threadpk6methodp6jvalue 16 pc 000643d8 system lib libdvm so z14dvmcallmethodvp6threadpk6methodp6objectbp6jvaluest9 va list 17 pc 000643fc system lib libdvm so z13dvmcallmethodp6threadpk6methodp6objectp6jvaluez 18 pc 00058878 system lib libdvm so 19 pc 0000d8b8 system lib libc so thread entry java backtrace at android graphic bitmap nativerecycle at android graphic bitmap recycle at com facebook imagepipeline memory bitmapcounter 1 release at com facebook common reference sharedreference deletereference at com facebook common reference closeablereference close at com facebook imagepipeline image closeablestaticbitmap close at com facebook common internal closeable close at com facebook common reference closeablereference 1 release at com facebook common reference sharedreference deletereference at com facebook common reference closeablereference close at com facebook common reference closeablereference closesafely at com facebook imagepipeline cache countingmemorycache maybeclose at com facebook imagepipeline cache countingmemorycache maybeevictentrie at com facebook imagepipeline cache countingmemorycache cache |
facebookfresco | bug set ture to webpsupportenabled and mdecodememoryfileenable | Bug | set ture to mwebpsupportenabled and mdecodememoryfileenable com facebook imagepipeline core imagepipelineconfig run the follow refrence function com facebook imagepipeline platform gingerbreadpurgeabledecoder decodefiledescriptoraspurgeable two fail situation 1 seriously that cause app and system anr or crash on android 4 1 2 2 decode fail on android 2 3 logcat print skia skimagedecoder factory return null |
facebookfresco | setdownsampleenable true then resize don t work for webp with at least android api 17 | Bug | hello test fresco with setdownsampleenable true on one api 17 device I don t have the downsample fresco log requestlogginglistener with another device that be api 10 file be well downsample I could see the requestlogginglistener line the api 10 device with same fresco setting downsample and resize to same size be fast about x2 to x4 to decode picture that the api 17 one api 10 requestlogginglistener time 210302582 onproducerfinishwithsuccess requestid 11 producer decodeproducer elapsedtime 273 ms extramap bitmapsize 1600x1067 queuetime 0 imagetype default isfinal true hasgoodquality true api 17 requestlogginglistener time 89545018 onproducerfinishwithsuccess requestid 52 producer decodeproducer elapsedtime 928 ms extramap bitmapsize 1600x1067 queuetime 2 imagetype default isfinal true hasgoodquality true on api 10 I can find the downsample log line downsampleutil downsample specify size 2048x2048 image size 1600x1067 ratio 1 3 x 1 9 ratio 1 919 for thus I can t in api 17 I have read this and see downsample be experimental but which android version be support and which be not this have be test with fresco 0 10 0 0 11 0 all test picture be prefetch to disk and store there before to be display greating eric |
facebookfresco | resume download from point which it be interrupt | Enhancement | idea in place with unstable internet connection with bad internet there may be a useful feature to be able to download medium just from the same position where it be previously interrupt it be support by http from at least v1 1 by range header but now default fetcher will throw any datum it have download if error occur solution put artificially download datum in some cache possible file cache to be able to resume download for this purpose to save flexibility I propose to use special fetcher which will have it s internal cache and if cache be hit will firstly give byte from cache only after that from internet while download medium from internet it byte will be append just at the end of file in cache I have already write some code in my fork just prototype with test app poorly cover with test and non absolutely reliably so it will be improve problem as I be not a very skillful programmer so I can not answer some question which I face during this job 1 what be necessary and sufficient condition to say that destination host support offset by range header in byte and have accept request with range header response code 206 2 what be necessary and sufficient condition to say that file we be download be the same as we download previous from same uri there be a lot of different header in http and I be little bit get confuse by they 3 in contribute md mention about unit test what be the amount and quality of the test you demand p s it will be brilliant if anybody from community or from facebook team will give I some advise upd here be the link to actual cross repository compare |
facebookfresco | tap on retry logic doesn t work if cache image be break | Bug | here be the step I reproduce the issue 1 load an image with simpledraweeview e g 2 find out the cache file by this url accord to this 3 I pull out the cache file manually make it corrupt push it back to the phone 4 now it will show the retry icon when the image be load however when I tap on it see the log v unknown abstractdraweecontroller controller 52a0b440 44 final fail onfailure failure java lang illegalargumentexception unknown image format be this retry logic expect accord to design what I be expect be that it will try to clear the wrong cache and download it again from network |
facebookfresco | placeholderimage don t display in androidstudio preview if have round attribute | Bug | my code |
facebookfresco | bug when set failureimage and roundedcornerradius not zero value at the same time | Bug | description when set failureimage and roundedcornerradius not zero value at the same time the failure image display abnormal see image below reproduction device xiaomi 11 resolution 3200 1400 but 2400 1400 be ok fresco version 2 3 0 2 6 0 but 0 13 0 be ok platform version android 11 miui 12 5 just copy simple code below to your application and with such condition you can see the bug stable recurrence moreover set or change failureimagescaletype be totally useless fresco 2 6 0 2 3 0 image fresco 0 13 0 image my failure image my failure image |
facebookfresco | migrate off jcenter | Enhancement | jcenter will be sunset on may 1 2020 announcement |
facebookfresco | inherit from shapeableimageview | Question | description currently it be not possible to custom shape our simpledraweeview com google android material imageview shapeableimageview would offer a solution for this it would also fix all the issue with roundascircle and would offer even more customization |
facebookfresco | load large resolution picture | Question | hello we use this library in our development as an image loading dependency but in use if the image resolution be particularly high for example 5990 4180 at this time there be multiple imageview and the system refresh rate drop sharply it will be very stuck be there any solution fresco version 2 3 0 platform version summi m2 android version 7 1 2 |
facebookfresco | adapter android 10 | Duplicate | android 10 open the album and the video cover be blank |
facebookfresco | placeholderimage not in center on google pixel xl | Duplicate | description xml 20200928 093458 the gif show two image switch visibile to gone and you can see the placeholderimage of the image be not in center reproduction I find it only show on google pixel xl it not reproduce on oneplus 6 t solution additional information fresco version 2 3 0 platform version device google pixel xl android version 10 |
facebookfresco | round corner distort image | Duplicate | description inside my android application I have a recyclerview that include several simpledraweeview feed with url from an api the actualimagescaletype be set to centerinside and there be a background color set to fit the design I use rounded corner too unfortunately this break all image in place where the background would be visible also happen if roundedcornerradius be set to 1dp see follow image image image I hope that be not the intend behavior in this case reproduction a sample project can be find here additional information fresco version 2 3 0 platform version test on pixel 2 api 30 emulator and xiaomi mi 10 api 30 device |
facebookfresco | okhttp transport alternative | Enhancement | after late kotlin upgrade okhttp 3 12 12 for ktor not an option any more I switch my api21 build to ktor cio but still can t cut okhttp dep because of fresco be there an option or potential roadmap to have transport plugin to be able change okhttp to something else I d like to switch to ktor cio |
facebookfresco | webp | Bug | xml simpview findviewbyid r i d simpview draweecontroller controller fresco newdraweecontrollerbuilder seturi path setautoplayanimation true setoldcontroller simpview getcontroller build simpview setcontroller controller |
facebookfresco | loss the ninepatchchunk info in bitmap | Enhancement | I download a picture that contain nine patch info by imagepipeline but I get a bitmap without nine path info the code be val url val imagepipeline fresco getimagepipeline val imagerequ imagerequ imagerequ fromuri url val datasource imagepipeline fetchdecodedimage imagerequ context datasource subscribe object basebitmapdatasubscriber override fun onfailureimpl datasource datasource override fun onnewresultimpl bmptemp bitmap var chunk bmptemp ninepatchchunk this chunk null uithreadimmediateexecutorservice getinstance I download this picture by a normal thread bitmap ninepatchchunk be not null |
facebookfresco | flutter support | Enhancement | this be a feature request to support flutter currently in flutter we be use blurhash to show a blurred image placeholder while the full image be be load in the background but there s a problem that the blurred image be static and win t change during the update of the original image like in instagram I m wonder if you can make a package to use in flutter thank |
facebookfresco | com caverock xxe injection | Bug | description xml external entity xxe injection vulnerable module com caverock androidsvg introduce through com caverock exploit maturity no know exploit fix in 1 3 0 detailed path and remediation introduce through com caverock reproduction solution remediation upgrade to com caverock additional information fresco version late platform version android overview com caverock androidsvg be a svg parser and renderer for android affect version of this package be vulnerable to xml external entity xxe injection via the svg parse component |
facebookfresco | fbcore s proguard limit be too broad | Enhancement | description the proguard configuration in fbcore 2 1 0 aar include a line that keep all class with a native method which be not good as we can t choose to shrink other class with native method any more keep native method keepclassmember class native reproduction any demo app implement fresco should be able to reproduce solution change the proguard rule to be something like the follow keep native method keepclassmember class com facebook native additional information fresco version 2 1 0 platform version android |
facebookfresco | issue with add apng support | Enhancement | apng image be always recognize as png I be try to add a custom decoder for apng but run into an interesting issue because the header start with the same sequence in apng as png fresco always recognize this as a png in defaultimagedecoder decode you can see fresco first check for a default image format match before check the custom decoder for a match because of this an apng will always get see as a png even if all the format checker and drawable factory be setup properly can you think of a way around this issue simply get fresco to check custom image format first fresco version 2 0 0 platform version all android version |
facebookfresco | libpng v1 6 35 cve 2019 7317 | Bug | png image free in png c in libpng 1 6 x before 1 6 37 have a use after free because png image free function be call under png safe execute |
facebookfresco | upgrade giflib to 5 1 8 | Enhancement | it look like fresco be use an old version of giflib which may make it vulnerable to cve 2019 15133 be fresco vulnerable to this should it be upgrade to use 5 1 8 |
facebookfresco | fix fresco 2 1 java only version | Bug | I want to use java only version in my project we can find some instruction on version 2 1 0 release note I hava add java fresco gradle setup implementation com facebook fresco fresco 2 1 0 exclude group com facebook soloader module soloader exclude group com facebook fresco module soloader exclude group com facebook fresco module nativeimagefilter exclude group com facebook fresco module nativeimagetranscoder exclude group com facebook fresco module memory type native exclude group com facebook fresco module imagepipeline native and change freco init code imagepipelineconfig builder builder createfrescoconfig builder experiment setnativecodedisable true fresco initialize getapplicationcontext builder build null false but we still get some problem fresco still try load so file so which be the right way to use java only version can we get some wiki about this can we exclude so file when use java only version |
facebookfresco | unrelease resource stream | Enhancement | l142 the program can potentially fail to release a system resource |
facebookfresco | when version more than 1 9 0 simpledraweeview use roundascircle placeholderimage display small | Bug | in xml when use fresco version 1 9 0 display right 291575360267 pic but when use version more than 1 9 0 like 1 10 0 or 2 0 0 271575360148 pic file be in drawable directory ic boleto detail icon I try the method of but feel it s not a good solution because the 1 9 0 be display right 1 9 0 2 0 0 display different in one mobile phone because 1 9 0 find some crash in google play I want to update library version but have display problem may you solve my question thx for your help |
facebookfresco | showcase crash for api 21 | Bug | description showcase be crash for api 21 reproduction open placeholder progress failure tab solution additional information platform version api 21 |
facebookfresco | animate gif package break downloadable gif with round | Question | description I m use com facebook fresco fresco and com facebook fresco animate gif for show animate gif I load a gif image non animate from the internet and apply roundingparam I expect to see round image but I get square gif from app resource work fine I need animate gif package for animation but how to disable it for non animate gif reproduction if enable animate gif package then roundingparam will break but animation will work fine solution disable animate gif package resolve problem but all animate gif break additional information fresco version 2 0 0 animate gif 2 0 0 platform version any device |
facebookfresco | do fresco have a way of synchronize download to return bitmap | Question | do fresco have a way of synchronize download to return bitmap |
facebookfresco | low image quality use component on rn 0 57 fresco 1 10 0 | Enhancement | description rn issue rn 0 57 x bundle large image have low quality when view use component with 1 1 ar on android close there be low quality when load large bundle png gif and maybe more format not jpeg image only on android at the left screenshot we see the exact same code run with rn 0 56 0 and at the right screenshot we see rn 0 57 1 the code be just a simple image and the image size be 2111 x 4645 pixel both project be fresh installed use react native init rn057imagetest and react native init version 0 56 0 rn056imaget this continue to happen from 0 56 and all version after and late rn 0 60 x this be confirm to be cause by rn fresco lib change between 0 56 and 0 57 from 1 9 0 to 1 10 0 check comment issuecomment 520155609 after some search at fresco issue I can see some relate issue that it s suggest that large image should be divide and recompose piece by piece which it resolve many case most map relate large image but it can be very inconvenient especially for dynamic load create image this be work until rn 0 56 and from 0 57 and after it do not reproduction rn it s the initial app js with an component add type prop export default class app extend component render return additional information at this comment issuecomment 520418832 lambdapioneer write that this maybe be relate to scale down sub sample large image I assume it s relate to how fresco scale down sub sample large image which be an important feature for memory and performance concern there have be some change in these area during that time mainly for remove native code dependency to help reduce the also press so unsatisfied link error so to say it might be a side effect of another large improvement fresco version 1 10 0 platform version rn 0 57 all android version |
facebookfresco | class cast exception | Question | exception java lang classcastexception o mw can not be cast to o nw at com app example share shareutil 2 onnewresultimpl 243 shareutil java 243 at com facebook datasource basedatasubscriber onnewresult 46 basedatasubscriber java 46 at com facebook datasource abstractdatasource 1 run 176 abstractdatasource java 176 at android os handler handlecallback 873 handler java 873 at android os handler dispatchmessage 99 handler java 99 at android os looper loop 193 looper java 193 at android app activitythread main 6863 activitythread java 6863 at java lang reflect method invoke method java at com android internal os runtimeinit methodandargscaller run 537 runtimeinit java 537 at com android internal os zygoteinit main 858 zygoteinit java 858 code snipe datasubscriber datasubscriber new basedatasubscriber override protect void onnewresultimpl com facebook datasource datasource datasource if datasource isfinishe return closeablereference imagereference null closeablereference closeablereference null try imagereference datasource getresult if imagereference null closeablereference imagereference clone closeablebitmap closeablebitmap closeablereference get catch exception e logutil reportnonfatalexception tag e not able to cast closeablereference to closeablebitmap additional information fresco version 2 0 0 device hmd global nokia 5 oneplus a6010 |
facebookfresco | how to region decode a huge image | Question | description in my app it sometimes happen an oom crash when decode a huge image I want to region decode the image just when the image be big enough and the format be png jpeg and reponse to touch event to change the region after read the source I do not find a way to achieve this what should I do oom stack java lang outofmemoryerror fail to allocate a 529212 byte allocation with 175512 free byte and 171 kb until oom at dalvik system vmruntime newnonmovablearray native method at android graphic bitmap nativecreate native method at android graphic bitmap createbitmap bitmap java 812 at android graphic bitmap createbitmap bitmap java 789 at android graphic bitmap createbitmap bitmap java 756 at com facebook imagepipeline memory bitmappool alloc at com facebook imagepipeline memory bitmappool alloc at com facebook imagepipeline memory basepool retryonce at com facebook imagepipeline memory basepool retryonce at com facebook imagepipeline memory basepool get at com facebook imagepipeline platform artdecoder decodestaticimagefromstream at com facebook imagepipeline platform artdecoder decodejpegfromencodedimage at com facebook imagepipeline decoder defaultimagedecoder decodejpeg at com facebook imagepipeline decoder defaultimagedecoder 1 decode at com facebook imagepipeline decoder defaultimagedecoder decode at com facebook imagepipeline producer decodeproducer progressivedecoder dodecode at com facebook imagepipeline producer decodeproducer progressivedecoder access 200 access 400 at com facebook imagepipeline producer decodeproducer progressivedecoder 1 run at com facebook imagepipeline producers jobscheduler dojob at com facebook imagepipeline producers jobscheduler access 000 at com facebook imagepipeline producers jobscheduler 1 run at java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1112 at java util concurrent threadpoolexecutor worker run threadpoolexecutor java 587 at com facebook imagepipeline core prioritythreadfactory 1 run searchbox 51 at java lang thread run thread java 818 |
facebookfresco | android q open fail eacce permission deny | Bug | description run in android q beta 5 and use the uri from mediastore but the image will not show reproduction load image path from mediastore and use the path to generate uri then put it into the imagerequ solution resolver openfiledescriptor item mode maybe use this will help additional information fresco version last platform version android q beta 5 |
facebookfresco | fresco | Duplicate | displaymetric density 2 3 fresco simpledraweeview simpledraweeview displaymetric density |
facebookfresco | java lang thread parkfor thread java 2163 | Bug | description this be an online bug that can not be reproduce my stacktrace java java lang thread parkfor thread java 2163 sun misc unsafe park unsafe java 358 java util concurrent lock locksupport park locksupport java 190 java util concurrent lock abstractqueuedsynchronizer conditionobject await abstractqueuedsynchronizer java 2059 java util concurrent linkedblockingqueue take linkedblockingqueue java 442 java util concurrent threadpoolexecutor gettask threadpoolexecutor java 1092 java util concurrent threadpoolexecutor runworker threadpoolexecutor java 1152 java util concurrent threadpoolexecutor worker run threadpoolexecutor java 641 com facebook imagepipeline core prioritythreadfactory 1 run prioritythreadfactory java 51 java lang thread run thread java 784 additional information fresco version 1 13 0 platform version android 9 level 28 |
facebookfresco | fast thumbnail | Question | to get a thumbnail you need to decode the full picture and then scale it to thumbnail size to overcome this obstacle the jpeg format allow you to get a picture 1 2 1 4 1 8 or even 1 16 in size of the original picture e g for a factor 1 8 a 5000x5000 picture will be return as a 625x625 picture java do not offer this functionality c lib like ijg do for jpeg thumbnail you just need the dc component and skip all the ac component this mean you only have to decrypt the dc component you still have to do the full huffman decompression but still it save a hell lot of time disk I o memory and exception pure but clever java especially multi thread java often beat native performance wise this lack of fast thumbnail support shape the type of app you could write with java over the last 20 year fast thumbnail be essential please implement |
facebookfresco | loading image with custom progress will report an error don t know how to round that drawable | Enhancement | load image with custom progress genericdraweehierarchy build genericdraweehierarchybuilder newinstance mcontext getresource setfadeduration 1000 setprogressbarimage new imageloadingdrawable build iv sethierarchy build iv setimageuri item getfile path this be my custom progress load public class imageloadingdrawable extend drawable private paint mringbackgroundpaint private int mringbackgroundcolor private paint mringpaint private int mringcolor private float mradius private float mringradius private float mstrokewidth private int mxcenter private int mycenter private int mtotalprogress 10000 private int mprogress public imageloadingdrawable initattrs private void initattrs mradius 64 mstrokewidth 16 mringbackgroundcolor 0xffadadad mringcolor 0xff0eb6d2 mringradius mradius mstrokewidth 2 initvariable private void initvariable mringbackgroundpaint new paint mringbackgroundpaint setantialia true mringbackgroundpaint setcolor mringbackgroundcolor mringbackgroundpaint setstyle paint style stroke mringbackgroundpaint setstrokewidth mstrokewidth mringpaint new paint mringpaint setantialia true mringpaint setcolor mringcolor mringpaint setstyle paint style stroke mringpaint setstrokewidth mstrokewidth override public void draw canvas canvas drawbar canvas mtotalprogress mringbackgroundpaint drawbar canvas mprogress mringpaint private void drawbar canvas canvas int level paint paint if level 0 rect bind getbound mxcenter bind centerx mycenter bind centery rectf oval new rectf oval leave mxcenter mringradius oval top mycenter mringradius oval right mringradius 2 mxcenter mringradius oval bottom mringradius 2 mycenter mringradius canvas drawarc oval 90 float level mtotalprogress 360 false paint override protect boolean onlevelchange int level mprogress level if level 0 level 10000 invalidateself return true else return false override public void setalpha int alpha mringpaint setalpha alpha override public void setcolorfilter colorfilter cf mringpaint setcolorfilter cf override public int getopacity return drawableutil getopacityfromcolor this mringpaint getcolor |
facebookfresco | the result of nativeblurfilter iterativeboxblur be differenet from iterativeboxblurfilter boxblurbitmapinplace | Enhancement | description I think nativeblurfilter be just a c rewrite of iterativeboxblurfilter so I expect these two method return same result but this be not true reproduction bitmap bit2 bitmap createbitmap 9 1 bitmap config argb 8888 bit2 setpixel 4 0 0xffffffff nativeblurfilter iterativeboxblur bit2 1 2 stringbuilder sb new stringbuilder native for int I 0 I 9 I sb append string format x bit2 getpixel I 0 sb append bit2 setpixel I 0 0 log d bluredgepostprocessor sb tostre bit2 bitmap createbitmap 9 1 bitmap config argb 8888 bit2 setpixel 4 0 0xffffffff iterativeboxblurfilter boxblurbitmapinplace bit2 1 2 sb new stringbuilder java for int I 0 I 9 I sb append string format x bit2 getpixel I 0 sb append bit2 setpixel I 0 0 log d bluredgepostprocessor sb tostre execute above code the output be as follow native 0 0 33ffffff 33ffffff 33ffffff 33ffffff 33ffffff 0 0 java 0 0 33323232 33323232 33323232 33323232 33323232 0 0 be the result of nativeblurfilter incorrect additional information fresco version 2 0 0 also try 1 14 2 and 1 11 0 still the same platform version android 9 avd |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.