repo stringlengths 7 67 | org stringlengths 2 32 ⌀ | issue_id int64 780k 941M | issue_number int64 1 134k | pull_request dict | events list | text_size int64 0 279k | bot_issue bool 1 class | modified_by_bot bool 2 classes | user_count int64 1 77 | event_count int64 1 191 | modified_usernames bool 2 classes |
|---|---|---|---|---|---|---|---|---|---|---|---|
saltstack/salt | saltstack | 106,198,842 | 27,091 | {
"number": 27091,
"repo": "salt",
"user_login": "saltstack"
} | [
{
"action": "opened",
"author": "perfinion",
"comment_id": null,
"datetime": 1442119712000,
"masked_author": "username_0",
"text": "The pre-flight checks try to change to $HOME, this can fail for multiple\r\nreasons. One such case is that /root is a protected dir under SELinux\r\nwhich the master should not have access to. The daemon should instead\r\nchange to the root dir which is the only dir that is always guaranteed\r\nto be there. The limited testing I have managed to do shows that windows\r\naccepts the '/' path too just fine so the os-specific case is not\r\nrequired either.\r\n\r\nChanging to $HOME was added in https://github.com/saltstack/salt/pull/21279\r\n\r\nGentoo-Bug: https://bugs.gentoo.org/560300",
"title": "salt/master: chdir to root not homedir",
"type": "issue"
},
{
"action": "created",
"author": "cachedout",
"comment_id": 140141235,
"datetime": 1442249192000,
"masked_author": "username_1",
"text": "I'm willing to merge this for now, but it needs extensive testing across all platforms so I'd like to let it run the full test suite across additional distros and see how things go. Thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cachedout",
"comment_id": 140141389,
"datetime": 1442249236000,
"masked_author": "username_1",
"text": "@twangboy Now that this is merged, please verify that your Windows installs still operate correctly. Thanks.",
"title": null,
"type": "comment"
}
] | 867 | false | false | 2 | 3 | false |
js-cookie/js-cookie | js-cookie | 110,191,968 | 98 | null | [
{
"action": "opened",
"author": "garmgrey",
"comment_id": null,
"datetime": 1444212613000,
"masked_author": "username_0",
"text": "Hello. \r\nI have some issue with dublicating cookie entries.\r\nSome time, when i call \r\n```javascript\r\nCookies.set('my-cookie-name', 'value', {'path': '/'});\r\n```\r\n\r\nI am sure that I call this method only one place in my code, but in result I have:\r\n\r\n```\r\n---------------------------------------------------------------\r\n Name Value Domain Path\r\n---------------------------------------------------------------\r\n my-cookie-name 1 mydomain.com /foo/bar/\r\n my-cookie-name value mydomain.com /\r\n---------------------------------------------------------------\r\n```\r\n\r\nThis does not happen every time.",
"title": "Duplicated cookie entries",
"type": "issue"
},
{
"action": "created",
"author": "FagnerMartinsBrack",
"comment_id": 146189737,
"datetime": 1444222865000,
"masked_author": "username_1",
"text": "Even though you call it once, the user could already have a cookie locally. Changing the code does not delete a cookie that was persisted earlier.\r\n\r\nAnother theory is that you might be passing an Object Literal reference in the `attributes` argument, then another code change the Object and the cookie is created with another `Path`.\r\n\r\nAnyway, it's pretty hard to figure out the problem without a reduced test case.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gcollombet",
"comment_id": 146209274,
"datetime": 1444227740000,
"masked_author": "username_2",
"text": "I have the same problem. I call \r\n Cookies.set('my-cookie-name', 'value');\r\nfrom a single location but it create me two cookie with same name one with / and one with my page requested uri.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "garmgrey",
"comment_id": 146219603,
"datetime": 1444229645000,
"masked_author": "username_0",
"text": "@username_2 That is why I use the attribute {path: '/'}. But this does not solve the problem.\r\n\r\n@username_1 Cookie with name ```'my-cookie-name'``` sets in only one place of code.\r\nThis issue i catch on my dev machine, so it can't be a old (or wrong) cookie.\r\nBut i use it for toggle some state. i mean like this:\r\n```javascript\r\nvar state = 'on';\r\n$elem.on('click', function(e){\r\n state = state === 'on' ? 'off' : 'on';\r\n Cookies.set('my-cookie-name', state, {path: '/'});\r\n});\r\n```\r\n\r\nMay be it's wrong usage? And i need to remove old cookie before set new value?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FagnerMartinsBrack",
"comment_id": 146220149,
"datetime": 1444229765000,
"masked_author": "username_1",
"text": "@username_0 \r\nIf you remove the cookie before setting the value it works?\r\nWhat is the output of `Cookies.set()` operation in all calls? Can you put a `console.log` there?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "garmgrey",
"comment_id": 146222865,
"datetime": 1444230225000,
"masked_author": "username_0",
"text": "@username_1 This problem occurs rarely, so it is difficult to catch. At this moment i remove cookie before set new value and do not catch the problem again. But i think it is wrong usage of ```js-cookie``` lib.\r\n\r\nDo you mean this?\r\n```javascript\r\nconsole.log(Cookies.set('my-cookie-name', state, {path: '/'}));\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gcollombet",
"comment_id": 146285138,
"datetime": 1444242343000,
"masked_author": "username_2",
"text": "Ok sorry, in my case it was a the server part that add the wrong cookie\n(I'll do a setcookie in php... ).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FagnerMartinsBrack",
"comment_id": 146371158,
"datetime": 1444262564000,
"masked_author": "username_1",
"text": "If you have any questions regarding js-cookie usage you can use the [`js-cookie`](http://stackoverflow.com/questions/tagged/js-cookie) tag on stackoverflow. The benefit of asking there is that it has better PageRank for Google and therefore has a greater chance to help somebody else in the future ;)\r\n\r\nIf you ask on StackOverflow please link here to increase awareness.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "garmgrey",
"comment_id": 146463565,
"datetime": 1444294829000,
"masked_author": "username_0",
"text": "@username_1 @username_2 \r\nThank you. I will write here when I find an answer...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "garmgrey",
"comment_id": 146471893,
"datetime": 1444296773000,
"masked_author": "username_0",
"text": "@username_1 [Question on StackOverflow](http://stackoverflow.com/questions/33011827/excess-record-in-cookies)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FagnerMartinsBrack",
"comment_id": 146716083,
"datetime": 1444347342000,
"masked_author": "username_1",
"text": "I will close this for now since it doesn't seems to be any `js-cookie` internal problem.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "FagnerMartinsBrack",
"comment_id": null,
"datetime": 1444347342000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3,116 | false | false | 3 | 12 | true |
raoulvdberge/refinedstorage | null | 164,568,092 | 173 | {
"number": 173,
"repo": "refinedstorage",
"user_login": "raoulvdberge"
} | [
{
"action": "opened",
"author": "GustoniaEagle",
"comment_id": null,
"datetime": 1467995471000,
"masked_author": "username_0",
"text": "",
"title": "New textures + model",
"type": "issue"
},
{
"action": "created",
"author": "raoulvdberge",
"comment_id": 231407772,
"datetime": 1467995608000,
"masked_author": "username_1",
"text": "o m g",
"title": null,
"type": "comment"
}
] | 5 | false | false | 2 | 2 | false |
eslint/eslint | eslint | 178,217,385 | 7,198 | {
"number": 7198,
"repo": "eslint",
"user_login": "eslint"
} | [
{
"action": "opened",
"author": "not-an-aardvark",
"comment_id": null,
"datetime": 1474418876000,
"masked_author": "username_0",
"text": "**What is the purpose of this pull request? (put an \"X\" next to item)**\r\n\r\n[ ] Documentation update\r\n[ ] Bug fix ([template](https://github.com/eslint/eslint/blob/master/templates/bug-report.md))\r\n[ ] New rule ([template](https://github.com/eslint/eslint/blob/master/templates/rule-proposal.md))\r\n[ ] Changes an existing rule ([template](https://github.com/eslint/eslint/blob/master/templates/rule-change-proposal.md))\r\n[x] Add autofixing to a rule\r\n[ ] Add a CLI option\r\n[ ] Add something to the core\r\n[ ] Other, please explain:\r\n\r\n<!--\r\n If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.)\r\n-->\r\n\r\n\r\n<!--\r\n The following is required for all pull requests:\r\n-->\r\n\r\n**Please check each item to ensure your pull request is ready:**\r\n\r\n- [x] I've read the [pull request guide](http://eslint.org/docs/developer-guide/contributing/pull-requests)\r\n- [x] I've included tests for my change\r\n- [x] I've updated documentation for my change (if appropriate)\r\n\r\n**What changes did you make? (Give an overview)**\r\n\r\nThis adds a fixer for `strict`. The fixer removes unnecessary `'use strict';` directives. Other errors reported by the `strict` rule are not fixed, to avoid breaking any working code.\r\n\r\nSee also: #6668, #6856\r\n\r\n**Is there anything you'd like reviewers to focus on?**\r\n\r\nNothing in particular.",
"title": "Update: add fixer for `strict` (fixes #6668)",
"type": "issue"
}
] | 1,460 | false | true | 1 | 1 | false |
Blacklight-Design/generator-symfony-alchemy | Blacklight-Design | 95,106,284 | 1 | null | [
{
"action": "opened",
"author": "geevcookie",
"comment_id": null,
"datetime": 1436936208000,
"masked_author": "username_0",
"text": "As an alternative to the classic JS concatenation and uglifying, Browserify will be an optional extra.\r\n\r\nThings to look at:\r\n- Will Browserify replace existing JS tasks if selected during prompt phase or will it simply provide a new task to work along with the existing JS tasks.\r\n- Should Bower be configured if Browserify is chosen or should this become an optional extra anyway.",
"title": "Browserify",
"type": "issue"
}
] | 382 | false | false | 1 | 1 | false |
rgrempel/elm-route-hash | null | 127,657,532 | 11 | null | [
{
"action": "opened",
"author": "kunjee17",
"comment_id": null,
"datetime": 1453287504000,
"masked_author": "username_0",
"text": "Hi, \r\n\r\nFirst of all this is the one full fledge routing library I found. Having all the thing. Thanks for great work. Only part I feel is it will be great if there is a way to inject animation for transitioning from page to page. \r\n\r\nIt is just a case of beautification but a good to have to compete other part like react and angular.\r\n\r\nThanks for great work. :)",
"title": "Provide animation or place to animate while transitioning from one page to another ",
"type": "issue"
},
{
"action": "created",
"author": "rgrempel",
"comment_id": 173380043,
"datetime": 1453328327000,
"masked_author": "username_1",
"text": "I'll think about how to do that. In principle, what a URL change generates (in this scheme) is a list of actions, so you could theoretically make those actions perform an animation ... but perhaps there is something the library can do to make that easier.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kunjee17",
"comment_id": 173441333,
"datetime": 1453347784000,
"masked_author": "username_0",
"text": "@username_1 thanks :). Will looking forward to it. For me (while building SPA) first blocker was good url library and your library just blast that blocker. I'm back to elm. :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amitaibu",
"comment_id": 173529623,
"datetime": 1453372128000,
"masked_author": "username_2",
"text": "fyi - I have seen some work by @username_3 on [this](https://github.com/username_3/elm-transit-router) . I think he's also going to consolidate his router solution with the transition module.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "etaque",
"comment_id": 173532203,
"datetime": 1453372729000,
"masked_author": "username_3",
"text": "yes, the hard work is being done by [elm-transit](https://github.com/username_3/elm-transit) (my router is already doing transitions, but it doesn't work with hashes yet).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kunjee17",
"comment_id": 173576913,
"datetime": 1453384680000,
"masked_author": "username_0",
"text": "@username_3 and @username_1 is it possible that we can mix match both libraries. May be end up with one or two mature routing library. Like React-Router for react.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rgrempel",
"comment_id": 226891442,
"datetime": 1466200721000,
"masked_author": "username_1",
"text": "I thought about this a bit more, and I'm pretty sure that it is just a question of getting your `location2action` (or, now, `location2messages`) function to return some actions (or messages) that will kick off an animation.\r\n\r\nTo illustrate, I've updated one of the examples to do that ... when you click on the squares to spin them, you can then use the back / forward buttons, and the URL transition will now be animated (just like the original spin was). Here are the changes:\r\n\r\nhttps://github.com/username_1/elm-route-url/commit/1618b1685e8981f3d48ddf8ae92f0657beca1287\r\n\r\nBut, this isn't really anything that elm-route-url can facilitate, since it has no idea what it means to animate your particular state change -- you just have to return messages that actually trigger an animation, whatever that means in your context.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "megaserg",
"comment_id": 228509112,
"datetime": 1466827414000,
"masked_author": "username_4",
"text": "@username_1 - I think an interesting challenge occurs when one wants to implement a transition where e.g. one page slides out of view and a new page slides in, side-by-side. That means both pages are momentarily visible together at the same time, which means they both have to be rendered, which means they both must be in the model (I guess?), which isn't really desirable. Do you know of an elegant solution?\r\n(I understand this is quite out of scope for this issue but still relevant).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rgrempel",
"comment_id": 228583346,
"datetime": 1466914291000,
"masked_author": "username_1",
"text": "I suppose the Elm-ish solution, as usual, is essentially to model the problem.\r\n\r\nSo, suppose you have a `Page` which represents one of several virtual pages, and you've got an `update` and `view` function that works with that `Model` -- so, the normal thing, you might say.\r\n\r\nNow, if you want to animate a transition to the next `Page`, I suppose you'll have to add something like a `Maybe AnimationState` to the `Page`. And, the `AnimationState` would be composed of something like a `Page` -- that is, the next page -- and something that tracks the animation progress. And your `update` method would need a modification to kick off the animation (and progress it). And your `view` method would need to consult the `AnimationState` to know whether to draw just one `Page` or perhaps two side-by-side (at some stage of the animation, as tracked within the `AnimationState`).\r\n\r\nOr something like that ... that's all a little vague, of course, but I think that would basically be the idea.\r\n\r\nNow, you could imagine a generic `AnimationState model` type, where, provided with the `update`, `view` et. al. functions for the `model` type, it would wrap them in some way to provide `update` and `view` functions that generically handle drawing the various stages of an animation. That seems possible to me, without thinking it through very hard -- there may well be some pitfalls that don't occur to me.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "rgrempel",
"comment_id": null,
"datetime": 1468219743000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 4,015 | false | false | 5 | 10 | true |
FreeRDP/FreeRDP | FreeRDP | 46,663,776 | 2,166 | null | [
{
"action": "opened",
"author": "oelbox",
"comment_id": null,
"datetime": 1414091161000,
"masked_author": "username_0",
"text": "Connecting to a rdp-server in fullscreen renders only the first 15-20 percent of the remote desktop, pressing ctrl-alt-enter (exiting fullscreen) the entire remote desktop is rendered normally, pressing ctrl-alt-enter to enter fullscreen again result in what appears to be a transparent window, meaning it is showing my local desktop, but nothing on the desktop is clickable - so it's like a fullscreen window that is completely transparent.\r\n\r\nWhen connecting in fullscreen and getting a partial render of the desktop, doing a \"windows-key+d\" (toggle desktop), xfreerdp will render the entire screen, but exiting fullscreen, and entering fullscreen again, doing \"windows-key+d\" again will not render the window, and I'm stuck in a \"fullscreen transparent window\" until I exit fullscreen.\r\n\r\nEverything works fine if I start xfreerdp without the fullscreen switch (but going fullscreen with ctrl-alt-enter introduces the problem again).\r\n\r\nThis was not an issue in xfreerdp 1.0.2, but was first experienced with 1.1.0. I've tried with version 1.2.0-beta1, but with the same result.\r\n\r\nI've tried various bpp settings and other adjustments to see if something else was influencing this (disabling xfwm compositor etc), but this did not seem to have any effect on the issue.\r\n\r\nMy system is running Arch Linux, with xfce 4.10 on an Intel HD 3000 (xf86-video-intel version 2.99.916).\r\n\r\nCommand line to connect:\r\nxfreerdp /f /admin /u:user /p:password /network:broadband /v:server:3389 /bpp:16\r\n\r\nThis goes for connecting to a windows xp machine, a windows server 2008, a windows server 2008 R2 and also windows XP running in virtualbox and connecting to the built in virtualbox rdp-server implementation.\r\n\r\nOnce in a while though, a fullscreen connect works, but pressing ctrl-alt-enter to exit full screen, and then pressing ctrl-alt-enter to enter fullscreen will always result in the \"fullscreen transparent window\".\r\n\r\nDowngrading to freerdp 1.02 and connecting using: \"xfreerdp -0 -f -u user -p password -x b server\" fixes the issue.\r\n\r\nIf this is a known bug, I apologize for posting a duplicate issue, I could not find any other issue describing the above, but that might come down to my lacking github-search-skills.",
"title": "xfreerdp fullscreen not rendering correctly or not at all",
"type": "issue"
},
{
"action": "created",
"author": "jawz101",
"comment_id": 119047304,
"datetime": 1436234855000,
"masked_author": "username_1",
"text": "remmina/freerdp have been causing me issues on Arch since I'd been using Arch for the past couple of years. Switching to Xubuntu seems to work well. I tried so many iterations of settings (disabling themes service on the Windows 7 box, disabling NLA and just using plain old security, trying different compression levels on the Arch box... nothing helps. All I can say is the RDP session hangs and I constantly have to disconnect and reconnect after every mouse click to get the screen to redraw itself.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "akallabeth",
"comment_id": 381043492,
"datetime": 1523602934000,
"masked_author": "username_2",
"text": "Fullscreen is working on `2.0.0-rc2`, create a new issue if you find something again.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "akallabeth",
"comment_id": null,
"datetime": 1523602935000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 2,815 | false | false | 3 | 4 | false |
angular/angular.io | angular | 77,502,132 | 118 | {
"number": 118,
"repo": "angular.io",
"user_login": "angular"
} | [
{
"action": "opened",
"author": "PzYon",
"comment_id": null,
"datetime": 1431925308000,
"masked_author": "username_0",
"text": "",
"title": "fixed typos in bios (harp.json)",
"type": "issue"
},
{
"action": "created",
"author": "kwalrath",
"comment_id": 103123356,
"datetime": 1431967544000,
"masked_author": "username_1",
"text": "LGTM. Thanks, @username_0!",
"title": null,
"type": "comment"
}
] | 21 | false | false | 2 | 2 | true |
nepsilon/search-query-parser | null | 177,413,879 | 7 | null | [
{
"action": "opened",
"author": "satazor",
"comment_id": null,
"datetime": 1474029012000,
"masked_author": "username_0",
"text": "The master branch contains a fix and some improvements that I would like to have on npm. Also could you please bump this to `1.0.0`? I'm going to use this module in https://npms.io",
"title": "Please release a new version",
"type": "issue"
},
{
"action": "closed",
"author": "nepsilon",
"comment_id": null,
"datetime": 1474030245000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "nepsilon",
"comment_id": 247592497,
"datetime": 1474030245000,
"masked_author": "username_1",
"text": "[Done](https://www.npmjs.com/package/search-query-parser)! \r\n\r\nLooking forward to use it on [npms.io](https://npms.io) 👍",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "satazor",
"comment_id": 247597274,
"datetime": 1474031668000,
"masked_author": "username_0",
"text": "Ty!",
"title": null,
"type": "comment"
}
] | 303 | false | false | 2 | 4 | false |
aws/aws-sdk-java | aws | 23,925,422 | 152 | {
"number": 152,
"repo": "aws-sdk-java",
"user_login": "aws"
} | [
{
"action": "opened",
"author": "kelcecil",
"comment_id": null,
"datetime": 1386518079000,
"masked_author": "username_0",
"text": "This addresses issue #89. There is a getRegion method already provided in AmazonS3Client that tries to pull the region from the superclass and defaults back to US_Standard when one is not set. Passing the result from getRegion as the region parameter in CreateBucketRequest is a simple way to implement the desired behavior.",
"title": "Use getRegion to determine where a bucket should be created when using createBucket(bucketName)",
"type": "issue"
},
{
"action": "created",
"author": "hanshuo-aws",
"comment_id": 94047246,
"datetime": 1429295669000,
"masked_author": "username_1",
"text": "See #89",
"title": null,
"type": "comment"
}
] | 331 | false | false | 2 | 2 | false |
rust-lang/rfcs | rust-lang | 43,716,444 | 313 | null | [
{
"action": "opened",
"author": "rust-highfive",
"comment_id": null,
"datetime": 1411535008000,
"masked_author": "username_0",
"text": "Note: Much or all of the feature requested here should be covered by RFC PR #195\r\n\r\n----\r\n\r\n<a href=\"https://github.com/username_2\"><img src=\"https://avatars.githubusercontent.com/u/173127?v=2\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [username_2](https://github.com/username_2)**\r\n_Tuesday Feb 19, 2013 at 16:15 GMT_\r\n\r\n_For earlier discussion, see https://github.com/rust-lang/rust/issues/5033_\r\n\r\n_This issue was labelled with: A-servo, A-traits, A-typesystem, B-RFC, I-enhancement, P-high in the Rust repository_\r\n\r\n----\r\n\r\nRust's type system reflects many advances in the state of the art.\r\n\r\nHowever, there is one feature (offered by C++ and ML) that is not present in Rust: The ability to declare within a trait a named type (and then each impl item would be obligated to bind that name to an appropriate type for the implementation).\r\n\r\nRelated work: See [Garcia et al. 2003](http://www.osl.iu.edu/publications/prints/2003/comparing_generic_programming03.pdf), especially section 6.2, 10.2, and 10.3. Another useful reference is [Chakravarty et al 2005](http://www.cse.unsw.edu.au/~chak/papers/CKP05.html)\r\n\r\nThe Haskell community calls such a construct an \"associated type synonym.\"\r\n\r\nHere is an small example to illustrate the idea.\r\n\r\nFirst, the easy part: how such a feature would look at the level of trait and impl items:\r\n\r\n```rust\r\ntrait Graph {\r\n pub type Node; // Graphs are composed of vertices\r\n pub type Edge; // and arcs between the vertices.\r\n pub fn src(&self, edge: Edge) -> Node;\r\n pub fn tgt(&self, edge: Edge) -> Node;\r\n}\r\n\r\n\r\n// A vector of (source,target) pairs is a graph where the edges\r\n// indices into the vector\r\nimpl<T : Copy> &[(T,T)] : Graph {\r\n pub type Node = T; // Here we satisfy the obligation to provide Node\r\n pub type Edge = uint; // and Edge implementation types.\r\n pub fn src(&self, edge: Edge) -> Node { let (s,_) = self[edge]; s }\r\n pub fn tgt(&self, edge: Edge) -> Node { let (_,t) = self[edge]; t }\r\n}\r\n```\r\n\r\nIdeally one would extract the type from a trait by using a path, using a type parameter as a path component. So for example:\r\n\r\n```rust\r\ntrait IncidenceGraph : Graph {\r\n pub fn out_degree(&self, node: self::Node) -> uint;\r\n pub fn out_edges(&self, node: self::Node, it: fn(self::Edge) -> bool);\r\n}\r\n\r\nfn children<G:IncidenceGraph>(&g:G, &n: G::Node) -> ~[G::Node] {\r\n let result = ~[];\r\n for g.out_edges(n) |e| {\r\n ret.push(g.tgt(n))\r\n }\r\n ret\r\n}\r\n```\r\n\r\nNote: I am aware that one can express currently express type synonyms in much the same way that one does in Java (or C#, or Eiffel; see Garcia et al paper): by making them a type-parameter of the trait itself. Rust's type-inference system does make that workaround more palatable, but it seems natural to enable the developer to express what they mean more directly: These types are obligations of the implementation, much like the functions declared in the trait, and thus it makes sense to express them the same way.\r\n\r\n----\r\n\r\nThere are various issues to consider: e.g.:\r\n * Do we allow bounds on the type declarations in the trait,\r\n * Is there is any potential ambiguity with module names introduced by allowing traits (or rather, type parameters implementing a trait) to appear as path components in paths that are used in a type-expression context.\r\n * Are there any gotcha's or generalizations that have been uncovered by the broader PL community that we would want to address. (For example, GHC has [indexed data families](http://www.haskell.org/haskellwiki/GHC/Type_families#Associated_family_declarations), with which I am not familiar but seem to be a generalization with some potential gotchas. Caveat: I am not a Haskell programmer.)\r\n\r\nDespite the above issues, this seems like a relatively straightforward change to the language (especially since one can already encode the pattern, so adding it should not inject e..g any type soundness bugs, right?).",
"title": "RFC: trait-declared associated type synonyms",
"type": "issue"
},
{
"action": "created",
"author": "quantheory",
"comment_id": 69867025,
"datetime": 1421209011000,
"masked_author": "username_1",
"text": "I sort of like this proposal, but I'm puzzled. Shouldn't something like the following be possible under the existing RFC?\r\n\r\n```rust\r\npub enum InputStep<I: InputIterator> {\r\n Cont(I::Element, I),\r\n Done(I::Leftovers),\r\n}\r\n\r\npub enum ZipInputLeftovers<L: InputIterator, R: InputIterator> {\r\n More1(L::Element, L, R::Leftovers),\r\n More2(L::Leftovers, R::Element, R),\r\n Neither(L::Leftovers, R::Leftovers),\r\n}\r\n```\r\n\r\nOf course this is more verbose than being able to inline these in the trait or impl, and you have to use names like `InputStep` in some cases, but this seems much better than making every used type a generic (input) parameter. Or am I wrong and something prevents this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pnkfelix",
"comment_id": 70076656,
"datetime": 1421323610000,
"masked_author": "username_2",
"text": "I'm going to close this ticket; at this point, the addition of associated items to the language has addressed the original problem that prompted me to file it back in early 2013, and any suggestions of further changes should be filed as separate tickets rather than appended here.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "pnkfelix",
"comment_id": null,
"datetime": 1421323610000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 4,922 | false | false | 3 | 4 | true |
zalando/zappr | zalando | 138,215,170 | 32 | null | [
{
"action": "opened",
"author": "prayerslayer",
"comment_id": null,
"datetime": 1457020023000,
"masked_author": "username_0",
"text": "",
"title": "Repo name is insufficient in list",
"type": "issue"
},
{
"action": "closed",
"author": "mfellner",
"comment_id": null,
"datetime": 1457029937000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 109 | false | false | 2 | 2 | false |
apache/spark | apache | 83,316,630 | 6,547 | {
"number": 6547,
"repo": "spark",
"user_login": "apache"
} | [
{
"action": "opened",
"author": "liancheng",
"comment_id": null,
"datetime": 1433135074000,
"masked_author": "username_0",
"text": "This is a follow-up of PR #6493, which has been reverted in branch-1.4 because it uses Java 7 specific APIs and breaks Java 6 build. This PR replaces those APIs with equivalent Guava ones to ensure Java 6 friendliness.\r\n\r\ncc @username_1 @pwendell, this should also be back ported to branch-1.4.",
"title": "[SQL] [TEST] [MINOR] Follow-up of PR #6493, use Guava API to ensure Java 6 friendliness",
"type": "issue"
},
{
"action": "created",
"author": "andrewor14",
"comment_id": 107308592,
"datetime": 1433135642000,
"masked_author": "username_1",
"text": "lgtm merging once tests pass",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liancheng",
"comment_id": 107851793,
"datetime": 1433232307000,
"masked_author": "username_0",
"text": "Addressed @zsxwing's comment, will merge this to master and branch-1.4 once Jenkins passes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "andrewor14",
"comment_id": 108136412,
"datetime": 1433290043000,
"masked_author": "username_1",
"text": "master 1.4 thanks cheng",
"title": null,
"type": "comment"
}
] | 436 | false | true | 2 | 4 | true |
ember-cli/loader.js | ember-cli | 222,450,917 | 117 | {
"number": 117,
"repo": "loader.js",
"user_login": "ember-cli"
} | [
{
"action": "opened",
"author": "runspired",
"comment_id": null,
"datetime": 1492528498000,
"masked_author": "username_0",
"text": "There is no `.npmignore` file excluding these, so `files: []` here is the SOT.\r\nThis might help make errors with `bower install` more obvious, as bower tends to attempt to pull from `lib/` and will not have `dist/` available to it.",
"title": "Remove `lib/` from published files.",
"type": "issue"
},
{
"action": "created",
"author": "runspired",
"comment_id": 294877552,
"datetime": 1492528514000,
"masked_author": "username_0",
"text": "cc @username_2 @username_1 @Turbo87",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rwjblue",
"comment_id": 294879211,
"datetime": 1492528833000,
"masked_author": "username_1",
"text": "Now that I think about it more, I thought we actually wanted to keep these files around. So that we can allow apps to opt-in or out of instrumentation in the build (with something like ember-heimdall). This functionality was removed temporarily but I believe that \"we all agree\" that we want the functionality...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stefanpenner",
"comment_id": 294879711,
"datetime": 1492528928000,
"masked_author": "username_2",
"text": "Didn't we produce two builds one instrumented and one not. If so, in either case we wouldn't need lib",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rwjblue",
"comment_id": 294881982,
"datetime": 1492529357000,
"masked_author": "username_1",
"text": "Hehe, I really don't recall 😝",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "runspired",
"comment_id": 294882978,
"datetime": 1492529536000,
"masked_author": "username_0",
"text": "Some thoughts\r\n\r\n- once (or before) `ember-heimdall` is published, we should prebuild an instrumented and non-instrumented version if we've stopped doing so. This addon seems like a good candidate to be `static`\r\n- relying on `lib/` for this seems like it would always be problematic, as we'd have to be extra careful to never do anything that didn't require a build step\r\n- `ember-heimdall` is not published yet",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stefanpenner",
"comment_id": 294920614,
"datetime": 1492536769000,
"masked_author": "username_2",
"text": "https://github.com/ember-cli/loader.js/blob/master/build.js#L20",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stefanpenner",
"comment_id": 294920789,
"datetime": 1492536798000,
"masked_author": "username_2",
"text": "@username_1 should this be major or minor release?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rwjblue",
"comment_id": 294930945,
"datetime": 1492538571000,
"masked_author": "username_1",
"text": "@username_2 - I think minor is fine, if folks were using `lib` they already had issues because it assumed `heimdall` global and whatnot...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stefanpenner",
"comment_id": 294962343,
"datetime": 1492545672000,
"masked_author": "username_2",
"text": "released as v4.3.0 🎉",
"title": null,
"type": "comment"
}
] | 1,390 | false | false | 3 | 10 | true |
guardian/frontend | guardian | 215,451,133 | 16,184 | {
"number": 16184,
"repo": "frontend",
"user_login": "guardian"
} | [
{
"action": "opened",
"author": "gustavpursche",
"comment_id": null,
"datetime": 1490022608000,
"masked_author": "username_0",
"text": "## What does this change?\r\n\r\nUpdates the hosts used to fetch polyfill.io.\r\n\r\n## What is the value of this and can you measure success?\r\n\r\nShorter response times, due to less DNS, TLS roundtrips\r\n\r\n## Does this affect other platforms - Amp, Apps, etc?\r\n\r\nNo.\r\n\r\n## Screenshots\r\n\r\nNo.\r\n\r\n## Tested in CODE?\r\n\r\nNo.",
"title": "Update polyfill.io hosts",
"type": "issue"
},
{
"action": "created",
"author": "PRBuilds",
"comment_id": 287791079,
"datetime": 1490022950000,
"masked_author": "username_1",
"text": "PR build results:\n\nscreenshots\n[mobile.png](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-16184/screenshots/books%252F2014%252Fmay%252F21%252Fguardian-journalists-jonathan-freedland-ghaith-abdul-ahad-win-orwell-prize-journalism/mobile.png) • [wide.png](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-16184/screenshots/books%252F2014%252Fmay%252F21%252Fguardian-journalists-jonathan-freedland-ghaith-abdul-ahad-win-orwell-prize-journalism/wide.png) • [tablet.png](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-16184/screenshots/books%252F2014%252Fmay%252F21%252Fguardian-journalists-jonathan-freedland-ghaith-abdul-ahad-win-orwell-prize-journalism/tablet.png) • [desktop.png](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-16184/screenshots/books%252F2014%252Fmay%252F21%252Fguardian-journalists-jonathan-freedland-ghaith-abdul-ahad-win-orwell-prize-journalism/desktop.png)\n \nexceptions (0)\n[thrown-exceptions.js](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-16184/thrown-exceptions.js) \n\nwebpagetest (2)\n[performanceComparisonSummary.txt](https://s3-eu-west-1.amazonaws.com/prbuilds/PR-16184/performanceComparisonSummary.txt)\n\n-automated message",
"title": null,
"type": "comment"
}
] | 1,466 | false | true | 2 | 2 | false |
dcos/dcos-ui | dcos | 165,202,755 | 697 | {
"number": 697,
"repo": "dcos-ui",
"user_login": "dcos"
} | [
{
"action": "opened",
"author": "kennyt",
"comment_id": null,
"datetime": 1468365313000,
"masked_author": "username_0",
"text": "",
"title": "Remove link tags in service form description",
"type": "issue"
},
{
"action": "created",
"author": "mesosphere-web",
"comment_id": 232210081,
"datetime": 1468365318000,
"masked_author": "username_1",
"text": "Reviewer: @philipnrmn",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jfurrow",
"comment_id": 232210376,
"datetime": 1468365425000,
"masked_author": "username_2",
"text": ":ship:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kennyt",
"comment_id": 232214066,
"datetime": 1468366822000,
"masked_author": "username_0",
"text": "LGTM, nice one",
"title": null,
"type": "comment"
}
] | 41 | false | false | 3 | 4 | false |
silviomoreto/bootstrap-select | null | 37,718,602 | 643 | null | [
{
"action": "opened",
"author": "sirNemanjapro",
"comment_id": null,
"datetime": 1405168054000,
"masked_author": "username_0",
"text": "Is there a chance we could use any other type of font icon instead of the pre built Bootstrap glyphs?\n\nIf so, how would one use them? Example?",
"title": "data-icon with FontAwesome (or any other)",
"type": "issue"
},
{
"action": "created",
"author": "sovtek",
"comment_id": 274483116,
"datetime": 1485176758000,
"masked_author": "username_1",
"text": "I am having this issue too. Is it possible to use font awesome with the \"data-icon\" attribute? Not trying to overload iconbase or tick icon. Trying to make individual option icons use font-awesome.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rjmd",
"comment_id": 325257416,
"datetime": 1503894494000,
"masked_author": "username_2",
"text": "Agreed with @username_1 , I would also like to put font-awesome icons into the data-icon attribute...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "caseyjhol",
"comment_id": 325470478,
"datetime": 1503951923000,
"masked_author": "username_3",
"text": "data-icon simply creates a span element with a class that is whatever you've set data-icon to. So, if you want Font Awesome, simply set `data-icon=\"fa-heart\"`. That would result in `<span class=\"fa fa-heart\"></span>`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rjmd",
"comment_id": 327654741,
"datetime": 1504746977000,
"masked_author": "username_2",
"text": "Thanks @username_3, the only issue with this solution is that I want the icon to be colored depending on the item in the list.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikomister",
"comment_id": 454053990,
"datetime": 1547481146000,
"masked_author": "username_4",
"text": "**(Bootstrap ^4.*.*, bootstrap-select ^v1.13.2)** **I think I found a solution**. Just add the \"fa\" into data-icon attribute **before** the fa-\"your icon name\", like this: \r\n`\r\n<select class=\"selectpicker\" data-live-search=\"true\" data-iconBase=\"fa\" data-tickIcon=\"fa-check\" multiple>\r\n <option data-icon=\"fa fa-phone\" value=\"1\">One</option>\r\n <option value=\"2\">Two</option>\r\n <option value=\"3\">Three</option>\r\n </select>`",
"title": null,
"type": "comment"
}
] | 1,335 | false | false | 5 | 6 | true |
Vector35/binaryninja-docs | Vector35 | 136,184,320 | 167 | null | [
{
"action": "opened",
"author": "psifertex",
"comment_id": null,
"datetime": 1456347455000,
"masked_author": "username_0",
"text": "RIP relative instructions are converted to absolute addresses during display which works well for cross references but does NOT work when when attempting to in-place edit one of the instructions as the absolute encoding will be 1) potentially wrong for ASLR binaries, and 2) a longer instruction",
"title": "disassembling RIP relative instructions",
"type": "issue"
},
{
"action": "created",
"author": "psifertex",
"comment_id": 212278599,
"datetime": 1461133407000,
"masked_author": "username_0",
"text": "Fixed in dev.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "psifertex",
"comment_id": null,
"datetime": 1461133407000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 308 | false | false | 1 | 3 | false |
naver/ngrinder | naver | 140,138,198 | 90 | null | [
{
"action": "opened",
"author": "yusufchang",
"comment_id": null,
"datetime": 1457689289000,
"masked_author": "username_0",
"text": "2016-03-11 17:15:06,337 INFO agent daemon : worker PVGN50897276A-0 started\r\n2016-03-11 17:15:36,560 INFO agent daemon : received a stop message\r\n2016-03-11 17:15:36,561 INFO agent daemon : Don't start anymore by message from controller.\r\n2016-03-11 17:15:39,289 INFO agent daemon : received a stop message\r\n2016-03-11 17:15:41,807 INFO agent daemon : received a stop message\r\n2016-03-11 17:15:41,807 INFO agent daemon : Terminating unresponsive processes by force\r\n2016-03-11 17:15:41,994 INFO agent daemon : All workers are finished\r\n2016-03-11 17:15:41,994 INFO agent daemon : communication shut down\r\n2016-03-11 17:15:41,994 INFO agent daemon : Test shuts down.\r\n2016-03-11 17:15:41,994 INFO agent controller : Send log for test_3\r\n2016-03-11 17:15:42,010 INFO agent controller : Clean up the perftest logs\r\n\r\nHi, I'm very confused about agent stop message. \r\n\r\nI just clicked start test from console, and agent received above log, test normally ran in console page and came out data report, but about 30 seconds later, agent daemon received a stop message like above log. I don't know the stop reason, can make sure no stop message sent by myself.\r\n\r\nAnywhere else meet the same problem? And any suggestion?\r\nThanks",
"title": "Agent daemon received a stop message",
"type": "issue"
},
{
"action": "created",
"author": "yusufchang",
"comment_id": 196619343,
"datetime": 1458008574000,
"masked_author": "username_0",
"text": "solved",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "yusufchang",
"comment_id": null,
"datetime": 1458008574000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "zlatsh",
"comment_id": 321142786,
"datetime": 1502249415000,
"masked_author": "username_1",
"text": "how did you solve it? we have same problem sometimes, please share you solution, thanks",
"title": null,
"type": "comment"
}
] | 1,345 | false | false | 2 | 4 | false |
archiecobbs/logwarn | null | 157,154,981 | 25 | null | [
{
"action": "opened",
"author": "andreasstieger",
"comment_id": null,
"datetime": 1464337534000,
"masked_author": "username_0",
"text": "Please distribute bootstrapped tarballs (e.g. containing the configure script) with your releases by attaching them to the corresponding tag as a binary asset.",
"title": "distribute bootstrapped tarballs.",
"type": "issue"
},
{
"action": "created",
"author": "archiecobbs",
"comment_id": 222234810,
"datetime": 1464377596000,
"masked_author": "username_1",
"text": "They are distributed, it's just not obvious where to get them.\r\n\r\nSee https://github.com/username_1/logwarn/wiki/Downloads\r\n\r\nI'll also put a link on the main README.\r\n\r\nThanks.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "archiecobbs",
"comment_id": null,
"datetime": 1464377597000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 337 | false | false | 2 | 3 | true |
burtonwilliamt/carlogicapi | null | 184,250,252 | 12 | null | [
{
"action": "opened",
"author": "cowang4",
"comment_id": null,
"datetime": 1476974768000,
"masked_author": "username_0",
"text": "",
"title": "Write Installation Guide - Windows",
"type": "issue"
},
{
"action": "closed",
"author": "sptfire127",
"comment_id": null,
"datetime": 1477011770000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 0 | false | false | 2 | 2 | false |
jhudson8/react-chartjs | null | 131,497,279 | 76 | null | [
{
"action": "opened",
"author": "matrinox",
"comment_id": null,
"datetime": 1454626178000,
"masked_author": "username_0",
"text": "Is it possible to version the decencies so this package can be used in React 13? Right now any version of react-chartjs, including versions before React 14 was even announced, require React 14.x due to react-dom requiring React 14.x",
"title": "Versioning?",
"type": "issue"
},
{
"action": "created",
"author": "austinpray",
"comment_id": 180138857,
"datetime": 1454635105000,
"masked_author": "username_1",
"text": "Here is the break: https://github.com/jhudson8/react-chartjs/commit/29297915b3aa92702b982b7dfdf2103e9390a9cf \r\n\r\nUse 0.6, I suppose. I'm open to bug fixes being backported to 0.6.x if you PR: https://github.com/jhudson8/react-chartjs/tree/0.6",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "austinpray",
"comment_id": null,
"datetime": 1459113769000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 474 | false | false | 2 | 3 | false |
line/line-bot-sdk-python | line | 208,503,049 | 32 | null | [
{
"action": "opened",
"author": "fhals",
"comment_id": null,
"datetime": 1487351726000,
"masked_author": "username_0",
"text": "I'm trying to send audio message via Line. The message was successfully sent from Line app. Then I get the binary via chunking. But it's weird that the binary output doesn't give the same voice as the original one. Any idea?",
"title": "Audio output is not consistent with audio input",
"type": "issue"
},
{
"action": "created",
"author": "fhals",
"comment_id": 280900248,
"datetime": 1487486795000,
"masked_author": "username_0",
"text": "I think the problem is in my encoding.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "fhals",
"comment_id": null,
"datetime": 1487486795000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 262 | false | false | 1 | 3 | false |
alisw/AliPhysics | alisw | 214,699,793 | 154 | {
"number": 154,
"repo": "AliPhysics",
"user_login": "alisw"
} | [
{
"action": "opened",
"author": "brinick",
"comment_id": null,
"datetime": 1489669990000,
"masked_author": "username_0",
"text": "",
"title": "Stress Test 10",
"type": "issue"
},
{
"action": "created",
"author": "alibuild",
"comment_id": 287052434,
"datetime": 1489670013000,
"masked_author": "username_1",
"text": "e1006035ec45b27d432f50fd000322a406a44730: approval required: 1 of @mkrzewic (mkrzewic), @loizides (Constantinos Loizides), @jmargutt (Jacopo Margutti), @rbertens (Redmer Alexander Bertens), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @qgp (Jochen Klein), @mfasDa (Markus Fasel), @aiola (Salvatore Aiola), @username_3 (Laurent Aphecetche)\n\n_Comment with `+1` to approve and allow automatic merging,or with `+test` to run tests only. **Please comment on the pull request: [click here](https://github.com/alisw/AliPhysics/pull/154) and comment at the bottom of the page.**_",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ktf",
"comment_id": 287055263,
"datetime": 1489670653000,
"masked_author": "username_2",
"text": "+test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alibuild",
"comment_id": 287055425,
"datetime": 1489670692000,
"masked_author": "username_1",
"text": "e1006035ec45b27d432f50fd000322a406a44730: testing approved: will not be automatically merged; starting testing. If testing succeeds, merging will require further approval from 1 of @mkrzewic (mkrzewic), @loizides (Constantinos Loizides), @jmargutt (Jacopo Margutti), @rbertens (Redmer Alexander Bertens), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @qgp (Jochen Klein), @mfasDa (Markus Fasel), @aiola (Salvatore Aiola), @username_3 (Laurent Aphecetche)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alibuild",
"comment_id": 287071574,
"datetime": 1489673980000,
"masked_author": "username_1",
"text": "e1006035ec45b27d432f50fd000322a406a44730: tests OK, approval required for merging: 1 of @mkrzewic (mkrzewic), @loizides (Constantinos Loizides), @jmargutt (Jacopo Margutti), @rbertens (Redmer Alexander Bertens), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @qgp (Jochen Klein), @mfasDa (Markus Fasel), @aiola (Salvatore Aiola), @username_3 (Laurent Aphecetche)\n\n_Comment with `+1` to merge. **Please comment on the pull request: [click here](https://github.com/alisw/AliPhysics/pull/154) and comment at the bottom of the page.**_",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aphecetche",
"comment_id": 287089164,
"datetime": 1489677257000,
"masked_author": "username_3",
"text": "+1",
"title": null,
"type": "comment"
}
] | 1,551 | false | false | 4 | 6 | true |
uber/tchannel-python | uber | 172,804,258 | 439 | {
"number": 439,
"repo": "tchannel-python",
"user_login": "uber"
} | [
{
"action": "opened",
"author": "yurishkuro",
"comment_id": null,
"datetime": 1471985688000,
"masked_author": "username_0",
"text": "I ran into similar issue with jaeger-client-python, but forgot to apply it here. The published egg should not contain `crossdock` module.\r\n\r\n@abhinav",
"title": "Do not publish `crossdock` module, it's for tests only",
"type": "issue"
},
{
"action": "created",
"author": "breerly",
"comment_id": 241875503,
"datetime": 1471985747000,
"masked_author": "username_1",
"text": "Aaah, good catch! :shipit:",
"title": null,
"type": "comment"
}
] | 175 | false | false | 2 | 2 | false |
18F/calc | 18F | 174,055,751 | 629 | {
"number": 629,
"repo": "calc",
"user_login": "18F"
} | [
{
"action": "opened",
"author": "jseppi",
"comment_id": null,
"datetime": 1472572098000,
"masked_author": "username_0",
"text": "Work In Progress.\r\n\r\nCreating a decorator to handle form submissions for canceling Data Capture flows.\r\n\r\nCloses #478\r\n\r\nTo Do:\r\n- [ ] functionality\r\n- [ ] tests\r\n- [ ] add decorator to applicable view methods\r\n- [ ] styling tweaks for making cancel buttons",
"title": "[WIP] Canceling data_capture flows",
"type": "issue"
},
{
"action": "created",
"author": "jseppi",
"comment_id": 243603622,
"datetime": 1472596590000,
"masked_author": "username_0",
"text": "Ugh, I can't seem to get my test methods to do what I think they should be doing.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jseppi",
"comment_id": 243801967,
"datetime": 1472657352000,
"masked_author": "username_0",
"text": "ready for review @username_1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jseppi",
"comment_id": 243802851,
"datetime": 1472657519000,
"masked_author": "username_0",
"text": "The problem I was having with tests was that I was trying to raise exceptions in the decorator, but those exceptions are not really catchable in a straightforward way. It seems that throwing decorator exceptions is not a great practice. Instead of checking arguments, I think we're covered by normal Django behaviors. For example, f a view name isn't found, then Django will through an exception somewhere else when it tries to do the reverse lookup, so I think that's ok.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "toolness",
"comment_id": 243856804,
"datetime": 1472668159000,
"masked_author": "username_1",
"text": "This looks good, feel free to merge it!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jseppi",
"comment_id": 243882899,
"datetime": 1472673725000,
"masked_author": "username_0",
"text": "womp womp, travis failed with error `Cannot download \"https://github.com/sass/node-sass/releases/download/v3.8.0/linux-x64-47_binding.node\":`\r\n\r\nResubmitted the job",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jseppi",
"comment_id": 243888585,
"datetime": 1472674905000,
"masked_author": "username_0",
"text": "Lol, and now codeclimate is apparently stalled. Happy Wednesday!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jseppi",
"comment_id": 243895970,
"datetime": 1472676420000,
"masked_author": "username_0",
"text": "Um, something is wrong with codeclimate. It's been running for nearly hour yet hasn't even finished checking out the code according to its status page. Given that it had a green light before the merge of #641, and #641 had its own green light, I am just going to merge this PR.\r\n\r\n<img width=\"934\" alt=\"screen shot 2016-08-31 at 3 46 43 pm\" src=\"https://cloud.githubusercontent.com/assets/697848/18145769/26174e1c-6f92-11e6-8b1d-61da06bb3c5f.png\">",
"title": null,
"type": "comment"
}
] | 1,550 | false | false | 2 | 8 | true |
NixOS/nixpkgs | NixOS | 182,758,559 | 19,508 | {
"number": 19508,
"repo": "nixpkgs",
"user_login": "NixOS"
} | [
{
"action": "opened",
"author": "peterhoeg",
"comment_id": null,
"datetime": 1476356373000,
"masked_author": "username_0",
"text": "###### Motivation for this change\r\n\r\nAlso includes a basic nixos module.\r\n\r\nThis is ridiculously painful due to how dependencies are handled (or I'm missing something completely).\r\n\r\nThe basic dependencies for the application itself are declared up front, but each sub-module has a ```REQUIREMENTS``` array where other python packages are listed. homeassistant will then try to load those dependencies if the module is activated and if failing to do so, will fall back to using pip to install them.\r\n\r\nI honestly don't know what the best way to deal with this is. It's a rabbit hole of dependencies that reminds me of .rpm hell in the old RH days. Additionally, these sub modules will sometimes require specific versions which means multiple versions now need to be maintained and the maintenance cost just shoots up.\r\n\r\nAny thoughts @fridh?\r\n\r\n###### Things done\r\n\r\n- [X] Tested using sandboxing\r\n ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n on non-NixOS)\r\n- Built on platform(s)\r\n - [X] NixOS\r\n - [ ] OS X\r\n - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [X] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---",
"title": "homeassistant: [WIP] init at 0.30.2",
"type": "issue"
},
{
"action": "created",
"author": "schneefux",
"comment_id": 253486670,
"datetime": 1476357876000,
"masked_author": "username_1",
"text": "[requirements-all.txt](https://github.com/home-assistant/home-assistant/blob/dev/requirements_all.txt) includes all the packages you would possibly need. The dynamic `pip` installation is merely for convenience so you don't have to install packages you don't use.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FRidh",
"comment_id": 253487451,
"datetime": 1476358132000,
"masked_author": "username_2",
"text": "Lots of dependencies -> lots of work. That's just how it is right now. Outside of Nixpkgs you could use `pypi2nix`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "peterhoeg",
"comment_id": 253551657,
"datetime": 1476373194000,
"masked_author": "username_0",
"text": "first of all, thank you @fridh for all the feedback, much appreciated!\r\n\r\nThis is a WIP as I wasn't sure if my approach was correct, so I will get all the items cleaned up you mentioned. All tests will be enabled of course, I just wanted to see if I could get this thing up and running first.\r\n\r\nBut it offhand seems like there should be a better way. Coming from ruby where the combination of ```bundler``` and ```bundix``` makes it *super* easy, packaging a complex python app seems extremely work intensive.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FRidh",
"comment_id": 253554692,
"datetime": 1476373819000,
"masked_author": "username_2",
"text": "@username_0 you're welcome. \r\n\r\nThere should indeed be a better way, but unfortunately upstream doesn't provide any. Python packaging is quite a mess. People can put whatever code they want in `setup.py`. Therefore, the only way to find out what relations packages have, is to actually build them. This is the approach `pypi2nix` takes. But with extension types you need to override the results, and fixing test suites is still something you need to do yourself (if you're interested in the tests, that is).\r\n\r\nAs soon as Hydra allows network access during evaluation time, I will further work on https://github.com/NixOS/nixpkgs/pull/16005, which at least reduces the amount of work the packaging requires.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FRidh",
"comment_id": 253557234,
"datetime": 1476374339000,
"masked_author": "username_2",
"text": "(hmm, but that should actually work now since https://github.com/NixOS/nix/commit/06bbfb6004942bfcddd930e746ee7a2bfe5c3872)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "peterhoeg",
"comment_id": 253763808,
"datetime": 1476440611000,
"masked_author": "username_0",
"text": "So for the time being, what would you recommend for packaging home assistant?\r\n\r\nThe way I see it, we can do one of the following:\r\n\r\n1) Package the bare minimum (ie the server without any modules and its requirements). Then let it download via PIP as it launches.\r\n\r\n2) Item 1 + how ever many additional modules I can be bothered to manually write expressions for.\r\n\r\n3) Use pypi2nix on the ```requirements_all.txt``` file and use it as an external source.\r\n\r\n4) Wait for a more elegant solution.\r\n\r\n\r\n2 seems a bit pointless as there will be modules that require PIP anyway and there is not much difference between having 70% and 97% of the packages dynamically installed.\r\n\r\n3 requires additional work on the part of the person using home assistant which doesn't seem like a nice solution.\r\n\r\nThat really only leaves us with option 1.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FRidh",
"comment_id": 253777991,
"datetime": 1476445498000,
"masked_author": "username_2",
"text": "This won't work because it cannot write in the store. You would have to specify another directory to install the modules, however, the Nix Python won't be able to find those modules.\r\n\r\n\r\nI suggest for now that you create a new repo in which you define the module, and where you create the expressions with `pypi2nix`. If one wants to use `homeassistant`, they can clone the repo, and import it. There are other modules like that, e.g. [musnix](https://github.com/musnix/musnix). This saves you a lot of time, while keeping it fairly straightforward for others to use your module. Not everything needs to be in Nixpkgs.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "peterhoeg",
"comment_id": 254254422,
"datetime": 1476720757000,
"masked_author": "username_0",
"text": "@fridh assuming the home-assistant binary installs using ```--user```, shouldn't both python modules in the store and local user modules be available?\r\n\r\nIn any case, thanks to @garbas, ```pypi2nix``` is now able to generate the expressions for home-assistant, so I will be sticking that in a separate repository and move the nixos bits there too in the same way as musnix. \r\n\r\nWould you (the collective nix(os) maintainers be open to moving that repository under the main NixOS github organization if we handle changes similarly to nixpkgs (ie, only trusted project members can merge)? That should enable us to ship modules that cannot make it into the main repository but still be of the same high standard.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FRidh",
"comment_id": 255042938,
"datetime": 1476952350000,
"masked_author": "username_2",
"text": "I think at some point it might make sense to put such repo's together under one umbrella.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "peterhoeg",
"comment_id": 255046465,
"datetime": 1476953280000,
"masked_author": "username_0",
"text": "For anyone else stumbling over this issue, @garbas has created a dedicated repos for python packages generated using pypi2nix which is where I'll be submitting the home-assistant stuff. https://github.com/garbas/nixpkgs-python\r\n\r\n@username_2, once again thank you for taking the time to explain things.",
"title": null,
"type": "comment"
}
] | 5,738 | false | true | 3 | 11 | true |
composer/composer | composer | 17,458,591 | 2,135 | null | [
{
"action": "opened",
"author": "boldtrn",
"comment_id": null,
"datetime": 1375285146000,
"masked_author": "username_0",
"text": "I wonder if it's possible to pass arguments to scripts that are called from the `composer.json`?\n\nE.G.\n\n```\n\"scripts\" : {\n \"post-update-cmd\" : [\n \"Mopa\\\\Bundle\\\\BootstrapBundle\\\\Composer\\\\ScriptHandler::postInstallSymlinkTwitterBootstrap\"\n ]\n}\n```\n\nNow I want to pass the argument `--no-symlink` to the script. But it doesn't work by adding `--no-symlink`.",
"title": "Passing arguments to scripts",
"type": "issue"
},
{
"action": "created",
"author": "simonbergmann",
"comment_id": 260742536,
"datetime": 1479238394000,
"masked_author": "username_1",
"text": "@username_0 if you want to pass the argument --no-symlink to a script you can do this:\r\ncomposer post-update-cmd -- --no-symlink\r\nmore info here: https://getcomposer.org/doc/articles/scripts.md",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FGM",
"comment_id": 283290372,
"datetime": 1488360807000,
"masked_author": "username_2",
"text": "Creative use of xargs in the script definition might help, by echoing the flags you want and having the script command be \"xargs original_command\"",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pmgouveia",
"comment_id": 310414028,
"datetime": 1498145101000,
"masked_author": "username_3",
"text": "@username_2 can you elaborate? thanks! 👍",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "olivertappin",
"comment_id": 490409601,
"datetime": 1557306335000,
"masked_author": "username_4",
"text": "This still seems to be an issue in the latest version of Composer (v1.8.5)",
"title": null,
"type": "comment"
}
] | 824 | false | false | 5 | 5 | true |
Microsoft/RTVS | Microsoft | 181,539,192 | 2,449 | {
"number": 2449,
"repo": "RTVS",
"user_login": "Microsoft"
} | [
{
"action": "opened",
"author": "huguesv",
"comment_id": null,
"datetime": 1475792060000,
"masked_author": "username_0",
"text": "Fixes https://github.com/Microsoft/RTVS/issues/2409\r\n\r\nFile looks like this now:\r\n```\r\n# Application settings file.\r\n# File content was generated on 10/6/2016 3:09:07 PM.\r\n\r\nsettings <- new.env()\r\n\r\nsettings$name1 <- 'value1'\r\n\r\nsettings$name2 <- 'value2'\r\n\r\n```\r\n\r\nAnd it can import settings from v0.5 or older. Once you save, it will rewrite it in new format.\r\n\r\nSo if you source the settings file, you access them via `settings$name1`. That's not exactly what is mentioned in the bug though, which says you should be able to access them via `settings:::name1`. Not sure if that was a mistake of if there's a way to achieve that.",
"title": "Store settings in an environment.",
"type": "issue"
},
{
"action": "created",
"author": "MikhailArkhipov",
"comment_id": 252111347,
"datetime": 1475794585000,
"masked_author": "username_1",
"text": "👍",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "huguesv",
"comment_id": 252156367,
"datetime": 1475818152000,
"masked_author": "username_0",
"text": "Added a fix for #2420.\r\n\r\nAll values are escaped/unescaped when saving/writing to Settings.R, which means the UI is slightly annoying to use when newlines are present, but user can always edit those directly in Settings.R. The benefit is that the user doesn't need to worry about generating invalid strings, there's no need to know they are stored in R code as opposed XML or whatever.\r\n\r\nFYI `FromRStringLiteral` was not used before. I made changes to that one and `ToRStringLiteral` so that you can round-trip values that have characters that need escaping.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MikhailArkhipov",
"comment_id": 252269477,
"datetime": 1475851020000,
"masked_author": "username_1",
"text": "👍",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "huguesv",
"comment_id": 254323090,
"datetime": 1476735946000,
"masked_author": "username_0",
"text": "Added parsing of hex and octal escape sequence.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "int19h",
"comment_id": 254649850,
"datetime": 1476827402000,
"masked_author": "username_2",
"text": "👍",
"title": null,
"type": "comment"
}
] | 1,242 | false | false | 3 | 6 | false |
garnaat/kappa | null | 189,850,124 | 94 | null | [
{
"action": "opened",
"author": "jarv",
"comment_id": null,
"datetime": 1479331500000,
"masked_author": "username_0",
"text": "I'm sharing some code between several lambda functions. Instead of creating a module and installing it in each `_src` directory I am finding it easier to symlink to the common code like so:\r\n\r\n```\r\nfunc1/_src/common -> ../../common\r\nfunc2/_src/common -> ../../common\r\n```\r\n\r\nIn order to make this work for the zipfile creation I need to change `os.walk(lambda_dir)` to `os.walk(lambda_dir, followlinks=True)` in `function.py`.\r\n\r\nWould you open open to a PR to make this configurable or is there a better way to share code between lambda functions?",
"title": "Following symlinks",
"type": "issue"
},
{
"action": "created",
"author": "josegonzalez",
"comment_id": 261379138,
"datetime": 1479419039000,
"masked_author": "username_1",
"text": "Sure go for it.",
"title": null,
"type": "comment"
}
] | 563 | false | false | 2 | 2 | false |
ocombe/ocLazyLoad | null | 175,082,303 | 345 | null | [
{
"action": "opened",
"author": "liasrose",
"comment_id": null,
"datetime": 1473085544000,
"masked_author": "username_0",
"text": "Hi everyone,\r\n\r\nwhile implementing oclazyload to the component router tutorial [https://docs.angularjs.org/guide/component-router](url), I came across the following problem:\r\n\r\n`this.gotoHeroes = function () {\r\nvar heroId = this.hero && this.hero.id;\r\n this.$router.navigate(['HeroList', {id: heroId}]);};`\r\n\r\n(this is a function for a Button that simply goes back in the path)\r\n\r\nproduces the Error: angular.js:13236 TypeError: Cannot read property 'navigate' of undefined\r\n\r\nDebugging showed that the router is the same router as in the app.js / hero.component, but it seems like it can't fall back to the path it knew before. What is interessting, since it worked perfectly without implementing lazy loading. \r\nIs there any coincidence?\r\n\r\nBest regards\r\nusername_0",
"title": "Going back in the path doesn't work with oclazyload?",
"type": "issue"
},
{
"action": "created",
"author": "djKooks",
"comment_id": 244862015,
"datetime": 1473143781000,
"masked_author": "username_1",
"text": "@username_0 it is hard to know with this information because there are no comment about how lazy load has been implemented on your code. Could you show us more detail?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liasrose",
"comment_id": 244883563,
"datetime": 1473150443000,
"masked_author": "username_0",
"text": "I implemented lazy loading like this in the app.js:\r\n\r\n`(function () {\r\n var app = angular.module('app', ['oc.lazyLoad', 'ngComponentRouter']);\r\n\r\n app.config(function ($locationProvider) {\r\n $locationProvider.html5Mode(true);\r\n });\r\n\r\n app.value('$routerRootComponent', 'app');\r\n\r\n\r\n app.component('app', {\r\n template: [\r\n '<a ng-link=\"[\\'Home\\']\">Home</a> |',\r\n '<a ng-link=\"[\\'Heroes\\']\">Heroes</a> |',\r\n '<a ng-link=\"[\\'CrisisCenter\\']\">Crisis Center</a>',\r\n '<hr>',\r\n '<ng-outlet></ng-outlet>'\r\n ].join('\\n'),\r\n controller: ['$router', '$ocLazyLoad', function ($router, $ocLazyLoad) {\r\n $router.config([\r\n {path: '/', name: 'Home', component: 'home', usaAsDefault: true},\r\n\r\n //Heroes Route\r\n {\r\n path: '/heroes/...',\r\n name: 'Heroes',\r\n loader: function () {\r\n // lazy load Heroes\r\n return $ocLazyLoad.load('/heroes/heroes.js')\r\n .then(function () {\r\n return 'heroes';\r\n });\r\n }\r\n },`\r\n\r\nLazy loading functions perfect, also loading to the \"subroute\", the heroList and heroDetail (both components of heroes, in this example everything is in one file)\r\n\r\n`$routeConfig: [\r\n {path: '/', name: 'HeroList', component: 'heroList', useAsDefault: true},\r\n {path: '/:id', name: 'HeroDetail', component: 'heroDetail'}\r\n ]`\r\n\r\nthe only thing that isn't working, is going back from HeroDetail to HeroList via the router (see code in my first comment above). I can also go back just using window.history.back(), so there is no urgent help needed, I was just curious why its not working anymore after implementing lazyloading.\r\n\r\nBest regards\r\nusername_0",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "djKooks",
"comment_id": 246238895,
"datetime": 1473653124000,
"masked_author": "username_1",
"text": "@username_0 I am implementing this based on ui-router. It also does not load again when it moves to parent path because it is already loaded. Is your router correctly setup 'HeroList' and 'HeroDetail' as parent-children relation? \r\nI will try on ngComponentRouter too to see this goes well.",
"title": null,
"type": "comment"
}
] | 3,156 | false | false | 2 | 4 | true |
wangding/SeleniumIDEDoc | null | 190,270,824 | 7 | null | [
{
"action": "opened",
"author": "gaomengyao",
"comment_id": null,
"datetime": 1479460709000,
"masked_author": "username_0",
"text": "制作测试案例--录制：你会经常需要把 click 命令改为 # clickAndWait，来确保您的测试用例（**不**）会暂停，直到新页面加载完成。",
"title": "【bug】表达错误",
"type": "issue"
},
{
"action": "created",
"author": "wangding",
"comment_id": 261502301,
"datetime": 1479465834000,
"masked_author": "username_1",
"text": "原文是什么？修改的结果是什么呢？",
"title": null,
"type": "comment"
}
] | 91 | false | false | 2 | 2 | false |
cmgmyr/laravel-messenger | null | 190,280,554 | 180 | null | [
{
"action": "opened",
"author": "jrleonr",
"comment_id": null,
"datetime": 1479463559000,
"masked_author": "username_0",
"text": "In the MessageControllers we have this:\r\n\r\n```php\r\n// show current user in list if not a current participant\r\n// $users = User::whereNotIn('id', $thread->participantsUserIds())->get();\r\n\r\n// don't show the current user in list\r\n$userId = Auth::user()->id;\r\n$users = User::whereNotIn('id', $thread->participantsUserIds($userId))->get();\r\n```\r\n\r\nThat will show all the users in the database except those on the participants table. This confuse me a bit. How do you don't show yourself in the participants list, if when you send your id, it's added twice. Something is not completely right but don't know what!! is the example not updated or the code itself?\r\n\r\nThanks!",
"title": "Removing and showing participants list",
"type": "issue"
},
{
"action": "created",
"author": "cmgmyr",
"comment_id": 266117819,
"datetime": 1481316102000,
"masked_author": "username_1",
"text": "Hi @username_0,\r\nIf you take a look at the `update` method on the controller you'll see:\r\n\r\n```php\r\n$participant = Participant::firstOrCreate(\r\n [\r\n 'thread_id' => $thread->id,\r\n 'user_id' => Auth::user()->id,\r\n ]\r\n);\r\n$participant->last_read = new Carbon;\r\n$participant->save();\r\n```\r\n\r\nThe `firstOrCreate` will just grab the current user as a participant, if the current user is a new participant, then it will get added. It will not be duplicated in the database. Make sense? Feel free to reply to this thread if you have any more questions.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "cmgmyr",
"comment_id": null,
"datetime": 1481316102000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 1,229 | false | false | 2 | 3 | true |
Ayuget/Redface | null | 168,520,488 | 149 | null | [
{
"action": "opened",
"author": "Ayuget",
"comment_id": null,
"datetime": 1469975536000,
"masked_author": "username_0",
"text": "depuis le dernière version, quand on est dans un sujet et qu'on rafraîchit ça ne rafraîchit que la page en cours. \nSi une nouvelle page est apparue on ne le sait pas.\n\n \n\nObligé de revenir à la liste des sujets et de la rafraîchir pour que la nouvelle page soit disponible",
"title": "Nouvelles pages non détectées lors d'un rafraîchissement",
"type": "issue"
},
{
"action": "created",
"author": "nbonnec",
"comment_id": 243831438,
"datetime": 1472663041000,
"masked_author": "username_1",
"text": "Le problème vient de là : https://github.com/username_0/Redface/blob/master/app/src/main/java/com/ayuget/redface/ui/fragment/TopicFragment.java#L327-L333\r\n\r\nLe soft considère que ce n'est pas le même topic.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ayuget",
"comment_id": 246135182,
"datetime": 1473538613000,
"masked_author": "username_0",
"text": "Ouep bien vu !\n\nBizarre je n'ai plus les notifications lors de tes commentaires sur les issues, désolé du délai de réponse :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nbonnec",
"comment_id": 247078611,
"datetime": 1473871829000,
"masked_author": "username_1",
"text": "Oui c'est bien ce que je me disais, pas de problèmes :D",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Ayuget",
"comment_id": null,
"datetime": 1476431965000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 654 | false | false | 2 | 5 | true |
pycontribs/jenkinsapi | pycontribs | 227,656,206 | 551 | null | [
{
"action": "opened",
"author": "tuukkamustonen",
"comment_id": null,
"datetime": 1494417660000,
"masked_author": "username_0",
"text": "##### ISSUE TYPE\r\n\r\nFeature Idea\r\n\r\n##### SUMMARY\r\n\r\nI need to use both `KrbRequester` and `CrumbRequester` at the same time, and current implementation doesn't support that.\r\n\r\nSo, I need to create a class that combines features from both. Something else would be nice, but I don't have suggestion how to implement it, really. The maintainer(s) are probably already aware of this issue, and have some idea?",
"title": "Allow using multiple requesters at the same time",
"type": "issue"
},
{
"action": "created",
"author": "lechat",
"comment_id": 312673706,
"datetime": 1499095165000,
"masked_author": "username_1",
"text": "I am, maintainer, not using Kerberos and not using crumbs, so I have no place to test such requester... Please submit pull request for your combined class, we will review code and accept it.",
"title": null,
"type": "comment"
}
] | 597 | false | true | 2 | 2 | false |
dart-lang/pub-dartlang-dart | dart-lang | 275,994,246 | 620 | null | [
{
"action": "opened",
"author": "mit-mit",
"comment_id": null,
"datetime": 1511342241000,
"masked_author": "username_0",
"text": "The individual package pages show a tag for the package type, e.g. 'FLUTTER' here:\r\nhttps://pub.dartlang.org/experimental/packages/url_launcher#-readme-tab-\r\n\r\nFor flutter packages this currently links to https://pub.dartlang.org/flutter/packages. I think it should link to https://pub.dartlang.org/experimental/flutter.",
"title": "Flutter tag links to incorrect page",
"type": "issue"
},
{
"action": "created",
"author": "mit-mit",
"comment_id": 346289985,
"datetime": 1511342250000,
"masked_author": "username_0",
"text": "cc @username_1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "isoos",
"comment_id": 346295662,
"datetime": 1511343561000,
"masked_author": "username_1",
"text": "This is fixed in code, but not deployed yet.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mit-mit",
"comment_id": 346298769,
"datetime": 1511344236000,
"masked_author": "username_0",
"text": "Great, thanks",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kevmoo",
"comment_id": 346494755,
"datetime": 1511391287000,
"masked_author": "username_2",
"text": "Deployed!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "kevmoo",
"comment_id": null,
"datetime": 1511391288000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 395 | false | false | 3 | 6 | true |
SumoLogic/elasticsearch-client | SumoLogic | 210,286,519 | 105 | null | [
{
"action": "opened",
"author": "logicbomb",
"comment_id": null,
"datetime": 1488086317000,
"masked_author": "username_0",
"text": "You should include the supported elastic search version numbers to the readme file. I spent too much time on this only to find it doesn't support the version of ES I'm using.",
"title": "Add supported ES version to readme",
"type": "issue"
},
{
"action": "created",
"author": "rcoh",
"comment_id": 282541804,
"datetime": 1488098741000,
"masked_author": "username_1",
"text": "Good point, sorry about that. I've updated the README",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "rcoh",
"comment_id": null,
"datetime": 1488098742000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 228 | false | false | 2 | 3 | false |
sindresorhus/file-type | null | 115,700,268 | 41 | {
"number": 41,
"repo": "file-type",
"user_login": "sindresorhus"
} | [
{
"action": "opened",
"author": "alexanderlperez",
"comment_id": null,
"datetime": 1446939921000,
"masked_author": "username_0",
"text": "Types added: xpi, cab, deb, ar, tz, tlz",
"title": "Added handful of compressed file types",
"type": "issue"
},
{
"action": "created",
"author": "sindresorhus",
"comment_id": 154801312,
"datetime": 1446978529000,
"masked_author": "username_1",
"text": "Thanks :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexanderlperez",
"comment_id": 154887204,
"datetime": 1447026274000,
"masked_author": "username_0",
"text": "Love what you do, totally welcome. #22",
"title": null,
"type": "comment"
}
] | 87 | false | false | 2 | 3 | false |
NuGetPackageExplorer/NuGetPackageExplorer | NuGetPackageExplorer | 251,547,554 | 222 | null | [
{
"action": "opened",
"author": "bouyeijiang",
"comment_id": null,
"datetime": 1503289944000,
"masked_author": "username_0",
"text": "Hi! Thanks for reporting this feature/bug/question! \r\n\r\nPlease keep / fill in the relevant info from this template so that we can help you as best as possible.\r\n\r\n**Type** (choose one):\r\n\r\n- Bug\r\n- Feature request\r\n- Question\r\n\r\n**NPE version**: (e.g. 3.12) (see Help -> about)\r\n\r\n**Installed from**: ClickOnce / chocolatey.org / Zip on CodePlex / Windows Store\r\n\r\nIn case of a BUG:\r\n\r\n- What is the current result?\r\n- What is the expected result?\r\n- Please post full exception details in case of an Exception (message, stacktrace, inner exceptions)\r\n- Are there any work arrounds? yes/no\r\n- Is there a version in which it did worked? \r\n- Is there a package on Nuget.org which shows the bug?\r\n\r\nin case of a FEATURE REQUEST:\r\n \r\n - Why do we need it?\r\n - Please provide an use case.",
"title": "can't push package",
"type": "issue"
},
{
"action": "closed",
"author": "bouyeijiang",
"comment_id": null,
"datetime": 1503290845000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "reopened",
"author": "bouyeijiang",
"comment_id": null,
"datetime": 1503290927000,
"masked_author": "username_0",
"text": "Hi! Thanks for reporting this feature/bug/question! \r\n\r\nPlease keep / fill in the relevant info from this template so that we can help you as best as possible.\r\n\r\n**Type** (choose one):\r\n\r\n- Bug\r\n- Feature request\r\n- Question\r\n\r\n**NPE version**: (e.g. 3.12) (see Help -> about)\r\n\r\n**Installed from**: ClickOnce / chocolatey.org / Zip on CodePlex / Windows Store\r\n\r\nIn case of a BUG:\r\n\r\n- What is the current result?\r\n- What is the expected result?\r\n- Please post full exception details in case of an Exception (message, stacktrace, inner exceptions)\r\n- Are there any work arrounds? yes/no\r\n- Is there a version in which it did worked? \r\n- Is there a package on Nuget.org which shows the bug?\r\n\r\nin case of a FEATURE REQUEST:\r\n \r\n - Why do we need it?\r\n - Please provide an use case.",
"title": "how to i remove packages from version?",
"type": "issue"
},
{
"action": "created",
"author": "tiesont",
"comment_id": 323650289,
"datetime": 1503293657000,
"masked_author": "username_1",
"text": "It would help if you actually filled in the issue template. It's not exactly clear what you are asking.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "304NotModified",
"comment_id": 333814170,
"datetime": 1507030134000,
"masked_author": "username_2",
"text": "Closing for now, will reopen if the provided info is provided",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "304NotModified",
"comment_id": null,
"datetime": 1507030136000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 1,728 | false | false | 3 | 6 | false |
mozilla/pdf.js | mozilla | 187,738,227 | 7,788 | null | [
{
"action": "opened",
"author": "rkni9ht",
"comment_id": null,
"datetime": 1478531862000,
"masked_author": "username_0",
"text": "Link to PDF file (or attach file here):\r\n[font-bug.pdf](https://github.com/mozilla/pdf.js/files/575695/font-bug.pdf)\r\nTried with multiple files, writing number in bottom right corner with reportlab in python using following code:\r\n```\r\nc.setFillColorRGB(255, 0, 0)\r\nc.setFont(\"Helvetica\", 12)\r\nc.drawString(width - 50, 10, text)\r\n```\r\n\r\nConfiguration:\r\n- Web browser and its version: Firefox 49.0.2\r\n\r\nSteps to reproduce the problem:\r\n1. open the pdf file in the browser\r\n\r\nWhat is the expected behavior? (add screenshot)\r\nExpected to see bates number in bottom right. \r\n\r\n\r\nWhat went wrong? (add screenshot)\r\nIt doesn't load the text and prints to console:\r\n```\r\nWarning: fontRef not availablepdf.worker.js:2298:5\r\nWarning: Error during font loading: Font F1 is not availablepdf.js:277:5\r\nWarning: fontRef not available\r\n```",
"title": "fontRef Error when drawing string with ReportLab",
"type": "issue"
},
{
"action": "created",
"author": "timvandermeij",
"comment_id": 766094259,
"datetime": 1611414826000,
"masked_author": "username_1",
"text": "Closing since this one is fixed now.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "timvandermeij",
"comment_id": null,
"datetime": 1611414826000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 974 | false | false | 2 | 3 | false |
urbit/docs | urbit | 263,636,603 | 208 | null | [
{
"action": "opened",
"author": "joshuareagan",
"comment_id": null,
"datetime": 1507377358000,
"masked_author": "username_0",
"text": "\"A Hoon expression is called a twig. A twig is an AST node: the noun that the Hoon compiler makes when it parses a source expression.\"\r\n\r\nThis quotation is from twig.md. It's really puzzling. On the one hand, a \"twig\" is a Hoon expression, and Hoon expressions live in the source file. On the other hand, a \"twig\" is a node in a noun produced by the Hoon compiler when it's fed a source file.\r\n\r\nI object to using the same word for both the input and the output of the compiler. Basically I'm following up on @belisarius222 's point in this thread:\r\n\r\nhttps://github.com/urbit/docs/pull/205#issuecomment-334600935\r\n\r\nIf we want to talk about what the compiler does, even in this document, that's fine. I'm sure we could work out something that could be quite helpful. (I want to learn more about the compiler!) But we need to clarify our concepts because this sort of ambiguity leads to a lot of \"double vision\" for beginners. (\"Does term X mean y or z? Or is Urbit somehow so radical that y = z?\")\r\n\r\nI'm calling for a decision about what to do with the word \"twig\". It seems like its true definition is the latter one: it's an AST node in a noun produced by the compiler. The word \"expression\" is well-worn but perfectly fine for describing the things we have in source files.\r\n\r\nOf course I may be confused, in which case I'm happy to be corrected.\r\n\r\nI recommend other ambiguities be noted in this issue, if there are any.",
"title": "Documentation ambiguity",
"type": "issue"
},
{
"action": "closed",
"author": "joshuareagan",
"comment_id": null,
"datetime": 1507398560000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "reopened",
"author": "joshuareagan",
"comment_id": null,
"datetime": 1507398566000,
"masked_author": "username_0",
"text": "\"A Hoon expression is called a twig. A twig is an AST node: the noun that the Hoon compiler makes when it parses a source expression.\"\r\n\r\nThis quotation is from twig.md. It's really puzzling. On the one hand, a \"twig\" is a Hoon expression, and Hoon expressions live in the source file. On the other hand, a \"twig\" is a node in a noun produced by the Hoon compiler when it's fed a source file.\r\n\r\nI object to using the same word for both the input and the output of the compiler. Basically I'm following up on @belisarius222 's point in this thread:\r\n\r\nhttps://github.com/urbit/docs/pull/205#issuecomment-334600935\r\n\r\nIf we want to talk about what the compiler does, even in this document, that's fine. I'm sure we could work out something that could be quite helpful. (I want to learn more about the compiler!) But we need to clarify our concepts because this sort of ambiguity leads to a lot of \"double vision\" for beginners. (\"Does term X mean y or z? Or is Urbit somehow so radical that y = z?\")\r\n\r\nI'm calling for a decision about what to do with the word \"twig\". It seems like its true definition is the latter one: it's an AST node in a noun produced by the compiler. The word \"expression\" is well-worn but perfectly fine for describing the things we have in source files.\r\n\r\nOf course I may be confused, in which case I'm happy to be corrected.\r\n\r\nI recommend other ambiguities be noted in this issue, if there are any.",
"title": "Documentation ambiguity",
"type": "issue"
},
{
"action": "created",
"author": "cgyarvin",
"comment_id": 334954374,
"datetime": 1507398956000,
"masked_author": "username_1",
"text": "Yes, “expression” for source and “twig” for node are fine.\n\nSent from my iPhone\n\n>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joshuareagan",
"comment_id": 334978828,
"datetime": 1507430418000,
"masked_author": "username_0",
"text": "Huh, that was easy...\r\n\r\nNext question: upon making the change above, how to clarify the names of sub-expressions? Some runes have certain sub-expressions that must evaluate to molds; the rest can evaluate to anything. The current docs call the former \"moss\" and the latter \"seed\". These are also said to be aliases for \"twigs\". In hoon.hoon it looks like everything is just called a \"twig\", so \"moss\" and \"seed\" seem to be docs-only vocabulary. Right now they're treated in a weird way in the rune docs, like aliases of ++twig mold within hoon.hoon. Of course they aren't really, so we're free to reserve these concepts for just the subexpressions if we want to.\r\n\r\nI'm not really sure how much is gained by these names. Is there a possibility of conserving some weirdness points by eliminating them? It seems simpler and clearer to call normal sub-expressions (which can be anything) either just \"subexpressions\" or \"expression child/children\". Perhaps a special name is warranted for children that must evaluate to molds, in which case inertia and tradition may suffice for keeping the name \"moss\". But it's not a particularly intuitive name...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joshuareagan",
"comment_id": 334979795,
"datetime": 1507432222000,
"masked_author": "username_0",
"text": "Or maybe we can speak in terms of \"moldy\" and \"woody\" subexpressions, dropping \"moss\" and \"seed\"...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joshuareagan",
"comment_id": 334979817,
"datetime": 1507432257000,
"masked_author": "username_0",
"text": "I think my preference is simply to say \"subexpression\" but call the special ones \"moldy\".",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cgyarvin",
"comment_id": 334979997,
"datetime": 1507432603000,
"masked_author": "username_1",
"text": "I have a better idea: “value” and “pattern” modes.\n\nWe’ve essentially gone from one mode and two syntaxes, to two modes (parsing contexts) and one syntax.\n\nSent from my iPhone\n\n>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joshuareagan",
"comment_id": 334980157,
"datetime": 1507432856000,
"masked_author": "username_0",
"text": "\"value\" and \"pattern\" sound good. What do you mean by \"mode\"?\r\n\r\n\"The regular, tall form of a `?:` Hoon expression start with the rune `?:` followed by a `gap`, and then three \"value\" ____s, each of which is separated from its neighbors by a `gap`.\"\r\n\r\nWe can fill in the blank with \"subexpression\" but maybe that's a mouthful.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joshuareagan",
"comment_id": 334980211,
"datetime": 1507432940000,
"masked_author": "username_0",
"text": "Wait, I understand \"mode\" now. Sorry about the delay.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joshuareagan",
"comment_id": 335414229,
"datetime": 1507627433000,
"masked_author": "username_0",
"text": "Just to make sure I understand the proposal: \"We have but one syntax, and two modes for parsing it. The value mode happens when the compiler takes the source and makes an AST of tagged unions. The pattern mode happens when the AST is parsed thereafter...\"\r\n\r\nI hate to play the same note over and over, but I'm not sure \"one syntax, two modes\" is the right way to go. Because, strictly speaking, there really *isn't* one syntax. The source file has `gap`s between subexpressions, and the AST product of the compiler doesn't. This probably sounds pedantic, but it really isn't. Of course there is an extremely tight semantic relationship between the two \"modes\", but mixing semantics and syntax in the documentation seems like a bad idea. We're giving people a brand new network of concepts, which means they can't lean as heavily on experience and intuition to figure out what we're saying. We have to make up for it by being really clear and precise in the docs.\r\n\r\nSyntax is about the physically detectable symbols in front of the coder. We should stick to that.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joshuareagan",
"comment_id": 350544485,
"datetime": 1512908501000,
"masked_author": "username_0",
"text": "I deleted my old comments which were basically misunderstandings. I like the value/pattern distinction for expressions. With latest updates to Hoon and upcoming doc revisions, I'm happy.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "joshuareagan",
"comment_id": null,
"datetime": 1512908502000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 6,122 | false | false | 2 | 13 | false |
swagger-api/swagger-codegen | swagger-api | 196,976,304 | 4,446 | null | [
{
"action": "opened",
"author": "gdurand",
"comment_id": null,
"datetime": 1482337953000,
"masked_author": "username_0",
"text": "##### Description\r\n\r\nIn a Model class constructor, if a parameter of type enum is optional, it is defaulted to null, which is illegal for enums.\r\n\r\n##### Swagger-codegen version\r\n\r\nmaster\r\n\r\n##### Suggest a Fix\r\n\r\nPerhaps default it to 0, but it is a valid enum value so it's no better, unless enums are generated starting with value 1.",
"title": "[csharp] Optional enum parameters in method declarations should not be = null",
"type": "issue"
},
{
"action": "created",
"author": "jimschubert",
"comment_id": 269262694,
"datetime": 1482808005000,
"masked_author": "username_1",
"text": "This should already be addressed and fixed by #4145. @username_0 would you want to test my PR against your expectations?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gdurand",
"comment_id": 270079104,
"datetime": 1483436865000,
"masked_author": "username_0",
"text": "Your PR fixes the compilation issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "wing328",
"comment_id": 270086757,
"datetime": 1483439547000,
"masked_author": "username_2",
"text": "@username_0 thanks for testing the PR, which has been merged into master.\r\n\r\nThanks @username_1 for the fix.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "wing328",
"comment_id": null,
"datetime": 1483441658000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 595 | false | false | 3 | 5 | true |
tompave/fun_with_flags_ui | null | 238,513,657 | 1 | {
"number": 1,
"repo": "fun_with_flags_ui",
"user_login": "tompave"
} | [
{
"action": "opened",
"author": "Gazler",
"comment_id": null,
"datetime": 1498476355000,
"masked_author": "username_0",
"text": "Instead of having actors displayed in the format:\r\n\r\n * user:1\r\n * user:2\r\n * user:404\r\n * country:uk\r\n\r\nAliases allow a function to be called with the flag, which could fetch\r\nthe users names from the database and transform them into:\r\n\r\n * User Name 1\r\n * User Name 2\r\n * user:404\r\n * United Kingdom\r\n\r\nThis is achieved with the following (optional) config:\r\n\r\n config :fun_with_flags_ui, :flag_page,\r\n alias_fn: &MyApp.Feature.flag_alias/1\r\n\r\nThe function expects a `%FunWithFlags.Flag{}` struct, and returns a\r\n`%FunWithFlags.Flag{}` struct.\r\n\r\nAn example (inefficient) implementation of the\r\n`MyApp.Feature.flag_alias/1` function could be:\r\n\r\n def flag_alias(flag) do\r\n gates = Enum.map(flag.gates, &get_gate_aliases/1)\r\n %{flag | gates: gates}\r\n end\r\n\r\n defp get_gate_aliases(%{for: \"user:\" <> id} = gate) do\r\n case MyApp.Repo.get(MyApp.User, id) do\r\n nil -> gate\r\n user -> %{gate | for: {\"account:\" <> id, user.name}}\r\n end\r\n end\r\n defp get_gate_aliases(%{for: \"country:uk\"} = gate) do\r\n %{gate | for: {\"country:uk\", \"United Kingdom\"}}\r\n end\r\n defp get_gate_aliases(gate), do: gate\r\n\r\nIf the `for` is a 2-tuple, in the format `{:id, :display_name}` then the\r\n`:id` will be used for all form actions (such as enable/disable) and the\r\n`:display_name` field will be used when actually displaying the actor\r\nrow.\r\n\r\nI chose to use a 2-tuple as it doesn't require any modification of the existing structs. One downside is that it does violate the typespec at https://github.com/username_1/fun_with_flags/blob/master/lib/fun_with_flags/gate.ex#L6",
"title": "Allow aliases for actors on the flag page",
"type": "issue"
},
{
"action": "created",
"author": "tompave",
"comment_id": 311223813,
"datetime": 1498525599000,
"masked_author": "username_1",
"text": "Hello, and thank you for the PR!\r\n\r\nI understand the feature, but I'm not too sure about including it into the library.\r\n\r\nFeature toggles are mainly a tool for developers, and creating flags and gates – programmatically or through the web GUI – requires to know about the expected structure of actor IDs and which flag names will be referenced in code. Since users of the dashboard need to _think_ about the actual underlying IDs, I fear that displaying actors with prettified labels instead of the actual values would create confusion.\r\n\r\nThis is especially important because creating new actors will still require to enter the _actual ID values_ in the form input. Requiring to input values with a certain format and then displaying the same saved values with a different format would makes the UI harder to understand. Displaying the actual IDs serves also the purpose of providing examples of which kind of values are valid and already in use, which would be lost with this change.\r\n\r\nAlso, the actor ID formats are really up to the applications, so I'm not even sure about the default implementation for `alias_fn`. I used a colon in the examples because it's a common separator, but `user(52)`, `user-42` or even `userI_AM_BATMAN42` are all as valid formats as `user:42`.\r\n\r\nIn light of the above, I would discourage the introduction of this change.\r\n----\r\n\r\nIf you want to keep pursuing this functionality in you fork, however, I have a few recommendations:\r\n\r\n1. maybe display the prettified alias, but do so in a new column and keep the raw values in the screen.\r\n2. at the moment this PR is changing the internal shape of `%Flag{}` and `%Gate{}` structs when they're loaded, with the consequence that the rest of the library needs to be aware that they could be either vanilla structs or transformed structs. This is less than ideal because those structs are private (nothing outside `FunWithFlags` should modify them), and the rest of the library should safely rely on them having a certain structure. The proof that is makes things more complicated is that you had to sprinkle extra functions here and there to handle the potentially different structs. What if instead you leave everything as it is, and just add a `generate_label(gate)` function to be invoked only when you need to display the alias?\r\n3. doing what I suggested in the previous point also protect you from further changes in this library, to some extent. Try to keep the coupling to the internal details to a minimum.\r\n4. It might be easier to just use a `fn` instead of a `{Module, :function}` tuple. As long as the arity it fixed, it's more portable.\r\n\r\nI hope it makes sense!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Gazler",
"comment_id": 311278498,
"datetime": 1498549090000,
"masked_author": "username_0",
"text": "This works fine when using Mix, but doesn't work with a release, the reference to the function will cause a syntax error in sys.config.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tompave",
"comment_id": 311287631,
"datetime": 1498551557000,
"masked_author": "username_1",
"text": "I understand, but that then requires the developer to write a good aggregate query instead of an inefficient one.",
"title": null,
"type": "comment"
}
] | 4,518 | false | false | 2 | 4 | true |
RubyMoney/money-rails | RubyMoney | 216,842,678 | 477 | null | [
{
"action": "opened",
"author": "vikks",
"comment_id": null,
"datetime": 1490373878000,
"masked_author": "username_0",
"text": "",
"title": "unknown attribute error when used with jsonb attributes",
"type": "issue"
},
{
"action": "created",
"author": "antstorm",
"comment_id": 289125834,
"datetime": 1490384790000,
"masked_author": "username_1",
"text": "@username_0 can you point to the file/line that throws the error?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vikks",
"comment_id": 289182073,
"datetime": 1490408635000,
"masked_author": "username_0",
"text": "##### StackTrace\r\n\r\n```ruby\r\n (0.2ms) BEGIN\r\n (0.1ms) ROLLBACK\r\nCompleted 500 Internal Server Error in 66ms (ActiveRecord: 10.8ms)\r\n\r\nActiveModel::MissingAttributeError (can't write unknown attribute `price_fils`):\r\n \r\napp/controllers/products_controller.rb:32:in `update'\r\n Rendering /Users/vikas/.rvm/gems/ruby-2.3.0/gems/actionpack-5.0.1/lib/action_dispatch/middleware/templates/rescues/diagnostics.html.erb within rescues/layout\r\n Rendering /Users/vikas/.rvm/gems/ruby-2.3.0/gems/actionpack-5.0.1/lib/action_dispatch/middleware/templates/rescues/_source.html.erb\r\n(...)\r\n```\r\n##### in products_controller.rb\r\n\r\n```ruby\r\ndef update \r\n @product = Product.find params[:id]\r\n @product.update product_params\r\nend\r\n\r\n# params = {\"product\"=>{\"price\"=>\"100\"}, \"commit\"=>\"Update\", \"id\"=>\"13\"}\r\ndef product_params\r\n params.require(:product).permit!\r\nend\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "antstorm",
"comment_id": 289268869,
"datetime": 1490520806000,
"masked_author": "username_1",
"text": "@username_0 thanks, I'll have a closer look",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "antstorm",
"comment_id": 291119727,
"datetime": 1491219845000,
"masked_author": "username_1",
"text": "@username_0 it seems like this behaviour is not supported, because `money-rails` uses `write_attribute` when modifying values (not the setter). You can still use the gem, but you'll need to modify your setter to something like:\r\n\r\n```ruby\r\ndef price=(new_value)\r\n properties[:price_cents] = Money.new(new_value).fractional\r\nend\r\n```\r\n\r\nHope that helps.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "swrobel",
"comment_id": 363288076,
"datetime": 1517883405000,
"masked_author": "username_2",
"text": "Alternatively, it seems you can do the following:\r\n\r\n```ruby\r\nclass Product < ApplicationRecord\r\n # properties is a jsonb column in postgreql\r\n store_accessor :properties, :price_cents\r\n monetize :price_cents, disable_validation: true\r\n validates :price, money: { greater_than_or_equal_to: 0 }\r\nend\r\n```\r\n\r\nSince bizarrely, the subunit (_cents column) setter is only overwritten with `write_attribute` [when validations are enabled](https://github.com/RubyMoney/money-rails/blob/v1.10.0/lib/money-rails/active_record/monetizable.rb#L130).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "antstorm",
"comment_id": 363899090,
"datetime": 1518035141000,
"masked_author": "username_1",
"text": "@username_2 good point, I guess we can override it anyways",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "semmons99",
"comment_id": null,
"datetime": 1614549795000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 1,910 | false | false | 4 | 8 | true |
rhblind/django-gcharts | null | 107,267,042 | 11 | null | [
{
"action": "opened",
"author": "flurischt",
"comment_id": null,
"datetime": 1442606091000,
"masked_author": "username_0",
"text": "I'm currently on 1.7. Running ```manage.py check``` yields the following warning:\r\n```\r\n(vipris)~/D/g/z ❯❯❯ python manage.py check \r\n../venv/lib/python2.7/site-packages/gcharts/__init__.py:42: RemovedInDjango18Warning: `GChartsManager.get_query_set` method should be renamed `get_queryset`.\r\n```",
"title": "Django 1.8 compatibility - get_query_set should be renamed",
"type": "issue"
},
{
"action": "created",
"author": "rhblind",
"comment_id": 141555632,
"datetime": 1442607440000,
"masked_author": "username_1",
"text": "Hi, thanks for reporting.\r\nThis library is in desperate need for some care and love, and I have it on my list. I'll try to make some time for updating to 1.8 compatibility and hopefully python 3.x as well.",
"title": null,
"type": "comment"
}
] | 500 | false | false | 2 | 2 | false |
pingcap/tidb | pingcap | 147,716,572 | 1,088 | {
"number": 1088,
"repo": "tidb",
"user_login": "pingcap"
} | [
{
"action": "opened",
"author": "zimulala",
"comment_id": null,
"datetime": 1460460244000,
"masked_author": "username_0",
"text": "fix issue #1071",
"title": "*: Fix issue #1071",
"type": "issue"
},
{
"action": "created",
"author": "coocood",
"comment_id": 209805298,
"datetime": 1460619092000,
"masked_author": "username_1",
"text": "LGTM",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shenli",
"comment_id": 209835095,
"datetime": 1460624026000,
"masked_author": "username_2",
"text": "LGTM",
"title": null,
"type": "comment"
}
] | 23 | false | false | 3 | 3 | false |
shivamdixit/WebGoatPHP | null | 169,466,116 | 47 | null | [
{
"action": "opened",
"author": "nhajiyani",
"comment_id": null,
"datetime": 1470342487000,
"masked_author": "username_0",
"text": "Hi,\r\nThis is not an issue per se with your repo, I am wondering whats happening with the webgoat project now that it is down.\r\n\r\nThanks.",
"title": "http://webgoatphp.com/ is down",
"type": "issue"
},
{
"action": "created",
"author": "abiusx",
"comment_id": 237675818,
"datetime": 1470343044000,
"masked_author": "username_1",
"text": "Hmm…\nI hosted the website personally. Now that I’m no longer partaking in OWASP, we need volunteers to do that.\n-A\n\n>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shivamdixit",
"comment_id": 242309088,
"datetime": 1472111862000,
"masked_author": "username_2",
"text": "Hi @username_0,\r\n\r\nWe will be bringing the website back up soon. You need to host the application locally till then. \r\n\r\nThanks!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "shivamdixit",
"comment_id": null,
"datetime": 1472111871000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 380 | false | false | 3 | 4 | true |
opencv/opencv | opencv | 126,731,096 | 5,972 | {
"number": 5972,
"repo": "opencv",
"user_login": "opencv"
} | [
{
"action": "opened",
"author": "varunagrawal",
"comment_id": null,
"datetime": 1452800227000,
"masked_author": "username_0",
"text": "When the ChamferMatcher object is deconstructed, it tries deleting the templates attached to it during the `matching` function. The templates are already deleted by the Template deconstructor though, and thus an error. Hence I have commented out the delete operation in the Template deconstructor.",
"title": "Fix for missing templates when ChamferMatcher is deconstructed.",
"type": "issue"
},
{
"action": "created",
"author": "mshabunin",
"comment_id": 231404469,
"datetime": 1467994910000,
"masked_author": "username_1",
"text": "@username_0 , this solution can not be accepted because it will create memory leak. The `Matching` class creates templates in the `addTemplateFromImage` method and since it owns them - it should delete them. More code should be rewritten to correctly handle memory allocations in this algorithm.\r\n\r\nIf you have an advanced fix please create new PR, because this one is broken.",
"title": null,
"type": "comment"
}
] | 675 | false | false | 2 | 2 | true |
ManageIQ/manageiq | ManageIQ | 65,214,601 | 2,426 | {
"number": 2426,
"repo": "manageiq",
"user_login": "ManageIQ"
} | [
{
"action": "opened",
"author": "romanblanco",
"comment_id": null,
"datetime": 1427722740000,
"masked_author": "username_0",
"text": "Parent issue: #2389\r\nShould be reviewed after #2425 got merged",
"title": "Added missing semicolons, var's; using dot notation",
"type": "issue"
},
{
"action": "created",
"author": "martinpovolny",
"comment_id": 95582976,
"datetime": 1429795568000,
"masked_author": "username_1",
"text": "No further notes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "martinpovolny",
"comment_id": 96656890,
"datetime": 1430142324000,
"masked_author": "username_1",
"text": "@username_0 : great, thx for the re-checking. I'd merge this right after we for a branch for the release.",
"title": null,
"type": "comment"
}
] | 185 | false | true | 2 | 3 | true |
calcinai/xero-php | null | 104,439,029 | 86 | null | [
{
"action": "opened",
"author": "FLamparski",
"comment_id": null,
"datetime": 1441186466000,
"masked_author": "username_0",
"text": "We all know that reading the source code is the best way to learn about a particular system, and the code is quite readable. However I think many developers would appreciate a separate documentation, or at least more examples like how to make a more complex query etc.\r\n\r\nI can help with that but I'll defer to you whether we use Sphinx + ReadTheDocs or PHPDoc + GitHub Pages, or something else entirely.",
"title": "Better documentation needed",
"type": "issue"
},
{
"action": "created",
"author": "calcinai",
"comment_id": 137201831,
"datetime": 1441218734000,
"masked_author": "username_1",
"text": "I've used Sphinx, but like the idea of the doc being in the code, since it probably won't be too verbose anyway. I think that way it's more likely it stays up-to-date.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FLamparski",
"comment_id": 137230010,
"datetime": 1441224738000,
"masked_author": "username_0",
"text": "I'm tinkering with adding some docs to the code on my fork, will PR you soon. I see you're already generating PHPDoc comments for the models, that's cool!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ultradox",
"comment_id": 306747265,
"datetime": 1496829109000,
"masked_author": "username_2",
"text": "More examples and documentation would be much appreciated. The readability of the source code is a function of one's level of expertise, and I'm struggling. I don't understand how to harness return data, as described here https://community.xero.com/developer/discussion/51339152/\r\n\r\nAny pointers or assistance would be much appreciated.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "calcinai",
"comment_id": 306747878,
"datetime": 1496829259000,
"masked_author": "username_1",
"text": "@username_2 it's definitely something that needs doing, especially now that Xero are recommending this library. Unfortunately I just don't have the time to write it up at the moment - part of me also didn't want to do it until the 2.0 branch is out (a looooong time coming).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "calcinai",
"comment_id": 306750654,
"datetime": 1496829985000,
"masked_author": "username_1",
"text": "@username_2 In answer to your question on the Xero forum, look at the usage [here](https://github.com/username_1/xero-php#usage) for the basic idea - you'll get contact objects in there that will have all the methods available.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ultradox",
"comment_id": 306752062,
"datetime": 1496830370000,
"masked_author": "username_2",
"text": "Thanks for the advice on the Xero forum, I'll try it out.",
"title": null,
"type": "comment"
}
] | 1,615 | false | false | 3 | 7 | true |
pantsbuild/pants | pantsbuild | 256,466,308 | 4,858 | {
"number": 4858,
"repo": "pants",
"user_login": "pantsbuild"
} | [
{
"action": "opened",
"author": "mateor",
"comment_id": null,
"datetime": 1504991455000,
"masked_author": "username_0",
"text": "requests[security] has a dependency on pyopenssl, which is currently\r\ntriggering a depreaction due to an OpenSSL.rand call.\r\n\r\npyopenssl has fixed this issue in code, but is waiting for a maintainer\r\nto return from vacation and cut a release.\r\n\r\nIn the meantime, the release cannot be completed with the current\r\ndep due to the non-zero it raises.\r\n\r\n .7/site-packages/urllib3/contrib/pyopenssl.py:46: DeprecationWarning: OpenSSL.rand is deprecated - you should use os.urandom instead\r\n import OpenSSL.SSL\r\n **** Failed to install cryptography-2.0.3 (caused by: NonZeroExit(\"received exit code 1 during execution of\r\n\r\nThis was a CI-fix around ssl handshakes, and since the CI is currently having its own\r\nissues, I figured we could unlock the release while we wait.\r\n\r\nIf this commit lands, it should be short-term and be undone once the\r\npyopenssl can be released.\r\n\r\nReferences: #4856\r\n\r\n### Problem\r\n\r\n(_explain the context of the problem and why you're making this change. include\r\nreferences to all relevant github issues._)\r\n\r\n### Solution\r\n\r\n(_describe the modifications you've made._)\r\n\r\n### Result\r\n\r\n(_describe how your changes affect the end-user behavior of the system. this section is\r\noptional, and should generally be summarized in the title of the pull request._)",
"title": "Downgrade to vanilla requests.",
"type": "issue"
},
{
"action": "created",
"author": "mateor",
"comment_id": 328303701,
"datetime": 1504991483000,
"masked_author": "username_0",
"text": "Lets see what the CI says, and if promising, I will pull in reviewers.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mateor",
"comment_id": 328308336,
"datetime": 1504997781000,
"masked_author": "username_0",
"text": "Hmmm. This is failing an interpreter selection test for pex integration. No mention of it in the issues that I saw, but seems unrelated to the change in this patch: https://travis-ci.org/pantsbuild/pants/jobs/273705291#L1128",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mateor",
"comment_id": 328791184,
"datetime": 1505207193000,
"masked_author": "username_0",
"text": "Okay, according to [here](https://travis-ci.org/pantsbuild/pants/jobs/273473403), this CI failure is indeed a preexisting issue. So I will not feel compelled to block the release.\r\n\r\nMerging this and will put out the release after work on Tuesday",
"title": null,
"type": "comment"
}
] | 1,831 | false | false | 1 | 4 | false |
ionic-team/ionic-cli | ionic-team | 78,944,386 | 432 | null | [
{
"action": "opened",
"author": "l-ll",
"comment_id": null,
"datetime": 1432206045000,
"masked_author": "username_0",
"text": "after install ionic with `sudo npm install ionic -g` in mac,\ncan't run ionic command.\nalso can't find ionic in /usr/lcoal/bin/ \nPlease help me :sob:",
"title": "ionic: command not found",
"type": "issue"
},
{
"action": "created",
"author": "XKushal",
"comment_id": 462004811,
"datetime": 1549678836000,
"masked_author": "username_1",
"text": "same issue. were u able to figure out?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "XKushal",
"comment_id": 462004859,
"datetime": 1549678870000,
"masked_author": "username_1",
"text": "same issue. were u able to figure out?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Sachinbekre",
"comment_id": 519486132,
"datetime": 1565265106000,
"masked_author": "username_2",
"text": "same issue\r\n-bash: ionic: command not found",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "abarkhuysen",
"comment_id": 542510230,
"datetime": 1571200749000,
"masked_author": "username_3",
"text": "same issue\r\n-bash: ionic: command not found",
"title": null,
"type": "comment"
}
] | 312 | false | false | 4 | 5 | false |
Blazemeter/taurus | Blazemeter | 213,226,824 | 511 | {
"number": 511,
"repo": "taurus",
"user_login": "Blazemeter"
} | [
{
"action": "opened",
"author": "greyfenrir",
"comment_id": null,
"datetime": 1489113594000,
"masked_author": "username_0",
"text": "",
"title": "add support of lists to json body",
"type": "issue"
},
{
"action": "created",
"author": "undera",
"comment_id": 285694894,
"datetime": 1489159043000,
"masked_author": "username_1",
"text": "Unit test to cover this case?",
"title": null,
"type": "comment"
}
] | 29 | false | true | 2 | 2 | false |
felixfbecker/vscode-php-intellisense | null | 226,744,998 | 118 | null | [
{
"action": "opened",
"author": "rogierverbrugge",
"comment_id": null,
"datetime": 1494053334000,
"masked_author": "username_0",
"text": "When I use __construct() to setup dependency injection the protected property that I set won't be available through $this.\r\n\r\nIt works when I use it directly\r\n\r\n\r\nBut not when it's a property\r\n\r\n\r\nAny idea how that's possible?",
"title": "Setting protected properties in __construct",
"type": "issue"
},
{
"action": "created",
"author": "jens1o",
"comment_id": 299620295,
"datetime": 1494053442000,
"masked_author": "username_1",
"text": "What's your doc comment for the property? It relies on it",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rogierverbrugge",
"comment_id": 299620649,
"datetime": 1494053956000,
"masked_author": "username_0",
"text": "Thank you! Had to change it to AuthService instead of App\\Services\\AuthService.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "rogierverbrugge",
"comment_id": null,
"datetime": 1494053956000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "felixfbecker",
"comment_id": 299629534,
"datetime": 1494065154000,
"masked_author": "username_2",
"text": "Fully qualified names must start with a leading backslash, otherwise they are resolved relative to the current namespace.",
"title": null,
"type": "comment"
}
] | 571 | false | false | 3 | 5 | false |
nilenso/reviews | nilenso | 66,926,865 | 3 | {
"number": 3,
"repo": "reviews",
"user_login": "nilenso"
} | [
{
"action": "opened",
"author": "gja",
"comment_id": null,
"datetime": 1428423331000,
"masked_author": "username_0",
"text": "",
"title": "Increase the height of the text box",
"type": "issue"
},
{
"action": "created",
"author": "timothyandrew",
"comment_id": 90822507,
"datetime": 1428475885000,
"masked_author": "username_1",
"text": "Thanks! :+1:",
"title": null,
"type": "comment"
}
] | 12 | false | false | 2 | 2 | false |
cookpad/expeditor | cookpad | 223,731,597 | 27 | {
"number": 27,
"repo": "expeditor",
"user_login": "cookpad"
} | [
{
"action": "opened",
"author": "taiki45",
"comment_id": null,
"datetime": 1493020167000,
"masked_author": "username_0",
"text": "User should be able to select whether use or not:\r\nhttps://github.com/ruby-concurrency/concurrent-ruby/blob/v1.0.5/README.md#note-for-gem-developers\r\n\r\n@cookpad/dev-infra Any thoughts?",
"title": "We should not depend on this in a gemspec",
"type": "issue"
},
{
"action": "created",
"author": "taiki45",
"comment_id": 296573070,
"datetime": 1493022196000,
"masked_author": "username_0",
"text": "Tests are fragile now... retried.",
"title": null,
"type": "comment"
}
] | 217 | false | false | 1 | 2 | false |
thephpleague/omnipay-authorizenet | thephpleague | 60,204,763 | 18 | {
"number": 18,
"repo": "omnipay-authorizenet",
"user_login": "thephpleague"
} | [
{
"action": "opened",
"author": "judgej",
"comment_id": null,
"datetime": 1425732014000,
"masked_author": "username_0",
"text": "I hope the test coverage is enough. See what you think.\r\n\r\nThe DPM and SIM callback hash checks are supposed to work the same way. However, I am not convinced the SIM version does the right thing. In the callback, the hash should be against the shared secret and login ID, supplied by the merchant site, and the transaction reference and amount, supplied by the gateway in the callback POST data.That is how I have set up the DPM hash check. The SIM hash check looks at the amount supplied by the merchant site rather than in the POST data (which is arguiably fine as a check, *but* will product the wrong and less useful exception if that check fails), and the transaction id supplied by the merchant site. That second one is most definitely wrong - it should be the transaction reference, and that is only known for the first time in the callback as it is supplied as POST data (x_trans_id).\r\n\r\nI don't want to break sites already using SIM that have probably got a workaround in place, so the DPM hash is coded differently, and is used differently.",
"title": "DPM support for Authorize.Net",
"type": "issue"
},
{
"action": "created",
"author": "judgej",
"comment_id": 101429159,
"datetime": 1431466696000,
"masked_author": "username_0",
"text": "I'm not sure where we left this. Is it still waiting for something from me? It's been in production for me for a few months, with over $300k in approved transactions, so I'm confident that it's working, though that doesn't mean I have not missed out some test coverage.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kayladnls",
"comment_id": 101429409,
"datetime": 1431466772000,
"masked_author": "username_1",
"text": ":+1: Thank you @username_0",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "judgej",
"comment_id": 101430208,
"datetime": 1431467009000,
"masked_author": "username_0",
"text": "Well, I'm not going to be able to sleep tonight now. Thanks :-)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kayladnls",
"comment_id": 101434430,
"datetime": 1431467845000,
"masked_author": "username_1",
"text": "but... why?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "judgej",
"comment_id": 101435316,
"datetime": 1431468115000,
"masked_author": "username_0",
"text": "Just new code hitting the big, wide world. They grow up so fast, but always come back crying when they fall over.",
"title": null,
"type": "comment"
}
] | 1,529 | false | false | 2 | 6 | true |
ampedandwired/html-webpack-plugin | null | 199,746,038 | 541 | null | [
{
"action": "opened",
"author": "PeachScript",
"comment_id": null,
"datetime": 1484031183000,
"masked_author": "username_0",
"text": "Hello, I got an error `fullTemplatePath` when I passing loader query parameters like the following code:\r\n\r\n```js\r\nnew HtmlWebpackPlugin({\r\n filename: 'index.html',\r\n template: '!!html!swig?raw=true!./src/tmpl/index.html'\r\n```\r\n\r\nThen I got an error `fullTemplatePath`:\r\n```\r\n!!html!/Absolute/path/to/context/swig?raw=true!./src/tmpl/index.swig\r\n```\r\n\r\nSo the `Child compilation` certainly failed, I read the source code and debug it, I think this problem caused by regexp in the `getFullTemplatePath` function, because the current regexp no deal with loader query parameters, it will match the `swig` substring and resolve it as a file path, is that right?",
"title": "Template path resolving error if passing loader query parameters",
"type": "issue"
},
{
"action": "created",
"author": "PeachScript",
"comment_id": 271502083,
"datetime": 1484031979000,
"masked_author": "username_0",
"text": "I created a pull request to fix it, please review it.\r\n\r\nAnd this PR has been tested locally against Node.js v4, v5, v6, v7, but I don't know why the `travis-ci` failed...",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "PeachScript",
"comment_id": null,
"datetime": 1485712950000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "PeachScript",
"comment_id": 275932796,
"datetime": 1485712950000,
"masked_author": "username_0",
"text": "PR has been merged, close this issue now.",
"title": null,
"type": "comment"
}
] | 871 | false | false | 1 | 4 | false |
neoziro/primus-cluster | null | 31,348,913 | 3 | null | [
{
"action": "opened",
"author": "rodincave",
"comment_id": null,
"datetime": 1397239125000,
"masked_author": "username_0",
"text": "Hi,\r\n\r\nI am wondering if there is possibility to use this plugin to send 1-to-1 messages from one user1 on server1 to user2 on server2 ?\r\nI installed the plugin with redis-rooms and redis-emitter. I saw how to broadcast a message to an entier room, but is there a way to send it to only one specific socket in a room ?\r\n\r\nThanks",
"title": "Send a message to a specific user on an other instance",
"type": "issue"
},
{
"action": "created",
"author": "SeyZ",
"comment_id": 70428496,
"datetime": 1421618647000,
"masked_author": "username_1",
"text": ":+1: for this feature request",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlondono",
"comment_id": 93584951,
"datetime": 1429136199000,
"masked_author": "username_2",
"text": "I thought I could send a event to a spark by using\r\n```\r\n primus.spark(sparkId)\r\n```\r\nbut it only return a spark if exist on that cluster",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "PedroMD",
"comment_id": 210440520,
"datetime": 1460722230000,
"masked_author": "username_3",
"text": "@neoziro, I know this issue is closed, but did you really end up adding support for this as you've previously mentioned?",
"title": null,
"type": "comment"
}
] | 614 | false | false | 4 | 4 | false |
aws/aws-sdk-php-laravel | aws | 127,434,180 | 94 | null | [
{
"action": "opened",
"author": "sulthanallaudeen",
"comment_id": null,
"datetime": 1453206184000,
"masked_author": "username_0",
"text": "I am using US Standard\r\n\r\nAnd here's my Code\r\n\r\n$s3 = AWS::get('s3');\r\n$s3->putObject(array(\r\n 'Bucket' => 'Mybucketname',\r\n 'Body' => Input::get('name'),\r\n));\r\n\r\nWhile i am trying to upload, it is giving me the error",
"title": "Issue while uploading in US Region",
"type": "issue"
},
{
"action": "created",
"author": "jeremeamia",
"comment_id": 172893492,
"datetime": 1453218415000,
"masked_author": "username_1",
"text": "What does your config look like?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sulthanallaudeen",
"comment_id": 173183317,
"datetime": 1453291131000,
"masked_author": "username_0",
"text": "here is my config look like\r\n\r\n<?php\r\n\r\nreturn [\r\n 'credentials' => [\r\n 'key' => 'yy',\r\n 'secret' => 'xx',\r\n ],\r\n 'region' => 'us-east-1',\r\n 'version' => 'latest',\r\n\r\n // You can override settings for specific services\r\n 'Ses' => [\r\n 'region' => 'us-east-1',\r\n ],\r\n];\r\n\r\nMy Location is US Standard",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sulthanallaudeen",
"comment_id": 173219544,
"datetime": 1453299935000,
"masked_author": "username_0",
"text": "Also this is my code\r\n\r\n$s3->putObject(array(\r\n 'Bucket' => 'greenhoppingbucket',\r\n 'Key' => '1231',\r\n 'Body' => Input::get('name'),\r\n));\r\n\r\nIn the bucket i can find a file named as 1231 is created by my real file.. is not getting stored, which i had as 'body' .. \r\nWhat might be the issue.. help pls",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jeskew",
"comment_id": 173299067,
"datetime": 1453311657000,
"masked_author": "username_2",
"text": "@username_0 So you're no longer getting the \"Please send all future requests to this endpoint\" error, but an empty object is created in your bucket?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sulthanallaudeen",
"comment_id": 173306598,
"datetime": 1453312999000,
"masked_author": "username_0",
"text": "Yes in my bucket an empty object is created always",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sulthanallaudeen",
"comment_id": 173307223,
"datetime": 1453313066000,
"masked_author": "username_0",
"text": "$s3 = App::make('aws')->get('s3');\r\n$s3->putObject(array(\r\n 'Bucket' => 'greenhoppingbucket',\r\n 'Key' => 'somevalue',\r\n 'Body' => Input::get('name'),\r\n 'SourceFile' => Input::get('name'),\r\n));\r\n\r\nIn the above code, the output is , i am getting 'somevalue' as object created in bucket. but the files is not stored in the bucket.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jeremeamia",
"comment_id": 173318438,
"datetime": 1453314987000,
"masked_author": "username_1",
"text": "What is the value of `Input::get('name')`? You must be sending an empty string to S3.\r\n\r\nAlso, you shouldn't be using both `Body` and `SourceFile`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sulthanallaudeen",
"comment_id": 173319351,
"datetime": 1453315169000,
"masked_author": "username_0",
"text": "In the jquery request i am getting the image by \r\n\r\nvar files = document.getElementById (\"upload\").files;\r\nvar file = files[0];\r\n$.ajax({\r\n method: \"POST\",\r\n url: \"imageUpload\",\r\n data: {\r\n 'name': file.name,\r\n 'type': file.type,\r\n }\r\n })\r\n .done(function(msg) {\r\n\r\nAnd inside the controller i am getting it by \r\n\r\nInput::get('name');\r\n\r\nnote : if i return `Input::get('name')` inside my controller, i can see the image's name over there..",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jeskew",
"comment_id": 173396639,
"datetime": 1453331839000,
"masked_author": "username_2",
"text": "So `Input::get('name')` is a file path on the server?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jeskew",
"comment_id": 179985815,
"datetime": 1454610694000,
"masked_author": "username_2",
"text": "Based on the information available, it sounds like you're sending the file name to the server. You'll need to send the entire file unless the path being sent is on the server, not the client.\r\n\r\nPlease feel free to reopen if you have any questions or concerns.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jeskew",
"comment_id": null,
"datetime": 1454610695000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 2,502 | false | false | 3 | 12 | true |
doctimjones/docker-c9-workstation | null | 207,575,122 | 2 | {
"number": 2,
"repo": "docker-c9-workstation",
"user_login": "doctimjones"
} | [
{
"action": "opened",
"author": "boblannon",
"comment_id": null,
"datetime": 1487091613000,
"masked_author": "username_0",
"text": "",
"title": "change localhost url in \"easiest way\" section",
"type": "issue"
},
{
"action": "created",
"author": "doctimjones",
"comment_id": 279777184,
"datetime": 1487093574000,
"masked_author": "username_1",
"text": "👍",
"title": null,
"type": "comment"
}
] | 1 | false | false | 2 | 2 | false |
vuejs/cn.vuejs.org | vuejs | 122,906,648 | 86 | null | [
{
"action": "opened",
"author": "qiansen1386",
"comment_id": null,
"datetime": 1450428618000,
"masked_author": "username_0",
"text": "\r\n\r\n",
"title": "为什么只有中文的首页还是推1.0.10。。。",
"type": "issue"
},
{
"action": "closed",
"author": "yyx990803",
"comment_id": null,
"datetime": 1450466049000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "yyx990803",
"comment_id": 165874237,
"datetime": 1450466049000,
"masked_author": "username_1",
"text": "已更新",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "qiansen1386",
"comment_id": 165935639,
"datetime": 1450490767000,
"masked_author": "username_0",
"text": "感谢大牛！:joy:",
"title": null,
"type": "comment"
}
] | 383 | false | false | 2 | 4 | false |
docker/docker-py | docker | 132,379,393 | 930 | {
"number": 930,
"repo": "docker-py",
"user_login": "docker"
} | [
{
"action": "opened",
"author": "speedplane",
"comment_id": null,
"datetime": 1455012815000,
"masked_author": "username_0",
"text": "Seems like a straightforward improvement to gzip our tarballs before sending them. For me, it greatly improved performance (reduced my own docker image from 120MB to 40MB).\r\n\r\nSigned-off-by: Michael Sander <michael.sander@docketalarm.com",
"title": "Use gzip to compress tar balls before sending.",
"type": "issue"
},
{
"action": "created",
"author": "GordonTheTurtle",
"comment_id": 181797737,
"datetime": 1455012818000,
"masked_author": "username_1",
"text": "Please sign your commits following these rules:\nhttps://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work\nThe easiest way to do this is to amend the last commit:\n~~~console\n$ git clone -b \"patch-1\" git@github.com:username_0/docker-py.git somewhere\n$ cd somewhere\n$ git rebase -i HEAD~2\neditor opens\nchange each 'pick' to 'edit'\nsave the file and quit\n$ git commit --amend -s --no-edit\n$ git rebase --continue # and repeat the amend for each commit\n$ git push -f\n~~~\n\nAmmending updates the existing PR. You **DO NOT** need to open a new one.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "speedplane",
"comment_id": 181803233,
"datetime": 1455013672000,
"masked_author": "username_0",
"text": "Also, FYI, I caught this while experiencing pain with Docker on Google's managed VM.\r\nhttps://code.google.com/p/google-cloud-sdk/issues/detail?id=456",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shin-",
"comment_id": 200488803,
"datetime": 1458758416000,
"masked_author": "username_2",
"text": "Closing via #1008",
"title": null,
"type": "comment"
}
] | 961 | false | false | 3 | 4 | true |
knsv/mermaid | null | 201,797,026 | 461 | null | [
{
"action": "opened",
"author": "XiaoZYang",
"comment_id": null,
"datetime": 1484815735000,
"masked_author": "username_0",
"text": "I install `mermaid` with command `$ npm install mermaid -g` . When I run it with command `mermaid $ftest_ile` I got this error:\r\n\r\n\r\nThen I try `npm install phantomjs` and it works.\r\nNow, I am wondering it is a bug or wrong configuration in `package.js`(I found **\"phantomjs\":\"^2.1.3\"** in `package.js`).\r\nTHX!",
"title": "Phantomjs Dependency",
"type": "issue"
},
{
"action": "created",
"author": "tylerlong",
"comment_id": 372690745,
"datetime": 1520952366000,
"masked_author": "username_1",
"text": "We do not use PhantomJS any more. Ref: https://github.com/mermaidjs/mermaid.cli",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tylerlong",
"comment_id": null,
"datetime": 1520952366000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 515 | false | false | 2 | 3 | false |
trill-lang/LLVMSwift | trill-lang | 203,464,680 | 51 | null | [
{
"action": "opened",
"author": "CodaFi",
"comment_id": null,
"datetime": 1485458745000,
"masked_author": "username_0",
"text": "This is a formatted list of APIs we do not yet wrap.\r\n\r\n- [ ] LLVMAShr\r\n- [ ] LLVMAbortProcessAction\r\n- [ ] LLVMAdd\r\n- [ ] LLVMAddAlias\r\n- [ ] LLVMAddAlwaysInlinerPass\r\n- [ ] LLVMAddAnalysisPasses\r\n- [ ] LLVMAddArgumentPromotionPass\r\n- [ ] LLVMAddAttribute\r\n- [ ] LLVMAddAttributeAtIndex\r\n- [ ] LLVMAddBBVectorizePass\r\n- [ ] LLVMAddCallSiteAttribute\r\n- [ ] LLVMAddClause\r\n- [ ] LLVMAddConstantMergePass\r\n- [ ] LLVMAddDeadArgEliminationPass\r\n- [ ] LLVMAddDestination\r\n- [ ] LLVMAddFunctionAttr\r\n- [ ] LLVMAddFunctionAttrsPass\r\n- [ ] LLVMAddFunctionInliningPass\r\n- [ ] LLVMAddGlobalDCEPass\r\n- [ ] LLVMAddGlobalInAddressSpace\r\n- [ ] LLVMAddGlobalMapping\r\n- [ ] LLVMAddGlobalOptimizerPass\r\n- [ ] LLVMAddIPConstantPropagationPass\r\n- [ ] LLVMAddIPSCCPPass\r\n- [ ] LLVMAddInstrAttribute\r\n- [ ] LLVMAddInternalizePass\r\n- [ ] LLVMAddLoopVectorizePass\r\n- [ ] LLVMAddModule\r\n- [ ] LLVMAddNamedMetadataOperand\r\n- [ ] LLVMAddPruneEHPass\r\n- [ ] LLVMAddSLPVectorizePass\r\n- [ ] LLVMAddScalarReplAggregatesPassWithThreshold\r\n- [ ] LLVMAddStripDeadPrototypesPass\r\n- [ ] LLVMAddStripSymbolsPass\r\n- [ ] LLVMAddSymbol\r\n- [ ] LLVMAddTargetDependentFunctionAttr\r\n- [ ] LLVMAddTargetLibraryInfo\r\n- [ ] LLVMAddrSpaceCast\r\n- [ ] LLVMAlignment\r\n- [ ] LLVMAlloca\r\n- [ ] LLVMAlwaysInlineAttribute\r\n- [ ] LLVMAnalysis\r\n- [ ] LLVMAnd\r\n- [ ] LLVMAnyRegCallConv\r\n- [ ] LLVMAppendingLinkage\r\n- [ ] LLVMArgumentValueKind\r\n- [ ] LLVMAtomicCmpXchg\r\n- [ ] LLVMAtomicOrdering\r\n- [ ] LLVMAtomicOrderingAcquire\r\n- [ ] LLVMAtomicOrderingAcquireRelease\r\n- [ ] LLVMAtomicOrderingMonotonic\r\n- [ ] LLVMAtomicOrderingNotAtomic\r\n- [ ] LLVMAtomicOrderingRelease\r\n- [ ] LLVMAtomicOrderingSequentiallyConsistent\r\n- [ ] LLVMAtomicOrderingUnordered\r\n- [ ] LLVMAtomicRMW\r\n- [ ] LLVMAtomicRMWBinOp\r\n- [ ] LLVMAtomicRMWBinOpAdd\r\n- [ ] LLVMAtomicRMWBinOpAnd\r\n- [ ] LLVMAtomicRMWBinOpMax\r\n- [ ] LLVMAtomicRMWBinOpMin\r\n- [ ] LLVMAtomicRMWBinOpNand\r\n- [ ] LLVMAtomicRMWBinOpOr\r\n- [ ] LLVMAtomicRMWBinOpSub\r\n- [ ] LLVMAtomicRMWBinOpUMax\r\n- [ ] LLVMAtomicRMWBinOpUMin\r\n- [ ] LLVMAtomicRMWBinOpXchg\r\n- [ ] LLVMAtomicRMWBinOpXor\r\n- [ ] LLVMAttribute\r\n- [ ] LLVMAttributeFunctionIndex\r\n- [ ] LLVMAttributeIndex\r\n- [ ] LLVMAttributeRef\r\n- [ ] LLVMAttributeReturnIndex\r\n- [ ] LLVMAvailableExternallyLinkage\r\n- [ ] LLVMBasicBlockAsValue\r\n- [ ] LLVMBasicBlockValueKind\r\n- [ ] LLVMBitCast\r\n- [ ] LLVMBitReader\r\n- [ ] LLVMBitWriter\r\n- [ ] LLVMBlockAddress\r\n- [ ] LLVMBlockAddressValueKind\r\n- [ ] LLVMBr\r\n- [ ] LLVMBuildAddrSpaceCast\r\n- [ ] LLVMBuildAggregateRet\r\n- [ ] LLVMBuildArrayAlloca\r\n- [ ] LLVMBuildArrayMalloc\r\n- [ ] LLVMBuildAtomicCmpXchg\r\n- [ ] LLVMBuildAtomicRMW\r\n- [ ] LLVMBuildBinOp\r\n- [ ] LLVMBuildCast\r\n- [ ] LLVMBuildExactSDiv\r\n- [ ] LLVMBuildExtractElement\r\n- [ ] LLVMBuildExtractValue\r\n- [ ] LLVMBuildFPCast\r\n- [ ] LLVMBuildFPExt\r\n- [ ] LLVMBuildFPTrunc\r\n- [ ] LLVMBuildFence\r\n- [ ] LLVMBuildFree\r\n- [ ] LLVMBuildIndirectBr\r\n- [ ] LLVMBuildIntCast\r\n- [ ] LLVMBuildInvoke\r\n- [ ] LLVMBuildLandingPad\r\n- [ ] LLVMBuildMalloc\r\n- [ ] LLVMBuildNUWSub\r\n- [ ] LLVMBuildPointerCast\r\n- [ ] LLVMBuildPtrDiff\r\n- [ ] LLVMBuildPtrToInt\r\n- [ ] LLVMBuildResume\r\n- [ ] LLVMBuildSExtOrBitCast\r\n- [ ] LLVMBuildSelect\r\n- [ ] LLVMBuildShuffleVector\r\n- [ ] LLVMBuildVAArg\r\n- [ ] LLVMBuildZExtOrBitCast\r\n- [ ] LLVMByValAttribute\r\n- [ ] LLVMC\r\n- [ ] LLVMCAnalysis\r\n- [ ] LLVMCBitReader\r\n- [ ] LLVMCBitWriter\r\n- [ ] LLVMCCallConv\r\n- [ ] LLVMCCore\r\n- [ ] LLVMCCoreContext\r\n- [ ] LLVMCCoreInstructionBuilder\r\n- [ ] LLVMCCoreMemoryBuffers\r\n- [ ] LLVMCCoreModule\r\n- [ ] LLVMCCoreModuleProvider\r\n- [ ] LLVMCCorePassManagers\r\n- [ ] LLVMCCorePassRegistry\r\n- [ ] LLVMCCoreThreading\r\n- [ ] LLVMCCoreType\r\n- [ ] LLVMCCoreTypeFloat\r\n- [ ] LLVMCCoreTypeFunction\r\n- [ ] LLVMCCoreTypeInt\r\n- [ ] LLVMCCoreTypeOther\r\n- [ ] LLVMCCoreTypeSequential\r\n- [ ] LLVMCCoreTypeStruct\r\n- [ ] LLVMCCoreTypes\r\n- [ ] LLVMCCoreValueBasicBlock\r\n- [ ] LLVMCCoreValueConstant\r\n- [ ] LLVMCCoreValueConstantComposite\r\n- [ ] LLVMCCoreValueConstantExpressions\r\n- [ ] LLVMCCoreValueConstantGlobals\r\n- [ ] LLVMCCoreValueConstantScalar\r\n- [ ] LLVMCCoreValueFunction\r\n- [ ] LLVMCCoreValueFunctionParameters\r\n- [ ] LLVMCCoreValueGeneral\r\n- [ ] LLVMCCoreValueInstruction\r\n- [ ] LLVMCCoreValueInstructionAlloca\r\n- [ ] LLVMCCoreValueInstructionCall\r\n- [ ] LLVMCCoreValueInstructionExtractValue\r\n- [ ] LLVMCCoreValueInstructionGetElementPointer\r\n- [ ] LLVMCCoreValueInstructionInsertValue\r\n- [ ] LLVMCCoreValueInstructionPHINode\r\n- [ ] LLVMCCoreValueInstructionTerminator\r\n- [ ] LLVMCCoreValueMetadata\r\n- [ ] LLVMCCoreValueUser\r\n- [ ] LLVMCCoreValueUses\r\n- [ ] LLVMCCoreValueWithAlignment\r\n- [ ] LLVMCCoreValues\r\n- [ ] LLVMCDisassembler\r\n- [ ] LLVMCExecutionEngine\r\n- [ ] LLVMCInitialization\r\n- [ ] LLVMCLTO\r\n- [ ] LLVMCLinkTimeOptimizer\r\n- [ ] LLVMCObject\r\n- [ ] LLVMCSupportTypes\r\n- [ ] LLVMCTLTO\r\n- [ ] LLVMCTLTO_CACHING\r\n- [ ] LLVMCTarget\r\n- [ ] LLVMCTransforms\r\n- [ ] LLVMCTransformsIPO\r\n- [ ] LLVMCTransformsPassManagerBuilder\r\n- [ ] LLVMCTransformsScalar\r\n- [ ] LLVMCTransformsVectorize\r\n- [ ] LLVMCall\r\n- [ ] LLVMCallConv\r\n- [ ] LLVMCatchPad\r\n- [ ] LLVMCatchRet\r\n- [ ] LLVMCatchSwitch\r\n- [ ] LLVMCleanupPad\r\n- [ ] LLVMCleanupRet\r\n- [ ] LLVMCloneModule\r\n- [ ] LLVMColdAttribute\r\n- [ ] LLVMColdCallConv\r\n- [ ] LLVMCommonLinkage\r\n- [ ] LLVMConstAShr\r\n- [ ] LLVMConstAdd\r\n- [ ] LLVMConstAddrSpaceCast\r\n- [ ] LLVMConstAnd\r\n- [ ] LLVMConstBitCast\r\n- [ ] LLVMConstExactSDiv\r\n- [ ] LLVMConstExtractElement\r\n- [ ] LLVMConstExtractValue\r\n- [ ] LLVMConstFAdd\r\n- [ ] LLVMConstFCmp\r\n- [ ] LLVMConstFDiv\r\n- [ ] LLVMConstFMul\r\n- [ ] LLVMConstFNeg\r\n- [ ] LLVMConstFPCast\r\n- [ ] LLVMConstFPExt\r\n- [ ] LLVMConstFPToSI\r\n- [ ] LLVMConstFPToUI\r\n- [ ] LLVMConstFPTrunc\r\n- [ ] LLVMConstFRem\r\n- [ ] LLVMConstFSub\r\n- [ ] LLVMConstICmp\r\n- [ ] LLVMConstInBoundsGEP\r\n- [ ] LLVMConstInlineAsm\r\n- [ ] LLVMConstInsertElement\r\n- [ ] LLVMConstInsertValue\r\n- [ ] LLVMConstIntCast\r\n- [ ] LLVMConstIntGetSExtValue\r\n- [ ] LLVMConstIntGetZExtValue\r\n- [ ] LLVMConstIntOfArbitraryPrecision\r\n- [ ] LLVMConstIntOfString\r\n- [ ] LLVMConstIntOfStringAndSize\r\n- [ ] LLVMConstIntToPtr\r\n- [ ] LLVMConstLShr\r\n- [ ] LLVMConstMul\r\n- [ ] LLVMConstNSWAdd\r\n- [ ] LLVMConstNSWMul\r\n- [ ] LLVMConstNSWNeg\r\n- [ ] LLVMConstNSWSub\r\n- [ ] LLVMConstNUWAdd\r\n- [ ] LLVMConstNUWMul\r\n- [ ] LLVMConstNUWNeg\r\n- [ ] LLVMConstNUWSub\r\n- [ ] LLVMConstNamedStruct\r\n- [ ] LLVMConstNeg\r\n- [ ] LLVMConstNot\r\n- [ ] LLVMConstOr\r\n- [ ] LLVMConstPointerCast\r\n- [ ] LLVMConstPtrToInt\r\n- [ ] LLVMConstRealGetDouble\r\n- [ ] LLVMConstRealOfString\r\n- [ ] LLVMConstRealOfStringAndSize\r\n- [ ] LLVMConstSDiv\r\n- [ ] LLVMConstSExt\r\n- [ ] LLVMConstSExtOrBitCast\r\n- [ ] LLVMConstSIToFP\r\n- [ ] LLVMConstSRem\r\n- [ ] LLVMConstSelect\r\n- [ ] LLVMConstShl\r\n- [ ] LLVMConstShuffleVector\r\n- [ ] LLVMConstStringInContext\r\n- [ ] LLVMConstStructInContext\r\n- [ ] LLVMConstSub\r\n- [ ] LLVMConstTrunc\r\n- [ ] LLVMConstTruncOrBitCast\r\n- [ ] LLVMConstUDiv\r\n- [ ] LLVMConstUIToFP\r\n- [ ] LLVMConstURem\r\n- [ ] LLVMConstVector\r\n- [ ] LLVMConstXor\r\n- [ ] LLVMConstZExt\r\n- [ ] LLVMConstZExtOrBitCast\r\n- [ ] LLVMConstantAggregateZeroValueKind\r\n- [ ] LLVMConstantArrayValueKind\r\n- [ ] LLVMConstantDataArrayValueKind\r\n- [ ] LLVMConstantDataVectorValueKind\r\n- [ ] LLVMConstantExprValueKind\r\n- [ ] LLVMConstantFPValueKind\r\n- [ ] LLVMConstantIntValueKind\r\n- [ ] LLVMConstantPointerNullValueKind\r\n- [ ] LLVMConstantStructValueKind\r\n- [ ] LLVMConstantTokenNoneValueKind\r\n- [ ] LLVMConstantVectorValueKind\r\n- [ ] LLVMContext\r\n- [ ] LLVMContextCreate\r\n- [ ] LLVMContextDispose\r\n- [ ] LLVMContextGetDiagnosticContext\r\n- [ ] LLVMContextGetDiagnosticHandler\r\n- [ ] LLVMContextSetDiagnosticHandler\r\n- [ ] LLVMContextSetYieldCallback\r\n- [ ] LLVMConvergentAttribute\r\n- [ ] LLVMCore\r\n- [ ] LLVMCoreValueConstantGlobalAlias\r\n- [ ] LLVMCoreValueConstantGlobalVariable\r\n- [ ] LLVMCountBasicBlocks\r\n- [ ] LLVMCountParams\r\n- [ ] LLVMCountStructElementTypes\r\n- [ ] LLVMCreateBuilder\r\n- [ ] LLVMCreateDisasm\r\n- [ ] LLVMCreateDisasmCPU\r\n- [ ] LLVMCreateDisasmCPUFeatures\r\n- [ ] LLVMCreateEnumAttribute\r\n- [ ] LLVMCreateFunctionPassManager\r\n- [ ] LLVMCreateGenericValueOfFloat\r\n- [ ] LLVMCreateGenericValueOfInt\r\n- [ ] LLVMCreateGenericValueOfPointer\r\n- [ ] LLVMCreateInterpreterForModule\r\n- [ ] LLVMCreateJITCompilerForModule\r\n- [ ] LLVMCreateMCJITCompilerForModule\r\n- [ ] LLVMCreateMemoryBufferWithContentsOfFile\r\n- [ ] LLVMCreateMemoryBufferWithMemoryRange\r\n- [ ] LLVMCreateMemoryBufferWithMemoryRangeCopy\r\n- [ ] LLVMCreateMemoryBufferWithSTDIN\r\n- [ ] LLVMCreateMessage\r\n- [ ] LLVMCreateModuleProviderForExistingModule\r\n- [ ] LLVMCreateObjectFile\r\n- [ ] LLVMCreatePassManager\r\n- [ ] LLVMCreateSimpleMCJITMemoryManager\r\n- [ ] LLVMCreateStringAttribute\r\n- [ ] LLVMCreateTargetData\r\n- [ ] LLVMDLLExportLinkage\r\n- [ ] LLVMDLLExportStorageClass\r\n- [ ] LLVMDLLImportLinkage\r\n- [ ] LLVMDLLImportStorageClass\r\n- [ ] LLVMDLLStorageClass\r\n- [ ] LLVMDSError\r\n- [ ] LLVMDSNote\r\n- [ ] LLVMDSRemark\r\n- [ ] LLVMDSWarning\r\n- [ ] LLVMDefaultStorageClass\r\n- [ ] LLVMDefaultVisibility\r\n- [ ] LLVMDiagnosticHandler\r\n- [ ] LLVMDiagnosticInfoRef\r\n- [ ] LLVMDiagnosticSeverity\r\n- [ ] LLVMDisasmContextRef\r\n- [ ] LLVMDisasmDispose\r\n- [ ] LLVMDisasmInstruction\r\n- [ ] LLVMDisassembler_Option_AsmPrinterVariant\r\n- [ ] LLVMDisassembler_Option_PrintImmHex\r\n- [ ] LLVMDisassembler_Option_PrintLatency\r\n- [ ] LLVMDisassembler_Option_SetInstrComments\r\n- [ ] LLVMDisassembler_Option_UseMarkup\r\n- [ ] LLVMDisassembler_ReferenceType_DeMangled_Name\r\n- [ ] LLVMDisassembler_ReferenceType_InOut_None\r\n- [ ] LLVMDisassembler_ReferenceType_In_ARM64_ADDXri\r\n- [ ] LLVMDisassembler_ReferenceType_In_ARM64_ADR\r\n- [ ] LLVMDisassembler_ReferenceType_In_ARM64_ADRP\r\n- [ ] LLVMDisassembler_ReferenceType_In_ARM64_LDRXl\r\n- [ ] LLVMDisassembler_ReferenceType_In_ARM64_LDRXui\r\n- [ ] LLVMDisassembler_ReferenceType_In_Branch\r\n- [ ] LLVMDisassembler_ReferenceType_In_PCrel_Load\r\n- [ ] LLVMDisassembler_ReferenceType_Out_LitPool_CstrAddr\r\n- [ ] LLVMDisassembler_ReferenceType_Out_LitPool_SymAddr\r\n- [ ] LLVMDisassembler_ReferenceType_Out_Objc_CFString_Ref\r\n- [ ] LLVMDisassembler_ReferenceType_Out_Objc_Class_Ref\r\n- [ ] LLVMDisassembler_ReferenceType_Out_Objc_Message\r\n- [ ] LLVMDisassembler_ReferenceType_Out_Objc_Message_Ref\r\n- [ ] LLVMDisassembler_ReferenceType_Out_Objc_Selector_Ref\r\n- [ ] LLVMDisassembler_ReferenceType_Out_SymbolStub\r\n- [ ] LLVMDisassembler_VariantKind_ARM64_GOTPAGE\r\n- [ ] LLVMDisassembler_VariantKind_ARM64_GOTPAGEOFF\r\n- [ ] LLVMDisassembler_VariantKind_ARM64_PAGE\r\n- [ ] LLVMDisassembler_VariantKind_ARM64_PAGEOFF\r\n- [ ] LLVMDisassembler_VariantKind_ARM64_TLVOFF\r\n- [ ] LLVMDisassembler_VariantKind_ARM64_TLVP\r\n- [ ] LLVMDisassembler_VariantKind_ARM_HI16\r\n- [ ] LLVMDisassembler_VariantKind_ARM_LO16\r\n- [ ] LLVMDisassembler_VariantKind_None\r\n- [ ] LLVMDisposeExecutionEngine\r\n- [ ] LLVMDisposeGenericValue\r\n- [ ] LLVMDisposeMCJITMemoryManager\r\n- [ ] LLVMDisposeMemoryBuffer\r\n- [ ] LLVMDisposeModuleProvider\r\n- [ ] LLVMDisposeObjectFile\r\n- [ ] LLVMDisposePassManager\r\n- [ ] LLVMDisposeRelocationIterator\r\n- [ ] LLVMDisposeSectionIterator\r\n- [ ] LLVMDisposeSymbolIterator\r\n- [ ] LLVMDoubleTypeInContext\r\n- [ ] LLVMEnablePrettyStackTrace\r\n- [ ] LLVMExecutionEngine\r\n- [ ] LLVMExternalLinkage\r\n- [ ] LLVMExternalWeakLinkage\r\n- [ ] LLVMExtractElement\r\n- [ ] LLVMExtractValue\r\n- [ ] LLVMFAdd\r\n- [ ] LLVMFCmp\r\n- [ ] LLVMFDiv\r\n- [ ] LLVMFMul\r\n- [ ] LLVMFP128TypeInContext\r\n- [ ] LLVMFPExt\r\n- [ ] LLVMFPToSI\r\n- [ ] LLVMFPToUI\r\n- [ ] LLVMFPTrunc\r\n- [ ] LLVMFRem\r\n- [ ] LLVMFSub\r\n- [ ] LLVMFastCallConv\r\n- [ ] LLVMFatalErrorHandler\r\n- [ ] LLVMFence\r\n- [ ] LLVMFinalizeFunctionPassManager\r\n- [ ] LLVMFindFunction\r\n- [ ] LLVMFloatTypeInContext\r\n- [ ] LLVMFreeMachineCodeForFunction\r\n- [ ] LLVMFunctionValueKind\r\n- [ ] LLVMGeneralDynamicTLSModel\r\n- [ ] LLVMGenericValueIntWidth\r\n- [ ] LLVMGenericValueRef\r\n- [ ] LLVMGenericValueToFloat\r\n- [ ] LLVMGenericValueToInt\r\n- [ ] LLVMGenericValueToPointer\r\n- [ ] LLVMGetAllocatedType\r\n- [ ] LLVMGetAsString\r\n- [ ] LLVMGetAttribute\r\n- [ ] LLVMGetAttributeCountAtIndex\r\n- [ ] LLVMGetAttributesAtIndex\r\n- [ ] LLVMGetBasicBlockName\r\n- [ ] LLVMGetBasicBlockTerminator\r\n- [ ] LLVMGetBasicBlocks\r\n- [ ] LLVMGetBitcodeModule\r\n- [ ] LLVMGetBitcodeModule2\r\n- [ ] LLVMGetBitcodeModuleInContext\r\n- [ ] LLVMGetBitcodeModuleInContext2\r\n- [ ] LLVMGetBufferSize\r\n- [ ] LLVMGetBufferStart\r\n- [ ] LLVMGetCallSiteAttributeCount\r\n- [ ] LLVMGetCallSiteAttributes\r\n- [ ] LLVMGetCallSiteEnumAttribute\r\n- [ ] LLVMGetCallSiteStringAttribute\r\n- [ ] LLVMGetCalledValue\r\n- [ ] LLVMGetClause\r\n- [ ] LLVMGetCmpXchgFailureOrdering\r\n- [ ] LLVMGetCmpXchgSuccessOrdering\r\n- [ ] LLVMGetCondition\r\n- [ ] LLVMGetConstOpcode\r\n- [ ] LLVMGetCurrentDebugLocation\r\n- [ ] LLVMGetDLLStorageClass\r\n- [ ] LLVMGetDataLayout\r\n- [ ] LLVMGetDataLayoutStr\r\n- [ ] LLVMGetDiagInfoDescription\r\n- [ ] LLVMGetDiagInfoSeverity\r\n- [ ] LLVMGetElementAsConstant\r\n- [ ] LLVMGetElementPtr\r\n- [ ] LLVMGetEnumAttributeAtIndex\r\n- [ ] LLVMGetEnumAttributeKind\r\n- [ ] LLVMGetEnumAttributeKindForName\r\n- [ ] LLVMGetEnumAttributeValue\r\n- [ ] LLVMGetExecutionEngineTargetData\r\n- [ ] LLVMGetExecutionEngineTargetMachine\r\n- [ ] LLVMGetFCmpPredicate\r\n- [ ] LLVMGetFirstFunction\r\n- [ ] LLVMGetFirstGlobal\r\n- [ ] LLVMGetFirstTarget\r\n- [ ] LLVMGetFirstUse\r\n- [ ] LLVMGetFunctionAddress\r\n- [ ] LLVMGetFunctionAttr\r\n- [ ] LLVMGetFunctionCallConv\r\n- [ ] LLVMGetGC\r\n- [ ] LLVMGetGlobalParent\r\n- [ ] LLVMGetGlobalPassRegistry\r\n- [ ] LLVMGetGlobalValueAddress\r\n- [ ] LLVMGetICmpPredicate\r\n- [ ] LLVMGetIndices\r\n- [ ] LLVMGetInstructionCallConv\r\n- [ ] LLVMGetInstructionParent\r\n- [ ] LLVMGetIntrinsicID\r\n- [ ] LLVMGetLastEnumAttributeKind\r\n- [ ] LLVMGetLastFunction\r\n- [ ] LLVMGetLastGlobal\r\n- [ ] LLVMGetLinkage\r\n- [ ] LLVMGetMDKindID\r\n- [ ] LLVMGetMDKindIDInContext\r\n- [ ] LLVMGetMDNodeNumOperands\r\n- [ ] LLVMGetMDNodeOperands\r\n- [ ] LLVMGetMDString\r\n- [ ] LLVMGetMetadata\r\n- [ ] LLVMGetModuleIdentifier\r\n- [ ] LLVMGetNamedGlobal\r\n- [ ] LLVMGetNamedMetadataNumOperands\r\n- [ ] LLVMGetNamedMetadataOperands\r\n- [ ] LLVMGetNextFunction\r\n- [ ] LLVMGetNextGlobal\r\n- [ ] LLVMGetNextTarget\r\n- [ ] LLVMGetNormalDest\r\n- [ ] LLVMGetNumArgOperands\r\n- [ ] LLVMGetNumClauses\r\n- [ ] LLVMGetNumIndices\r\n- [ ] LLVMGetNumOperands\r\n- [ ] LLVMGetNumSuccessors\r\n- [ ] LLVMGetOperand\r\n- [ ] LLVMGetOperandUse\r\n- [ ] LLVMGetOrdering\r\n- [ ] LLVMGetParamParent\r\n- [ ] LLVMGetParams\r\n- [ ] LLVMGetPersonalityFn\r\n- [ ] LLVMGetPointerToGlobal\r\n- [ ] LLVMGetPreviousBasicBlock\r\n- [ ] LLVMGetPreviousFunction\r\n- [ ] LLVMGetPreviousGlobal\r\n- [ ] LLVMGetRelocationOffset\r\n- [ ] LLVMGetRelocationSymbol\r\n- [ ] LLVMGetRelocationType\r\n- [ ] LLVMGetRelocationTypeName\r\n- [ ] LLVMGetRelocationValueString\r\n- [ ] LLVMGetRelocations\r\n- [ ] LLVMGetSection\r\n- [ ] LLVMGetSectionAddress\r\n- [ ] LLVMGetSectionContainsSymbol\r\n- [ ] LLVMGetSectionContents\r\n- [ ] LLVMGetSectionName\r\n- [ ] LLVMGetSectionSize\r\n- [ ] LLVMGetSections\r\n- [ ] LLVMGetStringAttributeAtIndex\r\n- [ ] LLVMGetStringAttributeKind\r\n- [ ] LLVMGetStringAttributeValue\r\n- [ ] LLVMGetStructElementTypes\r\n- [ ] LLVMGetStructName\r\n- [ ] LLVMGetSuccessor\r\n- [ ] LLVMGetSwitchDefaultDest\r\n- [ ] LLVMGetSymbolAddress\r\n- [ ] LLVMGetSymbolName\r\n- [ ] LLVMGetSymbolSize\r\n- [ ] LLVMGetSymbols\r\n- [ ] LLVMGetTarget\r\n- [ ] LLVMGetTargetDescription\r\n- [ ] LLVMGetTargetFromName\r\n- [ ] LLVMGetTargetMachineCPU\r\n- [ ] LLVMGetTargetMachineFeatureString\r\n- [ ] LLVMGetTargetMachineTarget\r\n- [ ] LLVMGetTargetMachineTriple\r\n- [ ] LLVMGetTargetName\r\n- [ ] LLVMGetThreadLocalMode\r\n- [ ] LLVMGetTypeContext\r\n- [ ] LLVMGetUnwindDest\r\n- [ ] LLVMGetValueKind\r\n- [ ] LLVMGetVisibility\r\n- [ ] LLVMGetVolatile\r\n- [ ] LLVMGhostLinkage\r\n- [ ] LLVMGlobalAliasValueKind\r\n- [ ] LLVMGlobalIFuncValueKind\r\n- [ ] LLVMGlobalVariableValueKind\r\n- [ ] LLVMHalfTypeInContext\r\n- [ ] LLVMHasMetadata\r\n- [ ] LLVMHasPersonalityFn\r\n- [ ] LLVMHasUnnamedAddr\r\n- [ ] LLVMHiddenVisibility\r\n- [ ] LLVMICmp\r\n- [ ] LLVMIPO\r\n- [ ] LLVMInAllocaAttribute\r\n- [ ] LLVMInRegAttribute\r\n- [ ] LLVMIndirectBr\r\n- [ ] LLVMInitialExecTLSModel\r\n- [ ] LLVMInitialize\r\n- [ ] LLVMInitializeAnalysis\r\n- [ ] LLVMInitializeCodeGen\r\n- [ ] LLVMInitializeCore\r\n- [ ] LLVMInitializeIPA\r\n- [ ] LLVMInitializeIPO\r\n- [ ] LLVMInitializeInstCombine\r\n- [ ] LLVMInitializeInstrumentation\r\n- [ ] LLVMInitializeMCJITCompilerOptions\r\n- [ ] LLVMInitializeNativeAsmParser\r\n- [ ] LLVMInitializeNativeAsmPrinter\r\n- [ ] LLVMInitializeNativeDisassembler\r\n- [ ] LLVMInitializeNativeTarget\r\n- [ ] LLVMInitializeNativeTargetAsmParser\r\n- [ ] LLVMInitializeNativeTargetAsmPrinter\r\n- [ ] LLVMInitializeNativeTargetDisassembler\r\n- [ ] LLVMInitializeObjCARCOpts\r\n- [ ] LLVMInitializeScalarOpts\r\n- [ ] LLVMInitializeTarget\r\n- [ ] LLVMInitializeTransformUtils\r\n- [ ] LLVMInitializeVectorization\r\n- [ ] LLVMInlineAsmValueKind\r\n- [ ] LLVMInlineHintAttribute\r\n- [ ] LLVMInsertBasicBlock\r\n- [ ] LLVMInsertBasicBlockInContext\r\n- [ ] LLVMInsertElement\r\n- [ ] LLVMInsertValue\r\n- [ ] LLVMInstallFatalErrorHandler\r\n- [ ] LLVMInstructionClone\r\n- [ ] LLVMInstructionEraseFromParent\r\n- [ ] LLVMInstructionRemoveFromParent\r\n- [ ] LLVMInstructionValueKind\r\n- [ ] LLVMInt128Type\r\n- [ ] LLVMInt128TypeInContext\r\n- [ ] LLVMInt16Type\r\n- [ ] LLVMInt16TypeInContext\r\n- [ ] LLVMInt1Type\r\n- [ ] LLVMInt1TypeInContext\r\n- [ ] LLVMInt32Type\r\n- [ ] LLVMInt32TypeInContext\r\n- [ ] LLVMInt64Type\r\n- [ ] LLVMInt64TypeInContext\r\n- [ ] LLVMInt8Type\r\n- [ ] LLVMInt8TypeInContext\r\n- [ ] LLVMIntToPtr\r\n- [ ] LLVMIntTypeInContext\r\n- [ ] LLVMInternalLinkage\r\n- [ ] LLVMInvoke\r\n- [ ] LLVMIsA\r\n- [ ] LLVMIsAMDNode\r\n- [ ] LLVMIsAMDString\r\n- [ ] LLVMIsAtomicSingleThread\r\n- [ ] LLVMIsCleanup\r\n- [ ] LLVMIsConditional\r\n- [ ] LLVMIsConstantString\r\n- [ ] LLVMIsDeclaration\r\n- [ ] LLVMIsEnumAttribute\r\n- [ ] LLVMIsInBounds\r\n- [ ] LLVMIsMultithreaded\r\n- [ ] LLVMIsNull\r\n- [ ] LLVMIsOpaqueStruct\r\n- [ ] LLVMIsPackedStruct\r\n- [ ] LLVMIsRelocationIteratorAtEnd\r\n- [ ] LLVMIsSectionIteratorAtEnd\r\n- [ ] LLVMIsStringAttribute\r\n- [ ] LLVMIsSymbolIteratorAtEnd\r\n- [ ] LLVMIsTailCall\r\n- [ ] LLVMJumpTableAttribute\r\n- [ ] LLVMLShr\r\n- [ ] LLVMLabelTypeInContext\r\n- [ ] LLVMLandingPad\r\n- [ ] LLVMLandingPadCatch\r\n- [ ] LLVMLandingPadClauseTy\r\n- [ ] LLVMLandingPadFilter\r\n- [ ] LLVMLinkInInterpreter\r\n- [ ] LLVMLinkInMCJIT\r\n- [ ] LLVMLinkModules2\r\n- [ ] LLVMLinkOnceAnyLinkage\r\n- [ ] LLVMLinkOnceODRAutoHideLinkage\r\n- [ ] LLVMLinkOnceODRLinkage\r\n- [ ] LLVMLinkage\r\n- [ ] LLVMLinkerDestroySource\r\n- [ ] LLVMLinkerMode\r\n- [ ] LLVMLinkerPreserveSource_Removed\r\n- [ ] LLVMLinkerPrivateLinkage\r\n- [ ] LLVMLinkerPrivateWeakLinkage\r\n- [ ] LLVMLoad\r\n- [ ] LLVMLoadLibraryPermanently\r\n- [ ] LLVMLocalDynamicTLSModel\r\n- [ ] LLVMLocalExecTLSModel\r\n- [ ] LLVMMCJITCompilerOptions\r\n- [ ] LLVMMCJITMemoryManagerRef\r\n- [ ] LLVMMDNode\r\n- [ ] LLVMMDNodeInContext\r\n- [ ] LLVMMDString\r\n- [ ] LLVMMDStringInContext\r\n- [ ] LLVMMemoryBufferRef\r\n- [ ] LLVMMemoryDefValueKind\r\n- [ ] LLVMMemoryManagerAllocateCodeSectionCallback\r\n- [ ] LLVMMemoryManagerAllocateDataSectionCallback\r\n- [ ] LLVMMemoryManagerDestroyCallback\r\n- [ ] LLVMMemoryManagerFinalizeMemoryCallback\r\n- [ ] LLVMMemoryPhiValueKind\r\n- [ ] LLVMMemoryUseValueKind\r\n- [ ] LLVMMetadataAsValueValueKind\r\n- [ ] LLVMModuleProviderRef\r\n- [ ] LLVMMoveToContainingSection\r\n- [ ] LLVMMoveToNextRelocation\r\n- [ ] LLVMMoveToNextSection\r\n- [ ] LLVMMoveToNextSymbol\r\n- [ ] LLVMMul\r\n- [ ] LLVMNakedAttribute\r\n- [ ] LLVMNestAttribute\r\n- [ ] LLVMNoAliasAttribute\r\n- [ ] LLVMNoCaptureAttribute\r\n- [ ] LLVMNoImplicitFloatAttribute\r\n- [ ] LLVMNoInlineAttribute\r\n- [ ] LLVMNoRedZoneAttribute\r\n- [ ] LLVMNoReturnAttribute\r\n- [ ] LLVMNoUnwindAttribute\r\n- [ ] LLVMNonLazyBind\r\n- [ ] LLVMNonNullAttribute\r\n- [ ] LLVMNotThreadLocal\r\n- [ ] LLVMObject\r\n- [ ] LLVMObjectFileRef\r\n- [ ] LLVMOpInfo1\r\n- [ ] LLVMOpInfoCallback\r\n- [ ] LLVMOpInfoSymbol1\r\n- [ ] LLVMOpaqueAttributeRef\r\n- [ ] LLVMOpaqueBasicBlock\r\n- [ ] LLVMOpaqueBuilder\r\n- [ ] LLVMOpaqueContext\r\n- [ ] LLVMOpaqueDiagnosticInfo\r\n- [ ] LLVMOpaqueExecutionEngine\r\n- [ ] LLVMOpaqueGenericValue\r\n- [ ] LLVMOpaqueLTOCodeGenerator\r\n- [ ] LLVMOpaqueLTOModule\r\n- [ ] LLVMOpaqueMCJITMemoryManager\r\n- [ ] LLVMOpaqueMemoryBuffer\r\n- [ ] LLVMOpaqueModule\r\n- [ ] LLVMOpaqueModuleProvider\r\n- [ ] LLVMOpaqueObjectFile\r\n- [ ] LLVMOpaquePassManager\r\n- [ ] LLVMOpaquePassManagerBuilder\r\n- [ ] LLVMOpaquePassRegistry\r\n- [ ] LLVMOpaqueRelocationIterator\r\n- [ ] LLVMOpaqueSectionIterator\r\n- [ ] LLVMOpaqueSymbolIterator\r\n- [ ] LLVMOpaqueTargetData\r\n- [ ] LLVMOpaqueTargetLibraryInfotData\r\n- [ ] LLVMOpaqueTargetMachine\r\n- [ ] LLVMOpaqueThinLTOCodeGenerator\r\n- [ ] LLVMOpaqueType\r\n- [ ] LLVMOpaqueUse\r\n- [ ] LLVMOpaqueValue\r\n- [ ] LLVMOpcode\r\n- [ ] LLVMOptimizeForSizeAttribute\r\n- [ ] LLVMOptimizeNoneAttribute\r\n- [ ] LLVMOr\r\n- [ ] LLVMOrcAddEagerlyCompiledIR\r\n- [ ] LLVMOrcAddLazilyCompiledIR\r\n- [ ] LLVMOrcAddObjectFile\r\n- [ ] LLVMOrcCreateIndirectStub\r\n- [ ] LLVMOrcCreateInstance\r\n- [ ] LLVMOrcCreateLazyCompileCallback\r\n- [ ] LLVMOrcDisposeInstance\r\n- [ ] LLVMOrcDisposeMangledSymbol\r\n- [ ] LLVMOrcErrGeneric\r\n- [ ] LLVMOrcErrSuccess\r\n- [ ] LLVMOrcErrorCode\r\n- [ ] LLVMOrcGetErrorMsg\r\n- [ ] LLVMOrcGetMangledSymbol\r\n- [ ] LLVMOrcGetSymbolAddress\r\n- [ ] LLVMOrcJIT\r\n- [ ] LLVMOrcJITStackRef\r\n- [ ] LLVMOrcLazyCompileCallbackFn\r\n- [ ] LLVMOrcModuleHandle\r\n- [ ] LLVMOrcOpaqueJITStack\r\n- [ ] LLVMOrcRemoveModule\r\n- [ ] LLVMOrcSetIndirectStubPointer\r\n- [ ] LLVMOrcSymbolResolverFn\r\n- [ ] LLVMOrcTargetAddress\r\n- [ ] LLVMPHI\r\n- [ ] LLVMPPCFP128TypeInContext\r\n- [ ] LLVMParseBitcode\r\n- [ ] LLVMParseBitcode2\r\n- [ ] LLVMParseBitcodeInContext\r\n- [ ] LLVMParseBitcodeInContext2\r\n- [ ] LLVMParseCommandLineOptions\r\n- [ ] LLVMParseIRInContext\r\n- [ ] LLVMPassManagerBuilderCreate\r\n- [ ] LLVMPassManagerBuilderDispose\r\n- [ ] LLVMPassManagerBuilderPopulateFunctionPassManager\r\n- [ ] LLVMPassManagerBuilderPopulateLTOPassManager\r\n- [ ] LLVMPassManagerBuilderPopulateModulePassManager\r\n- [ ] LLVMPassManagerBuilderRef\r\n- [ ] LLVMPassManagerBuilderSetDisableSimplifyLibCalls\r\n- [ ] LLVMPassManagerBuilderSetDisableUnitAtATime\r\n- [ ] LLVMPassManagerBuilderSetDisableUnrollLoops\r\n- [ ] LLVMPassManagerBuilderSetOptLevel\r\n- [ ] LLVMPassManagerBuilderSetSizeLevel\r\n- [ ] LLVMPassManagerBuilderUseInlinerWithThreshold\r\n- [ ] LLVMPassRegistryRef\r\n- [ ] LLVMPrintMessageAction\r\n- [ ] LLVMPrintModuleToString\r\n- [ ] LLVMPrintTypeToString\r\n- [ ] LLVMPrintValueToString\r\n- [ ] LLVMPrivateLinkage\r\n- [ ] LLVMProtectedVisibility\r\n- [ ] LLVMPtrToInt\r\n- [ ] LLVMReadNoneAttribute\r\n- [ ] LLVMReadOnlyAttribute\r\n- [ ] LLVMRecompileAndRelinkFunction\r\n- [ ] LLVMRelocationIteratorRef\r\n- [ ] LLVMRemoveAttribute\r\n- [ ] LLVMRemoveCallSiteEnumAttribute\r\n- [ ] LLVMRemoveCallSiteStringAttribute\r\n- [ ] LLVMRemoveEnumAttributeAtIndex\r\n- [ ] LLVMRemoveFunctionAttr\r\n- [ ] LLVMRemoveInstrAttribute\r\n- [ ] LLVMRemoveModule\r\n- [ ] LLVMRemoveStringAttributeAtIndex\r\n- [ ] LLVMResetFatalErrorHandler\r\n- [ ] LLVMResume\r\n- [ ] LLVMRet\r\n- [ ] LLVMReturnsTwice\r\n- [ ] LLVMRunPassManager\r\n- [ ] LLVMRunStaticConstructors\r\n- [ ] LLVMRunStaticDestructors\r\n- [ ] LLVMSDiv\r\n- [ ] LLVMSExt\r\n- [ ] LLVMSExtAttribute\r\n- [ ] LLVMSIToFP\r\n- [ ] LLVMSRem\r\n- [ ] LLVMSafeStackAttribute\r\n- [ ] LLVMSanitizeAddressAttribute\r\n- [ ] LLVMScalarOpts\r\n- [ ] LLVMSearchForAddressOfSymbol\r\n- [ ] LLVMSectionIteratorRef\r\n- [ ] LLVMSelect\r\n- [ ] LLVMSetAtomicSingleThread\r\n- [ ] LLVMSetCleanup\r\n- [ ] LLVMSetCmpXchgFailureOrdering\r\n- [ ] LLVMSetCmpXchgSuccessOrdering\r\n- [ ] LLVMSetCondition\r\n- [ ] LLVMSetCurrentDebugLocation\r\n- [ ] LLVMSetDLLStorageClass\r\n- [ ] LLVMSetDataLayout\r\n- [ ] LLVMSetDisasmOptions\r\n- [ ] LLVMSetFunctionCallConv\r\n- [ ] LLVMSetGC\r\n- [ ] LLVMSetInstDebugLocation\r\n- [ ] LLVMSetInstrParamAlignment\r\n- [ ] LLVMSetInstructionCallConv\r\n- [ ] LLVMSetIsInBounds\r\n- [ ] LLVMSetLinkage\r\n- [ ] LLVMSetMetadata\r\n- [ ] LLVMSetModuleDataLayout\r\n- [ ] LLVMSetModuleIdentifier\r\n- [ ] LLVMSetModuleInlineAsm\r\n- [ ] LLVMSetNormalDest\r\n- [ ] LLVMSetOperand\r\n- [ ] LLVMSetOrdering\r\n- [ ] LLVMSetParamAlignment\r\n- [ ] LLVMSetPersonalityFn\r\n- [ ] LLVMSetSection\r\n- [ ] LLVMSetSuccessor\r\n- [ ] LLVMSetTailCall\r\n- [ ] LLVMSetTarget\r\n- [ ] LLVMSetTargetMachineAsmVerbosity\r\n- [ ] LLVMSetThreadLocalMode\r\n- [ ] LLVMSetUnnamedAddr\r\n- [ ] LLVMSetUnwindDest\r\n- [ ] LLVMSetVisibility\r\n- [ ] LLVMSetVolatile\r\n- [ ] LLVMShl\r\n- [ ] LLVMShuffleVector\r\n- [ ] LLVMShutdown\r\n- [ ] LLVMStackAlignment\r\n- [ ] LLVMStackProtectAttribute\r\n- [ ] LLVMStackProtectReqAttribute\r\n- [ ] LLVMStackProtectStrongAttribute\r\n- [ ] LLVMStartMultithreaded\r\n- [ ] LLVMStopMultithreaded\r\n- [ ] LLVMStore\r\n- [ ] LLVMStructGetTypeAtIndex\r\n- [ ] LLVMStructRetAttribute\r\n- [ ] LLVMStructTypeInContext\r\n- [ ] LLVMSub\r\n- [ ] LLVMSwiftErrorAttribute\r\n- [ ] LLVMSwiftSelfAttribute\r\n- [ ] LLVMSwitch\r\n- [ ] LLVMSymbolIteratorRef\r\n- [ ] LLVMSymbolLookupCallback\r\n- [ ] LLVMTarget\r\n- [ ] LLVMTargetHasAsmBackend\r\n- [ ] LLVMTargetHasJIT\r\n- [ ] LLVMTargetHasTargetMachine\r\n- [ ] LLVMTargetLibraryInfoRef\r\n- [ ] LLVMTargetMachineEmitToMemoryBuffer\r\n- [ ] LLVMThreadLocalMode\r\n- [ ] LLVMTrunc\r\n- [ ] LLVMTypeIsSized\r\n- [ ] LLVMTypeKind\r\n- [ ] LLVMUDiv\r\n- [ ] LLVMUIToFP\r\n- [ ] LLVMURem\r\n- [ ] LLVMUWTable\r\n- [ ] LLVMUndefValueValueKind\r\n- [ ] LLVMUnreachable\r\n- [ ] LLVMUserOp1\r\n- [ ] LLVMUserOp2\r\n- [ ] LLVMVAArg\r\n- [ ] LLVMValueAsBasicBlock\r\n- [ ] LLVMValueIsBasicBlock\r\n- [ ] LLVMValueKind\r\n- [ ] LLVMValueRefs\r\n- [ ] LLVMVectorize\r\n- [ ] LLVMVerifierFailureAction\r\n- [ ] LLVMVerifyFunction\r\n- [ ] LLVMViewFunctionCFG\r\n- [ ] LLVMViewFunctionCFGOnly\r\n- [ ] LLVMVisibility\r\n- [ ] LLVMVoidTypeInContext\r\n- [ ] LLVMWeakAnyLinkage\r\n- [ ] LLVMWeakODRLinkage\r\n- [ ] LLVMWebKitJSCallConv\r\n- [ ] LLVMWriteBitcodeToFD\r\n- [ ] LLVMWriteBitcodeToFileHandle\r\n- [ ] LLVMWriteBitcodeToMemoryBuffer\r\n- [ ] LLVMX86FP80TypeInContext\r\n- [ ] LLVMX86FastcallCallConv\r\n- [ ] LLVMX86MMXTypeInContext\r\n- [ ] LLVMX86StdcallCallConv\r\n- [ ] LLVMXor\r\n- [ ] LLVMYieldCallback\r\n- [ ] LLVMZExt\r\n- [ ] LLVMZExtAttribute\r\n- [ ] LLVM_ASM_PARSER\r\n- [ ] LLVM_ASM_PRINTER\r\n- [ ] LLVM_C_ANALYSIS_H\r\n- [ ] LLVM_C_BITREADER_H\r\n- [ ] LLVM_C_BITWRITER_H\r\n- [ ] LLVM_C_CORE_H\r\n- [ ] LLVM_C_DISASSEMBLER_H\r\n- [ ] LLVM_C_ERROR_HANDLING_H\r\n- [ ] LLVM_C_EXECUTIONENGINE_H\r\n- [ ] LLVM_C_INITIALIZATION_H\r\n- [ ] LLVM_C_IRREADER_H\r\n- [ ] LLVM_C_LINKER_H\r\n- [ ] LLVM_C_LINKTIMEOPTIMIZER_H\r\n- [ ] LLVM_C_LTO_H\r\n- [ ] LLVM_C_OBJECT_H\r\n- [ ] LLVM_C_ORCBINDINGS_H\r\n- [ ] LLVM_C_SUPPORT_H\r\n- [ ] LLVM_C_TARGETMACHINE_H\r\n- [ ] LLVM_C_TARGET_H\r\n- [ ] LLVM_C_TRANSFORMS_IPO_H\r\n- [ ] LLVM_C_TRANSFORMS_PASSMANAGERBUILDER_H\r\n- [ ] LLVM_C_TRANSFORMS_SCALAR_H\r\n- [ ] LLVM_C_TRANSFORMS_VECTORIZE_H\r\n- [ ] LLVM_C_TYPES_H\r\n- [ ] LLVM_DECLARE_VALUE_CAST\r\n- [ ] LLVM_DISASSEMBLER\r\n- [ ] LLVM_ENABLE_THREADS\r\n- [ ] LLVM_FOR_EACH_VALUE_SUBCLASS\r\n- [ ] LLVM_LTO_ASM_FAILURE\r\n- [ ] LLVM_LTO_MODULE_MERGE_FAILURE\r\n- [ ] LLVM_LTO_NO_TARGET\r\n- [ ] LLVM_LTO_NO_WORK\r\n- [ ] LLVM_LTO_NULL_OBJECT\r\n- [ ] LLVM_LTO_OPT_SUCCESS\r\n- [ ] LLVM_LTO_READ_FAILURE\r\n- [ ] LLVM_LTO_READ_SUCCESS\r\n- [ ] LLVM_LTO_UNKNOWN\r\n- [ ] LLVM_LTO_WRITE_FAILURE\r\n- [ ] LLVM_NATIVE_ASMPARSER\r\n- [ ] LLVM_NATIVE_ASMPRINTER\r\n- [ ] LLVM_NATIVE_DISASSEMBLER\r\n- [ ] LLVM_NATIVE_TARGET\r\n- [ ] LLVM_NATIVE_TARGETINFO\r\n- [ ] LLVM_NATIVE_TARGETMC\r\n- [ ] LLVM_TARGET",
"title": "Missing Functionality in LLVMSwift",
"type": "issue"
},
{
"action": "created",
"author": "harlanhaskins",
"comment_id": 275488117,
"datetime": 1485459086000,
"masked_author": "username_1",
"text": "Thank you!!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "blacktop",
"comment_id": 613677896,
"datetime": 1586897886000,
"masked_author": "username_2",
"text": "+1 for Disassembly API coverage 🙏",
"title": null,
"type": "comment"
}
] | 26,959 | false | false | 3 | 3 | false |
ssllabs/ssllabs-scan | ssllabs | 48,278,028 | 19 | null | [
{
"action": "opened",
"author": "andrepereiradasilva",
"comment_id": null,
"datetime": 1415634307000,
"masked_author": "username_0",
"text": "The api results doesn't return some information that is in the online version.\r\nI detected this ones:\r\n- Chain certificates: [Signature Algorithm (ex: for SHA1 warnings) | Key ]\r\n- PCI compliant\r\n- FIPS-ready",
"title": "Missing data from online version?",
"type": "issue"
},
{
"action": "created",
"author": "andrepereiradasilva",
"comment_id": 68862452,
"datetime": 1420549469000,
"masked_author": "username_0",
"text": "Don't know if you know, but ENISA plublished a new recommendations report. They divided their old report in two:\r\n\r\n**Study on cryptographic protocols**\r\nhttp://www.enisa.europa.eu/activities/identity-and-trust/library/deliverables/study-on-cryptographic-protocols\r\n\r\n**Algorithms, key size and parameters report 2014**\r\nhttp://www.enisa.europa.eu/activities/identity-and-trust/library/deliverables/algorithms-key-size-and-parameters-report-2014",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ivanr",
"comment_id": 83998237,
"datetime": 1426853811000,
"masked_author": "username_1",
"text": "Done in 1.16.1, now running on dev.ssllabs.com. New fields are: sigAlg, notBefore, notAfter, keyAlg, keyStrength, keySize.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ivanr",
"comment_id": null,
"datetime": 1426853811000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 775 | false | false | 2 | 4 | false |
auth0/passport-linkedin-oauth2 | auth0 | 67,663,211 | 29 | null | [
{
"action": "opened",
"author": "boris-petrov1214",
"comment_id": null,
"datetime": 1428693537000,
"masked_author": "username_0",
"text": "",
"title": "linkedin announced the breaking change in their developer program, will that affect the library?",
"type": "issue"
},
{
"action": "created",
"author": "xeroxoid",
"comment_id": 101832967,
"datetime": 1431555115000,
"masked_author": "username_1",
"text": "It seems that it has...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xeroxoid",
"comment_id": 101842122,
"datetime": 1431558019000,
"masked_author": "username_1",
"text": "So to get your app to work you have to limit your scope to the now allowed permissions. i.e.:\r\n\r\n````javascript\r\n ...\r\n linkedinStrategy = new LinkedInStrategy({\r\n clientID: config.linkedin.clientID,\r\n clientSecret: config.linkedin.clientSecret,\r\n callbackURL: config.linkedin.callbackURL,\r\n scope: ['r_basicprofile', 'w_share', 'r_emailaddress' ],\r\n passReqToCallback: true\r\n },...\r\n ...\r\n````\r\n\r\nSo no more leeching on them profiles :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sidonaldson",
"comment_id": 102366185,
"datetime": 1431686674000,
"masked_author": "username_2",
"text": "Yup, so \"r_contactinfo\" is now allowed only for authorised partners. I guess they want you to still use linkedin ;)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chewedon",
"comment_id": 126941924,
"datetime": 1438451487000,
"masked_author": "username_3",
"text": "I'm using Sailsjs. \r\n\r\nThe call to: \r\n\r\n login: function(req, res) {\t\t\r\n\t\tpassport.authenticate('linkedin', function(err, user, info) {\r\n\t\t\t// The request will be redirected to LinkedIn for authentication, so this \r\n \t\t // function will not be called. \r\n\t\t});\r\n }\r\n\r\nDoes not redirect the user to the Linkedin login prompt for the user to enter email and password, could it be related to Linkedin's server changes or am I using this library in a wrong way ?\r\n\r\nAt the moment, my browser just hangs there, spinning and never completing the request for an access token.",
"title": null,
"type": "comment"
}
] | 1,189 | false | false | 4 | 5 | false |
srmeier/KnightOnline | null | 219,376,119 | 42 | null | [
{
"action": "opened",
"author": "Demircivi",
"comment_id": null,
"datetime": 1491338426000,
"masked_author": "username_0",
"text": "You were able to switch between pages by using mouse wheel in Item buy page of any NPC in 1299.",
"title": "Navigating with mouse wheel in NPC items",
"type": "issue"
},
{
"action": "closed",
"author": "twostars",
"comment_id": null,
"datetime": 1495235249000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "twostars",
"comment_id": 302830263,
"datetime": 1495235249000,
"masked_author": "username_1",
"text": "This issue was moved to ApexKO/OpenKO#42",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "twostars",
"comment_id": null,
"datetime": 1504483645000,
"masked_author": "username_1",
"text": "You were able to switch between pages by using mouse wheel in Item buy page of any NPC in 1299.",
"title": "Navigating with mouse wheel in NPC items",
"type": "issue"
}
] | 230 | false | false | 2 | 4 | false |
opentable/oc | opentable | 217,268,119 | 423 | {
"number": 423,
"repo": "oc",
"user_login": "opentable"
} | [
{
"action": "opened",
"author": "nickbalestra",
"comment_id": null,
"datetime": 1490625593000,
"masked_author": "username_0",
"text": "- [x] CLi dev configure with `oc-template-jade` and `oc-template-handlebars` by default\r\n- [x] `getTemplate()` helper for the repository to leverage on template.getInfo() API\r\n- [x] add templates to contextObj\r\n\r\n@matteofigus did I miss anything? (Still WIP)",
"title": "[WIP][GPT-517] Exposing registry supported templates via context",
"type": "issue"
},
{
"action": "created",
"author": "nickbalestra",
"comment_id": 289484558,
"datetime": 1490627586000,
"masked_author": "username_0",
"text": "Want to add some tests for this",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nickbalestra",
"comment_id": 290123829,
"datetime": 1490800759000,
"masked_author": "username_0",
"text": "@matteofigus Added some test, and some error handling. Also removed the need to define core-templates in the conf (next will need to see how to extend this dinamically for dev).",
"title": null,
"type": "comment"
}
] | 467 | false | false | 1 | 3 | false |
Microsoft/vscode | Microsoft | 172,334,733 | 10,764 | null | [
{
"action": "opened",
"author": "yesmar",
"comment_id": null,
"datetime": 1471805173000,
"masked_author": "username_0",
"text": "- VSCode Version: 1.4.0\r\n- OS Version: OS X 10.11.6, Ubuntu Linux 16.04.1 and Windows 10\r\n\r\nSteps to Reproduce:\r\n\r\n1. Open up a new terminal window\r\n2. Invoke VSCode thusly: `code -g :` or `code -g :9`\r\n\r\nIf you invoke VSCode from the command line with the `-g` switch but pass in bogus data (specifically, a `:` by itself or with a line number), VSCode will fail with an uncaught exception:\r\n\r\n\r\n\r\nThe exception is the same regardless of OS, which is expected.\r\n\r\nPassing `-g` with no argument will cause VSCode to open normally, as will passing in `-g file`, `-g file:` or `-g file:9`.\r\n\r\nRecommended behavior for `-g :` and `-g :9` is to act is if `-g` were passed alone. That is, open up a new buffer, but don't try to do any parsing or take anything for granted.",
"title": "Bogus user input on the command line shouldn't result in an uncaught exception",
"type": "issue"
},
{
"action": "closed",
"author": "joaomoreno",
"comment_id": null,
"datetime": 1471859777000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 906 | false | false | 2 | 2 | false |
fortunejs/fortune | fortunejs | 168,035,567 | 229 | null | [
{
"action": "opened",
"author": "0x8890",
"comment_id": null,
"datetime": 1469692721000,
"masked_author": "username_0",
"text": "this limits the space allowed to the system memory. use disk instead.",
"title": "Do not use memory in IndexedDB adapter",
"type": "issue"
},
{
"action": "created",
"author": "0x8890",
"comment_id": 239406947,
"datetime": 1470995563000,
"masked_author": "username_0",
"text": "Giving this more thought, actually I think that it would be useful to replace Buffer types with IDs so that they can be de-referenced. Then this Buffer collection would not be loaded in memory, but instead would be accessed like any other collection. This memory optimizing behavior should be opt-in because it changes how data is accessed.\r\n\r\nAlso, the IndexedDB adapter should implement LRU like the memory adapter does, otherwise it would result in records being lost but still on disk.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "0x8890",
"comment_id": null,
"datetime": 1476202029000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "0x8890",
"comment_id": 252963609,
"datetime": 1476202029000,
"masked_author": "username_0",
"text": "Actually I think this might not be a good idea since it's too complicated and won't matter unless storing lots of data.",
"title": null,
"type": "comment"
}
] | 677 | false | false | 1 | 4 | false |
alexhultman/libvc | null | 140,860,375 | 4 | {
"number": 4,
"repo": "libvc",
"user_login": "alexhultman"
} | [
{
"action": "opened",
"author": "minzmann",
"comment_id": null,
"datetime": 1458011946000,
"masked_author": "username_0",
"text": "",
"title": "Fixed small typo",
"type": "issue"
},
{
"action": "created",
"author": "alexhultman",
"comment_id": 196635427,
"datetime": 1458012112000,
"masked_author": "username_1",
"text": "Lol. Thanks",
"title": null,
"type": "comment"
}
] | 11 | false | false | 2 | 2 | false |
rails/rails | rails | 53,857,071 | 18,421 | {
"number": 18421,
"repo": "rails",
"user_login": "rails"
} | [
{
"action": "opened",
"author": "txus",
"comment_id": null,
"datetime": 1420801658000,
"masked_author": "username_0",
"text": "Strong parameters included `Rack::Test::UploadedFile` as a permitted scalar in 91d1ac0, adding an implicit dependency on `rack/test`. This commit makes that explicit so that cherry-picking on Rails modules (for instance using rails-api) doesn't break strong parameters.",
"title": "Add missing require \"rack/test\"",
"type": "issue"
},
{
"action": "created",
"author": "rafaelfranca",
"comment_id": 69363734,
"datetime": 1420822881000,
"masked_author": "username_1",
"text": "Not sure if it is a good idea to add a test library as runtime dependency of strong parameters. But if we will do this can we require only upload_file?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "carlosantoniodasilva",
"comment_id": 69512166,
"datetime": 1421011403000,
"masked_author": "username_2",
"text": "/cc @username_3",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "txus",
"comment_id": 69538857,
"datetime": 1421050403000,
"masked_author": "username_0",
"text": "@username_1 I know, I cringed at that too. However rack-test *is* already a runtime dependency of strong parameters (introduced in 91d1ac0), albeit implicit -- I'm just making it explicit.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fxn",
"comment_id": 69717896,
"datetime": 1421141725000,
"masked_author": "username_3",
"text": "First a point about the need of an explicit require, which is the motivation for the PR.\r\n\r\nThe Rails code base is big, and we use Ruby autoloading to avoid repeating requires where we feel it pays off. Contract is that any client code should load the main file of a Rails component, you can't just cherry-pick a random file from a Rails library. The entry point of every Rails library declares autoloads among other things. See for example [*active_record.rb*](https://github.com/rails/rails/blob/master/activerecord/lib/active_record.rb).\r\n\r\nIn that line, every Rails component is also responsible for loading [*active_support/rails.rb*](https://github.com/rails/rails/blob/master/activesupport/lib/active_support/rails.rb), and thus no internal file is supposed to explicitly load any of those ones. You can freely use `blank?` for example, no need to put an explicit require for it (and it would be against project rules to do so).\r\n\r\nSo, in that sense, I am :-1: on the explicit require.\r\n\r\nAnother debate is whether `rack/test` should be loaded as a side-effect of the current autoload in Action Dispatch. That should not happen. Why do we have that autoload in a so [prominent place](https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch.rb#L31-L33)? Could we move it closer to something that is only evaluated in a test environment perhaps? (Note that `defined?(Rack::Test)` returns true because there's an autoload, so we cannot conditionally add the class.)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ferdy89",
"comment_id": 172732199,
"datetime": 1453176701000,
"masked_author": "username_4",
"text": "This was already implemented here https://github.com/rails/rails/pull/22475 so that makes this issue stale",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "arthurnn",
"comment_id": 175672904,
"datetime": 1453907119000,
"masked_author": "username_5",
"text": "indeed this was done on https://github.com/rails/rails/pull/22475. Thanks @username_4 for noticing.\r\n\r\n@username_6 have you saw this discussion before doing that? thoughts? cc @matthewd",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "claudiob",
"comment_id": 175733797,
"datetime": 1453912688000,
"masked_author": "username_6",
"text": "No thoughts about it, whatever works :wink:",
"title": null,
"type": "comment"
}
] | 2,434 | false | false | 7 | 8 | true |
funkia/turbine | funkia | 231,911,897 | 56 | null | [
{
"action": "opened",
"author": "dmitriz",
"comment_id": null,
"datetime": 1496023249000,
"masked_author": "username_0",
"text": "Motivated by the discussion in https://github.com/uzujs/uzu/issues/6#issuecomment-304519136,\r\nmaybe taking out the local Storage here as external parameter would make the data flow more explicit:\r\nhttps://github.com/funkia/turbine/blob/master/examples/todo/src/TodoApp.ts#L69\r\n\r\nSomehow I feel it does not really belong to the main app but comes from outside.\r\n\r\nIt might be interesting to compare with the implementation here:\r\nhttps://github.com/briancavalier/most-todomvc/blob/master/src/index.js#L75",
"title": "Take the localStorage out as parameter?",
"type": "issue"
}
] | 503 | false | false | 1 | 1 | false |
goaop/framework | goaop | 141,150,765 | 261 | null | [
{
"action": "opened",
"author": "DavertMik",
"comment_id": null,
"datetime": 1458093771000,
"masked_author": "username_0",
"text": "Looks like current have big issues with parsing php code with \"::class\" in it. \r\n\r\nCode to reproduce:\r\n\r\n```php\r\n<?php\r\nrequire_once 'vendor/autoload.php';\r\n\r\n$string = \"<?php\r\nreturn [\r\n 'user' => User::class\r\n];\r\n\";\r\n\r\nerror_reporting(-1);\r\nini_set('display_errors', 'On');\r\nerror_reporting(E_ALL);\r\n$broker = new \\TokenReflection\\Broker(new \\TokenReflection\\Broker\\Backend\\Memory());\r\n$broker->processString($string, 'reflection_test.php');\r\necho \"done\";\r\n\r\n```\r\n\r\nInstalled packages:\r\n\r\n```\r\n➜ AspectMock git:(master) ✗ composer show\r\nYou are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug\r\nandrewsville/php-token-reflection 1.4.0 Library emulating the PHP internal reflection using just the tokenized source code.\r\ncodeception/base 2.1.5 BDD-style testing framework\r\ncodeception/specify 0.4.3 BDD code blocks for PHPUnit and Codeception\r\ncodeception/verify 0.3.0 BDD assertion library for PHPUnit\r\ndoctrine/annotations v1.2.7 Docblock Annotations Parser\r\ndoctrine/instantiator 1.0.5 A small, lightweight utility to instantiate objects in PHP without invoking their constructors\r\ndoctrine/lexer v1.0.1 Base library for a lexer that can be used in Top-Down, Recursive Descent Parsers.\r\ngoaop/framework 1.0.2 Framework for aspect-oriented programming in PHP.\r\nguzzlehttp/psr7 1.2.3 PSR-7 message implementation\r\njakubledl/dissect v1.0.1 Lexing and parsing in pure PHP\r\nmyclabs/deep-copy 1.5.0 Create deep copies (clones) of your objects\r\nphpdocumentor/reflection-docblock 2.0.4 \r\nphpspec/prophecy v1.6.0 Highly opinionated mocking framework for PHP 5.3+\r\nphpunit/php-code-coverage 2.2.4 Library that provides collection, processing, and rendering functionality for PHP code coverage information.\r\nphpunit/php-file-iterator 1.4.1 FilterIterator implementation that filters files based on a list of suffixes.\r\nphpunit/php-text-template 1.2.1 Simple template engine.\r\nphpunit/php-timer 1.0.7 Utility class for timing\r\nphpunit/php-token-stream 1.4.8 Wrapper around PHP's tokenizer extension.\r\nphpunit/phpunit 4.8.24 The PHP Unit Testing framework.\r\nphpunit/phpunit-mock-objects 2.3.8 Mock Object library for PHPUnit\r\npsr/http-message 1.0 Common interface for HTTP messages\r\nsebastian/comparator 1.2.0 Provides the functionality to compare PHP values for equality\r\nsebastian/diff 1.4.1 Diff implementation\r\nsebastian/environment 1.3.5 Provides functionality to handle HHVM/PHP environments\r\nsebastian/exporter 1.2.1 Provides the functionality to export PHP variables for visualization\r\nsebastian/global-state 1.1.1 Snapshotting of global state\r\nsebastian/recursion-context 1.0.2 Provides functionality to recursively process PHP variables\r\nsebastian/version 1.0.6 Library that helps with managing the version number of Git-hosted PHP projects\r\nsymfony/browser-kit v3.0.3 Symfony BrowserKit Component\r\nsymfony/console v3.0.3 Symfony Console Component\r\nsymfony/css-selector v3.0.3 Symfony CssSelector Component\r\nsymfony/dom-crawler v3.0.3 Symfony DomCrawler Component\r\nsymfony/event-dispatcher v3.0.3 Symfony EventDispatcher Component\r\nsymfony/finder v3.0.3 Symfony Finder Component\r\nsymfony/polyfill-mbstring v1.1.1 Symfony polyfill for the Mbstring extension\r\nsymfony/yaml v3.0.3 Symfony Yaml Component\r\n\r\n```",
"title": "::class issues",
"type": "issue"
},
{
"action": "created",
"author": "DavertMik",
"comment_id": 197115623,
"datetime": 1458094549000,
"masked_author": "username_0",
"text": "However, this code works:\r\n\r\n```php\r\nclass UserModel {\r\n public function getClass() {\r\n\r\n return User::class();\r\n}\r\n}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DavertMik",
"comment_id": 197116417,
"datetime": 1458094793000,
"masked_author": "username_0",
"text": "I know that's the issue of tokenizer and not of Go AOP itself, but as php-tokenizer is deprecated I'm not sure what to do next. Should I try to patch it and send a PR or use one of the works like `kornrunner/php-token-reflection`? Or just switch to PHP-Parser and Go AOP v2?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lisachenko",
"comment_id": 197358708,
"datetime": 1458139097000,
"masked_author": "username_1",
"text": "I think the best option here is to drop 1.x version of framework and give a try for 2.x-dev, it relies on `nikic/PHP-Parser` and can be considered more reliable and supported. As a bonus, you will get a support for PHP5.6 and PHP7 syntax.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DavertMik",
"comment_id": 197385552,
"datetime": 1458142423000,
"masked_author": "username_0",
"text": "Yeah, I managed to overcome this issue by not loading this exact file. \r\nOk, can you create a tag got 2.0 branch so I could try it on my project?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lisachenko",
"comment_id": 197422718,
"datetime": 1458147382000,
"masked_author": "username_1",
"text": "Yes, will do it this evening",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lisachenko",
"comment_id": 201244757,
"datetime": 1458904986000,
"masked_author": "username_1",
"text": "This issue related only to the 1.x branch and already fixed in the master. Closing it.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "lisachenko",
"comment_id": null,
"datetime": 1458904987000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 4,677 | false | false | 2 | 8 | false |
irods/irods | irods | 201,014,425 | 3,442 | null | [
{
"action": "opened",
"author": "vincent-legoll",
"comment_id": null,
"datetime": 1484571905000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nI'm new to irods, I installed the icommands on a fresh centos 7 VM,\r\nfollowing https://packages.irods.org recipe:\r\n```\r\nrpm --import https://packages.irods.org/irods-signing-key.asc\r\nwget -qO - https://packages.irods.org/renci-irods.yum.repo > /etc/yum.repos.d/renci-irods.yum.repo\r\nyum -y install irods-icommands\r\n```\r\n\r\nThen I iinit'ed my given credentials, and tested it works OK:\r\n```\r\n$ ils /\r\n/:\r\n C- /FRGRID\r\n$ imkdir test\r\n$ ils\r\n/FRGRID/home/vlegoll:\r\n C- /FRGRID/home/vlegoll/test\r\n[vince@vl-irods-test ~]$ ils -A\r\n/FRGRID/home/vlegoll:\r\n ACL - vlegoll#FRGRID:own \r\n Inheritance - Disabled\r\n C- /FRGRID/home/vlegoll/test\r\n```\r\n\r\nBut when trying to get more tested, I stumbled upon that error:\r\n```\r\n$ iput test.txt\r\nremote addresses: 134.158.239.52 ERROR: putUtil: put error for /FRGRID/home/vlegoll/test.txt, status = -321000 status = -321000 USER_NO_RESC_INPUT_ERR\r\nLevel 0: DEBUG: execMicroService3: error when executing microservice\r\nline 172, col 26, rule base core\r\nacSetRescSchemeForCreate {msiSetDefaultResc(\"demoResc\",\"null\"); }\r\n```\r\n\r\nIs this meant to be understandable ? What am I missing ?\r\n\r\nThe iRods service I'm connecting to is a 3.X (I think) whereas the client I installed is (probably) 4.2.X.\r\n\r\nIs there nothing to give meaningful error messages in case the backwards compatibility has been broken between those versions ?",
"title": "iput cryptic error message",
"type": "issue"
},
{
"action": "created",
"author": "trel",
"comment_id": 272870258,
"datetime": 1484575699000,
"masked_author": "username_1",
"text": "Hi Vincent,\r\n\r\nBackwards compatibility has been a top goal, but mostly focused on server-to-server compatibility across a Federation of two differently versioned Zones. If you're connecting to a 3.x Zone, it will be instructive to see whether the 3.x iCommands connect without any trouble. You can confirm that the server is of a certain version with `imiscsvrinfo`.\r\n\r\nThe USER_NO_RESC_INPUT_ERR error itself suggests a possible misconfiguration on the server side - can you confirm that there is (not) a storage resource named `demoResc` in the Zone? If the goal is to get files to land on a differently named resource by default, then the server needs to update the target of the `acSetRescSchemeForCreate` rule in `core.re`.\r\n\r\nIf you know the name of the storage resource you'd like files to land on, you can also try to put files there directly with:\r\n```\r\n$ iput -R <resc_name> test.txt\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vincent-legoll",
"comment_id": 272876035,
"datetime": 1484577108000,
"masked_author": "username_0",
"text": "How would I do that ?\r\n\r\nBut following your suggestion about ```iput -R```, I think something is not fully configured on my side, because I got ```irodsDefResource``` from my irods administrator, that I didn't know how to use. And using it with -R made it work OK.\r\n\r\nAnd now with a bit of guessworks, I put it in \"irods_default_resource\" in .irods/irods_environment.json, and all is working properly client 4.2.X, servers on 3.3.1 !\r\n\r\nNow the question remains about the cryptic error message...\r\n\r\nMaybe adding a warning could help a bit:\r\n\"No resource specified, using default: 'demoResc'\"",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "trel",
"comment_id": null,
"datetime": 1508380486000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "vincent-legoll",
"comment_id": 337826243,
"datetime": 1508399039000,
"masked_author": "username_0",
"text": "@username_1 the doc fix LGTM, thanks",
"title": null,
"type": "comment"
}
] | 2,905 | false | false | 2 | 5 | true |
prometheus/prometheus | prometheus | 152,044,928 | 1,607 | null | [
{
"action": "opened",
"author": "harneksidhu",
"comment_id": null,
"datetime": 1462040703000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nI am trying to find some documentation on how to setup basic authentication for the Prometheus database. I was not able to find anything on Prometheus' documentation. However, I notice Grafana mentions that basic auth is possible for Prometheus http://docs.grafana.org/datasources/prometheus/.\r\n\r\nIs basic authentication possible and if so, where can I find the appropriate instructions in the documentation?\r\n\r\nThanks!",
"title": "Prometheus Basic Authentication",
"type": "issue"
},
{
"action": "created",
"author": "barkerd427",
"comment_id": 215985660,
"datetime": 1462041123000,
"masked_author": "username_1",
"text": "I believe this is done by putting something line nginx in front of it. I\nknow of no authentication within Prometheus.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "beorn7",
"comment_id": 215986953,
"datetime": 1462042302000,
"masked_author": "username_2",
"text": "Answer is here: http://www.robustperception.io/adding-basic-auth-to-prometheus-with-nginx/",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "beorn7",
"comment_id": null,
"datetime": 1462042302000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 637 | false | true | 3 | 4 | false |
scikit-learn/scikit-learn | scikit-learn | 251,648,120 | 9,593 | {
"number": 9593,
"repo": "scikit-learn",
"user_login": "scikit-learn"
} | [
{
"action": "opened",
"author": "reiinakano",
"comment_id": null,
"datetime": 1503319417000,
"masked_author": "username_0",
"text": "<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\n<!-- Example: Fixes #1234 -->\r\nFixes #9589 \r\n\r\n#### What does this implement/fix? Explain your changes.\r\nI figured that the purpose of this code (original)\r\n\r\n```python\r\nif method in ['decision_function', 'predict_proba', 'predict_log_proba']:\r\n n_classes = len(set(y))\r\n predictions_ = np.zeros((X_test.shape[0], n_classes))\r\n if method == 'decision_function' and len(estimator.classes_) == 2:\r\n predictions_[:, estimator.classes_[-1]] = predictions\r\n else:\r\n predictions_[:, estimator.classes_] = predictions\r\n predictions = predictions_\r\n```\r\n\r\nis to handle cases where the cross-validation done in `cross_val_predict` doesn't properly stratify the classes i.e. one fold in the CV may not have all classes present.\r\n\r\nHowever, it misses an edge case for `decision_function` when `len(estimator.classes_) == 2` (train split has only 2 classes) and `n_classes == 2` (total data has only 2 classes). It wrongly assumes that the output will be of shape `(n_samples, n_classes)`, when in fact, this is only true for `decision_function` if `n_classes > 2`. For the correct behavior, we must first check if the total number of classes is greater than 2, and if it is not, we must stick to an output shape of `(n_samples,)`.\r\n\r\n#### Any other comments?\r\n\r\nWhile this PR fixes the case raised in #9589, it still doesn't take into account the fact that for `sklearn.svm.SVC`, `decision_function` does not always follow the shape `(n_samples, n_classes)` or `(n_samples,)`. If `decision_function_shape` is not set to `ovr`, the shape is `(n_samples, n_classes * (n_classes-1) / 2)`, and if different train splits have different numbers of classes (not stratified), this inconsistency can't be fixed by the approach currently taken by `cross_val_predict`.\r\n\r\nI would also like to point out my personal opinion that `cross_val_predict` should probably just throw an error if the classes are not stratified properly (by this I mean some classes are entirely absent in some splits) instead of handling it automatically as it tries to do now. Metrics like log loss and ROC might be affected if for some splits, entire columns are zeroed out. Idk, it just feels inconsistent. Of course, you guys have the final say on this.\r\n\r\nWhat I mean by inconsistent:\r\n\r\n```python\r\nfrom sklearn.model_selection import cross_val_predict, KFold\r\nfrom sklearn.datasets import load_iris\r\nfrom sklearn.linear_model import LogisticRegression\r\n\r\nX, y = load_iris(True)\r\ncross_val_predict(LogisticRegression(), X, y, cv=KFold().split(X), method='predict_proba')\r\n```\r\n\r\nreturns (array cut down in size)\r\n\r\n```\r\narray([[ 0.00000000e+00, 9.99987841e-01, 1.21585683e-05],\r\n [ 0.00000000e+00, 9.99963190e-01, 3.68104260e-05],\r\n [ 0.00000000e+00, 9.99970224e-01, 2.97757119e-05],\r\n [ 0.00000000e+00, 9.99978481e-01, 2.15185386e-05],\r\n [ 0.00000000e+00, 9.99993136e-01, 6.86428459e-06],\r\n [ 1.20030529e-01, 0.00000000e+00, 8.79969471e-01],\r\n [ 1.13183668e-01, 0.00000000e+00, 8.86816332e-01],\r\n [ 6.75506225e-02, 0.00000000e+00, 9.32449377e-01],\r\n [ 1.07273496e-01, 0.00000000e+00, 8.92726504e-01],\r\n [ 1.26854747e-01, 0.00000000e+00, 8.73145253e-01],\r\n [ 1.16881976e-01, 0.00000000e+00, 8.83118024e-01],\r\n [ 2.45077442e-04, 9.99754923e-01, 0.00000000e+00],\r\n [ 2.70475201e-04, 9.99729525e-01, 0.00000000e+00],\r\n [ 6.59523734e-04, 9.99340476e-01, 0.00000000e+00],\r\n [ 4.07574999e-04, 9.99592425e-01, 0.00000000e+00],\r\n [ 2.42451670e-03, 9.97575483e-01, 0.00000000e+00],\r\n [ 2.03959503e-03, 9.97960405e-01, 0.00000000e+00]])\r\n```\r\nNotice how there are \"zeroed out\" columns.\r\n\r\nAnd even worse:\r\n\r\n```python\r\nfrom sklearn.model_selection import cross_val_predict, KFold\r\nfrom sklearn.datasets import load_iris\r\nfrom sklearn.linear_model import LogisticRegression\r\n\r\nX, y = load_iris(True)\r\ncross_val_predict(LogisticRegression(), X, y, cv=KFold().split(X), method='decision_function')\r\n```\r\nreturns (array cut down in size)\r\n```\r\narray([[ 0. , 0. , -11.31746426],\r\n [ 0. , 0. , -10.20969263],\r\n [ 0. , 0. , -10.42178776],\r\n [ 0. , 0. , -9.60397656],\r\n [ 0. , 0. , -11.30005126],\r\n [ 0. , 0. , -11.1906238 ],\r\n [ 0. , 0. , -10.05510072],\r\n [ 0. , 0. , -10.74657422],\r\n [ 0. , 0. , -9.20295991],\r\n [ 0. , 8.3136912 , 0. ],\r\n [ 0. , 6.77281268, 0. ],\r\n [ 0. , 7.79874366, 0. ],\r\n [ 0. , 7.29615134, 0. ],\r\n [ 0. , 7.9199709 , 0. ],\r\n [ 0. , 9.163118 , 0. ],\r\n [ 0. , 5.8858718 , 0. ],\r\n [ 0. , 6.37425957, 0. ],\r\n [ 0. , 6.66261924, 0. ],\r\n [ 0. , 6.19296233, 0. ]])\r\n```\r\nwhich is hardly of use to anyone.\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->",
"title": "[WIP] Fix cross_val_predict behavior for binary classification in decision_function (Fixes #9589)",
"type": "issue"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 323743822,
"datetime": 1503322023000,
"masked_author": "username_1",
"text": "I think better not to error in the context of using this in ClassifierChain or a stacking meta-estimator.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 323749514,
"datetime": 1503323712000,
"masked_author": "username_0",
"text": "NaN makes it clearer that these columns weren't considered at all for this particular split, but wouldn't that break things? For instance, I frequently use `np.argmax(cross_val_predict(..., method='predict_proba))` to recover the true labels for calculating accuracy, etc. Of course, I always make sure my folds are stratified so I'm probably not going to face it, but still.. Also, wouldn't that break ClassifierChains and stacking meta-estimators?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 323870974,
"datetime": 1503355162000,
"masked_author": "username_1",
"text": "yes, nan would probably break it all. a warning is probably a good idea.\nBut first we need to fix the regression.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 323921155,
"datetime": 1503378845000,
"masked_author": "username_0",
"text": "I've added the necessary unit tests.\r\n\r\nAlthough at this point, I'd like to point out there's another regression for the case of SVC with `decision_function_shape=ovo`\r\n\r\nCode to test:\r\n```python\r\nfrom sklearn.datasets import load_digits\r\nfrom sklearn.svm import SVC\r\nfrom sklearn.model_selection import cross_val_predict\r\n\r\nX, y = load_digits(return_X_y=True)\r\ncross_val_predict(SVC(kernel='linear', decision_function_shape='ovo'), X, y, method='decision_function').shape\r\n```\r\n\r\n**Expected Results**\r\nIn previous versions, this is `(1797, 45)`\r\n\r\n**Actual Results**\r\n```\r\nValueError: shape mismatch: value array of shape (602,45) could not be broadcast to indexing result of shape (10,602)\r\n```\r\n\r\nThis error is due to the shape of an SVC decision function with `decision_function_shape` set to `'ovr'` which is `(n_samples, n_classes * (n_classes-1) / 2)`\r\n\r\nShould I include the fix in this PR?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 323945416,
"datetime": 1503387659000,
"masked_author": "username_1",
"text": "Thanks. Maybe fix that in a separate PR unless they're going to step on\neach others' toes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 323989642,
"datetime": 1503398748000,
"masked_author": "username_0",
"text": "Hi @username_1, I changed this back to WIP since there was a conflict with a recent merge. I also figured out a better fix that also fixes the SVC \"ovo\" regression.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 323989752,
"datetime": 1503398776000,
"masked_author": "username_1",
"text": "Okay. Let me know when it's MRG, i.e. ready for review.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 324014866,
"datetime": 1503405930000,
"masked_author": "username_0",
"text": "@username_1 Ready for review",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 324057852,
"datetime": 1503414774000,
"masked_author": "username_0",
"text": "Yup, sorry. Added unit test and addressed comments.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amueller",
"comment_id": 325999056,
"datetime": 1504101555000,
"masked_author": "username_2",
"text": "A solution to some more of this will be in #9532 but that will probably still take a while.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amueller",
"comment_id": 326031443,
"datetime": 1504107640000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amueller",
"comment_id": 326031684,
"datetime": 1504107683000,
"masked_author": "username_2",
"text": "This is the case when some classifiers have 1 class and some have 2 classes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 326042552,
"datetime": 1504109866000,
"masked_author": "username_0",
"text": "Got it. Didn't know some classifiers could be fit on a single class. So that's *another* regression. How do you want to handle this case? It sounds similar to the case `if method == 'decision_function' and len(estimator.classes_) == 2`, which is currently handled by doing `predictions_[:, estimator.classes_[-1]] = predictions`.\r\n\r\nIf that's fine, I think the fix is to simply change the former line to `if method == 'decision_function' and len(estimator.classes_) <= 2`.\r\n\r\nThis would fix the errors, but frankly, I'd still prefer a stern warning that something went wrong during cross-validation using `cross_val_predict`.\r\n\r\nFor the ovo case, should I include that in this PR as well? I didn't include it previously since this PR primarily fixes regressions and I didn't want to include a new \"feature\".",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amueller",
"comment_id": 326045716,
"datetime": 1504110575000,
"masked_author": "username_2",
"text": "Not sure if the 1 class thing is a regression or was always broken ;)\r\nAnd I think I'd like the error / test for OVO in this PR.\r\n\r\nSorry, I don't understand your proposal for the 1class / 2class case. The result in the 2 class case should be 1d, not 2d. That's the original bug this is trying to solve, right?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 326048935,
"datetime": 1504111277000,
"masked_author": "username_0",
"text": "The case I'm talking about is when the original dataset has >2 classes, and a particular fold is <=2 *and* the method is `decision_function`. The original bug is still fixed by the `if n_classes != len(estimator.classes_):` check.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amueller",
"comment_id": 326050223,
"datetime": 1504111545000,
"masked_author": "username_2",
"text": "Ah. My breaking example is with the dataset having two classes, and some folds have one class.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 326054741,
"datetime": 1504112458000,
"masked_author": "username_0",
"text": "You're right. It's not a regression, but another edge case that needs to be fixed. Yes, we should add an explicit check that `n_classes > 2` but only if the method used is `decision_function`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 326349959,
"datetime": 1504196799000,
"masked_author": "username_0",
"text": "@username_2 I've added both the error for OvO and the fix for a dataset having two classes, and some folds having one class. Added unit tests for both.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 327260698,
"datetime": 1504635709000,
"masked_author": "username_0",
"text": "@username_1 Addressed comments. Failure in Appveyor appears from an unrelated test.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 327699214,
"datetime": 1504765388000,
"masked_author": "username_0",
"text": "I'm not sure why an unrelated test in `sklearn.neighbors` is failing in Appveyor when the only difference in the commit that caused the failure is a few comments and additional unit tests.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 327705902,
"datetime": 1504767536000,
"masked_author": "username_1",
"text": "That appears to be a very rare failure at random. I'll fix that test and restart appveyor.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 327755133,
"datetime": 1504778720000,
"masked_author": "username_0",
"text": "Finally green. Thanks! Ready for review.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amueller",
"comment_id": 332542212,
"datetime": 1506522978000,
"masked_author": "username_2",
"text": "Ok, I think if one fold only contains one class, we should probably just error becaus it's a bit unclear to me what is supposed to happen. And this is such a weird edge-case that I don't think we should hold 0.19.1 for that.\r\n\r\nFor the if-else thing in the decision function case: maybe just add some comments? right now I find the code hard to read. But seems ok to me.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 332619872,
"datetime": 1506538219000,
"masked_author": "username_0",
"text": "@username_2 I've addressed your comments. So, ready for review again.\r\n\r\nThe test failures are due to something unrelated again..",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 332705569,
"datetime": 1506564094000,
"masked_author": "username_0",
"text": "@username_2 addressed your comments. Ready for review again.\r\n\r\nThe test failures seem to be due to something unrelated again...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 332710191,
"datetime": 1506566012000,
"masked_author": "username_1",
"text": "Add a blank commit and the failures should go away due to a patch in master",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 332788289,
"datetime": 1506592589000,
"masked_author": "username_0",
"text": "So.. something failed. But again, I have no idea what...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lesteve",
"comment_id": 332841282,
"datetime": 1506606399000,
"masked_author": "username_3",
"text": "You can see that this is lgtm failing (google it if you want to know more what lgtm does). For some reason it has done that recently, not sure why but you don't need to worry about this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 333735039,
"datetime": 1507004590000,
"masked_author": "username_1",
"text": "I'll add a what's new entry when throwing it into 0.19.1, to avoid having it incorrectly in 0.20",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lesteve",
"comment_id": 335178848,
"datetime": 1507560062000,
"masked_author": "username_3",
"text": "I looked at this for a bit, my main comment: with your change it seems like we are not very consistent when we ave a training fold which does not have all the training labels present in the complete dataset:\r\n* if prediction.ndim == 2, which I think for method='decision_function' means `len(est.classes_) >= 3`, we raise an error saying use a proper stratification technique\r\n* if prediction.ndim < 2, which I think for method='decision_function' means `len(est.classes_) <= 2`, we do not raise an error.\r\n\r\nAlso it seems like the fix for cross_val_predict in binary classification as reported in #9589 is actually moving the from the logic from https://github.com/scikit-learn/scikit-learn/pull/7889 in a `if n_classes != len(estimator.classes_)`. I would like to take a closer look at this to understand better whether this is the right thing to do.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 335187932,
"datetime": 1507561928000,
"masked_author": "username_0",
"text": "I don't think there is ever a case when `decision_function` returns `predictions.ndim == 2`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lesteve",
"comment_id": 335418355,
"datetime": 1507628373000,
"masked_author": "username_3",
"text": "You are right, I read the code too quickly, which to my defence is a bit tricky to follow.\r\n\r\nI am not convinced we are doing the right thing when we don't have all the classes in the training fold (for example setting decision function to 0 in the missing classes does not seem right).\r\nOne way to avoid the problem would be to raise an error when we don't have all the classes in the training fold? Is there a reason why we don't do this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 335421814,
"datetime": 1507629188000,
"masked_author": "username_0",
"text": "Yup, I agree this does not make sense.\r\n\r\nPerhaps what we could do is keep the special imbalanced handling code only for `predict_proba` and error out when it is imbalanced for `decision_function`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 335425268,
"datetime": 1507629983000,
"masked_author": "username_1",
"text": "The problem is that it does just happen in practice, when some classes are\ninfrequent. It might not make sense for decision_function to assume some\narbitrary value but it does make sense to zero out a column in\npredict_proba.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 335426165,
"datetime": 1507630215000,
"masked_author": "username_0",
"text": "How about erroring out imbalanced classes in `decision_function` but zeroing out columns in `predict_proba` and `log_predict_proba`? Literally all the complication in this PR is because of the different weird ways `decision_function` behaves.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 335426250,
"datetime": 1507630240000,
"masked_author": "username_1",
"text": "Essentially all we do in that case is make it harder for people to do the\nsame analysis on a highly imbalanced classification problem that they do\nwith a balanced one, which in turn makes it harder for people to provide\ngeneric ML tools built on top of our library.\n\nOne example, again, is stacking.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 335427204,
"datetime": 1507630483000,
"masked_author": "username_1",
"text": "I suppose that is, at least, more principled, and I can accept that. (And\nby that I mean erroring for decision_function but not for\npredict_{log_}proba).\n\nYes, these quirks and edge cases are annoying to deal with. But I feel like\nsometimes it's our role as a library provider to handle them as best we\ncan, and raise an error only when the user has done something wrong or at\nleast very rare. I don't think this falls under very rare.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lesteve",
"comment_id": 335473669,
"datetime": 1507642411000,
"masked_author": "username_3",
"text": "I read a bit the discussion in the related PRs, sorry it's taking me some time to catch up. Basically here is my summary:\r\n\r\n* I would be a favour of a warning when the training fold does not contain all the classes. https://github.com/scikit-learn/scikit-learn/pull/8773#issuecomment-330362879 agrees with that as well.\r\n* the fix for the wrong shape in cross_validation_predict with method=decision_function (which consists in only applying the logic from #7889 when `n_classes != n_classes_train`) is fine\r\n* `method='decision_function'` has a number of edge cases. Raising an exception for `method='decision_function'` if `n_classes_train != n_classes` may be an easy way to avoid tackling all these special cases.\r\n 1. SVC with ovo with uncommon number of columns for decision function `n_classes_train * (n_classes_train - 1) / 2` rather than `n_classes`. Tackled in this PR already.\r\n 2. `n_classes_train <= 2` and `n_classes >= 3`, you get a 1d array as the output of decision_function and then it is not clear what to do with it. I would be in favour of raising an exception in this case.\r\n 3. `n_classes_train == 1` and `n_classes == 2`. No idea what to do in this case. I don't know how common this is for classifier to be able to be fittable with a single class and have decision_function. I quickly looked using all_estimators and I found `['AdaBoostClassifier', 'LinearDiscriminantAnalysis', 'RidgeClassifier', 'RidgeClassifierCV']`.\r\n* predictions should be initialized to 0 if `method='predict_proba'` but `-inf` (or maybe `np.finfo(X.dtype).min`) if `method='predict_log_proba'`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 335477729,
"datetime": 1507643230000,
"masked_author": "username_0",
"text": "There is another case for `decision_function`\r\n\r\niv. `n_classes_train > 2` and `n_classes > 2` but `n_classes_train < n_classes`. Currently we set missing classes to 0.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lesteve",
"comment_id": 335698632,
"datetime": 1507704113000,
"masked_author": "username_3",
"text": "For decision_function either we do the same as predict_log_proba or we decide that we always raise an exception, given that there are many edge cases for decision_function ...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reiinakano",
"comment_id": 335800354,
"datetime": 1507726575000,
"masked_author": "username_0",
"text": "I think I've mostly sorted this out. For a non-special case of `decision_function` (`iv. n_classes_train > 2 and n_classes > 2 but n_classes_train != n_classes.`), I do the same as `predict_log_proba`. For the other special cases, there is an error message. \r\n\r\nApologies for the confusing code previously, I should've done it this way in the first place, but I didn't expect `decision_function` to have so many edge cases.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jnothman",
"comment_id": 337407829,
"datetime": 1508282875000,
"masked_author": "username_1",
"text": "I would like to see this merged and 0.19.1 released by the end of the week. Is that reasonable, @username_2?",
"title": null,
"type": "comment"
}
] | 16,588 | false | true | 4 | 43 | true |
JohnSundell/Marathon | null | 232,606,889 | 81 | null | [
{
"action": "opened",
"author": "johndpope",
"comment_id": null,
"datetime": 1496244937000,
"masked_author": "username_0",
"text": "➜ Desktop marathon help add\r\n📦 add\r\n------\r\nAdd a package from a given URL to be able to use it from your scripts\r\n\r\n👉 Usage: 'marathon add <url-or-path-to-package>'\r\n\r\nℹ️ You can also use a 'Marathonfile' to automatically add packages. See https://github.com/johnsundell/marathon for more information",
"title": "clarification on adding / (if it not possible - letting user know) specific tags of repos in marathon add",
"type": "issue"
},
{
"action": "created",
"author": "johndpope",
"comment_id": 305226494,
"datetime": 1496244995000,
"masked_author": "username_0",
"text": "eg. want to add tag 0.0.1\r\n marathon add https://github.com/username_0/swift-grpc-tensorflow.git \r\n\r\nhttps://github.com/username_0/swift-grpc-tensorflow/tree/0.0.1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JohnSundell",
"comment_id": 305245497,
"datetime": 1496248838000,
"masked_author": "username_1",
"text": "Version pinning is not yet supported, but it's something that we do want to add support for. I added this issue: https://github.com/username_1/Marathon/issues/82 to keep track of this new feature, so feel free to put any comments/suggestions you might have in there 🙂 Closing this in favor of the linked issue.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "JohnSundell",
"comment_id": null,
"datetime": 1496248838000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 777 | false | false | 2 | 4 | true |
jonathantribouharet/JTCalendar | null | 172,977,491 | 292 | null | [
{
"action": "opened",
"author": "roadst3r",
"comment_id": null,
"datetime": 1472051176000,
"masked_author": "username_0",
"text": "I've been trying to get the current month from JTCalendar manager without any success.\r\nIts easy when the user touches a day, but I want to update my own label, when user swipes the month.\r\nThere are 2 methods: calendarDidLoadNextPage & calendarDidLoadPreviousPage, that are triggered when user swipe the month or week, but after that, I cant get the month date from anywhere, visible month date, not selected one.\r\n\r\nAny ideas?",
"title": "Struggling with a way to get current month/week on screen.",
"type": "issue"
},
{
"action": "created",
"author": "jneiluj",
"comment_id": 253986709,
"datetime": 1476540785000,
"masked_author": "username_1",
"text": "Use date from calendar.date in the 2 delegates (or calendarManager.date) and not dateSelected saved in - (void)calendar:(JTCalendarManager *)calendar didTouchDayView:(JTCalendarDayView *)dayView;",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jonathantribouharet",
"comment_id": null,
"datetime": 1483494786000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "jonathantribouharet",
"comment_id": 270276485,
"datetime": 1483494786000,
"masked_author": "username_2",
"text": "Just like that `[_calendarManager date];`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "brunotereso-acceptto",
"comment_id": 270276804,
"datetime": 1483494946000,
"masked_author": "username_3",
"text": "I don't have the code with me right now, but from what I remember [_calendarManager date] was updated after choosing a day.\r\nMy problem was getting the month while swiping the calendar without choosing any day.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "roadst3r",
"comment_id": 270276991,
"datetime": 1483495035000,
"masked_author": "username_0",
"text": "I don't have the code with me right now, but from what I remember [_calendarManager date] was updated after choosing a day.\r\nMy problem was getting the month while swiping the calendar without choosing any day.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathantribouharet",
"comment_id": 270278130,
"datetime": 1483495565000,
"masked_author": "username_2",
"text": "The manager is just a proxy for the date in `JTHorizontalCalendarView` which is updated in continuous during the scroll. Check again and come back if you still have the problem.",
"title": null,
"type": "comment"
}
] | 1,261 | false | false | 4 | 7 | false |
tensorics/tensorics-core | tensorics | 118,232,658 | 3 | null | [
{
"action": "opened",
"author": "kaifox",
"comment_id": null,
"datetime": 1448156262000,
"masked_author": "username_0",
"text": "Instead, it should be possible to e.g. use an interface as a dimension.",
"title": "Dimension should not be limited to lowermost classes",
"type": "issue"
},
{
"action": "created",
"author": "agorzawski",
"comment_id": 248386820,
"datetime": 1474395516000,
"masked_author": "username_1",
"text": "Please check the test defined in the **CoordinatesOnInterfacesTest.class.** It is Simplified (only Double Tensor one) but covering the main issues we have. I will start investigating/coding slowly, fell free to change the test on **interface-in-dimension branch**.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "michi42",
"comment_id": 254839273,
"datetime": 1476889155000,
"masked_author": "username_2",
"text": "fixed by #8",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "michi42",
"comment_id": null,
"datetime": 1476889159000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 347 | false | false | 3 | 4 | false |
slamdata/purescript-halogen | slamdata | 71,598,613 | 98 | null | [
{
"action": "opened",
"author": "cryogenian",
"comment_id": null,
"datetime": 1430229856000,
"masked_author": "username_0",
"text": "How do you think is it possible to add pseudoattributes for `HTML` like `clicked`, `focused` etc? And if it setted to `true` generate an event. Can be helpful to change focus or select texts.",
"title": "Generate events",
"type": "issue"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97210197,
"datetime": 1430255957000,
"masked_author": "username_1",
"text": "It should be fairly simple to implement these in terms of `init`, no?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cryogenian",
"comment_id": 97213108,
"datetime": 1430256433000,
"masked_author": "username_0",
"text": "Erm... Could you give a clue how to do it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97244323,
"datetime": 1430259836000,
"masked_author": "username_1",
"text": "Something like\r\n\r\n```purescript\r\nH.div [ A.init if shouldClick then yield ThingToDoOnClick else empty ] []\r\n```\r\n\r\n?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cryogenian",
"comment_id": 97245161,
"datetime": 1430260165000,
"masked_author": "username_0",
"text": "Do you mean `initializer`? I can't find `A.init`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97245321,
"datetime": 1430260229000,
"masked_author": "username_1",
"text": "Yes, sorry.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cryogenian",
"comment_id": 97246814,
"datetime": 1430260831000,
"masked_author": "username_0",
"text": "I mean not to do something that we do when events are fired, but to fire those events. In example `e.focus()` or `e.select()`. I'm afraid it can be done only by `Widget`'s `init` not `A.initializer`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97247179,
"datetime": 1430260974000,
"masked_author": "username_1",
"text": "Sorry, I was thinking of the jQuery-style, where `el.click()` means \"generate a click event\", and assumed you just wanted to generate the input to the state machine without a click from the user. Maybe we do need #89 after all...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97295904,
"datetime": 1430278847000,
"masked_author": "username_1",
"text": "Can we do this with hooks?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97308260,
"datetime": 1430284517000,
"masked_author": "username_1",
"text": "@username_3 @username_0 I've put an (untested) sketch of a possible solution on the `hooks` branch. I think we can use this to define custom attributes like `focus`. I don't have time to work on this any more tonight, but I can take a look tomorrow if this approach looks ok.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97868023,
"datetime": 1430411148000,
"masked_author": "username_1",
"text": "Here's a thought. What if you used a data attribute, and we did an effectful pass over the DOM after each render, to apply any custom attributes, using jQuery or `simple-dom`? I could add a hook to `runUI`, and it would probably be cleaner than hook attributes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "garyb",
"comment_id": 97870133,
"datetime": 1430411474000,
"masked_author": "username_2",
"text": "That might be an option, but manipulating the DOM outside of virtual dom can really be asking for trouble when you're not doing it with hooks, widgets, etc. Or is that what you meant by using the data attribute? Use that as a marker for \"make change here\"?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97872723,
"datetime": 1430411930000,
"masked_author": "username_1",
"text": "Pretty much. The case I was thinking of was focussing a text box. We could set a `data-should-focus` attribute, and then use jQuery to focus or blur that element if necessary after rendering.\r\n\r\nWe could do the same thing with a hook in an attribute, defining\r\n\r\n```purescript\r\nfocussed :: Boolean -> Attr\r\nfocussed = attr \"halogen-hook-focussed\" <<< makeFocusHook\r\n\r\nmakeFocusHook :: Boolean -> Hook\r\nmakeFocusHook = hook ...\r\n```\r\n\r\nI have a sketch of the second approach in the `hooks2` branch.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "garyb",
"comment_id": 97874326,
"datetime": 1430412230000,
"masked_author": "username_2",
"text": "Sounds reasonable to me.\r\n\r\nThat general method is pretty much how I proposed widget initialisation should work in one of the many other discussions - although with the machinery hidden somehow. The idea being then we can delay init until the node exists, has size, etc.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 97875658,
"datetime": 1430412483000,
"masked_author": "username_1",
"text": "Sorry, which one?\r\n\r\nImplementing widgets with the data-attribute approach seems possible, and even preferable, if we can cram arbitrary data into a data-attribute using `virtual-dom`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "garyb",
"comment_id": 97882011,
"datetime": 1430413299000,
"masked_author": "username_2",
"text": "Well it's something I did in a JS project, so it might not translate directly, but the idea was using a hook that registered a \"update me\" request on `hook`, and then after render those requests were all processed. The registration part in that case was done with a global array, so that wouldn't quite be the way to handle it, but perhaps a data-attribute could be used to similar effect.\r\n\r\nIn my case it was for triggering animations on elements rather than doing anything widgety, but it seemed potentially workable?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jdegoes",
"comment_id": 97942132,
"datetime": 1430422914000,
"masked_author": "username_3",
"text": "Note that this is really a symptom of the more general information flow problem I've been ranting about: which is that it's not possible to emit messages from an SF; rather, the SF can only emit stateless, declarative HTML, which is leading to questionable hacks like this (not that I have a good way of solving it, just remarking on why this issue is arising and why information is being forced through pseudo-attributes -- because that's the only way to get event-oriented information out).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 98011853,
"datetime": 1430442000000,
"masked_author": "username_1",
"text": "It seems what you're referring to is really a limitation of `virtual-dom`, or even React, or just the general \"generate a pure virtual DOM element and patch\" approach, unless I'm missing something.\r\n\r\nAnyway, I want to nail this down so that I can implement something this weekend. Given everyone's current experience, which do we prefer?\r\n\r\n- Support for hook-valued attributes\r\n- Data attributes and support for custom post-render hooks\r\n\r\nThere's no reason we can't support both of course, but I think it would be good to pick one and stick with it. I prefer the second, since I think it actually subsumes the current widget implementation, and it is closer in spirit to the \"push effects to the boundary\" approach.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jdegoes",
"comment_id": 98168574,
"datetime": 1430496934000,
"masked_author": "username_3",
"text": "I defer to @username_2, @username_0, and @puffnfresh, as they're the ones who have to use this. :smile:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "garyb",
"comment_id": 98349759,
"datetime": 1430566542000,
"masked_author": "username_2",
"text": "Custom post-render hooks seem like they'll be more useful given the requirements of widgets and Bootstrap-style functionality decorators, so my vote goes to the data attribute approach too.\r\n\r\nSomething to keep in mind is we need to preserve those when manually setting values via `dataSet`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "paf31",
"comment_id": 98522600,
"datetime": 1430679143000,
"masked_author": "username_1",
"text": "I think this is handled by #106, shall I close?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "cryogenian",
"comment_id": null,
"datetime": 1430717705000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 4,837 | false | false | 4 | 22 | true |
aspnet/Hosting | aspnet | 126,418,773 | 567 | null | [
{
"action": "opened",
"author": "davidfowl",
"comment_id": null,
"datetime": 1452692058000,
"masked_author": "username_0",
"text": "We have `IWebApplicationBuilder`, `WebApplicationBuilder`, `IWebApplication`, and `IApplicationBuilder`.\r\n\r\n`IApplicationBuilder` looks related to `IWebApplicationBuilder` but they are not. \r\n\r\nToday:\r\n\r\n\r\n```C#\r\nvar host = new WebHostBuilder()\r\n .UseServer(\"Microsoft.AspNet.Server.Kestrel\")\r\n .UseUrls(\"http://localhost:5001\")\r\n .UseStartup<Startup>()\r\n .Build();\r\n\r\nhost.Run();\r\n```\r\n\r\nPotential:\r\n\r\n```C#\r\nvar app = new WebApplicationBuilder()\r\n .UseServer(\"Microsoft.AspNet.Server.Kestrel\")\r\n .UseUrls(\"http://localhost:5001\")\r\n .UseStartup<Startup>()\r\n .Build();\r\n\r\napp.Run();\r\n```",
"title": "Consider changing WebApplication* to WebHost*",
"type": "issue"
},
{
"action": "created",
"author": "Tratcher",
"comment_id": 171301621,
"datetime": 1452694305000,
"masked_author": "username_1",
"text": "I do agree there's ambiguity between IWebApplicationBuilder and IApplicationBuilder.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 171502219,
"datetime": 1452737378000,
"masked_author": "username_0",
"text": "Shall we go with host instead of application then?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Tratcher",
"comment_id": 171516529,
"datetime": 1452740699000,
"masked_author": "username_1",
"text": "You're with @DamianEdwards right? Did he have anything to say on the subject?\r\n\r\nI think it's fine, but I don't envy @username_5 having to touch all the repos again.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 171518301,
"datetime": 1452741722000,
"masked_author": "username_0",
"text": "Yes, we spoke about this today and concluded that it looks like WebApplication was wrong.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikes-gh",
"comment_id": 171584312,
"datetime": 1452763665000,
"masked_author": "username_2",
"text": "Would that mean also changing WebApplicationConfiguration to WebHostConfiguration?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 171584767,
"datetime": 1452763802000,
"masked_author": "username_0",
"text": "@username_2 yes re: `WebHostConfiguration`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikes-gh",
"comment_id": 171585401,
"datetime": 1452763997000,
"masked_author": "username_2",
"text": "@username_0 \r\n```\r\nWebHostBuilder\r\nWebHostConfiguration\r\n```\r\nvs\r\n```\r\nWebHostingBuilder\r\nWebHostingConfiguration\r\n```\r\nThe later seems slightly more abstracted to me",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 171585729,
"datetime": 1452764094000,
"masked_author": "username_0",
"text": "I dunno what you mean by more abstracted. I prefer:\r\n\r\nI prefer a `WebHostBuilder` that builds a `WebHost` using `WebHostConfiguration`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikes-gh",
"comment_id": 171586586,
"datetime": 1452764351000,
"masked_author": "username_2",
"text": "WebHost is fine.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 171586737,
"datetime": 1452764409000,
"masked_author": "username_0",
"text": "PS: @username_5 I'm sorry dude, that's alot of repos to update :disappointed:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikes-gh",
"comment_id": 171593695,
"datetime": 1452765989000,
"masked_author": "username_2",
"text": "WebHostConfiguration would read hosting.json seems a mismatch\r\nWebHostingConfiguration would seem a more logically. match..",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 171594575,
"datetime": 1452766259000,
"masked_author": "username_0",
"text": "But we're going to call it `WebHostConfiguration` so it matches the other names. We're splitting hairs and naming is hard but that's what we're calling it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aL3891",
"comment_id": 172204116,
"datetime": 1452949529000,
"masked_author": "username_3",
"text": "Maybe hosting.json could be host.json? (or webhost.json)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "henkmollema",
"comment_id": 172260852,
"datetime": 1452981415000,
"masked_author": "username_4",
"text": "`hosting.json` configures the hosting API. Webhost is just a part of that. It's not like we're renaming the repo to Webhost.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JunTaoLuo",
"comment_id": 172418370,
"datetime": 1453089119000,
"masked_author": "username_5",
"text": "Marking as done since rename has been merged to dev and all repos have been updated. Will post announcement after monitoring test pass and close issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GuardRex",
"comment_id": 172424019,
"datetime": 1453091941000,
"masked_author": "username_6",
"text": "... according to @username_1 https://github.com/aspnet/IISIntegration/issues/52#issuecomment-171444840",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikes-gh",
"comment_id": 172620732,
"datetime": 1453142834000,
"masked_author": "username_2",
"text": "@username_5 \r\nLooks like aspnet/Security is failing after this",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 172624161,
"datetime": 1453143852000,
"masked_author": "username_0",
"text": "What is failing?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikes-gh",
"comment_id": 172626295,
"datetime": 1453144463000,
"masked_author": "username_2",
"text": "Microsoft.AspNet.Authentication.Test \r\n\r\nI noticed because I have a pull request for FacebookMiddleware\r\n\r\n```\r\n[00:05:14] Compiling \r\n[00:05:14] Microsoft.AspNet.Authentication.Test\r\n[00:05:14] for \r\n[00:05:14] DNX,Version=v4.5.1\r\n[00:05:14] \r\n[00:05:17] \u001b[1m\u001b[31mC:\\projects\\security\\test\\Microsoft.AspNet.Authentication.Test\\test\\Microsoft.AspNet.Authentication.Test\\Twitter\\TwitterMiddlewareTests.cs(155,31): error CS0246: The type or namespace name 'WebHostBuilder' could not be found (are you missing a usi\r\n[00:05:17] ng directive or an assembly reference?)\r\n[00:05:17] \r\n[00:05:17] \r\n[00:05:17] Compilation failed.\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JunTaoLuo",
"comment_id": 172683272,
"datetime": 1453160533000,
"masked_author": "username_5",
"text": "@username_2 I think your packages may be out of date and updating to the newest packages should fix the problem. @username_6 I don't know how feasible listing all the versions is since many packages were affected. I will look into it but at least the renames will impact Microsoft.AspNet.Hosting rc2-16237 or later for sure.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "JunTaoLuo",
"comment_id": null,
"datetime": 1453168089000,
"masked_author": "username_5",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "JunTaoLuo",
"comment_id": 172703513,
"datetime": 1453168089000,
"masked_author": "username_5",
"text": "Seems like test pass will be broken for other reasons. Since I did not see any test failures relating to this change, I'm closing the issue for now.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidfowl",
"comment_id": 172743492,
"datetime": 1453181554000,
"masked_author": "username_0",
"text": ":clap:",
"title": null,
"type": "comment"
}
] | 3,561 | false | false | 7 | 24 | true |
sckott/usdaplantsapi | null | 259,891,798 | 11 | null | [
{
"action": "opened",
"author": "sckott",
"comment_id": null,
"datetime": 1506103178000,
"masked_author": "username_0",
"text": "@username_1 curious if you've seen a newer dump of the database?",
"title": "new dump perhaps",
"type": "issue"
},
{
"action": "created",
"author": "dlebauer",
"comment_id": 331580132,
"datetime": 1506121632000,
"masked_author": "username_1",
"text": "Nope. It seems pretty stable. Not sure how frequently it is updated. You can get updated dumps in the advanced search page. I quickly tried it just now and wasn't getting any results.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sckott",
"comment_id": 331583913,
"datetime": 1506123717000,
"masked_author": "username_0",
"text": "okay, thx",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "sckott",
"comment_id": null,
"datetime": 1597419438000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 254 | false | false | 2 | 4 | true |
asascience-open/ooi-ui | asascience-open | 169,127,466 | 780 | {
"number": 780,
"repo": "ooi-ui",
"user_login": "asascience-open"
} | [
{
"action": "opened",
"author": "Bobfrat",
"comment_id": null,
"datetime": 1470229796000,
"masked_author": "username_0",
"text": "@DanielJMaher goes along with https://github.com/asascience-open/ooi-ui-services/pull/519",
"title": "Keep color checked on and disabled always",
"type": "issue"
},
{
"action": "created",
"author": "oceanzus",
"comment_id": 237253448,
"datetime": 1470234648000,
"masked_author": "username_1",
"text": ":+1:",
"title": null,
"type": "comment"
}
] | 93 | false | false | 2 | 2 | false |
phpstan/phpstan | phpstan | 201,990,838 | 94 | null | [
{
"action": "opened",
"author": "hkdobrev",
"comment_id": null,
"datetime": 1484863966000,
"masked_author": "username_0",
"text": "When a class has a `__toString()` method, an instance of it should be able to be passed to a method expecting a string.\r\n\r\nPlease let me know if this sounds right.\r\n\r\nI currently get an error like that with level 5:\r\n\r\n```\r\nParameter #1 $expression of method Foo::parse() expects string, Expression given.\r\n```\r\nWhere\r\n```php\r\nclass Expression\r\n{\r\n public function __toString()\r\n {\r\n // ...\r\n }\r\n}\r\n```",
"title": "Accept classes with __toString() method as valid string arguments",
"type": "issue"
},
{
"action": "created",
"author": "ondrejmirtes",
"comment_id": 273933227,
"datetime": 1484869021000,
"masked_author": "username_1",
"text": "You're right, this can be correctly handled how you suggested. It hasn't been until now because I consider using `__toString` to be a not very good programming practice. It's very limiting - what if an object has two or more possible string representations? Like \"First name Last name\" or \"Last Name, First name\"? Also, `__toString` cannot throw exception. The only acceptable `__toString` usage is for debugging purposes. So your entities could probably implement something like this:\r\n\r\n```\r\npublic function __toString()\r\n{\r\n return get_class($this) . '#' . $this->getId();\r\n}\r\n```\r\n\r\nPassing an object where only string is accepted is often a mistake rather than an intent. But I agree that this should be allowed by default with a possible stricter setting to reject it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hkdobrev",
"comment_id": 273939215,
"datetime": 1484871068000,
"masked_author": "username_0",
"text": "@username_1 I agree with all of your remarks, but when you are trying to use PHPStan to detect problems in a legacy system which has a ton of classes already using `__toString()`, this should be covered. Also when you are dealing with 3rd party libraries which use such patterns, it's only sensible to detect this by default.\r\n\r\nAlso some people coming from different languages may say this is their preferred practice of writing classes. Even if it's not OOP. The same logic applies in part for `Countable`, `ArrayAccess`, `Iterable` and `Traversable` but with them we at least have interfaces and a more documented and a sensible way of doing things.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ondrejmirtes",
"comment_id": 273994105,
"datetime": 1484896543000,
"masked_author": "username_1",
"text": "I agree. PHPStan cannot be opinionated since it's for finding bugs, so it\nwill accept objects with __toString in places where string belongs by\ndefault :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ondrejmirtes",
"comment_id": 274287352,
"datetime": 1485031743000,
"masked_author": "username_1",
"text": "Fixed with https://github.com/phpstan/phpstan/commit/254def88b153eb9dfa8ceab4a92eed92ccab8ca2.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ondrejmirtes",
"comment_id": null,
"datetime": 1485031744000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2,097 | false | false | 2 | 6 | true |
rubygems/rubygems | rubygems | 51,710,797 | 1,098 | null | [
{
"action": "opened",
"author": "zeljkofilipin",
"comment_id": null,
"datetime": 1418317012000,
"masked_author": "username_0",
"text": "For example, mediawiki_selenium gem reports warnings when building the gem. Code example from commit [172518](https://gerrit.wikimedia.org/r/#/c/172518/):\r\n\r\n```\r\n$ gem build mediawiki_selenium.gemspec\r\nWARNING: open-ended dependency on redcarpet (>= 0, development) is not\r\nrecommended\r\n if redcarpet is semantically versioned, use:\r\n add_development_dependency 'redcarpet', '~> 0'\r\nWARNING: open-ended dependency on yard (>= 0, development) is not\r\nrecommended\r\n if yard is semantically versioned, use:\r\n add_development_dependency 'yard', '~> 0'\r\nWARNING: See http://guides.rubygems.org/specification-reference/ for\r\nhelp\r\n Successfully built RubyGem\r\n Name: mediawiki_selenium\r\n Version: 0.4.1\r\n File: mediawiki_selenium-0.4.1.gem\r\n```\r\n\r\nI would like for the jenkins job that builds the gem to fail if there are any warnings. Looking at [gem build](http://guides.rubygems.org/command-reference/#gem-build) documentation, I do not see a way for the build to fail if there are any warnings.\r\n\r\nWhat I am looking for is something like this:\r\n\r\n```\r\n$ gem build mediawiki_selenium.gemspec --strict\r\nWARNING: open-ended dependency on redcarpet (>= 0, development) is not\r\nrecommended\r\n if redcarpet is semantically versioned, use:\r\n add_development_dependency 'redcarpet', '~> 0'\r\n...\r\nGem build failed because of warnings.\r\n```\r\n\r\nI have [asked](http://help.rubygems.org/discussions/questions/8986-can-gem-build-fail-if-there-are-_any_-warnings) at help.rubygems.org and got the answer to file a bug here.",
"title": "Can \"gem build\" fail if there are _any_ warnings?",
"type": "issue"
},
{
"action": "created",
"author": "djberg96",
"comment_id": 145888848,
"datetime": 1444144181000,
"masked_author": "username_1",
"text": "I like the idea, but wonder if this would be better suited as a plugin.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "segiddins",
"comment_id": 145901171,
"datetime": 1444145320000,
"masked_author": "username_2",
"text": "You can manually load up the gem spec and validate it for packaging in the interim, and I have an open PR to disallow warnings that I need to finish up.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "drbrain",
"comment_id": 145950803,
"datetime": 1444155146000,
"masked_author": "username_3",
"text": "It needs to be built-in, otherwise projects that build gems through API (not `gem build`) can't take advantage of it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "djberg96",
"comment_id": 145953966,
"datetime": 1444155795000,
"masked_author": "username_1",
"text": "@username_3 Ok, sounds alright to me, then.\r\n\r\n@username_0 we just need a PR now. :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "drbrain",
"comment_id": 145954633,
"datetime": 1444155877000,
"masked_author": "username_3",
"text": "There's #1335 by @username_2 that is in-progress",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "copiousfreetime",
"comment_id": 180596027,
"datetime": 1454710849000,
"masked_author": "username_4",
"text": "Calling this as a duplicate of #1334",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "copiousfreetime",
"comment_id": null,
"datetime": 1454710849000,
"masked_author": "username_4",
"text": "",
"title": null,
"type": "issue"
}
] | 2,033 | false | false | 5 | 8 | true |
SpoonX/aurelia-orm | SpoonX | 143,861,804 | 62 | {
"number": 62,
"repo": "aurelia-orm",
"user_login": "SpoonX"
} | [
{
"action": "opened",
"author": "kellyethridge",
"comment_id": null,
"datetime": 1459122937000,
"masked_author": "username_0",
"text": "This update has a hard-coded set for exactly one import. This may become fragile depending on how often you change the API.",
"title": "Excluded imports except ValidationRule in generating d.ts files.",
"type": "issue"
},
{
"action": "created",
"author": "kellyethridge",
"comment_id": 202170521,
"datetime": 1459123165000,
"masked_author": "username_0",
"text": "This pull-request probably shouldn't be accepted until after the removal of the spoonx prefix is applied.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "doktordirk",
"comment_id": 202318969,
"datetime": 1459157078000,
"masked_author": "username_1",
"text": "why is the validation import needed while the other external imports are not?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RWOverdijk",
"comment_id": 202347525,
"datetime": 1459164757000,
"masked_author": "username_2",
"text": "@username_1 Because we provide a custom validator. :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "doktordirk",
"comment_id": 202953050,
"datetime": 1459265235000,
"masked_author": "username_1",
"text": "@username_0 right. that place is giving me pain. i suggest to add a like 'dts-builder-options.js' file (where and like paths.js) and get an array of additional importsToAdd from there. (you might need to rebase first)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "doktordirk",
"comment_id": 204269982,
"datetime": 1459492480000,
"masked_author": "username_1",
"text": "yes. :+1: that's good. lets merge those commits to make it look nicer in the commit log. (reset to branching point (--mixed which is default to keep changes). add what should be in new version, commit and force push)\r\n\r\nfor command line that'll be :\r\n```sh\r\ngit reset 9e84f30\r\ngit add build/*\r\ngit commit -m \"fix(d.ts): include only necessary imports\"\r\ngit push -f origin HEAD\r\n```\r\ngulp util and a new build isn't needed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RWOverdijk",
"comment_id": 204306618,
"datetime": 1459499263000,
"masked_author": "username_2",
"text": "@username_0 That's one beautiful commit you have there :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RWOverdijk",
"comment_id": 204306780,
"datetime": 1459499313000,
"masked_author": "username_2",
"text": "Two tiny comments in the same file. After that, you have my :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "doktordirk",
"comment_id": 204650124,
"datetime": 1459575176000,
"masked_author": "username_1",
"text": "nice work !!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kellyethridge",
"comment_id": 204667913,
"datetime": 1459582892000,
"masked_author": "username_0",
"text": ":+1: thanks guys. It's been a fun learning experience.",
"title": null,
"type": "comment"
}
] | 1,191 | false | false | 3 | 10 | true |
boonproject/boon | boonproject | 56,049,415 | 294 | null | [
{
"action": "opened",
"author": "patient-zero",
"comment_id": null,
"datetime": 1422633077000,
"masked_author": "username_0",
"text": "I struggled trying to figure out why I could not override encoding of a java.net.InetAddress, and finally realized that TypeType was recognizing it as SYSTEM, which always uses the unknown serializer, i.e. the toString() method. It would be better to lift this limitation, otherwise types like Java 8 Time representations, InetAddress and lots of other reasonable things to override will need to be wrapped.",
"title": "system types cannot be overridden with custom serializers",
"type": "issue"
},
{
"action": "created",
"author": "RichardHightower",
"comment_id": 73315254,
"datetime": 1423257926000,
"masked_author": "username_1",
"text": "Ok.. I will consider that. I think I want to handle InetAddress the right way.. not sure what that is yet.\r\n\r\nBoon is still in Java 7 land, but I will try to figure out how to support Java 8 Time in Java 7 in a way so you can use Boon with Java 8 even though it is still in Java 7. \r\n\r\nI have been working on QBit a lot lately. I need to come back to Boon and fix some of these things.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RichardHightower",
"comment_id": 85250883,
"datetime": 1427154829000,
"masked_author": "username_1",
"text": "Do you have the code where you attempted to install a custom serializer that failed?\r\nI will use that as the test case.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kyle-downey",
"comment_id": 85256776,
"datetime": 1427156361000,
"masked_author": "username_2",
"text": "If you remove setUseAnnotations(true) it will not work.\r\n\r\n JsonSerializerFactory jsonSerializerFactory = new JsonSerializerFactory()\r\n .setAsciiOnly(true)\r\n .setUseAnnotations(true)\r\n .addTypeSerializer(PasswordHolder.class, new AbstractCustomObjectSerializer<PasswordHolder>(PasswordHolder.class) {\r\n @Override\r\n public void serializeObject(JsonSerializerInternal serializer, PasswordHolder instance, CharBuf builder) {\r\n builder.addQuoted(instance.getPassword());\r\n }\r\n })\r\n .usePropertyOnly();",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RichardHightower",
"comment_id": 85257062,
"datetime": 1427156522000,
"masked_author": "username_1",
"text": "I think you meant that comment for the other issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kyle-downey",
"comment_id": 85452353,
"datetime": 1427195244000,
"masked_author": "username_2",
"text": "Migrated comment to #292",
"title": null,
"type": "comment"
}
] | 1,645 | false | false | 3 | 6 | false |
mapbox/carto | mapbox | 161,277,524 | 449 | null | [
{
"action": "opened",
"author": "springmeyer",
"comment_id": null,
"datetime": 1466451857000,
"masked_author": "username_0",
"text": "```\r\n1) JS linting eslint should have no errors in lib:\r\n Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.\r\n ```\r\n\r\n@username_1 looks like you added this test: https://github.com/mapbox/carto/commit/1421611d619e093af463bdc09a88683aa5249ca9. Can you think through a solution such that travis runs stay green? I presume the problem is that linking takes too long on the slow travis machines.\r\n\r\nPossible solutions I see:\r\n\r\n - 1) Flip to `sudo:false` at https://github.com/mapbox/carto/blob/master/.travis.yml#L3 to access more powerful travis machines. Using `sudo:false` broke things mysteriously before, but it likely doable with a little effort to figure out what broke\r\n - 2) Increase the timeout length\r\n - 3) Move linting out of the tape tests and move to a `pretest` target.\r\n\r\n#3 would be my preference, but no strong opinion.",
"title": "Travis failures",
"type": "issue"
},
{
"action": "created",
"author": "nebulon42",
"comment_id": 227564774,
"datetime": 1466541613000,
"masked_author": "username_1",
"text": "Right, I'll have a look.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "nebulon42",
"comment_id": null,
"datetime": 1481464908000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 906 | false | false | 2 | 3 | true |
nfl/glitr | nfl | 195,044,816 | 6 | null | [
{
"action": "opened",
"author": "tinnou",
"comment_id": null,
"datetime": 1481566106000,
"masked_author": "username_0",
"text": "Glitr scans domains however some domains might exist outside of the graph but we could still need them in the GraphQL schema.\r\n\r\nAdd GLiTR configuration time, offer the ability to add additional Java types for inspection.\r\n\r\nExample:\r\nFor instance types A and B could implement an interface C that is discovered by GLiTR. Types A and B being never referenced elsewhere will not be inspected by GLiTR.",
"title": "Have a way to add additional types that are outside of the visited domain graph",
"type": "issue"
},
{
"action": "created",
"author": "tinnou",
"comment_id": 269697645,
"datetime": 1483047571000,
"masked_author": "username_0",
"text": "Here is an example on how to add types after initiation of the `Glitr` instance.\r\n\r\n```\r\n Glitr glitr = GlitrBuilder.newGlitr()\r\n .withRelay()\r\n .withQueryRoot(new Viewer())\r\n .withMutationRoot(mutation)\r\n .withObjectMapper(configureGlitrObjectMapper())\r\n .build();\r\n // Man and Cyborg implement the Person interface but they haven't been discovered by GLiTR\r\n // we can ask for additional lookup\r\n glitr.getTypeRegistry().lookup(Man.class);\r\n glitr.getTypeRegistry().lookup(Cyborg.class);\r\n // make sure to reload the GraphQL Schema for the changes to take effect\r\n glitr.reloadSchema(Viewer.class, mutation.getClass());\r\n```\r\n\r\nSee this [test](https://github.com/nfl/glitr/commit/851eda6a31e7b68a81afbf3db4b342371555dc18#diff-72b0c7662755b3a4b8379243cc511df4R13) for a full example.\r\n\r\nAs a side note, we could add the option to register additional types in the builder. We will come back to it in the future when needed.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tinnou",
"comment_id": null,
"datetime": 1483047571000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1,447 | false | false | 1 | 3 | false |
fugacious/fugacious | fugacious | 172,547,676 | 63 | {
"number": 63,
"repo": "fugacious",
"user_login": "fugacious"
} | [
{
"action": "opened",
"author": "adelevie",
"comment_id": null,
"datetime": 1471897942000,
"masked_author": "username_0",
"text": "",
"title": "fix spacing in message.rb",
"type": "issue"
},
{
"action": "created",
"author": "jgrevich",
"comment_id": 246256748,
"datetime": 1473660129000,
"masked_author": "username_1",
"text": "Thanks. Alan!",
"title": null,
"type": "comment"
}
] | 13 | false | true | 2 | 2 | false |
akofman/cordova-plugin-add-swift-support | null | 219,748,589 | 27 | null | [
{
"action": "opened",
"author": "chrisdurfee",
"comment_id": null,
"datetime": 1491436443000,
"masked_author": "username_0",
"text": "iTunes connect is refusing to allow builds to be uploaded in the application loader due to a missing \"SwiftSupport\" folder. I have included the plugin in my project but it still doesn't add the necessary swift files to allow it to be added to itunes. \r\n\r\niTunes error: \r\n\r\n'We have discovered one or more issues with your recent delivery for \"app name\". To process your delivery, the following issues must be corrected: \r\nInvalid Swift Support - The SwiftSupport folder is missing. Rebuild your app using the current public (GM) version of Xcode and resubmit it. \r\nOnce these issues have been corrected, you can then redeliver the corrected binary. \r\nRegards,'",
"title": "Invalid Swift Support iTunes Error",
"type": "issue"
},
{
"action": "created",
"author": "jelkevdh",
"comment_id": 305025628,
"datetime": 1496182887000,
"masked_author": "username_1",
"text": "Have the same issue :(",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "akofman",
"comment_id": 313742015,
"datetime": 1499447941000,
"masked_author": "username_2",
"text": "Hello guys, what version of `XCode` are you using ? Are you uploading your app from `XCode` or `Application Loader` ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrisdurfee",
"comment_id": 318917825,
"datetime": 1501437101000,
"masked_author": "username_0",
"text": "I'm using cocoon.io to cloud compile. They won't specify what version of xcode they use but I assume it recent. After i upload the iPad to the iTunes connect through application loader using xcode.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "akofman",
"comment_id": 318939970,
"datetime": 1501459801000,
"masked_author": "username_2",
"text": "hmmm maybe you don't use the last version of this plugin (1.7.0) ?\r\nThe previous versions were not compatible with the most recent xcode.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yogeshwar238",
"comment_id": 344247039,
"datetime": 1510663223000,
"masked_author": "username_3",
"text": "I am also facing the same issue. \r\nAny help is much appreciated.",
"title": null,
"type": "comment"
}
] | 1,197 | false | false | 4 | 6 | false |
nolimits4web/Swiper | null | 56,712,996 | 1,084 | null | [
{
"action": "opened",
"author": "soupking",
"comment_id": null,
"datetime": 1423162705000,
"masked_author": "username_0",
"text": "Hi username_1,\r\n\r\nI'm trying to build a page where the first slide slides halfway upon swipe and subsequent slides swipe underneath the first slide all sliding left horizontally. I see you have a vertical slider inside your horizontal nested slider demo but when the mode is altered it doesn't recognize it separately from the main one. Is there another attribute I need to turn off/on for this to happen?\r\n\r\nAlso is it possible to have slide images stop fixed at a certain value? Those are the two things I need to sort out to build this thing.\r\n\r\nThanks for any suggestions.",
"title": "Is it possible to build a horizontal nested Swiper inside another?",
"type": "issue"
},
{
"action": "created",
"author": "nolimits4web",
"comment_id": 73362588,
"datetime": 1423312543000,
"masked_author": "username_1",
"text": "No, it is impossible to have nested horizontal in horizontal",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "nolimits4web",
"comment_id": null,
"datetime": 1423686484000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "IllyaMoskvin",
"comment_id": 196377524,
"datetime": 1457970538000,
"masked_author": "username_2",
"text": "Apparently, it is possible now? You have to set `nested: true` for the configuration of the inner slider. Here, I modified the [nested swiper demo](http://idangero.us/swiper/demos/11-nested.html) from the main site so that the inner slider is horizontal, not vertical. Check out this fiddle: https://jsfiddle.net/imoskvin/s0fm20m6/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pkuczynski",
"comment_id": 250601752,
"datetime": 1475185906000,
"masked_author": "username_3",
"text": "Another example of an alternative nested swiper: https://jsfiddle.net/imoskvin/s0fm20m6/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "but1head",
"comment_id": 294359928,
"datetime": 1492359225000,
"masked_author": "username_4",
"text": "it is impossible for horizontal parent and freeMode nested?",
"title": null,
"type": "comment"
}
] | 1,116 | false | true | 5 | 6 | true |
nokiatech/heif | null | 266,424,403 | 25 | null | [
{
"action": "opened",
"author": "anbysure",
"comment_id": null,
"datetime": 1508319228000,
"masked_author": "username_0",
"text": "This is error log. please help me,thank you.\r\n\r\n[root@baseline build]# cmake ..\r\n-- The C compiler identification is GNU 4.4.7\r\n-- The CXX compiler identification is GNU 4.4.7\r\n-- Check for working C compiler: /usr/bin/cc\r\n-- Check for working C compiler: /usr/bin/cc -- works\r\n-- Detecting C compiler ABI info\r\n-- Detecting C compiler ABI info - done\r\n-- Check for working CXX compiler: /usr/bin/c++\r\n-- Check for working CXX compiler: /usr/bin/c++ -- works\r\n-- Detecting CXX compiler ABI info\r\n-- Detecting CXX compiler ABI info - done\r\n-- System name : Linux\r\n-- Project Name : HEIF\r\n-- Project directory : /home/heif\r\n-- Executables in : /home/heif/Bins\r\n-- File-list : \r\n-- Performing Test COMPILER_SUPPORTS_CXX11\r\n-- Performing Test COMPILER_SUPPORTS_CXX11 - Failed\r\n-- Performing Test COMPILER_SUPPORTS_CXX0X\r\n-- Performing Test COMPILER_SUPPORTS_CXX0X - Success\r\n-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) \r\n-- Configuring done\r\n-- Generating done\r\n-- Build files have been written to: /home/heif/build\r\n[root@baseline build]# make\r\n/usr/bin/cmake -H/home/heif -B/home/heif/build --check-build-system CMakeFiles/Makefile.cmake 0\r\n/usr/bin/cmake -E cmake_progress_start /home/heif/build/CMakeFiles /home/heif/build/CMakeFiles/progress.marks\r\nmake -f CMakeFiles/Makefile2 all\r\nmake[1]: Entering directory `/home/heif/build'\r\nmake -f Srcs/parser/h265parser/CMakeFiles/h265parser.dir/build.make Srcs/parser/h265parser/CMakeFiles/h265parser.dir/depend\r\nmake[2]: Entering directory `/home/heif/build'\r\ncd /home/heif/build && /usr/bin/cmake -E cmake_depends \"Unix Makefiles\" /home/heif /home/heif/Srcs/parser/h265parser /home/heif/build /home/heif/build/Srcs/parser/h265parser /home/heif/build/Srcs/parser/h265parser/CMakeFiles/h265parser.dir/DependInfo.cmake --color=\r\nScanning dependencies of target h265parser\r\nmake[2]: Leaving directory `/home/heif/build'\r\nmake -f Srcs/parser/h265parser/CMakeFiles/h265parser.dir/build.make Srcs/parser/h265parser/CMakeFiles/h265parser.dir/build\r\nmake[2]: Entering directory `/home/heif/build'\r\n/usr/bin/cmake -E cmake_progress_report /home/heif/build/CMakeFiles 65\r\n[ 1%] Building CXX object Srcs/parser/h265parser/CMakeFiles/h265parser.dir/h265parser.cpp.o\r\ncd /home/heif/build/Srcs/parser/h265parser && /usr/bin/c++ -std=c++0x -Wall -Wextra -Werror -Wno-missing-field-initializers -I/home/heif/Srcs/common -I/home/heif/Srcs/parser -o CMakeFiles/h265parser.dir/h265parser.cpp.o -c /home/heif/Srcs/parser/h265parser/h265parser.cpp\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp: In destructor ‘virtual H265Parser::~H265Parser()’:\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:38: error: expected initializer before ‘:’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:43: error: expected primary-expression before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:43: error: expected ‘;’ before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:43: error: expected primary-expression before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:43: error: expected ‘)’ before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:43: error: expected initializer before ‘:’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:48: error: expected primary-expression before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:48: error: expected ‘;’ before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:48: error: expected primary-expression before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:48: error: expected ‘)’ before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:48: error: expected initializer before ‘:’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:52: error: expected primary-expression before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:52: error: expected ‘;’ before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:52: error: expected primary-expression before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:52: error: expected ‘)’ before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:52: error: expected primary-expression before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:52: error: expected ‘;’ before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp: In member function ‘bool H265Parser::initDisplayOrderArray(const char*)’:\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:109: error: expected initializer before ‘:’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:116: error: could not convert ‘std::sort [with _RAIter = __gnu_cxx::__normal_iterator<ParserInterface::PicOrder*, std::vector<ParserInterface::PicOrder, std::allocator<ParserInterface::PicOrder> > >, _Compare = bool (*)(const ParserInterface::PicOrder&, const ParserInterface::PicOrder&)](picOrder.std::vector<_Tp, _Alloc>::begin [with _Tp = ParserInterface::PicOrder, _Alloc = std::allocator<ParserInterface::PicOrder>](), picOrder.std::vector<_Tp, _Alloc>::end [with _Tp = ParserInterface::PicOrder, _Alloc = std::allocator<ParserInterface::PicOrder>](), ParserInterface::compareDecodeOrder)’ to ‘bool’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:118: error: expected primary-expression before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:118: error: expected ‘)’ before ‘for’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:118: error: expected initializer before ‘:’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:122: error: could not convert ‘picOrder.std::vector<_Tp, _Alloc>::clear [with _Tp = ParserInterface::PicOrder, _Alloc = std::allocator<ParserInterface::PicOrder>]()’ to ‘bool’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:123: error: expected primary-expression before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:123: error: expected ‘)’ before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:123: error: expected primary-expression before ‘}’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:123: error: expected ‘;’ before ‘}’ token\r\ncc1plus: warnings being treated as errors\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:86: error: unused variable ‘displayNum’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp: In member function ‘bool H265Parser::hasVpsExtension()’:\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:147: error: expected initializer before ‘:’ token\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: expected primary-expression at end of input\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: expected ‘;’ at end of input\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: expected primary-expression at end of input\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: expected ‘)’ at end of input\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: expected statement at end of input\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:146: error: unused variable ‘hasExtension’\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: expected ‘}’ at end of input\r\n/home/heif/Srcs/parser/h265parser/h265parser.cpp:3033: error: no return statement in function returning non-void\r\nmake[2]: *** [Srcs/parser/h265parser/CMakeFiles/h265parser.dir/h265parser.cpp.o] Error 1\r\nmake[2]: Leaving directory `/home/heif/build'\r\nmake[1]: *** [Srcs/parser/h265parser/CMakeFiles/h265parser.dir/all] Error 2\r\nmake[1]: Leaving directory `/home/heif/build'\r\nmake: *** [all] Error 2",
"title": "build fail in Centos 6.5",
"type": "issue"
},
{
"action": "created",
"author": "guoying1030",
"comment_id": 346562238,
"datetime": 1511427911000,
"masked_author": "username_1",
"text": "you must upgrad gcc and g++ to 4.8",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jieweijasson",
"comment_id": 363365680,
"datetime": 1517909976000,
"masked_author": "username_2",
"text": "请问我在centos7上编译通过了，生成了可执行文件，下一步怎么让.heic格式的图片转为jpeg格式？谢谢",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nokiatech",
"comment_id": 371476688,
"datetime": 1520513095000,
"masked_author": "username_3",
"text": "Code requires C++11 support from compiler.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "nokiatech",
"comment_id": null,
"datetime": 1520513095000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 7,606 | false | false | 4 | 5 | false |
appcelerator/amp | appcelerator | 172,890,111 | 59 | null | [
{
"action": "opened",
"author": "ndegory",
"comment_id": null,
"datetime": 1472026109000,
"masked_author": "username_0",
"text": "Main issue is that when the Kafka input fails, the telemetry worker doesn't exit, because there's at least one input that is working correctly. the netstat plugin (enabled by default in the image) should be explicitely removed from the telemetry worker.",
"title": "netstat metrics from telemetry workers appeared in influxdb",
"type": "issue"
},
{
"action": "closed",
"author": "freignat91",
"comment_id": null,
"datetime": 1472026423000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 253 | false | false | 2 | 2 | false |
clawpack/clawpack | clawpack | 191,415,364 | 94 | {
"number": 94,
"repo": "clawpack",
"user_login": "clawpack"
} | [
{
"action": "opened",
"author": "mandli",
"comment_id": null,
"datetime": 1479951456000,
"masked_author": "username_0",
"text": "See PRs in the sub-repositories for details:\r\n - clawpack/amrclaw#178\r\n - clawpack/geoclaw#232\r\n - clawpack/clawutil#106\r\n - clawpack/classic#75",
"title": "Adds gauge output options",
"type": "issue"
},
{
"action": "created",
"author": "rjleveque",
"comment_id": 263167812,
"datetime": 1480298996000,
"masked_author": "username_1",
"text": "Will be replaced by a new PR.",
"title": null,
"type": "comment"
}
] | 173 | false | false | 2 | 2 | false |
auth0/repo-supervisor | auth0 | 240,170,774 | 7 | null | [
{
"action": "opened",
"author": "glenjamin",
"comment_id": null,
"datetime": 1499088023000,
"masked_author": "username_0",
"text": "/Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:13199\r\n result[value] = key;\r\n ^\r\n\r\nTypeError: Cannot convert object to primitive value\r\n at /Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:13199:21\r\n at /Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:3209:9\r\n at /Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:4944:15\r\n at baseForOwn (/Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:3001:24)\r\n at baseInverter (/Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:3208:7)\r\n at /Users/glen/Development/GitHub/repo-supervisor/node_modules/lodash/lodash.js:5247:16\r\n at e.exports (/Users/glen/Development/GitHub/repo-supervisor/dist/cli.js:1:3646)\r\n at /Users/glen/Development/GitHub/repo-supervisor/dist/cli.js:1:2281\r\n at Array.forEach (native)\r\n at Object.processFile (/Users/glen/Development/GitHub/repo-supervisor/dist/cli.js:1:2148)\r\n```",
"title": "Crashes with \"Cannot convert object to primitive value\"",
"type": "issue"
},
{
"action": "created",
"author": "radekk",
"comment_id": 314787693,
"datetime": 1499869894000,
"masked_author": "username_1",
"text": "I tried to reproduce this issue successfully. It does trigger an error when you scan the current directory of repo-supervisor project.\r\n\r\nIt's caused by `node_modules/globals/globals.json` file which is a standard JSON file but it breaks `invert()` function from `lodash` module. I already filled an issue for mentioned library, depending on that I will decide what to do further.\r\n\r\nReported issue: https://github.com/lodash/lodash/issues/3260",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "radekk",
"comment_id": null,
"datetime": 1499983541000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 1,508 | false | false | 2 | 3 | false |
KnpLabs/FriendlyContexts | KnpLabs | 217,327,387 | 227 | null | [
{
"action": "opened",
"author": "Nek-",
"comment_id": null,
"datetime": 1490637821000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nI think we should consider to add a configuration \"by feature\" and enable (or not) features with this configuration. (just like it's done in the FrameworkBundle of Symfony !)\r\n\r\nThis would fix #225.\r\n\r\nI already start to work on the topic. Stop me if you think it's a wrong idea :) .",
"title": "[RFC] Disable features by default",
"type": "issue"
},
{
"action": "created",
"author": "Einenlum",
"comment_id": 289695678,
"datetime": 1490688628000,
"masked_author": "username_1",
"text": ":+1:",
"title": null,
"type": "comment"
}
] | 297 | false | false | 2 | 2 | false |
YoKeyword/Fragmentation | null | 269,873,030 | 619 | null | [
{
"action": "opened",
"author": "andy91310",
"comment_id": null,
"datetime": 1509438340000,
"masked_author": "username_0",
"text": "`Caused by: android.content.res.Resources$NotFoundException: File res/anim/h_fragment_exit.xml from xml type anim resource ID #0x7f050012\r\n\tat android.content.res.Resources.loadXmlResourceParser(Resources.java:3743)\r\n\tat android.content.res.Resources.loadXmlResourceParser(Resources.java:3690)\r\n\tat android.content.res.Resources.getAnimation(Resources.java:2165)\r\n\tat android.view.animation.AnimationUtils.loadAnimation(AnimationUtils.java:71)\r\n\tat me.yokeyword.fragmentation.helper.internal.AnimatorHelper.initExitAnim(AnimatorHelper.java:75)\r\n\tat me.yokeyword.fragmentation.helper.internal.AnimatorHelper.notifyChanged(AnimatorHelper.java:30)\r\n\tat me.yokeyword.fragmentation.helper.internal.AnimatorHelper.<init>(AnimatorHelper.java:24)\r\n\tat me.yokeyword.fragmentation.SupportFragmentDelegate.onCreate(SupportFragmentDelegate.java:108)\r\n\tat me.yokeyword.fragmentation.SupportFragment.onCreate(SupportFragment.java:48)\r\n\tat com.ftt.app.ui.fragment.BaseMvpFragment.onCreate(BaseMvpFragment.java:18)\r\n\tat android.support.v4.app.Fragment.performCreate(Fragment.java:2339)\r\n\tat android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1377)\r\n\tat android.support.v4.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1740)\r\n\tat android.support.v4.app.BackStackRecord.executeOps(BackStackRecord.java:794)\r\n\tat android.support.v4.app.FragmentManagerImpl.executeOps(FragmentManager.java:2580)\r\n\tat android.support.v4.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2367)\r\n\tat android.support.v4.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManager.java:2322)\r\n\tat android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:2229)\r\n\tat android.support.v4.app.FragmentManagerImpl.dispatchStateChange(FragmentManager.java:3221)\r\n\tat android.support.v4.app.FragmentManagerImpl.dispatchActivityCreated(FragmentManager.java:3171)\r\n\tat android.support.v4.app.Fragment.performActivityCreated(Fragment.java:2369)\r\n\tat android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1442)\r\n\tat android.support.v4.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManager.java:1740)\r\n\tat android.support.v4.app.FragmentManagerImpl.moveToState(FragmentManager.java:1809)\r\n\tat android.support.v4.app.BackStackRecord.executeOps(BackStackRecord.java:799)\r\n\tat android.support.v4.app.FragmentManagerImpl.executeOps(FragmentManager.java:2580)\r\n\tat android.support.v4.app.FragmentManagerImpl.executeOpsTogether(FragmentManager.java:2367)\r\n\tat android.support.v4.app.FragmentManagerImpl.removeRedundantOperationsAndExecute(FragmentManager.java:2322)\r\n\tat android.support.v4.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:2229)\r\n\tat android.support.v4.app.FragmentManagerImpl.dispatchStateChange(FragmentManager.java:3221)\r\n\tat android.support.v4.app.FragmentManagerImpl.dispatchActivityCreated(FragmentManager.java:3171)\r\n\tat android.support.v4.app.FragmentController.dispatchActivityCreated(FragmentController.java:192)\r\n\tat android.support.v4.app.FragmentActivity.onStart(FragmentActivity.java:560)\r\n\tat android.support.v7.app.AppCompatActivity.onStart(AppCompatActivity.java:177)\r\n\tat android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1178)\r\n\tat android.app.Activity.performStart(Activity.java:5321)\r\n\tat android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2292)\r\n\t... 11 more`",
"title": "这个错误是因为什么呢？",
"type": "issue"
},
{
"action": "created",
"author": "YoKeyword",
"comment_id": 340729095,
"datetime": 1509447706000,
"masked_author": "username_1",
"text": "描述下发生异常的环境\r\n\r\n偶现还是必现？ 线上环境还是开发环境？",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "andy91310",
"comment_id": 340962600,
"datetime": 1509504235000,
"masked_author": "username_0",
"text": "线上环境呢，目前只发现一个在三星4.4.4的手机上。",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "YoKeyword",
"comment_id": null,
"datetime": 1509523956000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "YoKeyword",
"comment_id": 341029740,
"datetime": 1509523956000,
"masked_author": "username_1",
"text": "如果发生在开发环境，一般clean下即可；\r\n\r\n你的情况是只发生在线上该机型，并只有一次的话，可以忽略， 毕竟Android系统也会抽风 ＝，＝",
"title": null,
"type": "comment"
}
] | 3,564 | false | false | 2 | 5 | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.