repo stringlengths 7 67 | org stringlengths 2 32 ⌀ | issue_id int64 780k 941M | issue_number int64 1 134k | pull_request dict | events list | user_count int64 1 77 | event_count int64 1 192 | text_size int64 0 329k | bot_issue bool 1 class | modified_by_bot bool 2 classes | text_size_no_bots int64 0 279k | modified_usernames bool 2 classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
GoogleCloudPlatform/gcsfuse | GoogleCloudPlatform | 98,032,667 | 94 | null | [
{
"action": "opened",
"author": "jacobsa",
"comment_id": null,
"datetime": 1438205256000,
"masked_author": "username_0",
"text": "During the refactor of the installation instructions to deal with release binaries, I accidentally killed two things that [used to be](https://github.com/GoogleCloudPlatform/gcsfuse/blob/634609f64f84464a3f5c743ec9cff623addfce11/docs/installing.md#debian-and-ubuntu) there:\r\n\r\n1. Add yourself to group `fuse`.\r\n2. Work around the Debian permissions bug.\r\n\r\nThese need to be restored.",
"title": "/dev/fuse permissions issues and installation instructions",
"type": "issue"
},
{
"action": "created",
"author": "jacobsa",
"comment_id": 126101010,
"datetime": 1438205386000,
"masked_author": "username_0",
"text": "Oops, (2) is actually [already there](https://github.com/googlecloudplatform/gcsfuse/blob/ab844839b7fe5e762e66bea10fec6515ffa7da10/docs/installing.md#debian-and-ubuntu). (1) is still missing, though.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jacobsa",
"comment_id": null,
"datetime": 1438205675000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 581 | false | false | 581 | false |
deepgram/kur | deepgram | 226,763,994 | 72 | null | [
{
"action": "opened",
"author": "EmbraceLife",
"comment_id": null,
"datetime": 1494071364000,
"masked_author": "username_0",
"text": "I want to convert a gan_mnist in tensorflow to gan_mnist in kur. \r\n\r\nAt this moment, all I know about model in kur is the following: \r\nmodel's life cycle: \r\n1. model as dict in kurfile --> \r\n2. model as list of kur containers or layers --> \r\n3. model as layers of keras --> \r\n4. with a Func defined in keras (which I cannot manage to see inside from kur) to train (forward pass to get loss, and backward pass to update weights) \r\n\r\nTherefore, it seems to me that I can only access loss and weights easily with kur source, but I have not see a way to access each layer's output directly, such as logits of each model below. Is there a way to access each layer's output directly? \r\n\r\nAnother difficulty I have is write the models in kurfile. Is the kurfile below make sense or valid in logic? Sometimes I am confused about when to use `-`, and when not to use `-`, I have marked the place where I am particularly confused with `????`. \r\n\r\nThere are two sections below: 1. parts of kurfile; 2. corresponding parts in tensorflow\r\n\r\nSection1: some key sections of gan_mnist pseudo-kurfile \r\n\r\n```yaml\r\nmodel: # see model code in tensorflow below\r\n generator:\r\n - input: input_z # shape (?, 100)\r\n - dense: 128 # g_hidden_size = 128\r\n - activation:\r\n name: leakyrelu\r\n alpha: 0.01\r\n - dense: 784 # out_dim (generator) = input_size (real image) = 784\r\n - activation:\r\n name: tanh\r\n - output: # output of the latest layer\r\n name: g_out # shape (?, 784)\r\n\r\n discriminator_real:\r\n - input: input_real # or images # shape (?, 784)\r\n - dense: 128 # d_hidden_size\r\n - activation:\r\n name: leakyrelu\r\n alpha: 0.01\r\n - dense: 1 # shrink nodes from 128 to 1, for 2_labels classification with sigmoid (non softmax)\r\n logits: d_logits_real # can I output logits here\r\n# do I need to output logits\r\n - activation:\r\n name: sigmoid\r\n - output: # output of the latest layer\r\n# can logits in the layer before the latest layer be accessed from here?\r\n name: d_out_real # not used at all ?\r\n\r\n discriminator_fake:\r\n - input: g_out # shape (?, 784)\r\n - dense: 128 # d_hidden_size\r\n - activation:\r\n name: leakyrelu\r\n alpha: 0.01\r\n - dense: 1 # shrink nodes from 128 to 1, for 2_labels classification with sigmoid (non softmax)\r\n logits: d_logits_fake # can I output logits here\r\n# do I need to output logits\r\n - activation:\r\n name: sigmoid\r\n - output: # output of the latest layer\r\n# can logits in the layer before the latest layer be accessed from here?\r\n name: d_out_fake # not used at all?\r\n\r\n# https://kur.deepgram.com/specification.html?highlight=loss#loss\r\nloss: # see loss code in tensorflow below\r\n generator:\r\n - target: labels_g # labels=tf.ones_like(d_logits_fake), it can be defined as one input data \r\n - logits: d_logits_fake # when to use `-`, when not????\r\n name: categorical_crossentropy\r\n g_loss: g_loss\r\n discriminator_real:\r\n - target: labels_d_real # labels=tf.ones_like(d_logits_real) * (1 - smooth)\r\n - logits: d_logits_real\r\n name: categorical_crossentropy\r\n d_loss_real: d_loss_real\r\n discriminator_fake:\r\n - target: labels_d_fake # labels=tf.zeros_like(d_logits_fake)\r\n - logits: d_logits_fake\r\n name: categorical_crossentropy\r\n d_loss_fake: d_loss_fake\r\n\r\ntrain:\r\n optimizer: # see the optimizers tensorflow code below\r\n - opt_discriminator:\r\n name: adam\r\n learning_rate: 0.001\r\n d_loss: d_loss # d_loss = d_loss_real + d_loss_fake\r\n d_trainable: d_vars\r\n - opt_generator:\r\n name: adam\r\n learning_rate: 0.001\r\n g_loss: g_loss\r\n g_trainable: g_vars\r\n```\r\n\r\n\r\nSection2 is the key parts (d_model, g_model, losses, optimizers ... ) in tensorflow below\r\n\r\n**Inputs for generator and discriminator**\r\n```python\r\ndef model_inputs(real_dim, z_dim):\r\n\t# real_dim is 784 for sure\r\n inputs_real = tf.placeholder(tf.float32, (None, real_dim), name='input_real')\r\n\r\n\t# z_dim is set 100, but can be almost any number\r\n inputs_z = tf.placeholder(tf.float32, (None, z_dim), name='input_z')\r\n\r\n return inputs_real, inputs_z\r\n```\r\n\r\n**Generator model**\r\n```python\r\ndef generator(z, out_dim, n_units=128, reuse=False, alpha=0.01):\r\n with tf.variable_scope('generator', reuse=reuse):\r\n # Hidden layer\r\n h1 = tf.layers.dense(z, n_units, activation=None)\r\n # Leaky ReLU\r\n h1 = tf.maximum(alpha * h1, h1)\r\n\r\n # Logits and tanh output\r\n logits = tf.layers.dense(h1, out_dim, activation=None)\r\n out = tf.tanh(logits)\r\n\r\n return out\r\n```\r\n\r\n**Discriminator model**\r\n```python\r\n\r\ndef discriminator(x, n_units=128, reuse=False, alpha=0.01):\r\n with tf.variable_scope('discriminator', reuse=reuse):\r\n # Hidden layer\r\n h1 = tf.layers.dense(x, n_units, activation=None)\r\n # Leaky ReLU\r\n h1 = tf.maximum(alpha * h1, h1)\r\n\r\n logits = tf.layers.dense(h1, 1, activation=None)\r\n out = tf.sigmoid(logits)\r\n\r\n return out, logits\r\n```\r\n\r\n\r\n**Hyperparameters**\r\n```python\r\n# Size of input image to discriminator\r\ninput_size = 784\r\n# Size of latent vector to generator\r\n# The latent sample is a random vector the generator uses to construct it's fake images. As the generator learns through training, it figures out how to map these random vectors to recognizable images that can fool the discriminator\r\nz_size = 100 # not 784! so it can be any number?\r\n# Sizes of hidden layers in generator and discriminator\r\ng_hidden_size = 128\r\nd_hidden_size = 128\r\n# Leak factor for leaky ReLU\r\nalpha = 0.01\r\n# Smoothing\r\nsmooth = 0.1\r\n```\r\n\r\n**Build network**\r\n```python\r\ntf.reset_default_graph()\r\n\r\n# Create our input placeholders\r\ninput_real, input_z = model_inputs(input_size, z_size)\r\n\r\n# Build the model\r\ng_out = generator(input_z, input_size)\r\n# g_out is the generator output, not model object\r\n\r\n# discriminate on real images, get output and logits\r\nd_out_real, d_logits_real = discriminator(input_real)\r\n# discriminate on generated images, get output and logits\r\nd_out_fake, d_logits_fake = discriminator(g_out, reuse=True)\r\n\r\n```\r\n\r\n**Calculate losses**\r\n```python\r\n# get loss on how good discriminator work on real images\r\nd_loss_real = tf.reduce_mean(\r\n tf.nn.sigmoid_cross_entropy_with_logits(\r\n\t\t\t\t \t\t\tlogits=d_logits_real,\r\n\t\t\t\t\t\t\t# labels are all true as 1s\r\n\t\t\t\t\t\t\t# label smoothing *(1-smooth)\r\n labels=tf.ones_like(d_logits_real) * (1 - smooth)))\r\n\r\n# get loss on how good discriminator work on generated images \t\t\t\t\t\t\t\r\nd_loss_fake = tf.reduce_mean(# get the mean for all the images in the batch\r\n tf.nn.sigmoid_cross_entropy_with_logits(\r\n\t\t\t\t \t\t\tlogits=d_logits_fake,\r\n\t\t\t\t\t\t\t# labels are all false, as 0s\r\n labels=tf.zeros_like(d_logits_real)))\r\n\r\n# get total loss by adding up \t\t\t\t\t\t\t\r\nd_loss = d_loss_real + d_loss_fake\r\n\r\n# get loss on how well generator work for generating images as real as possible\r\ng_loss = tf.reduce_mean(\r\n tf.nn.sigmoid_cross_entropy_with_logits(\r\n\t\t\t \t\t\tlogits=d_logits_fake,\r\n\t\t\t\t\t\t# generator wants images all be real as possible, so set True, 1s\r\n labels=tf.ones_like(d_logits_fake)))\r\n```\r\n\r\n\r\n**Optimizers**\r\n```python\r\n# Optimizers\r\nlearning_rate = 0.002\r\n\r\n# Get the trainable_variables, split into G and D parts\r\nt_vars = tf.trainable_variables()\r\ng_vars = [var for var in t_vars if var.name.startswith('generator')]\r\nd_vars = [var for var in t_vars if var.name.startswith('discriminator')]\r\n\r\n# update the selected weights, or the discriminator weights\r\nd_train_opt = tf.train.AdamOptimizer(learning_rate).minimize(d_loss, var_list=d_vars)\r\n\r\n# update the selected weights, or the generator weights\r\ng_train_opt = tf.train.AdamOptimizer(learning_rate).minimize(g_loss, var_list=g_vars)\r\n```",
"title": "How to convert gan_mnist example from tensorflow to kur?",
"type": "issue"
},
{
"action": "created",
"author": "ajsyp",
"comment_id": 300503915,
"datetime": 1494427289000,
"masked_author": "username_1",
"text": "I'm not certain what you mean by, \"It seems to me that I can't access each layer's output directly, such as logits of each model below.... Is there a way to access each layer's output directly with kur?\" What does \"directly\" mean? You can reference other layers by name, and you can cause any layer to be outputted as part of the model output.\r\n\r\nI think the bigger question is multi-modal architectures, like GANs. These are _not_ currently supported in Kur, but is something on the horizon that I've been thinking about adding. Your Kurfile is logically consistent, I think, and stylistically good, but it isn't a valid Kurfile because, well, Kur doesn't support multiple models.\r\n\r\nP.S. When to use \"-\" or not is a YAML thing. If you indent and use \"-\", you are starting a list:\r\n```\r\ngrocery_list:\r\n - apples\r\n - oranges\r\n```\r\nIf you indent without using \"-\", you are starting a map/dictionary/key-value pairs:\r\n```\r\nmovie_ratings:\r\n harry_potter: good\r\n twilight: bad\r\n```\r\nYou can nest these things: you can have list items which are dictionaries, you have dictionaries whose values are lists, you can have dictionaries whose values are dictionaries, you can have list items which are themselves lists, etc. If you are ever in doubt, look at the YAML spec or, if you are more comfortable in JSON, just use JSON Kurfiles or a YAML/JSON converter to see what is going on.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 9,275 | false | false | 9,275 | false |
deis/controller | deis | 145,295,225 | 592 | {
"number": 592,
"repo": "controller",
"user_login": "deis"
} | [
{
"action": "opened",
"author": "bacongobbler",
"comment_id": null,
"datetime": 1459547836000,
"masked_author": "username_0",
"text": "Django Rest Framework will wrap the string with quotes because\r\nof the JSONRenderer. Django's HttpResponse class handles the\r\napplication logs as we expect it to.\r\n\r\nthis is a port of deis/deis#5004",
"title": "fix(controller): use django HttpResponse for logs",
"type": "issue"
},
{
"action": "created",
"author": "bacongobbler",
"comment_id": 204584110,
"datetime": 1459547914000,
"masked_author": "username_0",
"text": "throwing on a \"needs manual testing\" because I've tested this fix on v1 but not on v2.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "helgi",
"comment_id": 207131570,
"datetime": 1460070242000,
"masked_author": "username_1",
"text": "There is no way to make DRF do what we want?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bacongobbler",
"comment_id": 207171324,
"datetime": 1460080754000,
"masked_author": "username_0",
"text": "Not optimally. You'd have to create a third party PlainTextRenderer class, but then you have to figure out a way to get it to only apply to the `logs` function in the AppView.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bacongobbler",
"comment_id": 207171917,
"datetime": 1460080805000,
"masked_author": "username_0",
"text": "AFAIK DRF only allows renderers to apply to the entire class or to a module function but not to a specific function in a class.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "helgi",
"comment_id": 207526781,
"datetime": 1460136528000,
"masked_author": "username_1",
"text": "Ah yeah I see now, http://www.django-rest-framework.org/api-guide/renderers/#example why on earth wouldn't they just include that\r\n\r\nHowever applying a single render is easy `@renderer_classes((PlainTextRenderer))` decorator on the given functions",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bacongobbler",
"comment_id": 209528024,
"datetime": 1460564116000,
"masked_author": "username_0",
"text": "@username_1 any clue on how to compare a byte string to a regular string? Looks like more python 3 snarf again: https://travis-ci.org/deis/controller/builds/122652731#L346",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "helgi",
"comment_id": 209531584,
"datetime": 1460564773000,
"masked_author": "username_1",
"text": "Then you are converting it wrong, a `str()` is not enough. You can also try `assertIn` or `assertContains`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "helgi",
"comment_id": 209532117,
"datetime": 1460564878000,
"masked_author": "username_1",
"text": "`response.content.decode(encoding='UTF-8')` would be how you convert it to a string",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "helgi",
"comment_id": 209532427,
"datetime": 1460564926000,
"masked_author": "username_1",
"text": "`str(bytesThing, encoding='UTF-8')` might... Can't recall",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bacongobbler",
"comment_id": 211492833,
"datetime": 1461001161000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "helgi",
"comment_id": 211494265,
"datetime": 1461001296000,
"masked_author": "username_1",
"text": "I've def used `assertContains` a few times in our tests to get past a `b'foo'` problem :) Lets use that for consistency but I'd recommend adding the `status_code` to the `contains` call so it is a \"single\" failure instead of 2 assertions like they are now",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bacongobbler",
"comment_id": 213555766,
"datetime": 1461351820000,
"masked_author": "username_0",
"text": "Jenkins really doesn't like me today. Those test failures are `ps` test failures as well as router issues, so it's unrelated to these changes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "helgi",
"comment_id": 213555952,
"datetime": 1461351846000,
"masked_author": "username_1",
"text": "I've been seeing those as well on other PRs...",
"title": null,
"type": "comment"
}
] | 3 | 15 | 1,732 | false | true | 1,732 | true |
Azure/azure-cli | Azure | 294,969,045 | 5,503 | null | [
{
"action": "opened",
"author": "chrisdias",
"comment_id": null,
"datetime": 1517965253000,
"masked_author": "username_0",
"text": "I tried to install the latest CLI from the docs: https://docs.microsoft.com/en-us/cli/azure/install-azure-cli-macos?view=azure-cli-latest. I'm pretty sure I installed using brew so I ran:\r\n \r\nbrew update && brew install azure-cli\r\n \r\nit ran for a while, then this:\r\n \r\n```\r\nError: An unexpected error occurred during the `brew link` step\r\nThe formula built, but is not symlinked into /usr/local\r\nPermission denied @ dir_s_mkdir - /usr/local/Frameworks\r\nError: Permission denied @ dir_s_mkdir - /usr/local/Frameworks\r\n```\r\n\r\nTried to do this manually:\r\n\r\n``` \r\n~/src/vscode-docker$ brew link --overwrite python3\r\nLinking /usr/local/Cellar/python3/3.6.4_2... Error: Permission denied @ dir_s_mkdir - /usr/local/Frameworks\r\n```\r\n \r\nSo I tried running with sudo and get a big error:\r\n\r\n``` \r\n~/src/vscode-docker$ sudo brew link --overwrite python3\r\nPassword:\r\nError: Running Homebrew as root is extremely dangerous and no longer supported.\r\nAs Homebrew does not drop privileges on installation you would be giving all\r\nbuild scripts full access to your system.\r\n```\r\n\r\nIf i run `brew upgrade azure-cli` i see:\r\n\r\n`Error: azure-cli 2.0.26 already installed`\r\n\r\nif i `which az` gives me `/usr/local/bin/az`",
"title": "unable to update cli using homebrew",
"type": "issue"
},
{
"action": "created",
"author": "derekbekoe",
"comment_id": 363620407,
"datetime": 1517965573000,
"masked_author": "username_1",
"text": "Please provide\r\n```\r\nCLI version (az --version) / OS version / Shell Type (e.g. bash, cmd.exe, Bash on Windows)\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrisdias",
"comment_id": 363622408,
"datetime": 1517966207000,
"masked_author": "username_0",
"text": "sorry. Im on a Mac (10.13.2) using bash. after trying to run az upgrade a few different ways, now i have this:\r\n\r\n~/src$ az -v\r\nNo module named 'pkg_resources'\r\nTraceback (most recent call last):\r\n File \"/usr/local/Cellar/azure-cli/2.0.26/libexec/lib/python3.6/site-packages/knack/cli.py\", line 187, in invoke\r\n self.show_version()\r\n File \"/usr/local/Cellar/azure-cli/2.0.26/libexec/lib/python3.6/site-packages/azure/cli/core/__init__.py\", line 79, in show_version\r\n print(get_az_version_string())\r\n File \"/usr/local/Cellar/azure-cli/2.0.26/libexec/lib/python3.6/site-packages/azure/cli/core/util.py\", line 60, in get_az_version_string\r\n installed_dists = get_installed_cli_distributions()\r\n File \"/usr/local/Cellar/azure-cli/2.0.26/libexec/lib/python3.6/site-packages/azure/cli/core/util.py\", line 51, in get_installed_cli_distributions\r\n from pkg_resources import working_set\r\nModuleNotFoundError: No module named 'pkg_resources'",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "derekbekoe",
"comment_id": 363835783,
"datetime": 1518022658000,
"masked_author": "username_1",
"text": "Are you in a Python virtual environment or have 'az' installed elsewhere on the machine?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrisdias",
"comment_id": 363839942,
"datetime": 1518023419000,
"masked_author": "username_0",
"text": "i am not in a python virtual environment as far as i know and i may have had az installed elsewhere. i can't remember how i originally installed it. i think there was a .dmg or .zip for mac as well, but that doesn't seem to exist anymore.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mattmasteller",
"comment_id": 364361548,
"datetime": 1518163002000,
"masked_author": "username_2",
"text": "I have very similar issues. Wondering if it has anything to do with running Python 3.6.3 using the Anaconda distribution? \r\n\r\n```bash\r\n$ python --version\r\nPython 3.6.3 :: Anaconda, Inc.\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "grimaldou",
"comment_id": 365703157,
"datetime": 1518633470000,
"masked_author": "username_3",
"text": "Same here, do you have any news?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "grimaldou",
"comment_id": 365705766,
"datetime": 1518634013000,
"masked_author": "username_3",
"text": "I solve my case, hope solve yours:\r\n\r\n1.- Uninstall Azure CLI (could have an error, it is ok)\r\n`brew uninstall azure-cli`\r\n\r\n2.- Update just brew\r\n`brew update`\r\n\r\n3.- Upgrade brew\r\n`brew upgrade`\r\n\r\n4.- Clean up brew\r\n`brew cleanup`\r\n\r\n5.- Reinstall just the Azure CLI\r\n `brew install azure-cli`\r\n\r\n6.- Check the CLI\r\n`az help`\r\n\r\nHope it works for you!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pjhayward",
"comment_id": 368789853,
"datetime": 1519721221000,
"masked_author": "username_4",
"text": "@username_3 's suggestion worked for me after I made sure that Python 3.6.x was properly installed. I used Anaconda to install and activate it in an environment.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrisdias",
"comment_id": 369791588,
"datetime": 1519954727000,
"masked_author": "username_0",
"text": "It looks like I had originally installed the az CLI using the install script (https://docs.microsoft.com/en-us/cli/azure/install-azure-cli-linux?view=azure-cli-latest). I cleaned that up using the instructions provided with that page, then installed using homebrew and it works. Generally. When I run `az --version` I get this:\r\n\r\n```\r\n~/src$ az --version\r\nNo module named 'pkg_resources'\r\nTraceback (most recent call last):\r\n File \"/usr/local/Cellar/azure-cli/2.0.28/libexec/lib/python3.6/site-packages/knack/cli.py\", line 187, in invoke\r\n self.show_version()\r\n File \"/usr/local/Cellar/azure-cli/2.0.28/libexec/lib/python3.6/site-packages/azure/cli/core/__init__.py\", line 79, in show_version\r\n print(get_az_version_string())\r\n File \"/usr/local/Cellar/azure-cli/2.0.28/libexec/lib/python3.6/site-packages/azure/cli/core/util.py\", line 60, in get_az_version_string\r\n installed_dists = get_installed_cli_distributions()\r\n File \"/usr/local/Cellar/azure-cli/2.0.28/libexec/lib/python3.6/site-packages/azure/cli/core/util.py\", line 51, in get_installed_cli_distributions\r\n from pkg_resources import working_set\r\nModuleNotFoundError: No module named 'pkg_resources'\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pjhayward",
"comment_id": 369849866,
"datetime": 1519977727000,
"masked_author": "username_4",
"text": "Hi Chris,\n\nThis happens when your Python environment is not set up correctly. I manage Python versions and environments for different projects with Anaconda. When I run `az —verion` under my standard environment I get the same error as reported below. However, the command works when I change to me Python 3.6.2 environment under which azure-cli was installed. Here is an example of the output it gives me:\n\n peter@Peters-MacBook-Pro > source activate py3.6.2\n peter@Peters-MacBook-Pro > az --version\nazure-cli (2.0.27)\n\nacr (2.0.21)\nacs (2.0.26)\nadvisor (0.1.2)\nappservice (0.1.26)\nbackup (1.0.6)\nbatch (3.1.10)\nbatchai (0.1.5)\nbilling (0.1.7)\ncdn (0.0.13)\ncloud (2.0.12)\ncognitiveservices (0.1.10)\ncommand-modules-nspkg (2.0.1)\nconfigure (2.0.14)\nconsumption (0.2.1)\ncontainer (0.1.18)\ncore (2.0.27)\ncosmosdb (0.1.19)\ndla (0.0.18)\ndls (0.0.19)\neventgrid (0.1.10)\nextension (0.0.9)\nfeedback (2.1.0)\nfind (0.2.8)\ninteractive (0.3.16)\niot (0.1.17)\nkeyvault (2.0.18)\nlab (0.0.17)\nmonitor (0.1.2)\nnetwork (2.0.23)\nnspkg (3.0.1)\nprofile (2.0.19)\nrdbms (0.0.12)\nredis (0.2.11)\nreservations (0.1.1)\nresource (2.0.23)\nrole (2.0.19)\nservicefabric (0.0.10)\nsql (2.0.21)\nstorage (2.0.25)\nvm (2.0.26)\n\nPython location '/Users/peter/Anaconda2/envs/py3.6.2/bin/python3.6'\nExtensions directory '/Users/peter/.azure/cliextensions'\n\nPython (Darwin) 3.6.2 |Anaconda custom (x86_64)| (default, Jul 20 2017, 13:14:59)\n[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)]\n\nLegal docs and information: aka.ms/AzureCliLegal\n\nHope this helps.\n\nKind regards,\n\n-- \nPeter Hayward\nData Scientist · Praelexis\n\nCapital Place F · 15 - 21 Neutron Avenue · Technopark · Stellenbosch · 7600\nTel: +27 (0) 72 354 5228 \n\nEmail: peterhayward@praelexis.com <mailto:mcelory@praelexis.com>\n\n>",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "chrisdias",
"comment_id": null,
"datetime": 1520122685000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "chrisdias",
"comment_id": 370190795,
"datetime": 1520122685000,
"masked_author": "username_0",
"text": "Update: \r\n\r\nI was was given a tip that my python `setuptools` might have been deleted (see [here]( https://stackoverflow.com/questions/7446187/no-module-named-pkg-resources)). So, I ran:\r\n\r\n`curl https://bootstrap.pypa.io/ez_setup.py | python`\r\n\r\nbut that failed with permission issues to `/Library/Python`. I ran again with `sudo` but that still failed.\r\n\r\nAfter digging around the docs more, I installed `wget` with brew, which in turn notified my that my python was out of date (a bit weird). So I ran:\r\n\r\n`brew upgrade python`\r\n\r\nAnd from there, everything started working.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mzaatar",
"comment_id": 371015940,
"datetime": 1520395507000,
"masked_author": "username_5",
"text": "What worked for me was going to this folder `/usr/local/Cellar/python/3.6.4_3/Frameworks/Python.framework/Versions/3.6/lib`\r\nand creating and empty folder called \"pkg_resources\" and then run \r\n`az --version `\r\nAfter that all good, I started installing the azure-iot-developer-kit which was my main goal. Thanks for the tips on this page!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "derekbekoe",
"comment_id": 371023760,
"datetime": 1520399023000,
"masked_author": "username_1",
"text": "You could also try`brew doctor` and see if that provides any hints.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "seattlevine",
"comment_id": 373810173,
"datetime": 1521226123000,
"masked_author": "username_6",
"text": "I ran\r\n`brew reinstall python3`\r\nto fix this",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "codymullins",
"comment_id": 399696566,
"datetime": 1529776073000,
"masked_author": "username_7",
"text": "The fix by @username_3 worked after I followed the [instructions here](https://github.com/Homebrew/homebrew-core/issues/19286) by chingNotCHing.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "raywang",
"comment_id": 475140927,
"datetime": 1553155695000,
"masked_author": "username_8",
"text": "works for me +1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "at1012",
"comment_id": 535282132,
"datetime": 1569459288000,
"masked_author": "username_9",
"text": "Seeing this issue on macos: \r\n\r\n**$ az --version**\r\nazure-cli 2.0.72 *\r\n\r\ncommand-modules-nspkg 2.0.3\r\ncore 2.0.72 *\r\nnspkg 3.0.4\r\ntelemetry 1.0.3\r\n\r\nPython location '/usr/local/Cellar/azure-cli/2.0.72_1/libexec/bin/python'\r\nExtensions directory '/Users/****/.azure/cliextensions'\r\n\r\nPython (Darwin) 3.7.4 (default, Sep 7 2019, 18:27:02)\r\n[Clang 10.0.1 (clang-1001.0.46.4)]\r\n\r\nLegal docs and information: aka.ms/AzureCliLegal\r\nYou have **2 updates available**. Consider updating your CLI installation\r\n\r\n**$ brew update && brew upgrade azure-cli**\r\nAlready up-to-date.\r\n**Error: azure-cli 2.0.72_1 already installed**\r\n\r\nMacOS Version: Mojave 10.14.6\r\nShell Type: bash\r\nNot in a virtualenv",
"title": null,
"type": "comment"
}
] | 10 | 19 | 8,259 | false | false | 8,259 | true |
zalando/nakadi | zalando | 214,379,592 | 612 | {
"number": 612,
"repo": "nakadi",
"user_login": "zalando"
} | [
{
"action": "opened",
"author": "adyach",
"comment_id": null,
"datetime": 1489582362000,
"masked_author": "username_0",
"text": "",
"title": "aruha-600: reset subscription cursor",
"type": "issue"
},
{
"action": "created",
"author": "adyach",
"comment_id": 293240580,
"datetime": 1491912696000,
"masked_author": "username_0",
"text": "@username_1 fixed majority of the points in dd594d6, please, have another look",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "antban",
"comment_id": 295271401,
"datetime": 1492608734000,
"masked_author": "username_1",
"text": ":+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "antban",
"comment_id": 296570972,
"datetime": 1493021813000,
"masked_author": "username_1",
"text": ":+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "adyach",
"comment_id": 296573409,
"datetime": 1493022256000,
"masked_author": "username_0",
"text": "👍",
"title": null,
"type": "comment"
}
] | 3 | 6 | 83 | false | true | 83 | true |
ionic-team/stencil | ionic-team | 298,127,949 | 552 | null | [
{
"action": "opened",
"author": "mlynch",
"comment_id": null,
"datetime": 1518995240000,
"masked_author": "username_0",
"text": "It seems that using a relative path of just `./` causes prerender to infinitely loop, printing out this in the process:\r\n\r\n<img width=\"677\" alt=\"screen shot 2018-02-18 at 5 06 29 pm\" src=\"https://user-images.githubusercontent.com/11214/36358102-17e43f02-14ce-11e8-9e43-ee78b40d3131.png\">\r\n\r\nThis was triggered probably by this URL: `<a href=\"./#getting-started\">`",
"title": "Infinite loop in pre-render",
"type": "issue"
},
{
"action": "closed",
"author": "adamdbradley",
"comment_id": null,
"datetime": 1519058964000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 363 | false | false | 363 | false |
255kb/stack-on-a-budget | null | 196,819,605 | 61 | null | [
{
"action": "opened",
"author": "clement-jacquet",
"comment_id": null,
"datetime": 1482281728000,
"masked_author": "username_0",
"text": "ex:\r\n# **Static app hosting**\r\n**_Host a one-page website or similar_**",
"title": "Add short description below service names",
"type": "issue"
},
{
"action": "created",
"author": "255kb",
"comment_id": 268631784,
"datetime": 1482352372000,
"masked_author": "username_1",
"text": "hi good idea, but below service names, or categories names ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "clement-jacquet",
"comment_id": 268673595,
"datetime": 1482363209000,
"masked_author": "username_0",
"text": "Categories names, my bad",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Panca68",
"comment_id": 269133482,
"datetime": 1482691819000,
"masked_author": "username_2",
"text": "pancaagusananda70@gmail.com",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "clement-jacquet",
"comment_id": 269354738,
"datetime": 1482858983000,
"masked_author": "username_0",
"text": "Unfortunately my english isn't good enough to do it... That's the main reason why I opened this issue!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "255kb",
"comment_id": null,
"datetime": 1579867607000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 6 | 284 | false | false | 284 | false |
CS2103AUG2017-T16-B1/main | CS2103AUG2017-T16-B1 | 268,987,154 | 132 | {
"number": 132,
"repo": "main",
"user_login": "CS2103AUG2017-T16-B1"
} | [
{
"action": "opened",
"author": "vicisapotato",
"comment_id": null,
"datetime": 1509079693000,
"masked_author": "username_0",
"text": "Changed color of PENDING status\r\nedited parcel card grid dimensions",
"title": "UI: small UI fix",
"type": "issue"
}
] | 2 | 2 | 370 | false | true | 67 | false |
mrdoob/three.js | null | 175,315,691 | 9,634 | {
"number": 9634,
"repo": "three.js",
"user_login": "mrdoob"
} | [
{
"action": "opened",
"author": "vakorol",
"comment_id": null,
"datetime": 1473186096000,
"masked_author": "username_0",
"text": "Update description of the object returned by `RayCaster.intersectObjects` when intersecting `Points`.",
"title": "Update docs for Raycaster.intersectObjects.",
"type": "issue"
},
{
"action": "created",
"author": "killroy42",
"comment_id": 246299267,
"datetime": 1473673566000,
"masked_author": "username_1",
"text": "Not sure if the issue is related, but Raycaster is behaving oddly for me at the moment. For example, it's returning 8 hits on a scene with 2 Plane Geometries and a GridHelper... And they don't seem to be correct.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mrdoob",
"comment_id": 246548672,
"datetime": 1473731016000,
"masked_author": "username_2",
"text": "@username_1 Please, create a new Issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mrdoob",
"comment_id": 246549147,
"datetime": 1473731197000,
"masked_author": "username_2",
"text": "#9654",
"title": null,
"type": "comment"
}
] | 3 | 4 | 356 | false | false | 356 | true |
InfomediaLtd/angular2-redux-example | InfomediaLtd | 128,594,912 | 2 | null | [
{
"action": "opened",
"author": "born2net",
"comment_id": null,
"datetime": 1453743252000,
"masked_author": "username_0",
"text": "I tried to include the code in my project and getting an error of\r\n\r\n```\r\ndispatching (dispatch) {\r\n\t dispatch(_this.requestUsers());\r\n\t _this._http.get(\"\" + BASE_URL)\r\n\t .map(function (result) { return result.json(); })\r\n\t .…\r\nbrowser_adapter.js:85 EXCEPTION: Error during instantiation of AdminComponent!\r\n\r\nORIGINAL EXCEPTION: Error: Actions must be plain objects. Use custom middleware for async actions.\r\n\r\nin AdminComponent\r\n```\r\n\r\n\r\nbasically that async calls must go through the middleware... have you seen this before?\r\n\r\nregards\r\n\r\nbasically",
"title": "Error on async call",
"type": "issue"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174597539,
"datetime": 1453743435000,
"masked_author": "username_1",
"text": "Interesting. I just tried getting a clean copy and it works well.\r\nCan you paste in the package.json and config.js files so we have exactly the same dependency versions?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174598592,
"datetime": 1453743661000,
"masked_author": "username_1",
"text": "Actually, even better, do you have the project public so I can take a look?\r\nMaybe you're not using thunks? Notice that all dispatches have to happen in a function that gets returned, which are \"thunks\" - they get the dispatch function as an argument and can dispatch other actions.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174599818,
"datetime": 1453743922000,
"masked_author": "username_0",
"text": "sure and thank you for checking, it's the Redux branch: https://github.com/username_0/ng2Boilerplate/tree/Redux",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174600107,
"datetime": 1453743980000,
"masked_author": "username_0",
"text": "and this is specifically for your code: https://github.com/username_0/ng2Boilerplate/tree/Redux/src/comps/app3",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174600392,
"datetime": 1453744042000,
"masked_author": "username_0",
"text": "I think I may found the issue tx to your comment, I believe my thunkMiddleware is missing",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174600759,
"datetime": 1453744125000,
"masked_author": "username_1",
"text": "No worries. Let me know if you're having trouble adding that in. Basically, you want to add it as a middleware.\r\n[https://github.com/gaearon/redux-thunk](https://github.com/gaearon/redux-thunk)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174601118,
"datetime": 1453744209000,
"masked_author": "username_0",
"text": "tx, I remembred why I took it out, becuase I has another issue with it, some off BrowserDomAdapter.logError from ng2... so I am checking again now, let me ask you if I may, what is the indow.devToolsExtension for?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174602460,
"datetime": 1453744477000,
"masked_author": "username_0",
"text": "ya same issue with that Thunk, error TS2304: Cannot find name 'BrowserDomAdapter'",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174602909,
"datetime": 1453744573000,
"masked_author": "username_1",
"text": "That's something really awesome that for me is one of the most significant benefits of redux - it gives you visibility of all actions happening. It's the redux devtools extension for Chrome: [https://github.com/zalmoxisus/redux-devtools-extension](https://github.com/zalmoxisus/redux-devtools-extension).\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174603370,
"datetime": 1453744674000,
"masked_author": "username_0",
"text": "he nice I ready about it... but I am using ng2, I think it's only for React... right? any idea on that error :/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174603544,
"datetime": 1453744714000,
"masked_author": "username_1",
"text": "Looking at it now. How do I reproduce it? Should I run the app from the main app.html or something deeper?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174603640,
"datetime": 1453744732000,
"masked_author": "username_1",
"text": "Nope. It's ng2 as well :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174603682,
"datetime": 1453744741000,
"masked_author": "username_0",
"text": "just saw it's for Redux... wow... installing :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174605487,
"datetime": 1453745127000,
"masked_author": "username_0",
"text": "here is the error I get in the console: \r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174606052,
"datetime": 1453745254000,
"masked_author": "username_1",
"text": "Looks like a problem with the import, maybe?\r\nI'm still waiting for \"npm install\" to finish... Quite a project :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174607258,
"datetime": 1453745531000,
"masked_author": "username_1",
"text": "NPM finished with an error (see below). Trying to run \"gulp LiveServer\" starts a browser on 8080 but it get a 404. 3001 shows that BrowserSync is running, but I'm not sure why 8080 doesn't serve the app. Ideas?\r\n\r\n\r\nRunning in build mode: true\r\n 10% 0/2 build modulests-loader: Using typescript@1.7.5 and /Users/username_1/Development/Workspace/\r\n3rd/ng2Boilerplate/tsconfig.json\r\n7737ms build modules\r\n26ms seal\r\n54ms optimize\r\n41ms hashing\r\n81ms create chunk assets\r\n\r\n22ms additional chunk assets\r\n2111ms optimize chunk assets\r\n1518ms optimize assets\r\nHash: 1ffbd575df64cc88f9ef\r\nVersion: webpack 1.12.12\r\nTime: 11619ms\r\n + 612 hidden modules\r\n\r\nERROR in Cannot find module 'less'\r\n @ ./~/style-loader!./~/css-loader!./~/less-loader!./~/bootstrap-webpack/bootstrap-styles.loader.\r\njs!./~/bootstrap-webpack/bootstrap.config.js 4:14-128\r\n\r\nERROR in Cannot find module 'less'\r\n @ ./~/style-loader!./~/css-loader!./~/less-loader!./~/font-awesome-webpack/font-awesome-styles.l\r\noader.js!./~/font-awesome-webpack/font-awesome.config.js 4:14-134",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174608227,
"datetime": 1453745744000,
"masked_author": "username_0",
"text": "ya I need to remove live-server as I no longer use it, I use the webpack server now, so you can ignore that and just run webpack-dev-server --nolazy --debug_mem --inline --progress --colors --display-error-details --display-cached --port=8080",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174609239,
"datetime": 1453745974000,
"masked_author": "username_1",
"text": "Looks a bit better, showing the progress thingy, but it just sits there. I only see two network requests - localhost (with a small HTML coming back) and loading.svg.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174609759,
"datetime": 1453746099000,
"masked_author": "username_1",
"text": "BTW, are you using the TypeScript compiler as a \"ts\" loader or Babel?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174609798,
"datetime": 1453746107000,
"masked_author": "username_0",
"text": "ts",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174610188,
"datetime": 1453746202000,
"masked_author": "username_0",
"text": "I have a feeling something is wrong with my const createStoreWithMiddleware = compose(applyMiddleware(thunkMiddleware, Lib.loggerMiddleware))(createStore);",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174610208,
"datetime": 1453746207000,
"masked_author": "username_1",
"text": "Any idea why it's not running?\r\n\r\nCan you try the following?\r\nimport * as thunkMiddleware from \"redux-thunk\"",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174610523,
"datetime": 1453746280000,
"masked_author": "username_1",
"text": "Well, the first thing I would have done (if I managed to run it locally :) ) is do a \"console.log(\"thunkMiddleware\",thunkMiddleware);\" right after the Babel comment in starwars.ts. See if you're getting the function imported properly. I have a feeling it's not and the problem is the import statement.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174610918,
"datetime": 1453746372000,
"masked_author": "username_0",
"text": "checking...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174612351,
"datetime": 1453746687000,
"masked_author": "username_1",
"text": "If it does import something it may still be wrong, because it bring in something that has a default.\r\nTry printing it out and checking what it is.\r\n\r\nFor me, for example, when I use the * syntax above I need to use thunkMiddleware.default to get to the actual function",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174612982,
"datetime": 1453746777000,
"masked_author": "username_0",
"text": "ok great, gotta go to a 45 min meeting so will try right after, tx!!!!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174613604,
"datetime": 1453746905000,
"masked_author": "username_1",
"text": "No worries. Let me know if that doesn't work and I'll check that tomorrow.\r\nWould be good to get to a point I can run it locally so I can easily figure it out. Pretty sure it's the import and some collision with Babel/Webpack/something.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174671512,
"datetime": 1453757419000,
"masked_author": "username_0",
"text": "u d man, fixed it like u said with the import:\r\n\r\nimport * as thunk from 'redux-thunk';\r\n\r\nconst createStoreWithMiddleware = compose(applyMiddleware(<any> thunk, Lib.loggerMiddleware), typeof window === 'object' && typeof window.devToolsExtension !== 'undefined' ? window.devToolsExtension() : f => f)(createStore);\r\n\r\nand I LOOOOOOOOOOOVE the devTools ;)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 174757670,
"datetime": 1453771455000,
"masked_author": "username_0",
"text": "everything works great...\r\nquick q, will this leak memory as we call subscribe on every fetch?\r\n\r\n```\r\nfetchFilms() {\r\n return (dispatch) => {\r\n dispatch(this.requestFilms());\r\n\r\n this._http.get(`${BASE_URL}`)\r\n .map(result => result.json())\r\n .map(json => {\r\n dispatch(this.receiveFilms(json.results));\r\n dispatch(this.receiveNumberOfFilms(json.count));\r\n })\r\n .subscribe();\r\n };\r\n }\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 174839524,
"datetime": 1453786036000,
"masked_author": "username_1",
"text": "Glad to hear it all works well :)\r\n\r\nI don't think it should leak, because the object is only used within that function so once it ends (when the results come back from the server) it would be cleaned up. My understanding is that Rx subscriptions need to be cleaned up only if they are kept inside components or other containers.\r\n\r\nRelated question for you: Do you think we need to unsubscribe from the appStore in the components by doing that in the onDestroy lifecycle method? I wasn't sure if it's needed or not, given that we don't really keep a reference to the store and it should be destroyed as the component is cleaned up. Also, as much as I checked I couldn't find any leaks or misbehaviour so I didn't do that. Lastly, I really don't like the idea of keeping a reference and adding the onDestory boilerplate method, so I would love to not have to unsubscribe. Let me know if you find out this is required and I'll add it to the code.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 175098567,
"datetime": 1453825120000,
"masked_author": "username_0",
"text": "I reviewed the code and I think all is good... no need to unsub you are right...\r\nThe two things I would love to see (and will prob do in a bit) is add the Immutable.js and some Rxjs sure https://github.com/acdlite/redux-rx",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 175105058,
"datetime": 1453826155000,
"masked_author": "username_0",
"text": "One question I have is on your Films-Component for example, is it \"aware\" of redux as it uses dispatch etc... so doesn't that break \"encapsulation\" as the entire film component and it's children should not know anything about Redux? i.e.: should just be given the Redux data...?\r\n\r\ntx Sean",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 175111496,
"datetime": 1453827048000,
"masked_author": "username_1",
"text": "Redux-rx looks sweet! First time I see this extension for redux.\r\n\r\nIn regards to your question:\r\nThere's a clear dichotomy between the smart components and the dumb views. The views know nothing about state, redux or composition. They are just simple visual components that expose properties and events. Then smart container components are the ones that do know about the app store, subscribing to its state changes and dispatching actions (coming from action creators).\r\nI guess I could have exposed all the smartness to be done in the app container, but that wouldn't hold for any app that grows. So, it makes sense to create a set of smart components that know about redux. Ideally, the more dumb views you have the better, but at some point you have to have something to compose them in UI and tie them to the store, and that's what the smart container components do.\r\n\r\nDoes that make sense? Do you have other ideas about composition of components in this example?\r\n\r\nBTW, I'm contemplating about separating the Http code from the action creators to services. It's not a lot of code, so I'm not sure it's worth it, but it may clean up the action creators from knowing about Http and put all the service logic in a central place... Any thoughts about that?\r\n\r\nCheers,\r\nRuby",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 175112150,
"datetime": 1453827115000,
"masked_author": "username_1",
"text": "Is redux-rs for React only? It's got react in its dependencies...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 175114305,
"datetime": 1453827365000,
"masked_author": "username_0",
"text": "I don't think so because it was prompted from the Redux docs...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 175155314,
"datetime": 1453832357000,
"masked_author": "username_0",
"text": "Another note, as for example on\r\n```\r\nfetchFilm(index) {\r\n return (dispatch) => {\r\n debugger;\r\n dispatch(this.requestFilm());\r\n this._http.get(`${BASE_URL}${index + 1}/`)\r\n .map(result => result.json())\r\n .map(json => {\r\n dispatch(this.receiveFilm(json));\r\n })\r\n .subscribe();\r\n };\r\n }\r\n``` \r\n\r\nwe do actually call Subscribe on every single call. which could leak on a large app (lots of new daily movies for example...)\r\n\r\nmaybe this would be better:\r\n\r\n```\r\nfetchFilm(index) {\r\n return (dispatch) => {\r\n debugger;\r\n dispatch(this.requestFilm());\r\n var sub = this._http.get(`${BASE_URL}${index + 1}/`)\r\n .map(result => result.json())\r\n .map(json => {\r\n dispatch(this.receiveFilm(json));\r\n })\r\n .subscribe(e=>sub.unsubscribe());\r\n };\r\n }\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 175470056,
"datetime": 1453881330000,
"masked_author": "username_1",
"text": "I don't mind adding the unsubscribe, but I still wanted to check if there's a leak so here's what I did:\r\n\r\nI've updated the film action to create a 30MB variable for every time it gets called:\r\n```js\r\nfetchFilms() {\r\n return (dispatch) => {\r\n dispatch(this.requestFilms());\r\n\r\n let a = [];\r\n this._http.get(`${BASE_URL}`)\r\n .map(result => result.json())\r\n .map(json => {\r\n const t = JSON.stringify(json.results);\r\n for (var j=0; j<100; j++) {\r\n let big = \"\";\r\n for (var i=0; i<10000; i++) {\r\n big = big + t;\r\n }\r\n a.push(big);\r\n //console.log(j + \"\" + big.length);\r\n }\r\n dispatch(this.receiveFilms(json.results));\r\n dispatch(this.receiveNumberOfFilms(json.count));\r\n })\r\n .subscribe();\r\n };\r\n }\r\n```\r\n\r\nThen, updated the films component to retrieve films on an interval:\r\n```js\r\nconstructor(private _appStore:AppStore,\r\n private _filmActions:FilmActions) {\r\n\r\n _appStore.subscribe((state) => {\r\n this.filmsCount = state.films.count;\r\n this.currentFilm = state.films.currentFilm;\r\n this.isFetchingCurrentFilm = state.films.isFetchingFilm;\r\n });\r\n\r\n setInterval(() => {\r\n this.counter++;\r\n this._appStore.dispatch(this._filmActions.fetchFilms());\r\n },500);\r\n }\r\n```\r\n\r\nLooking at the Chrome memory tool I can see it allocating 30MB on every call, but then it drops, as expected:\r\n\r\n\r\nSo, I'm still not convinced there is a leak here. Any ideas on other tests we can perform to confirm it?\r\nAgain, not that I mind adding the \"unsubscribe\". It's probably cleaner anyway, but I would really like to understand what is the right way to do it and why do I need to worry about a leak.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rubyboy",
"comment_id": 175493640,
"datetime": 1453885128000,
"masked_author": "username_1",
"text": "I had another idea and look at the Http service source. Here's the important line from the(Http xhr backend)[https://github.com/angular/angular/blob/master/modules/angular2/src/http/backends/xhr_backend.ts#L61]: \r\n\r\n\r\nNotice how it runs the \"complete\" after getting the result. This means it actually unsubscribes on completion. So you don't need to do it yourself.\r\n\r\nTo confirm that, here's my new code for the fetchFilms method:\r\n```js\r\nfetchFilms() {\r\n return (dispatch) => {\r\n dispatch(this.requestFilms());\r\n\r\n let observer = this._http.get(`${BASE_URL}`)\r\n .map(result => result.json())\r\n .map(json => {\r\n dispatch(this.receiveFilms(json.results));\r\n dispatch(this.receiveNumberOfFilms(json.count));\r\n console.log(\"2 isUnsubscribed\",observer.isUnsubscribed);\r\n window.setTimeout(() => {\r\n console.log(\"3 isUnsubscribed\",observer.isUnsubscribed);\r\n },10);\r\n })\r\n .subscribe();\r\n console.log(\"1 isUnsubscribed\",observer.isUnsubscribed);\r\n };\r\n }\r\n```\r\n\r\nAs expected, you can see that it is always unsubscribed automatically after getting the result and finishing with the observable operators. This happens on a timeout (#3) so we can check the status of the observable when it's all done and completed.\r\n\r\n\r\nI think this concludes that there is no need to unsubscribe from the Http service :)\r\nAgree?\r\n\r\nCheers,\r\nRuby",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "born2net",
"comment_id": 175721914,
"datetime": 1453911821000,
"masked_author": "username_0",
"text": "I see, PERFECT, tx for the effort...",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "born2net",
"comment_id": null,
"datetime": 1453911821000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 41 | 14,142 | false | false | 14,142 | true |
Dyalog/ride | Dyalog | 330,244,525 | 434 | null | [
{
"action": "opened",
"author": "DyalogRichard",
"comment_id": null,
"datetime": 1528373492000,
"masked_author": "username_0",
"text": "### Describe the issue you are having\r\n<!-- Ride Issue -->\r\nEdit windows have no menu bar.\r\n\r\nAt the very least there could be:\r\n\r\nFile\r\n...Fix\r\n...Exit (and Fix)\r\n...Exit (and discard changes)\r\n\r\nEdit\r\n... Undo\r\n... Redo\r\n... Cut\r\n... Copy\r\n... Paste\r\n\r\n### Did you connect to an already running interpreter or start the interpreter from RIDE?\r\n<!-- Connect to already running/Start an interpreter -->\r\nConnect\r\n\r\n### How do you reproduce the issue?\r\n<!-- instructions to reproduce -->\r\nOpen an edit window\r\n\r\n### Paste the contents of Help → About (Shift+F1)\r\nIDE:\r\n Version: 4.1.3330\r\n Platform: Linux x86_64\r\n Date: 2018-06-04 16:50:49 +0100\r\n Git commit: 5407e4cc5de2c0e20a103e1acbbe965223f7b2b1\r\n Preferences:{\r\n \"autoCloseBrackets\":\"0\",\r\n \"dbg\":\"1\",\r\n \"floatOnTop\":\"1\",\r\n \"floating\":\"1\",\r\n \"kbdLocale\":\"en_GB\",\r\n \"lbarOrder\":\"← +-×÷*⍟⌹○!? |⌈⌊⊥⊤⊣⊢ =≠≤<>≥≡≢ ∨∧⍲⍱ ↑↓⊂⊃⊆⌷⍋⍒ ⍳⍸∊⍷∪∩~ /\\\\⌿⍀ ,⍪⍴⌽⊖⍉ ¨⍨⍣.∘⍤@ ⍞⎕⍠⌸⌺⌶⍎⍕ ⋄⍝→⍵⍺∇& ¯⍬ \",\r\n \"wrap\":\"1\",\r\n \"wse\":\"1\"\r\n }\r\n\r\nInterpreter:\r\n Version: 18.0.33338\r\n Platform: Linux-64\r\n Edition: Unicode/64\r\n Date: Jun 6 2018 at 16:21:25",
"title": "Edit windows have no menu bar",
"type": "issue"
}
] | 1 | 1 | 1,105 | false | false | 1,105 | false |
miztroh/wysiwyg-e | null | 291,237,747 | 208 | null | [
{
"action": "opened",
"author": "Icer2000",
"comment_id": null,
"datetime": 1516805712000,
"masked_author": "username_0",
"text": "If you use the wysiwyg editor in a Polymer 2 App inside of Shadowdom, the Toolbar Buttons never get enabled.\r\n\r\nThe Problem seems to be, that getSelection is undefined in Safari 11.03.",
"title": "getSelection() in safari is broken",
"type": "issue"
},
{
"action": "created",
"author": "miztroh",
"comment_id": 360192454,
"datetime": 1516811561000,
"masked_author": "username_1",
"text": "Yeah, there's a Safari bug filed for this. There's not really anything I can do to work around this. It's a critical feature of Shadow DOM and Safari doesn't support it yet.\r\n\r\nhttps://developer.mozilla.org/en-US/docs/Web/API/DocumentOrShadowRoot/getSelection\r\nhttps://bugs.webkit.org/show_bug.cgi?id=163921",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "miztroh",
"comment_id": null,
"datetime": 1516811561000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 494 | false | false | 494 | false |
platformio/platformio-atom-ide | platformio | 243,254,566 | 735 | null | [
{
"action": "opened",
"author": "dparker2112",
"comment_id": null,
"datetime": 1500227147000,
"masked_author": "username_0",
"text": "Error: Detected unknown package '/Users/davidparker/.platformio/packages/tool-avrdude @ ~1.60300.0'",
"title": "C/C++ project index rebuild failed",
"type": "issue"
},
{
"action": "created",
"author": "ivankravets",
"comment_id": 320314866,
"datetime": 1501869676000,
"masked_author": "username_1",
"text": "Please try again. COnnection issue.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ivankravets",
"comment_id": null,
"datetime": 1501869676000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 134 | false | false | 134 | false |
HaxeFoundation/haxe | HaxeFoundation | 17,909,036 | 2,065 | null | [
{
"action": "opened",
"author": "waneck",
"comment_id": null,
"datetime": 1376203548000,
"masked_author": "username_0",
"text": "Support native metadata declaration on Java and C#. This will need a way to typecheck them.\r\nI can make it work using macros and special interfaces, but wouldn't it be a good time to add checked metadatas for Haxe as well?\r\n\r\n(cc @ncannasse and @Simn )",
"title": "Java/C# : native annotations",
"type": "issue"
},
{
"action": "created",
"author": "commel",
"comment_id": 68532596,
"datetime": 1420211233000,
"masked_author": "username_1",
"text": "Especially needful for Hibernate or Servlet/Spring MVC-targets. Please implement this! :-)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "waneck",
"comment_id": null,
"datetime": 1425373798000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "commel",
"comment_id": 76913813,
"datetime": 1425375273000,
"masked_author": "username_1",
"text": ":+1:",
"title": null,
"type": "comment"
}
] | 2 | 4 | 346 | false | false | 346 | false |
Quintus/ruby-xz | null | 118,446,758 | 14 | null | [
{
"action": "opened",
"author": "Quintus",
"comment_id": null,
"datetime": 1448304819000,
"masked_author": "username_0",
"text": "To be of any use, the flags regarding archive checksums should actually make the archive’s validity accessible somehow rather than just printing a warning about an invalid checksum. Should probably cause an exception as an invalid archive can’t be read anyway.\r\n\r\nAPI breaking, so for 1.0.0.\r\n\r\nValete,\r\nusername_0",
"title": "Add methods accessing archive checksum",
"type": "issue"
}
] | 1 | 1 | 311 | false | false | 311 | true |
vmware/vsphere-flocker-driver | vmware | 146,021,387 | 25 | null | [
{
"action": "opened",
"author": "catdrich",
"comment_id": null,
"datetime": 1459869425000,
"masked_author": "username_0",
"text": "I have reinstalled all the servers using the documentation learned from issue #18, including using the correct pyVmomi version. \r\n\r\nThere are still some minor (hopefully) issues. When I first create a volume, for example:\r\nflockerctl --control-service xxxxxxx create --node xxxxxxx --size 10Gb --metadata \"name=postgres, size=small\r\nThe status seems to go from detached to pending, but then it stays in \"pending\" until I restart the flocker-dataset-agent service. I have set this sit all day without it attaching until I finally restarted the service.\r\n\r\nWhen I try to move the volume to another server in the group (once it's been successfully attached), it seems to be sporadic - some times it moves and attaches in a relatively short amount of time. Other times I have to restart the service. I can't find any pattern to this, but more often than not I have to restart the flocker-dataset-agent service.\r\n\r\nFYI, I am using swarm with flocker as a test (https://docs.clusterhq.com/en/latest/docker-integration/tutorial-swarm-compose.html) and then adapted it to test it with one of our applications, and it works (except for this bug with attaching the volumes that occurs).\r\n\r\nI move it by first stopping the present one and then doing a rm -f (as in the swarm tutorial linked in the previous paragraph). I then change the node designation in the environment in the docker-compose.yml for example, When I docker-compose up for the new node, it first shows as attached to the new node, then detached and I get an error that it is taking too long. After I try a third or fourth time, sometimes the volume attaches without me having to restart the dataset agent. \r\n\r\nAny ideas, suggestions? Eventually we might like to use the docker/flocker/swarm combination in production, but I think there are still a few kinks to work out. There will probably be several updates released until we are close to using this in production.",
"title": "Some slight issues related to issue #18 and volumes not attaching correctly",
"type": "issue"
},
{
"action": "created",
"author": "aliouba",
"comment_id": 215483708,
"datetime": 1461860592000,
"masked_author": "username_1",
"text": "+1",
"title": null,
"type": "comment"
}
] | 2 | 2 | 1,936 | false | false | 1,936 | false |
expo/expo | expo | 260,300,487 | 676 | null | [
{
"action": "opened",
"author": "tofoli",
"comment_id": null,
"datetime": 1506350238000,
"masked_author": "username_0",
"text": "I'm not using AdMob, but when I send my App to Apple I've identified the use of the ASIdentifierManager class, and asked to tell what kind of announcements it existed in my App. The strangest thing of all is that I'm using Expo version 20.0.0 , and in the past compilations such information was not required.\r\n\r\nSome help?",
"title": "No AdMob Apple has identified use of ASIdentifierManager in Expo 20.0.0",
"type": "issue"
},
{
"action": "created",
"author": "tofoli",
"comment_id": 331931003,
"datetime": 1506355739000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "terribleben",
"comment_id": 331932136,
"datetime": 1506355951000,
"masked_author": "username_1",
"text": "Hi, are you sure this is related to AdMob? Multiple Expo APIs use the IDFA, and that has not changed recently. Did you follow [these steps](https://docs.expo.io/versions/latest/guides/building-standalone-apps.html#6-submit-it-to-the-appropriate-store) (including the note about the IDFA) when submitting your app?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tofoli",
"comment_id": null,
"datetime": 1506356457000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "tofoli",
"comment_id": 331935273,
"datetime": 1506356576000,
"masked_author": "username_0",
"text": "Now I realized that I did not follow these steps, this misunderstanding occurred because the first time I sent the app to apple was not requested, only the second time.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "terribleben",
"comment_id": 331938252,
"datetime": 1506357221000,
"masked_author": "username_1",
"text": "Sorry about the trouble. Good luck with your project. :)",
"title": null,
"type": "comment"
}
] | 2 | 6 | 968 | false | false | 968 | false |
golang/dep | golang | 241,418,254 | 802 | null | [
{
"action": "opened",
"author": "Groxx",
"comment_id": null,
"datetime": 1499480471000,
"masked_author": "username_0",
"text": "<!--\r\n\r\nThanks for filing an issue! If this is a question or feature request, just delete\r\neverthing here and write out the request, providing as much context as you can.\r\n\r\n-->\r\n\r\n### What version of Go (`go version`) and `dep` (`git describe --tags`) are you using?\r\n```\r\n$ go version\r\ngo version go1.8.3 darwin/amd64\r\n$ cd $GOPATH/src/github.com/golang/dep && git describe --tags\r\nv0.1.0-202-gddf5680\r\n```\r\n### What `dep` command did you run?\r\n`dep init` (and `dep init -skip-tools`)\r\n(with some scrubbing due to internal paths. \"internal-A\" and \"internal-B\" are not .git suffixed and this happens both with and without \"vcs: git\" in glide.yaml)\r\n```\r\n$ dep init -v\r\nImporting configuration from glide. These are only initial constraints, and are further refined during the solve process.\r\nDetected glide configuration files...\r\n Loading /my/project/glide.yaml\r\n Loading /my/project/glide.lock\r\nConverting from glide.yaml and glide.lock...\r\n Using X as initial constraint for imported dep internal-X\r\n Using Y as initial constraint for imported dep internal-Y.git\r\n Using Z as initial constraint for imported dep internal-Z.git\r\n Using ^1.0.0 as initial constraint for imported dep github.com/eapache/go-resiliency\r\n Using master as initial constraint for imported dep github.com/juju/ratelimit\r\n Using master as initial constraint for imported dep github.com/jmcvetta/randutil\r\n Using master as initial constraint for imported dep golang.org/x/tools\r\n Using v1.1.4 as initial constraint for imported dep github.com/stretchr/testify\r\n Using master as initial constraint for imported dep github.com/vektra/mockery\r\n Using master as initial constraint for imported dep github.com/jmcvetta/randutil\r\nlist versions for internal-A(): unable to deduce repository and source type for \"internal-A\": unable to read metadata: unable to fetch raw metadata: failed HTTP request to URL \"http://internal-A?go-get=1\": Get http://internal-A?go-get=1: dial tcp 1.2.3.4:80: i/o timeout\r\n```\r\n```\r\n$ dep init -skip-tools -v\r\npanic: shouldn't be possible unable to deduce repository and source type for \"internal-B\": unable to read metadata: unable to fetch raw metadata: failed HTTP request to URL \"http://internal-B?go-get=1\": Get http://internal-B?go-get=1: dial tcp 1.2.3.4:80: i/o timeout\r\n\r\ngoroutine 1 [running]:\r\ngithub.com/golang/dep/internal/gps.(*solver).selectRoot(0xc420174000, 0xc42025c180, 0xc42025c1b0)\r\n\t/Users/stevenl/gopath/src/github.com/golang/dep/internal/gps/solver.go:549 +0xada\r\ngithub.com/golang/dep/internal/gps.(*solver).Solve(0xc420174000, 0x4a, 0x16bd340, 0xc42025c000, 0xc4200180be)\r\n\t/Users/stevenl/gopath/src/github.com/golang/dep/internal/gps/solver.go:394 +0x8d\r\nmain.(*initCommand).Run(0xc420159a3a, 0xc420019950, 0xc420010330, 0x0, 0x0, 0x0, 0x0)\r\n\t/Users/stevenl/gopath/src/github.com/golang/dep/cmd/dep/init.go:171 +0x6f6\r\nmain.(*Config).Run(0xc420072fc0, 0xc420072fc0)\r\n\t/Users/stevenl/gopath/src/github.com/golang/dep/cmd/dep/main.go:158 +0x876\r\nmain.main()\r\n\t/Users/stevenl/gopath/src/github.com/golang/dep/cmd/dep/main.go:45 +0x253\r\n```\r\n\r\nAnd the two failing packages are defined in glide.yaml as:\r\n```\r\n- package: internal-A\r\n version: ^0.1\r\n vcs: git # tried with and without this, no differences\r\n- package: internal-B\r\n version: ^0.1\r\n```\r\nwhich is interesting because some other internal packages seem to work, even though they're hosted in the same place and they also time out if I try to just visit `http://the/repo?go-get=1` in a browser... I've also tried removing the `^`, no change.\r\n\r\nThe only real difference I can see for the working internal packages (without checking for additional hosting locations, etc) is that the working ones do not have a normal/valid semver version. They're just a named tag and e.g. `1.2.3-beta4`\r\n\r\n---\r\n\r\nAs nice as an auto-init process is, it's having problems looking up stuff in our internal repos, which is of course happening before I would have any chance to tell it where to look instead.\r\nA way to ignore failures would be great, or even just a way to skip the import/parse entirely, without having to `dep init` in another folder somewhere.",
"title": "`dep init` fails when looking up a repository times out",
"type": "issue"
},
{
"action": "created",
"author": "Groxx",
"comment_id": 313829451,
"datetime": 1499483033000,
"masked_author": "username_0",
"text": "Ah, I guess this belongs behind some kind of private-repo support like #174 . I'll close it, and revisit after that's a bit more supported :)\r\nAnd thanks zevdg! go-vanity might be a workaround in the meantime, I hadn't heard of it.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Groxx",
"comment_id": null,
"datetime": 1499483033000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 4,374 | false | false | 4,374 | false |
svanderburg/node2nix | null | 204,521,039 | 37 | null | [
{
"action": "opened",
"author": "the-spyke",
"comment_id": null,
"datetime": 1485937007000,
"masked_author": "username_0",
"text": "My build machine started to fail, when I've updated node2nix to v1.1.1 from v1.1.0 with other packages.\r\n`anonymous function at \u001b[.../node-env.nix\u001b[ called without required argument 'python2', at...` \r\nSuch changes shouldn't be in patch version by SemVer.",
"title": "\"Use nodejs's version of Python\" broke build",
"type": "issue"
},
{
"action": "created",
"author": "svanderburg",
"comment_id": 322723868,
"datetime": 1502877639000,
"masked_author": "username_1",
"text": "This is because node2nix never overwrites node-env.nix on regeneration. It may have been possible that an old node-env.nix tries to build a newer package set with incompatibilities.\r\n\r\nIn the current version of node2nix this has been solved.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "svanderburg",
"comment_id": null,
"datetime": 1502877639000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 496 | false | false | 496 | false |
spring-projects/spring-data-commons | spring-projects | 313,856,078 | 285 | {
"number": 285,
"repo": "spring-data-commons",
"user_login": "spring-projects"
} | [
{
"action": "opened",
"author": "ChengyuanZhao",
"comment_id": null,
"datetime": 1523561084000,
"masked_author": "username_0",
"text": "<!--\r\n\r\nThank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.\r\nMake sure that:\r\n\r\n-->\r\n\r\n- [ ] You have read the [Spring Data contribution guidelines](https://github.com/spring-projects/spring-data-build/blob/master/CONTRIBUTING.adoc).\r\n- [ ] There is a ticket in the bug tracker for the project in our [JIRA](https://jira.spring.io/browse/DATACMNS).\r\n- [ ] You use the code formatters provided [here](https://github.com/spring-projects/spring-data-build/tree/master/etc/ide) and have them applied to your changes. Don’t submit any formatting related changes.\r\n- [ ] You submit test cases (unit or integration tests) that back your changes.\r\n- [ ] You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).",
"title": "type param T nees to be declared in example",
"type": "issue"
},
{
"action": "created",
"author": "ChengyuanZhao",
"comment_id": 380917637,
"datetime": 1523561150000,
"masked_author": "username_0",
"text": "@username_1 I think this example is missing the type param declaration",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mp911de",
"comment_id": 381052097,
"datetime": 1523605290000,
"masked_author": "username_1",
"text": "Thanks a lot. That's merged and backported now.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,061 | false | false | 1,061 | true |
PyCon/pycon | PyCon | 146,138,392 | 596 | null | [
{
"action": "opened",
"author": "felixc",
"comment_id": null,
"datetime": 1459899309000,
"masked_author": "username_0",
"text": "The program export feature currently does not fully populate plenary (e.g. welcome, keynote, etc.) sessions. They show up as just\r\n\r\n```csv\r\nName,Speakers,Room,Day,Start,End,Audience Level,Category,Url,Abstract\r\nplenary,,\"Session A, Session B, Session C, Session D, Session E\",2016-05-30,09:00:00,09:30:00,,,,\r\n```\r\n\r\nin the `/talks_schedule.csv` file.\r\n\r\nThis appears to be because in the underlying data they are not real \"talks\" — rather they are entries under Symposion_Schedule > Slots, where they then have a \"Content Override\" that describes their purpose (e.g. the one above is \"Welcome to PyCon\").\r\n\r\nSince the program export data is used to populate the mobile app, it would be great if these sessions could be fully populated in the exported data, whether as regular talks, or in their own separate file (no preference). My proposal would be that all \"slots\" of type \"plenary\" should be exported.\r\n\r\nThis is not critical for this year, as I can just populate the mobile app manually if necessary, but it would be nice to get as much as possible automated for future years.",
"title": "Plenary session data is incomplete in program export",
"type": "issue"
},
{
"action": "created",
"author": "brandon-rhodes",
"comment_id": 208104364,
"datetime": 1460336202000,
"masked_author": "username_1",
"text": "The fact that plenaries are not real talk entries dates back to at least 2015:\r\n\r\nhttps://us.pycon.org/2015/schedule/\r\n\r\nGiven that I think the graphic design depends on these being special events to receive the right color, I am going to take you up on your offer to do keynotes by hand this year. I will mark this issue as deserving attention for next year!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 1,442 | false | false | 1,442 | false |
okonet/lint-staged | null | 338,382,504 | 468 | null | [
{
"action": "opened",
"author": "tommedema",
"comment_id": null,
"datetime": 1530742122000,
"masked_author": "username_0",
"text": "I'm trying to rebuild my typescript project on each commit, after prettifying the code with `prettier`:\r\n\r\n```\r\n\"lint-staged\": {\r\n \"*.ts\": [\r\n \"prettier --parser typescript --write --no-semi\",\r\n \"tsc\",\r\n \"git add\"\r\n ]\r\n },\r\n```\r\n\r\nProblem is that the `tsc` command here seems to fail to see my `.tsconfig.json` file, probably because the working directory of `lint-staged` is set to the directory of the file that is committed.\r\n\r\nIs there a way to make this work? If I wanted to use something like `tsc --rootDir ../..` to \"fix\" the working directory how would I know the level of depth to go up in the directory tree for the currently staged file?",
"title": "Build typescript on commit",
"type": "issue"
},
{
"action": "closed",
"author": "sudo-suhas",
"comment_id": null,
"datetime": 1530774230000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "sudo-suhas",
"comment_id": 402625304,
"datetime": 1530774230000,
"masked_author": "username_1",
"text": "Why would you want to use `lint-staged` for that? Just use husky pre-commit hook to run what ever command you need. It could be done using `lint-staged && tsc-build-cmd`. Note that `tsc-build-cmd` is not a valid command and needs to be substituted with the one which will build your project.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tommedema",
"comment_id": 402722665,
"datetime": 1530797504000,
"masked_author": "username_0",
"text": "@username_1 the reason would be that I only want to `git add` if compilation succeeded. `tsc` has many compilation checks and if it fails I wouldn't want it to `git add`. Also, I wouldn't want to compile before my linters have run.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sudo-suhas",
"comment_id": 402724262,
"datetime": 1530797823000,
"masked_author": "username_1",
"text": "Use the pre commit hook as I mentioned above. That will do what you need.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tommedema",
"comment_id": 402724971,
"datetime": 1530797971000,
"masked_author": "username_0",
"text": "@username_1 it would run `git add` even if compilation fails; no?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sudo-suhas",
"comment_id": 402726321,
"datetime": 1530798246000,
"masked_author": "username_1",
"text": "`git add` doesn't make any difference. You ran it before running`lint-staged` anyway so effectively the files which were staged stay the same. What happens is that your pre-commit hook errors out during compilation and no commit is created. After that, it is upto you to modify required files, stage and commit them.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sibelius",
"comment_id": 418827220,
"datetime": 1536170952000,
"masked_author": "username_2",
"text": "anyway to typecheck on lint-staged?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "okonet",
"comment_id": 427875415,
"datetime": 1539011984000,
"masked_author": "username_3",
"text": "@username_2 I don't think TS supports that yet. Here is an example of how to do the check https://github.com/kubeapps/kubeapps/pull/700/files but it's not on staged files.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mgtitimoli",
"comment_id": 541384443,
"datetime": 1570939967000,
"masked_author": "username_4",
"text": "You can run `tsc` passing your `tsconfig.json` following these steps:\r\n\r\n1. Install [eslint-plugin-tsc](https://www.npmjs.com/package/eslint-plugin-tsc)\r\n2. Do not add `eslint-plugin-tsc` to your `eslint` config file but instead pass the plugin to `eslint` in the `lint-staged` command as follows\r\n```\r\n{\r\n \"*.ts\": [\r\n \"eslint --fix --plugin tsc --rule 'tsc/config: [2, {configFile: \"./tsconfig.json\"}]'\",\r\n \"git add\"\r\n ]\r\n}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "maoxiaoke",
"comment_id": 554338942,
"datetime": 1573820402000,
"masked_author": "username_5",
"text": "If you are using [husky](https://github.com/typicode/husky#readme), then you can do this:\r\n\r\n```json\r\n// package.json\r\n \"husky\": {\r\n \"hooks\": {\r\n \"pre-commit\": \"tsc --noEmit && lint-staged\"\r\n }\r\n }\r\n```\r\n\r\nBut it will check all .ts files of your project according to `tsconfig.json` instead of those staged files. May it help!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "khose",
"comment_id": 562693703,
"datetime": 1575658335000,
"masked_author": "username_6",
"text": "@username_5 `tsc --noEmit` won't do anything if you don't specify a file or the project setup file. Isn't it? When I try your solution, tsc does nothing.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "maoxiaoke",
"comment_id": 563641467,
"datetime": 1575946384000,
"masked_author": "username_5",
"text": "@username_6 Do you have `typescript` as a peer dependency and a `tsconfig.js` file in the project root?\r\n\r\nIn your `package.json`.\r\n\r\n```json\r\n...\r\n\"devDependencies\": {\r\n \"typescript\": \"^3.6.4\"\r\n}\r\n...\r\n```\r\n\r\nIn your `tsconfig.json`, you may specify which files you want to compile.\r\n\r\n```js\r\n{\r\n...\r\n \"include\": [\r\n \"src/**/*.ts\",\r\n \"src/**/*.tsx\"\r\n ],\r\n \"exclude\": [\r\n \"node_modules\",\r\n \"config\"\r\n ]\r\n}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "khose",
"comment_id": 563990752,
"datetime": 1575977201000,
"masked_author": "username_6",
"text": "Hum, I don't have `tsconfig.js` in the root folder. The rest seems to be in place. Let me check and come back to you. Thanks @username_5 !",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "szhu",
"comment_id": 605102567,
"datetime": 1585327388000,
"masked_author": "username_7",
"text": "hi, I know this is an already closed issue, but I still ran into it. I was able to fix it though!\r\n\r\nI think the issue has nothing to do with tsconfig or the working directory. The issue is that `lint-staged ` is appending the names of the changed files to the command. So if you're telling it to run `tsc`, it's actually running `tsc changedfile1.ts changedfile2.ts`. That's why it's ignoring your tsconfig, because passing extra files to it explicitly overrides that.\r\n\r\nI fixed this issue with the following config:\r\n\r\n```diff\r\n \"lint-staged\": {\r\n \"*.ts\": [\r\n \"prettier --parser typescript --write --no-semi\",\r\n- \"tsc\",\r\n+ \"bash -c tsc\",\r\n \"git add\"\r\n ]\r\n },\r\n```\r\n\r\n`bash` doesn't automatically pass its args down to child commands -- `bash -c tsc` effectively runs `tsc` but ignores all args.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "iiroj",
"comment_id": 605113810,
"datetime": 1585328458000,
"masked_author": "username_8",
"text": "@username_7 you could try using a js function config, so that you can skip passing the arguments to `tsc`.\r\n\r\nhttps://github.com/username_3/lint-staged/blob/master/README.md#example-run-tsc-on-changes-to-typescript-files-but-do-not-pass-any-filename-arguments",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "szhu",
"comment_id": 605114667,
"datetime": 1585328557000,
"masked_author": "username_7",
"text": "Oh wow didn't see that, thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "iiroj",
"comment_id": 605115545,
"datetime": 1585328650000,
"masked_author": "username_8",
"text": "Np, you’ll of course need to pass the first argument (array of filenames) to the other commands! You can see that in the other examples.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "uriklar",
"comment_id": 605975084,
"datetime": 1585572061000,
"masked_author": "username_9",
"text": "Anyone have a solution for running tsc type checking only on staged files and not on entire project? I looked through the thread but don't see any solution for this case.\r\nThanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "okonet",
"comment_id": 606022523,
"datetime": 1585577386000,
"masked_author": "username_3",
"text": "That's not possible since TS needs to build the whole project in order to do type checking. This is the limitation of TypeScript. You should not probably do this in the pre-commit hook.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mgtitimoli",
"comment_id": 606311249,
"datetime": 1585612124000,
"masked_author": "username_4",
"text": "@username_9 you can run `tsc` as an eslint plugin (run one tool instead of many), using the mechanism I described [here](https://github.com/username_3/lint-staged/issues/468#issuecomment-541384443)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "iamdevlinph",
"comment_id": 636878548,
"datetime": 1591020193000,
"masked_author": "username_10",
"text": "Wouldn't it be possible to have lint-staged call a function the user will provide (tsc in this case) during/after the `Running tasks...` section? With this we can make sure tsc only runs on the staged changes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tafelito",
"comment_id": 726151843,
"datetime": 1605195127000,
"masked_author": "username_11",
"text": "would it be posible to run a lint-staged cmd on pre-commit, like prettier but then do a type check before pushing. In my case I don't care about type checking before committing. Sometimes you can do WIP commits and you don't need to to run `tsc` there, but I do want to run it before pushing it to the repo. \r\nI know there is a `pre-push` hook in husky but how can you run different lint-staged commands?",
"title": null,
"type": "comment"
}
] | 12 | 23 | 5,753 | false | false | 5,753 | true |
relay-tools/react-router-relay | relay-tools | 151,489,776 | 146 | null | [
{
"action": "opened",
"author": "taion",
"comment_id": null,
"datetime": 1461790770000,
"masked_author": "username_0",
"text": "For example, I may want to check some data in an `onEnter` hook. Right now, this is only easily possible if I'm using `Relay.Store`.",
"title": "Make Relay environment available in router hooks",
"type": "issue"
},
{
"action": "created",
"author": "taion",
"comment_id": 215904637,
"datetime": 1461971500000,
"masked_author": "username_0",
"text": "Requires https://github.com/reactjs/react-router/issues/3404.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "idris",
"comment_id": 222264061,
"datetime": 1464387007000,
"masked_author": "username_1",
"text": "I have a problem where I want to return a not found (404) if something in my relay data is null. Would this issue resolve that?\r\n\r\nAlso, you said it's possible if using Relay.Store? How?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "taion",
"comment_id": 222275707,
"datetime": 1464392673000,
"masked_author": "username_0",
"text": "Just use the `Relay.Store` singleton in your `onEnter` hook. This issue is to track providing the non-singleton `Relay.Environment` that you pass into the router.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "taion",
"comment_id": 236067932,
"datetime": 1469753972000,
"masked_author": "username_0",
"text": "I'm going to close this issue because there's nothing to track here. This will fall out naturally once we resolve https://github.com/reactjs/react-router/issues/3404... and I'm not going to forget to work on this once https://github.com/reactjs/react-router/issues/3404 gets resolved, given that this is the motivation for that issue.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "taion",
"comment_id": null,
"datetime": 1469753975000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 877 | false | false | 877 | false |
Axinom/x2js | Axinom | 193,134,552 | 54 | null | [
{
"action": "opened",
"author": "Jacks50",
"comment_id": null,
"datetime": 1480690395000,
"masked_author": "username_0",
"text": "I'm installing x2js with the npm command \"npm install x2js\", but I don't know why the contents are different. Even when installing using the url instead of the module name, I don't have (for example) the same package.json, nor the type definition interface. Is there a reason for it ?",
"title": "Installing x2js with npm",
"type": "issue"
},
{
"action": "created",
"author": "sandersaares",
"comment_id": 264786314,
"datetime": 1480923587000,
"masked_author": "username_1",
"text": "It may be that you are looking in the development branch of the codebase, which may contain changes that are not yet published to npm. Can you confirm whether the state you see when installing via npm matches the state of the master branch in GitHub?\r\n\r\nYou can expect the latest changes currently in the development branch to be pushed to npm in December.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Jacks50",
"comment_id": 264787860,
"datetime": 1480924229000,
"masked_author": "username_0",
"text": "After looking at the state it seems you are right. The branch used is the master by comparing the files it contains. Should I wait until your next push before going further with x2js in my project or can I download and work with the type definition interface from DefinitelyTyped ?\r\n\r\nThank you very much for your answer !",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sandersaares",
"comment_id": 264795108,
"datetime": 1480926946000,
"masked_author": "username_1",
"text": "Feel free to work with the contents of the development branch. There are no open issues, so to the best of my knowledge it is in a good state. I do not currently expect any more changes to take place before it is published to npm - the delay is merely a matter of scheduling.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Jacks50",
"comment_id": 264796879,
"datetime": 1480927559000,
"masked_author": "username_0",
"text": "Okay, thank you very much for your answers @username_1 !",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Jacks50",
"comment_id": null,
"datetime": 1480927562000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 1,295 | false | false | 1,295 | true |
DefinitelyTyped/DefinitelyTyped | DefinitelyTyped | 161,008,699 | 9,703 | {
"number": 9703,
"repo": "DefinitelyTyped",
"user_login": "DefinitelyTyped"
} | [
{
"action": "opened",
"author": "samchon",
"comment_id": null,
"datetime": 1466229081000,
"masked_author": "username_0",
"text": "case 1. Add a new type definition.\r\n- [v] checked compilation succeeds with `--target es6` and `--noImplicitAny` options.\r\n- [v] has correct [naming convention](http://definitelytyped.org/guides/contributing.html#naming-the-file)\r\n- [v] has a [test file](http://definitelytyped.org/guides/contributing.html#tests) with the suffix of `-tests.ts` or `-tests.tsx`.\r\n===========\r\n## Finally, TypeScript-STL v1.0 has released.\r\n##### Release Candidate\r\nNow, release candidate has begun. If you find some bugs or something to improve, please write to the [**issues**](https://github.com/username_0/stl/issues).\r\n\r\n##### References\r\nYou can learn about the TypeScript-STL more deeply with API Documents and Wiki.\r\n - [API Documents](http://username_0.github.io/stl/api)\r\n - [Wiki](https://github.com/username_0/stl/wiki)\r\n\r\n##### Implementeds\r\n###### Containers\r\n- [Linear containers](http://username_0.github.io/stl/api/interfaces/std.base.container.ilinearcontainer.html)\r\n - [Vector](http://username_0.github.io/stl/api/classes/std.vector.html)\r\n - [List](http://username_0.github.io/stl/api/classes/std.list.html)\r\n - [Deque](http://username_0.github.io/stl/api/classes/std.deque.html)\r\n- [Tree-structured containers](http://username_0.github.io/stl/api/classes/std.base.tree.rbtree.html)\r\n - [TreeSet](http://username_0.github.io/stl/api/classes/std.treeset.html)\r\n - [TreeMap](http://username_0.github.io/stl/api/classes/std.treemap.html)\r\n - [TreeMultiSet](http://username_0.github.io/stl/api/classes/std.treemultiset.html)\r\n - [TreeMultiMap](http://username_0.github.io/stl/api/classes/std.treemultimap.html)\r\n- [Hashed containers](http://username_0.github.io/stl/api/classes/std.base.hash.hashbuckets.html)\r\n - [HashSet](http://username_0.github.io/stl/api/classes/std.hashset.html)\r\n - [HashMap](http://username_0.github.io/stl/api/classes/std.hashmap.html)\r\n - [HashMultiSet](http://username_0.github.io/stl/api/classes/std.hashmultiset.html)\r\n - [HashMultiMap](http://username_0.github.io/stl/api/classes/std.hashmultimap.html)\r\n- Etc.\r\n - [Queue](http://username_0.github.io/stl/api/classes/std.queue.html)\r\n - [Stack](http://username_0.github.io/stl/api/classes/std.stack.html)\r\n - [PriorityQueue](http://username_0.github.io/stl/api/classes/std.priorityqueue.html)\r\n\r\n###### Exceptions\r\nAll type of exceptions\r\n\r\n###### Global Functions\r\n - <algorithm>\r\n - All the functions in <algorithm>\r\n - <functional>\r\n - [std.bind](http://username_0.github.io/stl/api/modules/std.html#bind)\r\n - [std.placeholders](http://username_0.github.io/stl/api/modules/std.placeholders.html)\r\n - [std.hash](http://username_0.github.io/stl/api/modules/std.html#hash)\r\n - <utility>\r\n - [std.Pair](http://username_0.github.io/stl/api/classes/std.pair.html)\r\n\r\n## Updated from v0.9.7\r\n##### API Documents are strengthen with Class Diagrams\r\nNow, you can see the related class diagrams in *API Documents*'s each page.\r\n\r\n![Abstract Containers](http://username_0.github.io/stl/api/assets/images/design/abstract_containers.png \"Abstract Containers\")\r\n\r\n##### Hash and Tree containers are refactored\r\nOrdinary maps (also sets) are inherited from base.UniqueMap or base.MultiMap by uniqueness of key. Now, the map containers also implement base.ITreeMap or base.IHasMap by their key-mapping algorithm.\r\n\r\n - [ITreeMap](http://username_0.github.io/stl/api/interfaces/std.base.itreemap.html)\r\n - [IHashMap](http://username_0.github.io/stl/api/interfaces/std.base.ihashmap.html)\r\n\r\n##### Hash buckets function in Hash containers are implemented\r\nNow, you also can access to hash buckets following those member functions.\r\n\r\n - [begin](http://username_0.github.io/stl/api/interfaces/std.base.ihashmap.html#begin)\r\n - [end](http://username_0.github.io/stl/api/interfaces/std.base.ihashmap.html#end)\r\n - [bucket_count](http://username_0.github.io/stl/api/interfaces/std.base.ihashmap.html#bucket_count)\r\n - [bucket_size](http://username_0.github.io/stl/api/interfaces/std.base.ihashmap.html#bucket_size)\r\n - [max_load_factor](http://username_0.github.io/stl/api/interfaces/std.base.ihashmap.html#max_load_factor)\r\n - [bucket](http://username_0.github.io/stl/api/interfaces/std.base.ihashmap.html#bucket)\r\n - [reserve](http://username_0.github.io/stl/api/interfaces/std.base.ihashmap.html#reserve)\r\n - [rehash](http://username_0.github.io/stl/api/interfaces/std.base.ihashmap.html#rehash)\r\n\r\n##### Heap functions are implemented\r\nGlobal heap functions in **<algorithm>** are implemented.\r\n\r\n - [std.make_heap](http://username_0.github.io/stl/api/modules/std.html#make_heap)\r\n - [std.push_heap](http://username_0.github.io/stl/api/modules/std.html#push_heap)\r\n - [std.pop_heap](http://username_0.github.io/stl/api/modules/std.html#pop_heap)\r\n - [std.is_heap](http://username_0.github.io/stl/api/modules/std.html#is_heap)\r\n - [std.is_heap_until](http://username_0.github.io/stl/api/modules/std.html#is_heap_until)\r\n - [std.sort_heap](http://username_0.github.io/stl/api/modules/std.html#sort_heap)",
"title": "TypeScript-STL v1.0.0-rc.1",
"type": "issue"
},
{
"action": "created",
"author": "samchon",
"comment_id": 226942776,
"datetime": 1466256851000,
"masked_author": "username_0",
"text": "Wrong commit",
"title": null,
"type": "comment"
}
] | 2 | 3 | 6,570 | false | true | 4,964 | true |
SPStore/SPPageMenu | null | 278,495,398 | 6 | null | [
{
"action": "opened",
"author": "yanglijunwang",
"comment_id": null,
"datetime": 1512141044000,
"masked_author": "username_0",
"text": "比如从A界面跳到有你这个page的界面怎么接受传值呢。",
"title": "界面传值呢 ",
"type": "issue"
},
{
"action": "created",
"author": "SPStore",
"comment_id": 348692853,
"datetime": 1512222123000,
"masked_author": "username_1",
"text": "- (void)setItems:(nullable NSArray *)items selectedItemIndex:(NSUInteger)selectedItemIndex;这个方法就是接收传值的呀，你在控制器首先用一个数组接收上一个界面传过来的值，再把数组作为参数传入到pageMenu就可以。",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yanglijunwang",
"comment_id": 349194197,
"datetime": 1512449122000,
"masked_author": "username_0",
"text": "self.dataArr = @[@\"生活\",@\"影视中心\",@\"交通\",@\"电视剧\",@\"搞笑\"];\r\n \r\n // trackerStyle:跟踪器的样式\r\n SPPageMenu *pageMenu = [SPPageMenu pageMenuWithFrame:CGRectMake(0, NaviH, screenW, pageMenuH) trackerStyle:SPPageMenuTrackerStyleRect];\r\n // 传递数组，默认选中第1个\r\n [pageMenu setItems:self.dataArr selectedItemIndex:1];\r\n\r\n楼主 我看到你这个都是传标题 我的意思的 有没有把scrollView里面的加的某个控制器里面的值或者多选传到上个页面去 ，现在 这个是一个集合控制器 我跳转 到的是这个壳子控制器我想可以pop回去的时候能反向传值",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yanglijunwang",
"comment_id": 349194334,
"datetime": 1512449189000,
"masked_author": "username_0",
"text": "我研究了一下 我现在用的通知 您有什么好的建议吗",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "SPStore",
"comment_id": null,
"datetime": 1526895705000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "reopened",
"author": "SPStore",
"comment_id": null,
"datetime": 1526895766000,
"masked_author": "username_1",
"text": "比如从A界面跳到有你这个page的界面怎么接受传值呢。",
"title": "界面传值呢 ",
"type": "issue"
}
] | 2 | 6 | 649 | false | false | 649 | false |
karenderrickdavis/ndoch2016 | null | 147,603,067 | 18 | null | [
{
"action": "opened",
"author": "karenderrickdavis",
"comment_id": null,
"datetime": 1460423716000,
"masked_author": "username_0",
"text": "### Take pictures and tweet! \n\nTweeting during your event and taking pictures will help document the event. This will come in handy when you blog about the event. It'll also let the community know what you're up to.",
"title": "Take Pictures and Tweet!",
"type": "issue"
}
] | 1 | 1 | 215 | false | false | 215 | false |
kubernetes/kubernetes | kubernetes | 231,780,383 | 46,561 | {
"number": 46561,
"repo": "kubernetes",
"user_login": "kubernetes"
} | [
{
"action": "opened",
"author": "zhangxiaoyu-zidif",
"comment_id": null,
"datetime": 1495867002000,
"masked_author": "username_0",
"text": "<!-- Thanks for sending a pull request! Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://github.com/kubernetes/community/blob/master/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nReturn nil directly when err is nil\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!-- Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```",
"title": "Return nil when err is nil",
"type": "issue"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 304463681,
"datetime": 1495903985000,
"masked_author": "username_1",
"text": "This is effectively a noop. Why is this needed?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zhangxiaoyu-zidif",
"comment_id": 304482656,
"datetime": 1495929052000,
"masked_author": "username_0",
"text": "@username_1 Sir， please refer to https://github.com/kubernetes/kubernetes/pull/29866, https://github.com/kubernetes/kubernetes/pull/45162. That may be a format. Thanks.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 304492137,
"datetime": 1495945829000,
"masked_author": "username_1",
"text": "@k8s-bot ok to test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cblecker",
"comment_id": 304702943,
"datetime": 1496078030000,
"masked_author": "username_1",
"text": "/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "wojtek-t",
"comment_id": 304815527,
"datetime": 1496134353000,
"masked_author": "username_2",
"text": "/approve",
"title": null,
"type": "comment"
}
] | 5 | 13 | 4,825 | false | true | 1,432 | true |
herdup/herd | herdup | 204,712,154 | 65 | null | [
{
"action": "opened",
"author": "dawilster",
"comment_id": null,
"datetime": 1485984880000,
"masked_author": "username_0",
"text": "Bump mini_magick to `4.2.8` fix this issue I've been having https://github.com/minimagick/minimagick/issues/279\r\n\r\nI'm putting up a PR now",
"title": "Bump mini_magick to 4.2.8 ",
"type": "issue"
},
{
"action": "created",
"author": "dawilster",
"comment_id": 277015428,
"datetime": 1486054634000,
"masked_author": "username_0",
"text": "Sorry about this. I didn't realize that `mini_magick` `4.2.8` had been yanked by the author. The latest compatitable minor version `4.2.10`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hhff",
"comment_id": 277016556,
"datetime": 1486054861000,
"masked_author": "username_1",
"text": "@username_0 could you submit a PR for loosening the dep like `~> 4.2.10`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dawilster",
"comment_id": 277016772,
"datetime": 1486054902000,
"masked_author": "username_0",
"text": "@username_1 will do",
"title": null,
"type": "comment"
}
] | 2 | 4 | 361 | false | false | 361 | true |
shirasagi/shirasagi | shirasagi | 283,872,247 | 1,832 | {
"number": 1832,
"repo": "shirasagi",
"user_login": "shirasagi"
} | [
{
"action": "opened",
"author": "tany",
"comment_id": null,
"datetime": 1513860599000,
"masked_author": "username_0",
"text": "",
"title": "GWS Refactoring",
"type": "issue"
}
] | 2 | 2 | 283 | false | true | 0 | false |
Microsoft/vscode | Microsoft | 230,935,262 | 27,180 | {
"number": 27180,
"repo": "vscode",
"user_login": "Microsoft"
} | [
{
"action": "opened",
"author": "ramya-rao-a",
"comment_id": null,
"datetime": 1495608019000,
"masked_author": "username_0",
"text": "",
"title": "Start crash reporter inside child processes",
"type": "issue"
},
{
"action": "created",
"author": "bpasero",
"comment_id": 303640434,
"datetime": 1495610637000,
"masked_author": "username_1",
"text": "@username_0 I suggest to just introduce `process.env` variables for the crash reporter metadata and read them in the forked process. Using the local storage as a way to communicate data is a bad hack. At the very minimum it should be a ICrashReporterService that we can require in places where we need it (except for forked processes where we do not have services). Anyway, using process environment would save you that issue as well as you would not have to pass arguments around.\r\n\r\nWe still only have one crash reporter process even when we start it from other processes, right?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ramya-rao-a",
"comment_id": 303770581,
"datetime": 1495641745000,
"masked_author": "username_0",
"text": "In Mac which uses crashpad yes. There is a single handler for monitoring crashes for all processes (main, renderer, child)\r\n\r\nIn Windows, we need start another process that does the monitoring. This PR doesn't include that. See https://github.com/electron/electron/blob/master/docs/api/crash-reporter.md#crashreporterstartoptions\r\n\r\nI'll have to dig a little more to get the more details",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bpasero",
"comment_id": 303792057,
"datetime": 1495646306000,
"masked_author": "username_1",
"text": "@username_0 what we could also do as a starter is to only enable this on macOS for e.g. the extension host.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ramya-rao-a",
"comment_id": 303884606,
"datetime": 1495670003000,
"masked_author": "username_0",
"text": "@username_1 PR updated as we discussed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bpasero",
"comment_id": 303938661,
"datetime": 1495695498000,
"masked_author": "username_1",
"text": "@username_0 I pushed some refactorings and a bugfixes on top of your commit to this PR, please have a look. When trying this out locally I was getting a crash right on startup on the extension host. \r\n\r\nOne thing to look into is your use of `crashesDirectory`. Shouldn't this property be set on the crash reporter options directly and not the extra bag? And then, we should probably not set this option all the time but only from the object returned from `getChildProcessStartOptions`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ramya-rao-a",
"comment_id": 304051564,
"datetime": 1495728780000,
"masked_author": "username_0",
"text": "Ideally yes. This option is not used by the main/renderer process, so I didn't see the harm in sending it all the time rather than just for the child process. Fixed with 95c851784cbc61ad86cdd3abc7393f708477a330\r\n\r\nbtw I spent a lot of time getting the service plumbing to work, but kept getting unhelpful errors while instantiating the ExtensionHostProcessWorker which I then narrowed down to my service not defining \"_serviceBrand\". Do we have any docs around do's don'ts for such cases?",
"title": null,
"type": "comment"
}
] | 3 | 8 | 2,244 | false | true | 2,086 | true |
exercism/julia | exercism | 253,143,674 | 83 | {
"number": 83,
"repo": "julia",
"user_login": "exercism"
} | [
{
"action": "opened",
"author": "fsouza",
"comment_id": null,
"datetime": 1503813899000,
"masked_author": "username_0",
"text": "",
"title": "resources: fix link to Style Guide",
"type": "issue"
},
{
"action": "created",
"author": "SaschaMann",
"comment_id": 325439763,
"datetime": 1503945260000,
"masked_author": "username_1",
"text": "Good catch, thanks for fixing it! :)",
"title": null,
"type": "comment"
}
] | 2 | 2 | 36 | false | false | 36 | false |
catch22/octave-doctest | null | 169,528,433 | 153 | null | [
{
"action": "opened",
"author": "cbm755",
"comment_id": null,
"datetime": 1470372844000,
"masked_author": "username_0",
"text": "\"...\" does not match blank space at the beginning (end?) of lines. Perhaps gives some unexpected results if used to match whitespace in the middle of a command too.\r\n\r\nThis might be because of NORMALIZE_WHITESPACE and ELLIPSES and which one we do first...",
"title": "ELLIPSES doesn't match blank space properly",
"type": "issue"
},
{
"action": "closed",
"author": "cbm755",
"comment_id": null,
"datetime": 1477874777000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 256 | false | false | 256 | false |
ng2-ui/sticky | ng2-ui | 266,914,294 | 16 | null | [
{
"action": "opened",
"author": "paullessing",
"comment_id": null,
"datetime": 1508431917000,
"masked_author": "username_0",
"text": "In our application, we have multiple header elements which need to be sticky (at different times). I used `sticky-after` to attempt positioning the second header after the first header, but the second header started sticking too early - I believe it sticks at the bottom of where the first header _starts off_ rather than is when the second header hits it.",
"title": "`sticky-after` uses wrong position if element moves after creation",
"type": "issue"
},
{
"action": "closed",
"author": "allenhwkim",
"comment_id": null,
"datetime": 1508439065000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 356 | false | false | 356 | false |
cmugpi/git-practice | cmugpi | 270,794,876 | 174 | {
"number": 174,
"repo": "git-practice",
"user_login": "cmugpi"
} | [
{
"action": "opened",
"author": "tinawu98",
"comment_id": null,
"datetime": 1509654179000,
"masked_author": "username_0",
"text": "",
"title": "huachenw",
"type": "issue"
},
{
"action": "created",
"author": "wpaivine",
"comment_id": 348368090,
"datetime": 1512089219000,
"masked_author": "username_1",
"text": "_Yo, nice._",
"title": null,
"type": "comment"
}
] | 2 | 2 | 11 | false | false | 11 | false |
pantheon-systems/autotag | pantheon-systems | 240,864,803 | 14 | {
"number": 14,
"repo": "autotag",
"user_login": "pantheon-systems"
} | [
{
"action": "opened",
"author": "theckman",
"comment_id": null,
"datetime": 1499325249000,
"masked_author": "username_0",
"text": "This change enhances the `autotag` package to support including pre-release\r\ninformation on to a generated tag. This functionality is being added to\r\nfacilitate the tagging of releases that aren't considered ready for stable\r\nrelease, while being able to generate a tag that's useful for humans and\r\nautomated tooling.\r\n\r\n**Note:** this change introduces a breaking API change to the `NewRepo()`\r\nfunction. Instead of taking two string parameters, the function now takes an\r\n`autotag.GitRepoConfig` instance. This is because we added two new user-provided\r\nparameters to the `GitRepo` struct.\r\n\r\nIn our organization, we have the need to create releases from branches before\r\nthe merge to the stable (`master`) branch happens. This need isn't part of our\r\nnormal release workflow, and is reserved for situations where a release is\r\nneeded from a branch (think hotfix, or similar).\r\n\r\nTo accomplish the creation of pre-release tags, we added two new parameters that\r\ncan be used to configure the GitRepo:\r\n\r\n* PreReleaseName: the `NAME` to use in the tag (e.g., `v1.2.3-NAME`)\r\n* PreReleaseTimestampLayout the `LAYOUT` to use to generate the timestamp (e.g.,\r\n `v1.2.3-LAYOUT`) -- this a layout string from the `time` package\r\n\r\nIf either of these values are set, or both, a hyphen is added to the tag and the\r\nrespective values are added to the end of the tag. If these two values are\r\ncombined, and name is `test` and the layout is `epoch`, the tag would look\r\nsomething like `v1.2.4-test.1499323531`.\r\n\r\nWithin the `autotag` package itself, this is done by calculating the new stable\r\ntag (e.g., `v1.2.4`) and then appending the pre-release information to the end\r\nof it. The `autotag` code path that determines the latest tag now explicitly\r\nskips over tags with pre-release information attached. This is to ensure our\r\npre-release tags are only cut from stable ones.\r\n\r\nWithin the `autotag` binary, two more command line flags have been added:\r\n\r\n```\r\n-p, --pre-release-name= create a pre-release tag with this name (can be: alpha|beta|pre|rc)\r\n-T, --pre-release-timestamp= create a pre-release tag and append a timestamp (can be: datetime|epoch)\r\n```\r\n\r\nThe `-p` flag allows users to specify the pre-release-name. While the `autotag`\r\npackage allows us to specify any string we want, the `autotag` binary only\r\naccepts a subset of values to use (to promote good practices). The help output\r\nlists the possible values.\r\n\r\nThe `-T` flag supports either setting a `datetime` (`YYYYMMDDHHMMSS`) timestamp,\r\nor a UNIX `epoch` timestamp.\r\n\r\nHere is an example of them being used:\r\n\r\n```\r\n$ autotag -n -p pre\r\n1.1.1-pre\r\n$ autotag -n -T epoch\r\n1.1.1-1499320004\r\n$ autotag -n -T datetime\r\n1.1.1-20170706054703\r\n$ autotag -n -p pre -T epoch\r\n1.1.1-pre.1499319951\r\n$ autotag -n -p pre -T datetime\r\n1.1.1-pre.20170706054528\r\n```\r\n\r\nIn addition to the changes made, extra tests were added to assert the new\r\nfunctionality of the package. None of the older tests were changed, which\r\nindicates the behavior of the `autotag` binary should be backwards compatible\r\nwith previous versions.",
"title": "Add support for creating pre-release tags from last stable tag",
"type": "issue"
},
{
"action": "created",
"author": "spheromak",
"comment_id": 313481834,
"datetime": 1499366054000,
"masked_author": "username_1",
"text": "thanks @username_0",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "theckman",
"comment_id": 313519260,
"datetime": 1499375152000,
"masked_author": "username_0",
"text": "@username_1 my pleasure, thank you for the quick review/merge as well as making this codebase easy to extend (you too @fujin).",
"title": null,
"type": "comment"
}
] | 2 | 3 | 3,224 | false | false | 3,224 | true |
jsbin/jsbin | jsbin | 51,759,043 | 2,194 | null | [
{
"action": "opened",
"author": "sometimesmotion",
"comment_id": null,
"datetime": 1418346159000,
"masked_author": "username_0",
"text": "I made two accounts and would like to merge them- retaining my gihub account (username_0) and deleting my regular account (millrt138).",
"title": "Merge my github and regular accounts",
"type": "issue"
}
] | 2 | 3 | 660 | false | true | 139 | true |
mochajs/mocha | mochajs | 7,882,565 | 627 | null | [
{
"action": "opened",
"author": "rngadam",
"comment_id": null,
"datetime": 1351230155000,
"masked_author": "username_0",
"text": "This is a problem when running a directory of multiple tests.\r\n\r\nTest failures on assertion or exception give the correct file from the stack trace.\r\n\r\nA timeout however leaves us grepping for the correct file:\r\n\r\n```\r\n 2) lophilo watch watching...:\r\n Error: timeout of 2000ms exceeded\r\n at Object.<anonymous> (/home/username_0/local/node/lib/node_modules/mocha/lib/runnable.js:158:14)\r\n at Timer.list.ontimeout (timers.js:101:19\r\n```",
"title": "Add test file location on timeout exceeded test failure",
"type": "issue"
},
{
"action": "created",
"author": "BetaKevin",
"comment_id": 76430334,
"datetime": 1425056826000,
"masked_author": "username_1",
"text": ":+1:",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "boneskull",
"comment_id": null,
"datetime": 1521759034000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 3 | 450 | false | false | 450 | true |
videojs/videojs-contrib-ads | videojs | 292,467,583 | 324 | null | [
{
"action": "opened",
"author": "ypavlotsky",
"comment_id": null,
"datetime": 1517242600000,
"masked_author": "username_0",
"text": "Hi,\r\n\r\nI modified the [playlist sample](http://googleads.github.io/videojs-ima/examples/playlist/) for the video.js IMA plugin to play a second video once the first finishes and I'm seeing some weird behavior where once the first video's post-roll finishes, I see the pre-roll for the second video, but then I don't see the video for the second video, just audio, the poster and a loading spinner. The video plays normally if we try to play it afterwards. So we're not sure if this is a contrib-ads issue or a player issue, but figured to check with you first to see if there's something we should be doing differently.\r\n\r\nThanks,\r\nYury",
"title": "Playback error when playing one video with ads after another ",
"type": "issue"
},
{
"action": "created",
"author": "incompl",
"comment_id": 361632563,
"datetime": 1517326745000,
"masked_author": "username_1",
"text": "@username_2 This sounds like one of the issues you were working on, is it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alex-barstow",
"comment_id": 361730370,
"datetime": 1517345560000,
"masked_author": "username_2",
"text": "The symptoms certainly sound similar. The audio-only issue I was working on is unique to a different integration, though I suppose it's possible the underlying cause in contrib-ads is the same.\r\n\r\n@username_0 I am not able to reproduce the problem with your linked test page. Is that the modified or unmodified playlist sample? The second video does not autoplay after the postroll of the first video. If I can reproduce the issue I can try to determine whether it's caused by the same bug I'm working on.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ypavlotsky",
"comment_id": 361745236,
"datetime": 1517348813000,
"masked_author": "username_0",
"text": "The above page was the unmodified sample. I put up the modified code [here](https://username_0.github.io/vjsima/examples/playlist/).\r\n\r\nTo repro: click the play button, sit through the preroll on the first video and skip to the end. Sit through the post-roll and then the preroll for the second video, and you'll see the spinner and no content video after that.\r\n\r\nNote: it didn't happen 100% of the time for me, so it might be a race condition.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alex-barstow",
"comment_id": 364216359,
"datetime": 1518116962000,
"masked_author": "username_2",
"text": "So far I've had no luck reproducing this. @username_0 On which platforms have you observed it?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ypavlotsky",
"comment_id": null,
"datetime": 1518119328000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ypavlotsky",
"comment_id": 364227471,
"datetime": 1518119328000,
"masked_author": "username_0",
"text": "Just went back to try to repro it and now I can't get it to happen either. I'll close this out and comment back here if I run into it again. FWIW, I'm running Chrome 64 on Linux.",
"title": null,
"type": "comment"
}
] | 3 | 7 | 1,934 | false | false | 1,934 | true |
SpongePowered/SpongeAPI | SpongePowered | 126,003,878 | 1,027 | null | [
{
"action": "opened",
"author": "kashike",
"comment_id": null,
"datetime": 1452536043000,
"masked_author": "username_0",
"text": "https://github.com/SpongePowered/SpongeDocs/pull/430#discussion_r49355501",
"title": "FurnaceRecipe",
"type": "issue"
},
{
"action": "created",
"author": "Zidane",
"comment_id": 308762292,
"datetime": 1497538939000,
"masked_author": "username_1",
"text": "Closing as there is now a PR for this. Comment on that.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Zidane",
"comment_id": null,
"datetime": 1497538939000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 128 | false | false | 128 | false |
google/auto | google | 290,668,224 | 588 | null | [
{
"action": "opened",
"author": "hgschmie",
"comment_id": null,
"datetime": 1516667998000,
"masked_author": "username_0",
"text": "Similar to what was mentioned in #201, a problem with e.g. Jackson is that the generated classes (e.g. Foo_AutoValue) are package private. When turning off the \"make the class accessible feature\" with `objectMapper.disable(MapperFeature.CAN_OVERRIDE_ACCESS_MODIFIERS);`\r\nwill lead to exceptions where Jackson claims it can not execute a public method on such a bean:\r\n\r\n```\r\n java.lang.IllegalAccessException: Class com.fasterxml.jackson.databind.ser.BeanPropertyWriter can not access a member of class com.zuora.owl.testbed.db.entity.AutoValue_NationEntity with modifiers \"public\"\r\n! at sun.reflect.Reflection.ensureMemberAccess(Reflection.java:102)\r\n! at java.lang.reflect.AccessibleObject.slowCheckMemberAccess(AccessibleObject.java:296)\r\n! at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:288)\r\n! at java.lang.reflect.Method.invoke(Method.java:491)\r\n! at com.fasterxml.jackson.databind.ser.BeanPropertyWriter.serializeAsField(BeanPropertyWriter.java:687)\r\n! at com.fasterxml.jackson.module.afterburner.ser.ObjectMethodPropertyWriter.serializeAsField(ObjectMethodPropertyWriter.java:40)\r\n! at com.fasterxml.jackson.databind.ser.std.BeanSerializerBase.serializeFields(BeanSerializerBase.java:719)\r\n```\r\n\r\nwhile the implemented abstract method in the parent bean is public:\r\n\r\n```java\r\nimport com.fasterxml.jackson.annotation.JsonProperty;\r\nimport com.google.auto.value.AutoValue;\r\n\r\nimport java.util.UUID;\r\n\r\n@AutoValue\r\npublic abstract class NationEntity implements Entity {\r\n\r\n public static NationEntity create(\r\n @JsonProperty(\"id\") long id,\r\n @JsonProperty(\"nationKey\") UUID nationKey,\r\n @JsonProperty(\"name\") String name,\r\n @JsonProperty(\"regionKey\") UUID regionKey,\r\n @JsonProperty(\"comment\") String comment) {\r\n return new AutoValue_NationEntity(id, nationKey, name, regionKey, comment);\r\n }\r\n\r\n @JsonProperty(required = true)\r\n public abstract long getId();\r\n\r\n @JsonProperty(required = true)\r\n public abstract UUID getNationKey();\r\n\r\n @JsonProperty(required = true)\r\n public abstract String getName();\r\n\r\n @JsonProperty(required = true)\r\n public abstract UUID getRegionKey();\r\n\r\n @JsonProperty(required = true)\r\n public abstract String getComment();\r\n}\r\n```\r\n\r\nand also in the generated class, the class itself is package private:\r\n\r\n``` \r\nimport com.fasterxml.jackson.annotation.JsonProperty;\r\nimport java.util.UUID;\r\nimport javax.annotation.Generated;\r\n\r\n@Generated(\"com.google.auto.value.processor.AutoValueProcessor\")\r\n final class AutoValue_NationEntity extends NationEntity {\r\n\r\n private final long id;\r\n private final UUID nationKey;\r\n private final String name;\r\n private final UUID regionKey;\r\n private final String comment;\r\n\r\n AutoValue_NationEntity(\r\n long id,\r\n UUID nationKey,\r\n String name,\r\n UUID regionKey,\r\n String comment) {\r\n this.id = id;\r\n if (nationKey == null) {\r\n throw new NullPointerException(\"Null nationKey\");\r\n }\r\n this.nationKey = nationKey;\r\n if (name == null) {\r\n throw new NullPointerException(\"Null name\");\r\n }\r\n this.name = name;\r\n if (regionKey == null) {\r\n throw new NullPointerException(\"Null regionKey\");\r\n }\r\n this.regionKey = regionKey;\r\n if (comment == null) {\r\n throw new NullPointerException(\"Null comment\");\r\n }\r\n this.comment = comment;\r\n }\r\n\r\n @JsonProperty(required = true)\r\n @Override\r\n public long getId() {\r\n return id;\r\n }\r\n\r\n @JsonProperty(required = true)\r\n @Override\r\n public UUID getNationKey() {\r\n return nationKey;\r\n }\r\n\r\n @JsonProperty(required = true)\r\n @Override\r\n public String getName() {\r\n return name;\r\n }\r\n\r\n @JsonProperty(required = true)\r\n @Override\r\n public UUID getRegionKey() {\r\n return regionKey;\r\n }\r\n\r\n @JsonProperty(required = true)\r\n @Override\r\n public String getComment() {\r\n return comment;\r\n }\r\n\r\n @Override\r\n public String toString() {\r\n return \"NationEntity{\"\r\n + \"id=\" + id + \", \"\r\n + \"nationKey=\" + nationKey + \", \"\r\n + \"name=\" + name + \", \"\r\n + \"regionKey=\" + regionKey + \", \"\r\n + \"comment=\" + comment\r\n + \"}\";\r\n }\r\n\r\n @Override\r\n public boolean equals(Object o) {\r\n if (o == this) {\r\n return true;\r\n }\r\n if (o instanceof NationEntity) {\r\n NationEntity that = (NationEntity) o;\r\n return (this.id == that.getId())\r\n && (this.nationKey.equals(that.getNationKey()))\r\n && (this.name.equals(that.getName()))\r\n && (this.regionKey.equals(that.getRegionKey()))\r\n && (this.comment.equals(that.getComment()));\r\n }\r\n return false;\r\n }\r\n\r\n @Override\r\n public int hashCode() {\r\n int h = 1;\r\n h *= 1000003;\r\n h ^= (int) ((this.id >>> 32) ^ this.id);\r\n h *= 1000003;\r\n h ^= this.nationKey.hashCode();\r\n h *= 1000003;\r\n h ^= this.name.hashCode();\r\n h *= 1000003;\r\n h ^= this.regionKey.hashCode();\r\n h *= 1000003;\r\n h ^= this.comment.hashCode();\r\n return h;\r\n }\r\n\r\n}\r\n```\r\n\r\nThe issue is that Jackson uses the \"`public java.util.UUID AutoValue_NationEntity.getNationKey()` method instead of `public abstract java.util.UUID NationEntity.getNationKey()` so the class uses is not public. \r\n\r\nWorkarounds that I have is either adding the `@JsonSerialize(as=NationEntity.class)` annotation to NationEntity or allow Jackson to use `setAccessible`. Neither is really satisfying.\r\n\r\nHow about an attribute to `@AutoValue` that controls the visibility of generated classes with the default of \"package private\" but the option to make those public if desired?",
"title": "introspection of package private classes",
"type": "issue"
},
{
"action": "closed",
"author": "eamonnmcmanus",
"comment_id": null,
"datetime": 1516786349000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "eamonnmcmanus",
"comment_id": 360072414,
"datetime": 1516786349000,
"masked_author": "username_1",
"text": "For me this is clearly a bug in Jackson. It's a well-known problem that when you are invoking a public Method you may need to find its specification in a public superclass or superinterface. AutoValue even [does this](https://github.com/google/auto/blob/d5ca4ab484fd0def8d8c67b20481c3e285ed6c03/value/src/main/java/com/google/auto/value/processor/escapevelocity/ReferenceNode.java#L328) in its own implementation.\r\n\r\nIf you really want `AutoValue_Foo` to be public then you can trivially write an [extension](https://github.com/google/auto/blob/master/value/userguide/extensions.md) to achieve that. I don't expect that we will ever want this behaviour to be part of core AutoValue.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 6,319 | false | false | 6,319 | false |
kemitix/conditional | null | 253,113,489 | 4 | {
"number": 4,
"repo": "conditional",
"user_login": "kemitix"
} | [
{
"action": "opened",
"author": "kemitix",
"comment_id": null,
"datetime": 1503771346000,
"masked_author": "username_0",
"text": "",
"title": "Condition: avoid danger of JVM-level deadlock during initialisation",
"type": "issue"
}
] | 2 | 2 | 283 | false | true | 0 | false |
rstudio/shiny | rstudio | 8,424,087 | 42 | null | [
{
"action": "opened",
"author": "HarlanH",
"comment_id": null,
"datetime": 1353082798000,
"masked_author": "username_0",
"text": "Would love the `checkboxGroupInput` to (optionally) have a select all/select none box associated with the group.",
"title": "all-or-nothing selector for checkbox groups",
"type": "issue"
},
{
"action": "created",
"author": "cc886",
"comment_id": 286007771,
"datetime": 1489375773000,
"masked_author": "username_1",
"text": "I love this! An elegant solution!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "larmarange",
"comment_id": 442866236,
"datetime": 1543503915000,
"masked_author": "username_2",
"text": "Could it be relevant to reopen that suggestion?\r\n\r\nWhen using `shiny` with `flexdashboard`, it would be easier for basic users to have a simple option directly within `checkboxGroupInput ()`.\r\n\r\nBest regards",
"title": null,
"type": "comment"
}
] | 3 | 3 | 352 | false | false | 352 | false |
apache/karaf | apache | 263,352,687 | 381 | {
"number": 381,
"repo": "karaf",
"user_login": "apache"
} | [
{
"action": "opened",
"author": "tomq42",
"comment_id": null,
"datetime": 1507273217000,
"masked_author": "username_0",
"text": "",
"title": "[KARAF-5411] Allow for users.properties file not existing, or empty",
"type": "issue"
},
{
"action": "created",
"author": "jbonofre",
"comment_id": 334688039,
"datetime": 1507277316000,
"masked_author": "username_1",
"text": "Please, close this PR. The PR should be opened only on master and then we cherry-pick on other branches.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tomq42",
"comment_id": 334699199,
"datetime": 1507280397000,
"masked_author": "username_0",
"text": "Fair enough.\nThe code was significantly different in the Config class, and I actually couldn't get master to run, and 4.1 was what I was after.\n\n> On 06 October 2017 at 09:08 Jean-Baptiste",
"title": null,
"type": "comment"
}
] | 2 | 3 | 292 | false | false | 292 | false |
twbs/bootstrap | twbs | 267,222,790 | 24,474 | null | [
{
"action": "opened",
"author": "iantbarker",
"comment_id": null,
"datetime": 1508515053000,
"masked_author": "username_0",
"text": "I see old issues about theme colors but the answers seem to be that it is resolved in beta 2. I upgraded to beta 2 and I cannot get theme colors to work. My file structure is to import individual BS files into main.scss. I have:\r\n\r\n`@import \"bootstrap/functions\";\r\n@import \"bootstrap/variables\";\r\n@import \"_variables_custom.scss\";`\r\n\r\nIn my \"_variables_custom.scss\" file I have:\r\n\r\n`$brand-primary: \t#e95362;\r\n$theme-colors: (\r\n\t\"primary\": $brand-primary\r\n);`\r\n\r\nThis code changes the primary color but wipes out all other colors in the theme-colors map. I have to redeclare all the colors from the colors map to make it work.\r\n\r\nAm I missing something?",
"title": "Theme colors",
"type": "issue"
},
{
"action": "created",
"author": "jipexu",
"comment_id": 338255604,
"datetime": 1508516785000,
"masked_author": "username_1",
"text": "Hi\r\ni use like this way and work perfectly \r\n\r\n// core bootstrap functions\r\n@import \"../scss/functions\";\r\n@import \"../scss/mixins\";\r\n\r\n// variable overrides\r\n@import \"variables\"; <== your variables (in wich you need the new grayscale and colors function...)\r\n\r\n// full bootstrap\r\n@import \"../scss/bootstrap\";\r\n\r\n// style overrides if need\r\n@import \"xxxxx\";",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "andresgalante",
"comment_id": null,
"datetime": 1508529150000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "andresgalante",
"comment_id": 338306389,
"datetime": 1508529151000,
"masked_author": "username_2",
"text": "Hi @username_0, as @username_0 mentions import your variables **before** Bootstrap's it's documented here:\r\nhttp://getbootstrap.com/docs/4.0/getting-started/theming/#variable-defaults",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "iantbarker",
"comment_id": 338355547,
"datetime": 1508550143000,
"masked_author": "username_0",
"text": "Ah, my bad. Apologies.",
"title": null,
"type": "comment"
}
] | 3 | 5 | 1,217 | false | false | 1,217 | true |
nikita-volkov/th-instance-reification | null | 56,320,551 | 2 | null | [
{
"action": "opened",
"author": "3noch",
"comment_id": null,
"datetime": 1422926870000,
"masked_author": "username_0",
"text": "",
"title": "Support GHC 7.8",
"type": "issue"
},
{
"action": "closed",
"author": "nikita-volkov",
"comment_id": null,
"datetime": 1427009795000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "nikita-volkov",
"comment_id": 84547111,
"datetime": 1427009806000,
"masked_author": "username_1",
"text": "Fixed",
"title": null,
"type": "comment"
}
] | 2 | 3 | 5 | false | false | 5 | false |
binance-exchange/binance-java-api | binance-exchange | 318,127,130 | 120 | null | [
{
"action": "opened",
"author": "huykn",
"comment_id": null,
"datetime": 1524763833000,
"masked_author": "username_0",
"text": "tracelog:\r\n`\r\ncom.binance.api.client.exception.BinanceApiException: Account has insufficient balance for requested action. at com.binance.api.client.impl.BinanceApiServiceGenerator.executeSync(BinanceApiServiceGenerator.java:57) at com.binance.api.client.impl.BinanceApiRestClientImpl.newOrder(BinanceApiRestClientImpl.java:130)`\r\n\r\nRequest order:`\r\n{\"price\":\"14.107\",\"quantity\":\"1.000\",\"recvWindow\":6000000,\"side\":\"BUY\",\"symbol\":\"BNBUSDT\",\"timeInForce\":\"GTC\",\"timestamp\":1524763355419,\"type\":\"LIMIT\"}`\r\n\r\nError AssetBalance\r\n`BNB AssetBalance[asset=BNB,free=0.00000000,locked=0.00000000] USDT: AssetBalance[asset=USDT,free=0.00000000,locked=0.00000000]`\r\n\r\nMy account:\r\n<img width=\"663\" alt=\"screen shot 2018-04-27 at 12 25 11 am\" src=\"https://user-images.githubusercontent.com/11696396/39321664-da598a5c-49b1-11e8-91bf-0c8cf76a9c7a.png\">\r\n\r\nAlways tracelog: Account has insufficient balance for requested action.\r\nPlease help me!!!",
"title": "Account has insufficient balance for requested action.",
"type": "issue"
},
{
"action": "closed",
"author": "huykn",
"comment_id": null,
"datetime": 1524807707000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "huykn",
"comment_id": 384869938,
"datetime": 1524807707000,
"masked_author": "username_0",
"text": "issue when create restapi twice times",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rw026",
"comment_id": 482671264,
"datetime": 1555092708000,
"masked_author": "username_1",
"text": "What do you mean by creating rest api twice? Is there a way to close it?\r\nI run into the same problem but only creating the restapi once...",
"title": null,
"type": "comment"
}
] | 2 | 4 | 1,109 | false | false | 1,109 | false |
ubergeek42/weechat-android | null | 102,811,211 | 223 | null | [
{
"action": "opened",
"author": "txomon",
"comment_id": null,
"datetime": 1440427855000,
"masked_author": "username_0",
"text": "Hi, would it be possible to have DNS errors give more specific info? Currently just displays error : null",
"title": "DNS solve error just says error: null",
"type": "issue"
},
{
"action": "closed",
"author": "oakkitten",
"comment_id": null,
"datetime": 1444214190000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 105 | false | false | 105 | false |
vecnatechnologies/brec-tables | vecnatechnologies | 178,158,908 | 3 | null | [
{
"action": "opened",
"author": "mandragorn",
"comment_id": null,
"datetime": 1474400451000,
"masked_author": "username_0",
"text": "since the file structure of npm3 is flat there is not always a node_modules/brec-base as is reference here: https://github.com/vecnatechnologies/brec-tables/blob/master/index.js#L8-L12",
"title": "importing brec-base from brec-tables does not work in npm3",
"type": "issue"
},
{
"action": "created",
"author": "mandragorn",
"comment_id": 248412159,
"datetime": 1474400665000,
"masked_author": "username_0",
"text": "workaround is to use the brec-base reference.\r\ncurrent:\r\n```\r\n var brecTables = require('brec-tables');\r\n ...\r\n includePaths: [brecTables.base.sass, brecTables.tables.sass, paths.pikadateScss, paths.select2Scss],\r\n```\r\nworkaround:\r\n```\r\n var brecTables = require('brec-tables');\r\n var brec = require('brec-base');\r\n ...\r\n includePaths: [brec.sass, brecTables.tables.sass, paths.pikadateScss, paths.select2Scss],\r\n```",
"title": null,
"type": "comment"
}
] | 1 | 2 | 607 | false | false | 607 | false |
aspnet/RazorTooling | aspnet | 114,338,482 | 33 | {
"number": 33,
"repo": "RazorTooling",
"user_login": "aspnet"
} | [
{
"action": "opened",
"author": "NTaylorMullen",
"comment_id": null,
"datetime": 1446233038000,
"masked_author": "username_0",
"text": "- Previously providing the `-protocol` option would re-resolve the protocol based off the `RazorPlugin`s protocol. Now the plugin uses it verbatim and throws if it has an unknown Protocol.\r\n\r\n#31",
"title": "Remove the double protocol resolving of `resolve-taghelpers`.",
"type": "issue"
},
{
"action": "created",
"author": "NTaylorMullen",
"comment_id": 152624113,
"datetime": 1446233046000,
"masked_author": "username_0",
"text": "/cc @ToddGrun",
"title": null,
"type": "comment"
}
] | 1 | 2 | 208 | false | false | 208 | false |
commons-app/apps-android-commons | commons-app | 228,960,467 | 603 | null | [
{
"action": "opened",
"author": "sandarumk",
"comment_id": null,
"datetime": 1494925052000,
"masked_author": "username_0",
"text": "",
"title": "Use 'Retrofit' as the Android networking library.",
"type": "issue"
},
{
"action": "created",
"author": "whym",
"comment_id": 305719447,
"datetime": 1496390813000,
"masked_author": "username_1",
"text": "This is practically #492, I guess?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "veyndan",
"comment_id": 309845251,
"datetime": 1497982948000,
"masked_author": "username_2",
"text": "Yes, this issue is a duplicate.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "veyndan",
"comment_id": null,
"datetime": 1497982948000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 4 | 65 | false | false | 65 | false |
changeworld/love_equation | null | 197,462,479 | 123 | {
"number": 123,
"repo": "love_equation",
"user_login": "changeworld"
} | [
{
"action": "opened",
"author": "changeworld",
"comment_id": null,
"datetime": 1482585060000,
"masked_author": "username_0",
"text": "",
"title": "Code golf",
"type": "issue"
}
] | 2 | 2 | 274 | false | true | 0 | false |
jbox-web/redmine_git_hosting | jbox-web | 96,502,660 | 482 | null | [
{
"action": "opened",
"author": "pjouglet",
"comment_id": null,
"datetime": 1437552122000,
"masked_author": "username_0",
"text": "2015-07-21 16:42:14 +0200 [INFO] Create tmp directory : '/usr/share/redmine/tmp/redmine_git_hosting/git/gitolite-admin.git'\r\n2015-07-21 16:42:14 +0200 [INFO] Accessing gitolite-admin.git at '/usr/share/redmine/tmp/redmine_git_hosting/git/gitolite-admin.git'\r\n2015-07-21 16:42:14 +0200 [ERROR] Invalid Gitolite Admin SSH Keys\r\n2015-07-21 16:42:14 +0200 [ERROR] Failed to authenticate SSH session: Unable to open public key file\r\n2015-07-21 16:42:14 +0200 [ERROR] Problems to retrieve Gitolite hook parameters in Gitolite config 'namespace : redminegitolite'\r\n2015-07-21 16:42:14 +0200 [INFO] Set Git global parameter : redminegitolite.redmineurl (http://localhost:3000/githooks/post-receive/redmine)\r\n2015-07-21 16:42:14 +0200 [ERROR] Error while setting Git global parameter : redminegitolite.redmineurl (http://localhost:3000/githooks/post-receive/redmine)\r\n2015-07-21 16:42:14 +0200 [ERROR] Non-zero exit code pid 6784 exit 1 for `sudo -n -u git -i git config --global redminegitolite.redmineurl http://localhost:3000/githooks/post-receive/redmine`\r\n2015-07-21 16:42:14 +0200 [INFO] Set Git global parameter : redminegitolite.debugmode (false)\r\n2015-07-21 16:42:14 +0200 [ERROR] Error while setting Git global parameter : redminegitolite.debugmode (false)\r\n2015-07-21 16:42:14 +0200 [ERROR] Non-zero exit code pid 6789 exit 1 for `sudo -n -u git -i git config --global redminegitolite.debugmode false`\r\n2015-07-21 16:42:14 +0200 [INFO] Set Git global parameter : redminegitolite.asyncmode (false)\r\n2015-07-21 16:42:14 +0200 [ERROR] Error while setting Git global parameter : redminegitolite.asyncmode (false)\r\n2015-07-21 16:42:14 +0200 [ERROR] Non-zero exit code pid 6794 exit 1 for `sudo -n -u git -i git config --global redminegitolite.asyncmode false`\r\n2015-07-21 16:42:14 +0200 [INFO] Disable README creation for repositories\r\n2015-07-21 16:42:14 +0200 [INFO] Create tmp directory : '/usr/share/redmine/tmp/redmine_git_hosting/git/gitolite-admin.git'\r\n2015-07-21 16:42:14 +0200 [INFO] Accessing gitolite-admin.git at '/usr/share/redmine/tmp/redmine_git_hosting/git/gitolite-admin.git'\r\n2015-07-21 16:42:14 +0200 [ERROR] Invalid Gitolite Admin SSH Keys\r\n2015-07-21 16:42:14 +0200 [ERROR] Failed to authenticate SSH session: Unable to open public key fil\r\n\r\nI've retryed many time with documentation [documentation](http://redmine-git-hosting.io/get_started/) and always the same error :/\r\nDo you have an idea ?\r\nThanks !",
"title": "Error 500 configuration plugin",
"type": "issue"
},
{
"action": "created",
"author": "clee231",
"comment_id": 123949047,
"datetime": 1437621620000,
"masked_author": "username_1",
"text": "Well it says that your SSH keys is invalid.\r\nCan you verify that your SSH key is correct? (It should be located in: {BASE_REDMINE_DIRECTORY}/plugins/redmine_git_hosting/ssh_keys/)\r\n\r\nYou can use ssh-keygen to verify the key like so:\r\n```ssh-keygen -lf {BASE_REDMINE_DIRECTORY}/plugins/redmine_git_hosting/ssh_keys/redmine_gitolite_admin_id_rsa```\r\n\r\nThat command should output the fingerprint of the key, if it is valid. (Something like: \r\n```2048 aa:bb:cc:dd:ee:ff:00:11:22:33:44:55:66:77:88:99 redmine_gitolite_admin_id_rsa.pub```\r\n, with different hex values, obviously.)\r\n\r\nIf it is not valid, then you might want to create a new ssh key.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pjouglet",
"comment_id": 124387317,
"datetime": 1437722588000,
"masked_author": "username_0",
"text": "The authenticity of host 'localhost (::1)' can't be established.\r\nECDSA key fingerprint is 95:43:34:6d:f3:4b:0e:0f:e2:7d:c1:34:4f:56:b5:2d.\r\nAre you sure you want to continue connecting (yes/no)? yes\r\nFailed to add the host to the list of known hosts (/var/www/.ssh/known_hosts).\r\nhello redmine_gitolite_admin_id_rsa, this is git@ubuntu running gitolite3 v3.6.3-10-g4be7ac5 on git 1.9.1\r\nR W gitolite-admin\r\nR W testing\r\n\r\nMy www-data user is sudoers too :/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "n-rodriguez",
"comment_id": 124713372,
"datetime": 1437770088000,
"masked_author": "username_2",
"text": "Can you try to chmod 644 both private and public SSH keys?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pjouglet",
"comment_id": 125114776,
"datetime": 1437983650000,
"masked_author": "username_0",
"text": "Thanks for reply !\r\nI've applied chmod 644 on /usr/share/redmine/plugins/redmine_git_hosting/ssh_keys/* and on /home/git/redmine_gitolite_admin_id_rsa.pub and the problem are the same.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "clee231",
"comment_id": 125224753,
"datetime": 1438007130000,
"masked_author": "username_1",
"text": "Hmm... From the ssh-keygen test, it seem that your SSH key is valid. It also seem that your redmine user (www-data) can access them. Can you verify that your Gitolite configuration in the redmine_git_hosting plugin is correct?\r\nSpecifically, under `Administration -> Redmine Git Hosting -> SSH`. Verify that all 5 fields are correct.\r\n\r\n**Gitolite username** - Generally, this is something like `git`\r\n**Gitolite SSH private key** - This should be the **full absolute path** to your SSH admin private key. (For example: `/usr/share/redmine/plugins/redmine_git_hosting/ssh_keys/redmine_gitolite_admin_id_rsa`)\r\n**Gitolite SSH public key** - This should be the full absolute path to your SSH admin public key. (e.g. `/usr/share/redmine/plugins/redmine_git_hosting/ssh_keys/redmine_gitolite_admin_id_rsa.pub`)\r\n**SSH/Gitolite server host** - your server's domain name or IP address of where redmine & gitolite are installed on.\r\n**SSH/Gitolite server port** - Generally port 22.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pjouglet",
"comment_id": 125490227,
"datetime": 1438070280000,
"masked_author": "username_0",
"text": "and now it work o/\r\n\r\nIf you have more informations you can post it otherwise issue are close",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "n-rodriguez",
"comment_id": null,
"datetime": 1440107901000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 8 | 4,842 | false | false | 4,842 | false |
portworx/torpedo | portworx | 259,929,158 | 38 | {
"number": 38,
"repo": "torpedo",
"user_login": "portworx"
} | [
{
"action": "opened",
"author": "varunturlapati",
"comment_id": null,
"datetime": 1506112466000,
"masked_author": "username_0",
"text": "Attempt 3 to create a clean PR that doesn't have other code. This is narrowed down to crypto package pegging down plus my code changes",
"title": "Ssh after aws",
"type": "issue"
},
{
"action": "created",
"author": "varunturlapati",
"comment_id": 331557550,
"datetime": 1506113495000,
"masked_author": "username_0",
"text": "@adityadani @harsh-px \r\nFor this one I actually started with origin/master: created a new branch\r\nMerged my branch on it and pushed and created the PR",
"title": null,
"type": "comment"
}
] | 1 | 2 | 284 | false | false | 284 | false |
dockerfile/ubuntu | dockerfile | 130,209,105 | 13 | null | [
{
"action": "opened",
"author": "1605200517",
"comment_id": null,
"datetime": 1454281588000,
"masked_author": "username_0",
"text": "By default, this image uses POSIX locale settings. Maybe it could be a goof idea to make e.g. C.UTF-8 default - which is also installed but I have troubles switching inside Docker to it, need to do dpkg-reconfigure, xterm setup etc. UTF-8 should be ok as default, or?\r\n\r\nthx\r\nbest regards\r\nusername_0",
"title": "Default locale is not UTF-8",
"type": "issue"
}
] | 1 | 1 | 300 | false | false | 300 | true |
ronakg/quickr-preview.vim | null | 211,993,801 | 2 | {
"number": 2,
"repo": "quickr-preview.vim",
"user_login": "ronakg"
} | [
{
"action": "opened",
"author": "matt1003",
"comment_id": null,
"datetime": 1488756008000,
"masked_author": "username_0",
"text": "Resolves the following error when using location lists...\r\n```\r\nError detected while processing function QFList:\r\nline 1:\r\nE684: list index out of range: 0\r\nE15: Invalid expression: s:qflist[a:linenr - 1]\r\nline 4:\r\nE121: Undefined variable: l:entry\r\nE15: Invalid expression: l:entry.valid\r\nPress ENTER or type command to continue\r\n```",
"title": "Add support for location lists",
"type": "issue"
},
{
"action": "created",
"author": "ronakg",
"comment_id": 284286988,
"datetime": 1488766823000,
"masked_author": "username_1",
"text": "Thanks for the contribution.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 368 | false | false | 368 | false |
einfallstoll/express-ntlm | null | 215,885,206 | 26 | {
"number": 26,
"repo": "express-ntlm",
"user_login": "einfallstoll"
} | [
{
"action": "opened",
"author": "igor-ba",
"comment_id": null,
"datetime": 1490132054000,
"masked_author": "username_0",
"text": "First of all, let me thank your for your project, it really helped me a lot! \r\nThe improvement that I suggest covers the case where authentication was not successful, but you need to know the user name for further processing. Sure, I could also parse args for the debug function, but this additional complexity is unnecessary, if I could get the user data directly.\r\nSo what do you think on this PR?",
"title": "add user data even if connection is forbidden",
"type": "issue"
},
{
"action": "created",
"author": "einfallstoll",
"comment_id": 288359852,
"datetime": 1490179161000,
"masked_author": "username_1",
"text": "I appreciate your proposal, but I'm still undecided wether this would break backward compatibility or not. As it will call the `forbidden` function, it would just expose the NTLM-data to this function. Would someone check for `request.ntlm` in that function to see wether the module fucked up?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "igor-ba",
"comment_id": 288552519,
"datetime": 1490219812000,
"masked_author": "username_0",
"text": "This is basically the reason for the PR: to be able to check in forbidden function who failed the auth challenge. Failing to authenticate (e.g. due to typo in password) to NTLM might cause problems not only for this server, but also for file shares, corporate proxies etc. That is why I need in my case proper error message with at least user name + domain in it. \r\n\r\nRegarding the backward compatibility: this change affects only behavior of `forbidden` function, extending its parameter with additional fields. It could affect only code that explores `request` or `response` objects. I doubt that anyone puts such a complexity to the `forbidden` function.\r\n\r\nI would also be fine with introducing the user data only once as `request.ntlm` to reduce the risks. However this would make its behavior inconsistent compared to the normal case of successful authorization.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,560 | false | false | 1,560 | false |
real-logic/simple-binary-encoding | real-logic | 35,908,927 | 167 | null | [
{
"action": "opened",
"author": "tmontgomery",
"comment_id": null,
"datetime": 1403023612000,
"masked_author": "username_0",
"text": "1.0.1-RC2 has been released to maven central. Please see the changelog.",
"title": "1.0.1-RC2 released to maven",
"type": "issue"
},
{
"action": "closed",
"author": "mjpt777",
"comment_id": null,
"datetime": 1430465626000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 71 | false | false | 71 | false |
Baidu-AIP/java-sdk | Baidu-AIP | 294,607,925 | 12 | null | [
{
"action": "opened",
"author": "huangliang992",
"comment_id": null,
"datetime": 1517882920000,
"masked_author": "username_0",
"text": "实例：\r\n{\r\n \"id\":\"1\", //id\r\n \"word\":\"今天\", //word\r\n \"postag\":\"t\", //POS tag\r\n \"head\":\"2\", //id of current word's parent\r\n \"deprel\":\"ATT\" //depend relations between current word and parent\r\n },\r\n\r\n实际返回：\r\n{\r\n \"postag\": \"t\",\r\n \"deprel\": \"ATT\",\r\n \"word\": \"今天\",\r\n \"head\": 2\r\n },",
"title": "依存句法分析接口返回值中的词没有id",
"type": "issue"
},
{
"action": "created",
"author": "PeterPanZH",
"comment_id": 363296631,
"datetime": 1517886630000,
"masked_author": "username_1",
"text": "已反馈给后端模型，待修复，感谢~",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "PeterPanZH",
"comment_id": 363298249,
"datetime": 1517887277000,
"masked_author": "username_1",
"text": "@Baidu-AIP/backend",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "flyhighzy",
"comment_id": 380372640,
"datetime": 1523435635000,
"masked_author": "username_2",
"text": "预计4月底修复上线，感谢指正~",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "PeterPanZH",
"comment_id": null,
"datetime": 1532059039000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 5 | 397 | false | false | 397 | false |
fission/fission | fission | 272,458,819 | 392 | {
"number": 392,
"repo": "fission",
"user_login": "fission"
} | [
{
"action": "opened",
"author": "joshkelly",
"comment_id": null,
"datetime": 1510210650000,
"masked_author": "username_0",
"text": "Minor change of adding hostname for AWS cloud setup of fission env vars.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/fission/fission/392)\n<!-- Reviewable:end -->",
"title": "Added AWS to install cloud setup",
"type": "issue"
},
{
"action": "created",
"author": "soamvasani",
"comment_id": 344723856,
"datetime": 1510778972000,
"masked_author": "username_1",
"text": "Thanks @username_0 !",
"title": null,
"type": "comment"
}
] | 2 | 2 | 314 | false | false | 314 | true |
10up/Engineering-Best-Practices | 10up | 229,995,244 | 194 | null | [
{
"action": "opened",
"author": "jonathantneal",
"comment_id": null,
"datetime": 1495204723000,
"masked_author": "username_0",
"text": "— https://google.github.io/styleguide/htmlcssguide.html#Optional_Tags\r\n\r\nThanks for reading! Open to questions and/or let me know if you’d like help drafting up something more formal.",
"title": "Guidance on <head> and <body>",
"type": "issue"
},
{
"action": "created",
"author": "jalbertbowden",
"comment_id": 302740451,
"datetime": 1495209081000,
"masked_author": "username_1",
"text": "what about the importance of meta charset? isn't that necessary to prevent cross-site scripting, amongst other things?\r\nalso i don't see the html element in use in google's example with lang=\"\" attribute which is a necessary in my opinion. \r\nnot saying this is wrong, just confused about what exactly the point is...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathantneal",
"comment_id": 302743740,
"datetime": 1495209857000,
"masked_author": "username_0",
"text": "Google’s example is so minimal it raises the questions you ask. Let me know if these answers help.\r\n\r\nOn charsets and xss: It’s off topic of `<head>` and `<body>` but again Google’s example is so minimal. My two cents: some people add it with a `<meta>` tag, some people add it with headers, and some people add both. As long as the charset is there and it’s consistent with the content, awesome.\r\n\r\nOn lang: Google could have provided a second example where they use attributes like `<html lang=\"en\">` or `<body class=\"no-js\">` but I think they kept their example simple to make a specific point about elements developers and seo types blindly consider “sacred”.\r\n\r\nDoes that help clarify the point the Google styleguide was making?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jpdevries",
"comment_id": 302756991,
"datetime": 1495213187000,
"masked_author": "username_2",
"text": "My concern with encouraging omitting the `<html>` tag is that people will be even less likely to set the lang attribute, which should always be set. At our bootcamp we make sure students get in th habit of setting this. \r\n\r\nYes you can set lang on any attribute, but Ive never seen anyone using this \"optimization\" pattern do so. My two cents are that the reason browsers add these elements to the DOM is because they need to be there. So put them there. There are many things that are probably worth considering optimization wise before shaving a negligible amount off HTML weight.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathantneal",
"comment_id": 302775051,
"datetime": 1495217885000,
"masked_author": "username_0",
"text": "@username_2, agreed with your first point, but are you sure you are talking about my recommendation or Google’s *hardcore* example?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ivankruchkoff",
"comment_id": 302787921,
"datetime": 1495221215000,
"masked_author": "username_3",
"text": "There's a spec for html5 which specifies functionality:\r\nhttps://www.w3.org/TR/html5/document-metadata.html#the-head-element\r\n\r\nA head element's start tag may be omitted if the element is empty, or if the first thing inside the head element is an element.\r\nA head element's end tag may be omitted if the head element is not immediately followed by a space character or a comment.\r\n\r\nThere are more browsers than just Chrome and more search engines than Google, especially when you move away from the English speaking world.\r\n\r\nThat said, the takeaways here that html / head / body can be removed, what's the benefit? Slightly smaller file size?\r\n\r\nFinal point, stripping un-needed tags is probably something that can be done as minification, the same way css/js is compiled, generated html can be minified to strip unneeded tags.\r\n\r\nMy approach would be to write the full html/head/body tags and then leave tag stripping to a plugin in WP.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathantneal",
"comment_id": 302789203,
"datetime": 1495221565000,
"masked_author": "username_0",
"text": "Thanks, @ivankristianto! I hope you saw that I mentioned this behavior applies to all browsers; UC Browser, IE6, etc. The benefit is about avoiding the gotchas of `<head>`’s weakness. Not many people check the organization of their metadata, so if you find it useful to know that `<h1><p>SEO</p></h1>` is not a heading, you might also want to know the things I’ve shared about `<head>`, too. If nothing else, this will now be a search result for future generations.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jpdevries",
"comment_id": 302800810,
"datetime": 1495224914000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jalbertbowden",
"comment_id": 302805273,
"datetime": 1495226193000,
"masked_author": "username_1",
"text": "pretty sure the rendering engines go back and add them in for graceful degradation, as in correcting mistakes of the past.\r\ni think i get this now, and i can't say it is wrong, but to echo @username_2 points, too much is already overlooked and ignored by the web community as a whole. accessibility is broken practically everywhere, and this example is a jumping off point to breaking it even more, as well as breaking internationalization, which we haven't even gotten to yet.\r\nlast week i saw a bootcamp creator tweet out how his students asked him why he didn't use these two elements and his response is they don't matter. not only does that only apply in certain circumstances, its simply perpetuating this ridiculous cycle of who cares about markup and styles that is so prevalent.\r\ni know this is ranty, and i do apologize because this isn't my repo or project.\r\n\r\ni will say that i do disagree with that example being kept short to prove to google engineer's points. google is the living embodiment of html/css is an afterthought team typically, they do have a few good teams, but across the board, google's html/css is pretty bad.\r\n[take this example, for example ;) - view-source:https://google.github.io/styleguide/htmlcssguide.html#Optional_Tags](view-source:https://google.github.io/styleguide/htmlcssguide.html#Optional_Tags)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathantneal",
"comment_id": 302836701,
"datetime": 1495238999000,
"masked_author": "username_0",
"text": "@username_2, yessir, and I hope this discussion has been at the very least educational. @username_1, I think you make some great points. I like your rant! I do hope you’ve seen that `<head>` and `<body>` are optional, and I hope you’ve seen some of the issues you can run into when expecting `<head>` to work a certain way, but you are so right that we don’t want to encourage a culture of unnecessary minimalism, and we wouldn’t want developers taking this advice and throwing out any elements _they_ don’t think matter. Google’s example leans that way, but I’m a sucker for citations because I have no clout of my own! IMHO, I’d rather devs accidentally write `<button role=\"button\" type=\"button\"/>` than `<div onclick/>`. I’ll let the 10up devs determine what is best, whether it should be closed, or if you’d like me to write up anything the team _is_ comfortable with. Thanks everyone!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ivankruchkoff",
"comment_id": 303768822,
"datetime": 1495641395000,
"masked_author": "username_3",
"text": "Closing this out as I think we've looped through the full discussion on this topic. Feel free to re-open / comment if there's more to add or a relevant PR to link to.\r\n\r\nThanks @username_2, @username_1 and @username_0 for the productive discussion.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ivankruchkoff",
"comment_id": null,
"datetime": 1495641395000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "JJJ",
"comment_id": 303782352,
"datetime": 1495644236000,
"masked_author": "username_4",
"text": "This is why being explicit is so important, and why lenient interpreters don't actually do anyone any favors.\r\n\r\nBetween PHP, JavaScript, and browser rendering engines, people are accidentally encouraged to write the the loosest and sloppiest version of something that works at least once, instead of writing the best version of something that works well for everyone always.\r\n\r\nTechnically, you can build a house without electricity, and maybe that is actually what you want, but no one will come visit you.\r\n\r\nDo not omit these optional tags. 💜",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jonathantneal",
"comment_id": 303784258,
"datetime": 1495644629000,
"masked_author": "username_0",
"text": "Hmm? Why? You’ve forgotten your fact, and skipped to your conclusion. In fact, your entire post is a conclusion.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JJJ",
"comment_id": 303803500,
"datetime": 1495648767000,
"masked_author": "username_4",
"text": "I haven't forgotten anything, and your reply comes across as quite rude and uncooperative, but I'll reply assuming that isn't the case.\r\n\r\nThis is a non-issue, in search of a problem, in search of debate, which will result in no change. If you're looking for reasons to do something, you'll keep inventing them.\r\n\r\nThese tags are not optional. Rather, they are so mandatory that browsers have built-in support for when people make mistakes and forget them. This is what computers are currently good at, and what people are not good at understanding about computers.\r\n\r\n* CSS is optional.\r\n* JavaScript is optional.\r\n* html/head/title/body tags are mandatory.\r\n\r\nThe question of whether developers writing code for the web should omit those tags is like asking for permission to do a bad job, to which the answer should always be \"no.\"\r\n\r\nThe fact this is even questionable is it's own fact in my favor. If browsers didn't build in support for forgetful developers, and instead white-screened thanks to missing mandatory tags, that explicitness would have clearly communicated how important those tags are.\r\n\r\nOther opinionated non-fact best practices:\r\n* A feature built to protect user-land shouldn't be used against everyone else so that we can write a few less characters.\r\n* No page on the web will provide a good user experience without a title or relative meta tags. They're just too useful and engrained into the web experience to leave out entirely.\r\n* It's a slippery slope to code according to what is considered optional. Languages like PHP and JavaScript that started off as loose and friendly are being /improved/ to shift their biases towards implied explicivity, on their way towards more serious consequences for not being explicit.\r\n\r\n(And if you still have a problem with my lack of whatever, ping me privately. You reached out for public discussion – if you don't like what you get, ask for clarification. If your next reply is anything like your last one, I'm kindly not going to engage any further.)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jpdevries",
"comment_id": 303814882,
"datetime": 1495651303000,
"masked_author": "username_2",
"text": "I understand this discussion is about `<head>` and `<body>` and not necessarily `<html lang>`. Not trying to derail but I just want to share this because it was helpful for me to understand the important of the `lang` attribute. The problem with this:\r\n\r\n```html\r\n<!-- Recommended -->\r\n<!DOCTYPE html>\r\n<title>Saving money, saving bytes</title>\r\n<p>Qed.\r\n```\r\n\r\nIs this https://github.com/TryGhost/Casper/issues/286#issuecomment-281950302\r\n\r\nFor i18n and screen reader support the `lang` attribute should always be set, and it is my understanding that when browsers add a phantom `<html>` they don't set `lang`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JJJ",
"comment_id": 303823568,
"datetime": 1495653278000,
"masked_author": "username_4",
"text": "But we are free to display it (along with `head`) with CSS if we really wanted to be weird.\r\n\r\n```\r\n<style type=\"text/css\">head, title { display: block; color: red; text-align: center; }</style>\r\n<title>RED</title>\r\n<div>TODO everything</div>\r\n```\r\n\r\nNote that styling only the `title` tag will still leave it hidden, as the `head` tag being hidden seems to override the `title` even if `!important` is used.\r\n----\r\n\r\nTL;DR - We can do a lot of junky stuff with these elements. 💯",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tlovett1",
"comment_id": 303825796,
"datetime": 1495653817000,
"masked_author": "username_5",
"text": "Love the discussion! Thanks for posting @username_0. I think this is something to keep an eye but don't really see this being useful in our best practices.",
"title": null,
"type": "comment"
}
] | 6 | 18 | 9,758 | false | false | 9,758 | true |
puppetlabs/puppetlabs-postgresql | puppetlabs | 17,496,704 | 226 | null | [
{
"action": "opened",
"author": "direvus",
"comment_id": null,
"datetime": 1375347224000,
"masked_author": "username_0",
"text": "I am using this module under Gentoo, and most things seem to be working with a little massaging required.\n\nThe one thing that sticks out is the calls to Exec[postgresql_reload] that get triggered on changes to pg_hba. This Exec is hardcoded to use the 'service' command (see manifests/server.pp:87), which appears to be a RedHat/Debian specific thing -- at least, Gentoo doesn't have it. The correct way to reload postgres on Gentoo is e.g., `/etc/init.d/postgresql-9.2 reload`.\n\nI think this could be solved quite easily by allowing a 'reload_command' parameter to be passed into postgresql::server. Those of us who do not have a 'service' can just override it to suit.\n\nLet me know if you'd prefer me to provide a pull request, I'd be happy to do so.",
"title": "postgresql_reload depends on 'service' which is not present on all distros",
"type": "issue"
},
{
"action": "created",
"author": "chelnak",
"comment_id": 1061908153,
"datetime": 1646753695000,
"masked_author": "username_1",
"text": "Hello! We are doing some house keeping and noticed that this issue has been open for a long time.\n\nWe're going to close it but please do raise another issue if the issue still persists. 😄",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "chelnak",
"comment_id": null,
"datetime": 1646753696000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 942 | false | false | 942 | false |
NixOS/nixpkgs | NixOS | 106,152,952 | 9,825 | {
"number": 9825,
"repo": "nixpkgs",
"user_login": "NixOS"
} | [
{
"action": "opened",
"author": "ericsagnes",
"comment_id": null,
"datetime": 1442061337000,
"masked_author": "username_0",
"text": "connman:\r\n- blacklisting NixOS containers by default\r\n- added option for extra configurations\r\n\r\ndetails are in #9628\r\n\r\ncc package maintainer @username_2",
"title": "connman: improved configuration",
"type": "issue"
},
{
"action": "created",
"author": "ericsagnes",
"comment_id": 139775245,
"datetime": 1442068414000,
"masked_author": "username_0",
"text": "@copumpkin Thanks for the advice!\r\nIndeed a list of string here adds more flexibility, I updated the PR.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jagajaga",
"comment_id": 139800545,
"datetime": 1442080722000,
"masked_author": "username_1",
"text": "\"+1\"",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "matejc",
"comment_id": 139864581,
"datetime": 1442145607000,
"masked_author": "username_2",
"text": "@username_0 ok this looks great, let me try it .. if all checks out I will merge",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "matejc",
"comment_id": 139868062,
"datetime": 1442147452000,
"masked_author": "username_2",
"text": "@username_0 thanks!",
"title": null,
"type": "comment"
}
] | 3 | 5 | 357 | false | false | 357 | true |
QuantEcon/Games.jl | QuantEcon | 194,077,411 | 22 | {
"number": 22,
"repo": "Games.jl",
"user_login": "QuantEcon"
} | [
{
"action": "opened",
"author": "shizejin",
"comment_id": null,
"datetime": 1481124004000,
"masked_author": "username_0",
"text": "Add some games in \"test_pure_nash.jl\".\r\n\r\n1. Matching Pennies Game with 0 Pure Action Nash equilibrium;\r\n2. Coordination game with 2 Pure Action Nash equilibria;\r\n3. Unanimity Game with more than two players.\r\n\r\nIn the Unanimity Game, I use `combinations` from `Combinatorics`, and thus `Combinatorics` is required.",
"title": "Add some complicated games for testing \"pure_nash\".",
"type": "issue"
},
{
"action": "created",
"author": "cc7768",
"comment_id": 265588037,
"datetime": 1481148306000,
"masked_author": "username_1",
"text": "Hi @username_0. Thanks for adding these tests!\r\n\r\nIt is very useful to test the edge case that has 0 pure action nash equilibrium and a more complicated game. This should help keep us safe against breaking these functions in the future.\r\n\r\nI don't see anything I would change before merging. If @username_2 agrees then it is ready to be merged.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "oyamad",
"comment_id": 265637037,
"datetime": 1481164632000,
"masked_author": "username_2",
"text": "Looks good to me.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jstac",
"comment_id": 265637497,
"datetime": 1481164818000,
"masked_author": "username_3",
"text": "@username_0 Looks good, many thanks.",
"title": null,
"type": "comment"
}
] | 4 | 4 | 704 | false | false | 704 | true |
softdevteam/krun | softdevteam | 122,027,101 | 126 | null | [
{
"action": "opened",
"author": "vext01",
"comment_id": null,
"datetime": 1450093564000,
"masked_author": "username_0",
"text": "",
"title": "Startup sleep duration should be configurable.",
"type": "issue"
},
{
"action": "created",
"author": "vext01",
"comment_id": 192199061,
"datetime": 1457083034000,
"masked_author": "username_0",
"text": "There actually are many hard-coded parameters that could go into the config file with sensible defaults. Renamed issue to reflect this.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ltratt",
"comment_id": null,
"datetime": 1498472084000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ltratt",
"comment_id": 311019277,
"datetime": 1498472084000,
"masked_author": "username_1",
"text": "I think that we will do these on an as-needed basis (i.e. if users squeal), but we don't need to do so proactively. Closing.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 259 | false | false | 259 | false |
Microsoft/Docker-PowerShell | Microsoft | 153,500,681 | 55 | {
"number": 55,
"repo": "Docker-PowerShell",
"user_login": "Microsoft"
} | [
{
"action": "opened",
"author": "jstarks",
"comment_id": null,
"datetime": 1462555981000,
"masked_author": "username_0",
"text": "Fixes #54",
"title": "Ensure the nupkg includes all published files",
"type": "issue"
},
{
"action": "created",
"author": "jstarks",
"comment_id": 217549433,
"datetime": 1462566333000,
"masked_author": "username_0",
"text": "OK, I finally got this working with an appveyor test to ensure that the module is always loadable.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "swernli",
"comment_id": 217555613,
"datetime": 1462567940000,
"masked_author": "username_1",
"text": "LGTM",
"title": null,
"type": "comment"
}
] | 2 | 3 | 111 | false | false | 111 | false |
jaxon-php/jaxon-core | jaxon-php | 310,279,938 | 27 | null | [
{
"action": "opened",
"author": "Waxter81",
"comment_id": null,
"datetime": 1522539010000,
"masked_author": "username_0",
"text": "Configured Charset ISO-8859-1 with decode_utf8 enabled:\r\n```\r\n$jaxon->setOption('core.encoding', 'ISO-8859-1');\r\n$jaxon->setOption('core.decode_utf8', true);\r\n```\r\nI make a Jaxon Request with rq()->form(), like this:\r\n```\r\n<form id=\"formulario\">\r\n <!-- The crux of this page -->\r\n Enter your name:\r\n <input type=\"text\" name=\"username\" id=\"username\" />\r\n <input type=\"button\" value=\"Submit\" onclick=\" <?php echo rq()->call('Ajax.Test.hello',rq()->form('formulario'))?>\" />\r\n</form> \r\n```\r\n\r\nIn Request/Manager.php, there is a process() method that decodes input utf-8 parameters:\r\n```\r\n$mFunction = array(&$this, '__argumentDecodeUTF8_' . $sFunction);\r\narray_walk($this->aArgs, $mFunction);\r\n```\r\nIn my case, it's calling next method: \r\n```\r\n private function __argumentDecodeUTF8_iconv(&$mArg)\r\n {\r\n if(is_array($mArg))\r\n {\r\n foreach($mArg as $sKey => $xArg)\r\n {\r\n $sNewKey = $sKey;\r\n $this->__argumentDecodeUTF8_iconv($sNewKey);\r\n if($sNewKey != $sKey)\r\n {\r\n $mArg[$sNewKey] = $xArg;\r\n unset($mArg[$sKey]);\r\n $sKey = $sNewKey;\r\n }\r\n $this->__argumentDecodeUTF8_iconv($xArg);\r\n }\r\n }\r\n elseif(is_string($mArg))\r\n {\r\n $mArg = iconv(\"UTF-8\", $this->getOption('core.encoding') . '//TRANSLIT', $mArg);\r\n }\r\n error_log(print_r($mArg,true));\r\n }\r\n```\r\n**Previous method is not working when $mArg is an Array. It decodes ok individually each $sKey and each $xArg, but at the end of the recursive function, the arguments array stay inaltered, hasn't been decoded from utf-8.**\r\n\r\nI've fixed declaring this method instead:\r\n```\r\n private function myArgumentDecodeUTF8_iconv($mArg)\r\n {\r\n \tif(is_array($mArg)) {\r\n \t\tarray_walk_recursive($mArg, function(&$item, $key){\r\n \t\t\t$item = iconv(\"UTF-8\", $this->getOption('core.encoding') . '//TRANSLIT', $item); \t\t\t\r\n \t\t});\r\n \t}\r\n \telseif(is_string($mArg))\r\n \t{\r\n \t\t$mArg = iconv(\"UTF-8\", $this->getOption('core.encoding') . '//TRANSLIT', $mArg);\r\n \t}\r\n \t\r\n \treturn $mArg;\r\n }\r\n```\r\nAnd calling it like this: \r\n`if($sFunction == \"iconv\") $this->aArgs = $this->myArgumentDecodeUTF8_iconv($this->aArgs);`",
"title": "Decoding UTF-8 parameters from FormValues",
"type": "issue"
},
{
"action": "created",
"author": "feuzeu",
"comment_id": 378375682,
"datetime": 1522785339000,
"masked_author": "username_1",
"text": "Hi,\r\nCan you please provide some input data so I can reproduce the issue and test the fix?\r\nThanks.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Waxter81",
"comment_id": 378757142,
"datetime": 1522878752000,
"masked_author": "username_0",
"text": "test.php:\r\n```\r\n<?php \r\nheader('Content-type: text/html; charset=iso-8859-1');\r\nrequire(__DIR__ . '/jaxon/defs.php');\r\n?>\r\n\r\n<!doctype html>\r\n<html>\r\n<head></head>\r\n<body>\r\n<form id=\"formulario\">\r\n <!-- The crux of this page -->\r\n Enter your name:\r\n <input type=\"text\" name=\"username\" id=\"username\" />\r\n <input type=\"button\" value=\"Form Test\" onclick=\" <?php echo rq()->call('Ajax.Test.foo',rq()->form('formulario'))?>\" />\r\n <input type=\"button\" value=\"Select Test\" onclick=\" <?php echo rq()->call('Ajax.Test.foo',rq()->select('username'))?>\" />\r\n</form> \r\n</body>\r\n\r\n<div id=\"jaxon-code\">\r\n<?php\r\n$jaxon = jaxon();\r\necho $jaxon->getScript(true,true);\r\n?>\r\n</div>\r\n</html>\r\n```\r\nJaxon Test Class:\r\n```\r\n<?php\r\nnamespace Ajax;\r\nuse Jaxon\\Response\\Response; // and the Response class\r\n\r\nclass Test {\r\n\t\r\n\tprotected $response;\r\n\t\r\n\tpublic function __construct()\r\n\t{\r\n\t\t$this->response = new Response;\r\n\t}\r\n\tpublic function foo($param) {\r\n \t\t\r\n\t\t$response = new Response(); // Instance the response class\t\t\r\n\t\t\t\r\n\t\tif(is_array($param)) error_log($param['username']);\t\t\t\t\r\n\t\tif(is_string($param)) error_log($param);\t\t\t\t\r\n\t\t\r\n\t\treturn $response; // Return the response to the jaxon engine\r\n\t}\t\r\n}\r\n?>\r\n```\r\n\r\n# **Input Data in Form: López**\r\n\r\nTest 1: Click on \"Form Test\" button in Form.\r\nTest 2: Click on \"Select Test\" button in Form.\r\n\r\n```\r\nOutput log:\r\n[04-Apr-2018 23:42:27 Europe/Amsterdam] López\r\n[04-Apr-2018 23:42:42 Europe/Amsterdam] López\r\n```\r\n\r\nJaxon RequestManager (__argumentDecodeUTF8_iconv method) is not decoding UTF-8 to ISO-8859-1 when $this->aArgs is an Array.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 4,073 | false | false | 4,073 | false |
ccbrown/gggtracker | null | 288,973,677 | 17 | null | [
{
"action": "opened",
"author": "Kyle-Undefined",
"comment_id": null,
"datetime": 1516120770000,
"masked_author": "username_0",
"text": "Hi,\r\n\r\nWe use the GGG Tracker RSS in our Xbox Discord and noticed that the tracker doesn't have any posts from Jeff. Looking at the source, I'm assuming it's because he's not in the posters list. \r\n\r\nNormally I'd do a pull request myself, as this looks super easy, but I don't understand anything about Go and would not want to waste anyone's time with a bad pull request, so I figured making an issue would be best.\r\n\r\nJeff's profile is here: https://www.pathofexile.com/account/view-profile/Jeff_GGG\r\n\r\nThank you!",
"title": "Missing poster, Jeff_GGG",
"type": "issue"
},
{
"action": "created",
"author": "ccbrown",
"comment_id": 358117603,
"datetime": 1516139124000,
"masked_author": "username_1",
"text": "Thanks! I'll try to take care of this tonight or tomorrow.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ccbrown",
"comment_id": null,
"datetime": 1516405663000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ccbrown",
"comment_id": 359121069,
"datetime": 1516405663000,
"masked_author": "username_1",
"text": "Fixed via ebdeff62ee35b6f0dc6d7503e7523b358c45b70d. Thanks!",
"title": null,
"type": "comment"
}
] | 2 | 4 | 632 | false | false | 632 | false |
waterlink/active_record.cr | null | 145,378,907 | 47 | {
"number": 47,
"repo": "active_record.cr",
"user_login": "waterlink"
} | [
{
"action": "opened",
"author": "sdogruyol",
"comment_id": null,
"datetime": 1459607526000,
"masked_author": "username_0",
"text": "Work in progress. Don't merge yet.",
"title": "[WIP] Where IN Array support",
"type": "issue"
},
{
"action": "created",
"author": "sdogruyol",
"comment_id": 204729942,
"datetime": 1459609078000,
"masked_author": "username_0",
"text": "The specs pass on Crystal `0.14.2` but seems to fail in an unrelated place in `0.15.0`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdogruyol",
"comment_id": 204749786,
"datetime": 1459613944000,
"masked_author": "username_0",
"text": "The specs passed but actually it's not working in a real app with Postgresql. It's related to query building with params so i converted the `Array(T)` generator like below.\r\n\r\n```crystal\r\ndef _generate(query : ::Array(T), param_count = 0)\r\n query = query.map do |value|\r\n \"#{value}\"\r\n end.join(\", \")\r\n # This is later being sent to _generate(query : ::ActiveRecord::Criteria, param_count = 0)\r\n Query.new(\"(#{query})\")\r\nend\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "waterlink",
"comment_id": 204771081,
"datetime": 1459622358000,
"masked_author": "username_1",
"text": "Injecting values there directly is very \"bad idea\". Expect SQL injections.\r\n\r\nFailures with Postgres adapter should be fixed by overriding the `_generate(...)` for special cases, that need different query generation on Postgres in the `postgres_adapter.cr`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "waterlink",
"comment_id": 204771195,
"datetime": 1459622473000,
"masked_author": "username_1",
"text": "Oh, now it fails on `0.15.0` because we can't override now behavior of `!`. So we simply have to use `(...).not` now instead of `!(...)`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "waterlink",
"comment_id": 204771251,
"datetime": 1459622524000,
"masked_author": "username_1",
"text": "I will upgrade it to `0.15.0` in separate branch and make a release for it, when everything passes. After that you should rebase your commits on top of updated master branch",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdogruyol",
"comment_id": 204777319,
"datetime": 1459623095000,
"masked_author": "username_0",
"text": "@username_1 i strongly agree on that :+1: For now i'm still getting the grasp of how this all works.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "waterlink",
"comment_id": 204784398,
"datetime": 1459624635000,
"masked_author": "username_1",
"text": "Yeah, postgres adapter actually already does some overriding there: https://github.com/username_1/postgres_adapter.cr/blob/master/src/postgres_adapter.cr#L10-L15\r\n\r\nThe same overload for `Array(T)` is required I assume.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdogruyol",
"comment_id": 204784576,
"datetime": 1459624806000,
"masked_author": "username_0",
"text": "@username_1 actually the problem is that `in([1,2,3])` is turned into `Criteria` and then later the params is not being merged into the query. \r\n\r\nExample.\r\n\r\n```SELECT * FROM item_settings WHERE item_id IN (:1, :2, :3, :4)```\r\n\r\nThis gives SQL error since the syntax is not correct.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "waterlink",
"comment_id": 204784962,
"datetime": 1459625020000,
"masked_author": "username_1",
"text": "And maybe it makes sense to parametrize the code by the parameter name transformator and extract it to class of its own and re-use it from all implementations. Something like that:\r\n\r\n```crystal\r\n# in active_record\r\nclass ArrayQueryHandler\r\n def initialize(@param_name_transformer : Int32 -> String)\r\n end\r\n\r\n def handle(query : Array(T), param_count = 0)\r\n params = {} of String => T\r\n query = query.map do |value|\r\n param_count += 1\r\n params[param_count.to_s] = value\r\n @param_name_transformer.call(param_count)\r\n end.join(\", \")\r\n {Query.new(\"(#{query})\", params), param_count}\r\n end\r\nend\r\n\r\n# and usage in active_record:\r\ndef _generate(query : Array(T), param_count = 0)\r\n result, param_count = ArrayQueryHandler.new { |name| \":#{name}\" }.handle(query)\r\n result\r\nend\r\n\r\n# and usage in prosgres_adapter\r\ndef _generate(query : Array(T), param_count = 0)\r\n result, param_count = ArrayQueryHandler.new { |name| \"$#{name}\" }.handle(query)\r\n result\r\nend\r\n\r\n# see closely at the difference in the block.\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "waterlink",
"comment_id": 204785023,
"datetime": 1459625090000,
"masked_author": "username_1",
"text": "That sounds weird, it should not be converted to criteria. Could you update the branch (rebase against upstream master) and push it to github? So I can fetch it and play around to see what is happening.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdogruyol",
"comment_id": 204785282,
"datetime": 1459625183000,
"masked_author": "username_0",
"text": "@username_1 updated",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdogruyol",
"comment_id": 204788270,
"datetime": 1459626185000,
"masked_author": "username_0",
"text": "I've add `ArrayQueryHandler` like you said :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdogruyol",
"comment_id": 204789013,
"datetime": 1459626481000,
"masked_author": "username_0",
"text": "So just like you said adding below to `postgres_adapter` does it :tada: \r\n\r\n```crystal\r\ndef _generate(query : Array(T), param_count = 0)\r\n result, param_count = ::ActiveRecord::Sql::ArrayQueryHandler.new { |name| \"$#{name}\" }.handle(query)\r\n result\r\nend\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "waterlink",
"comment_id": 204789530,
"datetime": 1459626931000,
"masked_author": "username_1",
"text": "Great! I am going to merge this one then.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sdogruyol",
"comment_id": 204789683,
"datetime": 1459626978000,
"masked_author": "username_0",
"text": "Thanks a lot :heart_eyes:",
"title": null,
"type": "comment"
}
] | 2 | 16 | 3,357 | false | false | 3,357 | true |
PX4/Firmware | PX4 | 151,293,405 | 4,378 | null | [
{
"action": "opened",
"author": "priseborough",
"comment_id": null,
"datetime": 1461729224000,
"masked_author": "username_0",
"text": "Every 10th or so value of RPL1.t is zero which breaks replay.",
"title": "EKF2 replay logging is broken.",
"type": "issue"
},
{
"action": "created",
"author": "devbharat",
"comment_id": 215097505,
"datetime": 1461766531000,
"masked_author": "username_1",
"text": "@username_2 is the fix up somewhere ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "devbharat",
"comment_id": 215179738,
"datetime": 1461781063000,
"masked_author": "username_1",
"text": "I broke the replay message in separate parts for different sensors, had them all in the union except the one for IMU, which was its own struct. That solved it for me, not sure if its the best solution.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "devbharat",
"comment_id": 215234670,
"datetime": 1461792410000,
"masked_author": "username_1",
"text": "I finally have ekf2_replay working with vision on master. Something is weird though, I have to overwrite the length of LOG_ATT_MSG in ekf2_replay like this:\r\n\r\n // data message\r\n int length;\r\n if(header[2] != LOG_ATT_MSG){\r\n length = _formats[header[2]].length;\r\n } else {\r\n length = 55; // ATT has length 55, force it!\r\n }\r\n if (::read(fd, &data[0], length - 3) != length - 3) {\r\n PX4_INFO(\"Done!\");\r\n _task_should_exit = true;\r\n continue;\r\n }\r\n\r\nas the **_formats[header[2]].length** value for LOG_ATT_MSG is somehow 0, which would otherwise crash the app.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tumbili",
"comment_id": 215316150,
"datetime": 1461822546000,
"masked_author": "username_2",
"text": "@username_1 Try master now without your workaround.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tumbili",
"comment_id": null,
"datetime": 1461822547000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "devbharat",
"comment_id": 215317863,
"datetime": 1461823396000,
"masked_author": "username_1",
"text": "Are you re",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "devbharat",
"comment_id": null,
"datetime": 1461823396000,
"masked_author": "username_1",
"text": "Every 10th or so value of RPL1.t is zero which breaks replay.",
"title": "EKF2 replay logging is broken.",
"type": "issue"
},
{
"action": "created",
"author": "tumbili",
"comment_id": 215318986,
"datetime": 1461823916000,
"masked_author": "username_2",
"text": "@username_1 Yes, I tried and I get no messages like that.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "devbharat",
"comment_id": 215319545,
"datetime": 1461824167000,
"masked_author": "username_1",
"text": "OK, I'll diff the sdlog2 app with master and check then",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tumbili",
"comment_id": null,
"datetime": 1462294774000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "zubair123khan",
"comment_id": 227215068,
"datetime": 1466444590000,
"masked_author": "username_3",
"text": "hello guys, i need to replay a log and when i am running replay on it, its throwing me error that no rule to make this file, although i am in right directory. \r\nplease help me out with this..",
"title": null,
"type": "comment"
}
] | 4 | 12 | 1,334 | false | false | 1,334 | true |
JuliaDiff/ForwardDiff.jl | JuliaDiff | 207,016,325 | 191 | {
"number": 191,
"repo": "ForwardDiff.jl",
"user_login": "JuliaDiff"
} | [
{
"action": "opened",
"author": "yuyichao",
"comment_id": null,
"datetime": 1486855973000,
"masked_author": "username_0",
"text": "Local tests pass on 0.4 and 0.5. I'm assuming @ararslan [will have `a branch that should fix it` on 0.6](https://github.com/JuliaStats/StatsBase.jl/pull/235#issuecomment-279183388).",
"title": "Fix 0.6 abstract type declaration depwarn",
"type": "issue"
},
{
"action": "created",
"author": "yuyichao",
"comment_id": 280883267,
"datetime": 1487460821000,
"masked_author": "username_0",
"text": "Ping. I think this can be merged without #192?",
"title": null,
"type": "comment"
}
] | 1 | 2 | 227 | false | false | 227 | false |
theislab/anndata | theislab | 276,131,748 | 3 | null | [
{
"action": "opened",
"author": "flying-sheep",
"comment_id": null,
"datetime": 1511368371000,
"masked_author": "username_0",
"text": "This here:\r\n\r\nhttps://github.com/theislab/anndata/blob/38c500dc8e9becd4c78a82897dea5febcdb9e0a4/anndata/anndata.py#L669\r\n\r\nwould e.g. be nicer as\r\n\r\n```py\r\ndef concatenate(self, *adatas, batch_key='batch', batch_categories=None):\r\n ...\r\n```",
"title": "Use splats in API",
"type": "issue"
},
{
"action": "created",
"author": "falexwolf",
"comment_id": 348753022,
"datetime": 1512295024000,
"masked_author": "username_1",
"text": "I agree that splats are nicer... and they have been used in Scanpy since the very first lines, e.g. \r\nhttps://github.com/theislab/scanpy/blob/218a2cb53c4fdb4cd834efc5a8ff6fcaabf16d91/scanpy/logging.py#L47\r\n\r\nHowever, both pandas and numpy don't use it in their concat function \r\n([np](https://docs.scipy.org/doc/numpy/reference/generated/numpy.concatenate.html#numpy.concatenate), [pd](https://pandas.pydata.org/pandas-docs/stable/generated/pandas.concat.html)) and I took these as the model for AnnDatas concat function.\r\n\r\nHence, I'm not sure whether we should deviate from this - I think we should be as close as possible to numpy and pandas whenever it's not completely outrageous.\r\n\r\nPS: The Scanpy users are often not very python experienced, and they are used to passing lists without a splat star (`*alist`) also in many other places, like plotting an AnnData with several colors\r\n```\r\nsc.pl.scatter(adata, color=['anno1', 'anno2', 'anno3'])\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "flying-sheep",
"comment_id": 348801685,
"datetime": 1512324131000,
"masked_author": "username_0",
"text": "i see. that’s unfortunate, since numpy’s API [is confusing](https://stackoverflow.com/questions/9236926/concatenating-two-one-dimensional-numpy-arrays) for newbies as well.\r\n\r\nso we’re stuck between a rock and a hard place: be confusing for python beginners or be confusing for numpy-experienced users.\r\n\r\ni think that a good error message goes a long way – using splats means the user can’t pass further arguments by position but only by keyword (which is a good thing), and we could provide either a custom error message, or special handling of sequences being passed as only positional argument, like:\r\n\r\n```py\r\ndef concatenate(*adatas, batch_key='batch', batch_categories=None):\r\n if len(adatas) == 1 and not isinstance(adatas[0], AnnData):\r\n try: # convert iterable into tuple\r\n adatas = tuple(adatas[0])\r\n except Exception:\r\n pass\r\n```",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "falexwolf",
"comment_id": null,
"datetime": 1533025066000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 2,078 | false | false | 2,078 | false |
dangrossman/daterangepicker | null | 212,704,649 | 1,413 | null | [
{
"action": "opened",
"author": "manderson23",
"comment_id": null,
"datetime": 1488971253000,
"masked_author": "username_0",
"text": "My picker is configured as follows\r\n```\r\n$('#config-demo').daterangepicker({\r\n \"timePicker\": true,\r\n \"timePickerSeconds\": true,\r\n \"dateLimit\": {\r\n \"minutes\": 1\r\n },\r\n \"locale\": {\r\n \"format\": \"YYYY-MM-DD HH:mm:ss\"\r\n },\r\n \"startDate\": moment().startOf('second').subtract(1, 'minutes'),\r\n \"endDate\": moment().startOf('second'),\r\n \"autoUpdateInput\": true,\r\n }, function(start, end, label) {\r\n console.log(\"New date range selected: ' + start.format('YYYY-MM-DD') + ' to ' + end.format('YYYY-MM-DD') + ' (predefined range: ' + label + ')\");\r\n});\r\n```\r\n\r\n1. My picker displays as follows:\r\n\r\n\r\n\r\n2. I open the picker and select a new minute value for the start time. The time picker combos for the end time update as expected given the dateLimit but the formatted end date/time does not.\r\n\r\n\r\n\r\n3. I click apply. The start date/time updates as expected but the end date/time is unchanged.\r\n\r\n",
"title": "End Date/Time doesn't update when only minute of start time changed and dateLimit of 1 minute configured",
"type": "issue"
},
{
"action": "closed",
"author": "dangrossman",
"comment_id": null,
"datetime": 1524975884000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 1,249 | false | false | 1,249 | false |
rust-lang/libc | rust-lang | 124,143,024 | 117 | {
"number": 117,
"repo": "libc",
"user_login": "rust-lang"
} | [
{
"action": "opened",
"author": "mneumann",
"comment_id": null,
"datetime": 1451347158000,
"masked_author": "username_0",
"text": "Move FreeBSD's stat into freebsd_{x86,x86_64}.rs.",
"title": "DragonFly has different stat, dirent, clock_t, ino_t, nlink_t, blksize_t",
"type": "issue"
},
{
"action": "created",
"author": "mneumann",
"comment_id": 186584848,
"datetime": 1455971832000,
"masked_author": "username_0",
"text": "As this pull-request became stale, I opened up a new one (https://github.com/rust-lang/libc/pull/194) which fixes all current issues. Closing this one.",
"title": null,
"type": "comment"
}
] | 1 | 2 | 200 | false | false | 200 | false |
Microsoft/ILMerge | Microsoft | 304,967,646 | 38 | null | [
{
"action": "opened",
"author": "glenn-slayden",
"comment_id": null,
"datetime": 1520982587000,
"masked_author": "username_0",
"text": "https://github.com/Microsoft/ILMerge/blob/4a40a63205eaad5b9876254b70c71ac326d5600c/System.Compiler/Duplicator.cs#L603<pre>extra char, should be \"CodeContracts\" ------^ </pre>\r\n\r\n\r\nOk elsewhere in the same file:\r\n\r\nhttps://github.com/Microsoft/ILMerge/blob/4a40a63205eaad5b9876254b70c71ac326d5600c/System.Compiler/Duplicator.cs#L95",
"title": "Typo in '#if' macro symbol",
"type": "issue"
}
] | 1 | 1 | 331 | false | false | 331 | false |
AlmuraDev/SGCraft | AlmuraDev | 300,701,835 | 7 | null | [
{
"action": "opened",
"author": "Dockter",
"comment_id": null,
"datetime": 1519749100000,
"masked_author": "username_0",
"text": "Idea, implement an auto-dialer handheld device to store stargate addresses.\r\n\r\nThis would allow users the ability to travel to gates without having to remember the address.",
"title": "Auto-Dialer handheld device",
"type": "issue"
},
{
"action": "created",
"author": "ZyorTaelon",
"comment_id": 400971497,
"datetime": 1530177809000,
"masked_author": "username_1",
"text": "There's a computercraft program that can also be run on the handheld device.\r\nhttp://www.computercraft.info/forums2/index.php?/topic/16656-lanteacraft-sgcraft-ccdhd/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Dockter",
"comment_id": 401085176,
"datetime": 1530201552000,
"masked_author": "username_0",
"text": "That would require the Compucraft mod which I dont want to implement at this time.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ZyorTaelon",
"comment_id": 401092560,
"datetime": 1530202965000,
"masked_author": "username_1",
"text": "There's no need to implement anything. It's already compiled even. Just add the jar to your mods folder and tada... handheld dialer.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ZyorTaelon",
"comment_id": 401095577,
"datetime": 1530203553000,
"masked_author": "username_1",
"text": "Open Computers has a similar dialing program.\r\n\r\nThe thing is. The Stargates were intended to be dialed by DHD. If you watch the movie and tv show you'll notice the SGC had to connect unrelated computers to the stargate in order to dial it without a DHD. Same goes for this mod :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Dockter",
"comment_id": 469789870,
"datetime": 1551809398000,
"masked_author": "username_0",
"text": "I have a working prototype for this, its awesome.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Quisquid",
"comment_id": 469822395,
"datetime": 1551813649000,
"masked_author": "username_2",
"text": "I am curious about it! \r\nBut is it possible to disable it in the config for someone who is using Computercraft/OpenComputers on his server? Like me? gg",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Dockter",
"comment_id": 469827834,
"datetime": 1551814583000,
"masked_author": "username_0",
"text": "Yes, very much so. I am also introducing a \"Admin Configurator Tool\" that will allow you to configure every single option of a unique stargate. No longer will the gates have a global config that controls all of them. They will inherit the global config option is either they are a new gate or its requested they inherit them. Otherwise you'll be able to configure everything. You would be surprised all the configuration options that exist per stargate that currently are not configurable in the base configs. That is going to change.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "PowellA12",
"comment_id": 469855145,
"datetime": 1551819616000,
"masked_author": "username_3",
"text": "woot woot woot will you be able to set the address for the stargate?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Dockter",
"comment_id": 469859666,
"datetime": 1551820475000,
"masked_author": "username_0",
"text": "No, you will not be able to set the address. That is a mathematical computation that is used to assign all gate addresses. Changing that system would destroy the gate system as we know it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "PowellA12",
"comment_id": 469910815,
"datetime": 1551830816000,
"masked_author": "username_3",
"text": "k do you have the mathematical computation in equation form?\r\nnot in java script form \r\n-i have tried reading the files involved i have not understood how it gets the address it does",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Dockter",
"comment_id": null,
"datetime": 1552404975000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "Dockter",
"comment_id": 472052060,
"datetime": 1552404975000,
"masked_author": "username_0",
"text": "This feature has been implemented.",
"title": null,
"type": "comment"
}
] | 4 | 13 | 2,045 | false | false | 2,045 | false |
billysometimes/rethinkdb | null | 110,307,983 | 32 | null | [
{
"action": "opened",
"author": "artiifix",
"comment_id": null,
"datetime": 1444249181000,
"masked_author": "username_0",
"text": "I have tried the following query in the Data Explorer:\r\n```js\r\nr.db('test').table('teams').get(\"c525f3e4-4aff-4423-b85c-e9ac9a1f7738\").update({\r\n 'members': {'d429f4f3-edd0-41a5-a981-39e5db507760': {\r\n 'role': r.row('members')('d429f4f3-edd0-41a5-a981-39e5db507760')('role').default('user')\r\n }}\r\n})\r\n```\r\nand it works. I then translated it to Dart:\r\n```dart\r\nMap response = await r.table('teams').get(teamId).update({\r\n 'members': {user.id: {'role': r.row('members')(user.id)('role').rqlDefault('user')}}\r\n}).run(connection);\r\n```\r\nBut sadly this throws a `RqlCompileError`:\r\n```\r\nr.row is not defined in this context.\r\n```\r\nThis is the data I use:\r\n```js\r\nr.db('test').table('teams').insert([\r\n {\r\n 'creatorId': 'd429f4f3-edd0-41a5-a981-39e5db507760',\r\n 'id': 'c525f3e4-4aff-4423-b85c-e9ac9a1f7738',\r\n 'members': {\r\n '5cff7d1c-e0c1-4d45-84d3-1001ef08af0d': { role: 'user' },\r\n '85257fce-9bd7-4b31-9d50-ca2f626a04e5': { role: 'user' },\r\n 'd429f4f3-edd0-41a5-a981-39e5db507760': { role: 'admin' }\r\n },\r\n 'name': 'Team Conner'\r\n }\r\n }\r\n])",
"title": "Query that runs in Data Explorer but won't compile in Dart",
"type": "issue"
},
{
"action": "created",
"author": "billysometimes",
"comment_id": 146420044,
"datetime": 1444280297000,
"masked_author": "username_1",
"text": "Thanks for filing! Should be fixed now, the function short-cut r.row wasn't getting wrapped properly.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "billysometimes",
"comment_id": null,
"datetime": 1444322408000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,179 | false | false | 1,179 | false |
aspnet/Caching | aspnet | 128,032,109 | 144 | null | [
{
"action": "opened",
"author": "victorhurdugaci",
"comment_id": null,
"datetime": 1453414313000,
"masked_author": "username_0",
"text": "",
"title": "Convert the sql-cache command to dotnet",
"type": "issue"
},
{
"action": "closed",
"author": "cesarbs",
"comment_id": null,
"datetime": 1454459871000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 0 | false | false | 0 | false |
ManageIQ/manageiq | ManageIQ | 163,432,786 | 9,577 | {
"number": 9577,
"repo": "manageiq",
"user_login": "ManageIQ"
} | [
{
"action": "opened",
"author": "NickLaMuro",
"comment_id": null,
"datetime": 1467391301000,
"masked_author": "username_0",
"text": "Purpose or Intent\n-----------------\nUpdate to newest version of Rails to get us to the official 5.0 release.\n\n\nLinks\n-----\n* https://github.com/fixlr/codemirror-rails\n* https://github.com/fixlr/codemirror-rails/pull/49\n* https://github.com/rails/jbuilder/blob/master/CHANGELOG.md\n\n\nSteps for Testing/QA\n--------------------\n* This is a large jump for codemirror as far as minor releases goes, so we should make sure there are no issues with that.\n* jbuilder also got an update, though the test suite should probably be covering that.",
"title": "Upgrade to gem release of Rails 5.0",
"type": "issue"
},
{
"action": "created",
"author": "himdel",
"comment_id": 230250287,
"datetime": 1467625472000,
"masked_author": "username_1",
"text": "Verified that codemirror 5.11 seems to behave sanely in the UI..",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "himdel",
"comment_id": 230250809,
"datetime": 1467625625000,
"masked_author": "username_1",
"text": "Note for people using the `quiet_assets` gem in their local `Gemfile.dev.rb` .. it's deprecated, and will cause `bundle update` to fail .. but it can be replaced with a `Rails.application.config.assets.quiet = true` line somewhere in `config/initializers/*.rb`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "NickLaMuro",
"comment_id": 230501890,
"datetime": 1467730406000,
"masked_author": "username_0",
"text": "@Fryguy with the release of the new `codemirror-rails` gem, I think that closes out most of the reservations with merging this PR.\r\n\r\nAlso, is this something that needs to get merged into darga, or is #9563 good enough?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrisarcand",
"comment_id": 230516295,
"datetime": 1467733251000,
"masked_author": "username_2",
"text": "I would like to see this in Darga; I don't think relying on a hosted release candidate for a stable release of MIQ is a wise idea in the long run. @username_3 ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chessbyte",
"comment_id": 230522018,
"datetime": 1467734405000,
"masked_author": "username_3",
"text": "@username_2 I am all for backporting to Darga, BUT **first** it has to be merged on master. :-)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrisarcand",
"comment_id": 230528255,
"datetime": 1467735774000,
"masked_author": "username_2",
"text": "Code changes look solid, Martin verified codemirror... LGTM 👍",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jrafanie",
"comment_id": 230568686,
"datetime": 1467744755000,
"masked_author": "username_4",
"text": "🎉 👏",
"title": null,
"type": "comment"
}
] | 6 | 12 | 2,945 | false | true | 1,396 | true |
matrix-org/matrix-appservice-irc | matrix-org | 325,586,724 | 582 | null | [
{
"action": "opened",
"author": "shirishag75",
"comment_id": null,
"datetime": 1527061521000,
"masked_author": "username_0",
"text": "currently the irc bridges just tells you have joined a specific server or bunch of servers but doesn't give any info. as to what software and version is running by the specific server. \r\n\r\nWe get info. like http://paste.debian.net/1026060/ \r\n\r\nbut that doesn't tell much about the irc server you have joined.",
"title": "there should be a way to know ircd software and version running when joining a server. ",
"type": "issue"
},
{
"action": "created",
"author": "erdnaxeli",
"comment_id": 391260297,
"datetime": 1527063183000,
"masked_author": "username_1",
"text": "I think in this room the MOTD should be forwarded, and any other global messages.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shirishag75",
"comment_id": 391271067,
"datetime": 1527065407000,
"masked_author": "username_0",
"text": "it would be nice if that is implemented, we would at least get some more info. than nothing atm.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 485 | false | false | 485 | false |
d3sw/floop | d3sw | 252,096,251 | 9 | null | [
{
"action": "opened",
"author": "setcheverry",
"comment_id": null,
"datetime": 1503437627000,
"masked_author": "username_0",
"text": "## Expected Behavior\r\nFloop should be able to use service discovery. The configuration should have a flag that indicates is service discovery is needed for the domain to where we need to send the state of the job.\r\n\r\n## Current Behavior\r\nFloop doesn't support service discovery.\r\n\r\n## Possible Solution\r\nUse https://github.com/username_1/go-srv-resolver to add this functionality to floop.\r\n\r\n## Context\r\nWhen a service to report to is deployed using Docker then it URI will change over time. By adding service discovery to Floop, it will be able to report progress even if the uri of the service changes.\r\n\r\n## Your Environment\r\n* Product Version: v0.1.0\r\n* OS and OS Version: CentOS release 6.9 (2.6.32-696.6.3.el6.x86_64)",
"title": "Service discovery for Floop",
"type": "issue"
},
{
"action": "created",
"author": "euforia",
"comment_id": 326344597,
"datetime": 1504195603000,
"masked_author": "username_1",
"text": "We could add a top level config variable or just use DNS based service discovery by default and revert back to using regular DNS queries in the event of failure. Any thoughts?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "toddschilling",
"comment_id": 326345752,
"datetime": 1504195856000,
"masked_author": "username_2",
"text": "I was thinking about that too. At first I thought we'd use a configuration variable, but adding configuration when we don't need to might make the product overly complex to use in the long run. I think maybe just use DNS to do an SRV query and automatically revert to an A query if SRV doesn't return anything.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "toddschilling",
"comment_id": null,
"datetime": 1504195856000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "reopened",
"author": "toddschilling",
"comment_id": null,
"datetime": 1504195949000,
"masked_author": "username_2",
"text": "## Expected Behavior\r\nFloop should be able to use service discovery. The configuration should have a flag that indicates if service discovery is needed for the domain to where floop needs to send the state of a job.\r\n\r\n## Current Behavior\r\nFloop doesn't support service discovery.\r\n\r\n## Possible Solution\r\nUse https://github.com/username_1/go-srv-resolver to add this functionality to floop.\r\n\r\n## Context\r\nWhen a service to report to is deployed using Docker then it URI will change over time. By adding service discovery to Floop, it will be able to report progress even if the uri of the service changes.\r\n\r\n## Your Environment\r\n* Product Version: v0.1.0\r\n* OS and OS Version: CentOS release 6.9 (2.6.32-696.6.3.el6.x86_64)",
"title": "Service discovery for Floop",
"type": "issue"
},
{
"action": "closed",
"author": "metroidprototype",
"comment_id": null,
"datetime": 1505313303000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "metroidprototype",
"comment_id": 329187655,
"datetime": 1505313303000,
"masked_author": "username_3",
"text": "resolved with PR #11",
"title": null,
"type": "comment"
}
] | 4 | 7 | 1,952 | false | false | 1,952 | true |
18F/crime-data-explorer | 18F | 221,838,402 | 31 | null | [
{
"action": "opened",
"author": "AvivaOskow",
"comment_id": null,
"datetime": 1492186031000,
"masked_author": "username_0",
"text": "",
"title": "Explore new design for header",
"type": "issue"
},
{
"action": "created",
"author": "AvivaOskow",
"comment_id": 294186555,
"datetime": 1492187658000,
"masked_author": "username_0",
"text": "Examples:\nhttps://www.simple.com/\n\nhttps://login.gov/security/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AvivaOskow",
"comment_id": 294187048,
"datetime": 1492187821000,
"masked_author": "username_0",
"text": "<img width=\"1276\" alt=\"screen shot 2017-04-14 at 12 11 45 pm\" src=\"https://cloud.githubusercontent.com/assets/21244661/25049271/09843bd2-210f-11e7-8e83-86654a22efec.png\">\r\n\r\n\r\n<img width=\"1190\" alt=\"screen shot 2017-04-14 at 12 11 56 pm\" src=\"https://cloud.githubusercontent.com/assets/21244661/25049272/0d953da2-210f-11e7-8fbc-79c5bae21b12.png\">",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AvivaOskow",
"comment_id": 294524674,
"datetime": 1492447373000,
"masked_author": "username_0",
"text": "@username_1 @brendansudol what do you think about something like this?\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "amberwreed",
"comment_id": 305044464,
"datetime": 1496189510000,
"masked_author": "username_1",
"text": "@username_0 Although it seems low priority, I like the idea of exploring more options for the underline. Let's discuss some things to try quickly and go from there.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "AvivaOskow",
"comment_id": null,
"datetime": 1498681045000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 773 | false | false | 773 | true |
sdl/ecommerce-framework | sdl | 192,323,099 | 5 | null | [
{
"action": "opened",
"author": "jhorsman",
"comment_id": null,
"datetime": 1480435421000,
"masked_author": "username_0",
"text": "The E-Commerce framework is making assumptions on the publication names when running the cms-import.ps1. It would be nice if a developer could provide a publication mapping to instruct the script to use another publication. \r\n\r\nI.e. \"200 Example Content\" -> \"200 Global Content\"\r\n\r\nSee https://github.com/sdl/dxa-content-management/issues/6",
"title": "cms-import.ps1 publication mapping",
"type": "issue"
}
] | 1 | 1 | 340 | false | false | 340 | false |
SUSE/azurectl | SUSE | 139,905,884 | 100 | {
"number": 100,
"repo": "azurectl",
"user_login": "SUSE"
} | [
{
"action": "opened",
"author": "schaefi",
"comment_id": null,
"datetime": 1457620760000,
"masked_author": "username_0",
"text": "When instantiating a new VM, we create a disk file with the\r\nname '_instance', in the selected storage container. Since\r\nstorage files have unique names an additional uniq id information\r\nis required to allow creation of multiple vm's from the same image\r\nin a selected region and container. This fixes #99",
"title": "Create a uniq disk identifier on vm create",
"type": "issue"
},
{
"action": "created",
"author": "schaefi",
"comment_id": 195243161,
"datetime": 1457683278000,
"masked_author": "username_0",
"text": "ok I was concerned about a length limitation, I'm going to change it",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "schaefi",
"comment_id": 195260790,
"datetime": 1457685935000,
"masked_author": "username_0",
"text": "I stumbled over a small problem in one of the unit test, this is just a one liner fix which I think is ok to handle here too",
"title": null,
"type": "comment"
}
] | 1 | 3 | 498 | false | false | 498 | false |
openshift/origin | openshift | 226,179,200 | 14,039 | null | [
{
"action": "opened",
"author": "bparees",
"comment_id": null,
"datetime": 1493874667000,
"masked_author": "username_0",
"text": "with what should be a valid master-config for the build default admission controller:\r\n\r\n```\r\nadmissionConfig:\r\n pluginConfig:\r\n BuildDefaults:\r\n configuration:\r\n apiVersion: v1\r\n env:\r\n - name: test2\r\n value: value2\r\n kind: BuildDefaultsConfig\r\n resources:\r\n limits:\r\n cpu: \"400m\"\r\n memory: \"600Mi\"\r\n requests:\r\n cpu: \"300m\"\r\n memory: \"400Mi\"\r\n```\r\n\r\nthe master fails to start with:\r\n\r\n```\r\nF0504 00:37:55.308957 7210 start_master.go:743] Could not start build controller: env[0].name: Required value\r\n```\r\n\r\nbecause the validation of the bulid defaulter env section fails.\r\n\r\nsetting the env \"name\" field to \"Name\" works around this issue, but that should not be necessary.",
"title": "build defaulter admission controller config loading is broken",
"type": "issue"
},
{
"action": "created",
"author": "bparees",
"comment_id": 299098295,
"datetime": 1493874743000,
"masked_author": "username_0",
"text": "i think this https://github.com/openshift/origin/blob/master/pkg/build/admission/defaults/api/v1/types.go#L5\r\n\r\nshould have been an import of the v1 package. not sure why this just broke now though... perhaps rebase related?",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,022 | false | true | 1,022 | false |
hazelcast/hazelcast | hazelcast | 253,143,288 | 11,237 | null | [
{
"action": "opened",
"author": "pveentjer",
"comment_id": null,
"datetime": 1503813242000,
"masked_author": "username_0",
"text": "If a system loads a lot of data and needs to build up a large index, then the client will run into problems. It isn't a good out of the box experience because effectively it means that we can't rely on loading a lot of data.",
"title": "client: Slow database loads broken",
"type": "issue"
},
{
"action": "created",
"author": "mdogan",
"comment_id": 329432876,
"datetime": 1505382718000,
"masked_author": "username_1",
"text": "I didn't understand what this issue is about. Is it MapLoader, Hazelcast client or something else? Can you show a sample?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mdogan",
"comment_id": 329433028,
"datetime": 1505382752000,
"masked_author": "username_1",
"text": "Also if this is *Critical*, why is it postponed?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mmedenjak",
"comment_id": 329446257,
"datetime": 1505386267000,
"masked_author": "username_2",
"text": "Seems more like a core issue that affects client calls - a slow database load can cause `get` calls to timeout",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mmedenjak",
"comment_id": 356568751,
"datetime": 1515581846000,
"masked_author": "username_2",
"text": "Offloading map loader seems a pretty big task. I'm keen on having a PRD for this. cc @burakcelebi",
"title": null,
"type": "comment"
}
] | 3 | 5 | 600 | false | false | 600 | false |
rubykube/peatio | rubykube | 293,639,252 | 432 | null | [
{
"action": "opened",
"author": "mangeshgangwar",
"comment_id": null,
"datetime": 1517510329000,
"masked_author": "username_0",
"text": "Hi is there any way to make peatio fully responsive so that it can be viewed on mobile devices as well.\r\n\r\nThanks",
"title": "Responsive issue",
"type": "issue"
},
{
"action": "created",
"author": "sang-tech",
"comment_id": 362832287,
"datetime": 1517676478000,
"masked_author": "username_1",
"text": "short answer, yes.\r\n\r\nThe front end styling is completely separate from the back end mechanics. \r\n\r\nTechnically you could restyle the exisiting with ccs or create a whole new front end. I'm toying with both ideas now but i need to sort out my admin access issue first...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sang-tech",
"comment_id": 362832486,
"datetime": 1517676569000,
"masked_author": "username_1",
"text": "more specifically i will be working on a responsive front-end either way as soon as i have the technical issue sorted out.\r\n\r\ndetails to follow...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yivo",
"comment_id": 362852226,
"datetime": 1517690173000,
"masked_author": "username_2",
"text": "Hello @username_1 @username_0 \r\n\r\nWe have plans for recoding UI to Bootstrap 4 or som SPA framework like React.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mangeshgangwar",
"comment_id": 363148274,
"datetime": 1517849916000,
"masked_author": "username_0",
"text": "@username_2 Thanks Thats great..",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "yivo",
"comment_id": null,
"datetime": 1517947755000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 6 | 669 | false | false | 669 | true |
meganz/sdk | meganz | 204,611,012 | 545 | {
"number": 545,
"repo": "sdk",
"user_login": "meganz"
} | [
{
"action": "opened",
"author": "sergiohs84",
"comment_id": null,
"datetime": 1485962115000,
"masked_author": "username_0",
"text": "",
"title": "Add creation date to chat data",
"type": "issue"
},
{
"action": "created",
"author": "sergiohs84",
"comment_id": 278589164,
"datetime": 1486632266000,
"masked_author": "username_0",
"text": "trigger compilation",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "polmr",
"comment_id": 281706727,
"datetime": 1487778184000,
"masked_author": "username_1",
"text": "trigger compilation",
"title": null,
"type": "comment"
}
] | 3 | 10 | 350 | false | true | 38 | false |
mdehoog/Semantic-UI-Calendar | null | 199,520,628 | 30 | null | [
{
"action": "opened",
"author": "suhaboncukcu",
"comment_id": null,
"datetime": 1483958187000,
"masked_author": "username_0",
"text": "Hi! Thanks for your awesome work. \r\n\r\nI would like to set intervals for minutes in my app. Right now a user can pick time with 5 mins intervals. I would like to set it to 15 mins for example. or 30 mins in some cases.",
"title": "No way to show different minute intervals. ",
"type": "issue"
},
{
"action": "created",
"author": "mdehoog",
"comment_id": 271272271,
"datetime": 1483964720000,
"masked_author": "username_1",
"text": "Please see #16",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mdehoog",
"comment_id": null,
"datetime": 1483964720000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 231 | false | false | 231 | false |
prebid/prebid.github.io | prebid | 291,152,806 | 566 | {
"number": 566,
"repo": "prebid.github.io",
"user_login": "prebid"
} | [
{
"action": "opened",
"author": "dimashirokov",
"comment_id": null,
"datetime": 1516788957000,
"masked_author": "username_0",
"text": "https://github.com/prebid/Prebid.js/pull/1985",
"title": "Xendiz bid adaptor docs",
"type": "issue"
},
{
"action": "created",
"author": "mkendall07",
"comment_id": 362453594,
"datetime": 1517533522000,
"masked_author": "username_1",
"text": "@username_0 \r\nplease add `prebid_1_0_supported : true` to the header. Thanks",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dimashirokov",
"comment_id": 363801313,
"datetime": 1518016692000,
"masked_author": "username_0",
"text": "@username_1 Done",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rmloveland",
"comment_id": 365410338,
"datetime": 1518557344000,
"masked_author": "username_2",
"text": "Should be showing up on [the Downloads page](http://prebid.org/download.html) soon, thanks @username_0 !",
"title": null,
"type": "comment"
}
] | 3 | 4 | 245 | false | false | 245 | true |
ionic-team/ionic | ionic-team | 141,817,634 | 5,875 | null | [
{
"action": "opened",
"author": "davyzhang",
"comment_id": null,
"datetime": 1458294040000,
"masked_author": "username_0",
"text": "Forum link https://forum.ionicframework.com/t/poor-performance-with-ionic-2-tabs-and-segments-on-ios/45886/4\n#### Short description of the problem:\n\nSegment buttons in tabs ionic2 project can be very slow to switch on iphone\n#### What behavior are you expecting?\n\nsmoothly just like tabs\n\n**Steps to reproduce:**\n1. ionic start tabs --v2 --ts\n2. add segment with two tabs\n3. build & run on iphone\n\n```\ninsert any relevant code between the above and below backticks\n```\n\n**Other information:** (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)\n\n**Which Ionic Version?** 1.x or 2.x\n2.x beta\n\n**Run `ionic info` from terminal/cmd prompt:** (paste output below)\n\nYour system information:\n\nCordova CLI: 6.0.0\nGulp version: CLI version 3.9.0\nGulp local: Local version 3.9.1\nIonic Version: 2.0.0-beta.3\nIonic CLI Version: 2.0.0-beta.19\nIonic App Lib Version: 2.0.0-beta.9\nios-deploy version: 1.8.5 \nios-sim version: 5.0.3 \nOS: Mac OS X El Capitan\nNode Version: v4.2.1\nXcode version: Xcode 7.2 Build version 7C68",
"title": "Segment can be very slow on ios",
"type": "issue"
},
{
"action": "created",
"author": "mikamboo",
"comment_id": 310986991,
"datetime": 1498463231000,
"masked_author": "username_1",
"text": "Hello,\r\n\r\nSame problem for me with segments component on ios.",
"title": null,
"type": "comment"
}
] | 3 | 3 | 1,360 | false | true | 1,116 | false |
raceup/website | raceup | 286,059,596 | 8 | null | [
{
"action": "opened",
"author": "sirfoga",
"comment_id": null,
"datetime": 1515087286000,
"masked_author": "username_0",
"text": "Countdown: impostare 2 sezioni per mettere 2 Countdown (uno per gli Eventi uno per le competizioni)\r\n\r\n- [howto](https://www.elegantthemes.com/blog/divi-resources/how-to-create-a-countdown-timer-with-a-full-screen-background-video)\r\n- [idea](http://www.f1countdown.com/)",
"title": "Events countdown",
"type": "issue"
},
{
"action": "created",
"author": "sirfoga",
"comment_id": 357503034,
"datetime": 1515926848000,
"masked_author": "username_0",
"text": "fixed in #9",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "sirfoga",
"comment_id": null,
"datetime": 1515926854000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 281 | false | false | 281 | false |
greybax/cordova-plugin-proguard | null | 284,782,829 | 2 | null | [
{
"action": "opened",
"author": "bofe",
"comment_id": null,
"datetime": 1514403199000,
"masked_author": "username_0",
"text": "The latest version of the android platform for Cordova, when used in combination with this plugin, makes an app to crash on startup.",
"title": "Plugin makes app crash on startup using Cordova Android Platform 7.0.0",
"type": "issue"
},
{
"action": "created",
"author": "greybax",
"comment_id": 354281180,
"datetime": 1514464175000,
"masked_author": "username_1",
"text": "@username_0 please specify which errors did you get",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bofe",
"comment_id": 354293746,
"datetime": 1514470087000,
"masked_author": "username_0",
"text": "Sorry, here's the logcat:\r\n\r\n```\r\n12-28 10:58:04.757 11968 11968 I CordovaLog: Changing log level to DEBUG(3)\r\n12-28 10:58:04.757 11968 11968 I CordovaActivity: Apache Cordova native platform version 7.0.0 is starting\r\n12-28 10:58:04.757 11968 11968 D CordovaActivity: CordovaActivity.onCreate()\r\n12-28 10:58:04.761 11968 11968 D AndroidRuntime: Shutting down VM\r\n--------- beginning of crash\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: FATAL EXCEPTION: main\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: Process: com.testapp.username_0, PID: 11968\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.testapp.username_0/com.testapp.username_0.MainActivity}: java.lang.RuntimeException: Failed to create webview. \r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2426)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2490)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat android.app.ActivityThread.-wrap11(ActivityThread.java)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat android.app.ActivityThread$H.handleMessage(ActivityThread.java:1354)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat android.os.Handler.dispatchMessage(Handler.java:102)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat android.os.Looper.loop(Looper.java:148)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat android.app.ActivityThread.main(ActivityThread.java:5443)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat java.lang.reflect.Method.invoke(Native Method)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:728)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: Caused by: java.lang.RuntimeException: Failed to create webview. \r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat org.a.a.s.a(Unknown Source)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat org.a.a.f.e(Unknown Source)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat org.a.a.f.d(Unknown Source)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat org.a.a.f.a(Unknown Source)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat org.a.a.f.a(Unknown Source)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat com.testapp.username_0.MainActivity.onCreate(Unknown Source)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat android.app.Activity.performCreate(Activity.java:6245)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1130)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2379)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \t... 9 more\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: Caused by: java.lang.NoSuchMethodException: <init> [class android.content.Context, class org.a.a.o]\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat java.lang.Class.getConstructor(Class.java:528)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \tat java.lang.Class.getConstructor(Class.java:492)\r\n12-28 10:58:04.766 11968 11968 E AndroidRuntime: \t... 18 more\r\n12-28 10:58:04.785 2261 4294 W ActivityManager: Force finishing activity com.testapp.username_0/.MainActivity\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "greybax",
"comment_id": 354499835,
"datetime": 1514581170000,
"masked_author": "username_1",
"text": "not sure that this is exception because of plugin. Nowhere mentioned about this plugin in logs..",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bofe",
"comment_id": 354769854,
"datetime": 1514900903000,
"masked_author": "username_0",
"text": "It's easy to reproduce. Create a new android project in Cordova (make sure it's the latest Cordova Android Platform, 7.0.0). \r\n\r\nWithout the plugin, it runs perfectly.\r\nAdd the plugin, and it crashes on start.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GuilleOr",
"comment_id": 357303638,
"datetime": 1515778581000,
"masked_author": "username_2",
"text": "Hey username_1.\r\nSame thing happens to me!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "action7777",
"comment_id": 360092005,
"datetime": 1516790757000,
"masked_author": "username_3",
"text": "Confirming issues with your plugin and Cordova Android Platform 7. Without plugin app works perfectly, after installing plugin - black screen on app start, nothing in debug log.\r\nLooks like some project structure paths changed in Cordova Android Platform 7 and this causing troubles.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "erkutalakus",
"comment_id": 364961301,
"datetime": 1518450084000,
"masked_author": "username_4",
"text": "same problem here!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "greybax",
"comment_id": null,
"datetime": 1540249048000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "greybax",
"comment_id": 432023297,
"datetime": 1540249820000,
"masked_author": "username_1",
"text": "merged PR and bumped npm package to v2.0.0",
"title": null,
"type": "comment"
}
] | 5 | 10 | 4,384 | false | false | 4,384 | true |
netprotections/atonecon-ios | netprotections | 239,387,784 | 22 | null | [
{
"action": "opened",
"author": "at-thinhung",
"comment_id": null,
"datetime": 1498720936000,
"masked_author": "username_0",
"text": "### Summary (Required)\r\nParent task: #8 \r\nMake release framework document\r\n### Description (Required)\r\n- This document explains how to install and use the library\r\n\r\n### Acceptance Criteria (Optional)\r\n- The document is very easy to understand for shop's developers\r\n- The document has full guideline\r\n\r\n### References (Optional)\r\n- Refer how to another framework create document like this",
"title": "Make release framework document",
"type": "issue"
},
{
"action": "closed",
"author": "at-thinhung",
"comment_id": null,
"datetime": 1506590864000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 389 | false | false | 389 | false |
rubykube/barong | rubykube | 339,165,798 | 562 | null | [
{
"action": "opened",
"author": "frivolous106",
"comment_id": null,
"datetime": 1530988190000,
"masked_author": "username_0",
"text": "I have set config info in secret.yml.\r\nI am using with Twilio full account.\r\nI confirmed whether the info was set in code exactly.\r\nAlso on Twilio dashboard page, when requesting the message to the phone number, i receive the message on my phone.\r\nBut i cannot receive any sms code from Barong.\r\nI am using Barong 1.8-stable.\r\nThe rubykube peatio and barong disappoints me more and more.\r\nI am waiting this solution now.",
"title": "The server Barong(1.8-stable) doesnot send sms code at all.",
"type": "issue"
},
{
"action": "created",
"author": "frivolous106",
"comment_id": 403240392,
"datetime": 1530994524000,
"masked_author": "username_0",
"text": "I fixed this issue by myself.\r\nThe barong code has a error.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "frivolous106",
"comment_id": null,
"datetime": 1530997343000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ianeinser",
"comment_id": 407367743,
"datetime": 1532430307000,
"masked_author": "username_1",
"text": "@username_0 have you successfully configured email verification? mind sharing to us?",
"title": null,
"type": "comment"
}
] | 2 | 4 | 565 | false | false | 565 | true |
pharo-vcs/iceberg | pharo-vcs | 322,080,691 | 775 | null | [
{
"action": "opened",
"author": "jecisc",
"comment_id": null,
"datetime": 1525985512000,
"masked_author": "username_0",
"text": "**OS**\r\n\r\nWindows 7\r\n\r\n**Pharo**\r\n\r\nBuild information: Pharo-7.0+alpha.build.863.sha.794a5428eb0aa4d4413eb7e979f9651ec76be461 (32 Bit)\r\n\r\n**Iceberg**\r\n\r\nv0.7.5\r\n\r\n**Problem**\r\n\r\nI wanted to review this PR: https://github.com/pharo-project/pharo/pull/1331\r\n\r\nI opened the PR View windows of the Pharo repository, selected the one from sven and tried to review.\r\n\r\nI only got an empty window.\r\n\r\n",
"title": "Reviewing a PR is broken",
"type": "issue"
},
{
"action": "created",
"author": "bencoman",
"comment_id": 419724680,
"datetime": 1536507890000,
"masked_author": "username_1",
"text": "==> an empty window titled \"Browsing pull request: #98....\" appeared...\r\n",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "guillep",
"comment_id": null,
"datetime": 1540983812000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 3 | 709 | false | false | 709 | false |
dssg/triage | dssg | 283,058,556 | 345 | null | [
{
"action": "opened",
"author": "tweddielin",
"comment_id": null,
"datetime": 1513640668000,
"masked_author": "username_0",
"text": "",
"title": "Change the input of update_metric_filters to be separate arguments instead of a list of dictionary ",
"type": "issue"
},
{
"action": "closed",
"author": "thcrock",
"comment_id": null,
"datetime": 1516382039000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 0 | false | false | 0 | false |
VeliovGroup/Meteor-Files | VeliovGroup | 216,969,304 | 390 | null | [
{
"action": "opened",
"author": "achtan",
"comment_id": null,
"datetime": 1490442884000,
"masked_author": "username_0",
"text": "i want custom path for original image for example:\r\n````js\r\nconst path = fileRef._storagePath + \"/\" + fileRef.meta.postId + \"/\" + fileRef._id + \".\" + fileRef.extension;\r\n````\r\nis it possible to set this path before upload? or i should just move my file after upload?",
"title": "how to modify path of original image ?",
"type": "issue"
},
{
"action": "created",
"author": "dr-dimitru",
"comment_id": 289252206,
"datetime": 1490492964000,
"masked_author": "username_1",
"text": "Hello @username_0 ,\r\n\r\nMake `storagePath` a *Function*. See [relative thread](https://github.com/VeliovGroup/Meteor-Files/issues/317)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "achtan",
"comment_id": 289260727,
"datetime": 1490508160000,
"masked_author": "username_0",
"text": "thansk",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "achtan",
"comment_id": null,
"datetime": 1490508160000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 401 | false | false | 401 | true |
passport/express-4.x-facebook-example | passport | 192,512,758 | 9 | null | [
{
"action": "opened",
"author": "mmkal",
"comment_id": null,
"datetime": 1480497340000,
"masked_author": "username_0",
"text": "I realise this may be a little out of scope for a passport-facebook demo, but I think it'd make sense to have an example of how you could do storage in a database. Of course it wouldn't be worth setting up a real, persistent database, but it'd be a nice way to give the idea of _what_ to store by using a POJO. I'm coming to this reasonably new to node development, so the less comments I see that say things like \"you wouldn't do it this way in a production-ready app\", the better. You could probably get rid of most of those comment paragraphs above serialize- and deserializeUser that way too. \n\nPossible solution:\n\n```JavaScript\n// In a real app, you would use a regular database. \n// Using an in-memory dictionary here as a demo. \nvar database = {};\n...\npassport.use(new FacebookStrategy({\n clientID: FACEBOOK_APP_ID,\n clientSecret: FACEBOOK_APP_SECRET,\n callbackURL: \"http://localhost:3000/auth/facebook/callback\"\n },\n function(accessToken, refreshToken, profile, cb) {\n database[profile.id] = profile;\n cb(null, user);\n }\n));\n...\npassport.serializeUser(function(user, cb) {\n cb(null, user.id);\n});\n\npassport.deserializeUser(function(id, cb) {\n cb(null, database[id]);\n});\n```\n\nFor those of us with quite a lot of flexibility, not much context, and who just want to find the \"normal way\" to implement Facebook login, this would make it much easier to reason about where to drop in our data storage solution. \n\nIf you'd be receptive, I'd be happy to submit something like the above as a pull request?",
"title": "Add in user storage example ",
"type": "issue"
},
{
"action": "created",
"author": "jaredhanson",
"comment_id": 866159055,
"datetime": 1624380735000,
"masked_author": "username_1",
"text": "The example has been updated to include user storage using SQLite.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jaredhanson",
"comment_id": null,
"datetime": 1624380736000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,591 | false | false | 1,591 | false |
williaster/data-ui | null | 260,734,188 | 56 | {
"number": 56,
"repo": "data-ui",
"user_login": "williaster"
} | [
{
"action": "opened",
"author": "conglei",
"comment_id": null,
"datetime": 1506452614000,
"masked_author": "username_0",
"text": "Added new network library.",
"title": "Conglei graph",
"type": "issue"
},
{
"action": "created",
"author": "conglei",
"comment_id": 332540062,
"datetime": 1506522602000,
"masked_author": "username_0",
"text": "Changes done :) working on writting the test. Should I push the commit of the test file here?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "williaster",
"comment_id": 332593324,
"datetime": 1506532789000,
"masked_author": "username_1",
"text": "yep all commits should be pushed!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "conglei",
"comment_id": 332680438,
"datetime": 1506553594000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "williaster",
"comment_id": 332910073,
"datetime": 1506620304000,
"masked_author": "username_1",
"text": "Great thanks @username_0! \r\n\r\nwill merge and cut a release, and we can iterate on functionality if needed from there 🎉 it still might be useful for this to move back to @vx at some point (cc @username_2) but let's dog food it a bit first.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hshoff",
"comment_id": 332910368,
"datetime": 1506620374000,
"masked_author": "username_2",
"text": "Great work @username_0!",
"title": null,
"type": "comment"
}
] | 4 | 22 | 5,251 | false | true | 515 | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.