repo stringlengths 7 67 | org stringlengths 2 32 ⌀ | issue_id int64 780k 941M | issue_number int64 1 134k | pull_request dict | events list | user_count int64 1 77 | event_count int64 1 192 | text_size int64 0 329k | bot_issue bool 1 class | modified_by_bot bool 2 classes | text_size_no_bots int64 0 279k | modified_usernames bool 2 classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
Mailu/Mailu | Mailu | 377,061,294 | 702 | {
"number": 702,
"repo": "Mailu",
"user_login": "Mailu"
} | [
{
"action": "opened",
"author": "dani909",
"comment_id": null,
"datetime": 1541256673000,
"masked_author": "username_0",
"text": "Allow prefixing docker images as they may collide with other images.\r\nFor example the nginx image may collide with another nginx image on some personal docker hub accounts.\r\n\r\nThis PR allows setting an image prefix so\r\n`DOCKER_ORG=someuser DOCKER_PREFIX=mailu- docker-compose ...`\r\nwould tag the nginx image as `someuser/mailu-nginx` and it will not collide anymore and states that it is intended for use with Mailu.\r\n\r\nIn case nothing is provided for `DOCKER_PREFIX` it will obviously tag it as before.",
"title": "Add docker image prefix",
"type": "issue"
},
{
"action": "created",
"author": "muhlemmer",
"comment_id": 437295564,
"datetime": 1541754340000,
"masked_author": "username_1",
"text": "Note to self: templates for setup utility need adjustment to reflect this change.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hoellen",
"comment_id": 444609968,
"datetime": 1544037735000,
"masked_author": "username_2",
"text": "Resolved the merge conflict.",
"title": null,
"type": "comment"
}
] | 3 | 3 | 612 | false | false | 612 | false |
nficano/pytube | null | 398,822,694 | 353 | null | [
{
"action": "opened",
"author": "scalloty",
"comment_id": null,
"datetime": 1547461051000,
"masked_author": "username_0",
"text": "",
"title": "pytube.exceptions.RegexMatchError ",
"type": "issue"
},
{
"action": "created",
"author": "The-Judge",
"comment_id": 454159269,
"datetime": 1547499574000,
"masked_author": "username_1",
"text": "Experiencing the same with https://www.youtube.com/watch?v=YGpmxFj0yd4",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mbeltre",
"comment_id": 454475331,
"datetime": 1547572762000,
"masked_author": "username_2",
"text": "same here with https://www.youtube.com/watch?v=FrrsTi6M8_Q",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dbolya",
"comment_id": 455116197,
"datetime": 1547719826000,
"masked_author": "username_3",
"text": "Here's a fix:\r\n\r\nIn cypher.py, change pattern starting at line 38 to this:\r\n```Python\r\n pattern = [\r\n r'([\"\\'])signature\\1\\s*,\\s*(?P<sig>[a-zA-Z0-9$]+)\\(',\r\n r'\\.sig\\|\\|(?P<sig>[a-zA-Z0-9$]+)\\(',\r\n r'yt\\.akamaized\\.net/\\)\\s*\\|\\|\\s*.*?\\s*c\\s*&&\\s*d\\.set\\([^,]+\\s*,\\s*(?:encodeURIComponent\\s*\\()?(?P<sig>[a-zA-Z0-9$]+)\\(',\r\n r'\\bc\\s*&&\\s*d\\.set\\([^,]+\\s*,\\s*(?:encodeURIComponent\\s*\\()?\\s*(?P<sig>[a-zA-Z0-9$]+)\\(',\r\n r'\\bc\\s*&&\\s*d\\.set\\([^,]+\\s*,\\s*\\([^)]*\\)\\s*\\(\\s*(?P<sig>[a-zA-Z0-9$]+)\\(',\r\n ]\r\n```\r\n\r\n(these regexes come from [here](https://github.com/rg3/youtube-dl/commit/fa4ac365f69cbd51e4c9801984ebea49a12825b7))\r\n\r\nThen the regex_search function in helper.py seems to only use the first regex in the list for some reason, so we also need to fix that. Simplest way is to replace\r\n```Python\r\n raise RegexMatchError(\r\n 'regex pattern ({pattern}) had zero matches'\r\n .format(pattern=p),\r\n )\r\n```\r\nin helpers.py on line 39 with\r\n```Python\r\n if p == pattern[-1]:\r\n raise RegexMatchError(\r\n 'regex pattern ({pattern}) had zero matches'\r\n .format(pattern=p),\r\n )\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "The-Judge",
"comment_id": 457361257,
"datetime": 1548364889000,
"masked_author": "username_1",
"text": "That file refered to is named ``cipher.py``, for those who are puzzled.\r\n\r\nFor me, that change fixes it, too.\r\n\r\nHere's what @username_3 described as a patch:\r\n\r\n```\r\ndiff --git a/pytube/cipher.py b/pytube/cipher.py\r\nindex e048d1f..3db0a4c 100644\r\n--- a/pytube/cipher.py\r\n+++ b/pytube/cipher.py\r\n@@ -36,10 +36,11 @@ def get_initial_function_name(js):\r\n \"\"\"\r\n # c&&d.set(\"signature\", EE(c));\r\n pattern = [\r\n- r'yt\\.akamaized\\.net/\\)\\s*\\|\\|\\s*'\r\n- r'.*?\\s*c\\s*&&\\s*d\\.set\\([^,]+\\s*,\\s*(?P<sig>[a-zA-Z0-9$]+)\\(',\r\n+ r'([\"\\'])signature\\1\\s*,\\s*(?P<sig>[a-zA-Z0-9$]+)\\(',\r\n r'\\.sig\\|\\|(?P<sig>[a-zA-Z0-9$]+)\\(',\r\n- r'\\bc\\s*&&\\s*d\\.set\\([^,]+\\s*,\\s*(?P<sig>[a-zA-Z0-9$]+)\\(',\r\n+ r'yt\\.akamaized\\.net/\\)\\s*\\|\\|\\s*.*?\\s*c\\s*&&\\s*d\\.set\\([^,]+\\s*,\\s*(?:encodeURIComponent\\s*\\()?(?P<sig>[a-zA-Z0-9$]+)\\(',\r\n+ r'\\bc\\s*&&\\s*d\\.set\\([^,]+\\s*,\\s*(?:encodeURIComponent\\s*\\()?\\s*(?P<sig>[a-zA-Z0-9$]+)\\(',\r\n+ r'\\bc\\s*&&\\s*d\\.set\\([^,]+\\s*,\\s*\\([^)]*\\)\\s*\\(\\s*(?P<sig>[a-zA-Z0-9$]+)\\(',\r\n ]\r\n logger.debug('finding initial function name')\r\n return regex_search(pattern, js, group=1)\r\ndiff --git a/pytube/helpers.py b/pytube/helpers.py\r\nindex 93351a9..aeef190 100644\r\n--- a/pytube/helpers.py\r\n+++ b/pytube/helpers.py\r\n@@ -36,10 +36,11 @@ def regex_search(pattern, string, groups=False, group=None, flags=0):\r\n regex = re.compile(p, flags)\r\n results = regex.search(string)\r\n if not results:\r\n- raise RegexMatchError(\r\n- 'regex pattern ({pattern}) had zero matches'\r\n- .format(pattern=p),\r\n- )\r\n+ if p == pattern[-1]:\r\n+ raise RegexMatchError(\r\n+ 'regex pattern ({pattern}) had zero matches'\r\n+ .format(pattern=p),\r\n+ )\r\n else:\r\n logger.debug(\r\n 'finished regex search: %s',\r\n```\r\n\r\nWhen will this be implemented?? ;)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "peterrenshaw",
"comment_id": 457967856,
"datetime": 1548634808000,
"masked_author": "username_4",
"text": "@dboyla change works for me, excellent explanation.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "formazione",
"comment_id": 511217611,
"datetime": 1563122586000,
"masked_author": "username_5",
"text": "I have the same error in version 9.5.1, I tryed to do what username_3 suggested, but it does not work.",
"title": null,
"type": "comment"
}
] | 7 | 9 | 3,766 | false | true | 3,594 | true |
dita4publishers/org.dita4publishers.html5 | dita4publishers | 264,312,006 | 68 | null | [
{
"action": "opened",
"author": "nosaj3",
"comment_id": null,
"datetime": 1507656369000,
"masked_author": "username_0",
"text": "I'm getting a fatal error when attempting to process a map that includes nested topics with short descriptions. The same set of topics is succeeding when I unnest them. The error I receive is:\r\n\r\n`Error: Fatal error during transformation using /Users/jason.davis/Sandbox/test/tools/dita-ot/plugins/org.dita4publishers.html5/xsl/map2html5.xsl: A sequence of more than one item is not allowed as the first argument of normalize-space() (\"Test HWX Concept\", \"Short description stuff\") ; SystemID: file:/Users/jason.davis/Sandbox/test/tools/dita-ot/plugins/org.dita4publishers.html5/xsl/commonHtmlExtensionSupport.xsl; Line#: 469; Column#: -1`\r\n\r\n**d4p plugin version:** dita4publishers-toolkit-plugins-1.0.0RC26-ot-2.4\r\n**dita ot version:** 2.5.3\r\n**Sample of succeeding and failing project:** [test.zip](https://github.com/dita4publishers/org.dita4publishers.html5/files/1372770/test.zip)",
"title": "Build produces fatal error when processing nested topics with short descriptions",
"type": "issue"
},
{
"action": "created",
"author": "nosaj3",
"comment_id": 336913847,
"datetime": 1508165920000,
"masked_author": "username_0",
"text": "This code appears to be the culprit and seems problematic:\r\n\r\n`<xsl:apply-templates select=\".\" mode=\"related-links:group-unordered-links\">\r\n <xsl:with-param name=\"nodes\" select=\"descendant::*[contains(@class, ' topic/link ')]\r\n [count(. | key('omit-from-unordered-links', 1)) != count(key('omit-from-unordered-links', 1))]\r\n [generate-id(.)=generate-id((key('hideduplicates', concat(ancestor::*[contains(@class, ' topic/related-links ')]/parent::*[contains(@class, ' topic/topic ')]/@id, ' ',@href,@scope,@audience,@platform,@product,@otherprops,@rev,@type,normalize-space(child::*))))[1])]\"/>\r\n </xsl:apply-templates>`\r\n\r\nThis apply templates instruction is attempting to process a sequence of items through a normalize space function. If I limit this instruction to just one item:\r\n\r\n`normalize-space(child::*[1]))))[1])]\"`\r\n\r\nMy builds no longer fail. Obviously, this isn't a viable fix to the issue as it just essentially kicks the can down the road that it introduces potential problems with related links. This begs the question: why are short descriptions caught up in processing of potential related links?",
"title": null,
"type": "comment"
}
] | 1 | 2 | 2,024 | false | false | 2,024 | false |
DenHeadless/DTTableViewManager | null | 285,096,267 | 57 | null | [
{
"action": "opened",
"author": "iomark",
"comment_id": null,
"datetime": 1514555316000,
"masked_author": "username_0",
"text": "",
"title": "Version 6.1.0-beta.1 is not compiled from original source files",
"type": "issue"
},
{
"action": "closed",
"author": "DenHeadless",
"comment_id": null,
"datetime": 1514564148000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "DenHeadless",
"comment_id": 354465907,
"datetime": 1514564148000,
"masked_author": "username_1",
"text": "Hey!\r\n\r\nIt looks like you didn't run `carthage update` before compiling Example project. The mentioned API appeared in DTModelStorage 7.0.0-beta.1, on which DTTableViewManager 6.1.0-beta.1 depends on.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 340 | false | false | 340 | false |
mephux/komanda | null | 38,861,862 | 185 | null | [
{
"action": "opened",
"author": "rahatarmanahmed",
"comment_id": null,
"datetime": 1406524062000,
"masked_author": "username_0",
"text": "If you drag and drop an image onto the window, the window will only display that image, and must be force closed. Need to handle drag and drop events so this doesn't happen.",
"title": "Drag and drop navigates away from Komanda",
"type": "issue"
},
{
"action": "created",
"author": "solancer",
"comment_id": 163439404,
"datetime": 1449704847000,
"masked_author": "username_1",
"text": "Yes this is confirmed and still continues to happen.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 225 | false | false | 225 | false |
y-lohse/inkjs | null | 350,876,832 | 201 | {
"number": 201,
"repo": "inkjs",
"user_login": "y-lohse"
} | [
{
"action": "opened",
"author": "joethephish",
"comment_id": null,
"datetime": 1534350611000,
"masked_author": "username_0",
"text": "",
"title": "Typo fixes in callstack.js (fixes #200)",
"type": "issue"
},
{
"action": "created",
"author": "y-lohse",
"comment_id": 413498344,
"datetime": 1534415174000,
"masked_author": "username_1",
"text": "Thanks! That must have been annoying to find…",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joethephish",
"comment_id": 413503367,
"datetime": 1534416392000,
"masked_author": "username_0",
"text": "Naah not too bad actually. I debugged C# and JS side by side, and when I found the JS version of that var was undefined, I did a search for it and the instances in Callstack were missing in the search results :)",
"title": null,
"type": "comment"
}
] | 2 | 3 | 256 | false | false | 256 | false |
saltstack/salt | saltstack | 182,535,627 | 36,940 | null | [
{
"action": "opened",
"author": "aronneagu",
"comment_id": null,
"datetime": 1476281361000,
"masked_author": "username_0",
"text": "### Description of Issue/Question\r\nI am trying to run `salt <target> state.highstate` but I get the error \"Salt request timed out. The master is not responding. If this error persists after verifying the master is up, worker_threads may need to be increased. \" or \"Minion did not return. [No response]\". We have worker_threads the default value (5).\r\n\r\nWe are running 15 salt-minion EC2 instances with a salt-master running on t2.medium EC2 instance.\r\nI tried restarting the salt-master service but I still receive this error. When I run command `salt '*' test.ping` only some of the minions return, the others return the error above (No response), and never the same minions fail to reply on consecutive calls. Even after I connect to the minion and restart the service, test.ping returns \"Minion did not return. [No response]\".\r\n\r\nWhen I do manage to run state.highstate the return is \r\n```\r\n The minion function caused an exception: Traceback (most recent call last):\r\n File \"/usr/lib/python2.7/dist-packages/salt/minion.py\", line 1332, in _thread_return\r\n return_data = executor.execute()\r\n File \"/usr/lib/python2.7/dist-packages/salt/executors/direct_call.py\", line 28, in execute\r\n return self.func(*self.args, **self.kwargs)\r\n File \"/usr/lib/python2.7/dist-packages/salt/modules/state.py\", line 707, in highstate\r\n mocked=kwargs.get('mock', False))\r\n File \"/usr/lib/python2.7/dist-packages/salt/state.py\", line 3350, in __init__\r\n loader=loader)\r\n File \"/usr/lib/python2.7/dist-packages/salt/state.py\", line 657, in __init__\r\n self.opts['pillar'] = self._gather_pillar()\r\n File \"/usr/lib/python2.7/dist-packages/salt/state.py\", line 699, in _gather_pillar\r\n ret = pillar.compile_pillar()\r\n File \"/usr/lib/python2.7/dist-packages/salt/pillar/__init__.py\", line 170, in compile_pillar\r\n dictkey='pillar',\r\n File \"/usr/lib/python2.7/dist-packages/salt/utils/async.py\", line 75, in wrap\r\n ret = self._block_future(ret)\r\n File \"/usr/lib/python2.7/dist-packages/salt/utils/async.py\", line 85, in _block_future\r\n return future.result()\r\n File \"/usr/lib/python2.7/dist-packages/tornado/concurrent.py\", line 215, in result\r\n raise_exc_info(self._exc_info)\r\n File \"/usr/lib/python2.7/dist-packages/tornado/gen.py\", line 876, in run\r\n yielded = self.gen.throw(*exc_info)\r\n File \"/usr/lib/python2.7/dist-packages/salt/transport/zeromq.py\", line 188, in crypted_transfer_decode_dictentry\r\n tries=tries,\r\n File \"/usr/lib/python2.7/dist-packages/tornado/gen.py\", line 870, in run\r\n value = future.result()\r\n File \"/usr/lib/python2.7/dist-packages/tornado/concurrent.py\", line 215, in result\r\n raise_exc_info(self._exc_info)\r\n File \"<string>\", line 3, in raise_exc_info\r\n SaltReqTimeoutError: Message timed out\r\n```\r\nWhat could be causing this, or how can further troubleshoot this?\r\n\r\n### Setup\r\n(Please provide relevant configs and/or SLS files (Be sure to remove sensitive info).)\r\n\r\n### Steps to Reproduce Issue\r\n(Include debug logs if possible and relevant.)\r\n\r\n### Versions Report\r\n(Provided by running `salt --versions-report`. Please also mention any differences in master/minion versions.)\r\n```\r\nSalt Version:\r\n Salt: 2016.3.3\r\n \r\nDependency Versions:\r\n cffi: Not Installed\r\n cherrypy: 3.2.2\r\n dateutil: 2.5.2\r\n gitdb: 0.5.4\r\n gitpython: 0.3.2 RC1\r\n ioflo: Not Installed\r\n Jinja2: 2.7.2\r\n libgit2: Not Installed\r\n libnacl: Not Installed\r\n M2Crypto: 0.21.1\r\n Mako: 0.9.1\r\n msgpack-pure: Not Installed\r\n msgpack-python: 0.4.6\r\n mysql-python: 1.2.3\r\n pycparser: Not Installed\r\n pycrypto: 2.6.1\r\n pygit2: Not Installed\r\n Python: 2.7.6 (default, Jun 22 2015, 17:58:13)\r\n python-gnupg: Not Installed\r\n PyYAML: 3.10\r\n PyZMQ: 14.0.1\r\n RAET: Not Installed\r\n smmap: 0.8.2\r\n timelib: Not Installed\r\n Tornado: 4.2.1\r\n ZMQ: 4.0.4\r\n \r\nSystem Versions:\r\n dist: Ubuntu 14.04 trusty\r\n machine: x86_64\r\n release: 3.13.0-48-generic\r\n system: Linux\r\n version: Ubuntu 14.04 trusty\r\n```",
"title": "Salt request timed out. The master is not responding. If this error persists after verifying the master is up, worker_threads may need to be increased.",
"type": "issue"
},
{
"action": "created",
"author": "aronneagu",
"comment_id": 253225938,
"datetime": 1476281818000,
"masked_author": "username_0",
"text": "I forgot to mention that I tried increasing the worker_threads up to 10 and it didn't help.\r\n`salt '*' test.ping` returned the error\r\n`Salt request timed out. The master is not responding. If this error persists after verifying the master is up, worker_threads may need to be increased.`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ch3LL",
"comment_id": 253328267,
"datetime": 1476303834000,
"masked_author": "username_1",
"text": "@username_0 For the `\"Minion did not return. [No response]\"` error please ensure there is no network slowness or issues between the minion and masters. Also please set `log_level: debug` in the master and minion that will give us some more information in general. But the minion did not return a lot of times is telling of a network issue.\r\n\r\nAlso can you check `top` to see if maybe there is a resource issue? Thanks",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "buildmaster-nyansa",
"comment_id": 253519062,
"datetime": 1476366733000,
"masked_author": "username_2",
"text": "+1 \r\n\r\nThis seems like the same [issue](https://github.com/saltstack/salt/issues/36932) I am facing. I am using Boron as well for the master and slave. And after the upgrade, slave cannot connect to master. I am also completely **blocked!**\r\n\r\n## Salt Master Version\r\n```shell\r\n# salt --versions-report\r\nSalt Version:\r\n Salt: 2016.3.3\r\n \r\nDependency Versions:\r\n cffi: Not Installed\r\n cherrypy: Not Installed\r\n dateutil: 1.5\r\n gitdb: 0.5.4\r\n gitpython: 0.3.2 RC1\r\n ioflo: Not Installed\r\n Jinja2: 2.7.2\r\n libgit2: Not Installed\r\n libnacl: Not Installed\r\n M2Crypto: 0.21.1\r\n Mako: 0.9.1\r\n msgpack-pure: Not Installed\r\n msgpack-python: 0.3.0\r\n mysql-python: 1.2.3\r\n pycparser: Not Installed\r\n pycrypto: 2.6.1\r\n pygit2: Not Installed\r\n Python: 2.7.6 (default, Jun 22 2015, 17:58:13)\r\n python-gnupg: Not Installed\r\n PyYAML: 3.10\r\n PyZMQ: 14.0.1\r\n RAET: Not Installed\r\n smmap: 0.8.2\r\n timelib: Not Installed\r\n Tornado: 4.2.1\r\n ZMQ: 4.0.4\r\n \r\nSystem Versions:\r\n dist: Ubuntu 14.04 trusty\r\n machine: x86_64\r\n release: 3.13.0-92-generic\r\n system: Linux\r\n version: Ubuntu 14.04 trusty\r\n\r\n```\r\n\r\n## Salt Minion Version\r\n```bash\r\n$ sudo salt-minion --version\r\nsalt-minion 2015.5.3 (Lithium)\r\n```\r\n\r\nAll of the minions not able to establish contact with master over ZMQ. Even the ones spun up using the upgraded salt:\r\n\r\n```bash\r\n$ sudo salt-minion -l debug\r\n[DEBUG ] Reading configuration from /etc/salt/minion\r\n[DEBUG ] Including configuration from '/etc/salt/minion.d/_schedule.conf'\r\n[DEBUG ] Reading configuration from /etc/salt/minion.d/_schedule.conf\r\n[DEBUG ] Configuration file path: /etc/salt/minion\r\n[INFO ] Setting up the Salt Minion \"minion1\"\r\n[DEBUG ] Created pidfile: /var/run/salt-minion.pid\r\n[DEBUG ] Reading configuration from /etc/salt/minion\r\n[DEBUG ] Including configuration from '/etc/salt/minion.d/_schedule.conf'\r\n[DEBUG ] Reading configuration from /etc/salt/minion.d/_schedule.conf\r\n[DEBUG ] Attempting to authenticate with the Salt Master at 172.31.48.39\r\n[DEBUG ] Initializing new SAuth for ('/etc/salt/pki/minion', 'minion1', 'tcp://172.31.48.39:4506')\r\n[INFO ] SaltReqTimeoutError: after 60 seconds. (Try 1 of 7)\r\n[INFO ] SaltReqTimeoutError: after 60 seconds. (Try 2 of 7)\r\n[INFO ] SaltReqTimeoutError: after 60 seconds. (Try 3 of 7)\r\n[INFO ] SaltReqTimeoutError: after 60 seconds. (Try 4 of 7)\r\n[INFO ] SaltReqTimeoutError: after 60 seconds. (Try 5 of 7)\r\n[INFO ] SaltReqTimeoutError: after 60 seconds. (Try 6 of 7)\r\n[INFO ] SaltReqTimeoutError: after 60 seconds. (Try 7 of 7)\r\n[INFO ] The salt minion is shut down\r\n[ERROR ] Attempt to authenticate with the salt master failed\r\n[WARNING ] ** Restarting minion **\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "buildmaster-nyansa",
"comment_id": 253542153,
"datetime": 1476371400000,
"masked_author": "username_2",
"text": "Minions were able to attach when I upgraded salt master from Ubuntu 14.04 to 16.04.\r\n\r\n@username_0 Please double check your master version.\r\n\r\n```bash\r\n$ salt --versions-report\r\nSalt Version:\r\n Salt: 2016.3.3\r\n \r\nDependency Versions:\r\n cffi: Not Installed\r\n cherrypy: 3.5.0\r\n dateutil: 2.4.2\r\n gitdb: 0.6.4\r\n gitpython: 1.0.1\r\n ioflo: Not Installed\r\n Jinja2: 2.8\r\n libgit2: Not Installed\r\n libnacl: Not Installed\r\n M2Crypto: Not Installed\r\n Mako: 1.0.3\r\n msgpack-pure: Not Installed\r\n msgpack-python: 0.4.6\r\n mysql-python: Not Installed\r\n pycparser: Not Installed\r\n pycrypto: 2.6.1\r\n pygit2: Not Installed\r\n Python: 2.7.12 (default, Jul 1 2016, 15:12:24)\r\n python-gnupg: Not Installed\r\n PyYAML: 3.11\r\n PyZMQ: 15.2.0\r\n RAET: Not Installed\r\n smmap: 0.9.0\r\n timelib: Not Installed\r\n Tornado: 4.2.1\r\n ZMQ: 4.1.4\r\n \r\nSystem Versions:\r\n dist: Ubuntu 16.04 xenial\r\n machine: x86_64\r\n release: 4.4.0-43-generic\r\n system: Linux\r\n version: Ubuntu 16.04 xenial\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ch3LL",
"comment_id": 253666843,
"datetime": 1476400666000,
"masked_author": "username_1",
"text": "ahh thanks for that information @username_2 \r\n\r\ni wonder if you had upgraded your minions to 2016.3.3 as well if you still would see that error? but that might be too much to ask since you alreay moved to ubuntu16.\r\n\r\n@username_0 are you also using older minions?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rehmanzile",
"comment_id": 253679509,
"datetime": 1476405688000,
"masked_author": "username_3",
"text": "@username_1 I did upgrade the minions to 2016.3.3 but didn't work for me. It turns out the problem is somehow related to Ubuntu 14.04 when you upgrade salt-master from 2015.5.3 to 2016.3.3. \r\n\r\nTell your QA team to try this combination.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aronneagu",
"comment_id": 253730907,
"datetime": 1476430775000,
"masked_author": "username_0",
"text": "Hi guys,\r\nIndeed I am using older version of the salt-minion\r\n```\r\nsalt-minion 2016.3.0 (Boron)\r\n```\r\n\r\nThe problem is that when this happened 2 days ago, the problem appeared out of nowhere, and some of the minions did not reply (always different ones), and then abruptly as it started it the issue disappeared. I have no way of reproducing the issue. I will go ahead and upgrade the minions to 2016.3.3.\r\n@username_2 @username_1 thank you for your support and suggestions",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rehmanzile",
"comment_id": 253817341,
"datetime": 1476455602000,
"masked_author": "username_3",
"text": "@username_0 What is your Salt Master version? Use ```$ salt --versions-report``` to find out. Also, if you Salt Master server is using Ubuntu Trusty 14.04, then these intermittent connectivity issues do occur. I have experienced it in my environment and had to upgrade to 16.04.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aronneagu",
"comment_id": 253825866,
"datetime": 1476457238000,
"masked_author": "username_0",
"text": "@username_3 I am using 2016.3.3 for the salt-master (see my first post). Also the I am using Ubuntu 14.04. I am considering upgrading to 16.04, but it won't be something I can do in the immediate future, before I determine the impact on our application. \r\nI have created a script that will do a ping from the master to the minions, and that will show if there are losses in the network. However, the servers are EC2 instances running in a VPC, so I highly doubt that underlying network to be the cause.\r\nHow did you determine that the OS, and which part of it, was causing the connectivity issue?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rehmanzile",
"comment_id": 253831787,
"datetime": 1476458314000,
"masked_author": "username_3",
"text": "@username_0 I ruled out connectivity because I was using 2015.8.12 version of Salt Master on Ubuntu 14.04 originally in AWS. The master and minions were operating correctly. \r\n\r\nThen I upgraded the Salt Master and Minion version to 2016.3.3. Minions were having a hard time connecting to master and pings were failing. Same setup, different Salt version. Then I upgraded my OS to Ubuntu 16.04. All connectivity issues went away.\r\n\r\nI agree with you, I doubt your network is an issue in AWS. You can take a snap shot of the current salt and try to upgrade to resolve these issues. You can always revert back to the previous version.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aronneagu",
"comment_id": 253843005,
"datetime": 1476460697000,
"masked_author": "username_0",
"text": "@username_3 I will try to upgrade then the OS to Ubuntu 16.04 as soon as possible. Did you upgrade only the master OS, or also the minions? And just to be clear, you are using version 2016.3.3 for both the master and minion? (I appreciate all the effort and comments you added to the thread, they have been invaluable)\r\n\r\nToday it happened that I had a virtual machine running locally on my laptop connecting to the salt-master on AWS, and it was still timing out, so low chances that AWS infrastructure is at fault here.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rehmanzile",
"comment_id": 253848320,
"datetime": 1476461674000,
"masked_author": "username_3",
"text": "@username_0 You only need to upgrade the master OS. I believe the problem is with the Master OS. All of my minions are still running Ubuntu 14.04 with salt-minion version 2016.3.3. Hope this works out for you!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rehmanzile",
"comment_id": 254858641,
"datetime": 1476892888000,
"masked_author": "username_3",
"text": "@username_0 Just curious. Were you able to resolve the issue by upgrading salt master?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bkruger99",
"comment_id": 255192345,
"datetime": 1476988937000,
"masked_author": "username_4",
"text": "I have run into similar with ubuntu 14.04 doing a fresh salt master install. I've had to reboot the instance for it to work correctly (after all updates from apt, etc). 16.04 works without issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aronneagu",
"comment_id": 255385729,
"datetime": 1477058670000,
"masked_author": "username_0",
"text": "@username_3 I have successfully upgraded to 16.04, and the first time I ran salt '*' test.ping (after reboot), more than half of the instances failed to reply, with error \"Minion not connected [No response] (or [Not connected]\". The second time I issued the same command they all replied. So far they all seem to accept commands from the master.\r\n\r\nI encountered the same behavior on my test stack, the first salt command (usually test.ping) after upgrading to 16.04 fails.\r\n\r\nIf I won't encounter any issues in the next week, I will close the ticket",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ch3LL",
"comment_id": 255467443,
"datetime": 1477084628000,
"masked_author": "username_1",
"text": "Okay i went ahead and tried to replicate this issue and I am able to successfully replicate it. I even tried upgrading a bunch of the dependencies and did not see a difference. Here is my versions-report after the upgrade of versions:\r\n\r\n```\r\nroot@ip-10-63-221-160:~# salt --versions-report\r\nSalt Version:\r\n Salt: 2016.3.3\r\n \r\nDependency Versions:\r\n cffi: Not Installed\r\n cherrypy: Not Installed\r\n dateutil: 1.5\r\n gitdb: 0.5.4\r\n gitpython: 0.3.2 RC1\r\n ioflo: Not Installed\r\n Jinja2: 2.7.2\r\n libgit2: Not Installed\r\n libnacl: Not Installed\r\n M2Crypto: Not Installed\r\n Mako: 0.9.1\r\n msgpack-pure: Not Installed\r\n msgpack-python: 0.3.0\r\n mysql-python: 1.2.3\r\n pycparser: Not Installed\r\n pycrypto: 2.6.1\r\n pygit2: Not Installed\r\n Python: 2.7.6 (default, Jun 22 2015, 17:58:13)\r\n python-gnupg: Not Installed\r\n PyYAML: 3.10\r\n PyZMQ: 16.0.0\r\n RAET: Not Installed\r\n smmap: 0.8.2\r\n timelib: Not Installed\r\n Tornado: 4.2.1\r\n ZMQ: 4.1.5\r\n \r\nSystem Versions:\r\n dist: Ubuntu 14.04 trusty\r\n machine: x86_64\r\n release: 3.13.0-36-generic\r\n system: Linux\r\n version: Ubuntu 14.04 trusty\r\n \r\n```\r\n\r\nWeirdly enough when I installed the salt-minion on the same host as the master and was running the salt-minon processes everything worked as expected. I could ping remote minions and the local minion. But when I stop that minion process I can no longer ping and I get the `The master is not responding` error. \r\n\r\nI'm currently bringing up a test case to see if this affects clean installs of ubuntu14 as well. Will report results when done.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ch3LL",
"comment_id": 255467645,
"datetime": 1477084687000,
"masked_author": "username_1",
"text": "Oh and if anyone still has their ubuntu14 instance up can they see if running a minion the master helps? or mabye someone can clarify if they had a local minion running?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ch3LL",
"comment_id": 255471202,
"datetime": 1477085781000,
"masked_author": "username_1",
"text": "38d37\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ch3LL",
"comment_id": 255472543,
"datetime": 1477086199000,
"masked_author": "username_1",
"text": "Okay I can also confirm that upgrading the minions to 2016.3.3 resolves the issue well and this is my versions report for that upgraded minion:\r\n\r\n```\r\nSalt Version:\r\n Salt: 2016.3.3\r\n \r\nDependency Versions:\r\n cffi: Not Installed\r\n cherrypy: Not Installed\r\n dateutil: 1.5\r\n gitdb: Not Installed\r\n gitpython: Not Installed\r\n ioflo: Not Installed\r\n Jinja2: 2.7.2\r\n libgit2: Not Installed\r\n libnacl: Not Installed\r\n M2Crypto: 0.21.1\r\n Mako: 0.9.1\r\n msgpack-pure: Not Installed\r\n msgpack-python: 0.3.0\r\n mysql-python: 1.2.3\r\n pycparser: Not Installed\r\n pycrypto: 2.6.1\r\n pygit2: Not Installed\r\n Python: 2.7.6 (default, Jun 22 2015, 17:58:13)\r\n python-gnupg: Not Installed\r\n PyYAML: 3.10\r\n PyZMQ: 14.0.1\r\n RAET: Not Installed\r\n smmap: Not Installed\r\n timelib: Not Installed\r\n Tornado: 4.2.1\r\n ZMQ: 4.0.4\r\n \r\nSystem Versions:\r\n dist: Ubuntu 14.04 trusty\r\n machine: x86_64\r\n release: 3.13.0-36-generic\r\n system: Linux\r\n version: Ubuntu 14.04 trusty\r\n```\r\n\r\nSo to sum everything up:\r\n\r\n1. following situation creates issue:\r\n - upgrade 2015.5.3 master to 2016.3.3\r\n - minion stays at 2015.5.3\r\n\r\nWORKAROUND: fix this issue by installnig a 2016.3.3 minion on the master and weirdly enough you can ping the 2015.5.3 minion at that point)\r\n\r\nSOLUTION: upgrade minion to 2016.3.3 (although I think you guys pointed out that it did not work for you when upgrading the minions to 2016.3.3., which i canot replicate, so i'm wondering if you guys did not have a salt-minion on your master?)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cachedout",
"comment_id": 256237798,
"datetime": 1477451096000,
"masked_author": "username_5",
"text": "@username_1 Given your summary, do you think it would be sufficient to document those caveats and close this issue?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aronneagu",
"comment_id": 256353621,
"datetime": 1477489909000,
"masked_author": "username_0",
"text": "@username_1 I can confirm I did not have a minion on the master at any point. Both the master and minions were all at version 2016.3.3 when the issue happened, but I did upgrade the versions from 2015.x.x, so it wasn't a clean install.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rehmanzile",
"comment_id": 256670459,
"datetime": 1477581146000,
"masked_author": "username_3",
"text": "@username_1 My main concern with the solution you pointed out is the fact that salt-master cannot communicate to minions. And upgrading minions will be a daunting task, especially if ssh port is not available.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ch3LL",
"comment_id": 257971234,
"datetime": 1478114424000,
"masked_author": "username_1",
"text": "@username_3 agreed its not the best solution and it looks like an engineer has been assigned this so i'm sure there will be additional eyes on this. Did upgrading the minions to 2016.3.3 resolve the issue for you though? I think you mentioned it did not so I wanted to clear that up.\r\n\r\nI think the easier solution for someone would be to install a 2016.3.3 minion on the master and run that. That way they don't have to upgrade all minions. That should work as a temporary workaround.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rehmanzile",
"comment_id": 258462231,
"datetime": 1478273232000,
"masked_author": "username_3",
"text": "@username_1 I did not try upgrading the minions. With 50+ minions in the environment, it was not a feasible option for me.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ch3LL",
"comment_id": 258985859,
"datetime": 1478558212000,
"masked_author": "username_1",
"text": "@username_3 Thanks for clarifying",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DmitryKuzmenko",
"comment_id": 260592089,
"datetime": 1479202473000,
"masked_author": "username_6",
"text": "**The problem here is the same as #35480.**\r\nSalt master in 2016.3.3 has an issue in the shutdown procedure that causes some old MWorker processes could still alive after the master restart. In this case those workers could fetch jobs from the queue, but they aren't connected to the new Event Bus instance so master doesn't receive messages about job done by those workers.\r\n\r\n**How to check am I right:**\r\nIssue the following command: `ps aux | grep salt-master` and check MWorker processes PIDs. They all should have close numbers and all should be greater than `MWorkerQueue`, i.e. should be at the bottom of the list. For instance:\r\n```bash\r\n$ ps aux | grep salt-master\r\nroot 21229 0.0 4.1 243484 41916 ? Ss 11:34 0:00 /usr/bin/python /usr/bin/salt-master ProcessManager\r\nroot 21235 0.0 1.9 149500 20180 ? S 11:34 0:00 /usr/bin/python /usr/bin/salt-master MultiprocessingLoggingQueue\r\nroot 21238 0.0 3.5 320852 36072 ? Sl 11:34 0:00 /usr/bin/python /usr/bin/salt-master ZeroMQPubServerChannel\r\nroot 21239 0.0 3.3 243204 34500 ? S 11:34 0:00 /usr/bin/python /usr/bin/salt-master EventPublisher\r\nroot 21242 0.0 4.0 247504 41372 ? S 11:34 0:00 /usr/bin/python /usr/bin/salt-master Maintenance\r\nroot 21304 0.3 3.8 850344 38824 ? Sl 11:34 0:01 /usr/bin/python /usr/bin/salt-master Reactor\r\nroot 21305 0.0 3.3 243484 33928 ? S 11:34 0:00 /usr/bin/python /usr/bin/salt-master ReqServer_ProcessManager\r\nroot 21306 0.0 3.7 620340 38024 ? Sl 11:34 0:00 /usr/bin/python /usr/bin/salt-master MWorkerQueue\r\nroot 21314 0.0 4.3 477456 43860 ? Sl 11:34 0:00 /usr/bin/python /usr/bin/salt-master MWorker-0\r\nroot 21318 0.0 4.3 329996 44212 ? Sl 11:34 0:00 /usr/bin/python /usr/bin/salt-master MWorker-1\r\nroot 21321 0.0 4.3 329992 44536 ? Sl 11:34 0:00 /usr/bin/python /usr/bin/salt-master MWorker-2\r\nroot 21324 0.0 4.2 328788 43596 ? Sl 11:34 0:00 /usr/bin/python /usr/bin/salt-master MWorker-3\r\nroot 21327 0.0 4.2 328792 43604 ? Sl 11:34 0:00 /usr/bin/python /usr/bin/salt-master MWorker-4\r\n```\r\n\r\n**\"What can I do?\"**\r\nYou can do one of the following to fix the issue:\r\n1 Upgrade to 2016.3.4. It has all the master shutdown fixes applied. The only master update is needed.\r\n2 Manually apply ca8eb7e0760297c2bb8abc49fe58af57637de3fb, 6ad299871505e5b3adcfbe582855ae509a1879e7, b6937ebaa80e95a1f5edc89011d2119c0ab6a4cf to 2016.3.3 master. This could be done by cloning salt git repo to somewhere and execute these commands:\r\n```bash\r\n$ git show ca8eb7e0760297c2bb8abc49fe58af57637de3fb 6ad299871505e5b3adcfbe582855ae509a1879e7 b6937ebaa80e95a1f5edc89011d2119c0ab6a4cf >/tmp/patch\r\n$ cd /usr/lib/python2.7/dist-packages/salt\r\n$ sudo patch -p2 < /tmp/patch\r\n```\r\n3 Cleanup on stop via the init system. 14.04 uses upstart, you can add post-stop script to `/etc/init/salt-master.conf`:\r\n```bash\r\npost-stop script\r\n exec /bin/salt-kill.sh\r\nend script\r\n```\r\nwhere `/bin/salt-kill.sh` is executable file with the following contents:\r\n```bash\r\n#!/bin/bash\r\npkill -9 -f \"/usr/bin/python /usr/bin/salt-master\"\r\nexit 0\r\n```\r\nUbuntu 16.04 uses systemd and it looks systemd do the stop job better than upstart. But if it's needed the systemd script could be updated too by adding `ExecStopPost=pkill -9 -f \"/usr/bin/python /usr/bin/salt-master\"` to the `[Service]` section of `/lib/systemd/system/salt-master.service`",
"title": null,
"type": "comment"
}
] | 8 | 28 | 21,792 | false | true | 21,792 | true |
ustbhuangyi/better-scroll | null | 397,677,422 | 732 | null | [
{
"action": "opened",
"author": "Herryjoeson",
"comment_id": null,
"datetime": 1547097918000,
"masked_author": "username_0",
"text": "我参考了demo并且使用react实现了一份一模一样的代码.当我在使用pulling up的时候,并且设置了滑倒底部的提示容器。但是无论如何都无法滚动到提示的容器这个位置\r\n\r\n实际我的页面只能看到\r\n\r\n当我尝试往上拉看到了 但是他回弹把它藏起来了\r\n\r\n实际我想要就是能够把classname为pullup-wrapper这个能展示出来",
"title": "使用pullingup发生一些很诡异的问题",
"type": "issue"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 452976778,
"datetime": 1547098662000,
"masked_author": "username_0",
"text": "我现在就是说要让pull-wrapper的容器能显示正常滚到哪里。我是在他的后面加多了一个div并且设置一定的高度",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "theniceangel",
"comment_id": 452986836,
"datetime": 1547102195000,
"masked_author": "username_1",
"text": "提供线上可调试demo",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 452990055,
"datetime": 1547103264000,
"masked_author": "username_0",
"text": "稍等",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 452994154,
"datetime": 1547104547000,
"masked_author": "username_0",
"text": "@username_1 http://wubing.saltwater.xin/#/pages/test/test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "theniceangel",
"comment_id": 453463126,
"datetime": 1547201208000,
"masked_author": "username_1",
"text": "看demo没啥问题",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 453464969,
"datetime": 1547201532000,
"masked_author": "username_0",
"text": "那个加载提示的容器不应该在到底部会显示出来的吗",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 453466274,
"datetime": 1547201749000,
"masked_author": "username_0",
"text": "比如我设置上拉前的底部文字应该是上拉加载下一页。可是我现在滚动到底部。看不到那个容器。需要我上拉看到。并且回弹就藏起来了",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "theniceangel",
"comment_id": 453728824,
"datetime": 1547280387000,
"masked_author": "username_1",
"text": "看现象应该是高度计算错误，确保所有的dom渲染之后，再初始化bs",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 453744947,
"datetime": 1547297398000,
"masked_author": "username_0",
"text": "我已经更新了demo,并且在对应的console输出了东西,来确定定位问题.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 453745244,
"datetime": 1547297669000,
"masked_author": "username_0",
"text": "这一次我在react渲染dom完输出了console.log,并且初始化bs使用3秒。。结果并没有看到底部。但是奇怪的是我如果滚动了一下滚动条 3秒后定时器去初始化的时候底部看的到了,但是之前发生滚动的那些试图在也看不到了 具体你可以尝试一下,我第一个是子元素给0的哪一个",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lllllleo-chan",
"comment_id": 453891357,
"datetime": 1547434288000,
"masked_author": "username_2",
"text": "看你的demo你把wrapper设置成了100vh，忽略了topbar的高度，实际上bs没有滚动",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 454350956,
"datetime": 1547549677000,
"masked_author": "username_0",
"text": "我设置成100%就和撑成实际的高度了",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 454351642,
"datetime": 1547549808000,
"masked_author": "username_0",
"text": "按照大佬的意思。我需要如何改动",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lllllleo-chan",
"comment_id": 454351678,
"datetime": 1547549817000,
"masked_author": "username_2",
"text": "你可以把overflow设置成auto",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 454353337,
"datetime": 1547550136000,
"masked_author": "username_0",
"text": "我晚点试试。",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 454711698,
"datetime": 1547631045000,
"masked_author": "username_0",
"text": "用了auto后好像多出一点内容",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lllllleo-chan",
"comment_id": 454713506,
"datetime": 1547631400000,
"masked_author": "username_2",
"text": "你可以用flex布局让main-content自适应+overflow：auto，然后里面的内容高度100%，我也不太清楚你的空白怎么来的，我现在开发都是这样玩的，应该不会有什么问题",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 454718113,
"datetime": 1547632295000,
"masked_author": "username_0",
"text": "空白不加1px就没问题",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 454720151,
"datetime": 1547632681000,
"masked_author": "username_0",
"text": "我现在就先用着后面的dom来顶前面的bottombar来显示出来",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 454720805,
"datetime": 1547632809000,
"masked_author": "username_0",
"text": "我最奇怪的就是不知道为什么我的定时器没到600毫秒执行的期间滑动了页面 底部可以直接看到但是头顶的那个元素会遮挡bar的高度",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 454810695,
"datetime": 1547650986000,
"masked_author": "username_0",
"text": "终于解决了",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Herryjoeson",
"comment_id": null,
"datetime": 1547651096000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "yangmeijuan",
"comment_id": 517595043,
"datetime": 1564731812000,
"masked_author": "username_3",
"text": "请问我也遇到相似问题 ，能提供一下解决方法吗",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xaviertung",
"comment_id": 541075024,
"datetime": 1570802162000,
"masked_author": "username_4",
"text": "@username_0 请问怎么解决的，方便贴出来吗，我也遇到类似的问题了。",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Herryjoeson",
"comment_id": 541272869,
"datetime": 1570845966000,
"masked_author": "username_0",
"text": "你需要明确一个高度给到scroll不然计算有问题就会导致这样",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xaviertung",
"comment_id": 541431170,
"datetime": 1570982467000,
"masked_author": "username_4",
"text": "是2.0beta2版本的问题，安卓微信客户端上拉刷新时未正常计划滚动条高度。",
"title": null,
"type": "comment"
}
] | 5 | 27 | 1,379 | false | false | 1,379 | true |
nvaccess/nvda | nvaccess | 437,660,494 | 9,520 | null | [
{
"action": "opened",
"author": "UNBREAKING",
"comment_id": null,
"datetime": 1556283413000,
"masked_author": "username_0",
"text": "### Steps to reproduce: \r\n1) Open IE 11 and then open: http://www.w3.org/TR/wai-aria-practices/examples/tabs/tabs-1/tabs.html\r\n2) use navigation to Example of Tab menu\r\n3) use navigation between tabs of Example menu\r\n### Actual behavior:\r\n1) Announce only of tablist and no announce of any tab.\r\n\r\n### Expected behavior:\r\n2) The same announce as in other browsers such as Google Chrome\r\n### System configuration\r\n#### NVDA installed/portable/running from source:\r\nNVDA installed as app on desktop and turned on\r\n#### NVDA version:\r\n2019.1\r\n#### Windows version:\r\nWindows 10\r\n#### Name and version of other software in use when reproducing the issue:\r\n\r\n#### Other information about your system:\r\nVersion of IE: 11.1746.15063.0\r\n### Other questions\r\n#### Does the issue still occur after restarting your PC?\r\nYes\r\n#### Have you tried any other versions of NVDA? If so, please report their behaviors.\r\nNo",
"title": "NVDA doesn't announce tabs in IE",
"type": "issue"
},
{
"action": "created",
"author": "Brian1Gaff",
"comment_id": 487111835,
"datetime": 1556294777000,
"masked_author": "username_1",
"text": "Is this not due to the lack of current development of IE by Microsoft, they \nkind of just left it. Are you saying it used to work before?\n Brian\n\nbglists@blueyonder.co.uk\nSent via blueyonder.\nPlease address personal E-mail to:-\nbriang1@blueyonder.co.uk, putting 'Brian Gaff'\nin the display name field.\n-----",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DrSooom",
"comment_id": 487219420,
"datetime": 1556317406000,
"masked_author": "username_2",
"text": "I couldn't reproduce it with IE 11.0.9600.19301 (32-bit) on Win7x64 and NVDA 2018.1. The names of the tabs are announced correctly in focus mode during switching them by pressing ArrowRight and ArrowLeft.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Brian1Gaff",
"comment_id": 487264450,
"datetime": 1556351010000,
"masked_author": "username_1",
"text": "The obvious difference is the version of nvda, and windows used between the \nreporter and yourself. I do not know enough about IE version labelling to \nknow if it matters on that front.\n It needs another windows 10 IE user to comment I think, but I do stand by \nwhat I observed earlier about the priority of this problem given such a wide \nchoice of better browsers now.\n Brian\n\nbglists@blueyonder.co.uk\nSent via blueyonder.\nPlease address personal E-mail to:-\nbriang1@blueyonder.co.uk, putting 'Brian Gaff'\nin the display name field.\n-----",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JulienCochuyt",
"comment_id": 511377434,
"datetime": 1563192828000,
"masked_author": "username_3",
"text": "what I observed earlier about the priority of this problem given such a wide\r\nchoice of better browsers now.\r\n\r\nI am sorry to contradict, but I have to stand against this argument.\r\nOf course there are far better browsers to choose from… when you do have the choice.\r\nMany web applications still in use were designed for IE and only support IE.\r\nThis is still really common especially in corporate environments.\r\n\r\nFor what I could test with latest NVDA 2019.2beta3 / IE 11 / Windows 10, even if PR #9930 gets merged, there will still be an issue under IE with HTML tab headers: Their index and total number is not announced even if \"Guess object position information when unavailable\" is checked in the \"Object Presentation\" settings.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "michaelDCurran",
"comment_id": null,
"datetime": 1568188684000,
"masked_author": "username_4",
"text": "",
"title": null,
"type": "issue"
}
] | 5 | 6 | 2,689 | false | false | 2,689 | false |
MobleyLab/SAMPL7 | MobleyLab | 448,928,567 | 12 | null | [
{
"action": "opened",
"author": "davidlmobley",
"comment_id": null,
"datetime": 1558973534000,
"masked_author": "username_0",
"text": "Once we've got the last of the guests up, let's use a script to make standard sdf/mol2 files for all of the guests from the SMILES strings so everything will be uniform and constructed with the same toolkits.",
"title": "Once all source files for guests are up, construct standard mol2/sdf files",
"type": "issue"
},
{
"action": "created",
"author": "bergazin",
"comment_id": 508858152,
"datetime": 1562359282000,
"masked_author": "username_1",
"text": "Trimertrip guests in PDB, SDF and MOL2 file format added here (includes the notebook to generate them) https://github.com/MobleyLab/SAMPL7/tree/username_1/host_guest/Isaacs_clip/host_guest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bergazin",
"comment_id": 508858550,
"datetime": 1562359416000,
"masked_author": "username_1",
"text": "Should I close this? @username_0",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "davidlmobley",
"comment_id": 512974027,
"datetime": 1563481589000,
"masked_author": "username_0",
"text": "@username_1 we don't yet have mol2/sdf files for the cyclodextrin case (though I believe these overlap with the other cases and perhaps can be copied in from there).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bergazin",
"comment_id": 513046729,
"datetime": 1563497239000,
"masked_author": "username_1",
"text": "Just made a PR that adds additional input files for the cyclodextrin challenge: https://github.com/MobleyLab/SAMPL7/pull/23#issue-299139482",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "davidlmobley",
"comment_id": null,
"datetime": 1563829431000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "davidlmobley",
"comment_id": 513953862,
"datetime": 1563829431000,
"masked_author": "username_0",
"text": "Closed by #23",
"title": null,
"type": "comment"
}
] | 2 | 7 | 743 | false | false | 743 | true |
electron/electron | electron | 314,940,268 | 12,634 | null | [
{
"action": "opened",
"author": "KochiyaOcean",
"comment_id": null,
"datetime": 1523950709000,
"masked_author": "username_0",
"text": "<!--\r\nThanks for opening an issue! A few things to keep in mind:\r\n\r\n- The issue tracker is only for bugs and feature requests.\r\n- Before reporting a bug, please try reproducing your issue against\r\n the latest version of Electron.\r\n- If you need general advice, join our Slack: http://atom-slack.herokuapp.com\r\n-->\r\n\r\n* Electron version:\r\n* Operating system:\r\n\r\n### Expected behavior\r\n\r\n<!-- What do you think should happen? -->\r\nWhen `webPreferences.nativeWindowOpen` is set to true, BrowserWindows opened by `window.open`'s memory will be released after be closed.\r\n\r\n### Actual behavior\r\n\r\n<!-- What actually happens? -->\r\nThe memory is not released and caused memory leak\r\n\r\n### How to reproduce\r\n- Clone https://github.com/username_0/electron-bugs/tree/native-open-memory-leak\r\n- Run `electron . ` in the cloned repo\r\n- Memory usage of electron process will be increasing in task manager\r\n\r\n<!-- \r\n\r\nYour best chance of getting this bug looked at quickly is to provide a REPOSITORY that can be cloned and run.\r\n\r\nYou can fork https://github.com/electron/electron-quick-start and include a link to the branch with your changes.\r\n\r\nIf you provide a URL, please list the commands required to clone/setup/run your repo e.g.\r\n\r\n $ git clone $YOUR_URL -b $BRANCH\r\n $ npm install\r\n $ npm start || electron .\r\n\r\n-->",
"title": "window.open with nativeWindowOpen option causes memory leak",
"type": "issue"
},
{
"action": "created",
"author": "KochiyaOcean",
"comment_id": 381881539,
"datetime": 1523950806000,
"masked_author": "username_0",
"text": "Seems this issue is relative to https://github.com/electron/electron/issues/12027",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MarshallOfSound",
"comment_id": 384514884,
"datetime": 1524719441000,
"masked_author": "username_1",
"text": "Appears to occur on all known Electron versions with this feature 👍 Approximately 5MB per window",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GhostDev26",
"comment_id": 421914029,
"datetime": 1537169349000,
"masked_author": "username_2",
"text": "Still occurs on 2.0.9",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "VishwasShashidhar",
"comment_id": 424617956,
"datetime": 1537947763000,
"masked_author": "username_3",
"text": "We've observed this on 3.0.0 as well.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zcbenz",
"comment_id": 428511814,
"datetime": 1539165377000,
"masked_author": "username_4",
"text": "From the profile of heap allocations, it seems that the V8 contexts of the new windows have never been released, resulting in a leak of V8 contexts in the renderer process of the embedder page.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "VishwasShashidhar",
"comment_id": 429304238,
"datetime": 1539346160000,
"masked_author": "username_3",
"text": "@username_4 Thanks for the details. Is there a work-around for this at the moment?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "zcbenz",
"comment_id": null,
"datetime": 1540449068000,
"masked_author": "username_4",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "orange4glace",
"comment_id": 441971188,
"datetime": 1543307626000,
"masked_author": "username_5",
"text": "I tested on the latest electron and seems it's still happening.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "orange4glace",
"comment_id": 441975423,
"datetime": 1543308486000,
"masked_author": "username_5",
"text": "Tested on nightly build version, (4.0.0-nightly.201) it seems it's still happening even nodeIntegration is disabled.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "KochiyaOcean",
"comment_id": 441994698,
"datetime": 1543312075000,
"masked_author": "username_0",
"text": "@username_5 https://github.com/electron/electron/issues/15666 seems it will be fixed in 5.0.x release.",
"title": null,
"type": "comment"
}
] | 6 | 11 | 2,106 | false | false | 2,106 | true |
zhmcclient/python-zhmcclient | zhmcclient | 240,928,164 | 364 | {
"number": 364,
"repo": "python-zhmcclient",
"user_login": "zhmcclient"
} | [
{
"action": "opened",
"author": "andy-maier",
"comment_id": null,
"datetime": 1499341014000,
"masked_author": "username_0",
"text": "**Note:** This PR is on top of PR #359.\r\nAffects only mock support.\r\nReady for review and merge.\r\nDetails in commit message.",
"title": "Fixes #319: Mock: Added support for Get Connected VNICs operation.",
"type": "issue"
},
{
"action": "created",
"author": "andy-maier",
"comment_id": 313390697,
"datetime": 1499346436000,
"masked_author": "username_0",
"text": "+1",
"title": null,
"type": "comment"
}
] | 2 | 4 | 705 | false | true | 126 | false |
SharePoint/PnP-PowerShell | SharePoint | 417,122,165 | 1,949 | {
"number": 1949,
"repo": "PnP-PowerShell",
"user_login": "SharePoint"
} | [
{
"action": "opened",
"author": "KoenZomers",
"comment_id": null,
"datetime": 1551763143000,
"masked_author": "username_0",
"text": "## Type ##\r\n- [X] Bug Fix\r\n- [ ] New Feature\r\n- [ ] Sample\r\n\r\n## Related Issues? ##\r\nN/A\r\n\r\n## What is in this Pull Request ? ##\r\nFixing GetAzureADCredentialsContext not available in on premises thus the code not compiling in SharePoint 2019 mode",
"title": "Fixing GetAzureADCredentialsContext not available on prem issue",
"type": "issue"
},
{
"action": "created",
"author": "erwinvanhunen",
"comment_id": 469604473,
"datetime": 1551777771000,
"masked_author": "username_1",
"text": "Good one!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 255 | false | false | 255 | false |
firstcontributions/first-contributions | firstcontributions | 399,648,794 | 14,099 | {
"number": 14099,
"repo": "first-contributions",
"user_login": "firstcontributions"
} | [
{
"action": "opened",
"author": "saiskee",
"comment_id": null,
"datetime": 1547614958000,
"masked_author": "username_0",
"text": "",
"title": "Add saiskee to Contributors list",
"type": "issue"
},
{
"action": "created",
"author": "Roshanjossey",
"comment_id": 454652875,
"datetime": 1547614974000,
"masked_author": "username_1",
"text": "Hi @username_0, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.\nCould you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?\n\n
We’ve recently added social share to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 620 | false | false | 620 | true |
jamespetts/simutrans-extended | null | 414,852,661 | 113 | null | [
{
"action": "opened",
"author": "Huperspace",
"comment_id": null,
"datetime": 1551220352000,
"masked_author": "username_0",
"text": "I want to be able to sort the buying vehicles as if there are a lot of vehicles to choose one but the visuals don't differ to much I have to read and search a lot before I find the right ones.\r\nSorts like release year, Speed, Power, Same brand (for Waggon sets),...",
"title": "[Feature Request] Be able to sort the buying vehicles",
"type": "issue"
},
{
"action": "created",
"author": "vladki77",
"comment_id": 467653672,
"datetime": 1551222664000,
"masked_author": "username_1",
"text": "I think this is already implemented in standard, so it could be taken from there, and perhaps extended to include comfort, catering, classes, liveries, and other extended stuff",
"title": null,
"type": "comment"
}
] | 2 | 2 | 441 | false | false | 441 | false |
draios/sysdig | draios | 316,081,328 | 1,105 | {
"number": 1105,
"repo": "sysdig",
"user_login": "draios"
} | [
{
"action": "opened",
"author": "mstemm",
"comment_id": null,
"datetime": 1524182691000,
"masked_author": "username_0",
"text": "Several changes to expand the set of events that are skipped by falco, and to centralize the logic for knowing which events to skip.",
"title": "More ef drop falco",
"type": "issue"
},
{
"action": "created",
"author": "mstemm",
"comment_id": 382920392,
"datetime": 1524183102000,
"masked_author": "username_0",
"text": "@mattpag, could you take a look at the syscalls I excluded? I tried to be consistent about keeping any syscalls that could modify state outside of the process.",
"title": null,
"type": "comment"
}
] | 1 | 2 | 291 | false | false | 291 | false |
tensorflow/transform | tensorflow | 332,548,641 | 66 | null | [
{
"action": "opened",
"author": "Debasish-Das-CK",
"comment_id": null,
"datetime": 1529007349000,
"masked_author": "username_0",
"text": "dataset = tf.contrib.data.make_batched_features_dataset(\r\n file_pattern=transformed_examples,\r\n batch_size=batch_size,\r\n features=tf_transform_output.transformed_feature_spec(),\r\n reader=tf.data.TFRecordDataset,\r\n shuffle=True)\r\ntft examples uses a contrib API which is not official. Can I use the following ?\r\n\r\ndataset = tf.data.TFRecordDataset(filenames_list)\r\ndataset = dataset.map(_parse_proto)\r\ndataset.map(tf_transform_output.transformed_feature_spec())",
"title": "apply tft.TFTransformOutput.transformed_feature_spec to tf.data",
"type": "issue"
},
{
"action": "created",
"author": "Debasish-Das-CK",
"comment_id": 397424531,
"datetime": 1529007369000,
"masked_author": "username_0",
"text": "also I guess examples need to be updated with the official API...should I push a PR ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ravwojdyla",
"comment_id": 400081356,
"datetime": 1529957820000,
"masked_author": "username_1",
"text": "@username_0 `tf.contrib.data.make_batched_features_dataset` is full supported and recommended see https://www.youtube.com/watch?v=uIcqeP7MFH0.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Debasish-Das-CK",
"comment_id": null,
"datetime": 1529957864000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 727 | false | false | 727 | true |
Inter-Actief/alexia | Inter-Actief | 363,127,637 | 61 | null | [
{
"action": "opened",
"author": "WKobes",
"comment_id": null,
"datetime": 1537792662000,
"masked_author": "username_0",
"text": "Currently the nickname can be changed in the Membership form. In theory, a person can be a tender at multiple organisations, which causes that other associations could edit the same nickname field. In my opinion this field should be either moved to the ProfileEditForm, or the 'nickname' field should be made Membership-specific.",
"title": "Move nickname to profile edit form or make it membership dependable",
"type": "issue"
},
{
"action": "created",
"author": "CasEbbers",
"comment_id": 424070024,
"datetime": 1537812396000,
"masked_author": "username_1",
"text": "Yeah, I agree. 7ed97487ae4 was a quick fix and the nickname should definitely be a property of the Membership model. Will be working on that.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "WKobes",
"comment_id": null,
"datetime": 1616461125000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "WKobes",
"comment_id": 804504744,
"datetime": 1616461125000,
"masked_author": "username_0",
"text": "Low priority in current development progress",
"title": null,
"type": "comment"
}
] | 2 | 4 | 514 | false | false | 514 | false |
DLR-SC/tigl | DLR-SC | 427,014,681 | 584 | null | [
{
"action": "opened",
"author": "CedricDPS",
"comment_id": null,
"datetime": 1553869804000,
"masked_author": "username_0",
"text": "Hello i try to install tigl on my python interpreter.\r\nAfter install it from conda, i debug my code and i obtain the following error :\r\n\r\n`Traceback (most recent call last):\r\n File \"C:\\PROGRAMS\\Miniconda3\\lib\\site-packages\\tigl3\\tigl3wrapper.py\", line 278, in Tigl3\r\n lib = ctypes.cdll.tigl3\r\n File \"C:\\PROGRAMS\\Miniconda3\\lib\\ctypes\\__init__.py\", line 426, in __getattr__\r\n dll = self._dlltype(name)\r\n File \"C:\\PROGRAMS\\Miniconda3\\lib\\ctypes\\__init__.py\", line 356, in __init__\r\n self._handle = _dlopen(self._name, mode)\r\nOSError: [WinError 126] Le module spécifié est introuvable\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n File \"C:\\Users\\cedric.dalaudiere.DPS\\.p2\\pool\\plugins\\org.python.pydev.core_7.1.0.201902031515\\pysrc\\pydevd.py\", line 2225, in <module>\r\n main()\r\n File \"C:\\Users\\cedric.dalaudiere.DPS\\.p2\\pool\\plugins\\org.python.pydev.core_7.1.0.201902031515\\pysrc\\pydevd.py\", line 2218, in main\r\n globals = debugger.run(setup['file'], None, None, is_module)\r\n File \"C:\\Users\\cedric.dalaudiere.DPS\\.p2\\pool\\plugins\\org.python.pydev.core_7.1.0.201902031515\\pysrc\\pydevd.py\", line 1560, in run\r\n return self._exec(is_module, entry_point_fn, module_name, file, globals, locals)\r\n File \"C:\\Users\\cedric.dalaudiere.DPS\\.p2\\pool\\plugins\\org.python.pydev.core_7.1.0.201902031515\\pysrc\\pydevd.py\", line 1567, in _exec\r\n pydev_imports.execfile(file, globals, locals) # execute the script\r\n File \"C:\\Users\\cedric.dalaudiere.DPS\\.p2\\pool\\plugins\\org.python.pydev.core_7.1.0.201902031515\\pysrc\\_pydev_imps\\_pydev_execfile.py\", line 25, in execfile\r\n exec(compile(contents+\"\\n\", file, 'exec'), glob, loc)\r\n File \"H:\\PROJET\\KARREN\\CEASIOM_CPACS\\RCE\\CEASIOMpy\\test\\TestCPACS2SUMO\\test_cpacs2sumo.py\", line 26, in <module>\r\n from lib.CPACS2SUMO.cpacs2sumo import convert_cpacs_to_sumo\r\n File \"H:\\PROJET\\KARREN\\CEASIOM_CPACS\\RCE\\CEASIOMpy\\lib\\CPACS2SUMO\\cpacs2sumo.py\", line 32, in <module>\r\n from lib.utils.cpacsfunctions import open_tixi, close_tixi\r\n File \"H:\\PROJET\\KARREN\\CEASIOM_CPACS\\RCE\\CEASIOMpy\\lib\\utils\\cpacsfunctions.py\", line 38, in <module>\r\n import tigl3.tigl3wrapper as tigl3wrapper\r\n File \"C:\\PROGRAMS\\Miniconda3\\lib\\site-packages\\tigl3\\tigl3wrapper.py\", line 269, in <module>\r\n class Tigl3(object):\r\n File \"C:\\PROGRAMS\\Miniconda3\\lib\\site-packages\\tigl3\\tigl3wrapper.py\", line 285, in Tigl3`",
"title": "How to install on python",
"type": "issue"
},
{
"action": "created",
"author": "joergbrech",
"comment_id": 478220405,
"datetime": 1553934582000,
"masked_author": "username_1",
"text": "Hi Cedric, can you please tell me the command you used to install TiGL and which python version you are using? Can you run our examples, e.g. https://github.com/DLR-SC/tigl/blob/cpacs_3/examples/python/api_basic_demo.py?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "CedricDPS",
"comment_id": 478469846,
"datetime": 1554104336000,
"masked_author": "username_0",
"text": "Hi Jan, thank you for your quick answer. \r\n\r\nI 'm using Python 3.7 (x64) from Miniconda 4.6.8 on Windows 7 Professional 64 bits.\r\n\r\nTo install TiGL, I have downloaded the win-64/tigl3-3.0.0rc1-py35_vc14_9.tar.bz2 file available on https://anaconda.org/DLR-SC/tigl3/files and I have installed it with conda command : `conda install \"<path>\\win-64/tigl3-3.0.0rc1-py35_vc14_9.tar.bz2\"`\r\n\r\nConcerning your test code, I have tried to run it but it seems that I have the same issues. After debugging, problems come from the import line : `from tigl3.tigl3wrapper import Tigl3, TiglBoolean`\r\n\r\nPlease find attached the python error :\r\n\r\n`Traceback (most recent call last):\r\n File \"C:\\PROGRAMS\\Miniconda3\\lib\\site-packages\\tigl3\\tigl3wrapper.py\", line 278, in Tigl3\r\n lib = ctypes.cdll.tigl3\r\n File \"C:\\PROGRAMS\\Miniconda3\\lib\\ctypes\\__init__.py\", line 426, in __getattr__\r\n dll = self._dlltype(name)\r\n File \"C:\\PROGRAMS\\Miniconda3\\lib\\ctypes\\__init__.py\", line 356, in __init__\r\n self._handle = _dlopen(self._name, mode)\r\nOSError: [WinError 126] Le module spécifié est introuvable\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n File \"C:\\Users\\cedric.dalaudiere.DPS\\.p2\\pool\\plugins\\org.python.pydev.core_7.1.0.201902031515\\pysrc\\pydevd.py\", line 2225, in <module>\r\n main()\r\n File \"C:\\Users\\cedric.dalaudiere.DPS\\.p2\\pool\\plugins\\org.python.pydev.core_7.1.0.201902031515\\pysrc\\pydevd.py\", line 2218, in main\r\n globals = debugger.run(setup['file'], None, None, is_module)\r\n File \"C:\\Users\\cedric.dalaudiere.DPS\\.p2\\pool\\plugins\\org.python.pydev.core_7.1.0.201902031515\\pysrc\\pydevd.py\", line 1560, in run\r\n return self._exec(is_module, entry_point_fn, module_name, file, globals, locals)\r\n File \"C:\\Users\\cedric.dalaudiere.DPS\\.p2\\pool\\plugins\\org.python.pydev.core_7.1.0.201902031515\\pysrc\\pydevd.py\", line 1567, in _exec\r\n pydev_imports.execfile(file, globals, locals) # execute the script\r\n File \"C:\\Users\\cedric.dalaudiere.DPS\\.p2\\pool\\plugins\\org.python.pydev.core_7.1.0.201902031515\\pysrc\\_pydev_imps\\_pydev_execfile.py\", line 25, in execfile\r\n exec(compile(contents+\"\\n\", file, 'exec'), glob, loc)\r\n File \"H:\\PROJET\\KARREN\\CEASIOM_CPACS\\RCE\\CEASIOMpy\\test\\python_demo.py\", line 19, in <module>\r\n from tigl3.tigl3wrapper import Tigl3, TiglBoolean\r\n File \"C:\\PROGRAMS\\Miniconda3\\lib\\site-packages\\tigl3\\tigl3wrapper.py\", line 269, in <module>\r\n class Tigl3(object):\r\n File \"C:\\PROGRAMS\\Miniconda3\\lib\\site-packages\\tigl3\\tigl3wrapper.py\", line 285, in Tigl3\r\n \" 1) The PATH (Windows) / LD_LIBRARY_PATH (Linux) environment variable points to the library\\n\" +\r\nException: Could not load the tigl3 library. Please check if:\r\n 1) The PATH (Windows) / LD_LIBRARY_PATH (Linux) environment variable points to the library\r\n 2) The architecture of the library matches the architecture of python (a 32 bit python needs a 32 bit shared library)`\r\n\r\nThank you in advance,",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rainman110",
"comment_id": 478471348,
"datetime": 1554104644000,
"masked_author": "username_2",
"text": "@username_0 You've installed tigl3 incorrectly. Tigl3 depends on OpenCASCADE and other software. When explicitly installing a downloaded package, in won't install its dependencies. Therefore you get the message above.\r\n\r\nAt the moment, we only support Python 3.5. To install tigl correctly, enter on the anaconda prompt:\r\n\r\n```\r\nconda create -n tigl_env tigl3 python=3.5\r\n```\r\n\r\nThis will create a virtual environment \"tigl_env\" and installs all required packages into this environment.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "CedricDPS",
"comment_id": 478490354,
"datetime": 1554108264000,
"masked_author": "username_0",
"text": "Hi Martin, it works.\r\nThank you for your time,\r\nCedric",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "joergbrech",
"comment_id": null,
"datetime": 1554108783000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 6 | 6,145 | false | false | 6,145 | true |
ianho/xing-weapp-editor | null | 395,626,318 | 5 | null | [
{
"action": "opened",
"author": "namelzx",
"comment_id": null,
"datetime": 1546531164000,
"masked_author": "username_0",
"text": "",
"title": "uploadFile 上传图片返回的数据格式是怎样的？",
"type": "issue"
},
{
"action": "created",
"author": "namelzx",
"comment_id": 451192339,
"datetime": 1546532083000,
"masked_author": "username_0",
"text": "已经解决。\r\n感谢分享",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xhf19940721",
"comment_id": 462605193,
"datetime": 1549943568000,
"masked_author": "username_1",
"text": "返回的数据格式是什么样的啊？遇到这个问题了，求告知谢谢！",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ianho",
"comment_id": null,
"datetime": 1550044718000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ianho",
"comment_id": 463096879,
"datetime": 1550044718000,
"masked_author": "username_2",
"text": "传入`image-upload-key-chain`参数对应返回格式\r\n如：返回的json数据为`{ image : { url: 'http://xxx.jpg' } }`，则传入`image.url`\r\n可在README中`组件属性`表格中查到",
"title": null,
"type": "comment"
}
] | 3 | 5 | 163 | false | false | 163 | false |
asturiashacking/activities | asturiashacking | 278,710,505 | 7 | null | [
{
"action": "opened",
"author": "dgsuarez",
"comment_id": null,
"datetime": 1512242952000,
"masked_author": "username_0",
"text": "# Propuesta de Actividad\r\n\r\n## Título\r\n\r\nProgramas que se entienden a si mismos. Metaprogramación en el siglo XXI.\r\n\r\n## Descripción\r\n\r\nIntrospección, reflectividad, macros... Veremos como diferentes lenguajes usan\r\nestas técnicas para ayudar a hacer nuestro código más conciso y expresivo (y lo\r\nfácil que es también conseguir todo lo contrario).\r\n\r\n## Nivel\r\n\r\nAunque no asumiremos conocimientos específicos de ningún lenguaje de ni de las\r\ntécnicas que vamos a ver, sí que esperamos un nivel medio de programación.\r\n\r\n## Información adicional\r\n\r\nNecesitaría proyector.\r\n\r\n## Sobre mí\r\n\r\nMás de estar en xterm que en otra cosa. Va para unos años en una relación no\r\nexclusiva y sin formalizar con Ruby. CTO en Sweetspot Intelligence.\r\n\r\n<https://github.com/username_0/>\r\n[@dg_suarez](https://twitter.com/dg_suarez)",
"title": "(Charla) ",
"type": "issue"
},
{
"action": "created",
"author": "sergioalvz",
"comment_id": 348815328,
"datetime": 1512335792000,
"masked_author": "username_1",
"text": "@username_0 ¿cuándo te encajaría poder impartirla, Diego? ¿Enero?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dgsuarez",
"comment_id": 349008640,
"datetime": 1512403549000,
"masked_author": "username_0",
"text": "Sí, segunda mitad de Enero idealmente.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sergioalvz",
"comment_id": 353717563,
"datetime": 1514023102000,
"masked_author": "username_1",
"text": "Tentativa: 25 de enero de 2018. cc: @username_0",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tasugo",
"comment_id": null,
"datetime": 1516966523000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 5 | 960 | false | false | 960 | true |
angusmoore/arphit | null | 291,420,350 | 15 | {
"number": 15,
"repo": "arphit",
"user_login": "angusmoore"
} | [
{
"action": "opened",
"author": "angusmoore",
"comment_id": null,
"datetime": 1516843937000,
"masked_author": "username_0",
"text": "Permits different datasets for different panels.\r\nAlso permits non-time-series graphs.",
"title": "Add better handling of data",
"type": "issue"
}
] | 2 | 2 | 363 | false | true | 86 | false |
siimon/prom-client | null | 397,349,295 | 240 | null | [
{
"action": "opened",
"author": "KayHS",
"comment_id": null,
"datetime": 1547036862000,
"masked_author": "username_0",
"text": "Hi,\r\n\r\nWhat is the connection between prom-client and node_exporter if any.\r\n\r\nI downloaded this Grafana Node exporter dashboard - https://grafana.com/dashboards/405\r\n\r\nI found the DS i am using is not producing a lot of those variable metrics it is looking for. \r\nMy prometheus target is configured to look at my node app /metrics endpoint which displays the output of prom-client.\r\n\r\n```\r\n this.app.get(\"/metrics\", (req, res) => {\r\n res.end(client.register.metrics());\r\n });\r\n\r\n```\r\n\r\nHow do i get the metrics from node_exporter?",
"title": "prom-client and node exporter",
"type": "issue"
},
{
"action": "closed",
"author": "KayHS",
"comment_id": null,
"datetime": 1547045830000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 550 | false | false | 550 | false |
mCRL2org/mCRL2 | mCRL2org | 326,659,072 | 1,133 | null | [
{
"action": "opened",
"author": "jgroote",
"comment_id": null,
"datetime": 1360880266000,
"masked_author": "username_0",
"text": "*Issue migrated from trac ticket # 1131*\n\n**component:** Core: Print Library | **priority:** minor\n\n#### 2013-02-14 22:17:46: @username_2 created the issue\n\n\n___\nCurrently too many parentheses are used when printing abstractions in certain contexts. For example:\n\n```\nforall n: Bool. n => (forall k: Bool. k => n)\n```\n\nIt looks like the function print_expression needs to be specialized for abstractions (and possibly some other operators too).",
"title": "Unnecessary parentheses in pretty printing of abstractions",
"type": "issue"
},
{
"action": "created",
"author": "tneele",
"comment_id": 510463344,
"datetime": 1562847817000,
"masked_author": "username_1",
"text": "I do not find the provided example very convincing. The precedence of the forall operator is lower than the implication operator (ie, the implication binds stronger. The fact that the `forall k` occurs on the right-hand side of the implication is essential for the fact that `forall n: Bool. n => forall k: Bool. k => n` can only be interpreted in one way.\r\n\r\nHowever, commit 2f4a60ce74d43 introduced some new unnecessary parentheses. For example, in the expression `(a && a) && a`, the parentheses are not necessary.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "wiegerw",
"comment_id": 512888637,
"datetime": 1563467129000,
"masked_author": "username_2",
"text": "The change in commit 07bc09d should solve the unnecessary problem with parentheses in the expression `(a && a) && a`. Perhaps there are more operators with the wrong associativity annotations. The problem is that information about associativity is only partially available in the dparser grammar.",
"title": null,
"type": "comment"
}
] | 3 | 3 | 1,254 | false | false | 1,254 | true |
node-schedule/node-schedule | node-schedule | 363,877,241 | 465 | null | [
{
"action": "opened",
"author": "serakfalcon",
"comment_id": null,
"datetime": 1537943643000,
"masked_author": "username_0",
"text": "`0 0 8-11,23 * * *` causes strange behavior- it will only run the 11 PM time and 8-11 AM are ignored (on initialization next run time is always the 11 PM time) ... seems like some parsing error with the string",
"title": "cron-string doesn't properly support commas",
"type": "issue"
},
{
"action": "created",
"author": "santigimeno",
"comment_id": 441605937,
"datetime": 1543231345000,
"masked_author": "username_1",
"text": "This should be reported to https://github.com/harrisiirak/cron-parser",
"title": null,
"type": "comment"
}
] | 2 | 2 | 278 | false | false | 278 | false |
pandas-dev/pandas | pandas-dev | 364,137,189 | 22,840 | null | [
{
"action": "opened",
"author": "dsaxton",
"comment_id": null,
"datetime": 1537983401000,
"masked_author": "username_0",
"text": "In a lot of situations it's useful to remove the redundant or trivial (diagonal) entries from a correlation matrix. For example, if you want to query a correlation matrix to find highly or perfectly correlated columns you have to find some way of manually ignoring the diagonal, or if you want to remove only one of two highly correlated columns, it's useful to be working only with the lower triangular form.\r\n\r\nTherefore I think it would be very useful to add a boolean argument to `DataFrame.corr` which specifies if the lower triangular correlation matrix should be returned (if the upper triangular is desired, the user just takes the transpose) instead of the full.",
"title": "ENH: Allow option to return lower triangular correlation matrix in DataFrame.corr",
"type": "issue"
},
{
"action": "created",
"author": "mroeschke",
"comment_id": 424848160,
"datetime": 1537991670000,
"masked_author": "username_1",
"text": "Copying from the https://github.com/pandas-dev/pandas/pull/22842#issuecomment-424844444\r\n\r\n1. If we were to include a tri argument, I would prefer a tri=None(default)/'upper'/'lower' instead of tri=True/False for just the lower triangular so users can have the option of the upper triangular.\r\n\r\n2. In your implementation, it appears fill value would be NaN as opposed to numpy (triu/trul) which the fill value is 0. I am not sure what the preferred fill value should be, but in general we try to stay consistent with numpy conventions.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aliobeid",
"comment_id": 427773124,
"datetime": 1538991263000,
"masked_author": "username_2",
"text": "correlation a commutative operation i.e. corr(a,b)=corr(b,a). Calculating anything other that a triangle does not make any sense",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aliobeid",
"comment_id": 427777447,
"datetime": 1538992301000,
"masked_author": "username_2",
"text": "Pearson correlation is commutative i.e. corr(X,Y) = corr(Y,X). It makes no sense to calculate anything other than one of the triangles",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jreback",
"comment_id": null,
"datetime": 1541255785000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 5 | 1,470 | false | false | 1,470 | false |
uNetworking/uWebSockets | uNetworking | 412,343,396 | 835 | null | [
{
"action": "opened",
"author": "szmarczak",
"comment_id": null,
"datetime": 1550657273000,
"masked_author": "username_0",
"text": "How does this compare to the [Techempower Benchmark](https://www.techempower.com/benchmarks/)? It's kinda hard to believe the benchmarks you have provided - the source code is incomplete (it lacks code for other HTTP libs).",
"title": "Techempower Benchmark",
"type": "issue"
},
{
"action": "created",
"author": "alexhultman",
"comment_id": 465521045,
"datetime": 1550659227000,
"masked_author": "username_1",
"text": "Please explain, I don't get what you're trying to say. There's no source code specific to any one server, they all share the same exact benchmarking code - the standard wrk tool using default settings.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "szmarczak",
"comment_id": 465572625,
"datetime": 1550669170000,
"masked_author": "username_0",
"text": "Have tried out [autocannon](https://github.com/mcollina/autocannon)? For me it provides more load than `wrk` (about 20k+ more requests when testing Node).\r\n\r\nLooking back at my first question, I'm really curious how `uws` compares to the Techempower Benchmark.\r\nIt would be nice to see it there.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexhultman",
"comment_id": 465591796,
"datetime": 1550672030000,
"masked_author": "username_1",
"text": "This project is not a database or a json serializer.\r\n\r\nSo it makes little sense to benchmark it as if. Besides, TechEmpower cannot properly benchmark high end server software, the top 13 are all separated by nothing but noise. They are all capped by IO.\r\n\r\nFurther on TechEmpower do not properly normalize CPU-time, leading to majorly invalid results where single threaded servers are compared with multithreaded ones, etc.\r\n\r\nIn short TechEmpower is really not a good benchmark. I do my own tests and if they are not enough then do your own tests.\r\n\r\nThis project is not in a phase where it needs to prove anything regarding performance. It's pretty much a well known fact by now.\r\n\r\nI have an upcoming article benchmarking 1 million websockets on a laptop over WiFi. That's the kind of stuff I do.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ddevienne",
"comment_id": 465607244,
"datetime": 1550674071000,
"masked_author": "username_2",
"text": "If you don't mind, could you please post your article in this thread or your main project page?\r\nAlso, for reference, a recent \"1 million websockets\" in Go: https://github.com/eranyanay/1m-go-websockets\r\nI'm eager to read your article!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "szmarczak",
"comment_id": 465640177,
"datetime": 1550678529000,
"masked_author": "username_0",
"text": "Well, you haven't convinced me. Because you say so it doesn't mean it is.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexhultman",
"comment_id": 465644066,
"datetime": 1550679047000,
"masked_author": "username_1",
"text": "I don't need to convince you. You can pay me xxx USD an hour and I will try my hardest. Otherwise, not interested.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexhultman",
"comment_id": 465662318,
"datetime": 1550681528000,
"masked_author": "username_1",
"text": "Published here https://medium.com/@username_1/millions-of-active-websockets-with-node-js-7dc575746a01",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "alexhultman",
"comment_id": null,
"datetime": 1550683846000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "szmarczak",
"comment_id": 465755157,
"datetime": 1550696994000,
"masked_author": "username_0",
"text": "Why did you use `--max-old-space-size=8192` while the app used only 0.5GB? `1024` should be enough in that case.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexhultman",
"comment_id": 465758169,
"datetime": 1550697544000,
"masked_author": "username_1",
"text": "The point being made is you can't do the same with other libs. That process was well over 4 GB",
"title": null,
"type": "comment"
}
] | 3 | 11 | 2,249 | false | false | 2,249 | true |
electron/electron | electron | 435,302,228 | 17,883 | {
"number": 17883,
"repo": "electron",
"user_login": "electron"
} | [
{
"action": "opened",
"author": "nornagon",
"comment_id": null,
"datetime": 1555707359000,
"masked_author": "username_0",
"text": "#### Description of Change\r\nThis rolls Chromium to the first M75 branch in preparation for branching 6-0-x.\r\n\r\n#### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [ ] `npm test` passes\r\n- [ ] tests are [changed or added](https://github.com/electron/electron/blob/master/docs/development/testing.md)\r\n- [ ] relevant documentation is changed or added\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/master/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/master/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: Updated Chromium to 75.0.3770.3",
"title": "chore: bump chromium to 75.0.3770.3",
"type": "issue"
},
{
"action": "created",
"author": "MarshallOfSound",
"comment_id": 485286234,
"datetime": 1555884985000,
"masked_author": "username_1",
"text": "I've retargetted this PR at `6-0-x`",
"title": null,
"type": "comment"
}
] | 3 | 3 | 970 | false | true | 970 | false |
jsxc/jsxc | jsxc | 347,808,855 | 718 | null | [
{
"action": "opened",
"author": "ChristophWurst",
"comment_id": null,
"datetime": 1533540485000,
"masked_author": "username_0",
"text": "Hi,\r\n\r\nas you may have already seen, we have entered the beta phase for the release of Nextcloud 14. We usually try to keep up compatibility with previous app versions, but in some cases apps need some adjustments to properly work on new Nextcloud releases. With Nextcloud 14 there have been quite some changes in that regard:\r\n\r\nYou can find a list of all critical changes for app developers and admins at https://github.com/nextcloud/server/issues/7827. You can run occ app:check-code to validate that there are no issues with deprecated or private message calls.\r\n\r\nOne critical change is the overall restructuring of the main template (https://github.com/nextcloud/server/pull/9982) that might require some adjustments in your app.\r\n\r\nWe would be very pleased if you can make your app compatible with Nextcloud 14 and release a new version to the app store, so that users can properly test it and the upgrade experience to Nextcloud 14 will be even better than before.\r\n\r\nFeel free to ask, if you have any questions regarding making your app compatible with Nextcloud 14.\r\n\r\nThanks for being part of the Nextcloud community and for all the effort you put into providing this app :rocket: .",
"title": "Compatibility with Nextcloud 14",
"type": "issue"
},
{
"action": "created",
"author": "sualko",
"comment_id": 414292801,
"datetime": 1534766595000,
"masked_author": "username_1",
"text": "Thanks for your kind reminder to update ojsxc. After updating Nextcloud to 14 beta.4 my admin settings were gone. Can it be possible that I have to use different section classes for personal and admin section in NC14? Is this an intended behavior or should I open an issue?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ChristophWurst",
"comment_id": 414293926,
"datetime": 1534766847000,
"masked_author": "username_0",
"text": "cc @blizzz @username_2",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "juliushaertl",
"comment_id": 414304431,
"datetime": 1534769224000,
"masked_author": "username_2",
"text": "@username_1 We have renamed some sections. Can you link me to the code, then I can have a look it if is affected.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sualko",
"comment_id": 414305995,
"datetime": 1534769589000,
"masked_author": "username_1",
"text": "https://github.com/nextcloud/jsxc.nextcloud/blob/9f342ec4455ad67f9960a152f28894dc22bd3490/appinfo/info.xml#L45-L50\r\n\r\nI use my own section and discovered that with the linked config only the personal section is shown. If I remove the `personal-section` element my admin section is right back.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sualko",
"comment_id": 414308296,
"datetime": 1534770070000,
"masked_author": "username_1",
"text": "Thanks for looking at it, I will open an issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sualko",
"comment_id": 418275361,
"datetime": 1536047708000,
"masked_author": "username_1",
"text": "OJSXC is now compatible with NC 14.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "sualko",
"comment_id": null,
"datetime": 1536047709000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ChristophWurst",
"comment_id": 418275926,
"datetime": 1536047837000,
"masked_author": "username_0",
"text": "Thank you, @username_1 :v:",
"title": null,
"type": "comment"
}
] | 4 | 10 | 2,484 | false | true | 1,995 | true |
AgileVentures/osra | AgileVentures | 70,131,522 | 365 | {
"number": 365,
"repo": "osra",
"user_login": "AgileVentures"
} | [
{
"action": "opened",
"author": "razorcd",
"comment_id": null,
"datetime": 1429710692000,
"masked_author": "username_0",
"text": "https://osraav.atlassian.net/browse/OSRA-405\r\n\r\n- added Rails Login/Logout functionality using devise gem\r\n- changed devise messages from using `Sign in`/`Sign out` to use `Log in`/`Log out`\r\n- removed AA login functionality (had to)\r\n- replaced HQ cucumber features with rspec features\r\n- added login/logout route specs\r\n- small cosmetic css changes",
"title": "Osra405 hq admin user authentication",
"type": "issue"
},
{
"action": "created",
"author": "razorcd",
"comment_id": 95493733,
"datetime": 1429778928000,
"masked_author": "username_0",
"text": "\r\n\r\n\r\n\r\n\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "razorcd",
"comment_id": 95494199,
"datetime": 1429779054000,
"masked_author": "username_0",
"text": "By default it will load the hq login form. (AA login form/routes removed) But once logged in, it will redirect to AA dashboard.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "razorcd",
"comment_id": 95495697,
"datetime": 1429779363000,
"masked_author": "username_0",
"text": "Notice: because we are not showing the left navbar, the `success` flash message: `Logged out successfully.` is a little off. \r\nAn easy fix would be to just move the flash message just between the header and navbar and remove the border and margin, so it looks more like in AA:\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gmunumel",
"comment_id": 95692779,
"datetime": 1429817279000,
"masked_author": "username_1",
"text": "Looks great :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "razorcd",
"comment_id": 95746562,
"datetime": 1429831624000,
"masked_author": "username_0",
"text": "Hq::Devise and Admin::Devise now run in parallel. ActiveAdmin functionality is not affected.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gmunumel",
"comment_id": 99766067,
"datetime": 1430986466000,
"masked_author": "username_1",
"text": ":shipit:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "razorcd",
"comment_id": 100191628,
"datetime": 1431082267000,
"masked_author": "username_0",
"text": "UPDATE: rspec Feature tests have helper modules for the shared methods.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "razorcd",
"comment_id": 100199177,
"datetime": 1431084522000,
"masked_author": "username_0",
"text": "The only inconvenient for this authorization in rails is that you need to log in in `/admin ` to access the active admin pages and the log in in `/hq` to access the hq pages.\r\nAA and Rails should run in parallel so I think we should keep this behavior.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "robbiejackson",
"comment_id": 100362981,
"datetime": 1431118745000,
"masked_author": "username_2",
"text": "Christian just checking up with you regarding the folder structure. For the controllers you've got devise under app/controllers/hq as app/controllers/hq/devise \r\nbut for the views you've app/views/devise with hq in the middle between views and devise. Is this what you think is best?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "razorcd",
"comment_id": 100539671,
"datetime": 1431202046000,
"masked_author": "username_0",
"text": "@username_2 yes, you are right. I moved `app/views/devise` to `app/views/hq/devise`\r\n\r\nThanks. Good find!",
"title": null,
"type": "comment"
}
] | 3 | 11 | 2,170 | false | false | 2,170 | true |
jlippold/tweakCompatible | null | 311,703,786 | 8,964 | null | [
{
"action": "opened",
"author": "nulloverfl0w",
"comment_id": null,
"datetime": 1522949754000,
"masked_author": "username_0",
"text": "```\r\n{\r\n \"packageId\": \"com.matchstic.xenhtml\",\r\n \"action\": \"working\",\r\n \"userInfo\": {\r\n \"arch32\": false,\r\n \"packageId\": \"com.matchstic.xenhtml\",\r\n \"deviceId\": \"iPhone8,4\",\r\n \"url\": \"http://cydia.saurik.com/package/com.matchstic.xenhtml/\",\r\n \"iOSVersion\": \"10.3.3\",\r\n \"packageVersionIndexed\": false,\r\n \"packageName\": \"Xen HTML\",\r\n \"category\": \"System\",\r\n \"repository\": \"xenpublic.incendo.ws\",\r\n \"name\": \"Xen HTML\",\r\n \"packageIndexed\": true,\r\n \"packageStatusExplaination\": \"A matching version of this tweak for this iOS version could not be found. Please submit a review if you choose to install.\",\r\n \"id\": \"com.matchstic.xenhtml\",\r\n \"commercial\": false,\r\n \"packageInstalled\": true,\r\n \"tweakCompatVersion\": \"0.0.6\",\r\n \"shortDescription\": \"Unified HTML rendering; lockscreen and homescreen\",\r\n \"latest\": \"0.4rc1\",\r\n \"author\": \"Matt Clarke\",\r\n \"packageStatus\": \"Unknown\"\r\n },\r\n \"base64\": \"eyJhcmNoMzIiOmZhbHNlLCJwYWNrYWdlSWQiOiJjb20ubWF0Y2hzdGljLnhlbmh0bWwiLCJkZXZpY2VJZCI6ImlQaG9uZTgsNCIsInVybCI6Imh0dHA6XC9cL2N5ZGlhLnNhdXJpay5jb21cL3BhY2thZ2VcL2NvbS5tYXRjaHN0aWMueGVuaHRtbFwvIiwiaU9TVmVyc2lvbiI6IjEwLjMuMyIsInBhY2thZ2VWZXJzaW9uSW5kZXhlZCI6ZmFsc2UsInBhY2thZ2VOYW1lIjoiWGVuIEhUTUwiLCJjYXRlZ29yeSI6IlN5c3RlbSIsInJlcG9zaXRvcnkiOiJ4ZW5wdWJsaWMuaW5jZW5kby53cyIsIm5hbWUiOiJYZW4gSFRNTCIsInBhY2thZ2VJbmRleGVkIjp0cnVlLCJwYWNrYWdlU3RhdHVzRXhwbGFpbmF0aW9uIjoiQSBtYXRjaGluZyB2ZXJzaW9uIG9mIHRoaXMgdHdlYWsgZm9yIHRoaXMgaU9TIHZlcnNpb24gY291bGQgbm90IGJlIGZvdW5kLiBQbGVhc2Ugc3VibWl0IGEgcmV2aWV3IGlmIHlvdSBjaG9vc2UgdG8gaW5zdGFsbC4iLCJpZCI6ImNvbS5tYXRjaHN0aWMueGVuaHRtbCIsImNvbW1lcmNpYWwiOmZhbHNlLCJwYWNrYWdlSW5zdGFsbGVkIjp0cnVlLCJ0d2Vha0NvbXBhdFZlcnNpb24iOiIwLjAuNiIsInNob3J0RGVzY3JpcHRpb24iOiJVbmlmaWVkIEhUTUwgcmVuZGVyaW5nOyBsb2Nrc2NyZWVuIGFuZCBob21lc2NyZWVuIiwibGF0ZXN0IjoiMC40cmMxIiwiYXV0aG9yIjoiTWF0dCBDbGFya2UiLCJwYWNrYWdlU3RhdHVzIjoiVW5rbm93biJ9\",\r\n \"chosenStatus\": \"working\",\r\n \"notes\": \"\"\r\n}\r\n```",
"title": "`Xen HTML` working on iOS 10.3.3",
"type": "issue"
}
] | 2 | 3 | 2,191 | false | true | 1,949 | false |
JetBrains/resharper-unity | JetBrains | 318,021,696 | 541 | null | [
{
"action": "opened",
"author": "van800",
"comment_id": null,
"datetime": 1524748029000,
"masked_author": "username_0",
"text": "Stacktrace:\r\n\r\n at <unknown> <0xffffffff>\r\n at (wrapper managed-to-native) System.Diagnostics.FileVersionInfo.GetVersionInfo_internal (System.Diagnostics.FileVersionInfo,string) [0x0000c] in <de53a4562d5c41bca99809c83471e659>:0\r\n at System.Diagnostics.FileVersionInfo.GetVersionInfo (string) [0x00019] in <de53a4562d5c41bca99809c83471e659>:0\r\n at JetBrains.ReSharper.Plugins.Unity.Rider.UnityPluginDetector.ExistingInstallation (System.Collections.Generic.List`1<JetBrains.Util.FileSystemPath>) [0x000b5] in <b3856fe5489a42cfa1cb0441a5c57ca3>:0\r\n at JetBrains.ReSharper.Plugins.Unity.Rider.UnityPluginDetector.TryFindOnDisk (JetBrains.Util.FileSystemPath,JetBrains.ReSharper.Plugins.Unity.Rider.UnityPluginDetector/InstallationInfo&) [0x00097] in <b3856fe5489a42cfa1cb0441a5c57ca3>:0\r\n at JetBrains.ReSharper.Plugins.Unity.Rider.UnityPluginDetector.GetInstallationInfo (JetBrains.Util.FileSystemPath) [0x000a3] in <b3856fe5489a42cfa1cb0441a5c57ca3>:0\r\n at JetBrains.ReSharper.Plugins.Unity.Rider.UnityPluginInstaller.InstallPluginIfRequired (System.Collections.Generic.ICollection`1<JetBrains.ProjectModel.IProject>) [0x00072] in <b3856fe5489a42cfa1cb0441a5c57ca3>:0\r\n at JetBrains.ReSharper.Plugins.Unity.Rider.UnityPluginInstaller/<>c__DisplayClass13_0.<JetBrains.ReSharper.Plugins.Unity.ProjectModel.UnresolvedUnityReferencesTracker.IHandler.OnReferenceAdded>b__0 () [0x00000] in <b3856fe5489a42cfa1cb0441a5c57ca3>:0\r\n at JetBrains.Application.Threading.IShellLocksEx.ExecuteWithReadLock (JetBrains.Application.Threading.IShellLocks,System.Action) [0x00027] in <153558c58959475b8ea85863c7bb0527>:0\r\n at JetBrains.Application.Threading.IShellLocksEx/<>c__DisplayClass4_0.<ExecuteOrQueueReadLockEx>b__0 () [0x00000] in <153558c58959475b8ea85863c7bb0527>:0\r\n at JetBrains.Threading.ReentrancyGuardEx/<>c__DisplayClass0_0.<Queue>b__3 () [0x0001c] in <686ba25a59194fd5b52c26390c880580>:0\r\n at JetBrains.Threading.ReentrancyGuard.Execute (string,System.Action) [0x00071] in <686ba25a59194fd5b52c26390c880580>:0\r\n at JetBrains.Threading.ReentrancyGuard.ExecutePendingActions () [0x00053] in <686ba25a59194fd5b52c26390c880580>:0\r\n at JetBrains.Threading.JetDispatcher/Closure.Execute () [0x0008a] in <686ba25a59194fd5b52c26390c880580>:0\r\n at JetBrains.Util.Concurrency.UnixJetDispatcher/UnixJetDispatcherStaticMethods.Run () [0x0001f] in <686ba25a59194fd5b52c26390c880580>:0\r\n at JetBrains.Threading.JetDispatcher.Run () [0x00000] in <686ba25a59194fd5b52c26390c880580>:0\r\n at JetBrains.ReSharper.Host.Product.ReSharperHostMain.Main (JetBrains.DataFlow.Lifetime,JetBrains.ReSharper.Host.Features.Settings.IReSharperHostSettings,JetBrains.Util.ILogger,JetBrains.ReSharper.Host.Features.Components.ShellProtocol,JetBrains.Rider.Model.RdModelRoot,JetBrains.Application.Environment.ApplicationShutdownRequests) [0x00069] in <c2b4ce401bb14246976ea513f1d2c310>:0",
"title": "Rider crash",
"type": "issue"
},
{
"action": "closed",
"author": "van800",
"comment_id": null,
"datetime": 1525204579000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "kappaxbeta",
"comment_id": 511245311,
"datetime": 1563148110000,
"masked_author": "username_1",
"text": "https://stackoverflow.com/questions/56913463/android-studio-crash-on-code-autocomplete\r\n\r\nI just leaf this here because when I google rider unity crash, the link solved my problem :)",
"title": null,
"type": "comment"
}
] | 2 | 3 | 3,049 | false | false | 3,049 | false |
orchidsoftware/platform | orchidsoftware | 298,801,437 | 554 | null | [
{
"action": "opened",
"author": "realkalinux",
"comment_id": null,
"datetime": 1519173350000,
"masked_author": "username_0",
"text": "Hey, I want to translate this project into Turkish.\r\nI'm very good at this, so I want to start with your permission.",
"title": "Request for Turkish translation",
"type": "issue"
},
{
"action": "closed",
"author": "PSalador",
"comment_id": null,
"datetime": 1540439647000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 3 | 389 | false | true | 116 | false |
propelorm/Propel2 | propelorm | 319,534,482 | 1,477 | null | [
{
"action": "opened",
"author": "rauwebieten",
"comment_id": null,
"datetime": 1525264578000,
"masked_author": "username_0",
"text": "I'm trying to generate a schema file from an existing SQL-server database. This database has multiple schema's. There are 2 schema's with a table who share the same name. \r\nfor example dbo.HARDWARE_TYPE and config.HARDWARE_TYPE\r\n\r\nThe propel reverse command throws an error:\r\n```\r\nIn Database.php line 502:\r\n Table \"HARDWARE_TYPE\" declared twice \r\n```",
"title": "database:reverse command on sql server with schema's",
"type": "issue"
}
] | 1 | 1 | 353 | false | false | 353 | false |
pions/webrtc | pions | 403,675,276 | 380 | {
"number": 380,
"repo": "webrtc",
"user_login": "pions"
} | [
{
"action": "opened",
"author": "Sean-Der",
"comment_id": null,
"datetime": 1548659019000,
"masked_author": "username_0",
"text": "Resolves #272",
"title": "Export RTP/RTCP to unique packages",
"type": "issue"
}
] | 2 | 2 | 863 | false | true | 13 | false |
rsmbl/Resemble.js | rsmbl | 397,798,205 | 163 | null | [
{
"action": "opened",
"author": "webjohan",
"comment_id": null,
"datetime": 1547121527000,
"masked_author": "username_0",
"text": "Is there a better way to determine if resemble is runned in node?\r\n\r\nIf you use core.js together with resemble this function:\r\nvar isNode = new Function(\"try {return this===global;}catch(e){return false;}\");\r\nwill return true since core.js adds a global var.",
"title": "Core.js and resemble global var \"collition\"",
"type": "issue"
},
{
"action": "closed",
"author": "jamescryer",
"comment_id": null,
"datetime": 1550942660000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "jamescryer",
"comment_id": 466670904,
"datetime": 1550942660000,
"masked_author": "username_1",
"text": "Should be fixed in v3.0.2",
"title": null,
"type": "comment"
}
] | 2 | 3 | 283 | false | false | 283 | false |
netz98/n98-magerun2 | netz98 | 192,546,560 | 253 | null | [
{
"action": "opened",
"author": "ktomk",
"comment_id": null,
"datetime": 1480506793000,
"masked_author": "username_0",
"text": "When executing Magerun 2 inside a Magento 1 project, it crashes with a fatal error:\r\n\r\n\t$n98-magerun2.phar --version\r\n\tPHP Warning: require_once(www/app/bootstrap.php): failed to open\r\n\tstream: No such file or directory in\r\n\tphar:///home/memyselfandi/bin/n98-magerun2.phar/src/N98/Magento/Application.php on line 745\r\n\r\n\tWarning: require_once(www/app/bootstrap.php): failed to open stream: No\r\n\tsuch file or directory in\r\n\tphar:///home/memyselfandi/bin/n98-magerun2.phar/src/N98/Magento/Application.php on line 745\r\n\tPHP Fatal error: require_once(): Failed opening required\r\n\t'www/app/bootstrap.php' (include_path='.:') in\r\n\tphar:///home/memyselfandi/bin/n98-magerun2.phar/src/N98/Magento/Application.php on line 745\r\n\r\n\tFatal error: require_once(): Failed opening required\r\n\t'www/app/bootstrap.php' (include_path='.:') in\r\n\tphar:///home/memyselfandi/bin/n98-magerun2.phar/src/N98/Magento/Application.php on line 745\r\n\r\nInstead of giving a non-saying fatal-error with some backtrace (on occasion), it would be better to give an error message or prevent the error at all if this fault is caused while detecting Magetno.",
"title": "Fatal error when running Magerun 2 inside a Magento 1 tree",
"type": "issue"
},
{
"action": "closed",
"author": "ktomk",
"comment_id": null,
"datetime": 1480587620000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ktomk",
"comment_id": 264134474,
"datetime": 1480587620000,
"masked_author": "username_0",
"text": "We believe that the bug reported is fixed in the development version. It can be upgraded to it using the `self-update` command with the `--unstable` switch.",
"title": null,
"type": "comment"
}
] | 1 | 3 | 1,276 | false | false | 1,276 | false |
Chatham/Vault.NET | Chatham | 335,734,938 | 26 | null | [
{
"action": "opened",
"author": "NTTLuke",
"comment_id": null,
"datetime": 1530005502000,
"masked_author": "username_0",
"text": "- and the result?.Data is null\r\n\r\n**Other info**\r\nUsing the Vault client with the same user and password , for having the properly token , works fine. \r\nLooking inside the UI , the secret version is v2 but during the debug the client.Secret seems v1. Is it possible ?\r\n\r\nDo you have suggestions ? \r\nThank you",
"title": "Read<T> return warning and null values",
"type": "issue"
},
{
"action": "created",
"author": "chrishoffman",
"comment_id": 400245455,
"datetime": 1530005760000,
"masked_author": "username_1",
"text": "There are different api paths for the v2 api. You need to request your data at ‘secret/data/mongodb’ in kv v2.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "chrishoffman",
"comment_id": null,
"datetime": 1530005760000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "NTTLuke",
"comment_id": 400246420,
"datetime": 1530005963000,
"masked_author": "username_0",
"text": "Thank you",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "chrishoffman",
"comment_id": null,
"datetime": 1530006001000,
"masked_author": "username_1",
"text": "- and the result?.Data is null\r\n\r\n**Other info**\r\n\r\n- Using the Vault client with the same user and password , for having the properly token , works fine. \r\n\r\n- Looking inside the UI , the secret version is v2 but during the debug the client.Secret seems v1. Is it possible ?\r\n\r\nDo you have suggestions ? \r\nThank you",
"title": "Read<T> return warning and null values",
"type": "issue"
},
{
"action": "closed",
"author": "chrishoffman",
"comment_id": null,
"datetime": 1530008481000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "chrishoffman",
"comment_id": 400258102,
"datetime": 1530008481000,
"masked_author": "username_1",
"text": "The data type returned by KVv2 is not `Dictionary<String, String>`, it is `Dictionary<String, Dictionary<String, String>>`. I created some tests to test KVv2 behavior to show usage.\r\n\r\nhttps://github.com/Chatham/Vault.NET/pull/27",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "apuchkov",
"comment_id": 815262268,
"datetime": 1617829468000,
"masked_author": "username_2",
"text": "I think it worth adding a sample in a readme to show how to get secrets from kv2.\r\n\r\nI just tried to use this library for the first time following the readme and ran into the same two problems:\r\n - having a path without a \"data\" in it (StackOverflow helped with that)\r\n - then getting exception \"Unexpected character encountered while parsing value: {. Path 'data.data', line 1, position 120.)\" (luckily found this ticket after going through issues one be one)",
"title": null,
"type": "comment"
}
] | 3 | 8 | 1,434 | false | false | 1,434 | false |
mholt/caddy | null | 392,066,904 | 2,394 | null | [
{
"action": "opened",
"author": "lukenowak",
"comment_id": null,
"datetime": 1545125451000,
"masked_author": "username_0",
"text": "### 1. What version of Caddy are you using (`caddy -version`)?\r\n\r\nCaddy 0.11.1 (non-commercial use only) \r\n\r\n\r\n### 2. What are you trying to do?\r\n\r\nAccess caddy with QUIC protocol after sending it `USR1` signal\r\n\r\n### 3. What is your entire Caddyfile?\r\n```text\r\nhttps://example.com:16443 {\r\n bind 127.0.0.1\r\n tls self_signed\r\n}\r\n```\r\n\r\n### 4. How did you run Caddy (give the full command and describe the execution environment)?\r\n\r\n`./caddy -log stdout -quic &`\r\n\r\nDebian Jessie.\r\n\r\n### 5. Please paste any relevant HTTP request(s) here.\r\n\r\n```\r\nquic_client --disable-certificate-verification --host=127.0.01 --port=16443 https://example.com > /dev/null\r\nkill -USR1 %1\r\nquic_client --disable-certificate-verification --host=127.0.01 --port=16443 https://example.com > /dev/null\r\n```\r\nAfter sending USR1 signal I see such output in the output:\r\n```\r\n2018/12/18 10:26:46 [INFO] SIGUSR1: Reloading\r\n2018/12/18 10:26:46 [INFO] Reloading\r\n2018/12/18 10:26:46 [INFO] Reloading complete\r\n2018/12/18 10:26:46 serving QUIC connections: server closed\r\n```\r\n\r\n### 6. What did you expect to see?\r\n\r\nTwo times `Request failed (404).` as result of quic_client.\r\n\r\n### 7. What did you see instead (give full error messages and/or log)?\r\n\r\nFirst `Request failed (404).`, then after sending `USR1` to Caddy it ended with `Failed to connect to 127.0.0.1:16443. Error: QUIC_NETWORK_IDLE_TIMEOUT`\r\n\r\n### 8. How can someone who is starting from scratch reproduce the bug as minimally as possible?\r\n\r\n```\r\ncat > Caddyfile\r\nhttps://example.com:16443 {\r\n bind 127.0.0.1\r\n tls self_signed\r\n}\r\n^D\r\n./caddy -log stdout -quic &\r\n```\r\n\r\n_Note_: My `quic_client` is `client-linux-debug` from https://github.com/lucas-clemente/quic-go",
"title": "Caddy does not reply with QUIC after USR1",
"type": "issue"
},
{
"action": "created",
"author": "mholt",
"comment_id": 456477769,
"datetime": 1548176475000,
"masked_author": "username_1",
"text": "I've been able to reproduce it and am looking into it, however, might need some guidance from @username_2. https://github.com/lucas-clemente/quic-go/issues/1743\r\n\r\nIt seems that the QUIC library does not assign a new \"server\" when it sees a new connection ID after the reloads.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "marten-seemann",
"comment_id": 456480034,
"datetime": 1548176807000,
"masked_author": "username_2",
"text": "I'll have a look at this issue tomorrow.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mholt",
"comment_id": 457865248,
"datetime": 1548536116000,
"masked_author": "username_1",
"text": "We're both investigating this now! (Thanks for your help, Marten!)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bprodoehl",
"comment_id": 472267693,
"datetime": 1552448473000,
"masked_author": "username_3",
"text": "I am still seeing this bug with 0.11.5. Did you guys happen to get anywhere in your investigation of the issue?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hoswey",
"comment_id": 479825724,
"datetime": 1554370628000,
"masked_author": "username_4",
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lukenowak",
"comment_id": 508474124,
"datetime": 1562245194000,
"masked_author": "username_0",
"text": "I just checked the behaviour with Caddy 1.0.0, and it seems QUIC correctly replies after SIGUSR1 and configuration reload. Is it only partially fixed or works by chance?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lukenowak",
"comment_id": 508480927,
"datetime": 1562246554000,
"masked_author": "username_0",
"text": "I was wrong, it does not work, I made wrong test :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mholt",
"comment_id": 593650099,
"datetime": 1583187141000,
"masked_author": "username_1",
"text": "Should be fixed in v2 now.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mholt",
"comment_id": null,
"datetime": 1583187141000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 5 | 10 | 2,550 | false | false | 2,550 | true |
gaearon/react-hot-loader | null | 287,642,895 | 782 | null | [
{
"action": "opened",
"author": "aaronjensen",
"comment_id": null,
"datetime": 1515637505000,
"masked_author": "username_0",
"text": "Hi, we're testing out react-hot-loader@next and weren't able to get it working with redbox as we had it before. Ideally we could use it w/ create-react-app's react-error-overlay. Has anyone done this? My attempts at it were unsuccessful.\r\n\r\nThanks!",
"title": "How to use next with react-error-overlay?",
"type": "issue"
},
{
"action": "created",
"author": "theKashey",
"comment_id": 356820647,
"datetime": 1515644472000,
"masked_author": "username_1",
"text": "`errorReporter` prop should still work fine.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aaronjensen",
"comment_id": 356823955,
"datetime": 1515646027000,
"masked_author": "username_0",
"text": "Maybe I was doing it wrong, but the setup I had from RHL3 didn't work. I was doing this in my src/index:\r\n\r\n```js\r\n// @flow\r\nimport * as React from 'react'\r\nimport ReactDOM from 'react-dom'\r\nimport { AppContainer } from 'react-hot-loader'\r\nimport Redbox from 'redbox-react'\r\nimport { getRoot } from '@@common'\r\nimport App from '@@app-ui/components/App'\r\nimport type { Config } from '@@app-ui/config'\r\n\r\nconst CustomErrorReporter = ({ error }) => <Redbox error={error} />\r\nconst render = (Component, config: Config) => {\r\n ReactDOM.render(\r\n <AppContainer errorReporter={CustomErrorReporter}>\r\n <Component config={config} />\r\n </AppContainer>,\r\n getRoot(),\r\n )\r\n}\r\n\r\nlet storedConfig: void | Config\r\nexport const startApp = (config: Config) => {\r\n storedConfig = config\r\n render(App, config)\r\n}\r\n\r\nif (module.hot) {\r\n module.hot.accept('@@app-ui/components/App', () => {\r\n if (storedConfig) {\r\n render(App, storedConfig)\r\n }\r\n })\r\n}\r\n\r\nexport default startApp\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "theKashey",
"comment_id": 356825186,
"datetime": 1515646591000,
"masked_author": "username_1",
"text": "It does not show RedBox or literally does not work?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aaronjensen",
"comment_id": 356825374,
"datetime": 1515646681000,
"masked_author": "username_0",
"text": "RedBox works, but react-hot-loader does not. It doesn't refresh the page, but it blows away the render tree",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "theKashey",
"comment_id": 356840436,
"datetime": 1515652587000,
"masked_author": "username_1",
"text": "Wow! That unfair. \r\nCan you provide more data how to repeat this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "aaronjensen",
"comment_id": 356844750,
"datetime": 1515654253000,
"masked_author": "username_0",
"text": "Sorry, to be clear by \"blows away the render tree\" what I meant was that it rerenders from scratch, scrapping any previous state. I'll see if I can put a repro together, though after trying w/ the webpack-modern example I couldn't reproduce what I'm seeing so I'll try and debug a little further on my repo first.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "TheAifam5",
"comment_id": 357456320,
"datetime": 1515868427000,
"masked_author": "username_2",
"text": "So I wrote also my own \"RedBox\" and after update to the new version, does not work anymore.\r\nAlso I set the RHL log level to debug but that does not help (no info).\r\nI will try provide more information later (in 30 minutes) - gonna do some debugging.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "theKashey",
"comment_id": 357469121,
"datetime": 1515879395000,
"masked_author": "username_1",
"text": "One should pursue ts-loader. It somehow breaks webpack's HRM.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "neoziro",
"comment_id": 359381924,
"datetime": 1516616635000,
"masked_author": "username_3",
"text": "I would like to deprecate `errorReporter`, try to add a custom [Error Boundary](https://reactjs.org/blog/2017/07/26/error-handling-in-react-16.html) in your root component (just after `hot` or `AppContainer`) and it should work.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "neoziro",
"comment_id": null,
"datetime": 1516637394000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "neoziro",
"comment_id": 359473695,
"datetime": 1516637394000,
"masked_author": "username_3",
"text": "Documented in [v4.0.0-beta.17](https://github.com/gaearon/react-hot-loader/releases/tag/v4.0.0-beta.17).",
"title": null,
"type": "comment"
}
] | 4 | 12 | 2,465 | false | false | 2,465 | false |
f-miyu/Plugin.CloudFirestore | null | 452,060,610 | 6 | null | [
{
"action": "opened",
"author": "manuel-mariani",
"comment_id": null,
"datetime": 1559661752000,
"masked_author": "username_0",
"text": "",
"title": "How to add a document with a specific Id?",
"type": "issue"
},
{
"action": "created",
"author": "manuel-mariani",
"comment_id": 499388708,
"datetime": 1559807551000,
"masked_author": "username_0",
"text": "Found the solution!\r\nYou have to do\r\n`await CrossCloudFirestore.Current.Instance\r\n .GetCollection(\"<your collection>\")\r\n .GetDocument(\"<custom id>\")\r\n .SetDataAsync(<your model with data>, null);`",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "manuel-mariani",
"comment_id": null,
"datetime": 1559807555000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "manuel-mariani",
"comment_id": 500570858,
"datetime": 1560196599000,
"masked_author": "username_0",
"text": "Edit: if that doesn't work or you get duplicates with different id you can use \r\n`await CrossCloudFirestore.Current.Instance .GetCollection(\"<your collection>\") .GetDocument(\"<custom id>\") .UpdateDataAsync(<your model with data>);`",
"title": null,
"type": "comment"
}
] | 1 | 4 | 550 | false | false | 550 | false |
mraynauld/ProjetBidon | null | 367,257,430 | 1 | {
"number": 1,
"repo": "ProjetBidon",
"user_login": "mraynauld"
} | [
{
"action": "opened",
"author": "mraynauld",
"comment_id": null,
"datetime": 1538752824000,
"masked_author": "username_0",
"text": "Convertir les sections en titre\r\nIntégrer Branche 1 dans Master",
"title": "Convertir les sections en titre",
"type": "issue"
},
{
"action": "created",
"author": "FHuchet",
"comment_id": 427408030,
"datetime": 1538753868000,
"masked_author": "username_1",
"text": "J'approuve les corrections.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 90 | false | false | 90 | false |
spinnaker/deck | spinnaker | 274,910,537 | 4,474 | {
"number": 4474,
"repo": "deck",
"user_login": "spinnaker"
} | [
{
"action": "opened",
"author": "ethanfrogers",
"comment_id": null,
"datetime": 1510934164000,
"masked_author": "username_0",
"text": "adds support for running jobs with multiple containers. will convert\r\nexisting `container` usage to `containers`\r\n\r\nspinnaker/spinnaker#1961\r\n\r\n@danielpeach PTAL. for real this time. this is the final round of run job work.",
"title": "feat(provider/kubernetes): runJob multi container",
"type": "issue"
},
{
"action": "created",
"author": "ethanfrogers",
"comment_id": 345284650,
"datetime": 1510934601000,
"masked_author": "username_0",
"text": "## W/ Multiple Containers\r\n\r\n\r\n## Modal\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ethanfrogers",
"comment_id": 345358703,
"datetime": 1510950970000,
"masked_author": "username_0",
"text": "comments addressed!\r\n\r\nThe move from `container` -> `containers` is a bit concerning but everything should still work. The next time users make edits to the stage, it should get converted.",
"title": null,
"type": "comment"
}
] | 1 | 3 | 670 | false | false | 670 | false |
kean/Nuke | null | 392,063,541 | 206 | null | [
{
"action": "opened",
"author": "gabors",
"comment_id": null,
"datetime": 1545124934000,
"masked_author": "username_0",
"text": "Looks like on macOS this never displays an image if I use a fadeIn transition\r\n\r\n`Nuke.loadImage(\r\n with: imageRequest,\r\n options: ImageLoadingOptions(\r\n placeholder: placeholderImage,\r\n transition: .fadeIn(duration: 0.33)\r\n ),\r\n into: imageView)\r\n`\r\nyet on iOS/tvOS it works great.\r\nOn macOS as soon as I remove the whole options parameter, images show up fine.",
"title": "macOS Nuke.loadImage",
"type": "issue"
},
{
"action": "created",
"author": "kean",
"comment_id": 448154569,
"datetime": 1545125346000,
"masked_author": "username_1",
"text": "Seems be an issue with fade transition on macOS, would appreciate an MR.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gabors",
"comment_id": 448155087,
"datetime": 1545125451000,
"masked_author": "username_0",
"text": "Простите а \"MR\" енто что?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gabors",
"comment_id": 448158002,
"datetime": 1545126025000,
"masked_author": "username_0",
"text": "Looked at your code for the macOS fade transition.\r\nWill try to make it work.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kean",
"comment_id": 448165199,
"datetime": 1545127412000,
"masked_author": "username_1",
"text": "Sorry, I got used to the terminology we use at work (MR - Merge Request). PR - Pull Request.\r\n\r\nYep, seems perfect, I think that's what I'm using except that I forgot to display the actual image 😁",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gabors",
"comment_id": 448165593,
"datetime": 1545127492000,
"masked_author": "username_0",
"text": "Lol. Happens.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "kean",
"comment_id": null,
"datetime": 1545823075000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "kean",
"comment_id": 449952001,
"datetime": 1545823075000,
"masked_author": "username_1",
"text": "Fixed in [7.5.2](https://github.com/username_1/Nuke/releases/tag/7.5.2)",
"title": null,
"type": "comment"
}
] | 2 | 8 | 908 | false | false | 908 | true |
guardian/dotcom-rendering | guardian | 368,683,784 | 206 | {
"number": 206,
"repo": "dotcom-rendering",
"user_login": "guardian"
} | [
{
"action": "opened",
"author": "MatthewJWalls",
"comment_id": null,
"datetime": 1539180402000,
"masked_author": "username_0",
"text": "## What does this change?\r\n\r\nWe want to use i.guim links for images in the article body. In frontend, this is done by a cleaner, so we need to use the cleaned version of the html in dotcomponents instead of the raw stuff from capi. \r\n\r\nWe already have a field for this on the model so we can just hopefully switch to using the cleaned html and it should work.\r\n\r\nThis work does not cover the main media image yet, we'll need to think of a separate solution for that I think.\r\n\r\nhttps://www.theguardian.com/artanddesign/2018/sep/13/diana-funeral-re-enacted-salford-jill-dando-mariachi-band-princess-wales is a good article to test with as it has multiple body images.\r\n\r\n## Why?",
"title": "Use cleaned html for body and main",
"type": "issue"
},
{
"action": "created",
"author": "SiAdcock",
"comment_id": 429311837,
"datetime": 1539348047000,
"masked_author": "username_1",
"text": "I'm a bit sad about moving away from the block here, for the sake of using correct image URLs. As we were discussing earlier, maybe it would be better to pass the `body` and `main` fields through image cleaners in frontend, and sending the result to dotcom-rendering?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MatthewJWalls",
"comment_id": 429320117,
"datetime": 1539349832000,
"masked_author": "username_0",
"text": "@username_1 Yeah I agree I'll close this and maye we can dolfd the improvements into the datamodel changes",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,048 | false | false | 1,048 | true |
solvebio/solvebio-python | solvebio | 195,372,098 | 120 | null | [
{
"action": "opened",
"author": "dandanxu",
"comment_id": null,
"datetime": 1481664126000,
"masked_author": "username_0",
"text": "Instead of necessarily a local file (as it is now). It'd be convenient not have to reupload a large file when trying out a different template :).",
"title": "Allow `solvebio import` shortcut to take a upload id",
"type": "issue"
},
{
"action": "closed",
"author": "jsh2134",
"comment_id": null,
"datetime": 1501249845000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "jsh2134",
"comment_id": 318657115,
"datetime": 1501249845000,
"masked_author": "username_1",
"text": "Uploads are deprecated and will be removed in future minor versions",
"title": null,
"type": "comment"
}
] | 2 | 3 | 212 | false | false | 212 | false |
glotzerlab/signac | glotzerlab | 446,699,309 | 197 | null | [
{
"action": "opened",
"author": "csadorf",
"comment_id": null,
"datetime": 1558454146000,
"masked_author": "username_0",
"text": "Based on feature usage, the project root directory currently contains a number of special files. Some of them are hidden, some are not.\r\n\r\n- signac_project_document.json\r\n- signac.rc\r\n- .signac_sp_cache.json.gz\r\n- .signac_history.txt\r\n\r\nAs suggested by @username_1 we may want to switch to a more compact storage format, for example by bundling all files within a `.signac` folder.",
"title": "Use more compact schema for root directory files",
"type": "issue"
},
{
"action": "created",
"author": "vyasr",
"comment_id": 591568600,
"datetime": 1582741141000,
"masked_author": "username_1",
"text": "@username_2 @username_4 thoughts on this issue? I think this would be relatively straightforward to implement, the bigger question is what tradeoffs there are. For example, making this change would effectively discourage direct modification of the signac.rc file, for instance to change the workspace (you would have to go through the config API). Personally I think this is a good thing and would want to follow git's example; you can always modify .git/config if you know what you're doing, but it's better to put up some barriers to this for less-experienced users IMO.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bdice",
"comment_id": 591582818,
"datetime": 1582743047000,
"masked_author": "username_2",
"text": "I propose:\r\n- Keep `signac.rc` and project/job state point/document/data files clearly visible with the current name scheme.\r\n- Place all caches and shell history files in a `.signac` directory.\r\n- Recommend adding `.signac` to `.gitignore`.\r\n\r\nI believe that the clear visibility of signac files (aside from caches/shell history files) is a good thing, especially for new users learning to navigate the data space.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vyasr",
"comment_id": 591585280,
"datetime": 1582743363000,
"masked_author": "username_1",
"text": "I'm mostly in agreement. All JSON document files should be visible, all internally generated caches etc should be hidden. The only file I'm not 100% sure about is signac.rc, since we tend to mirror git a lot and `.git` is hidden. I could see going either way with this file, so I'll defer to others if you have preferences.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "b-butler",
"comment_id": 591610463,
"datetime": 1582746549000,
"masked_author": "username_3",
"text": "I think that having one way to modify the configuration is best for new users. Thus I would suggest putting `signac.rc` in the `.signac` folder while exposing the settings through the config API.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "csadorf",
"comment_id": 591610571,
"datetime": 1582746562000,
"masked_author": "username_0",
"text": "Agreed, I'm not so sure about the config file either.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikemhenry",
"comment_id": 592756305,
"datetime": 1582928568000,
"masked_author": "username_4",
"text": "I will have to think about this a bit. I like how clean it would be to keep `signac.rc` under source control, and just ignore `.signac/`. But if we want to 'hide' `signac.rc` from new users/let people live theirs lives without seeing it, perhaps `.signac.rc` (or even `.signacrc`) would be a good compromise. That way the file is still 'hidden' but it would be easy to keep it tracked in source control, and then users can with confidence know anything in the `.signac/` folder isn't critical.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "atravitz",
"comment_id": 725744422,
"datetime": 1605141264000,
"masked_author": "username_5",
"text": "I like this suggestion a lot. Is there anything blocking us from making this change now?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "csadorf",
"comment_id": 725962421,
"datetime": 1605173881000,
"masked_author": "username_0",
"text": "I think what we need is some super basic guidelines for developers on how this folder is to be used. For example, should files related to _flow_ be placed in `.signac/flow/` or can they just go into `.signac/`? What about the \"core\" files, do they go into the root directory or into `.signac/core/`? So, I'd suggest that we compile all the files that we currently have, make a complete proposal as to how to structure them, derive some very basic rules regarding namespaces that can be applied in the future, and then we can assess whether we want to immediately implement that in a backwards compatible way or whether we just break with 2.0 and then require the new structure. Either way, we would want to have an automated migration path.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bdice",
"comment_id": 727297710,
"datetime": 1605407397000,
"masked_author": "username_2",
"text": "Here's an attempt at compiling and organizing all the project-wide files. Feel free to edit this comment if I missed something and you have privileges to edit on my behalf.\r\n\r\n| Path | Code/Data | .gitignore? | Suitable for .signac? | Package |\r\n|------------------------------|-----------|-------------|-----------------------|---------|\r\n| .bundles | Data | Yes | Yes | flow |\r\n| .signac_shell_history | Data | Yes | Yes | core |\r\n| .signac_sp_cache.json.gz | Data | Yes | Yes | core |\r\n| signac.rc | Code? | Yes/No? | No | core |\r\n| signac_data.h5 | Data | Yes | No | core |\r\n| signac_project_document.json | Data | Yes | No | core |\r\n| workspace | Data | Yes | No | core |\r\n\r\nMy reasoning for the columns I included: It should be easy to separate code and data. I try keep a relatively strict separation and commit code but do not commit data. I consider the information in `signac.rc` to be somewhere between the two and I honestly don't know whether to recommend committing it (in practice, I don't think that I usually commit `signac.rc`). However, there are important semantic differences among the data files, so I broke it out into \"Suitable for .signac?\". Data managed by the framework (likely intended for long-term archival) shouldn't be treated the same as temporary cache info that could be re-generated.\r\n\r\nI propose this set of rules:\r\n- `signac.rc` shall contain project configuration and settings (retain current behavior).\r\n- The `.signac` directory shall be used for optional caches or state information that would not be recommended to commit to source control.\r\n - This includes command histories or temporary execution information like `.bundles`.\r\n - A hypothetical example would be temporary files or caches generated by signac-dashboard.\r\n- The `.signac` directory shall **not** be used for project data managed by the framework (e.g. the project document or HDF5 data).\r\n- `.signac` shall only contain files or subdirectories with pre-determined names, not arbitrary or user-defined names.\r\n - Subdirectories of `.signac` may contain files or subdirectories with arbitrary names (e.g. files named according to a job id or scheduler job number).\r\n- Names of files in `.signac` do not need to begin with a period or contain the word \"signac\" because they are already prefixed with `.signac/`.\r\n - For example, I recommend renaming `.signac_sp_cache.json.gz` to `.signac/statepoint_cache.json.gz`.\r\n\r\nConsequences that should follow from these rules:\r\n- Removing files in `.signac` should have a relatively low impact on the project.\r\n- `.signac` should be safe to add to `.gitignore`.\r\n\r\nI think @username_0's proposal of namespaces (subdirectories in `.signac`) is worth considering but might be an unnecessary layer. I think we can safely assume that framework developers can coordinate as needed to avoid conflict between filenames (we've had no trouble in the root directory, and it only gets easier to manage in a hidden subdirectory).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vyasr",
"comment_id": 727496631,
"datetime": 1605415161000,
"masked_author": "username_1",
"text": "I won't have time to think more about this for a while, so when I saw this comment I figured I'd add my thoughts now (I also added the signac_statepoints.json file to the table).\r\n\r\nWhile source control is something to consider, and code vs data is an important distinction, I think what determines whether or not something belongs in `.signac` is based on the mission statement of signac: providing organization for data on the filesystem that can then be accessed _with or without signac_. That reasoning establishes a clear dividing line: all data and information describing its organization (the workspace, statepoints, hdf5 stores, project doc/store, etc) must be visible, while any intermediate or cache file generated by signac that would not be necessary for a non-signac user to interpret the data space can be hidden in `.signac`. This reasoning does not change any of the rules @username_2 proposes, it just places a different emphasis on how to think about them. It also says nothing about the internal organization of `.signac`; the suggestion that subdirectories must be used for arbitrarily named files is fine with me, it would help keep things cleaner.\r\n\r\nFrom that perspective, and knowing how `signac.rc` is currently used, there is only one reason why `signac.rc` needs to be visible: the need to know the workspace. To my knowledge there is no other configuration information stored in `signac.rc` that is relevant to parsing the data. The fact that the workspace is configurable is what makes this dividing line blurry, since that has immediate implications on how to parse the data (for instance, if there are folders workspace1 to workspace10 and they all contain different data, which is the active workspace?). That makes me wonder how useful the ability to configure the workspace directory is. Given that you can always just move the current workspace to a different location and make a new directory (or symlink one), what is the benefit of this feature? IMO if we removed that, then `signac.rc` would be a candidate to move into `.signac`. The only other benefit to having it there is to be able to see whether a directory is a signac project, but I don't think that's a very strong argument since you can just as easily look for `.signac`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "csadorf",
"comment_id": 728206031,
"datetime": 1605547307000,
"masked_author": "username_0",
"text": "I mostly agree with @username_2 's rules and I also agree with @username_1 ' assessment and slight shift in perspective. I also agree that removing the ability to change the workspace would probably make a lot of sense not only in this context, but also in general (this has been proposed and discussed before).\r\n\r\nWith this I suggest the following addendum to the so far proposed rules:\r\n1. Configuration files within a project root directory are placed in `.signac/config`.\r\n2. The project workspace is *always* `$PROJECT_ROOT/workspace` (could be a separate change).\r\n3. A project root directory is defined as the parent directory of a directory named `.signac`.\r\n\r\nThis has the following advantages:\r\n1. Our git-analogy is even better adhered to (compare `.git/config` etc.)\r\n2. For a user who does not use signac, it does not matter what workspace is active or whatever, really only the data matters.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cbkerr",
"comment_id": 754184633,
"datetime": 1609790315000,
"masked_author": "username_6",
"text": "I like the idea that I can delete the `.signac` file and signac will just regenerate cache files, etc.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vyasr",
"comment_id": 754196574,
"datetime": 1609791670000,
"masked_author": "username_1",
"text": "That's a valid argument for allowing configuration of the variable. I still think that the benefits of a standardized schema may outweigh this, since then it doesn't rely on user documentation at all. It would also allow us to specify a much more explicit data model in a way that would allow us to change the data layout much more easily in the future, which would be very valuable for some of the generalizations originally proposed in the signac 2.0 prototype. We can always discuss this specific configuration independently of the other parts of this issue, though.\r\n\r\nRegarding whether users will be familiar enough with git to know to look for a .git file, I don't really think that's super relevant. Mirroring git is a nice design pattern for us, but from a user perspective what really matters is whether users know how to figure out if something is a signac directory. Teaching a user to look for `.signac` is marginally harder than teaching them to look for `signac.rc` (`ls -a` vs `ls`), but in either case it's something we'd be teaching in a tutorial so I think it's fine.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vyasr",
"comment_id": 786925614,
"datetime": 1614378202000,
"masked_author": "username_1",
"text": "@glotzerlab/signac-committers I'm wondering what we should do with the `signac_statepoints.json` file. Currently, every method of the Project that uses this file can be pointed to a different filename if necessary, but ultimately it boils down to functioning like another state point cache, but one that is more \"trusted\". If the file exists, the internal `_get_statepoint` method can read from this file if a given state point is found neither in the state point cache, nor on disk. Similarly, the `repair` method can use this file to reconstruct the data space if anything has been corrupted. However, I've never seen any of this functionality put to use, and I'm not sure that as a user I would know when I had a `signac_statepoints.json` file whose contents I trusted more than the actual data space. \r\n\r\nThe `write_statepoints` method can be used to generate this file, or alternatively store the same data into a different filename provided by the user. I can imagine that functionality possibly being useful, but I'm not sure about the rest. How should we deal with this? I'm leaning towards removing most (if not all) logic associated with it, but I could be overlooking significant benefits that it confers. If we want to keep it, though, we do need to address where the file should live; the \"default\" file should perhaps be within `.signac`, but users can also write to a custom file, which would not be hidden. This dichotomy seems odd to me.\r\n\r\n @username_0 in case you had specific goals in mind when adding this feature let us know!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bdice",
"comment_id": 786932462,
"datetime": 1614379035000,
"masked_author": "username_2",
"text": "I think you would know that repairs from a state point cache are needed if signac raised an error when opening jobs/reading state points.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vyasr",
"comment_id": 786942205,
"datetime": 1614380895000,
"masked_author": "username_1",
"text": "Yes, I agree that you'd know when repairs are necessary. The thing I don't know is how you would know whether to trust the `signac_statepoints.json` file. For all you know it could be vastly out-of-date, or contain state points that are no longer desired.",
"title": null,
"type": "comment"
}
] | 8 | 18 | 13,017 | false | true | 12,845 | true |
draios/falco | draios | 365,482,707 | 430 | null | [
{
"action": "opened",
"author": "B3DTech",
"comment_id": null,
"datetime": 1538403365000,
"masked_author": "username_0",
"text": "The Wiki documentation for installation says that there is an example yaml file for K8S, but the link is dead and I don't see it in the source tree.",
"title": "K8S example missing",
"type": "issue"
},
{
"action": "created",
"author": "mfdii",
"comment_id": 425951376,
"datetime": 1538407834000,
"masked_author": "username_1",
"text": "Sorry, we've move the examples to integrations.\n\nhttps://github.com/draios/falco/tree/dev/integrations",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mstemm",
"comment_id": 436088527,
"datetime": 1541464606000,
"masked_author": "username_2",
"text": "I've updated the wiki, so closing this issue.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mstemm",
"comment_id": null,
"datetime": 1541464606000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 4 | 295 | false | false | 295 | false |
sleuthkit/autopsy | sleuthkit | 95,395,494 | 1,436 | null | [
{
"action": "opened",
"author": "lifayk",
"comment_id": null,
"datetime": 1437039973000,
"masked_author": "username_0",
"text": "Fresh installation of Autopsy 3.1.3\r\nI created a new case and clicked on Add data source and get this:\r\n\r\nTraceback (most recent call last):\r\n File \"C:\\Soft\\Autopsy-3.1.3\\autopsy\\modules\\ext\\jython-standalone-2.7.0.jar\\Lib\\site.py\", line 585, in <module>\r\n File \"C:\\Soft\\Autopsy-3.1.3\\autopsy\\modules\\ext\\jython-standalone-2.7.0.jar\\Lib\\site.py\", line 567, in main\r\n File \"C:\\Soft\\Autopsy-3.1.3\\autopsy\\modules\\ext\\jython-standalone-2.7.0.jar\\Lib\\site.py\", line 300, in addusersitepackages\r\n File \"C:\\Soft\\Autopsy-3.1.3\\autopsy\\modules\\ext\\jython-standalone-2.7.0.jar\\Lib\\site.py\", line 289, in getusersitepackages\r\n File \"C:\\Soft\\Autopsy-3.1.3\\autopsy\\modules\\ext\\jython-standalone-2.7.0.jar\\Lib\\sysconfig.py\", line 416, in get_path\r\n File \"C:\\Soft\\Autopsy-3.1.3\\autopsy\\modules\\ext\\jython-standalone-2.7.0.jar\\Lib\\sysconfig.py\", line 407, in get_paths\r\n File \"C:\\Soft\\Autopsy-3.1.3\\autopsy\\modules\\ext\\jython-standalone-2.7.0.jar\\Lib\\sysconfig.py\", line 180, in _expand_vars\r\n File \"C:\\Soft\\Autopsy-3.1.3\\autopsy\\modules\\ext\\jython-standalone-2.7.0.jar\\Lib\\sysconfig.py\", line 154, in _subst_vars\r\n File \"C:\\Soft\\Autopsy-3.1.3\\autopsy\\modules\\ext\\jython-standalone-2.7.0.jar\\Lib\\sysconfig.py\", line 154, in _subst_vars\r\nUnicodeEncodeError: 'ascii' codec can't encode characters in position 9-21: ordinal not in range(128)",
"title": "Add data source issue",
"type": "issue"
},
{
"action": "created",
"author": "bcarrier",
"comment_id": 121950888,
"datetime": 1437052080000,
"masked_author": "username_1",
"text": "Did you write a python module or install one? Those modules get loaded and parsed when the Add Data Source button is pressed.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lifayk",
"comment_id": 121952179,
"datetime": 1437052409000,
"masked_author": "username_0",
"text": "No. I just downloaded distr from official site (sourceforge) for x64 and installed it on Windows 2012 R2. No additional configuration.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bcarrier",
"comment_id": 122901865,
"datetime": 1437402318000,
"masked_author": "username_1",
"text": "Do you have Python installed anywhere else on your system? We can't recreate this here, but some googling seems to be that this can be from the library we are using for Python support is looking on the system for other Python code and is hitting a path name that has non-ASCII characters in it. Any ideas on what that path could be?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kefir-",
"comment_id": 122919842,
"datetime": 1437406524000,
"masked_author": "username_2",
"text": "Is the C:\\Soft\\ just a custom install location instead of for instance C:\\Program Files?\r\n\r\nCould there be any other path components that have non-ascii characters? What is your user name, for instance?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lifayk",
"comment_id": 123199139,
"datetime": 1437463943000,
"masked_author": "username_0",
"text": "No, I don't have any other Python installations. \r\nThe problem was that my profile name had non-English characters. I've renamed my account name in c:\\Users\\<ProfileName>. Now it's ok. The issue is solved.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "lifayk",
"comment_id": null,
"datetime": 1437463944000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "kefir-",
"comment_id": 123272943,
"datetime": 1437478139000,
"masked_author": "username_2",
"text": "That should be resolved in the code, rather than requiring ascii-only user names.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lifayk",
"comment_id": 123287693,
"datetime": 1437481221000,
"masked_author": "username_0",
"text": "Agree.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bcarrier",
"comment_id": 123302312,
"datetime": 1437484886000,
"masked_author": "username_1",
"text": "Thanks for helping to diagnose. We'll try to recreate this and see if we can change the Jython code to not consider this a fatal error.",
"title": null,
"type": "comment"
}
] | 3 | 10 | 2,557 | false | false | 2,557 | false |
graphql/graphql-relay-js | graphql | 310,782,686 | 207 | null | [
{
"action": "opened",
"author": "amit1911",
"comment_id": null,
"datetime": 1522751872000,
"masked_author": "username_0",
"text": "I have a scenario where I need to validate if the user is allowed to perform a certain mutation or not. If the user isn't allowed to perform the mutation, then I would like to pass some errors to the client side so that I can show more descriptive messages. How can I do this?",
"title": "How to throw errors from mutateAndGetPayload function?",
"type": "issue"
},
{
"action": "closed",
"author": "amit1911",
"comment_id": null,
"datetime": 1522915637000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 276 | false | false | 276 | false |
dcos/dcos | dcos | 268,091,239 | 2,039 | {
"number": 2039,
"repo": "dcos",
"user_login": "dcos"
} | [
{
"action": "opened",
"author": "GoelDeepak",
"comment_id": null,
"datetime": 1508860942000,
"masked_author": "username_0",
"text": "## High Level Description\r\n\r\nThis is for my own project and this PR is never intended to be merged. I will close when my experimentation is over\r\n\r\n## Related Issues\r\n\r\n - [DCOS_OSS-<number>](https://jira.dcos.io/browse/DCOS_OSS-<number>) Foo the Bar so it stops Bazzing.\r\n - [DCOS-<number>](https://jira.mesosphere.com/browse/DCOS-<number>) Foo the Bar so it stops Bazzing.\r\n\r\n## Checklist for all PR's\r\n\r\n - [ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:\r\n - [ ] Read the [DC/OS contributing guidelines](https://github.com/dcos/dcos/blob/master/contributing.md)\r\n - [ ] Followed relevant code rules [Rules for Packages and Systemd](https://github.com/dcos/dcos/tree/master/docs)\r\n\r\n## Checklist for component/package updates:\r\n\r\nIf you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath `packages`), then in addition to the above please also include:\r\n\r\n - [ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): [example](https://github.com/dcos/dcos-mesos-modules/compare/f6fa27d7c40f4207ba3bb2274e2cfe79b62a395a...6660b90fbbf69a15ef46d0184e36755881d6a5ae)\r\n - [ ] Test Results: [link to CI job test results for component]\r\n - [ ] Code Coverage (if available): [link to code coverage report]\r\n___\r\n**PLEASE FILL IN THE TEMPLATE ABOVE** / **DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE**\r\n\r\n## Instructions and Review Process\r\n\r\n**What is the review process and when will my changes land?**\r\n\r\nAll PRs require 2 approvals using github's [pull request reviews](https://help.github.com/articles/about-pull-request-reviews/).\r\n\r\nReviewers should be:\r\n* Developers who understand the code being modified.\r\n* Developers responsible for code that interacts with or depends on the code being modified.\r\n\r\nIt is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has **2 ship-it's**, **no red reviews**, and **all tests are green** it will be included in the [next train](https://github.com/dcos/dcos/blob/master/contributing.md).",
"title": "[WIP] make periodic reconcile of l4lb config",
"type": "issue"
},
{
"action": "created",
"author": "spahl",
"comment_id": 339488185,
"datetime": 1508969401000,
"masked_author": "username_1",
"text": "@mesosphere-mergebot bump-ee",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GoelDeepak",
"comment_id": 339670074,
"datetime": 1509025395000,
"masked_author": "username_0",
"text": "@mesosphere-mergebot bump-ee",
"title": null,
"type": "comment"
}
] | 3 | 6 | 3,089 | false | true | 2,366 | false |
iview/iview | iview | 384,584,686 | 4,908 | null | [
{
"action": "opened",
"author": "kotoyo1516",
"comment_id": null,
"datetime": 1543283318000,
"masked_author": "username_0",
"text": "_Originally posted by @iview-bot in https://github.com/iview/iview/issues/4907#issuecomment-441862466_",
"title": "Hello, this issue has been closed because it does not conform to our issue requirements. Please use the [Issue Helper](https://www.iviewui.com/new-issue) to create an issue - thank you!",
"type": "issue"
}
] | 2 | 3 | 287 | false | true | 102 | false |
devopsdays/devopsdays-web | devopsdays | 266,957,674 | 3,453 | {
"number": 3453,
"repo": "devopsdays-web",
"user_login": "devopsdays"
} | [
{
"action": "opened",
"author": "delgod",
"comment_id": null,
"datetime": 1508440717000,
"masked_author": "username_0",
"text": "This reverts commit bcb1b858875bcd3683f2dea8720cf3ce53998d2d.\r\n\r\n*Please title your pull request in this format: The event name and year in the title of the PR, along with a description of what is being changed, i.e., `[CHI-2017] Add Bluth Company as a sponsor`*",
"title": "Revert \"Add Kiel organizer\" (wrong city)",
"type": "issue"
},
{
"action": "created",
"author": "bridgetkromhout",
"comment_id": 338020526,
"datetime": 1508443228000,
"masked_author": "username_1",
"text": "Off by one errors! 😂",
"title": null,
"type": "comment"
}
] | 2 | 2 | 282 | false | false | 282 | false |
django-extensions/django-extensions | django-extensions | 411,062,717 | 1,308 | {
"number": 1308,
"repo": "django-extensions",
"user_login": "django-extensions"
} | [
{
"action": "opened",
"author": "kuter",
"comment_id": null,
"datetime": 1550315880000,
"masked_author": "username_0",
"text": "",
"title": "Removed passwd management command",
"type": "issue"
}
] | 2 | 2 | 316 | false | true | 0 | false |
JuliaNLSolvers/LsqFit.jl | JuliaNLSolvers | 427,927,855 | 117 | {
"number": 117,
"repo": "LsqFit.jl",
"user_login": "JuliaNLSolvers"
} | [
{
"action": "opened",
"author": "pkofod",
"comment_id": null,
"datetime": 1554155434000,
"masked_author": "username_0",
"text": "Merged conflict resolved version of https://github.com/JuliaNLSolvers/LsqFit.jl/pull/106\r\n\r\n@username_1",
"title": "Geomerged",
"type": "issue"
},
{
"action": "created",
"author": "Magalame",
"comment_id": 481362119,
"datetime": 1554832306000,
"masked_author": "username_1",
"text": "bump",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pkofod",
"comment_id": 481409214,
"datetime": 1554839455000,
"masked_author": "username_0",
"text": "I think it's ready now, no?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Magalame",
"comment_id": 481414922,
"datetime": 1554840455000,
"masked_author": "username_1",
"text": "Seems like it! I'm really happy we got it done eventually",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pkofod",
"comment_id": 481415659,
"datetime": 1554840584000,
"masked_author": "username_0",
"text": "yeah, that's on me. Seems like I removed a method too much, or the inplace keyword is called somewhere where it shouldn't. Will fix :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pkofod",
"comment_id": 481422043,
"datetime": 1554841672000,
"masked_author": "username_0",
"text": "Thanks for the work :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Magalame",
"comment_id": 481426384,
"datetime": 1554842351000,
"masked_author": "username_1",
"text": "🎉",
"title": null,
"type": "comment"
}
] | 2 | 7 | 346 | false | false | 346 | true |
AsyncHttpClient/async-http-client | AsyncHttpClient | 124,492,861 | 1,069 | {
"number": 1069,
"repo": "async-http-client",
"user_login": "AsyncHttpClient"
} | [
{
"action": "opened",
"author": "mitsy",
"comment_id": null,
"datetime": 1451585485000,
"masked_author": "username_0",
"text": "Adding unit tests to convert some of the \"online\" tests to \"standalone\" ones using WireMock. In this PR, the \"online\" ones are not removed, but corresponding \"standalone\" ones are added to *Local test classes. Even apart from these, other tests are added wherever there was scope to add them. Please review. Thanks.\r\n\r\nMitali Jha\r\nDevFactory",
"title": "Adding unit tests",
"type": "issue"
},
{
"action": "created",
"author": "slandelle",
"comment_id": 169149557,
"datetime": 1452031773000,
"masked_author": "username_1",
"text": "Hi Mitali,\r\n\r\nThanks a lot!\r\n\r\nWould it be possible for you to provide a first PR with only the tests that are not based on WireMock, please?\r\nThen, we'll figure out the best course of action regarding the other ones.\r\n\r\nThanks",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mitsy",
"comment_id": 169249669,
"datetime": 1452062594000,
"masked_author": "username_0",
"text": "Sure, Stephane. I'll work on it. Thanks for the review comments.\n\nI am evaluating if we could get away without using WireMock and instead use\njetty for testing the functionality that we are testing here with WireMock.\n\n\nThanks a lot.\nMitali",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slandelle",
"comment_id": 169261078,
"datetime": 1452066830000,
"masked_author": "username_1",
"text": "I'm starting to consider if I couldn't build a simple test framework on top of Jetty, without abstracting anything away the way WireMock does. Maybe having a way to enqueue handlers, similar to OkHttp's MockServer.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slandelle",
"comment_id": 169282852,
"datetime": 1452074859000,
"masked_author": "username_1",
"text": "@username_0 As expected, my PR is being rejected because WireMock's author want to retain JDK7 compatibility for some time. So no Jetty 9.3 there for now, which is a no go for us.\r\n\r\nLet's keep on going with a custom tailor made solution so we don't depend on any external agenda. I'm pretty sure I can improve our current crappy integration test framework. I'll work on this next week, my hands at full atm.\r\n\r\nIn the meantime, it would be great if you could extract the non WireMock based stuff and submit a new isolated PR that I could quickly merge. I could do it myself, but you wouldn't be credited for the commit, so it would be a pity. Please just tell me.\r\n\r\nRegards",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mitsy",
"comment_id": 169284904,
"datetime": 1452075450000,
"masked_author": "username_0",
"text": "I'll raise an islolated PR soon. Meanwhile, over the course of this week,\nI'll anyway investigate what it takes to create a jetty based custom\nintegration test solution (similar to WireMock).\n\nRegards",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slandelle",
"comment_id": 169285388,
"datetime": 1452075603000,
"masked_author": "username_1",
"text": "Awesome, thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slandelle",
"comment_id": 169291705,
"datetime": 1452076391000,
"masked_author": "username_1",
"text": "Closing this PR. Eager to get the next one :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slandelle",
"comment_id": 170895349,
"datetime": 1452601363000,
"masked_author": "username_1",
"text": "@username_0 gentle ping. Did you get a chance to extract the non WireMock stuff?",
"title": null,
"type": "comment"
}
] | 2 | 9 | 2,028 | false | false | 2,028 | true |
giantswarm/happa | giantswarm | 440,027,668 | 575 | {
"number": 575,
"repo": "happa",
"user_login": "giantswarm"
} | [
{
"action": "opened",
"author": "ls42",
"comment_id": null,
"datetime": 1556887233000,
"masked_author": "username_0",
"text": "Hey, found a tyop in the example after creating a cluster.",
"title": "Fix sed command in example.",
"type": "issue"
},
{
"action": "created",
"author": "oponder",
"comment_id": 489128925,
"datetime": 1556896170000,
"masked_author": "username_1",
"text": "@username_0 Thanks for your PR!\r\n\r\nI think mac has a slightly weird version of `sed`.\r\nIf I run that (on macOS) I get: \r\n\r\n```\r\n$ sed -i \"s/YOUR_CLUSTER_BASE_DOMAIN/sdsn4.k8s.sample.io/\" helloworld-manifest.yaml\r\nsed: 1: \"helloworld-manifest.yaml\": extra characters at the end of h command\r\n```\r\n\r\nDoes the above work for you? What platform are you using? \r\n\r\nDoes anyone know an alternative that has more chance to take the same arguments?\r\n\r\nOtherwise I can use platform detection in Happa and offer up different versions of the `sed` command. I'd rather avoid it though.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ls42",
"comment_id": 489135767,
"datetime": 1556897347000,
"masked_author": "username_0",
"text": "@username_1 you're very welcome!\r\n\r\nThe command you mentioned works for me. If I'm not mistaken, macOS uses a BSD version of sed, and the GNU project somehow has a different version. I'm on Linux, details below. \r\n\r\n[I looked it up](http://man.openbsd.org/sed#i): BSD sed needs a filename after the `-i` command, for backups. It looks like there's no elegant way without platform detection.\r\n\r\n```\r\nclericbeast ~/gollum $ sed -i \"s/YOUR_CLUSTER_BASE_DOMAIN/sdsn4.k8s.sample.io/\" helloworld-manifest.yaml\r\nclericbeast ~/gollum $ sed --version ; cat /etc/os-release \r\nsed (GNU sed) 4.7\r\nPackaged by Debian\r\nCopyright (C) 2018 Free Software Foundation, Inc.\r\nLicense GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.\r\nThis is free software: you are free to change and redistribute it.\r\nThere is NO WARRANTY, to the extent permitted by law.\r\n\r\nWritten by Jay Fenlason, Tom Lord, Ken Pizzini,\r\nPaolo Bonzini, Jim Meyering, and Assaf Gordon.\r\nGNU sed home page: <https://www.gnu.org/software/sed/>.\r\nGeneral help using GNU software: <https://www.gnu.org/gethelp/>.\r\nE-mail bug reports to: <bug-sed@gnu.org>.\r\nNAME=\"Ubuntu\"\r\nVERSION=\"19.04 (Disco Dingo)\"\r\nID=ubuntu\r\nID_LIKE=debian\r\nPRETTY_NAME=\"Ubuntu 19.04\"\r\nVERSION_ID=\"19.04\"\r\nHOME_URL=\"https://www.ubuntu.com/\"\r\nSUPPORT_URL=\"https://help.ubuntu.com/\"\r\nBUG_REPORT_URL=\"https://bugs.launchpad.net/ubuntu/\"\r\nPRIVACY_POLICY_URL=\"https://www.ubuntu.com/legal/terms-and-policies/privacy-policy\"\r\nVERSION_CODENAME=disco\r\nUBUNTU_CODENAME=disco\r\nclericbeast ~/gollum $ grep sample.io helloworld-manifest.yaml \r\n - host: helloworld.sdsn4.k8s.sample.io\r\nclericbeast ~/gollum $ \r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ls42",
"comment_id": 489138969,
"datetime": 1556897874000,
"masked_author": "username_0",
"text": "It does work like this on GNU sed: `sed -i\"\" \"s/YOUR_CLUSTER_BASE_DOMAIN/sdsn4.k8s.sample.io/\" helloworld-manifest.yaml`. Maybe that works on macOS, too?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "oponder",
"comment_id": 489142878,
"datetime": 1556898546000,
"masked_author": "username_1",
"text": "Unfortunately not, just gave it try. I'll do the platform detection thing, we already have code for that in another part of the getting started guide, so it's not too much work to introduce that.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "oponder",
"comment_id": 489144807,
"datetime": 1556898909000,
"masked_author": "username_1",
"text": "@username_0: Unless you feel like taking your PR further? You can see the platform detection happening in \r\n\r\nhttps://github.com/giantswarm/happa/blob/master/src/components/getting-started/1_configure_kubectl.js\r\n\r\nI would do it in a similar way to that page, so that we show the tabs (Mac, Linux, Windows), and then the appropriate sed command for each.\r\n\r\nTotally no worries if that's a bit too much hassle and React / JSX slinging for what looked initially like a quick contribution.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ls42",
"comment_id": 489178689,
"datetime": 1556905030000,
"masked_author": "username_0",
"text": "@username_1 I'm intrigued, let me have a look!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ls42",
"comment_id": 489210444,
"datetime": 1556911177000,
"masked_author": "username_0",
"text": "See c4b4724e8f67c5ddf06ec67ac3b13b7e9d343bfe\r\n\r\nSorry, this is untested, I don't have the environment for React at\r\nthe moment. But maybe this already works as expected? I deliberately\r\nleft out the **Windows** tab since it would require changes in the first page\r\nas well (adding `sed` to the *scoop install/update* part).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "oponder",
"comment_id": 489323676,
"datetime": 1556973828000,
"masked_author": "username_1",
"text": "@username_0 Let me preface this by saying I realise I'm asking for a lot of minutia from a friendly contributor. If at any point you think you want to move on from doing these little changes, just let me know. I'm happy to take over. \r\n\r\nWith that out of the way. This looks good and works for me! \r\n\r\nI do have a few changes.\r\n\r\n- There's some text changes I'm thinking of:\r\n\r\n Could you change the `p` tag from:\r\n\r\n ```\r\n <p>\r\n Next use <code>sed</code> to replace the placeholder{' '}\r\n <code>YOUR_CLUSTER_BASE_DOMAIN</code> with{' '}\r\n <code>{this.clusterBaseDomain()}</code>.\r\n </p>\r\n ```\r\n\r\n to (2 separate p tags):\r\n\r\n ```\r\n <p>\r\n Next replace the placeholder{' '}\r\n <code>YOUR_CLUSTER_BASE_DOMAIN</code> with{' '}\r\n <code>{this.clusterBaseDomain()}</code>.\r\n </p>\r\n\r\n <p>\r\n If you are on Linux or Mac OS you can use the command below to do this.\r\n Windows users willl have to use their favorite text editor and manually\r\n edit the <code>helloworld-manifest.yaml</code> file.\r\n </p>\r\n ```\r\n\r\n- We also got a missing semicolon that our linter will complain about on line 36 of `2_simple_example.js`\r\n\r\n- Also I would love it if you added yourself to the `CONTRIBUTORS.md`, unless you have any objection to that.\r\n\r\n If you're lost for words, it can be something like (inserted in alphabetical order),\r\n\r\n ```\r\n - [Stephan Brauer](https://github.com/username_0)\r\n - Discovered our sed command didn't work for linux users and contributed a thorough fix.\r\n ```\r\n\r\n- And lastly can you acknowledge our DCO here: https://github.com/giantswarm/happa/blob/master/DCO\r\nReplying with something like \"I've read and agree with the DCO.\" is sufficient.\r\n\r\nThanks again!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ls42",
"comment_id": 489352563,
"datetime": 1556994515000,
"masked_author": "username_0",
"text": "I've read and agree with the [DCO](https://github.com/giantswarm/happa/blob/master/DCO) :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ls42",
"comment_id": 489361757,
"datetime": 1557000628000,
"masked_author": "username_0",
"text": "@username_1 I'm seriously happy to help, and that you're trying to engage me fix this the proper way. Thank you!\r\n\r\nI changed the parts you requested, although I took the liberty to change \"Mac OS\" to \"macOS\", I believe that's the official style. Let me know if I should change it back.\r\n\r\n:v:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ls42",
"comment_id": 489362132,
"datetime": 1557000969000,
"masked_author": "username_0",
"text": "Nevermind, changed it back to \"Mac OS\". I missed that you're writing it like that in other places, too.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "oponder",
"comment_id": 489513931,
"datetime": 1557124548000,
"masked_author": "username_1",
"text": "@username_0 looks good to me! I think there is a linter error still, sorry you can't see those, since our CI only runs for non forked pull requests.\r\n\r\nCould you run `yarn run prettier` and commit the result, then we should have a fully good to go PR.\r\n\r\nIn the meanwhile I'll fiddle with our CI a bit, so that we can let forked PR's also get built. When that's done we should see the PR go fully green, and I'll merge it shortly after that.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ls42",
"comment_id": 489519017,
"datetime": 1557126245000,
"masked_author": "username_0",
"text": "@username_1 done!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "oponder",
"comment_id": 491597748,
"datetime": 1557669111000,
"masked_author": "username_1",
"text": "Sorry this is taking a lil while, the CI changes are taking me a bit longer than I hoped.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ls42",
"comment_id": 491704345,
"datetime": 1557731892000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "oponder",
"comment_id": 492708274,
"datetime": 1557934798000,
"masked_author": "username_1",
"text": "Going to use my admin powers and merge this despite the CI error.\r\n\r\nBuilding forked PR's requires a bit more work, but I don't want to let this linger because of that.\r\n\r\nThanks for your work @username_0",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ls42",
"comment_id": 492733772,
"datetime": 1557938895000,
"masked_author": "username_0",
"text": "That’s awesome, thanks!\n\nI like how you encouraged me to go the extra mile, and it was very rewarding. \n\nThanks again! I’ll be looking for the next opportunity to contribute :-)\n\nSent from my iPhone\n\n>",
"title": null,
"type": "comment"
}
] | 2 | 18 | 6,696 | false | false | 6,696 | true |
josephpei/uv2ray | null | 454,995,597 | 1 | null | [
{
"action": "opened",
"author": "hippyk",
"comment_id": null,
"datetime": 1560310290000,
"masked_author": "username_0",
"text": "点 '应用' 按钮则会重置所有输入框.\r\n\r\n系统: ubuntu\r\n\r\n",
"title": "配置无法保存",
"type": "issue"
},
{
"action": "created",
"author": "josephpei",
"comment_id": 501704310,
"datetime": 1560432740000,
"masked_author": "username_1",
"text": "Fixed, 请更新，欢迎提交 PR !",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "josephpei",
"comment_id": null,
"datetime": 1570705674000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 167 | false | false | 167 | false |
renkun-ken/formattable | null | 307,894,703 | 105 | null | [
{
"action": "opened",
"author": "pmaji",
"comment_id": null,
"datetime": 1521777459000,
"masked_author": "username_0",
"text": "Presently, within R Shiny, when building a \"renderFormattable({ })\" table, I see no way of avoiding manually calling column names. In the code snippet below (cut for size so it's incomplete) the **bolded** items are the exact column names. It would be great if instead I could replace, for example, \"assetportfolio_rate_of_return\" with names(port_summary_table)[1], or some such other way of dynamically calling names. The status quo makes it very difficult to control column names, and prevents me from using, just as an example, any column names that contain spaces. \r\n\r\nHow can this be fixed circumvented @renkun-ken ? For reference, the code that uses this is located here (https://github.com/username_0/crypto-asset-comparison-tool/blob/master/app.R). \r\n\r\nformattable(_port_summary_table_, \r\n list(\r\n **asset_portfolio_rate_of_return** = formatter(\"span\",\r\n style = x ~ style(\r\n display = \"inline-block\",\r\n direction = \"rtl\",\r\n \"border-radius\" = \"4px\",\r\n \"padding-right\" = \"2px\",\r\n \"background-color\" = csscolor(\"darkslategray\"),\r\n width = percent(proportion(x)),\r\n color = csscolor(gradient(x, \"red\", \"green\"))\r\n )),\r\n **asset_portfolio_absolute_profit** = formatter(\"span\",\r\n style = x ~ style(\r\n display = \"inline-block\",\r\n direction = \"rtl\",\r\n \"border-radius\" = \"4px\",\r\n \"padding-right\" = \"2px\",\r\n \"background-color\" = csscolor(\"darkslategray\"),\r\n width = percent(proportion(x)),\r\n color = csscolor(gradient(x, \"red\", \"green\"))\r\n )),",
"title": "support for dynamic column names?",
"type": "issue"
},
{
"action": "closed",
"author": "pmaji",
"comment_id": null,
"datetime": 1522892456000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 2,855 | false | true | 2,689 | true |
ypinskiy/GBF-Raiders | null | 343,010,002 | 36 | null | [
{
"action": "opened",
"author": "Cyinthia",
"comment_id": null,
"datetime": 1532073610000,
"masked_author": "username_0",
"text": "tried to allow it via advanced settings, notifications then added the sight but the enable desktop notification button cannot be pressed.",
"title": "cannot enable desktop notifications",
"type": "issue"
},
{
"action": "created",
"author": "Shumatsu",
"comment_id": 407199056,
"datetime": 1532379533000,
"masked_author": "username_1",
"text": "What browser are you using?",
"title": null,
"type": "comment"
}
] | 2 | 2 | 164 | false | false | 164 | false |
containous/traefik | containous | 117,423,079 | 116 | null | [
{
"action": "opened",
"author": "polds",
"comment_id": null,
"datetime": 1447786237000,
"masked_author": "username_0",
"text": "Using the wildcard subdomain you can listen to `{subdomain: [a-z]+}.example.com`, that however does not also include `example.com`. Is it possible to listen to both?",
"title": "Possible to listen to both www.example.com and example.com?",
"type": "issue"
},
{
"action": "closed",
"author": "vdemeester",
"comment_id": null,
"datetime": 1459952656000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 165 | false | false | 165 | false |
uclibs/scholar_uc | uclibs | 240,212,092 | 1,537 | null | [
{
"action": "opened",
"author": "scherztc",
"comment_id": null,
"datetime": 1499097297000,
"masked_author": "username_0",
"text": "### Descriptive summary\r\n\r\nThe Universal Viewer is not finding the IIIF files on the scholar-dev.uc.edu environment. The first place to look is removing this localhost line from the config file. \r\n\r\nhttps://github.com/uclibs/scholar_uc/blob/develop/config/environments/development.rb#L36\r\n\r\nThere still might be a deeper problem but start here.",
"title": "DEV: Universal Viewer / RIIIF not working.",
"type": "issue"
},
{
"action": "created",
"author": "scherztc",
"comment_id": 312681985,
"datetime": 1499097371000,
"masked_author": "username_0",
"text": "<img width=\"819\" alt=\"screen shot 2017-07-03 at 11 55 13 am\" src=\"https://user-images.githubusercontent.com/5084562/27800265-9a9338f6-5fe6-11e7-8909-410537852533.png\">",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "scherztc",
"comment_id": 314157980,
"datetime": 1499703717000,
"masked_author": "username_0",
"text": "Russell Koonts [10:24 AM] \r\nNot sure if this is a hyrax or universalviewer question, but I’ll start here. Moved our hyrax development site off of a local VM to our development server. Now when trying to access images in the universalviewer via the server’s url, the images show up as errors. Developer console shows a Failed to load Resource: net::ERR_CONNECTION_REFUSED error (localhost:3000/…). This has been explained to me as the browser looking for localhost:3000 on my laptop. Is there a way to set the default host in the development environment to the server’s url?\r\n\r\nJustin Coyne [10:26 AM] \r\n@rkoonts I wonder if that URL is indexed in the solr documents?\r\n\r\n\r\nRussell Koonts [10:44 AM] \r\n@jcoyne Turns out it was our proxy_pass and proxy_set_header weren’t set up completely. Now that they are, all is fine. Your recommendation got us looking at the server conf file in order to proxy solr and we realized it wasn’t correct.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hortongn",
"comment_id": 317103991,
"datetime": 1500668706000,
"masked_author": "username_1",
"text": "@username_0 This is where the derivatives path is getting set on scholar-dev\r\nhttps://github.com/uclibs/scholar_uc/blob/develop/config/initializers/hyrax.rb.bamboo#L124\r\nBamboo sets it to /srv/apps/scholar-derivatives",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hortongn",
"comment_id": 318093497,
"datetime": 1501083725000,
"masked_author": "username_1",
"text": "@username_0 I did a diff on the config files on scholar-dev and scholar-beta and didn't find any differences that might be causing the problem.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "scherztc",
"comment_id": 319478917,
"datetime": 1501617448000,
"masked_author": "username_0",
"text": "Special apache encoding note: https://github.com/curationexperts/riiif#special-note-for-passenger-and-apache-users",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "13miciunasl",
"comment_id": null,
"datetime": 1502739325000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 7 | 1,926 | false | false | 1,926 | true |
sebgroup/ng-wizard | sebgroup | 415,531,507 | 5 | {
"number": 5,
"repo": "ng-wizard",
"user_login": "sebgroup"
} | [
{
"action": "opened",
"author": "MartinAskestad",
"comment_id": null,
"datetime": 1551347005000,
"masked_author": "username_0",
"text": "",
"title": "Update travis",
"type": "issue"
},
{
"action": "created",
"author": "sebopensource",
"comment_id": 474930281,
"datetime": 1553101072000,
"masked_author": "username_1",
"text": ":tada: This PR is included in version 1.0.0 :tada:\n\nThe release is available on:\n- [npm package (@latest dist-tag)](https://www.npmjs.com/package/@sebgroup/ng-wizard)\n- [GitHub release](https://github.com/sebgroup/ng-wizard/releases/tag/v1.0.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:",
"title": null,
"type": "comment"
}
] | 2 | 2 | 349 | false | false | 349 | false |
greenplum-db/gpdb | greenplum-db | 180,968,263 | 1,174 | {
"number": 1174,
"repo": "gpdb",
"user_login": "greenplum-db"
} | [
{
"action": "opened",
"author": "chrishajas",
"comment_id": null,
"datetime": 1475605503000,
"masked_author": "username_0",
"text": "Previously the script had a constant false which caused the tool to\r\nrebuild the cluster without mirrors even if mirrors were present.\r\n\r\nAuthors: Chris Hajas and Larry Hamel",
"title": "Fix Persistent Rebuild to use mirrors if mirrors are present.",
"type": "issue"
},
{
"action": "created",
"author": "Chibin",
"comment_id": 251732272,
"datetime": 1475686290000,
"masked_author": "username_1",
"text": "Should we create the test case scenario that caught this issue?\r\n\r\notherwise 👍",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "danielgustafsson",
"comment_id": 251890628,
"datetime": 1475739980000,
"masked_author": "username_2",
"text": "LGTM",
"title": null,
"type": "comment"
}
] | 4 | 4 | 405 | false | true | 256 | false |
bitcoin/bitcoin | bitcoin | 404,966,433 | 15,295 | {
"number": 15295,
"repo": "bitcoin",
"user_login": "bitcoin"
} | [
{
"action": "opened",
"author": "MarcoFalke",
"comment_id": null,
"datetime": 1548882725000,
"masked_author": "username_0",
"text": "WIP",
"title": "fuzz: Add test/fuzz/test_runner.py and run it in travis",
"type": "issue"
},
{
"action": "created",
"author": "practicalswift",
"comment_id": 459114272,
"datetime": 1548883348000,
"masked_author": "username_1",
"text": "Concept ACK. Very nice!\r\n\r\nRelated: #10364 (\"Feature request: Make Bitcoin libFuzzer-friendly and consider integration into the OSS-Fuzz project\"). Feel free to collect the $20k bounty :-)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "laanwj",
"comment_id": 459318197,
"datetime": 1548935822000,
"masked_author": "username_2",
"text": "Can you please explain what you're adding here—\r\nWill adding fuzzing to travis make the tests non-deterministic, by randomizing it? Or does it only verify the current corpus?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MarcoFalke",
"comment_id": 459380679,
"datetime": 1548947646000,
"masked_author": "username_0",
"text": "Indeed the script currently only supports running over all seeds exactly once",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Sjors",
"comment_id": 459809688,
"datetime": 1549043757000,
"masked_author": "username_3",
"text": "Concept ACK. I can't get fuzzing to work on macOS (not that I tried hard), so having it on Travis sounds like a safe idea.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MarcoFalke",
"comment_id": 463396871,
"datetime": 1550095988000,
"masked_author": "username_0",
"text": "Thx, done",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "practicalswift",
"comment_id": 463531840,
"datetime": 1550131756000,
"masked_author": "username_1",
"text": "utACK fa7ca8ef58bf3e3b91d1f5a67fa42008e63b1f7b\r\n\r\nLet's get this merged :-)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MarcoFalke",
"comment_id": 463700235,
"datetime": 1550162746000,
"masked_author": "username_0",
"text": "Would be nice if at least some person other than myself and travis could test this. Just copy-paste the commands in the readme on a linux machine and tell me your computer didn't crash or something.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jamesob",
"comment_id": 463784121,
"datetime": 1550176441000,
"masked_author": "username_4",
"text": "Tested changes (https://github.com/bitcoin/bitcoin/pull/15295/commits/fa7ca8ef58bf3e3b91d1f5a67fa42008e63b1f7b) to `doc/fuzzing.md` on `Linux 4.15.0-43-generic #46-Ubuntu SMP x86_64` with `afl-fuzz 2.52b`. Installed afl from scratch, rebuilt Bitcoin with requisite flags, and confirmed that running `afl-fuzz` with the `transaction_deserialize` works as intended.\r\n\r\nUsed new test_runner script which looks like an easy way to delegate to calling `src/test/fuzz/*`. Have yet to get any meaningful output back, but maybe this is intended?\r\n```\r\n$ ./test/fuzz/test_runner.py -l DEBUG ~/src/qa-assets/fuzz_seed_corpus transaction_deserialize\r\n\r\nFuzz targets found: ['address_deserialize', 'addrman_deserialize', 'banentry_deserialize', 'block_deserialize', 'blockheader_deserialize', 'blocklocator_deserialize', 'blockmerkleroot', 'blocktransactions_deserialize', 'blocktransactionsrequest_deserialize', 'blockundo_deserialize', 'bloomfilter_deserialize', 'coins_deserialize', 'diskblockindex_deserialize', 'inv_deserialize', 'messageheader_deserialize', 'netaddr_deserialize', 'service_deserialize', 'transaction_deserialize', 'txoutcompressor_deserialize', 'txundo_deserialize']\r\nFuzz targets selected: ['transaction_deserialize']\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jamesob",
"comment_id": 463797022,
"datetime": 1550178483000,
"masked_author": "username_4",
"text": "Tested ACK https://github.com/bitcoin/bitcoin/pull/15295/commits/fa535af92c179b0ffb9280e0b2dc5acfeb80964a. Rebuilt with libfuzzer and tested the command that previously failed with afl:\r\n```\r\n$ ./test/fuzz/test_runner.py -l DEBUG ~/src/qa-assets/fuzz_seed_corpus transaction_deserialize\r\n\r\nFuzz targets found: ['address_deserialize', 'addrman_deserialize', 'banentry_deserialize', 'block_deserialize', 'blockheader_deserialize', 'blocklocator_deserialize', 'blockmerkleroot', 'blocktransactions_deserialize', 'blocktransactionsrequest_deserialize', 'blockundo_deserialize', 'bloomfilter_deserialize', 'coins_deserialize', 'diskblockindex_deserialize', 'inv_deserialize', 'messageheader_deserialize', 'netaddr_deserialize', 'service_deserialize', 'transaction_deserialize', 'txoutcompressor_deserialize', 'txundo_deserialize']\r\nFuzz targets selected: ['transaction_deserialize']\r\nRun transaction_deserialize with args ['/home/james/src/bitcoin/src/test/fuzz/transaction_deserialize', '-runs=1', '/home/james/src/qa-assets/fuzz_seed_corpus/transaction_deserialize']\r\nOutput: INFO: Seed: 819372946\r\nINFO: Loaded 1 modules (2002 inline 8-bit counters): 2002 [0x55b9cec15620, 0x55b9cec15df2),\r\nINFO: Loaded 1 PC tables (2002 PCs): 2002 [0x55b9cec15df8,0x55b9cec1db18),\r\nINFO: 295 files found in /home/james/src/qa-assets/fuzz_seed_corpus/transaction_deserialize\r\nINFO: -max_len is not provided; libFuzzer will not generate inputs larger than 52575 bytes\r\nINFO: seed corpus: files: 295 min: 1b max: 52575b total: 491499b rss: 45Mb\r\n#296 INITED cov: 240 ft: 938 corp: 277/475Kb exec/s: 0 rss: 106Mb\r\n#296 DONE cov: 240 ft: 938 corp: 277/475Kb exec/s: 0 rss: 106Mb\r\nDone 296 runs in 0 second(s)\r\n```\r\n\r\nWorth noting that I had to bump clang from 4. to 6. in order for the `-fsanitize=fuzzer` flags to work.",
"title": null,
"type": "comment"
}
] | 6 | 13 | 14,232 | false | true | 3,893 | false |
mglaman/phpstan-drupal | null | 439,629,860 | 66 | {
"number": 66,
"repo": "phpstan-drupal",
"user_login": "mglaman"
} | [
{
"action": "opened",
"author": "jibran",
"comment_id": null,
"datetime": 1556808357000,
"masked_author": "username_0",
"text": "This is a follow up of #51 and #52 which got reverted in #53. \r\n\r\nIf `\\Drupal` is used anywhere in `*.install` file it shows: \r\n```\r\n\\Drupal::$container is not initialized yet. \\Drupal::setContainer() must be called with a real container.\r\n```",
"title": "Analyzing *.install still shows: \\Drupal:: is not initialized yet",
"type": "issue"
},
{
"action": "created",
"author": "mglaman",
"comment_id": 488705627,
"datetime": 1556808884000,
"masked_author": "username_1",
"text": "I realized the testing was pretty broken. Hopefully this can be caught in PHPUNit as well",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mglaman",
"comment_id": 488833728,
"datetime": 1556831464000,
"masked_author": "username_1",
"text": "This should only occur _if_ `\\Drupal::service` is invoked anywhere in a file when it is required. Such as `require $file` ends up executing code",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jibran",
"comment_id": 488953565,
"datetime": 1556863291000,
"masked_author": "username_0",
"text": "I think that is correct I'll have a look later today.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jibran",
"comment_id": 490320939,
"datetime": 1557281800000,
"masked_author": "username_0",
"text": "Did you fix this in #68?",
"title": null,
"type": "comment"
}
] | 2 | 5 | 553 | false | false | 553 | false |
opnsense/core | opnsense | 332,807,096 | 2,466 | {
"number": 2466,
"repo": "core",
"user_login": "opnsense"
} | [
{
"action": "opened",
"author": "whislock",
"comment_id": null,
"datetime": 1529074477000,
"masked_author": "username_0",
"text": "This conforms to current recommendations and best practices for a\r\n128-bit security margin.\r\n\r\n2048 is still the minimum recommended, but 2048-bit RSA only aligns to a\r\n112-bit security margin, roughly analogous to 3DES. AES-128, the\r\nminimum recommended cipher, requires a 3072-bit RSA key and a 256-bit digest\r\n(SHA256) to provide an equivalent security level in all cryptographic\r\ncomponents.",
"title": "Added 3072-bit key length options.",
"type": "issue"
},
{
"action": "created",
"author": "whislock",
"comment_id": 397658588,
"datetime": 1529076723000,
"masked_author": "username_0",
"text": "Need to further test this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "whislock",
"comment_id": 397666174,
"datetime": 1529078345000,
"masked_author": "username_0",
"text": "Additional question: Where are we sourcing the sample DH parameter files from?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fichtner",
"comment_id": 397899998,
"datetime": 1529262924000,
"masked_author": "username_1",
"text": "This should be split in two: 3072 bits for certificates and 3072 bits for DH. For the latter it may be more favourable to avoid adding a lot of \"odd\" DH default params to the system, because...\r\n\r\n... to answer your question we sporadically provide new parameters and it takes a long time to update them if they grow in number (and bit size).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fichtner",
"comment_id": 397901317,
"datetime": 1529264268000,
"masked_author": "username_1",
"text": "I know it's a standard, but if I regenerate fr a release it already takes a while, adding more standard sizes will make it even longer, making it less likely to provide new files for the existing ones.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "whislock",
"comment_id": 397903218,
"datetime": 1529266266000,
"masked_author": "username_0",
"text": "So, more to the point, you should not be generating DH parameters for releases. You should be using the default ones from RFC 7919. If the end-user wants to use custom parameter sets, they should generate them themselves.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fichtner",
"comment_id": 397943198,
"datetime": 1529298488000,
"masked_author": "username_1",
"text": "Fine, so who will do the work necessary to avoid lower security in these circumstances? When will we be switching to a default regeneration of DH parameters and how will it be done? How do we minimise the gap between using default parameters and custom parameters in new installs? Do we have all the code in place or do we need to do more? How much *measurable* security will we gain from doing what is suggested here?\r\n\r\nBesides this my review points still stand... if you want a change merged please split it into Cert and DH parts...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "whislock",
"comment_id": 398031320,
"datetime": 1529323354000,
"masked_author": "username_0",
"text": "That depends on your risk profile and tolerance. For most users, this would be a transparent change whose benefits may never be observed. In raw terms, shipping audited and standard values provides an assurance that the values included with the release were not tampered with or poorly-generated. A \"nothing up my sleeve\" number, if you will.\r\n\r\nThe Mozilla Foundation states this advice explicitly. [Server-Side TLS](https://wiki.mozilla.org/Security/Server_Side_TLS#Pre-defined_DHE_groups) While the page itself may offer guidance on configuring web servers, the rest of it is fully-applicable to anything participating in TLS connections.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fichtner",
"comment_id": 398034526,
"datetime": 1529324189000,
"masked_author": "username_1",
"text": "We've been following up on https://weakdh.org/sysadmin.html ever since 2015 and this is the first complaint that it's *all wrong*. What you state here is therefore news to me. On first glance I cannot find enough info to back up your claims, so I'll park this PR and ask around to give it the benefit of the doubt it deserves and I wish you will do the same for what we have currently in place.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fichtner",
"comment_id": 398037992,
"datetime": 1529325021000,
"masked_author": "username_1",
"text": "Ah, thanks for the clarification.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "whislock",
"comment_id": 398195705,
"datetime": 1529355968000,
"masked_author": "username_0",
"text": "I'm going to undo the commits to the DH portions so that the cert parts can go in under this PR, and I'll submit a DH-specific PR later if its agreed upon.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "whislock",
"comment_id": 398198347,
"datetime": 1529356556000,
"masked_author": "username_0",
"text": "Done.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fichtner",
"comment_id": 398275498,
"datetime": 1529384821000,
"masked_author": "username_1",
"text": "Merged, thank you.\r\n\r\nAs for RFC 7919, how about we make them optionally usable? We already have a mode selector in the development version. This also means one day we could switch to them by default in new installation and not take anything away from existing users.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fichtner",
"comment_id": 398382444,
"datetime": 1529411564000,
"masked_author": "username_1",
"text": "Because we're not making RFC 71919 a default unless the community is willing to support this move. So the community needs to be engaged, best by shipping options to them to try out and discuss further in the forum. :)\r\n\r\nOther issue is that 1024 is not provided by RFC, but still of deprecated use in existing installs so you end up with a mixed or broken environment on upgrade if we were to do the switch. As a stopgap we'll be bumping the defaults in OpenVPN to 2048 with 18.1.10 and then give RFC a fair chance on 18.7 so that we could switch to it by default when 19.1 is out.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "whislock",
"comment_id": 398385231,
"datetime": 1529412198000,
"masked_author": "username_0",
"text": "The \"wisdom of crowds\" approach is not the correct approach where crypto is concerned. The fact that you accepted a pull request predicated on the idea that periodic regeneration of DH groups is good or necessary is proof of that fact. Do what you will, but this is the wrong approach.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fichtner",
"comment_id": 398389119,
"datetime": 1529413024000,
"masked_author": "username_1",
"text": "Your mind is set; I have no reason to change it. :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "whislock",
"comment_id": 398393365,
"datetime": 1529413866000,
"masked_author": "username_0",
"text": "My mind isn't the issue. I have standards and best practices on my side, reinforced with documentation. You're choosing to ignore that, which is strange to me.\r\n\r\nYou accepted a pull request regarding DH params with \"a couple dudes talked about it on IRC\" as support, but you resist this proposal when an actual RFC exists in support of the proposal with the statement of \"we're not doing this unless the community supports it.\" Talk about double standards. I won't be contributing further to this project.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fichtner",
"comment_id": 398396089,
"datetime": 1529414384000,
"masked_author": "username_1",
"text": "You have:\r\n\r\n1. Asserted that you set your opinion above a community voice in an open source project scope.\r\n2. You continue to be pushy with no regard for other people's schedules, ideas and explicit questions to give \"the benefit of the doubt\".\r\n3. Have failed to realise that 90% of what you asked is already in the development version.\r\n\r\nFeel free to not back off, but in any case this is the last you see of me responding.\r\n\r\n\r\nThanks,\r\nFranco",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "whislock",
"comment_id": 398398501,
"datetime": 1529414856000,
"masked_author": "username_0",
"text": "Again, that's on you. I have the knowledge and expertise to render a judgment on this. It's a shame you choose not to benefit from it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fichtner",
"comment_id": 398399491,
"datetime": 1529415053000,
"masked_author": "username_1",
"text": "Your assertion is wrong and it makes you act like a less than favourable human being. People live and learn, either with you or without you. I'm closing this thread, because you continue to deviate from the topic for attacks because you don't get what you want.",
"title": null,
"type": "comment"
}
] | 2 | 20 | 5,561 | false | false | 5,561 | false |
rshipp/awesome-malware-analysis | null | 388,138,337 | 169 | {
"number": 169,
"repo": "awesome-malware-analysis",
"user_login": "rshipp"
} | [
{
"action": "opened",
"author": "PolluxAvenger",
"comment_id": null,
"datetime": 1544090495000,
"masked_author": "username_0",
"text": "update of readme_cn.md",
"title": "Chinese Translation update",
"type": "issue"
},
{
"action": "created",
"author": "rshipp",
"comment_id": 445061767,
"datetime": 1544137264000,
"masked_author": "username_1",
"text": "Thanks! 😄",
"title": null,
"type": "comment"
}
] | 2 | 2 | 31 | false | false | 31 | false |
rapid7/metasploitable3 | rapid7 | 237,915,936 | 151 | null | [
{
"action": "opened",
"author": "Chan9390",
"comment_id": null,
"datetime": 1498152026000,
"masked_author": "username_0",
"text": "SNMP service is mentioned in the [Vulnerabilities Wiki](https://github.com/rapid7/metasploitable3/wiki/Vulnerabilities) but after building the VM, it is seen that this service doesn't start.\r\nThis affects the #140 PR also.\r\n\r\n## Host System\r\n* OS: Ubuntu 16.04\r\n* Packer Version: 1.0.0\r\n* Vagrant Version: 1.9.1\r\n* VirtualBox Version: 5.1.18",
"title": "SNMP service not running",
"type": "issue"
},
{
"action": "created",
"author": "maxlandon",
"comment_id": 357573636,
"datetime": 1515986489000,
"masked_author": "username_1",
"text": "To solve this:\r\n1) In **Administrative Tools**, go to **Server Manager**\r\n2) In the right menu bar, go to **Features**, then click **Add Features**\r\n3) Select **SNMP Services**\r\n4) Install\r\n5) Restart the VM, as asked by Windows\r\n\r\nThen,\r\n6) In **Administrative Tools**, go to **Services**\r\n7) Right-clic on **SNMP Service**\r\n8) In **Security**, select **Accept SNMP packets from any host**\r\n\r\nThen the SNMP enum_users will work.\r\nI hope it is the good way to solve the issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "HudsonSeiler",
"comment_id": 480033353,
"datetime": 1554406387000,
"masked_author": "username_2",
"text": "Having the same issue did I build the vm wrong whats the deal did they change it tried the fix and it did not help no users any help would greatly be appreciated",
"title": null,
"type": "comment"
}
] | 3 | 3 | 978 | false | false | 978 | false |
kataras/iris | null | 161,851,792 | 214 | null | [
{
"action": "opened",
"author": "EtienneBruines",
"comment_id": null,
"datetime": 1466664581000,
"masked_author": "username_0",
"text": "Currently, `IStore` is defined as:\r\n\r\n```go\r\n\r\n// IStore is the interface which all session stores should implement\r\ntype IStore interface {\r\n\tGet(interface{}) interface{}\r\n\tGetString(key interface{}) string\r\n\tGetInt(key interface{}) int\r\n\tSet(interface{}, interface{}) error\r\n\tDelete(interface{}) error\r\n\tClear() error\r\n\tVisitAll(func(interface{}, interface{}))\r\n\tGetAll() map[interface{}]interface{}\r\n\tID() string\r\n\tLastAccessedTime() time.Time\r\n\tSetLastAccessedTime(time.Time)\r\n\tDestroy()\r\n}\r\n```\r\n\r\nI would love if it included an `Exists(interface{}) bool`. This way one can check if a certain key is present, without caring at all about its contents. I could implement it and submit a PR if you'd like. \r\n\r\nThoughts?",
"title": "Feature request: session.Exists",
"type": "issue"
},
{
"action": "created",
"author": "kataras",
"comment_id": 227964969,
"datetime": 1466664729000,
"masked_author": "username_1",
"text": "Get returns nil if the key doesnt exists :P",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "EtienneBruines",
"comment_id": 227965134,
"datetime": 1466664786000,
"masked_author": "username_0",
"text": "But if it exists, some data may be retrieved from a backend database, while it's not being used? (i.e. you only care *if* it exists; you're not using it afterwards)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "kataras",
"comment_id": null,
"datetime": 1466664964000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "kataras",
"comment_id": 227965653,
"datetime": 1466664964000,
"masked_author": "username_1",
"text": "The store doesn't ` retrieve from a backend while it's not being used, the `Exists`will do the same thing as this: \r\n```go\r\nif v:= store.Get(\"key\"); v != nil { // if store.Exists(\"key\") { } else { }\r\n // exists\r\n }else {\r\n // doesnt exists\r\n}\r\n```` \r\n\r\nLet's keep things, we will have duplication of code with the `Exists`:/",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "kataras",
"comment_id": null,
"datetime": 1466664965000,
"masked_author": "username_1",
"text": "Currently, `IStore` is defined as:\r\n\r\n```go\r\n\r\n// IStore is the interface which all session stores should implement\r\ntype IStore interface {\r\n\tGet(interface{}) interface{}\r\n\tGetString(key interface{}) string\r\n\tGetInt(key interface{}) int\r\n\tSet(interface{}, interface{}) error\r\n\tDelete(interface{}) error\r\n\tClear() error\r\n\tVisitAll(func(interface{}, interface{}))\r\n\tGetAll() map[interface{}]interface{}\r\n\tID() string\r\n\tLastAccessedTime() time.Time\r\n\tSetLastAccessedTime(time.Time)\r\n\tDestroy()\r\n}\r\n```\r\n\r\nI would love if it included an `Exists(interface{}) bool`. This way one can check if a certain key is present, without caring at all about its contents. I could implement it and submit a PR if you'd like. \r\n\r\nThoughts?\r\n\r\n<bountysource-plugin>\r\n---\r\nWant to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/35416290-feature-request-session-exists?utm_campaign=plugin&utm_content=tracker%2F30189074&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F30189074&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>",
"title": "Feature request: session.Exists",
"type": "issue"
},
{
"action": "closed",
"author": "kataras",
"comment_id": null,
"datetime": 1466752293000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 7 | 2,410 | false | false | 2,410 | false |
infinitered/ignite-ir-boilerplate-bowser | infinitered | 322,152,182 | 19 | null | [
{
"action": "opened",
"author": "skellock",
"comment_id": null,
"datetime": 1526008072000,
"masked_author": "username_0",
"text": "`storyshots` now has a dependency on `puppeteer`.\r\n\r\nLet's investigate how to shed this. \r\n\r\nThat's a monster of a dependency we don't want until we're ready.",
"title": "puppeteer is now a dependency",
"type": "issue"
},
{
"action": "closed",
"author": "leonskim",
"comment_id": null,
"datetime": 1528143139000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "leonskim",
"comment_id": 394483205,
"datetime": 1528143139000,
"masked_author": "username_1",
"text": "Added puppeteer-independent `addon-storyshots` for now. Hope they separate the package eventually. Some info: https://github.com/storybooks/storybook/issues/3623",
"title": null,
"type": "comment"
}
] | 2 | 3 | 320 | false | false | 320 | false |
bpampuch/pdfmake | null | 359,328,306 | 1,489 | null | [
{
"action": "opened",
"author": "alejandrodr1903",
"comment_id": null,
"datetime": 1536732402000,
"masked_author": "username_0",
"text": "So, im doing a table with pdfmake, but, when im going to print it, i got the next error:\r\n\r\n\r\n\r\nMy code looks like this:\r\n`tableinfo=[\r\n\t\t\t \t\t[{text: \"Información de la empresa\", colSpan: 9}],\r\n\t\t\t\t\t\t\t[{text: 'Empresa:', style: 'dataInfoin'}, {text: arregloinfo[\"nombre\"], colSpan: 4},{text: 'Rif:', style: 'dataInfoin'},{text: arregloinfo[\"rif\"]},{text: 'Telefono Oficina:', style: 'dataInfoin'},{text: arregloinfo[\"tel_empre\"]}],\r\n\t\t\t\t\t\t\t[{text: 'Direccion:', style: 'dataInfoin'}, {text: arregloinfo[\"direccion\"], colSpan: 4},{text: 'Estado:', style: 'dataInfoin'},{text: arregloinfo[\"estado\"]},{text: 'Telefono Celular:', style: 'dataInfoin'},{text: arregloinfo[\"telmovil_empre\"]}],\r\n\t\t\t\t\t\t\t[{text: \"Reporte generado por\", colSpan: 9}],\r\n\t\t\t\t\t\t\t[{text: 'Nombre:', style: 'dataInfoin'}, {text: storedNames[\"nombre\"]+\" \"+storedNames[\"apellido\"], colSpan: 2},{text: 'Cedula:', style: 'dataInfoin'},{text: storedNames[\"cedula\"]},{text: 'Telefono Hogar:', style: 'dataInfoin'},{text: storedNames[\"telf_hogar\"]},{text: 'Telefono Celular:', style: 'dataInfoin'},{text: storedNames[\"telf_movil\"]}],\r\n\t\t\t\t\t\t];\r\nvar docDefinition = {\r\n\t\t\tcontent: [\r\n\t\t\t\t{\r\n\t\t\t\t\ttable: {\r\n\t\t\t\t\t\twidths: ['auto', 'auto', 'auto', 'auto', 'auto', 'auto', 'auto', 'auto', 'auto'],\r\n\t\t\t\t\t\theaderRows: 0,\r\n\t\t\t\t\t\tbody: tableinfo,\r\n\t\t\t\t\t}\r\n\t\t\t\t}\r\n\t\t\t],\r\n\t\t\tstyles: {\r\n\t\t\t\tdataInfoin: {\r\n\t\t\t\t\tbold: true,\r\n\t\t\t\t}\r\n\t\t\t}\r\n\t\t};\r\n\t\tpdfMake.fonts = {\r\n\t \tRoboto: {\r\n\t\t normal: 'Roboto-Regular.ttf',\r\n\t\t bold: 'Roboto-Medium.ttf',\r\n\t\t italics: 'Roboto-Italic.ttf',\r\n\t\t bolditalics: 'Roboto-MediumItalic.ttf'\r\n\t \t}\r\n\t \t};\r\n\t\tpdfMake.createPdf(docDefinition).open();`",
"title": "TypeError: p is undefined ",
"type": "issue"
}
] | 1 | 1 | 1,782 | false | false | 1,782 | false |
Jermolene/TiddlyWiki5 | null | 54,712,565 | 1,383 | {
"number": 1383,
"repo": "TiddlyWiki5",
"user_login": "Jermolene"
} | [
{
"action": "opened",
"author": "tobibeer",
"comment_id": null,
"datetime": 1421619717000,
"masked_author": "username_0",
"text": "atm they are rendered lst which is a problem for mobile / responsive ux",
"title": "place topbars first in page-layout",
"type": "issue"
},
{
"action": "created",
"author": "Jermolene",
"comment_id": 71653179,
"datetime": 1422367912000,
"masked_author": "username_1",
"text": "@username_0 we reorder the elements of the page template with the `list` field on `$:/tags/PageTemplate`. I'd be reluctant to start using two different conflicting techniques.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tobibeer",
"comment_id": 71757049,
"datetime": 1422404121000,
"masked_author": "username_0",
"text": "I understand. I didn't even considered they could have been explicitly put last. Reverted the topbar tiddlers and modified the **list** field of the tag tiddler instead.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Jermolene",
"comment_id": 71830430,
"datetime": 1422449717000,
"masked_author": "username_1",
"text": "Thanks @username_0",
"title": null,
"type": "comment"
}
] | 2 | 4 | 429 | false | false | 429 | true |
mdickin/vscode-markdown-shortcuts | null | 257,036,707 | 32 | null | [
{
"action": "opened",
"author": "Dod9er",
"comment_id": null,
"datetime": 1505221687000,
"masked_author": "username_0",
"text": "Hi,\r\none of the default keybindings I use quite often is \"Ctrl+Shift+L\" in order to change a string at multiple locations. Check editor.action.selectHighlights at https://code.visualstudio.com/docs/getstarted/keybindings for reference.\r\nIs it possble to change this keybinding for markdown-shortcuts on my own ? Didn´t find the necessary config.",
"title": "\"Ctrl+Shift+L\" for images conflicts with default keybinding for editor.action.selectHighlights",
"type": "issue"
},
{
"action": "created",
"author": "mdickin",
"comment_id": 328850747,
"datetime": 1505222374000,
"masked_author": "username_1",
"text": "Sorry about that!\r\n\r\nYou can remap that shortcut if you go to File > Preferences > Keyboard Shortcuts.\r\n\r\nSearch for \"ctrl+shift+L\" and it will bring up the conflicting bindings. You can remap it, remove it, whatever you want.\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Dod9er",
"comment_id": null,
"datetime": 1505223227000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "Dod9er",
"comment_id": 328854639,
"datetime": 1505223227000,
"masked_author": "username_0",
"text": "Ahh, ok. I´m quite new to VSCode, as you see. Thanks for your hint :+1:",
"title": null,
"type": "comment"
}
] | 2 | 4 | 756 | false | false | 756 | false |
tensorflow/tfjs | tensorflow | 391,839,730 | 1,007 | null | [
{
"action": "opened",
"author": "talvasconcelos",
"comment_id": null,
"datetime": 1545071868000,
"masked_author": "username_0",
"text": "I'm trying to use fitDataset on tfjs@0.14.1 but i can't find my way of turning my data into something fitDataset can digest. \r\n\r\nI have 2 arrays, 1 is an array of arrays with my features and the other an array of arrays with the labels.\r\n\r\nHow do i \"transform\" the data to be fed into the model with fitDataset? I've already flattened the 2 arrays into one, [0] has the features, [1] has the labels\r\n\r\ni'm getting .batch() is not a function",
"title": "VanillaJs example",
"type": "issue"
}
] | 1 | 1 | 441 | false | false | 441 | false |
dotnet/docfx | dotnet | 281,383,564 | 2,305 | null | [
{
"action": "opened",
"author": "andreycha",
"comment_id": null,
"datetime": 1513085207000,
"masked_author": "username_0",
"text": "**DocFX Version Used**: 2.28.2\r\n\r\n**Template used**: default\r\n\r\nI have following code:\r\n\r\n```\r\n/// <summary>\r\n/// See <see cref=\"Fixture.FindTag(int, TagType)\"/> for detailed information.\r\n/// </summary>\r\npublic FixtureTag FindTag(int value, TagType type)\r\n{\r\n return Tags.SingleOrDefault(p => p.Value == value && p.Type == type);\r\n}\r\n```\r\n\r\nHere is what generated and displayed in API docs:\r\n\r\n\r\n\r\nThe thing is that I deliberately omitted `<param>` and `<returns>` tags, and I'd expect them not showing in docs as well.\r\n\r\nPlease consider removing these data from metadata/UI if there are no corresponding tags in comments. E.g. there is no Exceptions section if there are no `<exception>` tags.",
"title": "Do not show Parameters and Returns if there is no corresponding tags in comments",
"type": "issue"
},
{
"action": "created",
"author": "vicancy",
"comment_id": 351901675,
"datetime": 1513307512000,
"masked_author": "username_1",
"text": "I agree that if there is no `exception` tag in comment there should not be Exception section in UI. \r\nBut in the `param` and `returns` case, it not only contains descriptions from comment, but also `Type` that links to some other pages, in your case, `FixtureTag` is clickable. So I doubt if this is a general request.\r\n\r\nThere is a feature to make the syntax clickable. When that feature is implemented, we can for sure remove these sections when comment does not exist.\r\n\r\nFor now, there is a quick way to achieve this though, to custom the partial template `class.tmpl.partial` by adding `{{description}}` existence check....\r\n\r\nWhat's your idea @username_0 ? Please feel free to let me know your suggestions and concerns.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "andreycha",
"comment_id": 352250492,
"datetime": 1513511860000,
"masked_author": "username_0",
"text": "Changing `class.tmpl.partial` is fine for me, thanks for the hint!\r\n\r\nAnd yes, I agree that when syntax becomes clickable, hiding empty sections can be made a general behavior.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "suzdalnitski",
"comment_id": 358882284,
"datetime": 1516344875000,
"masked_author": "username_2",
"text": "@username_1 \r\n@username_0 \r\n\r\nCan you please provide me with a sample `class.tmpl.partial` template to exclude empty `{{description}}` blocks? I'm just getting started with docfx, and this is way over my head...\r\n\r\nThank you!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "andreycha",
"comment_id": 358921211,
"datetime": 1516356469000,
"masked_author": "username_0",
"text": "@username_2 for example here is `return` block from `class.tmpl.partial`:\r\n\r\n```\r\n{{#return}}\r\n<h5 class=\"returns\">{{__global.returns}}</h5>\r\n<table class=\"table table-bordered table-striped table-condensed\">\r\n <thead>\r\n <tr>\r\n <th>{{__global.type}}</th>\r\n <th>{{__global.description}}</th>\r\n </tr>\r\n </thead>\r\n <tbody>\r\n <tr>\r\n <td>{{{type.specName.0.value}}}</td>\r\n <td>{{{description}}}</td>\r\n </tr>\r\n </tbody>\r\n</table>\r\n{{/return}}\r\n```\r\n\r\nall you need is to wrap its content into `{{#description}}{{/description}}`, where `#` means that the block will not be generated if `description` is empty:\r\n\r\n```\r\n{{#return}}\r\n{{#description}}\r\n...\r\n{{/description}}\r\n{{/return}}\r\n```",
"title": null,
"type": "comment"
}
] | 4 | 8 | 2,954 | false | true | 2,647 | true |
hyrise/hyrise | hyrise | 389,470,793 | 1,362 | {
"number": 1362,
"repo": "hyrise",
"user_login": "hyrise"
} | [
{
"action": "opened",
"author": "mrzzzrm",
"comment_id": null,
"datetime": 1544473301000,
"masked_author": "username_0",
"text": "Just a proposal. Feel free to reject.\r\n\r\nCloses #1341 \r\n\r\n```\r\nartifacts/\r\n├── ci\r\n├── test_data\r\n│ ├── bin\r\n│ ├── csv\r\n│ └── tbl\r\n│ ├── aggregateoperator\r\n│ │ ├── 0gb_0agg\r\n│ │ ├── 0gb_1agg\r\n│ │ ├── 0gb_2agg\r\n│ │ ├── 0gb_3agg\r\n│ │ ├── groupby_int_1gb_0agg\r\n│ │ ├── groupby_int_1gb_1agg\r\n│ │ ├── groupby_int_1gb_2agg\r\n│ │ ├── groupby_int_1gb_3agg\r\n│ │ ├── groupby_int_2gb_0agg\r\n│ │ ├── groupby_int_2gb_1agg\r\n│ │ ├── groupby_int_2gb_2agg\r\n│ │ ├── groupby_int_3gb_0agg\r\n│ │ ├── groupby_int_3gb_1agg\r\n│ │ ├── groupby_string_1gb_1agg\r\n│ │ └── join_2gb_0agg\r\n│ ├── case\r\n│ ├── expression_evaluator\r\n│ ├── joinoperators\r\n│ ├── projection\r\n│ ├── show_columns\r\n│ ├── sqlite\r\n│ └── tpch\r\n│ ├── minimal\r\n│ └── sf-0.001\r\n└── tracer_scripts\r\n```",
"title": "Reduce clutter in project root dir; move test Tables out of src/",
"type": "issue"
},
{
"action": "created",
"author": "mrzzzrm",
"comment_id": 447276562,
"datetime": 1544781784000,
"masked_author": "username_0",
"text": "Any quick opinion on this @username_1?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Bensk1",
"comment_id": 447284328,
"datetime": 1544783524000,
"masked_author": "username_1",
"text": "I really like the idea of it!",
"title": null,
"type": "comment"
}
] | 2 | 3 | 990 | false | false | 990 | true |
spences10/framework-of-the-day | null | 418,658,257 | 328 | {
"number": 328,
"repo": "framework-of-the-day",
"user_login": "spences10"
} | [
{
"action": "opened",
"author": "spences10",
"comment_id": null,
"datetime": 1552028340000,
"masked_author": "username_0",
"text": "",
"title": "Patches to dev",
"type": "issue"
}
] | 2 | 2 | 197 | false | true | 0 | false |
electron/electron | electron | 347,088,836 | 13,916 | null | [
{
"action": "opened",
"author": "envex",
"comment_id": null,
"datetime": 1533227843000,
"masked_author": "username_0",
"text": "* Electron Version: Electron 2.0.0\r\n* Operating System (Platform and Version): macOS High Sierra 10.13.6 (17G65)\r\n\r\n**Expected Behavior**\r\n\r\nIdeally the `setApplicationMenu` event is ignored, or the menu items are updated. \r\n\r\nThis may not be a bug, but if the event can't be ignored, it would be nice to have a method of checking if the menu has focus, so I can not call `setApplicationMenu`.\r\n\r\n**Actual behavior**\r\n\r\nCalling `setApplicationMenu` while the top menu has focus \"crashes\" the menu.\r\n\r\n**To Reproduce**\r\n\r\n- Load up the app on the `set-menu-bug`.\r\n- Press down on a menu item and don't mouseup.\r\n- Once the `setInterval` tries to update the menu, you'll notice the menu crashes.\r\n\r\nVideo: https://www.dropbox.com/s/pzgq3fa4gl4655n/set-menu-bug.mov?dl=0\r\n\r\nBranch: https://github.com/username_0/electron-quick-start/tree/set-menu-bug\r\n\r\n```sh\r\n$ git clone git@github.com:username_0/electron-quick-start.git -b set-menu-bug\r\n$ npm install\r\n$ npm start || electron .\r\n```",
"title": "Calling setApplicationMenu when the menu has focus removes the submenu",
"type": "issue"
},
{
"action": "created",
"author": "envex",
"comment_id": 410544525,
"datetime": 1533499710000,
"masked_author": "username_0",
"text": "Thank you!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sethlu",
"comment_id": 410545035,
"datetime": 1533500228000,
"masked_author": "username_1",
"text": "@username_0 Would you mind checking if the same issue occurs in Electron 3 too? (I think it's prolly fixed 🤔 now.)\r\n\r\n@username_2 I made this PR a while ago that went into Electron 3: https://github.com/electron/electron/pull/12809",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "envex",
"comment_id": 410545128,
"datetime": 1533500322000,
"masked_author": "username_0",
"text": "@username_1 Will check right now.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sethlu",
"comment_id": 410546157,
"datetime": 1533501326000,
"masked_author": "username_1",
"text": "@username_0 Glad to hear about that 😺 \r\n\r\n@MarshallOfSound @username_2 Shall we back port https://github.com/electron/electron/pull/12809 to Electron 2?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "codebytere",
"comment_id": 410549532,
"datetime": 1533504655000,
"masked_author": "username_2",
"text": "@username_1 i'd say so, on it rn!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "envex",
"comment_id": 421352656,
"datetime": 1536930462000,
"masked_author": "username_0",
"text": "@username_1 Thank you!",
"title": null,
"type": "comment"
}
] | 3 | 7 | 1,432 | false | false | 1,432 | true |
eerohele/dita-ot-gradle | null | 277,508,123 | 14 | null | [
{
"action": "opened",
"author": "sanderson-sfdc",
"comment_id": null,
"datetime": 1511897135000,
"masked_author": "username_0",
"text": "I'd love to be able to do something like this:\r\n\r\n`repositories {\r\n mavenCentral()\r\n}\r\n\r\nplugins {\r\n id 'com.github.username_1.dita-ot-gradle' version '0.5.0'\r\n}\r\n\r\ndependencies {\r\n compile 'com.github.dita-ot:dita-ot-minimal:1.8.2'\r\n}`\r\n\r\nrather than have to do a prior install. This works well with the other enhancement about running an install task. For an automated continuous integration system I could then start from a clean VM and run a build with all my extensions.",
"title": "Use dita-ot-minimal gradle package instead of requiring an installed version",
"type": "issue"
},
{
"action": "created",
"author": "eerohele",
"comment_id": 347661664,
"datetime": 1511902775000,
"masked_author": "username_1",
"text": "That *would* be nice. To be honest, I hadn't realized that was an option.\r\n\r\nAlthough I suppose it'd be better to use `org.dita-ot:dost:3.0` instead, since it seems like the artifact at `com.github.dita-ot` hasn't been updated in quite a while.\r\n\r\nI'll have to look into whether I can make that work. I'm not sure how you'd call DITA-OT in this scenario.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sanderson-sfdc",
"comment_id": 347668027,
"datetime": 1511904180000,
"masked_author": "username_0",
"text": "Are you sure you're using a valid DITA-OT directory?\r\n\r\n* Try:\r\nRun with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.\r\n\r\nBUILD FAILED'\r\n\r\nWhat plugin file is it looking for?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sanderson-sfdc",
"comment_id": 347671006,
"datetime": 1511904866000,
"masked_author": "username_0",
"text": "I'm pretty sure dost is just the jar, not the entire OT package. If we can get this working, I'm sure we can get some more recent OT packages made available.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eerohele",
"comment_id": 347894293,
"datetime": 1511969116000,
"masked_author": "username_1",
"text": "It's looking for either `config/plugins.xml` or `resources/plugins.xml` in the DITA-OT directory. I might be wrong, but I think that file didn't yet exist in DITA-OT 1.8.\r\n\r\nIt might also be that that approach doesn't work because the DITA-OT Gradle Plugin is looking for the file before the `extractOt` task is executed. I'll need to investigate to be sure.\r\n\r\nAn alternative solution to defining a Maven dependency would be to use the [Gradle Download Task](https://github.com/michel-kraemer/gradle-download-task) to download the [DITA-OT distribution package](https://github.com/dita-ot/dita-ot/releases/download/3.0/dita-ot-3.0.zip), extract it, and point the DITA-OT Gradle Plugin to use that installation. I think I might actually prefer that option.\r\n\r\nI'll see if I have the time to look into this over the weekend.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fviolette",
"comment_id": 380937571,
"datetime": 1523565633000,
"masked_author": "username_2",
"text": "I favor the second approach mentioned too: for one particular project, authors always build locally first . It's extremely helpful to rely on DITA-OT Gradle with the Wrapper and couple of other helper plugins – like grgit, gradle-download-task and saxon-gradle :+1:\r\n\r\nDefining `ditaOt.dir` with a closure within the `dita` task does the job:\r\n\r\n```\r\nplugins {\r\n id \"de.undercouch.download\" version '3.4.2'\r\n id 'com.github.username_1.dita-ot-gradle' version '0.5.0'\r\n id 'com.github.username_1.saxon-gradle' version '0.3.0'\r\n}\r\n\r\ndef ditaOtVersion = '2.5.1'\r\n\r\ntask downloadZipFile(type: Download) {\r\n src \"https://github.com/dita-ot/dita-ot/releases/download/${ditaOtVersion}/dita-ot-${ditaOtVersion}.zip\"\r\n dest new File(buildDir, \"dita-ot-${ditaOtVersion}.zip\")\r\n overwrite false\r\n}\r\n\r\ntask downloadAndUnzipFile(dependsOn: downloadZipFile, type: Copy) {\r\n from zipTree(downloadZipFile.dest)\r\n into buildDir\r\n}\r\n\r\ndita {\r\n doFirst {\r\n ditaOt.dir \"${buildDir}/dita-ot-${ditaOtVersion}\"\r\n }\r\n input 'guidelines.ditamap'\r\n output outputDir\r\n transtype 'html5'\r\n}\r\n\r\ndefaultTasks 'downloadAndUnzipFile', 'dita'\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sanderson-sfdc",
"comment_id": 391426877,
"datetime": 1527095450000,
"masked_author": "username_0",
"text": "Great solution @username_2. You mention you'd prefer this way than the dependency, because it would allow people to build locally.\r\n\r\nI think the way to resolve that would be to have two Maven/gradle packages; one that's a \"full\" DITA-OT install, with all the scripts you mention, and another, a \"core\" DITA-OT that is aimed at gradle-only usage.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eerohele",
"comment_id": 391677347,
"datetime": 1527160468000,
"masked_author": "username_1",
"text": "Sorry about the delayed response.\r\n\r\n@username_2: Using `doFirst` inside `dita` is a nice trick! That hadn't occurred to me.\r\n\r\nIt might actually be better if the plugin didn't require DITA-OT to be present in the configuration phase at all so that you would't need to use `doFirst`, but I'm not sure I can make that change in a backwards-compatible way.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fviolette",
"comment_id": 391687647,
"datetime": 1527163024000,
"masked_author": "username_2",
"text": "@username_1 @username_3 Would `plugins` fit in this closure? Last time I checked it didn't but I don't recall to be honest.\r\n\r\nGenerally speaking, fully support the last remark :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lionelmoi",
"comment_id": 391705029,
"datetime": 1527166696000,
"masked_author": "username_3",
"text": "I actually don't use the 'plugin' mechanism... I use I use an 'exec' task to call the 'dita --install' command after copying my plugins in the 'plugins' folder.\r\n\r\n@username_1 \r\n\"It might actually be better if the plugin didn't require DITA-OT to be present in the Gradle configuration phase\"\r\n\r\nThat would be great indeed!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eerohele",
"comment_id": 392030049,
"datetime": 1527249225000,
"masked_author": "username_1",
"text": "This doesn't seem too difficult. I modified the plugin so that this works:\r\n\r\n```groovy\r\nplugins {\r\n id \"de.undercouch.download\" version '3.4.2'\r\n id 'com.github.username_1.dita-ot-gradle' version '0.6.0-SNAPSHOT'\r\n}\r\n\r\ndef ditaOtVersion = '3.0.4'\r\n\r\ntask downloadZipFile(type: Download) {\r\n src \"https://github.com/dita-ot/dita-ot/releases/download/${ditaOtVersion}/dita-ot-${ditaOtVersion}.zip\"\r\n dest new File(buildDir, \"dita-ot-${ditaOtVersion}.zip\")\r\n overwrite false\r\n}\r\n\r\ntask downloadAndUnzipFile(dependsOn: downloadZipFile, type: Copy) {\r\n from zipTree(downloadZipFile.dest)\r\n into buildDir\r\n}\r\n\r\ndefaultTasks 'dita'\r\n\r\ndita {\r\n dependsOn downloadAndUnzipFile\r\n ditaOt \"${buildDir}/dita-ot-${ditaOtVersion}\"\r\n input 'dita/root.ditamap'\r\n transtype 'html5', 'pdf'\r\n}\r\n```\r\n\r\nI'll just need to clean up the code and write some tests before I can release a new version of the plugin.\r\n\r\nThen again, it might be convenient if you could just define something like `ditaOtVersion`. The plugin would then download that DITA-OT version from GitHub, install any plugins you've specified in `plugins`, then run your build.\r\n\r\nThat's a bigger effort, though, and I'm not sure I'll have the time to get to that any time soon, I'm afraid.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lionelmoi",
"comment_id": 392030717,
"datetime": 1527249401000,
"masked_author": "username_3",
"text": "You rock!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eerohele",
"comment_id": 393039398,
"datetime": 1527659819000,
"masked_author": "username_1",
"text": "I looked into modifying the plugin so that you'd just have to specify a DITA-OT version, and the plugin would then download and install it so that you could just start publishing.\r\n\r\nThe downloading bit isn't too difficult, but I haven't yet found a way to specify the DITA-OT version so that it works.\r\n\r\nAlso, adding support for installing plugins isn't very easy, because there's no super-straightforward and reliable way of checking whether a plugin is installed. The current implementation doesn't seem to take this into account.\r\n\r\nFurthermore, doing that while retaining backwards compatibility is quite tricky.\r\n\r\nAt the moment, my thinking is that I'll add support for making it easier to use the plugin in conjunction with the Download plugin and leave it up to the user to make things work.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eerohele",
"comment_id": 395340722,
"datetime": 1528360771000,
"masked_author": "username_1",
"text": "I'm quite swamped at the moment, but I'll try to do it as soon as I can.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eerohele",
"comment_id": 395495791,
"datetime": 1528391369000,
"masked_author": "username_1",
"text": "Note, though, that the API is subject to change at this point.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fviolette",
"comment_id": 396891958,
"datetime": 1528885949000,
"masked_author": "username_2",
"text": "Initial tests work OK on my end (no plugins).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lionelmoi",
"comment_id": 396892445,
"datetime": 1528886074000,
"masked_author": "username_3",
"text": "Defining the ditaOt.dir during execution phase seems to work for me too. \r\n\r\nI can't make plugins work yet but I may not be using it right.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eerohele",
"comment_id": 396920685,
"datetime": 1528893118000,
"masked_author": "username_1",
"text": "Plugins aren't supported yet. It's a bit complicated. See #19.\r\n\r\nLet's continue the discussion there.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "eerohele",
"comment_id": 552762720,
"datetime": 1573542113000,
"masked_author": "username_1",
"text": "0.6.0 is out with support for downloading DITA-OT and installing plugins from the plugin registry prior to publishing things.\r\n\r\nSee the buildfile [`download`](https://github.com/username_1/dita-ot-gradle/blob/master/examples/download/build.gradle) example for details.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "eerohele",
"comment_id": null,
"datetime": 1573542114000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 20 | 7,165 | false | false | 7,165 | true |
kekyo/gcc-toolchain | null | 287,757,213 | 4 | null | [
{
"action": "opened",
"author": "mingwandroid",
"comment_id": null,
"datetime": 1515671005000,
"masked_author": "username_0",
"text": "It does everything this does and so much more.",
"title": "Do you know about crosstool-ng?",
"type": "issue"
},
{
"action": "created",
"author": "kekyo",
"comment_id": 356932789,
"datetime": 1515677077000,
"masked_author": "username_1",
"text": "@username_0 Very thanks Ray! I didn't know it project and I feel better way for use it :)\r\nI'll practice it!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kekyo",
"comment_id": 357611005,
"datetime": 1516004315000,
"masked_author": "username_1",
"text": "@username_0 Thanks suggestion, I tested, it can't compile on MSYS2/MinGW environment (Failed permission bit check by configure). I feel it's related for:\r\n\r\n* https://github.com/crosstool-ng/crosstool-ng/issues/749\r\n* https://github.com/crosstool-ng/crosstool-ng/issues/715\r\n\r\nHmm... it's a shame :(",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Smasherr",
"comment_id": 444807475,
"datetime": 1544088680000,
"masked_author": "username_2",
"text": "I have opened crosstool-ng/crosstool-ng#715 but still I was able to compile it under cygwin.",
"title": null,
"type": "comment"
}
] | 3 | 4 | 549 | false | false | 549 | true |
sphinx-doc/sphinx | sphinx-doc | 132,879,501 | 2,309 | null | [
{
"action": "opened",
"author": "tk0miya",
"comment_id": null,
"datetime": 1455161687000,
"masked_author": "username_0",
"text": "In [reStructuredText Markup Specification](http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#hyperlink-targets), \"indirect hyperlink targets\" is introduced.\r\nIt can define an alias of hyperlink targets.\r\n\r\nIt works fine with Sphinx. But, it could not refer them by `:ref:` role.\r\n\r\nExample::\r\n```\r\n.. indirect hyperlink targets\r\n\r\n.. _one: two_\r\n.. _two: three_\r\n.. _three:\r\n\r\n.. figure:: logo.jpg\r\n\r\n caption of figure\r\n\r\nReference Names:\r\n one_, two_ and three_ work fine.\r\n\r\nReference role:\r\n :ref:`three` works fine. But :ref:`one` and :ref:`two` does not work.\r\n```\r\n\r\nIt warns like following:\r\n```\r\n/Users/tkomiya/work/tmp/doc/index.rst:23: WARNING: undefined label: one (if the link has no caption the label must precede a section header)\r\n/Users/tkomiya/work/tmp/doc/index.rst:23: WARNING: undefined label: two (if the link has no caption the label must precede a section header)\r\n```",
"title": "Could not refer \"indirect hyperlink targets\" by ref-role",
"type": "issue"
},
{
"action": "created",
"author": "shimizukawa",
"comment_id": 182694328,
"datetime": 1455163970000,
"masked_author": "username_1",
"text": "I hope this patch solve the issue.\r\n```diff\r\ndiff --git a/sphinx/domains/std.py b/sphinx/domains/std.py\r\nindex 9fb16a9..dcf87e3 100644\r\n--- a/sphinx/domains/std.py\r\n+++ b/sphinx/domains/std.py\r\n@@ -541,6 +541,8 @@ class StandardDomain(Domain):\r\n env.warn_node('duplicate label %s, ' % name + 'other instance '\r\n 'in ' + env.doc2path(labels[name][0]), node)\r\n anonlabels[name] = docname, labelid\r\n+ while node.tagname == 'target':\r\n+ node = node.next_node(siblings=True)\r\n if node.tagname == 'section':\r\n sectname = clean_astext(node[0]) # node[0] == title node\r\n elif node.tagname == 'figure':\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tk0miya",
"comment_id": 182709114,
"datetime": 1455166741000,
"masked_author": "username_0",
"text": "@username_1 It does not work following case:\r\n```\r\n.. _one: two_\r\n.. _three:\r\n\r\n.. figure:: logo.jpg\r\n\r\n caption of figure\r\n\r\nReference Names:\r\n one_, two_ and three_ work fine.\r\n\r\nReference role:\r\n :ref:`three` works fine. But :ref:`one` and :ref:`two` does not work.\r\n\r\n.. _two: three_\r\n```\r\n\r\n`node.next_node()` is not good to resolve indirect hyperlink target. we have to trace the references recursively.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tk0miya",
"comment_id": 213890327,
"datetime": 1461474039000,
"masked_author": "username_0",
"text": "Fixed at ad738a0.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tk0miya",
"comment_id": null,
"datetime": 1461474044000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 5 | 2,075 | false | false | 2,075 | true |
prettier/vim-prettier | prettier | 433,155,472 | 183 | null | [
{
"action": "opened",
"author": "Fandekasp",
"comment_id": null,
"datetime": 1555316790000,
"masked_author": "username_0",
"text": "**Do you want to request a *feature* or report a *bug*?**\r\nBug\r\n\r\n**What is the current/expected behavior?**\r\nfile syntax coloration should behave independently from plugins like vim-prettier.\r\n\r\nvim-prettier enabled\r\n\r\n\r\nvim-prettier disabled\r\n\r\n\r\n* disabling the 3 lines is the only thing I changed in my vimrc.\r\n* Auto-selection of htmldjango filetype over html is done by plugin 'tweekmonster/django-plus.vim'\r\n* As you can see in the screenshot, html/htmldjango filetypes aren't evne listed in the vim-prettier Plug for list. Therefore I cannot run `:PrettierVersion` from that file\r\n\r\n**What version of `vim-prettier` are you using - (output of `:PrettierVersion`) ?**\r\nwhen run from a js file, I get `0.2.7`\r\n\r\n**What version of `prettier` are you using - (output of `:PrettierCliVersion`) ?**\r\n```\r\nnode: error while loading shared libraries: libicui18n.so.63: cannot open shared object file: No such file or directory^@\r\n```\r\n⇒ Well, maybe that's the reason of the problem, although I'd love to understand the reason for the libicui18n library to break filetype selection when vim-prettier is on.\r\n\r\n**What is your `prettier` executable path - (output of `:PrettierCliPath`) ?**\r\n/home/dori/.vim/plugged/vim-prettier/node_modules/.bin/prettier\r\n\r\n**Did this work in previous versions of vim-prettier and/or prettier ?**\r\nI think so.",
"title": "No syntax color for html files when vim-prettier is enabled",
"type": "issue"
},
{
"action": "created",
"author": "Fandekasp",
"comment_id": 483157769,
"datetime": 1555316953000,
"masked_author": "username_0",
"text": "Tried a quickfix with\r\n```console\r\n$ sudo ln -s /usr/lib/libicui18n.so /usr/lib/libicui18n.so.63\r\n$ sudo ln -s /usr/lib/libicuuc.so /usr/lib/libicuuc.so.63\r\n```\r\n\r\nbut it's getting uglier\r\n\r\n```\r\n:PrettierCliVersion\r\nnode: symbol lookup error: node: undefined symbol: _ZN6icu_638ByteSink15GetAppendBufferEiiPciPi^\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Fandekasp",
"comment_id": 483169066,
"datetime": 1555318960000,
"masked_author": "username_0",
"text": "@junegunn @tweekmonster any idea why this is happening? How can I debug this?\r\nThanks for your help",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Fandekasp",
"comment_id": 525529108,
"datetime": 1566982970000,
"masked_author": "username_0",
"text": "@username_1 sorry, I have never used vim-prettier in the end, and am not working on a js project at the moment. But I'll keep in mind that you release a new version for the next opportunity, thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mitermayer",
"comment_id": 526006116,
"datetime": 1567049413000,
"masked_author": "username_1",
"text": "Hi @username_0,\r\n\r\nThanks for letting me know. Will close this issue :) feel free to re-open in the future if you still experience this issue",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mitermayer",
"comment_id": null,
"datetime": 1567049413000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 2,171 | false | false | 2,171 | true |
billmalarky/react-native-queue | null | 309,596,174 | 9 | null | [
{
"action": "opened",
"author": "laurisaarni",
"comment_id": null,
"datetime": 1522290379000,
"masked_author": "username_0",
"text": "Please see the issue https://github.com/realm/realm-js/issues/1711.\r\n\r\nUsing realm version 2.2.15 fixes the bug.",
"title": "A bug in Realm js version crashes the app when using remote debugger. ",
"type": "issue"
},
{
"action": "created",
"author": "billmalarky",
"comment_id": 377282636,
"datetime": 1522339003000,
"masked_author": "username_1",
"text": "Looks like that may not resolve it.\r\n\r\nhttps://github.com/realm/realm-js/issues/1711#issuecomment-377091874",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "saarnilauri",
"comment_id": 377425650,
"datetime": 1522375869000,
"masked_author": "username_2",
"text": "@username_1 In my case, I had a dependency to Realm in my package.json and to react-native-queue when I changed mine and react-native-queue to use 2.2.15 the problem was gone. I'm not sure if the user claiming it did not work had a similar use case.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "juliancorrea",
"comment_id": 383069000,
"datetime": 1524224097000,
"masked_author": "username_3",
"text": "About this issue, see this: https://github.com/facebook/react-native/issues/11989#issuecomment-314111441\r\n\r\nThe commit that solve the problem is: https://github.com/realm/realm-js/pull/1744/files/aed0fa5cd97db9d19b6951815f369ff943d82d20 e was merged on master.\r\n\r\nHowever, there is no release with it, so I've change the file realm/lib/browser/index.js until a new release.\r\n\r\nIts necessary change the realm/lib/user.js, commenting the line 45, because the 'Cannot redefine property: logout' problem.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "maxhalty",
"comment_id": 384407135,
"datetime": 1524684721000,
"masked_author": "username_4",
"text": "Hi Guys! do you know when the next release will be? We really need this fix and for now we are commenting the line but that's not a good fix for our team.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "billmalarky",
"comment_id": 385079684,
"datetime": 1524859491000,
"masked_author": "username_1",
"text": "@username_2 To be clear, if I explicitly set the realm dependency in package.json to \"2.2.15\" as in the PR below (I'll increment the patch version directly on master) this should resolve the issue to your knowledge (assuming people nuke node_modules and rerun yarn or npm install)?\r\n\r\nhttps://github.com/username_1/react-native-queue/pull/19",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "billmalarky",
"comment_id": 385082538,
"datetime": 1524860195000,
"masked_author": "username_1",
"text": "Realm is on 2.4.0 now, is this still even an issue?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Shubham-Sinha",
"comment_id": 386577896,
"datetime": 1525434691000,
"masked_author": "username_5",
"text": "Use this ``adb logcat *:S ReactNative:V ReactNativeJS:V BackgroundTask:V`` to log and debug",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "saarnilauri",
"comment_id": 423874005,
"datetime": 1537762690000,
"masked_author": "username_2",
"text": "Fine by me",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "billmalarky",
"comment_id": null,
"datetime": 1537815244000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "billmalarky",
"comment_id": 424085282,
"datetime": 1537815244000,
"masked_author": "username_1",
"text": "👌",
"title": null,
"type": "comment"
}
] | 6 | 11 | 1,620 | false | false | 1,620 | true |
mne-tools/mne-python | mne-tools | 398,360,021 | 5,831 | {
"number": 5831,
"repo": "mne-python",
"user_login": "mne-tools"
} | [
{
"action": "opened",
"author": "larsoner",
"comment_id": null,
"datetime": 1547224016000,
"masked_author": "username_0",
"text": "Should get tests passing on 3.7, and enable one of our Travis runs to use 3.7.",
"title": "FIX: Minor fixes for 3.7",
"type": "issue"
},
{
"action": "created",
"author": "larsoner",
"comment_id": 453717699,
"datetime": 1547266074000,
"masked_author": "username_0",
"text": "The segmentation faults I fought through here *might* relate to #5806.\r\n\r\nBut in any case, ready for review/merge if the CIs come back happy finally.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "agramfort",
"comment_id": 453730725,
"datetime": 1547282402000,
"masked_author": "username_1",
"text": "thx @username_0",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "agramfort",
"comment_id": 453754384,
"datetime": 1547305456000,
"masked_author": "username_1",
"text": "let's say it's just a hunch as we have no other painful compiled code than\nvtk...\n\nUnfortunately I cannot replicated easily :(",
"title": null,
"type": "comment"
}
] | 3 | 5 | 888 | false | true | 366 | true |
oliviertassinari/react-swipeable-views | null | 249,680,614 | 321 | null | [
{
"action": "opened",
"author": "storrisi",
"comment_id": null,
"datetime": 1502467683000,
"masked_author": "username_0",
"text": "Don't know if it possible, i would like to use this to swipe the columns of a MultiGrid component of react-virtualized",
"title": "How to use this with a Grid?",
"type": "issue"
},
{
"action": "created",
"author": "oliviertassinari",
"comment_id": 321855294,
"datetime": 1502468035000,
"masked_author": "username_1",
"text": "I have no clue, let us know if it's possible :).",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "oliviertassinari",
"comment_id": null,
"datetime": 1502468035000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "storrisi",
"comment_id": 332187218,
"datetime": 1506430122000,
"masked_author": "username_0",
"text": "Done! I'll post here the solution if you want",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "oliviertassinari",
"comment_id": 332204510,
"datetime": 1506433845000,
"masked_author": "username_1",
"text": "Yeah, I'm always happy to hear more about how people use this lib! We could even use it to add a demo in the docs.",
"title": null,
"type": "comment"
}
] | 2 | 5 | 325 | false | false | 325 | false |
wagenaartje/neataptic | null | 435,327,057 | 152 | null | [
{
"action": "opened",
"author": "AZE38",
"comment_id": null,
"datetime": 1555714997000,
"masked_author": "username_0",
"text": "hi, i want to train a network with evolve, i dont have output target, i just want to take the \"better\" network ,with my \"condtion\" in game -> \"create-news and mutate\" from this network ! I can do this ? if yes, how ? ^^ ( sry for my english..)\r\n\r\nthx !",
"title": "How to define output for evolve without target in game.",
"type": "issue"
},
{
"action": "created",
"author": "AZE38",
"comment_id": 485034738,
"datetime": 1555715318000,
"masked_author": "username_0",
"text": "beacause all of i have seen, i have to define \r\n\r\nvar trainingSet = [\r\n { input: [0,0], output: [0] },\r\n { input: [0,1], output: [1] },\r\n { input: [1,0], output: [1] },\r\n { input: [1,1], output: [0] }\r\n ];\r\n\r\n\r\nBut i have juste one input [0...,i,.....n], who change in each \"FPS\" , and no \"output\"... so i want to \"decomposed\" the training, and select each \"better\" for my next generation.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AZE38",
"comment_id": 485035729,
"datetime": 1555715783000,
"masked_author": "username_0",
"text": "oohhhh.... is juste methods.selection.TOURNAMENT ?\r\n\r\nSry ^^",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AZE38",
"comment_id": 485036368,
"datetime": 1555716076000,
"masked_author": "username_0",
"text": "hoo..i just must to do my own selection ->crossover->mutation .... from all of my starting network ? and stop when i m happy.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AZE38",
"comment_id": 485042301,
"datetime": 1555719232000,
"masked_author": "username_0",
"text": "sry for useless post ^^",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rhysstubbs",
"comment_id": 487849392,
"datetime": 1556610093000,
"masked_author": "username_1",
"text": "@username_0 please close the issue if this is resolved.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "AZE38",
"comment_id": null,
"datetime": 1558735408000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 7 | 912 | false | false | 912 | true |
wenzhixin/bootstrap-table | null | 163,414,845 | 2,422 | {
"number": 2422,
"repo": "bootstrap-table",
"user_login": "wenzhixin"
} | [
{
"action": "opened",
"author": "fenichelar",
"comment_id": null,
"datetime": 1467385478000,
"masked_author": "username_0",
"text": "",
"title": "Add auto refresh extension",
"type": "issue"
},
{
"action": "created",
"author": "wenzhixin",
"comment_id": 230130979,
"datetime": 1467511233000,
"masked_author": "username_1",
"text": "Can you help to provide a jsfiddle example to show the extension?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fenichelar",
"comment_id": 232182180,
"datetime": 1468357769000,
"masked_author": "username_0",
"text": "Yes. I will post asap.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fenichelar",
"comment_id": 247997093,
"datetime": 1474292724000,
"masked_author": "username_0",
"text": "http://jsfiddle.net/username_0/n6kkrc4t/\r\n\r\nUnable to load data from a URL in the fiddle so it is kinda useless.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "wenzhixin",
"comment_id": 280228807,
"datetime": 1487219689000,
"masked_author": "username_1",
"text": "Merged into develop https://github.com/username_1/bootstrap-table/commit/3b79e931adcbbc277398309fb7278a46925b3099",
"title": null,
"type": "comment"
}
] | 2 | 5 | 311 | false | false | 311 | true |
IBM/ibm-cloud-functions-serverless-apis | IBM | 446,908,236 | 85 | {
"number": 85,
"repo": "ibm-cloud-functions-serverless-apis",
"user_login": "IBM"
} | [
{
"action": "opened",
"author": "dokun1",
"comment_id": null,
"datetime": 1558493461000,
"masked_author": "username_0",
"text": "I've made some updates so that this works with the revised `ibmcloud` command line interface. Most of the commands work, but the `ibmcloud login` method with all of the flags doesn't quite work the way I'm expecting it to. Nonetheless, the individual action creation methods work now, and they're good enough for a client workshop.",
"title": "CLI Updates",
"type": "issue"
},
{
"action": "created",
"author": "dokun1",
"comment_id": 494786429,
"datetime": 1558529104000,
"masked_author": "username_0",
"text": "@username_1 let me know when you have time to take a peek at this - I feel like this might be an easy PR to merge in 😄",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stevemar",
"comment_id": 494807814,
"datetime": 1558532525000,
"masked_author": "username_1",
"text": "Thanks @username_0 !",
"title": null,
"type": "comment"
}
] | 2 | 3 | 463 | false | false | 463 | true |
metwork-framework/mfdata | metwork-framework | 418,235,534 | 66 | {
"number": 66,
"repo": "mfdata",
"user_login": "metwork-framework"
} | [
{
"action": "opened",
"author": "thefab",
"comment_id": null,
"datetime": 1551954510000,
"masked_author": "username_0",
"text": "Now (and it is on by default), we can dump tags into another file\r\n(like with archive plugins) when moving the file to the trash.\r\n\r\nClose #65",
"title": "feat: fix #65 and introduce new configuration options around",
"type": "issue"
}
] | 2 | 2 | 264 | false | true | 142 | false |
Urigo/angular-meteor | null | 200,715,283 | 1,546 | null | [
{
"action": "closed",
"author": "dotansimha",
"comment_id": null,
"datetime": 1484466782000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 5 | 7,126 | false | true | 0 | false |
qhacks/hacker-dashboard | qhacks | 333,774,858 | 131 | {
"number": 131,
"repo": "hacker-dashboard",
"user_login": "qhacks"
} | [
{
"action": "opened",
"author": "joeytepp",
"comment_id": null,
"datetime": 1529430572000,
"masked_author": "username_0",
"text": "## Proposed Change\r\nUse [jest](https://facebook.github.io/jest/docs/en/getting-started.html) for unit testing on the hacker dashboard\r\nFixes Issue Ticket: #126 \r\n\r\n### Description\r\nAfter investigating several options, chose jest as unit testing framework for ongoing development\r\n### List of changes:\r\n\r\n\t- Added jest to dependencies\r\n\t- Added jest testing to `test` script in `package.json`\r\n\t- Created an example test file in tests folder\r\n\r\n## Pull Request Checklist:\r\n\r\n\t1. [ ] Does your submission pass tests?\r\n\t2. [ ] Have you lint your code locally prior to submission?\r\n\t3. [ ] Have you written new tests for your core changes, as applicable?",
"title": "Add jest for unit testing",
"type": "issue"
},
{
"action": "created",
"author": "joeytepp",
"comment_id": 398499835,
"datetime": 1529433019000,
"masked_author": "username_0",
"text": "@username_1 the client unit tests fail unless you run npm install from inside the client folder, do you know any way around this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joeytepp",
"comment_id": 400527658,
"datetime": 1530068399000,
"masked_author": "username_0",
"text": "@username_1 sounds good, gonna make some revisions on this after the long weekend 👍",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RobertWSaunders",
"comment_id": 402334386,
"datetime": 1530666913000,
"masked_author": "username_1",
"text": "Looks you have some conflicts to solve from the merging of #133. Your tests should be passing after that though, unless your new unit tests fail ahaha.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RobertWSaunders",
"comment_id": 402342725,
"datetime": 1530670433000,
"masked_author": "username_1",
"text": "Updated the PR to use the new template for ya! Excited to have this in and get some experience writing some tests for our endpoints, this will be an awesome contribution that will lead to better code and a more bullet proof project.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joeytepp",
"comment_id": 404364891,
"datetime": 1531360605000,
"masked_author": "username_0",
"text": "@username_1 ready for you to review this now. Also squashed and cherrypicked the original branch to fix the files changed issue",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joeytepp",
"comment_id": 406299332,
"datetime": 1532011083000,
"masked_author": "username_0",
"text": "@username_1 still waiting on this one ⏱🕚⏳🙃",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joeytepp",
"comment_id": 407593289,
"datetime": 1532478149000,
"masked_author": "username_0",
"text": "@username_1 missed some of your comments on my initial response, think i've addressed them all now. I'll get rid of the `jsconfig` stuff now and we will figure out the rest 👍",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RobertWSaunders",
"comment_id": 407789665,
"datetime": 1532531544000,
"masked_author": "username_1",
"text": "Lemme know when this is good for another review!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joeytepp",
"comment_id": 407965681,
"datetime": 1532576053000,
"masked_author": "username_0",
"text": "@username_1 see my comments on the access token/env stuff, ready for you to give this another review (also added a badge to the README)",
"title": null,
"type": "comment"
}
] | 2 | 10 | 1,801 | false | false | 1,801 | true |
coreos/go-oidc | coreos | 375,504,579 | 183 | null | [
{
"action": "opened",
"author": "pankrator",
"comment_id": null,
"datetime": 1540908054000,
"masked_author": "username_0",
"text": "Would it make sense to add possibility to skip the Issuer URL [check][2], like the [client id][1]?\r\nWe have a use case where the Authorization server issues tokens with different issuer urls.\r\n\r\n[1]: https://github.com/coreos/go-oidc/blob/v2/verify.go#L86\r\n[2]: https://github.com/coreos/go-oidc/blob/v2/verify.go#L234-L243",
"title": "Skip issuer URL check",
"type": "issue"
},
{
"action": "created",
"author": "ericchiang",
"comment_id": 434760932,
"datetime": 1541004239000,
"masked_author": "username_1",
"text": "dup of https://github.com/coreos/go-oidc/issues/159 and several other issues\r\n\r\ntl;dr - no",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ericchiang",
"comment_id": null,
"datetime": 1541027447000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 413 | false | false | 413 | false |
inorganik/countUp.js | null | 405,716,485 | 209 | null | [
{
"action": "opened",
"author": "ScottHarrisonDev",
"comment_id": null,
"datetime": 1549030108000,
"masked_author": "username_0",
"text": "<!-- Please enter the info below -->\r\n```\r\n[X] Bug\r\n[ ] Feature request\r\n\r\nCountUp.js version:\r\n1.9.3\r\n```\r\n\r\n## Description\r\n`startVal` seems to be ignored on Firefox and Safari (latest versions of both) as the counter starts from 0 in these browsers however it starts from the value that is set in the JS on chrome.\r\n\r\n### Steps to reproduce\r\n1. Create new CountUp instance with a `startVal` that is greater than 0. For example 200000000\r\n2. View the counter in chrome to verify that is working correctly. It should start at 200000000.\r\n3. View in Ffirefox/Safari and you should see the counter starting from 0 rather than the 200000000 it should be.",
"title": "startVal is ignored on Firefox and Safari",
"type": "issue"
},
{
"action": "created",
"author": "inorganik",
"comment_id": 459777494,
"datetime": 1549037858000,
"masked_author": "username_1",
"text": "Hmm, I couldn't reproduce. I ran the demo at http://username_1.github.io/countUp.js/ on Safari and Firefox, with 200000000 as the start val and it worked fine. The demo creates a new instance every time you click \"start\". \r\n\r\nJust to make sure, in Firefox I copied from the code visualizer into the console:\r\n```js\r\nvar demo = new CountUp('myTargetElement', 200000000, 5182, 0, 2.5, options);\r\n```\r\nAs expected, it changed the startVal to 200000000. Then I did:\r\n```js\r\ndemo.start();\r\n```\r\nAnd it worked fine.\r\n\r\nCan you please copy all your js and html that is relevant to countUp and paste it here so I can see if anything else could be the issue? Likely your selector or how you are passing the values.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ScottHarrisonDev",
"comment_id": null,
"datetime": 1549039972000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ScottHarrisonDev",
"comment_id": 459789358,
"datetime": 1549039972000,
"masked_author": "username_0",
"text": "Thanks for the prompt responses Jamie, looking into the code (We inherited the code and only have the minified JS so as you can imagine it's a bit of a slog!) I just found a line of code: `$(\"#contador\").html((0).format()),` .... no idea why it was in there but that was almost certainly causing the issue which now is no longer a problem in FF or Safari.\r\n\r\nThanks again I'll close the issue 👍",
"title": null,
"type": "comment"
}
] | 2 | 4 | 1,750 | false | false | 1,750 | true |
LuckSiege/PictureSelector | null | 398,508,268 | 738 | null | [
{
"action": "opened",
"author": "15120822558",
"comment_id": null,
"datetime": 1547257387000,
"masked_author": "username_0",
"text": "1、没有返回视频大小的方法？\r\n2、有没有好的视频压缩库推荐？",
"title": "视频问题",
"type": "issue"
},
{
"action": "created",
"author": "LuckSiege",
"comment_id": 552880253,
"datetime": 1573563099000,
"masked_author": "username_1",
"text": "视频大小新版本已返回，压缩的暂时没有",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "LuckSiege",
"comment_id": null,
"datetime": 1573563100000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 49 | false | false | 49 | false |
SeldonIO/seldon-core | SeldonIO | 410,037,059 | 448 | null | [
{
"action": "opened",
"author": "benoitbayol",
"comment_id": null,
"datetime": 1550097548000,
"masked_author": "username_0",
"text": "Hey,\r\n\r\nI am creating some images with:\r\n```\r\ns2i build . seldonio/seldon-core-s2i-python3:0.4 my.registry.com/my-image:version\r\ndocker push my.registry.com/my-image:version\r\n```\r\nIf I test this image locally with `docker run -p 5000:5000 my-image:version` I have no problem to call /predict with internal api in order to have a response with a json payload with \"strData\" and outputting a json in \"binData\" (I don't understand why it does come as a strData)\r\n\r\nThen I am creating a deployement in kubeflow with seldon and ksonnet with:\r\n```\r\nks registry add kubeflow github.com/kubeflow/kubeflow/tree/v0.4.1/kubeflow\r\nks pkg install kubeflow/seldon\r\nks generate seldon seldon\r\nks apply default -c seldon\r\nks generate seldon-serve-simple-v1alpha2 my-model --image my.registry.com/my-image:version\r\nks apply default -c my-model\r\n```\r\nEverything is fine until I call the my-model/api/v0.1/predictions external api.\r\n\r\nIn the log I have:\r\n```\r\n2019-02-13 21:58:17.655 INFO 5 --- [nio-8000-exec-3] i.s.e.service.InternalPredictionService : Requesting http://seldon-xxxxxxx:9000/predict\r\n2019-02-13 21:58:17.935 INFO 5 --- [nio-8000-exec-3] i.s.e.service.InternalPredictionService : {\"binData\":[[0.9999990463256836],[0.0002424759150017053]],\"meta\":{}}\r\n2019-02-13 21:58:17.938 ERROR 5 --- [nio-8000-exec-3] i.s.e.service.InternalPredictionService : Couldn't retrieve prediction from external prediction server - \r\n```\r\nFor the binData I have also tried by outputting a json but in any case the result of my /predict cannot be transfered to the external with some com.google.protobuf.InvalidProtocolBufferException problems (when outputting json.dumps() I have a problem on length)\r\n\r\nDo you have any idea ? I have looked all the examples and I cannot see the obvious reason why it is not working.\r\n\r\nThanks.",
"title": "cannot get working external api but internal api is ok",
"type": "issue"
},
{
"action": "created",
"author": "cliveseldon",
"comment_id": 463407839,
"datetime": 1550098190000,
"masked_author": "username_1",
"text": "Is there a full exception stack trace from the engine container?\r\nIs there any logs from your model container?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cliveseldon",
"comment_id": 463411871,
"datetime": 1550099045000,
"masked_author": "username_1",
"text": "The reason it comes back as `bindata` looks like a bug.\r\nhttps://github.com/SeldonIO/seldon-core/blob/da0a2fb99238eee62f3c454982456da2211c3953/python/seldon_core/model_microservice.py#L99-L100\r\nWe are rewriting the python wrapper so we can fix that as part of that work",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "benoitbayol",
"comment_id": 463524216,
"datetime": 1550129891000,
"masked_author": "username_0",
"text": "Is that what you are looking for ?\r\n```\r\ncom.google.protobuf.InvalidProtocolBufferException: null\r\n\tat com.google.protobuf.util.JsonFormat$ParserImpl.merge(JsonFormat.java:1084) ~[protobuf-java-util-3.2.0rc2.jar!/:na]\r\n\tat com.google.protobuf.util.JsonFormat$Parser.merge(JsonFormat.java:277) ~[protobuf-java-util-3.2.0rc2.jar!/:na]\r\n\tat io.seldon.engine.service.InternalPredictionService.queryREST(InternalPredictionService.java:354) [classes!/:0.2.3]\r\n\tat io.seldon.engine.service.InternalPredictionService.transformInput(InternalPredictionService.java:216) [classes!/:0.2.3]\r\n\tat io.seldon.engine.predictors.PredictiveUnitBean.transformInput(PredictiveUnitBean.java:178) [classes!/:0.2.3]\r\n\tat io.seldon.engine.predictors.PredictiveUnitBean.getOutputAsync(PredictiveUnitBean.java:76) [classes!/:0.2.3]\r\n\tat io.seldon.engine.predictors.PredictiveUnitBean.getOutput(PredictiveUnitBean.java:60) [classes!/:0.2.3]\r\n\tat io.seldon.engine.predictors.PredictiveUnitBean$$FastClassBySpringCGLIB$$ddb0d27b.invoke(<generated>) [classes!/:0.2.3]\r\n\tat org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204) [spring-core-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:652) [spring-aop-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat io.seldon.engine.predictors.PredictiveUnitBean$$EnhancerBySpringCGLIB$$1d5f6264.getOutput(<generated>) [classes!/:0.2.3]\r\n\tat io.seldon.engine.predictors.PredictorBean.predict(PredictorBean.java:54) [classes!/:0.2.3]\r\n\tat io.seldon.engine.service.PredictionService.predict(PredictionService.java:84) [classes!/:0.2.3]\r\n\tat io.seldon.engine.api.rest.RestClientController.predictions(RestClientController.java:120) [classes!/:0.2.3]\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_171]\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_171]\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_171]\r\n\tat java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_171]\r\n\tat org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:220) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:134) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:116) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:827) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:738) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:963) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:897) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:872) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat javax.servlet.http.HttpServlet.service(HttpServlet.java:648) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat javax.servlet.http.HttpServlet.service(HttpServlet.java:729) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:230) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) [tomcat-embed-websocket-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.boot.web.filter.ApplicationContextHeaderFilter.doFilterInternal(ApplicationContextHeaderFilter.java:55) [spring-boot-1.4.3.RELEASE.jar!/:1.4.3.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.boot.actuate.trace.WebRequestTraceFilter.doFilterInternal(WebRequestTraceFilter.java:105) [spring-boot-actuator-1.4.3.RELEASE.jar!/:1.4.3.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:99) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.web.filter.HttpPutFormContentFilter.doFilterInternal(HttpPutFormContentFilter.java:89) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.web.filter.HiddenHttpMethodFilter.doFilterInternal(HiddenHttpMethodFilter.java:77) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:197) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.boot.actuate.autoconfigure.MetricsFilter.doFilterInternal(MetricsFilter.java:106) [spring-boot-actuator-1.4.3.RELEASE.jar!/:1.4.3.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:108) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:349) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:784) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:802) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1410) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_171]\r\n\tat java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_171]\r\n\tat org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat java.lang.Thread.run(Thread.java:748) [na:1.8.0_171]\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cliveseldon",
"comment_id": 463527309,
"datetime": 1550130704000,
"masked_author": "username_1",
"text": "This looks like the JSON returned by your model can't be parsed into a SeldonMessage.\r\nDo you have the raw JSON returned by your model or an example that illustrates it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "benoitbayol",
"comment_id": 464726913,
"datetime": 1550495599000,
"masked_author": "username_0",
"text": "For example:\r\n```\r\n2019-02-15 14:56:05.054 INFO 5 --- [nio-8000-exec-1] i.s.e.service.InternalPredictionService : {\"binData\":[[0.9999990463256836],[0.0002424759150017053]],\"meta\":{}}\r\n\r\n2019-02-15 14:56:05.091 ERROR 5 --- [nio-8000-exec-1] i.s.e.service.InternalPredictionService : Couldn't retrieve prediction from external prediction server - \r\n\r\ncom.google.protobuf.InvalidProtocolBufferException: null\r\n\tat com.google.protobuf.util.JsonFormat$ParserImpl.merge(JsonFormat.java:1084) ~[protobuf-java-util-3.2.0rc2.jar!/:na]\r\n\tat com.google.protobuf.util.JsonFormat$Parser.merge(JsonFormat.java:277) ~[protobuf-java-util-3.2.0rc2.jar!/:na]\r\n\tat io.seldon.engine.service.InternalPredictionService.queryREST(InternalPredictionService.java:354) [classes!/:0.2.3]\r\n\tat io.seldon.engine.service.InternalPredictionService.transformInput(InternalPredictionService.java:216) [classes!/:0.2.3]\r\n\tat io.seldon.engine.predictors.PredictiveUnitBean.transformInput(PredictiveUnitBean.java:178) [classes!/:0.2.3]\r\n\tat io.seldon.engine.predictors.PredictiveUnitBean.getOutputAsync(PredictiveUnitBean.java:76) [classes!/:0.2.3]\r\n\tat io.seldon.engine.predictors.PredictiveUnitBean.getOutput(PredictiveUnitBean.java:60) [classes!/:0.2.3]\r\n\tat io.seldon.engine.predictors.PredictiveUnitBean$$FastClassBySpringCGLIB$$ddb0d27b.invoke(<generated>) [classes!/:0.2.3]\r\n\tat org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204) [spring-core-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:652) [spring-aop-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat io.seldon.engine.predictors.PredictiveUnitBean$$EnhancerBySpringCGLIB$$1d5f6264.getOutput(<generated>) [classes!/:0.2.3]\r\n\tat io.seldon.engine.predictors.PredictorBean.predict(PredictorBean.java:54) [classes!/:0.2.3]\r\n\tat io.seldon.engine.service.PredictionService.predict(PredictionService.java:84) [classes!/:0.2.3]\r\n\tat io.seldon.engine.api.rest.RestClientController.predictions(RestClientController.java:120) [classes!/:0.2.3]\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[na:1.8.0_171]\r\n\tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[na:1.8.0_171]\r\n\tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[na:1.8.0_171]\r\n\tat java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_171]\r\n\tat org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:220) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:134) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:116) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:827) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:738) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:963) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:897) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:970) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:872) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat javax.servlet.http.HttpServlet.service(HttpServlet.java:648) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:846) [spring-webmvc-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat javax.servlet.http.HttpServlet.service(HttpServlet.java:729) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:230) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) [tomcat-embed-websocket-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.boot.web.filter.ApplicationContextHeaderFilter.doFilterInternal(ApplicationContextHeaderFilter.java:55) [spring-boot-1.4.3.RELEASE.jar!/:1.4.3.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.boot.actuate.trace.WebRequestTraceFilter.doFilterInternal(WebRequestTraceFilter.java:105) [spring-boot-actuator-1.4.3.RELEASE.jar!/:1.4.3.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:99) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.web.filter.HttpPutFormContentFilter.doFilterInternal(HttpPutFormContentFilter.java:89) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.web.filter.HiddenHttpMethodFilter.doFilterInternal(HiddenHttpMethodFilter.java:77) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:197) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.springframework.boot.actuate.autoconfigure.MetricsFilter.doFilterInternal(MetricsFilter.java:106) [spring-boot-actuator-1.4.3.RELEASE.jar!/:1.4.3.RELEASE]\r\n\tat org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107) [spring-web-4.3.5.RELEASE.jar!/:4.3.5.RELEASE]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:192) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:165) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:108) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:349) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:784) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:802) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1410) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) [na:1.8.0_171]\r\n\tat java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) [na:1.8.0_171]\r\n\tat org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-embed-core-8.5.6.jar!/:8.5.6]\r\n\tat java.lang.Thread.run(Thread.java:748) [na:1.8.0_171]\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cliveseldon",
"comment_id": 464732374,
"datetime": 1550496705000,
"masked_author": "username_1",
"text": "The `binData` field should be base 64 encoded for decoding the JSON to not fail. How are you creating the `binData` field?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "benoitbayol",
"comment_id": 464732970,
"datetime": 1550496818000,
"masked_author": "username_0",
"text": "I am not. I think it is created by the python code you have showed me upper\nbecause there is not binData on my side.\n\n\n\n-- \n*Benoît BAYOL*\nSenior Lead Software Engineer\n\n\nStation F - 55 Boulevard Vincent Auriol - 75013 Paris",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cliveseldon",
"comment_id": 464796460,
"datetime": 1550506834000,
"masked_author": "username_1",
"text": "Can you clarify what your input payload is? Is it using `strData`?\r\nI think there are two options:\r\n * You could base64 encode the data before returning it and that should work\r\n * You could use the undocumented `predict_rest` endpoint which gives you access to the raw input. This assumes you are using 0.2.5 version. For `predict_rest` you need to return a valid `SeldonMessage` JSON as return.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "cliveseldon",
"comment_id": null,
"datetime": 1554389931000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "cliveseldon",
"comment_id": 479933259,
"datetime": 1554389931000,
"masked_author": "username_1",
"text": "Closing a solutions exist in latest python code or fix via base64. Please reopen if not appropriate.",
"title": null,
"type": "comment"
}
] | 2 | 11 | 24,947 | false | false | 24,947 | false |
IIIF-TEI-Exploratory-Group/InteroperabilityFixtures | IIIF-TEI-Exploratory-Group | 254,875,823 | 2 | null | [
{
"action": "opened",
"author": "benwbrum",
"comment_id": null,
"datetime": 1504446641000,
"masked_author": "username_0",
"text": "Any communication of IIIF image information via TEI should be non-breaking, so that applications that are not aware of IIIF are still able to display images.\r\n\r\nThe valid values of the `facs` attribute are specified as `teidata.pointer`, defined as a valid URI: \"The range of syntactically valid values is defined by RFC 3986 Uniform Resource Identifier (URI): Generic Syntax. Note that the values themselves are encoded using RFC 3987 Internationalized Resource Identifiers (IRIs) mapping to URIs.\"",
"title": "Non-IIIF TEI viewer displays IIIF-enabled TEI files",
"type": "issue"
}
] | 1 | 1 | 499 | false | false | 499 | false |
confluentinc/confluent-kafka-dotnet | confluentinc | 356,242,707 | 618 | {
"number": 618,
"repo": "confluent-kafka-dotnet",
"user_login": "confluentinc"
} | [
{
"action": "opened",
"author": "mhowlett",
"comment_id": null,
"datetime": 1535848681000,
"masked_author": "username_0",
"text": "this PR takes a look at what happens if `ISerializer/IDeserializer` are replaced by delegates. \r\n\r\nNotes:\r\n- we can't express the delegates as a `Func`.. since `ReadOnlySpan<T>` can't be a generic parameter.\r\n- the serializers are very specific for use with the kafka clients (regardless of their form) - they need a topic parameter and the serializer is likely going to have a `IMemoryOwner<byte>` parameter, which is a general concept but that's pretty advanced, limiting general usefulness.\r\n- there is structural benefit from re-organizing things so that serdes are not `IDisposable`s - the API is easier to 'get' - the user doesn't need to wonder about transfer of ownership.\r\n- coupling is reduced substantially if the current configuration mechanism is removed. the way things work would be more straightforward (to the user). the disadvantage is that the way things work now does add value - it allows a single config dictionary to work for every thing AND provide fail fast functionality if something is wrong. However, the same functionality can be achieved with a few `.Select` statements prior to passing a config dictionary to the various bits.\r\n- There is perf. advantage to having the consumer run the deserializer as part of the consume call (can be done before librdkafka memory is freed). for this reason, it wouldn't be good to decouple deserializer and consumer completely.\r\n- On the producer, avro serializers need to be topic aware. having the serialization performed by the producer means the topic doesn't need to be specified multiple times. a reason not to decouple serializer/producer completely.\r\n- I've added UTF8 (string) and `byte[]` to the (de)serializer types that don't need to be explicitly specified. it could be argued that having strings implicitly default to UTF8 is not a good feature. i could remove this, but I think i'm in favor of it. I don't like the look of `Serializers.UTF8` on initialization, and i don't think defaulting to UTF8 will cause problems.",
"title": "ISerializer/IDeserializer -> delegates [WIP]",
"type": "issue"
},
{
"action": "created",
"author": "mhowlett",
"comment_id": 417899952,
"datetime": 1535854513000,
"masked_author": "username_0",
"text": "more notes:\r\n\r\n- I played with removing `topic` from the (de)serializer delegates, since the only place this is used is in the avro serializer and the pull of simplicity is strong - perhaps it's better with going with simplicity, and anything that needs more can build on top of the basics. However, any API I came up with was worse, in my view, from a users perspective, and central registration of schemas is an important architectural pattern we believe many people should use, so we want this usage to be straightforward.\r\n\r\n- something else we could do is go the other way and give everything passed into the produce method to the serializer. @vchekan suggests header values would be useful.\r\n\r\n- An advantage of typed producers/consumers is type safety.\r\n\r\n- Another advantage of typed producers/consumers is terseness. Although straightforward to serialize / deserialize to/from bytes, in practice I find this is more characters of typing.\r\n\r\n- The basic auth PR I have open follows other clients and uses `SASL_INHERIT` as a potential source. Implicitly, this assumes a single config is used for everything. This PR breaks that way of thinking.",
"title": null,
"type": "comment"
}
] | 1 | 2 | 3,151 | false | false | 3,151 | false |
chrismaltby/gb-studio | null | 436,951,669 | 55 | null | [
{
"action": "opened",
"author": "KrazyProductionz",
"comment_id": null,
"datetime": 1556149478000,
"masked_author": "username_0",
"text": "A menu would be nice to put in for RPG's. Other RPG elements can be added such as a healthbar and a combat system like Legend of Zelda and Pokémon. Another thing that can be added is warp to a scene and warp back to the previous scene and go back to where you were. Thanks.",
"title": "[Request]Menu and others",
"type": "issue"
},
{
"action": "created",
"author": "DerekLF",
"comment_id": 486568559,
"datetime": 1556180461000,
"masked_author": "username_1",
"text": "The warping back and forth can just be done with the 'Switch scene' command. It's the easiest way I think.\r\nThe pokemon combat system has been discussed in #41. Something like zelda's combat system and more in #33. and a proper in-game menu in my post #24.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JanusTesla",
"comment_id": 487318491,
"datetime": 1556398093000,
"masked_author": "username_2",
"text": "I'd like to be able to use a variable to determine where 'switch scene' warped to- I think right now a specific scene has to be chosen in advance which makes switching to a menu map and then back to where you were standing difficult",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Igerow",
"comment_id": 488670160,
"datetime": 1556803262000,
"masked_author": "username_3",
"text": "You could create a \"room number\" variable, changing in every room. When you leave the menu, just check \"room number\" to switch to the correct room. The only problem are the players coordinates. If there would be a way to check x and y for the player, a menu would be no longer a problem.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "thomas-alrek",
"comment_id": 488697213,
"datetime": 1556807589000,
"masked_author": "username_4",
"text": "@username_3 A method for checking an Actors position is already merged into the `develop` branch",
"title": null,
"type": "comment"
}
] | 5 | 5 | 1,140 | false | false | 1,140 | true |
rossfuhrman/_why_the_lucky_markov | null | 360,171,079 | 613 | null | [
{
"action": "opened",
"author": "roadtojoy",
"comment_id": null,
"datetime": 1536906026000,
"masked_author": "username_0",
"text": "Toot: So this random boar lost his whole family in a text file. No less than eight and no more. \n One comment = 1 upvote. Sometime after this gets 2 upvotes, it will be posted to the main account at https://mastodon.xyz/@_why_toots",
"title": "So this random boar lost his whole family in a text file. No less than eight and no more.",
"type": "issue"
}
] | 1 | 1 | 231 | false | false | 231 | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.