repo stringlengths 7 67 | org stringlengths 2 32 ⌀ | issue_id int64 780k 941M | issue_number int64 1 134k | pull_request dict | events list | user_count int64 1 77 | event_count int64 1 192 | text_size int64 0 329k | bot_issue bool 1 class | modified_by_bot bool 2 classes | text_size_no_bots int64 0 279k | modified_usernames bool 2 classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
github/explore | github | 265,056,072 | 39 | {
"number": 39,
"repo": "explore",
"user_login": "github"
} | [
{
"action": "opened",
"author": "cheshire137",
"comment_id": null,
"datetime": 1507836066000,
"masked_author": "username_0",
"text": "- [x] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md\r\n\r\nI am:\r\n - [ ] Suggesting edits to an existing Topic page\r\n - [x] Curating a new Topic page\r\n\r\n- [x] I've formatted my changes as a new folder directory, named for the topic as it appears in the URL on GitHub (e.g. `https://github.com/topics/[NAME]`)\r\n- [x] My folder contains a `*.png` image (if applicable) and `index.md`\r\n- [x] All required fields in my `index.md` conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs\r\n\r\nPlease explain why you think this Topic page should be curated:\r\n\r\nhttps://github.com/topics/github-api has 644 repositories currently, and I think it will continue to grow. We can show helpful information, like a link to the API docs, in the sidebar if we curate this topic.",
"title": "Add github-api topic",
"type": "issue"
},
{
"action": "created",
"author": "cheshire137",
"comment_id": 336239490,
"datetime": 1507836107000,
"masked_author": "username_0",
"text": "/cc @username_1 for input on the description",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kdaigle",
"comment_id": 336494858,
"datetime": 1507910475000,
"masked_author": "username_1",
"text": "My schedule won't allow me to look at this today. @bswinnerton can you review this?",
"title": null,
"type": "comment"
}
] | 2 | 3 | 974 | false | false | 974 | true |
ocaml/opam-repository | ocaml | 160,960,267 | 6,794 | {
"number": 6794,
"repo": "opam-repository",
"user_login": "ocaml"
} | [
{
"action": "opened",
"author": "dbuenzli",
"comment_id": null,
"datetime": 1466192253000,
"masked_author": "username_0",
"text": "The transitory OCaml software packager\n\nTopkg is a packager for distributing OCaml software. It provides an\nAPI to describe the files a package installs in a given build\nconfiguration and to specify information about the package's\ndistribution creation and publication procedures.\n\nThe optional topkg-care package provides the `topkg` command line tool\nwhich helps with various aspects of a package's life cycle: creating\nand linting a distribution, releasing it on the WWW, publish its\ndocumentation, add it to the OCaml OPAM repository, etc.\n\nTopkg is distributed under the ISC license and has **no**\ndependencies. This is what your packages will need as a *build*\ndependency.\n\nTopkg-care is distributed under the ISC license it depends on\n[fmt][fmt], [logs][logs], [bos][bos], [cmdliner][cmdliner] and\n`opam-lib`.\n\n[fmt]: http://erratique.ch/software/fmt\n[logs]: http://erratique.ch/software/logs\n[bos]: http://erratique.ch/software/bos\n[cmdliner]: http://erratique.ch/software/cmdliner\n\n\n---\n* Homepage: http://erratique.ch/software/topkg\n* Source repo: http://erratique.ch/repos/topkg.git\n* Bug tracker: https://github.com/username_0/topkg/issues\n\n---\n\n\n---\nv0.7.4 2016-06-17 Cambridge (UK)\n--------------------------------\n\n- Add test description and run support. New `topkg test` command.\n- Add distribution publication description support. Allows to define the\n set of default publication artefacts in the package description. The cli\n syntax of `topkg publish` for alternative artefacts changes from\n `alt KIND` to `alt-KIND`.\n- Distributed (and thus installed) OPAM files are now properly\n versioned via the `version:` field.\n- Improve tarball reproducibility across systems by not relying on the\n VCS checkout state for determining the read and write rights (#43).\n- OPAM package submission: use the `opam-publish` submit message\n to append the release notes to the submission.\n- Toy GitHub delegate: improve user authentication by trying to steal\n an existing opam-publish token.\n- Toy GitHub delegate: improve package documentation publication. Thanks\n to Thomas Gazagnaire for the patches.\n- Error message and IPC logging level propagation improvements. Thanks to\n Thomas Gazagnaire for the help.\nPull-request generated by opam-publish v0.3.2",
"title": "topkg.0.7.4 - via opam-publish",
"type": "issue"
},
{
"action": "created",
"author": "camelus",
"comment_id": 226863348,
"datetime": 1466192409000,
"masked_author": "username_1",
"text": "##### :white_check_mark: All lint checks passed <small>711c19ff0f6297c0e4af0f85730d7af6fae931ab</small>\n\n* These packages passed lint tests: `topkg.0.7.4`\n\n\n---\n\n\n##### :white_check_mark: Installability check (5164 → 5165)\n\n* new installable packages (1): `topkg.0.7.4`",
"title": null,
"type": "comment"
}
] | 2 | 2 | 2,537 | false | false | 2,537 | true |
Netflix/conductor | Netflix | 325,443,753 | 549 | {
"number": 549,
"repo": "conductor",
"user_login": "Netflix"
} | [
{
"action": "opened",
"author": "pctreddy",
"comment_id": null,
"datetime": 1527019606000,
"masked_author": "username_0",
"text": "",
"title": "Ability to disable workflows based on workflow definition configuration",
"type": "issue"
},
{
"action": "created",
"author": "cyzhao",
"comment_id": 398273443,
"datetime": 1529383871000,
"masked_author": "username_1",
"text": "@username_0 can you resolve the conflict so that can be merged?",
"title": null,
"type": "comment"
}
] | 2 | 2 | 61 | false | false | 61 | true |
projectfluent/fluent-locale-rs | projectfluent | 349,211,704 | 6 | null | [
{
"action": "opened",
"author": "zbraniecki",
"comment_id": null,
"datetime": 1533834040000,
"masked_author": "username_0",
"text": "Our current strategy uses empty field to match wildcard, which results in empty locales matching all other locales.\r\n\r\nThat means that unless specifically blocked (which we did in 0.4.1) `x-testing` matches everything.",
"title": "Empty locale (or `x-testing`) should not match everything",
"type": "issue"
},
{
"action": "closed",
"author": "zbraniecki",
"comment_id": null,
"datetime": 1564530988000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "zbraniecki",
"comment_id": 516639503,
"datetime": 1564530988000,
"masked_author": "username_0",
"text": "Empty locale doesn't match anything anymore!",
"title": null,
"type": "comment"
}
] | 1 | 3 | 262 | false | false | 262 | false |
jlippold/tweakCompatible | null | 350,679,882 | 43,768 | null | [
{
"action": "opened",
"author": "Perenrox",
"comment_id": null,
"datetime": 1534306396000,
"masked_author": "username_0",
"text": "```\r\n{\r\n \"packageId\": \"com.unlimapps.fbpp\",\r\n \"action\": \"notworking\",\r\n \"userInfo\": {\r\n \"arch32\": false,\r\n \"packageId\": \"com.unlimapps.fbpp\",\r\n \"deviceId\": \"iPhone8,2\",\r\n \"url\": \"http://cydia.saurik.com/package/com.unlimapps.fbpp/\",\r\n \"iOSVersion\": \"11.0.3\",\r\n \"packageVersionIndexed\": true,\r\n \"packageName\": \"Facebook ++\",\r\n \"category\": \"Tweaks\",\r\n \"repository\": \"beta.unlimapps.com\",\r\n \"name\": \"Facebook ++\",\r\n \"installed\": \"1.6r-38\",\r\n \"packageIndexed\": true,\r\n \"packageStatusExplaination\": \"A matching version of this tweak for this iOS version could not be found. Please submit a review if you choose to install.\",\r\n \"id\": \"com.unlimapps.fbpp\",\r\n \"commercial\": false,\r\n \"packageInstalled\": true,\r\n \"tweakCompatVersion\": \"0.1.0\",\r\n \"shortDescription\": \"The Facebook tweak that allows you to turn off read recipts, use the in-app messenger, save/download videos and much more!\",\r\n \"latest\": \"1.6r-38\",\r\n \"author\": \"UnlimApps Inc\",\r\n \"packageStatus\": \"Unknown\"\r\n },\r\n \"base64\": \"eyJhcmNoMzIiOmZhbHNlLCJwYWNrYWdlSWQiOiJjb20udW5saW1hcHBzLmZicHAiLCJkZXZpY2VJZCI6ImlQaG9uZTgsMiIsInVybCI6Imh0dHA6XC9cL2N5ZGlhLnNhdXJpay5jb21cL3BhY2thZ2VcL2NvbS51bmxpbWFwcHMuZmJwcFwvIiwiaU9TVmVyc2lvbiI6IjExLjAuMyIsInBhY2thZ2VWZXJzaW9uSW5kZXhlZCI6dHJ1ZSwicGFja2FnZU5hbWUiOiJGYWNlYm9vayArKyIsImNhdGVnb3J5IjoiVHdlYWtzIiwicmVwb3NpdG9yeSI6ImJldGEudW5saW1hcHBzLmNvbSIsIm5hbWUiOiJGYWNlYm9vayArKyIsImluc3RhbGxlZCI6IjEuNnItMzgiLCJwYWNrYWdlSW5kZXhlZCI6dHJ1ZSwicGFja2FnZVN0YXR1c0V4cGxhaW5hdGlvbiI6IkEgbWF0Y2hpbmcgdmVyc2lvbiBvZiB0aGlzIHR3ZWFrIGZvciB0aGlzIGlPUyB2ZXJzaW9uIGNvdWxkIG5vdCBiZSBmb3VuZC4gUGxlYXNlIHN1Ym1pdCBhIHJldmlldyBpZiB5b3UgY2hvb3NlIHRvIGluc3RhbGwuIiwiaWQiOiJjb20udW5saW1hcHBzLmZicHAiLCJjb21tZXJjaWFsIjpmYWxzZSwicGFja2FnZUluc3RhbGxlZCI6dHJ1ZSwidHdlYWtDb21wYXRWZXJzaW9uIjoiMC4xLjAiLCJzaG9ydERlc2NyaXB0aW9uIjoiVGhlIEZhY2Vib29rIHR3ZWFrIHRoYXQgYWxsb3dzIHlvdSB0byB0dXJuIG9mZiByZWFkIHJlY2lwdHMsIHVzZSB0aGUgaW4tYXBwIG1lc3Nlbmdlciwgc2F2ZVwvZG93bmxvYWQgdmlkZW9zIGFuZCBtdWNoIG1vcmUhIiwibGF0ZXN0IjoiMS42ci0zOCIsImF1dGhvciI6IlVubGltQXBwcyBJbmMiLCJwYWNrYWdlU3RhdHVzIjoiVW5rbm93biJ9\",\r\n \"chosenStatus\": \"not working\",\r\n \"notes\": \"None of the features are there except ads lmao. Needs to be updated for latest version of Snapchat. \"\r\n}\r\n```",
"title": "`Facebook ++` not working on iOS 11.0.3",
"type": "issue"
}
] | 2 | 3 | 2,518 | false | true | 2,276 | false |
openshift/origin | openshift | 178,550,321 | 11,049 | {
"number": 11049,
"repo": "origin",
"user_login": "openshift"
} | [
{
"action": "opened",
"author": "chrira",
"comment_id": null,
"datetime": 1474532921000,
"masked_author": "username_0",
"text": "Added wildfly 10.1 spec pointing to wildfly-101-centos7.\r\nUpdated wildfly:latest to 10.1 image stream.",
"title": "add wildfly 10.1 spec",
"type": "issue"
},
{
"action": "created",
"author": "bparees",
"comment_id": 248883246,
"datetime": 1474545588000,
"masked_author": "username_1",
"text": "you'll need to run \"hack/update-generated-bootstrap-bindata.sh\" because we embed this imagestream in go code as well for oc cluster up.\r\n\r\nif you don't have a full dev environment available to do that, let me know and i can just redo this pull.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrira",
"comment_id": 248898376,
"datetime": 1474549674000,
"masked_author": "username_0",
"text": "pkg/bootstrap/bindata.go is now updated such that the tests pass again",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bparees",
"comment_id": 248899436,
"datetime": 1474549953000,
"masked_author": "username_1",
"text": "excellent, please squash your commits and i'll merge.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrira",
"comment_id": 248903825,
"datetime": 1474551055000,
"masked_author": "username_0",
"text": "the squashing is done",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bparees",
"comment_id": 248908991,
"datetime": 1474552244000,
"masked_author": "username_1",
"text": "[merge]",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chrira",
"comment_id": 249139977,
"datetime": 1474621282000,
"masked_author": "username_0",
"text": "test/cmd/debug.sh updated to expect wildfly-101-centos7 as latest wildfly image",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bparees",
"comment_id": 249433726,
"datetime": 1474823727000,
"masked_author": "username_1",
"text": "[merge]",
"title": null,
"type": "comment"
}
] | 3 | 28 | 2,392 | false | true | 583 | false |
yandexdataschool/Practical_RL | yandexdataschool | 406,017,660 | 112 | {
"number": 112,
"repo": "Practical_RL",
"user_login": "yandexdataschool"
} | [
{
"action": "opened",
"author": "Pastafarianist",
"comment_id": null,
"datetime": 1549138097000,
"masked_author": "username_0",
"text": "* replace `weighted_choice` in `mdp.py` with `np.random.choice` (correct me if I'm wrong, but they seem identical)\r\n* autoformatting",
"title": "Style fixes for week 2",
"type": "issue"
},
{
"action": "created",
"author": "justheuristic",
"comment_id": 459997499,
"datetime": 1549140040000,
"masked_author": "username_1",
"text": "ты прав, они одинаковы. weighted choice пришёл из того потока cs188x, когда нампая ещё не было",
"title": null,
"type": "comment"
}
] | 2 | 2 | 226 | false | false | 226 | false |
jlippold/tweakCompatible | null | 482,120,485 | 94,614 | null | [
{
"action": "opened",
"author": "tom0034",
"comment_id": null,
"datetime": 1566194502000,
"masked_author": "username_0",
"text": "```\r\n{\r\n \"packageId\": \"com.pixelomer.thesmallerthebetter\",\r\n \"action\": \"working\",\r\n \"userInfo\": {\r\n \"arch32\": false,\r\n \"packageId\": \"com.pixelomer.thesmallerthebetter\",\r\n \"deviceId\": \"iPhone8,2\",\r\n \"url\": \"http://cydia.saurik.com/package/com.pixelomer.thesmallerthebetter/\",\r\n \"iOSVersion\": \"12.4\",\r\n \"packageVersionIndexed\": true,\r\n \"packageName\": \"TheSmallerTheBetter\",\r\n \"category\": \"Tweaks\",\r\n \"repository\": \"PixelOmer's Repo\",\r\n \"name\": \"TheSmallerTheBetter\",\r\n \"installed\": \"1.0.1-1\",\r\n \"packageIndexed\": true,\r\n \"packageStatusExplaination\": \"A matching version of this tweak for this iOS version could not be found. Please submit a review if you choose to install.\",\r\n \"id\": \"com.pixelomer.thesmallerthebetter\",\r\n \"commercial\": false,\r\n \"packageInstalled\": true,\r\n \"tweakCompatVersion\": \"0.1.5\",\r\n \"shortDescription\": \"Disable large titles in apps\",\r\n \"latest\": \"1.0.1-1\",\r\n \"author\": \"PixelOmer\",\r\n \"packageStatus\": \"Unknown\"\r\n },\r\n \"base64\": \"eyJhcmNoMzIiOmZhbHNlLCJwYWNrYWdlSWQiOiJjb20ucGl4ZWxvbWVyLnRoZXNtYWxsZXJ0aGViZXR0ZXIiLCJkZXZpY2VJZCI6ImlQaG9uZTgsMiIsInVybCI6Imh0dHA6XC9cL2N5ZGlhLnNhdXJpay5jb21cL3BhY2thZ2VcL2NvbS5waXhlbG9tZXIudGhlc21hbGxlcnRoZWJldHRlclwvIiwiaU9TVmVyc2lvbiI6IjEyLjQiLCJwYWNrYWdlVmVyc2lvbkluZGV4ZWQiOnRydWUsInBhY2thZ2VOYW1lIjoiVGhlU21hbGxlclRoZUJldHRlciIsImNhdGVnb3J5IjoiVHdlYWtzIiwicmVwb3NpdG9yeSI6IlBpeGVsT21lcidzIFJlcG8iLCJuYW1lIjoiVGhlU21hbGxlclRoZUJldHRlciIsImluc3RhbGxlZCI6IjEuMC4xLTEiLCJwYWNrYWdlSW5kZXhlZCI6dHJ1ZSwicGFja2FnZVN0YXR1c0V4cGxhaW5hdGlvbiI6IkEgbWF0Y2hpbmcgdmVyc2lvbiBvZiB0aGlzIHR3ZWFrIGZvciB0aGlzIGlPUyB2ZXJzaW9uIGNvdWxkIG5vdCBiZSBmb3VuZC4gUGxlYXNlIHN1Ym1pdCBhIHJldmlldyBpZiB5b3UgY2hvb3NlIHRvIGluc3RhbGwuIiwiaWQiOiJjb20ucGl4ZWxvbWVyLnRoZXNtYWxsZXJ0aGViZXR0ZXIiLCJjb21tZXJjaWFsIjpmYWxzZSwicGFja2FnZUluc3RhbGxlZCI6dHJ1ZSwidHdlYWtDb21wYXRWZXJzaW9uIjoiMC4xLjUiLCJzaG9ydERlc2NyaXB0aW9uIjoiRGlzYWJsZSBsYXJnZSB0aXRsZXMgaW4gYXBwcyIsImxhdGVzdCI6IjEuMC4xLTEiLCJhdXRob3IiOiJQaXhlbE9tZXIiLCJwYWNrYWdlU3RhdHVzIjoiVW5rbm93biJ9\",\r\n \"chosenStatus\": \"working\",\r\n \"notes\": \"\"\r\n}\r\n```",
"title": "`TheSmallerTheBetter` working on iOS 12.4",
"type": "issue"
},
{
"action": "closed",
"author": "jlippold",
"comment_id": null,
"datetime": 1566220235000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 3 | 2,329 | false | true | 2,087 | false |
mapbox/mapbox-gl-js | mapbox | 471,112,070 | 8,527 | null | [
{
"action": "opened",
"author": "tristen",
"comment_id": null,
"datetime": 1563803952000,
"masked_author": "username_0",
"text": "If `text-allow-overlap` is set to `true` I would still expect variable label placement to work on finding the optimal display. Instead, it appears clustered like this:\r\n\r\n\r\n\r\nHere's what my layer looks like:\r\n\r\n```js\r\n{\r\n id: 'foo',\r\n type: 'symbol',\r\n source: 'composite',\r\n 'source-layer': 'housenum_label',\r\n layout: {\r\n 'text-field': 'I am a label',\r\n 'text-size': 12.5,\r\n 'text-allow-overlap': true,\r\n 'text-variable-anchor': [\r\n 'center',\r\n 'left',\r\n 'right',\r\n 'top',\r\n 'bottom',\r\n 'top-left',\r\n 'top-right',\r\n 'bottom-left',\r\n 'bottom-right'\r\n ],\r\n 'text-justify': 'auto'\r\n }\r\n}\r\n```\r\n\r\n---\r\n\r\nMapbox GL JS Version: **v1.1.1**\r\nAnd a link to the demo: https://jsfiddle.net/username_0/tpaygf4w/",
"title": "Don't disable variable label placement if text-allow-overlap is set to true",
"type": "issue"
},
{
"action": "created",
"author": "ansis",
"comment_id": 515223039,
"datetime": 1564090437000,
"masked_author": "username_1",
"text": "Are you expecting it to try different positions looking for one without collisions and only allow a collision if there is no position without a collision?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tristen",
"comment_id": 515439800,
"datetime": 1564145794000,
"masked_author": "username_0",
"text": "@username_1 right. Even if `*-allow-overlap` is true I would expect variable label placement to still try and find an optimized position before concluding there will be overlap.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chloekraw",
"comment_id": 518370327,
"datetime": 1565033883000,
"masked_author": "username_2",
"text": "cc: @username_3 @alexshalamov",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pozdnyakov",
"comment_id": 520378057,
"datetime": 1565607038000,
"masked_author": "username_3",
"text": "Implementation for gl-native https://github.com/mapbox/mapbox-gl-native/pull/15354",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "pozdnyakov",
"comment_id": null,
"datetime": 1565632856000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "tristen",
"comment_id": 520531418,
"datetime": 1565632951000,
"masked_author": "username_0",
"text": "Whoa! Amazing @username_3. Should this be left open for the GL JS portion of the work?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pozdnyakov",
"comment_id": 520532363,
"datetime": 1565633091000,
"masked_author": "username_3",
"text": "Is it fine, if I make a separate issue in GL Native to track mapbox/mapbox-gl-native#15354",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chloekraw",
"comment_id": 520532568,
"datetime": 1565633124000,
"masked_author": "username_2",
"text": "@username_0 https://github.com/mapbox/mapbox-gl-js/pull/8620 is in gl-js!",
"title": null,
"type": "comment"
}
] | 4 | 9 | 1,570 | false | false | 1,570 | true |
ibm-capi/capi-utils | ibm-capi | 315,060,563 | 32 | null | [
{
"action": "opened",
"author": "ibm-genwqe",
"comment_id": null,
"datetime": 1523971785000,
"masked_author": "username_0",
"text": "I did modify the code for N250SP. \r\nThe code was restructured adding function so that the macros can be removed.\r\nSee Pull request\r\nI also was working on one more patch to avoid a scenario where more than one card is installed (e.g. Card 0 and 1) and card 0 was somehow removed after card reset. This did follow in a error since you do check a devive (/sys/class/cxl/card0/...) which is not there anymore. \r\n\r\nThe patch i added but its not in the pull request was:\r\ndiff --git a/capi-flash-script.sh b/capi-flash-script.sh\r\nindex 489cbda..2deabe3 100755\r\n--- a/capi-flash-script.sh\r\n+++ b/capi-flash-script.sh\r\n@@ -137,7 +137,18 @@ printf \"${bold}%-7s %-30s %-29s %-20s %s${normal}\\n\" \"#\" \"Card\" \"Flashed\" \"by\" \"\r\n # print card information and flash history\r\n i=0;\r\n while read d; do\r\n- p[$i]=$(cat /sys/class/cxl/card$i/device/subsystem_device)\r\n+ # Go to list of Cards if Card is not given\r\n+ if (($card == -1)); then\r\n+ p[$i]=$(cat /sys/class/cxl/card$i/device/subsystem_device)\r\n+ else\r\n+ # Check only if given card is the index, skip all others\r\n+ if (($card == $i)); then\r\n+ p[$i]=$(cat /sys/class/cxl/card$i/device/subsystem_device)\r\n+ else\r\n+ printf \"Search Card %s Skip %s Device: %s\" \"${card}\" \"${i}\", \"${d}\"\r\n+ continue\r\n+ fi\r\n+ fi\r\n # check for legacy device\r\n if [[ ${p[$i]:0:6} == \"0x04af\" ]]; then\r\n p[$i]=$(cat /sys/class/cxl/card$i/psl_revision | xargs printf \"0x%.4X\")",
"title": "Pull Request",
"type": "issue"
}
] | 1 | 1 | 1,430 | false | false | 1,430 | false |
apache/incubator-dubbo | apache | 315,338,279 | 1,624 | null | [
{
"action": "opened",
"author": "YoungHu",
"comment_id": null,
"datetime": 1524030135000,
"masked_author": "username_0",
"text": "when using dubbo in production env, we found that in specific scenes(register same interface with multiplay group or version) service register will cause zookeeper output huge data for a long time. the reason is when service export, it will notice all consumers who described the interface but **NOT interface&group or version**. the root reason is dubbo store all of the services or consumers under interfacde node and not split them with group or version. now we forked dubbo source code then did the split operation, want to know if official have any good idea. \r\n\r\nBTW, I did a test and record it in my [CSDN Blog](https://blog.csdn.net/huyong1990/article/details/79988177)",
"title": "[Design bug] unreasonable design for register dubbo service",
"type": "issue"
},
{
"action": "created",
"author": "EdwardLee03",
"comment_id": 387252391,
"datetime": 1525741392000,
"masked_author": "username_1",
"text": "Good! 👍 \r\n@username_0 你们的解决方案：“修复的方法就是注册和查找服务的时候，有分组的加上一个分组zk节点，这样就能准确找到具体的服务而不是找这个接口下面所有服务。” 如果使用场景改变一下，服务版本有60个，你们的方案是否合理呢。同时，ZK数据结构至少增加一层分组zk节点层，应该需要调整`RegistryDirectory`和`ZookeeperRegistry`实现。\r\n\r\nMaybe use the service key (`[group/]interface[:version]`) of service layer of ZooKeeper, not use service instead. So simple adjust the `ZookeeperRegistry.toServicePath(URL)` implementation. @username_4",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "YoungHu",
"comment_id": 389040288,
"datetime": 1526359053000,
"masked_author": "username_0",
"text": "@username_1 Yeah, our solution is to change the ZookeeperRegistry.toServicePath(URL) implementation, for our company use `group` more frequent than `version`, so our zk path like this(`interface:group`). for community version, I have two suggestion. the first, change the zk path to `interface:group:version`; the second, don't change zk path, just filter the zk item under `interface` path",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "YoungHu",
"comment_id": 389413272,
"datetime": 1526453345000,
"masked_author": "username_0",
"text": "But that is not a fully solution, I just resolved the group problem not the version. In my onion, we should a discussion, because this change will affect dubbo service registry and discovery directly.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tswstarplanet",
"comment_id": 452772860,
"datetime": 1547053576000,
"masked_author": "username_2",
"text": "Have this bug been fixed ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "beiwei30",
"comment_id": 464663612,
"datetime": 1550483607000,
"masked_author": "username_3",
"text": "I believe we should visit this issue as early as possible.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chickenlj",
"comment_id": 469129992,
"datetime": 1551679551000,
"masked_author": "username_4",
"text": "I personally don't agree with isolating services with different groups or versions in service discovery level. Currently, Dubbo consumers can only interact with those providers with identically the same group and version, but we may change this behavior soon. For example, let consumer consume providers with version v1 and v2 at the same time, to enable canary deployment or A/B test.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "beiwei30",
"comment_id": 469610818,
"datetime": 1551778863000,
"masked_author": "username_3",
"text": "should we postpone this issue?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "chickenlj",
"comment_id": null,
"datetime": 1573028351000,
"masked_author": "username_4",
"text": "",
"title": null,
"type": "issue"
}
] | 5 | 9 | 2,167 | false | false | 2,167 | true |
billylam/newman-reporter-testrail | null | 475,208,057 | 6 | null | [
{
"action": "opened",
"author": "dobryakov",
"comment_id": null,
"datetime": 1564586424000,
"masked_author": "username_0",
"text": "Testrail Api Key doesn't work. Using password instead of key (e.g. TESTRAIL_APIKEY=your_password) works.",
"title": "Testrail Api Key doesn't work",
"type": "issue"
},
{
"action": "created",
"author": "billylam",
"comment_id": 516943290,
"datetime": 1564593877000,
"masked_author": "username_1",
"text": "It seems to work for me. Was it a newly generated key? TestRail's API key generation is a little weird in that you have to first add the key then also save the page, or the key won't be added to your account. If you don't save the page as well the key won't be saved even if it was generated.\r\n\r\nLet me know if it is still an issue.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "billylam",
"comment_id": null,
"datetime": 1565121059000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "billylam",
"comment_id": 518817909,
"datetime": 1565121070000,
"masked_author": "username_1",
"text": "Reopen if still an issue",
"title": null,
"type": "comment"
}
] | 2 | 4 | 463 | false | false | 463 | false |
backend-br/revise-seu-curriculo | backend-br | 326,099,118 | 4 | null | [
{
"action": "opened",
"author": "VSPPedro",
"comment_id": null,
"datetime": 1527164978000,
"masked_author": "username_0",
"text": "Sendo sincero, no momento estou procurando por uma vaga de desenvolvedor júnior e de preferência remoto para fora do país.\r\n\r\nO que vocês acham?\r\n\r\n[Resume](https://drive.google.com/file/d/1A5Qld0tJJyTr58E0bdi2kx-L53WYX4bT/view?usp=sharing)\r\n\r\nObrigado",
"title": "CV - Pedro Paiva",
"type": "issue"
},
{
"action": "created",
"author": "VSPPedro",
"comment_id": 392114744,
"datetime": 1527266459000,
"masked_author": "username_0",
"text": "Depois de mais alguns feedbacks:\r\n\r\n[Resume Br](https://drive.google.com/file/d/1r1m3SorDvYG7VICILp0iCuSoobd2QTvP/view?usp=sharing)\r\n\r\nSatisfeito com o resultado!\r\n\r\nRecomendo a plataforma!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "VSPPedro",
"comment_id": null,
"datetime": 1527266462000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 441 | false | false | 441 | false |
Rasec11/invie-github | null | 411,276,664 | 1 | null | [
{
"action": "opened",
"author": "Rasec11",
"comment_id": null,
"datetime": 1550457101000,
"masked_author": "username_0",
"text": "## ¿Cómo puede replicar el problema?\r\nCuando abro mi navegador Chrome en la version 60 y hago scroll la pagina se pone negra\r\n## ¿En qué versión de Invie ocurre?\r\nOcurre en la version actual del website 4 de octubre",
"title": "Esto no funciona porfa fix",
"type": "issue"
}
] | 1 | 1 | 215 | false | false | 215 | false |
aspnet/AspNetCore | aspnet | 405,484,625 | 7,172 | null | [
{
"action": "opened",
"author": "shellicar",
"comment_id": null,
"datetime": 1548976931000,
"masked_author": "username_0",
"text": "### Describe the bug\r\nASP.NET Core project targeting .net framework doesn't start when hosted by IIS with InProcess hosting model.\r\n\r\n### To Reproduce\r\nSteps to reproduce the behavior:\r\n1. Using ASP.NET Core 2.2\r\n2. Create new \"ASP.NET Core Web Application\" targeting \".NET Framework\"\r\n3. Specify InProcess hosting model.\r\n4. Host using IIS.\r\n5. Browse to website.\r\n6. Receive error: \"HTTP Error 500.0 - ANCM In-Process Handler Load Failure\"\r\n\r\n### Expected behavior\r\nEither application displays, or a clear error indicating the issue.\r\n\r\n### Screenshots\r\nerror on browsing\r\n\r\n\r\nancm debug log\r\n\r\n\r\nweb.config\r\n\r\n\r\nIIS version\r\n\r\n\r\n\r\n### Additional context\r\nI have only run into this issue with projects with TargetFramework of net461.\r\nOther projects targeting netcoreapp2.2 work fine.",
"title": "Can't host ASP.NET 2.2 Core project targeting net461 with InProcess",
"type": "issue"
},
{
"action": "created",
"author": "vovikdrg",
"comment_id": 459554323,
"datetime": 1548979331000,
"masked_author": "username_1",
"text": "Not supported.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vovikdrg",
"comment_id": 459554386,
"datetime": 1548979347000,
"masked_author": "username_1",
"text": "https://stackoverflow.com/questions/54109762/aspnetcore-2-2-targetting-net-framework-inprocess-fails-on-azure-app-service-w/54119290#54119290",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vovikdrg",
"comment_id": 459554518,
"datetime": 1548979376000,
"masked_author": "username_1",
"text": "https://docs.microsoft.com/en-us/aspnet/core/migration/21-to-22?view=aspnetcore-2.2&tabs=visual-studio",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shellicar",
"comment_id": 459920063,
"datetime": 1549070224000,
"masked_author": "username_0",
"text": "I would expect an error when publishing then, as it should be obvious that it wouldn't work at that point.",
"title": null,
"type": "comment"
}
] | 2 | 5 | 1,589 | false | false | 1,589 | false |
bluelinelabs/Conductor | bluelinelabs | 361,662,344 | 480 | null | [
{
"action": "opened",
"author": "ildar2",
"comment_id": null,
"datetime": 1537349961000,
"masked_author": "username_0",
"text": "I tried copying code from demo, but my background is always gray, while in demo an underlying controller is seen through View's `android:background=\"@color/immersive_background\"`",
"title": "[Question] How do you keep DialogController's background transparent?",
"type": "issue"
},
{
"action": "closed",
"author": "EricKuck",
"comment_id": null,
"datetime": 1537593301000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "EricKuck",
"comment_id": 423717632,
"datetime": 1537593301000,
"masked_author": "username_1",
"text": "Most likely you're using a change handler that's removing the controller you're trying to show the dialog over. Make sure `removesFromViewOnPush` is false for whatever change handler you're using.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 374 | false | false | 374 | false |
LN-Zap/zap-desktop | LN-Zap | 430,643,360 | 1,983 | null | [
{
"action": "opened",
"author": "korhaliv",
"comment_id": null,
"datetime": 1554755312000,
"masked_author": "username_0",
"text": "<!--- Provide a general summary of the issue in the Title above -->\r\n\r\n## Description\r\nPayment form should accept bech32 address format",
"title": "Incorrect bech32 address validation",
"type": "issue"
},
{
"action": "closed",
"author": "mrfelton",
"comment_id": null,
"datetime": 1554896000000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 135 | false | false | 135 | false |
consenlabs/token-profile | consenlabs | 466,099,809 | 4,474 | null | [
{
"action": "opened",
"author": "chainfinance",
"comment_id": null,
"datetime": 1562734726000,
"masked_author": "username_0",
"text": "block.cc链接：https://mifengcha.com/q/CFC\r\n代币简称：CFC \r\n合约地址：0x7f288ff5a8055f5f6103a80dd806cf8415e035c7\r\nEtherscan链接：https://etherscan.io/token/0x7f288ff5a8055f5f6103a80dd806cf8415e035c7",
"title": "ERC-20 ： 添加CFC价格显示",
"type": "issue"
},
{
"action": "created",
"author": "chainfinance",
"comment_id": 511288786,
"datetime": 1563172775000,
"masked_author": "username_0",
"text": "请尽快处理一下，谢谢。",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tstt",
"comment_id": null,
"datetime": 1563184233000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "tstt",
"comment_id": 511339453,
"datetime": 1563184233000,
"masked_author": "username_1",
"text": "已添加，请确认。",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "chainfinance",
"comment_id": 511632165,
"datetime": 1563241752000,
"masked_author": "username_0",
"text": "老大您好！再请教下，现在imtoken 2.0版本的以太坊钱包资产中心价格显示了，但CFC资产详情页面价格不显示。另外imtoken1.0版本，也不显示CFC价格，请问是否能给进一步处理一下呢？\r\nhttps://github.com/consenlabs/token-profile/issues/4474\r\n谢谢，添麻烦了",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "makoshan",
"comment_id": null,
"datetime": 1563241753000,
"masked_author": "username_2",
"text": "block.cc链接：https://mifengcha.com/q/CFC\r\n代币简称：CFC \r\n合约地址：0x7f288ff5a8055f5f6103a80dd806cf8415e035c7\r\nEtherscan链接：https://etherscan.io/token/0x7f288ff5a8055f5f6103a80dd806cf8415e035c7",
"title": "ERC-20 ： 添加CFC价格显示",
"type": "issue"
},
{
"action": "created",
"author": "tstt",
"comment_id": 511649485,
"datetime": 1563247445000,
"masked_author": "username_1",
"text": "是这样的，目前只支持 2.0 资产首页的价格显示，2.0 资产详情页和 1.0 暂不支持进一步处理。",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "tstt",
"comment_id": null,
"datetime": 1563247448000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 8 | 594 | false | false | 594 | false |
runelite/runelite | runelite | 482,051,091 | 9,696 | null | [
{
"action": "opened",
"author": "RSNKitt3n",
"comment_id": null,
"datetime": 1566170881000,
"masked_author": "username_0",
"text": "**Describe the bug**\r\nWhen clicking the maximize button, my client only takes a portion of the screen. I have tried reinstalling runelite and deleting related files, changing display settings, and restarting my computer but nothing has helped. I tried with the official OSRS client and it works just fine.\r\n\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Open the client as normal\r\n2. Login or stay logged out, doesn't matter\r\n3. Click maximize button and then be sad :(\r\n\r\n**Expected behavior**\r\nClient is expected to take up the whole screen.\r\n\r\n**Screenshots**\r\n\r\n<img width=\"1280\" alt=\"NWghOerCcw\" src=\"https://user-images.githubusercontent.com/54251743/63231703-f4784780-c1dc-11e9-999e-4f8fb8001c1d.png\">\r\n\r\n**Environment (please complete the following information):**\r\n - OS: Windows 10\r\n - RuneLite version: 1.5.31.1\r\n - Launcher version: 2.0\r\n\r\n**Additional context**\r\nNone",
"title": "Window Maximize Doesn't Properly Fit Screen",
"type": "issue"
},
{
"action": "created",
"author": "Adam-",
"comment_id": 522368872,
"datetime": 1566171549000,
"masked_author": "username_1",
"text": "If you set DPI scaling override to `System` does that do anything?\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RSNKitt3n",
"comment_id": 522371357,
"datetime": 1566173528000,
"masked_author": "username_0",
"text": "damn you're my hero thanks for the speedy response!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "RSNKitt3n",
"comment_id": null,
"datetime": 1566173528000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "Adam-",
"comment_id": 522371677,
"datetime": 1566173710000,
"masked_author": "username_1",
"text": "This is probably still a bug I was just wondering if that would fix it or not.",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "RSNKitt3n",
"comment_id": null,
"datetime": 1566173769000,
"masked_author": "username_0",
"text": "**Describe the bug**\r\nWhen clicking the maximize button, my client only takes a portion of the screen. I have tried reinstalling runelite and deleting related files, changing display settings, and restarting my computer but nothing has helped. I tried with the official OSRS client and it works just fine.\r\n\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Open the client as normal\r\n2. Login or stay logged out, doesn't matter\r\n3. Click maximize button and then be sad :(\r\n\r\n**Expected behavior**\r\nClient is expected to take up the whole screen.\r\n\r\n**Screenshots**\r\n\r\n<img width=\"1280\" alt=\"NWghOerCcw\" src=\"https://user-images.githubusercontent.com/54251743/63231703-f4784780-c1dc-11e9-999e-4f8fb8001c1d.png\">\r\n\r\n**Environment (please complete the following information):**\r\n - OS: Windows 10\r\n - RuneLite version: 1.5.31.1\r\n - Launcher version: 2.0\r\n\r\n**Additional context**\r\nNone",
"title": "Window Maximize Doesn't Properly Fit Screen",
"type": "issue"
},
{
"action": "created",
"author": "RSNKitt3n",
"comment_id": 522371761,
"datetime": 1566173769000,
"masked_author": "username_0",
"text": "well i'll leave open and let someone else decide then, ty",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Crownescent",
"comment_id": 522382807,
"datetime": 1566179357000,
"masked_author": "username_2",
"text": "I am also having the same problem as username_0. I'm sorry if me commenting this is useless/annoying, I'm not really sure how issues like this are brought up on Github as I've never used it, but I just wanted to let you know that I'm also having this problem. I was installing Runelite on a new laptop, and the same issue occurred. I tried the DPI override you suggested with no success.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Adam-",
"comment_id": 522385946,
"datetime": 1566180661000,
"masked_author": "username_1",
"text": "If you use https://sigterm.info/runelite/RuneLiteSetup32.exe - does that fix it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Crownescent",
"comment_id": 522390626,
"datetime": 1566182426000,
"masked_author": "username_2",
"text": "Am I supposed to uninstall and use that setup to reinstall Runelite?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Adam-",
"comment_id": 522552115,
"datetime": 1566218109000,
"masked_author": "username_1",
"text": "What do you mean by \"crashing\"? I can run it and it works okay.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Crownescent",
"comment_id": 522648044,
"datetime": 1566231349000,
"masked_author": "username_2",
"text": "Crashing as in when I use that specific setup to install Runelite, the game does not make it to the log-in screen. Using the installation setup from runelite.net, the game installs properly and works fine aside from the issue stated in this thread.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Adam-",
"comment_id": 522650992,
"datetime": 1566231807000,
"masked_author": "username_1",
"text": "Does the 32bit installer from runelite.net work?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Crownescent",
"comment_id": 522651202,
"datetime": 1566231842000,
"masked_author": "username_2",
"text": "Yes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Adam-",
"comment_id": 522658825,
"datetime": 1566233050000,
"masked_author": "username_1",
"text": "@username_0 are you available to test it instead?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "raiyni",
"comment_id": 522839212,
"datetime": 1566272134000,
"masked_author": "username_3",
"text": "This worked for a user in discord.\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Crownescent",
"comment_id": 522856888,
"datetime": 1566278262000,
"masked_author": "username_2",
"text": "Upon rechecking my Runelite version, the 32 bit installer does not work for me, but the 64 bit installer does. Sorry for the confusion.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Hawkie1",
"comment_id": 523151459,
"datetime": 1566327665000,
"masked_author": "username_4",
"text": "all of this is true for me as well, but the 32bit version runs very poorly for my pc is 64 bit. There seems to only be a link on runelite.net for a previous version in 32bit. getting like 15 fps where before I had at least 40 or 50 on the 64bit client",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Hawkie1",
"comment_id": 523152023,
"datetime": 1566327761000,
"masked_author": "username_4",
"text": "i might just stick with the fcked up maximize client just to get better fps, over this previous 32bit version provided on runelite.net",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "NikoZBK",
"comment_id": 523993861,
"datetime": 1566493797000,
"masked_author": "username_5",
"text": "This fixed my resolution issue. Main monitor is 1440p, side monitor is 1080p. Issue was launcher was using the 1920x1080 resolution of the side monitor rather than the 2,560 x 1,440 resolution of the main monitor.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Adam-",
"comment_id": null,
"datetime": 1566603705000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "Adam-",
"comment_id": 524493740,
"datetime": 1566603705000,
"masked_author": "username_1",
"text": "Fixed with launcher version 2.0.2.",
"title": null,
"type": "comment"
}
] | 6 | 22 | 4,019 | false | false | 4,019 | true |
CUTR-at-USF/gtfs-realtime-validator | CUTR-at-USF | 304,153,071 | 322 | null | [
{
"action": "opened",
"author": "skjolber",
"comment_id": null,
"datetime": 1520770258000,
"masked_author": "username_0",
"text": "**Summary:** \r\n\r\nManual construction of queries adding strings together is security hole\r\n\r\n**Steps to reproduce:** \r\n\r\nSee all createQuery(..) method calls.\r\n\r\n**Expected behavior:** \r\n\r\nUse builder to add parameters. \r\n\r\n**Observed behavior:** \r\n\r\nString appending\r\n\r\n**Platform:** \r\n\r\nJava",
"title": "SQL injection",
"type": "issue"
},
{
"action": "created",
"author": "barbeau",
"comment_id": 372149927,
"datetime": 1520802973000,
"masked_author": "username_1",
"text": "@username_0 Thanks for flagging this!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "barbeau",
"comment_id": 377622945,
"datetime": 1522443840000,
"masked_author": "username_1",
"text": "@username_0 https://github.com/CUTR-at-USF/gtfs-realtime-validator/pull/324 should fix this if you want to have a look. I'm going to test a bit before merging, any other eyes on this are welcome.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "barbeau",
"comment_id": null,
"datetime": 1522675990000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 521 | false | false | 521 | true |
mitodl/mitxpro | mitodl | 465,544,472 | 786 | null | [
{
"action": "created",
"author": "pdpinch",
"comment_id": 509715975,
"datetime": 1562690176000,
"masked_author": "username_0",
"text": "closed via #787",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "pdpinch",
"comment_id": null,
"datetime": 1562690178000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,403 | false | true | 15 | false |
mwarning/openwrt-examples | null | 439,459,293 | 5 | null | [
{
"action": "opened",
"author": "nusret3",
"comment_id": null,
"datetime": 1556782304000,
"masked_author": "username_0",
"text": "If the router already runs OpenWrt, then use the openwrt-*-sysupgrade.bin images. Transfer the image file to /tmp/ on the device (usually via scp <image> root@192.168.1.1:/tmp/) and use sysupgrade to apply the image:\r\n\r\nsysupgrade /tmp/openwrt-*-sysupgrade.bin\r\nAdd -n to keep configuration files <------ adding -n does not keep configuration files. it overwrites instead!!! be careful",
"title": "sysupgrade",
"type": "issue"
},
{
"action": "created",
"author": "mwarning",
"comment_id": 488670418,
"datetime": 1556803302000,
"masked_author": "username_1",
"text": "Nice catch. Thanks! Fixed now.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mwarning",
"comment_id": null,
"datetime": 1556803302000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 415 | false | false | 415 | false |
Zetrith/Multiplayer | null | 401,099,465 | 18 | {
"number": 18,
"repo": "Multiplayer",
"user_login": "Zetrith"
} | [
{
"action": "opened",
"author": "murmax",
"comment_id": null,
"datetime": 1547991939000,
"masked_author": "username_0",
"text": "Russian translation",
"title": "Russian translation",
"type": "issue"
},
{
"action": "created",
"author": "Zetrith",
"comment_id": 456261469,
"datetime": 1548128587000,
"masked_author": "username_1",
"text": "Thanks!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 26 | false | false | 26 | false |
conda-forge/yarn-feedstock | conda-forge | 364,302,778 | 15 | {
"number": 15,
"repo": "yarn-feedstock",
"user_login": "conda-forge"
} | [
{
"action": "opened",
"author": "bollwyvl",
"comment_id": null,
"datetime": 1538023325000,
"masked_author": "username_0",
"text": "Checklist\r\n* [x] Used a fork of the feedstock to propose changes\r\n* [ ] Bumped the build number (if the version is unchanged)\r\n* [x] Reset the build number to `0` (if the version changed)\r\n* [ ] [Re-rendered]( https://conda-forge.org/docs/conda_smithy.html#how-to-re-render ) with the latest `conda-smithy` (Use the phrase <code>@<space/>conda-forge-admin, please rerender</code> in a comment in this PR for automated rerendering)\r\n* [x] Ensured the license file is being packaged.\r\n\r\nAppears to be a bugfix:\r\nhttps://github.com/yarnpkg/yarn/compare/v1.10.0...v1.10.1",
"title": "Bump to 1.10.1",
"type": "issue"
},
{
"action": "created",
"author": "bollwyvl",
"comment_id": 425083819,
"datetime": 1538053686000,
"masked_author": "username_0",
"text": "Afk today, if anyone else wants to hit the button!",
"title": null,
"type": "comment"
}
] | 2 | 3 | 813 | false | true | 617 | false |
yiisoft/yii2 | yiisoft | 263,004,757 | 14,919 | null | [
{
"action": "opened",
"author": "papalapa",
"comment_id": null,
"datetime": 1507179503000,
"masked_author": "username_0",
"text": "### What steps will reproduce the problem?\r\nIn controller I have sent cookies like this:\r\n`Yii::$app->response->cookies->add(new yii\\web\\Cookie(['name' => 'user.name', 'value' => 'Jack Black']));`\r\nand\r\n`Yii::$app->response->cookies->add(new yii\\web\\Cookie(['name' => 'user-login', 'value' => 'jack']));`\r\n\r\nThen to get cookies in view I use code like this:\r\n`Yii::$app->request->cookies->getValue('user.name');`\r\nand\r\n`Yii::$app->request->cookies->getValue('user-login');`\r\n\r\n### What is the expected result?\r\nI waiting for `'Jack Black'` and `'jack'`.\r\n\r\n### What do you get instead?\r\nI receive a `NULL` value and `'jack'`.\r\n\r\n**Why dot symbol is not allowed in cookie?**\r\n\r\n### Additional info\r\n\r\n| Q | A\r\n| ---------------- | ---\r\n| Yii version | 2.0.12\r\n| PHP version | 5.4\r\n| Operating system | Ubuntu",
"title": "What is wrong with name of Cookie on getting?",
"type": "issue"
},
{
"action": "created",
"author": "samdark",
"comment_id": 334585410,
"datetime": 1507235975000,
"masked_author": "username_1",
"text": "What do you have in $_COOKIES?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dmirogin",
"comment_id": 334585495,
"datetime": 1507235992000,
"masked_author": "username_2",
"text": "Cause this\r\n`Yii::$app->response->cookies->add(new yii\\web\\Cookie(['name' => 'user.name', 'value' => 'Jack Black']));`\r\nsets cookie to response. Nothing more.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dmirogin",
"comment_id": 334585735,
"datetime": 1507236057000,
"masked_author": "username_2",
"text": "And you read cookies from request.\r\nRequest cookies and response cookies are different cookie bags.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "samdark",
"comment_id": 334608569,
"datetime": 1507242159000,
"masked_author": "username_1",
"text": "@username_2 I think he actually means reading cookie in a view in the next request, not the same one. Am I right, @username_0?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "papalapa",
"comment_id": 339252915,
"datetime": 1508919681000,
"masked_author": "username_0",
"text": "@username_2, @username_1 is right about setting and getting cookies.\r\nThe browser cookies after this manipulations has both variables: user.name and user-login, but on getting values I have this:\r\nvar_dump(Yii::$app->request->cookies->getValue('user-login')); // jack\r\nvar_dump(Yii::$app->request->cookies->getValue('user.name')); // NULL\r\n\r\nI think problem is in «.» symbol in cookie variable name.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "samdark",
"comment_id": 339253957,
"datetime": 1508919941000,
"masked_author": "username_1",
"text": "Yes https://harrybailey.com/2009/04/dots-arent-allowed-in-php-cookie-names/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "samdark",
"comment_id": 339253981,
"datetime": 1508919947000,
"masked_author": "username_1",
"text": "Not sure we should handle it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "papalapa",
"comment_id": 339256198,
"datetime": 1508920454000,
"masked_author": "username_0",
"text": "Oh, it is deeper than seems. I have never thinking about global variable names. Thank you @username_1.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "samdark",
"comment_id": 339259904,
"datetime": 1508921260000,
"masked_author": "username_1",
"text": "Either we should convert dots to underscores behind the scenes or throw an exception for cookies with dots in their names.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "papalapa",
"comment_id": 340183888,
"datetime": 1509189616000,
"masked_author": "username_0",
"text": "I think throwing an exception will be a better way to handle it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "samdark",
"comment_id": 340196301,
"datetime": 1509201947000,
"masked_author": "username_1",
"text": "Yes. Agree.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "klimov-paul",
"comment_id": 355565517,
"datetime": 1515162038000,
"masked_author": "username_3",
"text": "Disagreed. There are many symbols, which are not allowed in the Cookie name: spaces `=`, `;` and so on. Should we check them too?\r\n\r\nBesides PHP does not put any restriction on setting cookie with dot in the name. The only problem is that appears in `$_COOKIE` with dots been replaced by underscore.\r\nAlso this behavior may be fixed in the future PHP versions as 'register_globals' directive has been removed long ago.\r\n\r\nI do not think any actions should be performed.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "samdark",
"comment_id": 355855765,
"datetime": 1515361971000,
"masked_author": "username_1",
"text": "Makes sense.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "samdark",
"comment_id": null,
"datetime": 1515361971000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 15 | 2,517 | false | false | 2,517 | true |
CartoDB/toolkit | CartoDB | 501,646,762 | 19 | {
"number": 19,
"repo": "toolkit",
"user_login": "CartoDB"
} | [
{
"action": "opened",
"author": "rjimenezda",
"comment_id": null,
"datetime": 1570040146000,
"masked_author": "username_0",
"text": "This PR adds the code to the 'toolkit' package, which exposes all other packages and creates the concept of an 'App'. This package serves a twofold purpose:\r\n\r\n- It lets you install it and use each package individually\r\n- Use the App / OAuthApp that will do all the internal bindings for you.\r\n\r\nBesides the code itself, I'd appreciate some input on the how the export looks right now. I've standardized it (check out how @carto/toolkit imports them, and the index.html).\r\n\r\nAlso, App / OAuthApp are on the same level as SQL, OAuth, etc...should we create a level for them? CartoApp? I dunno",
"title": "Feature/metapackage",
"type": "issue"
},
{
"action": "created",
"author": "rjimenezda",
"comment_id": 538477728,
"datetime": 1570208083000,
"masked_author": "username_0",
"text": "Note to self: after the amazing async refactor, the first time you log into an OAuth app, the getters won't work, but they do if you refresh. Must fix this, it's a bug present on rc.4",
"title": null,
"type": "comment"
}
] | 1 | 2 | 774 | false | false | 774 | false |
RallyCommunity/CustomChart | RallyCommunity | 349,657,342 | 56 | null | [
{
"action": "opened",
"author": "nestep",
"comment_id": null,
"datetime": 1533935145000,
"masked_author": "username_0",
"text": "I'd like to be able to show number of remaining hours on open tasks in the sprint associated with each team member. I can do number of (count) like so:\r\n\r\nCan you add \"To Do\" (remaining hours) to the drop-down for \"Aggregation Type\"? Currently the list only has these:\r\n- Count\r\n- Actuals Total\r\n- Estimate Total",
"title": "Add Aggregation Type of \"To Do\" for Type \"Task\"",
"type": "issue"
}
] | 1 | 1 | 424 | false | false | 424 | false |
etaty/rediscala | null | 441,519,799 | 211 | null | [
{
"action": "opened",
"author": "TopSpoofer",
"comment_id": null,
"datetime": 1557281825000,
"masked_author": "username_0",
"text": "can update akka 2.5.10+?",
"title": "can update akka 2.5.10+?",
"type": "issue"
},
{
"action": "created",
"author": "redkhalil",
"comment_id": 493890209,
"datetime": 1558341193000,
"masked_author": "username_1",
"text": "I have a branch to update to `2.5.22` but I don't have permissions to upload. Can we upgrade to the latest Akka 2.5.22 and Scala 2.12.8?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "etaty",
"comment_id": 504737179,
"datetime": 1561284253000,
"masked_author": "username_2",
"text": "fixed by PR #214",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "etaty",
"comment_id": null,
"datetime": 1561284253000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 4 | 176 | false | false | 176 | false |
akka/akka | akka | 420,390,782 | 26,515 | {
"number": 26515,
"repo": "akka",
"user_login": "akka"
} | [
{
"action": "opened",
"author": "raboof",
"comment_id": null,
"datetime": 1552468567000,
"masked_author": "username_0",
"text": "Refs #26502",
"title": "Explicitly require jdk9+ for javadoc generation",
"type": "issue"
},
{
"action": "created",
"author": "raboof",
"comment_id": 472342013,
"datetime": 1552468845000,
"masked_author": "username_0",
"text": "(removed javadoc generation from Jenkins, as it clearly didn't test anything anyway. javadoc problems will eventually be caught by the nightly akka-docs, which seems soon enough)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "raboof",
"comment_id": 472342035,
"datetime": 1552468850000,
"masked_author": "username_0",
"text": "PLS BUILD",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "raboof",
"comment_id": 472348771,
"datetime": 1552470014000,
"masked_author": "username_0",
"text": "PLS BUILD",
"title": null,
"type": "comment"
}
] | 2 | 7 | 243 | false | true | 207 | false |
elastic/apm-agent-dotnet | elastic | 438,894,223 | 215 | null | [
{
"action": "opened",
"author": "gregkalapos",
"comment_id": null,
"datetime": 1556645771000,
"masked_author": "username_0",
"text": "Sending requests in parallel to the agent fails:\r\n\r\n``` AssertionError: queried for [('processor.event', 'transaction'), ('service.name', ['dotnetapp'])], expected 1000, got 832```\r\n\r\nLogs from the agent: \r\n[agentlogs_failingconcurrentTest.txt](https://github.com/elastic/apm-agent-dotnet/files/3132407/agentlogs_failingconcurrentTest.txt)",
"title": "Failing concurrent integration test",
"type": "issue"
},
{
"action": "created",
"author": "gregkalapos",
"comment_id": 488048744,
"datetime": 1556646483000,
"masked_author": "username_0",
"text": "I suspect this is a bug in `PaylodSender`. \r\n\r\nNumber of `[Debug] - {Tracer} Starting Transaction` logs: 1000. (also 100 for ending `Ending Transaction`)\r\nNumber of `{PayloadSenderV2} Sent items to server` logs: 768. (some of those batches send more than 1 transaction! )\r\n\r\nNow, the way this works is that every `Transaction.End` forces the `PayloadSender` to send data (spans are batched until 20 items). \r\n\r\nBut I suspect that due to the parallelism some Transactions remain in the queue. I planned to add some timeout and send those... maybe that's the way to go.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gregkalapos",
"comment_id": 488637322,
"datetime": 1556796353000,
"masked_author": "username_0",
"text": "The problem is that we can't queue the Transansactions:\r\n\r\n```\r\npublic void QueueTransaction(ITransaction transaction)\r\n{\r\n _eventQueue.Post(transaction)) //<-- this returns false and the `transaction` won't be in the `BatchBlock`, so we don't send it to the server \r\n _eventQueue.TriggerBatch();\r\n}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gregkalapos",
"comment_id": 488864739,
"datetime": 1556838799000,
"masked_author": "username_0",
"text": "Fixed in https://github.com/elastic/apm-agent-dotnet/pull/219",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "gregkalapos",
"comment_id": null,
"datetime": 1556838799000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 5 | 1,275 | false | false | 1,275 | false |
scm-spain/CMP | scm-spain | 344,390,281 | 23 | {
"number": 23,
"repo": "CMP",
"user_login": "scm-spain"
} | [
{
"action": "opened",
"author": "victuxbb",
"comment_id": null,
"datetime": 1532515325000,
"masked_author": "username_0",
"text": "* Add a Cookie handler to isolate read and write operations\r\n* Remove inmemory consent repository, not necessary now, we just inject a CookieHandler with a JSDOM to mock dom side effects\r\n* Add CookieHandler test cases\r\n* Fix consent repository tests",
"title": "Isolate Cookie handling",
"type": "issue"
}
] | 2 | 2 | 250 | false | true | 250 | false |
arlac77/bitbucket-repository-provider | null | 463,489,545 | 561 | null | [
{
"action": "closed",
"author": "arlac77",
"comment_id": null,
"datetime": 1562137609000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 3,862 | false | true | 0 | false |
micropython/micropython | micropython | 410,532,477 | 4,502 | null | [
{
"action": "opened",
"author": "XenGi",
"comment_id": null,
"datetime": 1550185502000,
"masked_author": "username_0",
"text": "```\r\n\r\nI hope someone with more knowledge about the underlying C code or the harware can shine some light on this.\r\n\r\n[esp32-gateway]: https://github.com/OLIMEX/ESP32-GATEWAY/raw/master/HARDWARE/Hardware%20revision%20C/ESP32-GATEWAY_Rev_C_Color.pdf\r\n[esp32-evb]: https://github.com/OLIMEX/ESP32-EVB/raw/master/HARDWARE/REV-D/ESP32-EVB_Rev_D.pdf\r\n[esp32-poe]: https://github.com/OLIMEX/ESP32-POE/raw/master/HARDWARE/ESP32-PoE-hardware-revision-C/ESP32-PoE_Rev_C_Color.pdf\r\n[demo]: https://github.com/OLIMEX/ESP32-POE/tree/master/SOFTWARE/ESP-IDF/ESP32_PoE_Ethernet",
"title": "Ethernet support on the Olimex ESP32-POE",
"type": "issue"
},
{
"action": "created",
"author": "readylan",
"comment_id": 463996361,
"datetime": 1550227780000,
"masked_author": "username_1",
"text": "Hello ! \r\nI have the same problem. I have contacted with Olimex support and they have send me this line of code:\r\n```\r\nlan = network.LAN(mdc = machine.Pin(23), mdio = machine.Pin(18), power = machine.Pin(17), phy_type = network.PHY_LAN8720, phy_addr=0)\r\n```\r\nbut it doesn't work. They told me to than t is better to post in the MicroPython’s forums since here, the team members are familiar with their boards ..",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "YonasJ",
"comment_id": 464188187,
"datetime": 1550262479000,
"masked_author": "username_2",
"text": "`\r\n\r\nThis, open issue, seems related as well. \r\n\r\nhttps://github.com/micropython/micropython-esp32/issues/239\r\n\r\nAnd, this seems to be a solution on the C side, but as far as I can tell it should be implemented.\r\n\r\nhttps://github.com/OLIMEX/ESP32-EVB/issues/11",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "YonasJ",
"comment_id": 464200106,
"datetime": 1550264954000,
"masked_author": "username_2",
"text": "This must be related to something I am doing, when I try it with: esp32-20190113-v1.9.4-779-g5064df207.bin I am able to get it to work. But based on my own build from the trunk, it does not work.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "petrkr",
"comment_id": 464431011,
"datetime": 1550393979000,
"masked_author": "username_3",
"text": "I (19581) event: eth ip: 10.200.0.137, mask: 255.255.255.0, gw: 10.200.0.1\r\nI (19581) network: event 24\r\n```\r\n\r\nI can provide current mater BIN for your test (if you want) and will try implement configuration option for this parameter and will try do Pull Request whenever I will get time. Meanwhile hard-coded version for me is enough :)\r\n\r\nPetr",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "petrkr",
"comment_id": 464431099,
"datetime": 1550394033000,
"masked_author": "username_3",
"text": "And I forgot. Here is patch\r\n\r\n```\r\ndiff --git a/ports/esp32/network_lan.c b/ports/esp32/network_lan.c\r\nindex fba4de73a..258c6f3fd 100644\r\n--- a/ports/esp32/network_lan.c\r\n+++ b/ports/esp32/network_lan.c\r\n@@ -146,6 +146,9 @@ STATIC mp_obj_t get_lan(size_t n_args, const mp_obj_t *pos_args, mp_map_t *kw_ar\r\n config.gpio_config = init_lan_rmii;\r\n config.tcpip_input = tcpip_adapter_eth_input;\r\n \r\n+ // Hard coded test for GPIO17 clock output\r\n+ config.clock_mode = 3;\r\n+\r\n if (esp_eth_init(&config) == ESP_OK) {\r\n self->active = false;\r\n self->initialized = true;\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "readylan",
"comment_id": 464448204,
"datetime": 1550404960000,
"masked_author": "username_1",
"text": "Ok, very good, I will try it soon and tell you what happens. Thank you!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "petrkr",
"comment_id": 464448797,
"datetime": 1550405243000,
"masked_author": "username_3",
"text": "you can try that PR already (if you are able compile it yourself). https://github.com/username_3/micropython/commit/472c5a2937f01fa5543b3caeefc6e0a838080c7f",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "readylan",
"comment_id": 464489241,
"datetime": 1550426906000,
"masked_author": "username_1",
"text": "Hello, I'm interested in that way ..",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "petrkr",
"comment_id": 464498024,
"datetime": 1550431566000,
"masked_author": "username_3",
"text": "Can you try https://username_3.net/micropython-v1.10-108-gbd1b537be-dirty-build-username_3-LANclock.bin\r\nIt's latest `master` with that mine PR, version with optional `power` too. Since you using internal clock, you do not need use power at all, and specify `power = None` is littlebit useless I think, so I made it as default if not specified\r\n\r\nAlso you have to try if your phy is 0 or 1, for example mine wavewhare module is 1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "readylan",
"comment_id": 464708980,
"datetime": 1550491754000,
"masked_author": "username_1",
"text": "Hello, thank you for your help but my board doesn't work:\r\n(phy_addr=0/1)\r\n\r\n```\r\nlan = network.LAN(mdc = machine.Pin(23), mdio = machine.Pin(18), phy_type = network.PHY_LAN8720, phy_addr=1)\r\nlan.active(1)\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\nOSError: ethernet enable failed\r\n```\r\nI don't know if (or how) can provide more information.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "petrkr",
"comment_id": 464713097,
"datetime": 1550492628000,
"masked_author": "username_3",
"text": "You should specify also clock_mode parameter. I guess in your board case it would be:\r\n\r\n`lan = network.LAN(mdc = machine.Pin(23), mdio = machine.Pin(18), phy_type = network.PHY_LAN8720, phy_addr=1, clock_mode=network.ETH_CLOCK_GPIO17_OUT)`\r\n\r\nor `phy_mode=0`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "readylan",
"comment_id": 464716037,
"datetime": 1550493233000,
"masked_author": "username_1",
"text": "Tested without luck, I don't know what to do ..",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "petrkr",
"comment_id": 464717815,
"datetime": 1550493630000,
"masked_author": "username_3",
"text": "Regards to schematic (if you have Olimex PoE board) they also have \"power\" pin at GPIO12. So try\r\n\r\n`lan = network.LAN(mdc = machine.Pin(23), mdio = machine.Pin(18), power=machine.Pin(12), phy_type = network.PHY_LAN8720, phy_addr=0, clock_mode=network.ETH_CLOCK_GPIO17_OUT)`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "readylan",
"comment_id": 464723334,
"datetime": 1550494826000,
"masked_author": "username_1",
"text": "I can not get it to work but there are news: the board has link status, its ethernet leds (green and yellow) are active. I've noticed that after unplug from usb and replug again. But I get the same error when trying to activate from the python shell.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "petrkr",
"comment_id": 464725729,
"datetime": 1550495358000,
"masked_author": "username_3",
"text": "Maybe you can try skip power= and power-up that module by yourself before lan instance by something like\r\n\r\n```\r\nlan_power = machine.Pin(12, machine.Pin.OUT)\r\nlan_power.value(1)\r\n```\r\n\r\nand then without `power`\r\n```\r\nlan = network.LAN(mdc = machine.Pin(23), mdio = machine.Pin(18), phy_type = network.PHY_LAN8720, phy_addr=0, clock_mode=network.ETH_CLOCK_GPIO17_OUT\r\n```\r\n\r\nyou have to determine if lan_power is value 1 or 0 to power-up that module. As you wrote, you have to see link/activity LED's lighting\r\n\r\nalso now I check datasheet, that module is 8710, not 8720, can be that also problem? Have you tried some other example? Like from Arduino-C?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "readylan",
"comment_id": 464735454,
"datetime": 1550497302000,
"masked_author": "username_1",
"text": "First, I confirm lan_power on 1 power-up the board and leds, otherwise they remain off.\r\nThe sketch in Arduino that works for me is [this](https://github.com/espressif/arduino-esp32/blob/master/libraries/WiFi/examples/ETH_LAN8720_internal_clock/ETH_LAN8720_internal_clock.ino).\r\n(changing mdc/mdio pins)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "petrkr",
"comment_id": 464740466,
"datetime": 1550498241000,
"masked_author": "username_3",
"text": "One more question, on Micropython, do you have some `boot.py` or `main.py` which can sits on Ethernet GPIO pins ? For me onetime I had problem my old code in boot.py initialized one of PHY pin to OUTPUT and as HIGH or something...\r\n\r\nAlso when you try different `lan = network.LAN()` you have to reboot board (full, not just CTRL+D) because that old configuration will stay used (like phy_addr, clock mode,etc). If you play with network, it's better always do hard-reboot to be sure all MCU state was reset to default state.\r\n\r\nyou can use either `machine.reset()` or unplug/replug power",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "readylan",
"comment_id": 464818808,
"datetime": 1550510737000,
"masked_author": "username_1",
"text": "('192.168.1.170', '255.255.255.0', '192.168.1.1', '192.168.1.1')\r\n```\r\nIt is important for me since this board is quite good price and being PoE It is very suitable for my projects.\r\nThank you again !",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "petrkr",
"comment_id": 464843012,
"datetime": 1550516137000,
"masked_author": "username_3",
"text": "Good, since you already made it work, you can now also test that if `power=` option will work instead that separated `lan_power`. So you do not need do extra steps...\r\n\r\nRegards, also thanks for test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "readylan",
"comment_id": 465104483,
"datetime": 1550578070000,
"masked_author": "username_1",
"text": "('192.168.1.170', '255.255.255.0', '192.168.1.1', '192.168.1.1')\r\n```\r\nRegards,",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "coon42",
"comment_id": 465759840,
"datetime": 1550697834000,
"masked_author": "username_4",
"text": "Works fine with Olimex ESP32-POE :). Thanks for the patch!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "XenGi",
"comment_id": 465849338,
"datetime": 1550720186000,
"masked_author": "username_0",
"text": "Nice work guys. Thx to all of you. I'm getting more of the ESP32-POEs now. :)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "dpgeorge",
"comment_id": null,
"datetime": 1550752474000,
"masked_author": "username_5",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "dpgeorge",
"comment_id": 465984046,
"datetime": 1550752532000,
"masked_author": "username_5",
"text": "The `clock_mode` parameter was added in 7d8c71c222ed7793c99792eb15966504e039dae4",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "adrian-vlad",
"comment_id": 933014804,
"datetime": 1633290709000,
"masked_author": "username_6",
"text": "E (29017) emac_esp32: emac_esp32_init(308): reset timeout\r\nE (29017) esp_eth: esp_eth_driver_install(198): init mac failed\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\nOSError: esp_eth_driver_install failed\r\n```\r\n\r\nHow can I use the wired LAN on this board without rebuilding the firmware myself?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "petrkr",
"comment_id": 934208655,
"datetime": 1633424315000,
"masked_author": "username_3",
"text": "I made issue for that on espressif long time ago as they drop this change from runtime and kept only during build time\r\n\r\nhttps://github.com/espressif/esp-idf/issues/6564\r\n\r\nBut they already closed that issue, so now it's about integrate to micropython build and use this SDK which supports that",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hagenbuch",
"comment_id": 1042074794,
"datetime": 1645039449000,
"masked_author": "username_7",
"text": "but I only get the error\r\n\r\nAttribute Error: 'module' object has no attribute 'ETH_CLOCK_GPIO17_OUT\r\n\r\nWhere did I go wrong?\r\n\r\nI'm installing with Thonny on Linux Mint 20.3, went fine as far as I can see.\r\nAndreas",
"title": null,
"type": "comment"
}
] | 8 | 28 | 7,331 | false | false | 7,331 | true |
ansible/molecule | ansible | 377,646,197 | 1,557 | {
"number": 1557,
"repo": "molecule",
"user_login": "ansible"
} | [
{
"action": "opened",
"author": "webknjaz",
"comment_id": null,
"datetime": 1541465224000,
"masked_author": "username_0",
"text": "* Increase minimal required tox version\r\n* Collapse env lists\r\n* Add tests against Ansible 2.7 and devel branch\r\n* Adjust ini config style\r\n\r\n#### PR Type\r\n\r\n- Feature Pull Request",
"title": "Improve tox config",
"type": "issue"
},
{
"action": "created",
"author": "webknjaz",
"comment_id": 436224346,
"datetime": 1541504489000,
"masked_author": "username_0",
"text": "@lwm @ssbarnea @gundalow @themr0c thanks for your reviews!",
"title": null,
"type": "comment"
}
] | 1 | 2 | 238 | false | false | 238 | false |
Microsoft/AppCenter-SDK-Apple | Microsoft | 376,540,222 | 1,200 | {
"number": 1200,
"repo": "AppCenter-SDK-Apple",
"user_login": "Microsoft"
} | [
{
"action": "opened",
"author": "bmourat",
"comment_id": null,
"datetime": 1541101215000,
"masked_author": "username_0",
"text": "* [x] Are tests passing locally?\r\n* [x] Did you add unit tests?\r\n\r\nThis PR adds crash fixtures for macOS and adds some unit testing of basic crash parameters. Array [here](https://github.com/Microsoft/AppCenter-SDK-Apple/compare/add-fixtures-for-mac-crashes?expand=1#diff-8cec48ec45970a2268bd3896a91a7d87R20) is formatted in this way for better readability.",
"title": "Add fixtures for mac crashes",
"type": "issue"
}
] | 2 | 2 | 357 | false | true | 357 | false |
openshift/release | openshift | 399,287,119 | 2,588 | {
"number": 2588,
"repo": "release",
"user_login": "openshift"
} | [
{
"action": "opened",
"author": "kargakis",
"comment_id": null,
"datetime": 1547549143000,
"masked_author": "username_0",
"text": "Regarding deploying prow, I found the latest state of the upstream docs to be pretty satisfactory. If you want to play around @charlesakalugwu @mjudeikis \r\n\r\n/kind documentation",
"title": "Use getting started docs for linking to prow",
"type": "issue"
}
] | 2 | 2 | 962 | false | true | 177 | false |
YegorZaremba/typeorm-mock-unit-testing-example | null | 490,778,256 | 5 | null | [
{
"action": "opened",
"author": "YegorZaremba",
"comment_id": null,
"datetime": 1567962515000,
"masked_author": "username_0",
"text": "**Motivation**\r\n\r\nIt'll be useful for newcomers who wanna use Jest framework\r\n\r\n[Jest docs](https://jestjs.io/docs/en/mock-functions)",
"title": "Re-write jest unit tests using native Jest mock instead of Sinon library",
"type": "issue"
},
{
"action": "closed",
"author": "YegorZaremba",
"comment_id": null,
"datetime": 1569741126000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "YegorZaremba",
"comment_id": 536309963,
"datetime": 1569769034000,
"masked_author": "username_0",
"text": "a lot of commits because of playing with `commit-lint` and `git rebase`",
"title": null,
"type": "comment"
}
] | 1 | 3 | 204 | false | false | 204 | false |
rust-lang-cn/english-chinese-glossary-of-rust | rust-lang-cn | 454,125,583 | 4 | {
"number": 4,
"repo": "english-chinese-glossary-of-rust",
"user_login": "rust-lang-cn"
} | [
{
"action": "opened",
"author": "upsuper",
"comment_id": null,
"datetime": 1560166230000,
"masked_author": "username_0",
"text": "",
"title": "修正optimization错拼",
"type": "issue"
},
{
"action": "created",
"author": "aaranxu",
"comment_id": 504370697,
"datetime": 1561111502000,
"masked_author": "username_1",
"text": "感谢",
"title": null,
"type": "comment"
}
] | 2 | 2 | 2 | false | false | 2 | false |
folio-org/ui-finance | folio-org | 378,476,361 | 40 | {
"number": 40,
"repo": "ui-finance",
"user_login": "folio-org"
} | [
{
"action": "opened",
"author": "bonthebeerman",
"comment_id": null,
"datetime": 1541626058000,
"masked_author": "username_0",
"text": "also removed budgetView.js componentWillMount",
"title": "UIF-42 Fiscal year detailed and edit data",
"type": "issue"
}
] | 2 | 3 | 2,391 | false | true | 45 | false |
slimphp/Slim | slimphp | 298,445,177 | 2,403 | null | [
{
"action": "opened",
"author": "conrad10781",
"comment_id": null,
"datetime": 1519089877000,
"masked_author": "username_0",
"text": "I've done my best to research the documentation or another issue that clarifies this, and I apologize if there is something that provides clarity to this.\r\n\r\nUsing the LIFO ( last in first out ) approach, my thought would be when executing the following:\r\n\r\n```php\r\nclass Middleware_Test\r\n{\r\n protected $_name;\r\n \r\n public function __construct($name)\r\n {\r\n $this->_name = $name;\r\n }\r\n \r\n public function __invoke(\\Slim\\Http\\Request $request, \\Slim\\Http\\Response $response, $next)\r\n {\r\n print \"\\nHELLO FROM {$this->_name} Middleware\";\r\n \r\n $response = $next($request, $response);\r\n \r\n return $response;\r\n }\r\n}\r\n\r\nrequire \"../vendor/autoload.php\";\r\n\r\n$app = new \\Slim\\App();\r\n\r\n$app->add(new Middleware_Test(\"Middleware1\"));\r\n$app->add(new Middleware_Test(\"Middleware2\"));\r\n$app->add(new Middleware_Test(\"Middleware3\"));\r\n\r\n$app->group(\"/some/path\", function () {\r\n $this->get(\"/{testing}\", function ($request, $response, $args) {\r\n return $response->write(\"Middleware Test Response\");\r\n })->add(new Middleware_Test(\"Middleware6\"))->add(new Middleware_Test(\"Middleware7\"));\r\n})->add(new Middleware_Test(\"Middleware4\"))->add(new Middleware_Test(\"Middleware5\"));\r\n \r\n$app->run();\r\n\r\n\r\n\r\n```\r\n\r\nThat the order of execution would be:\r\n\r\n```\r\nHELLO FROM Middleware7 Middleware\r\nHELLO FROM Middleware6 Middleware\r\nHELLO FROM Middleware5 Middleware\r\nHELLO FROM Middleware4 Middleware\r\nHELLO FROM Middleware3 Middleware\r\nHELLO FROM Middleware2 Middleware\r\nHELLO FROM Middleware1 Middleware\r\n```\r\n\r\nThe logic being that the sequence is following what I believe to be the declaration and ultimately the application's logic. \r\n\r\nMiddleware1/Middleware2 are added before any routes are set, before any routing logic was processed.\r\n\r\nThen, as FastRoute matches the group the groups Middleware is added, and finally the matching route's middleware inside the group gets added.\r\n\r\nInstead the order is:\r\n\r\n```\r\nHELLO FROM Middleware3 Middleware\r\nHELLO FROM Middleware2 Middleware\r\nHELLO FROM Middleware1 Middleware\r\nHELLO FROM Middleware5 Middleware\r\nHELLO FROM Middleware4 Middleware\r\nHELLO FROM Middleware7 Middleware\r\nHELLO FROM Middleware6 Middleware\r\n```\r\n\r\nI'm having some difficulty following the logic of the order. It's the LIFO of the application, then the group specific LIFO ( if applicable ), then the route specific LIFO. \r\n\r\nI could /possibly/ see if the order was 5,4,7,6,3,2,1 that the order of the group and specific route were just swapped, but still ahead of the application. However with the application, group and route all seemingly out of order from their declaration order, I'm a bit confused.\r\n\r\nProvided this is expected, can someone provide the explanation on this order of execution?",
"title": "Slim 3.X middleware order verification",
"type": "issue"
},
{
"action": "created",
"author": "l0gicgate",
"comment_id": 366853447,
"datetime": 1519095431000,
"masked_author": "username_1",
"text": "This is the correct behavior, the reason being is that the group's path will be matched first before the final route's path. And then middleware ordering works the same while being nested (last in, first out).\r\n\r\nThis is the way it'll work:\r\n```php\r\n/*\r\n * These will all be executed prior to routing being done\r\n * Unless you set `determineRouteBeforeAppMiddleware` in your App settings\r\n * Then these would execute after routing in the same LIFO order (3, 2, 1) which means\r\n * Middleware 5, 4, 7 and 6 would execute first and then Middleware 3, 2 and 1\r\n */\r\n$app->add(new Middleware_Test(\"Middleware1\"));\r\n$app->add(new Middleware_Test(\"Middleware2\"));\r\n$app->add(new Middleware_Test(\"Middleware3\"));\r\n```\r\n```php\r\n/*\r\n * As for the middleware added here, as mentioned above the $app->group path will match first\r\n * which will cause Middleware 5 and 4 to be executed\r\n * Then the $this->get(\"/{testing}\") path will be executed after which will cause\r\n * Middleware 7 and 6 to be executed.\r\n */\r\n$app->group(\"/some/path\", function () {\r\n $this->get(\"/{testing}\", function ($request, $response, $args) {\r\n return $response->write(\"Middleware Test Response\");\r\n })->add(new Middleware_Test(\"Middleware6\"))->add(new Middleware_Test(\"Middleware7\"));\r\n})->add(new Middleware_Test(\"Middleware4\"))->add(new Middleware_Test(\"Middleware5\"));\r\n```\r\n\r\nHope this answers your questions.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "l0gicgate",
"comment_id": 366862013,
"datetime": 1519099903000,
"masked_author": "username_1",
"text": "@username_0 you are correct actually. That setting does not affect how the middleware stack is being run.\r\n\r\nI just wrote two test cases. My assumption was in fact correct though in the way the middleware is being executed, however I was wrong about the setting. All the setting does it provide the `$request` object with the attribute `routeInfo` and doesn't change the way the middleware stack is being run.\r\n\r\nHere are the test cases I wrote and for the record the second test fails:\r\n```php\r\nclass Middleware\r\n{\r\n /**\r\n * @var string\r\n */\r\n protected $name;\r\n\r\n /**\r\n * Middleware constructor.\r\n * @param $name\r\n */\r\n public function __construct($name)\r\n {\r\n $this->name = $name;\r\n }\r\n\r\n public function __invoke(Request $request, Response $response, callable $next)\r\n {\r\n $text = $request->getAttribute('text', '');\r\n $text .= \"MW {$this->name}, \";\r\n $request = $request->withAttribute('text', $text);\r\n return $next($request, $response);\r\n }\r\n}\r\n```\r\n```php\r\nclass MiddlewareOrderTest extends TestCase\r\n{\r\n public function testMiddlewareOrderWithDetermineRouteBeforeAppMiddlewareOn()\r\n {\r\n $app = new App([\r\n 'settings' => [\r\n 'determineRouteBeforeAppMiddleware' => true,\r\n ],\r\n ]);\r\n\r\n $mw1 = new Middleware('1');\r\n $mw2 = new Middleware('2');\r\n $mw3 = new Middleware('3');\r\n $app->add($mw1);\r\n $app->add($mw2);\r\n $app->add($mw3);\r\n\r\n\r\n $mw4 = new Middleware('4');\r\n $mw5 = new Middleware('5');\r\n $mw6 = new Middleware('6');\r\n $mw7 = new Middleware('7');\r\n $app->group(\"/foo\", function () use ($mw6, $mw7) {\r\n $this->get(\"/bar\", function (Request $request, Response $response, $args) {\r\n $text = $request->getAttribute('text');\r\n return $response->write($text);\r\n })\r\n ->add($mw6)\r\n ->add($mw7);\r\n })\r\n ->add($mw4)\r\n ->add($mw5);\r\n\r\n $request = $this->requestFactory('/foo/bar');\r\n $response = new Response();\r\n $response = $app->process($request, $response);\r\n $app->respond($response);\r\n\r\n $this->expectOutputString(\"MW 3, MW 2, MW 1, MW 5, MW 4, MW 7, MW 6, \");\r\n }\r\n\r\n public function testMiddlewareOrderWithDetermineRouteBeforeAppMiddlewareOff()\r\n {\r\n $app = new App([\r\n 'settings' => [\r\n 'determineRouteBeforeAppMiddleware' => false,\r\n ],\r\n ]);\r\n\r\n $mw1 = new Middleware('1');\r\n $mw2 = new Middleware('2');\r\n $mw3 = new Middleware('3');\r\n $app->add($mw1);\r\n $app->add($mw2);\r\n $app->add($mw3);\r\n\r\n\r\n $mw4 = new Middleware('4');\r\n $mw5 = new Middleware('5');\r\n $mw6 = new Middleware('6');\r\n $mw7 = new Middleware('7');\r\n $app->group(\"/foo\", function () use ($mw6, $mw7) {\r\n $this->get(\"/bar\", function (Request $request, Response $response, $args) {\r\n $text = $request->getAttribute('text');\r\n return $response->write($text);\r\n })\r\n ->add($mw6)\r\n ->add($mw7);\r\n })\r\n ->add($mw4)\r\n ->add($mw5);\r\n\r\n $request = $this->requestFactory('/foo/bar');\r\n $response = new Response();\r\n $response = $app->process($request, $response);\r\n $app->respond($response);\r\n\r\n $this->expectOutputString(\"MW 5, MW 4, MW 7, MW 6, MW 3, MW 2, MW 1, \");\r\n }\r\n\r\n /**\r\n * @param $requestUri\r\n * @param string $method\r\n * @return Request\r\n */\r\n public function requestFactory($requestUri, $method = 'GET')\r\n {\r\n $env = Environment::mock([\r\n 'SCRIPT_NAME' => '/index.php',\r\n 'REQUEST_URI' => $requestUri,\r\n 'REQUEST_METHOD' => $method,\r\n ]);\r\n $uri = Uri::createFromEnvironment($env);\r\n $headers = Headers::createFromEnvironment($env);\r\n $cookies = [];\r\n $serverParams = $env->all();\r\n $body = new RequestBody();\r\n $request = new Request($method, $uri, $headers, $cookies, $serverParams, $body);\r\n\r\n return $request;\r\n }\r\n}\r\n```\r\n\r\nThe output from PHPUnit on the second test case:\r\n```\r\nThere was 1 failure:\r\n\r\n1) Tests\\MockRepo\\AppTest::testMiddlewareOrderWithDetermineRouteBeforeAppMiddlewareOff\r\nFailed asserting that two strings are equal.\r\n--- Expected\r\n+++ Actual\r\n@@ @@\r\n-'MW 5, MW 4, MW 7, MW 6, MW 3, MW 2, MW 1, '\r\n+'MW 3, MW 2, MW 1, MW 5, MW 4, MW 7, MW 6, '\r\n\r\nFAILURES!\r\nTests: 2, Assertions: 2, Failures: 1.\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "akrabat",
"comment_id": 366902812,
"datetime": 1519115524000,
"masked_author": "username_2",
"text": "I wonder if we should change to FIFO for Slim 4?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "conrad10781",
"comment_id": 366967671,
"datetime": 1519131044000,
"masked_author": "username_0",
"text": "If there is a vote, mine would be for FIFO by default.\r\n\r\nI don't think it really creates a lot of issues after seeing the order in which Middleware is executed now in Slim 3. \r\n\r\nFor anyone migrating to Slim 4, it would still execute app, route group, route as it does now, just the order in which you ->add() Middleware only on those levels would change.\r\n\r\nIf it was changed to be more LIFO where it was route, route group, app, it seems to get a bit more hairy when considering users who are migrating because it's the same terminology but actually behaves different. Especially if that is relying on, or affected by the \"determineRouteBeforeAppMiddleware\" setting, or it's equivalent in Slim 4. Meaning, the idea that this setting could affect the order of Middleware execution seems like it would potentially create it's own issue.\r\n\r\nSo even if someone just read FIFO in the Slim 4 docs and thought \"this changes everything\". If they went back to Slim 3 and saw what was reported here, they would see it wasn't really that big of a change. As currently it's LIFO of FIFO declaration, and a change to FIFO would just be FIFO of FIFO declaration.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "odan",
"comment_id": 367072151,
"datetime": 1519151247000,
"masked_author": "username_3",
"text": "I would be happy if the the order of the middleware stack changes in v4. I think the first middleware must be the first to be executed. That would just be more logical.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "geggleto",
"comment_id": 367072955,
"datetime": 1519151387000,
"masked_author": "username_4",
"text": "If we change the ordering now, migrating projects is going to be a bit more tricky. We will have to make sure we document the changes extensively.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "conrad10781",
"comment_id": 367078379,
"datetime": 1519152446000,
"masked_author": "username_0",
"text": "Please see https://github.com/slimphp/Slim/issues/2403#issuecomment-366967671 if you haven't already. I don't personally think this is going to be a huge change. Provided again it remains in the same order it does now of app, route group, route. The only change anyone would need is the ordering on those individual \"levels\", because currently it's LIFO of FIFO declaration, and a change to FIFO would just be FIFO of FIFO declaration. For me at least, this is more confusing.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "l0gicgate",
"comment_id": 367206666,
"datetime": 1519185725000,
"masked_author": "username_1",
"text": "I think that FIFO makes more sense, it's easier to comprehend for the end user. I also believe that Slim 4 is a new direction where we introduce new concepts and do things differently. There are already breaking changes, we should steer in the direction that makes the most sense. For the handful of users that will migrate entire projects from 3 to 4, we can provide support.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "geggleto",
"comment_id": 369254841,
"datetime": 1519827869000,
"masked_author": "username_4",
"text": "@username_0 we can't change how it works in 3.x (it would be a backwards compatibility break) however we can in 4.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "geggleto",
"comment_id": 369255003,
"datetime": 1519827902000,
"masked_author": "username_4",
"text": "Going to close this one as resolved. We can continue the discussions in the other issue about LIFO vs FIFO.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "geggleto",
"comment_id": null,
"datetime": 1519827902000,
"masked_author": "username_4",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "conrad10781",
"comment_id": 369267614,
"datetime": 1519830306000,
"masked_author": "username_0",
"text": "@username_4 , sorry for the confusion. I wasn't implying to change it for 3, just that if it changed in 4, despite it sounding like a huge change, it really wouldn't be if the declaration hierarchy order ( App, Route Group, Route ) stayed the same. Because as it is, it's LIFO of FIFO declaration, which honestly didn't match the expectation I had at least when reading the documentation and implementing.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tobiascapin",
"comment_id": 502642093,
"datetime": 1560770444000,
"masked_author": "username_5",
"text": "Is this order still valid for Slim 3.12? I'm trying that test and I get FIFO order, is something changed?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tobiascapin",
"comment_id": 502646403,
"datetime": 1560771337000,
"masked_author": "username_5",
"text": "Do you confirm that there is no way to have a valid (LIFO or FIFO) following the declaration order? As far as I know the current fixed order is:\r\nApplication MW LIFO, then Group LIFO, then Route LIFO.\r\nIs there any way to follow the declaration order instead of general MW always before the router or group MW? thanks",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "l0gicgate",
"comment_id": 502777315,
"datetime": 1560792505000,
"masked_author": "username_1",
"text": "@username_5 the order is fixed LIFO for everything in both Slim 3 and Slim 4. \r\n\r\nUnless you rewrite the `MiddlewareAwareTrait` in Slim 3 and most of the App’s core you won’t be able to change that. \r\n\r\nAs for Slim 4 you’d need to rewrite the `MiddlewareDispatcher` component and the App’s constructor to use your rewritten dispatcher to make it possible.",
"title": null,
"type": "comment"
}
] | 6 | 16 | 12,620 | false | false | 12,620 | true |
HIT-SCIR/ELMoForManyLangs | HIT-SCIR | 403,340,672 | 43 | null | [
{
"action": "opened",
"author": "hot-cheeto",
"comment_id": null,
"datetime": 1548451930000,
"masked_author": "username_0",
"text": "Hello, \r\n\r\nI am running sent2elmo function with a custom dataset (reddit data). I am running into the problem of ZeroDivisionError. The error seems to happen in line 202 in elmo.py. What is happening or what is in my input that is causing this ?\r\n\r\nThanks in advance",
"title": "Zero Division Error ",
"type": "issue"
},
{
"action": "created",
"author": "hot-cheeto",
"comment_id": 457739101,
"datetime": 1548452461000,
"masked_author": "username_0",
"text": "I feel silly, the problem was an empty list.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "hot-cheeto",
"comment_id": null,
"datetime": 1548452461000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 310 | false | false | 310 | false |
spacetelescope/jwql | spacetelescope | 361,370,620 | 153 | null | [
{
"action": "opened",
"author": "bourque",
"comment_id": null,
"datetime": 1537285732000,
"masked_author": "username_0",
"text": "We now have publicly-facing documentation on ReadtheDocs: https://jwql.readthedocs.io/en/latest/\r\n\r\nWe could add a `Docs` tab in the main navbar of the webapp to point to this. Perhaps also a pointer to it in the About page.",
"title": "Add documentation tab to web app",
"type": "issue"
},
{
"action": "created",
"author": "bourque",
"comment_id": 422447777,
"datetime": 1537285803000,
"masked_author": "username_0",
"text": "@username_1 This is a pretty simple issue and would be a good first introduction to contributing something to the web app, want to try it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bhilbert4",
"comment_id": 422451581,
"datetime": 1537286467000,
"masked_author": "username_1",
"text": "Sure!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "bourque",
"comment_id": null,
"datetime": 1541687412000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 367 | false | false | 367 | true |
Shopify/kubernetes-deploy | Shopify | 284,025,053 | 232 | {
"number": 232,
"repo": "kubernetes-deploy",
"user_login": "Shopify"
} | [
{
"action": "opened",
"author": "KnVerey",
"comment_id": null,
"datetime": 1513896079000,
"masked_author": "username_0",
"text": "@Shopify/cloudplatform @Shopify/redis-memcached @username_3 @kirs \r\n\r\n## What this does\r\n\r\nThis PR makes it possible to add a `kubernetes-deploy.shopify.io/timeout-override-seconds` annotation to any individual resource. If that annotation is present and valid, its value will be used in place of the global hard timeout for that resource type.\r\n\r\nI think this is a reasonable feature even though it may let people shoot themselves/Shipit in the foot with reeeeeaaaaaly long timeouts because:\r\n- We've tinkered with the global timeout on Deployment in the past just for core.\r\n- #225 requested a timeout override for StatefulSets (and the same thing was raised internally for kafka)\r\n- #231 is asking to bump the timout for Redis because of a single instance.\r\n- This gem is open-source, and different organizations may be using it in very different contexts and for deploying very different things.\r\n\r\n\r\n## Alternatives\r\n\r\n* The various pod controllers are the main use case for this override (even Redis is actually watching a deployment), and for those using something like ProgressDeadlineSeconds (which only exists on Deployment) would be ideal. I've seen issues in k8s core about bringing all the workload controllers in line with each other before v1, so presumably this will be an option eventually. But last I checked StatefulSets (for example) still don't have a Progressing condition on k8s core master.\r\n* Make Redis use ProgressDeadlineSeconds (since as mentioned above it is watching a Deployment), and set that value really high on the offending deployment. This isn't crazy... in fact the Redis controller should probably use that strategy when we switch to controller-reported statuses for CRs.\r\n* Implement ProgressDeadlineSeconds-like behaviour for StatefulSets (and possibly other pod controller classes) client-side. I'm hesitant to do this since it would not be straightforward, and the feature is eventually coming upstream (where it belongs).",
"title": "Enable per-resource timeout customization via an annotation",
"type": "issue"
},
{
"action": "created",
"author": "devonboyer",
"comment_id": 353480685,
"datetime": 1513897822000,
"masked_author": "username_1",
"text": "@kwestein Once this PR ships we will be able to fix the timeout problems you are having.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "katdrobnjakovic",
"comment_id": 353615442,
"datetime": 1513955209000,
"masked_author": "username_2",
"text": "Is this something that is happening soon? I'm okay with shipping this (as I understand it it will be useful for others as well) and adding the annotations to quickly fix the few apps we have seen have problems with their deployments timing out and then refactor to the ProgressDeadlineSeconds strategy. \r\n\r\nOn our side, we are not in a rush to ship this today as everyone is on holiday and we have a workaround in place if those apps do need to deploy over the break.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "KnVerey",
"comment_id": 353646065,
"datetime": 1513965143000,
"masked_author": "username_0",
"text": "Thanks for letting me know 👍",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "psycotica0-shopify",
"comment_id": 353660108,
"datetime": 1513970483000,
"masked_author": "username_3",
"text": "It should be possible to write a test like\r\n- Construct resource, set `deploy_started_at` to 6 minutes ago, validate that `dummy.deploy_timed_out?` is true.\r\n- Construct a resource with a custom timeout of 10m, set `deploy_started_at` to 6 minutes ago, validate that `dummy.deploy_timed_out?` is false.\r\n\r\nUnless that's too Integrationy for the unit tests.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "KnVerey",
"comment_id": 353707817,
"datetime": 1514006121000,
"masked_author": "username_0",
"text": "Updated to use ISO8601 durations* and add more tests.\r\n\r\n\\* These are neat and powerful and standard, and it's great to get the parser for free, but I felt like the intuitive \"1s/m/h\" should also work without the \"PT\" prefix, and that being case-sensitive would be annoying. So I wrapped the parser in a custom one with those features. LMK what you think.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "psycotica0-shopify",
"comment_id": 354845680,
"datetime": 1514919110000,
"masked_author": "username_3",
"text": "(These tests seem great, by the way!)",
"title": null,
"type": "comment"
}
] | 4 | 7 | 3,305 | false | false | 3,305 | true |
ehcache/ehcache3 | ehcache | 263,825,693 | 2,157 | {
"number": 2157,
"repo": "ehcache3",
"user_login": "ehcache"
} | [
{
"action": "opened",
"author": "ljacomet",
"comment_id": null,
"datetime": 1507539756000,
"masked_author": "username_0",
"text": "* Add static method for converting a java.time.Duration into an Ehcache\r\nDuration\r\n* Add methods on the Expirations utility taking java.time.Duration\r\nparameters",
"title": "Fix #2068 Add support for java.time.Duration",
"type": "issue"
},
{
"action": "created",
"author": "ljacomet",
"comment_id": 344301464,
"datetime": 1510674528000,
"masked_author": "username_0",
"text": "This will not get merged, going with the approach in #2166",
"title": null,
"type": "comment"
}
] | 1 | 2 | 219 | false | false | 219 | false |
rapidcore/rapidcore | rapidcore | 433,173,010 | 114 | null | [
{
"action": "opened",
"author": "IceAndSnow",
"comment_id": null,
"datetime": 1555319265000,
"masked_author": "username_0",
"text": "",
"title": "Upgrade to .NET Standard 2.0",
"type": "issue"
},
{
"action": "closed",
"author": "nover",
"comment_id": null,
"datetime": 1556701177000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 0 | false | false | 0 | false |
ropensci/rorcid | ropensci | 303,072,017 | 46 | null | [
{
"action": "opened",
"author": "jofazepa",
"comment_id": null,
"datetime": 1520424198000,
"masked_author": "username_0",
"text": "```",
"title": "Error using multiple ORCID ID's",
"type": "issue"
},
{
"action": "created",
"author": "sckott",
"comment_id": 371227901,
"datetime": 1520445789000,
"masked_author": "username_1",
"text": "thanks for the issue @username_0 \r\n\r\ncan you share your `sessionInfo()` please",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jofazepa",
"comment_id": 371416166,
"datetime": 1520497809000,
"masked_author": "username_0",
"text": "R version 3.4.3 (2017-11-30)\r\nPlatform: x86_64-w64-mingw32/x64 (64-bit)\r\nRunning under: Windows >= 8 x64 (build 9200)\r\n\r\nMatrix products: default\r\n\r\nlocale:\r\n[1] LC_COLLATE=Portuguese_Portugal.1252 LC_CTYPE=Portuguese_Portugal.1252 LC_MONETARY=Portuguese_Portugal.1252 LC_NUMERIC=C \r\n[5] LC_TIME=Portuguese_Portugal.1252 \r\n\r\nattached base packages:\r\n[1] stats graphics grDevices utils datasets methods base \r\n\r\nother attached packages:\r\n[1] rorcid_0.4.0\r\n\r\nloaded via a namespace (and not attached):\r\n[1] httr_1.3.1 compiler_3.4.3 R6_2.2.2 tools_3.4.3 curl_3.1 yaml_2.1.17 crul_0.5.2 jsonlite_1.5",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sckott",
"comment_id": 371529634,
"datetime": 1520524410000,
"masked_author": "username_1",
"text": "The new version of `rorcid` has some changes, one of which is `orcid_id` only accepts one ORCID.\r\n\r\nyou're looking for just getting the same ORCID id again from the result?\r\n\r\n```r\r\nids <- c(\"0000-0003-1620-1408\", \"0000-0002-9341-7985\")\r\nlapply(ids, function(x) names(orcid_id(x)))\r\n```",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jofazepa",
"comment_id": null,
"datetime": 1520525133000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "jofazepa",
"comment_id": 371533483,
"datetime": 1520525133000,
"masked_author": "username_0",
"text": "I used to get bulk publications/work for multiple ORCID Ids, using this:\r\n`x <- orcid_id(orcid = ids, profile = \"works\")`\r\nWhen I got the error I just run through the rORCID tutorial and found the code I pasted here. Also tried other ways, like\r\n`x <- lapply(orcid_id(orcid = ids), \"[[\", \"orcid-identifier\")`\r\nAnd the same error happens. I was looking for a way to do the same thing, because that is why I use rORCID for, getting info from a group of researchers, but I see that the new version or rOrcid is unable to do it.",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "jofazepa",
"comment_id": null,
"datetime": 1520525259000,
"masked_author": "username_0",
"text": "```",
"title": "Error using multiple ORCID ID's",
"type": "issue"
},
{
"action": "created",
"author": "sckott",
"comment_id": 371542498,
"datetime": 1520526798000,
"masked_author": "username_1",
"text": "it is able to do that if you slightly change your code. \r\n\r\nthis in the new verison\r\n\r\n```r\r\nids <- c(\"0000-0003-1620-1408\", \"0000-0002-9341-7985\")\r\nlapply(ids, function(x) names(orcid_id(x)))\r\n```\r\n\r\ndoes exactly what this did in the old version\r\n\r\n```r\r\nids <- c(\"0000-0003-1620-1408\", \"0000-0002-9341-7985\")\r\nlapply(orcid_id(orcid = ids), \"[[\", \"orcid-identifier\")\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jofazepa",
"comment_id": 371553417,
"datetime": 1520528754000,
"masked_author": "username_0",
"text": "This means that if I change \"names\" for \"works\" I get the works from them, like this:\r\n`x <- lapply(ids, function(x) works(orcid_id(x)))`\r\nTherefore just needing to change the list to a data.frame to be able to have an organized publications list for a set of orcid.ids.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sckott",
"comment_id": 371570035,
"datetime": 1520531936000,
"masked_author": "username_1",
"text": "right, the eg. I gave with `names()` was to just get exactly what your example code was doing. right, so just lapply or similar over your ORCID's",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jofazepa",
"comment_id": 371754486,
"datetime": 1520586277000,
"masked_author": "username_0",
"text": "Thanks username_1.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "jofazepa",
"comment_id": null,
"datetime": 1520586279000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 12 | 2,361 | false | false | 2,361 | true |
AnalyticalGraphicsInc/cesium | AnalyticalGraphicsInc | 307,107,324 | 6,355 | {
"number": 6355,
"repo": "cesium",
"user_login": "AnalyticalGraphicsInc"
} | [
{
"action": "opened",
"author": "srwiseman",
"comment_id": null,
"datetime": 1521601866000,
"masked_author": "username_0",
"text": "@username_1, as discussed, I added a test for #6305.\r\n\r\nBasically, I copied the \"computes bounding sphere\" test, but I changed it to give it a bad model uri. The test then expects the bounding sphere state to resolve to FAILED, which it does due to the fix in #6305.\r\n\r\nLet me know if this works!",
"title": "Added a test for PR 6305",
"type": "issue"
},
{
"action": "created",
"author": "lilleyse",
"comment_id": 374996820,
"datetime": 1521648535000,
"masked_author": "username_1",
"text": "Thanks @username_0",
"title": null,
"type": "comment"
}
] | 2 | 2 | 311 | false | false | 311 | true |
pingcap/tidb | pingcap | 339,038,575 | 7,007 | null | [
{
"action": "opened",
"author": "xinwu5",
"comment_id": null,
"datetime": 1530902962000,
"masked_author": "username_0",
"text": "Please answer these questions before submitting your issue. Thanks!\r\n\r\n1. What did you do?\r\n```\r\nmysql> create user test5@'100.%' identified by '';\r\nQuery OK, 1 row affected (0.01 sec)\r\n\r\nmysql> grant select on test.* to test5@'100.%';\r\nQuery OK, 0 rows affected (0.01 sec)\r\n\r\nmysql> select user from mysql.user where user ='test5';\r\n+-------+\r\n| user |\r\n+-------+\r\n| test5 |\r\n+-------+\r\n1 row in set (0.01 sec)\r\n\r\nmysql> show grants for test5@'100.%';\r\n+-------------------------------------------+\r\n| Grants for test5@100.% |\r\n+-------------------------------------------+\r\n| GRANT Select ON test.* TO 'test5'@'100.%' |\r\n+-------------------------------------------+\r\n1 row in set (0.00 sec)\r\n\r\n**---- Everything is good until now.**\r\n\r\nmysql> drop user test5@'100.%';\r\nQuery OK, 0 rows affected (0.01 sec)\r\n\r\nmysql> show grants for test5@'100.%';\r\n+-------------------------------------------+\r\n| Grants for test5@100.% |\r\n+-------------------------------------------+\r\n| GRANT Select ON test.* TO 'test5'@'100.%' |\r\n+-------------------------------------------+\r\n1 row in set (0.00 sec)\r\n\r\nmysql> select user from mysql.user where user ='test5';\r\nEmpty set (0.01 sec)\r\n\r\nmysql> flush privileges;\r\nQuery OK, 0 rows affected (0.14 sec)\r\n\r\nmysql> select user from mysql.user where user ='test5';\r\nEmpty set (0.01 sec)\r\n\r\nmysql> show grants for test5@'100.%';\r\n+-------------------------------------------+\r\n| Grants for test5@100.% |\r\n+-------------------------------------------+\r\n| GRANT Select ON test.* TO 'test5'@'100.%' |\r\n+-------------------------------------------+\r\n1 row in set (0.00 sec)\r\n```\r\n\r\n2. What did you expect to see?\r\n\r\nAfter the user has been dropped, `show grants for test5@'100.%';` should return empty.\r\n\r\n3. What did you see instead?\r\n```\r\nmysql> show grants for test5@'100.%';\r\n+-------------------------------------------+\r\n| Grants for test5@100.% |\r\n+-------------------------------------------+\r\n| GRANT Select ON test.* TO 'test5'@'100.%' |\r\n+-------------------------------------------+\r\n```\r\n4. What version of TiDB are you using (`tidb-server -V` or run `select tidb_version();` on TiDB)?\r\n```\r\nmysql> select tidb_version()\\G\r\n*************************** 1. row ***************************\r\ntidb_version(): Release Version: v2.0.4-15-g14552af\r\nGit Commit Hash: 14552afb4228c87f746c884c1548abc3eea4035e\r\nGit Branch: release-2.0\r\nUTC Build Time: 2018-07-04 11:56:13\r\nGoVersion: go version go1.10.2 linux/amd64\r\nTiKV Min Version: 2.0.0-rc.4.1\r\n1 row in set (0.00 sec)\r\n```",
"title": "Show grants still keep result after user has been dropped",
"type": "issue"
},
{
"action": "created",
"author": "shenli",
"comment_id": 403118224,
"datetime": 1530903139000,
"masked_author": "username_1",
"text": "@username_0 Thanks for your report!\r\nCould you try `flush privileges`? Please refer to https://github.com/pingcap/docs/blob/master/sql/privilege.md#time-of-effect",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xinwu5",
"comment_id": 403120431,
"datetime": 1530903709000,
"masked_author": "username_0",
"text": "In my original post, `flush privileges` is one of the action I have done. \r\nAs the doc says the time period is 5m, the following output is after 20m with the flush privileges.\r\n```\r\nmysql> show grants for test5@'100.%';\r\n+-------------------------------------------+\r\n| Grants for test5@100.% |\r\n+-------------------------------------------+\r\n| GRANT Select ON test.* TO 'test5'@'100.%' |\r\n+-------------------------------------------+\r\n1 row in set (0.00 sec)\r\n\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zz-jason",
"comment_id": 403177128,
"datetime": 1530924445000,
"masked_author": "username_2",
"text": "@username_3 PTAL",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tiancaiamao",
"comment_id": 403291930,
"datetime": 1531060485000,
"masked_author": "username_3",
"text": "I believe @zhexuany have handled this before. \r\nSee https://github.com/pingcap/tidb/pull/6624\r\nIt's not in the release-2.0 branch, should we cherry pick @username_1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "shenli",
"comment_id": 403338171,
"datetime": 1531101415000,
"masked_author": "username_1",
"text": "@zhexuany Please cherry-pick it to the release-2.0 branch.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "wwar",
"comment_id": 612103736,
"datetime": 1586535499000,
"masked_author": "username_4",
"text": "Confirming that this bug can be closed / TiDB behavior is identical to MySQL:\r\n\r\n```\r\nCREATE USER u1;\r\nGRANT SELECT ON test.* TO u1;\r\nSELECT * FROM mysql.user WHERE user = 'u1';\r\nSHOW GRANTS FOR u1;\r\nDROP USER u1;\r\nSHOW GRANTS FOR u1;\r\nSELECT * FROM mysql.user WHERE user = 'u1';\r\nFLUSH PRIVILEGES;\r\nSELECT * FROM mysql.user WHERE user = 'u1';\r\nSHOW GRANTS FOR u1;\r\n\r\n\r\nmysql [localhost:8019] {root} ((none)) > CREATE USER u1;\r\nQuery OK, 0 rows affected (0.00 sec)\r\n\r\nmysql [localhost:8019] {root} ((none)) > GRANT SELECT ON test.* TO u1;\r\nQuery OK, 0 rows affected (0.01 sec)\r\n\r\nmysql [localhost:8019] {root} ((none)) > SELECT * FROM mysql.user WHERE user = 'u1';\r\n+------+------+-------------+-------------+-------------+-------------+-------------+-----------+-------------+---------------+--------------+-----------+------------+-----------------+------------+------------+--------------+------------+-----------------------+------------------+--------------+-----------------+------------------+------------------+----------------+---------------------+--------------------+------------------+------------+--------------+------------------------+----------+------------------------+--------------------------+----------------------------+---------------+-------------+-----------------+----------------------+-----------------------+-----------------------+------------------+-----------------------+-------------------+----------------+------------------+----------------+------------------------+---------------------+--------------------------+-----------------+\r\n| Host | User | Select_priv | Insert_priv | Update_priv | Delete_priv | Create_priv | Drop_priv | Reload_priv | Shutdown_priv | Process_priv | File_priv | Grant_priv | References_priv | Index_priv | Alter_priv | Show_db_priv | Super_priv | Create_tmp_table_priv | Lock_tables_priv | Execute_priv | Repl_slave_priv | Repl_client_priv | Create_view_priv | Show_view_priv | Create_routine_priv | Alter_routine_priv | Create_user_priv | Event_priv | Trigger_priv | Create_tablespace_priv | ssl_type | ssl_cipher | x509_issuer | x509_subject | max_questions | max_updates | max_connections | max_user_connections | plugin | authentication_string | password_expired | password_last_changed | password_lifetime | account_locked | Create_role_priv | Drop_role_priv | Password_reuse_history | Password_reuse_time | Password_require_current | User_attributes |\r\n+------+------+-------------+-------------+-------------+-------------+-------------+-----------+-------------+---------------+--------------+-----------+------------+-----------------+------------+------------+--------------+------------+-----------------------+------------------+--------------+-----------------+------------------+------------------+----------------+---------------------+--------------------+------------------+------------+--------------+------------------------+----------+------------------------+--------------------------+----------------------------+---------------+-------------+-----------------+----------------------+-----------------------+-----------------------+------------------+-----------------------+-------------------+----------------+------------------+----------------+------------------------+---------------------+--------------------------+-----------------+\r\n| % | u1 | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | | 0x | 0x | 0x | 0 | 0 | 0 | 0 | caching_sha2_password | | N | 2020-04-10 10:16:01 | NULL | N | N | N | NULL | NULL | NULL | NULL |\r\n+------+------+-------------+-------------+-------------+-------------+-------------+-----------+-------------+---------------+--------------+-----------+------------+-----------------+------------+------------+--------------+------------+-----------------------+------------------+--------------+-----------------+------------------+------------------+----------------+---------------------+--------------------+------------------+------------+--------------+------------------------+----------+------------------------+--------------------------+----------------------------+---------------+-------------+-----------------+----------------------+-----------------------+-----------------------+------------------+-----------------------+-------------------+----------------+------------------+----------------+------------------------+---------------------+--------------------------+-----------------+\r\n1 row in set (0.00 sec)\r\n\r\nmysql [localhost:8019] {root} ((none)) > SHOW GRANTS FOR u1;\r\n+--------------------------------------+\r\n| Grants for u1@% |\r\n+--------------------------------------+\r\n| GRANT USAGE ON *.* TO `u1`@`%` |\r\n| GRANT SELECT ON `test`.* TO `u1`@`%` |\r\n+--------------------------------------+\r\n2 rows in set (0.00 sec)\r\n\r\nmysql [localhost:8019] {root} ((none)) > DROP USER u1;\r\nQuery OK, 0 rows affected (0.01 sec)\r\n\r\nmysql [localhost:8019] {root} ((none)) > SHOW GRANTS FOR u1;\r\nERROR 1141 (42000): There is no such grant defined for user 'u1' on host '%'\r\nmysql [localhost:8019] {root} ((none)) > SELECT * FROM mysql.user WHERE user = 'u1';\r\nEmpty set (0.00 sec)\r\n\r\nmysql [localhost:8019] {root} ((none)) > FLUSH PRIVILEGES;\r\nQuery OK, 0 rows affected (0.00 sec)\r\n\r\nmysql [localhost:8019] {root} ((none)) > SELECT * FROM mysql.user WHERE user = 'u1';\r\nEmpty set (0.00 sec)\r\n\r\nmysql [localhost:8019] {root} ((none)) > SHOW GRANTS FOR u1;\r\nERROR 1141 (42000): There is no such grant defined for user 'u1' on host '%'\r\n\r\n..\r\n\r\ntidb> CREATE USER u1;\r\nQuery OK, 0 rows affected (0.02 sec)\r\n\r\ntidb> GRANT SELECT ON test.* TO u1;\r\nQuery OK, 0 rows affected (0.01 sec)\r\n\r\ntidb> SELECT * FROM mysql.user WHERE user = 'u1';\r\n+------+------+-----------------------+-------------+-------------+-------------+-------------+-------------+-----------+--------------+------------+-----------------+------------+--------------+------------+-----------------------+------------------+--------------+------------------+----------------+---------------------+--------------------+------------+------------------+------------+--------------+------------------+----------------+----------------+---------------+-------------+-----------+\r\n| Host | User | authentication_string | Select_priv | Insert_priv | Update_priv | Delete_priv | Create_priv | Drop_priv | Process_priv | Grant_priv | References_priv | Alter_priv | Show_db_priv | Super_priv | Create_tmp_table_priv | Lock_tables_priv | Execute_priv | Create_view_priv | Show_view_priv | Create_routine_priv | Alter_routine_priv | Index_priv | Create_user_priv | Event_priv | Trigger_priv | Create_role_priv | Drop_role_priv | Account_locked | Shutdown_priv | Reload_priv | FILE_priv |\r\n+------+------+-----------------------+-------------+-------------+-------------+-------------+-------------+-----------+--------------+------------+-----------------+------------+--------------+------------+-----------------------+------------------+--------------+------------------+----------------+---------------------+--------------------+------------+------------------+------------+--------------+------------------+----------------+----------------+---------------+-------------+-----------+\r\n| % | u1 | | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N | N |\r\n+------+------+-----------------------+-------------+-------------+-------------+-------------+-------------+-----------+--------------+------------+-----------------+------------+--------------+------------+-----------------------+------------------+--------------+------------------+----------------+---------------------+--------------------+------------+------------------+------------+--------------+------------------+----------------+----------------+---------------+-------------+-----------+\r\n1 row in set (0.00 sec)\r\n\r\ntidb> SHOW GRANTS FOR u1;\r\n+------------------------------------+\r\n| Grants for u1@% |\r\n+------------------------------------+\r\n| GRANT USAGE ON *.* TO 'u1'@'%' |\r\n| GRANT Select ON test.* TO 'u1'@'%' |\r\n+------------------------------------+\r\n2 rows in set (0.00 sec)\r\n\r\ntidb> DROP USER u1;\r\nQuery OK, 0 rows affected (0.02 sec)\r\n\r\ntidb> SHOW GRANTS FOR u1;\r\nERROR 1141 (42000): There is no such grant defined for user 'u1' on host '%'\r\ntidb> SELECT * FROM mysql.user WHERE user = 'u1';\r\nEmpty set (0.00 sec)\r\n\r\ntidb> FLUSH PRIVILEGES;\r\nQuery OK, 0 rows affected (0.00 sec)\r\n\r\ntidb> SELECT * FROM mysql.user WHERE user = 'u1';\r\nEmpty set (0.00 sec)\r\n\r\ntidb> SHOW GRANTS FOR u1;\r\nERROR 1141 (42000): There is no such grant defined for user 'u1' on host '%'\r\ntidb> SELECT tidb_version()\\G\r\n*************************** 1. row ***************************\r\ntidb_version(): Release Version: v4.0.0-beta.2-183-g57db6cec7\r\nGit Commit Hash: 57db6cec7ffad78e74b6ac6c67a2bfe9a6718d17\r\nGit Branch: master\r\nUTC Build Time: 2020-04-04 08:06:18\r\nGoVersion: go1.13\r\nRace Enabled: false\r\nTiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306\r\nCheck Table Before Drop: false\r\n1 row in set (0.00 sec)\r\n\r\n\r\n```",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "zz-jason",
"comment_id": null,
"datetime": 1586597181000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "zz-jason",
"comment_id": 612376930,
"datetime": 1586597181000,
"masked_author": "username_2",
"text": "thank you @username_4, I'm going to close this issue now.",
"title": null,
"type": "comment"
}
] | 5 | 9 | 13,740 | false | false | 13,740 | true |
MicrosoftDocs/live-share | MicrosoftDocs | 355,815,930 | 895 | null | [
{
"action": "opened",
"author": "Aceix",
"comment_id": null,
"datetime": 1535681927000,
"masked_author": "username_0",
"text": "<!-- \r\nFor Visual Studio problems/feedback, please use the \"Report a Problem...\" feature built into the tool. See https://aka.ms/vsls-vsproblem.\r\n\r\nFor VS Code issues, attach verbose logs as follows:\r\n1. Press F1 (or Ctrl-Shift-P), type \"export logs\" and run the \"Live Share: Export Logs\" command.\r\n2. Drag and drop the zip to the issue on this screen and wait for it to upload before creating the issue.\r\n\r\nFor feature requests, please include enough of this same info so we know if the request is tool or language/platform specific.\r\n-->\r\n\r\n## Error:\r\nThe SSL connection could not be established, see inner exception.\r\n[vsls-logs.zip](https://github.com/MicrosoftDocs/live-share/files/2338531/vsls-logs.zip)\r\n\r\n## Steps to Reproduce:\r\n1. Click on VS Live Share icon on the left pane\r\n2. Choose \"Start collaboration session\"\r\n3. Login in browser and copy code\r\n4. Paste code in VS and hit enter\r\n\r\n...error happens when trying to login\r\n\r\n||Version Data|\r\n|-:|:-|\r\n|**extensionName**|VSLS|\r\n|**extensionVersion**|0.3.577|\r\n|**protocolVersion**|2.2|\r\n|**applicationName**|VSCode|\r\n|**applicationVersion**|1.25.1|\r\n|**platformName**|Linux|\r\n|**platformVersion**|4.15.0-32-generic|",
"title": "[VS Code] The SSL connection could not be established, see inner exception.",
"type": "issue"
},
{
"action": "created",
"author": "Priya91",
"comment_id": 418909666,
"datetime": 1536188743000,
"masked_author": "username_1",
"text": "@username_0 Looks like the ssh connection failed, because the remote detected you are not using right certificates.. Can you do a ```sudo update-ca-certificates``` to sync the openssl cert store with the linux OS cert store, this will fix issues with outdated entries.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 1,442 | false | false | 1,442 | true |
pinterest/elixometer | pinterest | 463,373,345 | 130 | {
"number": 130,
"repo": "elixometer",
"user_login": "pinterest"
} | [
{
"action": "opened",
"author": "jparise",
"comment_id": null,
"datetime": 1562092027000,
"masked_author": "username_0",
"text": "exometer_core already requires setup 2.0.2, so the version requirement\r\nis covered, and this version of setup appears to build correctly under\r\nboth :rebar and :rebar3, so we can remove the manager specifier, too.",
"title": "Remove the explicit dependency on :setup",
"type": "issue"
},
{
"action": "created",
"author": "fishcakez",
"comment_id": 507821176,
"datetime": 1562097184000,
"masked_author": "username_1",
"text": "Removing manager means we are unblocked from a release :O",
"title": null,
"type": "comment"
}
] | 2 | 2 | 270 | false | false | 270 | false |
rust-lang-nursery/failure | rust-lang-nursery | 328,530,224 | 210 | {
"number": 210,
"repo": "failure",
"user_login": "rust-lang-nursery"
} | [
{
"action": "opened",
"author": "the-kenny",
"comment_id": null,
"datetime": 1527861413000,
"masked_author": "username_0",
"text": "",
"title": "Fix TravisCI badge in README.md",
"type": "issue"
},
{
"action": "created",
"author": "withoutboats",
"comment_id": 395196405,
"datetime": 1528315559000,
"masked_author": "username_1",
"text": "Thanks for noticing this :)",
"title": null,
"type": "comment"
}
] | 2 | 2 | 27 | false | false | 27 | false |
elm/json | elm | 364,127,431 | 6 | null | [
{
"action": "opened",
"author": "jonathanjouty",
"comment_id": null,
"datetime": 1537981650000,
"masked_author": "username_0",
"text": "See https://github.com/elm/json/blob/master/src/Json/Decode.elm#L37",
"title": "elm-decode-pipeline link is wrong",
"type": "issue"
},
{
"action": "closed",
"author": "evancz",
"comment_id": null,
"datetime": 1538323349000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 67 | false | false | 67 | false |
fabric8io/kubernetes-client | fabric8io | 410,000,680 | 1,357 | null | [
{
"action": "opened",
"author": "xguerin",
"comment_id": null,
"datetime": 1550091754000,
"masked_author": "username_0",
"text": "Hello there,\r\n\r\nWhile playing with the `KubernetesMockServer` I realized that, while creating and querying CRDs work (as do any other standard Kubernetes resources), creating and querying CRD-backed resources don't.\r\n\r\nIs that an expected behavior? If not, is there an example or a gotcha I need to be aware of?\r\n\r\nThanks,",
"title": "KubernetesMockServer and CRD-backed resources",
"type": "issue"
}
] | 2 | 3 | 519 | false | true | 322 | false |
mitreid-connect/OpenID-Connect-Java-Spring-Server | mitreid-connect | 395,209,562 | 1,443 | null | [
{
"action": "opened",
"author": "edmundday",
"comment_id": null,
"datetime": 1546426067000,
"masked_author": "username_0",
"text": "When I e.g. create a new client under 'Manage clients' it works OK, but once the server is stopped and restarted it has gone. Same for whitelisting. Can anyone point me in the right direction? Thanks.",
"title": "Server not saving administrative data",
"type": "issue"
},
{
"action": "created",
"author": "kabiliravi",
"comment_id": 450917137,
"datetime": 1546447776000,
"masked_author": "username_1",
"text": "@username_0 I guess you are running the app using the default database configurations which is pointing to an embedded HSQL database.\r\n\r\nLook at this file:\r\nhttps://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/blob/master/openid-connect-server-webapp/src/main/webapp/WEB-INF/data-context.xml\r\n\r\nComment following part and uncomment the mysql one.\r\n`\r\n\t<bean id=\"dataSource\" class=\"com.zaxxer.hikari.HikariDataSource\" destroy-method=\"close\">\r\n\t\t<property name=\"driverClassName\" value=\"org.hsqldb.jdbcDriver\" />\r\n\t\t<property name=\"jdbcUrl\" value=\"jdbc:hsqldb:mem:oic;sql.syntax_mys=true\" />\r\n<!-- \t\t<property name=\"jdbcUrl\" value=\"jdbc:hsqldb:file:/tmp/oic;sql.syntax_mys=true\" /> -->\r\n\t\t<property name=\"username\" value=\"oic\" />\r\n\t\t<property name=\"password\" value=\"oic\" />\r\n\t</bean>\r\n\r\n\t<!-- Use the following to set up the OIC tables in the in-memory DB\r\n \t\t If you are using a file based HSQLDB you should not run this every time. -->\r\n\t<jdbc:initialize-database data-source=\"dataSource\">\r\n\t\t<jdbc:script location=\"classpath:/db/hsql/hsql_database_tables.sql\"/>\r\n\t\t<!-- The following file is for the jdbc-user-service spring security implementation -->\r\n\t\t<jdbc:script location=\"classpath:/db/hsql/security-schema.sql\"/>\r\n\t\t<!-- The following files are for safely bootstrapping users and clients into the database -->\r\n\t\t<jdbc:script location=\"classpath:/db/hsql/loading_temp_tables.sql\"/>\r\n\t\t<jdbc:script location=\"classpath:/db/hsql/users.sql\"/>\r\n\t\t<jdbc:script location=\"classpath:/db/hsql/clients.sql\"/>\r\n\t\t<jdbc:script location=\"classpath:/db/hsql/scopes.sql\"/>\r\n\t</jdbc:initialize-database>\r\n\r\n\t<bean id=\"jpaAdapter\" class=\"org.springframework.orm.jpa.vendor.EclipseLinkJpaVendorAdapter\">\r\n \t\t<property name=\"databasePlatform\" value=\"org.eclipse.persistence.platform.database.HSQLPlatform\" />\r\n\t\t<property name=\"showSql\" value=\"true\" />\r\n\t</bean>\r\n`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "edmundday",
"comment_id": 450953992,
"datetime": 1546456043000,
"masked_author": "username_0",
"text": "Many thanks. Do I need to create the DB first time?\r\nIs there any documentation on this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kabiliravi",
"comment_id": 450969202,
"datetime": 1546459382000,
"masked_author": "username_1",
"text": "@username_0 Yes you need to create the DB. For mysql you should name it \"oic\" or change the JDBC url to match your db name and connection url. According to the current default conf it is **value=\"jdbc:mysql://127.0.0.1:3306/oic\"**\r\n\r\nAnd the following tag will run the scripts for you on the app initialization:\r\n\r\n\t<!-- You can optionally initialize the database with test values here, \r\n\t\tbut this is not recommended for real systems -->\r\n<!-- \t<jdbc:initialize-database data-source=\"dataSource\"> -->\r\n<!-- \t\t<jdbc:script location=\"classpath:/db/tables/mysql_database_tables.sql\"/> -->\r\n<!-- \t\t<jdbc:script location=\"classpath:/db/tables/security-schema.sql\"/> -->\r\n<!-- \t\t<jdbc:script location=\"classpath:/db/tables/loading_temp_tables.sql\"/> -->\r\n<!-- \t\t<jdbc:script location=\"classpath:/db/mysql/users.sql\"/> -->\r\n<!-- \t\t<jdbc:script location=\"classpath:/db/mysql/clients.sql\"/> -->\r\n<!-- \t\t<jdbc:script location=\"classpath:/db/mysql/scopes.sql\"/> -->\r\n<!-- \t</jdbc:initialize-database> -->\r\n\r\nHowever, you can keep the above tag commented and manually initialize database yourself. \r\nThe scripts are here for HSQL, MySQL, Oracle and PostgreSQL\r\n\r\nhttps://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/tree/master/openid-connect-server-webapp/src/main/resources/db",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "edmundday",
"comment_id": 451167172,
"datetime": 1546527410000,
"masked_author": "username_0",
"text": "Thanks! i have got some way with this but am stuck with Table 'oic.users' doesn't exist. Any idea what format this able should be? I cannot find it any of the scripts.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "edmundday",
"comment_id": 451189657,
"datetime": 1546531561000,
"masked_author": "username_0",
"text": "I just used the temp version. Now I have to figure out where to add logins to the server. I cannot login to it to do so because none are set up!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "edmundday",
"comment_id": 451190846,
"datetime": 1546531793000,
"masked_author": "username_0",
"text": "Looks like users.sql does that.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kabiliravi",
"comment_id": 451194083,
"datetime": 1546532405000,
"masked_author": "username_1",
"text": "@username_0 yes all scripts are in https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/tree/master/openid-connect-server-webapp/src/main/resources/db and security-schema.sql is for creating the users and authorities and users.sql for initiating some test data",
"title": null,
"type": "comment"
}
] | 2 | 8 | 4,063 | false | false | 4,063 | true |
microsoft/Azure-Kinect-Sensor-SDK | microsoft | 484,751,233 | 674 | null | [
{
"action": "opened",
"author": "opalmu",
"comment_id": null,
"datetime": 1566604146000,
"masked_author": "username_0",
"text": "**Describe the bug**\r\nI am trying to get the depth value of the points collected from the color image. After I **transformed depth image to color camera**, often the depth value of the point of interest is shown to be 0 and the point itself is not detected by Kinect Azure. Another answer #588 mentioned that there is some interpolation/filter method to compensate this issue. I am wondering how could I use those methods in the code?\r\n\r\n**To Reproduce**\r\n\r\n1. Get the color image and depth image.\r\n2. Transform depth image to color camera.\r\n3. Extract the depth value of the point of interest.\r\n4. The depth value is vibrating from its true value and 0. \r\n\r\n**Expected behavior**\r\nGet the true depth value of the specific point extracted from 2D color image.\r\n\r\n**Code appendix**\r\nTo help reproduce the error, I also append my code here:\r\n\r\n```\r\n// Copyright (c) Microsoft Corporation. All rights reserved.\r\n// Licensed under the MIT License.\r\n\r\n#include <iostream>\r\n#include <stdio.h>\r\n#include <stdlib.h>\r\n#include <k4a/k4a.h>\r\n#include <sys/types.h>\r\n#include <sys/stat.h>\r\n#include <direct.h>\r\n#include \"opencv2/imgproc/imgproc.hpp\"\r\n#include \"opencv2/opencv.hpp\"\r\n#include <opencv2/core/mat.hpp>\r\n#include <opencv2/core/core.hpp>\r\n#include <opencv2/highgui/highgui.hpp>\r\n#include <opencv2/calib3d.hpp>\r\n#include <math.h>\r\n#include <string>\r\n#include <fstream>\r\n#include <sstream>\r\n\r\nusing namespace cv;\r\nusing namespace std;\r\n\r\nint main()\r\n{\r\n\t// 1.1: Start by counting the number of connected devices\r\n\tuint32_t device_count = k4a_device_get_installed_count();\r\n\tif (device_count == 0)\r\n\t{\r\n\t\tprintf(\"No K4A devices found\\n\");\r\n\t\treturn 0;\r\n\t}\r\n\telse\r\n\t{\r\n\t\tprintf(\"Found %d connected devices:\\n\", device_count);\r\n\t}\r\n\r\n\t// 1.2: Define the Exit block\r\n\tint returnCode = 1;\r\n\r\n\t// 1.3 Initialize the the device and capture attributes\r\n\tk4a_device_t device = NULL;\r\n\tk4a_capture_t capture = NULL;\r\n\tconst int32_t TIMEOUT_IN_MS = 1000;\r\n\r\n\t// 1.4: Initialize the frame count\r\n\tint totalFrame = 1;\r\n\tint captureFrameCount = totalFrame;\r\n\tprintf(\"Capturing %d frames\\n\", captureFrameCount);\r\n\r\n\t// 2: Set the configuration of device, you can also set it after open the device but before starting the camera\r\n\tk4a_device_configuration_t config = K4A_DEVICE_CONFIG_INIT_DISABLE_ALL;\r\n\tconfig.color_format = K4A_IMAGE_FORMAT_COLOR_BGRA32; // <==== For Color image\r\n\tconfig.color_resolution = K4A_COLOR_RESOLUTION_2160P;\r\n\tconfig.depth_mode = K4A_DEPTH_MODE_NFOV_UNBINNED; // <==== For Depth image\r\n\tconfig.camera_fps = K4A_FRAMES_PER_SECOND_30;\r\n\tconfig.synchronized_images_only = true;\r\n\r\n\t// 3: Open the device\r\n\tif (K4A_RESULT_SUCCEEDED != k4a_device_open(K4A_DEVICE_DEFAULT, &device))\r\n\t{\r\n\t\tprintf(\"Failed to open device\\n\");\r\n\t\tgoto Exit;\r\n\t}\r\n\r\n\t// 3.2 Set the calibration \r\n\tk4a_calibration_t calibration;\r\n\tif (K4A_RESULT_SUCCEEDED !=\r\n\t\tk4a_device_get_calibration(device, config.depth_mode, config.color_resolution, &calibration))\r\n\t{\r\n\t\tprintf(\"Failed to get calibration\\n\");\r\n\t\tgoto Exit;\r\n\t}\r\n\r\n\t// 4: Start the camera\r\n\tif (K4A_RESULT_SUCCEEDED != k4a_device_start_cameras(device, &config))\r\n\t{\r\n\t\tprintf(\"Failed to start device\\n\");\r\n\t\tgoto Exit;\r\n\t}\r\n\r\n\t// 5: Start to receive the captures and frames\r\n\twhile (captureFrameCount-- > 0)\r\n\t{\r\n\t\t// Get a depth frame\r\n\t\tswitch (k4a_device_get_capture(device, &capture, TIMEOUT_IN_MS))\r\n\t\t{\r\n\t\tcase K4A_WAIT_RESULT_SUCCEEDED:\r\n\t\t\tbreak;\r\n\t\tcase K4A_WAIT_RESULT_TIMEOUT:\r\n\t\t\tprintf(\"Timed out waiting for a capture\\n\");\r\n\t\t\tcontinue;\r\n\t\t\tbreak;\r\n\t\tcase K4A_WAIT_RESULT_FAILED:\r\n\t\t\tprintf(\"Failed to read a capture\\n\");\r\n\t\t\tgoto Exit;\r\n\t\t}\r\n\t\tprintf(\"==================================\\n\");\r\n\t\tprintf(\"Capture %4d | \\n\", captureFrameCount);\r\n\r\n\r\n\t\t// 5.1 Probe for a color image\r\n\t\tk4a_image_t image_color = k4a_capture_get_color_image(capture);\r\n\t\tif (image_color != NULL)\r\n\t\t{\r\n\t\t\t// 5.2 Get the sizes of color image\r\n\t\t\tint width = k4a_image_get_width_pixels(image_color);\r\n\t\t\tint height = k4a_image_get_height_pixels(image_color);\r\n\t\t\tint strides = k4a_image_get_stride_bytes(image_color);\r\n\t\t\tprintf(\"Color image height, width and strides: %d, %d, %d\\n\", height, width, strides);\r\n\r\n\t\t\t// 5.3 Store the image using opencv Mat\r\n\t\t\tuint8_t* color_image_data = k4a_image_get_buffer(image_color);\r\n\t\t\tconst Mat color_image(height, width, CV_8UC4, (void*)color_image_data, Mat::AUTO_STEP);\r\n\r\n\t\t\t// 5.4 Display the color image\r\n\t\t\tnamedWindow(\"foobar\", WINDOW_AUTOSIZE);\r\n\t\t\timshow(\"foobar\", color_image);\r\n\t\t\twaitKey(1000);\r\n\r\n\t\t\t// 5.6 release the image\r\n\t\t\t// k4a_image_release(image_color);\r\n\t\t}\r\n\t\telse\r\n\t\t{\r\n\t\t\tprintf(\" | Color None \");\r\n\t\t}\r\n\r\n\t\t// 6.1 Probe for a depth16 image\r\n\t\tconst k4a_image_t image_depth = k4a_capture_get_depth_image(capture);\r\n\t\tif (image_depth != NULL)\r\n\t\t{\r\n\t\t\t// 6.2 Get the sizes of depth image\r\n\t\t\tint width = k4a_image_get_width_pixels(image_depth);\r\n\t\t\tint height = k4a_image_get_height_pixels(image_depth);\r\n\t\t\tint strides = k4a_image_get_stride_bytes(image_depth);\r\n\t\t\tprintf(\"Depth image height, width and strides: %d, %d, %d\\n\", height, width, strides);\r\n\r\n\t\t\t// 6.3 Store the image using opencv Mat\r\n\t\t\tuint16_t* depth_image_data = (uint16_t*)(void*)k4a_image_get_buffer(image_depth);\r\n\t\t\tconst Mat depth_image(height, width, CV_16U, (void*)depth_image_data, Mat::AUTO_STEP);\r\n\r\n\t\t\t// 6.4 Display the depth image\r\n\t\t\tnamedWindow(\"foobar\", WINDOW_AUTOSIZE);\r\n\t\t\timshow(\"foobar\", depth_image);\r\n\t\t\twaitKey(1000);\r\n\t\t}\r\n\t\telse\r\n\t\t{\r\n\t\t\tprintf(\" | Depth16 None\\n\");\r\n\t\t}\r\n\r\n\t\t// 7: Convert 2D points to 3D point cloud\r\n\t\tint width = k4a_image_get_width_pixels(image_color);\r\n\t\tint height = k4a_image_get_height_pixels(image_color);\r\n\r\n // Find the position of the center point in the image\r\n\t\tfloat point_row = (height / 2);\r\n\t\tfloat point_column = (width / 2);\r\n\r\n\t\tint point_row_coord = (height / 2);\r\n\t\tint point_column_coord = (width / 2);\r\n\r\n\t\t// 9.2 derive the depth value in the color camera geometry using the function k4a_transformation_depth_image_to_color_camera().\r\n\t\tk4a_transformation_t transformation = NULL;\r\n\t\tk4a_image_t transformed_depth_image = NULL;\r\n\r\n\t\tif (K4A_RESULT_SUCCEEDED != k4a_image_create(K4A_IMAGE_FORMAT_DEPTH16,\r\n\t\t\twidth,\r\n\t\t\theight,\r\n\t\t\twidth * (int)sizeof(uint16_t),\r\n\t\t\t&transformed_depth_image))\r\n\t\t{\r\n\t\t\tprintf(\"Failed to create transformed color image\\n\");\r\n\t\t\treturn false;\r\n\t\t}\r\n\t\telse\r\n\t\t{\t\r\n\t\t\t// Transform the depth image to the size of color camera\r\n\t\t\ttransformation = k4a_transformation_create(&calibration);\r\n\t\t\tk4a_transformation_depth_image_to_color_camera(transformation, image_depth, transformed_depth_image);\r\n\r\n\t\t\t// 9.3 Store the image using opencv Mat\r\n\t\t\tuint16_t* transformed_depth_image_data = (uint16_t*)(void*)k4a_image_get_buffer(transformed_depth_image);\r\n\t\t\tconst Mat trans_depth_image(height, width, CV_16U, (void*)transformed_depth_image_data, Mat::AUTO_STEP);\r\n\r\n\t\t\t// 9.4 Get the corresponding depth values of 2D point\r\n\t\t\tvector<float> depth_value(1, 0);\r\n\t\t\tprintf(\"print the depth value of the center point\\n\");\r\n\t\t\t// The next line should have the output of the depth value of the middle point in the 2D color image.\r\n\t\t\tcout << trans_depth_image.at<cv::int16_t>(point_column_coord, point_row_coord) << endl;\r\n\r\n\t\t\t// 9.5 Display the images\r\n\t\t\tnamedWindow(\"foobar\", WINDOW_AUTOSIZE);\r\n\t\t\timshow(\"foobar\", trans_depth_image);\r\n\t\t\twaitKey(1000);\r\n\t\t}\r\n\r\n\t\t// To be continued.... k4a_calibration_2d_to_3d(&calibration, depth_value, )\r\n\r\n\t\t// release images\r\n\t\tk4a_image_release(image_depth);\r\n\t\tk4a_image_release(image_color);\r\n\t\tk4a_image_release(transformed_depth_image);\r\n\r\n\t\t// release capture\r\n\t\tk4a_capture_release(capture);\r\n\t}\r\n\r\n\treturnCode = 0;\r\nExit:\r\n\tif (device != NULL)\r\n\t{\r\n\t\tk4a_device_stop_cameras(device);\r\n\t\tk4a_device_close(device);\r\n\t}\r\n\r\n\treturn returnCode;\r\n}\r\n```\r\nThe code here should generate 3 windows that display color image, depth image and the transformed depth image. Finally it will print out the depth value of the center point. \r\n\r\n**Screenshots**\r\nHere I append the depth image and the transformed image that I have collected. Original depth image:\r\n\r\nTransformed depth image:\r\n\r\n\r\n\r\n**Desktop (please complete the following information):**\r\n - OS with Version: Windows 10\r\n - SDK Version: v1.1.1 with Visual studio 2019\r\n - Firmware version: N/A\r\n\r\n**Additional context**\r\nThank you so much for your help!",
"title": "How to filter/interpolate the depth value that is converted to color camera? Depth pixel value shown as 0.",
"type": "issue"
},
{
"action": "created",
"author": "rabbitdaxi",
"comment_id": 526293497,
"datetime": 1567101205000,
"masked_author": "username_1",
"text": "@username_0 Thank you for the sharing and exercise for depth inpaint. The information you provided in this issue surely will help others too. Let us know if you have any other questions, if not, please close this issue :)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "opalmu",
"comment_id": null,
"datetime": 1567121796000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "abhijaysingh",
"comment_id": 582373425,
"datetime": 1580903678000,
"masked_author": "username_2",
"text": "Hi @username_0! Can you please tell me how you obtained the mask for the transformed depth image?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "abhijaysingh",
"comment_id": 582746402,
"datetime": 1580967671000,
"masked_author": "username_2",
"text": "Hi @username_0 ! Can you please help me with the mask generation for the transformed depth image? I haven't been able to replicate your result",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GHSch",
"comment_id": 729121052,
"datetime": 1605638050000,
"masked_author": "username_3",
"text": "@username_0 I am using your listing from above and I get the results below (with strips in transformed depth image).\r\nDoes someone know of that problem, may be it is related to my sensor?\r\n\r\n\r\n\r\nCould somebody help with this problem?\r\n\r\n Operating system: Windows 10 64-bit\r\n Azure-Kinect-Sensor-SDK: latest build from source\r\n Compiler version (if built from source): Visual Studio 2019\r\n Firmware: Loading firmware package AzureKinectDK_Fw_1.6.108079014.bin.\r\n File size: 1294306 bytes\r\n This package contains:\r\n RGB camera firmware: 1.6.108\r\n Depth camera firmware: 1.6.79\r\n Depth config files: 6109.7 5006.27\r\n Audio firmware: 1.6.14\r\n Build Config: Production\r\n Certificate Type: Microsoft\r\n Signature Type: Microsoft",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rabbitdaxi",
"comment_id": 729131073,
"datetime": 1605639173000,
"masked_author": "username_1",
"text": "@username_3 your striping issue may be related to #840 #294, hope it helps",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GHSch",
"comment_id": 729210460,
"datetime": 1605646779000,
"masked_author": "username_3",
"text": "Thank you a lot, that solved the problem.",
"title": null,
"type": "comment"
}
] | 4 | 8 | 10,460 | false | false | 10,460 | true |
kubernetes/release | kubernetes | 481,957,831 | 850 | null | [
{
"action": "opened",
"author": "justaugustus",
"comment_id": null,
"datetime": 1566107754000,
"masked_author": "username_0",
"text": "Please consider adding cryptographic digests for the [files released in this project][releases]. Commonly called SHA256SUMS files they can be easily generated using the common `sha256sum` tool on most systems\r\n\r\n```\r\nsha256sum * > SHA256SUMS\r\n```\r\n\r\nAlternatively, there [are some release automation tools][integrations] that can build these files automatically.\r\n\r\nBesides being a useful practice for download verification I would also like to use the SHA256SUMS as a way to ensure the releases aren't tampered with and track when they are modified. There is a [tool called rget][rget] that can do this if you provide SHA256SUMS for your releases.\r\n\r\nThe rget tool also has a subcommand to make it easy to create SHA256SUMS for existing releases, just run:\r\n\r\n```\r\nrget github publish-release-sums https://github.com/REPLACE_ORG/REPLACE_PROJ/releases/tag/v2.0\r\n```\r\n\r\nThanks!\r\n\r\n[releases]: https://github.com/REPLACE_ORG/REPLACE_PROJ/releases\r\n[integrations]: https://github.com/merklecounty/rget/blob/master/Documentation/integrations.md#release-automation\r\n[rget]: https://github.com/merklecounty/rget#rget\r\n\r\n/assign\r\n/cc @username_1 @kubernetes/sig-release-admins @kubernetes/release-engineering \r\n/milestone v1.16\r\n/priority important-longterm\r\n/kind feature",
"title": "Add Cryptographic Digests to GitHub Releases Body",
"type": "issue"
},
{
"action": "created",
"author": "justaugustus",
"comment_id": 522293735,
"datetime": 1566107820000,
"masked_author": "username_0",
"text": "Phase 0 of this work is here: https://github.com/kubernetes/release/pull/849",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "justaugustus",
"comment_id": 522298055,
"datetime": 1566112880000,
"masked_author": "username_0",
"text": "Original request from @username_1: https://github.com/kubernetes/kubernetes/issues/70132#issuecomment-518297891\r\n\r\nMailing list discussion: https://groups.google.com/d/msg/kubernetes-sig-release/R_-VwBk-JUo/-tQk-JzNAgAJ\r\n\r\ncc: @dims",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "justaugustus",
"comment_id": 523559675,
"datetime": 1566407812000,
"masked_author": "username_0",
"text": "Bookmark to notes from today's WG K8s Infra meeting: https://docs.google.com/document/d/16VBfsFMynA7tObzuZGPpw-sKDKfFc_T5W_E4IeEIaOQ/edit#bookmark=id.nrt4nqi4a038",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "philips",
"comment_id": 555630348,
"datetime": 1574186293000,
"masked_author": "username_1",
"text": "This can be closed. rget is going to execute on a design to support arbitrary URLs https://github.com/merklecounty/rget/issues/10#issuecomment-555630002\r\n\r\n/close",
"title": null,
"type": "comment"
}
] | 4 | 8 | 2,597 | false | true | 1,891 | true |
thesofproject/sof | thesofproject | 399,230,466 | 839 | {
"number": 839,
"repo": "sof",
"user_login": "thesofproject"
} | [
{
"action": "opened",
"author": "zhuyingjiang",
"comment_id": null,
"datetime": 1547539957000,
"masked_author": "username_0",
"text": "separate the PR for rt5682 and nocodec.",
"title": "Topic/add cnl nocodec tplg",
"type": "issue"
},
{
"action": "created",
"author": "lgirdwood",
"comment_id": 454328936,
"datetime": 1547545460000,
"masked_author": "username_1",
"text": "@username_0 sorry not following, is this PR for the same files as https://github.com/thesofproject/sof/pull/834 ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zhuyingjiang",
"comment_id": 454333798,
"datetime": 1547546357000,
"masked_author": "username_0",
"text": "No, #834 is for rt5682 on CNL/WHL/CML, and this one is for cnl nocodec.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ranj063",
"comment_id": 454487512,
"datetime": 1547574848000,
"masked_author": "username_2",
"text": "@username_0 the commit message makes no sense \r\n\"CommetLake(CML) and Whiskeylake(WHL) are CannonLake\" \r\nYou need to make it clear that they have the same audio IP.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "plbossart",
"comment_id": 454528919,
"datetime": 1547582150000,
"masked_author": "username_3",
"text": "The IP has more capability than the SOC, and the board add further \nrestrictions. For a nocodec board I agree we should expose everything \nthe IP can deal with, even if it means some of the pins may not be \nvisible due to pin-muxing. For an actual device we should stick to what \nis actually usable, i.e. model the topology on board limitations.\n\nAlso you can't necessarily use the same topology for the same IP, e.g. \nfor APL and SKL there are fundamental differences in memory layout which \nlimit what can be done with internal memory only or conversely can't be \nscaled beyond the internal memory.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zhuyingjiang",
"comment_id": 455115027,
"datetime": 1547719603000,
"masked_author": "username_0",
"text": "@username_1 @username_2 @bardliao",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zhuyingjiang",
"comment_id": 456654765,
"datetime": 1548213690000,
"masked_author": "username_0",
"text": "@username_1",
"title": null,
"type": "comment"
}
] | 4 | 7 | 1,030 | false | false | 1,030 | true |
PowerShell/PowerShell-Docs | PowerShell | 393,278,475 | 3,460 | {
"number": 3460,
"repo": "PowerShell-Docs",
"user_login": "PowerShell"
} | [
{
"action": "opened",
"author": "lukexjeremy",
"comment_id": null,
"datetime": 1545356356000,
"masked_author": "username_0",
"text": "Fixes issue #3457. \r\n\r\nVersion(s) of document impacted\r\n------------------------------\r\n- [x] Impacts 6.next document\r\n- [ ] Impacts 6 document\r\n- [ ] Impacts 5.1 document\r\n- [ ] Impacts 5.0 document\r\n- [ ] Impacts 4.0 document\r\n- [ ] Impacts 3.0 document\r\n\r\n<!--\r\nIf the PR is fixing only a subset of document version(s), please explain why by picking appropriate items in the list below\r\nIf the PR is fixing all the document version(s), please delete the list/options below\r\n-->\r\nReason(s) for not updating all version of documents\r\n--------------------------------------------------\r\n- [x] The documented feature was introduced in version (list version here) of PowerShell\r\n- [ ] This issue only shows up in version (list version(s) here) of the document\r\n- [ ] This PR partially fixes the issue, and issue #<insert here> tracks the remaining work",
"title": "Document `UseMinimalHeader` switch on `Start-Transcript`",
"type": "issue"
},
{
"action": "created",
"author": "sdwheeler",
"comment_id": 449398789,
"datetime": 1545401598000,
"masked_author": "username_1",
"text": "Waiting on PowerShell/PowerShell#8402 to be merged.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lukexjeremy",
"comment_id": 449516921,
"datetime": 1545432318000,
"masked_author": "username_0",
"text": "It's merged now 😄",
"title": null,
"type": "comment"
}
] | 2 | 3 | 918 | false | false | 918 | false |
apple/swift | apple | 479,485,323 | 26,610 | {
"number": 26610,
"repo": "swift",
"user_login": "apple"
} | [
{
"action": "opened",
"author": "dcci",
"comment_id": null,
"datetime": 1565591218000,
"masked_author": "username_0",
"text": "<!-- What's in this pull request? -->\r\nReplace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\nResolves [SR-NNNN](https://bugs.swift.org/browse/SR-NNNN).\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->",
"title": "[WIP] Fix LLDB.framework install path in build-script.",
"type": "issue"
},
{
"action": "created",
"author": "dcci",
"comment_id": 520310837,
"datetime": 1565591279000,
"masked_author": "username_0",
"text": "@swift-ci please build toolchain",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dcci",
"comment_id": 520477572,
"datetime": 1565624316000,
"masked_author": "username_0",
"text": "@swift-ci test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dcci",
"comment_id": 520580199,
"datetime": 1565641358000,
"masked_author": "username_0",
"text": "I tested this locally with the produced toolchain and it works, so I'm going to merge it. I'm going to add an integration test next.",
"title": null,
"type": "comment"
}
] | 2 | 6 | 1,426 | false | true | 800 | false |
doctrine/coding-standard | doctrine | 362,915,829 | 89 | {
"number": 89,
"repo": "coding-standard",
"user_login": "doctrine"
} | [
{
"action": "opened",
"author": "Majkl578",
"comment_id": null,
"datetime": 1537681339000,
"masked_author": "username_0",
"text": "",
"title": "Enable OptimizedFunctionsWithoutUnpacking sniff",
"type": "issue"
},
{
"action": "created",
"author": "Majkl578",
"comment_id": 423800816,
"datetime": 1537691901000,
"masked_author": "username_0",
"text": "Any form of unpacking kills the optimization. sprintf() is not on [the list](https://github.com/php/php-src/blob/php-7.3.0RC1/Zend/zend_compile.c#L3912-L3971) so it's not affected. Your example is a candidate for vsprintf(). :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lcobucci",
"comment_id": 423803577,
"datetime": 1537695235000,
"masked_author": "username_1",
"text": "@username_0 TIL, thanks :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Majkl578",
"comment_id": 423853487,
"datetime": 1537742461000,
"masked_author": "username_0",
"text": "`array_merge()` is not specially compiled function so it's not affected.\r\nApplies only to these functions:\r\n```php\r\n\t\t'array_key_exists',\r\n\t\t'array_slice',\r\n\t\t'boolval',\r\n\t\t'call_user_func',\r\n\t\t'call_user_func_array',\r\n\t\t'chr',\r\n\t\t'count',\r\n\t\t'doubleval',\r\n\t\t'defined',\r\n\t\t'floatval',\r\n\t\t'func_get_args',\r\n\t\t'func_num_args',\r\n\t\t'get_called_class',\r\n\t\t'get_class',\r\n\t\t'gettype',\r\n\t\t'in_array',\r\n\t\t'intval',\r\n\t\t'is_array',\r\n\t\t'is_bool',\r\n\t\t'is_double',\r\n\t\t'is_float',\r\n\t\t'is_long',\r\n\t\t'is_int',\r\n\t\t'is_integer',\r\n\t\t'is_null',\r\n\t\t'is_object',\r\n\t\t'is_real',\r\n\t\t'is_resource',\r\n\t\t'is_string',\r\n\t\t'ord',\r\n\t\t'strlen',\r\n\t\t'strval',\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ocramius",
"comment_id": 423853939,
"datetime": 1537742984000,
"masked_author": "username_2",
"text": "That would still mean that (if it gets compiled), this rule still applies. Besides `call_user_func()`, I don't think any of these make any sense with variadic arguments",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "morozov",
"comment_id": 423854040,
"datetime": 1537743083000,
"masked_author": "username_3",
"text": "If it gets compiled, it’ll make sense to whitelist it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Majkl578",
"comment_id": 423856558,
"datetime": 1537745967000,
"masked_author": "username_0",
"text": "Hopefully, in this case the rule will be harmless. 😊",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Ocramius",
"comment_id": 423856762,
"datetime": 1537746199000,
"masked_author": "username_2",
"text": "As long as the list doesn't expand without BC breaks, this is 👍",
"title": null,
"type": "comment"
}
] | 4 | 8 | 1,218 | false | false | 1,218 | true |
saltstack/salt | saltstack | 384,480,316 | 50,640 | {
"number": 50640,
"repo": "salt",
"user_login": "saltstack"
} | [
{
"action": "opened",
"author": "garethgreenaway",
"comment_id": null,
"datetime": 1543261152000,
"masked_author": "username_0",
"text": "Conflicts:\r\n - tests/unit/transport/test_zeromq.py",
"title": "[2018.3] Merge forward from 2017.7 to 2018.3",
"type": "issue"
},
{
"action": "created",
"author": "dwoz",
"comment_id": 441813772,
"datetime": 1543269327000,
"masked_author": "username_1",
"text": "I've started the py2 tests again to see if the `integration.modules.test_sysmod.SysModuleTest.test_valid_docs` is being flaky or not.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 186 | false | false | 186 | false |
ngx-translate/example | ngx-translate | 398,705,688 | 4 | {
"number": 4,
"repo": "example",
"user_login": "ngx-translate"
} | [
{
"action": "opened",
"author": "nevadascout",
"comment_id": null,
"datetime": 1547417958000,
"masked_author": "username_0",
"text": "The `angular.json` file has an incorrect path to the `styles.scss` file in the test step.\r\nI've updated it to add the `src/` as is required.\r\n\r\nThis was the error I got when trying to run the tests with `npm test`:\r\n```\r\nERROR in multi ./styles.css\r\nModule not found: Error: Can't resolve '/Users/ns/dev/ngx-example/styles.css' in '/Users/ns/dev/ngx-example'\r\n @ multi ./styles.css styles[0]\r\n```",
"title": "Fixed issue with path to styles.scss when running tests",
"type": "issue"
},
{
"action": "created",
"author": "nevadascout",
"comment_id": 457410811,
"datetime": 1548376316000,
"masked_author": "username_0",
"text": "@ocombe Do you have a few minutes to review & merge this pull request? 😃",
"title": null,
"type": "comment"
}
] | 1 | 2 | 468 | false | false | 468 | false |
phpstan/phpstan | phpstan | 465,059,706 | 2,276 | null | [
{
"action": "opened",
"author": "mfn",
"comment_id": null,
"datetime": 1562563400000,
"masked_author": "username_0",
"text": "# Bug report\r\n\r\nphpstan: 0.11.10\r\n<!-- Before reporting an issue please check that you are using the latest PHPStan version! -->\r\n\r\n<!-- Please describe your problem here. -->\r\nAfter upgrading today I was greeted with the following:\r\n\r\n```\r\n [OK] No errors\r\n\r\n💡 Tip of the Day:\r\nOne or more properties in your code do not have a phpDoc with a type\r\nbut it could be inferred from the constructor to find more bugs.\r\nUse inferPrivatePropertyTypeFromConstructor: true in your phpstan.neon to try it out!\r\n```\r\n\r\nEven after enabling it like this from `phpstan.neon`:\r\n```\r\nparameters:\r\n inferPrivatePropertyTypeFromConstructor: true\r\n```\r\nI still get this message (and btw, nothing changed once I added the parameter, no additional report).\r\n\r\n### Expected output\r\n\r\n<!-- Was the issue reported incorrectly? Or should PHPStan detect an issue with the code but doesn't? -->\r\nDon't give me the tip of the day I already followed.",
"title": "Getting \"Tip of the Day\" for \"inferPrivatePropertyTypeFromConstructor: true\" even when enabled",
"type": "issue"
},
{
"action": "closed",
"author": "ondrejmirtes",
"comment_id": null,
"datetime": 1562565750000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ondrejmirtes",
"comment_id": 509090453,
"datetime": 1562565750000,
"masked_author": "username_1",
"text": "Of course, sorry about that! Fixed: https://github.com/phpstan/phpstan/commit/598e55238330306dee89be9995777c1ba3478b66\r\n\r\nWill release promptly as 0.11.11.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pavarnos",
"comment_id": 509101186,
"datetime": 1562568522000,
"masked_author": "username_2",
"text": "tip of the day is a cool idea though...",
"title": null,
"type": "comment"
}
] | 4 | 5 | 1,257 | false | true | 1,117 | false |
libretro/libretro-database | libretro | 428,880,094 | 834 | null | [
{
"action": "opened",
"author": "baxysquare",
"comment_id": null,
"datetime": 1554311420000,
"masked_author": "username_0",
"text": "I saw the announcement of the [Libretro Database](http://db.libretro.com/) site and wanted to thank you for your hard work. It's an incredible resource that, as an unintended consequence, gives the [retroarch-assets](https://github.com/libretro/retroarch-assets) team a better way to know what we have and what we need for the theme icon sets.\r\n\r\nIf you could clarify on the following icon/database discrepancies, I would appreciate it.\r\n- **RPG Maker:** We currently have \"RPG Maker 2000\" and RPG Maker 2003\" icon sets. We can remove the date from the icons and remove the extra set.\r\n- **Sony - PlayStation Portable Vita:** We currently have a \"Sony - PlayStation Vita\" set and can rename them to fall inline.",
"title": "Database to Theme Icons",
"type": "issue"
},
{
"action": "closed",
"author": "baxysquare",
"comment_id": null,
"datetime": 1558636666000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 713 | false | false | 713 | false |
scalapb/ScalaPB | scalapb | 344,795,342 | 477 | null | [
{
"action": "opened",
"author": "teivah",
"comment_id": null,
"datetime": 1532602631000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nI have two simples .proto files A.proto and B.proto with B importing A but I'm facing errors during sbt compile:\r\n```Import \"A.proto\" was not found or had errors.```\r\n\r\nAre imports managed?",
"title": "Import management",
"type": "issue"
},
{
"action": "created",
"author": "thesamet",
"comment_id": 408128710,
"datetime": 1532617518000,
"masked_author": "username_1",
"text": "Imports are working. Maybe `A.proto` has errors?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "thesamet",
"comment_id": null,
"datetime": 1533776977000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "thesamet",
"comment_id": 411604643,
"datetime": 1533776977000,
"masked_author": "username_1",
"text": "We have plenty of tests that use imports so it sounds like a usage error. I'm closing this issue for now. If you have any additional information to add, feel free to comment and I will re-open.",
"title": null,
"type": "comment"
}
] | 2 | 4 | 441 | false | false | 441 | false |
sandreas/m4b-tool | null | 388,253,642 | 18 | null | [
{
"action": "opened",
"author": "schrodincat",
"comment_id": null,
"datetime": 1544108660000,
"masked_author": "username_0",
"text": "It would be convenient to install utility system-wide with `brew`",
"title": "Brew formula",
"type": "issue"
},
{
"action": "created",
"author": "sandreas",
"comment_id": 444917292,
"datetime": 1544111128000,
"masked_author": "username_1",
"text": "Thank you for pointing this out.\r\n\r\nYes, this would be very nice... unfortunately there are a few things missing. At first i would like to create a small \"homepage\" for the tool (brew does not accept packages without homepage).\r\n\r\nAt the moment i'm to busy to do anything but perhaps in the beginning of the next year...\r\nAs soon as the homepage is out, i'll create a brew formulae (this should be too complex).\r\n\r\nAs an alternative, i would like to provide a preconfigured docker image with all dependencies in it and environment variables to configure the input and output...\r\nDockerfile is already in the repository, but it can only merge things so far.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sandreas",
"comment_id": 449753441,
"datetime": 1545669632000,
"masked_author": "username_1",
"text": "Progress: http://m4b-tool.fynder.de/\r\nI know that it is very basic, but at least it qualifies for a pull request :-)\r\n\r\nIn the next days i will take a look at the brew formula... if someone would like to help, i would appreciate it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sandreas",
"comment_id": 450384618,
"datetime": 1546013735000,
"masked_author": "username_1",
"text": "Ok, found the docs, brew formula should be working as expected with best audio quality options and all needed tools and required options. I ready updated the documentation.\r\n\r\nIf something does not work, please reopen this issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "schrodincat",
"comment_id": 450390279,
"datetime": 1546015842000,
"masked_author": "username_0",
"text": "Wow, awesome! Thank you🙏",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "sandreas",
"comment_id": null,
"datetime": 1546017307000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "ragaskar",
"comment_id": 672922022,
"datetime": 1597244088000,
"masked_author": "username_2",
"text": "Use with caution, trying to install from this tap broke my functioning ffmpeg on catalina.",
"title": null,
"type": "comment"
},
{
"action": "reopened",
"author": "sandreas",
"comment_id": null,
"datetime": 1597251520000,
"masked_author": "username_1",
"text": "It would be convenient to install utility system-wide with `brew`",
"title": "Brew formula",
"type": "issue"
},
{
"action": "created",
"author": "sandreas",
"comment_id": 672994743,
"datetime": 1597251552000,
"masked_author": "username_1",
"text": "This is a serious issue, thanks for reporting - I'll take a look.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ragaskar",
"comment_id": 673013847,
"datetime": 1597253874000,
"masked_author": "username_2",
"text": "Yeah, no worries, a `brew uninstall ffmpeg` followed by a `brew install ffmpeg` fixed it. ffmpeg even with vanilla brew seems to be voodoo, I recall having to do a number of weird steps when I first installed on this machine to avoid weird library errors. If it's helpful, when doing a brew install m4b-tool I got `Error: ffmpeg is already installed from homebrew/core!\r\nPlease `brew uninstall ffmpeg` first.\"`\r\n\r\nThe errors I got after running that command (fresh terminal window, so env was reloaded) when running `ffmpeg` directly were\r\n\r\n```\r\n○ → ffmpeg\r\ndyld: Library not loaded: /usr/local/opt/x264/lib/libx264.159.dylib\r\n Referenced from: /usr/local/bin/ffmpeg\r\n Reason: image not found\r\nAbort trap: 6\r\n```\r\n\r\nI'm not fussed about having it fixed (like I said, I'll probably try out the docker image approach when I get a chance), but love that you're taking a look after this feedback, so cool.",
"title": null,
"type": "comment"
}
] | 3 | 10 | 2,330 | false | false | 2,330 | false |
sunchao/parquet-rs | null | 279,206,033 | 28 | {
"number": 28,
"repo": "parquet-rs",
"user_login": "sunchao"
} | [
{
"action": "opened",
"author": "sadikovi",
"comment_id": null,
"datetime": 1512435117000,
"masked_author": "username_0",
"text": "This PR updates `parquet.thrift` file to the latest version in parquet-format (f1de77d31936f4d50f1286676a0034b6339918ee). All tests pass locally after I added missing codec types LZ4 and ZSTD.\r\n\r\nCloses #21",
"title": "Update parquet.thrift",
"type": "issue"
},
{
"action": "created",
"author": "sadikovi",
"comment_id": 349159429,
"datetime": 1512435463000,
"masked_author": "username_0",
"text": "@username_1 Could you review please? Thanks!\r\n\r\nI simply copied format to the repository. There are quite a few changes to the format itself with additions like column index, etc. For example, there is added LogicalType to replace ConvertedType. Do we need to add support for it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sadikovi",
"comment_id": 349159802,
"datetime": 1512435581000,
"masked_author": "username_0",
"text": "We should also create issues to add those LZ4 and ZSTD support!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sadikovi",
"comment_id": 349433239,
"datetime": 1512506187000,
"masked_author": "username_0",
"text": "@username_1 I addressed your comments. Could you have a look again? Thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sunchao",
"comment_id": 349443543,
"datetime": 1512508488000,
"masked_author": "username_1",
"text": "Merged. Thanks again @username_0 !",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "sadikovi",
"comment_id": 349445079,
"datetime": 1512508819000,
"masked_author": "username_0",
"text": "@username_1 thanks for the review and merge!",
"title": null,
"type": "comment"
}
] | 3 | 8 | 1,294 | false | true | 690 | true |
alphagov/panopticon | alphagov | 165,529,685 | 383 | {
"number": 383,
"repo": "panopticon",
"user_login": "alphagov"
} | [
{
"action": "opened",
"author": "jackscotti",
"comment_id": null,
"datetime": 1468492413000,
"masked_author": "username_0",
"text": "'Quick fix' to get rid of the \"NoMethodError: undefined method `tag_type' for\r\nnil:NilClass\" error, see here:\r\nhttps://github.com/alphagov/panopticon/blob/master/app/queue_consumers/tagging_updater.rb#L56\r\n\r\nWe should investigate why the item is not present in Panopticon's db.",
"title": "Update parent only when present in db",
"type": "issue"
},
{
"action": "created",
"author": "MatMoore",
"comment_id": 232628948,
"datetime": 1468492701000,
"masked_author": "username_1",
"text": "👍 from me, would like one other review though.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tijmenb",
"comment_id": 232635936,
"datetime": 1468494738000,
"masked_author": "username_2",
"text": "This seems legit. I'd be curious to see the items where this failed though, do you have an example?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jackscotti",
"comment_id": 232637032,
"datetime": 1468495077000,
"masked_author": "username_0",
"text": "@username_2 https://errbit.publishing.service.gov.uk/apps/52f0ceeb0da1152f0b000003/problems/578754826578637e7abf0000",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jackscotti",
"comment_id": 232637078,
"datetime": 1468495092000,
"masked_author": "username_0",
"text": "Merging.",
"title": null,
"type": "comment"
}
] | 3 | 5 | 543 | false | false | 543 | true |
awslabs/aws-cdk | awslabs | 362,984,019 | 763 | null | [
{
"action": "opened",
"author": "jmhummel",
"comment_id": null,
"datetime": 1537742437000,
"masked_author": "username_0",
"text": "Currently, all packages within aws-cdk reference other cdk modules using caret ranges: `^0.9.2`\r\nHere is an example from `@aws-cdk/aws-lambda`:\r\n```\r\n \"dependencies\": {\r\n \"@aws-cdk/assets\": \"^0.9.2\",\r\n \"@aws-cdk/aws-cloudwatch\": \"^0.9.2\",\r\n \"@aws-cdk/aws-codepipeline-api\": \"^0.9.2\",\r\n \"@aws-cdk/aws-ec2\": \"^0.9.2\",\r\n \"@aws-cdk/aws-events\": \"^0.9.2\",\r\n \"@aws-cdk/aws-iam\": \"^0.9.2\",\r\n \"@aws-cdk/aws-logs\": \"^0.9.2\",\r\n \"@aws-cdk/aws-s3\": \"^0.9.2\",\r\n \"@aws-cdk/aws-s3-notifications\": \"^0.9.2\",\r\n \"@aws-cdk/aws-sqs\": \"^0.9.2\",\r\n \"@aws-cdk/cdk\": \"^0.9.2\",\r\n \"@aws-cdk/cx-api\": \"^0.9.2\"\r\n },\r\n\r\n```\r\nhttps://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-lambda/package.json\r\n\r\nThe most recent release of `0.9.2` introduced many breaking changes. Projects dependent on `0.9.1` version are now broken, even if they specified the exact version in their package.json, as each `0.9.1` dependency pulls in other cdk modules using `^0.9.1`\r\n\r\nPlease consider using exact versions of cdk dependencies within modules for the next release.",
"title": "Caret ranges in package.json and breaking changes",
"type": "issue"
},
{
"action": "created",
"author": "rix0rrr",
"comment_id": 423905439,
"datetime": 1537777621000,
"masked_author": "username_1",
"text": "The mistake here was releasing as `0.9.2` instead of `0.10.0`. Our apologies for the breakage, we will do better going forward.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "rix0rrr",
"comment_id": null,
"datetime": 1537777629000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,206 | false | false | 1,206 | false |
Codeception/CodeceptJS | Codeception | 296,327,251 | 929 | null | [
{
"action": "opened",
"author": "cluehr",
"comment_id": null,
"datetime": 1518431515000,
"masked_author": "username_0",
"text": "```js\r\n// paste test\r\n```\r\n\r\n### Details\r\n\r\n* CodeceptJS version:\r\n* NodeJS Version:\r\n* Operating System:\r\n* Protractor || WebDriverIO || Nightmare version (if related)\r\n* Configuration file:\r\n\r\n```js\r\n# paste suite config here\r\n```",
"title": "Parallel execution of multiple test suites in multiple instances of same browser",
"type": "issue"
},
{
"action": "created",
"author": "reubenmiller",
"comment_id": 364903161,
"datetime": 1518436910000,
"masked_author": "username_1",
"text": "You can use the multi configuration for the same browser, you just have to specify which browsers you want to run with the configuration.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DavertMik",
"comment_id": 365388289,
"datetime": 1518552511000,
"masked_author": "username_2",
"text": "Both. \r\n\r\nMy personal preference to run parallel tests on continuous integration server. This way you can ensure that tests are isolated.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reubenmiller",
"comment_id": 368764875,
"datetime": 1519713992000,
"masked_author": "username_1",
"text": "@username_0 Does this answer your question?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "allenhwkim",
"comment_id": 378291864,
"datetime": 1522769404000,
"masked_author": "username_3",
"text": "I have the same requirement. \r\n\r\nLet's say I have 10 test files, and I want run all 10 tests at the same time not in sequence.\r\nAssuming each test takes 1 minute to run, I want to finish tests in 1-2 minute, not in 10 minute.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "michaltrunek",
"comment_id": 506333647,
"datetime": 1561640086000,
"masked_author": "username_4",
"text": "I tried to execute tests in parallel but managed to get max 2 tests running at the same time, is it possible to run more of them when using run-multiple please? \r\n\r\n**setup in codeceptjs conf file:**\r\n```\r\nmultiple: {\r\n parallel: {\r\n chunks: 3\r\n }\r\n }\r\n```\r\n**setup in docker-compose file for zalenium selenium-hub:**\r\n```\r\n# Usage:\r\n# docker-compose up --force-recreate\r\nversion: '2.1'\r\n\r\nservices:\r\n #--------------#\r\n zalenium:\r\n image: \"dosel/zalenium\"\r\n container_name: zalenium\r\n hostname: zalenium\r\n tty: true\r\n volumes:\r\n - /tmp/videos:/home/seluser/videos\r\n - /var/run/docker.sock:/var/run/docker.sock\r\n ports:\r\n - 4445:4444\r\n command: >\r\n start --desiredContainers 3\r\n --maxDockerSeleniumContainers 8\r\n --screenWidth 800 --screenHeight 600\r\n --timeZone \"Europe/Berlin\"\r\n --videoRecordingEnabled false\r\n --sauceLabsEnabled false\r\n --browserStackEnabled false\r\n --testingBotEnabled false\r\n --cbtEnabled false\r\n --startTunnel false\r\n environment:\r\n - HOST_UID\r\n - HOST_GID\r\n - SAUCE_USERNAME\r\n - SAUCE_ACCESS_KEY\r\n - BROWSER_STACK_USER\r\n - BROWSER_STACK_KEY\r\n - TESTINGBOT_KEY\r\n - TESTINGBOT_SECRET\r\n - CBT_USERNAME\r\n - CBT_AUTHKEY\r\n\r\n```",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "DavertMik",
"comment_id": null,
"datetime": 1630843494000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 5 | 7 | 2,140 | false | false | 2,140 | true |
Studio-Center/sc-auditions | Studio-Center | 454,333,039 | 10 | null | [
{
"action": "opened",
"author": "AlanSwenson",
"comment_id": null,
"datetime": 1560194957000,
"masked_author": "username_0",
"text": "Can you check this out when you get time. This is what I am getting after about a min or 2 when I try my Email Assigned talent.\r\n\r\n\r\n",
"title": "Getting an error trying to use my new Email Assigned feature",
"type": "issue"
},
{
"action": "created",
"author": "doodersrage",
"comment_id": 500587096,
"datetime": 1560199446000,
"masked_author": "username_1",
"text": "How are you triggering the sendTalentEmail method?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AlanSwenson",
"comment_id": 500593584,
"datetime": 1560200558000,
"masked_author": "username_0",
"text": "step one: click Email Assigned\nstep two: fill in subject and body\nstep three: click send",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AlanSwenson",
"comment_id": 500593795,
"datetime": 1560200593000,
"masked_author": "username_0",
"text": "It seems that the people are emailed, or maybe most of them are... As I got\nsome responses\n\nOn Mon, Jun 10, 2019 at 5:02 PM Alan Swenson <alan@alanswenson.dev> wrote:\n\n> step one: click Email Assigned\n> step two: fill in subject and body\n> step three: click send\n>\n>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "doodersrage",
"comment_id": 500594617,
"datetime": 1560200747000,
"masked_author": "username_1",
"text": "That method is called by various other methods to send talent emails, not sure immediately where it originates. Do the send talent email tool? https://studiocenterauditions.com/#!/tools/email-talent",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AlanSwenson",
"comment_id": 500595018,
"datetime": 1560200817000,
"masked_author": "username_0",
"text": "yup. thats what I am talking about. sorry.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "doodersrage",
"comment_id": 500957333,
"datetime": 1560276206000,
"masked_author": "username_1",
"text": "I think this error is triggering due to talent's not having email designated as primary contact method then having an error generated.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "doodersrage",
"comment_id": 500969673,
"datetime": 1560278174000,
"masked_author": "username_1",
"text": "Email talent tool updated to only list talent with email assigned as primary contact method. The email all talent checkout also filters out talent with email designated as primary contact now.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AlanSwenson",
"comment_id": 500970082,
"datetime": 1560278241000,
"masked_author": "username_0",
"text": "Excellent.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "doodersrage",
"comment_id": null,
"datetime": 1560280215000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 10 | 1,395 | false | false | 1,395 | false |
gangleri/humanbytes | null | 244,840,418 | 2 | {
"number": 2,
"repo": "humanbytes",
"user_login": "gangleri"
} | [
{
"action": "opened",
"author": "gangleri",
"comment_id": null,
"datetime": 1500721178000,
"masked_author": "username_0",
"text": "desc",
"title": "Title",
"type": "issue"
}
] | 2 | 2 | 4 | false | true | 4 | false |
ArtSabintsev/Siren | null | 363,645,185 | 230 | null | [
{
"action": "opened",
"author": "danielmhanover",
"comment_id": null,
"datetime": 1537890318000,
"masked_author": "username_0",
"text": "This was already brought up in [this issue](https://github.com/username_1/Siren/issues/225).\r\n\r\nI just wanted to say a quick fix is to replace `UIWindow.Level.alert` with `UIWindowLevelAlert` in `SirenUIAlertControllerExtension.swift`.",
"title": "Carthage Build Fails on Swift 4.2",
"type": "issue"
},
{
"action": "created",
"author": "ArtSabintsev",
"comment_id": 424435476,
"datetime": 1537897201000,
"masked_author": "username_1",
"text": "Hey - thanks for the message. That seems a bit weird, since https://developer.apple.com/documentation/uikit/uiwindow/level states that `UIWindow.Level` is the appropriate approach. Are you positive you're using Xcode 10 and it's that Carthage is using the Xcode10 `xcodebuild` toolchain?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ArtSabintsev",
"comment_id": null,
"datetime": 1537974222000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "danielmhanover",
"comment_id": 424752358,
"datetime": 1537974562000,
"masked_author": "username_0",
"text": "Yes I am certain that I am. I’m not sure why this is happening but if it doesn’t impair functionality, making this replacement might be beneficial.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ArtSabintsev",
"comment_id": 424755346,
"datetime": 1537975053000,
"masked_author": "username_1",
"text": "Can you send me a zip file with a blank sample project that tries to bring in Siren using Carthage? I’ll try to replicate it on my end afterwards. Thanks!\n\n<sub>Sent with <a href=\"http://githawk.com\">GitHawk</a></sub>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stevenp",
"comment_id": 429511680,
"datetime": 1539406990000,
"masked_author": "username_2",
"text": "This doesn't appear to be limited to Carthage. I'm building on the latest Xcode 10.1 beta using Cocoapods and I was also unable to compile due to this same error. \r\n\r\nI had a workaround in my Podfile that was setting the Swift version at the Pods project configuration level and deleting it for every Pod target, which ended up leaving me with Siren trying to compile with Swift 4 instead of 4.2. This code doesn't compile unless the target is explicitly set to 4.2, which is what was likely causing the error in this issue. I was able to remove my workaround now that my dependencies all work with Swift 4.2, and that resolved this problem for me.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ArtSabintsev",
"comment_id": 429533549,
"datetime": 1539429175000,
"masked_author": "username_1",
"text": "So everything is working now?\n\n<sub>Sent with <a href=\"http://githawk.com\">GitHawk</a></sub>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "stevenp",
"comment_id": 429594386,
"datetime": 1539489186000,
"masked_author": "username_2",
"text": "For me, at least, it is.",
"title": null,
"type": "comment"
}
] | 3 | 8 | 1,652 | false | false | 1,652 | true |
danielkrupinski/Osiris | null | 452,046,537 | 238 | null | [
{
"action": "opened",
"author": "Flaam",
"comment_id": null,
"datetime": 1559660225000,
"masked_author": "username_0",
"text": "Can someone send me a really good config for legit cheating? I have made one yesterday but isn't that legit.",
"title": "[Help] Legit Config",
"type": "issue"
},
{
"action": "created",
"author": "B0ruK",
"comment_id": 498751585,
"datetime": 1559666675000,
"masked_author": "username_1",
"text": "is this p2c forum?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ViniciusSchifferGuedes",
"comment_id": 498751729,
"datetime": 1559666702000,
"masked_author": "username_2",
"text": "no esp, no glow, chams visible pam health, 2.5 fov(nearest), +15 smooth(variable), X = 0.3, Y = 1, no trigger, no backtrack, recoil crosshair, sniper crosshair, no blur, auto pistol on, for more legit just more smooth(keep less than 100 points and -50% headshots)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Flaam",
"comment_id": 498752440,
"datetime": 1559666821000,
"masked_author": "username_0",
"text": "@username_1 who asked for ur opinion",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Flaam",
"comment_id": 498752621,
"datetime": 1559666854000,
"masked_author": "username_0",
"text": "@username_2 thank you very much",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "B0ruK",
"comment_id": 499296379,
"datetime": 1559778437000,
"masked_author": "username_1",
"text": "lol dont @ me child",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "danielkrupinski",
"comment_id": null,
"datetime": 1559799520000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 7 | 483 | false | false | 483 | true |
strapi/strapi | strapi | 437,746,376 | 3,194 | null | [
{
"action": "opened",
"author": "IceOnFire",
"comment_id": null,
"datetime": 1556295303000,
"masked_author": "username_0",
"text": "<!-- ⚠️ If you do not respect this template your issue will be closed. -->\r\n\r\n<!-- =============================================================================== -->\r\n<!-- ⚠️ If you are not using the current Strapi release, you will be asked to update. -->\r\n<!-- Please see the wiki for guides on upgrading to the latest release. -->\r\n<!-- =============================================================================== -->\r\n\r\n<!-- ⚠️ Make sure to browse the opened and closed issues before submitting your issue. -->\r\n\r\n<!-- ⚠️ Before writing your issue make sure you are using:-->\r\n<!-- Node 10.x.x -->\r\n<!-- npm 6.x.x -->\r\n<!-- The latest version of Strapi. -->\r\n\r\n**Informations**\r\n- **Node.js version**: v10.15.3<!-- Please ensure you are using the Node LTS version (v10) -->\r\n- **NPM version**: 6.4.1\r\n- **Strapi version**: 3.0.0-alpha.26.1<!-- Please make sure you are on the latest version -->\r\n- **Database**: MongoDB v3.6.8\r\n- **Operating system**: Linux Ubuntu 19.04 (Disco Dingo)\r\n- **(Optional) Link to your Project**: <!-- To speedup support, if you have your project on github/gitlab you can provide a link -->\r\n\r\n\r\n**What is the current behavior?**\r\n\r\nAfter migrating from 3.0.0-alpha.24 to 3.0.0-alpha.26.1 I changed all my services so they use `convertRestQueryParams` and `buildQuery`. Everything works fine.\r\n\r\nIn `fetchAll` I used to intercept the incoming parameters in order to change them into custom where clauses. For example, if `params.isBanned == true`, then I used to add a where clause such as\r\n```\r\n{\r\n $and: [\r\n { banStartDate: { $gt: date } },\r\n { banEndDate: { $lt: date } },\r\n ]\r\n}\r\n```\r\n\r\notherwise if `params.isBanned == false`\r\n\r\nI used to put\r\n```\r\n{\r\n $or: [\r\n { banStartDate: { $lte: date } },\r\n { banEndDate: { $gte: date } }\r\n ]\r\n}\r\n```\r\n\r\nNow that we have `convertRestQueryParams` and `buildQuery`, the format of our where clause has changed so I adapted it to the new structure. For the `$and` case it changes into\r\n```\r\n[\r\n { field: 'banStartDate', operator: 'lte', value: date },\r\n { field: 'banEndDate', operator: 'gte', value: date },\r\n]\r\n```\r\n\r\nbut for the `$or` case I cannot seem to find a solution: from [what I can see](https://github.com/strapi/strapi/blob/master/packages/strapi-hook-mongoose/lib/buildQuery.js) the `buildQuery` function supports the `$or` case only if I have the same operator and multiple values, but in my case I need to put completely different clauses in `$or`.\r\n\r\n**Steps to reproduce the problem**\r\n\r\nJust try to add some custom filters such as the one described above.\r\n\r\n**What is the expected behavior?**\r\n\r\nIt would be great if `buildQuery` supported multiple clauses in `$or`, otherwise simple custom filters such as the one described cannot be defined without going to a lower level.\r\n\r\n**Suggested solutions**\r\n\r\nMaybe the `buildQuery` function could have a special case in which, if the operator is `or`, then it just builds the `$or` clause with an array of values taken from `value`.",
"title": "Upgrade to 3.0.0-alpha.26.1: Cannot perform $or filters",
"type": "issue"
},
{
"action": "created",
"author": "IceOnFire",
"comment_id": 487116713,
"datetime": 1556295727000,
"masked_author": "username_0",
"text": "Maybe something like this?\r\n\r\n```\r\nconst buildWhereClause = ({ field, operator, value }) => {\r\n if (Array.isArray(value) && !['in', 'nin', 'or'].includes(operator)) { // bypass 'or'\r\n return {\r\n $or: value.map(val => buildWhereClause({ field, operator, value: val })),\r\n };\r\n }\r\n\r\n const val = formatValue(value);\r\n\r\n switch (operator) {\r\n case 'eq':\r\n return { [field]: val };\r\n case 'ne':\r\n return { [field]: { $ne: val } };\r\n case 'lt':\r\n return { [field]: { $lt: val } };\r\n case 'lte':\r\n return { [field]: { $lte: val } };\r\n case 'gt':\r\n return { [field]: { $gt: val } };\r\n case 'gte':\r\n return { [field]: { $gte: val } };\r\n case 'or':\r\n return { $or: Array.isArray(val) ? val : [val] }; // this should do the trick\r\n case 'in':\r\n return {\r\n [field]: {\r\n $in: Array.isArray(val) ? val : [val],\r\n },\r\n };\r\n case 'nin':\r\n return {\r\n [field]: {\r\n $nin: Array.isArray(val) ? val : [val],\r\n },\r\n };\r\n case 'contains': {\r\n return {\r\n [field]: {\r\n $regex: `${val}`,\r\n $options: 'i',\r\n },\r\n };\r\n }\r\n case 'ncontains':\r\n return {\r\n [field]: {\r\n $not: new RegExp(val, 'i'),\r\n },\r\n };\r\n case 'containss':\r\n return {\r\n [field]: {\r\n $regex: `${val}`,\r\n },\r\n };\r\n case 'ncontainss':\r\n return {\r\n [field]: {\r\n $not: new RegExp(val),\r\n },\r\n };\r\n\r\n default:\r\n throw new Error(`Unhandled whereClause : ${fullField} ${operator} ${value}`);\r\n }\r\n};\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "IceOnFire",
"comment_id": 487122450,
"datetime": 1556296875000,
"masked_author": "username_0",
"text": "Also, I cannot do any geospatial queries. This `buildWhereClause` function is a bit limiting apparently...",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ragnorc",
"comment_id": 561195658,
"datetime": 1575383833000,
"masked_author": "username_1",
"text": "Is there maybe an ETA for this? I think it is a very important issue as any non-trivial use case will somehow need boolean operators in GraphQL queries.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lauriejim",
"comment_id": 562208919,
"datetime": 1575563795000,
"masked_author": "username_2",
"text": "Hello! We don't have ETA about this topic.\r\nAnd we know it's important (high flag)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "samuelpetroline",
"comment_id": 572749285,
"datetime": 1578603047000,
"masked_author": "username_3",
"text": "Just pinning so I can see when any updates occurr ^^",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alexandrebodin",
"comment_id": 572914097,
"datetime": 1578642465000,
"masked_author": "username_4",
"text": "You can access a mongoose or bookshelf model through\r\n\r\n`strapi.query(modelName).model` then you can run any query you can with the specific underlying orm.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fastengineer",
"comment_id": 626253988,
"datetime": 1589070427000,
"masked_author": "username_5",
"text": "When I switched from mongodb to postgresql, I could easily use AND. There is no solution for OR.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "petersg83",
"comment_id": null,
"datetime": 1596534003000,
"masked_author": "username_6",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "petersg83",
"comment_id": 668495140,
"datetime": 1596534003000,
"masked_author": "username_6",
"text": "Fixed by #6965",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dadaphl",
"comment_id": 716896813,
"datetime": 1603757900000,
"masked_author": "username_7",
"text": "I can not find any information in the documentation on how to build an OR query with graphql in strapi. Google points to this issue. @username_6, would you mind sharing an example here? Thank you.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "derrickmehaffy",
"comment_id": 717284151,
"datetime": 1603809003000,
"masked_author": "username_8",
"text": "Something like this (we are aware of the lacking documentation for this and plan to make some changes)\r\n\r\n```\r\n{\r\n addresses(where: { _or: [ { postal_coder: \"92301\"}, { postal_coder: \"11111\"}] }) {\r\n postal_coder\r\n id\r\n }\r\n}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FenixDeveloper",
"comment_id": 718233159,
"datetime": 1603922382000,
"masked_author": "username_9",
"text": "@username_8 filter in this example will work with nested models? For example:\r\n\r\nmodelTop has fields \"_id, color\" and field \"childs\" related to many modelChild\r\nmodelChild has fields \"_id, published, type\" and field \"parent\" related to one modelTop\r\n\r\nIn this case can we build next query:\r\n`\r\n{\r\n modelTop(where: { _or: [\r\n { color_contains: \"white\", childs: { type: \"test\", published_ne: false } },\r\n { color_contains: \"white\", childs: { type_ne: \"test\" } }\r\n ] }) {\r\n color\r\n }\r\n}\r\n`\r\n\r\nIn current version i can query models with nested filters only without \"or\", but may be i did it wrong?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "derrickmehaffy",
"comment_id": 718787737,
"datetime": 1603981488000,
"masked_author": "username_8",
"text": "I don't believe so :thinking: I'll try and do some testing but we are planning a major rewrite this quarter on the filtering and deep filtering system especially with complex queries.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "derrickmehaffy",
"comment_id": 749248246,
"datetime": 1608592464000,
"masked_author": "username_8",
"text": "This issue has been mentioned on **Strapi Community Forum**. There might be relevant details there:\n\nhttps://forum.strapi.io/t/logical-operators-or-and-in-graphql-where-parameter-7795/1753/1",
"title": null,
"type": "comment"
}
] | 10 | 15 | 6,720 | false | false | 6,720 | true |
mattermost/mattermost-webapp | mattermost | 333,487,736 | 1,348 | {
"number": 1348,
"repo": "mattermost-webapp",
"user_login": "mattermost"
} | [
{
"action": "opened",
"author": "lieut-data",
"comment_id": null,
"datetime": 1529371430000,
"masked_author": "username_0",
"text": "#### Summary\r\nRely on window.basename, exported as part of the [previous changes](https://github.com/mattermost/mattermost-webapp/pull/1321) re: subpath, to configure react-router (and one exceptional case re: text formatting).\r\n\r\n@hmhealey, I've specifically added you to this PR given our discussion re: text_formatting.jsx and the shortcut I've taken here. I'm not super excited about the global, but I didn't want to do a wholescale refactor of the use of `browserHistory`, and the global usage is constrained to just two places. I'd love your feedback!\r\n\r\n#### Ticket Link\r\nhttps://mattermost.atlassian.net/browse/MM-10368\r\nhttps://mattermost.atlassian.net/browse/MM-10369\r\n\r\n#### Checklist\r\n- [x] Ran `make check-style` to check for style errors (required for all pull requests)\r\n- [x] Ran `make test` to ensure unit and component tests passed\r\n- [x] Added or updated unit tests (required for all new features)\r\n- [x] Has server changes: https://github.com/mattermost/mattermost-server/pull/8968",
"title": "MM-10368: react-router subpath",
"type": "issue"
},
{
"action": "created",
"author": "mattermod",
"comment_id": 399499797,
"datetime": 1529684605000,
"masked_author": "username_1",
"text": "`Setup Test Server` label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mattermod",
"comment_id": 399564313,
"datetime": 1529697372000,
"masked_author": "username_1",
"text": "Spinmint test server destroyed",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,162 | false | false | 1,162 | false |
Microsoft/AI | Microsoft | 379,009,545 | 260 | {
"number": 260,
"repo": "AI",
"user_login": "Microsoft"
} | [
{
"action": "opened",
"author": "lauren-mills",
"comment_id": null,
"datetime": 1541734342000,
"masked_author": "username_0",
"text": "<!--- Provide a general summary of your changes in the Title above -->\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n1. Added .bat files to parse .lu files into deploymentScripts folder for all languages and skills\r\n2. Removed all .luis and .qna files and added to .gitignore\r\n3. Added dispatch.lu for each language\r\n3. Updated POI cancel route .lu to use patterns for redundant utterances to allow for ludown parsing of dispatch.lu (cannot have more that 15000 utterances for one intent)\r\n\r\n\r\n# Notes\r\n- This does not include post build steps due to increased build time\r\n- Must run the .bat files before running msbotClone command\r\n\r\n## Related Issue\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\nfixes #21\r\n\r\n## Testing Steps\r\n<!--- Include any instructions for testing your Pull Request-->\r\n<!--- Include sample utterances, steps, etc-->\r\n1. Pull down code\r\n2. Run update_deployment_scripts.bat \r\n3. Verify populated deployment script files for all languages in DeploymentScripts folder of VirtualAssistant",
"title": "Lamil/deployment updates",
"type": "issue"
},
{
"action": "created",
"author": "lauren-mills",
"comment_id": 437249537,
"datetime": 1541739055000,
"masked_author": "username_0",
"text": "Added updates files for each language, so they can selectively be added in as build steps if desired.",
"title": null,
"type": "comment"
}
] | 1 | 2 | 1,373 | false | false | 1,373 | false |
w3c/webidl2.js | w3c | 443,630,537 | 321 | {
"number": 321,
"repo": "webidl2.js",
"user_login": "w3c"
} | [
{
"action": "opened",
"author": "kainino0x",
"comment_id": null,
"datetime": 1557786787000,
"masked_author": "username_0",
"text": "",
"title": "Fix JS error on productions/default.js bracket errors",
"type": "issue"
},
{
"action": "created",
"author": "saschanaz",
"comment_id": 492039528,
"datetime": 1557795768000,
"masked_author": "username_1",
"text": "Really need attaching some static analyzer.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "saschanaz",
"comment_id": 492045627,
"datetime": 1557797852000,
"masked_author": "username_1",
"text": "@username_0 Could you add a test for this? You can add a short relevant IDL code in `test/syntax/idl/` and run `npx webpack && npm run acquire`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "saschanaz",
"comment_id": 492923078,
"datetime": 1557984727000,
"masked_author": "username_1",
"text": "Not sure why Travis never runs. I confirmed this locally passes the test, so I'm merging this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kainino0x",
"comment_id": 492923923,
"datetime": 1557984982000,
"masked_author": "username_0",
"text": "Thanks so much for adding the test. I have been in all day standardization meetings this week so I haven't been able to look back at it.",
"title": null,
"type": "comment"
}
] | 2 | 5 | 416 | false | false | 416 | true |
Joshua-Ashton/d9vk | null | 442,195,495 | 81 | null | [
{
"action": "opened",
"author": "Monsterovich",
"comment_id": null,
"datetime": 1557402492000,
"masked_author": "username_0",
"text": "### Software information\r\n\r\nThe game works fine under wine and normal wine's d3d9.\r\n\r\n### System information\r\n- GPU: Mesa DRI Intel(R) HD Graphics 520 (Skylake GT2)\r\n- Driver: Mesa 19.1.0-devel - padoka PPA\r\n- Wine version: Wine Staging 4.7\r\n- DXVK version: 0.10\r\n\r\n### Apitrace file(s)\r\n\r\n\r\n### Log files\r\n[swtor_d3d9.log](https://github.com/Joshua-Ashton/d9vk/files/3161910/swtor_d3d9.log)\r\n[swtor_dxgi.log](https://github.com/Joshua-Ashton/d9vk/files/3161911/swtor_dxgi.log)",
"title": "Star Wars: The Old Republic black screen",
"type": "issue"
},
{
"action": "created",
"author": "kassindornelles",
"comment_id": 490887011,
"datetime": 1557405731000,
"masked_author": "username_1",
"text": "Try to apitrace the game, that could be really helpful. \r\napitrace dll [here](https://drive.google.com/open?id=1By-5qUdVsz_xJozRDJ-LHnkfXo_VhtA-)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Monsterovich",
"comment_id": 490917639,
"datetime": 1557410497000,
"masked_author": "username_0",
"text": "I can't. The game is run through launcher which runs the actual game exe.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "varris1",
"comment_id": 490919032,
"datetime": 1557410709000,
"masked_author": "username_2",
"text": "You don't have to start through apitrace.exe.\r\n\r\nput the d3d9.dll in the wrapper folder next to the .exe and set d3d9 to native,builtin",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Monsterovich",
"comment_id": 490920207,
"datetime": 1557410886000,
"masked_author": "username_0",
"text": "I didn't know that output files will appear on my desktop. I expected it appear in the game folder.\r\n[swtor.1.trace.zip](https://github.com/Joshua-Ashton/d9vk/files/3162502/swtor.1.trace.zip)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "K0bin",
"comment_id": 490921820,
"datetime": 1557411141000,
"masked_author": "username_3",
"text": "That file is way too small. You still did something wrong.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Monsterovich",
"comment_id": 490924796,
"datetime": 1557411603000,
"masked_author": "username_0",
"text": "I waited for over 2 mins and got the same file with size of 16396290 bytes.\r\nI have black screen and d9vk just stuck on the CreatePixelShader.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "tannisroot",
"comment_id": 490929144,
"datetime": 1557412250000,
"masked_author": "username_4",
"text": "Are you trying to apitrace it with d9vk? Because that is really not preferred and could cause issues. Use wined3d or better, native D3D on Windows instead.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Monsterovich",
"comment_id": 490935338,
"datetime": 1557413195000,
"masked_author": "username_0",
"text": "Okay, I run it with wined3d9. Here's .trace file.\r\nhttps://drive.google.com/open?id=1gJA9vY-tYNVHXBZ4yrao9vZnp6C4_97Z",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fls2018",
"comment_id": 493821402,
"datetime": 1558320277000,
"masked_author": "username_5",
"text": "I have the same issue, here's my trace: \r\n\r\nhttps://drive.google.com/file/d/1jT3oTXEyG1Z07JjoPKK0pZGYSJXWq_aF/view",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Monsterovich",
"comment_id": 494197662,
"datetime": 1558399266000,
"masked_author": "username_0",
"text": "Your trace is working for me.\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fls2018",
"comment_id": 494201931,
"datetime": 1558400913000,
"masked_author": "username_5",
"text": "Because the trace was done under wined3d it doesn't have the issue, however they can still look at the api calls to figure out why d9vk wouldn't work.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Monsterovich",
"comment_id": null,
"datetime": 1563222890000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "Monsterovich",
"comment_id": 511559342,
"datetime": 1563222890000,
"masked_author": "username_0",
"text": "Fixed in Version 0.13f - Hypnofrog.\r\n\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Monsterovich",
"comment_id": 511561255,
"datetime": 1563223228000,
"masked_author": "username_0",
"text": "[swtor_dxgi.log](https://github.com/Joshua-Ashton/d9vk/files/3394118/swtor_dxgi.log)\r\n[swtor_d3d9.log](https://github.com/Joshua-Ashton/d9vk/files/3394119/swtor_d3d9.log)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "K0bin",
"comment_id": 511561991,
"datetime": 1563223357000,
"masked_author": "username_3",
"text": "Why are you posting logs if the issue is fixed?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fls2018",
"comment_id": 511891189,
"datetime": 1563294738000,
"masked_author": "username_5",
"text": "It's not fixed here, splash screen starts but crashes thereafter.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "K0bin",
"comment_id": 511906872,
"datetime": 1563297401000,
"masked_author": "username_3",
"text": "Then post an apitrace so we can actually debug this",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fls2018",
"comment_id": 511978757,
"datetime": 1563309902000,
"masked_author": "username_5",
"text": "@username_3 \r\n\r\nHere's an apitrace, as you see it just hangs at the splash screen. I also used native d3d_compiler & d3dx9 as suggested in the release notes.\r\n\r\nhttps://drive.google.com/file/d/1uDsT16FPVBVPCfUhC9rf24RWKbi_QSKI/view",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Monsterovich",
"comment_id": 513545822,
"datetime": 1563708777000,
"masked_author": "username_0",
"text": "\r\n\r\nI noticed graphical artifacts in the main menu. This happens only when anti-aliasing is above medium.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fls2018",
"comment_id": 525087541,
"datetime": 1566870145000,
"masked_author": "username_5",
"text": "Haven't tried this since my last post but it appears to be working now since 0.20 at least.\r\n\r\n",
"title": null,
"type": "comment"
}
] | 6 | 21 | 3,253 | false | false | 3,253 | true |
aws/chalice | aws | 316,543,280 | 807 | null | [
{
"action": "opened",
"author": "rosskarchner",
"comment_id": null,
"datetime": 1524364670000,
"masked_author": "username_0",
"text": "From a brand-new Cloud9 environment (as an IAM user with [this custom policy](https://github.com/aws/chalice/issues/59#issuecomment-239640739), and I'm getting the following when I try to deploy the default app (the one you get along with new-project):\r\n\r\n```\r\nChaliceDeploymentError: ERROR - While deploying your chalice application, received the following error:\r\n\r\n An error occurred (InvalidClientTokenId) when calling the CreateRole \r\n operation: The security token included in the request is invalid\r\n```\r\nIs that IAM policy incomplete?",
"title": "\"The security token included in the request is invalid\" on Cloud9",
"type": "issue"
},
{
"action": "created",
"author": "kadrach",
"comment_id": 383351132,
"datetime": 1524365369000,
"masked_author": "username_1",
"text": "At first glance, that policy does not grant `iam:CreateRole`. However I would expect to see a permission denied error rather than a security token error. Are you manually setting credentials, or letting chalice (boto) pick up credentials?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rosskarchner",
"comment_id": 383417947,
"datetime": 1524436692000,
"masked_author": "username_0",
"text": "I'm letting Chalice pick them up automatically",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rosskarchner",
"comment_id": 383418202,
"datetime": 1524437010000,
"masked_author": "username_0",
"text": "I should also not that the policy I linked to is not the only one in place-- some of these are needed for Cloud9, and some were just added while attempting to troubleshoot.\r\n\r\n",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "rosskarchner",
"comment_id": null,
"datetime": 1524625653000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "rosskarchner",
"comment_id": 384147654,
"datetime": 1524625864000,
"masked_author": "username_0",
"text": "some googling indicates that there is an incompatibility between API's that use tokens, and service-linked roles. For now, I've set my credentials in environment variables, and things seem to be working OK.",
"title": null,
"type": "comment"
}
] | 2 | 6 | 1,347 | false | false | 1,347 | false |
freeCodeCamp/freeCodeCamp | freeCodeCamp | 447,226,535 | 36,110 | {
"number": 36110,
"repo": "freeCodeCamp",
"user_login": "freeCodeCamp"
} | [
{
"action": "opened",
"author": "ojeytonwilliams",
"comment_id": null,
"datetime": 1558541625000,
"masked_author": "username_0",
"text": "<!-- Please follow this checklist and put an x in each of the boxes, like this: [x]. It will ensure that our team takes your pull request seriously. -->\r\n\r\n- [x] I have read [freeCodeCamp's contribution guidelines](https://github.com/freeCodeCamp/freeCodeCamp/blob/master/CONTRIBUTING.md).\r\n- [x] My pull request has a descriptive title (not a vague title like `Update index.md`)\r\n- [x] My pull request targets the `master` branch of freeCodeCamp.\r\n- [x] None of my changes are plagiarized from another source without proper attribution.\r\n- [x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)\r\n- [x] My changes do not use shortened URLs or affiliate links.\r\n\r\n<!--If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.-->\r\n\r\nThe challenge [Basic CSS: Cascading CSS variables](https://learn.freecodecamp.org/responsive-web-design/basic-css/cascading-css-variables/) mixes up the concepts of inheritance and cascade. I rewrote things in terms of inheritance and, hopefully, clarified some of the wording.\r\n\r\nCloses #36108",
"title": "fix(curriculum): Change wording to talk about inheritance not cascade",
"type": "issue"
},
{
"action": "created",
"author": "RandellDawson",
"comment_id": 500178965,
"datetime": 1560046153000,
"masked_author": "username_1",
"text": "Thank you for your contribution to the page! 👍\r\nWe're happy to accept these changes, and look forward to future contributions. 🎉",
"title": null,
"type": "comment"
}
] | 2 | 2 | 1,258 | false | false | 1,258 | false |
oVirt/ovirt-ansible-hosted-engine-setup | oVirt | 355,294,053 | 17 | null | [
{
"action": "opened",
"author": "tiraboschi",
"comment_id": null,
"datetime": 1535569709000,
"masked_author": "username_0",
"text": "I fear that we have an issue on \r\n\r\n - name: Add an entry for this host on /etc/hosts on the local VM\r\n lineinfile:\r\n dest: /etc/hosts\r\n line: \"{{ he_host_ip }} {{ he_host_name }}\"\r\n\r\nin tasks/bootstrap_local_vm/03_engine_initial_tasks.yml\r\ndue to the fact that he_host_ip and he_host_name are empty there.",
"title": "Pass variables between role invocations",
"type": "issue"
},
{
"action": "closed",
"author": "tiraboschi",
"comment_id": null,
"datetime": 1544004769000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 320 | false | false | 320 | false |
kulshekhar/ts-jest | null | 203,807,036 | 103 | null | [
{
"action": "opened",
"author": "avandgard",
"comment_id": null,
"datetime": 1485609693000,
"masked_author": "username_0",
"text": "If I try to remove \"testResultsProcessor\" the watched test is working.\r\n\r\nIf I try to comment out lines (38-41) in coverageprocessor.js the watched test is working as well.\r\n\r\nThe only workaround I found is running coverage on demand separately (out of watched test). It makes sense but finding it out took some time.\r\n\r\nMaybe you will find a way how to fix it and if not others will find a way how to mitigate it earlier than me.",
"title": "The watched jest tests with results remapping fail.",
"type": "issue"
},
{
"action": "created",
"author": "kulshekhar",
"comment_id": 277652484,
"datetime": 1486379578000,
"masked_author": "username_1",
"text": "Would it be possible for you to create a minimal repo that reproduces this issue?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kulshekhar",
"comment_id": 287574542,
"datetime": 1489870933000,
"masked_author": "username_1",
"text": "Closing this.\r\n\r\nIf this is still an issue and if there is a minimal repo that can reproduce this, this issue can be reopened",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "kulshekhar",
"comment_id": null,
"datetime": 1489870934000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 636 | false | false | 636 | false |
local-motion/onboarding-web | local-motion | 381,561,502 | 58 | {
"number": 58,
"repo": "onboarding-web",
"user_login": "local-motion"
} | [
{
"action": "opened",
"author": "errrrk",
"comment_id": null,
"datetime": 1542367879000,
"masked_author": "username_0",
"text": "",
"title": "Onboarding map",
"type": "issue"
},
{
"action": "created",
"author": "gerard-payne",
"comment_id": 439370779,
"datetime": 1542369103000,
"masked_author": "username_1",
"text": "Incorrect merge of updated_layout branch. Recreating Pull request",
"title": null,
"type": "comment"
}
] | 2 | 2 | 65 | false | false | 65 | false |
OmniusLabs/Omnix | OmniusLabs | 424,673,813 | 6 | null | [
{
"action": "opened",
"author": "Lyrise",
"comment_id": null,
"datetime": 1553469886000,
"masked_author": "username_0",
"text": "",
"title": "[RocketPack] Recursive IDisposable call",
"type": "issue"
},
{
"action": "created",
"author": "lyrise",
"comment_id": 826003983,
"datetime": 1619224075000,
"masked_author": "username_1",
"text": "よく考えたら、子要素を他で使っている状況で、親要素をDisposeすると困る。\r\n\r\nなので、これは対応しない",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "lyrise",
"comment_id": null,
"datetime": 1619224076000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 55 | false | false | 55 | false |
material-components/material-components-android | material-components | 487,646,598 | 556 | null | [
{
"action": "opened",
"author": "opekope2",
"comment_id": null,
"datetime": 1567194848000,
"masked_author": "username_0",
"text": "**Description:** \r\nI have a ViewPager with fragments, rendering LinearLayouts. I change the LinearLayouts' content with addView() and removeView(). After a TextInputEditText gets focus in any activity or fragment and the soft keyboard appears, addView does not add views to the LinearLayout\r\n\r\n**Android API version:** \r\nTested on API 25 and API 28\r\n\r\n**Material Library version:**\r\nTested on 1.0.0 and 1.1.0-alpha09\r\n\r\n**Device:** \r\nGalaxy Nexus API 28 Emulator\r\nNexus 10 API 28 Emulator\r\nVernee Thor API 25 Device",
"title": "[TextInputEditText] TextInputEditText makes ViewPager render blank pages",
"type": "issue"
},
{
"action": "created",
"author": "opekope2",
"comment_id": 526735477,
"datetime": 1567196280000,
"masked_author": "username_0",
"text": "It's a bug in Android's EditText, not this library's fault",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "opekope2",
"comment_id": null,
"datetime": 1567196280000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 3 | 573 | false | false | 573 | false |
junegunn/fzf.vim | null | 417,869,270 | 777 | null | [
{
"action": "opened",
"author": "thornomad",
"comment_id": null,
"datetime": 1551886705000,
"masked_author": "username_0",
"text": "<!-- Check all that apply [x] -->\r\n- Category\r\n - [x] Question\r\n - [ ] Bug\r\n - [ ] Suggestion\r\n- OS\r\n - [ ] Linux\r\n - [x] macOS\r\n - [ ] Windows\r\n - [ ] Etc.\r\n- Vim\r\n - [ ] Vim\r\n - [x] Neovim\r\n\r\nI have a question about the order of results -- when I use `:GitFiles` and type in a partial file name, I tend to get the results in an order I would expect. However, when I use `:Buffers` and start typing, the order is different. How can I make `:Buffers` behave like `:GitFiles` ? \r\n\r\n### preferred order (see first hit) output `:GitFiles`\r\n\r\n\r\n### what I am getting with `:Buffers` (the `slip.rb` file that I would expect is far at the top)\r\n\r\n\r\n\r\nThe file I am expecting with `:Buffers` is not the first choice as it is with `:GitFiles`.\r\n\r\nThanks in advance for any help.",
"title": "Results order differs between :GitFiles/:Files and :Buffers",
"type": "issue"
},
{
"action": "created",
"author": "junegunn",
"comment_id": 470353696,
"datetime": 1551924286000,
"masked_author": "username_1",
"text": "`:Buffers` command lists open buffers in MRU-order (most recently used), and the difference in the initial orderings seems to affect the final result in your case. There's no easy way to fix this, as fzf is a general-purpose text filter rather than a file selector, the sorting algorithm is not specifically tailored for file paths.\r\n\r\n*A good way to prioritize `slip.rb` is to append `.` at the end of your query.* e.g. `slip.` or `s.`.\r\n\r\nThe entry with `slip` in its file name component gets a better score over the ones with `slip` in directory names, because in that case, `slip` is closer to `.`.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "junegunn",
"comment_id": null,
"datetime": 1551924286000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "thornomad",
"comment_id": 472066715,
"datetime": 1552406971000,
"masked_author": "username_0",
"text": "Thank you for the detailed response -- that tip about adding the `.` at the end of the query really helps in many situations. Thank you! I may look at changing the order of the buffers to align more with out the GitFiles sorts them ... maybe that would help. Thanks again for these tools!",
"title": null,
"type": "comment"
}
] | 2 | 4 | 1,909 | false | false | 1,909 | false |
antonbobkov/potato_game | null | 360,686,575 | 23 | {
"number": 23,
"repo": "potato_game",
"user_login": "antonbobkov"
} | [
{
"action": "opened",
"author": "pdlla",
"comment_id": null,
"datetime": 1537138118000,
"masked_author": "username_0",
"text": "",
"title": "more socket stuff",
"type": "issue"
},
{
"action": "created",
"author": "antonbobkov",
"comment_id": 421848166,
"datetime": 1537138481000,
"masked_author": "username_1",
"text": "MUCH PRODUCTIVE",
"title": null,
"type": "comment"
}
] | 2 | 2 | 15 | false | false | 15 | false |
girder/girder_worker | girder | 386,247,154 | 327 | null | [
{
"action": "opened",
"author": "subdavis",
"comment_id": null,
"datetime": 1543593643000,
"masked_author": "username_0",
"text": "Folder name: `UTM 2018-11-21T14:53:51.104Z`\r\n\r\n_docker_run:\r\n```\r\n(Pdb) pp container_args\r\n['/mnt/girder_worker/7723d0f170c1436b91deae01a83511d4/5bf5717f89f99f119ce51703/UTM '\r\n '2018-11-21T14:53:51.104Z',\r\n '/mnt/girder_worker/7723d0f170c1436b91deae01a83511d4/5bfea50989f99f119ce51d80/variables.csv',\r\n '--workingfolder',\r\n '/mnt/girder_worker/7723d0f170c1436b91deae01a83511d4/__results__']\r\n```\r\n\r\nError seen in celery: `cannot open file '2018-11-21T14:53:51.104Z': No such file or directory`",
"title": "spaces in girder folder name are incorrectly converted to container args.",
"type": "issue"
},
{
"action": "created",
"author": "subdavis",
"comment_id": 443284194,
"datetime": 1543600243000,
"masked_author": "username_0",
"text": "@username_1 \r\n\r\n```\r\n(Pdb) pp image\r\n'samuelgerber/utm'\r\n(Pdb) pp entrypoint\r\nNone\r\n(Pdb) pp volumes\r\n{'/tmp/tmpqbclifh4': {'bind': '/mnt/girder_worker/faa3b3626a104b19a115b7579abae1f6',\r\n 'mode': 'rw'}}\r\n(Pdb) pp container_args\r\n['/mnt/girder_worker/faa3b3626a104b19a115b7579abae1f6/5bf5717f89f99f119ce51703/UTM '\r\n '2018-11-21T14:53:51.104Z',\r\n '/mnt/girder_worker/faa3b3626a104b19a115b7579abae1f6/5bfea50989f99f119ce51d80/variables.csv',\r\n '--workingfolder',\r\n '/mnt/girder_worker/faa3b3626a104b19a115b7579abae1f6/__results__']\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kotfic",
"comment_id": 443284512,
"datetime": 1543600302000,
"masked_author": "username_1",
"text": "@username_2 i'm working on a failing test now",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kotfic",
"comment_id": 443343641,
"datetime": 1543612978000,
"masked_author": "username_1",
"text": "Turns out the string `'/mnt/girder_worker/faa3b3626a104b19a115b7579abae1f6/5bf5717f89f99f119ce51703/UTM 2018-11-21T14:53:51.104Z'` is not actually being split on the whitespace, **pdb** is choosing to split the string when ***printing***. The issue is the underlying container entrypoint script does not handle paths with spaces.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "kotfic",
"comment_id": null,
"datetime": 1543612978000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "zachmullen",
"comment_id": 443349312,
"datetime": 1543614375000,
"masked_author": "username_2",
"text": "For posterity, the entrypoint in question is [this R script](https://github.com/KitwareMedical/UTM/blob/master/Scripts/run.utm.barycenter.R).\r\n\r\nI don't know anything about R arg parsing, but from a quick glance, I'm guessing it's actually the result of how that R script makes subprocess calls internally to other R scripts (via the `system2` command).",
"title": null,
"type": "comment"
}
] | 3 | 6 | 1,775 | false | false | 1,775 | true |
dslemay/eslint-config-dslemay | null | 445,257,648 | 32 | {
"number": 32,
"repo": "eslint-config-dslemay",
"user_login": "dslemay"
} | [
{
"action": "opened",
"author": "dslemay",
"comment_id": null,
"datetime": 1558066688000,
"masked_author": "username_0",
"text": "",
"title": "fix: update eslint-plugin-react version range in package",
"type": "issue"
},
{
"action": "created",
"author": "dslemay",
"comment_id": 493314074,
"datetime": 1558066891000,
"masked_author": "username_0",
"text": ":tada: This PR is included in version 2.0.1 :tada:\n\nThe release is available on:\n- [npm package (@latest dist-tag)](https://www.npmjs.com/package/eslint-config-username_0)\n- [GitHub release](https://github.com/username_0/eslint-config-username_0/releases/tag/v2.0.1)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:",
"title": null,
"type": "comment"
}
] | 1 | 2 | 362 | false | false | 362 | true |
department-of-veterans-affairs/caseflow | department-of-veterans-affairs | 243,081,045 | 2,618 | null | [
{
"action": "opened",
"author": "abbyraskin",
"comment_id": null,
"datetime": 1500058300000,
"masked_author": "username_0",
"text": "**Story**\nAs a user, I want to know when my checked in cases are still loading, so I don't think my list is blank.\n\n## AC \n- [ ] Add loader (4 pt stars) with [reader green from style guide](https://dsva-appeals-certification-dev-1895622301.us-gov-west-1.elb.amazonaws.com/styleguide#loaders)\n- [ ] Copy underneath the loader is \"Loading cases in Reader...\"",
"title": "Welcome Gate | Loading indicator",
"type": "issue"
},
{
"action": "created",
"author": "kierachell",
"comment_id": 318644774,
"datetime": 1501246636000,
"masked_author": "username_1",
"text": "**PASSED**\r\nHOLYSHIT FINALLY\r\n",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "kierachell",
"comment_id": null,
"datetime": 1501246636000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 499 | false | false | 499 | false |
openshift/installer | openshift | 410,426,801 | 1,254 | {
"number": 1254,
"repo": "installer",
"user_login": "openshift"
} | [
{
"action": "opened",
"author": "deads2k",
"comment_id": null,
"datetime": 1550167901000,
"masked_author": "username_0",
"text": "cluster-config-operator is rendered and it produces CRD manifests, the ones\r\nin the installer are duplicates. This eliminates the cruft.\r\n\r\n/assign @username_1 @username_2",
"title": "bootkube: remove duplicate CRD manifests",
"type": "issue"
},
{
"action": "created",
"author": "wking",
"comment_id": 463737892,
"datetime": 1550168985000,
"masked_author": "username_1",
"text": "/lgtm",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "abhinavdahiya",
"comment_id": 463738213,
"datetime": 1550169033000,
"masked_author": "username_2",
"text": ":yay: /approve\r\n\r\nIf the CI goes green i'll `lgtm`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "deads2k",
"comment_id": 463800590,
"datetime": 1550179053000,
"masked_author": "username_0",
"text": "Known flake failures, well past bootstrapping. This completes work to clean up our CRD manifest story. Merging.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "abhinavdahiya",
"comment_id": 463801007,
"datetime": 1550179118000,
"masked_author": "username_2",
"text": "Talking to @ironcladlou the previous failure \r\nfrom [e2e-aws](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/1254/pull-ci-openshift-installer-master-e2e-aws/3708)\r\n\r\nwas known flake, so should be safe to override for you @username_0",
"title": null,
"type": "comment"
}
] | 5 | 10 | 5,290 | false | true | 614 | true |
elixirschool/elixirschool | elixirschool | 258,965,142 | 1,167 | {
"number": 1167,
"repo": "elixirschool",
"user_login": "elixirschool"
} | [
{
"action": "opened",
"author": "hlship",
"comment_id": null,
"datetime": 1505855357000,
"masked_author": "username_0",
"text": "As stated, the live version is for `Enum.chunk` which doesn't exist in Elixir 1.5.1.\r\n\r\nAlas, I'm not in a position to handle all the non-English translations.",
"title": "Update reference to Enum.chunk to modern Enum.chunk_every",
"type": "issue"
},
{
"action": "created",
"author": "doomspork",
"comment_id": 331648773,
"datetime": 1506184795000,
"masked_author": "username_1",
"text": "Thank you @username_0! I'll take care of the other languages 👍",
"title": null,
"type": "comment"
}
] | 2 | 2 | 218 | false | false | 218 | true |
yanatan16/passport-youtube-v3 | null | 87,367,620 | 3 | null | [
{
"action": "opened",
"author": "yanatan16",
"comment_id": null,
"datetime": 1434033224000,
"masked_author": "username_0",
"text": "From an email I received from Andre:\r\n\r\nI have a question regarding Passport-Youtubev3 strategy. It seems to be working however every single time, Google is prompting me to authorize with ‘Have offline access’. The strategy doesn’t seem to allow any additional parameters, however in your code, I found hardcoded following piece of code:\r\n\r\nhttps://github.com/username_0/passport-youtube-v3/blob/master/lib/passport-youtube-v3/strategy.js#L103\r\n```javascript\r\nStrategy.prototype.authorizationParams = function(options) {\r\n // test, should be passed through options\r\n return {\r\n access_type : 'offline',\r\n approval_prompt: 'force'\r\n }\r\n}\r\n```\r\n\r\nShould this piece of code be there? Would you have any other ideas?",
"title": "Offline Access",
"type": "issue"
},
{
"action": "created",
"author": "yanatan16",
"comment_id": 111156905,
"datetime": 1434033454000,
"masked_author": "username_0",
"text": "Yes these authorization parameters cause Google to try to authenticate the offline access ability. My gut feeling is that you'll want offline access, so you can use the access tokens later. \r\n\r\nhttps://developers.google.com/identity/protocols/OAuth2WebServer#offline\r\n\r\nThe best fix is probably to actually use the options object passed into that function with a default to the current parameters (for backwards compatibility)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yanatan16",
"comment_id": 111157853,
"datetime": 1434033710000,
"masked_author": "username_0",
"text": "We could just copy the code from https://github.com/jaredhanson/passport-google-oauth/blob/master/lib/passport-google-oauth/oauth2.js#L130",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RedPointMS",
"comment_id": 111211208,
"datetime": 1434042948000,
"masked_author": "username_1",
"text": "Thank you Jon",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yanatan16",
"comment_id": 112222059,
"datetime": 1434405449000,
"masked_author": "username_0",
"text": "Ok I merged the req and tagged the new version at `1.0.0`. Figured it should be 1.0 anyway. You'll have to update your `package.json` via `npm install passport-youtube-v3@1.0.0 --save`",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "yanatan16",
"comment_id": null,
"datetime": 1434405459000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "RedPointMS",
"comment_id": 112226695,
"datetime": 1434406706000,
"masked_author": "username_1",
"text": "Great! Thanks Jon",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "RedPointMS",
"comment_id": 112912998,
"datetime": 1434567246000,
"masked_author": "username_1",
"text": "Hi Jon,\r\nI must be missing something, I still have the same problem. It seems that whatever options I set, strategy defaults to 'force' however works fine if I change the hardcoded defaults in your code. Here is how I configure the strategy. What I am doing wrong?\r\n\r\n```javascript\r\npassport.use(new YoutubeV3Strategy({\r\n clientID: \"xxxxxxxxxxxxxxxxxxxxxxx\",\r\n clientSecret: \"xxxxxxxxxxxxxxxxxxxxx\",\r\n callbackURL: config.SERVER_LOCATION + \"/auth/youtube/return\",\r\n approval_prompt: 'auto',\r\n access_type: 'online',\r\n scope: ['https://www.googleapis.com/auth/youtube.readonly', 'https://www.googleapis.com/auth/plus.profile.emails.read']\r\n\r\n},\r\n function (accessToken, refreshToken, profile, done) {...\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yanatan16",
"comment_id": 114656634,
"datetime": 1435097535000,
"masked_author": "username_0",
"text": "Try \r\n```javascript\r\npassport.use(new YoutubeV3Strategy({\r\n clientID: \"xxxxxxxxxxxxxxxxxxxxxxx\",\r\n clientSecret: \"xxxxxxxxxxxxxxxxxxxxx\",\r\n callbackURL: config.SERVER_LOCATION + \"/auth/youtube/return\",\r\n authorizationParams: { \r\n approval_prompt: 'auto',\r\n access_type: 'online'\r\n },\r\n scope: ['https://www.googleapis.com/auth/youtube.readonly', 'https://www.googleapis.com/auth/plus.profile.emails.read']\r\n\r\n},\r\n function (accessToken, refreshToken, profile, done) {...\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bbatliner",
"comment_id": 130368302,
"datetime": 1439398372000,
"masked_author": "username_2",
"text": "@username_0 I have tried a config (see below) nearly identical to the one you proposed, and `approval_prompt` is still being set to `force`. If I set a breakpoint at the `authorizationParams` method in the Strategy source, `options` has no own properties (not even the other ones like `clientID`).\r\n```\r\n{\r\n \"clientID\": \"xxxxxxxxxxxxxxxxxxxxxx\",\r\n \"clientSecret\": \"xxxxxxxxxxxxxxxxxxxxxxx\",\r\n \"callbackURL\": \"/path/to/url\",\r\n \"profileURL\": \"https://www.googleapis.com/oauth2/v3/userinfo\",\r\n \"authorizationParams\": {\r\n \"access_type\": \"offline\",\r\n \"approval_prompt\": \"auto\"\r\n },\r\n \"scope\": [\"https://www.googleapis.com/auth/youtube\", \"email\", \"profile\"]\r\n}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yanatan16",
"comment_id": 131877343,
"datetime": 1439828274000,
"masked_author": "username_0",
"text": "@username_2 You are correct. The options that `authorizationParams` gets isn't the same as the `options` passed into `new YoutubeOAuth...`. So I've fixed this in 0b01605",
"title": null,
"type": "comment"
}
] | 3 | 11 | 3,572 | false | false | 3,572 | true |
hugsy/gef | null | 298,515,926 | 211 | null | [
{
"action": "opened",
"author": "u0m3",
"comment_id": null,
"datetime": 1519117275000,
"masked_author": "username_0",
"text": "### Step 1: Describe your environment\r\n\r\n * Operating System: Linux - 4.9.0-5-arm64 (64bit) on debian 9.3\r\n * Architecture: Arm64/AARCH64\r\n * GDB version (including the Python library version): **GDB** 7.12.0.20161007-git (**Python** 3.5.3 - final)\r\n\r\n\r\n### Step 2: Describe your problem\r\ngef fails to parse the sencond operand (`#imm` in ARM docs; operand[1] in gef code) because it's prefixed with a pound sign (`#`)\r\n\r\n#### Steps to reproduce\r\n\r\n 1. Debug any aarch64 binary with a _**TBZ**_ or _**TBNZ**_ instruction\r\n 1. Reach said instruction\r\n 1. Observe gef freak out\r\n\r\n#### Observed Results\r\nInstead of expected assembler display with contextual hints (in this case, branch followed/not followed hint), gef outputs an error message\r\n```\r\n[!] Command 'context' failed to execute properly, reason: invalid literal for int() with base 10: ' #31'\r\n```\r\n\r\n#### Expected results\r\nNormal gef operation\r\n\r\n#### Traces\r\nOutput with `gef config gef.debug 1`\r\n```\r\n─────────────────────────────── Exception raised ───────────────────────────────\r\nValueError: invalid literal for int() with base 10: ' #31'\r\n───────────────────────────── Detailed stacktrace ──────────────────────────────\r\n↳ File \"/home/radu/gef/gef.py\", line 1487, in is_branch_taken()\r\n → i = int(operands[1])\r\n↳ File \"/home/radu/gef/gef.py\", line 6535, in context_code()\r\n → is_taken, reason = current_arch.is_branch_taken(insn)\r\n↳ File \"/home/radu/gef/gef.py\", line 6395, in do_invoke()\r\n → layout_mapping[section]()\r\n↳ File \"/home/radu/gef/gef.py\", line 1994, in wrapper()\r\n → return f(*args, **kwargs)\r\n↳ File \"/home/radu/gef/gef.py\", line 3339, in invoke()\r\n → self.do_invoke(argv)\r\n───────────────────────────── Last 10 GDB commands ─────────────────────────────\r\n 250 b *0x000000000049bd5c\r\n 251 gef config context.clear_screen 1\r\n 252 r\r\n 253 context\r\n 254 gef config gef.debug 1\r\n 255 context\r\n 256 q\r\n 257 gef config gef.debug 1\r\n 258 b *0x000000000049bd5c\r\n 259 r\r\n───────────────────────────── Runtime environment ──────────────────────────────\r\n* GDB: 7.12.0.20161007-git\r\n* Python: 3.5.3 - final\r\n* OS: Linux - 4.9.0-5-arm64 (64bit) on debian 9.3\r\n────────────────────────────────────────────────────────────────────────────────\r\n```",
"title": "Failure to parse TBZ/TBNZ instruction #imm value for aarch64",
"type": "issue"
},
{
"action": "closed",
"author": "hugsy",
"comment_id": null,
"datetime": 1519147704000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "hugsy",
"comment_id": 367053721,
"datetime": 1519147704000,
"masked_author": "username_1",
"text": "Fixed by #213",
"title": null,
"type": "comment"
}
] | 2 | 3 | 2,288 | false | false | 2,288 | false |
apollographql/apollo-server | apollographql | 445,771,122 | 2,700 | null | [
{
"action": "opened",
"author": "dandv",
"comment_id": null,
"datetime": 1558230930000,
"masked_author": "username_0",
"text": "Not sure where to file this to get the appropriate attention:<sup>[1]</sup>\r\n\r\nThe [Introducing @defer](https://blog.apollographql.com/introducing-defer-in-apollo-server-f6797c4e9d6e) blog post got my colleague all excited about the feature, only to waste a good amount of time figuring out it was actually removed and on the roadmap for 3.0.\r\n\r\nPlease add a status notice at the top of that blog post.\r\n\r\n[1]: [Comments left to this end on the post itself](https://medium.com/@flavienvolken/what-is-the-current-status-of-defer-aa2bac8831bf) did not get attention",
"title": "Please update the @defer blog post",
"type": "issue"
},
{
"action": "created",
"author": "abernix",
"comment_id": 496239096,
"datetime": 1558969050000,
"masked_author": "username_1",
"text": "Thank you very much for opening this, @username_0, and apologies to your colleague for the time they had to expel while digging into this. I had some changes made to the blog post, including what I hope is a very clear warning that it's experimental and not production ready (and not in any current release!), which will hopefully save future readers.\r\n\r\nWe are still planning the re-introduction of `@defer`, but it's dependent on some other architectural changes to both the client and the server, in order to make sure that `@defer` can be supported end-to-end by client, server, tooling, Apollo Engine, etc.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "abernix",
"comment_id": null,
"datetime": 1558969050000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,170 | false | false | 1,170 | true |
SynoCommunity/spksrc | SynoCommunity | 397,738,087 | 3,573 | null | [
{
"action": "opened",
"author": "vinhpaint",
"comment_id": null,
"datetime": 1547112031000,
"masked_author": "username_0",
"text": "Log Details (ERROR)\r\nThu Jan 10 2019 14:46:53 GMT+0700 (Indochina Time)\r\n\r\nError while setting up platform broadlink\r\nTraceback (most recent call last):\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/homeassistant/helpers/entity_platform.py\", line 128, in _async_setup_platform\r\nSLOW_SETUP_MAX_WAIT, loop=hass.loop)\r\nFile \"/var/packages/python3/target/lib/python3.5/asyncio/tasks.py\", line 406, in wait_for\r\nreturn fut.result()\r\nFile \"/var/packages/python3/target/lib/python3.5/asyncio/futures.py\", line 294, in result\r\nraise self._exception\r\nFile \"/var/packages/python3/target/lib/python3.5/concurrent/futures/thread.py\", line 55, in run\r\nresult = self.fn(*self.args, **self.kwargs)\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/homeassistant/components/sensor/broadlink.py\", line 58, in setup_platform\r\nbroadlink_data = BroadlinkData(update_interval, host, mac_addr, timeout)\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/homeassistant/components/sensor/broadlink.py\", line 108, in __init__\r\nself._connect()\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/homeassistant/components/sensor/broadlink.py\", line 121, in _connect\r\nimport broadlink\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/broadlink/__init__.py\", line 5, in <module>\r\nfrom Crypto.Cipher import AES\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Cipher/__init__.py\", line 27, in <module>\r\nfrom Crypto.Cipher._mode_ecb import _create_ecb_cipher\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Cipher/_mode_ecb.py\", line 47, in <module>\r\n\"\"\"\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/_raw_api.py\", line 299, in load_pycryptodome_raw_lib\r\nraise OSError(\"Cannot load native module '%s': %s\" % (name, \", \".join(attempts)))\r\nOSError: Cannot load native module 'Crypto.Cipher._raw_ecb': Trying '_raw_ecb.cpython-35m-aarch64-linux-gnu.so': cannot load library '/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.cpython-35m-aarch64-linux-gnu.so': /volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.cpython-35m-aarch64-linux-gnu.so: cannot open shared object file: No such file or directory. Additionally, ctypes.util.find_library() did not manage to locate a library called '/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.cpython-35m-aarch64-linux-gnu.so', Trying '_raw_ecb.abi3.so': cannot load library '/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.abi3.so': /volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.abi3.so: cannot open shared object file: No such file or directory. Additionally, ctypes.util.find_library() did not manage to locate a library called '/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.abi3.so', Trying '_raw_ecb.so': cannot load library '/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.so': /volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.so: cannot open shared object file: No such file or directory. Additionally, ctypes.util.find_library() did not manage to locate a library called '/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.so'\r\n\r\nI installed the Home Assistant beta package and everything was fine since when I wanted to turn on broadlink RM component and also enable Broadlink RM for discover component. Did you see the same issue?\r\n\r\n### Setup\r\n_Package Name:_Home Assistant\r\n_Package Version:_0.82.1-2\r\n\r\n_NAS Model:_DS418\r\n_NAS Architecture:_Realtek RTD1296 SoC\r\n_DSM version:_DSM 6.2.1-23824 Update 4\r\n\r\n### Expected behavior\r\nHome Assistant 0.82.1-2\r\n\r\n### Actual behavior\r\nerror\r\n\r\n### Steps to reproduce\r\n_1._install Home Assistnat Beta\r\n_2._add into discovery component\r\nsensor:\r\n - platform: broadlink\r\n host: 192.168.2.202\r\n mac: 'B4:43:0D:B6:0C:CE'\r\n name: RMPro\r\n monitored_conditions:\r\n - temperature\r\n\r\n#### Package log\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/homeassistant/helpers/entity_platform.py\", line 128, in _async_setup_platform\r\nSLOW_SETUP_MAX_WAIT, loop=hass.loop)\r\nFile \"/var/packages/python3/target/lib/python3.5/asyncio/tasks.py\", line 406, in wait_for\r\nreturn fut.result()\r\nFile \"/var/packages/python3/target/lib/python3.5/asyncio/futures.py\", line 294, in result\r\nraise self._exception\r\nFile \"/var/packages/python3/target/lib/python3.5/concurrent/futures/thread.py\", line 55, in run\r\nresult = self.fn(*self.args, **self.kwargs)\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/homeassistant/components/sensor/broadlink.py\", line 58, in setup_platform\r\nbroadlink_data = BroadlinkData(update_interval, host, mac_addr, timeout)\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/homeassistant/components/sensor/broadlink.py\", line 108, in __init__\r\nself._connect()\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/homeassistant/components/sensor/broadlink.py\", line 121, in _connect\r\nimport broadlink\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/broadlink/__init__.py\", line 5, in <module>\r\nfrom Crypto.Cipher import AES\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Cipher/__init__.py\", line 27, in <module>\r\nfrom Crypto.Cipher._mode_ecb import _create_ecb_cipher\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Cipher/_mode_ecb.py\", line 47, in <module>\r\n\"\"\"\r\nFile \"/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/_raw_api.py\", line 299, in load_pycryptodome_raw_lib\r\nraise OSError(\"Cannot load native module '%s': %s\" % (name, \", \".join(attempts)))\r\nOSError: Cannot load native module 'Crypto.Cipher._raw_ecb': Trying '_raw_ecb.cpython-35m-aarch64-linux-gnu.so': cannot load library '/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.cpython-35m-aarch64-linux-gnu.so': /volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.cpython-35m-aarch64-linux-gnu.so: cannot open shared object file: No such file or directory. Additionally, ctypes.util.find_library() did not manage to locate a library called '/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.cpython-35m-aarch64-linux-gnu.so', Trying '_raw_ecb.abi3.so': cannot load library '/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.abi3.so': /volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.abi3.so: cannot open shared object file: No such file or directory. Additionally, ctypes.util.find_library() did not manage to locate a library called '/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.abi3.so', Trying '_raw_ecb.so': cannot load library '/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.so': /volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.so: cannot open shared object file: No such file or directory. Additionally, ctypes.util.find_library() did not manage to locate a library called '/volume1/@appstore/homeassistant/env/lib/python3.5/site-packages/Crypto/Util/../Cipher/_raw_ecb.so'",
"title": "Home Assistant - Error while setting up platform broadlink",
"type": "issue"
},
{
"action": "created",
"author": "hgy59",
"comment_id": 732695204,
"datetime": 1606201090000,
"masked_author": "username_1",
"text": "This might be fixed with python3 3.7.7 (and current home assistant v0.114.2-7)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "hgy59",
"comment_id": null,
"datetime": 1609066574000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 7,814 | false | false | 7,814 | false |
kubernetes/kubernetes | kubernetes | 256,343,784 | 52,192 | {
"number": 52192,
"repo": "kubernetes",
"user_login": "kubernetes"
} | [
{
"action": "opened",
"author": "liyinan926",
"comment_id": null,
"datetime": 1504897439000,
"masked_author": "username_0",
"text": "**What this PR does / why we need it**:\r\nThis PR setup and added initial integration tests for the DaemonSet controller. All tests included were ported from their unit test counterparts that currently use fake client, informers, reactor, etc. \r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: #52191.\r\n\r\n**Special notes for your reviewer**:\r\n@username_2 \r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```",
"title": "Initial integration test setup for DaemonSet controller",
"type": "issue"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 328188648,
"datetime": 1504897539000,
"masked_author": "username_0",
"text": "/unassign @bowei\r\n/unassign @ixdy\r\n/assign @username_2",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xiangpengzhao",
"comment_id": 328312181,
"datetime": 1505004189000,
"masked_author": "username_1",
"text": "/ok-to-test",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 328313599,
"datetime": 1505006983000,
"masked_author": "username_0",
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 331773023,
"datetime": 1506312839000,
"masked_author": "username_0",
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 337975726,
"datetime": 1508433285000,
"masked_author": "username_0",
"text": "@username_2 can you take a look?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 338790746,
"datetime": 1508791457000,
"masked_author": "username_0",
"text": "@username_2 this is the PR I mentioned.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 338805156,
"datetime": 1508794873000,
"masked_author": "username_0",
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kow3ns",
"comment_id": 339738626,
"datetime": 1509038690000,
"masked_author": "username_2",
"text": "/approve",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 339741196,
"datetime": 1509039248000,
"masked_author": "username_0",
"text": "Updated the BUILD file.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 339742558,
"datetime": 1509039534000,
"masked_author": "username_0",
"text": "/assign @username_4",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cjwagner",
"comment_id": 339834928,
"datetime": 1509062738000,
"masked_author": "username_3",
"text": "/retest",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xiangpengzhao",
"comment_id": 339843616,
"datetime": 1509066382000,
"masked_author": "username_1",
"text": "```\r\nI1027 00:16:13.422] Verifying hack/make-rules/../../hack/verify-bazel.sh\r\nI1027 00:16:31.893] diff -Naupr /go/src/k8s.io/kubernetes/test/integration/daemonset/BUILD /tmp/verify-bazel.xWgF3c/go/src/k8s.io/kubernetes/test/integration/daemonset/BUILD\r\nI1027 00:16:31.893] --- /go/src/k8s.io/kubernetes/test/integration/daemonset/BUILD\t2017-10-27 00:10:16.262995885 +0000\r\nI1027 00:16:31.893] +++ /tmp/verify-bazel.xWgF3c/go/src/k8s.io/kubernetes/test/integration/daemonset/BUILD\t2017-10-27 00:16:25.471230559 +0000\r\nI1027 00:16:31.894] @@ -15,7 +15,6 @@ go_test(\r\nI1027 00:16:31.894] importpath = \"k8s.io/kubernetes/test/integration/daemonset\",\r\nI1027 00:16:31.894] tags = [\"integration\"],\r\nI1027 00:16:31.894] deps = [\r\nI1027 00:16:31.894] - \"//pkg/api:go_default_library\",\r\nI1027 00:16:31.894] \"//pkg/api/v1/pod:go_default_library\",\r\nI1027 00:16:31.895] \"//pkg/controller/daemon:go_default_library\",\r\nI1027 00:16:31.895] \"//test/integration/framework:go_default_library\",\r\nI1027 00:16:31.895] \r\nI1027 00:16:31.895] Run ./hack/update-bazel.sh\r\nI1027 00:16:32.636] FAILED hack/make-rules/../../hack/verify-bazel.sh\t19s\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 339872024,
"datetime": 1509079897000,
"masked_author": "username_0",
"text": "Fixed the bazel build file.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "liyinan926",
"comment_id": 340562371,
"datetime": 1509392799000,
"masked_author": "username_0",
"text": "@username_4 Can you take a look? Thanks!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mikedanese",
"comment_id": 340847492,
"datetime": 1509472370000,
"masked_author": "username_4",
"text": "/approve",
"title": null,
"type": "comment"
}
] | 7 | 43 | 54,618 | false | true | 1,958 | true |
Level/leveldown | Level | 325,215,140 | 479 | {
"number": 479,
"repo": "leveldown",
"user_login": "Level"
} | [
{
"action": "created",
"author": "ralphtheninja",
"comment_id": 390930122,
"datetime": 1526982313000,
"masked_author": "username_0",
"text": "This is quite annoying. I did `npm publish` on `abstract-leveldown` and even received email from npm that it was published, but can't find it when trying to install it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vweevers",
"comment_id": 390948629,
"datetime": 1526986473000,
"masked_author": "username_1",
"text": "@username_0 that's weird. The registry doesn't show 5.0.0: https://registry.npmjs.org/abstract-leveldown",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vweevers",
"comment_id": 390949111,
"datetime": 1526986592000,
"masked_author": "username_1",
"text": "Npm is having some issues: https://status.npmjs.org/",
"title": null,
"type": "comment"
}
] | 3 | 4 | 4,399 | false | true | 327 | true |
mgravell/protobuf-net | null | 351,506,146 | 444 | null | [
{
"action": "opened",
"author": "MaxXor",
"comment_id": null,
"datetime": 1534495053000,
"masked_author": "username_0",
"text": "Hello, I'm currently using classes like this:\r\n\r\n```csharp\r\n public interface ICreature\r\n {\r\n }\r\n\r\n [ProtoContract]\r\n public class Human : ICreature\r\n {\r\n [ProtoMember(1)]\r\n public string Name{ get; set; }\r\n }\r\n\r\n [ProtoContract]\r\n public class Animal : ICreature\r\n {\r\n [ProtoMember(1)]\r\n public string Name{ get; set; }\r\n }\r\n```\r\n\r\nTo correctly un/serialize this with `Serializer.Deserialize<ICreature>(input)` I have to add them manually via:\r\n\r\n```csharp\r\nRuntimeTypeModel.Default[typeof(ICreature)].AddSubType(0, typeof(Human));\r\nRuntimeTypeModel.Default[typeof(ICreature)].AddSubType(1, typeof(Animal));\r\n```\r\n\r\nIs there any easier way to do this, without having to manually add all the sub types to the default model?",
"title": "Inheritance question",
"type": "issue"
},
{
"action": "created",
"author": "mgravell",
"comment_id": 413799388,
"datetime": 1534495439000,
"masked_author": "username_1",
"text": "This seems to work:\r\n\r\n```c#\r\n static void Main()\r\n {\r\n Serializer.PrepareSerializer<ICreature>();\r\n var creatures = new ICreature[] { new Human(), new Animal() };\r\n\r\n var clone = Serializer.DeepClone(creatures);\r\n Console.WriteLine(clone[0]); // Human\r\n Console.WriteLine(clone[1]); // Animal\r\n }\r\n\r\n [ProtoContract]\r\n [ProtoInclude(1, typeof(Human))]\r\n [ProtoInclude(2, typeof(Animal))]\r\n public interface ICreature\r\n {\r\n }\r\n```\r\n\r\nNote: `AddSubType(0, ...)` **should not work** - if it does, that's a bug - `0` is not a valid tag in protobuf.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MaxXor",
"comment_id": 413849641,
"datetime": 1534508768000,
"masked_author": "username_0",
"text": "Oh nevermind, you example is indeed working, thanks!",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "MaxXor",
"comment_id": null,
"datetime": 1534508768000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "MaxXor",
"comment_id": 413850227,
"datetime": 1534508927000,
"masked_author": "username_0",
"text": "When exactly is it required to call `PrepareSerializer`?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mgravell",
"comment_id": 413874007,
"datetime": 1534514183000,
"masked_author": "username_1",
"text": "good question; I haven't dug into which cog exactly fell out here; but: it is a good \"catch all\" for any problems of this kind; the 3.0 branch includes a new \"create a compiled type model for this entire assembly\" which I would recommend as a replacement - it is faster, too, and you don't need to worry about calling it multiple times (it does all the right things for reuse, etc).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mgravell",
"comment_id": 413884389,
"datetime": 1534516234000,
"masked_author": "username_1",
"text": "Confusingly, it is the `split-reader` branch. It made sense at the time, but it now encompasses all of the 3.0 changes (which are incomplete, in particular if you're using the new \"pipelines\" support).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MaxXor",
"comment_id": 415982368,
"datetime": 1535215998000,
"masked_author": "username_0",
"text": "I'm now adding a plugin system to my software and will use this to add dynamically new types to the serializer. This will continue to work in the v3.0, right?\r\n```csharp\r\nRuntimeTypeModel.Default[typeof(IBaseType)].AddSubType(counter, typeof(DerivedClass));\r\n```",
"title": null,
"type": "comment"
}
] | 2 | 8 | 2,344 | false | false | 2,344 | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.