repo stringlengths 7 67 | org stringlengths 2 32 ⌀ | issue_id int64 780k 941M | issue_number int64 1 134k | pull_request dict | events list | user_count int64 1 77 | event_count int64 1 192 | text_size int64 0 329k | bot_issue bool 1 class | modified_by_bot bool 2 classes | text_size_no_bots int64 0 279k | modified_usernames bool 2 classes |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
openbmc/openbmc-test-automation | openbmc | 409,189,452 | 1,602 | null | [
{
"action": "opened",
"author": "gkeishin",
"comment_id": null,
"datetime": 1549962179000,
"masked_author": "username_0",
"text": "Dev: https://github.com/ibm-openbmc/dev/issues/278",
"title": "Redfish: CPU Processors (missing properties) ",
"type": "issue"
},
{
"action": "created",
"author": "gkeishin",
"comment_id": 512356894,
"datetime": 1563381137000,
"masked_author": "username_0",
"text": "```\r\n$ curl -k -H \"X-Auth-Token: $bmc_token\" -X GET https://${BMC_IP}/redfish/v1/Systems/system/Processors/cpu0\r\n{\r\n \"@odata.context\": \"/redfish/v1/$metadata#Processor.Processor\",\r\n \"@odata.id\": \"/redfish/v1/Systems/system/Processors/cpu0\",\r\n \"@odata.type\": \"#Processor.v1_3_1.Processor\",\r\n \"Id\": \"cpu0\",\r\n \"InstructionSet\": \"PowerISA\",\r\n \"Manufacturer\": \"IBM\",\r\n \"Model\": \"\",\r\n \"Name\": \"Processor\",\r\n \"ProcessorArchitecture\": \"Power\",\r\n \"ProcessorType\": \"CPU\",\r\n \"Status\": {\r\n \"Health\": \"OK\",\r\n \"State\": \"Enabled\"\r\n },\r\n \"TotalCores\": 18\r\n}\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gkeishin",
"comment_id": 512358037,
"datetime": 1563381323000,
"masked_author": "username_0",
"text": "````\r\nhttps://gerrit.openbmc-project.xyz/#/c/openbmc/bmcweb/+/18590/\r\n\r\nThe scope of this issue is limited to \"TotalCores\". The remaining missing fields Model, PartNumber, SerialNumber, ProductionDate, Producer, and Version will be implemented as part of Assembly.\r\n```\r\n\r\nso \r\n```\r\n \"TotalCores\": 18 <-----\r\n```",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "gkeishin",
"comment_id": null,
"datetime": 1563381746000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 4 | 927 | false | false | 927 | false |
jaggedsoft/php-binance-api | null | 362,024,994 | 192 | null | [
{
"action": "opened",
"author": "andibastian",
"comment_id": null,
"datetime": 1537421713000,
"masked_author": "username_0",
"text": "can i use array for symbol in $api->ticker() ?",
"title": "Websocket $api->ticker array",
"type": "issue"
},
{
"action": "closed",
"author": "jaggedsoft",
"comment_id": null,
"datetime": 1537433220000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "jaggedsoft",
"comment_id": 423097672,
"datetime": 1537433220000,
"masked_author": "username_1",
"text": "```php\r\n$api->ticker(\"BNBBTC\", function($api, $symbol, $ticker) {\r\n\tprint_r($ticker);\r\n});\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jaggedsoft",
"comment_id": 423097881,
"datetime": 1537433260000,
"masked_author": "username_1",
"text": "No, this function accepts `false` as the first parameter and it will return data for all symbols. Otherwise it will return only one at a time",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "njghamdi",
"comment_id": 470948966,
"datetime": 1552055719000,
"masked_author": "username_2",
"text": "Hi Bro, \r\n\r\nthis and all other websocket functions only show result if you print it as an array ( print_r), \r\nbut does not work if you print only some elements ( such as $ticker->element ) , any suggestion to get an element without print_r ?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jaggedsoft",
"comment_id": 470961881,
"datetime": 1552057982000,
"masked_author": "username_1",
"text": "use it like an array `$ticker['element'];` cheers bro",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "njghamdi",
"comment_id": 470966018,
"datetime": 1552058669000,
"masked_author": "username_2",
"text": "Thanks boss for the great job and quick response. I'm using this \r\n\r\n$api->ticker(false, function($api, $symbol, $ticker) {\r\n//\tprint_r($ticker);\r\n\techo $ticker['symbol'] . \" | \" . $ticker['quoteVolume'] ;\r\n\techo \"<hr>\";\r\n});\r\n but it does not show any result, if I uncommented \"print_r($ticker)\" all works fine! Isn't possible to show up the result without a need to print_r first?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jaggedsoft",
"comment_id": 470971795,
"datetime": 1552059636000,
"masked_author": "username_1",
"text": "`$ticker[$symbol]` my friend, and `$ticker[$symbol]['quoteVolume']`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "njghamdi",
"comment_id": 470978883,
"datetime": 1552060797000,
"masked_author": "username_2",
"text": "Unfortunately, does not work either. I got those notice errors \r\n\r\nPHP Notice: Undefined index: ETHBTC on line 38\r\nPHP Notice: Undefined index: LTCBTC on line 38\r\nPHP Notice: Undefined index: LTCBTC on line 38\r\nPHP Notice: Undefined index: BNBBTC on line 38\r\nPHP Notice: Undefined index: BNBBTC on line 38\r\nPHP Notice: Undefined index: NEOBTC on line 38\r\n\r\nand nothing show on the browser as well.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jaggedsoft",
"comment_id": 470980961,
"datetime": 1552061151000,
"masked_author": "username_1",
"text": "So you need to loop through the array that's returned when you pass `false` as the first parameter, because each object is sent from binance like this:\r\n```\r\nArray\r\n(\r\n [eventType] => 24hrTicker\r\n [eventTime] => 1552061024363\r\n [symbol] => OSTETH\r\n [priceChange] => 0.00001316\r\n [percentChange] => 7.565\r\n [averagePrice] => 0.00018461\r\n [prevClose] => 0.00017491\r\n [close] => 0.00018713\r\n [closeQty] => 6130.00000000\r\n [bestBid] => 0.00018617\r\n [bestBidQty] => 21664.00000000\r\n [bestAsk] => 0.00018704\r\n```\r\n\r\n```php\r\nrequire 'vendor/autoload.php';\r\n$api = new Binance\\API('','');\r\n$api->ticker(false, function($api, $symbol, $ticker) {\r\n\techo \"{$ticker['symbol']}: {$ticker['close']}\\n\";\r\n});\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "njghamdi",
"comment_id": 470983328,
"datetime": 1552061536000,
"masked_author": "username_2",
"text": "Wow, finally I got it works. \r\nAppreciate it all, you are the hero. Thank you very much.",
"title": null,
"type": "comment"
}
] | 3 | 11 | 2,265 | false | false | 2,265 | false |
EndyKaufman/kaufman-bot | null | 509,333,279 | 49 | null | [
{
"action": "closed",
"author": "EndyKaufman",
"comment_id": null,
"datetime": 1610967025000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 6,613 | false | true | 0 | false |
rails/rails-perftest | rails | 317,803,210 | 45 | {
"number": 45,
"repo": "rails-perftest",
"user_login": "rails"
} | [
{
"action": "opened",
"author": "khamusa",
"comment_id": null,
"datetime": 1524692274000,
"masked_author": "username_0",
"text": "This change should be backward-compatible with previous Rails versions.\r\n\r\nRails 4+ is deprecating `db:test:prepare` since it is now handled tranparently by Rails itself.",
"title": "Handle absense of rake db:test:prepare / test:prepare on recent Rails versions",
"type": "issue"
},
{
"action": "created",
"author": "khamusa",
"comment_id": 384445538,
"datetime": 1524693005000,
"masked_author": "username_0",
"text": "Oh gosh, just realized this is also a duplicate...",
"title": null,
"type": "comment"
}
] | 1 | 2 | 220 | false | false | 220 | false |
hypothesis/h | hypothesis | 326,199,515 | 5,046 | {
"number": 5046,
"repo": "h",
"user_login": "hypothesis"
} | [
{
"action": "opened",
"author": "seanh",
"comment_id": null,
"datetime": 1527179444000,
"masked_author": "username_0",
"text": "Depends on https://github.com/hypothesis/h/pull/5045\r\n\r\nThese tests are kind of duplicative of the existing [tests for `separate_replies`](https://github.com/hypothesis/h/blob/49fd4cb4e415ac79e8144715bb2f677f3926f678/tests/h/search/core_test.py#L124). The `separate_replies` tests also test that replies are filtered out of `annotation_ids` but annotations are left in. But those are tests for the `separate_replies` argument, which is partly implemented by `TopLevelAnnotationsFilter`, partly by `RepliesMatcher`, and partly by code in `Search` itself. The fact that `TopLevelAnnotationsFilter` and `RepliesMatcher` are used to implement `separate_replies` is an internal implementation detail (`separate_replies` could be refactored to no longer use `TopLevelAnnotationsFilter` and its tests would still pass).\r\n\r\nThe tests in this PR are tests for `TopLevelAnnotationsFilter` when used directly (without `separate_replies`) as is [done by activity pages](https://github.com/hypothesis/h/blob/362143c17d7cd090255d9d36d6fecfbbb750218e/h/activity/query.py#L171).\r\n\r\nAlso, `TopLevelAnnotationsFilter` has to have a `TestTopLevelAnnotationsFilter` where you would expect one to be, otherwise it would look like there were no tests for it. Meanwhile, the filtering out of replies (while leaving annotations in) kind of has to be tested by the `separate_replies` tests otherwise `separate_replies` isn't fully tested. (Because of the way the code is written you can't really write a \"Test that it uses `TopLevelAnnotationsFilter`\" test for `separate_replies` that uses a mock `TopLevelAnnotationsFilter`, you would have to mock out `Builder` or something.)",
"title": "Add tests for TopLevelAnnotationsFilter",
"type": "issue"
}
] | 2 | 2 | 1,652 | false | true | 1,652 | false |
kmagiera/react-native-gesture-handler | null | 339,242,234 | 243 | null | [
{
"action": "opened",
"author": "brunolemos",
"comment_id": null,
"datetime": 1531070508000,
"masked_author": "username_0",
"text": "Is there any port of this library for the web?\r\nI think @vincentriemer [started a port](https://twitter.com/vincentriemer/status/1006733233881600000) but not sure if that can be decoupled from react-native-dom.\r\n\r\nMotivation: I'm a believer that all react-native packages should have web support.\r\nSharing code between platforms is one of the strengths of react-native, so every library I add I check if it has web support or how easy would it be to implement it myself.",
"title": "Web support",
"type": "issue"
},
{
"action": "created",
"author": "osdnk",
"comment_id": 403778355,
"datetime": 1531219016000,
"masked_author": "username_1",
"text": "Hi, @username_0 \r\nThank you for this issue. We are conscious that this is extremely important to support web as well. We will keep it in mind to do it some day but unfortunately it won't be happen in the nearest future.\r\nThus I decided to close this issue, but I doesn't mean that your idea won't be done some day.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "osdnk",
"comment_id": null,
"datetime": 1531219016000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "jaulz",
"comment_id": 452682065,
"datetime": 1547037441000,
"masked_author": "username_2",
"text": "@username_0 I just created https://github.com/kmagiera/react-native-gesture-handler/pull/406 in case you want to use it on web as well.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yairopro",
"comment_id": 538732098,
"datetime": 1570357635000,
"masked_author": "username_3",
"text": "Seems it's being implemented.🤗\r\n\r\n[Post on github](https://github.com/kmagiera/react-native-reanimated/issues/169#issuecomment-533803491)\r\n[Post on tweeter](https://twitter.com/Baconbrix/status/1173825701192929280)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "elie222",
"comment_id": 540998405,
"datetime": 1570787522000,
"masked_author": "username_4",
"text": "Wondering what the state of this is atm. Trying to convert a RN project to web, but ran into an issue around RNGH. For now, I'll just remove this functionality from web, but interested if there's a way to get it working already/timeline",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "AntoineFacq",
"comment_id": 748015816,
"datetime": 1608288208000,
"masked_author": "username_5",
"text": "Any news about it ? It seems like many libraries are dependent of this one to work on web, isn't it?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "moonman239",
"comment_id": 1042319346,
"datetime": 1645046280000,
"masked_author": "username_6",
"text": "I think Web functionality would be awesome, because it would help us to decentralize the mobile environment. Imagine a future where you can sell your apps & in-app purchases without paying Apple $99/year + 30% of sales. Plus you can take cryptocurrency payments.",
"title": null,
"type": "comment"
}
] | 7 | 8 | 1,731 | false | false | 1,731 | true |
ImageMagick/ImageMagick | ImageMagick | 391,652,810 | 1,423 | null | [
{
"action": "opened",
"author": "paon-m",
"comment_id": null,
"datetime": 1545043385000,
"masked_author": "username_0",
"text": "Hi,\r\n\r\nwe are using php ImageMagick extension to process some jpeg images converting them in some lower formats:\r\n\r\n $im = new \\Imagick($filePath);\r\n //if height or width are greater than resize value resize image\r\n if ($im->getimagewidth() > $resizeDim || $im->getimageheight() > $resizeDim) {\r\n $im->resizeImage($resizeDim, $resizeDim, \\Imagick::FILTER_LANCZOS, 1, true);\r\n }\r\n $im->transformimagecolorspace(\\Imagick::COLORSPACE_RGB);\r\n $im->setImageFormat('jpg'); //change image format\r\n $im->writeImage($destinationFilePath);\r\n\r\nand sometimes we have php crashing with this assert:\r\n\r\nphp: magick/memory.c:508: CopyMagickMemory: Assertion `source != (const void *) ((void *)0)' failed. \r\n\r\nUnfortunately is not something that happens always on the same images but it seems to occur randomly, so we don't a have a way to reproduce it with a test case.\r\n\r\nTechnical data : \r\nRed Hat Enterprise Linux Server release 6.4\r\n4 cpu, 8gb ram\r\nphp 5.5.23\r\nImageMagick 6.5.7\r\n\r\nI know it's an old version of php and ImageMagick, so I would know if update them will solve the problem, if yes please advise on the version we should use.\r\nMany thanks in advance\r\n\r\nMassimo",
"title": "assertion failed in CopyMagickMemory ",
"type": "issue"
},
{
"action": "created",
"author": "dlemstra",
"comment_id": 447989067,
"datetime": 1545078833000,
"masked_author": "username_1",
"text": "I would advise you to wait a couple days for the new version. The current release has some issues with JPEG files that contain XMP profiles. But I have no idea if that will resolve your issue. That is something that you will have to find out for yourself.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "urban-warrior",
"comment_id": null,
"datetime": 1545491767000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 3 | 1,570 | false | false | 1,570 | false |
google/keytransparency | google | 406,656,990 | 1,184 | null | [
{
"action": "opened",
"author": "Zyqsempai",
"comment_id": null,
"datetime": 1549351008000,
"masked_author": "username_0",
"text": "After fixing this one https://github.com/google/keytransparency/issues/1182 I am getting thi error.\r\n```\r\n Could not create Env: env: failed to open database: error running statement \"CREATE DATABASE trl_1549349836763157901\": Error 1045: Access denied for user 'root'@'172.21.0.1' (using password: NO)\r\n```\r\nIt's an error from trillian testdb.go and it's supper confusing for me, the first `sql.Open` request is made outside on `127.0.0.1:3306` but in next step `db.ExecContext()` makes it on `172.21.0.1`\r\n\r\nSo the question is for what purpose do we have docker-compose mysql, if tests are not interacting with it?\r\nEven though, it should work, port is exposed, we have `MYSQL_RANDOM_ROOT_PASSWORD: \"yes\"`.",
"title": "Integration tests are not working with docker-compose mysql",
"type": "issue"
},
{
"action": "created",
"author": "gdbelvin",
"comment_id": 461443344,
"datetime": 1549549979000,
"masked_author": "username_1",
"text": "I got these errors too and it wasn't clear to me what the root case was. \r\nIt was able to fix it by starting the `db` container first like so:\r\n```sh\r\ndocker-compose down # stop all existing containers\r\ndocker-compose up -d db # start just the db container and make sure it comes online ok.\r\ndocker-compose up # start everything else\r\n```\r\n\r\nIn the process of investigating, I also realized we were handling SSL keys the wrong way which I fixed in #11191\r\n\r\n@username_0 could you verify whether these changes fix this issue?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gdbelvin",
"comment_id": 461447303,
"datetime": 1549550501000,
"masked_author": "username_1",
"text": "On further investigation, I can confirm that this is an issue. The integration tests, do expect the root mysql user to have an empty password which the `MYSQL_RANDOM_ROOT_PASSWORD: yes` obviously breaks. This is something I'll discuss with the team.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gdbelvin",
"comment_id": 461781542,
"datetime": 1549627297000,
"masked_author": "username_1",
"text": "Fixed by #1198",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "gdbelvin",
"comment_id": null,
"datetime": 1549650832000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 5 | 1,494 | false | false | 1,494 | true |
rgebhart/nanoBALLS | null | 416,208,480 | 3 | null | [
{
"action": "opened",
"author": "ccurtis7",
"comment_id": null,
"datetime": 1551461930000,
"masked_author": "username_0",
"text": "Make sure to get a good set of use cases and components before getting too far into the project. \r\n\r\n I would consider including a little background before jumping into your use cases, the organizing your use cases hierarchically, with descriptions of both inputs and outputs, as described in the Software Design lecture.\r\n\r\nAnd I would also consider putting your use cases in a MarkDown file, as this will help with readability.",
"title": "Use cases and components?",
"type": "issue"
},
{
"action": "created",
"author": "isaack8",
"comment_id": 468771272,
"datetime": 1551466463000,
"masked_author": "username_1",
"text": "Just submitted it, wanted to clean up the formatting",
"title": null,
"type": "comment"
}
] | 2 | 2 | 481 | false | false | 481 | false |
btcsuite/btcd | btcsuite | 439,325,554 | 1,426 | {
"number": 1426,
"repo": "btcd",
"user_login": "btcsuite"
} | [
{
"action": "opened",
"author": "cfromknecht",
"comment_id": null,
"datetime": 1556744809000,
"masked_author": "username_0",
"text": "This PR optimizes the `wire` packages serialization of small buffers by minimizing the number of borrow/return round trips during message serialization. Currently the `wire` package uses a `binaryFreeList` from which 8-byte buffers are borrowed and returned for the purpose of serializing small integers and varints.\r\n\r\n## Problem\r\nTo understand the problem, consider calling [`WriteVarInt`](https://github.com/btcsuite/btcd/blob/master/wire/common.go#L538) on a number greater than `0xfc` (which requires writing the discriminant and a 2, 4, or 8 byte value following).\r\n\r\nFor instance, writing 20,000 will invoke [`PutUint8`](https://github.com/btcsuite/btcd/blob/master/wire/common.go#L538) and then [`PutUint16`](https://github.com/btcsuite/btcd/blob/master/wire/common.go#L548). Expanding this out to examine the message passing, we see:\r\n```\r\nbuffer <- freelist\r\n\r\nPutUInt8(buffer, discriminant)\r\nw.Write(buffer)\r\n\r\nfreelist <- buffer\r\n\r\nbuffer <- freelist\r\n\r\nPutUint16(buffer, value)\r\nw.Write(buffer)\r\n\r\nfreelist <- buffer\r\n```\r\n\r\nEach `<-` requires a channel `select`, which more-or-less bears the performance implication of a mutex. This cost, in addition to need to wake up other goroutines and switch executions, imparts a significant performance penalty. In the context of block serialization, several hundred thousand of these operations may be performed.\r\n\r\n## Solution\r\n\r\nIn our example above, we can improve this by only using two `<-`, one to borrow and one to return, as so:\r\n\r\n```\r\nbuffer <- freelist\r\n\r\nPutUInt8(buffer, discriminant)\r\nw.Write(buffer)\r\n\r\nPutUint16(buffer, value)\r\nw.Write(buffer)\r\n\r\nfreelist <- buffer\r\n```\r\n\r\nAs expected, cutting the number channels sends in half cuts also cuts the latency in half, which can be seen in the benchmarks below for larger `VarInt`s, \r\n\r\nThe remainder of this PR is to propagate this pattern all the way up to the top level of messages in the wire package, such that deserializing a message only incurs one borrow and one return. Any subroutines are made to conditionally borrow from the `binarySerializer` if the invoker has not provided them with a buffer, and conditionally return if they indeed were required to borrow.\r\n\r\nA good example of how these channel sends/receives can add up is in MsgTx serialization, which is now upwards of 80% faster as a result of these optimizations:\r\n```\r\nbenchmark old ns/op new ns/op delta\r\nBenchmarkSerializeTx-8 683 142 -79.21%\r\nBenchmarkSerializeTxSmall-8 724 143 -80.25%\r\nBenchmarkSerializeTxLarge-8 1476002 182111 -87.66%\r\n```\r\n\r\n## Preliminary Benchmarks\r\n```\r\nbenchmark old ns/op new ns/op delta\r\nBenchmarkWriteVarInt1-8 71.9 74.6 +3.76%\r\nBenchmarkWriteVarInt3-8 148 70.9 -52.09%\r\nBenchmarkWriteVarInt5-8 149 71.0 -52.35%\r\nBenchmarkWriteVarInt9-8 147 72.8 -50.48%\r\nBenchmarkReadVarInt1-8 78.8 77.9 -1.14%\r\nBenchmarkReadVarInt3-8 159 87.7 -44.84%\r\nBenchmarkReadVarInt5-8 155 88.3 -43.03%\r\nBenchmarkReadVarInt9-8 158 86.9 -45.00%\r\nBenchmarkReadVarStr4-8 120 119 -0.83%\r\nBenchmarkReadVarStr10-8 138 130 -5.80%\r\nBenchmarkWriteVarStr4-8 101 105 +3.96%\r\nBenchmarkWriteVarStr10-8 103 105 +1.94%\r\nBenchmarkReadOutPoint-8 91.3 28.7 -68.57%\r\nBenchmarkWriteOutPoint-8 78.9 10.2 -87.07%\r\nBenchmarkReadTxOut-8 245 118 -51.84%\r\nBenchmarkWriteTxOut-8 151 93.5 -38.08%\r\nBenchmarkReadTxIn-8 338 139 -58.88%\r\nBenchmarkWriteTxIn-8 238 31.0 -86.97%\r\nBenchmarkDeserializeTxSmall-8 1119 586 -47.63%\r\nBenchmarkDeserializeTxLarge-8 2476063 1275815 -48.47%\r\nBenchmarkSerializeTx-8 683 142 -79.21%\r\nBenchmarkSerializeTxSmall-8 724 143 -80.25%\r\nBenchmarkSerializeTxLarge-8 1476002 182111 -87.66%\r\nBenchmarkReadBlockHeader-8 406 69.1 -82.98%\r\nBenchmarkWriteBlockHeader-8 431 21.1 -95.10%\r\nBenchmarkDecodeGetHeaders-8 13537 12238 -9.60%\r\nBenchmarkDecodeHeaders-8 1025275 236709 -76.91%\r\nBenchmarkDecodeGetBlocks-8 13206 11684 -11.53%\r\nBenchmarkDecodeAddr-8 337977 157519 -53.39%\r\nBenchmarkDecodeInv-8 5990935 1898169 -68.32%\r\nBenchmarkDecodeNotFound-8 6285831 1864701 -70.33%\r\nBenchmarkDecodeMerkleBlock-8 4357 2606 -40.19%\r\nBenchmarkTxHash-8 1928 1222 -36.62%\r\nBenchmarkDoubleHashB-8 993 969 -2.42%\r\nBenchmarkDoubleHashH-8 932 1029 +10.41%\r\n\r\nbenchmark old allocs new allocs delta\r\nBenchmarkWriteBlockHeader-8 4 0 -100.00%\r\n// all others remain 0 alloc\r\n\r\nbenchmark old bytes new bytes delta\r\nBenchmarkWriteBlockHeader-8 16 0 -100.00%\r\n// all others remain unchanged\r\n```\r\n\r\n## Notes\r\n\r\nI'm still in the process of going through and adding benchmarks to top-level messages in order to guage the overall performance benefit, expect more to be added at a later point.\r\n\r\nThere are a few remaining messages which have not yet been optimized, e.g. `MsgAlert`, `MsgVesion`, etc. I plan to add those as well but decided to start with the ones that were more performance critical.",
"title": "wire: only borrow/return binaryFreeList buffers at the message level",
"type": "issue"
},
{
"action": "created",
"author": "jakesyl",
"comment_id": 594513654,
"datetime": 1583327576000,
"masked_author": "username_1",
"text": "@jcvernaleo (as per #1530)\r\n\r\n- low priority\r\n- enhancement\r\n\r\nBy the way @username_0 this is awesome!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "cfromknecht",
"comment_id": 772684714,
"datetime": 1612373365000,
"masked_author": "username_0",
"text": "FWIW I rebased this PR (locally) over #1684 and reran the `CalcSighHash` benchmarks.\r\nSince calculating the legacy sighash involves [serializing a copy of the original transaction](https://github.com/btcsuite/btcd/blob/master/txscript/script.go#L658),\r\noptimizing our wire encoding speeds up the sighash calculation speed significantly. \r\n\r\nThis is a comparison of CalcSigHash before and after applying the wire optimizations\r\nto this branch: \r\n```\r\nbenchmark old ns/op new ns/op delta\r\nBenchmarkCalcSigHash-8 3619477 1758789 -51.41%\r\n\r\nbenchmark old allocs new allocs delta\r\nBenchmarkCalcSigHash-8 801 712 -11.11%\r\n\r\nbenchmark old bytes new bytes delta\r\nBenchmarkCalcSigHash-8 1293354 1290504 -0.22%\r\n```\r\n\r\nUsing an 80% transaction serialization speedup to ballpark, this indicates roughly 2/3 of\r\nthe latency incurred by`CalcSigHash` is transaction serialization, and with this change it\r\nbecomes 1/4.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "onyb",
"comment_id": 973109656,
"datetime": 1637257575000,
"masked_author": "username_2",
"text": "@username_0 Could you please rebase this PR, since https://github.com/btcsuite/btcd/pull/1769 landed recently?",
"title": null,
"type": "comment"
}
] | 4 | 5 | 9,481 | false | true | 7,235 | true |
cargomedia/puppet-packages | cargomedia | 121,869,265 | 1,052 | null | [
{
"action": "opened",
"author": "kris-lab",
"comment_id": null,
"datetime": 1449943174000,
"masked_author": "username_0",
"text": "",
"title": "Raid coverage for bulldog/ubuntu",
"type": "issue"
},
{
"action": "created",
"author": "njam",
"comment_id": 164280526,
"datetime": 1450028891000,
"masked_author": "username_1",
"text": "Closing in favor of https://github.com/cargomedia/puppet-packages/issues/1065",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "njam",
"comment_id": null,
"datetime": 1450028891000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 77 | false | false | 77 | false |
nov/apple_id | null | 509,115,991 | 3 | null | [
{
"action": "opened",
"author": "freestyl3r",
"comment_id": null,
"datetime": 1571408766000,
"masked_author": "username_0",
"text": "After a successful authentication with apple, `code` is returned.\r\nIn the authorize url we can request additional information through the scope param.\r\nDoing so will result in `user` object being returned as well.\r\n\r\nWhen users login through safari though, a native window modal (keychain) takes control and does the authorize request for us.\r\nFirst problem with that approach is that `nonce` is not passed through from our original authorize url, so we cannot use it to verify the front & back channel token.\r\nThe second problem is that when using multiple scopes, ex `[:email, :name]`, they are encoded like this `email+code`.\r\nThe html rfc spec states that in query params (stuff after ?) spaces can be encoded as signs '+' and everything before with '%20'.\r\nApple's native popup is not aware of the '+' as an encoding method and tries to interpret multiple scopes as a single value, which is of course incorrect and ends up ignoring it altogether.\r\n\r\nFor this reason when using the plain apple sign in button in your [example project](https://github.com/username_1/signin-with-apple) through safari and the native popup appears (and intercepts the call) email & name are never returned.\r\n\r\n\r\n\r\nWhen using the JS SDK provided by apple, the scope is url encoded (`email%20code`) and we get the information as expected. We also get the option to choose which name and email to share.\r\n\r\n\r\n\r\nps. The above examples were taken **after** revoking access to the heroku app from the apple id console, because apple gives the email & name **only** the first time for a new client.",
"title": "Email & name are not returned after authenticating with apple",
"type": "issue"
},
{
"action": "closed",
"author": "nov",
"comment_id": null,
"datetime": 1590055775000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "nov",
"comment_id": 632002308,
"datetime": 1590055775000,
"masked_author": "username_1",
"text": "https://github.com/username_1/apple_id/pull/4#issuecomment-632001645",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,773 | false | false | 1,773 | true |
coreos/etcd-operator | coreos | 242,210,115 | 1,275 | {
"number": 1275,
"repo": "etcd-operator",
"user_login": "coreos"
} | [
{
"action": "opened",
"author": "hongchaodeng",
"comment_id": null,
"datetime": 1499814445000,
"masked_author": "username_0",
"text": "[skip ci]",
"title": "e2e: use absolute retry attempts to avoid rounding",
"type": "issue"
},
{
"action": "created",
"author": "hongchaodeng",
"comment_id": 314598270,
"datetime": 1499814992000,
"masked_author": "username_0",
"text": "Stress testing this.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hongchaodeng",
"comment_id": 314599095,
"datetime": 1499815299000,
"masked_author": "username_0",
"text": "fix https://github.com/coreos/etcd-operator/issues/1256",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "xiang90",
"comment_id": 314599295,
"datetime": 1499815380000,
"masked_author": "username_1",
"text": "why skip ci for this? i saw there were ci failures. i am not sure if this is a fix for #1256 unless we can prove it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hongchaodeng",
"comment_id": 314599439,
"datetime": 1499815429000,
"masked_author": "username_0",
"text": "The failure will be fixed by second commit.\r\n\r\nYes. We are stress testing it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hongchaodeng",
"comment_id": 314850117,
"datetime": 1499882681000,
"masked_author": "username_0",
"text": "So this PR has evolved to do:\r\n- changing all timeout param to explicit retries to avoid rounding\r\n- making up for long overdue debts in e2e code: unifying all retry interval, unifying wait operator ready method",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hasbro17",
"comment_id": 314863697,
"datetime": 1499885684000,
"masked_author": "username_2",
"text": "SGTM. Are the stress tests for this PR running on jenkins?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hongchaodeng",
"comment_id": 314872051,
"datetime": 1499887665000,
"masked_author": "username_0",
"text": "@username_2 \r\nRight. But I think the problem is probably be solved by https://github.com/coreos/etcd-operator/issues/1276 . This PR is mostly refactoring our e2e code, making up for previous debts.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hongchaodeng",
"comment_id": 314892788,
"datetime": 1499892621000,
"masked_author": "username_0",
"text": "@etcd-bot retest this please",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "hasbro17",
"comment_id": 314893142,
"datetime": 1499892715000,
"masked_author": "username_2",
"text": "LGTM if CI passes",
"title": null,
"type": "comment"
}
] | 3 | 10 | 786 | false | false | 786 | true |
duheng/Mozi | null | 310,224,225 | 15 | null | [
{
"action": "opened",
"author": "peterfei",
"comment_id": null,
"datetime": 1522485375000,
"masked_author": "username_0",
"text": "能否重新给个接口数据?",
"title": "接口已失效",
"type": "issue"
},
{
"action": "created",
"author": "duheng",
"comment_id": 377890024,
"datetime": 1522659919000,
"masked_author": "username_1",
"text": "感谢你的反馈， 已经更换成今日头条接口了，有些可能没有图片，先凑合用吧。之前用的一点资讯的接口人家不让用了。",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "peterfei",
"comment_id": null,
"datetime": 1523158804000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 65 | false | false | 65 | false |
certbot/certbot | certbot | 338,795,660 | 6,180 | null | [
{
"action": "opened",
"author": "Daniel15",
"comment_id": null,
"datetime": 1530848814000,
"masked_author": "username_0",
"text": "`certbot --help certonly` does not explain that the `--deploy-hook` function can be used to run a deploy hook after issuing the certificate, and that it **also** configures the hook to run on renewals too (by adding it to `/etc/letsencrypt/renewal/example.com.conf` as a `renew_hook` option). This is very useful to know.",
"title": "--deploy-hook not documented in certbot certonly docs",
"type": "issue"
},
{
"action": "created",
"author": "joohoi",
"comment_id": 403080956,
"datetime": 1530894007000,
"masked_author": "username_1",
"text": "Thanks for opening the issue! \r\n\r\nYou are right, and we actually have even more hook functionality baked in. There's a longish description of them in [certbot documentation](https://certbot.eff.org/docs/using.html#renewing-certificates). I believe the preferred way of handling the hooks is the hook directories in `/etc/letsencrypt/renewal-hooks` to give better visibility for users what's running and when. I'll bring your point up for discussion with the team.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "joohoi",
"comment_id": 403090504,
"datetime": 1530896236000,
"masked_author": "username_1",
"text": "You can check the certificate within the deploy hook script by using the environment variables `RENEWED_DOMAINS` or `RENEWED_LINEAGE` populated by Certbot to single out the certificate you want to act upon.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "GrahamH68",
"comment_id": 437710480,
"datetime": 1541974783000,
"masked_author": "username_2",
"text": "Are scripts in the deploy directory meant to be called on first creation of a certificate when using CERTONLY with DNS01 ?\r\n\r\nI have a simple script to echo out the contents of RENEWED_LINEAGE and RENEWED_DOMAINS, but it doesn't see to be called when a certificate is created.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mohag",
"comment_id": 439450260,
"datetime": 1542386087000,
"masked_author": "username_3",
"text": "To me it feels as if it might make to not add the `--deploy-hook` value to the config file (especially in the undocumented state). Keeping the `--renew-hook` option (at least on `certonly` and `run` seems like it might result in less unexpected behaviour) (I want to use `--deploy-hook` for a script that installs the certificate initially and it might not be safe to run multiple times...) (e..g append certificate options with filenames at the end of a configuration file)\r\n\r\n(If not this, some other way of separating installation and renewal hooks does seem useful for these reasons...)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mssaisandeep",
"comment_id": 487284720,
"datetime": 1556370370000,
"masked_author": "username_4",
"text": "I am facing the same issue, Running deploy hook for the cert generation will be called sometimes and may not be called sometimes. So is there any hook that I can use for every successful certificate generation(generating/renewal)?? \r\n\r\nBTW if I use certbot certonly --deploy-hook, then that --deploy-hook is getting converted to --renewal-hook in /etc/letsencrypt/renewal/<domainaname>.conf file. \r\n\r\nPlease help me.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lonix1",
"comment_id": 538646422,
"datetime": 1570279230000,
"masked_author": "username_5",
"text": "Has anyone found the answer?\r\n\r\nI also want to have a hook run after *cert creation*, but they only reliably run after *cert renewal*.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bmw",
"comment_id": 539233867,
"datetime": 1570487887000,
"masked_author": "username_6",
"text": "@username_5, you may also find my previous response useful, but the approach you have taken here will cause that script to be run whenever a certificate is issued with any subcommand. If that's the behavior you want, you're good to go!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mohag",
"comment_id": 706027670,
"datetime": 1602229609000,
"masked_author": "username_3",
"text": "Documentation page still does not list it under certonly",
"title": null,
"type": "comment"
}
] | 8 | 10 | 3,031 | false | true | 2,693 | true |
concur/developer.concur.com | concur | 414,874,660 | 1,854 | {
"number": 1854,
"repo": "developer.concur.com",
"user_login": "concur"
} | [
{
"action": "opened",
"author": "RoAnnC1",
"comment_id": null,
"datetime": 1551224628000,
"masked_author": "username_0",
"text": "These images weren't displaying due to incorrect paths.",
"title": "Update image paths with hyphen instead of underscore.",
"type": "issue"
},
{
"action": "created",
"author": "sarraloew",
"comment_id": 467670184,
"datetime": 1551226764000,
"masked_author": "username_1",
"text": ":shipit:",
"title": null,
"type": "comment"
}
] | 2 | 2 | 63 | false | false | 63 | false |
safex/safexcore | safex | 381,671,266 | 81 | null | [
{
"action": "opened",
"author": "KrzysztofHajdamowicz",
"comment_id": null,
"datetime": 1542385777000,
"masked_author": "username_0",
"text": "When downloaded safexcore zip from release pages, subdirectories of git submodules are empty.\r\nReady-to-go release packages should contain such files.",
"title": "Release .zip and .tar.gz doesn't cointain recursive submodules",
"type": "issue"
},
{
"action": "created",
"author": "atanmarko",
"comment_id": 439451522,
"datetime": 1542386320000,
"masked_author": "username_1",
"text": "Thanks for pointing out!\r\nGithub makes automatically source code files from the particular commit that does not include submodules. We'll check how to deal with that.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "atanmarko",
"comment_id": 439606688,
"datetime": 1542450696000,
"masked_author": "username_1",
"text": "Seems that it is not possible to do it automatically.\r\n\r\nhttps://stackoverflow.com/questions/34719785/how-to-add-submodule-files-to-a-github-release\r\n\r\nYou can always download source code from release branch:\r\n`git clone https://github.com/safex/safexcore.git --branch release-v0.1.1 --recursive`",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "atanmarko",
"comment_id": null,
"datetime": 1542451301000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "KrzysztofHajdamowicz",
"comment_id": 439607921,
"datetime": 1542452109000,
"masked_author": "username_0",
"text": "Is it a proper fix? I doubt so.\r\nProper fix should be done by taking down broken downloads and fixing manual about getting the code.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "atanmarko",
"comment_id": 439608985,
"datetime": 1542453311000,
"masked_author": "username_1",
"text": "Thanks for suggestions. You are welcome to help us and propose a way how to patch Github source code release procedure, as it does not give option to change or remove zip and tar.gz file included in the release. Binaries are created and uploaded manually, but source code files are directly tied to the commit/tag on the branch, and Github packs them and attaches them to the release in the background without exposing customization option.\r\nInstructions how to clone and compile from source code are available in Readme.\r\nIn case you have any ideas how we can improve things, please create a pull request and we will be happy to review and integrate it.",
"title": null,
"type": "comment"
}
] | 2 | 6 | 1,398 | false | false | 1,398 | false |
napalm-automation-community/napalm-dellos10 | napalm-automation-community | 358,995,551 | 17 | null | [
{
"action": "opened",
"author": "lboue",
"comment_id": null,
"datetime": 1536663690000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nI am facing an issue when I execute my Python script and call the get_mac_address_table method. Here is the snippet:\r\n```\r\ndriver = get_network_driver(driver_name)\r\ndevice = driver(host, 'admin', password, optional_args={'global_delay_factor': 3})\r\n\r\nmacAddrTable = device.get_mac_address_table()\r\nprint(\"macAddrTable:\")\r\npp.pprint(macAddrTable)\r\n```\r\n\r\n\r\nIt is complaining about XML formatting: \r\n`Response from the device is not in expected format : <?xml version=\"1.0\" encoding=\"UTF-8\"?>`\r\n\r\n\r\nMy device is a DELL **EMC S5148F-ON**.\r\n\r\n```\r\npython napalm-dellos10-get_mac-addr-table.py \r\nTraceback (most recent call last):\r\n File \"napalm-dellos10-get_mac-addr-table.py\", line 25, in <module>\r\n macAddrTable = device.get_mac_address_table()\r\n File \"/home/user/.local/lib/python2.7/site-packages/napalm_dellos10/dellos10.py\", line 800, in get_mac_address_table\r\n routes_xml_data = self.convert_xml_data(lldp_neighbors_output)\r\n File \"/home/user/.local/lib/python2.7/site-packages/napalm_dellos10/dellos10.py\", line 1775, in convert_xml_data\r\n raise CommandErrorException(msg.format(output))\r\nnapalm.base.exceptions.CommandErrorException: Response from the device is not in expected format : <?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n<rpc-reply>\r\n <bulk>\r\n <data>\r\n <fwd-table>\r\n <mac-addr>00:50:56:**:**:**</mac-addr>\r\n <vlan>vlan1</vlan>\r\n <entry-type>dynamic</entry-type>\r\n <if-name>port-channel5</if-name>\r\n </fwd-table>\r\n <fwd-table>\r\n <mac-addr>00:50:56:**:**:**</mac-addr>\r\n <vlan>vlan1</vlan>\r\n <entry-type>dynamic</entry-type>\r\n <if-name>port-channel3</if-name>\r\n </fwd-table>\r\n <fwd-table>\r\n ....\r\n```\r\n\r\nAre you facing the same issue too?\r\n\r\nRegards,\r\nLudovic",
"title": "get_mac_address_table method: Response from the device is not in expected format",
"type": "issue"
},
{
"action": "created",
"author": "javeedf",
"comment_id": 420247048,
"datetime": 1536666872000,
"masked_author": "username_1",
"text": "Hi Ludovic,\n\nWe didn't face this issue. Could you please send the complete debug log?\n\nWhat is the OS10 Version are you using?\n\nThanks\nMohamed Javeed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lboue",
"comment_id": 420277643,
"datetime": 1536673094000,
"masked_author": "username_0",
"text": "We are running 10.4.1.0. Here is the CLI output:\r\n\r\n```\r\nOS10# show version \r\nDell EMC Networking OS10-Enterprise\r\nCopyright (c) 1999-2018 by Dell Inc. All Rights Reserved.\r\nOS Version: 10.4.1.0\r\nBuild Version: 10.4.1.0.483\r\nBuild Time: 2018-07-27T09:26:42-0700\r\nSystem Type: S5148F-ON\r\nArchitecture: x86_64\r\n```\r\n\r\nRegards,\r\nLudovic",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "javeedf",
"comment_id": 420929956,
"datetime": 1536828022000,
"masked_author": "username_1",
"text": "Thank you Ludovic, we will look into it\n\nRegards\nMohamed Javeed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lboue",
"comment_id": 422358035,
"datetime": 1537270368000,
"masked_author": "username_0",
"text": "Did you find the issue? \r\nI have the same behaviour from a Windows client running Python 3.7:\r\n\r\n```\r\nC:\\Users\\user\\Documents\\NAPLAM\\DELLOS10>python napalm-dellos10-get_mac-addr-table.py\r\nPassword:\r\nTraceback (most recent call last):\r\n File \"C:\\Users\\user\\AppData\\Local\\Programs\\Python\\Python37-32\\lib\\site-packages\\napalm_dellos10\\dellos10.py\", line 1770, in convert_xml_data\r\n ret = ET.fromstring(encoded_output)\r\n File \"src\\lxml\\etree.pyx\", line 3213, in lxml.etree.fromstring\r\n File \"src\\lxml\\parser.pxi\", line 1877, in lxml.etree._parseMemoryDocument\r\n File \"src\\lxml\\parser.pxi\", line 1765, in lxml.etree._parseDoc\r\n File \"src\\lxml\\parser.pxi\", line 1127, in lxml.etree._BaseParser._parseDoc\r\n File \"src\\lxml\\parser.pxi\", line 601, in lxml.etree._ParserContext._handleParseResultDoc\r\n File \"src\\lxml\\parser.pxi\", line 711, in lxml.etree._handleParseResult\r\n File \"src\\lxml\\parser.pxi\", line 640, in lxml.etree._raiseParseError\r\n File \"<string>\", line 1213\r\nlxml.etree.XMLSyntaxError: XML declaration allowed only at the start of the document, line 1213, column 6\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n File \"napalm-dellos10-get_mac-addr-table.py\", line 24, in <module>\r\n macAddrTable = device.get_mac_address_table()\r\n File \"C:\\Users\\user\\AppData\\Local\\Programs\\Python\\Python37-32\\lib\\site-packages\\napalm_dellos10\\dellos10.py\", line 800, in get_mac_address_table\r\n routes_xml_data = self.convert_xml_data(lldp_neighbors_output)\r\n File \"C:\\Users\\user\\AppData\\Local\\Programs\\Python\\Python37-32\\lib\\site-packages\\napalm_dellos10\\dellos10.py\", line 1775, in convert_xml_data\r\n raise CommandErrorException(msg.format(output))\r\nnapalm.base.exceptions.CommandErrorException: Response from the device is not in expected format : <?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n<rpc-reply>\r\n <bulk>\r\n <data>\r\n <fwd-table>\r\n ...\r\n </bulk>\r\n</rpc-reply>\r\n```\r\n\r\nRegards,\r\nLudovic",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dell-emc-networking",
"comment_id": 422659972,
"datetime": 1537335520000,
"masked_author": "username_2",
"text": "Hi Ludovic,\n\n\nWe are still working on that.\n\n\nThe problem is with the command response from device, looks like command response from the device is in different format than which i have developed. is it possible for you to share \"show mac address-table | display-xml\" command response as a text file of your device for quick resolution?\n\n\nWe have tested with the following version, it is working fine for us. anyway we will check with your build version.\n\n?\n\n\n[cid:5e8c8790-e657-4f17-8688-cfde3c27dad4]\n\n\nResponse from napalm-dellos10 get_mac_address_table() API:\n\n\n[cid:a9086a2d-f2f7-442b-b1ae-52cffa982a47]\n\n\nThanks\n\nMohamed Javeed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dell-emc-networking",
"comment_id": 422661063,
"datetime": 1537335876000,
"masked_author": "username_2",
"text": "Looks like image cannot be attached, adding as text\r\n\r\n\r\nOS10# show version\r\nDell EMC Networking OS10-Enterprise\r\nCopyright (c) 1999-2018 by Dell Inc. All Rights Reserved.\r\nOS Version: 10.4.1.0X\r\nBuild Version: 10.4.1.0.X.446\r\nBuild Time: 2018-07-24T13:02:25-0700\r\nSystem Type: S5148F-ON\r\nArchitecture: x86_64\r\nUp Time: 10:41:44\r\nOS10# show mac address-table | display-xml\r\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n<rpc-reply>\r\n <bulk>\r\n <data>\r\n <fwd-table>\r\n <mac-addr>11:11:11:11:11:13</mac-addr>\r\n <vlan>vlan1</vlan>\r\n <entry-type>static</entry-type>\r\n <if-name>ethernet1/1/2</if-name>\r\n </fwd-table>\r\n <fwd-table>\r\n <mac-addr>11:11:11:11:11:17</mac-addr>\r\n <vlan>vlan6</vlan>\r\n <entry-type>static</entry-type>\r\n <if-name>ethernet1/1/4</if-name>\r\n </fwd-table>\r\n </data>\r\n <last-keys>\r\n <entry-type>static</entry-type>\r\n <mac-addr>11:11:11:11:11:17</mac-addr>\r\n <vlan>vlan6</vlan>\r\n </last-keys>\r\n </bulk>\r\n</rpc-reply>\r\nOS10#\r\n\r\n\r\nResponse from napalm-dellos10 get_amc_address_table() API,\r\n\r\n\r\nStarted ...\r\n[{'vlan': 1, 'last_move': -1.0, 'active': True, 'mac': u'11:11:11:11:11:13', 'static': True, 'interface': u'ethernet1/1/2', 'moves': -1}, {'vlan': 6, 'last_move': -1.0, 'active': True, 'mac': u'11:11:11:11:11:17', 'static': True, 'interface': u'ethernet1/1/4', 'moves': -1}]\r\n\r\nThanks\r\nMohamed Javeed\r\n\r\n\r\n\r\nFrom: Faroo, Mohamed Javeed\r\nSent: 19 September 2018 11:08\r\nTo: napalm-automation-community/napalm-dellos10; napalm-automation-community/napalm-dellos10\r\nCc: Subscribed\r\nSubject: Re: [napalm-automation-community/napalm-dellos10] get_mac_address_table method: Response from the device is not in expected format (#17)\r\n\r\n\r\nHi Ludovic,\r\n\r\n\r\nWe are still working on that.\r\n\r\n\r\nThe problem is with the command response from device, looks like command response from the device is in different format than which i have developed. is it possible for you to share \"show mac address-table | display-xml\" command response as a text file of your device for quick resolution?\r\n\r\n\r\nWe have tested with the following version, it is working fine for us. anyway we will check with your build version.\r\n\r\n\r\n\r\n\r\n[cid:5e8c8790-e657-4f17-8688-cfde3c27dad4]\r\n\r\n\r\nResponse from napalm-dellos10 get_mac_address_table() API:\r\n\r\n\r\n[cid:a9086a2d-f2f7-442b-b1ae-52cffa982a47]\r\n\r\n\r\nThanks\r\n\r\nMohamed Javeed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lboue",
"comment_id": 422699610,
"datetime": 1537344127000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nI noticed something odd. When I replace the command 'show mac address-table | display-xml' in the dellos10.py plugin file with a more precise one, I don't get the error anymore:\r\n- command 'show mac address-table interface port-channel1 | display-xml' is working\r\n- command 'show mac address-table vlan 130 | display-xml' is working\r\n\r\n```\r\n def get_mac_address_table(self):\r\n #cmd = 'show mac address-table vlan 130 | display-xml'\r\n cmd = 'show mac address-table interface port-channel1 | display-xml'\r\n #cmd = 'show mac address-table | display-xml'\r\n lldp_neighbors_output = self._send_command(cmd)\r\n``` \r\n\r\n**Output for the 'show mac address-table vlan 130 | display-xml' command:**\r\n``` \r\nC:\\Users\\user\\Documents\\NAPLAM\\DELLOS10>python napalm-dellos10-get_mac-addr-table.py\r\nPassword:\r\nmacAddrTable:\r\n[ { 'active': True,\r\n 'interface': 'port-channel4',\r\n 'last_move': -1.0,\r\n 'mac': 'ab:cd:ef:54:d2:f9',\r\n 'moves': -1,\r\n 'static': False,\r\n 'vlan': 130},\r\n { 'active': True,\r\n 'interface': 'port-channel4',\r\n 'last_move': -1.0,\r\n 'mac': 'ab:cd:ef:5a:fb:9a',\r\n 'moves': -1,\r\n 'static': False,\r\n 'vlan': 130},\r\n { 'active': True,\r\n 'interface': 'port-channel1',\r\n 'last_move': -1.0,\r\n 'mac': 'ab:cd:ef:b2:50:29',\r\n 'moves': -1,\r\n 'static': False,\r\n 'vlan': 130},\r\n { 'active': True,\r\n 'interface': 'port-channel47',\r\n 'last_move': -1.0,\r\n 'mac': 'ab:cd:ef:b2:58:2b',\r\n 'moves': -1,\r\n 'static': False,\r\n 'vlan': 130},\r\n { 'active': True,\r\n 'interface': 'port-channel2',\r\n 'last_move': -1.0,\r\n 'mac': 'ab:cd:ef:b3:27:7f',\r\n 'moves': -1,\r\n 'static': False,\r\n 'vlan': 130},\r\n { 'active': True,\r\n 'interface': 'port-channel1',\r\n 'last_move': -1.0,\r\n 'mac': 'ab:cd:ef:b3:56:a4',\r\n 'moves': -1,\r\n 'static': False,\r\n 'vlan': 130},\r\n { 'active': True,\r\n 'interface': 'port-channel47',\r\n 'last_move': -1.0,\r\n 'mac': 'ab:cd:ef:95:b9:19',\r\n 'moves': -1,\r\n 'static': False,\r\n 'vlan': 130},\r\n { 'active': True,\r\n 'interface': 'port-channel47',\r\n 'last_move': -1.0,\r\n 'mac': 'ab:cd:ef:c1:fb:c9',\r\n 'moves': -1,\r\n 'static': False,\r\n 'vlan': 130},\r\n { 'active': True,\r\n 'interface': 'port-channel47',\r\n 'last_move': -1.0,\r\n 'mac': 'ab:cd:ef:c1:ff:c9',\r\n 'moves': -1,\r\n 'static': False,\r\n 'vlan': 130},\r\n { 'active': True,\r\n 'interface': 'port-channel47',\r\n 'last_move': -1.0,\r\n 'mac': 'ab:cd:ef:a4:4c:14',\r\n 'moves': -1,\r\n 'static': False,\r\n 'vlan': 130},\r\n { 'active': True,\r\n 'interface': 'port-channel1000',\r\n 'last_move': -1.0,\r\n 'mac': 'ab:cd:ef:c1:fc:c9',\r\n 'moves': -1,\r\n 'static': True,\r\n 'vlan': 130}]\r\n``` \r\n\r\nIn addition, I had the same behaviour with the old 10.3 version before the upgrade. \r\n\r\nRegards,\r\nLudovic",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "javeedf",
"comment_id": 422726477,
"datetime": 1537349322000,
"masked_author": "username_1",
"text": "Hi Ludovic,\n\nPlease check if there are two XML tag inside the command \"show mac\naddress-table | display-xml\" response. That's when we will get this error\nmessage.\n\nPlease send the complete command response without editing\n\nThanks\nMohamed Javeed",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "javeedf",
"comment_id": 423039198,
"datetime": 1537419018000,
"masked_author": "username_1",
"text": "Hi Ludovic,\n\nCould you please add the below code and check if it works for you?\n\nBelow code handles multiple xml tags:\n\n* def get_mac_address_table(self):*\n* cmd = 'show mac address-table | display-xml'*\n* mac_table_output = self._send_command(cmd)*\n\n* base_xpath = \"./bulk/data/fwd-table\"*\n* ret_mac_dict = []*\n* mac_table_output_list = self._build_xml_list(mac_table_output)*\n* for output in mac_table_output_list:*\n* mac_table_xml_data = self.convert_xml_data(output)*\n* mac_xml_list = mac_table_xml_data.findall(base_xpath)*\n* for mac_xml in mac_xml_list:*\n* mac_addr = self.parse_item(mac_xml, 'mac-addr')*\n* # vlan id comes with \"vlan123\"*\n* vlan_id_str = self.parse_item(mac_xml, 'vlan')*\n* entry_type = self.parse_item(mac_xml, 'entry-type')*\n* if_name = self.parse_item(mac_xml, 'if-name')*\n* vlan_id = int(vlan_id_str[4:].strip())*\n* mac_dict = {*\n* \"mac\": mac_addr,*\n* \"interface\": if_name,*\n* \"static\": True if \"static\" == entry_type else False,*\n* \"active\": True,*\n* \"vlan\": vlan_id,*\n* \"moves\": self.UNKNOWN_INT,*\n* \"last_move\": self.UNKNOWN_FLOAT*\n* }*\n* ret_mac_dict.append(mac_dict)*\n\n* return ret_mac_dict*\n\nThanks\nMohamed Javeed\n\n\nOn Wed, Sep 19, 2018 at 2:58 PM Mohamed Javeed <username_1.dev@gmail.com>\nwrote:\n\n> Hi Ludovic,\n>\n> Please check if there are two XML tag inside the command \"show mac\n> address-table | display-xml\" response. That's when we will get this error\n> message.\n>\n> Please send the complete command response without editing\n>\n> Thanks\n> Mohamed Javeed\n>\n>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "javeedf",
"comment_id": 423040980,
"datetime": 1537419779000,
"masked_author": "username_1",
"text": "Added the code easy to copy:\r\n \r\n\r\n def get_mac_address_table(self):\r\n cmd = 'show mac address-table | display-xml'\r\n mac_table_output = self._send_command(cmd)\r\n base_xpath = './bulk/data/fwd-table'\r\n ret_mac_dict = []\r\n mac_table_output_list = self._build_xml_list(mac_table_output)\r\n for output in mac_table_output_list:\r\n mac_table_xml_data = self.convert_xml_data(output)\r\n mac_xml_list = mac_table_xml_data.findall(base_xpath)\r\n for mac_xml in mac_xml_list:\r\n mac_addr = self.parse_item(mac_xml, 'mac-addr')\r\n # vlan id comes with \"vlan123\"\r\n vlan_id_str = self.parse_item(mac_xml, 'vlan')\r\n entry_type = self.parse_item(mac_xml, 'entry-type')\r\n if_name = self.parse_item(mac_xml, 'if-name')\r\n vlan_id = int(vlan_id_str[4:].strip())\r\n mac_dict = {\r\n \"mac\": mac_addr,\r\n \"interface\": if_name,\r\n \"static\": True if \"static\" == entry_type else False,\r\n \"active\": True,\r\n \"vlan\": vlan_id,\r\n \"moves\": self.UNKNOWN_INT,\r\n \"last_move\": self.UNKNOWN_FLOAT\r\n }\r\n ret_mac_dict.append(mac_dict)\r\n return ret_mac_dict",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lboue",
"comment_id": 423910849,
"datetime": 1537779046000,
"masked_author": "username_0",
"text": "Hello Mohamed ,\r\n\r\nI did the test with your patch this morning and it works fine as you can see bellow:\r\n```\r\nC:\\Users\\user\\Documents\\NAPLAM\\DELLOS10>python napalm-dellos10-get_mac-addr-table.py\r\nPassword:\r\nmacAddrTable:\r\n[ { 'active': True,\r\n 'interface': 'port-channel5',\r\n 'last_move': -1.0,\r\n 'mac': '00:50:56:ab:cd:ab',\r\n 'moves': -1,\r\n 'static': False,\r\n 'vlan': 1},\r\n { 'active': True,\r\n 'interface': 'port-channel3',\r\n 'last_move': -1.0,\r\n 'mac': '00:50:56:ab:cd:ef',\r\n 'moves': -1,\r\n 'static': False,\r\n 'vlan': 1},\r\n ...\r\n```\r\n\r\nI don't have the XML error anymore:\r\n```\r\nC:\\Users\\user\\Documents\\NAPLAM\\DELLOS10>python napalm-dellos10-get_mac-addr-table.py\r\nPassword:\r\nTraceback (most recent call last):\r\n File \"C:\\Users\\user\\AppData\\Local\\Programs\\Python\\Python37-32\\lib\\site-packages\\napalm_dellos10\\dellos10.py\", line 1802, in convert_xml_data\r\n ret = ET.fromstring(encoded_output)\r\n File \"src\\lxml\\etree.pyx\", line 3213, in lxml.etree.fromstring\r\n File \"src\\lxml\\parser.pxi\", line 1877, in lxml.etree._parseMemoryDocument\r\n File \"src\\lxml\\parser.pxi\", line 1765, in lxml.etree._parseDoc\r\n File \"src\\lxml\\parser.pxi\", line 1127, in lxml.etree._BaseParser._parseDoc\r\n File \"src\\lxml\\parser.pxi\", line 601, in lxml.etree._ParserContext._handleParseResultDoc\r\n File \"src\\lxml\\parser.pxi\", line 711, in lxml.etree._handleParseResult\r\n File \"src\\lxml\\parser.pxi\", line 640, in lxml.etree._raiseParseError\r\n File \"<string>\", line 1213\r\nlxml.etree.XMLSyntaxError: XML declaration allowed only at the start of the document, line 1213, column 6\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n File \"napalm-dellos10-get_mac-addr-table.py\", line 24, in <module>\r\n macAddrTable = device.get_mac_address_table()\r\n File \"C:\\Users\\user\\AppData\\Local\\Programs\\Python\\Python37-32\\lib\\site-packages\\napalm_dellos10\\dellos10.py\", line 831, in get_mac_address_table\r\n routes_xml_data = self.convert_xml_data(lldp_neighbors_output)\r\n File \"C:\\Users\\user\\AppData\\Local\\Programs\\Python\\Python37-32\\lib\\site-packages\\napalm_dellos10\\dellos10.py\", line 1807, in convert_xml_data\r\n raise CommandErrorException(msg.format(output))\r\nnapalm.base.exceptions.CommandErrorException: Response from the device is not in expected format : <?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n<rpc-reply>\r\n <bulk>\r\n <data>\r\n```\r\n\r\nRegards,\r\nLudovic",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "javeedf",
"comment_id": 423912397,
"datetime": 1537779464000,
"masked_author": "username_1",
"text": "Thank you Ludovic. I will commit and update the pypi",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lboue",
"comment_id": 423913314,
"datetime": 1537779708000,
"masked_author": "username_0",
"text": "Thanks, you can refer to PR #18",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "javeedf",
"comment_id": 423914564,
"datetime": 1537780058000,
"masked_author": "username_1",
"text": "Sure Ludovic",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "skg-net",
"comment_id": null,
"datetime": 1537815934000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 16 | 16,596 | false | false | 16,596 | true |
gin-gonic/gin | gin-gonic | 394,769,623 | 1,721 | null | [
{
"action": "opened",
"author": "songjiayang",
"comment_id": null,
"datetime": 1546067958000,
"masked_author": "username_0",
"text": "- go version: go version go1.11.2 darwin/amd64\r\n- gin version: v1.3.0\r\n- operating system: darwin/amd64\r\n\r\n## Description\r\nI use `DataFromReader` add extraHeaders to response Header, but the header not format like httpHeader.Set(), my test code is:\r\n\r\n```golang\r\npackage main\r\n\r\nimport (\r\n\t\"github.com/gin-gonic/gin\"\r\n\t\"strings\"\r\n)\r\n\r\nfunc main() {\r\n\tr := gin.Default()\r\n\tr.GET(\"/req1\", func(c *gin.Context) {\r\n\t\tc.DataFromReader(200, 5, gin.MIMEMultipartPOSTForm, strings.NewReader(\"hello\"), map[string]string{\r\n\t\t\t\"x-request-id\": \"id\",\r\n\t\t})\r\n\t})\r\n\r\n\tr.GET(\"/req2\", func(c *gin.Context) {\r\n\t\tc.Writer.Header().Set(\"x-request-id\", \"id\")\r\n\t\tc.DataFromReader(200, 5, gin.MIMEMultipartPOSTForm, strings.NewReader(\"hello\"), map[string]string{})\r\n\t})\r\n\tr.Run()\r\n}\r\n\r\n```\r\n\r\n## Screenshots\r\n<img width=\"655\" alt=\"screen shot 2018-12-29 at 3 13 10 pm\" src=\"https://user-images.githubusercontent.com/1459834/50534751-561b7100-0b7c-11e9-8e44-a4cbb8d175a8.png\">\r\n\r\nAs your see `req1` response header key is `x-request-id` but `req2` is `X-Request-Id` and client use `response.Heaer().Get(\"x-request-id\") ` can only get `req2` value. \r\n\r\nThe `DataFromReader`'s extraHeaders setting should have the same behavior as `c.Writer.Header().Set`.",
"title": "gin render.writeHeaders is not MIMEHeader format",
"type": "issue"
},
{
"action": "closed",
"author": "thinkerou",
"comment_id": null,
"datetime": 1550816426000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 1,237 | false | false | 1,237 | false |
ntoll/uflash | null | 442,910,583 | 61 | null | [
{
"action": "opened",
"author": "rhubarbdog",
"comment_id": null,
"datetime": 1557525873000,
"masked_author": "username_0",
"text": "uflash needs a --port option to direct the process to the correct microbit when multiple microbits are plugged in. It also probably needs to mimic how `ufs` (microfs) selects a port. I have 2 microbits plugged in `uflash` flashes the first, where as `ufs ls` lists the contents of the second",
"title": "uflash need a --port option",
"type": "issue"
},
{
"action": "created",
"author": "zfm076",
"comment_id": 569595803,
"datetime": 1577687625000,
"masked_author": "username_1",
"text": "Yes, I want to know the answer. Have you solved it?",
"title": null,
"type": "comment"
}
] | 2 | 2 | 344 | false | false | 344 | false |
Polymer/tools | Polymer | 395,637,675 | 2,612 | null | [
{
"action": "opened",
"author": "vdegenne",
"comment_id": null,
"datetime": 1536937982000,
"masked_author": "username_0",
"text": "The reason I get this message is obvious : **I am not using the proper plugins to parse this babel/typescript feature into final served state**.\r\nHowever I am not using a direct parser or a compilation program myself. Instead I am using the `serve` command of the `polymer-cli` package (`1.8.0`). This command provides a compilation on-the-fly as modules are requested from the front-end. I searched a way to bind one of the module to the `serve` command but I couldn't find one.\r\nIs it a feature you guys are going to implement in the future ?",
"title": "lit-element @property syntax invalid",
"type": "issue"
},
{
"action": "created",
"author": "ronnyroeller",
"comment_id": 451962743,
"datetime": 1546873287000,
"masked_author": "username_1",
"text": "+1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Pickachu",
"comment_id": 454762854,
"datetime": 1547641934000,
"masked_author": "username_2",
"text": "tried manually adding plugin-proposal-decorators to the plugin array with no success, would like further directions or know if this will be implemented in the future.\r\n\r\nChanges:\r\n\r\n```javascript\r\n\r\nconst babelTransformEs2018 = [\r\n require('@babel/plugin-proposal-object-rest-spread'),\r\n require('@babel/plugin-proposal-async-generator-functions'),\r\n require('@babel/plugin-proposal-decorators'),\r\n require('@babel/plugin-proposal-class-properties'),\r\n];\r\n\r\n```\r\n\r\nAlso it is needed to update the babylon parser configs:\r\n\r\n```javascript\r\n babylon.parse(js, {\r\n // TODO(aomarks) Remove any when typings are updated for babylon 7.\r\n // tslint:disable-next-line: no-any\r\n sourceType: transformModulesToAmd === 'auto' ? 'unambiguous' :\r\n 'module',\r\n plugins: [\r\n 'decorators', // here\r\n 'classProperties', // here\r\n 'asyncGenerators',\r\n 'dynamicImport',\r\n // tslint:disable-next-line: no-any\r\n 'importMeta',\r\n 'objectRestSpread',\r\n ],\r\n });\r\n```\r\n\r\nInput:\r\n\r\n```javascript\r\nimport { LitElement, html, property } from \"../../../node_modules/@polymer/lit-element/lit-element.js\";\r\n\r\nclass Domo extends LitElement {\r\n @property({type : String}) prop1 = 'Hello World';\r\n}\r\n\r\nwindow.customElements.define('domo', Domo);\r\n```\r\n\r\nOutput:\r\n\r\n```javascript\r\nimport { LitElement, html, property } from \"../../../node_modules/@polymer/lit-element/lit-element.js\";\r\n\r\nclass Domo extends LitElement {\r\n @\r\n prop1 = 'Hello World';\r\n}\r\n\r\nwindow.customElements.define('domo', Domo);\r\n```",
"title": null,
"type": "comment"
}
] | 4 | 4 | 2,444 | false | true | 2,272 | false |
nicolasgarnier/drive-music-player | null | 440,165,955 | 37 | null | [
{
"action": "opened",
"author": "smcvey85",
"comment_id": null,
"datetime": 1556907935000,
"masked_author": "username_0",
"text": "<!--\r\n1. Please search [existing issues](https://github.com/gsuitedevs/drive-music-player/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc).\r\n2. Please file issues in English.\r\n-->\r\n\r\n## Expected Behavior\r\n\r\n(What did you expect to happen?)\r\n\r\n## Actual Behavior\r\n\r\n(What actually happened?)\r\n\r\n## Steps to Reproduce the Problem\r\n\r\n1.\r\n1.\r\n1.\r\n\r\n## Specifications\r\n\r\n- Browser:\r\n- OS: Mac/Linux/Windows",
"title": "The music player is talking over when I click an mp4 file in Google Drive. How do I adjust the settings so only mp3 files are played with the music player?",
"type": "issue"
},
{
"action": "created",
"author": "wildwillyrvs",
"comment_id": 523760289,
"datetime": 1566453471000,
"masked_author": "username_1",
"text": "git remote add origin https://github.com/username_1/Otto.git\r\ngit push -u origin master",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "wildwillyrvs",
"comment_id": 523766163,
"datetime": 1566454928000,
"masked_author": "username_1",
"text": "I thank you for the help and chance to try to under stand the git work place and the specail condution to even be in here. i have work with the. http://www.apache.org/licenses/LICENSE-2.0. along time ago. \r\nthanks otto. i will sign off now for i have no cute what to do, so I'll try something else.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 790 | false | false | 790 | true |
benjaminkott/bootstrap_package | null | 384,479,407 | 603 | null | [
{
"action": "opened",
"author": "quadronet",
"comment_id": null,
"datetime": 1543261004000,
"masked_author": "username_0",
"text": "# Bug Report\r\n\r\nthe text-field isn´t load with panel and text in columns, text with teaser..\r\n## Prerequisites\r\n\r\n* [x ] Can you reproduce the problem on TYPO3 v8.7 LTS\r\n* [ ] Can you reproduce the problem on TYPO3 v9.5 LTS\r\n* [ ] Did you [perform a cursory search](https://github.com/issues?q=is%3Aissue+user%3Abenjaminkott+repo%3Abenjaminkott%2Fbootstrap_package) to see if your bug or enhancement is already reported?\r\n\r\n## Description\r\n\r\n[Description of the bug or feature]\r\n\r\n## Steps to Reproduce\r\n\r\n1. [First Step]\r\n2. [Second Step]\r\n3. [and so on...]\r\n\r\n**Expected behavior:** [What you expected to happen]\r\n\r\n**Actual behavior:** [What actually happened]\r\n\r\n## Versions\r\n10.0.3\r\nYou can get this information from executing `composer show` at the command line if your TYPO3 installation is composer based, otherwise the version number will be shown in the extension manager.",
"title": "RTE isn´t loading with panel, text in columns",
"type": "issue"
},
{
"action": "closed",
"author": "quadronet",
"comment_id": null,
"datetime": 1543265109000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 882 | false | false | 882 | false |
dotnet/docfx | dotnet | 433,074,461 | 4,356 | {
"number": 4356,
"repo": "docfx",
"user_login": "dotnet"
} | [
{
"action": "opened",
"author": "yufeih",
"comment_id": null,
"datetime": 1555297001000,
"masked_author": "username_0",
"text": "",
"title": " Add file to JSON source info",
"type": "issue"
},
{
"action": "created",
"author": "OsmondJiang",
"comment_id": 483092357,
"datetime": 1555297502000,
"masked_author": "username_1",
"text": "what are we going to resolve in this PR?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "live1206",
"comment_id": 483114396,
"datetime": 1555306867000,
"masked_author": "username_2",
"text": "Should we add a not null check here? so that there is always a File populated.\r\nAnd populate file for these as well?\r\n[https://github.com/dotnet/docfx/blob/aefc5c92856e969675de894a49255f44197a991d/src/docfx/build/metadata/MetadataValidator.cs#L30](https://github.com/dotnet/docfx/blob/aefc5c92856e969675de894a49255f44197a991d/src/docfx/build/metadata/MetadataValidator.cs#L30)\r\n[https://github.com/dotnet/docfx/blob/aefc5c92856e969675de894a49255f44197a991d/src/docfx/build/metadata/MetadataValidator.cs#L46](https://github.com/dotnet/docfx/blob/aefc5c92856e969675de894a49255f44197a991d/src/docfx/build/metadata/MetadataValidator.cs#L46)\r\n\r\n---\r\nRefers to: src/docfx/lib/log/SourceInfo.cs:37 in 1e80a45. [](commit_id = 1e80a45e458b9ac292e037a56b719cd28d62af20, deletion_comment = False)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yufeih",
"comment_id": 483115195,
"datetime": 1555307127000,
"masked_author": "username_0",
"text": "yes, after all the other `nulls` are cleaned up.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "live1206",
"comment_id": 483116205,
"datetime": 1555307483000,
"masked_author": "username_2",
"text": "As I can see, the two in `MetadataValidator.cs` are the only nulls left to clean up.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yufeih",
"comment_id": 483116602,
"datetime": 1555307615000,
"masked_author": "username_0",
"text": "https://github.com/dotnet/docfx/commit/17b9711e9305d9d3bea68eeb7a5186ca5865b4c1#diff-600d735a03558a7e04fbe7a52cbea80aR20 makes that line could potentially also be `null`",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "live1206",
"comment_id": 483116805,
"datetime": 1555307685000,
"masked_author": "username_2",
"text": "ok, leave it for later change then",
"title": null,
"type": "comment"
}
] | 3 | 7 | 1,160 | false | false | 1,160 | false |
jitsi/lib-jitsi-meet | jitsi | 278,626,014 | 665 | {
"number": 665,
"repo": "lib-jitsi-meet",
"user_login": "jitsi"
} | [
{
"action": "opened",
"author": "damencho",
"comment_id": null,
"datetime": 1512170586000,
"masked_author": "username_0",
"text": "",
"title": "Updates default gum and peer connection constraints.",
"type": "issue"
},
{
"action": "created",
"author": "virtuacoplenny",
"comment_id": 348642594,
"datetime": 1512171340000,
"masked_author": "username_1",
"text": "The old getConstraints still exists (for now and maybe for eternity). You might want to add the new constraints there as well to get browsers other than firefox, newer chrome, and new safari.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "damencho",
"comment_id": 348643533,
"datetime": 1512171736000,
"masked_author": "username_0",
"text": "Thanks, will update and test there.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "damencho",
"comment_id": 348659686,
"datetime": 1512180367000,
"masked_author": "username_0",
"text": "Old constraints updated.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "virtuacoplenny",
"comment_id": 348659922,
"datetime": 1512180531000,
"masked_author": "username_1",
"text": "Looks good to me. I'll wait for @bbaldino to chime in too.",
"title": null,
"type": "comment"
}
] | 2 | 5 | 308 | false | false | 308 | false |
EasyCloudConsultants/EasyCloudBooks | EasyCloudConsultants | 437,011,865 | 379 | null | [
{
"action": "opened",
"author": "risipatel",
"comment_id": null,
"datetime": 1556169102000,
"masked_author": "username_0",
"text": "**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Go to 'Projects Page'\r\n2. Select any year that has many projects with different period.\r\n3. Check the result\r\n\r\n**Actual behavior**\r\nSystem displays 'All' in the Period filter but it actually displays only those projects which is of Full Period.\r\n\r\n\r\n\r\n**Expected behavior**\r\nIf system displays 'All' in the filter then it should display All projects or else If it displays projects which is of Full period then it should display Full in the Period Filter.\r\n",
"title": "After Selecting Year system displays project which has Full in period field.",
"type": "issue"
},
{
"action": "closed",
"author": "risipatel",
"comment_id": null,
"datetime": 1556281201000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 1 | 2 | 793 | false | false | 793 | false |
scoverage/sbt-scoverage | scoverage | 439,219,705 | 284 | null | [
{
"action": "opened",
"author": "nimaeskandary",
"comment_id": null,
"datetime": 1556726842000,
"masked_author": "username_0",
"text": "Hey there, trying to integrate scoverage with a scala.js project but running problems, after a clean coverage test I'm getting:\r\n\r\n```\r\n[info] [info] Wrote instrumentation file [/Users/username_0/Dev/vinyldns/modules/client/target/scala-2.12/scoverage-data/scoverage.coverage.xml]\r\n[info] [info] Will write measurement data to [/Users/username_0/Dev/vinyldns/modules/client/target/scala-2.12/scoverage-data]\r\n[error] /Users/username_0/Dev/vinyldns/modules/client/src/main/scala/vinyldns/client/pages/credentials/ApiCredentialsPage.scala:40:9: Found a dangling UndefinedParam at Position(file:/Users/username_0/Dev/vinyldns/modules/client/src/main/scala/vinyldns/client/pages/credentials/ApiCredentialsPage.scala,118,41). This is likely due to a bad interaction between a macro or a compiler plugin and the Scala.js compiler plugin. If you hit this, please let us know.\r\n[error] class Backend {\r\n[error] ^\r\n[error] one error found\r\n[error] (Compile / compileIncremental) Compilation failed\r\n[error] Total time: 63 s, completed May 1, 2019 11:56:14 AM\r\nsbt:client>\r\n```\r\n\r\nThe exact line its pointing out is this one: https://github.com/username_0/vinyldns/blob/portalv2-play/modules/client/src/main/scala/vinyldns/client/pages/credentials/ApiCredentialsPage.scala#L40\r\n\r\nAny ideas?",
"title": "issues running on scala js project",
"type": "issue"
},
{
"action": "created",
"author": "ckipp01",
"comment_id": 828492452,
"datetime": 1619619383000,
"masked_author": "username_1",
"text": "scalajs support should be working. If this is something you are still hitting on with a modern version, please do report back.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ckipp01",
"comment_id": null,
"datetime": 1619619383000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,431 | false | false | 1,431 | true |
clariuslabs/clide | clariuslabs | 428,810,889 | 128 | {
"number": 128,
"repo": "clide",
"user_login": "clariuslabs"
} | [
{
"action": "opened",
"author": "kzu",
"comment_id": null,
"datetime": 1554302799000,
"masked_author": "username_0",
"text": "In some cases, the SVs/IVs pattern is used to assign a service id (The SVs interface’s GUID) that differs from the ids of any interfaces it may happen to implement. Some times, it is just aliased to be the same id.\r\n\r\nIn this second case, declaring a dummy type with the same Guid is *not* needed, and it can moreover cause issues in the CLR as two COM types will end up having the same ID.\r\n\r\nIn service queries the only thing that matters is the GUIDs not the type, so for the purposes of GetService the types given are just a place to hang a GUID.\r\n\r\nThis commit removes the SVsAppId and replaces it with IVsAppId when queried.",
"title": "Remove unnecessary SVsAppId",
"type": "issue"
},
{
"action": "created",
"author": "kzu",
"comment_id": 479551630,
"datetime": 1554307117000,
"masked_author": "username_0",
"text": "build",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kzu",
"comment_id": 479983054,
"datetime": 1554397625000,
"masked_author": "username_0",
"text": "@monojenkins backport to v3.2",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "kzu",
"comment_id": 479983677,
"datetime": 1554397736000,
"masked_author": "username_0",
"text": "@monojenkins backport to v3.2",
"title": null,
"type": "comment"
}
] | 1 | 4 | 693 | false | false | 693 | false |
studentinsights/studentinsights | studentinsights | 498,447,205 | 2,633 | {
"number": 2633,
"repo": "studentinsights",
"user_login": "studentinsights"
} | [
{
"action": "opened",
"author": "kevinrobinson",
"comment_id": null,
"datetime": 1569435599000,
"masked_author": "username_0",
"text": "# What problem does this PR fix?\r\nFSF wasn't included.\r\n\r\n# What does this PR do?\r\nAdds it under \"blending\", even though it's probably technically a pre-skill.\r\n\r\n# Checklists\r\n*Which features or pages does this PR touch?*\r\n+ [x] Student Profile\r\n\r\n*Does this PR use tests to help verify we can deploy these changes quickly and confidently?*\r\n+ [x] Included specs for changes",
"title": "Reading: Include FSF on profile",
"type": "issue"
},
{
"action": "created",
"author": "kevinrobinson",
"comment_id": 535148563,
"datetime": 1569435616000,
"masked_author": "username_0",
"text": "selfie",
"title": null,
"type": "comment"
}
] | 1 | 2 | 381 | false | false | 381 | false |
MicrosoftPremier/VstsExtensions | MicrosoftPremier | 466,343,505 | 40 | null | [
{
"action": "opened",
"author": "mdwhitten",
"comment_id": null,
"datetime": 1562768975000,
"masked_author": "username_0",
"text": "I would like to be able to see the individual warnings per file, which seems to be possible based on the screenshot in [WarningsPolicy.md](https://github.com/MicrosoftPremier/VstsExtensions/blob/master/BuildQualityChecks/en-US/WarningsPolicy.md). However, all of my warnings appear as \"Unknown File\": \r\n\r\n\r\nThe log is being published to VSTS using the syntax`##vso[task.logissue type=warning;sourcepath=$messageFilePath;]$outputMessage\"`. Hence, the file path is being published as a part of the warning (see below), but doesn't seem that it is being picked up by the task.\r\n\r\n\r\n\r\nI've attached the log for more context:\r\n[log_21_154154.zip](https://github.com/MicrosoftPremier/VstsExtensions/files/3377977/log_21_154154.zip)\r\n\r\nThanks!",
"title": "Warnings report shows warnings as \"unknown file\"",
"type": "issue"
},
{
"action": "created",
"author": "mdwhitten",
"comment_id": 510087022,
"datetime": 1562769176000,
"masked_author": "username_0",
"text": "However, I had hoped that if I at least formatted my warning in the proper way, it would be picked up and reported in the same way as the MSBuild tasks.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ReneSchumacher",
"comment_id": 510157319,
"datetime": 1562780105000,
"masked_author": "username_1",
"text": "Hi Michael,\r\n\r\nsorry for letting you down, but we only run the proper analysis on logs created by one of the MSBuild-based tasks (VS Build, MSBuild) or the StyleCop task. Thus, it doesn't matter how you format your log output, the analysis logic will never pick up those log lines.\r\n\r\nHowever, it looks like you're using a standard tool (TestStand from National Instruments) to run some kind of static analysis (I haven't spent too much time skimming through their website). I assume there is no direct support for Azure DevOps from their end, right? I'm wondering if it might be worth investing a bit in creating a \"standard\" task for running this analysis that properly logs warnings and errors as real build issues (this would get rid of the need of custom warning filters to pick up those warnings) and then adding support for the resulting log file to the Build Quality Checks task. Especially if you'd be willing to share your parsing script and information about how to properly run the analysis. :)\r\n\r\nRené",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mdwhitten",
"comment_id": 514812264,
"datetime": 1564004810000,
"masked_author": "username_0",
"text": "Because of the above, I am **not using any warning filters**. Rather, I am using the [Azure Pipelines Logging Commands](https://github.com/microsoft/azure-pipelines-tasks/blob/master/docs/authoring/commands.md) to log the errors and warnings so that they show up as warnings and errors in the build summary in Azure. Is this what you mean by *properly log[ing] warnings and errors as real build issues*\"? \r\n\r\nAs best as I can tell, MSBuild and other tasks utilize the exact same command syntax to output their build warnings to the console, specifying which file rendered the warning using the `sourcepath` flag. I am doing the same thing in my logging above. Hence, this is the reason that I was surprised that the task does not pickup the file included with the warnings, since I think I am logging these the proper way.\r\n\r\nWhat are your thoughts? Thanks again for your support!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gerwinjansen",
"comment_id": 633931905,
"datetime": 1590487384000,
"masked_author": "username_2",
"text": "What is 'logs'? Is that the stdout/stderr or separate files? Can you explain how BuildQualityChecks works? Why can it detect warnings-including-sourcepaths for MSBuild-based tasks but only raw warnings for every other task? The raw-warning contains all the information that is needed.\r\nAnd even for MSBuild-based tasks it does not display the linenumber and columnnumber.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ReneSchumacher",
"comment_id": 633943784,
"datetime": 1590489026000,
"masked_author": "username_1",
"text": "Hi @username_2,\r\n\r\nBuild Quality Checks is not designed to display warnings created by other tasks. It's purpose is to simply count warnings and compare the current count with defined thresholds (either fixed value or the warning count from a previous build) to decide whether or not to break the build.\r\n\r\nEvery issues (warnings and errors) that is correctly logged by a task with the logging command you mentioned is displayed in the build summary automatically. That is the purpose of those logging commands. Thus, there's no need to repeat that information again which is the reason why we don't display any line or column information.\r\n\r\nI believe that you are talking about the warning statistics. The purpose of those is to give a summary of warning changes in specific code files (or arbitrary files when using the warning file evaluation). So instead of listing all details for all warnings in a file, we just show files that have either more or less warnings compared to the previous build.\r\n\r\nWhat are you expecting to see?\r\n\r\nBtw: we only run statistics analysis for MSBuild and StyleCop since we parse the actual warnings from the tool itself, not the logging commands. This is because in the past logging commands were not written to the log file so there was no easy way to grab them. We could update our task to run a logging command analysis, but we'll have to think about backwards compatibility.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ReneSchumacher",
"comment_id": 639464440,
"datetime": 1591361915000,
"masked_author": "username_1",
"text": "Hi @username_0,\r\n\r\nfirst, I have to apologize that it took us so long to work on your feedback. It was sitting on our backlog but there was always something else to do. Good news is that we were able to create a generic solution now that works for all tasks or scripts that use our logging commands similar to what you do in your PowerShell script. Your files should now properly show up in the statistics section of the extension summary.\r\n\r\nAs this issue is resolved now I'm going to close it. Nevertheless, please feel free to add additional comments or open new issues if you still have problems getting statistics from your pipeline.\r\n\r\nHappy building,\r\nRené",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "ReneSchumacher",
"comment_id": null,
"datetime": 1591361916000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "mdwhitten",
"comment_id": 640599188,
"datetime": 1591622503000,
"masked_author": "username_0",
"text": "That's great! Thank you for getting back to me and for creating the generic solution. I will happily use this in my pipelines now.",
"title": null,
"type": "comment"
}
] | 3 | 9 | 5,581 | false | false | 5,581 | true |
omerwe/MKLMM | null | 359,635,033 | 1 | null | [
{
"action": "opened",
"author": "DorothyWen1",
"comment_id": null,
"datetime": 1536783276000,
"masked_author": "username_0",
"text": "Hi there,\r\n\r\nI am interested in using your program to analyse my data. However, when I used default setting, I get errors when the number of SNPs within the region is larger than the sample size. I checked regionsRanker.py. It looks to me that the problems are due to the below code. Could you please let me know how to fix this? Thanks. \r\n\r\n def eigenDecompose(self, X, K, normalize=True):\r\n if (X.shape[1] >= X.shape[0]):\r\n s,U = la.eigh(K)\r\n\r\n\r\nCherry",
"title": "When X.shage[1]>X.shape[0]",
"type": "issue"
},
{
"action": "created",
"author": "omerwe",
"comment_id": 420825335,
"datetime": 1536792967000,
"masked_author": "username_1",
"text": "Hi Cherry,\n\nThanks for trying out MKLMM! Can you please provide more details about the\nexact command you ran and the error message you received? Having a larger\nnumber of SNPs in a region than the sample size shouldn't lead to a problem\n(typically one region includes the entire genome), but I'm afraid it could\nuse up a lot of memory, unless they are linear kernels. Is this related to\nwhat you're seeing?\n\nThanks,\n\nOmer",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "omerwe",
"comment_id": 421084607,
"datetime": 1536859137000,
"masked_author": "username_1",
"text": "Hi Cherry,\n\nCan you successfully run the examples shown in the github page\n<https://github.com/username_1/MKLMM>? If yes, then I would guess that there's\nsome specific problem with your data, and it's very difficult for me to\nfigure out what it is without more information... My best guess is that\nyour input includes a region that doesn't have any SNPs (e.g., maybe all\nthe SNPs were filtered out for some reason)? But I would need to see the\ndata or to get more information (or at least to see the error output) to\nknow more.\n\nBest,\n\nOmer",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,456 | false | false | 1,456 | true |
j4s0n-c/trowaSoft-VCV | null | 308,983,045 | 20 | null | [
{
"action": "opened",
"author": "Amidamaru888",
"comment_id": null,
"datetime": 1522159395000,
"masked_author": "username_0",
"text": "Is there a fast way to reset everything to 0 or is not a best practice to start notation in 0, I spend a lot of time from -10 to 0 (not as much as you developing this awesome tool of course) 👍",
"title": "Notes in voltage",
"type": "issue"
},
{
"action": "created",
"author": "chichian",
"comment_id": 376737051,
"datetime": 1522203231000,
"masked_author": "username_1",
"text": "Hi Amindamaru, \r\n\r\nIn the latest version (for Rack v0.6), voltSeq should default to 0 V (C4). I think the new Rack should be out soon or you can compile from the latest source if you have the 0.6 dev version of Rack.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "j4s0n-c",
"comment_id": null,
"datetime": 1522438212000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 3 | 409 | false | false | 409 | false |
Unikka/neos-slick | Unikka | 413,257,159 | 9 | {
"number": 9,
"repo": "neos-slick",
"user_login": "Unikka"
} | [
{
"action": "created",
"author": "markusguenther",
"comment_id": 466324855,
"datetime": 1550826099000,
"masked_author": "username_0",
"text": ":tada: This PR is included in version 2.0.4 :tada:\n\nThe release is available on [GitHub release](https://github.com/Unikka/neos-slick/releases/tag/v2.0.4)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:",
"title": null,
"type": "comment"
}
] | 2 | 2 | 3,905 | false | true | 259 | false |
microsoft/vscode-docs | microsoft | 459,425,832 | 2,787 | null | [
{
"action": "opened",
"author": "luabud",
"comment_id": null,
"datetime": 1561173125000,
"masked_author": "username_0",
"text": "Having [\"-n\", \"4\"] in pytestArgs not working properly in some cases due to a bug. Current workaround is to change [\"-n\", \"4\"] to [\"-n 4\"]. Can we make this minor change in the docs? \r\n\r\nRelated: https://github.com/microsoft/vscode-docs/issues/2551",
"title": "[Python] Update arguments to run parallel tests with pytest-xdist",
"type": "issue"
},
{
"action": "created",
"author": "gregvanl",
"comment_id": 504849352,
"datetime": 1561349196000,
"masked_author": "username_1",
"text": "@username_0 PRs welcome. @JoshuaPartlow can help you fork vscode-docs and submit a PR.\r\nhttps://help.github.com/en/articles/fork-a-repo",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gregvanl",
"comment_id": 505119851,
"datetime": 1561399891000,
"masked_author": "username_1",
"text": "Fixed with https://github.com/microsoft/vscode-docs/commit/2d5f49cbe6c63b7ec2cb8bada828a58109130fe8",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "gregvanl",
"comment_id": null,
"datetime": 1561399892000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 478 | false | false | 478 | true |
maxcountryman/flask-login | null | 287,416,763 | 379 | null | [
{
"action": "opened",
"author": "erhuabushuo",
"comment_id": null,
"datetime": 1515587313000,
"masked_author": "username_0",
"text": "Is there a way to accomplish logout the user has logged in when same user login.",
"title": "Is there a way to accomplish logout the user has logged in when same user login. ",
"type": "issue"
},
{
"action": "closed",
"author": "davidism",
"comment_id": null,
"datetime": 1515591116000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 80 | false | false | 80 | false |
rust-lang/rust | rust-lang | 513,638,479 | 65,916 | {
"number": 65916,
"repo": "rust",
"user_login": "rust-lang"
} | [
{
"action": "opened",
"author": "Centril",
"comment_id": null,
"datetime": 1572311734000,
"masked_author": "username_0",
"text": "Part of https://github.com/rust-lang/rust/pull/65324.\r\n\r\nr? @davidtwco\r\ncc @estebank @petrochenkov",
"title": "syntax: move stuff around",
"type": "issue"
},
{
"action": "created",
"author": "rust-highfive",
"comment_id": 547234561,
"datetime": 1572317989000,
"masked_author": "username_1",
"text": "The job `x86_64-gnu-llvm-6.0` of your PR [failed](https://dev.azure.com/rust-lang/rust/_build/results?buildId=12201&view=logs&jobId=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e) ([pretty log](https://rust-lang.github.io/rust-log-analyzer/log-viewer/#https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_apis/build/builds/12201/logs/66), [raw log](https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_apis/build/builds/12201/logs/66)). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.\n\n<details><summary><i>Click to expand the log.</i></summary>\n\n```plain\n2019-10-29T01:50:40.0843795Z ##[command]git remote add origin https://github.com/rust-lang/rust\n2019-10-29T01:50:40.1070986Z ##[command]git config gc.auto 0\n2019-10-29T01:50:40.1140590Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader\n2019-10-29T01:50:40.1188193Z ##[command]git config --get-all http.proxy\n2019-10-29T01:50:40.1319621Z ##[command]git -c http.extraheader=\"AUTHORIZATION: basic ***\" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65916/merge:refs/remotes/pull/65916/merge\n---\n2019-10-29T02:47:25.8407437Z .................................................................................................... 1600/9259\n2019-10-29T02:47:31.1532227Z .................................................................................................... 1700/9259\n2019-10-29T02:47:42.2039156Z ..........................................................i...............i......................... 1800/9259\n2019-10-29T02:47:49.1238661Z .................................................................................................... 1900/9259\n2019-10-29T02:48:02.2325605Z ................................................iiiii............................................... 2000/9259\n2019-10-29T02:48:11.9654192Z .................................................................................................... 2200/9259\n2019-10-29T02:48:14.3859806Z .................................................................................................... 2300/9259\n2019-10-29T02:48:17.8998184Z .................................................................................................... 2400/9259\n2019-10-29T02:48:39.0838280Z .................................................................................................... 2500/9259\n---\n2019-10-29T02:51:20.6803191Z .................................................i...............i.................................. 4800/9259\n2019-10-29T02:51:29.0831709Z .................................................................................................... 4900/9259\n2019-10-29T02:51:36.7173137Z .................................................................................................... 5000/9259\n2019-10-29T02:51:42.4639399Z .................................................................................................... 5100/9259\n2019-10-29T02:51:51.8015120Z ..................................................ii.ii...........i................................. 5200/9259\n2019-10-29T02:52:00.8163006Z .................................................................................................... 5400/9259\n2019-10-29T02:52:09.2405475Z .................................................................................................... 5500/9259\n2019-10-29T02:52:16.4960186Z ....................i............................................................................... 5600/9259\n2019-10-29T02:52:21.9851259Z .................................................................................................... 5700/9259\n2019-10-29T02:52:21.9851259Z .................................................................................................... 5700/9259\n2019-10-29T02:52:32.8007097Z .................................................................................................... 5800/9259\n2019-10-29T02:52:44.1199036Z .....ii...i..ii...........i......................................................................... 5900/9259\n2019-10-29T02:53:04.0677061Z .................................................................................................... 6100/9259\n2019-10-29T02:53:10.1798587Z .................................................................................................... 6200/9259\n2019-10-29T02:53:10.1798587Z .................................................................................................... 6200/9259\n2019-10-29T02:53:22.9406777Z ........................i..ii....................................................................... 6300/9259\n2019-10-29T02:53:41.1109579Z ..........................................................................................i......... 6500/9259\n2019-10-29T02:53:43.2680349Z .................................................................................................... 6600/9259\n2019-10-29T02:53:45.4668483Z .................................................................i.................................. 6700/9259\n2019-10-29T02:53:48.1894047Z .................................................................................................... 6800/9259\n---\n2019-10-29T02:57:57.7289868Z finished in 5.166\n2019-10-29T02:57:57.7454197Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)\n2019-10-29T02:57:57.8967630Z \n2019-10-29T02:57:57.8968224Z running 153 tests\n2019-10-29T02:58:00.8367785Z i....iii......iii..iiii...i.............................i..i..................i....i...........ii.i. 100/153\n2019-10-29T02:58:02.5991320Z i..iiii..............i.........iii.i.........ii......\n2019-10-29T02:58:02.5992388Z \n2019-10-29T02:58:02.6001488Z finished in 4.854\n2019-10-29T02:58:02.6159362Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)\n2019-10-29T02:58:02.7554617Z \n---\n2019-10-29T02:58:04.5262496Z finished in 1.910\n2019-10-29T02:58:04.5407352Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)\n2019-10-29T02:58:04.6685763Z \n2019-10-29T02:58:04.6686568Z running 9 tests\n2019-10-29T02:58:04.6687535Z iiiiiiiii\n2019-10-29T02:58:04.6687920Z \n2019-10-29T02:58:04.6689411Z finished in 0.127\n2019-10-29T02:58:04.6838177Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)\n2019-10-29T02:58:04.8256955Z \n---\n2019-10-29T02:58:21.6783286Z finished in 16.994\n2019-10-29T02:58:21.6996835Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)\n2019-10-29T02:58:21.8492279Z \n2019-10-29T02:58:21.8493379Z running 123 tests\n2019-10-29T02:58:44.2388430Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....ii..........iiii..........i...ii...i.......ii. 100/123\n2019-10-29T02:58:47.5210184Z i.i.i......iii.i.....ii\n2019-10-29T02:58:47.5211296Z \n2019-10-29T02:58:47.5217588Z finished in 25.822\n2019-10-29T02:58:47.5228517Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)\n2019-10-29T02:58:47.5252986Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)\n---\n2019-10-29T02:59:41.2716860Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22\n2019-10-29T02:59:41.2717266Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.\n2019-10-29T02:59:41.2719138Z ---- [ui] ui-fulldeps/roman-numerals-macro.rs stdout ----\n2019-10-29T02:59:41.2719541Z \n2019-10-29T02:59:41.2720040Z error: auxiliary build of \"/checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs\" failed to compile: \n2019-10-29T02:59:41.2720458Z status: exit code: 1\n2019-10-29T02:59:41.2721797Z command: \"/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc\" \"/checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs\" \"-Zthreads=1\" \"--target=x86_64-unknown-linux-gnu\" \"--error-format\" \"json\" \"-Zui-testing\" \"-C\" \"prefer-dynamic\" \"--out-dir\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/roman-numerals-macro/auxiliary\" \"-Crpath\" \"-O\" \"-Cdebuginfo=0\" \"-Zunstable-options\" \"-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers\" \"--crate-type\" \"dylib\" \"-L\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/roman-numerals-macro/auxiliary\"\n2019-10-29T02:59:41.2723363Z ------------------------------------------\n2019-10-29T02:59:41.2723532Z \n2019-10-29T02:59:41.2724019Z ------------------------------------------\n2019-10-29T02:59:41.2724299Z stderr:\n2019-10-29T02:59:41.2724299Z stderr:\n2019-10-29T02:59:41.2724635Z ------------------------------------------\n2019-10-29T02:59:41.2724813Z error[E0603]: module `token` is private\n2019-10-29T02:59:41.2725292Z --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:18:20\n2019-10-29T02:59:41.2725479Z |\n2019-10-29T02:59:41.2725634Z LL | use syntax::parse::token::{self, Token};\n2019-10-29T02:59:41.2725846Z \n2019-10-29T02:59:41.2725846Z \n2019-10-29T02:59:41.2726364Z warning: use of deprecated attribute `plugin_registrar`: compiler plugins are deprecated. See ***/pull/64675\n2019-10-29T02:59:41.2726742Z --> /checkout/src/test/ui-fulldeps/auxiliary/roman-numerals.rs:66:1\n2019-10-29T02:59:41.2727041Z LL | #[plugin_registrar]\n2019-10-29T02:59:41.2727177Z | ^^^^^^^^^^^^^^^^^^^ help: may be removed in a future compiler version\n2019-10-29T02:59:41.2727290Z |\n2019-10-29T02:59:41.2727400Z = note: `#[warn(deprecated)]` on by default\n---\n2019-10-29T02:59:41.2730014Z test result: FAILED. 68 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out\n2019-10-29T02:59:41.2730152Z \n2019-10-29T02:59:41.2730306Z \n2019-10-29T02:59:41.2730435Z \n2019-10-29T02:59:41.2732614Z command did not execute successfully: \"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest\" \"--compile-lib-path\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib\" \"--run-lib-path\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib\" \"--rustc-path\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc\" \"--src-base\" \"/checkout/src/test/ui-fulldeps\" \"--build-base\" \"/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps\" \"--stage-id\" \"stage2-x86_64-unknown-linux-gnu\" \"--mode\" \"ui\" \"--target\" \"x86_64-unknown-linux-gnu\" \"--host\" \"x86_64-unknown-linux-gnu\" \"--llvm-filecheck\" \"/usr/lib/llvm-6.0/bin/FileCheck\" \"--host-rustcflags\" \"-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers\" \"--target-rustcflags\" \"-Crpath -O -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers\" \"--docck-python\" \"/usr/bin/python2.7\" \"--lldb-python\" \"/usr/bin/python2.7\" \"--gdb\" \"/usr/bin/gdb\" \"--quiet\" \"--llvm-version\" \"6.0.0\\n\" \"--system-llvm\" \"--cc\" \"\" \"--cxx\" \"\" \"--cflags\" \"\" \"--llvm-components\" \"\" \"--llvm-cxxflags\" \"\" \"--adb-path\" \"adb\" \"--adb-test-dir\" \"/data/tmp/work\" \"--android-cross-path\" \"\" \"--color\" \"always\"\n2019-10-29T02:59:41.2734024Z \n2019-10-29T02:59:41.2734049Z \n2019-10-29T02:59:41.2737088Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test\n2019-10-29T02:59:41.2737260Z Build completed unsuccessfully in 1:02:07\n2019-10-29T02:59:41.2737260Z Build completed unsuccessfully in 1:02:07\n2019-10-29T02:59:41.2786550Z == clock drift check ==\n2019-10-29T02:59:41.2799310Z local time: Tue Oct 29 02:59:41 UTC 2019\n2019-10-29T02:59:41.5451331Z network time: Tue, 29 Oct 2019 02:59:41 GMT\n2019-10-29T02:59:41.5455519Z == end clock drift check ==\n2019-10-29T02:59:42.5658914Z \n2019-10-29T02:59:42.5754611Z ##[error]Bash exited with code '1'.\n2019-10-29T02:59:42.5816008Z ##[section]Starting: Checkout\n2019-10-29T02:59:42.5818581Z ==============================================================================\n2019-10-29T02:59:42.5818814Z Task : Get sources\n2019-10-29T02:59:42.5818859Z Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.\n```\n\n</details><p></p>\n\n[I'm a bot](https://github.com/rust-ops/rust-log-analyzer)! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact **`@TimNN`**. ([Feature Requests](https://github.com/rust-ops/rust-log-analyzer/issues?q=is%3Aopen+is%3Aissue+label%3Afeature-request))",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Centril",
"comment_id": 547899266,
"datetime": 1572441695000,
"masked_author": "username_0",
"text": "Squashed -- was easier than I feared. :)\r\n\r\n@username_2 r=davidtwco",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bors",
"comment_id": 547899275,
"datetime": 1572441697000,
"masked_author": "username_2",
"text": ":pushpin: Commit 27adef62d6e8f73e5645eb8ad7f5bbcb9d595122 has been approved by `davidtwco`\n\n<!-- @username_2 r=davidtwco 27adef62d6e8f73e5645eb8ad7f5bbcb9d595122 -->\n<!-- homu: {\"type\":\"Approved\",\"sha\":\"27adef62d6e8f73e5645eb8ad7f5bbcb9d595122\",\"approver\":\"davidtwco\"} -->",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Centril",
"comment_id": 548062452,
"datetime": 1572461651000,
"masked_author": "username_0",
"text": "I'm not even going to try getting this through CI now that the toolstate week is in effect. :)\r\n\r\n@username_2 r-",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bors",
"comment_id": 549230054,
"datetime": 1572846301000,
"masked_author": "username_2",
"text": ":umbrella: The latest upstream changes (presumably #65838) made this pull request unmergeable. Please resolve the merge conflicts.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Centril",
"comment_id": 550165904,
"datetime": 1573021772000,
"masked_author": "username_0",
"text": "Toolstate should be breakable again, @username_2 r=davidtwco",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bors",
"comment_id": 550165907,
"datetime": 1573021773000,
"masked_author": "username_2",
"text": ":pushpin: Commit 948674b6e94af25d7c64dbd91ba235467140457a has been approved by `davidtwco`\n\n<!-- @username_2 r=davidtwco 948674b6e94af25d7c64dbd91ba235467140457a -->\n<!-- homu: {\"type\":\"Approved\",\"sha\":\"948674b6e94af25d7c64dbd91ba235467140457a\",\"approver\":\"davidtwco\"} -->",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bors",
"comment_id": 550227460,
"datetime": 1573033032000,
"masked_author": "username_2",
"text": ":umbrella: The latest upstream changes (presumably #66143) made this pull request unmergeable. Please resolve the merge conflicts.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Centril",
"comment_id": 550237559,
"datetime": 1573034564000,
"masked_author": "username_0",
"text": "@username_2 r=davidtwco",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bors",
"comment_id": 550237567,
"datetime": 1573034565000,
"masked_author": "username_2",
"text": ":pushpin: Commit 7514dcdb8e8cf50a0ca6415d1b513e424b7c3144 has been approved by `davidtwco`\n\n<!-- @username_2 r=davidtwco 7514dcdb8e8cf50a0ca6415d1b513e424b7c3144 -->\n<!-- homu: {\"type\":\"Approved\",\"sha\":\"7514dcdb8e8cf50a0ca6415d1b513e424b7c3144\",\"approver\":\"davidtwco\"} -->",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bors",
"comment_id": 550675125,
"datetime": 1573099015000,
"masked_author": "username_2",
"text": ":umbrella: The latest upstream changes (presumably #65750) made this pull request unmergeable. Please resolve the merge conflicts.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Centril",
"comment_id": 550706725,
"datetime": 1573100427000,
"masked_author": "username_0",
"text": "@username_2 r=davidtwco",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bors",
"comment_id": 550706746,
"datetime": 1573100428000,
"masked_author": "username_2",
"text": ":pushpin: Commit fa72c5600514857f4e9f1ae95d1e10968055b4cb has been approved by `davidtwco`\n\n<!-- @username_2 r=davidtwco fa72c5600514857f4e9f1ae95d1e10968055b4cb -->\n<!-- homu: {\"type\":\"Approved\",\"sha\":\"fa72c5600514857f4e9f1ae95d1e10968055b4cb\",\"approver\":\"davidtwco\"} -->",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bors",
"comment_id": 551041540,
"datetime": 1573126394000,
"masked_author": "username_2",
"text": ":umbrella: The latest upstream changes (presumably #66180) made this pull request unmergeable. Please resolve the merge conflicts.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Centril",
"comment_id": 551069315,
"datetime": 1573131653000,
"masked_author": "username_0",
"text": "@username_2 r=davidtwco",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "bors",
"comment_id": 551069323,
"datetime": 1573131654000,
"masked_author": "username_2",
"text": ":pushpin: Commit cc9c139694389c8df158640d4bcc20a2fe31f1ea has been approved by `davidtwco`\n\n<!-- @username_2 r=davidtwco cc9c139694389c8df158640d4bcc20a2fe31f1ea -->\n<!-- homu: {\"type\":\"Approved\",\"sha\":\"cc9c139694389c8df158640d4bcc20a2fe31f1ea\",\"approver\":\"davidtwco\"} -->",
"title": null,
"type": "comment"
}
] | 3 | 17 | 14,848 | false | false | 14,848 | true |
bangnoise/ofxHapPlayer | null | 352,182,272 | 45 | null | [
{
"action": "opened",
"author": "gomesgustavo",
"comment_id": null,
"datetime": 1534778369000,
"masked_author": "username_0",
"text": "Hi,\r\nCan you help me to find where can I download these libraries?\r\n\r\nThey are required at the HapSupport.h header.\r\n\r\nCheers,\r\nGustavo",
"title": "QTML and Movies Library not found",
"type": "issue"
},
{
"action": "closed",
"author": "bangnoise",
"comment_id": null,
"datetime": 1543418379000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 135 | false | false | 135 | false |
dw/python-pure-cdb | null | 365,707,617 | 16 | null | [
{
"action": "opened",
"author": "bbayles",
"comment_id": null,
"datetime": 1538444906000,
"masked_author": "username_0",
"text": "There should be unit tests for the `python-pure-cdbmake` script. The [freecdb](https://packages.ubuntu.com/trusty/freecdb) package should be available to pull in on Travis CI, so we can automatically compare the output to the official version.",
"title": "Tests for python-pure-cdbmake",
"type": "issue"
}
] | 1 | 1 | 243 | false | false | 243 | false |
AllenInstitute/render-modules | AllenInstitute | 442,887,034 | 202 | {
"number": 202,
"repo": "render-modules",
"user_login": "AllenInstitute"
} | [
{
"action": "opened",
"author": "RussTorres",
"comment_id": null,
"datetime": 1557520914000,
"masked_author": "username_0",
"text": "fixes pathlib backport for python 2.7 and passes tests on python 3.7. Should be merged in after #200, since that resolve a python 3 issue as well.",
"title": "Python37 compat",
"type": "issue"
}
] | 2 | 2 | 147 | false | true | 147 | false |
Hopac/Hopac | Hopac | 84,489,970 | 70 | null | [
{
"action": "opened",
"author": "VesaKarvonen",
"comment_id": null,
"datetime": 1433328348000,
"masked_author": "username_0",
"text": "I just started a branch\r\n\r\n https://github.com/Hopac/Hopac/tree/sig-rethink\r\n\r\nto redesign the symbolic operators and some other parts of the signature of Hopac. Take a look at the first commit:\r\n\r\n https://github.com/Hopac/Hopac/commit/d47ebbe094d15fe4c98527e33f07e034fda55bb9\r\n\r\nThe main change to the operator symbols is to change them so that their precedences become \"correct\" so that parentheses can be eliminated from most common expression involving message passing and/or alternatives.\r\n\r\nHere is a kind of visual template of how the common alternative expression can be formed:\r\n\r\n```fsharp\r\n xCh ^-> fun x -> y // Sync on take from channel, continue with fun.\r\n<|> xCh *<- x ^->. y // Sync on give to channel, return value as result.\r\n<|> xAlt ^=> fun x -> result y // Sync on alternative, continue with job.\r\n<|> uAlt ^=>. yJ // Sync on alternative, continue with job ignoring result.\r\n```\r\n\r\nAlso added are new operators `*<-=>` and `*<+->` that directly implement the most common usage patterns (using guard (or prepare) and withNack) for encapsulating asynchronous requests as selective synchronous operations.\r\n\r\n```fsharp\r\nqCh *<-=> fun rI -> (q, rI) // Query with reply var, sync on give to server, wait reply.\r\nqCh *<+-> fun rI n -> (q, rI, n) // Query with reply ch and nack, send to server, sync on reply.\r\n```\r\n\r\nThese can, of course, also be used with the other alternative operators. For example, swap channel implementation:\r\n\r\n```fsharp\r\nlet swap (SwapCh sCh) (msgOut: 'a) =\r\n sCh ^=> fun (msgIn, outI) -> outI *<= msgOut >>% msgIn\r\n <|> sCh *<-=> fun inI -> (msgOut, inI)\r\n```\r\n\r\nThe new message passing operators now have higher precedence than monadic sequencing combinators, so one can now write sequences of message passes without parentheses. For example:\r\n\r\n```fsharp\r\nxI *<= x >>.\r\nxCh *<- x >>.\r\nyCh *<+ y\r\n```\r\n\r\nThe available operator symbols in F# are rather limited, but I feel that the redesigned operators lead to slightly cleaner expressions.\r\n\r\nThere are also some unnecessary operations being removed and I also plan to rename/rething some of the alternative combinators, but more on that later.\r\n\r\nFeedback would be welcome!\r\n\r\nIf you have plenty of extra time, you could try the brach locally and try to format your code with the changes to see if things improve and report back if things get difficult or you don't see a nice way to format your code.",
"title": "Signature rethink",
"type": "issue"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 108518318,
"datetime": 1433349766000,
"masked_author": "username_1",
"text": "The less parenthesis the better :)\r\n\r\nFrom first impression, `*<+` does not look very like an arrow.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 108519714,
"datetime": 1433350023000,
"masked_author": "username_1",
"text": "I think removing parenthesis from here\r\n\r\n```fsharp\r\nif 0 < n then (dec >>%? n - 1) <|>? (inc >>%? n + 1)\r\n```\r\n\r\n```fsharp\r\nif 0 < n then dec ^->. n - 1 <|> inc ^->. n + 1\r\n```\r\n\r\nmakes the expression harder to read.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 108520380,
"datetime": 1433350150000,
"masked_author": "username_1",
"text": "`^->` instead of `|>>?` looks better.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 108522939,
"datetime": 1433350573000,
"masked_author": "username_1",
"text": "```fsharp\r\n(source <~> failedMessages) ^=> fun msg ->\r\n```\r\nrequires parenthesis (not that I use `<~>` very often :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 108526282,
"datetime": 1433351275000,
"masked_author": "username_1",
"text": "```fsharp\r\nlet private takeOrThrow ch = \r\n (ch <|> timeOutMillis 10000 ^-> fun _ -> failwith \"timeout\") |> run \r\n```\r\nand\r\n```fsharp\r\nlet private takeOrThrow ch = \r\n ch <|> timeOutMillis 10000 ^-> fun _ -> failwith \"timeout\" |> run \r\n```\r\nhave completely different semantics. \r\n\r\ni.e. `a1 <|> a2 <|> a3 |> run` is a dangerous expression.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 108527703,
"datetime": 1433351562000,
"masked_author": "username_1",
"text": "Switched to Hopac.Extras, see https://github.com/Hopac/Hopac.Extras/commit/b38b8da830d3e995a41595e70916f42fb2ec07ed \r\n\r\nI'm not sure things become much better or worse. I like the consistency of `-` and `=` semantics where `-` always related to functions and `=` - to jobs.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 108528910,
"datetime": 1433351721000,
"masked_author": "username_1",
"text": "About `*<+->` and `*<-=>`, they are too complicated for my taste. Hard to remember. However, if split them to `*<+` + `->` and `*<-` + `=>`, then them begin to make sense, though.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "VesaKarvonen",
"comment_id": 108597337,
"datetime": 1433361695000,
"masked_author": "username_0",
"text": "That is exactly the idea behind those operators. :) The left hand side part is the message passing operation used to send the query to the server and right hand side is the message passing operation used to receive the reply from the server.\r\n\r\nOne way to make this clearer might be to add something between the parts. To make obvious the idea that you already figured out, the symbols could be `*<-+/-->` and `*<--/=->`. However, this perhaps gets a bit too long?\r\n\r\n```fsharp\r\nlet swap (SwapCh sCh) (msgOut: 'a) =\r\n sCh ^=> fun (msgIn, outI) -> outI *<-= msgOut >>% msgIn\r\n <|> sCh *<--/=-> fun inI -> (msgOut, inI)\r\n```\r\nvs\r\n```fsharp\r\nlet swap (SwapCh sCh) (msgOut: 'a) =\r\n sCh ^=> fun (msgIn, outI) -> outI *<-= msgOut >>% msgIn\r\n <|> sCh *<-=> fun inI -> (msgOut, inI)\r\n```\r\n\r\nNot sure which I would prefer here. Which one do you prefer? Other suggestions are also welcome.\r\n\r\nIn the object pool, for example, you have:\r\n```fsharp\r\n let get() = Alt.withNackJob <| fun nack ->\r\n let replyCh = Ch()\r\n reqCh *<+ (nack, replyCh) >>% replyCh\r\n```\r\nwhich could now be written as a one liner:\r\n```fsharp\r\n let get() = reqCh *<-+/--> fun replyCh nack -> (nack, replyCh)\r\n```\r\nor if you swap that tuple elements, you could write:\r\n```fsharp\r\n let get() = reqCh *<-+/--> curry id\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "VesaKarvonen",
"comment_id": 108603858,
"datetime": 1433362985000,
"masked_author": "username_0",
"text": "Speaking about more consistent choice of symbols, I wonder whether changing to the same scheme of using `=` for bind-like and and `-` for map-like operators and `.` as \"ignore\" and `!` as raise. So, instead of\r\n\r\n```fsharp\r\nval (>>=): Job<'x> -> ('x -> Job<'y>) -> Job<'y>\r\nval (>>.): Job<'x> -> Job<'y> -> Job<'y>\r\nval (|>>): Job<'x> -> ('x -> 'y ) -> Job<'y>\r\nval (>>%): Job<'x> -> 'y -> Job<'y>\r\nval (>>!): Job<'x> -> exn -> Job<'y>\r\n\r\nval (>=>): ('x -> Job<'y>) -> ('y -> Job<'z>) -> 'x -> Job<'z>\r\n```\r\n\r\nthere would be\r\n\r\n```fsharp\r\nval (>>=): Job<'x> -> ('x -> Job<'y>) -> Job<'y>\r\nval (>>=.): Job<'x> -> Job<'y> -> Job<'y>\r\nval (>>-): Job<'x> -> ('x -> 'y ) -> Job<'y>\r\nval (>>-.): Job<'x> -> 'y -> Job<'y>\r\nval (>>-!): Job<'x> -> exn -> Job<'y>\r\n\r\nval (>=>): ('x -> Job<'y>) -> ('y -> Job<'z>) -> 'x -> Job<'z>\r\nval (>=>.): ('x -> Job<'y>) -> Job<'z> -> 'x -> Job<'z>\r\nval (>->): ('x -> Job<'y>) -> ('y -> 'z ) -> 'x -> Job<'z>\r\nval (>->.): ('x -> Job<'y>) -> 'z -> 'x -> Job<'z>\r\nval (>->!): ('x -> Job<'y>) -> exn -> 'x -> Job<'z>\r\n```\r\n\r\nI believe the odd-case of `.>>` is not frequently used with jobs/alts/asyncs and it might be better to just remove it. It is more useful with parser combinators.\r\n\r\nOpinions?\r\n\r\nPersonally I think that `>>=.` looks a bit odd as I'm used to `>>.`, but I suppose it would start looking familiar very quickly.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vasily-kirichenko",
"comment_id": 108789529,
"datetime": 1433407407000,
"masked_author": "username_1",
"text": "About arrows\r\n```fsharp\r\nxCh *<-- x vs xCh *<- x\r\nxCh *<-+ x vs xCh *<+ x\r\nxIv *<-= x vs xIv *<= x\r\nxMv *<<-= x vs xMv *<<= x\r\nxMb *<<-+ x vs xMb *<<+ x\r\n```\r\nI prefer the right option. Although some of them don't look like very much as arrows, they are shorter. \r\n\r\nAbout `*<-=>` vs `*<--/=->`, I prefer the shorter version. \r\n\r\nAbout consistent use of `-` and `=`, I love the new operators. Much easier to remember.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "polytypic",
"comment_id": null,
"datetime": 1448108610000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 12 | 6,981 | false | false | 6,981 | false |
usds/website | usds | 198,742,666 | 228 | null | [
{
"action": "opened",
"author": "dkaufman36",
"comment_id": null,
"datetime": 1483545727000,
"masked_author": "username_0",
"text": "",
"title": "Remove 3 People from USDS.gov homepage people section",
"type": "issue"
},
{
"action": "created",
"author": "chrisfrommann",
"comment_id": 271690060,
"datetime": 1484080462000,
"masked_author": "username_1",
"text": "Fixed in `master`",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "chrisfrommann",
"comment_id": null,
"datetime": 1484080462000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 17 | false | false | 17 | false |
benjreinhart/react-native-aws3 | null | 222,122,967 | 41 | {
"number": 41,
"repo": "react-native-aws3",
"user_login": "benjreinhart"
} | [
{
"action": "opened",
"author": "JeffersonFilho",
"comment_id": null,
"datetime": 1492431777000,
"masked_author": "username_0",
"text": "Hello,\r\n\r\nThis will fix the issue with the 'NSURLSession/NSURLConnection HTTP load failed (kCFStreamErrorDomainSSL, -9843)' when trying to upload an image/video to your amazon bucket on iOS devices.\r\n\r\nYou also need to add this into your info.plist on NSAppTransportSecurity\r\n\r\n```\r\n<key>amazonaws.com</key>\r\n <dict>\r\n <key>NSExceptionAllowsInsecureHTTPLoads</key>\r\n <true/>\r\n </dict>\r\n```",
"title": "Remove https from bucket url to fix issue HTTP load failed (kCFStreamErrorDomainSSL, -9843 on iOS devices.",
"type": "issue"
},
{
"action": "created",
"author": "benjreinhart",
"comment_id": 294695295,
"datetime": 1492495178000,
"masked_author": "username_1",
"text": "Hey there, thanks for contributing! However, this hasn't been an issue for me or anyone else that I know of, so I'm not sure if this is actually solving any real problem that isn't specific to your use case / environment. Could you provide any more information on why https doesn't work for you, and why it would be acceptable to use insecure http requests?\r\n\r\nI don't want to send insecure requests nor did I know Amazon would even allow insecure requests (do they?). I'd much prefer to keep requests secure so I'm not going to accept this. If I see others also surfacing this as an actual issue that I'm just not aware of, I'd consider allowing an option to allow clients to *opt in* to insecure requests, but I wouldn't want it to be the default.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "JeffersonFilho",
"comment_id": 294721048,
"datetime": 1492502471000,
"masked_author": "username_0",
"text": "Morning @username_1 this issue is related to this https://github.com/username_1/react-native-aws3/issues/8 and I'm not sure either why it happens and how to fix it without doing what I did on the pull request.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,364 | false | false | 1,364 | true |
department-of-veterans-affairs/caseflow | department-of-veterans-affairs | 445,198,527 | 10,812 | null | [
{
"action": "opened",
"author": "tomas-nava",
"comment_id": null,
"datetime": 1558048791000,
"masked_author": "username_0",
"text": "Sentry error: https://sentry.ds.va.gov/department-of-veterans-affairs/caseflow/issues/3013/events/336170/\r\n\r\n[pdf.js](https://github.com/mozilla/pdf.js) has trouble rendering some PDFs, [possibly due to incompatible font issues](https://github.com/mozilla/pdf.js/issues/5798), and errors with the message \"Bad encoding in flate stream\". This doesn't appear to affect the ability of the user to view the document.",
"title": "\"bad encoding in flate stream\" error from pdf.js with certain documents",
"type": "issue"
},
{
"action": "created",
"author": "ferristseng",
"comment_id": 499897525,
"datetime": 1559916257000,
"masked_author": "username_1",
"text": "https://sentry.ds.va.gov/department-of-veterans-affairs/caseflow/issues/5286/",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jcq",
"comment_id": 618493317,
"datetime": 1587658522000,
"masked_author": "username_2",
"text": "https://sentry.ds.va.gov/department-of-veterans-affairs/caseflow/issues/7897/",
"title": null,
"type": "comment"
}
] | 3 | 3 | 566 | false | false | 566 | false |
cloudflare/cfssl | cloudflare | 142,625,142 | 559 | null | [
{
"action": "opened",
"author": "matiaskorhonen",
"comment_id": null,
"datetime": 1458646799000,
"masked_author": "username_0",
"text": "<https://cfssl.org/> goes into an infinite redirect loop:\r\n\r\n```console\r\n$ curl -i https://cfssl.org/\r\nHTTP/1.1 301 Moved Permanently\r\nServer: cloudflare-nginx\r\nDate: Tue, 22 Mar 2016 11:37:41 GMT\r\nContent-Type: text/html\r\nTransfer-Encoding: chunked\r\nConnection: keep-alive\r\nSet-Cookie: __cfduid=d269eecf164390cfd77dccc4afd8fd7841458646660; expires=Wed, 22-Mar-17 11:37:40 GMT; path=/; domain=.cfssl.org; HttpOnly\r\nLocation: https://cfssl.org/\r\nServed-In-Seconds: 0.000\r\nCF-RAY: 28795a5ea4503732-ARN\r\n\r\n<html>\r\n<head><title>301 Moved Permanently</title></head>\r\n<body bgcolor=\"white\">\r\n<center><h1>301 Moved Permanently</h1></center>\r\n<hr><center>nginx</center>\r\n</body>\r\n</html>\r\n```",
"title": "cfssl.org infinite redirect loop",
"type": "issue"
},
{
"action": "created",
"author": "jacobhaven",
"comment_id": 199861378,
"datetime": 1458659904000,
"masked_author": "username_1",
"text": "Odd. @jgrahamc could you take a look at this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "grittygrease",
"comment_id": 201073820,
"datetime": 1458862496000,
"masked_author": "username_2",
"text": "Fixed in CloudFlare configuration.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "grittygrease",
"comment_id": null,
"datetime": 1458862496000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "seunosewa",
"comment_id": 247764998,
"datetime": 1474112705000,
"masked_author": "username_3",
"text": "How was it fixed?",
"title": null,
"type": "comment"
}
] | 4 | 5 | 780 | false | false | 780 | false |
pgroonga/pgroonga | pgroonga | 498,068,003 | 113 | null | [
{
"action": "opened",
"author": "igolkotek",
"comment_id": null,
"datetime": 1569391558000,
"masked_author": "username_0",
"text": "Hi,\r\nIn postgres there is **<->** (FOLLOWED BY) tsquery operator, determining the distance between lexeme occurrences.\r\n**pgroonga_score** just submits a ranking place. \r\nIf we had a distance score like in postgres, it could be possible to make some weighted ranking just multiplying distance by weight.\r\nMaybe there is some other pgroonga_score function to show the distance?\r\n\r\nThanks",
"title": "Is available pgroonga_score as a distance, not a score?",
"type": "issue"
},
{
"action": "created",
"author": "kou",
"comment_id": 534873854,
"datetime": 1569392784000,
"masked_author": "username_1",
"text": "Could you show your use case with sample data?\r\nWhy do you want to implement weight by distance?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "igolkotek",
"comment_id": 534885986,
"datetime": 1569395362000,
"masked_author": "username_0",
"text": "As a variant to make a weighted query of several jsonb fields, I'd make this:\r\n\r\n```\r\nSELECT id, pgroonga_score(tableoid, ctid) * 1.0 AS score FROM jsonb_table WHERE title &@ 'word'\r\nunion\r\nSELECT id, pgroonga_score(tableoid, ctid)* 0.5 AS score FROM jsonb_table WHERE body &@ 'word'\r\norder by score desc\r\n```\r\nbut score as an ordinal ranking doesn't make sence",
"title": null,
"type": "comment"
}
] | 2 | 3 | 847 | false | false | 847 | false |
angular/angular | angular | 411,382,552 | 28,796 | null | [
{
"action": "opened",
"author": "Adam-Kernig",
"comment_id": null,
"datetime": 1550482711000,
"masked_author": "username_0",
"text": "### Affected Package\r\n@angular/compiler-cli - v7.2.5\r\n\r\n### Description\r\n\r\n│ Low │ Regular Expression Denial of Service \r\n│ Package │ braces \r\n│ Patched in │ >=2.3.1 \r\n│ Dependency of │ @angular/compiler-cli [dev] \r\n│ Path │ @angular/compiler-cli > chokidar > anymatch > micromatch > braces \r\n│ More info │ https://npmjs.com/advisories/786 \r\n\r\n**Anything else relevant?**\r\nLink to https://github.com/angular/angular/issues/28771 as they have reported it first",
"title": "NPM Audit Failure - @angular/compiler-cli - V7.2.5",
"type": "issue"
},
{
"action": "created",
"author": "Adam-Kernig",
"comment_id": 464664257,
"datetime": 1550483715000,
"masked_author": "username_0",
"text": "Update:\r\nThe issue has been reported here to help\r\nhttps://github.com/micromatch/anymatch/issues/26",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "vladimiry",
"comment_id": 464665973,
"datetime": 1550483982000,
"masked_author": "username_1",
"text": "Any reason to have two similar issues open (the original one https://github.com/angular/angular/issues/28771)?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Adam-Kernig",
"comment_id": 464671777,
"datetime": 1550484982000,
"masked_author": "username_0",
"text": "Yes, the post name was vague this is why I have included in the description for it to be linked.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "gkalpak",
"comment_id": null,
"datetime": 1550494505000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "gkalpak",
"comment_id": 464721870,
"datetime": 1550494505000,
"masked_author": "username_2",
"text": "Closing as a duplicate of #28771. I'll update the title there.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Adam-Kernig",
"comment_id": 464724233,
"datetime": 1550495026000,
"masked_author": "username_0",
"text": "thanks @username_2",
"title": null,
"type": "comment"
}
] | 4 | 8 | 1,480 | false | true | 1,120 | true |
Ensembl/public-plugins | Ensembl | 419,421,883 | 194 | {
"number": 194,
"repo": "public-plugins",
"user_login": "Ensembl"
} | [
{
"action": "opened",
"author": "at7",
"comment_id": null,
"datetime": 1552303852000,
"masked_author": "username_0",
"text": "I updated the path to use the release version. This will be important to get the correct data when checking archive sites.",
"title": "use release version",
"type": "issue"
},
{
"action": "created",
"author": "ens-ma7",
"comment_id": 472873153,
"datetime": 1552572655000,
"masked_author": "username_1",
"text": "@username_0 but that means for each release we will have to update the path?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "at7",
"comment_id": 472877646,
"datetime": 1552573050000,
"masked_author": "username_0",
"text": "The data is not static and compara includes new species every release. If we keep updating the release version and the new new name of the alignment directory (from 75_mammals.gerp_conservation_score in release-95 to 88_mammals.gerp_conservation_score in release-96) we will be backwards compatible for archive sites. They might not always increase but I think this way we are safe?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ens-ap5",
"comment_id": 472878302,
"datetime": 1552573112000,
"masked_author": "username_2",
"text": "Given that the first part of the URL is identical in each species ('ftp://ftp.ensembl.org/pub/current_compara/conservation_scores/'), it would make sense to generate it in the code that consumes the JSON, instead of having the full path hard-coded. Then we wouldn't need to update it every release, just when the number of mammals in the GERP alignment changes.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "at7",
"comment_id": 472879894,
"datetime": 1552573268000,
"masked_author": "username_0",
"text": "I like that. Shall we create a ticket for this for next time or is there time do it for 96? I can adjust the paths accordingly in the config files.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ens-ap5",
"comment_id": 472880358,
"datetime": 1552573314000,
"masked_author": "username_2",
"text": "It should be a simple change. Put in a ticket now and I'll pick it up, like we did for the vervet variation link.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "at7",
"comment_id": 472883439,
"datetime": 1552573596000,
"masked_author": "username_0",
"text": "Here is the ticket: https://www.ebi.ac.uk/panda/jira/browse/ENSWEB-4943\r\nThank you",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ens-ma7",
"comment_id": 472884090,
"datetime": 1552573659000,
"masked_author": "username_1",
"text": "Thanks @username_2, i was going to suggest the same thing, you are too quick in responding, i was confused, i thought i was replying on an all PR.\r\n\r\nI will leave this PR open until you have your changes in @username_2 , feel free to close it once you are happy.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ens-ap5",
"comment_id": 472884646,
"datetime": 1552573711000,
"masked_author": "username_2",
"text": "Sorry, I thought I'd chime in since I saw an obvious solution :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ens-ma7",
"comment_id": 472891644,
"datetime": 1552574362000,
"masked_author": "username_1",
"text": "No problem at all, its just that within 5 minutes there was like 4 comments on the PR :) anyway its all yours now :)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "at7",
"comment_id": 472894724,
"datetime": 1552574645000,
"masked_author": "username_0",
"text": "Is this what you had in mind? If yes, I will update the other species as well.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ens-ap5",
"comment_id": 472897448,
"datetime": 1552574948000,
"masked_author": "username_2",
"text": "Yes, that's perfect!",
"title": null,
"type": "comment"
}
] | 3 | 12 | 1,810 | false | false | 1,810 | true |
imachug/win-sudo | null | 332,836,756 | 26 | {
"number": 26,
"repo": "win-sudo",
"user_login": "imachug"
} | [
{
"action": "opened",
"author": "DemonixCraft-1",
"comment_id": null,
"datetime": 1529079449000,
"masked_author": "username_0",
"text": "I changed a few things in installalliases and moved some commands around in install.sh. Now I completely understand if you don't want to do this, due to Travis CI being for larger projects, and I'll gladly make a commit with the same changes but remove CI Integration. Here it is, `.travis.yml`, the config file for Travis CI, who in which will help us test, build, and deploy our commits with ease. I am unsure whether the owner of the repo will have to manually integrate Travis CI for this to work. My config demands that the test project is build in a Google Compute Engine using the Windows Operating System with a mere 3 environment variables (because these environment variables were defined in my fork, they may need to be redefined in every fork) : \r\n\r\n* USER_NAME : Username of the commiter\r\n\r\n* USER_EMAIL : Email of the commiter\r\n\r\n\r\n**Deploy Variables : ** (NOTE : These can be removed if the owner of the repo feels uncomfortable doing this)\r\n\r\n* GITHUB_TOKEN : Personal Access Token of the Repo Owner with the following scopes : repo, read:org, write:repo_hook, and user:email. This token is not shown in script, as it can be secretly passed to Travis as a secure variable. Again, I can remove the entire deploy section if you don't want to do this.\r\n\r\nThe goal of this PR is to make testing the win-sudo repo easier, as Travis CI builds the project in an isolated computer and will check for any errors. Since Travis CI works with Linux Distros, I had to move a few things around to installation would work both in Linux and Bash. \r\n\r\nIf username_1 doesn't want to go through with the `deploy` part I can just set the functionality to just check if the file works properly.",
"title": "Integrated Travis CI + Minor Changes",
"type": "issue"
},
{
"action": "created",
"author": "imachug",
"comment_id": 413594534,
"datetime": 1534434856000,
"masked_author": "username_1",
"text": "Sorry for inactivity.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 1,707 | false | false | 1,707 | true |
GSA/datagov-deploy | GSA | 498,478,906 | 978 | null | [
{
"action": "opened",
"author": "adborden",
"comment_id": null,
"datetime": 1569439792000,
"masked_author": "username_0",
"text": "## User Story\r\nAs a Data.gov content editor, I want to know what \"buckets\" we have for content, who the audience is, and what content should live there so that I know where I should put different content.\r\n\r\n## Details\r\n\r\n## Acceptance Criteria\r\n- [ ] Documentation describing our different components, the audience, and type of content",
"title": "Describe our different content repositories and what content should live there",
"type": "issue"
}
] | 1 | 1 | 336 | false | false | 336 | false |
qiniu/java-sdk | qiniu | 513,664,448 | 460 | null | [
{
"action": "opened",
"author": "zhufaming",
"comment_id": null,
"datetime": 1572318152000,
"masked_author": "username_0",
"text": "Cannot resolve com.qiniu:qiniu-java-sdk:7.2.25",
"title": "idea Maven 无法引用",
"type": "issue"
},
{
"action": "created",
"author": "forrest-mao",
"comment_id": 661910316,
"datetime": 1595343241000,
"masked_author": "username_1",
"text": "可以参考 maven 官方的示例进行引用 https://search.maven.org/artifact/com.qiniu/qiniu-java-sdk/7.2.29/jar",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "forrest-mao",
"comment_id": 661911555,
"datetime": 1595343368000,
"masked_author": "username_1",
"text": "仅七牛内部员工可见：https://jira.qiniu.io/browse/TS-985",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "peteryuanpan",
"comment_id": 662403209,
"datetime": 1595417722000,
"masked_author": "username_2",
"text": "关于如何IntelliJIDEA中导入MAVEN工程，可以参考这篇WIKI：[七牛JAVA SDK：IntelliJIDEA下引入maven工程](https://github.com/qiniu/java-sdk/wiki/%E4%B8%83%E7%89%9BJAVA-SDK%EF%BC%9AIntelliJIDEA%E4%B8%8B%E5%BC%95%E5%85%A5maven%E5%B7%A5%E7%A8%8B)",
"title": null,
"type": "comment"
}
] | 3 | 4 | 392 | false | false | 392 | false |
AdoptOpenJDK/openjdk-docker | AdoptOpenJDK | 461,504,661 | 185 | null | [
{
"action": "opened",
"author": "gdams",
"comment_id": null,
"datetime": 1561639097000,
"masked_author": "username_0",
"text": "We now have official images being built at https://hub.docker.com/_/adoptopenjdk\r\n\r\nSo far we build all releases for Ubuntu 18:04 and all windows releases. We don't build nightlies or slim builds in the official repo though.\r\n\r\nI would propose that we start by deprecating the windows images as they were the most recently added so probably have the least number of users. To deprecate the images we'll need to delete all matching tags, remove the platform from the build job and then add a notice to the top of the README in dockerhub pointing to the new repo.",
"title": "Start deprecating docker images that are built in the official repository",
"type": "issue"
},
{
"action": "created",
"author": "chadlwilson",
"comment_id": 507953361,
"datetime": 1562134200000,
"masked_author": "username_1",
"text": "Would you plan to deprecate only the images only being built in the official repo; i.e the slims (and debians, alpines) would stick around (non-deprecated) for a while?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gdams",
"comment_id": 507966338,
"datetime": 1562137047000,
"masked_author": "username_0",
"text": "That’s the current plan @username_1",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Crow-EH",
"comment_id": 525224648,
"datetime": 1566905987000,
"masked_author": "username_2",
"text": "A bit off-topic, but would you plan to build slims in the official repo ?",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "gdams",
"comment_id": null,
"datetime": 1616067040000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 5 | 838 | false | false | 838 | true |
CytadelHosting/patch_server_updater | CytadelHosting | 464,611,177 | 1 | null | [
{
"action": "opened",
"author": "iampavan",
"comment_id": null,
"datetime": 1562328529000,
"masked_author": "username_0",
"text": "If the PatchServer has an API token created, then the patch_server_updater scripts errors out.\r\n\r\n`JSON : /Users/admin/Desktop/CiscoAnyConnectSecureMobilityClient.json\r\nURL : https://abc.com/\r\nCONFIG : /Users/admin/Desktop/AnyConnect.conf\r\nInput JSON checked, seems to be OK, checking patch server access ...\r\nOk, https://abc.com is recheable, trying to push JSON file to the API.\r\nPush failed, check api response here :\r\n{\r\n \"unauthorized\": \"Authentication required\"\r\n}`\r\n\r\nI do have the API token, but how do I pass it in the script?\r\n\r\nFYI :\r\nIf the PatchServer does not have API token generated, then the patch_server_updater scripts works fine.\r\n\r\n`JSON : /Users/admin/Desktop/ParallelsDesktop.json\r\nURL : https://abc.com/\r\nCONFIG : /Users/admin/Desktop/ParallelsDesktop.conf\r\nInput JSON checked, seems to be OK, checking patch server access ...\r\nOk, https://abc.com is recheable, trying to push JSON file to the API.\r\nPush success, /Users/admin/Desktop/ParallelsDesktop.conf will be generate soon\r\n/Users/admin/Desktop/ParallelsDesktop.conf config file generated !\r\npatch_server_updater.sh [add] will be able to update a new version of ParallelsDesktop if you can parse a website and collect informations`",
"title": "Error \"unauthorized\": \"Authentication required\"",
"type": "issue"
},
{
"action": "created",
"author": "fabiencytadel",
"comment_id": 508747639,
"datetime": 1562330824000,
"masked_author": "username_1",
"text": "Hello,\r\nthank for your message, we didn't use this option with our patch server. I will check the code to implement that soon.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "iampavan",
"comment_id": 508754330,
"datetime": 1562332319000,
"masked_author": "username_0",
"text": "Thank you for your quick response. Appreciate it. ☺️",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fabiencytadel",
"comment_id": 510916985,
"datetime": 1562943261000,
"masked_author": "username_1",
"text": "Hello !\r\n\r\ncould you test the new feature on this branch ?\r\n\r\nhttps://github.com/CytadelHosting/patch_server_updater/tree/add_http_header_for_API_with_token\r\n\r\nThanks !",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "iampavan",
"comment_id": 510943266,
"datetime": 1562947680000,
"masked_author": "username_0",
"text": "Hey hey!\r\nTested. Works perfectly fine.\r\n\r\nThank you.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "iampavan",
"comment_id": 510949193,
"datetime": 1562948827000,
"masked_author": "username_0",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fabiencytadel",
"comment_id": 511355304,
"datetime": 1563187800000,
"masked_author": "username_1",
"text": "Hello Pavan, don't worry, i'm happy you like the script.\r\n\r\nI made some corrections, could you try ?\r\nThanks !",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "iampavan",
"comment_id": 511371223,
"datetime": 1563191471000,
"masked_author": "username_0",
"text": "Awesome. Works great!\r\n\r\nThank you Fabien.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "fabiencytadel",
"comment_id": 511375981,
"datetime": 1563192522000,
"masked_author": "username_1",
"text": "Nice ! Thanks for your help !",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "fabiencytadel",
"comment_id": null,
"datetime": 1563192522000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 10 | 1,792 | false | false | 1,792 | false |
danielnieto/electron-download-manager | null | 281,597,959 | 10 | {
"number": 10,
"repo": "electron-download-manager",
"user_login": "danielnieto"
} | [
{
"action": "opened",
"author": "rugor",
"comment_id": null,
"datetime": 1513129749000,
"masked_author": "username_0",
"text": "adds 'request' to dependencies",
"title": "fix dependencies ",
"type": "issue"
},
{
"action": "created",
"author": "rugor",
"comment_id": 351255752,
"datetime": 1513129870000,
"masked_author": "username_0",
"text": "When packaging for mac with electron packager an error is thrown in the main process because 'request' is used, but not defined as a dependency in package.json.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "danielnieto",
"comment_id": 355686968,
"datetime": 1515192630000,
"masked_author": "username_1",
"text": "thank you! so sorry for taking this much time to confirm the merge, I was on long vacations",
"title": null,
"type": "comment"
}
] | 2 | 3 | 281 | false | false | 281 | false |
jitamin/jitamin | jitamin | 450,140,703 | 325 | {
"number": 325,
"repo": "jitamin",
"user_login": "jitamin"
} | [
{
"action": "opened",
"author": "evangwt",
"comment_id": null,
"datetime": 1559195093000,
"masked_author": "username_0",
"text": "Some web root links are set to \"/\". This pull request fixs them with $application_url.",
"title": "Fix template application url",
"type": "issue"
},
{
"action": "created",
"author": "ugintl",
"comment_id": 982764457,
"datetime": 1638287322000,
"masked_author": "username_1",
"text": "@username_0 Is jitamin built using laravel? What version? When I run command `php artisan key:generate` it says `There are no commands defined in the \"key\" namespace` Similarly, when I run `php artisan --version` it gives me jitamin version. What is all this I do not understand",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "evangwt",
"comment_id": 987614388,
"datetime": 1638858856000,
"masked_author": "username_0",
"text": "It's not laravel.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 379 | false | false | 379 | true |
ManageIQ/manageiq-ui-classic | ManageIQ | 504,522,348 | 6,284 | {
"number": 6284,
"repo": "manageiq-ui-classic",
"user_login": "ManageIQ"
} | [
{
"action": "opened",
"author": "hstastna",
"comment_id": null,
"datetime": 1570612861000,
"masked_author": "username_0",
"text": "**Issue:** https://github.com/ManageIQ/manageiq-ui-classic/issues/6263\r\n\r\nThis PR fixes issue with displaying two _Cancel_ buttons after making changes in _Comparison Sections_ for Compare action. The core of the problem was that `@explorer` variable, which is needed [here](https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/views/layouts/_compare.html.haml#L21), was not always properly set . The place where I put the condition was chosen the way that no matter which changes we make while comparing items, `@explorer` is properly set.\r\n\r\nNote:\r\nI've tested also other screens (explorer and non-explorer ones) under _Compute > Infra_ and also _Compte > Clouds_ and the changes work for them well.\r\n\r\n---\r\n\r\n**Before:**\r\n\r\n\r\n**After:**\r\n",
"title": "Display only one Cancel button for Compare action",
"type": "issue"
}
] | 2 | 3 | 1,507 | false | true | 989 | false |
flutter/flutter | flutter | 487,675,191 | 39,586 | null | [
{
"action": "opened",
"author": "dertin",
"comment_id": null,
"datetime": 1567200044000,
"masked_author": "username_0",
"text": "Error when running Flutter Doctor on Android Studio and the iOS device is not recognized\r\n\r\n## Steps to Reproduce\r\n\r\n1. Install Android Studio\r\n2. Install Flutter plugin on android studio\r\n3. Install all necessary packages for iOS and Android on System\r\n4. Android studio -> Tools -> Flutter -> Flutter Doctor\r\n5. Error the iOS device is not recognized.\r\n\r\n## Logs\r\n\r\nERROR: **Android Studio -> Tools -> Flutter -> Flutter Doctor** \r\n```\r\n/opt/flutter-sdk/flutter/bin/flutter doctor --verbose\r\n\r\n[✓] Flutter (Channel stable, v1.7.8+hotfix.4, on Mac OS X 10.14.6 18G95, locale es-UY)\r\n • Flutter version 1.7.8+hotfix.4 at /opt/flutter-sdk/flutter\r\n • Framework revision 20e59316b8 (6 weeks ago), 2019-07-18 20:04:33 -0700\r\n • Engine revision fee001c93f\r\n • Dart version 2.4.0\r\n\r\n[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)\r\n • Android SDK at /Users/gcespedes/Library/Android/sdk\r\n • Android NDK location not configured (optional; useful for native profiling support)\r\n • Platform android-29, build-tools 29.0.2\r\n • ANDROID_HOME = /Users/gcespedes/Library/Android/sdk\r\n • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java\r\n • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)\r\n • All Android licenses accepted.\r\n\r\n[!] Xcode - develop for iOS and macOS (Xcode 10.3)\r\n • Xcode at /Applications/Xcode.app/Contents/Developer\r\n • Xcode 10.3, Build version 10G8\r\n ✗ CocoaPods not installed.\r\n CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.\r\n Without CocoaPods, plugins will not work on iOS or macOS.\r\n For more info, see https://flutter.dev/platform-plugins\r\n To install:\r\n brew install cocoapods\r\n pod setup\r\n ! Brew can be used to install CocoaPods.\r\n Download brew at https://brew.sh/.\r\n\r\n[✗] iOS tools - develop for iOS devices\r\n ✗ libimobiledevice and ideviceinstaller are not installed. To install with Brew, run:\r\n brew update\r\n brew install --HEAD usbmuxd\r\n brew link usbmuxd\r\n brew install --HEAD libimobiledevice\r\n brew install ideviceinstaller\r\n ✗ ios-deploy not installed. To install:\r\n brew install ios-deploy\r\n ! Brew can be used to install tools for iOS device development.\r\n Download brew at https://brew.sh/.\r\n\r\n[✓] Android Studio (version 3.5)\r\n • Android Studio at /Applications/Android Studio.app/Contents\r\n • Flutter plugin version 38.2.3\r\n • Dart plugin version 191.8423\r\n • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)\r\n\r\n[!] Connected device\r\n ! No devices available\r\n```\r\n\r\nPASS: **From the terminal**\r\n```\r\nuser$ /opt/flutter-sdk/flutter/bin/flutter doctor --verbose\r\n\r\n[✓] Flutter (Channel stable, v1.7.8+hotfix.4, on Mac OS X 10.14.6 18G95, locale es-UY)\r\n • Flutter version 1.7.8+hotfix.4 at /opt/flutter-sdk/flutter\r\n • Framework revision 20e59316b8 (6 weeks ago), 2019-07-18 20:04:33 -0700\r\n • Engine revision fee001c93f\r\n • Dart version 2.4.0\r\n\r\n \r\n[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)\r\n • Android SDK at /Users/user/Library/Android/sdk\r\n • Android NDK location not configured (optional; useful for native profiling support)\r\n • Platform android-29, build-tools 29.0.2\r\n • ANDROID_HOME = /Users/user/Library/Android/sdk\r\n • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java\r\n • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)\r\n • All Android licenses accepted.\r\n\r\n[✓] Xcode - develop for iOS and macOS (Xcode 10.3)\r\n • Xcode at /Applications/Xcode.app/Contents/Developer\r\n • Xcode 10.3, Build version 10G8\r\n • CocoaPods version 1.7.5\r\n\r\n[✓] iOS tools - develop for iOS devices\r\n • ios-deploy 1.9.4\r\n\r\n[✓] Android Studio (version 3.5)\r\n • Android Studio at /Applications/Android Studio.app/Contents\r\n • Flutter plugin version 38.2.3\r\n • Dart plugin version 191.8423\r\n • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)\r\n\r\n[✓] Connected device (1 available)\r\n • iPad • xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx • ios • iOS 12.4.1\r\n\r\n• No issues found!\r\n```\r\n\r\n- pod --version\r\n1.7.5\r\n\r\n- cat .profile AND cat .bashrc\r\n```\r\n...\r\nexport LANG=en_US.UTF-8\r\nexport ANDROID_HOME=/Users/user/Library/Android/sdk\r\nexport ANDROID_SDK=/Users/user/Library/Android/sdk\r\nexport PATH=$ANDROID_SDK/tools:$ANDROID_SDK/platform-tools:$PATH\r\nexport FLUTTER_ROOT=/opt/flutter-sdk/flutter\r\nexport PATH=${PATH}:/opt/flutter-sdk/flutter/bin\r\nexport PATH=${PATH}:/Users/gcespedes/.composer/vendor/bin\r\n...\r\n```",
"title": "Error when running Flutter Doctor on Android Studio and the iOS device is not recognized",
"type": "issue"
},
{
"action": "created",
"author": "jmagman",
"comment_id": 529708206,
"datetime": 1568072472000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "patelkrunal78",
"comment_id": 539078538,
"datetime": 1570463308000,
"masked_author": "username_2",
"text": "Very Similar To [Flutter plugin not installed error;. When running flutter doctor](https://icetutor.com/question/flutter-plugin-not-installed-error-when-running-flutter-doctor)",
"title": null,
"type": "comment"
}
] | 4 | 5 | 5,277 | false | true | 4,982 | false |
raulgarciamsft/ql | null | 505,544,397 | 2 | {
"number": 2,
"repo": "ql",
"user_login": "raulgarciamsft"
} | [
{
"action": "opened",
"author": "rdmarsh2",
"comment_id": null,
"datetime": 1570746858000,
"masked_author": "username_0",
"text": "",
"title": "C++/C#: autoformat QL files",
"type": "issue"
},
{
"action": "created",
"author": "jbj",
"comment_id": 541546729,
"datetime": 1571041042000,
"masked_author": "username_1",
"text": "@username_0 This is now in conflict. Also, `SAL.qll` has been added to the PR and needs autoformat.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 97 | false | false | 97 | true |
rosin-project/rosinstall_generator_time_machine | rosin-project | 378,851,805 | 8 | {
"number": 8,
"repo": "rosinstall_generator_time_machine",
"user_login": "rosin-project"
} | [
{
"action": "opened",
"author": "gavanderhoorn",
"comment_id": null,
"datetime": 1541700138000,
"masked_author": "username_0",
"text": "Unfinished, but wanted to get some early feedback.\r\n\r\nDocs have not been updated.",
"title": "WIP: Add pre 2014 support -- second attempt",
"type": "issue"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 437100402,
"datetime": 1541700637000,
"masked_author": "username_0",
"text": "@wasowski @username_2 @username_1\r\n\r\nTo use:\r\n\r\n - build Docker image (use build script)\r\n - check help output of `rosinstall_generator_tm.sh`\r\n\r\nNote: this new version of the time machine does not accept URLs to issues/PRs as input any more. It only accepts iso8601 timestamps.\r\n\r\nThe `get_issue_creation_date.py` script can be used to find the `created_at` datetime stamp, but that requires `PyGitHub`. That is present in the Docker image, but I don't provide an easy way to run that script inside a container yet.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 437100670,
"datetime": 1541700682000,
"masked_author": "username_0",
"text": "Related: #1, #2, #3 and #4.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 437146957,
"datetime": 1541709441000,
"masked_author": "username_0",
"text": "Next goal would be to add the time machine script itself to the Docker image. That way it would be completely self-contained.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 437411530,
"datetime": 1541780397000,
"masked_author": "username_0",
"text": "A simple test -- to see if at least the infrastructure of the new version works on machines-not-my-own:\r\n\r\n```\r\nrosinstall_generator_tm.sh \"2016-01-01T00:00:00+00:00\" indigo roscpp --deps\r\n```\r\n\r\nThat should get you a `.rosinstall` file (but printed to your console) with `roscpp` itself *and* all of its (transitive) dependencies.\r\n\r\nI've been creating some more rosdistro caches and uploading them so ideally generating that `.rosinstall` file takes very little time, as it should be able to reuse a cache I've already created.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "git-afsantos",
"comment_id": 437683056,
"datetime": 1541952885000,
"masked_author": "username_1",
"text": "The new changes look good, but once again my inexperience with Docker strikes.\r\n\r\nFrom what I understood, `virtualenv` has been replaced with a Docker image, which contains all the dependencies of the time machine. Including the time machine within said image is the end goal.\r\nSo, how does this work in practice for the newbies? Do I build the image and run a container, or does the time machine interact with the image in a more transparent way?\r\n\r\nSorry if the help output of the script answers this, have not tried it yet, but will soon.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 437683431,
"datetime": 1541953199000,
"masked_author": "username_0",
"text": "For the moment you only interact with the script. It does everything for you.\r\n\r\nExcept building the Docker image it needs that will contain the necessary `virtualenv`s.\r\n\r\nSo as I wrote in https://github.com/rosin-project/rosinstall_generator_time_machine/pull/8#issuecomment-437100402, you run `build.sh` in the `docker` sub dir and you're set (`rosinstall_generator_tm.sh` will also complain if it can't find the Docker image it needs).\r\n\r\n---\r\n\r\nFor the next version I'll add `rosinstall_generator_tm.sh` to the image and add a very thin shell script that will basically do something like this:\r\n\r\n```\r\ndocker run \\\r\n -it \\\r\n --rm \\\r\n -v <map some dirs in your homedir to inside the container> \\\r\n robust-rosin/rosinstall_generator_time_machine:02 \\\r\n /rgtm/rosinstall_generator_tm.sh \"$*\"\r\n```\r\n\r\nSo you still only interact with a bash script, but that just forwards everything to the script inside the Docker image.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ChrisTimperley",
"comment_id": 438314024,
"datetime": 1542123947000,
"masked_author": "username_2",
"text": "This is awesome. Thanks! I'll update the `build-rosinstall.py` script on a separate branch.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ChrisTimperley",
"comment_id": 438317192,
"datetime": 1542124418000,
"masked_author": "username_2",
"text": "One observation: It looks like git versions are now being returned instead of archives? Using the archives might help to reduce the size of the Docker image for each scenario?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "git-afsantos",
"comment_id": 438342817,
"datetime": 1542127405000,
"masked_author": "username_1",
"text": "Need to clone rosdistro .. done\r\nNeed to retrieve some rosdistro caches ..done\r\nRequested timepoint: '2016-01-01T00:00:00+00:00' (1451606400)\r\nResetting local rosdistro clone ..\r\nAlready on 'master'\r\nYour branch is up-to-date with 'origin/master'.\r\nDetermined rosdistro commit: a772634f (authored: 1451597278)\r\nReverting to ros/rosdistro@a772634f\r\nCache already exists for (distro; stamp) tuple, skipping generation\r\nUpdating local rosdistro index.yaml to use cache from the past ..\r\nInvoking: rosinstall_generator --rosdistro=indigo roscpp --deps --tar\r\nUsing ROS_DISTRO: indigo\r\n- tar:\r\n local-name: catkin\r\n uri: https://github.com/ros-gbp/catkin-release/archive/release/indigo/catkin/0.6.16-0.tar.gz\r\n version: catkin-release-release-indigo-catkin-0.6.16-0\r\n- tar:\r\n local-name: cmake_modules\r\n uri: https://github.com/ros-gbp/cmake_modules-release/archive/release/indigo/cmake_modules/0.3.3-0.tar.gz\r\n version: cmake_modules-release-release-indigo-cmake_modules-0.3.3-0\r\n- tar:\r\n local-name: gencpp\r\n uri: https://github.com/ros-gbp/gencpp-release/archive/release/indigo/gencpp/0.5.3-0.tar.gz\r\n version: gencpp-release-release-indigo-gencpp-0.5.3-0\r\n- tar:\r\n local-name: genlisp\r\n uri: https://github.com/ros-gbp/genlisp-release/archive/release/indigo/genlisp/0.4.15-0.tar.gz\r\n version: genlisp-release-release-indigo-genlisp-0.4.15-0\r\n- tar:\r\n local-name: genmsg\r\n uri: https://github.com/ros-gbp/genmsg-release/archive/release/indigo/genmsg/0.5.6-0.tar.gz\r\n version: genmsg-release-release-indigo-genmsg-0.5.6-0\r\n- tar:\r\n local-name: genpy\r\n uri: https://github.com/ros-gbp/genpy-release/archive/release/indigo/genpy/0.5.7-0.tar.gz\r\n version: genpy-release-release-indigo-genpy-0.5.7-0\r\n- tar:\r\n local-name: message_generation\r\n uri: https://github.com/ros-gbp/message_generation-release/archive/release/indigo/message_generation/0.2.10-0.tar.gz\r\n version: message_generation-release-release-indigo-message_generation-0.2.10-0\r\n- tar:\r\n local-name: message_runtime\r\n uri: https://github.com/ros-gbp/message_runtime-release/archive/release/indigo/message_runtime/0.4.12-0.tar.gz\r\n version: message_runtime-release-release-indigo-message_runtime-0.4.12-0\r\n- tar:\r\n local-name: ros/rosbuild\r\n uri: https://github.com/ros-gbp/ros-release/archive/release/indigo/rosbuild/1.11.11-0.tar.gz\r\n version: ros-release-release-indigo-rosbuild-1.11.11-0\r\n- tar:\r\n local-name: ros/roslang\r\n uri: https://github.com/ros-gbp/ros-release/archive/release/indigo/roslang/1.11.11-0.tar.gz\r\n version: ros-release-release-indigo-roslang-1.11.11-0\r\n- tar:\r\n local-name: ros/roslib\r\n uri: https://github.com/ros-gbp/ros-release/archive/release/indigo/roslib/1.11.11-0.tar.gz\r\n version: ros-release-release-indigo-roslib-1.11.11-0\r\n- tar:\r\n local-name: ros/rosunit\r\n uri: https://github.com/ros-gbp/ros-release/archive/release/indigo/rosunit/1.11.11-0.tar.gz\r\n version: ros-release-release-indigo-rosunit-1.11.11-0\r\n- tar:\r\n local-name: ros_comm/rosconsole\r\n uri: https://github.com/ros-gbp/ros_comm-release/archive/release/indigo/rosconsole/1.11.16-0.tar.gz\r\n version: ros_comm-release-release-indigo-rosconsole-1.11.16-0\r\n- tar:\r\n local-name: ros_comm/roscpp\r\n uri: https://github.com/ros-gbp/ros_comm-release/archive/release/indigo/roscpp/1.11.16-0.tar.gz\r\n version: ros_comm-release-release-indigo-roscpp-1.11.16-0\r\n- tar:\r\n local-name: ros_comm/xmlrpcpp\r\n uri: https://github.com/ros-gbp/ros_comm-release/archive/release/indigo/xmlrpcpp/1.11.16-0.tar.gz\r\n version: ros_comm-release-release-indigo-xmlrpcpp-1.11.16-0\r\n- tar:\r\n local-name: ros_comm_msgs/rosgraph_msgs\r\n uri: https://github.com/ros-gbp/ros_comm_msgs-release/archive/release/indigo/rosgraph_msgs/1.11.1-0.tar.gz\r\n version: ros_comm_msgs-release-release-indigo-rosgraph_msgs-1.11.1-0\r\n- tar:\r\n local-name: roscpp_core/cpp_common\r\n uri: https://github.com/ros-gbp/roscpp_core-release/archive/release/indigo/cpp_common/0.5.6-0.tar.gz\r\n version: roscpp_core-release-release-indigo-cpp_common-0.5.6-0\r\n- tar:\r\n local-name: roscpp_core/roscpp_serialization\r\n uri: https://github.com/ros-gbp/roscpp_core-release/archive/release/indigo/roscpp_serialization/0.5.6-0.tar.gz\r\n version: roscpp_core-release-release-indigo-roscpp_serialization-0.5.6-0\r\n- tar:\r\n local-name: roscpp_core/roscpp_traits\r\n uri: https://github.com/ros-gbp/roscpp_core-release/archive/release/indigo/roscpp_traits/0.5.6-0.tar.gz\r\n version: roscpp_core-release-release-indigo-roscpp_traits-0.5.6-0\r\n- tar:\r\n local-name: roscpp_core/rostime\r\n uri: https://github.com/ros-gbp/roscpp_core-release/archive/release/indigo/rostime/0.5.6-0.tar.gz\r\n version: roscpp_core-release-release-indigo-rostime-0.5.6-0\r\n- tar:\r\n local-name: rospack\r\n uri: https://github.com/ros-gbp/rospack-release/archive/release/indigo/rospack/2.2.5-0.tar.gz\r\n version: rospack-release-release-indigo-rospack-2.2.5-0\r\n- tar:\r\n local-name: std_msgs\r\n uri: https://github.com/ros-gbp/std_msgs-release/archive/release/indigo/std_msgs/0.5.9-1.tar.gz\r\n version: std_msgs-release-release-indigo-std_msgs-0.5.9-1\r\n</details>",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 438350682,
"datetime": 1542128654000,
"masked_author": "username_0",
"text": "Thanks @username_1.\r\n\r\nre: did not take long: that is good to hear and was one of the reasons I wanted to improve the script. Notice how it skips generating the cache because it already exists.\r\n\r\nThe output also looks like I would have expected it.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 438352295,
"datetime": 1542128913000,
"masked_author": "username_0",
"text": "O and one thing: if/when you have generated a few `.rosinstall` files -- and the accompanying `rosdistro` caches -- could you open a PR against [username_0/rgtm_rosdistro_caches](https://github.com/username_0/rgtm_rosdistro_caches) contributing the new caches.\r\n\r\nThat way things will go faster for everyone.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "git-afsantos",
"comment_id": 438435353,
"datetime": 1542142961000,
"masked_author": "username_1",
"text": "Not sure if I should open a new issue, of if it is intended behaviour (for now), and I just missed it.\r\n\r\nWhen the generator needs to build a new cache, output redirection should be avoided - or else, you do not see the prompts for github credentials, which require you to hit Enter.\r\n\r\nSo the best workflow for now is to run once without redirection, to build the cache if needed, and then run again, redirecting to the intended file.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 438438813,
"datetime": 1542143641000,
"masked_author": "username_0",
"text": "As also mentioned in https://github.com/robust-rosin/robust/issues/56#issuecomment-438438255, redirection should not be affecting the git pw prompts, as they should be appearing on `stderr`, which is not redirected with a regular `>`.\r\n\r\nI'll see if I can figure out what is going on.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 438663576,
"datetime": 1542202538000,
"masked_author": "username_0",
"text": "@username_1: I've added c7f97015. That appeared to be missing the redirect to `stderr`. A test on my machine with:\r\n\r\n```\r\nrosinstall_generator_tm.sh \"2014-05-11T00:00:00+00:00\" hydro > blaa.txt\r\n```\r\n\r\nshows all the output as I expected, including the pw and user prompts.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "git-afsantos",
"comment_id": 438727054,
"datetime": 1542213137000,
"masked_author": "username_1",
"text": "This works for me too. :+1:",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ChrisTimperley",
"comment_id": 440416194,
"datetime": 1542745231000,
"masked_author": "username_2",
"text": "I'm experiencing some unexpected behaviour with this version of the time machine:\r\n\r\n```\r\nbuilding rosinstall file for file: mavros/101c09b/101c09b.bug\r\nexecuting command: rosinstall_generator_tm.sh 2013-06-30 groovy mavros --deps --tar\r\ntime machine failed for bug [mavros/101c09b/101c09b.bug]:\r\nRequested timepoint: '2013-06-30' (1372564800)\r\nSwitching to pre-REP-141 infrastructure ..\r\nResetting local rosdistro clone ..\r\nPrevious HEAD position was d0158a278... Merge pull request #1148 from 130s/bloom-patch-4\r\nSwitched to branch 'master'\r\nYour branch is up-to-date with 'origin/master'.\r\nDetermined rosdistro commit: d0158a27 (authored: 1372611034)\r\nReverting to ros/rosdistro@d0158a27\r\nCache already exists for (distro; stamp) tuple, skipping generation\r\nUpdating local rosdistro index.yaml to use cache from the past ..\r\nInvoking: rosinstall_generator --rosdistro=groovy mavros --deps --tar\r\nUsing ROS_DISTRO: groovy\r\nThe following not released packages/stacks will be ignored: mavros\r\nNo packages/stacks left after ignoring not released\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 440419277,
"datetime": 1542745888000,
"masked_author": "username_0",
"text": "This is documented [here](https://github.com/rosin-project/rosinstall_generator_time_machine#no-packagesstacks-left-after-ignoring-not-released), but it basically means that `mavros` was not released in `groovy` at the time you requested.\r\n\r\nNote btw: the code expects a ISO 8601 timestamp, which I don't believe `2013-06-30` is. Is this the json/Python parsing of the yaml again?\r\n\r\n`date` and `git` can be flexible when parsing date-times, but just to avoid possible issues I would *really* recommend to use iso8601 stamps. They are much less ambiguous: `2016-06-30` does not include any info on timezones, which will make datetime parsing dependent on local time+date configuration.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ChrisTimperley",
"comment_id": 440421583,
"datetime": 1542746374000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 440423443,
"datetime": 1542746759000,
"masked_author": "username_0",
"text": "Are you not using the `get_issue_creation_date.py` script? I would not use the datetimes in the `.bug` files. They are too imprecise. Bugs can be very dependent on the state of the pkgs (and thus on the state of `rosdistro`). Afaik, @wasowski retrieved most of those stamps by looking at the date that github renders on mouse-over.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 440423867,
"datetime": 1542746839000,
"masked_author": "username_0",
"text": "O it could of course be that something is not working correctly. That's why it is a `WIP`.\r\n\r\nIf you'd manually checkout ros/rosdistro@d0158a27 you could see whether it's the correct state and whether `mavros` is listed in the relevant yaml files.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 440428628,
"datetime": 1542747821000,
"masked_author": "username_0",
"text": "Just did this (through Github, just click the link) and I cannot find `mavros` in https://github.com/ros/rosdistro/blob/d0158a278ddee40b3408ec4111bdc777cf62803f/groovy/release.yaml.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 441006355,
"datetime": 1542887409000,
"masked_author": "username_0",
"text": "I think I'm about ready to merge this PR.\r\n\r\nMigrating everything to be included in the Docker image is something I'll do in a separate PR.\r\n\r\nThings work sufficiently well for me right now with this new implementation.\r\n\r\n@username_2, @username_1: would you have any comments?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "git-afsantos",
"comment_id": 441102016,
"datetime": 1542912073000,
"masked_author": "username_1",
"text": ":+1: I have not run into any issues since the one concerning output redirection.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gavanderhoorn",
"comment_id": 441270625,
"datetime": 1542987530000,
"masked_author": "username_0",
"text": "Thanks for the \"review\" @username_1 :)",
"title": null,
"type": "comment"
}
] | 3 | 25 | 12,695 | false | false | 12,695 | true |
alphagov/finder-frontend | alphagov | 406,834,293 | 854 | {
"number": 854,
"repo": "finder-frontend",
"user_login": "alphagov"
} | [
{
"action": "opened",
"author": "bilbof",
"comment_id": null,
"datetime": 1549380269000,
"masked_author": "username_0",
"text": "Email sign up pages have prefixes like `\"News and communications: \"`\r\n\r\nBut the prefixes often have whitespaces at the end. This looks a bit odd, so this computes whether the whitespace is needed at the end.\r\n\r\nSee `subscription_list_title_prefix` on https://www.gov.uk/api/content/cma-cases/email-signup.\r\nSee also https://github.com/alphagov/rummager/pull/1419/files#diff-f74339b4005b4bfdbf8d693f5da78c6bR16",
"title": "Permit non whitespaced email title prefixes",
"type": "issue"
},
{
"action": "created",
"author": "bilbof",
"comment_id": 460688026,
"datetime": 1549381615000,
"masked_author": "username_0",
"text": "I'll put this on integration to double check.",
"title": null,
"type": "comment"
}
] | 1 | 2 | 454 | false | false | 454 | false |
apache/incubator-superset | apache | 439,467,239 | 7,430 | null | [
{
"action": "opened",
"author": "blcksrx",
"comment_id": null,
"datetime": 1556783869000,
"masked_author": "username_0",
"text": "Supporting excel files to import and export",
"title": "Excel Suport",
"type": "issue"
}
] | 3 | 4 | 692 | false | true | 43 | false |
balena-os/meta-balena | balena-os | 385,447,596 | 1,306 | null | [
{
"action": "opened",
"author": "xginn8",
"comment_id": null,
"datetime": 1543437614000,
"masked_author": "username_0",
"text": "`resin-supervisor` fails to update a container when DNS is unavailable, which comes from `dnsmasq`. `resin-supervisor` `Wants=dnsmasq.service`, however I believe it should `Require=dnsmasq.service`. Based on my reading of the `dnsmasq` source, there is no native socket-activated support for `Type=notify` readiness.",
"title": "resin-supervisor should depend on dnsmasq",
"type": "issue"
},
{
"action": "created",
"author": "agherzan",
"comment_id": 442889906,
"datetime": 1543507571000,
"masked_author": "username_1",
"text": "@username_0 Wants and Requires adds the dependency in the same way. The only difference is what happens if the dependency fails or can't be added to the transaction. As well, resin-supervisor doesn't depend on dnsmasq. I'm not sure I understand the actual issue here.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ZubairLK",
"comment_id": 578805998,
"datetime": 1580139381000,
"masked_author": "username_2",
"text": "Adding a `Wants=dnsmasq.service` doesn't sound like a bad idea. It should avoid spurious dns errors on first boot for well connected devices.\r\n\r\nDon't want to make a hard dependency via Requires.",
"title": null,
"type": "comment"
}
] | 3 | 3 | 774 | false | false | 774 | true |
satsukitv/twitter-block-chain | null | 435,368,788 | 29 | null | [
{
"action": "opened",
"author": "rinkydinkyproject",
"comment_id": null,
"datetime": 1555747221000,
"masked_author": "username_0",
"text": "The export list would be incredibly useful for importing blocks. Is it possible to use the export list feature to create a csv file that is friendly to the twitter blocklist format feature?",
"title": "Exporting to Twitter blocklist friendly format",
"type": "issue"
},
{
"action": "created",
"author": "satsukitv",
"comment_id": 557845381,
"datetime": 1574554855000,
"masked_author": "username_1",
"text": "pretty sure twitter is getting rid of that feature actually, so it's unlikely i'll implement it.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "satsukitv",
"comment_id": null,
"datetime": 1574554893000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 285 | false | false | 285 | false |
climate-machine/CLIMA | climate-machine | 485,979,941 | 400 | {
"number": 400,
"repo": "CLIMA",
"user_login": "climate-machine"
} | [
{
"action": "opened",
"author": "simonbyrne",
"comment_id": null,
"datetime": 1566932518000,
"masked_author": "username_0",
"text": "also use .= instead of = for assigning matrices\n\nFixes #392.",
"title": "use inbounds in VariableTemplates",
"type": "issue"
}
] | 3 | 6 | 458 | false | true | 60 | false |
dials/dials | dials | 444,862,802 | 788 | null | [
{
"action": "opened",
"author": "rjgildea",
"comment_id": null,
"datetime": 1558000609000,
"masked_author": "username_0",
"text": "When using the reference_from_experiments the error messages in event of failed comparison are not particularly useful, other than \"something is wrong with the beam comparison\":\r\n```$ dials.combine_experiments indexed* reference_from_experiment.detector=0 reference_from_experiment.beam=0 \r\nSorry: Beam didn't match reference within required tolerance for experiment 1 in indexed_experiments.json\r\n Adjust tolerances or set compare_models=False to ignore differences.\r\n```\r\nIt would be more useful if it could specify which beam attribute(s) was the cause of comparison failure, and how much outside the tolerance the attribute was.",
"title": "dials.combine_experiments reference_from_experiment: more useful error messages",
"type": "issue"
},
{
"action": "created",
"author": "dagewa",
"comment_id": 515079360,
"datetime": 1564066749000,
"masked_author": "username_1",
"text": "This is slightly tricky because the comparisons rely on `is_similar_to` functions, which are C++ and strictly bool\r\nhttps://github.com/dials/dxtbx/blob/20bd1171c2e4d82b99162151854f43d5a211cf6b/datablock.py#L1203-L1212\r\nI suppose one option would be for the dxtbx models to have `diff` functions that follow a similar logic as `is_similar_to` but return a string indicating the difference(s) between the models",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rjgildea",
"comment_id": 515083092,
"datetime": 1564067296000,
"masked_author": "username_0",
"text": "Like this?\r\nhttps://github.com/dials/dxtbx/blob/20bd1171c2e4d82b99162151854f43d5a211cf6b/datablock.py#L1276-L1314",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "dagewa",
"comment_id": null,
"datetime": 1564133319000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 4 | 1,160 | false | false | 1,160 | false |
JabRef/jabref | JabRef | 331,672,841 | 4,123 | {
"number": 4123,
"repo": "jabref",
"user_login": "JabRef"
} | [
{
"action": "opened",
"author": "Siedlerchr",
"comment_id": null,
"datetime": 1528822687000,
"masked_author": "username_0",
"text": "Fixes #4120\r\n\r\n<!-- describe the changes you have made here: what, why, ... \r\n Link issues by using the following pattern: [#333](https://github.com/JabRef/jabref/issues/333) or [koppor#49](https://github.com/koppor/jabref/issues/47).\r\n The title of the PR must not reference an issue, because GitHub does not support autolinking there. -->\r\n\r\n\r\n----\r\n\r\n- [x] Change in CHANGELOG.md described\r\n- [x] Tests created for changes\r\n- [x] Manually tested changed features in running JabRef\r\n- [ ] Screenshots added in PR description (for bigger UI changes)\r\n- [x] Ensured that [the git commit message is a good one](https://github.com/joelparkerhenderson/git_commit_message)\r\n- [ ] Check documentation status (Issue created for outdated help page at [help.jabref.org](https://github.com/JabRef/help.jabref.org/issues)?)",
"title": "Fix convert to bibtex moves contents of the file field",
"type": "issue"
},
{
"action": "created",
"author": "Siedlerchr",
"comment_id": 396682197,
"datetime": 1528826791000,
"masked_author": "username_0",
"text": "Yep that was my thought, too",
"title": null,
"type": "comment"
}
] | 1 | 2 | 849 | false | false | 849 | false |
mozilla/qbrt | mozilla | 210,642,650 | 1 | null | [
{
"action": "opened",
"author": "mykmelez",
"comment_id": null,
"datetime": 1488238924000,
"masked_author": "username_0",
"text": "",
"title": "give the project a fancy name",
"type": "issue"
},
{
"action": "created",
"author": "znk",
"comment_id": 284110120,
"datetime": 1488588364000,
"masked_author": "username_1",
"text": "Hello there, \r\nFound the project by chance and trying it by curiosity, it seems a nice mix of both worlds.\r\nGot it launched and stuck on a small error on runtime openDevTools message... Watching for now :).\r\nHope you find a great name. \"Laniakea\" would be my suggestion, as it is intriguing, space-related and memorable. \r\n\r\nCheers!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mykmelez",
"comment_id": 284111627,
"datetime": 1488589147000,
"masked_author": "username_0",
"text": "Hi @username_1, thanks for trying it out and suggesting a name! If you file an issue about the error you experienced, I'll take a look at it!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Happy-Ferret",
"comment_id": 286964508,
"datetime": 1489643504000,
"masked_author": "username_2",
"text": "Hey.\r\n\r\nHow about Higgs, as in \"Higgs Boson\"?\r\n\r\nCould be stylized as \"Hix\", as well.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "popey456963",
"comment_id": 318870668,
"datetime": 1501377459000,
"masked_author": "username_3",
"text": "I like qbrt, it's an awesome name!",
"title": null,
"type": "comment"
}
] | 4 | 5 | 585 | false | false | 585 | true |
codercom/code-server | codercom | 436,940,338 | 590 | null | [
{
"action": "opened",
"author": "raulvasquez",
"comment_id": null,
"datetime": 1556146362000,
"masked_author": "username_0",
"text": "If possible please add:\r\n\r\nHome Assistant Config Helper: https://marketplace.visualstudio.com/items?itemName=keesschollaart.vscode-home-assistant\r\n\r\nMaterial Design Icon Intellisense: https://marketplace.visualstudio.com/items?itemName=lukas-tr.materialdesignicons-intellisense",
"title": "Req: Home Assistant Config Helper and Material Design Icons Intellisense",
"type": "issue"
},
{
"action": "created",
"author": "nol166",
"comment_id": 486457339,
"datetime": 1556146454000,
"masked_author": "username_1",
"text": "@username_2 Is this something we could add?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "raulvasquez",
"comment_id": 486457924,
"datetime": 1556146630000,
"masked_author": "username_0",
"text": "@username_1 and @username_2 fwiw they are included in the hass.io vscode addon by default, but do not pop up in the codeserver store: https://github.com/hassio-addons/addon-vscode\r\n\r\nLooks like the hass.io version uses code-server as the base.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "foresthoffman",
"comment_id": 486479912,
"datetime": 1556153819000,
"masked_author": "username_2",
"text": "@username_0 @username_1 Interesting. It's on the list of extensions to look into!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "seaverd",
"comment_id": 509180980,
"datetime": 1562583815000,
"masked_author": "username_3",
"text": "@username_2 - Just wondering what the status was of adding these two extensions?\r\n\r\nThanks,\r\nDan",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "SAOPP",
"comment_id": 550056843,
"datetime": 1572993799000,
"masked_author": "username_4",
"text": "Guys, so currently we can't install this extension from code market yet? I can to install it from vsix?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "code-asher",
"comment_id": 550458422,
"datetime": 1573067657000,
"masked_author": "username_5",
"text": "Yeah installing them manually should work. We'll be working on our\nmarketplace soon which should resolve these issues but there's no\ntimeline yet.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "SAOPP",
"comment_id": 550500405,
"datetime": 1573074396000,
"masked_author": "username_4",
"text": "Thank u very much guys! Amazing product, only go ahead!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nhooyr",
"comment_id": 579546816,
"datetime": 1580260052000,
"masked_author": "username_6",
"text": "See #1299",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "nhooyr",
"comment_id": null,
"datetime": 1580260052000,
"masked_author": "username_6",
"text": "",
"title": null,
"type": "issue"
}
] | 7 | 10 | 1,057 | false | false | 1,057 | true |
ManageIQ/manageiq-ui-classic | ManageIQ | 222,750,148 | 1,080 | {
"number": 1080,
"repo": "manageiq-ui-classic",
"user_login": "ManageIQ"
} | [
{
"action": "opened",
"author": "martinpovolny",
"comment_id": null,
"datetime": 1492610781000,
"masked_author": "username_0",
"text": "https://bugzilla.redhat.com/show_bug.cgi?id=1443529\r\n\r\nThe extra line is called from show_timeline and RBAC is already checked at the beginning of the method.",
"title": "Fix AvailabilityZone broken by GenericShow refactoring.",
"type": "issue"
},
{
"action": "created",
"author": "martinpovolny",
"comment_id": 295287865,
"datetime": 1492611830000,
"masked_author": "username_0",
"text": "Hakiri and CC are crazy ;-)\r\n\r\n@mzazrivec : please, review",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "simaishi",
"comment_id": 295437733,
"datetime": 1492635269000,
"masked_author": "username_1",
"text": "Fine backport details:\r\n\r\n```\r\n$ git log -1\r\ncommit c8ec19c48c904c99d52b7e79a94509f34273baf4\r\nAuthor: Milan Zázrivec <mzazrivec@redhat.com>\r\nDate: Wed Apr 19 16:31:06 2017 +0200\r\n\r\n Merge pull request #1080 from username_0/availability_zone_timeline_fix\r\n \r\n Fix AvailabilityZone broken by GenericShow refactoring.\r\n (cherry picked from commit 3fcf319434a0d15cae70e15d94ce764860f7ded4)\r\n```",
"title": null,
"type": "comment"
}
] | 3 | 4 | 867 | false | true | 623 | true |
standard-release/cli | standard-release | 403,570,019 | 2 | null | [
{
"action": "opened",
"author": "tunnckoCore",
"comment_id": null,
"datetime": 1548607280000,
"masked_author": "username_0",
"text": "Because, `npm` is just one of them.\r\n\r\nWrap this as \"npm plugin\"\r\n\r\nhttps://github.com/standard-release/cli/blob/b630bf3cbcc38c082d59ebc47550c165b6c845a7/src/cli.js#L47-L68\r\n\r\nTo the plugin function pass `argv`, `process.env` and the `result` object.",
"title": "Allow plugins",
"type": "issue"
}
] | 1 | 1 | 250 | false | false | 250 | false |
google/crc32c | google | 373,233,435 | 23 | {
"number": 23,
"repo": "crc32c",
"user_login": "google"
} | [
{
"action": "opened",
"author": "coryan",
"comment_id": null,
"datetime": 1540334718000,
"masked_author": "username_0",
"text": "When compiling shared libraries the object libraries also need to compile with `-fPIC`.",
"title": "Support shared libraries.",
"type": "issue"
},
{
"action": "created",
"author": "coryan",
"comment_id": 433099898,
"datetime": 1540481807000,
"masked_author": "username_0",
"text": "Ping. Is there any feedback on this PR?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pwnall",
"comment_id": 438792054,
"datetime": 1542224476000,
"masked_author": "username_1",
"text": "@username_0 Do you happen to have a pointer to the docs that explain why this needs to be done? I expected that CMake would set all the necessary flags to reasonable values when enabling shared libraries. Am I using the wrong master switch?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "coryan",
"comment_id": 438794107,
"datetime": 1542224862000,
"masked_author": "username_0",
"text": "The [CMake documentation](https://cmake.org/cmake/help/latest/prop_tgt/POSITION_INDEPENDENT_CODE.html) says the property is set to `False` for `OBJECT` libraries. And this property controls whether `-fPIC` is set or not.\r\n\r\nThis is a good discussion on the general problem:\r\n\r\nhttps://stackoverflow.com/questions/50600708/combining-cmake-object-libraries-with-shared-libraries\r\n\r\nYou may want to turn on shared libraries for at least one build, I would be happy to do that in a future PR too.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "pwnall",
"comment_id": 438798456,
"datetime": 1542225666000,
"masked_author": "username_1",
"text": "Thanks for looking into it!\r\n\r\nFor this PR -- can you please add comments above the set_property blocks explaining why they need to be there?\r\n`# CMake only enables PIC by default in SHARED and MODULE targets.` should suffice.\r\n\r\nFor CI changes -- based on experience maintaining LevelDB and Snappy, I am really not looking forward to supporting a shared library build for this project. I'd like this project's guarantees to be similar to https://abseil.io/about/compatibility which I think reflects a lot of collective wisdom. Adding shared libraries to CI would imply support. Can you please follow up internally and explain the need, so I can know why I'd be taking on this burden?",
"title": null,
"type": "comment"
}
] | 2 | 5 | 1,539 | false | false | 1,539 | true |
dotnet-architecture/eShopOnContainers | dotnet-architecture | 476,002,438 | 1,113 | null | [
{
"action": "opened",
"author": "rahulrai-in",
"comment_id": null,
"datetime": 1564723622000,
"masked_author": "username_0",
"text": "The guidance does not say anything about operations that require reading historical data and then making decisions in aggregates. For example, handling a hypothetical case where a customer can't place more than N orders of a certain product across all the orders that they have placed.",
"title": "How to handle operations that require loading historical data",
"type": "issue"
},
{
"action": "created",
"author": "mvelosop",
"comment_id": 518787377,
"datetime": 1565115847000,
"masked_author": "username_1",
"text": "Hi @username_0,\r\n\r\nThat should be handled in the validation behavior in the MediatR pipeline, although currently the handling of the validation result has to be improved A LOT 😔.\r\n\r\nYou might want to take a look at some experiment I did sometime ago regarding this topic here: https://github.com/username_1/Microflow-X/blob/master/src/Tenants/App/Behaviors/ValidatorBehavior.cs\r\n\r\nHope this helps.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "rahulrai-in",
"comment_id": 518912428,
"datetime": 1565144357000,
"masked_author": "username_0",
"text": "Apologies if the details that I provided was not sufficient. I do have validators in my pipeline and I only perform basic type validations in the validators e.g. verify that a field has value or that length is less than n characters etc.\r\n\r\nCurrently, I execute validations that require querying historical data e.g. existing orders in my command handlers and hence I segregate validation issues with data that violates business constraints. However, I am not sure whether this is the ideal approach as business validations are the responsibility of aggregates and entities and I am pushing those responsibilities to command handlers.\r\n\r\nFrom what I can understand from the eshop sample, aggregates and entities can only apply business logic on the active record e.g. a single order record. However, this sample lacks guidance on what if an order record needs to execute some business logic based on whether there is another order for the customer in the database.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mvelosop",
"comment_id": 519132547,
"datetime": 1565189539000,
"masked_author": "username_1",
"text": "Hi @username_0, there are some nice insights there!\r\n\r\nYou can actually add anything to validators, say by injecting the required repositories like here: https://github.com/username_1/Microflow-X/blob/master/src/Tenants/App/Validators/AddTenantCommandValidator.cs\r\n\r\nWhat I'm currently doing (not actually in the above repo) is to have validators in the domain project even though executing the validations is performed in the application project. As you mention, I also think the validation details belong to the domain, and the application project just coordinates all pieces, without having to know that detail level.\r\n\r\nAbout the last paragraph, what I'd currently do, is tackling that in the corresponding command handler and perhaps call a different entity.method or adding another parameter to the method call.\r\n\r\nI've even thought that command handlers should be in the domain project and raise domain events to trigger any domain related actions but haven't actually implemented any app this way, so I have yet to check the results to see how it feels.\r\n\r\nHope this helps.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "mvelosop",
"comment_id": 520406956,
"datetime": 1565613368000,
"masked_author": "username_1",
"text": "Closing this issue now, but feel free to comment, will reopen if needed.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "mvelosop",
"comment_id": null,
"datetime": 1565613368000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 6 | 2,797 | false | false | 2,797 | true |
faker-ruby/faker | faker-ruby | 502,112,332 | 1,782 | {
"number": 1782,
"repo": "faker",
"user_login": "faker-ruby"
} | [
{
"action": "opened",
"author": "wladimirgramacho",
"comment_id": null,
"datetime": 1570113962000,
"masked_author": "username_0",
"text": "Issue #1765\r\n------\r\n\r\nExample:\r\n\r\nhttps://github.com/faker-ruby/faker/issues/1765\r\n\r\nDescription:\r\n------\r\nFixes the call `Faker::Address.city(options: { with_state: true })` so that it doesn't raise an exception and returns the desired result, e.g. `\"Northtown, Colorado\"`\r\n\r\nCode is tested.",
"title": "fix: city_with_state was not on en locale",
"type": "issue"
},
{
"action": "created",
"author": "koic",
"comment_id": 629149020,
"datetime": 1589537002000,
"masked_author": "username_1",
"text": "Thanks!",
"title": null,
"type": "comment"
}
] | 2 | 2 | 300 | false | false | 300 | false |
easylogic/colorpicker | null | 491,561,301 | 4 | null | [
{
"action": "opened",
"author": "lqez",
"comment_id": null,
"datetime": 1568108259000,
"masked_author": "username_0",
"text": "**Describe the bug**\r\n`[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event. Consider marking event handler as 'passive' to make the page more responsive.` was printed a lot from `colorpicker.js`.\r\n\r\n**To Reproduce**\r\nTurn on `verbose` on the browser console and see warnings.\r\n\r\n**Screenshots**\r\n<img width=\"1440\" alt=\"Screen Shot 2019-09-10 at 6 36 30 PM\" src=\"https://user-images.githubusercontent.com/579366/64602537-f0b19c80-d3f9-11e9-9a6a-13fc57487439.png\">\r\n\r\n**Desktop (please complete the following information):**\r\n - OS: macOS\r\n - Browser: Chrome \r\n - Version: 76.0.3809.132 (Official Build) (64-bit)\r\n\r\n**Additional context**\r\nXRef: https://www.chromestatus.com/feature/5745543795965952\r\nXRef: https://developers.google.com/web/tools/lighthouse/audits/passive-event-listeners?hl=ko",
"title": "[Violation] Added non-passive event listener to a scroll-blocking 'touchstart' event.",
"type": "issue"
},
{
"action": "created",
"author": "easylogic",
"comment_id": 533875772,
"datetime": 1569153713000,
"masked_author": "username_1",
"text": "i fixed at v1.9.64",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "easylogic",
"comment_id": null,
"datetime": 1569153713000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 843 | false | false | 843 | false |
divinerapier/onyxiafs | null | 478,752,934 | 36 | {
"number": 36,
"repo": "onyxiafs",
"user_login": "divinerapier"
} | [
{
"action": "opened",
"author": "divinerapier",
"comment_id": null,
"datetime": 1565313752000,
"masked_author": "username_0",
"text": "",
"title": "feature(volume): rotate volumes data",
"type": "issue"
}
] | 2 | 4 | 1,042 | false | true | 0 | false |
ziglang/zig | ziglang | 453,306,153 | 2,634 | null | [
{
"action": "opened",
"author": "HalosGhost",
"comment_id": null,
"datetime": 1559872073000,
"masked_author": "username_0",
"text": "## Prior Art\r\n\r\n* #383 \r\n* #2078 \r\n* #2255 \r\n* https://en.wikipedia.org/wiki/AOS_and_SOA\r\n\r\nThis issue is meant to serve as an issue to address the specific question of how Zig can, should, and (eventually) will provide support for smoothly transitioning between SoA and AoS.\r\n\r\nThe AoS strategy (an array of structures) is often more natural, and allows simpler code. However, the SoA strategy (where there is only a single structure, embedding arrays) is often more performance friendly for cache layout and SIMD optimization. Unfortunately, in most languages (as in Zig for the moment), switching between these strategies requires large refactoring.\r\n\r\nThe experimental (and still only privately-available) programming language named [jai](https://inductive.no/jai/) provides for novel tooling to dramatically simplify this transition. Jai offers a special tag that can be placed on structure definitions (``SOA``). When a struct is tagged with ``SOA``, the code is still written as it would be for the AoS strategy, but the memory layout will transparently be SoA. This allows for several pros:\r\n\r\n* developers can write code in the most intuitive fashion regardless of which memory layout is more performant for the situation\r\n* this language support offers the refactor as a single-line change rather than refactoring all the related code\r\n\r\nThe obvious con is that this bit of tooling is very specific (rather than being something more generalized for memory layout). Additionally, it is an extra bit of special syntax rather than something implemented in the language itself.\r\n\r\n@tgschultz put together a [short prototype](https://gist.github.com/tgschultz/e7ad60a9d30e6541915cb006b1735adb) of implementing this behavior within Zig which relies on this [helper struct](http://zig.tgschultz.com/pseudo_struct.zig).\r\n\r\nThis issue can be considered an open question and request for proposal for solution.",
"title": "Explicit support for AoS/SoA",
"type": "issue"
},
{
"action": "created",
"author": "dadhi",
"comment_id": 536608402,
"datetime": 1569856379000,
"masked_author": "username_1",
"text": "From one of the latest video on Jai, the author said something like an idea of a better option for the problem than SoA / AoS. Though he did not return to this afterward.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "EleanorNB",
"comment_id": 735720487,
"datetime": 1606734657000,
"masked_author": "username_2",
"text": "Potentially relevant: #7257",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "andrewrk",
"comment_id": 770354913,
"datetime": 1612086312000,
"masked_author": "username_3",
"text": "#7920 and #7854 demonstrate two perfectly reasonable ways to implement this in the std lib. There is no language feature needed here.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "andrewrk",
"comment_id": null,
"datetime": 1612086318000,
"masked_author": "username_3",
"text": "",
"title": null,
"type": "issue"
}
] | 4 | 5 | 2,239 | false | false | 2,239 | false |
nodejs/mentorship | nodejs | 354,719,835 | 90 | null | [
{
"action": "opened",
"author": "detrohutt",
"comment_id": null,
"datetime": 1535461136000,
"masked_author": "username_0",
"text": "[Mentorship Diary] Gus & Kostas\r\n(Mentorship Round 1) Gus will be mentoring Kostas on Node.js VM.",
"title": "[Mentorship Diary] Gus & Kostas",
"type": "issue"
},
{
"action": "created",
"author": "Bamieh",
"comment_id": 508426669,
"datetime": 1562235101000,
"masked_author": "username_1",
"text": "Mentorship was discontinued here as Gus dropped out.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Bamieh",
"comment_id": null,
"datetime": 1562235101000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 149 | false | false | 149 | false |
grpc/grpc | grpc | 466,681,326 | 19,608 | null | [
{
"action": "opened",
"author": "nareshv",
"comment_id": null,
"datetime": 1562825278000,
"masked_author": "username_0",
"text": "<!--\r\n\r\nThis form is for bug reports and feature requests ONLY!\r\nFor general questions and troubleshooting, please ask/look for answers here:\r\n- grpc.io mailing list: https://groups.google.com/forum/#!forum/grpc-io\r\n- StackOverflow, with \"grpc\" tag: https://stackoverflow.com/questions/tagged/grpc\r\n\r\nIssues specific to *grpc-java*, *grpc-go*, *grpc-node*, *grpc-dart*, *grpc-web* should be created in the repository they belong to (e.g. https://github.com/grpc/grpc-LANGUAGE/issues/new)\r\n-->\r\n \r\n### What version of gRPC and what language are you using?\r\n 1.22.0\r\n \r\n### What operating system (Linux, Windows,...) and version?\r\n Linux\r\n \r\n### What runtime / compiler are you using (e.g. python version or version of gcc)\r\n 3.x, rhel7\r\n \r\n### What did you do?\r\nFind if there is grpc-tools-1.22.0.tar.gz in Pypi\r\n \r\n### What did you expect to see?\r\n Expected to see source package for 1.22.0 in https://pypi.org/simple/grpcio-tools/\r\n \r\n### What did you see instead?\r\n All binary packages for 1.22.0\r\n \r\n### Anything else we should know about your project / environment?\r\nNone",
"title": "pypi sdist package for grpc-tools-1.22.0",
"type": "issue"
},
{
"action": "created",
"author": "gnossen",
"comment_id": 510977056,
"datetime": 1562954188000,
"masked_author": "username_1",
"text": "Thanks for the heads up. The problem should be resolved now. We'll be improving the release process to ensure this doesn't happen again.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "gnossen",
"comment_id": null,
"datetime": 1562954188000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 1,211 | false | false | 1,211 | false |
erlio/vernemq | erlio | 323,306,066 | 701 | {
"number": 701,
"repo": "vernemq",
"user_login": "erlio"
} | [
{
"action": "opened",
"author": "codeadict",
"comment_id": null,
"datetime": 1526404086000,
"masked_author": "username_0",
"text": "This is just to open a discussion about contribution checklist and standards, we can polish this together.",
"title": "Add PR template",
"type": "issue"
},
{
"action": "created",
"author": "codeadict",
"comment_id": 389562286,
"datetime": 1526484664000,
"masked_author": "username_0",
"text": "@larshesel @username_1 @username_2 ^^",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "dergraf",
"comment_id": 389648845,
"datetime": 1526501252000,
"masked_author": "username_1",
"text": "good initiative. :) I'd change a few points, but haven't had time to write down my thoughts.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "codeadict",
"comment_id": 392611023,
"datetime": 1527545879000,
"masked_author": "username_0",
"text": "Great!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ioolkos",
"comment_id": 669522290,
"datetime": 1596663016000,
"masked_author": "username_2",
"text": "Another forgotten PR. I'm going to merge this as this was @username_0's initiative, we can always adapt. (I also created a general .github repo today, for any useful templates)",
"title": null,
"type": "comment"
}
] | 3 | 5 | 410 | false | false | 410 | true |
ReactiveX/RxJava | ReactiveX | 302,338,523 | 5,891 | {
"number": 5891,
"repo": "RxJava",
"user_login": "ReactiveX"
} | [
{
"action": "opened",
"author": "akarnokd",
"comment_id": null,
"datetime": 1520262981000,
"masked_author": "username_0",
"text": "Improve the coverage of various components, fix impossible paths and other fixes. See the comments attached to the code changes.",
"title": "2.x: Improve coverage & related cleanup 03/05",
"type": "issue"
},
{
"action": "created",
"author": "akarnokd",
"comment_id": 370460138,
"datetime": 1520264457000,
"masked_author": "username_0",
"text": "Updated with some additional cleanup and fix to `ObservableSkip` lacking a validation.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 214 | false | true | 214 | false |
breuerfelix/jinsta | null | 517,409,360 | 62 | null | [
{
"action": "opened",
"author": "DrRek",
"comment_id": null,
"datetime": 1572902363000,
"masked_author": "username_0",
"text": "For some reason session.json is broken each time the application exits after handling an exception.",
"title": "session.json should not break if a radom exception occurs",
"type": "issue"
},
{
"action": "created",
"author": "breuerfelix",
"comment_id": 550044911,
"datetime": 1572991741000,
"masked_author": "username_1",
"text": "should be fixed now :)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "breuerfelix",
"comment_id": null,
"datetime": 1572991741000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 121 | false | false | 121 | false |
convergenceIM/alpha-scientist | null | 339,150,285 | 21 | null | [
{
"action": "opened",
"author": "yn-coder",
"comment_id": null,
"datetime": 1530974043000,
"masked_author": "username_0",
"text": "Need to add an \"About\" tab next to the Blog tab on the menu bar. I may also want to add another non-blog page (\"Consulting\").",
"title": "\"About\" tab next. Add another non-blog page (\"Consulting\")",
"type": "issue"
},
{
"action": "created",
"author": "yn-coder",
"comment_id": 403223824,
"datetime": 1530977826000,
"masked_author": "username_0",
"text": "`DISPLAY_PAGES_ON_MENU` should work, but they don't\r\n\r\nChecking",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "convergenceIM",
"comment_id": 403366356,
"datetime": 1531115181000,
"masked_author": "username_1",
"text": "This is great. What's your recommendation for how to create/edit the HTML for these pages? Just a one cell ipynb named about.ipynb etc... Use an HTML editor of some sort?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yn-coder",
"comment_id": 403374328,
"datetime": 1531118133000,
"masked_author": "username_0",
"text": "pages could by `.ipynb` or '.md'. Right now it's `.md` files here https://github.com/username_1/alpha-scientist/tree/master/content/pages\r\n\r\nMD it's just a plain text, Formatting is just **equal as _github_ comments**.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "convergenceIM",
"comment_id": null,
"datetime": 1531336839000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "convergenceIM",
"comment_id": 404281714,
"datetime": 1531336839000,
"masked_author": "username_1",
"text": "Works. Closing",
"title": null,
"type": "comment"
}
] | 2 | 6 | 597 | false | false | 597 | true |
department-of-veterans-affairs/caseflow | department-of-veterans-affairs | 363,389,748 | 7,119 | {
"number": 7119,
"repo": "caseflow",
"user_login": "department-of-veterans-affairs"
} | [
{
"action": "opened",
"author": "kencheeto",
"comment_id": null,
"datetime": 1537843602000,
"masked_author": "username_0",
"text": "Connects #6947 \r\n\r\n### Description\r\n* Adds a max address line length validation of 20 characters to the Veteran model\r\n* Adds support for displaying multiple kinds of validation errors on Veterans during Intake search (not just missing fields)\r\n* Adds error messaging for address line lengths that are too long\r\n* Removes handling of long address errors on intake completion\r\n\r\nthree potential visual things to tweak, to my eyes:\r\n* Our `cf-bare-list` style sets `list-style-type: none;` but I wonder if the tips would look better with visible bullets\r\n* the spacing between bullets in the tips feels a bit too large\r\n* should the missing fields vs long address messages be more distinct?\r\n\r\n### Screenshots of possible Veteran validation errors\r\n\r\nError when address line length is over 20 chars:\r\n<img width=\"881\" alt=\"screen shot 2018-09-24 at 7 02 35 pm\" src=\"https://user-images.githubusercontent.com/279406/45989569-1f8c0280-c031-11e8-969d-a9f07c6287e7.png\">\r\nExisting error when fields are missing:\r\n<img width=\"863\" alt=\"screen shot 2018-09-24 at 7 04 58 pm\" src=\"https://user-images.githubusercontent.com/279406/45989570-1f8c0280-c031-11e8-89ce-0bf8c3649304.png\">\r\nWhen both errors are present:\r\n<img width=\"877\" alt=\"screen shot 2018-09-24 at 7 33 41 pm\" src=\"https://user-images.githubusercontent.com/279406/45989571-1f8c0280-c031-11e8-9f05-42cfd5140dd4.png\">\r\n\r\n### Acceptance Criteria\r\n- [x] Code compiles correctly\r\n- [x] Feature, unit tests\r\n\r\n### Testing Plan\r\n1. Edit bgs_service.rb#L31 to add a long address and/or missing field\r\n ```diff\r\n -# veteran = Generators::Veteran.build(file_number: row_hash[\"vbms_id\"].chop)\r\n +veteran = Generators::Veteran.build(file_number: row_hash[\"vbms_id\"].chop, address_line1: \"super super long address blab blab blab\", city: nil, state: nil)\r\n ```\r\n1. Attempt to start an intake with any veteran\r\n1. Validate that the error(s) show up correctly",
"title": "Validate veteran address line length on intake search",
"type": "issue"
},
{
"action": "created",
"author": "suzchap",
"comment_id": 424455005,
"datetime": 1537900717000,
"masked_author": "username_1",
"text": "It's not super pretty but I think it's fine for now.",
"title": null,
"type": "comment"
}
] | 2 | 2 | 1,962 | false | false | 1,962 | false |
viacoin/vialectrum | viacoin | 369,398,907 | 19 | null | [
{
"action": "opened",
"author": "Aaahh",
"comment_id": null,
"datetime": 1539320062000,
"masked_author": "username_0",
"text": "https://github.com/viacoin/vialectrum/blob/b84aaf771b18a55a02b7a8b30c8cf40c6791625f/vialectrum/rsakey.py#L128\r\n\r\nalso worth nothing that it was crushed into a git commit it did not originate from.",
"title": "Unreachable line",
"type": "issue"
},
{
"action": "created",
"author": "romanornr",
"comment_id": 429215540,
"datetime": 1539324764000,
"masked_author": "username_1",
"text": "Please use the stable branch. Not the master branch (in development)",
"title": null,
"type": "comment"
}
] | 2 | 2 | 264 | false | false | 264 | false |
LibreVR/Revive | LibreVR | 520,951,539 | 1,387 | null | [
{
"action": "opened",
"author": "Starkraiven",
"comment_id": null,
"datetime": 1573477511000,
"masked_author": "username_0",
"text": "Playing Echo VR when making a throw either of an item or off of an object 4 movement the grip does not release on button depress often enough to make it a problem.",
"title": "Echo VR Grip release inconsistent",
"type": "issue"
},
{
"action": "created",
"author": "Armada651",
"comment_id": 552480019,
"datetime": 1573484517000,
"masked_author": "username_1",
"text": "Issue report did not follow format, closing due to lack of info.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "Armada651",
"comment_id": null,
"datetime": 1573484518000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 3 | 227 | false | false | 227 | false |
pravega/pravega | pravega | 451,828,453 | 3,872 | null | [
{
"action": "opened",
"author": "ravisharda",
"comment_id": null,
"datetime": 1559631515000,
"masked_author": "username_0",
"text": "**Problem description**\r\n\r\nSome of the operations of the Controller gRPC interface require a higher permission level READ_UPDATE (read/write), even though they appear to be read operations that don't modify the state of the resource. \r\n\r\nIssue #3277 sought reducing permission for such \"read\" operations from `READ_UPDATE` to `READ`, among other things. PR [3492](https://github.com/pravega/pravega/pull/3492) reduced the permission levels for most of the read operations but left others out as described in that PR's description. This issue seeks to explore and fix permissions required for the remaining read operations, as well as any new read operations that might have been added since then. \r\n\r\n**Problem location**\r\n`io.pravega.controller.server.rpc.grpc.v1.ControllerServiceImpl.java`. \r\n\r\n**Suggestions for an improvement**",
"title": "Reducing permission required for Controller gRPC read operations ",
"type": "issue"
},
{
"action": "created",
"author": "sarlaccpit",
"comment_id": 646824359,
"datetime": 1592594184000,
"masked_author": "username_1",
"text": "A couple examples of overly restrictive READ_UPDATE requirements may be:\r\n\r\nhttps://github.com/pravega/pravega/blob/master/controller/src/main/java/io/pravega/controller/server/rpc/grpc/v1/ControllerServiceImpl.java#L184-L188\r\n\r\nhttps://github.com/pravega/pravega/blob/master/controller/src/main/java/io/pravega/controller/server/rpc/grpc/v1/ControllerServiceImpl.java#L218-L224\r\n\r\nI'm surveying these as part of an effort to really tailor down what it means to really have just read(only) access to a scope. The conversation can extend also reader groups, water marking, stream cuts...",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "andreipaduroiu",
"comment_id": null,
"datetime": 1635785644000,
"masked_author": "username_2",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 3 | 1,421 | false | false | 1,421 | false |
michalmuskala/jason | null | 346,992,109 | 52 | {
"number": 52,
"repo": "jason",
"user_login": "michalmuskala"
} | [
{
"action": "opened",
"author": "Apelsinka223",
"comment_id": null,
"datetime": 1533213294000,
"masked_author": "username_0",
"text": "Hi, thanks for package! I suggest to optionally support tuples.\r\n\r\nIn this request I added option `tuples: :list | :raise (default)` to `Jason.encode/2`, and on `:list` value - tuples would be encoded as lists with meta element \"__tuple__\" as the list head. \r\nAlso I added `tuples: :tuple | :none (default)` option to `Jason.decode/2`, with `:tuple` value it would decode lists with \"__tuple__\" element in the head as tuples.\r\n\r\nAs default, `Jason.encode/2` and `Jason.decode/2` would work same as now.",
"title": "Tuples support",
"type": "issue"
},
{
"action": "created",
"author": "Apelsinka223",
"comment_id": 410346174,
"datetime": 1533322702000,
"masked_author": "username_0",
"text": "Dialyzer fails with `lib/encode.ex:238: Function tuple_raise/4 has no local return`, and I really have no idea how to fix it, already tried many ways.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "michalmuskala",
"comment_id": 410449932,
"datetime": 1533389717000,
"masked_author": "username_1",
"text": "Hi @username_0,\r\n\r\nI appreciate this work. The implementation of the feature and the tests are very thorough, I couldn't have written it better myself. Unfortunately, I'm not sure this feature belongs in the library. Let me explain:\r\n\r\nThe goal of Jason is to be a semantic encoder/decoder of JSON and not a general encoder/decoder of arbitrary Elixir terms. JSON itself doesn't have tuples - to deal with this deficiency, the PR introduces a \"magic\" `\"__tuple__\"` tag, but such conversion introduces application-specific logic and is not general. It couldn't be decoded into proper data by an arbitrary decoder.\r\n\r\nPerhaps a format that builds on top of JSON, such as [Transit](https://github.com/cognitect/transit-format), would be a better fit for such a feature? It has an explicit extension points for custom formates, but includes built-in definitions for arrays (which would correspond to tuples), lists or maps with composite terms.",
"title": null,
"type": "comment"
}
] | 2 | 3 | 1,596 | false | false | 1,596 | true |
Microsoft/Office365DSC | Microsoft | 434,848,242 | 91 | {
"number": 91,
"repo": "Office365DSC",
"user_login": "Microsoft"
} | [
{
"action": "opened",
"author": "NikCharlebois",
"comment_id": null,
"datetime": 1555603828000,
"masked_author": "username_0",
"text": "#### Pull Request (PR) description\r\nThis PR contains changes to a few resources, as well as a major Refactoring of the ReverseDSC components to ensure the .ps1 doesn't contains any information that is tenant specific. Instead all this info is entirely stored within the resulting ConfigurationData.psd1 file making it very easy for users to extract from one tenant and replicate over another one (keeping tenants in sync).\r\n\r\n#### This Pull Request (PR) fixes the following issues\r\nN/A",
"title": "ReverseDSC Fixes to Ensure Full Tenant Isolation",
"type": "issue"
}
] | 2 | 2 | 485 | false | true | 485 | false |
uoft-tapp/tapp | uoft-tapp | 250,145,528 | 175 | null | [
{
"action": "opened",
"author": "reidka",
"comment_id": null,
"datetime": 1502742757000,
"masked_author": "username_0",
"text": "The HLP courses appear in the JSON file exported from CHASS, but do not appear in the app after import.\r\n\r\nFor example, the following appears in the JSON, but I don't see the course anywhere in the app.\r\n\r\n```\r\n {\r\n \"course_id\": \"HLP101H1\",\r\n \"course_name\": \"Help Centre TA\",\r\n \"round_id\": \"110\",\r\n \"enrollment\": \"N/A\",\r\n \"n_positions\": \"6\",\r\n```",
"title": "HLP courses are not in the app",
"type": "issue"
},
{
"action": "created",
"author": "gabriellesc",
"comment_id": 322565723,
"datetime": 1502825617000,
"masked_author": "username_1",
"text": "Would it be possible for @username_2 to change the dates input fields in CHASS to `date` inputs, or something equivalent such that the dates are always in a consistent format?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reidka",
"comment_id": 323377438,
"datetime": 1503068428000,
"masked_author": "username_0",
"text": "Maybe. We can ask.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alynch",
"comment_id": 323393524,
"datetime": 1503072103000,
"masked_author": "username_2",
"text": "The JSON file has date/time fields of the form:\r\n\"last_updated\": \"2017-07-31 23:57:09\"\r\n\r\nwhich is valid ISO_8601 format [1]. What format would you prefer? \r\n\r\n\r\n[1] (a) The separator between date and time is normally 'T', but it's allowed to omit it by agreement between the parties. (b) We are not using a time zone designator.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "reidka",
"comment_id": 323395169,
"datetime": 1503072517000,
"masked_author": "username_0",
"text": "Hi @username_2, the field in question sis the \"dates\" field in the courses. It is a text box in the application, and I filled it in (at least) two different ways.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "alynch",
"comment_id": 323408492,
"datetime": 1503075960000,
"masked_author": "username_2",
"text": "Oh, sorry, my misunderstanding. Unfortunately the 'dates' field is a text field that departments use to indicate the duration of the appointment, and sometimes they use the field to add extra details. It would be quite a bit of work to convert it to two date fields (and a extra text field for extra info).",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "gabriellesc",
"comment_id": 323446959,
"datetime": 1503086186000,
"masked_author": "username_1",
"text": "@username_2 would it be possible to add helptext and/or formatting validation to the field to suggest and/or enforce that the data is entered in a fixed format - while still allowing additional text? For example:\r\n```\r\n<input type=\"text\" placeholder=\"dd/mm/yy - dd/mm/yy\" pattern=\"[0-9]{2}/[0-9]{2}/[0-9]{2} - [0-9]{2}/[0-9]{2}/[0-9]{2}.*\" />\r\n```\r\nwhich would enforce the date format \"dd/mm/yy - dd/mm/yy\" but allow as much subsequent additional text as desired?",
"title": null,
"type": "comment"
}
] | 3 | 7 | 1,852 | false | false | 1,852 | true |
tatfook/keepwork | tatfook | 463,683,901 | 4,897 | null | [
{
"action": "opened",
"author": "Kvaya",
"comment_id": null,
"datetime": 1562151227000,
"masked_author": "username_0",
"text": "背景：\r\nparacraft.org网站首页和About页是同一个显示页\r\n\r\n解决方案\r\n网站思路：https://keepwork.com/leonliu/asde/paracraft_org?tdsourcetag=s_pcqq_aiomsg\r\n\r\n设计稿地址：\r\n\r\n\r\n网站标题：显示形式“logo+文字”\r\n首页和About页的标题是：logo+Paracraft, the software for youth programming",
"title": "【paracraft.org】paracraft.org网站首页和About页开发 ",
"type": "issue"
},
{
"action": "closed",
"author": "ouyc",
"comment_id": null,
"datetime": 1563162271000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 334 | false | false | 334 | false |
googleapis/google-cloud-python | googleapis | 392,267,209 | 6,995 | {
"number": 6995,
"repo": "google-cloud-python",
"user_login": "googleapis"
} | [
{
"action": "opened",
"author": "crwilcox",
"comment_id": null,
"datetime": 1545155375000,
"masked_author": "username_0",
"text": "This pull request was generated using releasetool.",
"title": "Release speech 0.36.1",
"type": "issue"
}
] | 3 | 6 | 1,328 | false | true | 50 | false |
spacemeshos/go-spacemesh | spacemeshos | 522,128,987 | 1,490 | null | [
{
"action": "opened",
"author": "y0sher",
"comment_id": null,
"datetime": 1573642848000,
"masked_author": "username_0",
"text": "# Overview / Motivation\r\n\r\nWe have seen a case (quite a rare one), where a node started in a time where it fails to recognize the first tick and, starts counting in an off-by-one offset. ex: other miners send around layer 1 blocks and the affected miner get layer 1 tick on layer 2.\r\n\r\n# The Task\r\n\r\nCheck the timer code to make sure we don't miss ticks and calculate right whenever we start.\r\n\r\n# Implementation Notes\r\n`timesync`\r\n\r\n# Contribution Guidelines\r\nImportant: Issue assignment to developers will be by the order of their application and proficiency level according to the tasks complexity. We will not assign tasks to developers who haven't introduced themselves on our Gitter [dev channel](https://gitter.im/spacemesh-os/Lobby)\r\n\r\n1. Introduce yourself on go-spacemesh [dev chat channel](https://gitter.im/spacemesh-os/Lobby) - ask our team any question you may have about this task\r\n2. Fork branch `develop` to your own repo and work in your repo\r\n3. You must document all methods, enums and types with [godoc comments](https://blog.golang.org/godoc-documenting-go-code)\r\n4. You must write go unit tests for all types and methods when submitting a component, and integration tests if you submit a feature\r\n5. When ready for code review, submit a PR from your repo back to branch `develop`\r\n6. Attach relevant issue to PR",
"title": "Miner misses first tick when starting and continues with 1 offset",
"type": "issue"
},
{
"action": "closed",
"author": "antonlerner",
"comment_id": null,
"datetime": 1623856103000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 1,334 | false | false | 1,334 | false |
DavidBruant/auto-translate | null | 362,224,726 | 1 | null | [
{
"action": "opened",
"author": "DavidBruant",
"comment_id": null,
"datetime": 1537454998000,
"masked_author": "username_0",
"text": "http://opennmt.net/OpenNMT/installation/\r\n\r\n- [ ] Install Torch\r\n- [ ] Install additional dependencies:\r\n\r\n```sh\r\nluarocks install tds\r\nluarocks install bit32 # if using LuaJIT\r\n```\r\n\r\n- [ ] Clone the OpenNMT repository:\r\n\r\n```sh\r\ngit clone https://github.com/OpenNMT/OpenNMT\r\ncd OpenNMT\r\n```",
"title": "Install OpenNMT",
"type": "issue"
},
{
"action": "created",
"author": "DavidBruant",
"comment_id": 423216379,
"datetime": 1537455637000,
"masked_author": "username_0",
"text": "Torch : \r\nhttp://torch.ch/docs/getting-started.html\r\n\r\n```sh\r\ngit clone https://github.com/torch/distro.git ~/torch --recursive\r\ncd ~/torch; bash install-deps;\r\n./install.sh\r\n```\r\n\r\n```sh\r\nsource ~/.bashrc\r\n```\r\n\r\n```\r\n$ th\r\n \r\n ______ __ | Torch7 \r\n /_ __/__ ________/ / | Scientific computing for Lua. \r\n / / / _ \\/ __/ __/ _ \\ | \r\n /_/ \\___/_/ \\__/_//_/ | https://github.com/torch \r\n | http://torch.ch \r\n\t\t\t \r\nth> torch.Tensor{1,2,3}\r\n 1\r\n 2\r\n 3\r\n[torch.DoubleTensor of dimension 3]\r\n\r\nth>\r\n\r\nTo exit the interactive session, type ^c twice — the control key together with the c key, twice, or type os.exit(). Once the user has entered a complete expression, such as 1 + 2, and hits enter, the interactive session evaluates the expression and shows its value.\r\n\r\nTo evaluate expressions written in a source file file.lua, write dofile \"file.lua\".\r\n\r\nTo run code in a file non-interactively, you can give it as the first argument to the th command::\r\n\r\n$ th file.lua\r\n\r\nThere are various ways to run Lua code and provide options, similar to those available for the perl and ruby programs:\r\n\r\n $ th -h\r\n\r\n\r\n```",
"title": null,
"type": "comment"
}
] | 1 | 2 | 1,553 | false | false | 1,553 | false |
rethinkdb/rethinkdb | rethinkdb | 119,905,801 | 5,163 | null | [
{
"action": "opened",
"author": "bckfnn",
"comment_id": null,
"datetime": 1449049984000,
"masked_author": "username_0",
"text": "The constructor in Connection.java is private, making it impossible to create our own implementations of Connection.\r\n\r\nThe usecase that I would like to experiment with is a non-blocking connection that uses the networking classes from vert.x.\r\n\r\nPlease either make the constructor public, or even better, use a Connection interface in ReqlAst.java which can be implemented in different ways.",
"title": "Allow java Connection subclasses.",
"type": "issue"
},
{
"action": "created",
"author": "deontologician",
"comment_id": 181553188,
"datetime": 1454963109000,
"masked_author": "username_1",
"text": "I made the Connection constructor public in 559ef59, and there are larger Connection refactorings coming in #5292 that will make it potentially easier to customize the Connection",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "deontologician",
"comment_id": null,
"datetime": 1454963109000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "deontologician",
"comment_id": 181553762,
"datetime": 1454963171000,
"masked_author": "username_1",
"text": "Also, thanks for the suggestion @username_0 :)",
"title": null,
"type": "comment"
}
] | 2 | 4 | 612 | false | false | 612 | true |
node-modules/compressing | node-modules | 353,760,009 | 11 | {
"number": 11,
"repo": "compressing",
"user_login": "node-modules"
} | [
{
"action": "opened",
"author": "popomore",
"comment_id": null,
"datetime": 1535113001000,
"masked_author": "username_0",
"text": "",
"title": "fix: keep stat mode when compress tar or tgz",
"type": "issue"
},
{
"action": "created",
"author": "popomore",
"comment_id": 415752345,
"datetime": 1535115822000,
"masked_author": "username_0",
"text": "+ compressing@1.3.1",
"title": null,
"type": "comment"
}
] | 2 | 3 | 19 | false | true | 19 | false |
ManageIQ/manageiq | ManageIQ | 477,413,064 | 19,105 | {
"number": 19105,
"repo": "manageiq",
"user_login": "ManageIQ"
} | [
{
"action": "opened",
"author": "yrudman",
"comment_id": null,
"datetime": 1565101507000,
"masked_author": "username_0",
"text": "**ISSUE**: there is no good way to disable not needed schedule.\r\n**FIX**: accept nil or empty string as first argument to ```MiqScheduleWorker::Scheduler#schedule_every``` which will trigger skipping scheduling\r\n\r\nFixes https://bugzilla.redhat.com/show_bug.cgi?id=1736749\r\n\r\n@miq-bot add-label enhancement, core, changelog/yes, hammer/yes, ivanchuk/yes\r\n\r\n\\cc @gtanzillo",
"title": "Allow MiqSchedule to accept nil and skip scheduling",
"type": "issue"
},
{
"action": "created",
"author": "simaishi",
"comment_id": 519288831,
"datetime": 1565216195000,
"masked_author": "username_1",
"text": "Ivanchuk backport details:\r\n\r\n```\r\n$ git log -1\r\ncommit f33669afc6af838427272bed1bdf94fd889ce33e\r\nAuthor: Gregg Tanzillo <gtanzill@redhat.com>\r\nDate: Tue Aug 6 15:13:55 2019 -0400\r\n\r\n Merge pull request #19105 from username_0/pass-nil-to-miq_scheduler-to-ignore-schedule\r\n \r\n Allow MiqSchedule to accept nil and skip scheduling\r\n \r\n (cherry picked from commit 52f78217f0993eca88301e7a55475cb16b99c156)\r\n \r\n https://bugzilla.redhat.com/show_bug.cgi?id=1736749\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "simaishi",
"comment_id": 544681500,
"datetime": 1571687888000,
"masked_author": "username_1",
"text": "Hammer backport details:\r\n\r\n```\r\n$ git log -1\r\ncommit 0224c074171e566fd705db39808aace390ca1e94\r\nAuthor: Gregg Tanzillo <gtanzill@redhat.com>\r\nDate: Tue Aug 6 15:13:55 2019 -0400\r\n\r\n Merge pull request #19105 from username_0/pass-nil-to-miq_scheduler-to-ignore-schedule\r\n \r\n Allow MiqSchedule to accept nil and skip scheduling\r\n \r\n (cherry picked from commit 52f78217f0993eca88301e7a55475cb16b99c156)\r\n \r\n https://bugzilla.redhat.com/show_bug.cgi?id=1763862\r\n```",
"title": null,
"type": "comment"
}
] | 3 | 5 | 2,166 | false | true | 1,335 | true |
grpc/grpc-swift | grpc | 518,558,915 | 621 | null | [
{
"action": "opened",
"author": "weissi",
"comment_id": null,
"datetime": 1573055304000,
"masked_author": "username_0",
"text": "<!-- Thanks for helping grpc-swift! Before you submit your issue, please make sure to check the following boxes by putting an x in the [ ] (don't: [x ], [ x], do: [x]) -->\r\n\r\n### New Issue Checklist\r\n\r\n- [x] Updated grpc-swift to the latest version\r\n- [x] I read the [Contribution Guidelines](https://github.com/grpc/grpc-swift/blob/master/CONTRIBUTING.md)\r\n- [x] I searched for [existing GitHub issues](https://github.com/grpc/grpc-swift/issues)(especially, there are many [resolved issues related to SSL](https://github.com/grpc/grpc-swift/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aclosed+ssl))\r\n\r\n### Issue Description\r\n\r\n```\r\n$ swift test --sanitize=thread --disable-index-store\r\n[...]\r\nTest Case '-[GRPCTests.FunctionalTestsAnonymousClientNIOTS testBidirectionalStreamingLotsOfMessagesBatched]' started.\r\n/private/tmp/.nio-release-tools_N0Glvg/grpc-swift/Tests/GRPCTests/FunctionalTests.swift:189: error: -[GRPCTests.FunctionalTestsAnonymousClientNIOTS testBidirectionalStreamingLotsOfMessagesBatched] : Asynchronous wait failed: Exceeded timeout of 15 seconds, with unfulfilled expectations: \"Expecting 5000 response(s)\", \"Expecting status received\".\r\n/private/tmp/.nio-release-tools_N0Glvg/grpc-swift/Tests/GRPCTests/FunctionalTests.swift:202: error: -[GRPCTests.FunctionalTestsAnonymousClientNIOTS testBidirectionalStreamingLotsOfMessagesBatched] : XCTAssertEqual failed: (\"ok\") is not equal to (\"unavailable\")\r\nTest Case '-[GRPCTests.FunctionalTestsAnonymousClientNIOTS testBidirectionalStreamingLotsOfMessagesBatched]' failed (15.596 seconds).\r\n```\r\n\r\nthe OS was macOS Catalina\r\n\r\n- NIO: fbe0c8a6b8a968e449f1d4facd825e4069120efb\r\n- grpc swift: 2cd9ea7008312db794cb62d805f5ace043496ead",
"title": "[nio] at least under TSan, flaky test GRPCTests.FunctionalTestsAnonymousClientNIOTS testBidirectionalStreamingLotsOfMessagesBatched",
"type": "issue"
},
{
"action": "created",
"author": "glbrntt",
"comment_id": 550393789,
"datetime": 1573058322000,
"masked_author": "username_1",
"text": "It _looks_ like this is just timing out. Maybe we finally need to do #437 @username_2 / or increase the timeouts?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MrMage",
"comment_id": 551813072,
"datetime": 1573220539000,
"masked_author": "username_2",
"text": "I agree that we should probably have an option to exclude time sensitive tests; do you have a suggestion on how to best implement that?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "glbrntt",
"comment_id": 551822812,
"datetime": 1573220943000,
"masked_author": "username_1",
"text": "We can have an environment variable and then just check whether it's set or not. I'd think a computed property on `GRPCTestCase` (which is needed for log handler setup) and then just add something like: `guard self.enableTimeSensitiveTests else return` in each of the tests we care about.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "MrMage",
"comment_id": 551839865,
"datetime": 1573221899000,
"masked_author": "username_2",
"text": "👍",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "weissi",
"comment_id": 551942560,
"datetime": 1573238307000,
"masked_author": "username_0",
"text": "@username_2 & @username_1 that sounds perfect, in the NIO release tools we use `export ENABLE_TIMING_TESTS=false` to disable them as a few projects have used that syntax. If you don't mind it'd be great if you went for that one, if you choose some other syntax, please let me know and I'll add the respective environment variable to the release tools.",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "glbrntt",
"comment_id": null,
"datetime": 1578322552000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 3 | 7 | 2,569 | false | false | 2,569 | true |
msawczyn/EFDesigner | null | 513,376,350 | 115 | null | [
{
"action": "opened",
"author": "RuiAlias",
"comment_id": null,
"datetime": 1572276302000,
"masked_author": "username_0",
"text": "Hi, I'm getting the following error with v1.3.0.8pre-2:\r\n`'KeyBuilder' does not contain definition for 'Ignore'`\r\n\r\nI believe the relevant code is\r\nhttps://github.com/username_1/EFDesigner/blob/9fb90da6b823f0693b3b4018e727295108e68ab6/src/DslPackage/TextTemplates/EFCoreDesigner.ttinclude#L287-L297",
"title": "'KeyBuilder' does not contain definition for 'Ignore' in EF Core",
"type": "issue"
},
{
"action": "closed",
"author": "msawczyn",
"comment_id": null,
"datetime": 1573345971000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
}
] | 2 | 2 | 296 | false | false | 296 | true |
Microsoft/msphpsql | Microsoft | 283,799,744 | 641 | null | [
{
"action": "opened",
"author": "pniederlag",
"comment_id": null,
"datetime": 1513842793000,
"masked_author": "username_0",
"text": "The README in section \"Step 2: Install Prerequisites\" for debian 9 contains a link to https://packages.microsoft.com/config/debian/9/prod.list which is not available.\r\n\r\nIf there are no packages/support for debian 9/stretch yet please indicate that properly, thx.",
"title": "README pointer to Debian 9/stretch prod.list not available",
"type": "issue"
},
{
"action": "created",
"author": "yitam",
"comment_id": 353391069,
"datetime": 1513872845000,
"masked_author": "username_1",
"text": "For Debian 9 it requires [ODBC 17 preview](https://github.com/Microsoft/msphpsql/wiki/Install-and-configuration#debian-8-and-9)\r\nWe will modify README accordingly. Please let us know if this helps.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "lilgreenbird",
"comment_id": 353540479,
"datetime": 1513928168000,
"masked_author": "username_2",
"text": "hi @username_0 you can find the Debian 9 preview binaries [here](https://github.com/Microsoft/msphpsql/tree/master/ODBC%2017%20binaries%20preview/Debian%209)",
"title": null,
"type": "comment"
},
{
"action": "closed",
"author": "yitam",
"comment_id": null,
"datetime": 1515800638000,
"masked_author": "username_1",
"text": "",
"title": null,
"type": "issue"
},
{
"action": "created",
"author": "yitam",
"comment_id": 357385029,
"datetime": 1515800638000,
"masked_author": "username_1",
"text": "Closing this issue. Please feel free to reopen.",
"title": null,
"type": "comment"
}
] | 3 | 5 | 665 | false | false | 665 | true |
grpc/grpc | grpc | 448,290,120 | 19,137 | {
"number": 19137,
"repo": "grpc",
"user_login": "grpc"
} | [
{
"action": "opened",
"author": "ejona86",
"comment_id": null,
"datetime": 1558720873000,
"masked_author": "username_0",
"text": "Since openjdk8 is dead to us (see #19113), we cannot leave openjdk8 in\r\nthe list of runtimes in client_matrix.py. The list of runtimes is now\r\nthe defaults to use, which includes master, and you can specify\r\nalternative runtimes per-release.\r\n\r\nFixes #19113\r\n\r\n------\r\n\r\nI've tested this change with:\r\n```\r\n$ tools/interop_matrix/create_matrix_images.py --language java\r\n$ docker_image=gcr.io/grpc-testing/grpc_interop_java:master tools/interop_matrix/testcases/java__master\r\n```",
"title": "Swap java interop tests to openjdk8",
"type": "issue"
},
{
"action": "created",
"author": "jtattermusch",
"comment_id": 496809770,
"datetime": 1559112917000,
"masked_author": "username_1",
"text": "I've started an adhoc run of interop matrix.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "jtattermusch",
"comment_id": 496985034,
"datetime": 1559143509000,
"masked_author": "username_1",
"text": "Known failures:\r\n#18967\r\n#18608\r\n#18416",
"title": null,
"type": "comment"
}
] | 2 | 3 | 562 | false | false | 562 | false |
MvvmCross/MvvmCross | MvvmCross | 385,932,661 | 3,222 | {
"number": 3222,
"repo": "MvvmCross",
"user_login": "MvvmCross"
} | [
{
"action": "opened",
"author": "Cheesebaron",
"comment_id": null,
"datetime": 1543526733000,
"masked_author": "username_0",
"text": "### :sparkles: What kind of change does this PR introduce? (Bug fix, feature, docs update...)\r\nBug fix\r\n\r\n### :arrow_heading_down: What is the current behavior?\r\nDeadlock on startup when running on UWP.\r\n\r\nCurrently when simply uncommenting https://github.com/MvvmCross/MvvmCross/blob/develop/Projects/Playground/Playground.Core/ViewModels/RootViewModel.cs#L179 or adding a simple `await Task.Delay(500)` in Initialize of the RootViewModel on UWP, then the App never finishes starting up.\r\n\r\nIt seems like Startup doesn't like content switching a lot, especially not switching back to UI thread.\r\n\r\n### :new: What is the new behavior (if this is a feature change)?\r\nRemove `GetAwaiter().GetResult()` which _will_ block as soon as you try to get back to the UI thread. It is the same as calling `.Result`. Since the method is already marked `async` I just await it instead.\r\n\r\nAlso I don't see any reason as to why everything needs to return on to the context it came from, so added a bit of `ConfigureAwait(false)`.\r\n\r\n### :boom: Does this PR introduce a breaking change?\r\nHopefully not.\r\n\r\n### :bug: Recommendations for testing\r\nReviewers please test other platforms than UWP too!\r\n\r\n### :memo: Links to relevant issues/docs\r\n#3209 \r\n#2953\r\n#3221\r\n\r\n### :thinking: Checklist before submitting\r\n\r\n- [x] All projects build\r\n- [x] Follows style guide lines ([code style guide](https://github.com/MvvmCross/MvvmCross#code-style-guidelines))\r\n- [ ] Relevant documentation was updated ([docs style guide](https://www.mvvmcross.com/documentation/contributing/mvvmcross-docs-style-guide))\r\n- [x] Rebased onto current develop",
"title": "GetAwaiter().GetResult() is a really bad idea in a async method",
"type": "issue"
},
{
"action": "created",
"author": "nickrandolph",
"comment_id": 443084961,
"datetime": 1543551130000,
"masked_author": "username_1",
"text": "The point of calling GetResult is to force synchronouse behaviour here - doing async work on startup will cause issues and random exceptions if it takes too long. \r\nDon't call ConfigureAwait(false) - this doesn't return from the method on a different thread, it just means that the remainder of the thread is done on a different thread. Little or no saving.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Cheesebaron",
"comment_id": 443122169,
"datetime": 1543564712000,
"masked_author": "username_0",
"text": "It is fine for `StartupAsync` to call it with `GetAwaiter().GetResult()`, I understand that we want to block there. However, for `ApplicationStartup` to call `Navigate` like that is prone to break a lot. How come behavior is _different_ between implementing `MvxAppStart` that just takes a `ViewModel` contra the one with both `ViewModel` and `Parameter`? I don't see anything warrants this?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nickrandolph",
"comment_id": 443124447,
"datetime": 1543565363000,
"masked_author": "username_1",
"text": "Off top of my head I don't know the answer. Coming back to the UWP blocking issue, the answer is actually to get off the UI thread and the jump back as required (or don't await your init logic)",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "slodge",
"comment_id": 443126374,
"datetime": 1543565878000,
"masked_author": "username_2",
"text": "https://stackoverflow.com/a/5097066 <- MIT license",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "elucidsoft",
"comment_id": 443518659,
"datetime": 1543766679000,
"masked_author": "username_3",
"text": "This needs an immediate fix, debating the finer points of how to do this properly should be something that can be done after a hotfix for this issue is applied. This is a pretty severe issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nickrandolph",
"comment_id": 443542527,
"datetime": 1543785171000,
"masked_author": "username_1",
"text": "@username_3 no there is no excuse for implementing a patch that will just make the situation worse. From my understanding this is only an issue where an await is called within the Initalise of the first view model, or have I missed something? If this is the case, the workaround is to shift the awaitable logic to allow the first view to load",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "elucidsoft",
"comment_id": 443546919,
"datetime": 1543788610000,
"masked_author": "username_3",
"text": "This is an issue if there's a blocking call of any kind in the initialize of the first viewmodel. It will hang on startup, what's worse is it can hang on startup randomly and in unpredictable ways. For instance I was loading a database, since that took a different amount of time 90% of the time the app loaded fine. 10% of the time people were seeing random hangs on startup of the app. In the test case it's been simplified to demonstrate the issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nickrandolph",
"comment_id": 443547029,
"datetime": 1543788673000,
"masked_author": "username_1",
"text": "And you can't move this logic so that it gets done after the initial navigation?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "elucidsoft",
"comment_id": 443548663,
"datetime": 1543789998000,
"masked_author": "username_3",
"text": "I have a workaround, but imagine how many people who use this framework will have this issue? Perhaps even unnoticed, seems pretty bad.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nickrandolph",
"comment_id": 443549828,
"datetime": 1543790911000,
"masked_author": "username_1",
"text": "@username_3 in the short term we need to probably highlight this issue in the docs. Long term we might want to consider a synchronous navigation for the first navigation - we need to be explicit that async work should not be undertaken before the first view is shown. Particularly for XF delaying loading the first view will cause issues.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "flyingxu",
"comment_id": 443560103,
"datetime": 1543799033000,
"masked_author": "username_4",
"text": "`GetAwaiter().GetResult()` will block any further await calls with the same context unless the await calls are called with `ConfigureAwait(false)` (by giving up the context). See: https://blog.stephencleary.com/2012/07/dont-block-on-async-code.html . \r\nThe root cause of this issue is that `GetAwaiter().GetResult()` blocks the UI context and the `await Task.Delay()` can't get the context to return.\r\n\r\nIf yo search the whole MvvmCross lib code, there are only 2 `GetAwaiter().GetResult()` calls now. One is removed by this PR, the other one is mentioned [earlier](https://github.com/MvvmCross/MvvmCross/pull/3222#issuecomment-443078022) and I strongly suggest we remove it for good. If we keep the other `GetAwaiter().GetResult()`, we will find it blocks some other code sooner or later or we make all the await calls with `ConfigureAwait(false)`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "flyingxu",
"comment_id": 443566949,
"datetime": 1543802651000,
"masked_author": "username_4",
"text": "oh, even everybody (the lib, the lib's user) use 'ConfigureAwait(false)', it's not guaranteed to fix the issue 100% because 'ConfigureAwait(false)' is not guaranteed to switch to a new context. \r\nInteresting reading:\r\n\r\nhttps://stackoverflow.com/questions/53456754/configureawaitfalse-does-the-continuation-always-run-on-different-thread\r\n\r\nHere comes my final suggestion: remove all `GetAwaiter().GetResult()` from UI thread.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Cheesebaron",
"comment_id": 444007396,
"datetime": 1543910715000,
"masked_author": "username_0",
"text": "@username_1 it does yield a difference, if _all_ calls down the chain from the `StartAsync` have `ConfigureAwait(false)`. However, we cannot control that when a user doesn't do this in their `Initialize` method in their ViewModel.\r\n\r\nWe should look into the SO thread @username_2 posted. It seems interesting.\r\nAlternatively we could maybe abuse the `MvxNotifyTask` a bit with a `TaskCompletionSource` to get a blocking behavior.\r\n\r\nI'll have another stab at this soon.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Cheesebaron",
"comment_id": 444652685,
"datetime": 1544044795000,
"masked_author": "username_0",
"text": "So. I think I've fixed this now. I've added a SynchronizationContext which is based on Stephen Toub's AsyncPump [[1](https://blogs.msdn.microsoft.com/pfxteam/2012/01/20/await-synchronizationcontext-and-console-apps/)][[2](https://blogs.msdn.microsoft.com/pfxteam/2012/01/21/await-synchronizationcontext-and-console-apps-part-2/)][[3](https://blogs.msdn.microsoft.com/pfxteam/2012/02/02/await-synchronizationcontext-and-console-apps-part-3/)]\r\n\r\nThis allows us to kick off all tasks that are in `StartAsync` on the current thread and run serially until completion. This is what the `SingleThreadSynchronizationContext` ensures by simply running each task that is queued within `StartAsync` in succession.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nickrandolph",
"comment_id": 445107731,
"datetime": 1544151970000,
"masked_author": "username_1",
"text": "I've just run this up and walked through it a couple of times to get my head around it. It looks good to me and hopefully will resolve a bunch of startup related issues in the backlog - well done!",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "ferrydeboer",
"comment_id": 446214544,
"datetime": 1544537306000,
"masked_author": "username_5",
"text": "This dosn't work yet because the MvxIosUIThreadDispatcher.IsOnMainThread returns false due to the SynchronizationContext being of a different type. This is fairly easy to reproduce using a custom AppStart with the following implementation for NavigateToFirstViewModel:\r\n``` \r\nprotected override async Task NavigateToFirstViewModel(object hint = null)\r\n{\r\n await Task.Delay(1500);\r\n await NavigationService.Navigate<RootViewModel>();\r\n}\r\n```\r\nI validated this by modifying the MvxIosUIThreadDispatcher.IsOnMainThread:\r\n```\r\n public override bool IsOnMainThread\r\n {\r\n get\r\n {\r\n if (_uiSynchronizationContext == SynchronizationContext.Current) return true;\r\n var memberInfo = SynchronizationContext.Current?.GetType();\r\n if (memberInfo != null && memberInfo.Name.EndsWith(\"SingleThreadSynchronizationContext\")) return true;\r\n\r\n return false;\r\n }\r\n }\r\n```\r\nNow the application starts again, although in a rather smelly fashion using a string comparison on a type name.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Cheesebaron",
"comment_id": 446576287,
"datetime": 1544618865000,
"masked_author": "username_0",
"text": "@username_5 thanks for trying this code out. I will have a go at fixing this iOS issue.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Cheesebaron",
"comment_id": 446709062,
"datetime": 1544642155000,
"masked_author": "username_0",
"text": "OK. I've tested on UWP, WPF, Android and iOS now. All seem to work when checking whether Current SynchronizationContext is SingleThreadedSynchronizationContext.\r\n\r\nSince we are the only ones being able to create it and we always do that from the UI thread, it should be safe to do.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "flostr",
"comment_id": 447391030,
"datetime": 1544807724000,
"masked_author": "username_6",
"text": "Please fix this. I did spent half a day finding the cause of this issue. For me this happens exactly like described in [#3209](https://github.com/MvvmCross/MvvmCross/issues/3209).\r\n\r\nI currently fixed this by removing the **await** in **MvxAppStart<TViewModel>.NavigateToFirstViewModel**>\r\n```\r\n protected override async Task NavigateToFirstViewModel(object hint = null)\r\n {\r\n try\r\n {\r\n //await NavigationService.Navigate<TViewModel>();\r\n NavigationService.Navigate<TViewModel>();\r\n }\r\n catch (System.Exception exception)\r\n {\r\n throw exception.MvxWrap(\"Problem navigating to ViewModel {0}\", typeof(TViewModel).Name);\r\n }\r\n }\r\n```",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nickrandolph",
"comment_id": 475037682,
"datetime": 1553117685000,
"masked_author": "username_1",
"text": "Hey all, what do we need to get this merged?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Cheesebaron",
"comment_id": 475905205,
"datetime": 1553375592000,
"masked_author": "username_0",
"text": "Android sync does still not work. I'll try to find some time to fix it. But if someone wants to chip in they are welcome to do that.\r\n\r\nSimilarly to the other platforms, we need to pump the tasks that are run during startup of MvvmCross, this needs to happen on Android as well.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "zevsst",
"comment_id": 483239798,
"datetime": 1555332933000,
"masked_author": "username_7",
"text": "Observing this issue since our projects migrated to MvvmCross 6.2.3 in December 2018. Spent 1 day to figure out what was going wrong.\r\n\r\nThe temp solution is:\r\n`public class CustomMvxAppStart : MvxAppStart\r\n\t{\r\n\t\tpublic CustomMvxAppStart(IMvxApplication application, IMvxNavigationService navigationService) : base(application, navigationService)\r\n\t\t{\r\n\t\t}\r\n\r\n\t\tprotected override async Task NavigateToFirstViewModel(object hint = null)\r\n\t\t{\r\n\t\t\t// Never do this until Cross team gets this issue fixed\r\n\t\t\t// await NavigationService.Navigate<LoginViewModel>();\r\n\r\n\t\t\t// https://github.com/MvvmCross/MvvmCross/pull/3222\r\n\t\t\t// https://github.com/MvvmCross/MvvmCross/issues/3209 - warkaround was taken from here\r\n\t\t\t// https://github.com/MvvmCross/MvvmCross/issues/2953\r\n\t\t\t// https://github.com/MvvmCross/MvvmCross/issues/3221\r\n\r\n NavigationService.Navigate<SplashViewModel>();\r\n\t\t}\r\n\t}`\r\n\r\nAre you going to provide any fix?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "flostr",
"comment_id": 485763952,
"datetime": 1556018924000,
"masked_author": "username_6",
"text": "This PR looks like a proper solution by now. When can we expect it to be merged?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "arek-avanade",
"comment_id": 490382779,
"datetime": 1557301151000,
"masked_author": "username_8",
"text": "Instead of introducing custom sync context or any other complex solutions, why not just providing a different base view model class for the initial view, which doesn't have ANY async init methods, just sync? This could be the only class that MvxAppStart accepts. \r\nEach mobile developer would have to consciously make a decision how he/she wants to handle app start: it can be either purely synchronous OR one could use Task.Run(...).Wait() in his sync init method to run any asynchronous code and wait for the result on the main thread. This puts more control to the app developer and would let MvvmCross team avoid dirty solutions like `.GetAwaiter().GetResult()`.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "nickrandolph",
"comment_id": 490385489,
"datetime": 1557301686000,
"masked_author": "username_1",
"text": "What you've proposed is my option 1 in my response over at https://github.com/MvvmCross/MvvmCross/issues/3395 \r\n\r\nUnfortunately simply having a different base class isn't the right answer:\r\n- It's not adequate to make it synchronous because there are some thing you may want to do that are async actions. For example just doing a file read on UWP is an async operation. Simply creating a synchronous option doesn't help.\r\n- Duplicating the base class means that we need to have specific logic for the first navigation, which means more code to maintain and update as we evolve the platform.\r\n\r\nAssuming we can get @username_0 's proposed solution to work (which I think it pretty close now) this should be transparent to most devs and will allow them to put async actions in the Initialize method whilst still allowing all platforms to start up correctly.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "arek-avanade",
"comment_id": 490402691,
"datetime": 1557305041000,
"masked_author": "username_8",
"text": "I understand the need for async calls during start up, hence there is always possibility to use `Task.Run(...).Wait()` even in a sync method.\r\nI don't know the whole MvvmCross codebase, but if it's hard to introduce a different base view model class for start up, then I think the problem is not with the sync start up but with the current framework design. \r\nAsyncPump might be an elegant solution, but requires very specific knowledge to understand it. If there is a bug in this code, there are probably just a few people here who can fix it (or even just one - the author :) ), and also debugging the start up sequence in applications might be difficult.\r\nIf you guys want to push this forward as an interim solution, that makes sense to me, but I would not stick to that approach longer than absolutely needed.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "FinHorsley",
"comment_id": 599516107,
"datetime": 1584362797000,
"masked_author": "username_9",
"text": "@username_1 Do we really need async to cater for UWP? Hopefully i haven't missed a howler, but frameworks like Xamarin.Forms just have a synchronous startup, `override void OnStart()`\r\n\r\nThe startup here is an inherently synchronous process, so shouldn't this be reflected in the framework? 🙂",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "DavidMarquezF",
"comment_id": 621620027,
"datetime": 1588224332000,
"masked_author": "username_10",
"text": "This is currently causing problems in our app. Are there any plans to merge this??",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yanxiaodi",
"comment_id": 624445816,
"datetime": 1588742120000,
"masked_author": "username_11",
"text": "Hi, guys, any updates for this issue? Thanks.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "Cheesebaron",
"comment_id": 624478710,
"datetime": 1588748693000,
"masked_author": "username_0",
"text": "@username_11 no. Do you want to take over and finish it up?",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yanxiaodi",
"comment_id": 625138091,
"datetime": 1588843486000,
"masked_author": "username_11",
"text": "@username_0 I've tried but the solution crashes frequently on my laptop. I'll investigate it later.",
"title": null,
"type": "comment"
},
{
"action": "created",
"author": "yanxiaodi",
"comment_id": 626278177,
"datetime": 1589090177000,
"masked_author": "username_11",
"text": "@username_0 @username_1 so now what we need to do for this PR? I think the key thing here is to make sure that the app can start properly even if the lib user uses an async method in the AppStart.",
"title": null,
"type": "comment"
}
] | 12 | 33 | 13,459 | false | false | 13,459 | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.