sha
stringlengths
40
40
author
stringlengths
1
63
committer
stringlengths
1
41
message
stringlengths
1
65.5k
subject
stringlengths
1
5.64k
subject_length
float64
1
5.64k
is_chore
bool
2 classes
is_bot
bool
2 classes
subject_word_count
float64
1
806
verb_object_spacy
bool
2 classes
verb_object_stanza
bool
2 classes
fits_requirements
bool
2 classes
owner
stringlengths
2
15
repo
stringlengths
2
21
__index_level_0__
int64
0
85k
9fbd5e0f74234c9ebfe97f6f84c4c851cc67f6e2
Stefan Penner
Stefan Penner
Merge pull request #10681 from ef4/fix-unrecog Fix UnrecognizedURLError inheritance via router.js update
merge pull request from ef4/fix-unrecog
40
true
false
5
true
false
false
emberjs
ember.js
12,900
75d81a0566e7c3e59994dd84c2669cb326094352
Edward Faulkner
Edward Faulkner
Fix UnrecognizedURLError inheritance via router.js update
fix unrecognizedurlerror inheritance via router.js update
57
false
false
6
true
true
false
emberjs
ember.js
12,901
981ed2160526e185f325062e107d6086e95423fc
Stanley Stuart
Stanley Stuart
Merge pull request #10680 from emberjs/jshinting make jshint happy
merge pull request from emberjs/jshinting
42
true
false
5
true
false
false
emberjs
ember.js
12,902
3ddcad2a72d796cb0e30bca15d176d95e087f417
Stefan Penner
Stefan Penner
make jshint happy
make jshint happy
17
false
false
3
false
true
false
emberjs
ember.js
12,903
67b0df99bbc71342bbfe024835a9af2ccc4c5365
Robert Jackson
Robert Jackson
Merge pull request #10679 from rwjblue/remove-docs-for-deprecation Ensure docs are not detected for deprecation mixins.
merge pull request from rwjblue/remove-docs-for-deprecation
60
true
false
5
true
false
false
emberjs
ember.js
12,904
c7f9d3ed9959720c1d5e6bc7339fa31df41582c9
Robert Jackson
Robert Jackson
Ensure docs are not detected for deprecation mixins.
ensure docs are not detected for deprecation mixins
51
false
false
8
false
false
false
emberjs
ember.js
12,905
7b58afc12d47c0fae12eb3dbe2435e15a1db3fa5
Stefan Penner
Stefan Penner
Merge pull request #10678 from matthooks/master Fix typos in deprecations of unescaped style attribute
merge pull request from matthooks/master
41
true
false
5
true
false
false
emberjs
ember.js
12,906
d9fa5880c3097ec5cbf6df2152749dc09cb7490f
Robert Jackson
Robert Jackson
Merge pull request #10673 from wagenet/remove-each-proxy Remove EachProxy and EachArray from exports
merge pull request from wagenet/remove-each-proxy
50
true
false
5
true
false
false
emberjs
ember.js
12,907
ee305d2cadfad9624df5b1a2cb526fdf5b99f683
Robert Jackson
Robert Jackson
Merge pull request #10667 from wagenet/deprecate-try-catch-finally Deprecate tryFinally and tryCatchFinally
merge pull request from wagenet/deprecate-try-catch-finally
60
true
false
5
true
false
false
emberjs
ember.js
12,908
8c84524ede16cf8c684270e6c4fc75e0409e5cc5
Robert Jackson
Robert Jackson
Merge pull request #10668 from wagenet/deprecate-required Deprecate Ember.required
merge pull request from wagenet/deprecate-required
51
true
false
5
true
false
false
emberjs
ember.js
12,909
1ba2ceacc9f3a605dfc28050bb9918ebb78ad0e9
Robert Jackson
Robert Jackson
Merge pull request #10672 from wagenet/remove-descriptor Remove Ember.Descriptor from exports
merge pull request from wagenet/remove-descriptor
50
true
false
5
true
false
false
emberjs
ember.js
12,910
61cb273cb646f6a5740c328f8d43e140a52c1dca
Matt Hooks
Matt Hooks
Update bind_attr_test.js Fix typo.
update bind_attr_test.js
24
false
false
2
false
false
false
emberjs
ember.js
12,911
773bffb08b9f6120109e064db83091d3165f8e91
Matt Hooks
Matt Hooks
Update style_test.js Fix typo.
update style_test.js
20
false
false
2
true
false
false
emberjs
ember.js
12,912
3871be07e2b8c9ff2f9e73518effabbdaff52706
Matt Hooks
Matt Hooks
Update attr_node.js Fix typo.
update attr_node.js
19
false
false
2
false
false
false
emberjs
ember.js
12,913
75e6e5f8bfc4cf775b35c83c02b4345b6ed7cec8
Ilya Radchenko
Ilya Radchenko
Add missing component helper to 1.11.0-beta.1 changelog
add missing component helper to 1.11.0-beta.1 changelog
55
false
false
7
true
true
false
emberjs
ember.js
12,914
95caff58abbde77d1d0e627e766f36d00f80cab4
Stefan Penner
Stefan Penner
Merge pull request #10671 from wagenet/remove-private-docs Prevent unexported classes from being documented
merge pull request from wagenet/remove-private-docs
52
true
false
5
true
false
false
emberjs
ember.js
12,915
4b1a4a356feac492ed338796318c0c9760589565
Matthew Beale
Matthew Beale
Merge pull request #10663 from rwjblue/deprecate-unescaped-style-attribute [BUGFIX beta] Deprecate escaped style attributes.
merge pull request from rwjblue/deprecate-unescaped-style-attribute
68
true
false
5
true
false
false
emberjs
ember.js
12,916
7e8de72404c8121b5c7a8951be351b215047b03a
Peter Wagenet
Peter Wagenet
Prevent ControllerContentModelAliasDeprecation from being documented
prevent controllercontentmodelaliasdeprecation from being documented
68
false
false
5
true
true
false
emberjs
ember.js
12,917
3a4143f62b07d67e34ef40fde09724ea9f6147b1
Peter Wagenet
Peter Wagenet
Remove EachProxy and EachArray from exports
remove eachproxy and eacharray from exports
43
false
false
6
false
true
false
emberjs
ember.js
12,918
b339c671df7bcbdfdd9381ede4faf56f5f405b36
Peter Wagenet
Peter Wagenet
Remove Ember.Descriptor from exports
remove ember.descriptor from exports
36
false
false
4
true
true
true
emberjs
ember.js
12,919
8269b7b3e434ab150b96f3faa3e58e96e1a5b8a4
Peter Wagenet
Peter Wagenet
Prevent ComponentTemplateDeprecation from being documented
prevent componenttemplatedeprecation from being documented
58
false
false
5
true
true
false
emberjs
ember.js
12,920
cca8dd2b7f23e96aa407dd3becbbd64284df2b40
Peter Wagenet
Peter Wagenet
Stop exporting private views
stop exporting private views
28
false
false
4
false
false
false
emberjs
ember.js
12,921
e2f38191b870760196311fb9f919dfc2cd9a5cad
Peter Wagenet
Peter Wagenet
Deprecate Ember.required
deprecate ember.required
24
false
false
2
false
true
false
emberjs
ember.js
12,922
09a45e90f0d2e9028bd69c5b92385fade7aeff6e
Robert Jackson
Robert Jackson
[BUGFIX beta] Deprecate escaped style attributes.
[bugfix beta] deprecate escaped style attributes
48
false
false
6
false
false
false
emberjs
ember.js
12,923
082e17dab013522d0120a65ac74105f839882c3e
Peter Wagenet
Peter Wagenet
Deprecate tryFinally and tryCatchFinally
deprecate tryfinally and trycatchfinally
40
false
false
4
false
false
false
emberjs
ember.js
12,924
44d5f188c96a7e94bb977b07558c93fda192232d
Stefan Penner
Stefan Penner
Merge pull request #10572 from SaladFork/patch-1 Fix UnrecognizedURLError not being an Error
merge pull request from saladfork/patch-1
42
true
false
5
true
false
false
emberjs
ember.js
12,925
05c28c54b34e706edd68e8efa20cd6b1e5538cb8
Stefan Penner
Stefan Penner
Merge pull request #10638 from emberjs/destructuring-example some destructuring examples to prove it works
merge pull request from emberjs/destructuring-example
54
true
false
5
true
false
false
emberjs
ember.js
12,926
3f0d3ef22a694706266e353912886df0d947a8f2
Sjoerd de Jong
Sjoerd de Jong
Document primitives of Ember.Array mixin AFAIK `Ember.Array` needs `length` and `objectAt` to be implemented. `Ember.MutableArray` needs `replace()`, right?
document primitives of ember.array mixin
40
false
false
5
false
false
false
emberjs
ember.js
12,927
a791b68674ea3cffc590126bd43e728e6747504c
Stefan Penner
Stefan Penner
some destructuring examples to prove it works
some destructuring examples to prove it works
45
false
false
7
false
false
false
emberjs
ember.js
12,928
9fc73fee88dbbe51c803b15c2e2c1c1a6831f34b
Robert Jackson
Robert Jackson
Merge pull request #10640 from bmac/since-tags-docs [DOC beta] Add missing since tags
merge pull request from bmac/since-tags-docs
45
true
false
5
true
false
false
emberjs
ember.js
12,929
392e4c8dc8d4d6c7899491d5eff3e2c34e073b47
bmac
bmac
[DOC beta] Add missing since tags Registry was added in 1.11 component helper was added 1.11 Route activate and deactivate events were added in 1.9 Inject methods were added in 1.10 Ember.computed.reads was rendering in the wrong place
[doc beta] add missing since tags
33
false
false
6
false
false
false
emberjs
ember.js
12,930
f86ab841ad86b5a0229997b1a3e0c2847ffaf00d
Robert Jackson
Robert Jackson
Merge pull request #10639 from rwjblue/update-emberjs-build Use released version of emberjs-build.
merge pull request from rwjblue/update-emberjs-build
53
true
false
5
true
false
false
emberjs
ember.js
12,931
c35ecb8a39b0c6e0f62d78e3181504604b123c5b
Robert Jackson
Robert Jackson
Use released version of emberjs-build.
use released version of emberjs-build
37
false
false
5
false
true
false
emberjs
ember.js
12,932
06e41ad7ccd28558dd4e651aa070bc06f7757821
Stefan Penner
Stefan Penner
Merge pull request #10636 from emberjs/es6.properties.shorthand Es6.properties.shorthand
merge pull request from emberjs/es6.properties.shorthand
57
true
false
5
true
false
false
emberjs
ember.js
12,933
1b36c378b164ce3654dec944559092d488ca017b
Stefan Penner
Stefan Penner
Merge pull request #10615 from knownasilya/patch-6 Update mutable_array examples
merge pull request from knownasilya/patch-6
44
true
false
5
true
false
false
emberjs
ember.js
12,934
22f86fe2611f3b02f62e5923fc0a710460e405a5
Stefan Penner
Stefan Penner
Merge pull request #10634 from emberjs/cleanup-args cleanup arguments
merge pull request from emberjs/cleanup-args
45
true
false
5
true
false
false
emberjs
ember.js
12,935
90397ef15453da1cba1f6bda374e075f054bfdf4
Stefan Penner
Stefan Penner
es6.properties.shorthand
es6.properties.shorthand
24
false
false
1
false
false
false
emberjs
ember.js
12,936
df2fede770c21e4c3cbdd07517ad13791507ce5e
Stefan Penner
Stefan Penner
cleanup arguments
cleanup arguments
17
false
false
2
false
false
false
emberjs
ember.js
12,937
8b9f894b5569fe0bb144c4f124268678ff04fc13
Stefan Penner
Stefan Penner
cleanup arguments
cleanup arguments
17
false
false
2
false
false
false
emberjs
ember.js
12,938
614cfdc131b3c60d19747c80d8c7c8d7da17619d
Stefan Penner
Stefan Penner
Merge pull request #10524 from chadhietala/6-to-5 Introduce arrow functions, rest params, and string templates to Ember Metal
merge pull request from chadhietala/6-to-5
43
true
false
5
true
false
false
emberjs
ember.js
12,939
1df0877edfccc3fb117f16cc88b071976d4ecd3b
Chad Hietala
Chad Hietala
Introduces arrow functions, rest params, and string templates. This introduces ES6 arrow functions, rest params, and string templates to Ember Metal.
introduces arrow functions, rest params, and string templates
61
false
false
8
false
false
false
emberjs
ember.js
12,940
6c9945be004964c816b60706f25e04b6785b9c51
Stefan Penner
Stefan Penner
Merge pull request #10633 from emberjs/update-ember-cli Update ember cli
merge pull request from emberjs/update-ember-cli
49
true
false
5
true
false
false
emberjs
ember.js
12,941
18d211ff3ddb1a9a25ec58765de27289f4e74fbe
Stefan Penner
Stefan Penner
Merge pull request #10632 from emberjs/enable-destructuring bump emberjs-build, enable destructuring
merge pull request from emberjs/enable-destructuring
53
true
false
5
true
false
false
emberjs
ember.js
12,942
e381b71472be28c73e835602b99628bb034f5848
Stefan Penner
Stefan Penner
update ember-cli
update ember-cli
16
false
false
2
false
false
false
emberjs
ember.js
12,943
f43bc9990b462209db4a8fe093616fcd15bb09cd
Stefan Penner
Stefan Penner
bump emberjs-build, enable destructuring
bump emberjs-build, enable destructuring
40
true
false
4
false
true
false
emberjs
ember.js
12,944
d6f42c2d3d51695456d78c66a164f11eb67f7283
Robert Jackson
Robert Jackson
Merge pull request #10463 from teddyzeenny/async-helpers Fix async test helpers
merge pull request from teddyzeenny/async-helpers
50
true
false
5
true
false
false
emberjs
ember.js
12,945
223683b5b845c533784741cfd802ab00fee8e225
Martin Muñoz
Martin Muñoz
Merge pull request #10631 from rwjblue/deprecate-fooBinding-syntax [BUGFIX beta] Deprecate usage of {{view fooBinding="blah"}}.
merge pull request from rwjblue/deprecate-foobinding-syntax
60
true
false
5
true
false
false
emberjs
ember.js
12,946
3b9fc3ed87c2a8b13e56aecdeafc147d97836285
Robert Jackson
Robert Jackson
[BUGFIX beta] Deprecate usage of {{view fooBinding="blah"}}.
[bugfix beta] deprecate usage of {{view foobinding="blah"}}
59
false
false
7
false
false
false
emberjs
ember.js
12,947
fef64881ffefbc011dbe512342bf42c9d7473332
Robert Jackson
Robert Jackson
Merge pull request #10616 from mmun/fix-loader-cycles Fix lazy module cycle support
merge pull request from mmun/fix-loader-cycles
47
true
false
5
true
false
false
emberjs
ember.js
12,948
0196b843c24cc8ece265c018fd964d707994e106
Robert Jackson
Robert Jackson
Merge pull request #10627 from rwjblue/class-bound-sub-expr [BUGFIX beta] Fix `{{view class=(sub-expr)}}`.
merge pull request from rwjblue/class-bound-sub-expr
53
true
false
5
true
false
false
emberjs
ember.js
12,949
ca64b1f3db8bc878b4027edeccdaf717f358d4b3
Robert Jackson
Robert Jackson
Merge pull request #10630 from rwjblue/deprecate-quoteless-binding [BUGFIX beta] Deprecate using `fooBinding` with non-quoted values.
merge pull request from rwjblue/deprecate-quoteless-binding
60
true
false
5
true
false
false
emberjs
ember.js
12,950
6e0c01e562601b30a022735bf99496a6186297c1
Robert Jackson
Robert Jackson
[BUGFIX beta] Deprecate using `fooBinding` with non-quoted values. This was previously generating a warning, but not a deprecation. This sets the stage to remove the fallback in Ember 2.0.
[bugfix beta] deprecate using `foobinding` with non-quoted values
65
false
false
8
false
false
false
emberjs
ember.js
12,951
ed8f3dfcdb9406ef687c53b7c59a11e0e874840b
Robert Jackson
Robert Jackson
[BUGFIX beta] Fix `{{view class=(sub-expr)}}`.
[bugfix beta] fix `{{view class=(sub-expr)}}`
45
false
false
5
false
false
false
emberjs
ember.js
12,952
d96cc9eb31b27a52e8fabac38c1d18d14bd9e2ba
Stefan Penner
Stefan Penner
Update input.js
update input.js
15
false
false
2
true
false
false
emberjs
ember.js
12,953
8ebca79ae105752cfd8452a8b2f41aeb1aedb54a
Ilya Radchenko
Ilya Radchenko
Update mutable_array example Change quotes to single, and add some line breaks
update mutable_array example
28
false
false
3
true
true
true
emberjs
ember.js
12,954
07f3da2b37309acf63d8080bafb16387dd349eca
Martin Muñoz
Martin Muñoz
Fix lazy module cycle support
fix lazy module cycle support
29
false
false
5
false
false
false
emberjs
ember.js
12,955
a0554efa724a1db83cb2c55be75d20602c580fbf
Martin Muñoz
Martin Muñoz
Merge pull request #10613 from rwjblue/ensure-view-id-can-be-set [BUGFIX beta] Ensure `{{view id=bar}}` sets `id` on the view.
merge pull request from rwjblue/ensure-view-id-can-be-set
58
true
false
5
true
false
false
emberjs
ember.js
12,956
695302f421ecd99e6ef7b810f8c152bee6aa0afd
Robert Jackson
Robert Jackson
[BUGFIX beta] Ensure `{{view id=bar}}` sets `id` on the view.
[bugfix beta] ensure `{{view id=bar}}` sets `id` on the view
60
false
false
10
false
false
false
emberjs
ember.js
12,957
5e39827aa64f50ca13d9c3a16ad518e3a4311ad8
Robert Jackson
Robert Jackson
Merge pull request #10612 from rwjblue/fix-inject [BUGFIX release] `Ember.inject.controller()` works for all Controller types.
merge pull request from rwjblue/fix-inject
43
true
false
5
true
false
false
emberjs
ember.js
12,958
7aa33c8a482d72ffc5c9d07bfbf35c296e8d9b79
Robert Jackson
Robert Jackson
[BUGFIX release] `Ember.inject.controller()` works for all Controller types.
[bugfix release] `ember.inject.controller()` works for all controller types
75
false
false
8
false
false
false
emberjs
ember.js
12,959
a6fdd051df9cfff14642f556c892c909fd8e5189
Stefan Penner
Stefan Penner
Merge pull request #10604 from rwjblue/fix-funky-commment-stripping [BUGFIX beta] Ensure 'use strict'; remover comments are not stripped.
merge pull request from rwjblue/fix-funky-commment-stripping
61
true
false
5
true
false
false
emberjs
ember.js
12,960
42e6ac795ffa4831e779e4aa77f76898ae93fb08
Robert Jackson
Robert Jackson
[BUGFIX beta] Ensure 'use strict'; remover comments are not stripped.
[bugfix beta] ensure 'use strict'; remover comments are not stripped
68
false
false
10
false
false
false
emberjs
ember.js
12,961
069a24345928de3c1f746093b917517677cb2e4e
Matthew Beale
Matthew Beale
Merge pull request #10599 from emberjs/view-registry Don’t share view registry across containers
merge pull request from emberjs/view-registry
46
true
false
5
true
false
false
emberjs
ember.js
12,962
6a71ff26042f2e6f9516f9616d88159a2acd8bec
Tom Dale
Tom Dale
Use less container trickery thanks @igorT
use less container trickery
27
false
false
4
true
true
true
emberjs
ember.js
12,963
42993e5a4ba55cbb1919f1ce4108a4093d11ea89
Tom Dale
Tom Dale
Move view registry assertions into View
move view registry assertions into view
39
false
false
6
false
false
false
emberjs
ember.js
12,964
fef509a5f33c7a4cc708a95951073f5346e37a32
Tom Dale
Tom Dale
Don’t share view registry across containers Previously, all rendered views were inserted into the Ember.View.views global hash, indexed by their `elementId`. This hash is used by the EventDispatcher to locate views, and is also used by some advanced developers as a debugging aid. Unfortunately, using a global shared store of views is problematic in the FastBoot/application instance case, since multiple views with the same elementId can exist at the same time. This creates a race condition where the second view to be created will throw an exception, as Ember believes that a view with that element ID has already been created (normally an error in “single app” mode). This commit introduces the notion of a “view registry”, which is just a simple hash injected onto views and shared container-wide. Because each application instance in FastBoot has its own container, these views will naturally be isolated. To preserve backwards-compatibility, the default instance created when the app is booting normally (i.e., autoboot is `false`) injects the global Ember.View.views hash. We should consider removing this entirely in Ember 2.0, now that the Container pane of the Inspector gives developers easier access to registered views. Do note, however, that the Event Dispatcher still has a dependency on the global Ember.View.views, though it could be relatively easily refactored to also have the view registry injected.
don’t share view registry across containers
43
false
false
6
false
false
false
emberjs
ember.js
12,965
a27163ac470efabfc404eb53873d440faa708a78
Matthew Beale
Matthew Beale
Merge pull request #10424 from emberjs/explicit-node-rendering Explicit renderToElement API
merge pull request from emberjs/explicit-node-rendering
56
true
false
5
true
false
false
emberjs
ember.js
12,966
f54914982b5e07ae41ee5280574c024cc7072ef6
Tom Dale + Yehuda Katz
Tom Dale
Adds tests, documentation, and optional tagName
adds tests, documentation, and optional tagname
47
false
false
6
false
false
false
emberjs
ember.js
12,967
4b4e1e930301d55a03e058f7af6c6a2f35dc9a93
Tom Dale + Yehuda Katz
Tom Dale
Don’t implicitly create new run loop in render
don’t implicitly create new run loop in render
46
false
false
8
false
false
false
emberjs
ember.js
12,968
d426429812f587c3765bc84a724f3cdc43313b25
Tom Dale
Tom Dale
Disable didInsertElement hook in node tests
disable didinsertelement hook in node tests
43
false
false
6
false
true
false
emberjs
ember.js
12,969
0da23610bdfbe82bb046a0db6e9222fd58501693
Tom Dale
Tom Dale
Explicit “renderToElement” API The previous Node rendering tests were fairly brittle due to them faking out a Morph and overriding Ember.View’s `_morph` property. Indeed, this was just a short-term hack and the actual FastBoot API departed from it. Because of that, the recent outlet refactor broke the FastBoot implementation because it changed the application’s root view to be tag-less, breaking the assumption that the root view would always have an element. This commit makes explicit the API for rendering an an application’s view hierarchy into an element detached from the document’s body. In particular, the implementation of `appendTo` relied on jQuery to normalize selectors into elements. In FastBoot, jQuery is not available. Instead, we introduce a new `renderToElement` method that creates a new, detached `body` element and instructs Ember to render the view inside that element. Once rendering is complete, the `body` element is returned. Hopefully by making these APIs more explicit, we can ensure future commits do not break FastBoot rendering.
explicit “rendertoelement” api
30
false
false
3
false
false
false
emberjs
ember.js
12,970
4083e29164baa9ea9e74874c1483b462aedeaef4
Stefan Penner
Stefan Penner
Merge pull request #10592 from MajorBreakfast/master jspm support
merge pull request from majorbreakfast/master
46
true
false
5
true
true
false
emberjs
ember.js
12,971
141e94131eb1ff3bba0afc6a4a4a317f17b0c17e
Josef Reinhard Brandl
Josef Reinhard Brandl
jspm support
jspm support
12
false
false
2
false
false
false
emberjs
ember.js
12,972
aad7da62dfc51d031d86358388b458976cae19a2
Matthew Beale
Matthew Beale
Merge pull request #10588 from mixonic/contrib Bump fiddle
merge pull request from mixonic/contrib
40
true
false
5
true
false
false
emberjs
ember.js
12,973
0f18303f0c43d3fe2852351b41e305a6c977a6da
Matthew Beale
Matthew Beale
Bump fiddle
bump fiddle
11
true
false
2
true
true
false
emberjs
ember.js
12,974
f405cbd00e7670254dc76d12379df90bc76b512c
Robert Jackson
Robert Jackson
Merge pull request #3852 from mixonic/get [BREAKING BUGFIX] Do not assume null Ember.get targets are all globals
merge pull request from mixonic/get
36
true
false
5
true
false
false
emberjs
ember.js
12,975
b5b8d192d5b3ff702ee6006bf016b372e314a086
Robert Jackson
Robert Jackson
Merge pull request #10585 from wagenet/deprecate-core-view Deprecate direct use of CoreView
merge pull request from wagenet/deprecate-core-view
52
true
false
5
true
false
false
emberjs
ember.js
12,976
1a3dde2ef03a63db1bb0e5b41fad57f0744fc438
Matthew Beale
Matthew Beale
[BREAKING BUGFIX] Do not assume null Ember.get targets are all globals * Changes globals to only mean properties starting with $ or a capital letter. * Changes normalizeTuple(obj, 'Foo') to resolve Foo as a global. This makes the behavior consistent with normalizeTuple(obj, 'Foo.bar') which already resolves Foo as a global (and looks up bar). * Changes normalizeTuple(null, 'Foo') to resolve Foo as a global. * Specs normalizeTuple('null', 'foo') to resolve to [undefined, '']. This is unfortunate but needed to keep getPath happy. This code is old, and tricky to modify due to perf optimizations and edge case behavior. It would be great to refactor more heavily at some other date. I've spec'd out more of the current behavior and edge cases in this commit. Fixes #3760
[breaking bugfix] do not assume null ember.get targets are all globals
70
false
false
11
false
false
false
emberjs
ember.js
12,977
c6747547f5c1f73c64167c443e633c31867b2172
Peter Wagenet
Peter Wagenet
Deprecate direct use of CoreView
deprecate direct use of coreview
32
false
false
5
true
true
true
emberjs
ember.js
12,978
730fb0c767182ed5be7e597e4b2bc99627894495
Peter Wagenet
Peter Wagenet
Merge pull request #10509 from mnutt/update-query-param-arg-docs [DOC] update query param docs to add 'as' key
merge pull request from mnutt/update-query-param-arg-docs
58
true
false
5
true
false
false
emberjs
ember.js
12,979
37b88c9eb6489c50a8fc2a3eaa93d0ffb81ec8b9
Trek Glowacki
Trek Glowacki
Merge pull request #10576 from amiel/revert-10575-revert-10570-docs-update-generate-docs Revert "Revert "[DOC release] Remove obsolete instructions for building ...
merge pull request from amiel/revert-10575-revert-10570-docs-update-generate-docs
82
true
false
5
true
false
false
emberjs
ember.js
12,980
3388182916b7fd7056a0441d5c6f569dd48fcf5b
Amiel Martin
Amiel Martin
Revert "Revert "[DOC release] Remove obsolete instructions for building API docu..."
revert "revert "[doc release] remove obsolete instructions for building api docu..."
84
false
false
11
false
false
false
emberjs
ember.js
12,981
83c59d07f5fea85aef9ec96e1efcd28a61d7e1c0
Trek Glowacki
Trek Glowacki
Merge pull request #10575 from emberjs/revert-10570-docs-update-generate-docs Revert "[DOC release] Remove obsolete instructions for building API docu...
merge pull request from emberjs/revert-10570-docs-update-generate-docs
71
true
false
5
true
false
false
emberjs
ember.js
12,982
e9936433f13266cf6e2f6cc40d2701f4f5fbc646
Trek Glowacki
Trek Glowacki
Revert "[DOC release] Remove obsolete instructions for building API documentation"
revert "[doc release] remove obsolete instructions for building api documentation"
82
false
false
10
false
true
false
emberjs
ember.js
12,983
c10362b973f7b311115eafd39fa2b01deb4561ed
Tom Dale
Tom Dale
Merge pull request #10483 from emberjs/lazy-location [REFACTOR] Lazily reify router’s location
merge pull request from emberjs/lazy-location
46
true
false
5
true
true
false
emberjs
ember.js
12,984
5b142bc1c3ec81c5993704d6b4294d47d6b1179c
Elad Shahar
Elad Shahar
Update bower.json Update router.js to address issue with UnrecognizedURLError Fixes ember-cli/ember-cli#3416
update bower.json
17
false
false
2
true
false
false
emberjs
ember.js
12,985
d9752a081cf7868a87419e8d018db78db62cc612
Stefan Penner
Stefan Penner
Merge pull request #10570 from amiel/docs-update-generate-docs [DOC release] Remove obsolete instructions for building API documentation
merge pull request from amiel/docs-update-generate-docs
56
true
false
5
true
false
false
emberjs
ember.js
12,986
2e9973d314e54ae072578e058ed23392f2848310
Amiel Martin
Amiel Martin
[DOC release] Remove obsolete instructions for building API documentation
[doc release] remove obsolete instructions for building api documentation
73
false
false
9
false
false
false
emberjs
ember.js
12,987
bf3d5eb40deef35cac14f69a06557826240cb230
Tom Dale + Yehuda Katz
Tom Dale
Properly override location in visit()
properly override location in visit()
37
false
false
5
false
false
false
emberjs
ember.js
12,988
91cda570a3e991605d0bb69161338766805e368e
Tom Dale + Yehuda Katz
Tom Dale
Make router CP read-only
make router cp read-only
24
false
false
4
false
false
false
emberjs
ember.js
12,989
8e130e52089d01d0110137bb67b11758d67e0f16
Tom Dale + Yehuda Katz
Tom Dale
Lazily reify router’s location Users can override a router’s location by specifying its `location` property as a string. For example, to change the router from the “auto” location to the “none” location, users can do the following: ```js // app/router.js export default Ember.Router.extend({ location: 'none' }); ``` Previously, the reification of the string value into a concrete Location implementation happened at router creation time. This immediate reification made it difficult to make changes to the router configuration, since it had to be done at creation time. In general, classes that require configuration to be set at creation time are unwieldy to use with the container, since the container itself manages creation. For example, in the case of the Application's `visit()` API, the application instance would like to override the router to use the `none` location. When reification was at creation time, the router was created with the wrong location. Before the default could be overridden, the router would try to set up things like listeners on the browser's address bar, which would cause an exception to be thrown in Node environments where there is no notion of a URL. In this commit, reifying and setting up the location are deferred until the last possible moment, when routing starts (either by calling `startRouting()`, which starts the app at the browser's current URL, or by calling `handleURL()`, which starts the app at a provided URL). This allows the application to detect if it is in autoboot mode or not, and override the router's location before routing begins.
lazily reify router’s location
30
false
false
4
false
false
false
emberjs
ember.js
12,990
2638767618a0d65c898694013ba7dc4965790f4e
Robert Jackson
Robert Jackson
Merge pull request #10556 from rwjblue/deprecate-link-to-unwrapping [BUGFIX beta] Deprecate `{{link-to}}` unwrapping a controllers model.
merge pull request from rwjblue/deprecate-link-to-unwrapping
61
true
false
5
true
false
false
emberjs
ember.js
12,991
f64f214552dde3f7b853504766040af701e29302
Robert Jackson
Robert Jackson
[BUGFIX beta] Deprecate `{{link-to}}` unwrapping a controllers model.
[bugfix beta] deprecate `{{link-to}}` unwrapping a controllers model
68
false
false
8
false
false
false
emberjs
ember.js
12,992
3c0daeabb558b652aeb90620acdfbde92af4d64b
Robert Jackson
Robert Jackson
Merge pull request #10554 from rwjblue/undefined-this-in-helpers [BUGFIX beta] Remove access to `this` in HTMLBars helpers.
merge pull request from rwjblue/undefined-this-in-helpers
58
true
false
5
true
false
false
emberjs
ember.js
12,993
5d6353ac51fcdb113eab3e37ee990a4f947d4b74
Robert Jackson
Robert Jackson
[BUGFIX beta] Remove access to `this` in HTMLBars helpers. The value of `this` in a helper has changed at least twice (likely more). This updates the HTMLBars hooks to call each helper with an `undefined` context. The main purpose of this is to pave the way for another refactoring of the view + helper layer that uses `this` for a different purpose. To fix any usages of `this` in a helper, you can access the `view` from `env.data.view` instead.
[bugfix beta] remove access to `this` in htmlbars helpers
57
false
false
9
false
false
false
emberjs
ember.js
12,994
72f1bc47a8caac9a965f63afa5a24575f9853476
Robert Jackson
Robert Jackson
Merge pull request #10552 from coleww/patch-2 [DOC] fix generated href in link-to documentation
merge pull request from coleww/patch-2
39
true
false
5
true
false
false
emberjs
ember.js
12,995
b10fee826aacf131a7dde48c16912e030bac5266
Martin Muñoz
Martin Muñoz
Merge pull request #10553 from rwjblue/link-to-inline [BUGFIX release] Ensure that inline {{link-to}} does not cause a crash.
merge pull request from rwjblue/link-to-inline
47
true
false
5
true
false
false
emberjs
ember.js
12,996
4c3290502829d547ee5aba1d9dc236ec741213f5
Robert Jackson
Robert Jackson
[BUGFIX release] Ensure that inline {{link-to}} does not cause a crash.
[bugfix release] ensure that inline {{link-to}} does not cause a crash
70
false
false
11
false
false
false
emberjs
ember.js
12,997
d59953481e32e8a2ad501631f0983a2cab615dad
Cole Willsea
Cole Willsea
[DOC] fix generated href in link-to documentation makes the generated href match the router path
[doc] fix generated href in link-to documentation
49
false
false
7
false
false
false
emberjs
ember.js
12,998
673e2027dffe0a6da14c604be0abd0db45a241ab
Robert Jackson
Robert Jackson
Merge pull request #10550 from rwjblue/ensure-that-attrs-are-written-at-least-once [BUGFIX beta] Ensure that AttrNode's for value are rendered at least once.
merge pull request from rwjblue/ensure-that-attrs-are-written-at-least-once
76
true
false
5
true
false
false
emberjs
ember.js
12,999