Split (1)

train · 669k rows

sha stringlengths 1 40	author stringlengths 1 63 ⌀	committer stringlengths 1 41 ⌀	message stringlengths 1 65.5k ⌀	subject stringlengths 1 5.64k ⌀	subject_length float64 1 5.64k ⌀	is_chore bool 2 classes	is_bot bool 2 classes	subject_word_count float64 1 806 ⌀	verb_object_spacy bool 2 classes	verb_object_stanza bool 2 classes	fits_requirements bool 2 classes	owner stringlengths 2 15	repo stringlengths 2 21	__index_level_0__ int64 0 85.4k
992f4afad11c479e3a1c022db46ae74cf4e5ab94	Tom Dale and Yehuda Katz	Tilde Engineering	Rerender {{with}} when param changes	rerender {{with}} when param changes	36	false	false	5	false	true	false	emberjs	ember.js	12,700
ef7f4f016df37ef055940f281f453a038937ac35	Robert Jackson	Robert Jackson	Merge pull request #10813 from rwjblue/fix-compat-helper [BUGFIX release] Fix Ember.Handlebars comaptible helpers.	merge pull request from rwjblue/fix-compat-helper	50	true	false	5	true	false	false	emberjs	ember.js	12,701
0640d468335722088c2cecb3c0068c41248ea950	Robert Jackson	Robert Jackson	[BUGFIX release] Ensure `options.inverse` can be called in a compat helper.	[bugfix release] ensure `options.inverse` can be called in a compat helper	74	false	false	11	false	false	false	emberjs	ember.js	12,702
ed54cda663c74a9dcbfd99087ae79aa23d87d6cb	Robert Jackson	Robert Jackson	[BUGFIX release] Ensure `options.fn` can be called in a compat helper.	[bugfix release] ensure `options.fn` can be called in a compat helper	69	false	false	11	false	false	false	emberjs	ember.js	12,703
d6962481a13715f315c38d2232efeca980a78123	Robert Jackson	Robert Jackson	Merge pull request #10750 from mixonic/dep-stuff Deprecation cleanup (push block params, change CP url)	merge pull request from mixonic/dep-stuff	42	true	false	5	true	false	false	emberjs	ember.js	12,704
7fabf72eebc55666297324929e1bd84313e5dc3a	Matthew Beale	Matthew Beale	Update context-switching deprecations to point at block params syntax	update context-switching deprecations to point at block params syntax	69	false	false	9	false	false	false	emberjs	ember.js	12,705
8f13acfc83c55d629371f25cd0e6b005ccfa6c91	Estelle DeBlois	Estelle DeBlois	[FEATURE ember-application-instance-initializers] Deprecation is never thrown on lookup/lookupFactory The deprecation is never thrown when calling `lookup` or `lookupFactory` on a registry because `Ember.deprecate` is called with an options argument but no deprecation test (the options argument is incorrectly interpre...	[feature ember-application-instance-initializers] deprecation is never thrown on lookup/lookupfactory	101	false	false	8	false	false	false	emberjs	ember.js	12,706
6d171bb4bbc854931ce6838eba0d70667573472a	Matthew Beale	Tilde Engineering	Port getViewClientRects, getViewboundingClientRect to Glimmer	port getviewclientrects, getviewboundingclientrect to glimmer	61	false	false	5	false	false	false	emberjs	ember.js	12,707
df2e6a9e3785cd86991a4cff94ce1160a752b411	Matthew Beale	Tilde Engineering	Reenable tests related to undefined/null attr values	reenable tests related to undefined/null attr values	52	false	false	7	false	false	false	emberjs	ember.js	12,708
a1bff0683604ee321f5acc10ea03d9d05ded0645	Matthew Beale	Tilde Engineering	Drop tests for removed isVirtual behaviors	drop tests for removed isvirtual behaviors	42	false	false	6	true	true	true	emberjs	ember.js	12,709
2dd00930d3e7b64346a18f7b11939bda72646578	Tom Dale and Yehuda Katz	Tilde Engineering	Fix rebase conflicts and get tests passing	fix rebase conflicts and get tests passing	42	false	false	7	true	true	true	emberjs	ember.js	12,710
f6640d7da59bc234617b233886de6783ab0b1228	Robert Jackson	Tilde Engineering	Update HTMLBars to v0.12.0. No longer requires `npm link` for HTMLBars.	update htmlbars to v0.12.0	26	false	false	4	true	true	true	emberjs	ember.js	12,711
f23f4cd8bbf603ecbc67ff3b355576894614d722	Martin Muñoz	Tilde Engineering	Bump htmlbars version	bump htmlbars version	21	true	false	3	true	true	false	emberjs	ember.js	12,712
9ba35a636d9d2252f7390fd01ae3a19a89a9e256	Martin Muñoz	Tilde Engineering	Get action keyword mostly working	get action keyword mostly working	33	false	false	5	false	true	false	emberjs	ember.js	12,713
72bbc6fa00df64e54659e7892758eef853f89916	Yehuda Katz	Tilde Engineering	Get more tests passing	get more tests passing	22	false	false	4	false	true	false	emberjs	ember.js	12,714
0346b9bfe8b5a94480f0027eddf7887f8896b8fb	Martin Muñoz	Tilde Engineering	Mark 3 regressions as skipped	mark 3 regressions as skipped	29	false	false	5	true	true	true	emberjs	ember.js	12,715
3e61a6ac9750cdc428f57b6dafb4277533a4f41a	Martin Muñoz	Tilde Engineering	Fix style errors	fix style errors	16	false	false	3	true	true	true	emberjs	ember.js	12,716
c7ab85c1870600b64fa321e74be7d96344d92817	Yehuda Katz	Tilde Engineering	Get more tests passing	get more tests passing	22	false	false	4	false	true	false	emberjs	ember.js	12,717
4d2e7757c9be1f91396793ffcf7625c81139324b	Yehuda Katz	Tilde Engineering	Left off a bunch of new files	left off a bunch of new files	29	false	false	7	false	false	false	emberjs	ember.js	12,718
ef9d51e7bc5ef9d0aa35ea53fd9fef8de574f17d	Yehuda Katz	Tilde Engineering	Got 75 more tests passing in ember-htmlbars	got 75 more tests passing in ember-htmlbars	43	false	false	7	false	false	false	emberjs	ember.js	12,719
f9bb21a37ad853dc19a41dded30cbb88af8e4ac9	Tom Dale and Yehuda Katz	Tilde Engineering	Helper for finding pending tests that now pass	helper for finding pending tests that now pass	46	false	false	8	false	false	false	emberjs	ember.js	12,720
f39428f49d8f05a5a709033547f209f5ee8ecda5	Tom Dale and Yehuda Katz	Tilde Engineering	Unpend passing collection tests	unpend passing collection tests	31	false	false	4	false	false	false	emberjs	ember.js	12,721
d65c7cb8e7c35f2f241f5c0db2bff32d946bcb21	Tom Dale and Yehuda Katz	Tilde Engineering	Implement {{collection}} helper	implement {{collection}} helper	31	false	false	3	false	true	false	emberjs	ember.js	12,722
907910fb29ea62b87adc2055e09df93691b853fd	Tom Dale and Yehuda Katz	Tilde Engineering	Take machete to inBuffer state	take machete to inbuffer state	30	false	false	5	true	true	true	emberjs	ember.js	12,723
b504a0065c66caf52bf8f2a239a7dacf95d2ede2	Tom Dale and Yehuda Katz	Tilde Engineering	Attrs, scope and view destruction cleanup This commit fixes several edge cases in how scope was managed in templates, how attrs are looked up, and how views are cleaned up, particularly the willDestroyElement user hook.	attrs, scope and view destruction cleanup	41	false	false	6	false	false	false	emberjs	ember.js	12,724
22c7c6a90a4427f383d87d09f617a8f7f5a89423	Tom Dale and Yehuda Katz	Tilde Engineering	Made more {{#view}} tests pass	made more {{#view}} tests pass	30	false	false	5	false	false	false	emberjs	ember.js	12,725
5b395543ae0047adc809b49ac3a6ae5cf7e241d1	Tom Dale and Yehuda Katz	Tilde Engineering	Implement ContainerView and CollectionView The majority of this commit removes very legacy code from the CollectionView tests, which was all that was needed to get most of them working. Because CollectionView is a thin layer on top of ContainerView, once ContainerView was passing, CollectionView came with it. The onl...	implement containerview and collectionview	42	false	false	4	true	true	true	emberjs	ember.js	12,726
586f56bc0a6c5f94cc8885b4343acd98ed3dfe61	Martin Muñoz	Tilde Engineering	Skip remaining failing tests	skip remaining failing tests	28	false	false	4	true	true	true	emberjs	ember.js	12,727
b1470249b4eaf257fa074f0d4fa052f980653ca4	Martin Muñoz	Tilde Engineering	Fix style errors	fix style errors	16	false	false	3	true	true	true	emberjs	ember.js	12,728
14c677d65ceb8f183f00126715104064de518a1c	Tom Dale and Yehuda Katz	Tilde Engineering	Fix ContainerView scoping issue	fix containerview scoping issue	31	false	false	4	false	true	false	emberjs	ember.js	12,729
87e88163f951ba1d9e1d072acc013a634e02b807	Tom Dale and Yehuda Katz	Tilde Engineering	Initial support for stream labels As of this commit, all streams must have labels, which automatically propagate through composition. If we ever turn streams into a public API, we might want to relax this restriction, but as they are currently internal only, it is worth the effort to ensure that there is always a good...	initial support for stream labels	33	false	false	5	false	false	false	emberjs	ember.js	12,730
945b276531596807b7fa64e54a4644e96dacf63e	Tom Dale and Yehuda Katz	Tilde Engineering	A bunch of previously skipped tests are passing	a bunch of previously skipped tests are passing	47	false	false	8	false	false	false	emberjs	ember.js	12,731
9c7c1721318731b9101b5da3151e6ecf5c9c8552	Tom Dale and Yehuda Katz	Tilde Engineering	More ContainerView cleanup In particular, we now assert that views are not scheduled to revalidate from inside a lifecycle hook (didInsertElement or didUpdate). Doing so is a tremendous performance foot gun, and it is too easy for even experienced developers to cause cycles that destroy performance.	more containerview cleanup	26	false	false	3	false	false	false	emberjs	ember.js	12,732
281c7a27601cb96858fbf07a5a7d3939be55fe56	Tom Dale and Yehuda Katz	Tilde Engineering	Cleanup view destruction This commit improves how view destruction works in Glimmer. In particular, we had to carefully thread the needle between good performance and hewing to the semantics of older Ember 1.x apps. Previously, calling `destroy()` on a view would cause it to recursively walk its child view hierarchy ...	cleanup view destruction	24	false	false	3	false	false	false	emberjs	ember.js	12,733
de46297b360edbc8507f53dbdb124d15943c0a82	Matthew Beale	Tilde Engineering	Drop comma	drop comma	10	false	false	2	true	true	false	emberjs	ember.js	12,734
890ef0335c0941c94697f58b6b1f10463f1e7a64	Tom Dale and Yehuda Katz	Tilde Engineering	Remove unneeded code As part of our “Project Svelte” initiative, this commit takes a machete to code that is no longer needed after the Glimmer integration.	remove unneeded code	20	false	false	3	true	true	true	emberjs	ember.js	12,735
3aea201274e8d539c7c509896983960ba65d2a7e	Tom Dale and Yehuda Katz	Tilde Engineering	WIP on Glimmer-compatible ContainerView This commit represents a day of work on porting ContainerView to the new rendering engine. The basic functionality is extremely simple: we model a ContainerView as a simple templated view that `each`’s over its child views and renders them via a `view` helper. This commit also...	wip on glimmer-compatible containerview	39	false	false	4	false	false	false	emberjs	ember.js	12,736
a4e903bde4e0733de3e7408971484b3e5b4b081b	Tom Dale and Yehuda Katz	Tilde Engineering	Fall back to template if layout not available	fall back to template if layout not available	45	false	false	8	false	false	false	emberjs	ember.js	12,737
bc102305f8ffa40c7d60dd8e1c3c01d5b4a1bcf3	Tom Dale and Yehuda Katz	Tilde Engineering	Update to concise methods	update to concise methods	25	false	false	4	false	false	false	emberjs	ember.js	12,738
88c93e3c08e8bb8aca8517813fbd21045dd5b4b8	Tom Dale and Yehuda Katz	Tilde Engineering	Skip new failing tests after rebase	skip new failing tests after rebase	35	false	false	6	true	true	true	emberjs	ember.js	12,739
3a90910e7ffe5ca80d6d36837801fb41eddacb09	Tom Dale and Yehuda Katz	Tilde Engineering	Skip all failing tests In order to ensure that we do not cause regressions as we continue to work, we have marked all existing failing tests with `QUnit.skip`.	skip all failing tests	22	false	false	4	true	true	true	emberjs	ember.js	12,740
e6f3174433074b0ebc60f4d16fad6c25154ae03f	Tom Dale and Yehuda Katz	Tilde Engineering	Initial implementation of {{input}} All {{input}} tests pass, including ones that rely on bindings. This commit restores `attributeBindings` as a concatenated property, which was inadvertently removed in a previous cleanup.	initial implementation of {{input}}	35	false	false	4	false	false	false	emberjs	ember.js	12,741
6eece17a520d3d9e889e227cb1b08cde0454324b	Yehuda Katz	Tilde Engineering	Use improved child env support	use improved child env support	30	false	false	5	false	true	false	emberjs	ember.js	12,742
a0e85833a7438279ccd1a99dea3e8d6f78440d06	Yehuda Katz	Tilde Engineering	Make better use of the built-in stability check	make better use of the built-in stability check	47	false	false	8	true	true	true	emberjs	ember.js	12,743
13ff979099826cf89838776b4fd110559609e6c3	Yehuda Katz	Tilde Engineering	Create an Ember subclass of Morph This allows us to store general-purpose internal needs of Ember on the morph itself, leaving the remaining morph's state available to be diffed for `isStable` checks.	create an ember subclass of morph	33	false	false	6	true	true	true	emberjs	ember.js	12,744
8eebe7435d1f2edbd252686d34617773cbf3954c	Martin Muñoz	Tilde Engineering	Fix style errors	fix style errors	16	false	false	3	true	true	true	emberjs	ember.js	12,745
244ad0ff8e36f7927e6a22011f0bbce1dde7e217	Martin Muñoz	Tilde Engineering	Reimplement loc helper	reimplement loc helper	22	false	false	3	false	false	false	emberjs	ember.js	12,746
ac8f1064811c863cf0ca12e50cbc1bdca4c80afa	Martin Muñoz	Tilde Engineering	Rewrite each...in AST transform to use block params	rewrite each...in ast transform to use block params	51	false	false	8	true	true	false	emberjs	ember.js	12,747
f529ab6b85fc279cfd3eb54c31b5686c96494304	Tom Dale and Yehuda Katz	Tilde Engineering	Implement bound partial semantics Included in this commit: a change that differentiates between a render node that is being cleared and one that is being destroyed. A render node being cleared will want to tear down any associated components, while a node being destroyed will also want to unsubscribe from linked param...	implement bound partial semantics	33	false	false	4	true	true	true	emberjs	ember.js	12,748
a82291a8b484236215623b6ecd77b50494184e1f	Tom Dale and Yehuda Katz	Tilde Engineering	Fix context-switching #each	fix context-switching #each	27	false	false	3	true	false	true	emberjs	ember.js	12,749
e636e8b5c99535cb8188d79adbdbdb025323e935	Tom Dale and Yehuda Katz	Tilde Engineering	Make more legacy helper tests pass	make more legacy helper tests pass	34	false	false	6	false	false	false	emberjs	ember.js	12,750
0d0c17d669983fb14f67de1af551d434b698f4ca	Martin Muñoz	Tilde Engineering	Remove global stream memoization to fix more tests Memoizing into a local variable doesn't work well the tests since the tests mutate the value of the global. In theory we could define a test helper to work around this, but it doesn't seem like its worth the effort since this path is deprecated and has a simple upgrad...	remove global stream memoization to fix more tests	50	false	false	8	false	true	false	emberjs	ember.js	12,751
0f09b6d79e4a387cc600dac8e82db5061c86da87	Martin Muñoz	Tilde Engineering	Add support for binding to global paths	add support for binding to global paths	39	false	false	7	true	true	true	emberjs	ember.js	12,752
c3749561a5025d55a78a28d4e23f7e08c3d2ba1b	Tom Dale and Yehuda Katz	Tilde Engineering	Compatibility with legacy Handlebars helpers This commit makes use of the new `invokeHelper` hook in Handlebars to invoke helpers created with `Handlebars.registerHelper` with the correct parameters that they were expecting. The TLDR is that legacy (original generation) Handlebars helpers expect to receive their para...	compatibility with legacy handlebars helpers	44	false	false	5	false	false	false	emberjs	ember.js	12,753
f7513aff1c72ad03c1d2d411cf4f06a00d450eeb	Tom Dale and Yehuda Katz	Tilde Engineering	Implement more functionality * view.createElement * view.replaceIn * deprecated {{linkTo}} * fix active state when route transitions	implement more functionality	28	false	false	3	true	true	true	emberjs	ember.js	12,754
64c85fddb9cee6e88f46f40069eff5b67fd73adb	Tilde Engineering	Tilde Engineering	Make sure that if any outlets dirty, they all do The outlet peeling logic requires that if any outlet becomes dirty, all of its parent outlets are dirtied as well. These dirty parents will ensure that the outlet state is properly propagated, but the stability check will still ensure that unnecessary work is avoided.	make sure that if any outlets dirty, they all do	48	false	false	10	false	false	false	emberjs	ember.js	12,755
dfacc67ac805c5d23ab2152083cc1dc610bb14a5	Tilde Engineering	Tilde Engineering	yielded content should not see parent `view`.	yielded content should not see parent `view`	44	false	false	7	false	false	false	emberjs	ember.js	12,756
36b5515e1aaa3a32750929d773553a82e74b8350	Martin Muñoz	Tilde Engineering	Add some more KeyStream tests	add some more keystream tests	29	false	false	5	false	true	false	emberjs	ember.js	12,757
ae87fc90ca0b925e0ec3260466aeb71fc5850b08	Tilde Engineering	Tilde Engineering	Implement loading states for LinkView	implement loading states for linkview	37	false	false	5	true	true	true	emberjs	ember.js	12,758
b4d454eb9e5317b4bed875e44228f58a4b424781	Tilde Engineering	Tilde Engineering	Refactor ComponentNode	refactor componentnode	22	false	false	2	false	false	false	emberjs	ember.js	12,759
f75b2e11955e0eb84af08039d90cdf1203465494	Tilde Engineering	Tilde Engineering	Unify component creation Previously, we had in place three different methods for inserting views or components into the render hierarchy. Top-level views went through a legacy path that used RenderBuffer. Outlet’s went through our abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top- level components we...	unify component creation	24	false	false	3	true	true	true	emberjs	ember.js	12,760
7cff945c04bf66b0c621b6b70042c51d8a5b2cdf	Tom Dale and Yehuda Katz	Tilde Engineering	Introduce routing service This commit introduces a new routing service, so that we can decouple `LinkView` from knowing about the actual router’s internals. Before this commit, LinkView tried to find the router off of its controller, and looked up the application controller to get current router state. This commit cr...	introduce routing service	25	false	false	3	true	true	true	emberjs	ember.js	12,761
93d42e327425a9ae776fe200469b3048d47ef63d	Martin Muñoz	Tilde Engineering	Update linkRenderNode signature	update linkrendernode signature	31	false	false	3	true	true	true	emberjs	ember.js	12,762
dc5590e6bb7b3008e11d6db77f43d597346ebc7d	Martin Muñoz	Tilde Engineering	Deprecate bind-attr helper - Use an HTMLBars AST transform to rewrite bind-attr helpers to normal attribute bindings. - Introduce a private bind-attr-class helper to support the dasherizing behaviour of bind-attr with the class attribute. - Deprecate bind-attr and move the bind-attr/bindAttr deprecations to co...	deprecate bind-attr helper	26	false	false	3	false	false	false	emberjs	ember.js	12,763
7bb4a5bb8339c0aa0db9afe707989a6fd4aecef7	Martin Muñoz	Tilde Engineering	Fix some bugs in KeyStream	fix some bugs in keystream	26	false	false	5	true	true	true	emberjs	ember.js	12,764
b3f592aa6c605d7e12f2f009eb3bdb1aaae8b36d	Martin Muñoz	Tilde Engineering	Add KeyStream tests	add keystream tests	19	false	false	3	true	true	true	emberjs	ember.js	12,765
9620f8fc5f1c37d19f9783af3661b69cfb245560	Martin Muñoz	Tilde Engineering	Begin cleaning up stream tests - Add basic tests for KeyStream and fix some basic behaviour around computing the value while the stream is in the inactive state. - Drop irrelevant stream tests from ember-views	begin cleaning up stream tests	30	false	false	5	false	false	false	emberjs	ember.js	12,766
40c8848acbeefdeb25e951eed585fda3589dd22e	Martin Muñoz	Tilde Engineering	Some stream cleanup - Move KeyStream to ember-metal - Rename valueFn to compute - Move ember-metal/streams/simple to ember-metal/streams/simple-stream	some stream cleanup	19	false	false	3	false	false	false	emberjs	ember.js	12,767
f689553d3d14c3969693d53414def2a0d06e9220	Martin Muñoz	Tilde Engineering	Remove unused stream support from ember-views	remove unused stream support from ember-views	45	false	false	6	false	true	false	emberjs	ember.js	12,768
a62212b6bcab9d66a2db535a870ee35338464346	Yehuda Katz	Tilde Engineering	A more plausible impl of KeyStream	a more plausible impl of keystream	34	false	false	6	false	false	false	emberjs	ember.js	12,769
426d6fd48a59346f7c648c5419fb8c388d4b5a61	Yehuda Katz	Tilde Engineering	Revert "WIP perf work" This reverts commit f8174038f166c4f3d044673dfc865870fdbd26c1.	revert "wip perf work"	22	false	false	4	false	false	false	emberjs	ember.js	12,770
699c547e5a20b1c13e047b2e5e25ed7265bd9bf4	Yehuda Katz	Tilde Engineering	Remove unnecessary stream revalidate()	remove unnecessary stream revalidate()	38	false	false	4	false	true	false	emberjs	ember.js	12,771
916f32d378022b90ad6f890a5d71d310d4fa19a8	Kris Selden	Tilde Engineering	WIP perf work	wip perf work	13	false	false	3	false	false	false	emberjs	ember.js	12,772
85404493f1400cb98621a794534459609bc9d0e3	Tom Dale and Yehuda Katz	Tilde Engineering	Attribute bindings use manualElement Instead of adding a new system for dealing with attribute bindings, take Ember’s APIs and convert them into a list of attribute statements suitable for consumption by HTMLBars. Then, construct an HTMLBars `manualElement`, passing in the dynamically constructed attributes. We also ...	attribute bindings use manualelement	36	false	false	4	false	true	false	emberjs	ember.js	12,773
39a2a964cb6689511f83fb74e9a102727160e447	Tilde Engineering	Tilde Engineering	bindScope now takes an env	bindscope now takes an env	26	false	false	5	false	false	false	emberjs	ember.js	12,774
ee865c24317d2f48b4ae8fa0d01a9c476801d5dd	Tilde Engineering	Tilde Engineering	Remove rebase error	remove rebase error	19	false	false	3	true	true	true	emberjs	ember.js	12,775
189f07b0120bd0279aabc66357b66665bc7167e1	Tilde Engineering	Tilde Engineering	Improve “real app” booting This is a series of improvements made to get Skylight booting on this branch: * Implement the new version of `makeBoundHelper` semantics and the param `apply`ing behavior of `Handlebars.makeBoundHelper`. The dependent key behavior of `makeBoundHelper` is not yet implemented. * Implement...	improve “real app” booting	26	false	false	4	false	false	false	emberjs	ember.js	12,776
62763132922582c981efe7e6451b201a1c497da5	Tilde Engineering	Tilde Engineering	Fix stream bug	fix stream bug	14	false	false	3	false	true	false	emberjs	ember.js	12,777
6423461a20ecf6138908084a3ea849e9f6ff690c	Tom Dale and Yehuda Katz	Tilde Engineering	Invoke component lifecycle hooks predictably Previously, lifecycle hooks on components (e.g. `didInsertElement`) were invoked on components in an ad-hoc and unpredictable way. In this commit, we introduce the notion of two types of lifecycle hooks: 1. Immediately-dispatched hooks for teardown, which are invoked befo...	invoke component lifecycle hooks predictably	44	false	false	5	false	true	false	emberjs	ember.js	12,778
b869416b27ecd626bd8c26733bb57b1714762c8b	Tom Dale and Yehuda Katz	Tilde Engineering	Implement `{{component}}` helper	implement `{{component}}` helper	32	false	false	3	false	true	false	emberjs	ember.js	12,779
25368e52d1abbeac2355f03b1c8f98ad4afb9996	Tom Dale and Yehuda Katz	Tilde Engineering	Clean up how attrs are communicated through scope Previously, the code that allowed a component to propagate its attrs down the scope chain relied on several layers of indirection. Primarily, it used the `self` object to piggyback state through to `bindSelf`, where it could create and update stable streams that downst...	clean up how attrs are communicated through scope	49	false	false	8	false	false	false	emberjs	ember.js	12,780
739c5d5c33bb584dac2508bccf1556adcad0b94d	Tom Dale and Yehuda Katz	Tilde Engineering	Initial stab @ getting `with` + controller to work	initial stab @ getting `with` + controller to work	50	false	false	9	false	false	false	emberjs	ember.js	12,781
180856b5b6836f5cf95862ba02272722b064fc49	Tom Dale and Yehuda Katz	Tilde Engineering	Add an #each test	add an #each test	17	false	false	4	true	true	true	emberjs	ember.js	12,782
60a5851266c38c5eb587b8a13e2a01e7f179a4d2	Tom Dale and Yehuda Katz	Tilde Engineering	Fix stream bugs * actually unsubscribe from dependencies * make `chain` use a lazy dependency instead of triggering immediate consumption. * remove unused `notify` that was only delegating to the superclass	fix stream bugs	15	false	false	3	false	true	false	emberjs	ember.js	12,783
c4bccc80450462cbf6c03f7a93ebe218ad72aee2	Tom Dale and Yehuda Katz	Tilde Engineering	Utilize better host hooks in HTMLBars This also clarifies the responsibilities of ShadowRoot, extracting any notion of “components” into the parent ComponentNode and outlet keyword. Lastly, this commit greatly cleans up the passing of scope into shadow roots. In particular, the “hack” of using symbols to thread state...	utilize better host hooks in htmlbars	37	false	false	6	true	true	true	emberjs	ember.js	12,784
b492d0d680c31ac3a0db99640a4543e86d31caba	Tom Dale and Yehuda Katz	Tilde Engineering	More rigorous approach to stream stability This commit takes a more structured, less ad hoc approach to stream stability. In particular, the `bindSelf` hook is responsible for creating a stable set of stream “roots” at first render. On subsequent renders, those streams are simply updated in place, and if there are der...	more rigorous approach to stream stability	42	false	false	6	false	false	false	emberjs	ember.js	12,785
3ac557fdc2082b7be34f59c4df8d47ed1d942dea	Tom Dale and Yehuda Katz	Tilde Engineering	Implement barebones {{#each}} helper	implement barebones {{#each}} helper	36	false	false	4	false	true	false	emberjs	ember.js	12,786
d9c9f6003cb42013973fb9f4d50741dfe911eb4f	Tom Dale and Yehuda Katz	Tilde Engineering	Refactor shared view and component logic This commit moves most of the shared rendering logic for view and components into the `ComponentNode` object. This object was already used in the `component` hook, but it is now also used by the `view` keyword. This commit also changes the `view` keyword to use the new lifecyc...	refactor shared view and component logic	40	false	false	6	false	false	false	emberjs	ember.js	12,787
dedf26e1bc06df657f27fa774c9b44f7dad95f57	Tom Dale and Yehuda Katz	Tilde Engineering	Clean up code to use new keyword infrastructure	clean up code to use new keyword infrastructure	47	false	false	8	false	false	false	emberjs	ember.js	12,788
d22cf04434aea1ca5baa3509f1af2788e2aa890d	Tom Dale and Yehuda Katz	Tilde Engineering	[WIP] Outlets now work As of this commit, the primary functionality of outlets is working. The biggest change is that, instead of managing outlet changes in the view hierarchy, the `{{outlet}}` keyword is now responsible for determining what to do when rendering or revalidating. Thanks to @ef4’s previous work, the co...	[wip] outlets now work	22	false	false	4	false	false	false	emberjs	ember.js	12,789
a68a1c3cfa53a5b62dc4653a0bf83c2faea9eca6	Tom Dale and Yehuda Katz	Tilde Engineering	Refactor component hook to have a ShadowRoot	refactor component hook to have a shadowroot	44	false	false	7	false	false	false	emberjs	ember.js	12,790
9faf166fa07647a64018f49a7802a9b784cf1a7e	Tom Dale and Yehuda Katz	Tilde Engineering	[WIP] Implement willReceiveAttrs and other hooks This commit moves responsibility for lifecycle hooks on components into the renderer, and implements the `willReceiveAttrs` and `willUpdate` hooks. It also fixes some bugs where unnecessary rerendering was happening. Lastly, we implement the new HTMLBars hook `createF...	[wip] implement willreceiveattrs and other hooks	48	false	false	6	false	false	false	emberjs	ember.js	12,791
af8372f93173c85b2b19a6c8090fc03e0fa1ee20	Tom Dale and Yehuda Katz	Tilde Engineering	[WIP] Implement initial components The highlight of this commit is the `component_invocation_test`, which has started to have real functionality, including `component.attrs`, new lifecycle hooks, and the ability to re-render with stable nodes. These tests verify that observation correctly dirties the nodes and trigge...	[wip] implement initial components	34	false	false	4	false	false	false	emberjs	ember.js	12,792
816f252580e0e83d7453d6284a0741e99747fee3	Tom Dale and Yehuda Katz	Tilde Engineering	[WIP] Move view lifecycle management to HTMLBars Previously, the renderer was responsible for rendering top-level views and walking the view hierarchy, invoking lifecycle hooks. This commit changes the renderer to better cooperate with the new HTMLBars-driven semantics. In particular, we are moving towards a world w...	[wip] move view lifecycle management to htmlbars	48	false	false	7	false	false	false	emberjs	ember.js	12,793
e1f435517c4c73558e1a8d0d2ac228901e9af1c9	Tom Dale and Yehuda Katz	Tilde Engineering	[WIP] Continue progress on HTMLBars integration The highlight of this commit is that we now have an extremely rudimentary view helper. We also did a wide-ranging stream cleanup to allow streams to be destroyed via refcounting (from below) rather than always destroying from the top down. This allows a lot of sharing ...	[wip] continue progress on htmlbars integration	47	false	false	6	false	false	false	emberjs	ember.js	12,794
00bca5692811c228553b6874c6cd7488ce111a1e	Tom Dale and Yehuda Katz	Tilde Engineering	[WIP] Begin aggressive integration with HTMLBars This commit starts to integrate with the more aggressive HTMLBars changes. In particular, HTMLBars now takes more control over the rendering process, and delegates to Ember as it proceeds. Ember is responsible for managing the template scope, while HTMLBars is responsi...	[wip] begin aggressive integration with htmlbars	48	false	false	6	false	false	false	emberjs	ember.js	12,795
2449037756ef199ca5277c1fc898b0812f43171b	Tom Dale and Yehuda Katz	Tilde Engineering	Brings Ember up to date with reactive-rerendering To use this commit before the branch has merged to master, you must `npm link` the `reactive-rerendering` branch on `htmlbars`.	brings ember up to date with reactive-rerendering	49	false	false	7	false	false	false	emberjs	ember.js	12,796
0a02edd8a3fdf3591d9e39bbcb55f9b28c092da5	Robert Jackson	Robert Jackson	Merge pull request #10805 from emberjs/fix-router-regression [BUGFIX release] Correctly update URL after browser popstate	merge pull request from emberjs/fix-router-regression	54	true	false	5	true	false	false	emberjs	ember.js	12,797
a09f1440ba5cef825133c65ba2718ca1849710d5	Robert Jackson	Robert Jackson	Merge pull request #10795 from embersherpa/collection-view-fail [BUGFIX stable] Collection View with bound attributes throws an exception when content is changed	merge pull request from embersherpa/collection-view-fail	57	true	false	5	true	false	false	emberjs	ember.js	12,798
11b32a95d2b212243786af71ade259ad46f0c0e1	Tom Dale	Robert Jackson	[BUGFIX release] Correctly update URL after browser popstate This commit partially reverts 7afdc4108ba0ee7d239417a1ac97f8aab44016f7, which introduced a regression in the way HistoryLocation works. Prior to the above-mentioned commit, we would always consult the browser’s state stack when determining what the current ...	[bugfix release] correctly update url after browser popstate	60	false	false	8	false	false	false	emberjs	ember.js	12,799

Subsets and Splits

No community queries yet

The top public SQL queries from the community will appear here once available.