sha
stringlengths
1
40
author
stringlengths
1
63
committer
stringlengths
1
41
message
stringlengths
1
65.5k
subject
stringlengths
1
5.64k
subject_length
float64
1
5.64k
is_chore
bool
2 classes
is_bot
bool
2 classes
subject_word_count
float64
1
806
verb_object_spacy
bool
2 classes
verb_object_stanza
bool
2 classes
fits_requirements
bool
2 classes
owner
stringlengths
2
15
repo
stringlengths
2
21
__index_level_0__
int64
0
85.4k
a0e5394203d3f485c592c2d05d7d1a6b3cff6ced
Phillip Webb
Phillip Webb
Exclude stax test dependency Exclude transitive stax 1.0 dependency to prevent compile time eclipse errors.
exclude stax test dependency
28
false
false
4
true
true
true
spring-projects
spring-framework
19,357
18bf860c273179f95719d80b14d17c0c9ba99c38
Sam Brannen
Sam Brannen
Update Javadoc for MockMvc Deleted reference to the obsolete configureWarRootDir() method from the stand-alone spring-test-mvc project.
update javadoc for mockmvc
26
false
false
4
true
true
true
spring-projects
spring-framework
19,358
91da1383143bc15f945935960a79bc253bd1ce16
Rob Winch
Rob Winch
Use explicit JDK versions in aspects.gradle Previously aspects.gradle used the Gradle conventions for the source and target compatibility. This means that unless the conventions were updated the current JDK would be used for both source and target compatibilty. Since an update to build.gradle changed to configure the ...
use explicit jdk versions in aspects.gradle
43
false
false
6
true
true
true
spring-projects
spring-framework
19,359
2427391286f489e11981e1072aaebbf78dd5d3f7
Sam Brannen
Sam Brannen
Polish Javadoc in CookieValue and RequestHeader
polish javadoc in cookievalue and requestheader
47
false
false
6
false
false
false
spring-projects
spring-framework
19,360
ea823fd398d0a3030c477399a33074fc6c6acae6
Juergen Hoeller
Juergen Hoeller
AnnotationAwareOrderComparator etc
annotationawareordercomparator etc
34
false
false
2
false
false
false
spring-projects
spring-framework
19,361
e806c4eb3d5bd660c169e2b215a4e29b1f43bf35
Juergen Hoeller
unknown
AnnotationAwareOrderComparator is able to sort Class objects as well Issue: SPR-10152
annotationawareordercomparator is able to sort class objects as well
68
false
false
9
false
false
false
spring-projects
spring-framework
19,362
dae4485155096c1b9db1389fc90058c48d8e7906
Juergen Hoeller
unknown
Added dedicated sort method to AnnotationAwareOrderComparator Issue: SPR-9625
added dedicated sort method to annotationawareordercomparator
61
false
false
6
false
false
false
spring-projects
spring-framework
19,363
f6d7518013d97ed9f1edfa4c6b65065eafac445b
Juergen Hoeller
unknown
SpringContextResourceAdapter implements equals/hashCode according to the JCA 1.5 contract Issue: SPR-9162
springcontextresourceadapter implements equals/hashcode according to the jca 1.5 contract
89
false
false
9
false
false
false
spring-projects
spring-framework
19,364
5e8e901aba9abc55a9f3dedd0b5d5a0d8841357f
Juergen Hoeller
unknown
FreeMarkerConfigurationFactory properly supports TemplateLoaders when recreating Configurations Issue: SPR-9389
freemarkerconfigurationfactory properly supports templateloaders when recreating configurations
95
false
false
7
false
false
false
spring-projects
spring-framework
19,365
f8a7cf9f515f0d77fa515cec6af22ad1c8f2a58b
Juergen Hoeller
unknown
MimeMessageHelper encodes attachment filename if not ASCII compliant Issue: SPR-9258
mimemessagehelper encodes attachment filename if not ascii compliant
68
false
false
8
false
false
false
spring-projects
spring-framework
19,366
97ae403b53b5ca2402c5d651dfdc6295d6372735
Juergen Hoeller
unknown
AbstractAdvisingBeanPostProcessor caches per bean target class, working for null bean names as well Issue: SPR-10144
abstractadvisingbeanpostprocessor caches per bean target class, working for null bean names as well
99
false
false
13
false
false
false
spring-projects
spring-framework
19,367
3a9ca4a6bb8289b8495f22a9e60dc7799c93493b
Juergen Hoeller
unknown
MessageSourceResourceBundle overrides JDK 1.6 containsKey method, avoiding NPE in getKeys Issue: SPR-10136
messagesourceresourcebundle overrides jdk 1.6 containskey method, avoiding npe in getkeys
89
false
false
10
false
false
false
spring-projects
spring-framework
19,368
10dceb182e86fb79f6ad36a92d5f28088a319379
Juergen Hoeller
unknown
Marked LocalCacheProviderProxy as deprecated (following Hibernate 3.3.'s CacheProvider deprecation)
marked localcacheproviderproxy as deprecated (following hibernate 3.3.'s cacheprovider deprecation)
99
false
false
9
false
false
false
spring-projects
spring-framework
19,369
4ae9cf7cf11af1626cb5dd127c020c98507f8e7f
Sam Brannen
Sam Brannen
Ensure JUnit & TestNG tests run in spring-test Prior to this commit, the Gradle build configuration only executed TestNG-based tests and effectively disabled all JUnit-based tests in the spring-test module. Furthermore, TestNG-based tests were not properly reported in Bamboo CI builds. This commit ensures that both J...
ensure junit & testng tests run in spring-test
46
false
false
8
false
false
false
spring-projects
spring-framework
19,370
0b612d651ed0ffd4f87bde466316af3b8037d754
Phillip Webb
Phillip Webb
Merge branch 'cleanup-3.2.x' into 3.2.x * cleanup-3.2.x: Replace EasyMock with Mockito in spring-orm
merge branch 'cleanup-3.2.x' into 3.2.x
39
true
false
5
true
true
false
spring-projects
spring-framework
19,371
1386479d6c02ce48ee274f38291e66cf23ee1e8d
Phillip Webb
Phillip Webb
Merge branch 'SPR-10126' into cleanup-3.2.x * SPR-10126: Replace EasyMock with Mockito in spring-orm
merge branch 'spr-10126' into cleanup-3.2.x
43
true
false
5
true
true
false
spring-projects
spring-framework
19,372
ee1ddc90ecc0b8013757d332a299dd3b8c41bd84
Phillip Webb
Phillip Webb
Replace EasyMock with Mockito in spring-orm Issue: SPR-10126
replace easymock with mockito in spring-orm
43
false
false
6
true
true
true
spring-projects
spring-framework
19,373
2f6e45ff0615ec98114025eb3b78db8ab963d029
Rossen Stoyanchev
Rossen Stoyanchev
Add protected method to AbstractHandlerMethodMapping
add protected method to abstracthandlermethodmapping
52
false
false
5
true
true
false
spring-projects
spring-framework
19,374
f185c3a3c18f11770494060182780af61a8c9e55
Rossen Stoyanchev
Rossen Stoyanchev
Add option to not trim path segments in AntPathMatch Issue: SPR-8687
add option to not trim path segments in antpathmatch
52
false
false
9
true
true
false
spring-projects
spring-framework
19,375
68d4a70f8e7315d227b7727b087a65e64f4b0f9e
Rossen Stoyanchev
Rossen Stoyanchev
Add option to always append 'must-revalidate' Issue: SPR-9248
add option to always append 'must-revalidate'
45
false
false
6
true
true
true
spring-projects
spring-framework
19,376
24ffa5a706d1b8538ff1359c635905f0f9af9fb5
Rossen Stoyanchev
Rossen Stoyanchev
Update info on RestTemplate related to 401 status code Issue: SPR-9367
update info on resttemplate related to 401 status code
54
false
false
9
true
true
false
spring-projects
spring-framework
19,377
0829cbfdd3adc4459e47b6c4e1411dba796f964a
Chris Beams
Chris Beams
Update license header for recently modified files Issue: SPR-7763, SPR-10140, SPR-10132, SPR-10093, SPR-10103
update license header for recently modified files
49
false
false
7
true
false
true
spring-projects
spring-framework
19,378
07605948ff8056772b4e53d3745f64d22296e51d
Rossen Stoyanchev
Rossen Stoyanchev
Merge pull request #205 from acogoluegnes/SPR-10093 * tmp: Add support for HTTP OPTIONS in Spring MVC Test
merge pull request #205 from acogoluegnes/spr-10093
51
true
false
6
false
false
false
spring-projects
spring-framework
19,379
a56d8f28fe3c434d04d92ec6cd7ff60848cf8a2e
Arnaud Cogoluègnes
Rossen Stoyanchev
Add support for HTTP OPTIONS in Spring MVC Test Issue: SPR-10093
add support for http options in spring mvc test
47
false
false
9
true
true
true
spring-projects
spring-framework
19,380
c7d0054a9e60b89a1cfbe184e9bbcb983f9231cb
Rossen Stoyanchev
Rossen Stoyanchev
Remove closing tag in form tag's extra hidden fields The fields returned from a RequestDataValueProcessor are now written as hidden fields without a closing tag. Before: <input type="hidden" name="xxx" value="yyy"></input> After: <input type="hidden" name="xxx" value="yyy" /> Issue: SPR-10103
remove closing tag in form tag's extra hidden fields
52
false
false
9
true
true
false
spring-projects
spring-framework
19,381
2ac4a8c5411f8642ac2c40503678e5d7a4b56dbf
Rossen Stoyanchev
Rossen Stoyanchev
Update mvc chapter on annotations and proxies Issue: SPR-10132
update mvc chapter on annotations and proxies
45
false
false
7
true
true
true
spring-projects
spring-framework
19,382
87109b348cf1fcae2d4aefe64f9ce6b8fcf389a0
Rossen Stoyanchev
Rossen Stoyanchev
Add decoding matrix variable values Issue: SPR-10140
add decoding matrix variable values
35
false
false
5
false
false
false
spring-projects
spring-framework
19,383
23912771154c54f63fdc0034c181edee07f9bb89
Rossen Stoyanchev
Rossen Stoyanchev
Fix issue in BufferedImageHttpMessageConverter This change ensures BufferedImageHttpMessageConverter writes when "*/*" is requested. Issue: SPR-7763
fix issue in bufferedimagehttpmessageconverter
46
false
false
4
false
true
false
spring-projects
spring-framework
19,384
4611d150fee25869449007350f5b2a12d7262f66
Chris Beams
Chris Beams
Merge branch 'SPR-9843' into 3.2.x * SPR-9843: Add 3.1 migration section to reference docs
merge branch 'spr-9843' into 3.2.x
34
true
false
5
true
true
false
spring-projects
spring-framework
19,385
b8f223c404db419927d4f9763d71e10ca38d37dd
Chris Beams
Chris Beams
Add 3.1 migration section to reference docs Address error raised when using component-scan against the unqualified "org" base package. Issue: SPR-9843
add 3.1 migration section to reference docs
43
false
false
7
true
true
true
spring-projects
spring-framework
19,386
7bc9667913571d17c38f2c1854af9eebadffa832
Rossen Stoyanchev
Rossen Stoyanchev
Add support for placeholders in @RequestMapping @RequestMapping annotations now support ${...} placeholders. Issue: SPR-9935
add support for placeholders in @requestmapping
47
false
false
6
true
true
true
spring-projects
spring-framework
19,387
15c09713815a6006b88b31238ca29daf56619493
Phillip Webb
Phillip Webb
Merge branch 'cleanup-3.2.x' into 3.2.x * cleanup-3.2.x: Gradle 'api' task depends on 'jar' tasks Mark all IsFastEnough tests as performance tests
merge branch 'cleanup-3.2.x' into 3.2.x
39
true
false
5
true
true
false
spring-projects
spring-framework
19,388
153508a300772db262c6123f57fbc4bcbf89b4f4
Rossen Stoyanchev
Rossen Stoyanchev
Support "X-Forwarded-Host" in UriComponentsBuilder ServletUriComponentsBuilder now supports setting the host to the value held in the X-Forwarded-Host [0] header used in reverse proxy scenarios. [0] http://tools.ietf.org/html/draft-ietf-appsawg-http-forwarded-10 Issue: SPR-10110
support "x-forwarded-host" in uricomponentsbuilder
50
false
false
4
false
true
false
spring-projects
spring-framework
19,389
a4b00c732b13aa1628161cb35d49463c5c39d38c
Chris Beams
Chris Beams
Introduce BeanFactoryAnnotationUtils Commit 096693c46fba6e09b346a498b7002abd4d6540a9 refactored and deprecated TransactionAspectUtils, moving its #qualifiedBeanOfType and related methods into BeanFactoryUtils. This created a package cycle between beans.factory and beans.factory.annotation due to use of the beans.facto...
introduce beanfactoryannotationutils
36
false
false
2
true
true
false
spring-projects
spring-framework
19,390
4027b389031273955ffe343732eac50b8b5c0d25
Rossen Stoyanchev
Rossen Stoyanchev
Merge rather than add URI vars to data binding values As of Spring 3.1 URI variables can be used for data binding purposes in addition to request parameters (including query string and form params) In some cases URI variables and request params can overlap (e.g. form contains a child entity with an entityId as hidden...
merge rather than add uri vars to data binding values
53
true
false
10
false
false
false
spring-projects
spring-framework
19,391
5330c52ebfca1ab2fffca4bcc844d2d9f56a296b
Chris Beams
Chris Beams
Merge branch cbeams/SPR-7022 * SPR-7022: Support initial delay attribute for scheduled tasks Polish scheduled task execution infrastructure
merge branch cbeams/spr-7022
28
true
false
3
false
true
false
spring-projects
spring-framework
19,392
53673d6c598a587ab1e511bbce14ba8b686f8951
Chris Beams
Chris Beams
Support initial delay attribute for scheduled tasks java.util.concurrent's ScheduledExecutorService and its #schedule* methods allow for an 'initialDelay' parameter in milliseconds. Similarly, Spring's TaskExecutor abstraction allows for a concrete 'startTime' expressed as a Date. However, Spring's <task:scheduled> XM...
support initial delay attribute for scheduled tasks
51
false
false
7
false
true
false
spring-projects
spring-framework
19,393
4d5fe57a0831ca2ab86bb1a296470898e8f7f3ac
Chris Beams
Chris Beams
Polish scheduled task execution infrastructure In anticipation of substantive changes required to implement "initial delay" support in the <task:scheduled> element and @Scheduled annotation, the following updates have been made to the components and infrastructure supporting scheduled task execution: - Fix code styl...
polish scheduled task execution infrastructure
46
false
false
5
false
false
false
spring-projects
spring-framework
19,394
e2fbaa8470b647ffd9c0c8be5aa93f7dc3bf6c56
Chris Beams
Chris Beams
Merge pull request #62 from poutsma/SPR-9300 * SPR-9300: Add convenient WebAppInitializer base classes
merge pull request #62 from poutsma/spr-9300
44
true
false
6
false
false
false
spring-projects
spring-framework
19,395
f64c13ad2e986e6ae26e5759654a4bfb5ca6b937
Arjen Poutsma
Chris Beams
Add convenient WebAppInitializer base classes This commit introduces three abstract WebApplicationInitializers, to be used in the typical setup of a Spring-based web application. - AbstractContextLoaderInitializer provides an abstract base class for registering a ContextLoaderListener. - AbstractDispatcherServl...
add convenient webappinitializer base classes
45
false
false
5
false
true
false
spring-projects
spring-framework
19,396
37e024c6ebfdc57874e5024b3e9efa69de05fa44
Chris Beams
Chris Beams
Test meta-@Async executor qualification Prove that Async#value is respected even when using @Async as a meta annotation. Issue: SPR-6847
test meta-@async executor qualification
39
false
false
4
false
false
false
spring-projects
spring-framework
19,397
1d06001359c8acacb2c535d3f85be43777a673b3
Chris Beams
Chris Beams
Merge branch cbeams/SPR-6847 * SPR-6847: Support executor qualification with @Async#value Polish async method execution infrastructure Refactor and deprecate TransactionAspectUtils
merge branch cbeams/spr-6847
28
true
false
3
false
true
false
spring-projects
spring-framework
19,398
ed0576c1811bbb3a17e2e9aed2810dc3c9097a09
Chris Beams
Chris Beams
Support executor qualification with @Async#value Prior to this change, Spring's @Async annotation support was tied to a single AsyncTaskExecutor bean, meaning that all methods marked with @Async were forced to use the same executor. This is an undesirable limitation, given that certain methods may have different prior...
support executor qualification with @async#value
48
false
false
5
false
true
false
spring-projects
spring-framework
19,399
3fb11870d9e9fc47651c08442ac7e85140788579
Chris Beams
Chris Beams
Polish async method execution infrastructure In anticipation of substantive changes required to implement @Async executor qualification, the following updates have been made to the components and infrastructure supporting @Async functionality: - Fix trailing whitespace and indentation errors - Fix generics warnings...
polish async method execution infrastructure
44
false
false
5
false
false
false
spring-projects
spring-framework
19,400
096693c46fba6e09b346a498b7002abd4d6540a9
Chris Beams
Chris Beams
Refactor and deprecate TransactionAspectUtils TransactionAspectUtils contains a number of methods useful in retrieving a bean by type+qualifier. These methods are functionally general-purpose save for the hard coding of PlatformTransactionManager class literals throughout. This commit generifies these methods and mov...
refactor and deprecate transactionaspectutils
45
false
false
4
false
false
false
spring-projects
spring-framework
19,401
e71cd06a465228d54d373431f4b51a417013bea0
Sam Brannen
Sam Brannen
Doc. usage of JSR-250 lifecycle annotations in TCF The reference manual previously did not mention the applicability of JSR-250 lifecycle annotations within the TestContext framework. The lacking documentation here has lead to misunderstandings of the support provided for @PostConstruct and @PreDestroy in test classes...
doc. usage of jsr-250 lifecycle annotations in tcf
50
false
false
8
false
false
false
spring-projects
spring-framework
19,402
03d6350e4b3c7e23e3cc84bf3f261f2c53b5b1e9
Rossen Stoyanchev
Rossen Stoyanchev
Fix issue with resolution of WebDataBinder argument There is usually not need to put annotations on a WebDataBinder argument in an `@InitBinder` method. However, the presence of any annotation prevented the successful resolution of the argument. This fix addresses the issue. Issue: SPR-8946
fix issue with resolution of webdatabinder argument
51
false
false
7
true
true
false
spring-projects
spring-framework
19,403
5cd6543d8360489f9ecfcd0de63ee4e06d6e6728
Sam Brannen
Sam Brannen
Update @Bean Javadoc re: 'lite' mode, scope, etc. Updated the "@Bean Lite Mode" section in order to properly document scoping and lifecycle semantics. Also fleshed out the discussion of the non-applicability of 'inter-bean references' in lite mode. Issue: SPR-9425
'lite' mode, scope, etc
23
false
false
4
false
false
false
spring-projects
spring-framework
19,404
dc6b2abe46bc3edfaaf7020d2c95427412bed74c
Sam Brannen
Sam Brannen
Verify scope support for 'lite' @Beans in the TCF Introduced AtBeanLiteModeScopeTests integration tests to verify proper scoping of beans created in 'lite' mode. Updated comments in TACCWithoutACTests to better reflect the runtime behavior for 'lite' @Bean methods. Issue: SPR-9401
verify scope support for 'lite' @beans in the tcf
49
false
false
9
true
true
true
spring-projects
spring-framework
19,405
49966258f1230950e31f717750b67787742826aa
Sam Brannen
Sam Brannen
Polish doc for 'annotated class' support in TCF Revised the content in the @ContextConfiguration annotation section. Issue: SPR-9401
polish doc for 'annotated class' support in tcf
47
false
false
8
true
false
true
spring-projects
spring-framework
19,406
6a01ca6d353ef29b46deac89f9c248d978406f2d
Chris Beams
Chris Beams
Merge branch garyrussell/SPR-9249 * SPR-9249: Add value-type attrib to beans->map->entry element
merge branch garyrussell/spr-9249
33
true
false
3
true
true
false
spring-projects
spring-framework
19,407
183ac0c1ffb6369fc33e5de3d00b7974aebc200d
Gary Russell
Chris Beams
Add value-type attrib to beans->map->entry element Previously, the <value> subelement of a map <entry> allowed one to specify the type of a specific map entry value. This patch allows a value-type attribute as well, such that instead of the following syntax <entry key="x-message-ttl"> <value type="java.la...
add value-type attrib to beans->map->entry element
50
false
false
6
false
false
false
spring-projects
spring-framework
19,408
f3bcb6e2e413d48355771de7164730beeed80dad
Chris Beams
Chris Beams
Update spring.schemas to reflect 3.2 schemas Commit 180c5b2ef6c16f66145a4250b597a093e566d922 introduced 3.2 versions of all spring-* schemas; this commit updates spring.schemas mapping files to include these new versions.
update spring.schemas to reflect 3.2 schemas
44
false
false
6
true
true
true
spring-projects
spring-framework
19,409
504cdf498ea27f307c1ab7f9e520b700dfdb612f
Sam Brannen
Sam Brannen
Update documentation of 'annotated class' support in the TCF Updated the testing chapter of the reference manual to refer to 'annotated classes' instead of 'configuration classes' where appropriate. Also revised the content and examples in the @ContextConfiguration annotation section, mentioned Gradle, and reforma...
update documentation of 'annotated class' support in the tcf
60
false
false
9
true
true
false
spring-projects
spring-framework
19,410
09d98fd3ae88eaf878bda27f5a1277c171378c72
Sam Brannen
Sam Brannen
Delete superfluous fail() invocations in RequestResponseBodyMethodProcessorTests Several test methods in RequestResponseBodyMethodProcessorTests are currently annotated with @Test(expected=…) and additionally contain: fail("Expected exception"); This combination is superfluous, and the unnecessary fail() invocat...
delete superfluous fail() invocations in requestresponsebodymethodprocessortests
80
false
false
6
false
true
false
spring-projects
spring-framework
19,411
77ae101402d07b4a59bc9e52b3fe045f1a0e2e7d
Rossen Stoyanchev
Rossen Stoyanchev
Add required flag to @RequestBody If true and there is no body => HttpMessageNotReadableException If false and there is no body, the argument resolves to null. Issue: SPR-9239
add required flag to @requestbody
33
false
false
5
true
true
true
spring-projects
spring-framework
19,412
0105c5ebb9896641bdc601ff164a2404e817e505
Rossen Stoyanchev
Rossen Stoyanchev
Decode path vars in pre-3.1 `@MVC` support clases too See the commit comments for: https://github.com/SpringSource/spring-framework/commit/57307a0b2e5bce8f70d5deddf8df11d034dc8c5a This commit also applies the change to pre-3.1 `@MVC` suppor classes. Issue: SPR-6951
decode path vars in pre-3.1 `@mvc` support clases too
53
false
false
9
false
true
false
spring-projects
spring-framework
19,413
57307a0b2e5bce8f70d5deddf8df11d034dc8c5a
Rossen Stoyanchev
Rossen Stoyanchev
Decode path vars when url decoding is turned off When URL decoding is turned off in AbstractHandlerMapping, the extracted path variables are also not encoded. Turning off URL decoding may be necessary for request mapping to work correctly when the path may contain the (encoded) special character '/'. At the same time ...
decode path vars when url decoding is turned off
48
false
false
9
false
true
false
spring-projects
spring-framework
19,414
36e7cb2d3142466d0f169331352f9c2abf185574
Sam Brannen
Sam Brannen
Improve documentation of annotated class support in the TCF Updated all Javadoc in the Spring TestContext Framework (TCF) to explain and refer to 'annotated classes' instead of 'configuration classes'. Specifically, @ContextConfiguration now explicitly defines what is meant by 'annotated classes', and various other c...
improve documentation of annotated class support in the tcf
59
false
false
9
true
true
false
spring-projects
spring-framework
19,415
59e3223c849fd04c1415f5ddd9bfb9acb9a17b60
Sam Brannen
Sam Brannen
Polish recent changes to Log4jWebConfigurer Reordered inline comments so that they now apply to current state of the code. Added logger entry in testlog4j.properties to avoid console warning. Issue: SPR-9417
polish recent changes to log4jwebconfigurer
43
false
false
5
true
false
true
spring-projects
spring-framework
19,416
98bf01adfbe8a10c12607d3c2f018b0a8b5d6353
Chris Beams
Chris Beams
Merge pull request #42 from sslavic/SPR-5369 * SPR-5369: Fix circular placeholder prevention
merge pull request #42 from sslavic/spr-5369
44
true
false
6
false
false
false
spring-projects
spring-framework
19,417
18006c72b014246946fd487159de7e133d173a17
Stevo Slavic
Chris Beams
Fix circular placeholder prevention A set of resolved placeholder references is used for circular placeholder prevention. For complex property definitions this mechanism would put property values with unresolved inner placeholder references in the set, but would try to remove property values with placeholders resolved...
fix circular placeholder prevention
35
false
false
4
true
true
true
spring-projects
spring-framework
19,418
f667db56b145a8d1b9e0d39df4fed44341b50ab6
Chris Beams
Chris Beams
Merge pull request #34 from marschall/warnings * warnings: Fix compiler warnings
merge pull request #34 from marschall/warnings
46
true
false
6
false
false
false
spring-projects
spring-framework
19,419
13239a0c3d5bf226998f2da9eb66014118972a26
Philippe Marschall
Chris Beams
Fix compiler warnings This patch fixes several compiler warnings that do not point to code problems. Two kinds of warnings are fixed. First in a lot of cases @SuppressWarnings("unchecked") is used although there are no unchecked casts happening. This seems to be a leftover from when the code base was on Java 1.4, now ...
fix compiler warnings
21
false
false
3
true
true
true
spring-projects
spring-framework
19,420
e68b563626147120e84e164704969b83df7ad35d
Chris Beams
Chris Beams
Merge pull request #53 from aclement/SPR-9203 * SPR-9203: Eliminate trailing whitespace in SpEL classes Support [] array ref syntax in SpEL T() construct
merge pull request #53 from aclement/spr-9203
45
true
false
6
false
false
false
spring-projects
spring-framework
19,421
de2d8082121d3c2187b5555eb1e3a77f7128ba25
Chris Beams
Chris Beams
Eliminate trailing whitespace in SpEL classes
eliminate trailing whitespace in spel classes
45
false
false
6
true
false
true
spring-projects
spring-framework
19,422
916e9d6efa390faf8511942c0ab40dadf5da8382
Andy Clement
Chris Beams
Support [] array ref syntax in SpEL T() construct Prior to this change, SpEL would not allow the use of '[]' in expressions like the following: T(foo.Bar[]) This commit updates TypeReference and InternalSpelExpressionParser to support this syntax, avoiding the need for workarounds like: new foo.bar[0].class...
support [] array ref syntax in spel t() construct
49
false
false
9
false
false
false
spring-projects
spring-framework
19,423
0e8f5d877a3e0e98772030c9d565a9d133581d01
Chris Beams
Chris Beams
Merge pull request #57 from sslavic/SPR-8278 * SPR-8278: Fix compiler warnings in Constants/ConstantsTests Allow null params as advertised in Constants#toCode*
merge pull request #57 from sslavic/spr-8278
44
true
false
6
false
false
false
spring-projects
spring-framework
19,424
1f4b33c4ad72c0760bfc40867ce09a859c02f7aa
Chris Beams
Chris Beams
Fix compiler warnings in Constants/ConstantsTests
fix compiler warnings in constants/constantstests
49
false
false
5
true
true
true
spring-projects
spring-framework
19,425
6ffb0436fa55fb73048a5a9133a98e122e490119
Stevo Slavic
Chris Beams
Allow null params as advertised in Constants#toCode* Even though the Javadoc for Constants#toCode and #toCodeForSuffix specifies that a null value for the 'namePrefix' and 'nameSuffix' parameters are respectively allowed, before this change passing a null to either would result in a NullPointerException. This change ...
allow null params as advertised in constants#tocode*
52
false
false
7
true
true
false
spring-projects
spring-framework
19,426
95e99fe2a3eb1739d785f029e7fe9637fe3e26f8
Chris Beams
Chris Beams
Merge pull request #59 from sslavic/SPR-8360 * SPR-8360: Fix JibxMarshallerTests failing on Windows
merge pull request #59 from sslavic/spr-8360
44
true
false
6
false
false
false
spring-projects
spring-framework
19,427
51ae6845ad0aaa1b8ea6f002ddd4f8ded45a9dbc
Stevo Slavic
Chris Beams
Fix JibxMarshallerTests failing on Windows Before this change JibxMarshallerTests would fail on Windows with an error message explaining that JiBX compiler generated classes are not found on the classpath for binding with name 'binding'. Tests would execute well on Linux and OS X. Actual root cause of this bug is fou...
fix jibxmarshallertests failing on windows
42
false
false
5
false
true
false
spring-projects
spring-framework
19,428
0ca11d2296d289c0b42dc8c371723632d8a3e5ef
Chris Beams
Chris Beams
Merge pull request #49 from sslavic/SPR-9123 * SPR-9123: Fix SpEL JavaBean compliance
merge pull request #49 from sslavic/spr-9123
44
true
false
6
false
false
false
spring-projects
spring-framework
19,429
1f28bdfbfa7f6f7025dac18bd5cdf4fdefb32950
Stevo Slavic
Chris Beams
Fix SpEL JavaBean compliance Before this fix ReflectivePropertyAccessor was not able to find write method for valid property name that has first character in lower case and second character in upper case. Write method lookup would always convert first character of property name to upper case which is not compliant wit...
fix spel javabean compliance
28
false
false
4
true
true
true
spring-projects
spring-framework
19,430
2503b7eb891824da01ccde3b5035f0030ea757a4
Chris Beams
Chris Beams
Fix property replacement bug in Log4jWebConfigurer Previously, if the resolution of a ${...} placeholder resulted in a valid URL for the location of a log4j properties/XML file, the URL would ultimately be malformed by an unnecessary call to to WebUtils#getRealPath. The implementation of Log4jWebConfigurer#initLoggin...
fix property replacement bug in log4jwebconfigurer
50
false
false
6
false
false
false
spring-projects
spring-framework
19,431
f1246a43175dc040584140c9792beb5dce521e9b
Chris Beams
Chris Beams
Fix locale parsing error with en_en, tr_tr, etc Previously, StringUtils#parseLocaleString would parse locale strings having the same lowercase token for both language and country incorrectly, e.g. 'tr_tr' would parse to 'tr_TR_tr' as opposed to the expected 'tr_TR'. This commit fixes this behavior by using using Stri...
fix locale parsing error with en_en, tr_tr, etc
47
false
false
8
false
true
false
spring-projects
spring-framework
19,432
e8f8559a2e1c5fa5c559f887756cdc085c90f26b
Sam Brannen
Sam Brannen
Improve documentation of @Bean 'lite' mode Removed misleading mention of "configuration classes" in the "@Bean Lite Mode" section. Issue: SPR-9401
improve documentation of @bean 'lite' mode
42
false
false
6
true
true
true
spring-projects
spring-framework
19,433
94c9f96449960a94e49edd7709d49b243de4a5f1
Sam Brannen
Sam Brannen
Improve documentation of @Bean 'lite' mode Updated the class-level JavaDoc for @Bean to better explain the semantics of 'lite' mode. Renamed "Configuration Class Lite Mode" to "@Bean Lite Mode". Added discussion of @DependsOn to the class-level JavaDoc. Issue: SPR-9401
improve documentation of @bean 'lite' mode
42
false
false
6
true
true
true
spring-projects
spring-framework
19,434
dfd2b77b8a0789f2052f79802b2d7085fc5d186e
Chris Beams
Chris Beams
Merge pull request #81 from JanecekPetr/SPR-9342 * SPR-9342: Fix annotation search ending too early
merge pull request #81 from janecekpetr/spr-9342
48
true
false
6
true
false
false
spring-projects
spring-framework
19,435
ef7e728bb85c7dfa4c677deceac6bb2a61f5b9c8
Petr Janecek
Chris Beams
Fix annotation search ending too early In AnnotationUtils#findAnnotation(Method, Class), the search for a method annotation fails if: - the original method does not have the annotation - an abstract superclass does not have an equivalent method declared - an interface implemented by the superclass has the method...
fix annotation search ending too early
38
false
false
6
false
true
false
spring-projects
spring-framework
19,436
6023b2060b8b5c074c2a349aaecdb894045e48de
Sam Brannen
Sam Brannen
Fix minor grammatical errors in AbstractBeanDefinition
fix minor grammatical errors in abstractbeandefinition
54
false
false
6
true
true
false
spring-projects
spring-framework
19,437
98050268c529597279a50ee39382a2327c1d85e4
Sam Brannen
Sam Brannen
Improve documentation for configuration class 'lite' mode Overhauled the class-level JavaDoc in @Bean: - added h3 headers for greater clarity and readability - mentioned 'prototype' semantics for lite mode Issue: SPR-9401
improve documentation for configuration class 'lite' mode
57
false
false
7
true
true
false
spring-projects
spring-framework
19,438
cf5d55173bd73adf9c3a93204288013b1ceab246
Rossen Stoyanchev
Rossen Stoyanchev
Pattern suffix issue in AnnotationMethodHandlerAdapter SPR-9333
pattern suffix issue in annotationmethodhandleradapter
54
false
false
5
false
false
false
spring-projects
spring-framework
19,439
ae216fbbb548295005aba05d7f3e011cc9fd10c7
Chris Beams
Chris Beams
Merge pull request #63 from dukehoops/SPR-9298 * SPR-9298: Cache MethodParameter annotation lookup results
merge pull request #63 from dukehoops/spr-9298
46
true
false
6
false
false
false
spring-projects
spring-framework
19,440
c10d63dc011c95b3e24d4ed8d7140c73053736c6
Nikita Tovstoles
Chris Beams
Cache MethodParameter annotation lookup results Prior to this change, Spring's MethodParameter#getParameterAnnotations called java.lang.Method#getParameterAnnotations on every invocation. The latter ends up contending for a monitor inside (Sun) JDK code. This is problematic when dealing with the high number of @Reques...
cache methodparameter annotation lookup results
47
false
false
5
false
false
false
spring-projects
spring-framework
19,441
39f74b23748b2a7d83e783d64d641b209728d5c6
Chris Beams
Chris Beams
Merge pull request #37 from marschall/small-memory-fixes * small-memory-fixes: Optimize memory usage in factory *Metadata classes
merge pull request #37 from marschall/small-memory-fixes
56
true
false
6
false
false
false
spring-projects
spring-framework
19,442
cdb6d7447eacfd026c7400238493bb3dc9f17e1c
Philippe Marschall
Chris Beams
Optimize memory usage in factory *Metadata classes InjectionMetadata and LifecycleMetadata can end up having mostly empty instance variables. In such cases memory usage can be improved a little bit. This patch addresses this in two ways: - Creating a LinkedHashSet of the "right" size, the default capacity is 16 ...
optimize memory usage in factory *metadata classes
50
false
false
7
false
true
false
spring-projects
spring-framework
19,443
46bdb2de077063663f0daae85431ebe5c430edc8
Chris Beams
Chris Beams
Merge pull request #64 from marschall/SPR-9316 * SPR-9316: Avoid NPE in AutowiredAnnotationBeanPostProcessor
merge pull request #64 from marschall/spr-9316
46
true
false
6
false
false
false
spring-projects
spring-framework
19,444
2624b909060e0967e16771de7a35261decd5a4a9
Philippe Marschall
Chris Beams
Avoid NPE in AutowiredAnnotationBeanPostProcessor Prior to this change, AABPP#determineRequiredStatus never checked the return value of ReflectionUtils#findMethod when searching for a '#required' attribute. This call returns null for annotations such as @Inject, @Value and @Resource, and subsequently causes a NullPoin...
avoid npe in autowiredannotationbeanpostprocessor
49
false
false
4
true
true
true
spring-projects
spring-framework
19,445
b50f6e19a6820a8e735a89dfee1a85077e804ec5
Sam Brannen
Sam Brannen
Fix regression in ClassPathResource descriptions ClassPathResource.getDescription() now returns consistent, meaningful results for all variants of ClassPathResource's constructors. Issue: SPR-9413
fix regression in classpathresource descriptions
48
false
false
5
true
true
true
spring-projects
spring-framework
19,446
500a4dd99579b00027918abda7d4d74f2a65b3a9
Sam Brannen
Sam Brannen
Fix tx annotated tests so that they pass in the build AbstractTransactionalAnnotatedConfigClassTests is now annotated with @DirtiesContext(classMode = ClassMode.AFTER_EACH_TEST_METHOD) so that side-effects between tests are avoided. Re-enabled TransactionalAnnotatedConfigClassWithAtConfigurationTests and Transaction...
fix tx annotated tests so that they pass in the build
53
false
false
11
false
true
false
spring-projects
spring-framework
19,447
01a9dd97721c93fe80d8fd35bd5dc8de649b3595
Rossen Stoyanchev
Rossen Stoyanchev
Add option to set Content-Length in JSON Views MappingJackson2JsonView and MappingJacksonJsonView now provide an option that will set the Content-Length header of JSON responses. Use of the option implies buffering of the response and it must be enabled explicitly. Issue: SPR-7866
add option to set content-length in json views
46
false
false
8
true
true
true
spring-projects
spring-framework
19,448
2017b24867c6b009cad316960a84a7f55bec58c5
Sam Brannen
Sam Brannen
Disable tx annotated tests until working within the build Issue: SPR-9051
disable tx annotated tests until working within the build
57
false
false
9
false
true
false
spring-projects
spring-framework
19,449
2af294ab26b670c7f997054ab11ecf7402fee6ed
Rossen Stoyanchev
Rossen Stoyanchev
Add MessageCodesResolver hook to WebMvcConfigurer This change makes it possible to provide a custom MessageCodesResolver through the MVC Java config whether using @EnableWebMvc and extending WebMVcConfigurerAdapter or sub-classing directly from WebMvcConfigurationSupport. Issue: SPR-9223
add messagecodesresolver hook to webmvcconfigurer
49
false
false
5
true
true
true
spring-projects
spring-framework
19,450
1cec0f9c6575edb9f81ef39a7019b5d3edc0d656
Sam Brannen
Sam Brannen
Investigate claims made in SPR-9051 regarding transactional tests The claim: given an integration test class that is annotated with @ContextConfiguration and declares a configuration class that is missing an @Configuration annotation, if a transactional test method (i.e., one annotated with @Transactional) changes ...
investigate claims made in spr-9051 regarding transactional tests
65
false
false
8
true
true
false
spring-projects
spring-framework
19,451
9c223c178055829c778fc28a5082fa0338a68ca1
Chris Beams
Chris Beams
Fix broken link to JavaBean customization tutorial Issue: SPR-9408
fix broken link to javabean customization tutorial
50
false
false
7
true
true
true
spring-projects
spring-framework
19,452
19aceebb961bd7fe24477a8e15830c668f519385
Chris Beams
Chris Beams
Fix broken javadoc link to ROME tools project Issue: SPR-9379
fix broken javadoc link to rome tools project
45
false
false
8
true
true
true
spring-projects
spring-framework
19,453
2db4e15f0e5fa6a4bdf3bb46d0d280ea16fc8dea
Chris Beams
Chris Beams
Translate SQLTimeoutException to QueryTimeoutException SPR-7680 added QueryTimeoutException to Spring's DataAccessException hierarchy, but did not integrate it into the SQLExceptionSubclassTranslator; it was added mainly to accomodate users defining their own custom exception translators. However, it does make sense ...
translate sqltimeoutexception to querytimeoutexception
54
false
false
4
true
true
false
spring-projects
spring-framework
19,454
2ff43726be693f32b7bf2a6d237ab65f8ce84ba6
Chris Beams
Chris Beams
Restore serializability of HttpStatusCodeException SPR-7591 introduced a java.nio.charset.Charset field within HttpStatusCodeException. The former is non-serializable, thus by extension the latter also became non-serializable. Because the Charset field is only used for outputting the charset name in HttpStatusCodeExc...
restore serializability of httpstatuscodeexception
50
false
false
4
true
true
true
spring-projects
spring-framework
19,455
9a856c09f322b8ae821ff5e6a86dc0b0aeaf618d
Chris Beams
Chris Beams
Clarify @EnableScheduling javadoc It is now advised that destroyMethod="shutdown" should be used on @Bean methods returning an ExecutorService. Issue: SPR-9280
clarify @enablescheduling javadoc
33
false
false
3
true
true
true
spring-projects
spring-framework
19,456