language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 05fc0bbd4112b1151b768a77c3024dc18d294edc.json | Remove some unnecessary uses of Ember.A | packages/@ember/debug/data-adapter.ts | @@ -552,14 +552,14 @@ export default class DataAdapter<T> extends EmberObject {
: this._getObjectsOnNamespaces();
// New adapters return strings instead of classes.
- let klassTypes = emberA(stringTypes).map((name) => {
+ let klassTypes = stringTypes.map((name) => {
return {
klass: t... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | packages/@ember/-internals/glimmer/lib/utils/iterator.ts | @@ -5,6 +5,7 @@ import type { Option } from '@glimmer/interfaces';
import type { IteratorDelegate } from '@glimmer/reference';
import { consumeTag, isTracking, tagFor } from '@glimmer/validator';
import { EachInWrapper } from '../helpers/each-in';
+import type { NativeArray } from '@ember/array';
export default f... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | packages/@ember/-internals/utils/lib/ember-array.ts | @@ -1,4 +1,4 @@
-import type EmberArray from '@ember/array';
+import type { EmberArrayLike } from '@ember/array';
import { _WeakSet } from '@glimmer/util';
const EMBER_ARRAYS = new _WeakSet();
@@ -7,6 +7,6 @@ export function setEmberArray(obj: object) {
EMBER_ARRAYS.add(obj);
}
-export function isEmberArray(o... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | packages/@ember/-internals/utils/types.ts | @@ -4,4 +4,10 @@ export type MethodNamesOf<T> = {
[K in keyof T]: T[K] extends AnyFn ? K : never;
}[keyof T];
+export type MethodsOf<O> = Pick<O, MethodNamesOf<O>>;
+
+export type MethodParams<T, M extends MethodNamesOf<T>> = Parameters<MethodsOf<T>[M]>;
+
+export type MethodReturns<T, M extends MethodNamesOf<T>>... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | packages/@ember/array/index.ts | @@ -20,12 +20,12 @@ import MutableEnumerable from '@ember/enumerable/mutable';
import { compare, typeOf } from '@ember/utils';
import { ENV } from '@ember/-internals/environment';
import Observable from '@ember/object/observable';
-import type { AnyFn } from '@ember/-internals/utils/types';
+import type { MethodName... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | packages/@ember/array/type-tests/index.ts | @@ -25,8 +25,11 @@ class Target {
let target = new Target();
-expectTypeOf(arr).toMatchTypeOf<EmberArray<Foo>>();
-expectTypeOf(arr).toMatchTypeOf<MutableArray<Foo>>();
+// NativeArray does not exactly extend the interface of EmberArray and MutableArray,
+// since native methods are not overwritten.
+expectTypeOf(... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | packages/@ember/array/type-tests/mutable.ts | @@ -1,63 +1,67 @@
-import type MutableArray from '@ember/array/mutable';
-import { A } from '@ember/array';
+import MutableArray from '@ember/array/mutable';
import { expectTypeOf } from 'expect-type';
-class Foo {}
+class Foo {
+ constructor(public name: string) {}
+}
-let foo = new Foo();
+let foo = new Foo('... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | packages/@ember/debug/data-adapter.ts | @@ -544,7 +544,7 @@ export default class DataAdapter<T> extends EmberObject {
@method getModelTypes
@return {Array} Array of model types.
*/
- getModelTypes(): NativeArray<{ klass: unknown; name: string }> {
+ getModelTypes(): Array<{ klass: unknown; name: string }> {
let containerDebugAdapter = thi... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | type-tests/preview/@ember/array-test/array.ts | @@ -3,6 +3,7 @@ import type Array from '@ember/array';
import { A } from '@ember/array';
import type MutableArray from '@ember/array/mutable';
import { expectTypeOf } from 'expect-type';
+import NativeArray from '@ember/array/-private/native-array';
class Person extends EmberObject {
name = '';
@@ -19,20 +20,1... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | type-tests/preview/ember/array.ts | @@ -16,20 +16,18 @@ expectTypeOf(people.get('lastObject')).toEqualTypeOf<Person | undefined>();
expectTypeOf(people.get('firstObject')).toEqualTypeOf<Person | undefined>();
expectTypeOf(people.isAny('isHappy')).toBeBoolean();
expectTypeOf(people.isAny('isHappy', false)).toBeBoolean();
-// @ts-expect-error
+// TODO: ... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | type-tests/preview/ember/ember-module-tests.ts | @@ -153,7 +153,7 @@ expectTypeOf(Ember.Application.create()).toEqualTypeOf<Ember.Application>();
expectTypeOf(new Ember.ApplicationInstance()).toEqualTypeOf<Ember.ApplicationInstance>();
expectTypeOf(Ember.ApplicationInstance.create()).toEqualTypeOf<Ember.ApplicationInstance>();
// Ember.Array
-const a1: Ember.Array... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | type-tests/preview/ember/ember-tests.ts | @@ -112,14 +112,13 @@ people.invoke('sayHello');
// @ts-expect-error
people.invoke('name');
-type Arr = Ember.NativeArray<
- Ember.Object & {
- name?: string;
- }
->;
-const arr: Arr = Ember.A([Ember.Object.create(), Ember.Object.create()]);
-expectTypeOf(arr.setEach('name', 'unknown')).toEqualTypeOf<void>();
... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | types/preview/@ember/array/-private/native-array.d.ts | @@ -1,22 +1,180 @@
declare module '@ember/array/-private/native-array' {
import Observable from '@ember/object/observable';
+ import EmberArray from '@ember/array';
import MutableArray from '@ember/array/mutable';
import Mixin from '@ember/object/mixin';
// Get an alias to the global Array type to use i... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | types/preview/@ember/array/index.d.ts | @@ -73,7 +73,7 @@ declare module '@ember/array' {
* implements Ember.Observable, the value will be changed to `set(),` otherwise
* it will be set directly. `null` objects are skipped.
*/
- setEach<K extends keyof T>(key: K, value: T[K]): void;
+ setEach<K extends keyof T>(key: K, value: T[K]): t... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | types/preview/@ember/array/mutable.d.ts | @@ -15,7 +15,7 @@ declare module '@ember/array/mutable' {
/**
* __Required.__ You must implement this method to apply this mixin.
*/
- replace(idx: number, amt: number, objects: T[]): this;
+ replace(idx: number, amt: number, objects: T[]): void;
/**
* Remove all elements from the arra... | true |
Other | emberjs | ember.js | 720c3021213ff8e530c809d37ec3493899448681.json | Improve types for Ember Arrays | types/preview/ember/-private/type-utils.d.ts | @@ -7,16 +7,12 @@ declare module 'ember/-private/type-utils' {
export type AnyMethod<Target> = (this: Target, ...args: any[]) => unknown;
- export type MethodsOf<O> = {
- [K in keyof O]: O[K] extends AnyFn ? O[K] : never;
- };
-
- // Not just `keyof MethodsOf<O>` because that doesn't correctly exclude all ... | true |
Other | emberjs | ember.js | dff8831cdbb5583de443a1859e4f09054687119f.json | Explain the (un)safety of the type of `getOwner()`
The type for `getOwner()` is *technically* unsafe, but this unsafety is
one which end users will rarely hit in practice and, courtesy of Ember's
current types, is unavoidable if `getOwner(someService)` is to correctly
return `Owner` instead of `Owner | undefined`.
Th... | types/preview/@ember/application/index.d.ts | @@ -136,7 +136,14 @@ declare module '@ember/application' {
* objects is the responsibility of an "owner", which handled its
* instantiation and manages its lifetime.
*/
- export function getOwner(object: FrameworkObject): Owner;
+ // SAFETY: this first overload is, strictly speaking, *unsafe*. It is possi... | false |
Other | emberjs | ember.js | cdd04dab708955e862166ce1a00bb2a74b06f26b.json | Add failing type test for `getOwner(Component<S>)`
This catches the scenario where we have a component which actually has
a signature defined:
class Example extends Component<{ Args: { anyWillDo: true } }> {
method() {
getOwner(this); // should be `Owner`, not `| undefined`
}
}
Presently,... | type-tests/preview/@ember/owner-tests.ts | @@ -6,7 +6,11 @@ import Owner, {
Resolver,
KnownForTypeResult,
} from '@ember/owner';
+import Component from '@glimmer/component';
import { expectTypeOf } from 'expect-type';
+// TODO: once we move the runtime export to `@ember/owner`, update this import
+// as well. (That's why it's tested in this module!)
+im... | false |
Other | emberjs | ember.js | 0580eed5c18cdfcd239ccd475e04a1b4c222963c.json | Add v4.8.2 to CHANGELOG
(cherry picked from commit de4ecf64304e04f1543bc1b59cb71ff448b8543c) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v4.8.2 (November 3, 2022)
+
+- [#20244](https://github.com/emberjs/ember.js/pull/20244) Add missing type for `getComponentTemplate` to preview types
+
### v4.9.0-beta.3 (November 2, 2022)
- [CVE pending](https://emberjs.com/blog/ember-4-8-1-released) Fix a prototype polluti... | false |
Other | emberjs | ember.js | cca036eb575e10676e089f0d8efa01edd474cdb1.json | Add v4.9.0-beta.3 to CHANGELOG
(cherry picked from commit 0de013590e92900e5aee664e804ac0fcddf611bd) | CHANGELOG.md | @@ -1,5 +1,13 @@
# Ember Changelog
+### v4.9.0-beta.3 (November 2, 2022)
+
+- [CVE pending](https://emberjs.com/blog/ember-4-8-1-released) Fix a prototype pollution vulnerability in `set` and `setProperties`
+- [#20233](https://github.com/emberjs/ember.js/pull/20233) [BUGFIX] Include package name in deprecation erro... | false |
Other | emberjs | ember.js | 53ca013f87509315200c5969a8f55417af913786.json | Add v4.8.1 to CHANGELOG
(cherry picked from commit 9c226d38d41b7845e27bbd34bf463cbcc1a06cec) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v4.8.1 (November 2, 2022)
+
+- [CVE pending](https://emberjs.com/blog/ember-4-8-1-released) Fix a prototype pollution vulnerability in `set` and `setProperties`
+
### v4.4.4 (November 2, 2022)
- [CVE pending](https://emberjs.com/blog/ember-4-8-1-released) Fix a prototype po... | false |
Other | emberjs | ember.js | 6a17b8417e7e00e15b2b6f0441703f3c74f3fd0c.json | Add v4.4.4 to CHANGELOG
(cherry picked from commit 1dad13a08ae0e1165d83b7d5927e33cd8498c708) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v4.4.4 (November 2, 2022)
+
+- [CVE pending](https://emberjs.com/blog/ember-4-8-1-released) Fix a prototype pollution vulnerability in `set` and `setProperties
+
## v3.28.10 (November 2, 2022)
- [CVE pending](https://emberjs.com/blog/ember-4-8-1-released) Fix a prototype po... | false |
Other | emberjs | ember.js | 701ee45b79b4ee3f860d2c380aa3d87212e3fad5.json | Add v3.28.10 to CHANGELOG
(cherry picked from commit 198d7e168f3c857be4b7da539dd5b3785b2c1452) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+## v3.28.10 (November 2, 2022)
+
+- [CVE pending](https://emberjs.com/blog/ember-4-8-1-released) Fix a prototype pollution vulnerability in `set` and `setProperties`
+
### v3.24.7 (November 2, 2022)
- [CVE pending](https://emberjs.com/blog/ember-4-8-1-released) Fix a prototype ... | false |
Other | emberjs | ember.js | a20bff305ae45840deb07a4a36a09de55073e916.json | Add v3.24.7 to CHANGELOG
(cherry picked from commit 44e20f73ab7c49003d185bef361353412d7a6518) | CHANGELOG.md | @@ -1,6 +1,11 @@
# Ember Changelog
+### v3.24.7 (November 2, 2022)
+
+- [CVE pending](https://emberjs.com/blog/ember-4-8-1-released) Fix a prototype pollution vulnerability in `set` and `setProperties`
+
### v4.9.0-beta.2 (October 25, 2022)
+
- [#20227](https://github.com/emberjs/ember.js/pull/20227) [BUGFIX] Fix ... | false |
Other | emberjs | ember.js | 8bddebebc2df55625b1d1fe92332de3d2885752c.json | Convert packages/ember to TS | packages/@ember/-internals/environment/lib/context.ts | @@ -23,7 +23,7 @@ export const context = (function (
};
})(global, global.Ember);
-export function getLookup(): object {
+export function getLookup(): Record<string, unknown> {
return context.lookup;
}
| true |
Other | emberjs | ember.js | 8bddebebc2df55625b1d1fe92332de3d2885752c.json | Convert packages/ember to TS | packages/@ember/-internals/error-handling/index.ts | @@ -10,7 +10,7 @@ export function getOnerror() {
return onerror;
}
// Ember.onerror setter
-export function setOnerror(handler: Function) {
+export function setOnerror(handler: Function | undefined) {
onerror = handler;
}
| true |
Other | emberjs | ember.js | 8bddebebc2df55625b1d1fe92332de3d2885752c.json | Convert packages/ember to TS | packages/@ember/-internals/glimmer/lib/helper.ts | @@ -44,6 +44,32 @@ export interface SimpleHelper<T, P extends unknown[], N extends Dict<unknown>> {
compute: HelperFunction<T, P, N>;
}
+/**
+ In many cases it is not necessary to use the full `Helper` class.
+ The `helper` method create pure-function helpers without instances.
+ For example:
+
+ ```app/helpe... | true |
Other | emberjs | ember.js | 8bddebebc2df55625b1d1fe92332de3d2885752c.json | Convert packages/ember to TS | packages/@ember/helper/type-tests/invoke-helper.test.ts | @@ -1,4 +1,4 @@
-import Component from '@ember/-internals/glimmer/lib/component';
+import Component from '@ember/component';
import { getValue } from '@ember/-internals/metal';
import Helper from '@ember/component/helper';
import { invokeHelper } from '@ember/helper'; | true |
Other | emberjs | ember.js | 8bddebebc2df55625b1d1fe92332de3d2885752c.json | Convert packages/ember to TS | packages/ember/index.js | @@ -1,619 +0,0 @@
-import require, { has } from 'require';
-
-import { getENV, getLookup, setLookup } from '@ember/-internals/environment';
-import * as utils from '@ember/-internals/utils';
-import { Registry, Container } from '@ember/-internals/container';
-import * as instrumentation from '@ember/instrumentation';
-... | true |
Other | emberjs | ember.js | 8bddebebc2df55625b1d1fe92332de3d2885752c.json | Convert packages/ember to TS | packages/ember/index.ts | @@ -0,0 +1,710 @@
+/**
+@module ember
+*/
+
+import require, { has } from 'require';
+
+import { getENV, getLookup, setLookup } from '@ember/-internals/environment';
+import * as utils from '@ember/-internals/utils';
+import { Registry, Container } from '@ember/-internals/container';
+import * as instrumentation from '... | true |
Other | emberjs | ember.js | 8bddebebc2df55625b1d1fe92332de3d2885752c.json | Convert packages/ember to TS | packages/ember/type-tests/ember.test.ts | @@ -0,0 +1,7 @@
+import Ember from 'ember';
+
+import { expectTypeOf } from 'expect-type';
+
+expectTypeOf(Ember.onerror).toEqualTypeOf<Function | undefined>();
+
+expectTypeOf(Ember.HTMLBars).toMatchTypeOf<object>(); | true |
Other | emberjs | ember.js | 8bddebebc2df55625b1d1fe92332de3d2885752c.json | Convert packages/ember to TS | packages/internal-test-helpers/lib/test-cases/rendering.ts | @@ -2,7 +2,8 @@ import type { EmberPrecompileOptions } from 'ember-template-compiler';
import { compile } from 'ember-template-compiler';
import { EventDispatcher } from '@ember/-internals/views';
import type { Renderer } from '@ember/-internals/glimmer';
-import { helper, Helper, Component, _resetRenderers } from '... | true |
Other | emberjs | ember.js | 8bddebebc2df55625b1d1fe92332de3d2885752c.json | Convert packages/ember to TS | packages/internal-test-helpers/lib/test-cases/router-non-application.ts | @@ -2,7 +2,8 @@ import type { EmberPrecompileOptions } from 'ember-template-compiler';
import { compile } from 'ember-template-compiler';
import { EventDispatcher } from '@ember/-internals/views';
import type { Renderer } from '@ember/-internals/glimmer';
-import { Component, _resetRenderers } from '@ember/-internal... | true |
Other | emberjs | ember.js | 8bddebebc2df55625b1d1fe92332de3d2885752c.json | Convert packages/ember to TS | packages/internal-test-helpers/lib/test-cases/test-resolver-application.ts | @@ -1,7 +1,7 @@
import AbstractApplicationTestCase from './abstract-application';
import type Resolver from '../test-resolver';
import { ModuleBasedResolver } from '../test-resolver';
-import { Component } from '@ember/-internals/glimmer';
+import Component from '@ember/component';
import type { Factory } from '@em... | true |
Other | emberjs | ember.js | 8bddebebc2df55625b1d1fe92332de3d2885752c.json | Convert packages/ember to TS | packages/loader/lib/index.d.ts | @@ -1,9 +1,3 @@
-declare module 'ember' {
- const Ember: any;
-
- export default Ember;
-}
-
declare module 'require' {
export function has(path: string): boolean;
export default function require(path: string): any; | true |
Other | emberjs | ember.js | d61d713c055be1cc2c9c916c46d83af75f9af1ab.json | Add v4.9.0-beta.2 to CHANGELOG
(cherry picked from commit 5c79b3f6d2352fa3ca2ae585e7c1b9662f754d29) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v4.9.0-beta.2 (October 25, 2022)
+- [#20227](https://github.com/emberjs/ember.js/pull/20227) [BUGFIX] Fix unsafe internal cast for NativeArray
+- [#20228](https://github.com/emberjs/ember.js/pull/20228) [BUGFIX] Remove type export for ControllerMixin
+
### v4.9.0-beta.1 (Octob... | false |
Other | emberjs | ember.js | fdbd78031fd98da373af0623fe9c448cf5709550.json | Remove fallback to ember | packages/@ember/debug/lib/deprecate.ts | @@ -91,8 +91,7 @@ if (DEBUG) {
}
if (options?.until) {
- let namespace = options?.for ? options.for : "Ember";
- message = message + ` This will be removed in ${namespace} ${options.until}.`;
+ message = message + ` This will be removed in ${options.for} ${options.until}.`;
}
if (... | false |
Other | emberjs | ember.js | 53affff6b3c8af459442034bcddac09e135a33fb.json | Add v4.9.0-beta.1 to CHANGELOG
(cherry picked from commit 1211052b2aa89ac90009f9b626e542754c9a383a) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v4.9.0-beta.1 (October 17, 2022)
+
+- [#20203](https://github.com/emberjs/ember.js/pull/20203) / [#20204](https://github.com/emberjs/ember.js/pull/20204) [FEATURE] Preview types: Update to Typescript 4.8
+
### v4.8.0 (October 17, 2022)
- [#20180](https://github.com/emberjs... | false |
Other | emberjs | ember.js | 449c9a5cf0264d304805c00ac9937e88bd438111.json | Add v4.8.0 to CHANGELOG
(cherry picked from commit 9021de5a7c49d2556ccbe5f671c1b90a57da4cf1) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v4.8.0 (October 17, 2022)
+
+- [#20180](https://github.com/emberjs/ember.js/pull/20180) [FEATURE] Publish an opt-in preview of public types for Ember
+- [#20166](https://github.com/emberjs/ember.js/pull/20166) [BUGFIX] Upgrade router_js to fix Linked list of RouteInfos contain... | false |
Other | emberjs | ember.js | 1ea72b1cd37d80b45f97f05ef228dfeb13405370.json | Add v4.4.3 to CHANGELOG
(cherry picked from commit fd0f7cbeea607084ae1b29201e1bec56db0c7d5c) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v4.4.3 (October 12, 2022)
+
+- [#20166](https://github.com/emberjs/ember.js/pull/20166) [BUGFIX] Fix missing `RouteInfo` entries
+
### v4.7.1 (October 12, 2022)
- [#20166](https://github.com/emberjs/ember.js/pull/20166) [BUGFIX] Fix missing `RouteInfo` entries | false |
Other | emberjs | ember.js | 908329efd8d45829e960b38740cd95d6493bf732.json | Add v4.7.1 to CHANGELOG
(cherry picked from commit 9113e22b1c820b8ae149293782cd1d5d5ea63a67) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v4.7.1 (October 12, 2022)
+
+- [#20166](https://github.com/emberjs/ember.js/pull/20166) [BUGFIX] Fix missing `RouteInfo` entries
+
### v4.8.0-beta.5 (October 3, 2022)
- [#20212](https://github.com/emberjs/ember.js/pull/20212) [BUGFIX] Remove incorrect exports from preview r... | false |
Other | emberjs | ember.js | 81c10c76d5f074d9113a921e1117c290bda21fe9.json | Add v4.8.0-beta.5 to CHANGELOG
(cherry picked from commit 6cd18e4f675bab791ccc0b22e68b48be34e13c2e) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v4.8.0-beta.5 (October 3, 2022)
+
+- [#20212](https://github.com/emberjs/ember.js/pull/20212) [BUGFIX] Remove incorrect exports from preview routing types
+
### v4.8.0-beta.4 (September 26, 2022)
- [#20201](https://github.com/emberjs/ember.js/pull/20201) [BUGFIX] Fix type d... | false |
Other | emberjs | ember.js | 9921e72527239e0261094258dd69ae1d1a9ad269.json | Fix internal issues caught by TS 4.9
TS 4.9 understands the `in` operator and catches two issues for us which
earlier versions did not:
1. We were checking `name in model` in `Route#serialize` without
checking that `model` there is an object. Given that a route's model
is *not* guaranteed to be an object, this ... | packages/@ember/debug/data-adapter.ts | @@ -10,6 +10,7 @@ import { A as emberA } from '@ember/array';
import type { Cache } from '@glimmer/validator';
import { consumeTag, createCache, getValue, tagFor, untrack } from '@glimmer/validator';
import type ContainerDebugAdapter from '@ember/debug/container-debug-adapter';
+import { assert } from '.';
/**
@... | true |
Other | emberjs | ember.js | 9921e72527239e0261094258dd69ae1d1a9ad269.json | Fix internal issues caught by TS 4.9
TS 4.9 understands the `in` operator and catches two issues for us which
earlier versions did not:
1. We were checking `name in model` in `Route#serialize` without
checking that `model` there is an object. Given that a route's model
is *not* guaranteed to be an object, this ... | packages/@ember/routing/route.ts | @@ -353,7 +353,7 @@ class Route<T = unknown>
if (params.length === 1) {
let [name] = params;
assert('has name', name);
- if (name in model) {
+ if (typeof model === 'object' && name in model) {
object[name] = get(model, name);
} else if (/_id$/.test(name)) {
object[... | true |
Other | emberjs | ember.js | 3ec17789315fec24f63de0e0ab3177feb8906d83.json | Add v4.8.0-beta.4 to CHANGELOG
(cherry picked from commit 4ca204d9618ad3f3603908cb6caba917f8369908) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v4.8.0-beta.4 (September 26, 2022)
+
+- [#20201](https://github.com/emberjs/ember.js/pull/20201) [BUGFIX] Fix type definition for `Route`
+
### v4.8.0-beta.3 (September 19, 2022)
- [#20194](https://github.com/emberjs/ember.js/pull/20194) [BUGFIX] Provide a `.d.ts` file at t... | false |
Other | emberjs | ember.js | 73016e3798fa089512089e28b97b45d4d67a19e1.json | add annotations to comment | packages/@ember/object/observable.ts | @@ -125,6 +125,11 @@ interface Observable {
If this method returns any value other than `undefined`, it will be returned
instead. This allows you to implement "virtual" properties that are
not defined upfront.
+
+ @method get
+ @param {String} keyName The property to retrieve
+ @return {Object} ... | false |
Other | emberjs | ember.js | ef3926a60ffb14690e79902f26d984c49ffab709.json | Fix missing tags lint error | packages/@ember/controller/index.ts | @@ -44,12 +44,14 @@ interface ControllerMixin<T> extends ActionHandler {
as part of the application's initialization process. In most cases the
`target` property will automatically be set to the logical consumer of
actions for the controller.
+ @public
*/
target: unknown | null;
/**
Th... | false |
Other | emberjs | ember.js | a6d6831e242eb410a2d924735746119ccd25c95c.json | fix TypeWatcher invoking itself during onChange | packages/@ember/debug/data-adapter.ts | @@ -1,6 +1,6 @@
import type { Owner } from '@ember/-internals/owner';
import { getOwner } from '@ember/-internals/owner';
-import { _backburner } from '@ember/runloop';
+import { _backburner, next } from '@ember/runloop';
import { get } from '@ember/object';
import { dasherize } from '@ember/string';
import Namesp... | false |
Other | emberjs | ember.js | 46774eba9a2e8956dd7227cdbd08aad96fe74b26.json | Add v4.8.0-beta.3 to CHANGELOG
(cherry picked from commit 975b69e3de1bc8f8f6ad2c5096438c35c712f8ff) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v4.8.0-beta.3 (September 19, 2022)
+
+- [#20194](https://github.com/emberjs/ember.js/pull/20194) [BUGFIX] Provide a `.d.ts` file at types/stable
+- [#20196](https://github.com/emberjs/ember.js/pull/20196) [BUGFIX] types imports are at 'ember-source/types'
+
### v4.8.0-beta.2 ... | false |
Other | emberjs | ember.js | 2290078615a70a22013bc4780b4239bb92e1b534.json | fix license year | LICENSE | @@ -1,4 +1,4 @@
-Copyright (c) 2020 Yehuda Katz, Tom Dale and Ember.js contributors
+Copyright (c) 2022 Yehuda Katz, Tom Dale and Ember.js contributors
Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in | false |
Other | emberjs | ember.js | 40c1c8df3a10896db1f2e66e768b6985a53f208b.json | Use quickfix to fix two typescript errors | packages/@ember/-internals/container/lib/container.ts | @@ -225,13 +225,15 @@ if (DEBUG) {
* Wrap a factory manager in a proxy which will not permit properties to be
* set on the manager.
*/
-function wrapManagerInDeprecationProxy<T extends object, C>(
+function wrapManagerInDeprecationProxy<T extends object, C extends object | FactoryClass>(
manager: FactoryManage... | false |
Other | emberjs | ember.js | 4588ee19a79d635e13ffa15aeaa485b74171e904.json | remove the duplicate doc | packages/@ember/object/observable.ts | @@ -338,138 +338,18 @@ interface Observable {
cacheFor<K extends keyof this>(key: K): unknown;
}
const Observable = Mixin.create({
- /**
- Retrieves the value of a property from the object.
-
- This method is usually similar to using `object[keyName]` or `object.keyName`,
- however it supports both compu... | false |
Other | emberjs | ember.js | eac8bdfaf95a0e04e34f93465c948bfae275b577.json | Use service registry in owner.lookup | type-tests/preview/@ember/owner-tests.ts | @@ -64,6 +64,13 @@ expectTypeOf(owner.lookup('type:name')).toEqualTypeOf<unknown>();
owner.lookup('non-namespace-string');
expectTypeOf(owner.lookup('namespace@type:name')).toEqualTypeOf<unknown>();
+declare module '@ember/service' {
+ interface Registry {
+ 'my-type-test-service': ConstructThis;
+ }
+}
+expec... | true |
Other | emberjs | ember.js | eac8bdfaf95a0e04e34f93465c948bfae275b577.json | Use service registry in owner.lookup | types/preview/@ember/owner/index.d.ts | @@ -1,13 +1,12 @@
declare module '@ember/owner' {
+ import type { Registry } from '@ember/service';
+
/**
* The name for a factory consists of a namespace and the name of a specific
* type within that namespace, like `'service:session'`.
*/
export type FullName = `${string}:${string}`;
- // TODO:... | true |
Other | emberjs | ember.js | f48affedde8e19f617c973b4c01df33dfc475fee.json | Add v4.8.0-beta.1 to CHANGELOG
(cherry picked from commit 72f117864bd5054fd3c0098221ca9770aa0e1137) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v4.8.0-beta.1 (September 6, 2022)
+
+- [#20166](https://github.com/emberjs/ember.js/pull/20166) [BUGFIX] Upgrade router_js to fix Linked list of RouteInfos contains undefined object
+
### v4.7.0 (September 6, 2022)
- [#20126](https://github.com/emberjs/ember.js/pull/20126) ... | false |
Other | emberjs | ember.js | bf16bd3c4b5c209cd68d7704e5c367b488210634.json | Add v4.7.0 to CHANGELOG
(cherry picked from commit 0c59b21bb380daa491d9d9fcb1dc27fd5e56cd5d) | CHANGELOG.md | @@ -1,8 +1,8 @@
# Ember Changelog
-### v4.7.0-beta.1 (July 25, 2022)
+### v4.7.0 (September 6, 2022)
-- [#20126](https://github.com/emberjs/ember.js/pull/20126) [BUGFIX] Replacing Firefox detection that used a deprecated browser API
+- [#20126](https://github.com/emberjs/ember.js/pull/20126) [BUGFIX] Replace Firef... | false |
Other | emberjs | ember.js | 119b42cf214ff9c2bb5855787df68629b32afb16.json | Types preview: remove dead imports
The corresponding module declarations were removed earlier; this simply
drops the 'side-effect' imports from `types/preview/index.d.ts`. | types/preview/index.d.ts | @@ -89,10 +89,7 @@ import './@ember/polyfills';
import './@ember/polyfills/types';
import './@ember/routing';
-import './@ember/routing/-private/route-info'; // TODO: remove
-import './@ember/routing/-private/route-info-with-attributes'; // TODO: remove
import './@ember/routing/-private/router-dsl';
-import './@em... | false |
Other | emberjs | ember.js | 3fcc6d61d00e50ef0ca9f33e28fb8fc6fa4931e9.json | Fix import circularity | packages/@ember/controller/index.ts | @@ -1,4 +1,4 @@
-import { getOwner } from '@ember/application';
+import { getOwner } from '@ember/-internals/owner'; // This is imported from -internals to avoid circularity
import { computed, get } from '@ember/object';
import { FrameworkObject } from '@ember/object/-internals';
import { inject as metalInject } fro... | false |
Other | emberjs | ember.js | 17df5a1fed5cc42dfe511b2f6a2cd94f7ee03832.json | Remove types for array prototype extensions
See previous commit message for discussion of *why* these are being
removed. If we decide to re-introduce these types later, it will require
not only adding back in these tests but also taking some fairly distinct
approach to their inclusion, given the problems with the way ... | package.json | @@ -43,7 +43,6 @@
"lint:eslint:fix": "npm-run-all \"lint:eslint --fix\"",
"lint:tsc:stable": "tsc --noEmit",
"lint:tsc:preview": "tsc --noEmit --project type-tests/preview",
- "lint:tsc:preview-array-ext": "tsc --noEmit --project type-tests/preview-prototype-extensions",
"lint:tsc": "npm-run-all ... | true |
Other | emberjs | ember.js | 17df5a1fed5cc42dfe511b2f6a2cd94f7ee03832.json | Remove types for array prototype extensions
See previous commit message for discussion of *why* these are being
removed. If we decide to re-introduce these types later, it will require
not only adding back in these tests but also taking some fairly distinct
approach to their inclusion, given the problems with the way ... | type-tests/preview-prototype-extensions/README.md | @@ -1 +0,0 @@
-This exists so we can test the *rest* of the system *without* pulling in Array prototype extensions. | true |
Other | emberjs | ember.js | 17df5a1fed5cc42dfe511b2f6a2cd94f7ee03832.json | Remove types for array prototype extensions
See previous commit message for discussion of *why* these are being
removed. If we decide to re-introduce these types later, it will require
not only adding back in these tests but also taking some fairly distinct
approach to their inclusion, given the problems with the way ... | type-tests/preview-prototype-extensions/array-module-ext.ts | @@ -1,21 +0,0 @@
-import EmberObject from '@ember/object';
-import { expectTypeOf } from 'expect-type';
-import type NativeArray from '@ember/array/-private/native-array';
-
-class Person extends EmberObject {
- declare name: string;
-}
-
-const person = Person.create({ name: 'Joe' });
-const array = [person];
-
-expe... | true |
Other | emberjs | ember.js | 17df5a1fed5cc42dfe511b2f6a2cd94f7ee03832.json | Remove types for array prototype extensions
See previous commit message for discussion of *why* these are being
removed. If we decide to re-introduce these types later, it will require
not only adding back in these tests but also taking some fairly distinct
approach to their inclusion, given the problems with the way ... | type-tests/preview-prototype-extensions/ember-namespace-array-ext.ts | @@ -1,18 +0,0 @@
-import Ember from 'ember';
-import { expectTypeOf } from 'expect-type';
-
-class Person extends Ember.Object {
- declare name: string;
-}
-
-const person = Person.create({ name: 'Joe' });
-const array = [person];
-
-expectTypeOf(array.get('length')).toBeNumber();
-expectTypeOf(array.get('firstObject'... | true |
Other | emberjs | ember.js | 17df5a1fed5cc42dfe511b2f6a2cd94f7ee03832.json | Remove types for array prototype extensions
See previous commit message for discussion of *why* these are being
removed. If we decide to re-introduce these types later, it will require
not only adding back in these tests but also taking some fairly distinct
approach to their inclusion, given the problems with the way ... | type-tests/preview-prototype-extensions/index.d.ts | @@ -1,6 +0,0 @@
-import '../../types/preview';
-import type ArrayPrototypeExtensions from '@ember/array/types/prototype-extensions';
-
-declare global {
- interface Array<T> extends ArrayPrototypeExtensions<T> {}
-} | true |
Other | emberjs | ember.js | 17df5a1fed5cc42dfe511b2f6a2cd94f7ee03832.json | Remove types for array prototype extensions
See previous commit message for discussion of *why* these are being
removed. If we decide to re-introduce these types later, it will require
not only adding back in these tests but also taking some fairly distinct
approach to their inclusion, given the problems with the way ... | type-tests/preview-prototype-extensions/tsconfig.json | @@ -1,3 +0,0 @@
-{
- "extends": "@tsconfig/ember/tsconfig.json",
-} | true |
Other | emberjs | ember.js | 17df5a1fed5cc42dfe511b2f6a2cd94f7ee03832.json | Remove types for array prototype extensions
See previous commit message for discussion of *why* these are being
removed. If we decide to re-introduce these types later, it will require
not only adding back in these tests but also taking some fairly distinct
approach to their inclusion, given the problems with the way ... | types/preview/@ember/array/types/prototype-extensions.d.ts | @@ -1,6 +0,0 @@
-declare module '@ember/array/types/prototype-extensions' {
- import Observable from '@ember/object/observable';
- import MutableArray from '@ember/array/mutable';
-
- export default interface ArrayPrototypeExtensions<T> extends MutableArray<T>, Observable {}
-} | true |
Other | emberjs | ember.js | 17df5a1fed5cc42dfe511b2f6a2cd94f7ee03832.json | Remove types for array prototype extensions
See previous commit message for discussion of *why* these are being
removed. If we decide to re-introduce these types later, it will require
not only adding back in these tests but also taking some fairly distinct
approach to their inclusion, given the problems with the way ... | types/preview/ember/index.d.ts | @@ -44,7 +44,6 @@ declare module 'ember' {
import EmberArrayProxy from '@ember/array/proxy';
import type EmberEnumerable from '@ember/array/-private/enumerable';
import type EmberMutableEnumerable from '@ember/array/-private/mutable-enumerable';
- import type EmberArrayProtoExtensions from '@ember/array/types... | true |
Other | emberjs | ember.js | 17df5a1fed5cc42dfe511b2f6a2cd94f7ee03832.json | Remove types for array prototype extensions
See previous commit message for discussion of *why* these are being
removed. If we decide to re-introduce these types later, it will require
not only adding back in these tests but also taking some fairly distinct
approach to their inclusion, given the problems with the way ... | types/preview/index.d.ts | @@ -35,7 +35,6 @@ import './@ember/array/-private/mutable-enumerable';
import './@ember/array/-private/native-array';
import './@ember/array/mutable';
import './@ember/array/proxy';
-import './@ember/array/types/prototype-extensions';
import './@ember/component';
import './@ember/component/-private/class-names-s... | true |
Other | emberjs | ember.js | a0fd30ad4ea3927e23f0563002a4f2c8fc77f7ab.json | Ignore a case where Ember.get is distinct from get
While we would prefer this to work, it is not a hard necessity, for (at
least) two reasons:
1. Use of `Ember.get` vs. the import from `@ember/object` is rare and
should be discouraged.
2. Use of `get` is itself fairly unusual to *need* these days; most
uses ei... | types/preview/ember/test/object.ts | @@ -65,8 +65,18 @@ export class Foo2 extends Ember.Object {
// (currently) possible for the type utility to match it.
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const x: string = Ember.set(this, 'name', name);
+
+ // TODO: it would be nice if we can get this to work correctly; it is... | false |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | packages/@ember/-internals/runtime/lib/mixins/registry_proxy.ts | @@ -12,6 +12,14 @@ import { assert } from '@ember/debug';
// This is defined as a separate interface so that it can be used in the definition of
// `Owner` without also including the `__registry__` property.
export interface IRegistry {
+ /**
+ Given a fullName return the corresponding factory.
+
+ @public
+ ... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/@ember/engine/test/engine.ts | @@ -23,20 +23,20 @@ BaseEngine.instanceInitializer({
},
});
-const Engine1 = BaseEngine.create({
- rootElement: '#engine-one',
- customEvents: {
+class Engine1 extends BaseEngine {
+ rootElement = '#engine-one';
+ customEvents = {
paste: 'paste',
- },
-});
+ };
+}
-const Engine2 = BaseEngine.create({... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/@ember/object/test/create-negative.ts | @@ -1,11 +1,8 @@
-import { assertType } from './lib/assert';
-import { PersonWithNumberName, Person } from './create';
+import { Person } from './create';
// @ts-expect-error
Person.create({ firstName: 99 });
// @ts-expect-error
Person.create({}, { firstName: 99 });
// @ts-expect-error
Person.create({}, {}, { f... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/@ember/object/test/object.ts | @@ -1,102 +1,88 @@
-import EmberObject, { computed, notifyPropertyChange } from '@ember/object';
+import Object, { computed, get, notifyPropertyChange, set, setProperties } from '@ember/object';
+import { expectTypeOf } from 'expect-type';
-const LifetimeHooks = EmberObject.extend({
- resource: undefined as {} | u... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/@ember/object/test/proxy.ts | @@ -1,44 +1,50 @@
import Ember from 'ember';
import ObjectProxy from '@ember/object/proxy';
+import { expectTypeOf } from 'expect-type';
interface Book {
- title: string;
- subtitle: string;
- chapters: Array<{ title: string }>;
+ title: string;
+ subtitle: string;
+ chapters: Array<{ title: string }>;... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/@ember/routing/test/route.ts | @@ -1,3 +1,4 @@
+/* eslint-disable prefer-const */
import Route from '@ember/routing/route';
import Array from '@ember/array';
import EmberObject from '@ember/object';
@@ -9,201 +10,201 @@ class Post extends EmberObject {}
interface Posts extends Array<Post> {}
-Route.extend({
- beforeModel(transition: Trans... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/@ember/runloop/index.d.ts | @@ -3,6 +3,7 @@ import {
EmberMethodParams,
AnyFn,
EmberMethodReturn,
+ AnyMethod,
} from 'ember/-private/type-utils';
import { EmberRunQueues } from './-private/types';
import { EmberRunTimer } from '@ember/runloop/types';
@@ -100,6 +101,12 @@ export function once<T, M extends EmberMethod<T>>(
...args:... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/@ember/service/service-test.ts | @@ -0,0 +1,34 @@
+import Service, { inject, service } from '@ember/service';
+import EmberObject from '@ember/object';
+
+class FirstSvc extends Service {
+ foo = 'bar';
+ first() {
+ return '';
+ }
+}
+const SecondSvc = Service.extend({
+ foo: 'bar',
+ second() {
+ return '';
+ },
+});
+
+declare module '@... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/ember/index.d.ts | @@ -236,7 +236,9 @@ export namespace Ember {
* Can only be used when defining another controller.
*/
function controller(): Controller;
- function controller<K extends keyof ControllerRegistry>(name: K): ControllerRegistry[K];
+ function controller<K extends keyof ControllerRegistry>(
+ name... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/ember/test/access-modifier.ts | @@ -1,42 +0,0 @@
-/**
- * Tests to ensure that access modifier keywords are appropriately
- * respected and supported
- */
-import Ember from 'ember';
-import { assertType } from './lib/assert';
-
-class Foo extends Ember.Object {
- hello() {
- return 'world';
- }
- protected bar() {
- return 'ba... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/ember/test/application-instance.ts | @@ -5,18 +5,18 @@ const appInstance = ApplicationInstance.create();
appInstance.register('some:injection', class Foo {});
appInstance.register('some:injection', class Foo {}, {
- singleton: true,
+ singleton: true,
});
appInstance.register('some:injection', class Foo {}, {
- instantiate: false,
+ instan... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/ember/test/array-proxy.ts | @@ -9,16 +9,16 @@ proxy.set('content', Ember.A(['amoeba', 'paramecium']));
proxy.get('firstObject'); // 'amoeba'
const overridden = Ember.ArrayProxy.create({
- content: Ember.A(pets),
- objectAtContent(idx: number): string {
- return this.get('content').objectAt(idx)!.toUpperCase();
- },
+ content:... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/ember/test/controller.ts | @@ -1,11 +1,11 @@
-import Controller from '@ember/controller';
+import Ember from 'ember';
-Controller.extend({
- queryParams: ['category'],
- category: null,
- isExpanded: false,
+class MyController extends Ember.Controller {
+ queryParams = ['category'];
+ category = null;
+ isExpanded = false;
- t... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/ember/test/create-negative.ts | @@ -1,14 +1,8 @@
-import { assertType } from './lib/assert';
-import Ember from 'ember';
-import { PersonWithNumberName, Person } from './create';
+import { Person } from './create';
// @ts-expect-error
Person.create({ firstName: 99 });
// @ts-expect-error
Person.create({}, { firstName: 99 });
// @ts-expect-erro... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/ember/test/ember-module-tests.ts | @@ -34,8 +34,8 @@ Ember.compare('31', '114'); // $ExpectType number
Ember.debug('some info for developers');
// deprecate
Ember.deprecate("you shouldn't use this anymore", 3 === 3, {
- id: 'no-longer-allowed',
- until: '99.0.0',
+ id: 'no-longer-allowed',
+ until: '99.0.0',
});
// get
Ember.get({ z: 23 },... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/ember/test/engine.ts | @@ -1,40 +1,41 @@
import Ember from 'ember';
-import { assertType } from './lib/assert';
-const BaseEngine = Ember.Engine.extend({
- modulePrefix: 'my-engine',
-});
+class BaseEngine extends Ember.Engine {
+ modulePrefix = 'my-engine';
+}
-class Obj extends Ember.Object.extend({ foo: 'bar' }) {}
+class Obj ext... | true |
Other | emberjs | ember.js | 2dc87a1060efe1dbe8616a7c50d68fa78ed4149b.json | Add sundry improvements to preview types. | types/preview/ember/test/inject.ts | @@ -1,4 +1,5 @@
import Ember from 'ember';
+import { expectTypeOf } from 'expect-type';
class AuthService extends Ember.Service {
declare isAuthenticated: boolean;
@@ -18,13 +19,16 @@ declare module '@ember/service' {
declare module '@ember/controller' {
interface Registry {
- application: ApplicationCo... | true |
Other | emberjs | ember.js | 20c6148c42df5514e8e8a5712e3dbe522a952d8f.json | Fix preview types/tests for @ember/service | types/preview/@ember/service/index.d.ts | @@ -1,22 +1,22 @@
import EmberObject from '@ember/object';
-import ComputedProperty from '@ember/object/computed';
+import type { BasicComputedProperty } from '@ember/object/computed';
export default class Service extends EmberObject {}
/**
* Creates a property that lazily looks up a service in the container. Th... | true |
Other | emberjs | ember.js | 20c6148c42df5514e8e8a5712e3dbe522a952d8f.json | Fix preview types/tests for @ember/service | types/preview/@ember/service/test/main.ts | @@ -1,58 +0,0 @@
-import Service, { inject, service } from '@ember/service';
-import EmberObject from '@ember/object';
-
-class FirstSvc extends Service {
- foo = 'bar';
- first() {
- return '';
- }
-}
-const SecondSvc = Service.extend({
- foo: 'bar',
- second() {
- return '';
- },
-});
... | true |
Other | emberjs | ember.js | 20c6148c42df5514e8e8a5712e3dbe522a952d8f.json | Fix preview types/tests for @ember/service | types/preview/@ember/service/test/octane.ts | @@ -1,34 +0,0 @@
-import Service, { inject, service } from '@ember/service';
-import EmberObject from '@ember/object';
-
-class FirstSvc extends Service {
- foo = 'bar';
- first() {
- return '';
- }
-}
-const SecondSvc = Service.extend({
- foo: 'bar',
- second() {
- return '';
- },
-});
... | true |
Other | emberjs | ember.js | 20c6148c42df5514e8e8a5712e3dbe522a952d8f.json | Fix preview types/tests for @ember/service | types/preview/ember/test/inject.ts | @@ -1,41 +1,41 @@
import Ember from 'ember';
class AuthService extends Ember.Service {
- declare isAuthenticated: boolean;
+ declare isAuthenticated: boolean;
}
class ApplicationController extends Ember.Controller {
- model = {};
- declare string: string;
- transitionToLogin() {}
+ model = {};
+ ... | true |
Other | emberjs | ember.js | d32122b36f28c0781ba3da5d84a4689d975c1b7a.json | Improve preview types and tests for controllers | types/preview/@ember/controller/index.d.ts | @@ -1,6 +1,7 @@
import ActionHandler from '@ember/object/-private/action-handler';
import Mixin from '@ember/object/mixin';
import EmberObject from '@ember/object';
+import type { BasicComputedProperty } from '@ember/object/computed';
type QueryParamTypes = 'boolean' | 'number' | 'array' | 'string';
type QueryPa... | true |
Other | emberjs | ember.js | d32122b36f28c0781ba3da5d84a4689d975c1b7a.json | Improve preview types and tests for controllers | types/preview/@ember/controller/test/main.ts | @@ -1,14 +1,14 @@
import Controller, { inject } from '@ember/controller';
-Controller.extend({
- queryParams: ['category'],
- category: null,
- isExpanded: false,
+class MyController extends Controller {
+ queryParams = ['category'];
+ category = null;
+ isExpanded = false;
- first: inject(),
- s... | true |
Other | emberjs | ember.js | d32122b36f28c0781ba3da5d84a4689d975c1b7a.json | Improve preview types and tests for controllers | types/preview/@ember/controller/test/octane.ts | @@ -1,36 +1,36 @@
import Controller, { inject } from '@ember/controller';
class FirstController extends Controller {
- foo = 'bar';
- @inject declare second: InstanceType<typeof SecondController>;
- @inject() declare otherSecond: InstanceType<typeof SecondController>;
- @inject('second') declare moreSec... | true |
Other | emberjs | ember.js | 69eda9f3e0271cd2bd5d309a3f8ed22b175e34ef.json | Improve preview types and tests for helper | types/preview/@ember/component/helper.d.ts | @@ -21,7 +21,7 @@ declare const Empty: unique symbol;
* themselves, so ***DO NOT RELY ON IT***.
*/
export interface EmptyObject {
- [Empty]?: true;
+ [Empty]?: true;
}
type DefaultPositional = unknown[];
@@ -33,37 +33,37 @@ type DefaultNamed = EmptyObject;
* "normal" signature shape: `Args: { Named: ... | true |
Other | emberjs | ember.js | 69eda9f3e0271cd2bd5d309a3f8ed22b175e34ef.json | Improve preview types and tests for helper | types/preview/@ember/component/test/helper.ts | @@ -1,120 +1,142 @@
import Helper, { ExpandSignature, helper } from '@ember/component/helper';
class DeprecatedSignatureForm extends Helper<{
- PositionalArgs: [offset: Date];
- Return: Date;
+ PositionalArgs: [offset: Date];
+ Return: Date;
}> {
- timer?: ReturnType<typeof setInterval> | undefined;
- ... | true |
Other | emberjs | ember.js | d95a927fdcd851bbada245190f94d024734d6d30.json | Fix preview type tests for Ember Component | types/preview/@ember/component/test/component.ts | @@ -1,141 +1,138 @@
import Component from '@ember/component';
import Object, { computed, get } from '@ember/object';
-import hbs from 'htmlbars-inline-precompile';
import { assertType } from './lib/assert';
Component.extend({
- layout: hbs`
- <div>
- {{yield}}
- </div>
- `,
-});
-
-Co... | true |
Other | emberjs | ember.js | d95a927fdcd851bbada245190f94d024734d6d30.json | Fix preview type tests for Ember Component | types/preview/ember/test/component.ts | @@ -1,124 +1,119 @@
import Ember from 'ember';
-import Component from '@ember/component';
-import Object, { computed } from '@ember/object';
-import hbs from 'htmlbars-inline-precompile';
-import { assertType } from './lib/assert';
-
-Component.extend({
- layout: hbs`
- <div>
- {{yield}}
- </... | true |
Other | emberjs | ember.js | 4730ecd8b7a8e6b7b3f560fb7dabd3de605c3753.json | Fix preview types and tests for `Evented` | types/preview/@ember/object/test/event.ts | @@ -1,92 +1,96 @@
-import EmberObject, { observer } from '@ember/object';
+import EmberObject from '@ember/object';
import { sendEvent, addListener, removeListener } from '@ember/object/events';
import Evented, { on } from '@ember/object/evented';
function testOn() {
- const Job = EmberObject.extend({
- ... | true |
Other | emberjs | ember.js | 4730ecd8b7a8e6b7b3f560fb7dabd3de605c3753.json | Fix preview types and tests for `Evented` | types/preview/ember/index.d.ts | @@ -138,6 +138,7 @@ export namespace Ember {
const Error: typeof EmberError;
const Evented: typeof EmberObjectEventedNs.default;
+ interface Evented extends EmberObjectEventedNs.default {}
class Mixin extends EmberMixin {}
| true |
Other | emberjs | ember.js | 4730ecd8b7a8e6b7b3f560fb7dabd3de605c3753.json | Fix preview types and tests for `Evented` | types/preview/ember/test/event.ts | @@ -1,60 +1,61 @@
import Ember from 'ember';
function testOn() {
- const Job = Ember.Object.extend({
- logCompleted: Ember.on('completed', () => {
- console.log('Job completed!');
- }),
- });
+ const Job = Ember.Object.extend({
+ logCompleted: Ember.on('completed', () => {
+ ... | true |
Other | emberjs | ember.js | 52abdf166e8a5c80063a6a6f59a6dfb7682d6287.json | Update preview types for @ember/controller | types/preview/@ember/controller/index.d.ts | @@ -1,7 +1,6 @@
import ActionHandler from '@ember/object/-private/action-handler';
import Mixin from '@ember/object/mixin';
import EmberObject from '@ember/object';
-import ComputedProperty from '@ember/object/computed';
type QueryParamTypes = 'boolean' | 'number' | 'array' | 'string';
type QueryParamScopeTypes ... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.