language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
Homebrew
brew
4836ea0ba2119619697af87edf5fdb2280e90238.json
Remove XQuartz handling
Library/Homebrew/test/support/fixtures/cask/Casks/invalid/invalid-depends-on-x11-value.rb
@@ -1,11 +0,0 @@ -cask "invalid-depends-on-x11-value" do - version "1.2.3" - sha256 "67cdb8a02803ef37fdbf7e0be205863172e41a561ca446cd84f0d7ab35a99d94" - - url "file://#{TEST_FIXTURE_DIR}/cask/caffeine.zip" - homepage "https://brew.sh/invalid-depends-on-x11-value" - - depends_on x11: :no_such_value - - app "Caffeine.app" -end
true
Other
Homebrew
brew
92ef8f5c0d1f5eb3c26be0d92cf058d705aac985.json
`cask/audit`: fix arg handling
Library/Homebrew/cask/audit.rb
@@ -27,15 +27,16 @@ def initialize(cask, appcast: nil, download: nil, quarantine: nil, new_cask: nil) # `new_cask` implies `online` and `strict` - online = new_cask if online.nil? - strict = new_cask if strict.nil? + online = new_cask if online.blank? + strict = new_cask if strict.blank? # `online` implies `appcast` and `download` - appcast = online if appcast.nil? - download = online if download.nil? + appcast = online if appcast.nil? # `appcast` is `nil` if neither `--appcast` nor `--no-appcast` are passed + download = online if download.blank? + odie online # `new_cask` implies `token_conflicts` - token_conflicts = new_cask if token_conflicts.nil? + token_conflicts = new_cask if token_conflicts.blank? @cask = cask @appcast = appcast
true
Other
Homebrew
brew
92ef8f5c0d1f5eb3c26be0d92cf058d705aac985.json
`cask/audit`: fix arg handling
manpages/brew.1
@@ -1,7 +1,7 @@ .\" generated with Ronn/v0.7.3 .\" http://github.com/rtomayko/ronn/tree/0.7.3 . -.TH "BREW" "1" "October 2021" "Homebrew" "brew" +.TH "BREW" "1" "November 2021" "Homebrew" "brew" . .SH "NAME" \fBbrew\fR \- The Missing Package Manager for macOS (or Linux)
true
Other
Homebrew
brew
0b459aebda7443d62a4ef6b4f8455e0ce8804791.json
Update RBI files for i18n.
Library/Homebrew/sorbet/rbi/gems/i18n@1.8.11.rbi
@@ -1,9 +1,9 @@ +# typed: true + # DO NOT EDIT MANUALLY # This is an autogenerated file for types exported from the `i18n` gem. # Please instead update this file by running `bin/tapioca gem i18n`. -# typed: true - module I18n extend ::I18n::Base
false
Other
Homebrew
brew
952ef77fe1411af82cb1a7f48c688836d9853cf3.json
Update RBI files for rspec-support.
Library/Homebrew/sorbet/rbi/gems/rspec-support@3.10.3.rbi
@@ -1,9 +1,9 @@ +# typed: true + # DO NOT EDIT MANUALLY # This is an autogenerated file for types exported from the `rspec-support` gem. # Please instead update this file by running `bin/tapioca gem rspec-support`. -# typed: true - module RSpec extend ::RSpec::Support::Warnings extend ::RSpec::Core::Warnings
false
Other
Homebrew
brew
77273fe2b3b56ab84dce4d03b47b1129c949e19e.json
Cask::Audit: Handle referenced cask in livecheck `Cask::Audit#check_livecheck_version` was never updated to handle a referenced cask in a `livecheck` block (e.g., `cask "other-cask"`). As a result, this audit will wrongly give an error like `Version '1.2.3' differs from '' retrieved by livecheck.` in this scenario. This commit ensures that a referenced cask is handled by the audit and it won't error when the referenced check provides a good version.
Library/Homebrew/cask/audit.rb
@@ -553,11 +553,24 @@ def check_download def check_livecheck_version return unless appcast? + referenced_cask, = Homebrew::Livecheck.resolve_livecheck_reference(cask) + + # Respect skip conditions for a referenced cask + if referenced_cask + skip_info = Homebrew::Livecheck::SkipConditions.referenced_skip_information( + referenced_cask, + Homebrew::Livecheck.cask_name(cask), + ) + end + # Respect cask skip conditions (e.g. discontinued, latest, unversioned) - skip_info = Homebrew::Livecheck::SkipConditions.skip_information(cask) + skip_info ||= Homebrew::Livecheck::SkipConditions.skip_information(cask) return :skip if skip_info.present? - latest_version = Homebrew::Livecheck.latest_version(cask)&.fetch(:latest) + latest_version = Homebrew::Livecheck.latest_version( + cask, + referenced_formula_or_cask: referenced_cask, + )&.fetch(:latest) if cask.version.to_s == latest_version.to_s if cask.appcast add_error "Version '#{latest_version}' was automatically detected by livecheck; " \
true
Other
Homebrew
brew
77273fe2b3b56ab84dce4d03b47b1129c949e19e.json
Cask::Audit: Handle referenced cask in livecheck `Cask::Audit#check_livecheck_version` was never updated to handle a referenced cask in a `livecheck` block (e.g., `cask "other-cask"`). As a result, this audit will wrongly give an error like `Version '1.2.3' differs from '' retrieved by livecheck.` in this scenario. This commit ensures that a referenced cask is handled by the audit and it won't error when the referenced check provides a good version.
Library/Homebrew/test/cask/audit_spec.rb
@@ -421,23 +421,47 @@ def tmp_cask(name, text) it { is_expected.not_to fail_with(message) } end + context "when the Cask has a livecheck block referencing a Cask using skip" do + let(:cask_token) { "livecheck/livecheck-skip-reference" } + + it { is_expected.not_to fail_with(message) } + end + context "when the Cask is discontinued" do let(:cask_token) { "livecheck/discontinued" } it { is_expected.not_to fail_with(message) } end + context "when the Cask has a livecheck block referencing a discontinued Cask" do + let(:cask_token) { "livecheck/discontinued-reference" } + + it { is_expected.not_to fail_with(message) } + end + context "when version is :latest" do let(:cask_token) { "livecheck/version-latest" } it { is_expected.not_to fail_with(message) } end + context "when the Cask has a livecheck block referencing a Cask where version is :latest" do + let(:cask_token) { "livecheck/version-latest-reference" } + + it { is_expected.not_to fail_with(message) } + end + context "when url is unversioned" do let(:cask_token) { "livecheck/url-unversioned" } it { is_expected.not_to fail_with(message) } end + + context "when the Cask has a livecheck block referencing a Cask with an unversioned url" do + let(:cask_token) { "livecheck/url-unversioned-reference" } + + it { is_expected.not_to fail_with(message) } + end end describe "when the Cask stanza requires uninstall" do
true
Other
Homebrew
brew
77273fe2b3b56ab84dce4d03b47b1129c949e19e.json
Cask::Audit: Handle referenced cask in livecheck `Cask::Audit#check_livecheck_version` was never updated to handle a referenced cask in a `livecheck` block (e.g., `cask "other-cask"`). As a result, this audit will wrongly give an error like `Version '1.2.3' differs from '' retrieved by livecheck.` in this scenario. This commit ensures that a referenced cask is handled by the audit and it won't error when the referenced check provides a good version.
Library/Homebrew/test/support/fixtures/cask/Casks/livecheck/discontinued-reference.rb
@@ -0,0 +1,18 @@ +cask "discontinued-reference" do + version "1.2.3" + sha256 "8c62a2b791cf5f0da6066a0a4b6e85f62949cd60975da062df44adf887f4370b" + + # This cask is used in --online tests, so we use fake URLs to avoid impacting + # real servers. The URL paths are specific enough that they'll be + # understandable if they appear in local server logs. + url "http://localhost/homebrew/test/cask/audit/livecheck/discontinued-#{version}.dmg" + name "Discontinued Reference" + desc "Cask for testing a livecheck reference to a discontinued cask" + homepage "http://localhost/homebrew/test/cask/audit/livecheck/discontinued" + + livecheck do + cask "livecheck/discontinued" + end + + app "TestCask.app" +end
true
Other
Homebrew
brew
77273fe2b3b56ab84dce4d03b47b1129c949e19e.json
Cask::Audit: Handle referenced cask in livecheck `Cask::Audit#check_livecheck_version` was never updated to handle a referenced cask in a `livecheck` block (e.g., `cask "other-cask"`). As a result, this audit will wrongly give an error like `Version '1.2.3' differs from '' retrieved by livecheck.` in this scenario. This commit ensures that a referenced cask is handled by the audit and it won't error when the referenced check provides a good version.
Library/Homebrew/test/support/fixtures/cask/Casks/livecheck/livecheck-skip-reference.rb
@@ -0,0 +1,18 @@ +cask "livecheck-skip-reference" do + version "1.2.3" + sha256 "8c62a2b791cf5f0da6066a0a4b6e85f62949cd60975da062df44adf887f4370b" + + # This cask is used in --online tests, so we use fake URLs to avoid impacting + # real servers. The URL paths are specific enough that they'll be + # understandable if they appear in local server logs. + url "http://localhost/homebrew/test/cask/audit/livecheck/livecheck-skip-#{version}.dmg" + name "Skip Reference" + desc "Cask for testing a livecheck reference to a cask with a #skip livecheck block" + homepage "http://localhost/homebrew/test/cask/audit/livecheck/livecheck-skip" + + livecheck do + cask "livecheck/livecheck-skip" + end + + app "TestCask.app" +end
true
Other
Homebrew
brew
77273fe2b3b56ab84dce4d03b47b1129c949e19e.json
Cask::Audit: Handle referenced cask in livecheck `Cask::Audit#check_livecheck_version` was never updated to handle a referenced cask in a `livecheck` block (e.g., `cask "other-cask"`). As a result, this audit will wrongly give an error like `Version '1.2.3' differs from '' retrieved by livecheck.` in this scenario. This commit ensures that a referenced cask is handled by the audit and it won't error when the referenced check provides a good version.
Library/Homebrew/test/support/fixtures/cask/Casks/livecheck/url-unversioned-reference.rb
@@ -0,0 +1,18 @@ +cask "url-unversioned-reference" do + version "1.2.3" + sha256 "8c62a2b791cf5f0da6066a0a4b6e85f62949cd60975da062df44adf887f4370b" + + # This cask is used in --online tests, so we use fake URLs to avoid impacting + # real servers. The URL paths are specific enough that they'll be + # understandable if they appear in local server logs. + url "http://localhost/homebrew/test/cask/audit/livecheck/url-unversioned.dmg" + name "Unversioned URL Reference" + desc "Cask for testing a livecheck reference to a cask with an unversioned URL" + homepage "http://localhost/homebrew/test/cask/audit/livecheck/url-unversioned" + + livecheck do + cask "livecheck/url-unversioned" + end + + app "TestCask.app" +end
true
Other
Homebrew
brew
77273fe2b3b56ab84dce4d03b47b1129c949e19e.json
Cask::Audit: Handle referenced cask in livecheck `Cask::Audit#check_livecheck_version` was never updated to handle a referenced cask in a `livecheck` block (e.g., `cask "other-cask"`). As a result, this audit will wrongly give an error like `Version '1.2.3' differs from '' retrieved by livecheck.` in this scenario. This commit ensures that a referenced cask is handled by the audit and it won't error when the referenced check provides a good version.
Library/Homebrew/test/support/fixtures/cask/Casks/livecheck/version-latest-reference.rb
@@ -0,0 +1,18 @@ +cask "version-latest-reference" do + version :latest + sha256 :no_check + + # This cask is used in --online tests, so we use fake URLs to avoid impacting + # real servers. The URL paths are specific enough that they'll be + # understandable if they appear in local server logs. + url "http://localhost/homebrew/test/cask/audit/livecheck/version-latest.dmg" + name "Version Latest Reference" + desc "Cask for testing a livecheck reference to a cask where version is :latest" + homepage "http://localhost/homebrew/test/cask/audit/livecheck/version-latest" + + livecheck do + cask "livecheck/version-latest" + end + + app "TestCask.app" +end
true
Other
Homebrew
brew
9a4041d0dd00dede8e8398f5910c6322559ee16b.json
Update RBI files for yard-sorbet.
Library/Homebrew/sorbet/rbi/gems/yard-sorbet@0.6.1.rbi
@@ -49,6 +49,11 @@ end class YARDSorbet::Handlers::MixesInClassMethodsHandler < ::YARD::Handlers::Ruby::Base sig { void } def process; end + + class << self + sig { params(code_obj: String).returns(T.nilable(String)) } + def mixed_in_class_methods(code_obj); end + end end class YARDSorbet::Handlers::SigHandler < ::YARD::Handlers::Ruby::Base
false
Other
Homebrew
brew
a2cd969ddc55226f2682841c1cb530979d6b8456.json
Update RBI files for rubocop-performance.
Library/Homebrew/sorbet/rbi/gems/rubocop-performance@1.12.0.rbi
@@ -1,9 +1,9 @@ +# typed: true + # DO NOT EDIT MANUALLY # This is an autogenerated file for types exported from the `rubocop-performance` gem. # Please instead update this file by running `bin/tapioca gem rubocop-performance`. -# typed: true - module RuboCop; end module RuboCop::Cop; end module RuboCop::Cop::Performance; end @@ -202,6 +202,16 @@ end RuboCop::Cop::Performance::CompareWithBlock::MSG = T.let(T.unsafe(nil), String) +class RuboCop::Cop::Performance::ConcurrentMonotonicTime < ::RuboCop::Cop::Base + extend ::RuboCop::Cop::AutoCorrector + + def concurrent_monotonic_time?(param0 = T.unsafe(nil)); end + def on_send(node); end +end + +RuboCop::Cop::Performance::ConcurrentMonotonicTime::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::Performance::ConcurrentMonotonicTime::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) + class RuboCop::Cop::Performance::ConstantRegexp < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector @@ -236,7 +246,6 @@ RuboCop::Cop::Performance::Count::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) class RuboCop::Cop::Performance::DeletePrefix < ::RuboCop::Cop::Base include ::RuboCop::Cop::RegexpMetacharacter extend ::RuboCop::Cop::AutoCorrector - extend ::RuboCop::Cop::TargetRubyVersion def delete_prefix_candidate?(param0 = T.unsafe(nil)); end def on_send(node); end @@ -249,7 +258,6 @@ RuboCop::Cop::Performance::DeletePrefix::RESTRICT_ON_SEND = T.let(T.unsafe(nil), class RuboCop::Cop::Performance::DeleteSuffix < ::RuboCop::Cop::Base include ::RuboCop::Cop::RegexpMetacharacter extend ::RuboCop::Cop::AutoCorrector - extend ::RuboCop::Cop::TargetRubyVersion def delete_suffix_candidate?(param0 = T.unsafe(nil)); end def on_send(node); end @@ -437,6 +445,7 @@ class RuboCop::Cop::Performance::RedundantBlockCall < ::RuboCop::Cop::Base def blockarg_calls(param0, param1); end def blockarg_def(param0 = T.unsafe(nil)); end def on_def(node); end + def on_defs(node); end private @@ -454,7 +463,6 @@ RuboCop::Cop::Performance::RedundantBlockCall::YIELD = T.let(T.unsafe(nil), Stri class RuboCop::Cop::Performance::RedundantEqualityComparisonBlock < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector - extend ::RuboCop::Cop::TargetRubyVersion def on_block(node); end
false
Other
Homebrew
brew
aa6f10ff356e6bae2b53ee1c7cdafa26aa4c3ded.json
install, upgrade: fetch each formula only once
Library/Homebrew/formula_installer.rb
@@ -114,6 +114,15 @@ def self.clear_installed @installed = Set.new end + def self.fetched + @fetched ||= Set.new + end + + sig { void } + def self.clear_fetched + @fetched = Set.new + end + sig { returns(T::Boolean) } def build_from_source? @build_from_source_formulae.include?(formula.full_name) @@ -1141,6 +1150,8 @@ def fetch_dependencies sig { void } def fetch + return if self.class.fetched.include?(formula) + fetch_dependencies return if only_deps? @@ -1152,6 +1163,8 @@ def fetch formula.resources.each(&:fetch) end downloader.fetch + + self.class.fetched << formula end def downloader
true
Other
Homebrew
brew
aa6f10ff356e6bae2b53ee1c7cdafa26aa4c3ded.json
install, upgrade: fetch each formula only once
Library/Homebrew/test/spec_helper.rb
@@ -204,6 +204,7 @@ def find_files Requirement.clear_cache FormulaInstaller.clear_attempted FormulaInstaller.clear_installed + FormulaInstaller.clear_fetched TEST_DIRECTORIES.each(&:mkpath)
true
Other
Homebrew
brew
73bc934c85dd6fabf44076482affe267cd21c5a6.json
Caveats: suggest brew services for linux
Library/Homebrew/caveats.rb
@@ -40,7 +40,7 @@ def caveats caveats << function_completion_caveats(shell) end - caveats << plist_caveats + caveats << service_caveats caveats << elisp_caveats caveats.compact.join("\n") end @@ -151,39 +151,53 @@ def elisp_caveats EOS end - def plist_caveats - return if !f.plist_manual && !f.service? + def service_caveats + return if !f.plist && !f.service? && !keg&.plist_installed? + + s = [] command = if f.service? f.service.manual_command else f.plist_manual end - # Default to brew services not being supported. macOS overrides this behavior. - <<~EOS + return <<~EOS if !which("launchctl") && f.plist #{Formatter.warning("Warning:")} #{f.name} provides a launchd plist which can only be used on macOS! You can manually execute the service instead with: #{command} EOS - end - def plist_path - destination = if f.plist_startup - "/Library/LaunchDaemons" + # Brew services only works with these two tools + return <<~EOS if !which("systemctl") && !which("launchctl") && f.service? + #{Formatter.warning("Warning:")} #{f.name} provides a service which can only be used on macOS or systemd! + You can manually execute the service instead with: + #{command} + EOS + + is_running_service = f.service? && quiet_system("ps aux | grep #{f.service.command&.first}") + if is_running_service || (f.plist && quiet_system("/bin/launchctl list #{f.plist_name} &>/dev/null")) + s << "To restart #{f.full_name} after an upgrade:" + s << " #{f.plist_startup ? "sudo " : ""}brew services restart #{f.full_name}" + elsif f.plist_startup + s << "To start #{f.full_name} now and restart at startup:" + s << " sudo brew services start #{f.full_name}" else - "~/Library/LaunchAgents" + s << "To start #{f.full_name} now and restart at login:" + s << " brew services start #{f.full_name}" end - plist_filename = if f.plist - f.plist_path.basename - else - File.basename Dir["#{keg}/*.plist"].first + if f.plist_manual || f.service? + s << "Or, if you don't want/need a background service you can just run:" + s << " #{command}" end - destination_path = Pathname.new(File.expand_path(destination)) - destination_path/plist_filename + # pbpaste is the system clipboard tool on macOS and fails with `tmux` by default + # check if this is being run under `tmux` to avoid failing + if ENV["HOMEBREW_TMUX"] && !quiet_system("/usr/bin/pbpaste") + s << "" << "WARNING: brew services will fail when run under tmux." + end + + "#{s.join("\n")}\n" unless s.empty? end end - -require "extend/os/caveats"
true
Other
Homebrew
brew
73bc934c85dd6fabf44076482affe267cd21c5a6.json
Caveats: suggest brew services for linux
Library/Homebrew/extend/os/caveats.rb
@@ -1,4 +0,0 @@ -# typed: strict -# frozen_string_literal: true - -require "extend/os/mac/caveats" if OS.mac?
true
Other
Homebrew
brew
73bc934c85dd6fabf44076482affe267cd21c5a6.json
Caveats: suggest brew services for linux
Library/Homebrew/extend/os/mac/caveats.rb
@@ -1,63 +0,0 @@ -# typed: true -# frozen_string_literal: true - -class Caveats - undef plist_caveats - - def plist_caveats - s = [] - return if !f.plist && !f.service? && !keg&.plist_installed? - - plist_domain = f.plist_path.basename(".plist") - - # we readlink because this path probably doesn't exist since caveats - # occurs before the link step of installation - # Yosemite security measures mildly tighter rules: - # https://github.com/Homebrew/legacy-homebrew/issues/33815 - if f.plist && (!plist_path.file? || !plist_path.symlink?) - if f.plist_startup - s << "To have launchd start #{f.full_name} now and restart at startup:" - s << " sudo brew services start #{f.full_name}" - else - s << "To have launchd start #{f.full_name} now and restart at login:" - s << " brew services start #{f.full_name}" - end - # For startup plists, we cannot tell whether it's running on launchd, - # as it requires for `sudo launchctl list` to get real result. - elsif f.plist_startup - s << "To restart #{f.full_name} after an upgrade:" - s << " sudo brew services restart #{f.full_name}" - elsif Kernel.system "/bin/launchctl list #{plist_domain} &>/dev/null" - s << "To restart #{f.full_name} after an upgrade:" - s << " brew services restart #{f.full_name}" - else - s << "To start #{f.full_name}:" - s << " brew services start #{f.full_name}" - end - - if f.plist_manual || f.service? - command = if f.service? - f.service - .command - .map do |arg| - next arg unless arg.match?(/\s/) - - # quote multi-word arguments - "'#{arg}'" - end.join(" ") - else - f.plist_manual - end - - s << "Or, if you don't want/need a background service you can just run:" - s << " #{command}" - end - - # pbpaste is the system clipboard tool on macOS and fails with `tmux` by default - # check if this is being run under `tmux` to avoid failing - if ENV["HOMEBREW_TMUX"] && !quiet_system("/usr/bin/pbpaste") - s << "" << "WARNING: brew services will fail when run under tmux." - end - "#{s.join("\n")}\n" unless s.empty? - end -end
true
Other
Homebrew
brew
73bc934c85dd6fabf44076482affe267cd21c5a6.json
Caveats: suggest brew services for linux
Library/Homebrew/test/caveats_spec.rb
@@ -33,6 +33,17 @@ def caveats describe "#caveats" do context "when f.plist is not nil", :needs_macos do + it "prints error when no launchd is present" do + f = formula do + url "foo-1.0" + def plist + "plist_test.plist" + end + end + allow_any_instance_of(Object).to receive(:which).with("launchctl").and_return(nil) + expect(described_class.new(f).caveats).to include("provides a launchd plist which can only be used on macOS!") + end + it "prints plist startup information when f.plist_startup is not nil" do f = formula do url "foo-1.0" @@ -66,40 +77,13 @@ def plist plist_path = mktmpdir/"plist" FileUtils.touch plist_path allow(f_obj).to receive(:plist_path).and_return(plist_path) + allow(Homebrew).to receive(:_system).and_return(true) + allow(Homebrew).to receive(:_system).with("/bin/launchctl list #{f.plist_name} &>/dev/null").and_return(true) allow(plist_path).to receive(:symlink?).and_return(true) expect(f_obj.caveats).to include("restart #{f.full_name}") expect(f_obj.caveats).to include("sudo") end - context "when plist_path is not a file nor symlinked and plist_startup is false" do - let(:f) { - formula do - url "foo-1.0" - def plist - "plist_test.plist" - end - end - } - let(:f_obj) { described_class.new(f) } - let(:caveats) { f_obj.caveats } - let(:plist_path) { mktmpdir/"plist" } - - before do - FileUtils.touch plist_path - allow(f_obj).to receive(:plist_path).and_return(plist_path) - allow(plist_path).to receive(:symlink?).and_return(true) - end - - it "tells command to run after upgrade" do - allow(Kernel).to receive(:system).with(any_args).and_return(true) - expect(caveats).to include("restart #{f.full_name} after an upgrade") - end - - it "tells command to run to start formula" do - expect(caveats).to include("To start #{f.full_name}:") - end - end - it "gives information about plist_manual" do f = formula do url "foo-1.0" @@ -128,33 +112,94 @@ def plist expect(caveats).to include("background service") end - it "wraps multi-word service parameters" do + it "warns about brew failing under tmux" do f = formula do url "foo-1.0" - service do - run [bin/"nginx", "-g", "daemon off;"] + def plist + "plist_test.plist" end end + ENV["HOMEBREW_TMUX"] = "1" + allow(Homebrew).to receive(:_system).and_return(true) + allow(Homebrew).to receive(:_system).with("/usr/bin/pbpaste").and_return(false) caveats = described_class.new(f).caveats - expect(f.service?).to eq(true) - expect(caveats).to include("#{f.bin}/nginx -g 'daemon off;'") - expect(caveats).to include("background service") + expect(caveats).to include("WARNING:") + expect(caveats).to include("tmux") end + end - it "warns about brew failing under tmux" do + context "when f.service is not nil" do + it "prints warning when no service deamon is found" do f = formula do url "foo-1.0" - def plist - "plist_test.plist" + service do + run [bin/"cmd"] end + plist_options startup: true end - ENV["HOMEBREW_TMUX"] = "1" - allow(Homebrew).to receive(:_system).with("/usr/bin/pbpaste").and_return(false) + + allow_any_instance_of(Object).to receive(:which).with("launchctl").and_return(nil) + allow_any_instance_of(Object).to receive(:which).with("systemctl").and_return(nil) + expect(described_class.new(f).caveats).to include("service which can only be used on macOS or systemd!") + end + + it "prints service startup information when f.plist_startup is not nil" do + f = formula do + url "foo-1.0" + service do + run [bin/"cmd"] + end + plist_options startup: true + end + cmd = "#{HOMEBREW_CELLAR}/formula_name/1.0/bin/cmd" + allow(Homebrew).to receive(:_system).and_return(true) + allow(Homebrew).to receive(:_system).with("ps aux | grep #{cmd}").and_return(false) + expect(described_class.new(f).caveats).to include("startup") + end + + it "prints service login information when f.plist_startup is nil" do + f = formula do + url "foo-1.0" + service do + run [bin/"cmd"] + end + end + cmd = "#{HOMEBREW_CELLAR}/formula_name/1.0/bin/cmd" + allow(Homebrew).to receive(:_system).and_return(true) + allow(Homebrew).to receive(:_system).with("ps aux | grep #{cmd}").and_return(false) + expect(described_class.new(f).caveats).to include("login") + end + + it "gives information about restarting services after upgrade" do + f = formula do + url "foo-1.0" + service do + run [bin/"cmd"] + end + plist_options startup: true + end + cmd = "#{HOMEBREW_CELLAR}/formula_name/1.0/bin/cmd" + f_obj = described_class.new(f) + allow(Homebrew).to receive(:_system).and_return(true) + allow(Homebrew).to receive(:_system).with("ps aux | grep #{cmd}").and_return(true) + expect(f_obj.caveats).to include("restart #{f.full_name}") + expect(f_obj.caveats).to include("sudo") + end + + it "gives information about service manual command" do + f = formula do + url "foo-1.0" + service do + run [bin/"cmd", "start"] + environment_variables VAR: "foo" + end + end + cmd = "#{HOMEBREW_CELLAR}/formula_name/1.0/bin/cmd" caveats = described_class.new(f).caveats - expect(caveats).to include("WARNING:") - expect(caveats).to include("tmux") + expect(caveats).to include("background service") + expect(caveats).to include("VAR=\"foo\" #{cmd} start") end end
true
Other
Homebrew
brew
e6e0ba0521576ee81630bd25abe60b412a529408.json
cask cookbook: update livecheck blocks This change causes `livecheck` to return a nicer error if no match is found from the regex.
docs/Cask-Cookbook.md
@@ -748,6 +748,8 @@ If the version depends on multiple header fields, a block can be specified, e.g. strategy :header_match do |headers| v = headers["content-disposition"][/MyApp-(\d+(?:\.\d+)*)\.zip/i, 1] id = headers["location"][%r{/(\d+)/download$}i, 1] + next if v.blank? || id.blank? + "#{v},#{id}" end ``` @@ -757,6 +759,8 @@ Similarly, the `:page_match` strategy can also be used for more complex versions ```ruby strategy :page_match do |page| match = page.match(%r{href=.*?/(\d+)/MyApp-(\d+(?:\.\d+)*)\.zip}i) + next if match.blank? + "#{match[2]},#{match[1]}" end ```
false
Other
Homebrew
brew
aa95c17c8ee45c1d12b0b33121d561723a738a7e.json
keg_relocate: enable Java relocation for bottles This is a continuation of #12334.
Library/Homebrew/keg_relocate.rb
@@ -98,8 +98,8 @@ def prepare_relocation_to_placeholders relocation.add_replacement_pair(:perl, %r{\A#!(?:/usr/bin/perl\d\.\d+|#{HOMEBREW_PREFIX}/opt/perl/bin/perl)( |$)}o, "#!#{PERL_PLACEHOLDER}\\1") - # TODO: Enable relocation upon bottling when relocation upon pouring is in a brew release tag. - # relocation.add_replacement_pair(:java, JAVA_REGEX, JAVA_PLACEHOLDER) + relocation.add_replacement_pair(:java, JAVA_REGEX, JAVA_PLACEHOLDER) + relocation end alias generic_prepare_relocation_to_placeholders prepare_relocation_to_placeholders
false
Other
Homebrew
brew
457de40117188880f15a864d1ac3dd437274ea07.json
Apply suggestions from code review These are just a few style improvements. Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Library/Homebrew/extend/os/mac/keg_relocate.rb
@@ -172,8 +172,7 @@ def prepare_relocation_to_locations end relocation.add_replacement_pair(:perl, PERL_PLACEHOLDER, perl_path) - openjdk = openjdk_dep_name_if_applicable - if openjdk + if (openjdk = openjdk_dep_name_if_applicable) openjdk_path = HOMEBREW_PREFIX/"opt"/openjdk/"libexec/openjdk.jdk/Contents/Home" relocation.add_replacement_pair(:java, JAVA_PLACEHOLDER, openjdk_path.to_s) end
true
Other
Homebrew
brew
457de40117188880f15a864d1ac3dd437274ea07.json
Apply suggestions from code review These are just a few style improvements. Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Library/Homebrew/keg_relocate.rb
@@ -116,8 +116,9 @@ def prepare_relocation_to_locations relocation.add_replacement_pair(:repository, REPOSITORY_PLACEHOLDER, HOMEBREW_REPOSITORY.to_s) relocation.add_replacement_pair(:library, LIBRARY_PLACEHOLDER, HOMEBREW_LIBRARY.to_s) relocation.add_replacement_pair(:perl, PERL_PLACEHOLDER, "#{HOMEBREW_PREFIX}/opt/perl/bin/perl") - openjdk = openjdk_dep_name_if_applicable - relocation.add_replacement_pair(:java, JAVA_PLACEHOLDER, "#{HOMEBREW_PREFIX}/opt/#{openjdk}/libexec") if openjdk + if (openjdk = openjdk_dep_name_if_applicable) + relocation.add_replacement_pair(:java, JAVA_PLACEHOLDER, "#{HOMEBREW_PREFIX}/opt/#{openjdk}/libexec") + end relocation end @@ -130,9 +131,11 @@ def replace_placeholders_with_locations(files, skip_linkage: false) end def openjdk_dep_name_if_applicable - runtime_dependencies&.find do |dep| - dep["full_name"].match? Version.formula_optionally_versioned_regex(:openjdk) - end&.fetch("full_name") + deps = runtime_dependencies + return if deps.blank? + + dep_names = deps.map { |d| d["full_name"] } + dep_names.find { |d| d.match? Version.formula_optionally_versioned_regex(:openjdk) } end def replace_text_in_files(relocation, files: nil)
true
Other
Homebrew
brew
2e78389516501a74d639498b5c99acbaf6d90ebe.json
Improve `HOMEBREW_INSTALL_FROM_API` description
Library/Homebrew/env_config.rb
@@ -191,7 +191,8 @@ module EnvConfig }, HOMEBREW_INSTALL_FROM_API: { description: "If set, install formulae and casks in homebrew/core and homebrew/cask taps using Homebrew's " \ - "API instead of needing (large, slow) local checkouts of these repositories.", + "API instead of needing (large, slow) local checkouts of these repositories." \ + "\n\n *Note:* Users with developer mode enabled cannot set HOMEBREW_INSTALL_FROM_API.", boolean: true, }, HOMEBREW_LIVECHECK_WATCHLIST: {
true
Other
Homebrew
brew
2e78389516501a74d639498b5c99acbaf6d90ebe.json
Improve `HOMEBREW_INSTALL_FROM_API` description
docs/Manpage.md
@@ -2032,6 +2032,8 @@ example, run `export HOMEBREW_NO_INSECURE_REDIRECT=1` rather than just - `HOMEBREW_INSTALL_FROM_API` <br>If set, install formulae and casks in homebrew/core and homebrew/cask taps using Homebrew's API instead of needing (large, slow) local checkouts of these repositories. + *Note:* Users with developer mode enabled cannot set HOMEBREW_INSTALL_FROM_API. + - `HOMEBREW_LIVECHECK_WATCHLIST` <br>Consult this file for the list of formulae to check by default when no formula argument is passed to `brew livecheck`.
true
Other
Homebrew
brew
2e78389516501a74d639498b5c99acbaf6d90ebe.json
Improve `HOMEBREW_INSTALL_FROM_API` description
manpages/brew.1
@@ -2933,6 +2933,9 @@ Print this text before the installation summary of each successful build\. .br If set, install formulae and casks in homebrew/core and homebrew/cask taps using Homebrew\'s API instead of needing (large, slow) local checkouts of these repositories\. . +.IP +\fINote:\fR Users with developer mode enabled cannot set HOMEBREW_INSTALL_FROM_API\. +. .TP \fBHOMEBREW_LIVECHECK_WATCHLIST\fR .
true
Other
Homebrew
brew
e69fbaf3575a2a4aec529927b190815eb2fbb64d.json
bottle.rb: fix typo in go regex
Library/Homebrew/dev-cmd/bottle.rb
@@ -281,7 +281,7 @@ def formula_ignores(f) end if any_go_deps go_regex = Version.formula_optionally_versioned_regex(:go, full: false) - ignores << %r{#{cellar_regex}/#{go_regex}/[\d.]+/libexec]} + ignores << %r{#{cellar_regex}/#{go_regex}/[\d.]+/libexec} end ignores << case f.name
false
Other
Homebrew
brew
25e61f65dbd57836cd6a42af7c941b2a91c406df.json
cmd/update-report: check core tap is installed. Otherwise `CoreTap.instance.linuxbrew_core?` can fail.
Library/Homebrew/cmd/update-report.rb
@@ -43,7 +43,8 @@ def update_report args = update_report_args.parse # Run `brew update` (again) if we've got a linuxbrew-core CoreTap - if CoreTap.instance.linuxbrew_core? && ENV["HOMEBREW_LINUXBREW_CORE_MIGRATION"].blank? + if CoreTap.instance.installed? && CoreTap.instance.linuxbrew_core? && + ENV["HOMEBREW_LINUXBREW_CORE_MIGRATION"].blank? ohai_stdout_or_stderr "Re-running `brew update` for linuxbrew-core migration" if ENV["HOMEBREW_CORE_DEFAULT_GIT_REMOTE"] != ENV["HOMEBREW_CORE_GIT_REMOTE"]
false
Other
Homebrew
brew
ce2d946a7cd11a69ea1631579bf7df0e738adf0f.json
formula_auditor: add audit for formulae with synced versions
Library/Homebrew/formula_auditor.rb
@@ -118,6 +118,31 @@ def self.aliases @aliases ||= Formula.aliases + Formula.tap_aliases end + SYNCED_VERSIONS_FORMULAE_FILE = "synced_versions_formulae.json" + + def audit_synced_versions_formulae + synced_versions_formulae_file = formula.tap.path/SYNCED_VERSIONS_FORMULAE_FILE + return unless synced_versions_formulae_file.file? + + name = formula.name + version = formula.version + + synced_versions_formulae = JSON.parse(synced_versions_formulae_file.read) + synced_versions_formulae.each do |synced_version_formulae| + next unless synced_version_formulae.include? name + + synced_version_formulae.each do |synced_formula| + next if synced_formula == name + + if (synced_version = Formulary.factory(synced_formula).version) != version + problem "Version of `#{synced_formula}` (#{synced_version}) should match version of `#{name}` (#{version})" + end + end + + break + end + end + def audit_formula_name name = formula.name
false
Other
Homebrew
brew
c6dbff43bdbce250415303693efa81165d03a955.json
dev-cmd/dispatch-build-bottle: allow an array of macOS runners
Library/Homebrew/cli/args.rbi
@@ -168,7 +168,7 @@ module Homebrew sig { returns(T.nilable(String)) } def tap; end - sig { returns(T.nilable(String)) } + sig { returns(T.nilable(T::Array[String])) } def macos; end sig { returns(T.nilable(T::Array[String])) }
true
Other
Homebrew
brew
c6dbff43bdbce250415303693efa81165d03a955.json
dev-cmd/dispatch-build-bottle: allow an array of macOS runners
Library/Homebrew/dev-cmd/dispatch-build-bottle.rb
@@ -21,8 +21,8 @@ def dispatch_build_bottle_args description: "Build timeout (in minutes, default: 60)." flag "--issue=", description: "If specified, post a comment to this issue number if the job fails." - flag "--macos=", - description: "Version of macOS the bottle should be built for." + comma_array "--macos=", + description: "Version(s) of macOS the bottle should be built for." flag "--workflow=", description: "Dispatch specified workflow (default: `dispatch-build-bottle.yml`)." switch "--upload", @@ -51,33 +51,35 @@ def dispatch_build_bottle # TODO: remove when core taps are merged repo.gsub!("linux", "home") unless args.tap - runner = if (macos = args.macos) - # We accept runner name syntax (11-arm64) or bottle syntax (arm64_big_sur) - os, arch = macos.yield_self do |s| - tag = Utils::Bottles::Tag.from_symbol(s.to_sym) - [tag.to_macos_version, tag.arch] - rescue ArgumentError, MacOSVersionError - os, arch = s.split("-", 2) - [MacOS::Version.new(os), arch&.to_sym] - end + runners = if (macos = args.macos&.compact_blank) && macos.present? + macos.map do |element| + # We accept runner name syntax (11-arm64) or bottle syntax (arm64_big_sur) + os, arch = element.yield_self do |s| + tag = Utils::Bottles::Tag.from_symbol(s.to_sym) + [tag.to_macos_version, tag.arch] + rescue ArgumentError, MacOSVersionError + os, arch = s.split("-", 2) + [MacOS::Version.new(os), arch&.to_sym] + end - if arch.present? && arch != :x86_64 - "#{os}-#{arch}" - else - os.to_s + if arch.present? && arch != :x86_64 + "#{os}-#{arch}" + else + os.to_s + end end elsif args.linux? - "ubuntu-latest" + ["ubuntu-latest"] elsif args.linux_self_hosted? - "linux-self-hosted-1" + ["linux-self-hosted-1"] else raise UsageError, "Must specify --macos or --linux or --linux-self-hosted option" end args.named.to_resolved_formulae.each do |formula| # Required inputs inputs = { - runner: runner, + runner: runners.join(","), formula: formula.name, } @@ -88,7 +90,7 @@ def dispatch_build_bottle inputs[:upload] = args.upload?.to_s if args.upload? inputs[:wheezy] = args.linux_wheezy?.to_s if args.linux_wheezy? - ohai "Dispatching #{tap} bottling request of formula \"#{formula.name}\" for #{runner}" + ohai "Dispatching #{tap} bottling request of formula \"#{formula.name}\" for #{runners.join(", ")}" GitHub.workflow_dispatch_event(user, repo, workflow, ref, inputs) end end
true
Other
Homebrew
brew
f96f29f68ddfd0fd43049b1448b1d0e25c050f3c.json
pr-automerge: remove linux to homebrew-core label Merging is done, we don't use this label anymore
Library/Homebrew/dev-cmd/pr-automerge.rb
@@ -21,8 +21,7 @@ def pr_automerge_args description: "Pull requests must have this label." comma_array "--without-labels", description: "Pull requests must not have these labels (default: "\ - "`do not merge`, `new formula`, `automerge-skip`, "\ - "`linux to homebrew-core`)." + "`do not merge`, `new formula`, `automerge-skip`)." switch "--without-approval", description: "Pull requests do not require approval to be merged." switch "--publish", @@ -49,7 +48,6 @@ def pr_automerge "do not merge", "new formula", "automerge-skip", - "linux to homebrew-core", ] tap = Tap.fetch(args.tap || CoreTap.instance.name)
false
Other
Homebrew
brew
aad9d1898d58158058d6d84b9cb73a8965c0b51a.json
Update RBI files for sorbet.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -5537,6 +5537,8 @@ end module MonitorMixin def initialize(*args); end + EXCEPTION_IMMEDIATE = ::T.let(nil, ::T.untyped) + EXCEPTION_NEVER = ::T.let(nil, ::T.untyped) end class MonitorMixin::ConditionVariable
false
Other
Homebrew
brew
f21b85857b8be1bd1d6cf572fcef2543c2e01be6.json
Update RBI files for zeitwerk.
Library/Homebrew/sorbet/rbi/gems/zeitwerk@2.5.1.rbi
@@ -22,20 +22,6 @@ module Zeitwerk end end -class Zeitwerk::Autoloads - def initialize; end - - def a2c; end - def abspath_for(parent, cname); end - def c2a; end - def clear; end - def cref_for(abspath); end - def define(parent, cname, abspath); end - def delete(abspath); end - def each(&block); end - def empty?; end -end - class Zeitwerk::Error < ::StandardError; end module Zeitwerk::ExplicitNamespace @@ -95,6 +81,7 @@ class Zeitwerk::Loader private def autoload_file(parent, cname, file); end + def autoload_path_set_by_me_for?(parent, cname); end def autoload_subdir(parent, cname, subdir); end def promote_namespace_from_implicit_to_explicit(dir:, file:, parent:, cname:); end def raise_if_conflicting_directory(dir); end
true
Other
Homebrew
brew
f21b85857b8be1bd1d6cf572fcef2543c2e01be6.json
Update RBI files for zeitwerk.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -5537,6 +5537,8 @@ end module MonitorMixin def initialize(*args); end + EXCEPTION_IMMEDIATE = ::T.let(nil, ::T.untyped) + EXCEPTION_NEVER = ::T.let(nil, ::T.untyped) end class MonitorMixin::ConditionVariable
true
Other
Homebrew
brew
ccb1628bb47f55a2cf60a3b5614d4f635dddf1e1.json
workflows/doctor: add Monterey CI
.github/workflows/doctor.yml
@@ -18,7 +18,7 @@ jobs: tests: strategy: matrix: - version: ["11-arm64", "11", "10.15", "10.14"] + version: ["12-arm64", "12", "11-arm64", "11", "10.15"] fail-fast: false runs-on: ${{ matrix.version }} env:
false
Other
Homebrew
brew
0118e6ec41a4fb2e2638165fee0a4f492f19bf81.json
Apply suggestions from code review Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
Library/Homebrew/cmd/update-report.rb
@@ -48,7 +48,8 @@ def update_report if ENV["HOMEBREW_CORE_DEFAULT_GIT_REMOTE"] != ENV["HOMEBREW_CORE_GIT_REMOTE"] opoo <<~EOS - HOMEBREW_CORE_GIT_REMOTE was set. It has been unset for the migration. + HOMEBREW_CORE_GIT_REMOTE was set: #{ENV["HOMEBREW_CORE_GIT_REMOTE"]}. + It has been unset for the migration. You may need to change this from a linuxbrew-core mirror to a homebrew-core one. EOS @@ -57,8 +58,9 @@ def update_report if ENV["HOMEBREW_BOTTLE_DEFAULT_DOMAIN"] != ENV["HOMEBREW_BOTTLE_DOMAIN"] opoo <<~EOS - HOMEBREW_BOTTLE_DOMAIN was set. It has been unset for the migration. - You may need to change this Linuxbrew packages to Homebrew packages. + HOMEBREW_BOTTLE_DOMAIN was set: #{ENV["HOMEBREW_BOTTLE_DOMAIN"]}. + It has been unset for the migration. + You may need to change this from a Linuxbrew package mirror to a Homebrew one. EOS end
true
Other
Homebrew
brew
0118e6ec41a4fb2e2638165fee0a4f492f19bf81.json
Apply suggestions from code review Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
Library/Homebrew/extend/os/linux/diagnostic.rb
@@ -130,12 +130,12 @@ def check_linuxbrew_core end def check_linuxbrew_bottle_domain - return unless Homebrew::EnvConfig.bottle_domain.include?("linuxbrew-core") + return unless Homebrew::EnvConfig.bottle_domain.include?("linuxbrew") <<~EOS - Your HOMEBREW_BOTTLE_DOMAIN still contains linuxbrew-core. - You must unset it (or adjust it to not contain linuxbrew-core - e.g. by using homebrew-core instead). + Your HOMEBREW_BOTTLE_DOMAIN still contains "linuxbrew". + You must unset it (or adjust it to not contain linuxbrew + e.g. by using homebrew instead). EOS end end
true
Other
Homebrew
brew
8c22e009acaafa7de7c2c8ee298229efd21f2503.json
update depends_on_java to suggest temurin AdoptOpenJDK has been deprecated. Temurin is the new cask
Library/Homebrew/cask/dsl/caveats.rb
@@ -112,17 +112,17 @@ def eval_caveats(&block) if java_version == :any <<~EOS #{@cask} requires Java. You can install the latest version with: - brew install --cask adoptopenjdk + brew install --cask temurin EOS elsif java_version.include?("+") <<~EOS #{@cask} requires Java #{java_version}. You can install the latest version with: - brew install --cask adoptopenjdk + brew install --cask temurin EOS else <<~EOS #{@cask} requires Java #{java_version}. You can install it with: - brew install --cask homebrew/cask-versions/adoptopenjdk#{java_version} + brew install --cask homebrew/cask-versions/temurin#{java_version} EOS end end
false
Other
Homebrew
brew
943b79d2fbf6776067594a3f670bf7e045960707.json
os/mac/diagnostic: allow Ruby 2.6.8
Library/Homebrew/extend/os/mac/diagnostic.rb
@@ -201,12 +201,19 @@ def check_if_xcode_needs_clt_installed end def check_ruby_version - return if RUBY_VERSION == HOMEBREW_REQUIRED_RUBY_VERSION + # TODO: require 2.6.8 for everyone once enough have updated to Monterey + required_version = if MacOS.version >= :monterey || + ENV["HOMEBREW_RUBY_PATH"].to_s.include?("/vendor/portable-ruby/") + "2.6.8" + else + HOMEBREW_REQUIRED_RUBY_VERSION + end + return if RUBY_VERSION == required_version return if Homebrew::EnvConfig.developer? && OS::Mac.version.prerelease? <<~EOS Ruby version #{RUBY_VERSION} is unsupported on #{MacOS.version}. Homebrew - is developed and tested on Ruby #{HOMEBREW_REQUIRED_RUBY_VERSION}, and may not work correctly + is developed and tested on Ruby #{required_version}, and may not work correctly on other Rubies. Patches are accepted as long as they don't cause breakage on supported Rubies. EOS
false
Other
Homebrew
brew
bc46bcf301898fa87a6ba2997ae23f3b0b1eab0d.json
Update RBI files for zeitwerk.
Library/Homebrew/sorbet/rbi/gems/zeitwerk@2.5.0.rbi
@@ -16,7 +16,26 @@ module Kernel end end -module Zeitwerk; end +module Zeitwerk + class << self + def with_loader; end + end +end + +class Zeitwerk::Autoloads + def initialize; end + + def a2c; end + def abspath_for(parent, cname); end + def c2a; end + def clear; end + def cref_for(abspath); end + def define(parent, cname, abspath); end + def delete(abspath); end + def each(&block); end + def empty?; end +end + class Zeitwerk::Error < ::StandardError; end module Zeitwerk::ExplicitNamespace @@ -27,7 +46,7 @@ module Zeitwerk::ExplicitNamespace def mutex; end def register(cpath, loader); end def tracer; end - def unregister(loader); end + def unregister_loader(loader); end private @@ -54,73 +73,35 @@ end class Zeitwerk::Loader include ::Zeitwerk::RealModName include ::Zeitwerk::Loader::Callbacks + include ::Zeitwerk::Loader::Helpers + include ::Zeitwerk::Loader::Config def initialize; end def autoloaded_dirs; end def autoloads; end - def collapse(*glob_patterns); end - def collapse_dirs; end - def collapse_glob_patterns; end - def dirs; end - def do_not_eager_load(*paths); end - def eager_load; end - def eager_load_exclusions; end - def enable_reloading; end - def ignore(*glob_patterns); end - def ignored_glob_patterns; end - def ignored_paths; end - def inflector; end - def inflector=(_arg0); end + def eager_load(force: T.unsafe(nil)); end def lazy_subdirs; end - def log!; end - def logger; end - def logger=(_arg0); end - def manages?(dir); end def mutex; end def mutex2; end - def on_load(cpath, &block); end - def on_load_callbacks; end - def preload(*paths); end - def preloads; end - def push_dir(path, namespace: T.unsafe(nil)); end def reload; end - def reloading_enabled?; end - def root_dirs; end def setup; end - def tag; end - def tag=(tag); end def to_unload; end def unload; end def unloadable_cpath?(cpath); end def unloadable_cpaths; end + def unregister; end private - def actual_root_dirs; end def autoload_file(parent, cname, file); end - def autoload_for?(parent, cname); end def autoload_subdir(parent, cname, subdir); end - def cdef?(parent, cname); end - def cpath(parent, cname); end - def dir?(path); end - def do_preload; end - def do_preload_abspath(abspath); end - def do_preload_dir(dir); end - def do_preload_file(file); end - def expand_glob_patterns(glob_patterns); end - def expand_paths(paths); end - def log(message); end - def ls(dir); end def promote_namespace_from_implicit_to_explicit(dir:, file:, parent:, cname:); end def raise_if_conflicting_directory(dir); end - def recompute_collapse_dirs; end - def recompute_ignored_paths; end def register_explicit_namespace(cpath); end - def ruby?(path); end + def run_on_unload_callbacks(cpath, value, abspath); end def set_autoload(parent, cname, abspath); end def set_autoloads_in_dir(dir, parent); end - def strict_autoload_path(parent, cname); end def unload_autoload(parent, cname); end def unload_cref(parent, cname); end @@ -144,7 +125,64 @@ module Zeitwerk::Loader::Callbacks private - def run_on_load_callbacks(cpath); end + def run_on_load_callbacks(cpath, value, abspath); end +end + +module Zeitwerk::Loader::Config + def initialize; end + + def collapse(*glob_patterns); end + def collapse_dirs; end + def collapse_glob_patterns; end + def dirs; end + def do_not_eager_load(*paths); end + def eager_load_exclusions; end + def enable_reloading; end + def ignore(*glob_patterns); end + def ignored_glob_patterns; end + def ignored_paths; end + def ignores?(abspath); end + def inflector; end + def inflector=(_arg0); end + def log!; end + def logger; end + def logger=(_arg0); end + def on_load(cpath = T.unsafe(nil), &block); end + def on_load_callbacks; end + def on_setup(&block); end + def on_setup_callbacks; end + def on_unload(cpath = T.unsafe(nil), &block); end + def on_unload_callbacks; end + def push_dir(path, namespace: T.unsafe(nil)); end + def reloading_enabled?; end + def root_dirs; end + def tag; end + def tag=(tag); end + + private + + def actual_root_dirs; end + def collapse?(dir); end + def excluded_from_eager_load?(abspath); end + def expand_glob_patterns(glob_patterns); end + def expand_paths(paths); end + def recompute_collapse_dirs; end + def recompute_ignored_paths; end + def root_dir?(dir); end +end + +module Zeitwerk::Loader::Helpers + private + + def cdef?(parent, cname); end + def cget(parent, cname); end + def cpath(parent, cname); end + def dir?(path); end + def hidden?(basename); end + def log(message); end + def ls(dir); end + def ruby?(path); end + def strict_autoload_path(parent, cname); end end class Zeitwerk::NameError < ::NameError; end @@ -165,11 +203,13 @@ module Zeitwerk::Registry def loaders; end def loaders_managing_gems; end def on_unload(loader); end - def register_autoload(loader, realpath); end - def register_inception(cpath, realpath, loader); end + def register_autoload(loader, abspath); end + def register_inception(cpath, abspath, loader); end def register_loader(loader); end - def unregister_autoload(realpath); end + def unregister_autoload(abspath); end + def unregister_loader(loader); end end end class Zeitwerk::ReloadingDisabledError < ::Zeitwerk::Error; end +Zeitwerk::VERSION = T.let(T.unsafe(nil), String)
true
Other
Homebrew
brew
bc46bcf301898fa87a6ba2997ae23f3b0b1eab0d.json
Update RBI files for zeitwerk.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -4510,6 +4510,8 @@ end module Homebrew::EnvConfig extend ::T::Private::Methods::MethodHooks extend ::T::Private::Methods::SingletonMethodHooks + def self.additional_google_analytics_id(); end + def self.all_proxy(); end def self.arch(); end @@ -4628,6 +4630,8 @@ module Homebrew::EnvConfig def self.sorbet_runtime?(); end + def self.ssh_config_path(); end + def self.sudo_askpass(); end def self.svn(); end
true
Other
Homebrew
brew
811d0fa0bd42010f5597dca132e13ccddff146ed.json
bump: add option to retrieve a subset of results Plus a few fixes for output.
Library/Homebrew/cli/args.rbi
@@ -192,6 +192,9 @@ module Homebrew sig { returns(T.nilable(String)) } def limit; end + sig { returns(T.nilable(String)) } + def start_with; end + sig { returns(T.nilable(String)) } def message; end
true
Other
Homebrew
brew
811d0fa0bd42010f5597dca132e13ccddff146ed.json
bump: add option to retrieve a subset of results Plus a few fixes for output.
Library/Homebrew/dev-cmd/bump.rb
@@ -13,8 +13,9 @@ module Homebrew def bump_args Homebrew::CLI::Parser.new do description <<~EOS - Display out-of-date brew formulae and the latest version available. - Also displays whether a pull request has been opened with the URL. + Display out-of-date brew formulae and the latest version available. If the + returned current and livecheck versions differ or when querying specific + formulae, also displays whether a pull request has been opened with the URL. EOS switch "--full-name", description: "Print formulae/casks with fully-qualified names." @@ -26,6 +27,8 @@ def bump_args description: "Check only casks." flag "--limit=", description: "Limit number of package results returned." + flag "--start-with=", + description: "Letter or word that the list of package results should alphabetically follow." conflicts "--cask", "--formula" @@ -53,6 +56,18 @@ def bump limit = args.limit.to_i if args.limit.present? + unless quiet_system(HOMEBREW_SHIMS_PATH/"shared/curl", "--tlsv1.3", "--head", "https://repology.org/") + begin + brewed_curl = Formula["curl"] + unless brewed_curl.any_version_installed? + ohai "Installing `curl` for Repology queries..." + safe_system HOMEBREW_BREW_FILE, "install", "--formula", brewed_curl.full_name + end + rescue FormulaUnavailableError + opoo "A `curl` with TLS 1.3 support is required for Repology queries" + end + end + if formulae_and_casks.present? Livecheck.load_other_tap_strategies(formulae_and_casks) @@ -104,21 +119,25 @@ def bump api_response = {} unless args.cask? api_response[:formulae] = - Repology.parse_api_response(limit, repository: Repology::HOMEBREW_CORE) + Repology.parse_api_response(limit, args.start_with, repository: Repology::HOMEBREW_CORE) end unless args.formula? api_response[:casks] = - Repology.parse_api_response(limit, repository: Repology::HOMEBREW_CASK) + Repology.parse_api_response(limit, args.start_with, repository: Repology::HOMEBREW_CASK) end - api_response.each do |package_type, outdated_packages| + api_response.each_with_index do |(package_type, outdated_packages), idx| repository = if package_type == :formulae Repology::HOMEBREW_CORE else Repology::HOMEBREW_CASK end + puts if idx.positive? + oh1 package_type.capitalize if api_response.size > 1 outdated_packages.each_with_index do |(_name, repositories), i| + break if limit && i >= limit + homebrew_repo = repositories.find do |repo| repo["repo"] == repository end @@ -143,8 +162,6 @@ def bump puts if i.positive? retrieve_and_display_info(formula_or_cask, name, repositories, args: args, ambiguous_cask: ambiguous_cask) - - break if limit && i >= limit end end end @@ -180,7 +197,7 @@ def livecheck_result(formula_or_cask) return "unable to get versions" if latest.blank? - latest.to_s + Version.new(latest) rescue => e "error: #{e}" end @@ -211,22 +228,24 @@ def retrieve_and_display_info(formula_or_cask, name, repositories, args:, ambigu end livecheck_latest = livecheck_result(formula_or_cask) - pull_requests = retrieve_pull_requests(formula_or_cask, name) unless args.no_pull_requests? + pull_requests = if !args.no_pull_requests? && (args.named.present? || livecheck_latest != current_version) + retrieve_pull_requests(formula_or_cask, name) + end name += " (cask)" if ambiguous_cask title = if current_version == repology_latest && current_version == livecheck_latest - "#{name} is up to date!" + "#{name} #{Tty.green}is up to date!#{Tty.reset}" else name end ohai title puts <<~EOS - Current formula version: #{current_version} - Latest Repology version: #{repology_latest} + Current #{formula_or_cask.is_a?(Formula) ? "formula version:" : "cask version: "} #{current_version} Latest livecheck version: #{livecheck_latest} + Latest Repology version: #{repology_latest} EOS - puts "Open pull requests: #{pull_requests}" unless args.no_pull_requests? + puts "Open pull requests: #{pull_requests}" unless pull_requests.nil? end end
true
Other
Homebrew
brew
811d0fa0bd42010f5597dca132e13ccddff146ed.json
bump: add option to retrieve a subset of results Plus a few fixes for output.
Library/Homebrew/test/dev-cmd/bump_spec.rb
@@ -6,7 +6,7 @@ describe "brew bump" do it_behaves_like "parseable arguments" - describe "formula", :integration_test, :needs_network do + describe "formula", :integration_test, :needs_network, :needs_tls13 do it "returns data for single valid specified formula" do install_test_formula "testball"
true
Other
Homebrew
brew
811d0fa0bd42010f5597dca132e13ccddff146ed.json
bump: add option to retrieve a subset of results Plus a few fixes for output.
Library/Homebrew/test/spec_helper.rb
@@ -169,6 +169,15 @@ .append(svnadmin.dirname) end + config.before(:each, :needs_tls13) do + begin + curl = Utils::Curl.curl_executable(use_homebrew_curl: OS.mac?) + rescue FormulaUnavailableError + skip "curl formula not available" + end + skip "Requires curl with TLS 1.3 support." unless quiet_system curl, "--tlsv1.3", "--head", "https://brew.sh/" + end + config.before(:each, :needs_unzip) do skip "Unzip is not installed." unless which("unzip") end
true
Other
Homebrew
brew
811d0fa0bd42010f5597dca132e13ccddff146ed.json
bump: add option to retrieve a subset of results Plus a few fixes for output.
Library/Homebrew/test/utils/repology_spec.rb
@@ -4,7 +4,7 @@ require "utils/repology" describe Repology do - describe "single_package_query", :needs_network do + describe "single_package_query", :needs_network, :needs_tls13 do it "returns nil for non-existent package" do response = described_class.single_package_query("invalidName", repository: "homebrew") @@ -14,15 +14,12 @@ it "returns a hash for existing package" do response = described_class.single_package_query("openclonk", repository: "homebrew") - expect(response).to be_nil - # TODO: uncomment (and remove line above) when we have a fix for Repology - # `curl` issues - # expect(response).not_to be_nil - # expect(response).to be_a(Hash) + expect(response).not_to be_nil + expect(response).to be_a(Hash) end end - describe "parse_api_response", :needs_network do + describe "parse_api_response", :needs_network, :needs_tls13 do it "returns a hash of data" do limit = 1 response = described_class.parse_api_response(limit, repository: "homebrew")
true
Other
Homebrew
brew
811d0fa0bd42010f5597dca132e13ccddff146ed.json
bump: add option to retrieve a subset of results Plus a few fixes for output.
Library/Homebrew/utils/curl.rb
@@ -357,6 +357,12 @@ def curl_http_content_headers_and_checksum( file.unlink end + def homebrew_curl_available? + Formulary.factory("curl").present? + rescue FormulaUnavailableError + false + end + def http_status_ok?(status) (100..299).cover?(status.to_i) end
true
Other
Homebrew
brew
811d0fa0bd42010f5597dca132e13ccddff146ed.json
bump: add option to retrieve a subset of results Plus a few fixes for output.
Library/Homebrew/utils/repology.rb
@@ -15,33 +15,29 @@ module Repology MAX_PAGINATION = 15 private_constant :MAX_PAGINATION - def query_api(_last_package_in_response = "", repository:) - {} - # TODO: uncomment (and remove lines above) when we have a fix for Repology - # `curl` issues - # last_package_in_response += "/" if last_package_in_response.present? - # url = "https://repology.org/api/v1/projects/#{last_package_in_response}?inrepo=#{repository}&outdated=1" - - # output, _errors, _status = curl_output(url.to_s) - # JSON.parse(output) + def query_api(last_package_in_response = "", repository:) + last_package_in_response += "/" if last_package_in_response.present? + url = "https://repology.org/api/v1/projects/#{last_package_in_response}?inrepo=#{repository}&outdated=1" + + output, _errors, _status = curl_output(url.to_s, use_homebrew_curl: OS.mac?) + JSON.parse(output) end def single_package_query(name, repository:) - # TODO: uncomment when we have a fix for Repology `curl` issues - # url = "https://repology.org/tools/project-by?repo=#{repository}&" \ - # "name_type=srcname&target_page=api_v1_project&name=#{name}" - - # output, _errors, _status = curl_output("--location", url.to_s) - - # begin - # data = JSON.parse(output) - # { name => data } - # rescue - # nil - # end + url = "https://repology.org/tools/project-by?repo=#{repository}&" \ + "name_type=srcname&target_page=api_v1_project&name=#{name}" + + output, _errors, _status = curl_output("--location", url.to_s, use_homebrew_curl: OS.mac?) + + begin + data = JSON.parse(output) + { name => data } + rescue + nil + end end - def parse_api_response(limit = nil, repository:) + def parse_api_response(limit = nil, last_package = "", repository:) package_term = case repository when HOMEBREW_CORE "formula" @@ -55,14 +51,13 @@ def parse_api_response(limit = nil, repository:) page_no = 1 outdated_packages = {} - last_package = "" while page_no <= MAX_PAGINATION odebug "Paginating Repology API page: #{page_no}" response = query_api(last_package, repository: repository) outdated_packages.merge!(response) - last_package = response.keys.last + last_package = response.keys.max page_no += 1 break if (limit && outdated_packages.size >= limit) || response.size <= 1 @@ -71,7 +66,7 @@ def parse_api_response(limit = nil, repository:) puts "#{outdated_packages.size} outdated #{package_term.pluralize(outdated_packages.size)} found" puts - outdated_packages + outdated_packages.sort.to_h end def latest_version(repositories)
true
Other
Homebrew
brew
811d0fa0bd42010f5597dca132e13ccddff146ed.json
bump: add option to retrieve a subset of results Plus a few fixes for output.
completions/bash/brew
@@ -436,6 +436,7 @@ _brew_bump() { --limit --no-pull-requests --quiet + --start-with --verbose " return
true
Other
Homebrew
brew
811d0fa0bd42010f5597dca132e13ccddff146ed.json
bump: add option to retrieve a subset of results Plus a few fixes for output.
completions/fish/brew.fish
@@ -388,6 +388,7 @@ __fish_brew_complete_arg 'bump' -l help -d 'Show this message' __fish_brew_complete_arg 'bump' -l limit -d 'Limit number of package results returned' __fish_brew_complete_arg 'bump' -l no-pull-requests -d 'Do not retrieve pull requests from GitHub' __fish_brew_complete_arg 'bump' -l quiet -d 'Make some output more quiet' +__fish_brew_complete_arg 'bump' -l start-with -d 'Letter or word that the list of package results should alphabetically follow' __fish_brew_complete_arg 'bump' -l verbose -d 'Make some output more verbose' __fish_brew_complete_arg 'bump; and not __fish_seen_argument -l cask -l casks' -a '(__fish_brew_suggest_formulae_all)' __fish_brew_complete_arg 'bump; and not __fish_seen_argument -l formula -l formulae' -a '(__fish_brew_suggest_casks_all)'
true
Other
Homebrew
brew
811d0fa0bd42010f5597dca132e13ccddff146ed.json
bump: add option to retrieve a subset of results Plus a few fixes for output.
completions/zsh/_brew
@@ -479,6 +479,7 @@ _brew_bump() { '--limit[Limit number of package results returned]' \ '--no-pull-requests[Do not retrieve pull requests from GitHub]' \ '--quiet[Make some output more quiet]' \ + '--start-with[Letter or word that the list of package results should alphabetically follow]' \ '--verbose[Make some output more verbose]' \ - formula \ '(--cask)--formula[Check only formulae]' \
true
Other
Homebrew
brew
811d0fa0bd42010f5597dca132e13ccddff146ed.json
bump: add option to retrieve a subset of results Plus a few fixes for output.
docs/Manpage.md
@@ -899,8 +899,9 @@ value, while `--no-rebuild` will remove it. ### `bump` [*`options`*] [*`formula`*|*`cask`* ...] -Display out-of-date brew formulae and the latest version available. -Also displays whether a pull request has been opened with the URL. +Display out-of-date brew formulae and the latest version available. If the +returned current and livecheck versions differ or when querying specific +formulae, also displays whether a pull request has been opened with the URL. * `--full-name`: Print formulae/casks with fully-qualified names. @@ -912,6 +913,8 @@ Also displays whether a pull request has been opened with the URL. Check only casks. * `--limit`: Limit number of package results returned. +* `--start-with`: + Letter or word that the list of package results should alphabetically follow. ### `bump-cask-pr` [*`options`*] *`cask`*
true
Other
Homebrew
brew
811d0fa0bd42010f5597dca132e13ccddff146ed.json
bump: add option to retrieve a subset of results Plus a few fixes for output.
manpages/brew.1
@@ -1261,7 +1261,7 @@ Use the specified \fIURL\fR as the root of the bottle\'s URL instead of Homebrew Use the specified download strategy class for downloading the bottle\'s URL instead of Homebrew\'s default\. . .SS "\fBbump\fR [\fIoptions\fR] [\fIformula\fR|\fIcask\fR \.\.\.]" -Display out\-of\-date brew formulae and the latest version available\. Also displays whether a pull request has been opened with the URL\. +Display out\-of\-date brew formulae and the latest version available\. If the returned current and livecheck versions differ or when querying specific formulae, also displays whether a pull request has been opened with the URL\. . .TP \fB\-\-full\-name\fR @@ -1283,6 +1283,10 @@ Check only casks\. \fB\-\-limit\fR Limit number of package results returned\. . +.TP +\fB\-\-start\-with\fR +Letter or word that the list of package results should alphabetically follow\. +. .SS "\fBbump\-cask\-pr\fR [\fIoptions\fR] \fIcask\fR" Create a pull request to update \fIcask\fR with a new version\. .
true
Other
Homebrew
brew
541b9556f80f1777ddfc5cb8ac8f5cda94f1209c.json
tests.yml: install curl on macOS for TLS 1.3 support
.github/workflows/tests.yml
@@ -309,6 +309,8 @@ jobs: brew sh -c "svn --homebrew=print-path" which svn which svnadmin + brew install curl + which curl - name: Create parallel test log directory run: mkdir tests
false
Other
Homebrew
brew
e567d7f595eeed6e2bc4e905e45ddc7b7817bc44.json
Update Formula-Cookbook.md gsub! example The use of a naked expression will trigger errors from `brew audit` so use instead parenthesis around the parameters as per its recommendation and to avoid ambiguous syntax.
docs/Formula-Cookbook.md
@@ -441,7 +441,7 @@ inreplace "path", before, after ```ruby inreplace "path" do |s| - s.gsub! /foo/, "bar" + s.gsub!(/foo/, "bar") s.gsub! "123", "456" end ```
false
Other
Homebrew
brew
412406298db46758868ec68fbf4b9281c49125db.json
Update RBI files for sorbet.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -4482,48 +4482,6 @@ module Homebrew::API extend ::T::Private::Methods::SingletonMethodHooks end -module Homebrew::Assertions - def assert_include(*args); end - - def assert_no_match(*args); end - - def assert_not_empty(*args); end - - def assert_not_equal(*args); end - - def assert_not_in_delta(*args); end - - def assert_not_in_epsilon(*args); end - - def assert_not_include(*args); end - - def assert_not_includes(*args); end - - def assert_not_instance_of(*args); end - - def assert_not_kind_of(*args); end - - def assert_not_match(*args); end - - def assert_not_nil(*args); end - - def assert_not_operator(*args); end - - def assert_not_predicate(*args); end - - def assert_not_respond_to(*args); end - - def assert_not_same(*args); end - - def assert_path_exist(*args); end - - def assert_path_not_exist(*args); end - - def assert_raise(*args); end - - def assert_throw(*args); end -end - class Homebrew::BundleVersion extend ::T::Private::Methods::MethodHooks extend ::T::Private::Methods::SingletonMethodHooks
false
Other
Homebrew
brew
8a086c5ab772dfdbcbbfc1ee710af4e88a647b02.json
Update RBI files for racc.
Library/Homebrew/sorbet/rbi/gems/racc@1.6.0.rbi
@@ -5,14 +5,9 @@ # typed: true class Object < ::BasicObject - include ::ActiveSupport::ForkTracker::CoreExt - include ::ActiveSupport::ForkTracker::CoreExtPrivate - include ::ActiveSupport::ToJsonWithActiveSupportEncoder include ::Kernel include ::JSON::Ext::Generator::GeneratorMethods::Object include ::PP::ObjectMixin - include ::ActiveSupport::Tryable - include ::ActiveSupport::Dependencies::Loadable end ParseError = Racc::ParseError
true
Other
Homebrew
brew
8a086c5ab772dfdbcbbfc1ee710af4e88a647b02.json
Update RBI files for racc.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -4482,48 +4482,6 @@ module Homebrew::API extend ::T::Private::Methods::SingletonMethodHooks end -module Homebrew::Assertions - def assert_include(*args); end - - def assert_no_match(*args); end - - def assert_not_empty(*args); end - - def assert_not_equal(*args); end - - def assert_not_in_delta(*args); end - - def assert_not_in_epsilon(*args); end - - def assert_not_include(*args); end - - def assert_not_includes(*args); end - - def assert_not_instance_of(*args); end - - def assert_not_kind_of(*args); end - - def assert_not_match(*args); end - - def assert_not_nil(*args); end - - def assert_not_operator(*args); end - - def assert_not_predicate(*args); end - - def assert_not_respond_to(*args); end - - def assert_not_same(*args); end - - def assert_path_exist(*args); end - - def assert_path_not_exist(*args); end - - def assert_raise(*args); end - - def assert_throw(*args); end -end - class Homebrew::BundleVersion extend ::T::Private::Methods::MethodHooks extend ::T::Private::Methods::SingletonMethodHooks @@ -5800,8 +5758,6 @@ class Object def __send!(*arg); end - def funcall(*arg); end - def stub(name, val_or_callable, *block_args); end def to_yaml(options=T.unsafe(nil)); end
true
Other
Homebrew
brew
5d670728f153c16583c08b43c18e2c9547eed084.json
os/mac/xcode: require Xcode 13.1 on Monterey
Library/Homebrew/os/mac/xcode.rb
@@ -23,7 +23,7 @@ module Xcode def latest_version(macos: MacOS.version) latest_stable = "13.0" case macos - when "12" then "13.0" + when "12" then "13.1" when "11" then latest_stable when "10.15" then "12.4" when "10.14" then "11.3.1" @@ -47,7 +47,7 @@ def latest_version(macos: MacOS.version) sig { returns(String) } def minimum_version case MacOS.version - when "12" then "13.0" + when "12" then "13.1" when "11" then "12.2" when "10.15" then "11.0" when "10.14" then "10.2"
false
Other
Homebrew
brew
93340e08d5b2aa2b80bb04292bd37c70cacbceca.json
cmd/search: add Arch Linux Arch update their packages very quickly, so they're quite useful as a reference for building formulae.
Library/Homebrew/cmd/search.rb
@@ -15,15 +15,16 @@ module Homebrew extend Search PACKAGE_MANAGERS = { - repology: ->(query) { "https://repology.org/projects/?search=#{query}" }, - macports: ->(query) { "https://ports.macports.org/search/?q=#{query}" }, - fink: ->(query) { "https://pdb.finkproject.org/pdb/browse.php?summary=#{query}" }, - opensuse: ->(query) { "https://software.opensuse.org/search?q=#{query}" }, - fedora: ->(query) { "https://apps.fedoraproject.org/packages/s/#{query}" }, - debian: lambda { |query| + repology: ->(query) { "https://repology.org/projects/?search=#{query}" }, + macports: ->(query) { "https://ports.macports.org/search/?q=#{query}" }, + fink: ->(query) { "https://pdb.finkproject.org/pdb/browse.php?summary=#{query}" }, + opensuse: ->(query) { "https://software.opensuse.org/search?q=#{query}" }, + fedora: ->(query) { "https://apps.fedoraproject.org/packages/s/#{query}" }, + archlinux: ->(query) { "https://archlinux.org/packages/?q=#{query}" }, + debian: lambda { |query| "https://packages.debian.org/search?keywords=#{query}&searchon=names&suite=all&section=all" }, - ubuntu: lambda { |query| + ubuntu: lambda { |query| "https://packages.ubuntu.com/search?keywords=#{query}&searchon=names&suite=all&section=all" }, }.freeze
false
Other
Homebrew
brew
12a9ec9fd7e1616538bffd5c0460e97c0f7823b9.json
Update RBI files for spoom.
Library/Homebrew/sorbet/rbi/gems/colorize@0.8.1.rbi
@@ -1,39 +0,0 @@ -# DO NOT EDIT MANUALLY -# This is an autogenerated file for types exported from the `colorize` gem. -# Please instead update this file by running `bin/tapioca gem colorize`. - -# typed: true - -module Colorize; end - -module Colorize::ClassMethods - def color_codes; end - def color_matrix(_ = T.unsafe(nil)); end - def color_methods; end - def color_samples; end - def colors; end - def disable_colorization(value = T.unsafe(nil)); end - def disable_colorization=(value); end - def mode_codes; end - def modes; end - def modes_methods; end -end - -module Colorize::InstanceMethods - def colorize(params); end - def colorized?; end - def uncolorize; end - - private - - def background_color(color); end - def color(color); end - def color_from_symbol(match, symbol); end - def colors_from_hash(match, hash); end - def colors_from_params(match, params); end - def defaults_colors(match); end - def mode(mode); end - def require_windows_libs; end - def scan_for_colors; end - def split_colors(match); end -end
true
Other
Homebrew
brew
12a9ec9fd7e1616538bffd5c0460e97c0f7823b9.json
Update RBI files for spoom.
Library/Homebrew/sorbet/rbi/gems/spoom@1.1.5.rbi
@@ -14,6 +14,7 @@ end module Spoom::Cli; end class Spoom::Cli::Bump < ::Thor + include ::Spoom::Colorize include ::Spoom::Cli::Helper sig { params(directory: String).void } @@ -26,13 +27,15 @@ class Spoom::Cli::Bump < ::Thor end class Spoom::Cli::Config < ::Thor + include ::Spoom::Colorize include ::Spoom::Cli::Helper def help(command = T.unsafe(nil), subcommand = T.unsafe(nil)); end def show; end end class Spoom::Cli::Coverage < ::Thor + include ::Spoom::Colorize include ::Spoom::Cli::Helper def bundle_install(path, sha); end @@ -48,16 +51,16 @@ end Spoom::Cli::Coverage::DATA_DIR = T.let(T.unsafe(nil), String) module Spoom::Cli::Helper - include ::Thor::Shell + include ::Spoom::Colorize sig { params(string: String).returns(String) } def blue(string); end sig { returns(T::Boolean) } def color?; end - sig { params(string: String, color: Symbol).returns(String) } - def colorize(string, color); end + sig { params(string: String, color: Spoom::Color).returns(String) } + def colorize(string, *color); end sig { returns(String) } def exec_path; end @@ -96,9 +99,8 @@ module Spoom::Cli::Helper def yellow(string); end end -Spoom::Cli::Helper::HIGHLIGHT_COLOR = T.let(T.unsafe(nil), Symbol) - class Spoom::Cli::LSP < ::Thor + include ::Spoom::Colorize include ::Spoom::Cli::Helper def defs(file, line, col); end @@ -118,6 +120,7 @@ class Spoom::Cli::LSP < ::Thor end class Spoom::Cli::Main < ::Thor + include ::Spoom::Colorize include ::Spoom::Cli::Helper def __print_version; end @@ -134,6 +137,7 @@ class Spoom::Cli::Main < ::Thor end class Spoom::Cli::Run < ::Thor + include ::Spoom::Colorize include ::Spoom::Cli::Helper def colorize_message(message); end @@ -147,6 +151,37 @@ Spoom::Cli::Run::SORT_CODE = T.let(T.unsafe(nil), String) Spoom::Cli::Run::SORT_ENUM = T.let(T.unsafe(nil), Array) Spoom::Cli::Run::SORT_LOC = T.let(T.unsafe(nil), String) +class Spoom::Color < ::T::Enum + enums do + CLEAR = new + BOLD = new + BLACK = new + RED = new + GREEN = new + YELLOW = new + BLUE = new + MAGENTA = new + CYAN = new + WHITE = new + LIGHT_BLACK = new + LIGHT_RED = new + LIGHT_GREEN = new + LIGHT_YELLOW = new + LIGHT_BLUE = new + LIGHT_MAGENTA = new + LIGHT_CYAN = new + LIGHT_WHITE = new + end + + sig { returns(String) } + def ansi_code; end +end + +module Spoom::Colorize + sig { params(string: String, color: Spoom::Color).returns(String) } + def set_color(string, *color); end +end + module Spoom::Coverage class << self sig { params(snapshots: T::Array[Spoom::Coverage::Snapshot], palette: Spoom::Coverage::D3::ColorPalette, path: String).returns(Spoom::Coverage::Report) } @@ -693,7 +728,7 @@ class Spoom::FileTree::TreePrinter < ::Spoom::Printer sig { params(node: Spoom::FileTree::Node).returns(T.nilable(String)) } def node_strictness(node); end - sig { params(strictness: T.nilable(String)).returns(Symbol) } + sig { params(strictness: T.nilable(String)).returns(Spoom::Color) } def strictness_color(strictness); end end @@ -973,13 +1008,15 @@ class Spoom::LSP::SymbolPrinter < ::Spoom::Printer end class Spoom::Printer + include ::Spoom::Colorize + abstract! sig { params(out: T.any(IO, StringIO), colors: T::Boolean, indent_level: Integer).void } def initialize(out: T.unsafe(nil), colors: T.unsafe(nil), indent_level: T.unsafe(nil)); end - sig { params(string: String, color: Symbol).returns(String) } - def colorize(string, color); end + sig { params(string: String, color: Spoom::Color).returns(String) } + def colorize(string, *color); end sig { void } def dedent; end @@ -995,8 +1032,8 @@ class Spoom::Printer sig { params(string: T.nilable(String)).void } def print(string); end - sig { params(string: T.nilable(String), color: Symbol, colors: Symbol).void } - def print_colored(string, color, *colors); end + sig { params(string: T.nilable(String), color: Spoom::Color).void } + def print_colored(string, *color); end sig { params(string: T.nilable(String)).void } def printl(string); end
true
Other
Homebrew
brew
12a9ec9fd7e1616538bffd5c0460e97c0f7823b9.json
Update RBI files for spoom.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -9027,6 +9027,10 @@ class Spoom::Cli::Bump extend ::T::Private::Methods::SingletonMethodHooks end +module Spoom::Cli::Helper + HIGHLIGHT_COLOR = ::T.let(nil, ::T.untyped) +end + module Spoom::Cli::Helper extend ::T::Sig extend ::T::Helpers @@ -9038,6 +9042,12 @@ class Spoom::Cli::Main extend ::T::Sig end +module Spoom::Colorize + extend ::T::Sig + extend ::T::Private::Methods::MethodHooks + extend ::T::Private::Methods::SingletonMethodHooks +end + class Spoom::Coverage::D3::Base extend ::T::Sig extend ::T::Helpers @@ -9205,101 +9215,25 @@ module Spoom end class String - def black(); end - - def blink(); end - - def blue(); end - - def bold(); end - - def cyan(); end - def exclude?(string); end def fast_xs(); end - def green(); end - - def hide(); end - def indent(amount, indent_string=T.unsafe(nil), indent_empty_lines=T.unsafe(nil)); end def indent!(amount, indent_string=T.unsafe(nil), indent_empty_lines=T.unsafe(nil)); end - def italic(); end - - def light_black(); end - - def light_blue(); end - - def light_cyan(); end - - def light_green(); end - - def light_magenta(); end - - def light_red(); end - - def light_white(); end - - def light_yellow(); end - - def magenta(); end - - def on_black(); end - - def on_blue(); end - - def on_cyan(); end - - def on_green(); end - - def on_light_black(); end - - def on_light_blue(); end - - def on_light_cyan(); end - - def on_light_green(); end - - def on_light_magenta(); end - - def on_light_red(); end - - def on_light_white(); end - - def on_light_yellow(); end - - def on_magenta(); end - - def on_red(); end - - def on_white(); end - - def on_yellow(); end - - def red(); end - def shellescape(); end def shellsplit(); end - def swap(); end - def to_nfc(); end def to_nfd(); end def to_nfkc(); end def to_nfkd(); end - - def underline(); end - - def white(); end - - def yellow(); end end class String
true
Other
Homebrew
brew
12a9ec9fd7e1616538bffd5c0460e97c0f7823b9.json
Update RBI files for spoom.
Library/Homebrew/sorbet/rbi/todo.rbi
@@ -2,6 +2,8 @@ # srb rbi todo # typed: strong +module ::Colorize::ClassMethods; end +module ::Colorize::InstanceMethods; end module ::StackProf; end module T::InterfaceWrapper::Helpers; end module T::Private::Abstract::Hooks; end
true
Other
Homebrew
brew
e8eb781470df7463ca2147862d257815f5062314.json
mac/formula_cellar_checks: apply suggestions from code review - Fix missing space - use `MachO::Utils.fat_magic?` - call `#flag?` consistently. Co-authored-by: Bo Anderson <mail@boanderson.me>
Library/Homebrew/extend/os/mac/formula_cellar_checks.rb
@@ -41,7 +41,7 @@ def check_openssl_links These object files were linked against the deprecated system OpenSSL or the system's private LibreSSL. Adding `depends_on "openssl"` to the formula may help. - #{system_openssl * "\n "} + #{system_openssl * "\n "} EOS end @@ -97,10 +97,10 @@ def check_flat_namespace(formula) next true unless file.dylib? macho = MachO.open(file) - if file.universal? + if MachO::Utils.fat_magic?(macho.magic) macho.machos.map(&:header).all? { |h| h.flag? :MH_TWOLEVEL } else - macho.header.flag?(:MH_TWOLEVEL) + macho.header.flag? :MH_TWOLEVEL end end return if flat_namespace_files.empty?
false
Other
Homebrew
brew
cfc1821e2c6b0c162cb2d675fae33ca6f08a62bb.json
tap: fix unexpected wrong variable name
Library/Homebrew/tap.rb
@@ -384,7 +384,7 @@ def fix_remote_configuration(requested_remote: nil, quiet: false) path.git_origin_set_head_auto new_upstream_head = path.git_origin_branch - return if new_upstream_head == old_upstream_head + return if new_upstream_head == current_upstream_head path.git_rename_branch old: current_upstream_head, new: new_upstream_head path.git_branch_set_upstream local: new_upstream_head, origin: new_upstream_head
false
Other
Homebrew
brew
889b30b32e6b0d8d6bfccbd28a557c66121fa7a6.json
tap: apply suggestions from code review Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Library/Homebrew/tap.rb
@@ -765,7 +765,7 @@ def install(quiet: false, clone_target: nil, force_auto_update: nil, custom_remo remote = Homebrew::EnvConfig.core_git_remote requested_remote = clone_target || default_remote - # The remote will changed again on `brew update` since remotes for Homebrew/core are mismatch + # The remote will changed again on `brew update` since remotes for Homebrew/core are mismatched raise TapCoreRemoteMismatchError.new(name, remote, requested_remote) if requested_remote != remote if remote != default_remote
false
Other
Homebrew
brew
3dcfc7e26e663f8378d48aa6a6d48541aea31d9d.json
tap: apply suggestions from code review Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Library/Homebrew/tap.rb
@@ -366,7 +366,7 @@ def link_completions_and_manpages end def fix_remote_configuration(requested_remote: nil, quiet: false) - unless requested_remote.nil? + if requested_remote.present? path.cd do safe_system "git", "remote", "set-url", "origin", requested_remote safe_system "git", "config", "remote.origin.fetch", "+refs/heads/*:refs/remotes/origin/*" @@ -375,10 +375,10 @@ def fix_remote_configuration(requested_remote: nil, quiet: false) end current_upstream_head = path.git_origin_branch - return if requested_remote.nil? && path.git_origin_has_branch?(current_upstream_head) + return if requested_remote.blank? && path.git_origin_has_branch?(current_upstream_head) args = %w[fetch] - args << "-q" if quiet + args << "--quiet" if quiet args << "origin" safe_system "git", "-C", path, *args path.git_origin_set_head_auto
false
Other
Homebrew
brew
4fbe0a2b1bd35eb76467a9decee526382fe9ac5b.json
Fix false positives in audit There was a typo that made it so that all libraries were being included in `flat_namespace_files`.
Library/Homebrew/extend/os/mac/formula_cellar_checks.rb
@@ -98,9 +98,9 @@ def check_flat_namespace(formula) macho = MachO.open(file) if file.universal? - macho.machos.map(&:header).all? { |h| h.flag? :MH_TWO_LEVEL } + macho.machos.map(&:header).all? { |h| h.flag? :MH_TWOLEVEL } else - macho.header.flag?(:MH_TWO_LEVEL) + macho.header.flag?(:MH_TWOLEVEL) end end return if flat_namespace_files.empty?
false
Other
Homebrew
brew
07bcab367fb05bbb3af7e05c67c41e725c0de043.json
sorbet: Update RBI files. Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -5858,6 +5858,7 @@ class Object HOMEBREW_USER_AGENT_RUBY = ::T.let(nil, ::T.untyped) HOMEBREW_VERSION = ::T.let(nil, ::T.untyped) HOMEBREW_WWW = ::T.let(nil, ::T.untyped) + LINUXBREW_CORE_MIGRATION_LIST = ::T.let(nil, ::T.untyped) OFFICIAL_CASK_TAPS = ::T.let(nil, ::T.untyped) OFFICIAL_CMD_TAPS = ::T.let(nil, ::T.untyped) OPTION_DESC_WIDTH = ::T.let(nil, ::T.untyped)
false
Other
Homebrew
brew
231b10beea223bd62ccbbd6783ec4d1fc45115d9.json
os/mac: track only the major version instead
Library/Homebrew/os/mac.rb
@@ -45,7 +45,8 @@ def full_version=(version) sig { returns(::Version) } def latest_sdk_version # TODO: bump version when new Xcode macOS SDK is released - ::Version.new("11.3") + # NOTE: We only track the major version of the SDK. + ::Version.new("11") end private :latest_sdk_version
false
Other
Homebrew
brew
2d89e7d24e9e24fc44e487bcef72ccffdc353908.json
utils/shfmt.sh: apply suggestions from code review Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Library/Homebrew/utils/shfmt.sh
@@ -390,7 +390,7 @@ do retcode="$?" if [[ "${retcode}" == 4 ]] then - onoe "${0##*/}: Bad styles detected in file \"${file}\", apply auto-fix." + onoe "${0##*/}: Bad styles detected in file \"${file}\", fixing..." retcode='' fi fi
false
Other
Homebrew
brew
3113bf7158141b5223709933b65f3fa3fcfefc28.json
utils/shfmt.sh: redirect differences to stderr
Library/Homebrew/utils/shfmt.sh
@@ -371,7 +371,7 @@ format() { cp -af "${tempfile}" "${file}" else # Show differences - "${DIFF}" "${DIFF_ARGS[@]}" "${file}" "${tempfile}" + "${DIFF}" "${DIFF_ARGS[@]}" "${file}" "${tempfile}" 1>&2 fi return 4 else
false
Other
Homebrew
brew
61bce2e71a90ba07f0646275b917766ec3d100e3.json
Update RBI files for rubocop-rails.
Library/Homebrew/sorbet/rbi/gems/rubocop-rails@2.12.3.rbi
@@ -387,6 +387,7 @@ class RuboCop::Cop::Rails::ContentTag < ::RuboCop::Cop::Base def autocorrect(corrector, node, preferred_method); end def corrected_ancestor?(node); end def correction_range(node); end + def register_offense(node, message, preferred_method); end end RuboCop::Cop::Rails::ContentTag::MSG = T.let(T.unsafe(nil), String) @@ -690,6 +691,8 @@ class RuboCop::Cop::Rails::FindEach < ::RuboCop::Cop::Base private + def active_model_error?(node); end + def active_model_error_where?(node); end def ignored?(node); end end
true
Other
Homebrew
brew
61bce2e71a90ba07f0646275b917766ec3d100e3.json
Update RBI files for rubocop-rails.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -7425,11 +7425,6 @@ module Readline def self.completion_quote_character(); end end -module ReleaseNotes - extend ::T::Private::Methods::MethodHooks - extend ::T::Private::Methods::SingletonMethodHooks -end - class Requirement extend ::T::Private::Methods::MethodHooks extend ::T::Private::Methods::SingletonMethodHooks
true
Other
Homebrew
brew
18ece131972068fc72d6ea649ee0238564e25d58.json
Update RBI files for sorbet.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -490,26 +490,6 @@ class Bundler::Injector def self.remove(gems, options=T.unsafe(nil)); end end -class Bundler::Installer - def generate_bundler_executable_stubs(spec, options=T.unsafe(nil)); end - - def generate_standalone_bundler_executable_stubs(spec); end - - def initialize(root, definition); end - - def post_install_messages(); end - - def run(options); end -end - -class Bundler::Installer - def self.ambiguous_gems(); end - - def self.ambiguous_gems=(ambiguous_gems); end - - def self.install(root, definition, options=T.unsafe(nil)); end -end - class Bundler::Molinillo::DependencyGraph include ::Enumerable end @@ -7425,11 +7405,6 @@ module Readline def self.completion_quote_character(); end end -module ReleaseNotes - extend ::T::Private::Methods::MethodHooks - extend ::T::Private::Methods::SingletonMethodHooks -end - class Requirement extend ::T::Private::Methods::MethodHooks extend ::T::Private::Methods::SingletonMethodHooks
false
Other
Homebrew
brew
aa90e09c4a0358f0391e2dc701c84584c96f87ec.json
Update RBI files for rbi.
Library/Homebrew/sorbet/rbi/gems/rbi@0.0.5.rbi
@@ -651,6 +651,9 @@ class RBI::Param < ::RBI::NodeWithComments sig { override.params(v: RBI::Printer).void } def accept_printer(v); end + sig { returns(T::Array[String]) } + def comments_lines; end + sig { returns(String) } def name; end @@ -670,6 +673,9 @@ class RBI::ParseError < ::StandardError end class RBI::Parser + sig { void } + def initialize; end + sig { params(path: String).returns(RBI::Tree) } def parse_file(path); end @@ -1025,6 +1031,9 @@ class RBI::SigParam < ::RBI::NodeWithComments sig { override.params(v: RBI::Printer).void } def accept_printer(v); end + sig { returns(T::Array[String]) } + def comments_lines; end + sig { returns(String) } def name; end
true
Other
Homebrew
brew
aa90e09c4a0358f0391e2dc701c84584c96f87ec.json
Update RBI files for rbi.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -7425,11 +7425,6 @@ module Readline def self.completion_quote_character(); end end -module ReleaseNotes - extend ::T::Private::Methods::MethodHooks - extend ::T::Private::Methods::SingletonMethodHooks -end - class Requirement extend ::T::Private::Methods::MethodHooks extend ::T::Private::Methods::SingletonMethodHooks
true
Other
Homebrew
brew
25fe428ed27e89cd5ff9f7c6aee9d32e2e73faa7.json
system_config: fix clang version output on Linux If you have Homebrew LLVM installed, `brew config` will show Clang: 12.0.1 build (parse error) because Homebrew LLVM does not give a build number. Some installations from the system package manager do have this information, so let's show it if it's available but skip complaining if not. I've kept the original code for macOS because we always expect Apple's build number to show there.
Library/Homebrew/extend/os/mac/system_config.rb
@@ -7,7 +7,7 @@ module SystemConfig class << self include SystemCommand::Mixin - undef describe_homebrew_ruby + undef describe_homebrew_ruby, describe_clang def describe_homebrew_ruby s = describe_homebrew_ruby_version @@ -19,6 +19,13 @@ def describe_homebrew_ruby end end + def describe_clang + return "N/A" if clang.null? + + clang_build_info = clang_build.null? ? "(parse error)" : clang_build + "#{clang} build #{clang_build_info}" + end + def xcode @xcode ||= if MacOS::Xcode.installed? xcode = MacOS::Xcode.version.to_s
true
Other
Homebrew
brew
25fe428ed27e89cd5ff9f7c6aee9d32e2e73faa7.json
system_config: fix clang version output on Linux If you have Homebrew LLVM installed, `brew config` will show Clang: 12.0.1 build (parse error) because Homebrew LLVM does not give a build number. Some installations from the system package manager do have this information, so let's show it if it's available but skip complaining if not. I've kept the original code for macOS because we always expect Apple's build number to show there.
Library/Homebrew/system_config.rb
@@ -76,8 +76,11 @@ def core_tap_origin def describe_clang return "N/A" if clang.null? - clang_build_info = clang_build.null? ? "(parse error)" : clang_build - "#{clang} build #{clang_build_info}" + if clang_build.null? + clang.to_s + else + "#{clang} build #{clang_build}" + end end def describe_path(path)
true
Other
Homebrew
brew
4f1bbf003ad1ad3523cdc59a04d49e0973d05090.json
Use GitHub API to generate release notes
Library/Homebrew/dev-cmd/release.rb
@@ -2,7 +2,6 @@ # frozen_string_literal: true require "cli/parser" -require "release_notes" module Homebrew extend T::Sig @@ -70,12 +69,15 @@ def release if args.major? || args.minor? latest_major_minor_version = "#{latest_version.major}.#{latest_version.minor.to_i}.0" ohai "Release notes since #{latest_major_minor_version} for #{new_version} blog post:" - # release notes without username suffix or dependabot bumps - puts ReleaseNotes.generate_release_notes(latest_major_minor_version, "origin/HEAD") - .lines - .reject { |l| l.include?(" (@Homebrew)") } - .map { |l| l.gsub(/ \(@[\w-]+\)$/, "") } - .sort + # release notes without usernames, new contributors, or extra lines + blog_post_notes = GitHub.generate_release_notes("Homebrew", "brew", new_version, + previous_tag: latest_major_minor_version)["body"] + blog_post_notes = blog_post_notes.lines.map do |line| + next unless (match = line.match(/^\* (.*) by @[\w-]+ in (.*)$/)) + + "- [#{match[1]}](#{match[2]})" + end.compact.sort + puts blog_post_notes end ohai "Creating draft release for version #{new_version}" @@ -85,7 +87,8 @@ def release else "" end - release_notes += ReleaseNotes.generate_release_notes latest_version, "origin/HEAD" + release_notes += GitHub.generate_release_notes("Homebrew", "brew", new_version, + previous_tag: latest_version)["body"] begin release = GitHub.create_or_update_release "Homebrew", "brew", new_version, body: release_notes, draft: true
true
Other
Homebrew
brew
4f1bbf003ad1ad3523cdc59a04d49e0973d05090.json
Use GitHub API to generate release notes
Library/Homebrew/release_notes.rb
@@ -1,30 +0,0 @@ -# typed: strict -# frozen_string_literal: true - -# Helper functions for generating release notes. -# -# @api private -module ReleaseNotes - extend T::Sig - - module_function - - sig { - params(start_ref: T.any(String, Version), end_ref: T.any(String, Version), markdown: T.nilable(T::Boolean)) - .returns(String) - } - def generate_release_notes(start_ref, end_ref, markdown: false) - Utils.safe_popen_read( - "git", "-C", HOMEBREW_REPOSITORY, "log", "--pretty=format:'%s >> - %b%n'", "#{start_ref}..#{end_ref}" - ).lines.map do |s| - matches = s.match(%r{.*Merge pull request #(?<pr>\d+) from (?<user>[^/]+)/[^>]*>> - (?<body>.*)}) - next if matches.blank? - next if matches[:user] == "Homebrew" - - body = matches[:body].presence - body ||= s.gsub(/.*(Merge pull request .*) >> - .*/, "\\1").chomp - - "- [#{body}](https://github.com/Homebrew/brew/pull/#{matches[:pr]}) (@#{matches[:user]})\n" - end.compact.join - end -end
true
Other
Homebrew
brew
4f1bbf003ad1ad3523cdc59a04d49e0973d05090.json
Use GitHub API to generate release notes
Library/Homebrew/test/release_notes_spec.rb
@@ -1,28 +0,0 @@ -# typed: false -# frozen_string_literal: true - -require "release_notes" - -describe ReleaseNotes do - before do - HOMEBREW_REPOSITORY.cd do - system "git", "init" - system "git", "commit", "--allow-empty", "-m", "Initial commit" - system "git", "tag", "release-notes-testing" - system "git", "commit", "--allow-empty", "-m", "Merge pull request #1 from Homebrew/fix", "-m", "Do something" - system "git", "commit", "--allow-empty", "-m", "make a change" - system "git", "commit", "--allow-empty", "-m", "Merge pull request #2 from User/fix", "-m", "Do something else" - system "git", "commit", "--allow-empty", "-m", "another change" - system "git", "commit", "--allow-empty", "-m", "Merge pull request #3 from User/another_change" - end - end - - describe ".generate_release_notes" do - it "generates markdown release notes" do - expect(described_class.generate_release_notes("release-notes-testing", "HEAD")).to eq <<~NOTES - - [Merge pull request #3 from User/another_change](https://github.com/Homebrew/brew/pull/3) (@User) - - [Do something else](https://github.com/Homebrew/brew/pull/2) (@User) - NOTES - end - end -end
true
Other
Homebrew
brew
4f1bbf003ad1ad3523cdc59a04d49e0973d05090.json
Use GitHub API to generate release notes
Library/Homebrew/utils/github.rb
@@ -225,6 +225,13 @@ def get_latest_release(user, repo) API.open_rest(url, request_method: :GET) end + def generate_release_notes(user, repo, tag, previous_tag: nil) + url = "#{API_URL}/repos/#{user}/#{repo}/releases/generate-notes" + data = { tag_name: tag } + data[:previous_tag_name] = previous_tag if previous_tag.present? + API.open_rest(url, data: data, request_method: :POST, scopes: CREATE_ISSUE_FORK_OR_PR_SCOPES) + end + def create_or_update_release(user, repo, tag, id: nil, name: nil, body: nil, draft: false) url = "#{API_URL}/repos/#{user}/#{repo}/releases" method = if id
true
Other
Homebrew
brew
03a72760ef8a7b3c04193ed51fa5398d38abbd96.json
utils/curl: add comment detailing options handling
Library/Homebrew/utils/curl.rb
@@ -304,13 +304,16 @@ def curl_http_content_headers_and_checksum( ) file = Tempfile.new.tap(&:close) + # Convert specs to options. This is mostly key-value options, + # unless the value is a boolean in which case treat as as flag. specs = specs.flat_map do |option, argument| next [] if argument == false # No flag. args = ["--#{option.to_s.tr("_", "-")}"] args << argument unless argument == true # It's a flag. args end + max_time = hash_needed ? 600 : 25 output, _, status = curl_output( *specs, "--dump-header", "-", "--output", file.path, "--location", url,
false
Other
Homebrew
brew
c6cddacc5ef10703db87b277158548f3959085f1.json
utils/curl: fix false flag handling
Library/Homebrew/utils/curl.rb
@@ -305,7 +305,7 @@ def curl_http_content_headers_and_checksum( file = Tempfile.new.tap(&:close) specs = specs.flat_map do |option, argument| - next if argument == false # No flag. + next [] if argument == false # No flag. args = ["--#{option.to_s.tr("_", "-")}"] args << argument unless argument == true # It's a flag.
false
Other
Homebrew
brew
73a1ff82d25560746fae3fb4cbc51df6acbbd786.json
utils/curl: fix flag handling
Library/Homebrew/utils/curl.rb
@@ -304,7 +304,13 @@ def curl_http_content_headers_and_checksum( ) file = Tempfile.new.tap(&:close) - specs = specs.flat_map { |option, argument| ["--#{option.to_s.tr("_", "-")}", argument] } + specs = specs.flat_map do |option, argument| + next if argument == false # No flag. + + args = ["--#{option.to_s.tr("_", "-")}"] + args << argument unless argument == true # It's a flag. + args + end max_time = hash_needed ? 600 : 25 output, _, status = curl_output( *specs, "--dump-header", "-", "--output", file.path, "--location", url,
false
Other
Homebrew
brew
cb0a90262d8914b749fadcede523ef2e0604cbd4.json
download_strategy: remove redundant conditional
Library/Homebrew/download_strategy.rb
@@ -550,7 +550,7 @@ def _curl_args "because we need it installed to download securely." @insecure_warning_shown = true end - args += ["--insecure"] if meta[:insecure] + args += ["--insecure"] end args
false
Other
Homebrew
brew
dd263e0a5ef9fe68d396caf0c7412b842764dd40.json
Update RBI files for sorbet.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -62,11 +62,6 @@ class Addrinfo def connect_internal(local_addrinfo, timeout=T.unsafe(nil)); end end -class Archive - extend ::T::Private::Methods::MethodHooks - extend ::T::Private::Methods::SingletonMethodHooks -end - class Array def abbrev(pattern=T.unsafe(nil)); end @@ -4659,8 +4654,6 @@ module Homebrew::EnvConfig def self.install_badge(); end - def self.internet_archive_key(); end - def self.livecheck_watchlist(); end def self.logs(); end
false
Other
Homebrew
brew
629dbb7c593f97538d59691173add17d47657939.json
rubocops/urls: allow plain HTTP mirrors
Library/Homebrew/rubocops/extend/formula.rb
@@ -35,14 +35,14 @@ def on_class(node) # @param urls [Array] url/mirror method call nodes # @param regex [Regexp] pattern to match URLs def audit_urls(urls, regex) - urls.each do |url_node| + urls.each_with_index do |url_node, index| url_string_node = parameters(url_node).first url_string = string_content(url_string_node) match_object = regex_match_group(url_string_node, regex) next unless match_object offending_node(url_string_node.parent) - yield match_object, url_string + yield match_object, url_string, index end end
true
Other
Homebrew
brew
629dbb7c593f97538d59691173add17d47657939.json
rubocops/urls: allow plain HTTP mirrors
Library/Homebrew/rubocops/urls.rb
@@ -83,8 +83,14 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node) %r{^http://(?:[^/]*\.)?archive\.org}, %r{^http://(?:[^/]*\.)?freedesktop\.org}, %r{^http://(?:[^/]*\.)?mirrorservice\.org/}]) - audit_urls(urls, http_to_https_patterns) do |_, url| - problem "Please use https:// for #{url}" + audit_urls(urls, http_to_https_patterns) do |_, url, index| + # It's fine to have a plain HTTP mirror further down the mirror list. + https_url = url.dup.insert(4, "s") + https_index = nil + audit_urls(urls, https_url) do |_, _, found_https_index| + https_index = found_https_index + end + problem "Please use https:// for #{url}" if !https_index || https_index > index end apache_mirror_pattern = %r{^https?://(?:[^/]*\.)?apache\.org/dyn/closer\.(?:cgi|lua)\?path=/?(.*)}i
true
Other
Homebrew
brew
84a7c2ba7d1b45764cc5381f67d63eec1448de9f.json
Add VS Code to list of fallback editors
Library/Homebrew/utils.rb
@@ -363,8 +363,8 @@ def which_editor editor = Homebrew::EnvConfig.editor return editor if editor - # Find Atom, Sublime Text, Textmate, BBEdit / TextWrangler, or vim - editor = %w[atom subl mate edit vim].find do |candidate| + # Find Atom, Sublime Text, VS Code, Textmate, BBEdit / TextWrangler, or vim + editor = %w[atom subl code mate edit vim].find do |candidate| candidate if which(candidate, ENV["HOMEBREW_PATH"]) end editor ||= "vim"
false
Other
Homebrew
brew
5542b8d585c13c756d6bcf9885282885d6d5b2e8.json
Update RBI files for rubocop.
Library/Homebrew/sorbet/rbi/gems/rubocop@1.22.0.rbi
@@ -255,6 +255,7 @@ class RuboCop::Config def to_s; end def transform_values(*args, &block); end def validate(*args, &block); end + def validate_after_resolution; end private @@ -541,6 +542,7 @@ class RuboCop::ConfigValidator def smart_loaded_path(*args, &block); end def target_ruby_version; end def validate; end + def validate_after_resolution; end def validate_section_presence(name); end private @@ -911,18 +913,22 @@ class RuboCop::Cop::Bundler::InsecureProtocolSource < ::RuboCop::Cop::Base def insecure_protocol_source?(param0 = T.unsafe(nil)); end def on_send(node); end + + private + + def allow_http_protocol?; end end RuboCop::Cop::Bundler::InsecureProtocolSource::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::Bundler::InsecureProtocolSource::MSG_HTTP_PROTOCOL = T.let(T.unsafe(nil), String) RuboCop::Cop::Bundler::InsecureProtocolSource::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) -class RuboCop::Cop::Bundler::OrderedGems < ::RuboCop::Cop::Cop - include ::RuboCop::Cop::ConfigurableEnforcedStyle +class RuboCop::Cop::Bundler::OrderedGems < ::RuboCop::Cop::Base include ::RuboCop::Cop::OrderedGemNode + extend ::RuboCop::Cop::AutoCorrector - def autocorrect(node); end def gem_declarations(param0); end - def investigate(processed_source); end + def on_new_investigation; end private @@ -1468,12 +1474,14 @@ end module RuboCop::Cop::FrozenStringLiteral private + def frozen_heredoc?(node); end def frozen_string_literal?(node); end def frozen_string_literal_comment_exists?; end def frozen_string_literal_specified?; end def frozen_string_literals_disabled?; end def frozen_string_literals_enabled?; end def leading_comment_lines; end + def uninterpolated_string?(node); end class << self def frozen_string_literal_comment_exists?; end @@ -1483,7 +1491,6 @@ end RuboCop::Cop::FrozenStringLiteral::FROZEN_STRING_LITERAL = T.let(T.unsafe(nil), String) RuboCop::Cop::FrozenStringLiteral::FROZEN_STRING_LITERAL_ENABLED = T.let(T.unsafe(nil), String) RuboCop::Cop::FrozenStringLiteral::FROZEN_STRING_LITERAL_TYPES_RUBY27 = T.let(T.unsafe(nil), Array) -RuboCop::Cop::FrozenStringLiteral::FROZEN_STRING_LITERAL_TYPES_RUBY30 = T.let(T.unsafe(nil), Array) module RuboCop::Cop::GemDeclaration extend ::RuboCop::AST::NodePattern::Macros @@ -1520,13 +1527,12 @@ end RuboCop::Cop::Gemspec::DuplicatedAssignment::MSG = T.let(T.unsafe(nil), String) -class RuboCop::Cop::Gemspec::OrderedDependencies < ::RuboCop::Cop::Cop - include ::RuboCop::Cop::ConfigurableEnforcedStyle +class RuboCop::Cop::Gemspec::OrderedDependencies < ::RuboCop::Cop::Base include ::RuboCop::Cop::OrderedGemNode + extend ::RuboCop::Cop::AutoCorrector - def autocorrect(node); end def dependency_declarations(param0); end - def investigate(processed_source); end + def on_new_investigation; end private @@ -1565,7 +1571,7 @@ end RuboCop::Cop::Gemspec::RubyVersionGlobalsUsage::MSG = T.let(T.unsafe(nil), String) class RuboCop::Cop::Generator - def initialize(name, github_user, output: T.unsafe(nil)); end + def initialize(name, output: T.unsafe(nil)); end def inject_config(config_file_path: T.unsafe(nil), version_added: T.unsafe(nil)); end def inject_require(root_file_path: T.unsafe(nil)); end @@ -1579,7 +1585,6 @@ class RuboCop::Cop::Generator def generate(template); end def generated_source; end def generated_spec; end - def github_user; end def output; end def snake_case(camel_case_string); end def source_path; end @@ -2160,9 +2165,12 @@ class RuboCop::Cop::Layout::DotPosition < ::RuboCop::Cop::Base def ampersand_dot?(node); end def autocorrect(corrector, dot, node); end def correct_dot_position_style?(dot_line, selector_line); end + def heredoc?(node); end + def last_heredoc_line(node); end def line_between?(first_line, second_line); end def message(dot); end def proper_dot_position?(node); end + def receiver_end_line(node); end def selector_range(node); end end @@ -3058,7 +3066,7 @@ class RuboCop::Cop::Layout::LineLength < ::RuboCop::Cop::Base def line_in_heredoc?(line_number); end def line_in_permitted_heredoc?(line_number); end def max; end - def register_offense(loc, line, line_index); end + def register_offense(loc, line, line_index, length: T.unsafe(nil)); end def shebang?(line, line_index); end end @@ -3334,7 +3342,9 @@ class RuboCop::Cop::Layout::SingleLineBlockChain < ::RuboCop::Cop::Base private + def call_method_after_block?(node, dot_range, closing_block_delimiter_line_num); end def offending_range(node); end + def selector_range(node); end end RuboCop::Cop::Layout::SingleLineBlockChain::MSG = T.let(T.unsafe(nil), String) @@ -3383,6 +3393,7 @@ class RuboCop::Cop::Layout::SpaceAfterNot < ::RuboCop::Cop::Base end RuboCop::Cop::Layout::SpaceAfterNot::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::Layout::SpaceAfterNot::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) class RuboCop::Cop::Layout::SpaceAfterSemicolon < ::RuboCop::Cop::Base include ::RuboCop::Cop::SpaceAfterPunctuation @@ -3611,6 +3622,7 @@ class RuboCop::Cop::Layout::SpaceBeforeBrackets < ::RuboCop::Cop::Base end RuboCop::Cop::Layout::SpaceBeforeBrackets::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::Layout::SpaceBeforeBrackets::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) class RuboCop::Cop::Layout::SpaceBeforeComma < ::RuboCop::Cop::Base include ::RuboCop::Cop::RangeHelp @@ -3783,11 +3795,15 @@ class RuboCop::Cop::Layout::SpaceInsideParens < ::RuboCop::Cop::Base private def can_be_ignored?(token1, token2); end - def each_extraneous_space(tokens); end - def each_extraneous_space_in_empty_parens(token1, token2); end - def each_missing_space(token1, token2); end + def correct_extaneus_space_between_consecutive_parens(token1, token2); end + def correct_extraneous_space(tokens); end + def correct_extraneous_space_in_empty_parens(token1, token2); end + def correct_missing_space(token1, token2); end + def left_parens?(token1, token2); end def parens?(token1, token2); end + def process_with_compact_style(tokens); end def process_with_space_style(tokens); end + def right_parens?(token1, token2); end def same_line?(token1, token2); end end @@ -4011,6 +4027,26 @@ end RuboCop::Cop::Lint::AmbiguousOperator::AMBIGUITIES = T.let(T.unsafe(nil), Hash) RuboCop::Cop::Lint::AmbiguousOperator::MSG_FORMAT = T.let(T.unsafe(nil), String) +class RuboCop::Cop::Lint::AmbiguousOperatorPrecedence < ::RuboCop::Cop::Base + extend ::RuboCop::Cop::AutoCorrector + + def on_and(node); end + def on_new_investigation; end + def on_send(node); end + + private + + def autocorrect(corrector, node); end + def greater_precedence?(node1, node2); end + def operator?(node); end + def operator_name(node); end + def precedence(node); end +end + +RuboCop::Cop::Lint::AmbiguousOperatorPrecedence::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::Lint::AmbiguousOperatorPrecedence::PRECEDENCE = T.let(T.unsafe(nil), Array) +RuboCop::Cop::Lint::AmbiguousOperatorPrecedence::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) + class RuboCop::Cop::Lint::AmbiguousRange < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector @@ -4055,7 +4091,7 @@ class RuboCop::Cop::Lint::AssignmentInCondition < ::RuboCop::Cop::Base def conditional_assignment?(asgn_node); end def message(_node); end def skip_children?(asgn_node); end - def traverse_node(node, types, &block); end + def traverse_node(node, &block); end end RuboCop::Cop::Lint::AssignmentInCondition::ASGN_TYPES = T.let(T.unsafe(nil), Array) @@ -4147,7 +4183,6 @@ class RuboCop::Cop::Lint::Debugger < ::RuboCop::Cop::Base end RuboCop::Cop::Lint::Debugger::MSG = T.let(T.unsafe(nil), String) -RuboCop::Cop::Lint::Debugger::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) class RuboCop::Cop::Lint::DeprecatedClassMethods < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector @@ -4176,7 +4211,7 @@ class RuboCop::Cop::Lint::DeprecatedClassMethods::DeprecatedClassMethod private - def delimeter; end + def delimiter; end end RuboCop::Cop::Lint::DeprecatedClassMethods::INSTANCE_METHOD_DELIMETER = T.let(T.unsafe(nil), String) @@ -4192,7 +4227,7 @@ class RuboCop::Cop::Lint::DeprecatedClassMethods::Replacement private - def delimeter; end + def delimiter; end def instance_method?; end end @@ -4372,6 +4407,7 @@ class RuboCop::Cop::Lint::ElseLayout < ::RuboCop::Cop::Base def autocorrect(corrector, node, first_else); end def check(node); end def check_else(node); end + def indentation_width; end end RuboCop::Cop::Lint::ElseLayout::MSG = T.let(T.unsafe(nil), String) @@ -4619,6 +4655,21 @@ RuboCop::Cop::Lint::ImplicitStringConcatenation::FOR_ARRAY = T.let(T.unsafe(nil) RuboCop::Cop::Lint::ImplicitStringConcatenation::FOR_METHOD = T.let(T.unsafe(nil), String) RuboCop::Cop::Lint::ImplicitStringConcatenation::MSG = T.let(T.unsafe(nil), String) +class RuboCop::Cop::Lint::IncompatibleIoSelectWithFiberScheduler < ::RuboCop::Cop::Base + extend ::RuboCop::Cop::AutoCorrector + + def io_select(param0 = T.unsafe(nil)); end + def on_send(node); end + + private + + def preferred_method(read, write, timeout); end + def scheduler_compatible?(io1, io2); end +end + +RuboCop::Cop::Lint::IncompatibleIoSelectWithFiberScheduler::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::Lint::IncompatibleIoSelectWithFiberScheduler::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) + class RuboCop::Cop::Lint::IneffectiveAccessModifier < ::RuboCop::Cop::Base def on_class(node); end def on_module(node); end @@ -4898,6 +4949,7 @@ class RuboCop::Cop::Lint::NumberConversion < ::RuboCop::Cop::Base private + def conversion_method?(method_name); end def correct_method(node, receiver); end def correct_sym_method(to_method); end def handle_as_symbol(node); end @@ -4909,6 +4961,7 @@ class RuboCop::Cop::Lint::NumberConversion < ::RuboCop::Cop::Base def top_receiver(node); end end +RuboCop::Cop::Lint::NumberConversion::CONVERSION_METHODS = T.let(T.unsafe(nil), Array) RuboCop::Cop::Lint::NumberConversion::CONVERSION_METHOD_CLASS_MAPPING = T.let(T.unsafe(nil), Hash) RuboCop::Cop::Lint::NumberConversion::METHODS = T.let(T.unsafe(nil), String) RuboCop::Cop::Lint::NumberConversion::MSG = T.let(T.unsafe(nil), String) @@ -5252,6 +5305,21 @@ end RuboCop::Cop::Lint::RequireParentheses::MSG = T.let(T.unsafe(nil), String) +class RuboCop::Cop::Lint::RequireRelativeSelfPath < ::RuboCop::Cop::Base + include ::RuboCop::Cop::RangeHelp + extend ::RuboCop::Cop::AutoCorrector + + def on_send(node); end + + private + + def remove_ext(file_path); end + def same_file?(file_path, required_feature); end +end + +RuboCop::Cop::Lint::RequireRelativeSelfPath::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::Lint::RequireRelativeSelfPath::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) + class RuboCop::Cop::Lint::RescueException < ::RuboCop::Cop::Base def on_resbody(node); end def targets_exception?(rescue_arg_node); end @@ -6451,8 +6519,7 @@ class RuboCop::Cop::Naming::InclusiveLanguage < ::RuboCop::Cop::Base def add_to_flagged_term_hash(regex_string, term, term_definition); end def array_to_ignorecase_regex(strings); end def check_token?(type); end - def create_message(word); end - def create_message_for_file(word); end + def create_message(word, message = T.unsafe(nil)); end def create_multiple_word_message_for_file(words); end def create_single_word_message_for_file(word); end def ensure_regex_string(regex); end @@ -6471,6 +6538,8 @@ class RuboCop::Cop::Naming::InclusiveLanguage < ::RuboCop::Cop::Base end RuboCop::Cop::Naming::InclusiveLanguage::EMPTY_ARRAY = T.let(T.unsafe(nil), Array) +RuboCop::Cop::Naming::InclusiveLanguage::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::Naming::InclusiveLanguage::MSG_FOR_FILE_PATH = T.let(T.unsafe(nil), String) class RuboCop::Cop::Naming::InclusiveLanguage::WordLocation < ::Struct def position; end @@ -6567,6 +6636,7 @@ class RuboCop::Cop::Naming::RescuedExceptionsVariableName < ::RuboCop::Cop::Base def message(node); end def offense_range(resbody); end def preferred_name(variable_name); end + def shadowed_variable_name?(node); end def variable_name(node); end def variable_name_matches?(node, name); end end @@ -6708,6 +6778,7 @@ end class RuboCop::Cop::OrderedGemCorrector extend ::RuboCop::Cop::OrderedGemNode + extend ::RuboCop::Cop::RangeHelp class << self def comments_as_separators; end @@ -6812,6 +6883,7 @@ module RuboCop::Cop::PrecedingFollowingAlignment def aligned_with_adjacent_line?(range, predicate); end def aligned_with_any_line?(line_ranges, range, indent = T.unsafe(nil), &predicate); end def aligned_with_any_line_range?(line_ranges, range, &predicate); end + def aligned_with_append_operator?(range, line); end def aligned_with_assignment(token, line_range); end def aligned_with_line?(line_nos, range, indent = T.unsafe(nil)); end def aligned_with_operator?(range); end @@ -6979,6 +7051,15 @@ end RuboCop::Cop::Security::Eval::MSG = T.let(T.unsafe(nil), String) RuboCop::Cop::Security::Eval::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) +class RuboCop::Cop::Security::IoMethods < ::RuboCop::Cop::Base + extend ::RuboCop::Cop::AutoCorrector + + def on_send(node); end +end + +RuboCop::Cop::Security::IoMethods::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::Security::IoMethods::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) + class RuboCop::Cop::Security::JSONLoad < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector @@ -7985,6 +8066,7 @@ RuboCop::Cop::Style::DocumentDynamicEvalDefinition::RESTRICT_ON_SEND = T.let(T.u class RuboCop::Cop::Style::Documentation < ::RuboCop::Cop::Base include ::RuboCop::Cop::DocumentationComment + include ::RuboCop::Cop::RangeHelp def constant_definition?(param0 = T.unsafe(nil)); end def constant_visibility_declaration?(param0 = T.unsafe(nil)); end @@ -7995,16 +8077,18 @@ class RuboCop::Cop::Style::Documentation < ::RuboCop::Cop::Base private def allowed_constants; end - def check(node, body, type); end + def check(node, body); end def compact_namespace?(node); end def constant_allowed?(node); end def constant_declaration?(node); end + def identifier(node); end def macro_only?(body); end def namespace?(node); end def nodoc(node); end def nodoc?(comment, require_all: T.unsafe(nil)); end def nodoc_comment?(node, require_all: T.unsafe(nil)); end def nodoc_self_or_outer_module?(node); end + def qualify_const(node); end end RuboCop::Cop::Style::Documentation::MSG = T.let(T.unsafe(nil), String) @@ -8334,12 +8418,13 @@ class RuboCop::Cop::Style::ExplicitBlockArgument < ::RuboCop::Cop::Base private - def add_block_argument(node, corrector); end + def add_block_argument(node, corrector, block_name); end def block_body_range(block_node, send_node); end def call_like?(node); end - def correct_call_node(node, corrector); end + def correct_call_node(node, corrector, block_name); end def empty_arguments?(node); end - def insert_argument(node, corrector); end + def extract_block_name(def_node); end + def insert_argument(node, corrector, block_name); end def yielding_arguments?(block_args, yield_args); end end @@ -9671,6 +9756,30 @@ RuboCop::Cop::Style::Not::MSG = T.let(T.unsafe(nil), String) RuboCop::Cop::Style::Not::OPPOSITE_METHODS = T.let(T.unsafe(nil), Hash) RuboCop::Cop::Style::Not::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) +class RuboCop::Cop::Style::NumberedParameters < ::RuboCop::Cop::Base + include ::RuboCop::Cop::ConfigurableEnforcedStyle + extend ::RuboCop::Cop::TargetRubyVersion + + def on_numblock(node); end +end + +RuboCop::Cop::Style::NumberedParameters::MSG_DISALLOW = T.let(T.unsafe(nil), String) +RuboCop::Cop::Style::NumberedParameters::MSG_MULTI_LINE = T.let(T.unsafe(nil), String) + +class RuboCop::Cop::Style::NumberedParametersLimit < ::RuboCop::Cop::Base + extend ::RuboCop::Cop::TargetRubyVersion + + def max=(value); end + def on_numblock(node); end + + private + + def max_count; end +end + +RuboCop::Cop::Style::NumberedParametersLimit::DEFAULT_MAX_VALUE = T.let(T.unsafe(nil), Integer) +RuboCop::Cop::Style::NumberedParametersLimit::MSG = T.let(T.unsafe(nil), String) + class RuboCop::Cop::Style::NumericLiteralPrefix < ::RuboCop::Cop::Base include ::RuboCop::Cop::IntegerNode extend ::RuboCop::Cop::AutoCorrector @@ -9716,7 +9825,7 @@ class RuboCop::Cop::Style::NumericLiterals < ::RuboCop::Cop::Base def format_int_part(int_part); end def format_number(node); end def min_digits; end - def register_offense(node); end + def register_offense(node, &_block); end def short_group_regex; end end @@ -9801,9 +9910,12 @@ class RuboCop::Cop::Style::OptionalBooleanParameter < ::RuboCop::Cop::Base def on_def(node); end def on_defs(node); end + + private + + def format_message(argument); end end -RuboCop::Cop::Style::OptionalBooleanParameter::BOOLEAN_TYPES = T.let(T.unsafe(nil), Array) RuboCop::Cop::Style::OptionalBooleanParameter::MSG = T.let(T.unsafe(nil), String) class RuboCop::Cop::Style::OrAssignment < ::RuboCop::Cop::Base @@ -10235,10 +10347,15 @@ end RuboCop::Cop::Style::RedundantFetchBlock::MSG = T.let(T.unsafe(nil), String) class RuboCop::Cop::Style::RedundantFileExtensionInRequire < ::RuboCop::Cop::Base + include ::RuboCop::Cop::RangeHelp extend ::RuboCop::Cop::AutoCorrector def on_send(node); end def require_call?(param0 = T.unsafe(nil)); end + + private + + def extension_range(name_node); end end RuboCop::Cop::Style::RedundantFileExtensionInRequire::MSG = T.let(T.unsafe(nil), String) @@ -10438,6 +10555,7 @@ class RuboCop::Cop::Style::RedundantSelf < ::RuboCop::Cop::Base def on_def(node); end def on_defs(node); end def on_if(node); end + def on_in_pattern(node); end def on_lvasgn(node); end def on_masgn(node); end def on_op_asgn(node); end @@ -10450,6 +10568,7 @@ class RuboCop::Cop::Style::RedundantSelf < ::RuboCop::Cop::Base def add_lhs_to_local_variables_scopes(rhs, lhs); end def add_masgn_lhs_variables(rhs, lhs); end + def add_match_var_scopes(in_pattern_node); end def add_scope(node, local_variables = T.unsafe(nil)); end def allow_self(node); end def allowed_send_node?(node); end @@ -10518,10 +10637,11 @@ class RuboCop::Cop::Style::RedundantSort < ::RuboCop::Cop::Base def accessor_start(node); end def arg_node(node); end def arg_value(node); end - def autocorrect(corrector, node, sort_node, sorter, accessor); end def base(accessor, arg); end + def find_redundant_sort(*nodes); end def message(node, sorter, accessor); end - def offense_range(sort_node, ancestor); end + def offense_range(sort_node, node); end + def register_offense(node, sort_node, sorter, accessor); end def suffix(sorter); end def suggestion(sorter, accessor, arg); end end @@ -10697,6 +10817,26 @@ end RuboCop::Cop::Style::Sample::MSG = T.let(T.unsafe(nil), String) RuboCop::Cop::Style::Sample::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) +class RuboCop::Cop::Style::SelectByRegexp < ::RuboCop::Cop::Base + include ::RuboCop::Cop::RangeHelp + extend ::RuboCop::Cop::AutoCorrector + + def calls_lvar?(param0 = T.unsafe(nil), param1); end + def on_send(node); end + def regexp_match?(param0 = T.unsafe(nil)); end + + private + + def extract_send_node(block_node); end + def find_regexp(node); end + def register_offense(node, block_node, regexp); end +end + +RuboCop::Cop::Style::SelectByRegexp::MSG = T.let(T.unsafe(nil), String) +RuboCop::Cop::Style::SelectByRegexp::REGEXP_METHODS = T.let(T.unsafe(nil), Set) +RuboCop::Cop::Style::SelectByRegexp::REPLACEMENTS = T.let(T.unsafe(nil), Hash) +RuboCop::Cop::Style::SelectByRegexp::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array) + class RuboCop::Cop::Style::SelfAssignment < ::RuboCop::Cop::Base extend ::RuboCop::Cop::AutoCorrector @@ -11531,6 +11671,7 @@ RuboCop::Cop::Style::YodaCondition::EQUALITY_OPERATORS = T.let(T.unsafe(nil), Ar RuboCop::Cop::Style::YodaCondition::MSG = T.let(T.unsafe(nil), String) RuboCop::Cop::Style::YodaCondition::NONCOMMUTATIVE_OPERATORS = T.let(T.unsafe(nil), Array) RuboCop::Cop::Style::YodaCondition::PROGRAM_NAMES = T.let(T.unsafe(nil), Array) +RuboCop::Cop::Style::YodaCondition::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Set) RuboCop::Cop::Style::YodaCondition::REVERSE_COMPARISON = T.let(T.unsafe(nil), Hash) class RuboCop::Cop::Style::ZeroLengthPredicate < ::RuboCop::Cop::Base @@ -11718,7 +11859,7 @@ module RuboCop::Cop::Util def double_quotes_required?(string); end def escape_string(string); end def first_part_of_call_chain(node); end - def indent(node); end + def indent(node, offset: T.unsafe(nil)); end def interpret_string_escapes(string); end def line_range(node); end def needs_escaping?(string); end @@ -11739,7 +11880,7 @@ module RuboCop::Cop::Util def double_quotes_required?(string); end def escape_string(string); end def first_part_of_call_chain(node); end - def indent(node); end + def indent(node, offset: T.unsafe(nil)); end def interpret_string_escapes(string); end def line_range(node); end def needs_escaping?(string); end @@ -12530,8 +12671,8 @@ end RuboCop::Formatter::PacmanFormatter::FALLBACK_TERMINAL_WIDTH = T.let(T.unsafe(nil), Integer) RuboCop::Formatter::PacmanFormatter::GHOST = T.let(T.unsafe(nil), String) -RuboCop::Formatter::PacmanFormatter::PACDOT = T.let(T.unsafe(nil), Rainbow::Presenter) -RuboCop::Formatter::PacmanFormatter::PACMAN = T.let(T.unsafe(nil), Rainbow::Presenter) +RuboCop::Formatter::PacmanFormatter::PACDOT = T.let(T.unsafe(nil), Rainbow::NullPresenter) +RuboCop::Formatter::PacmanFormatter::PACMAN = T.let(T.unsafe(nil), Rainbow::NullPresenter) class RuboCop::Formatter::ProgressFormatter < ::RuboCop::Formatter::ClangStyleFormatter include ::RuboCop::Formatter::TextUtil @@ -12725,23 +12866,23 @@ class RuboCop::Options private - def add_aliases(opts); end - def add_auto_gen_options(opts); end - def add_boolean_flags(opts); end + def add_additional_modes(opts); end + def add_autocorrection_options(opts); end def add_cache_options(opts); end - def add_configuration_options(opts); end + def add_check_options(opts); end + def add_config_generation_options(opts); end def add_cop_selection_csv_option(option, opts); end - def add_flags_with_optional_args(opts); end - def add_formatting_options(opts); end - def add_list_options(opts); end - def add_only_options(opts); end + def add_general_options(opts); end + def add_output_options(opts); end def add_severity_option(opts); end def args_from_env; end def args_from_file; end def define_options; end def long_opt_symbol(args); end def option(opts, *args); end + def rainbow; end def require_feature(file); end + def section(opts, heading, &_block); end end RuboCop::Options::DEFAULT_MAXIMUM_EXCLUSION_ITEMS = T.let(T.unsafe(nil), Integer)
false
Other
Homebrew
brew
61a7ffb999963a2ef8d8f0b247956c8280cb831a.json
development_tools: add type signatures
Library/Homebrew/development_tools.rb
@@ -1,9 +1,14 @@ -# typed: false +# typed: true # frozen_string_literal: true +require "version" + # @private class DevelopmentTools class << self + extend T::Sig + + sig { params(tool: String).returns(T.nilable(Pathname)) } def locate(tool) # Don't call tools (cc, make, strip, etc.) directly! # Give the name of the binary you look for as a string to this method @@ -18,28 +23,40 @@ def locate(tool) end end + sig { returns(T::Boolean) } def installed? - locate("clang") || locate("gcc") + locate("clang").present? || locate("gcc").present? end + sig { returns(String) } def installation_instructions "Install Clang or run `brew install gcc`." end - alias custom_installation_instructions installation_instructions + sig { returns(String) } + def custom_installation_instructions + installation_instructions + end + + # TODO: This method appears to be unused. Can it be deleted? + sig { returns(T.nilable(String)) } def default_cc cc = DevelopmentTools.locate "cc" + return if cc.nil? + begin cc.realpath.basename.to_s rescue nil end end + sig { returns(Symbol) } def default_compiler :clang end + sig { returns(Version) } def clang_version @clang_version ||= if (path = locate("clang")) && (build_version = `#{path} --version`[/(?:clang|LLVM) version (\d+\.\d(?:\.\d)?)/, 1]) @@ -49,6 +66,7 @@ def clang_version end end + sig { returns(Version) } def clang_build_version @clang_build_version ||= if (path = locate("clang")) && (build_version = `#{path} --version`[ @@ -59,6 +77,7 @@ def clang_build_version end end + sig { returns(Version) } def llvm_clang_build_version @llvm_clang_build_version ||= begin path = Formulary.factory("llvm").opt_prefix/"bin/clang" @@ -71,6 +90,7 @@ def llvm_clang_build_version end end + sig { params(cc: String).returns(Version) } def non_apple_gcc_version(cc) (@non_apple_gcc_version ||= {}).fetch(cc) do path = HOMEBREW_PREFIX/"opt/#{CompilerSelector.preferred_gcc}/bin"/cc @@ -85,19 +105,23 @@ def non_apple_gcc_version(cc) end end + sig { void } def clear_version_cache @clang_version = @clang_build_version = nil @non_apple_gcc_version = {} end + sig { returns(T::Boolean) } def curl_handles_most_https_certificates? true end + sig { returns(T::Boolean) } def subversion_handles_most_https_certificates? true end + sig { returns(T::Hash[String, T.untyped]) } def build_system_info { "os" => ENV["HOMEBREW_SYSTEM"],
true
Other
Homebrew
brew
61a7ffb999963a2ef8d8f0b247956c8280cb831a.json
development_tools: add type signatures
Library/Homebrew/extend/os/linux/development_tools.rb
@@ -5,6 +5,7 @@ class DevelopmentTools class << self extend T::Sig + sig { params(tool: String).returns(T.nilable(Pathname)) } def locate(tool) (@locate ||= {}).fetch(tool) do |key| @locate[key] = if (path = HOMEBREW_PREFIX/"bin/#{tool}").executable? @@ -20,6 +21,7 @@ def default_compiler :gcc end + sig { returns(T::Hash[String, T.untyped]) } def build_system_info generic_build_system_info.merge({ "glibc_version" => OS::Linux::Glibc.version,
true
Other
Homebrew
brew
61a7ffb999963a2ef8d8f0b247956c8280cb831a.json
development_tools: add type signatures
Library/Homebrew/extend/os/mac/development_tools.rb
@@ -12,6 +12,7 @@ class << self undef installed?, default_compiler, curl_handles_most_https_certificates?, subversion_handles_most_https_certificates? + sig { params(tool: String).returns(T.nilable(Pathname)) } def locate(tool) (@locate ||= {}).fetch(tool) do |key| @locate[key] = if (located_tool = generic_locate(tool)) @@ -26,6 +27,7 @@ def locate(tool) # Checks if the user has any developer tools installed, either via Xcode # or the CLT. Convenient for guarding against formula builds when building # is impossible. + sig { returns(T::Boolean) } def installed? MacOS::Xcode.installed? || MacOS::CLT.installed? end @@ -62,6 +64,7 @@ def custom_installation_instructions EOS end + sig { returns(T::Hash[String, T.untyped]) } def build_system_info build_info = { "xcode" => MacOS::Xcode.version.to_s.presence,
true
Other
Homebrew
brew
61a7ffb999963a2ef8d8f0b247956c8280cb831a.json
development_tools: add type signatures
Library/Homebrew/extend/os/mac/extend/ENV/shared.rb
@@ -18,8 +18,8 @@ def setup_build_environment(formula: nil, cc: nil, build_bottle: false, bottle_a def no_weak_imports_support? return false unless compiler == :clang - return false if MacOS::Xcode.version && MacOS::Xcode.version < "8.0" - return false if MacOS::CLT.version && MacOS::CLT.version < "8.0" + return false if !MacOS::Xcode.version.null? && MacOS::Xcode.version < "8.0" + return false if !MacOS::CLT.version.null? && MacOS::CLT.version < "8.0" true end
true
Other
Homebrew
brew
61a7ffb999963a2ef8d8f0b247956c8280cb831a.json
development_tools: add type signatures
Library/Homebrew/os/mac.rb
@@ -178,13 +178,15 @@ def macports_or_fink paths.uniq end + sig { params(ids: String).returns(T.nilable(Pathname)) } def app_with_bundle_id(*ids) path = mdfind(*ids) .reject { |p| p.include?("/Backups.backupdb/") } .first Pathname.new(path) if path.present? end + sig { params(ids: String).returns(T::Array[String]) } def mdfind(*ids) (@mdfind ||= {}).fetch(ids) do @mdfind[ids] = Utils.popen_read("/usr/bin/mdfind", mdfind_query(*ids)).split("\n") @@ -197,6 +199,7 @@ def pkgutil_info(id) end end + sig { params(ids: String).returns(String) } def mdfind_query(*ids) ids.map! { |id| "kMDItemCFBundleIdentifier == #{id}" }.join(" || ") end
true
Other
Homebrew
brew
61a7ffb999963a2ef8d8f0b247956c8280cb831a.json
development_tools: add type signatures
Library/Homebrew/os/mac/sdk.rb
@@ -9,11 +9,21 @@ module Mac # # @api private class SDK + extend T::Sig + # 11.x SDKs are explicitly excluded - we want the MacOSX11.sdk symlink instead. VERSIONED_SDK_REGEX = /MacOSX(10\.\d+|\d+)\.sdk$/.freeze - attr_reader :version, :path, :source + sig { returns(OS::Mac::Version) } + attr_reader :version + sig { returns(Pathname) } + attr_reader :path + + sig { returns(Symbol) } + attr_reader :source + + sig { params(version: OS::Mac::Version, path: T.any(String, Pathname), source: Symbol).void } def initialize(version, path, source) @version = version @path = Pathname.new(path) @@ -25,15 +35,22 @@ def initialize(version, path, source) # # @api private class BaseSDKLocator + extend T::Sig + extend T::Helpers + + abstract! + class NoSDKError < StandardError; end + sig { params(v: OS::Mac::Version).returns(SDK) } def sdk_for(v) sdk = all_sdks.find { |s| s.version == v } raise NoSDKError if sdk.nil? sdk end + sig { returns(T::Array[SDK]) } def all_sdks return @all_sdks if @all_sdks @@ -62,6 +79,7 @@ def all_sdks @all_sdks end + sig { params(v: T.nilable(OS::Mac::Version)).returns(T.nilable(SDK)) } def sdk_if_applicable(v = nil) sdk = begin if v.blank? @@ -81,20 +99,20 @@ def sdk_if_applicable(v = nil) sdk end - def source - nil - end + sig { abstract.returns(Symbol) } + def source; end private - def sdk_prefix - "" - end + sig { abstract.returns(String) } + def sdk_prefix; end + sig { returns(T.nilable(SDK)) } def latest_sdk all_sdks.max_by(&:version) end + sig { params(sdk_path: Pathname).returns(T.nilable(OS::Mac::Version)) } def read_sdk_version(sdk_path) sdk_settings = sdk_path/"SDKSettings.json" sdk_settings_string = sdk_settings.read if sdk_settings.exist? @@ -129,13 +147,14 @@ def read_sdk_version(sdk_path) class XcodeSDKLocator < BaseSDKLocator extend T::Sig - sig { returns(Symbol) } + sig { override.returns(Symbol) } def source :xcode end private + sig { override.returns(String) } def sdk_prefix @sdk_prefix ||= begin # Xcode.prefix is pretty smart, so let's look inside to find the sdk @@ -155,7 +174,7 @@ def sdk_prefix class CLTSDKLocator < BaseSDKLocator extend T::Sig - sig { returns(Symbol) } + sig { override.returns(Symbol) } def source :clt end @@ -169,6 +188,7 @@ def source # separate package, so we can't rely on their being present. # This will only look up SDKs on Xcode 10 or newer, and still # return nil SDKs for Xcode 9 and older. + sig { override.returns(String) } def sdk_prefix @sdk_prefix ||= if CLT.provides_sdk? "#{CLT::PKG_PATH}/SDKs"
true