language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
Library/Homebrew/utils/analytics.sh
@@ -10,7 +10,7 @@ migrate-legacy-uuid-file() { if [[ -f "${legacy_uuid_file}" ]] then - analytics_uuid="$(<"${legacy_uuid_file}")" + analytics_uuid="$(cat "${legacy_uuid_file}")" if [[ -n "${analytics_uuid}" ]] then git config --file="${HOMEBREW_REPOSITORY}/.git/config" --replace-all home...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
Library/Homebrew/utils/lock.sh
@@ -8,7 +8,7 @@ lock() { local lock_dir="${HOMEBREW_PREFIX}/var/homebrew/locks" local lock_file="${lock_dir}/${name}" [[ -d "${lock_dir}" ]] || mkdir -p "${lock_dir}" - if ! [[ -w "${lock_dir}" ]] + if [[ ! -w "${lock_dir}" ]] then odie <<EOS Can't create ${name} lock in ${lock_dir}!
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
Library/Homebrew/utils/ruby.sh
@@ -8,14 +8,14 @@ which_all() { fi local executable entries entry retcode=1 - IFS=':' read -r -a entries <<< "${PATH}" # `readarray -d ':' -t` seems not applicable on WSL Bash + IFS=':' read -r -a entries <<<"${PATH}" # `readarray -d ':' -t` seems not applicable on WSL Bash for entry in "${entries[@]}" ...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
bin/brew
@@ -114,7 +114,7 @@ then # Skip if variable value is empty. [[ -z "${!VAR}" ]] && continue - FILTERED_ENV+=( "${VAR}=${!VAR}" ) + FILTERED_ENV+=("${VAR}=${!VAR}") done exec /usr/bin/env -i "${FILTERED_ENV[@]}" /bin/bash "${HOMEBREW_LIBRARY}/Homebrew/brew.sh" "$@"
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
docs/Common-Issues.md
@@ -17,14 +17,14 @@ After running `brew update`, you receive a Git error warning about untracked fil This is caused by an old bug in in the `update` code that has long since been fixed. However, the nature of the bug requires that you do the following: ```sh -cd $(brew --repository) +cd "$(brew --repository)" git ...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
docs/FAQ.md
@@ -55,7 +55,7 @@ Homebrew doesn't support arbitrary mixing and matching of formula versions, so e Which is usually: `~/Library/Caches/Homebrew` ## My Mac `.app`s don’t find Homebrew utilities! -GUI apps on macOS don’t have Homebrew's prefix in their `PATH` by default. If you're on Mountain Lion or later, you can f...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
docs/Formula-Cookbook.md
@@ -361,7 +361,7 @@ Everything is built on Git, so contribution is easy: ```sh brew update # required in more ways than you think (initialises the brew git repository if you don't already have it) -cd $(brew --repository homebrew/core) +cd "$(brew --repository homebrew/core)" # Create a new git branch for your for...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
docs/Gems,-Eggs-and-Perl-Modules.md
@@ -118,7 +118,7 @@ Then put the appropriate incantation in your shell’s startup, e.g. for [`local::lib`](https://metacpan.org/pod/local::lib) docs. ```sh -eval $(perl -I$HOME/perl5/lib/perl5 -Mlocal::lib) +eval "$(perl -I$HOME/perl5/lib/perl5 -Mlocal::lib)" ``` Now (after you restart your shell) `cpan` or `per...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
docs/Homebrew-and-Python.md
@@ -77,7 +77,7 @@ For brewed Python, modules installed with `pip3` or `python3 setup.py install` w The system Python may not know which compiler flags to set in order to build bindings for software installed in Homebrew so you may need to run: ```sh -CFLAGS=-I$(brew --prefix)/include LDFLAGS=-L$(brew --prefix)/lib ...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
docs/Homebrew-linuxbrew-core-Maintainer-Guide.md
@@ -44,9 +44,9 @@ variable, or let `hub fork` add a remote for you. ```bash brew install hub -cd $(brew --repository homebrew/core) +cd "$(brew --repository homebrew/core)" git remote add homebrew https://github.com/Homebrew/homebrew-core.git -hub fork --remote-name=$HOMEBREW_GITHUB_USER +hub fork --remote-name="$...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
docs/Homebrew-on-Linux.md
@@ -31,10 +31,10 @@ The prefix `/home/linuxbrew/.linuxbrew` was chosen so that users without admin a Follow the *Next steps* instructions to add Homebrew to your `PATH` and to your bash shell profile script, either `~/.profile` on Debian/Ubuntu or `~/.bash_profile` on CentOS/Fedora/Red Hat. ```sh -test -d ~/.linuxb...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
docs/How-To-Open-a-Homebrew-Pull-Request.md
@@ -15,7 +15,7 @@ Depending on the change you want to make, you need to send the pull request to t * This creates a personal remote repository that you can push to. This is needed because only Homebrew maintainers have push access to the main repositories. 2. Change to the directory containing your Homebrew install...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
docs/How-to-Build-Software-Outside-Homebrew-with-Homebrew-keg-only-Dependencies.md
@@ -27,21 +27,21 @@ Useful, reliable alternatives exist should you wish to use `keg_only` tools outs You can set flags to give configure scripts or Makefiles a nudge in the right direction. An example of flag setting: ```sh -./configure --prefix=/Users/Dave/Downloads CFLAGS=-I$(brew --prefix)/opt/openssl/include LD...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
docs/Manpage.md
@@ -572,7 +572,7 @@ Print export statements. When run in a shell, this installation of Homebrew will The variables `HOMEBREW_PREFIX`, `HOMEBREW_CELLAR` and `HOMEBREW_REPOSITORY` are also exported to avoid querying them multiple times. The variable `HOMEBREW_SHELLENV_PREFIX` will be exported to avoid adding duplicat...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
docs/Shell-Completion.md
@@ -13,13 +13,16 @@ Shell completions for external Homebrew commands are not automatically installed To make Homebrew's completions available in `bash`, you must source the definitions as part of your shell's startup. Add the following to your `~/.bash_profile` (or, if it doesn't exist, `~/.profile`): ```sh -if typ...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
docs/Tips-N'-Tricks.md
@@ -28,14 +28,14 @@ In the case of Erlang, this requires renaming the file from `otp_src_R13B03` to `brew --cache -s erlang` will print the correct name of the cached download. This means instead of manually renaming a formula, you can -run `mv the_tarball $(brew --cache -s <formula>)`. +run `mv the_tarball "$(brew...
true
Other
Homebrew
brew
3f96d963f7a2e5ff0f084bcb16e7f95e5aa72cfd.json
style: fix inconsistent code style for shell scripts
manpages/brew.1
@@ -1,7 +1,7 @@ .\" generated with Ronn/v0.7.3 .\" http://github.com/rtomayko/ronn/tree/0.7.3 . -.TH "BREW" "1" "August 2021" "Homebrew" "brew" +.TH "BREW" "1" "September 2021" "Homebrew" "brew" . .SH "NAME" \fBbrew\fR \- The Missing Package Manager for macOS (or Linux) @@ -796,7 +796,7 @@ Search for \fItext\fR i...
true
Other
Homebrew
brew
414935fb391117f7449adc8b78fc6758c5a3e5b1.json
shims: enforce usage of Swift-bundled Clang on Linux Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Library/Homebrew/shims/linux/super/swift
@@ -0,0 +1 @@ +../../super/swift \ No newline at end of file
true
Other
Homebrew
brew
414935fb391117f7449adc8b78fc6758c5a3e5b1.json
shims: enforce usage of Swift-bundled Clang on Linux Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Library/Homebrew/shims/super/cc
@@ -79,6 +79,8 @@ class Cmd "#{ENV["HOMEBREW_PREFIX"]}/opt/llvm/bin/#{Regexp.last_match(1)}" when /\w\+\+(-\d+(\.\d)?)?$/ case ENV["HOMEBREW_CC"] + when "swift_clang" + "#{ENV["HOMEBREW_PREFIX"]}/opt/swift/libexec/bin/clang++" when /clang/ "clang++" when /llvm-gcc/ ...
true
Other
Homebrew
brew
414935fb391117f7449adc8b78fc6758c5a3e5b1.json
shims: enforce usage of Swift-bundled Clang on Linux Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Library/Homebrew/shims/super/swift
@@ -0,0 +1,15 @@ +#!/bin/bash + +# Ensure we use Swift's clang when performing Swift builds. + +export CC="clang" +export CXX="clang++" + +# swift_clang isn't a shim but is used to ensure the cc shim +# points to the compiler inside the swift keg +export HOMEBREW_CC="swift_clang" +export HOMEBREW_CXX="swift_clang++" + ...
true
Other
Homebrew
brew
fc056cec59fb752840fe2a7da224d05b70b09860.json
docs: update documentation for shell requirement
docs/Installation.md
@@ -16,7 +16,7 @@ it does it too. You have to confirm everything it will do before it starts. * Command Line Tools (CLT) for Xcode: `xcode-select --install`, [developer.apple.com/downloads](https://developer.apple.com/downloads) or [Xcode](https://itunes.apple.com/us/app/xcode/id497799835) <sup>[3](#3)</sup> -* ...
false
Other
Homebrew
brew
deef3539a87400b7aa15ae537b1c89f48baa5c64.json
Update RBI files for parallel.
Library/Homebrew/sorbet/rbi/gems/parallel@1.21.0.rbi
@@ -27,7 +27,7 @@ module Parallel def create_workers(job_factory, options, &block); end def extract_count_from_options(options); end def process_incoming_jobs(read, write, job_factory, options, &block); end - def replace_worker(job_factory, workers, i, options, blk); end + def replace_worker(job_fa...
false
Other
Homebrew
brew
4bd7b50a8263fcc845bf1f2b95940c2d87f37ee2.json
sorbet: Update RBI files. Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -3110,6 +3110,143 @@ class DevelopmentTools extend ::T::Private::Methods::SingletonMethodHooks end +class DidYouMean::ClassNameChecker + def class_name(); end + + def class_names(); end + + def corrections(); end + + def initialize(exception); end + + def scopes(); end +end + +module DidYouMean::Correctab...
false
Other
Homebrew
brew
3e15023269326bb9c34ca63e360f3178983f7376.json
test/os/mac: fix uses_from_macos_elements tests.
Library/Homebrew/test/os/mac/formula_spec.rb
@@ -33,8 +33,8 @@ expect(f.class.stable.deps.first.name).to eq("foo") expect(f.class.head.deps.first.name).to eq("foo") - expect(f.class.stable.uses_from_macos_elements).to be_empty - expect(f.class.head.uses_from_macos_elements).to be_empty + expect(f.class.stable.uses_from_macos_element...
true
Other
Homebrew
brew
3e15023269326bb9c34ca63e360f3178983f7376.json
test/os/mac: fix uses_from_macos_elements tests.
Library/Homebrew/test/os/mac/software_spec_spec.rb
@@ -23,7 +23,7 @@ spec.uses_from_macos("foo", since: :high_sierra) expect(spec.deps.first.name).to eq("foo") - expect(spec.uses_from_macos_elements).to be_empty + expect(spec.uses_from_macos_elements).to eq(["foo"]) end it "works with tags" do
true
Other
Homebrew
brew
e2552d19a65c0f192fe5554f9996f7e5efa5135b.json
sorbet: Update RBI files. Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -32477,6 +32477,11 @@ module Utils::Svn extend ::T::Private::Methods::SingletonMethodHooks end +class Utils::TopologicalHash + extend ::T::Private::Methods::MethodHooks + extend ::T::Private::Methods::SingletonMethodHooks +end + module Utils extend ::T::Private::Methods::MethodHooks extend ::T::Privat...
false
Other
Homebrew
brew
b5bc6368b7f79a8c70dae389d48df3964b8c3843.json
cmd/vendor-install.sh: update artifact URL
Library/Homebrew/cmd/vendor-install.sh
@@ -37,7 +37,7 @@ then ruby_URLs=() if [[ -n "${HOMEBREW_ARTIFACT_DOMAIN}" ]] then - ruby_URLs+=("${HOMEBREW_ARTIFACT_DOMAIN}/bottles-portable-ruby/${ruby_FILENAME}") + ruby_URLs+=("${HOMEBREW_ARTIFACT_DOMAIN}/v2/homebrew/portable-ruby/portable-ruby/blobs/sha256:${ruby_SHA}") fi if [[ -n "${HOMEBRE...
false
Other
Homebrew
brew
5c6d2b154fdc3bcc82bd8b7b1015c500386785d2.json
utils/ruby.sh: remove dependency for `which` command
Library/Homebrew/utils/ruby.sh
@@ -1,9 +1,31 @@ export HOMEBREW_REQUIRED_RUBY_VERSION=2.6.3 +# Search given executable in all PATH entries (remove dependency for `which` command) +which_all() { + if [[ $# -ne 1 ]] + then + return 1 + fi + + local executable entries entry retcode=1 + IFS=':' read -r -a entries <<< "${PATH}" # `readarray -...
false
Other
Homebrew
brew
14c2afe1d84af5657a3af0f85e194aa619f94661.json
Fix empty gem RBIs for non-vendored dependencies
Library/Homebrew/sorbet/tapioca/require.rb
@@ -1,4 +1,25 @@ # typed: strict # frozen_string_literal: true -# Add your extra requires here +# This should not be made a constant or Tapioca will think it is part of a gem. +dependency_require_map = { + "activesupport" => "active_support", + "ruby-macho" => "macho", +}.freeze + +Bundler.definition.locked_ge...
false
Other
Homebrew
brew
188ac3413b6abf689294b281898e89be956f0d5c.json
sorbet: Update RBI files. Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
Library/Homebrew/sorbet/rbi/parlour.rbi
@@ -160,5 +160,8 @@ module Cask sig { returns(T::Boolean) } def quarantine?; end + + sig { returns(T::Boolean) } + def quiet?; end end end
false
Other
Homebrew
brew
80bf12d63ffedf7828bc4ef935b39f6199b9aa25.json
Update RBI files for sorbet.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -18912,10 +18912,6 @@ class REXML::Validation::ValidationException def initialize(msg); end end -class REXML::XPath - def self.match(element, path=T.unsafe(nil), namespaces=T.unsafe(nil), variables=T.unsafe(nil), options=T.unsafe(nil)); end -end - class REXML::XPathParser DEBUG = ::T.let(nil, ::T.untyped)...
true
Other
Homebrew
brew
80bf12d63ffedf7828bc4ef935b39f6199b9aa25.json
Update RBI files for sorbet.
Library/Homebrew/sorbet/rbi/parlour.rbi
@@ -160,5 +160,8 @@ module Cask sig { returns(T::Boolean) } def quarantine?; end + + sig { returns(T::Boolean) } + def quiet?; end end end
true
Other
Homebrew
brew
15e8852128bfe0da12c02d105fabccbed3758b8e.json
upgrade: add install_formula helper method
Library/Homebrew/install.rb
@@ -212,7 +212,10 @@ def install_formula?( elsif f.linked? message = "#{f.name} #{f.linked_version} is already installed" if f.outdated? && !head - return true unless Homebrew::EnvConfig.no_install_upgrade? + unless Homebrew::EnvConfig.no_install_upgrade? + puts "#{...
true
Other
Homebrew
brew
15e8852128bfe0da12c02d105fabccbed3758b8e.json
upgrade: add install_formula helper method
Library/Homebrew/upgrade.rb
@@ -164,42 +164,50 @@ def create_formula_installer( def upgrade_formula(formula_installer, dry_run: false, verbose: false) formula = formula_installer.formula - kegs = outdated_kegs(formula) - linked_kegs = kegs.select(&:linked?) - if dry_run print_dry_run_dependencies(formula, f...
true
Other
Homebrew
brew
b0668f4e312c4890972768915233a56fc395e691.json
Use `-s` flag in `uname` call Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Library/Homebrew/os.rb
@@ -40,7 +40,7 @@ def self.kernel_version # @api public sig { returns(String) } def self.uname - @uname ||= Utils.safe_popen_read("uname").chomp + @uname ||= Utils.safe_popen_read("uname", "-s").chomp end ::OS_VERSION = ENV["HOMEBREW_OS_VERSION"]
false
Other
Homebrew
brew
e8c26e2da9a4888a801045d1681c13d434837ef7.json
use keyword argument
Library/Homebrew/cmd/list.rb
@@ -104,7 +104,7 @@ def list puts full_cask_names if full_cask_names.present? end elsif args.cask? - list_casks(args.named.to_casks, args) + list_casks(args.named.to_casks, args: args) elsif args.pinned? || args.versions? filtered_list args: args elsif args.no_named? @@ -...
false
Other
Homebrew
brew
3751d9d69141f16d97627c2e7503035f8c35a0b7.json
Update Sorbet RBIs
Library/Homebrew/sorbet/rbi/gems/ecma-re-validator@0.3.0.rbi
@@ -0,0 +1,8 @@ +# DO NOT EDIT MANUALLY +# This is an autogenerated file for types exported from the `ecma-re-validator` gem. +# Please instead update this file by running `bin/tapioca sync`. + +# typed: true + +# THIS IS AN EMPTY RBI FILE. +# see https://github.com/Shopify/tapioca/blob/master/README.md#manual-gem-requ...
true
Other
Homebrew
brew
3751d9d69141f16d97627c2e7503035f8c35a0b7.json
Update Sorbet RBIs
Library/Homebrew/sorbet/rbi/gems/hana@1.3.7.rbi
@@ -0,0 +1,8 @@ +# DO NOT EDIT MANUALLY +# This is an autogenerated file for types exported from the `hana` gem. +# Please instead update this file by running `bin/tapioca sync`. + +# typed: true + +# THIS IS AN EMPTY RBI FILE. +# see https://github.com/Shopify/tapioca/blob/master/README.md#manual-gem-requires
true
Other
Homebrew
brew
3751d9d69141f16d97627c2e7503035f8c35a0b7.json
Update Sorbet RBIs
Library/Homebrew/sorbet/rbi/gems/json_schemer@0.2.18.rbi
@@ -0,0 +1,8 @@ +# DO NOT EDIT MANUALLY +# This is an autogenerated file for types exported from the `json_schemer` gem. +# Please instead update this file by running `bin/tapioca sync`. + +# typed: true + +# THIS IS AN EMPTY RBI FILE. +# see https://github.com/Shopify/tapioca/blob/master/README.md#manual-gem-requires
true
Other
Homebrew
brew
3751d9d69141f16d97627c2e7503035f8c35a0b7.json
Update Sorbet RBIs
Library/Homebrew/sorbet/rbi/gems/uri_template@0.7.0.rbi
@@ -0,0 +1,8 @@ +# DO NOT EDIT MANUALLY +# This is an autogenerated file for types exported from the `uri_template` gem. +# Please instead update this file by running `bin/tapioca sync`. + +# typed: true + +# THIS IS AN EMPTY RBI FILE. +# see https://github.com/Shopify/tapioca/blob/master/README.md#manual-gem-requires
true
Other
Homebrew
brew
3751d9d69141f16d97627c2e7503035f8c35a0b7.json
Update Sorbet RBIs
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -7465,6 +7465,16 @@ module ERB::Util def self.unwrapped_html_escape(s); end end +module EcmaReValidator + INVALID_REGEXP = ::T.let(nil, ::T.untyped) + INVALID_TOKENS = ::T.let(nil, ::T.untyped) + UNICODE_CHARACTERS = ::T.let(nil, ::T.untyped) +end + +module EcmaReValidator + def self.valid?(input); end +en...
true
Other
Homebrew
brew
3751d9d69141f16d97627c2e7503035f8c35a0b7.json
Update Sorbet RBIs
Library/Homebrew/sorbet/rbi/todo.rbi
@@ -4,7 +4,6 @@ # typed: strong module ::StackProf; end module DependencyCollector::Compat; end -module GitHubPackages::JSONSchemer; end module OS::Mac::Version::NULL; end module T::InterfaceWrapper::Helpers; end module T::Private::Abstract::Hooks; end
true
Other
Homebrew
brew
e7d3dc853273c6b1c0279178aa27b5fa2c2246e6.json
workflows/triage: limit concurrent runs
.github/workflows/triage.yml
@@ -12,6 +12,8 @@ on: schedule: - cron: "0 */3 * * *" # every 3 hours +concurrency: triage-${{ github.ref }} + jobs: review: runs-on: ubuntu-latest
false
Other
Homebrew
brew
698f4a8f6999d3faee87ae6321274b58d7ae13e8.json
Add process_type to service DSL This enables mpd to be run with the "Interactive" value, which avoids performance issues such as skipping when playing music. See this PR, where this was done previously: https://github.com/Homebrew/homebrew-core/pull/19410 The ProcessType plist key was lost in the conversion to the se...
Library/Homebrew/service.rb
@@ -13,6 +13,11 @@ class Service RUN_TYPE_INTERVAL = "interval" RUN_TYPE_CRON = "cron" + PROCESS_TYPE_BACKGROUND = "background" + PROCESS_TYPE_STANDARD = "standard" + PROCESS_TYPE_INTERACTIVE = "interactive" + PROCESS_TYPE_ADAPTIVE = "adaptive" + # sig { params(formula: Formula).void } ...
true
Other
Homebrew
brew
698f4a8f6999d3faee87ae6321274b58d7ae13e8.json
Add process_type to service DSL This enables mpd to be run with the "Interactive" value, which avoids performance issues such as skipping when playing music. See this PR, where this was done previously: https://github.com/Homebrew/homebrew-core/pull/19410 The ProcessType plist key was lost in the conversion to the se...
Library/Homebrew/test/service_spec.rb
@@ -76,6 +76,7 @@ root_dir var working_dir var keep_alive true + process_type "interactive" restart_delay 30 macos_legacy_timers true end @@ -101,6 +102,8 @@ \t<string>homebrew.mxcl.formula_name</string> \t<key>LegacyTimers</key> \t<t...
true
Other
Homebrew
brew
0c3e49092c2e807092d157f3723d712a807e37b1.json
upgrade: use topological sort to upgrade formulae
Library/Homebrew/cask.rb
@@ -20,6 +20,5 @@ require "cask/pkg" require "cask/quarantine" require "cask/staged" -require "cask/topological_hash" require "cask/url" require "cask/utils"
true
Other
Homebrew
brew
0c3e49092c2e807092d157f3723d712a807e37b1.json
upgrade: use topological sort to upgrade formulae
Library/Homebrew/cask/installer.rb
@@ -3,8 +3,8 @@ require "formula_installer" require "unpack_strategy" +require "utils/topological_hash" -require "cask/topological_hash" require "cask/config" require "cask/download" require "cask/staged" @@ -290,43 +290,14 @@ def arch_dependencies "but you are running #{@current_arch}." end ...
true
Other
Homebrew
brew
0c3e49092c2e807092d157f3723d712a807e37b1.json
upgrade: use topological sort to upgrade formulae
Library/Homebrew/cask/topological_hash.rb
@@ -1,21 +0,0 @@ -# typed: true -# frozen_string_literal: true - -require "tsort" - -module Cask - # Topologically sortable hash map. - class TopologicalHash < Hash - include TSort - - private - - def tsort_each_node(&block) - each_key(&block) - end - - def tsort_each_child(node, &block) - fe...
true
Other
Homebrew
brew
0c3e49092c2e807092d157f3723d712a807e37b1.json
upgrade: use topological sort to upgrade formulae
Library/Homebrew/test/utils/topological_hash_spec.rb
@@ -0,0 +1,99 @@ +# typed: false +# frozen_string_literal: true + +require "utils/topological_hash" + +describe Utils::TopologicalHash do + describe "#tsort" do + it "returns a topologically sorted array" do + hash = described_class.new + hash[1] = [2, 3] + hash[2] = [3] + hash[3] = [] + ha...
true
Other
Homebrew
brew
0c3e49092c2e807092d157f3723d712a807e37b1.json
upgrade: use topological sort to upgrade formulae
Library/Homebrew/upgrade.rb
@@ -6,6 +6,7 @@ require "development_tools" require "messages" require "cleanup" +require "utils/topological_hash" module Homebrew # Helper functions for upgrading formulae. @@ -42,6 +43,14 @@ def upgrade_formulae( end end + dependency_graph = Utils::TopologicalHash.graph_package_depende...
true
Other
Homebrew
brew
0c3e49092c2e807092d157f3723d712a807e37b1.json
upgrade: use topological sort to upgrade formulae
Library/Homebrew/utils/topological_hash.rb
@@ -0,0 +1,63 @@ +# typed: true +# frozen_string_literal: true + +require "tsort" + +module Utils + # Topologically sortable hash map. + class TopologicalHash < Hash + extend T::Sig + + include TSort + + sig { + params( + packages: T.any(Cask::Cask, Formula, T::Array[T.any(Cask::Cask, Formula)...
true
Other
Homebrew
brew
342fb409f88eb31cf99c4b7437c08e1e3002dee9.json
Update RBI files for rubocop-rails.
Library/Homebrew/sorbet/rbi/gems/rubocop-rails@2.12.0.rbi
@@ -383,10 +383,10 @@ class RuboCop::Cop::Rails::ContentTag < ::RuboCop::Cop::Base private def allowed_argument?(argument); end - def autocorrect(corrector, node); end + def allowed_name?(argument); end + def autocorrect(corrector, node, preferred_method); end def corrected_ancestor?(node); end def cor...
false
Other
Homebrew
brew
c90e63b2998312e4c9aa029599df2c0b184faaa6.json
os: add `uname` method This will allow us to replace code like os = if OS.mac? "Darwin" else "Linux" end with a call to `OS.uname`. Doing rg '= (if )?OS\.(mac|linux)\?' returns about 70 matches, so there are probably at least a handful of formulae that could be simplified by this.
Library/Homebrew/os.rb
@@ -35,6 +35,14 @@ def self.kernel_version @kernel_version ||= Version.new(Utils.safe_popen_read("uname", "-r").chomp) end + # Get the kernel name. + # + # @api public + sig { returns(String) } + def self.uname + @uname ||= Utils.safe_popen_read("uname").chomp + end + ::OS_VERSION = ENV["HOMEBREW_...
false
Other
Homebrew
brew
d742ea94f74d6b1a8770092a648fa4b161bdc8cd.json
os/mac/pkgconfig/12: update version info
Library/Homebrew/os/mac/pkgconfig/12/expat.pc
@@ -5,7 +5,7 @@ libdir=${exec_prefix}/lib includedir=${prefix}/include Name: expat -Version: 2.2.8 +Version: 2.4.1 Description: expat XML parser URL: http://www.libexpat.org Libs: -L${libdir} -lexpat
true
Other
Homebrew
brew
d742ea94f74d6b1a8770092a648fa4b161bdc8cd.json
os/mac/pkgconfig/12: update version info
Library/Homebrew/os/mac/pkgconfig/12/libcurl.pc
@@ -5,11 +5,11 @@ # | (__| |_| | _ <| |___ # \___|\___/|_| \_\_____| # -# Copyright (C) 2001 - 2018, Daniel Stenberg, <daniel@haxx.se>, et al. +# Copyright (C) 2001 - 2020, Daniel Stenberg, <daniel@haxx.se>, et al. # # This software is licensed as described i...
true
Other
Homebrew
brew
d742ea94f74d6b1a8770092a648fa4b161bdc8cd.json
os/mac/pkgconfig/12: update version info
Library/Homebrew/os/mac/pkgconfig/12/sqlite3.pc
@@ -6,7 +6,7 @@ includedir=${prefix}/include Name: SQLite Description: SQL database engine -Version: 3.32.3 +Version: 3.36.0 Libs: -L${libdir} -lsqlite3 Libs.private: Cflags:
true
Other
Homebrew
brew
a0093bd64730006200039a27913303d4479d2590.json
test/support/fixtures/bottles: add fixtures for Monterey
Library/Homebrew/test/support/fixtures/bottles/testball_bottle-0.1.arm64_monterey.bottle.tar.gz
@@ -0,0 +1 @@ +testball_bottle-0.1.yosemite.bottle.tar.gz \ No newline at end of file
true
Other
Homebrew
brew
a0093bd64730006200039a27913303d4479d2590.json
test/support/fixtures/bottles: add fixtures for Monterey
Library/Homebrew/test/support/fixtures/bottles/testball_bottle-0.1.monterey.bottle.tar.gz
@@ -0,0 +1 @@ +testball_bottle-0.1.yosemite.bottle.tar.gz \ No newline at end of file
true
Other
Homebrew
brew
c6aea445a38e333568c5d45bdd05ddb60b27b22d.json
formula_auditor: allow uses_from_macos for aliases. This will enable https://github.com/Homebrew/homebrew-core/pull/84910 which will enable https://github.com/Homebrew/brew/pull/12008.
Library/Homebrew/formula_auditor.rb
@@ -263,7 +263,9 @@ def audit_deps next unless @core_tap - if self.class.aliases.include?(dep.name) + # we want to allow uses_from_macos for aliases but not bare dependencies + if self.class.aliases.include?(dep.name) && + (spec.uses_from_macos_elements.blank? || sp...
false
Other
Homebrew
brew
ebc4cce4569acc946a5078e672021c05bcad6e4c.json
rubocops/lines: add some OS cop comments/exceptions. Exclude and comment the cases the autocorrect currently doesn't work. Follow-up from #11955.
Library/Homebrew/rubocops/lines.rb
@@ -368,6 +368,9 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node) block_node = offending_node.parent next if block_node.type != :block + # TODO: could fix corrector to handle this but punting for now. + next if block_node.single_li...
false
Other
Homebrew
brew
a6e4e195c197a70c9c47f75992ed1b82f6656d3a.json
rubocops/lines: recommend on_os/OS.os? based on context. Recommend the use of `on_macos` and `on_linux` unless we're in `def install`, `def post_install` or `test do` in which case recommend `OS.mac?` and `OS.linux?` instead.
Library/Homebrew/formula.rb
@@ -64,7 +64,7 @@ class Formula include Utils::Shebang include Utils::Shell include Context - include OnOS + include OnOS # TODO: 3.3.0: deprecate OnOS usage in instance methods. extend Enumerable extend Forwardable extend Cachable
true
Other
Homebrew
brew
a6e4e195c197a70c9c47f75992ed1b82f6656d3a.json
rubocops/lines: recommend on_os/OS.os? based on context. Recommend the use of `on_macos` and `on_linux` unless we're in `def install`, `def post_install` or `test do` in which case recommend `OS.mac?` and `OS.linux?` instead.
Library/Homebrew/formula_support.rb
@@ -69,7 +69,7 @@ class BottleDisableReason def initialize(type, reason) @type = type @reason = reason - # TODO: 3.3.0 should deprecate this behaviour as it was only needed for + # TODO: 3.3.0: deprecate this behaviour as it was only needed for # Homebrew/core (where we don't want unneeded or di...
true
Other
Homebrew
brew
a6e4e195c197a70c9c47f75992ed1b82f6656d3a.json
rubocops/lines: recommend on_os/OS.os? based on context. Recommend the use of `on_macos` and `on_linux` unless we're in `def install`, `def post_install` or `test do` in which case recommend `OS.mac?` and `OS.linux?` instead.
Library/Homebrew/rubocops/lines.rb
@@ -347,6 +347,82 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node) end end + # This cop makes sure that OS conditionals are consistent. + # + # @api private + class OSConditionals < FormulaCop + extend AutoCorrector + + def audit_formula(_node, ...
true
Other
Homebrew
brew
a6e4e195c197a70c9c47f75992ed1b82f6656d3a.json
rubocops/lines: recommend on_os/OS.os? based on context. Recommend the use of `on_macos` and `on_linux` unless we're in `def install`, `def post_install` or `test do` in which case recommend `OS.mac?` and `OS.linux?` instead.
Library/Homebrew/rubocops/shared/helper_functions.rb
@@ -113,8 +113,10 @@ def find_node_method_by_name(node, method_name) nil end - # Sets the given node as the offending node when required in custom cops. - def offending_node(node) + # Gets/sets the given node as the offending node when required in custom cops. + def offending_node(...
true
Other
Homebrew
brew
a6e4e195c197a70c9c47f75992ed1b82f6656d3a.json
rubocops/lines: recommend on_os/OS.os? based on context. Recommend the use of `on_macos` and `on_linux` unless we're in `def install`, `def post_install` or `test do` in which case recommend `OS.mac?` and `OS.linux?` instead.
Library/Homebrew/test/rubocops/text/on_os_conditionals_spec.rb
@@ -0,0 +1,86 @@ +# typed: false +# frozen_string_literal: true + +require "rubocops/lines" + +describe RuboCop::Cop::FormulaAudit::OSConditionals do + subject(:cop) { described_class.new } + + context "when auditing OS conditionals" do + it "reports an offense when `OS.linux?` is used on Formula class" do + ...
true
Other
Homebrew
brew
c80bcc3f3d7602c2e88aa6e7a2103e4048bf9196.json
Exclude bot commmits from new release notes
.github/release.yml
@@ -0,0 +1,5 @@ +changelog: + exclude: + authors: + - dependabot + - BrewTestBot
false
Other
Homebrew
brew
2b6e58063694e2a676d647dfa247d61229623d62.json
ENV/super: add `shims_path` helper method. This allows us to stop repeatedly hardcoding this on macOS/Linux in formulae.
Library/Homebrew/extend/ENV/super.rb
@@ -29,6 +29,13 @@ def self.extended(base) base.run_time_deps = [] end + # The location of Homebrew's shims on this OS. + # @public + sig { returns(Pathname) } + def self.shims_path + HOMEBREW_SHIMS_PATH/"super" + end + # @private sig { returns(T.nilable(Pathname)) } def self.bin; end
true
Other
Homebrew
brew
2b6e58063694e2a676d647dfa247d61229623d62.json
ENV/super: add `shims_path` helper method. This allows us to stop repeatedly hardcoding this on macOS/Linux in formulae.
Library/Homebrew/extend/os/linux/extend/ENV/super.rb
@@ -4,9 +4,15 @@ module Superenv extend T::Sig + # The location of Homebrew's shims on Linux. + # @public + def self.shims_path + HOMEBREW_SHIMS_PATH/"linux/super" + end + # @private def self.bin - (HOMEBREW_SHIMS_PATH/"linux/super").realpath + shims_path.realpath end # @private
true
Other
Homebrew
brew
2b6e58063694e2a676d647dfa247d61229623d62.json
ENV/super: add `shims_path` helper method. This allows us to stop repeatedly hardcoding this on macOS/Linux in formulae.
Library/Homebrew/extend/os/mac/extend/ENV/super.rb
@@ -5,13 +5,19 @@ module Superenv extend T::Sig class << self + # The location of Homebrew's shims on macOS. + # @public + def shims_path + HOMEBREW_SHIMS_PATH/"mac/super" + end + undef bin # @private def bin return unless DevelopmentTools.installed? - (HOMEBREW_S...
true
Other
Homebrew
brew
669d7fd79dee4952ac78a65d4dc84e67d57cf717.json
sorbet: Update RBI files. Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -31529,6 +31529,11 @@ class Utils::Bottles::Tag extend ::T::Private::Methods::SingletonMethodHooks end +module Utils::Curl + extend ::T::Private::Methods::MethodHooks + extend ::T::Private::Methods::SingletonMethodHooks +end + module Utils::Inreplace extend ::T::Private::Methods::MethodHooks extend ::...
false
Other
Homebrew
brew
1f0f08c30d418356b0378f5460647e3425653204.json
Remove redundant begin
Library/Homebrew/sandbox.rb
@@ -115,20 +115,18 @@ def exec(*args) end write_to_pty = proc do - begin - # Update the window size whenever the parent terminal's window size changes. - old_winch = trap(:WINCH, &winch) - winch.call(nil) + # Update the window size whenever the pare...
false
Other
Homebrew
brew
f88966a8a53198106f01475b7c09ef08ef00e0e9.json
Use curl options where appropriate
Library/Homebrew/api.rb
@@ -27,7 +27,7 @@ def fetch(endpoint, json: true) return cache[endpoint] if cache.present? && cache.key?(endpoint) api_url = "#{API_DOMAIN}/#{endpoint}" - output = Utils::Curl.curl_output("--fail", "--max-time", "5", api_url) + output = Utils::Curl.curl_output("--fail", api_url, max_time: 5) ...
true
Other
Homebrew
brew
f88966a8a53198106f01475b7c09ef08ef00e0e9.json
Use curl options where appropriate
Library/Homebrew/download_strategy.rb
@@ -558,7 +558,7 @@ def curl_output(*args, **options) end def curl(*args, **options) - args << "--connect-timeout" << "15" unless mirrors.empty? + options[:connect_timeout] = 15 unless mirrors.empty? super(*_curl_args, *args, **_curl_opts, **command_output_options, **options) end end
true
Other
Homebrew
brew
f88966a8a53198106f01475b7c09ef08ef00e0e9.json
Use curl options where appropriate
Library/Homebrew/livecheck/strategy.rb
@@ -39,8 +39,6 @@ module Strategy DEFAULT_CURL_ARGS = [ # Follow redirections to handle mirrors, relocations, etc. "--location", - "--connect-timeout", CURL_CONNECT_TIMEOUT, - "--max-time", CURL_MAX_TIME ].freeze # `curl` arguments used in `Strategy#page_headers` m...
true
Other
Homebrew
brew
f88966a8a53198106f01475b7c09ef08ef00e0e9.json
Use curl options where appropriate
Library/Homebrew/utils/curl.rb
@@ -214,8 +214,13 @@ def curl_check_http_content(url, url_type, specs: {}, user_agents: [:default], if url != secure_url user_agents.each do |user_agent| secure_details = begin - curl_http_content_headers_and_checksum(secure_url, specs: specs, hash_needed: true, - ...
true
Other
Homebrew
brew
dce6b77ad05ce23850fecdafb007cd261108a30a.json
Modify syntax for readability / consistency leverage map block and guard clause for readability thx @MikeMcQuaid
Library/Homebrew/extend/os/mac/caveats.rb
@@ -37,9 +37,14 @@ def plist_caveats if f.plist_manual || f.service? command = if f.service? - f.service.command - .map { |arg| (arg =~ /\s/) ? "'#{arg}'" : arg } # wrap multi-word arguments in quotes - .join(" ") + f.service + .command + .map do |arg| + ...
false
Other
Homebrew
brew
c88f4c064556b867ec1a3460ab9f8820453cef18.json
Use raw block to return tty to proper state
Library/Homebrew/sandbox.rb
@@ -101,32 +101,40 @@ def exec(*args) command = [SANDBOX_EXEC, "-f", seatbelt.path, *args] # Start sandbox in a pseudoterminal to prevent access of the parent terminal. T.unsafe(PTY).spawn(*command) do |r, w, pid| - # Set the PTY's window size to match the parent terminal. - # Some fo...
false
Other
Homebrew
brew
bc4abc1fa9eaa7dec8fa51b6f5238079a74c6de8.json
Update RBI files for tapioca.
Library/Homebrew/sorbet/rbi/gems/tapioca@0.4.26.rbi
@@ -772,7 +772,7 @@ Tapioca::Compilers::Sorbet::SORBET = T.let(T.unsafe(nil), Pathname) module Tapioca::Compilers::SymbolTable; end class Tapioca::Compilers::SymbolTable::SymbolGenerator - sig { params(gem: Tapioca::Gemfile::Gem, indent: Integer).void } + sig { params(gem: Tapioca::Gemfile::GemSpec, indent: Integ...
true
Other
Homebrew
brew
bc4abc1fa9eaa7dec8fa51b6f5238079a74c6de8.json
Update RBI files for tapioca.
Library/Homebrew/sorbet/rbi/todo.rbi
@@ -10,4 +10,3 @@ module T::InterfaceWrapper::Helpers; end module T::Private::Abstract::Hooks; end module T::Private::Methods::MethodHooks; end module T::Private::Methods::SingletonMethodHooks; end -module Tapioca::Gemfile::Gem::Specification; end
true
Other
Homebrew
brew
87f5d989233476f364f9d15316ff68c6d3b6f922.json
Add test for multi-word service argument warpping
Library/Homebrew/test/caveats_spec.rb
@@ -124,7 +124,21 @@ def plist caveats = described_class.new(f).caveats expect(f.service?).to eq(true) - expect(caveats).to include("'#{f.bin}/php' 'test'") + expect(caveats).to include("#{f.bin}/php test") + expect(caveats).to include("background service") + end + + i...
false
Other
Homebrew
brew
a0cc4a467c6506d7e0233cb3a0030c891300e565.json
Update RBI files for sorbet.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -9815,10 +9815,10 @@ module Homebrew::EnvConfig def self.force_brewed_git?(); end - def self.force_homebrew_on_linux?(); end - def self.force_homebrew_core_repo_on_linux?(); end + def self.force_homebrew_on_linux?(); end + def self.force_vendor_ruby?(); end def self.ftp_proxy(); end
false
Other
Homebrew
brew
1532c081f264a8c762b57bbfff0dd1eefc2acec5.json
Add space character in map (pacify brew style)
Library/Homebrew/extend/os/mac/caveats.rb
@@ -37,7 +37,7 @@ def plist_caveats if f.plist_manual || f.service? command = if f.service? - f.service.command.map{ |arg| "'#{arg}'" }.join(" ") + f.service.command.map { |arg| "'#{arg}'" }.join(" ") else f.plist_manual end
false
Other
Homebrew
brew
7d0a36752b6d9b0fee0b2ae650d9042335f99cd7.json
curl: echo any cookies received on a redirect
Library/Homebrew/utils/curl.rb
@@ -33,6 +33,9 @@ def curl_args(*extra_args, **options) # do not load .curlrc unless requested (must be the first argument) args << "--disable" unless Homebrew::EnvConfig.curlrc? + # echo any cookies received on a redirect + args << "--cookie-jar" << "/dev/null" + args << "--globoff" ...
false
Other
Homebrew
brew
999a3c66f98273329f40f85048da9f6428b4862d.json
docs: use brew --repository shorthand in Cask Cookbook
docs/Cask-Cookbook.md
@@ -297,7 +297,7 @@ There are a few different ways the `appcast` can be determined: * An appcast can be any URL hosted by the app’s developer that changes every time a new release is out or that contains the version number of the current release (e.g. a download HTML page). Webpages that only change on new version r...
true
Other
Homebrew
brew
999a3c66f98273329f40f85048da9f6428b4862d.json
docs: use brew --repository shorthand in Cask Cookbook
docs/Formula-Cookbook.md
@@ -361,7 +361,7 @@ Everything is built on Git, so contribution is easy: ```sh brew update # required in more ways than you think (initialises the brew git repository if you don't already have it) -cd $(brew --repo homebrew/core) +cd $(brew --repository homebrew/core) # Create a new git branch for your formula so ...
true
Other
Homebrew
brew
999a3c66f98273329f40f85048da9f6428b4862d.json
docs: use brew --repository shorthand in Cask Cookbook
docs/Homebrew-linuxbrew-core-Maintainer-Guide.md
@@ -44,7 +44,7 @@ variable, or let `hub fork` add a remote for you. ```bash brew install hub -cd $(brew --repo homebrew/core) +cd $(brew --repository homebrew/core) git remote add homebrew https://github.com/Homebrew/homebrew-core.git hub fork --remote-name=$HOMEBREW_GITHUB_USER ```
true
Other
Homebrew
brew
3e1c8ea8778d1a33f15212e33a701c969e5dfe34.json
Apply suggestions from code review
Library/Homebrew/upgrade.rb
@@ -44,7 +44,7 @@ def upgrade_formulae( formula_installers = formulae_to_install.map do |formula| Migrator.migrate_if_needed(formula, force: force) begin - fi = create_formula_installer( + fi = create_and_fetch_formula_installer( formula, flags: ...
false
Other
Homebrew
brew
4fc876fb2356a796e541e20b264ab7c71e3ea42e.json
Update RBI files for tapioca.
Library/Homebrew/sorbet/rbi/gems/tapioca@0.4.25.rbi
@@ -1082,6 +1082,9 @@ class Tapioca::Gemfile def lockfile; end + sig { returns([T::Array[Gem::Specification], T::Array[String]]) } + def materialize_deps; end + sig { returns(Bundler::Runtime) } def runtime; end end
true
Other
Homebrew
brew
4fc876fb2356a796e541e20b264ab7c71e3ea42e.json
Update RBI files for tapioca.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -9849,6 +9849,8 @@ module Homebrew::EnvConfig def self.no_bootsnap?(); end + def self.no_cleanup_formulae(); end + def self.no_color?(); end def self.no_compat?(); end
true
Other
Homebrew
brew
4fc876fb2356a796e541e20b264ab7c71e3ea42e.json
Update RBI files for tapioca.
Library/Homebrew/sorbet/rbi/todo.rbi
@@ -10,3 +10,4 @@ module T::InterfaceWrapper::Helpers; end module T::Private::Abstract::Hooks; end module T::Private::Methods::MethodHooks; end module T::Private::Methods::SingletonMethodHooks; end +module Tapioca::Gemfile::Gem::Specification; end
true
Other
Homebrew
brew
525137f37e5be05087dfe57b426ef0251eef252c.json
Update RBI files for sorbet.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -9849,6 +9849,8 @@ module Homebrew::EnvConfig def self.no_bootsnap?(); end + def self.no_cleanup_formulae(); end + def self.no_color?(); end def self.no_compat?(); end
false
Other
Homebrew
brew
05c1c5895ebe80f9737557fa320d2c30de68a001.json
Apply suggestions from code review
Library/Homebrew/brew.sh
@@ -51,8 +51,23 @@ HOMEBREW_CACHE="${HOMEBREW_CACHE:-${HOMEBREW_DEFAULT_CACHE}}" HOMEBREW_LOGS="${HOMEBREW_LOGS:-${HOMEBREW_DEFAULT_LOGS}}" HOMEBREW_TEMP="${HOMEBREW_TEMP:-${HOMEBREW_DEFAULT_TEMP}}" +# Don't need to handle a default case. +# HOMEBREW_LIBRARY set by bin/brew +# shellcheck disable=SC2249,SC2154 +case...
true
Other
Homebrew
brew
05c1c5895ebe80f9737557fa320d2c30de68a001.json
Apply suggestions from code review
Library/Homebrew/cmd/shellenv.sh
@@ -4,24 +4,14 @@ #: #: The variables `HOMEBREW_PREFIX`, `HOMEBREW_CELLAR` and `HOMEBREW_REPOSITORY` are also exported to avoid querying them multiple times. #: The variable `HOMEBREW_SHELLENV_PREFIX` will be exported to avoid adding duplicate entries to the environment variables. -#: -#: Consider adding evaluati...
true
Other
Homebrew
brew
05c1c5895ebe80f9737557fa320d2c30de68a001.json
Apply suggestions from code review
docs/Manpage.md
@@ -570,13 +570,7 @@ Print export statements. When run in a shell, this installation of Homebrew will The variables `HOMEBREW_PREFIX`, `HOMEBREW_CELLAR` and `HOMEBREW_REPOSITORY` are also exported to avoid querying them multiple times. The variable `HOMEBREW_SHELLENV_PREFIX` will be exported to avoid adding duplica...
true
Other
Homebrew
brew
05c1c5895ebe80f9737557fa320d2c30de68a001.json
Apply suggestions from code review
manpages/brew.1
@@ -792,13 +792,7 @@ Search for \fItext\fR in the given database\. Print export statements\. When run in a shell, this installation of Homebrew will be added to your \fBPATH\fR, \fBMANPATH\fR, and \fBINFOPATH\fR\. . .P -The variables \fBHOMEBREW_PREFIX\fR, \fBHOMEBREW_CELLAR\fR and \fBHOMEBREW_REPOSITORY\fR are also...
true
Other
Homebrew
brew
92dd0229cb003013f99054f4b00e73fb485aa21f.json
sorbet: Update RBI files. Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi
@@ -9669,6 +9669,10 @@ module Homebrew::API::Cask extend ::T::Private::Methods::SingletonMethodHooks end +module Homebrew::API::CaskSource + extend ::T::Private::Methods::SingletonMethodHooks +end + module Homebrew::API::Formula extend ::T::Private::Methods::SingletonMethodHooks end
false
Other
Homebrew
brew
27fb6506a0ab3c4edc131818453dd9022f99e4e7.json
Apply suggestions from code review Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Library/Homebrew/cmd/shellenv.sh
@@ -19,7 +19,7 @@ homebrew-shellenv() { if [[ "${HOMEBREW_SHELLENV_PREFIX}" == "${HOMEBREW_PREFIX}" ]]; then [[ "$(PATH="${HOMEBREW_PATH}" command -v brew)" == "${HOMEBREW_PREFIX}/bin/brew" ]] && return opoo "You have set HOMEBREW_SHELLENV_PREFIX=\"${HOMEBREW_SHELLENV_PREFIX}\"," \ - "but the brew'...
false
Other
Homebrew
brew
c56c7d91ba56c6dd0cb37369a23e7e08b4cace76.json
Update RBI files for rubocop.
Library/Homebrew/sorbet/rbi/gems/rubocop@1.20.0.rbi
@@ -875,6 +875,29 @@ end RuboCop::Cop::AmbiguousCopName::MSG = T.let(T.unsafe(nil), String) +class RuboCop::Cop::AnnotationComment + extend ::Forwardable + + def initialize(comment, keywords); end + + def annotation?; end + def bounds; end + def colon; end + def comment; end + def correct?(colon:); end + d...
false
Other
Homebrew
brew
326321c1fdcba7717ec27e3db8cec9c0dfe15069.json
cli/parser: allow commands that look like options
Library/Homebrew/cli/parser.rb
@@ -264,6 +264,7 @@ def parse_remaining(argv, ignore_invalid_options: false) remaining = [] argv, non_options = split_non_options(argv) + allow_commands = Array(@named_args_type).include?(:command) while i < argv.count begin @@ -279,7 +280,7 @@ def parse_remaining(argv, ...
true
Other
Homebrew
brew
326321c1fdcba7717ec27e3db8cec9c0dfe15069.json
cli/parser: allow commands that look like options
Library/Homebrew/test/cli/parser_spec.rb
@@ -559,5 +559,19 @@ Homebrew::CLI::MaxNamedArgumentsError, /This command does not take more than 1 formula or cask argument/ ) end + + it "accepts commands with :command" do + parser = described_class.new do + named_args :command + end + expect { parser.parse(["--prefix", ...
true