language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 49d5291600a0b6d70ff9913e10ff9f2f23e2eb7b.json | Update Glimmer VM
Updates the VM to the latest version, which includes a number of major
changes:
- Refactors the resolver to not cache values, as this is unnecessary
- Refactors the resolver to return helper/modifier definitions directly
- Refactors the resolver to return ResolvedComponentDefinitions
- Updates vario... | packages/ember/index.js | @@ -103,22 +103,18 @@ import {
Checkbox,
Component,
setComponentManager,
- capabilities,
escapeExpression,
getTemplates,
Helper,
helper,
- helperCapabilities,
htmlSafe,
- invokeHelper,
isHTMLSafe,
LinkComponent,
setTemplates,
template,
TextField,
TextArea,
isSerialization... | true |
Other | emberjs | ember.js | 49d5291600a0b6d70ff9913e10ff9f2f23e2eb7b.json | Update Glimmer VM
Updates the VM to the latest version, which includes a number of major
changes:
- Refactors the resolver to not cache values, as this is unnecessary
- Refactors the resolver to return helper/modifier definitions directly
- Refactors the resolver to return ResolvedComponentDefinitions
- Updates vario... | packages/ember/tests/reexports_test.js | @@ -220,7 +220,7 @@ let allExports = [
['platform.defineProperty', null, { value: true }],
['platform.hasPropertyAccessors', null, { value: true }],
['defineProperty', '@ember/-internals/metal'],
- ['destroy', '@glimmer/runtime', 'destroy'],
+ ['destroy', '@glimmer/destroyable', 'destroy'],
['libraries', ... | true |
Other | emberjs | ember.js | 49d5291600a0b6d70ff9913e10ff9f2f23e2eb7b.json | Update Glimmer VM
Updates the VM to the latest version, which includes a number of major
changes:
- Refactors the resolver to not cache values, as this is unnecessary
- Refactors the resolver to return helper/modifier definitions directly
- Refactors the resolver to return ResolvedComponentDefinitions
- Updates vario... | yarn.lock | @@ -1657,154 +1657,187 @@
minimatch "^3.0.4"
strip-json-comments "^3.1.1"
-"@glimmer/compiler@0.67.0":
- version "0.67.0"
- resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.67.0.tgz#fed033c725b73be7fa4f5200fe15616758bc6ca4"
- integrity sha512-CCw31F1XYGm73iy2lrsowV9yr+aXAGauLaNWrO5N+... | true |
Other | emberjs | ember.js | 1ae3f13e5be1dc949045e7061b924fc0fa3ec47a.json | Add v3.24.0-beta.2 to CHANGELOG
(cherry picked from commit 46d27a0194009d39eb22b4f62e7033b8498bdef0) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.24.0-beta.2 (November 24, 2020)
+
+- [#19282](https://github.com/emberjs/ember.js/pull/19282) [BUGFIX] Issue deprecations (instead of assertions) for tracked mutation in constructor during rendering
+
### v3.24.0-beta.1 (November 16, 2020)
- [#19224](https://github.com/e... | false |
Other | emberjs | ember.js | f1f7342774b7e4ba2ccc4266f8e4bfcc2120af88.json | Add v3.23.1 to CHANGELOG.md.
(cherry picked from commit 2a89d9a1a6692f4c58545810cd355e2f866b3284) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.23.1 (November 23, 2020)
+
+- [#19282](https://github.com/emberjs/ember.js/pull/19282) [BUGFIX] Issue deprecations (instead of assertions) for tracked mutation in constructor during rendering
+
### v3.24.0-beta.1 (November 16, 2020)
- [#19224](https://github.com/emberjs/... | false |
Other | emberjs | ember.js | 1393ab777d0a2511228b4e9a1eeee066288483db.json | Fix docs coverage | packages/@ember/-internals/views/lib/system/event_dispatcher.js | @@ -252,7 +252,7 @@ export default EmberObject.extend({
@param event the name of the event in the browser
*/
setupHandlerForBrowserEvent(event) {
- this._setupHandler(this._sanitizedRootElement, event, this.finalEventNameMapping[event]);
+ this.setupHandler(this._sanitizedRootElement, event, this.final... | true |
Other | emberjs | ember.js | 1393ab777d0a2511228b4e9a1eeee066288483db.json | Fix docs coverage | tests/docs/expected.js | @@ -528,6 +528,8 @@ module.exports = {
'setupController',
'setupForTesting',
'setupHandler',
+ 'setupHandlerForBrowserEvent',
+ 'setupHandlerForEmberEvent',
'setupRegistry',
'shiftObject',
'shouldRender', | true |
Other | emberjs | ember.js | 5f0621c9381c3e3c67aca4ae3bc430f8d9ab2492.json | Fix EventDispatcher test | packages/@ember/-internals/glimmer/tests/integration/event-dispatcher-test.js | @@ -1,7 +1,7 @@
import { RenderingTestCase, moduleFor, runTask } from 'internal-test-helpers';
import { Component } from '../utils/helpers';
-import { getCurrentRunLoop, run } from '@ember/runloop';
+import { getCurrentRunLoop } from '@ember/runloop';
import {
subscribe as instrumentationSubscribe,
reset as ... | true |
Other | emberjs | ember.js | 5f0621c9381c3e3c67aca4ae3bc430f8d9ab2492.json | Fix EventDispatcher test | packages/internal-test-helpers/lib/test-cases/rendering.js | @@ -31,7 +31,10 @@ export default class RenderingTestCase extends AbstractTestCase {
this.element = document.querySelector('#qunit-fixture');
this.component = null;
- if (!bootOptions || bootOptions.isInteractive !== false) {
+ if (
+ !bootOptions ||
+ (bootOptions.isInteractive !== false &&... | true |
Other | emberjs | ember.js | b2f89ef997458ddbfee55ea6bc2465fc96c61608.json | Fix event handling of built-in components | packages/@ember/-internals/glimmer/lib/components/link-to.ts | @@ -13,6 +13,7 @@ import { inject as injectService } from '@ember/service';
import { DEBUG } from '@glimmer/env';
import EmberComponent, { HAS_BLOCK } from '../component';
import layout from '../templates/link-to';
+import { getOwner } from '@ember/-internals/owner';
/**
The `LinkTo` component renders a link t... | true |
Other | emberjs | ember.js | b2f89ef997458ddbfee55ea6bc2465fc96c61608.json | Fix event handling of built-in components | packages/@ember/-internals/glimmer/lib/modifiers/action.ts | @@ -215,7 +215,7 @@ export default class ActionModifierManager
get setupEventHandler(): (eventName: string) => void {
if (this._setupEventHandler === undefined) {
let dispatcher = this.owner.lookup('event_dispatcher:main') as any; // @todo
- this._setupEventHandler = (eventName) => dispatcher['setup... | true |
Other | emberjs | ember.js | b2f89ef997458ddbfee55ea6bc2465fc96c61608.json | Fix event handling of built-in components | packages/@ember/-internals/views/lib/mixins/text_support.js | @@ -136,13 +136,6 @@ export default Mixin.create(TargetActionSupport, {
disabled: false,
maxlength: null,
- init() {
- this._super(...arguments);
- this.on('paste', this, this._elementValueDidChange);
- this.on('cut', this, this._elementValueDidChange);
- this.on('input', this, this._elementValueDi... | true |
Other | emberjs | ember.js | b2f89ef997458ddbfee55ea6bc2465fc96c61608.json | Fix event handling of built-in components | packages/@ember/-internals/views/lib/system/event_dispatcher.js | @@ -250,10 +250,10 @@ export default EmberObject.extend({
@private
@method setupHandler
- @param {Element} rootElement
@param {String} event the name of the event in the browser
@param {String} eventName the name of the method to call on the view
- */
+ @param {Element} rootElement
+ */
... | true |
Other | emberjs | ember.js | 793fdddaaec8fe24ee9dafcf2ebda7a56d75b479.json | Add v3.24.0-beta.1 to CHANGELOG
(cherry picked from commit a39707f0a35a288426fa9dcaaf5d86d06e8f576e) | CHANGELOG.md | @@ -1,5 +1,22 @@
# Ember Changelog
+### v3.24.0-beta.1 (November 16, 2020)
+
+- [#19224](https://github.com/emberjs/ember.js/pull/19224) [FEATURE] Add `{{page-title}}` helper to route template blueprints to implement [RFC #0654](https://github.com/emberjs/rfcs/blob/master/text/0645-add-ember-page-title-addon.md).
+... | false |
Other | emberjs | ember.js | b30895b58ce33aa751333825718f1b5f9eb7709a.json | Add v3.23.0 to CHANGELOG
(cherry picked from commit 21447b22453c5f6366e81d455f0b1c27aef087ca) | CHANGELOG.md | @@ -1,32 +1,20 @@
# Ember Changelog
-### v3.23.0-beta.5 (November 9, 2020)
-
-- [#19249](https://github.com/emberjs/ember.js/pull/19249) [BUGFIX] Fix bugs in query params with intermediate transitions
-
-### v3.23.0-beta.4 (November 2, 2020)
-
-- [#19142](https://github.com/emberjs/ember.js/pull/19142) [BUGFIX] Fix ... | false |
Other | emberjs | ember.js | f2104f2d2a092cfdb95317f1f6745dcc498f1334.json | Add v3.22.1 to CHANGELOG.md.
(cherry picked from commit 566424788b313efb8f4a63e182b461a013db8e05) | CHANGELOG.md | @@ -28,6 +28,13 @@
- [#19136](https://github.com/emberjs/ember.js/pull/19136) [BUGFIX] Update router microlib to improve Transition related debugging
- [#19173](https://github.com/emberjs/ember.js/pull/19173) [BUGFIX] Enforce usage of `capabilities` generation.
+### v3.22.1 (November 10, 2020)
+
+- [#19193](https:/... | false |
Other | emberjs | ember.js | 4c9499d836122c4277cee48327e971fd3ace0c77.json | Add v3.20.6 to CHANGELOG.md. | CHANGELOG.md | @@ -58,6 +58,14 @@
- [#19087](https://github.com/emberjs/ember.js/pull/19087) [BUGFIX] Generated initializer tests no longer causes a deprecation warning
- [#17571](https://github.com/emberjs/ember.js/pull/17571) [BUGFIX] Avoid tampering `queryParam` argument in RouterService#isActive
+### v3.20.6 (November 11, 20... | false |
Other | emberjs | ember.js | 70fffeaa6320cc84455a1367fd1c84f89d30151b.json | Add v3.23.0-beta.5 to CHANGELOG
(cherry picked from commit f757e5722048843b6f37a48514aec9eddbf27f79) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.23.0-beta.5 (November 9, 2020)
+
+- [#19249](https://github.com/emberjs/ember.js/pull/19249) [BUGFIX] Fix bugs in query params with intermediate transitions
+
### v3.23.0-beta.4 (November 2, 2020)
- [#19142](https://github.com/emberjs/ember.js/pull/19142) [BUGFIX] Fix Ap... | false |
Other | emberjs | ember.js | ec49e0eee542791ca6916a71096988acab9c2ec0.json | Add v3.23.0-beta.4 to CHANGELOG
(cherry picked from commit 09ecf1cd3be31b0320e400d7172de0f13352d027) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v3.23.0-beta.4 (November 2, 2020)
+
+- [#19142](https://github.com/emberjs/ember.js/pull/19142) [BUGFIX] Fix App booting before DOM ready without jQuery
+- [#19198](https://github.com/emberjs/ember.js/pull/19198) / [#19232](https://github.com/emberjs/ember.js/pull/19232) [BUGF... | false |
Other | emberjs | ember.js | 05e278a573a07f40177f75a5ab3daa41ea738d44.json | Add v3.23.0-beta.3 to CHANGELOG
(cherry picked from commit a8aff10265bcfdbc1dafbe4d01669d8e5107328e) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v3.23.0-beta.3 (October 26, 2020)
+
+- [#19199](https://github.com/emberjs/ember.js/pull/19199) [BUGFIX] Fix Ember Inspector to not be in a broken state after render errors
+- [#19221](https://github.com/emberjs/ember.js/pull/19221) [BUGFIX] Ensure fn and (mut) work with falsy... | false |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/@ember/-internals/glimmer/lib/modifiers/on.ts | @@ -69,7 +69,7 @@ export class OnModifierState {
this.args = args;
}
- updateFromArgs() {
+ updateFromArgs(): void {
let { args } = this;
let { once, passive, capture }: AddEventListenerOptions = reifyNamed(args.named);
@@ -321,15 +321,15 @@ export default class OnModifierManager implements Modi... | true |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/@ember/-internals/glimmer/lib/template_registry.ts | @@ -7,11 +7,11 @@ interface TemplatesRegistry {
}
let TEMPLATES: TemplatesRegistry = {};
-export function setTemplates(templates: TemplatesRegistry) {
+export function setTemplates(templates: TemplatesRegistry): void {
TEMPLATES = templates;
}
-export function getTemplates() {
+export function getTemplates():... | true |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/@ember/-internals/glimmer/lib/utils/curly-component-state-bucket.ts | @@ -60,7 +60,7 @@ export default class ComponentStateBucket {
registerDestructor(this, () => this.component.destroy());
}
- willDestroy() {
+ willDestroy(): void {
let { component, environment } = this;
if (environment.isInteractive) {
@@ -80,7 +80,7 @@ export default class ComponentStateBucket ... | true |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/@ember/-internals/utils/lib/super.ts | @@ -54,16 +54,16 @@ function createObserverListenerMetaFor(fn: Function) {
return meta;
}
-export function observerListenerMetaFor(fn: Function) {
+export function observerListenerMetaFor(fn: Function): ObserverListenerMeta | undefined {
return OBSERVERS_LISTENERS_MAP.get(fn);
}
-export function setObserver... | true |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/@ember/-internals/views/lib/system/utils.ts | @@ -9,14 +9,14 @@ import { Dict, Option } from '@glimmer/interfaces';
@module ember
*/
-export function isSimpleClick(event: MouseEvent) {
+export function isSimpleClick(event: MouseEvent): boolean {
let modifier = event.shiftKey || event.metaKey || event.altKey || event.ctrlKey;
let secondaryClick = event.wh... | true |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/ember-template-compiler/lib/system/compile-options.ts | @@ -76,7 +76,7 @@ function wrapLegacyPluginIfNeeded(_plugin: PluginFunc | LegacyPluginClass): Plug
return plugin as PluginFunc;
}
-export function registerPlugin(type: string, _plugin: PluginFunc | LegacyPluginClass) {
+export function registerPlugin(type: string, _plugin: PluginFunc | LegacyPluginClass): void {
... | true |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/ember-template-compiler/tests/utils/transform-test-case.ts | @@ -5,7 +5,7 @@ import { AbstractTestCase } from 'internal-test-helpers';
import { compileOptions } from '../../index';
export default class extends AbstractTestCase {
- assertTransformed(before: string, after: string) {
+ assertTransformed(before: string, after: string): void {
this.assert.deepEqual(deloc(a... | true |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/internal-test-helpers/lib/ember-dev/assertion.ts | @@ -30,7 +30,7 @@ const BREAK = {};
In particular, this prevents `Ember.assert` from throw errors that would
disrupt the control flow.
*/
-export function setupAssertionHelpers(hooks: NestedHooks, env: DebugEnv) {
+export function setupAssertionHelpers(hooks: NestedHooks, env: DebugEnv): void {
let originalAs... | true |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/internal-test-helpers/lib/ember-dev/containers.ts | @@ -2,7 +2,7 @@ import { Container } from '@ember/-internals/container';
const { _leakTracking: containerLeakTracking } = Container;
-export function setupContainersCheck(hooks: NestedHooks) {
+export function setupContainersCheck(hooks: NestedHooks): void {
hooks.afterEach(function () {
if (containerLeakT... | true |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/internal-test-helpers/lib/ember-dev/debug.ts | @@ -12,21 +12,21 @@ class DebugAssert {
this.tracker = null;
}
- inject() {}
+ inject(): void {}
- restore() {
+ restore(): void {
this.reset();
}
- reset() {
+ reset(): void {
if (this.tracker) {
this.tracker.restoreMethod();
}
this.tracker = null;
}
- assert()... | true |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/internal-test-helpers/lib/ember-dev/deprecation.ts | @@ -21,7 +21,7 @@ declare global {
}
}
-export function setupDeprecationHelpers(hooks: NestedHooks, env: DebugEnv) {
+export function setupDeprecationHelpers(hooks: NestedHooks, env: DebugEnv): void {
let assertion = new DeprecationAssert(env);
hooks.beforeEach(function () {
@@ -40,7 +40,7 @@ class Deprec... | true |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/internal-test-helpers/lib/ember-dev/method-call-tracker.ts | @@ -24,7 +24,7 @@ export default class MethodCallTracker {
this._originalMethod = undefined;
}
- stubMethod() {
+ stubMethod(): void {
if (this._originalMethod) {
// Method is already stubbed
return;
@@ -42,32 +42,32 @@ export default class MethodCallTracker {
});
}
- restoreMe... | true |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/internal-test-helpers/lib/ember-dev/namespaces.ts | @@ -1,7 +1,7 @@
import { NAMESPACES, NAMESPACES_BY_ID } from '@ember/-internals/metal';
import { run } from '@ember/runloop';
-export function setupNamespacesCheck(hooks: NestedHooks) {
+export function setupNamespacesCheck(hooks: NestedHooks): void {
hooks.afterEach(function () {
let { assert } = QUnit.con... | true |
Other | emberjs | ember.js | a492ffedd7db6b641fd7e8e10fb9483d619995f7.json | fix linter warnings in 14 files | packages/internal-test-helpers/lib/ember-dev/observers.ts | @@ -1,7 +1,7 @@
import { ASYNC_OBSERVERS, SYNC_OBSERVERS } from '@ember/-internals/metal';
import { run } from '@ember/runloop';
-export function setupObserversCheck(hooks: NestedHooks) {
+export function setupObserversCheck(hooks: NestedHooks): void {
hooks.afterEach(function () {
let { assert } = QUnit.co... | true |
Other | emberjs | ember.js | 29b096bdceb31a6afabb9955e4f67a10b4e7e621.json | fix linitng warnings in run.ts file | packages/internal-test-helpers/lib/run.ts | @@ -9,29 +9,29 @@ import {
import { Promise } from 'rsvp';
-export function runAppend(view: any) {
+export function runAppend(view: any): void {
run(view, 'appendTo', document.getElementById('qunit-fixture'));
}
-export function runDestroy(toDestroy: any) {
+export function runDestroy(toDestroy: any): void {... | false |
Other | emberjs | ember.js | 3a866f974b6605db8a9a2b32355a7388de6ed536.json | Add v3.23.0-beta.2 to CHANGELOG
(cherry picked from commit 4bfc97e683e623174263471e71e9ddf9b8a739b8) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v3.23.0-beta.2 (October 19, 2020)
+
+- [#19193](https://github.com/emberjs/ember.js/pull/19193) [BUGFIX] Ensure user lifecycle hooks are untracked
+- [#19213](https://github.com/emberjs/ember.js/pull/19213) [BUGFIX] Update rendering engine to improve error ergonomics.
+
### v... | false |
Other | emberjs | ember.js | fb1f3e665cd9690784b8112434cc44e1ffd71b71.json | add constants to test-framework-detector | blueprints/test-framework-detector.js | @@ -11,37 +11,40 @@ module.exports = function (blueprint) {
blueprint.filesPath = function () {
let type;
+ const qunitRfcVersion = 'qunit-rfc-232';
+ const mochaRfcVersion = 'mocha-rfc-232';
+ const mochaVersion = 'mocha-0.12';
let dependencies = this.project.dependencies();
if ('ember-q... | false |
Other | emberjs | ember.js | 02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json | Fix linting issues | packages/@ember/-internals/glimmer/tests/integration/application/engine-test.js | @@ -551,12 +551,7 @@ moduleFor(
},
})
);
- this.register(
- 'template:application_error',
- compile(
- 'Error! {{@model.message}}'
- )
- );
+ this.register('template:application_error', compile('Error! {{@model.message}}'));
... | true |
Other | emberjs | ember.js | 02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json | Fix linting issues | packages/@ember/-internals/glimmer/tests/integration/application/rendering-test.js | @@ -194,9 +194,7 @@ moduleFor(
`);
}
- async ['@test interior mutations on the model with tracked properties'](
- assert
- ) {
+ async ['@test interior mutations on the model with tracked properties'](assert) {
class Model {
@tracked color;
@@ -317,9 +315,7 @@ moduleFor(
... | true |
Other | emberjs | ember.js | 02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json | Fix linting issues | packages/@ember/-internals/glimmer/tests/integration/components/link-to/routing-angle-test.js | @@ -916,9 +916,7 @@ moduleFor(
});
}
- async [`@test The <LinkTo /> component moves into the named route with context`](
- assert
- ) {
+ async [`@test The <LinkTo /> component moves into the named route with context`](assert) {
this.router.map(function () {
this.route('abo... | true |
Other | emberjs | ember.js | 02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json | Fix linting issues | packages/@ember/-internals/glimmer/tests/integration/components/link-to/routing-curly-test.js | @@ -916,9 +916,7 @@ moduleFor(
});
}
- async [`@test The {{link-to}} component moves into the named route with context`](
- assert
- ) {
+ async [`@test The {{link-to}} component moves into the named route with context`](assert) {
this.router.map(function () {
this.route('a... | true |
Other | emberjs | ember.js | 02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json | Fix linting issues | packages/@ember/-internals/glimmer/tests/integration/mount-test.js | @@ -322,12 +322,9 @@ moduleFor(
this._super(...arguments);
this.register(
'template:application',
- compile(
- '<h2>Param Engine: {{@model.foo}}</h2>',
- {
- moduleName: 'my-app/templates/application.hbs',
- ... | true |
Other | emberjs | ember.js | 02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json | Fix linting issues | packages/ember/tests/homepage_example_test.js | @@ -7,10 +7,7 @@ import { moduleFor, ApplicationTestCase } from 'internal-test-helpers';
moduleFor(
'The example renders correctly',
class extends ApplicationTestCase {
-
- async ['@test Render index template into application outlet'](
- assert
- ) {
+ async ['@test Render index template into appli... | true |
Other | emberjs | ember.js | 02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json | Fix linting issues | packages/ember/tests/routing/model_loading_test.js | @@ -397,9 +397,7 @@ moduleFor(
});
}
- [`@test The Specials Page getting its model by deserializing the params hash`](
- assert
- ) {
+ [`@test The Specials Page getting its model by deserializing the params hash`](assert) {
this.router.map(function () {
this.route('home', { ... | true |
Other | emberjs | ember.js | 02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json | Fix linting issues | packages/ember/tests/routing/router_service_test/transitionTo_test.js | @@ -158,9 +158,7 @@ moduleFor(
});
}
- async ['@test RouterService#transitionTo with dynamic segment'](
- assert
- ) {
+ async ['@test RouterService#transitionTo with dynamic segment'](assert) {
assert.expect(3);
let componentInstance;
@@ -196,9 +194,7 @@ moduleFor(
th... | true |
Other | emberjs | ember.js | 02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json | Fix linting issues | packages/ember/tests/routing/substates_test.js | @@ -676,9 +676,7 @@ moduleFor(
return promise;
}
- async ['@test Default error event moves into nested route'](
- assert
- ) {
+ async ['@test Default error event moves into nested route'](assert) {
await this.visit('/');
this.addTemplate('grandma.error', 'ERROR: {{@model.msg... | true |
Other | emberjs | ember.js | 02f092a2c1d4a77fbaf6a7e0e80a452634b7164c.json | Fix linting issues | packages/ember/tests/routing/template_rendering_test.js | @@ -204,9 +204,7 @@ moduleFor(
assert.equal(this.$('p').text(), 'YES I AM HOME', 'The homepage template was rendered');
}
- async [`@test Model passed via renderTemplate model is set as controller's model`](
- assert
- ) {
+ async [`@test Model passed via renderTemplate model is set as contr... | true |
Other | emberjs | ember.js | c4e1cd1e572ae4efb1296ef664c6462b71ab2089.json | Remove use of deprecated set-env github action API
See https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ | .github/workflows/cron.yml | @@ -30,7 +30,7 @@ jobs:
git add cron.txt
git commit -m "Cron $(date +%Y-%m-%d) for ${{matrix.branch}}"
export SHA=`git rev-parse HEAD`
- echo "::set-env name=SHA::$SHA"
+ echo "SHA=$SHA" >> $GITHUB_ENV
- name: Push branch to trigger Build workflow
# T... | false |
Other | emberjs | ember.js | 009b51abde39bd1cb76d8ebd8ad0d2fe524d27b7.json | use constructor instead of init | packages/@ember/-internals/routing/lib/services/router.ts | @@ -1,4 +1,4 @@
-import { getOwner } from '@ember/-internals/owner';
+import { getOwner, Owner } from '@ember/-internals/owner';
import { Evented } from '@ember/-internals/runtime';
import { symbol } from '@ember/-internals/utils';
import { assert } from '@ember/debug';
@@ -77,10 +77,10 @@ export default class Route... | false |
Other | emberjs | ember.js | 56a1da5b3b56ed84f6de2193a4fb0c01c0c7d4f2.json | CHORE: combine two test cases into one
Since `jQuery.isReady = false;` is set before each test case. | packages/@ember/application/tests/readiness_test.js | @@ -96,6 +96,7 @@ moduleFor(
run(() => {
application = Application.create({ router: false });
application.deferReadiness();
+ assert.equal(readyWasCalled, 0, "ready wasn't called yet");
});
assert.equal(readyWasCalled, 0, "ready wasn't called yet");
@@ -110,28 +111,6 @@ m... | false |
Other | emberjs | ember.js | c79a57ae3732d461aba234b2bd78d9fb4e90f862.json | Add v3.23.0-beta.1 to CHANGELOG
(cherry picked from commit dd71cbb7d8b895979e93cdcb3ac1cba3ddc3bab3) | CHANGELOG.md | @@ -1,5 +1,14 @@
# Ember Changelog
+### v3.23.0-beta.1 (October 5, 2020)
+
+- [#19160](https://github.com/emberjs/ember.js/pull/19160) / [#19182](https://github.com/emberjs/ember.js/pull/19182) [FEATURE] Implements the helper manager feature specified in the [Helper Managers RFC](https://github.com/emberjs/rfcs/blob... | false |
Other | emberjs | ember.js | e2a6babc5fcca17f58343997854c558b5b5f1dd5.json | Add v3.22.0 to CHANGELOG
(cherry picked from commit 388d5c381a48c409ace0ac38f4dd35109fe8f0a2) | CHANGELOG.md | @@ -1,31 +1,14 @@
# Ember Changelog
-### v3.22.0-beta.5 (September 30, 2020)
-
-- [#19172](https://github.com/emberjs/ember.js/pull/19172) [BUGFIX] Ensures that tracked properties initialize property
-
-### v3.22.0-beta.4 (September 30, 2020)
-
-- [#19138](https://github.com/emberjs/ember.js/pull/19138) [BUGFIX] Fix... | false |
Other | emberjs | ember.js | 5becf8846a00a1be254cb777c31258f5f8b86c54.json | Keep browserstack key in plaintext
It turns out this was intentional. The key has no privileged access to anything in our case, and it needs to be in plaintext if we want to run browserstack against PRs. | .github/workflows/ci.yml | @@ -88,7 +88,9 @@ jobs:
- name: test:browserstack
env:
BROWSERSTACK_USERNAME: emberjscoreteam1
- BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
+ # This is in plaintext on purpose. It has no privileged access to anything (this is a free
+ # account)... | false |
Other | emberjs | ember.js | 9a0d9a73ca82faea20ee18950c0b07cd4b71e859.json | Apply suggestions from code review
Co-authored-by: Jonathan Haines <jonno.haines@gmail.com> | .eslintrc.js | @@ -47,9 +47,9 @@ module.exports = {
rules: {
'@typescript-eslint/ban-ts-comment': 'warn',
- '@typescript-eslint/ban-types': 'warn',
- '@typescript-eslint/no-empty-function': 'warn',
- '@typescript-eslint/no-this-alias': 'warn',
+ '@typescript-eslint/ban-types': 'off',
+ ... | false |
Other | emberjs | ember.js | 7fd407c2f80feb14d24a22ec762521bad563a746.json | Add v3.22.0-beta.5 to CHANGELOG
(cherry picked from commit ae3c065f7c3416f6c497b2a5b5d9e6dd4d549662) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.22.0-beta.5 (September 30, 2020)
+
+- [#19172](https://github.com/emberjs/ember.js/pull/19172) [BUGFIX] Ensures that tracked properties initialize property
+
### v3.22.0-beta.4 (September 30, 2020)
- [#19138](https://github.com/emberjs/ember.js/pull/19138) [BUGFIX] Fix t... | false |
Other | emberjs | ember.js | 984c9adaa2e863fd2f8dd919600f364e84c6a9a4.json | Add v3.22.0-beta.4 to CHANGELOG
(cherry picked from commit 3010b89abd5fd15e65414b1654222498eb6607bf) | CHANGELOG.md | @@ -1,5 +1,13 @@
# Ember Changelog
+### v3.22.0-beta.4 (September 30, 2020)
+
+- [#19138](https://github.com/emberjs/ember.js/pull/19138) [BUGFIX] Fix tag cycles in query parameters
+- [#19094](https://github.com/emberjs/ember.js/pull/19094) [BUGFIX] Fix RouterService#isActive() to work with tracking
+- [#19163](ht... | false |
Other | emberjs | ember.js | 389486714360f972eb44638c6874791d442c4216.json | Add v3.21.3 to CHANGELOG.md. | CHANGELOG.md | @@ -15,6 +15,10 @@
- [#18984](https://github.com/emberjs/ember.js/pull/18984) / [#19067](https://github.com/emberjs/ember.js/pull/19067) [FEATURE] Add low-level Cache API per [Autotracking Memoization RFC](https://github.com/emberjs/rfcs/blob/master/text/0615-autotracking-memoization.md)
- [#19086](https://github.com... | false |
Other | emberjs | ember.js | f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json | Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that w... | packages/@ember/-internals/glimmer/lib/component-managers/custom.ts | @@ -19,6 +19,7 @@ import { EmberVMEnvironment } from '../environment';
import RuntimeResolver from '../resolver';
import { OwnedTemplate } from '../template';
import { argsProxyFor } from '../utils/args-proxy';
+import { buildCapabilities, InternalCapabilities } from '../utils/managers';
import AbstractComponentMan... | true |
Other | emberjs | ember.js | f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json | Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that w... | packages/@ember/-internals/glimmer/lib/helpers/custom.ts | @@ -3,10 +3,11 @@ import { DEBUG } from '@glimmer/env';
import { Arguments, Helper as GlimmerHelper } from '@glimmer/interfaces';
import { createComputeRef, UNDEFINED_REFERENCE } from '@glimmer/reference';
import { argsProxyFor } from '../utils/args-proxy';
+import { buildCapabilities, InternalCapabilities } from '.... | true |
Other | emberjs | ember.js | f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json | Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that w... | packages/@ember/-internals/glimmer/lib/modifiers/custom.ts | @@ -6,6 +6,7 @@ import { registerDestructor, reifyArgs } from '@glimmer/runtime';
import { createUpdatableTag, untrack, UpdatableTag } from '@glimmer/validator';
import { SimpleElement } from '@simple-dom/interface';
import { argsProxyFor } from '../utils/args-proxy';
+import { buildCapabilities, InternalCapabilitie... | true |
Other | emberjs | ember.js | f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json | Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that w... | packages/@ember/-internals/glimmer/lib/utils/managers.ts | @@ -1,8 +1,10 @@
import { Owner } from '@ember/-internals/owner';
-import { deprecate } from '@ember/debug';
+import { assert, deprecate } from '@ember/debug';
import { COMPONENT_MANAGER_STRING_LOOKUP } from '@ember/deprecated-features';
+import { DEBUG } from '@glimmer/env';
+import { _WeakSet } from '@glimmer/util'... | true |
Other | emberjs | ember.js | f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json | Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that w... | packages/@ember/-internals/glimmer/tests/integration/custom-component-manager-test.js | @@ -522,6 +522,62 @@ moduleFor(
this.assertHTML(`<p>hello max</p>`);
assert.verifySteps(['updateComponent', 'didUpdateComponent']);
}
+
+ '@test capabilities helper function must be used to generate capabilities'(assert) {
+ let ComponentClass = setComponentManager(
+ () => {
+ ... | true |
Other | emberjs | ember.js | f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json | Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that w... | packages/@ember/-internals/glimmer/tests/integration/custom-modifier-manager-test.js | @@ -21,7 +21,7 @@ class ModifierManagerTest extends RenderingTestCase {
expectAssertion(() => {
this.render('<h1 {{foo-bar}}>hello world</h1>');
- }, /Custom modifier managers must define their capabilities/);
+ }, /Custom modifier managers must have a `capabilities` property /);
}
'@test ca... | true |
Other | emberjs | ember.js | f776ac84baa67ae29fb2c13a94f2ca55a967b2b3.json | Enforce usage of `capabilities` generation.
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that w... | packages/@ember/-internals/glimmer/tests/integration/helpers/helper-manager-test.js | @@ -289,6 +289,34 @@ if (EMBER_GLIMMER_HELPER_MANAGER) {
this.assertText('hello');
}
+
+ '@test capabilities helper function must be used to generate capabilities'(assert) {
+ class OverrideTestHelperManager extends TestHelperManager {
+ capabilities = {
+ hasValue: tru... | true |
Other | emberjs | ember.js | 15217a3ab36a35c8b26361c3155a30efe4a0f8ae.json | Add v3.21.2 to CHANGELOG.md. | CHANGELOG.md | @@ -15,6 +15,11 @@
- [#18984](https://github.com/emberjs/ember.js/pull/18984) / [#19067](https://github.com/emberjs/ember.js/pull/19067) [FEATURE] Add low-level Cache API per [Autotracking Memoization RFC](https://github.com/emberjs/rfcs/blob/master/text/0615-autotracking-memoization.md)
- [#19086](https://github.com... | false |
Other | emberjs | ember.js | 26ef075c85688d26b1b12921bb4b5d4073507d83.json | Update TypeScript to v4.0.0 | .eslintrc.js | @@ -68,6 +68,7 @@ module.exports = {
'no-dupe-class-members': 'off',
'no-unused-vars': 'off',
'no-undef': 'off',
+ 'no-redeclare': 'off',
'import/export': 'off',
'import/named': 'off', | true |
Other | emberjs | ember.js | 26ef075c85688d26b1b12921bb4b5d4073507d83.json | Update TypeScript to v4.0.0 | package.json | @@ -87,7 +87,7 @@
"@simple-dom/document": "^1.4.0",
"@types/qunit": "^2.9.1",
"@types/rsvp": "^4.0.3",
- "@typescript-eslint/parser": "^2.33.0",
+ "@typescript-eslint/parser": "^4.3.0",
"auto-dist-tag": "^1.0.0",
"aws-sdk": "^2.686.0",
"babel-eslint": "^10.1.0",
@@ -101,7 +101,7 @@
... | true |
Other | emberjs | ember.js | 26ef075c85688d26b1b12921bb4b5d4073507d83.json | Update TypeScript to v4.0.0 | packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts | @@ -1530,20 +1530,20 @@ if (ENV._DEBUG_RENDER_TREE) {
nodeBounds(node: Node): CapturedBounds {
return {
- parentElement: (expect(
+ parentElement: ((expect(
node.parentNode,
'BUG: detached node'
- ) as SimpleNode) as SimpleElement,
- firstN... | true |
Other | emberjs | ember.js | 26ef075c85688d26b1b12921bb4b5d4073507d83.json | Update TypeScript to v4.0.0 | packages/@ember/-internals/views/lib/system/utils.ts | @@ -171,8 +171,8 @@ export function getViewRange(view: View): Range {
let bounds = getViewBounds(view);
let range = document.createRange();
- range.setStartBefore(bounds.firstNode as Node);
- range.setEndAfter(bounds.lastNode as Node);
+ range.setStartBefore((bounds.firstNode as unknown) as Node);
+ range.s... | true |
Other | emberjs | ember.js | 26ef075c85688d26b1b12921bb4b5d4073507d83.json | Update TypeScript to v4.0.0 | yarn.lock | @@ -1060,6 +1060,27 @@
"@glimmer/interfaces" "^0.61.2"
"@glimmer/util" "^0.61.2"
+"@nodelib/fs.scandir@2.1.3":
+ version "2.1.3"
+ resolved "https://registry.yarnpkg.com/@nodelib/fs.scandir/-/fs.scandir-2.1.3.tgz#3a582bdb53804c6ba6d146579c46e52130cf4a3b"
+ integrity sha512-eGmwYQn3gxo4r7jdQnkrrN6bY478C3P... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | lib/index.js | @@ -250,8 +250,8 @@ module.exports = {
if (
!isProduction &&
- (PRE_BUILT_TARGETS.every(target => targets.includes(target)) &&
- targets.length === PRE_BUILT_TARGETS.length)
+ PRE_BUILT_TARGETS.every(target => targets.includes(target)) &&
+ targets.length === PRE_BUILT_TARGETS.length... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | node-tests/blueprints/acceptance-test-test.js | @@ -75,7 +75,10 @@ describe('Blueprint: acceptance-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', ... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | node-tests/blueprints/component-test-test.js | @@ -166,7 +166,10 @@ describe('Blueprint: component-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit',... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | node-tests/blueprints/controller-test-test.js | @@ -126,7 +126,10 @@ describe('Blueprint: controller-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit'... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | node-tests/blueprints/helper-test-test.js | @@ -126,7 +126,10 @@ describe('Blueprint: helper-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', de... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | node-tests/blueprints/initializer-test-test.js | @@ -75,7 +75,10 @@ describe('Blueprint: initializer-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit',... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | node-tests/blueprints/instance-initializer-test-test.js | @@ -75,7 +75,10 @@ describe('Blueprint: instance-initializer-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'embe... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | node-tests/blueprints/mixin-test-test.js | @@ -69,7 +69,10 @@ describe('Blueprint: mixin-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', delet... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | node-tests/blueprints/route-test-test.js | @@ -88,7 +88,10 @@ describe('Blueprint: route-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', delet... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | node-tests/blueprints/service-test-test.js | @@ -92,7 +92,10 @@ describe('Blueprint: service-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', del... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | node-tests/blueprints/util-test-test.js | @@ -73,7 +73,10 @@ describe('Blueprint: util-test', function() {
describe('with ember-mocha@0.14.0', function() {
beforeEach(function() {
- modifyPackages([{ name: 'ember-qunit', delete: true }, { name: 'ember-mocha', dev: true }]);
+ modifyPackages([
+ { name: 'ember-qunit', delete... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/glimmer/tests/integration/application/debug-render-tree-test.ts | @@ -1502,7 +1502,7 @@ if (ENV._DEBUG_RENDER_TREE) {
): ExpectedRenderNode;
outlet(node: ExpectedRenderNode & { type: 'engine' | 'route-template' }): ExpectedRenderNode;
outlet(
- nodeOrName: string | ExpectedRenderNode & { type: 'engine' | 'route-template' },
+ nodeOrName: string | (E... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/glimmer/tests/integration/application/helper-registration-test.js | @@ -58,9 +58,15 @@ moduleFor(
`<div id='wrapper'>{{omg}}|{{yorp 'boo'}}|{{yorp 'ya'}}</div>`
);
- this.application.register('helper:omg', helper(() => 'OMG'));
+ this.application.register(
+ 'helper:omg',
+ helper(() => 'OMG')
+ );
- this.application.register('helpe... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/glimmer/tests/integration/components/append-test.js | @@ -140,7 +140,10 @@ class AbstractAppendTest extends RenderingTestCase {
assert.deepEqual(
hooks,
- [['x-parent', 'init'], ['x-parent', 'on(init)']],
+ [
+ ['x-parent', 'init'],
+ ['x-parent', 'on(init)'],
+ ],
'creation of x-parent'
);
| true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/glimmer/tests/integration/components/life-cycle-test.js | @@ -1077,7 +1077,11 @@ class LifeCycleHooksTest extends RenderingTestCase {
this.assertRegisteredViews('intial render');
let initialHooks = () => {
- let ret = [['an-item', 'init'], ['an-item', 'on(init)'], ['an-item', 'didReceiveAttrs']];
+ let ret = [
+ ['an-item', 'init'],
+ ['an-... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/glimmer/tests/integration/mount-test.js | @@ -121,7 +121,9 @@ moduleFor(
this.engineRegistrations['template:application'] = compile(
'hi {{person.name}} [{{component-with-backtracking-set person=person}}]',
- { moduleName: 'my-app/templates/application.hbs' }
+ {
+ moduleName: 'my-app/templates/application.hbs',
+ ... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/glimmer/tests/integration/syntax/each-test.js | @@ -890,7 +890,10 @@ class EachTest extends AbstractEachTest {
[`@test an outer {{#each}}'s scoped variable does not clobber an inner {{#each}}'s property if they share the same name - Issue #1315`]() {
let content = this.createList(['X', 'Y']);
- let options = this.createList([{ label: 'One', value: 1 }, ... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/meta/lib/meta.ts | @@ -744,7 +744,7 @@ function indexOfListener(
for (let i = listeners.length - 1; i >= 0; i--) {
let listener = listeners[i];
- if (listener.event === event && (listener.target === target && listener.method === method)) {
+ if (listener.event === event && listener.target === target && listener.method ===... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/metal/lib/decorator.ts | @@ -2,7 +2,7 @@ import { Meta, meta as metaFor, peekMeta } from '@ember/-internals/meta';
import { assert } from '@ember/debug';
import { _WeakSet as WeakSet } from '@glimmer/util';
-export type DecoratorPropertyDescriptor = PropertyDescriptor & { initializer?: any } | undefined;
+export type DecoratorPropertyDescr... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/metal/tests/accessors/get_test.js | @@ -110,7 +110,10 @@ moduleFor(
assert.equal(get({ foo: func }, 'foo.bar'), 'awesome');
assert.equal(get({ foo: func }, 'foo.bar.length'), 7);
assert.equal(get({}, 'foo.bar.length'), undefined);
- assert.equal(get(function() {}, 'foo.bar.length'), undefined);
+ assert.equal(
+ get(... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/metal/tests/computed_test.js | @@ -183,22 +183,38 @@ moduleFor(
['@test defining a computed property with a dependent key more than one level deep beyond @each is not supported']() {
expectNoWarning(() => {
obj = {};
- defineProperty(obj, 'someProp', computed('todos', () => {}));
+ defineProperty(
+ obj,
+... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/routing/lib/system/router.ts | @@ -1438,11 +1438,13 @@ function calculatePostTransitionState(
// If the routeInfo is not resolved, we serialize the context into params
if (!routeInfo.isResolved) {
- params[routeInfo.name] = routeInfo.serialize(routeInfo.context as
- | {
- [key: string]: unknown;
- }
- ... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/runtime/tests/array/sortBy-test.js | @@ -12,7 +12,10 @@ class SortByTests extends AbstractTestCase {
}
'@test supports multiple propertyNames'() {
- let obj = this.newObject([{ a: 1, b: 2 }, { a: 1, b: 1 }]);
+ let obj = this.newObject([
+ { a: 1, b: 2 },
+ { a: 1, b: 1 },
+ ]);
let sorted = obj.sortBy('a', 'b');
thi... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/runtime/tests/array/uniqBy-test.js | @@ -8,7 +8,10 @@ class UniqByTests extends AbstractTestCase {
{ id: 2, value: 'two' },
{ id: 1, value: 'one' },
]);
- this.assert.deepEqual(numbers.uniqBy('id'), [{ id: 1, value: 'one' }, { id: 2, value: 'two' }]);
+ this.assert.deepEqual(numbers.uniqBy('id'), [
+ { id: 1, value: 'one' },
... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/runtime/tests/legacy_1x/mixins/observable/observable_test.js | @@ -430,9 +430,7 @@ moduleFor(
assert.equal(
object.set(key, values[1]),
values[1],
- `Try #3: object.set(${key}, ${
- values[1]
- }) should not run function since it is setting same value as before`
+ `Try #3: object.set(${key}, ${values[1]}) should ... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/runtime/tests/mixins/promise_proxy_test.js | @@ -56,7 +56,10 @@ moduleFor(
let didFulfillCount = 0;
let didRejectCount = 0;
- proxy.then(() => didFulfillCount++, () => didRejectCount++);
+ proxy.then(
+ () => didFulfillCount++,
+ () => didRejectCount++
+ );
assert.equal(get(proxy, 'content'), undefined, 'expec... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/utils/tests/checkHasSuper_test.js | @@ -10,7 +10,10 @@ if (isChrome || isFirefox) {
'checkHasSuper',
class extends TestCase {
['@test does not super wrap needlessly [GH #12462]'](assert) {
- assert.notOk(checkHasSuper(function() {}), 'empty function does not have super');
+ assert.notOk(
+ checkHasSuper(function() ... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/-internals/utils/tests/get-debug-name-test.js | @@ -10,10 +10,16 @@ if (DEBUG) {
class Person {}
assert.equal(getDebugName({}), '(unknown object)');
- assert.equal(getDebugName(() => {}), '(unknown function)');
+ assert.equal(
+ getDebugName(() => {}),
+ '(unknown function)'
+ );
assert.equal(getDeb... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/object/tests/computed/reduce_computed_macros_test.js | @@ -639,7 +639,10 @@ moduleFor(
}
);
-[['uniq', uniq], ['union', union]].forEach(tuple => {
+[
+ ['uniq', uniq],
+ ['union', union],
+].forEach(tuple => {
let [name, macro] = tuple;
moduleFor(
@@ -745,7 +748,11 @@ moduleFor(
list: null,
uniqueById: uniqBy('list', 'id'),
}).creat... | true |
Other | emberjs | ember.js | 68f4483df86c7a2e42739c3d99c87d34fa445edd.json | Apply new prettier autofix | packages/@ember/runloop/tests/run_test.js | @@ -15,7 +15,11 @@ moduleFor(
},
};
- assert.equal(run(() => 'FOO'), 'FOO', 'pass function only');
+ assert.equal(
+ run(() => 'FOO'),
+ 'FOO',
+ 'pass function only'
+ );
assert.deepEqual(run(obj, obj.foo), ['BAR', 'FOO'], 'pass obj and obj.method');
... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.