language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | Homebrew | brew | 5afff3f3aa1d806855d460e5f39bfbef28ef6262.json | Handle macOS Homebrew on ARM
- Output `brew doctor` and `brew install` messages noting this configuration is (currently) unsupported and encourage use of Rosetta instead
- Output Rosetta 2 usage in `brew config` on ARM (whether in Rosetta 2 or not)
- Check the architecture of (newly installed) dependencies and ensure ... | Library/Homebrew/global.rb | @@ -69,7 +69,8 @@
"(KHTML, like Gecko) Version/10.0.3 Safari/602.4.8"
HOMEBREW_DEFAULT_PREFIX = "/usr/local"
-LINUXBREW_DEFAULT_PREFIX = "/home/linuxbrew/.linuxbrew"
+HOMEBREW_MACOS_ARM_DEFAULT_PREFIX = "/opt/homebrew"
+HOMEBREW_LINUX_DEFAULT_PREFIX = "/home/linuxbrew/.linuxbrew"
require "fileutils"
require "... | true |
Other | Homebrew | brew | 5afff3f3aa1d806855d460e5f39bfbef28ef6262.json | Handle macOS Homebrew on ARM
- Output `brew doctor` and `brew install` messages noting this configuration is (currently) unsupported and encourage use of Rosetta instead
- Output Rosetta 2 usage in `brew config` on ARM (whether in Rosetta 2 or not)
- Check the architecture of (newly installed) dependencies and ensure ... | Library/Homebrew/hardware.rb | @@ -156,7 +156,7 @@ def arch_flag(arch)
"-march=#{arch}"
end
- def in_rosetta?
+ def in_rosetta2?
false
end
end | true |
Other | Homebrew | brew | 5afff3f3aa1d806855d460e5f39bfbef28ef6262.json | Handle macOS Homebrew on ARM
- Output `brew doctor` and `brew install` messages noting this configuration is (currently) unsupported and encourage use of Rosetta instead
- Output Rosetta 2 usage in `brew config` on ARM (whether in Rosetta 2 or not)
- Check the architecture of (newly installed) dependencies and ensure ... | Library/Homebrew/install.rb | @@ -14,6 +14,7 @@ module Install
module_function
def perform_preinstall_checks(all_fatal: false, cc: nil)
+ check_prefix
check_cpu
attempt_directory_creation
check_cc_argv(cc)
@@ -28,20 +29,27 @@ def perform_build_from_source_checks(all_fatal: false)
Diagnostic.checks(:build... | true |
Other | Homebrew | brew | 5afff3f3aa1d806855d460e5f39bfbef28ef6262.json | Handle macOS Homebrew on ARM
- Output `brew doctor` and `brew install` messages noting this configuration is (currently) unsupported and encourage use of Rosetta instead
- Output Rosetta 2 usage in `brew config` on ARM (whether in Rosetta 2 or not)
- Check the architecture of (newly installed) dependencies and ensure ... | Library/Homebrew/os/global.rb | @@ -1,4 +1,8 @@
# typed: strict
# frozen_string_literal: true
-require "os/linux/global" if OS.linux?
+if OS.mac?
+ require "os/mac/global"
+elsif OS.linux?
+ require "os/linux/global"
+end | true |
Other | Homebrew | brew | 5afff3f3aa1d806855d460e5f39bfbef28ef6262.json | Handle macOS Homebrew on ARM
- Output `brew doctor` and `brew install` messages noting this configuration is (currently) unsupported and encourage use of Rosetta instead
- Output Rosetta 2 usage in `brew config` on ARM (whether in Rosetta 2 or not)
- Check the architecture of (newly installed) dependencies and ensure ... | Library/Homebrew/os/linux/global.rb | @@ -12,6 +12,6 @@ module Homebrew
DEFAULT_PREFIX ||= if Homebrew::EnvConfig.force_homebrew_on_linux?
HOMEBREW_DEFAULT_PREFIX
else
- LINUXBREW_DEFAULT_PREFIX
+ HOMEBREW_LINUX_DEFAULT_PREFIX
end.freeze
end | true |
Other | Homebrew | brew | 5afff3f3aa1d806855d460e5f39bfbef28ef6262.json | Handle macOS Homebrew on ARM
- Output `brew doctor` and `brew install` messages noting this configuration is (currently) unsupported and encourage use of Rosetta instead
- Output Rosetta 2 usage in `brew config` on ARM (whether in Rosetta 2 or not)
- Check the architecture of (newly installed) dependencies and ensure ... | Library/Homebrew/os/mac/global.rb | @@ -0,0 +1,10 @@
+# typed: false
+# frozen_string_literal: true
+
+module Homebrew
+ DEFAULT_PREFIX ||= if Hardware::CPU.arm?
+ HOMEBREW_MACOS_ARM_DEFAULT_PREFIX
+ else
+ HOMEBREW_DEFAULT_PREFIX
+ end.freeze
+end | true |
Other | Homebrew | brew | 5afff3f3aa1d806855d460e5f39bfbef28ef6262.json | Handle macOS Homebrew on ARM
- Output `brew doctor` and `brew install` messages noting this configuration is (currently) unsupported and encourage use of Rosetta instead
- Output Rosetta 2 usage in `brew config` on ARM (whether in Rosetta 2 or not)
- Check the architecture of (newly installed) dependencies and ensure ... | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -13404,8 +13404,10 @@ class Object
HOMEBREW_LIBRARY = ::T.let(nil, ::T.untyped)
HOMEBREW_LIBRARY_PATH = ::T.let(nil, ::T.untyped)
HOMEBREW_LINKED_KEGS = ::T.let(nil, ::T.untyped)
+ HOMEBREW_LINUX_DEFAULT_PREFIX = ::T.let(nil, ::T.untyped)
HOMEBREW_LOCKS = ::T.let(nil, ::T.untyped)
HOMEBREW_LOGS = ::T... | true |
Other | Homebrew | brew | 5afff3f3aa1d806855d460e5f39bfbef28ef6262.json | Handle macOS Homebrew on ARM
- Output `brew doctor` and `brew install` messages noting this configuration is (currently) unsupported and encourage use of Rosetta instead
- Output Rosetta 2 usage in `brew config` on ARM (whether in Rosetta 2 or not)
- Check the architecture of (newly installed) dependencies and ensure ... | Library/Homebrew/tab.rb | @@ -186,6 +186,7 @@ def self.empty
"compiler" => DevelopmentTools.default_compiler,
"aliases" => [],
"runtime_dependencies" => nil,
+ "arch" => nil,
"source" => {
"path" => nil,
"tap" => nil... | true |
Other | Homebrew | brew | 5afff3f3aa1d806855d460e5f39bfbef28ef6262.json | Handle macOS Homebrew on ARM
- Output `brew doctor` and `brew install` messages noting this configuration is (currently) unsupported and encourage use of Rosetta instead
- Output Rosetta 2 usage in `brew config` on ARM (whether in Rosetta 2 or not)
- Check the architecture of (newly installed) dependencies and ensure ... | docs/Installation.md | @@ -31,10 +31,11 @@ Just extract (or `git clone`) Homebrew wherever you want. Just avoid:
* `/tmp` subdirectories because Homebrew gets upset.
* `/sw` and `/opt/local` because build scripts get confused when Homebrew is there instead of Fink or MacPorts, respectively.
-However do yourself a favour and install to `/... | true |
Other | Homebrew | brew | c1c8bda3edcd896d6ba8a5496b302330e3db6962.json | sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -2980,6 +2980,10 @@ end
BasicObject::BasicObject = BasicObject
+class BasicSocket
+ def read_nonblock(len, str=T.unsafe(nil), exception: T.unsafe(nil)); end
+end
+
class Benchmark::Job
def initialize(width); end
end
@@ -5580,10 +5584,6 @@ class Cask::Cask
def zap(&block); end
end
-class Cask::Cmd::A... | false |
Other | Homebrew | brew | e9be4cb83d9c4e58b3894c63eac26fe0034fc96e.json | sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/parallel@1.20.0.rbi | @@ -1,6 +1,6 @@
# DO NOT EDIT MANUALLY
# This is an autogenerated file for types exported from the `parallel` gem.
-# Please instead update this file by running `tapioca generate --exclude json`.
+# Please instead update this file by running `tapioca sync`.
# typed: true
@@ -26,7 +26,6 @@ module Parallel
de... | true |
Other | Homebrew | brew | e9be4cb83d9c4e58b3894c63eac26fe0034fc96e.json | sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rubocop-ast@1.1.1.rbi | @@ -929,10 +929,10 @@ class RuboCop::AST::NodePattern::Compiler::Debug::Colorizer::Result < ::Struct
def color_map_for(node, color); end
class << self
- def [](*_); end
+ def [](*_arg0); end
def inspect; end
def members; end
- def new(*_); end
+ def new(*_arg0); end
end
end
@@ -1078,... | true |
Other | Homebrew | brew | e9be4cb83d9c4e58b3894c63eac26fe0034fc96e.json | sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rubocop-rspec@2.0.0.rbi | @@ -54,6 +54,10 @@ class RuboCop::Cop::RSpec::AlignLeftLetBrace < ::RuboCop::Cop::RSpec::Base
def on_new_investigation; end
+ private
+
+ def token_aligner; end
+
class << self
def autocorrect_incompatible_with; end
end
@@ -66,6 +70,10 @@ class RuboCop::Cop::RSpec::AlignRightLetBrace < ::RuboCop::Co... | true |
Other | Homebrew | brew | e9be4cb83d9c4e58b3894c63eac26fe0034fc96e.json | sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rubocop@1.2.0.rbi | @@ -74,7 +74,7 @@ class RuboCop::CLI::Command::Base
class << self
def by_command_name(name); end
def command_name; end
- def command_name=(_); end
+ def command_name=(_arg0); end
def inherited(subclass); end
end
end
@@ -197,10 +197,10 @@ class RuboCop::CommentConfig::CopAnalysis < ::Struct
... | true |
Other | Homebrew | brew | e9be4cb83d9c4e58b3894c63eac26fe0034fc96e.json | sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -25838,6 +25838,14 @@ module Readline
def self.completion_quote_character(); end
end
+class Regexp::Expression::Base
+ include ::RuboCop::Ext::RegexpParser::Expression::Base
+end
+
+class Regexp::Expression::CharacterSet
+ include ::RuboCop::Ext::RegexpParser::Expression::CharacterSet
+end
+
class ReporterH... | true |
Other | Homebrew | brew | 52de3f9d8d6c5bf6ed193d643c23e35f143c6cd6.json | extract: fix tap regex | Library/Homebrew/dev-cmd/extract.rb | @@ -101,9 +101,9 @@ def extract_args
def extract
args = extract_args.parse
- if args.named.first =~ HOMEBREW_TAP_FORMULA_REGEX
- name = Regexp.last_match(3).downcase
- source_tap = Tap.fetch(Regexp.last_match(1), Regexp.last_match(2))
+ if (match = args.named.first.match(HOMEBREW_TAP_FORMULA_R... | false |
Other | Homebrew | brew | 8b1aaa957ab95ba229d3c8f9998a1a858f0c5d34.json | rubocop: set Lint/EmptyBlock as rubocop_todo | Library/Homebrew/.rubocop_todo.yml | @@ -22,3 +22,15 @@ Style/Documentation:
- 'utils/popen.rb'
- 'utils/shell.rb'
- 'version.rb'
+
+Lint/EmptyBlock:
+ Exclude:
+ - 'dependency.rb'
+ - 'dev-cmd/extract.rb'
+ - 'test/cache_store_spec.rb'
+ - 'test/checksum_verification_spec.rb'
+ - 'test/compiler_failure_spec.rb'
+ - 'test... | false |
Other | Homebrew | brew | 9ad37ddc36c8438db97fdb3e4484d724e06eaffe.json | Revert "uses_from_macos: fix force_homebrew_on_linux behaviour." | Library/Homebrew/extend/os/mac/software_spec.rb | @@ -1,8 +1,6 @@
# typed: false
# frozen_string_literal: true
-# The Library/Homebrew/extend/os/software_spec.rb conditional logic will need to be more nuanced
-# if this file ever includes more than `uses_from_macos`.
class SoftwareSpec
undef uses_from_macos
| true |
Other | Homebrew | brew | 9ad37ddc36c8438db97fdb3e4484d724e06eaffe.json | Revert "uses_from_macos: fix force_homebrew_on_linux behaviour." | Library/Homebrew/extend/os/software_spec.rb | @@ -1,9 +1,8 @@
# typed: strict
# frozen_string_literal: true
-# This logic will need to be more nuanced if this file includes more than `uses_from_macos`.
-if OS.mac? || Homebrew::EnvConfig.force_homebrew_on_linux?
- require "extend/os/mac/software_spec"
-elsif OS.linux?
+if OS.linux?
require "extend/os/linux/... | true |
Other | Homebrew | brew | a867e78f62c807b65ff4f80587d1a512252febf0.json | uses_from_macos: fix force_homebrew_on_linux behaviour.
Otherwise the dependencies are read incorrectly on Linux when we're
trying to analyse Homebrew. | Library/Homebrew/extend/os/mac/software_spec.rb | @@ -1,6 +1,8 @@
# typed: false
# frozen_string_literal: true
+# The Library/Homebrew/extend/os/software_spec.rb conditional logic will need to be more nuanced
+# if this file ever includes more than `uses_from_macos`.
class SoftwareSpec
undef uses_from_macos
| true |
Other | Homebrew | brew | a867e78f62c807b65ff4f80587d1a512252febf0.json | uses_from_macos: fix force_homebrew_on_linux behaviour.
Otherwise the dependencies are read incorrectly on Linux when we're
trying to analyse Homebrew. | Library/Homebrew/extend/os/software_spec.rb | @@ -1,8 +1,9 @@
# typed: strict
# frozen_string_literal: true
-if OS.linux?
- require "extend/os/linux/software_spec"
-elsif OS.mac?
+# This logic will need to be more nuanced if this file includes more than `uses_from_macos`.
+if OS.mac? || Homebrew::EnvConfig.force_homebrew_on_linux?
require "extend/os/mac/so... | true |
Other | Homebrew | brew | 4ae72e0bdfeab8258da4caf4103f75ec14c8b09c.json | tap: add constants for json files | Library/Homebrew/dev-cmd/audit.rb | @@ -1190,14 +1190,8 @@ def audit
audit_tap_audit_exceptions
end
- HOMEBREW_TAP_JSON_FILES = %w[
- formula_renames.json
- tap_migrations.json
- audit_exceptions/*.json
- ].freeze
-
def audit_json_files
- json_patterns = HOMEBREW_TAP_JSON_FILES.map { |pattern| @path/pattern }
... | true |
Other | Homebrew | brew | 4ae72e0bdfeab8258da4caf4103f75ec14c8b09c.json | tap: add constants for json files | Library/Homebrew/tap.rb | @@ -16,6 +16,16 @@ class Tap
TAP_DIRECTORY = (HOMEBREW_LIBRARY/"Taps").freeze
+ HOMEBREW_TAP_FORMULA_RENAMES_FILE = "formula_renames.json"
+ HOMEBREW_TAP_MIGRATIONS_FILE = "tap_migrations.json"
+ HOMEBREW_TAP_AUDIT_EXCEPTIONS_DIR = "audit_exceptions"
+
+ HOMEBREW_TAP_JSON_FILES = %W[
+ #{HOMEBREW_TAP_FORM... | true |
Other | Homebrew | brew | 9057a630212d95b57e7ee5492f7662a2340ff288.json | dev-cmd/pr-upload: run `brew audit` before uploading.
Check that `brew bottle --merge --write` hasn't broken `brew audit`. | Library/Homebrew/dev-cmd/pr-upload.rb | @@ -87,6 +87,14 @@ def pr_upload
safe_system HOMEBREW_BREW_FILE, *bottle_args
+ # Check the bottle commits did not break `brew audit`
+ unless args.no_commit?
+ audit_args = ["bottle", "--merge", "--write"]
+ audit_args << "--verbose" if args.verbose?
+ audit_args << "--debug" if args.debu... | false |
Other | Homebrew | brew | d73a0e3040d3b59ef3711a3e2cf405c28a463b11.json | sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -5523,6 +5523,8 @@ class Cask::Cask
def dictionary(&block); end
+ def discontinued?(&block); end
+
def font(&block); end
def homepage(&block); end
@@ -5715,6 +5717,8 @@ class Cask::DSL::Caveats
def discontinued(*args); end
+ def discontinued?(); end
+
def files_in_usr_local(*args); end
... | false |
Other | Homebrew | brew | b4d4f6d50422107ef79c5b976bed891915d5ef2e.json | audit: require JSON arrays/objects for audit exceptions | Library/Homebrew/dev-cmd/audit.rb | @@ -1207,6 +1207,14 @@ def audit_json_files
def audit_tap_audit_exceptions
@tap_audit_exceptions.each do |list_name, formula_names|
+ unless [Hash, Array].include? formula_names.class
+ problem <<~EOS
+ audit_exceptions/#{list_name}.json should contain a JSON array
+ ... | false |
Other | Homebrew | brew | 6b27dcb11ce2a353c73ea7fd771b960899702736.json | workflows/tests: use Big Sur.
Migrate GitHub Actions to Big Sur. | .github/workflows/tests.yml | @@ -6,18 +6,21 @@ on:
env:
HOMEBREW_DEVELOPER: 1
HOMEBREW_NO_AUTO_UPDATE: 1
+ HOMEBREW_GITHUB_ACTIONS_BIG_SUR_TESTING: 1 # TODO: remove when Big Sur is released.
jobs:
tests:
if: github.repository == 'Homebrew/brew'
runs-on: ${{ matrix.os }}
strategy:
matrix:
- os: [ubuntu-lates... | true |
Other | Homebrew | brew | 6b27dcb11ce2a353c73ea7fd771b960899702736.json | workflows/tests: use Big Sur.
Migrate GitHub Actions to Big Sur. | Library/Homebrew/extend/os/mac/diagnostic.rb | @@ -93,6 +93,9 @@ def check_for_non_prefixed_findutils
def check_for_unsupported_macos
return if Homebrew::EnvConfig.developer?
+ # TODO: remove when Big Sur is released.
+ return if MacOS.version == :big_sur && ENV["HOMEBREW_GITHUB_ACTIONS_BIG_SUR_TESTING"]
+
who = +"We"
... | true |
Other | Homebrew | brew | 6b27dcb11ce2a353c73ea7fd771b960899702736.json | workflows/tests: use Big Sur.
Migrate GitHub Actions to Big Sur. | Library/Homebrew/test/os/mac/diagnostic_spec.rb | @@ -6,6 +6,7 @@
describe Homebrew::Diagnostic::Checks do
specify "#check_for_unsupported_macos" do
ENV.delete("HOMEBREW_DEVELOPER")
+ allow(OS::Mac).to receive(:version).and_return(OS::Mac::Version.new("10.14"))
allow(OS::Mac).to receive(:prerelease?).and_return(true)
expect(subject.check_for_un... | true |
Other | Homebrew | brew | 6b27dcb11ce2a353c73ea7fd771b960899702736.json | workflows/tests: use Big Sur.
Migrate GitHub Actions to Big Sur. | Library/Homebrew/test/spec_helper.rb | @@ -109,7 +109,7 @@
config.before(:each, :needs_java) do
java_installed = if OS.mac?
- Utils.popen_read("/usr/libexec/java_home", "--failfast")
+ Utils.popen_read("/usr/libexec/java_home", "--failfast", "--version", "1.0+")
$CHILD_STATUS.success?
else
which("java") | true |
Other | Homebrew | brew | 763e761a200cb9ddd839c0351ceb7221e719f80e.json | sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -2980,6 +2980,10 @@ end
BasicObject::BasicObject = BasicObject
+class BasicSocket
+ def read_nonblock(len, str=T.unsafe(nil), exception: T.unsafe(nil)); end
+end
+
class Benchmark::Job
def initialize(width); end
end
@@ -5578,10 +5582,6 @@ class Cask::Cask
def zap(&block); end
end
-class Cask::Cmd::A... | false |
Other | Homebrew | brew | 027419effe57b424eb76ca2151e7effa26e33c8c.json | test/language/node: add test for prepare/prepack removal | Library/Homebrew/test/language/node_spec.rb | @@ -24,6 +24,20 @@
end
end
+ describe "#std_pack_for_installation" do
+ npm_pack_cmd = "npm pack --ignore-scripts"
+
+ it "removes prepare and prepack scripts" do
+ path = Pathname("package.json")
+ path.atomic_write("{\"scripts\":{\"prepare\": \"ls\", \"prepack\": \"ls\", \"test\": \"ls\"}}"... | false |
Other | Homebrew | brew | c062429dddebf52f1cf218b190d00a3a34d2f7d1.json | language/node: remove unneeded scripts prior to installation | Library/Homebrew/language/node.rb | @@ -16,6 +16,17 @@ def self.pack_for_installation
# fed to `npm install` only symlinks are created linking back to that
# directory, consequently breaking that assumption. We require a tarball
# because npm install creates a "real" installation when fed a tarball.
+ if (package = Pathname("pac... | false |
Other | Homebrew | brew | 2a941ec6b17bcb0d9557cf3604d64a3954cc199e.json | audit, tap: incorporate suggestions from code review | Library/Homebrew/dev-cmd/audit.rb | @@ -121,7 +121,7 @@ def audit
# Run tap audits first
if args.tap
tap = Tap.fetch(args.tap)
- ta = TapAuditor.new(tap, options)
+ ta = TapAuditor.new(tap, strict: args.strict?)
ta.audit
if ta.problems.any?
@@ -1158,25 +1158,24 @@ def problem(text)
class TapAuditor
attr_... | true |
Other | Homebrew | brew | 2a941ec6b17bcb0d9557cf3604d64a3954cc199e.json | audit, tap: incorporate suggestions from code review | Library/Homebrew/tap.rb | @@ -546,12 +546,12 @@ def tap_migrations
def audit_exceptions
@audit_exceptions = {}
- Dir[path/"audit_exceptions/*"].each do |exception_file|
- list_name = File.basename(exception_file).chomp(".json").to_sym
+ Pathname.glob(path/"audit_exceptions/*").each do |exception_file|
+ list_name = exc... | true |
Other | Homebrew | brew | 089810709cfaae625867f2ee3e9c61f6822e9a2c.json | audit: add tap_audit_exceptions attribute | Library/Homebrew/dev-cmd/audit.rb | @@ -1156,7 +1156,7 @@ def problem(text)
end
class TapAuditor
- attr_reader :name, :path, :problems
+ attr_reader :name, :path, :tap_audit_exceptions, :problems
def initialize(tap, options = {})
@name = tap.name | false |
Other | Homebrew | brew | 1b95059c2b1db0e45e9a10fb2040a90311bbdd3d.json | Restrict audit to homebrew/core
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com> | Library/Homebrew/rubocops/lines.rb | @@ -668,6 +668,8 @@ def audit_formula(_node, _class_node, _parent_class_node, body_node)
# This cop ensures that new formulae depending on Requirements are not introduced in homebrew/core.
class CoreRequirements < FormulaCop
def audit_formula(_node, _class_node, _parent_class_node, _body_node)
+ ... | false |
Other | Homebrew | brew | fe1c7c16b0d2df1a6e9e85dbb5f4bdec93971e84.json | audit: add tap audits for audit exceptions | Library/Homebrew/dev-cmd/audit.rb | @@ -118,6 +118,21 @@ def audit
options[:except_cops] = [:FormulaAuditStrict]
end
+ # Run tap audits first
+ if args.tap
+ tap = Tap.fetch(args.tap)
+ ta = TapAuditor.new(tap, options)
+ ta.audit
+
+ if ta.problems.any?
+ tap_problem_lines = format_problem_lines(ta.problems... | false |
Other | Homebrew | brew | e1f463ff26a13eda48f4fcbaf0049a593d2cb8f0.json | audit: use name `tap_audit_exceptions` | Library/Homebrew/dev-cmd/audit.rb | @@ -127,15 +127,15 @@ def audit
audit_formulae.sort.each do |f|
only = only_cops ? ["style"] : args.only
options = {
- new_formula: new_formula,
- strict: strict,
- online: online,
- git: git,
- only: ... | false |
Other | Homebrew | brew | 10ae9bcde728148ffed445f976cb06d3cf08e65d.json | modify autoremove to use uninstall | Library/Homebrew/cmd/autoremove.rb | @@ -2,8 +2,11 @@
require "formula"
require "cli/parser"
+require "uninstall"
module Homebrew
+ extend Uninstall
+
module_function
def autoremove_args
@@ -19,17 +22,13 @@ def autoremove_args
end
end
- def get_removable_formulae(installed_formulae)
- removable_formulae = []
-
- installed_... | false |
Other | Homebrew | brew | 0fa417706a2143dbec1e6fd2f29f3e3e32663252.json | cmd: add autoremove command | Library/Homebrew/cmd/autoremove.rb | @@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+require "formula"
+require "cli/parser"
+
+module Homebrew
+ module_function
+
+ def autoremove_args
+ Homebrew::CLI::Parser.new do
+ usage_banner <<~EOS
+ `autoremove` [<options>]
+
+ Remove packages that weren't installed on request and are no... | true |
Other | Homebrew | brew | 0fa417706a2143dbec1e6fd2f29f3e3e32663252.json | cmd: add autoremove command | Library/Homebrew/test/.rubocop_todo.yml | @@ -33,6 +33,7 @@ RSpec/MultipleDescribes:
- 'cmd/--repository_spec.rb'
- 'cmd/--version_spec.rb'
- 'cmd/analytics_spec.rb'
+ - 'cmd/autoremove_spec.rb'
- 'cmd/cleanup_spec.rb'
- 'cmd/commands_spec.rb'
- 'cmd/config_spec.rb' | true |
Other | Homebrew | brew | 0fa417706a2143dbec1e6fd2f29f3e3e32663252.json | cmd: add autoremove command | Library/Homebrew/test/cmd/autoremove_spec.rb | @@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+require "cmd/shared_examples/args_parse"
+
+describe "Homebrew.autoremove_args" do
+ it_behaves_like "parseable arguments"
+end | true |
Other | Homebrew | brew | 0fa417706a2143dbec1e6fd2f29f3e3e32663252.json | cmd: add autoremove command | completions/internal_commands_list.txt | @@ -12,6 +12,7 @@
abv
analytics
audit
+autoremove
bottle
bump
bump-cask-pr | true |
Other | Homebrew | brew | 0fa417706a2143dbec1e6fd2f29f3e3e32663252.json | cmd: add autoremove command | docs/Manpage.md | @@ -56,6 +56,13 @@ Turn Homebrew's analytics on or off respectively.
`brew analytics regenerate-uuid`:
Regenerate the UUID used for Homebrew's analytics.
+### `autoremove` [*`options`*]
+
+Remove packages that weren't installed on request and are no longer needed.
+
+* `-n`, `--dry-run`:
+ Just print what would be... | true |
Other | Homebrew | brew | 0fa417706a2143dbec1e6fd2f29f3e3e32663252.json | cmd: add autoremove command | manpages/brew.1 | @@ -53,6 +53,13 @@ Control Homebrew\'s anonymous aggregate user behaviour analytics\. Read more at
\fBbrew analytics regenerate\-uuid\fR
Regenerate the UUID used for Homebrew\'s analytics\.
.
+.SS "\fBautoremove\fR [\fIoptions\fR]"
+Remove packages that weren\'t installed on request and are no longer needed\.
+.... | true |
Other | Homebrew | brew | 4127a7b62422ed0b9c38dbe022ee958640b7c614.json | move some uninstall tests to new file | Library/Homebrew/test/cmd/uninstall_spec.rb | @@ -19,61 +19,3 @@
.and be_a_success
end
end
-
-describe Homebrew do
- let(:dependency) { formula("dependency") { url "f-1" } }
- let(:dependent) do
- formula("dependent") do
- url "f-1"
- depends_on "dependency"
- end
- end
-
- let(:kegs_by_rack) { { dependency.rack => [Keg.new(dependenc... | true |
Other | Homebrew | brew | 4127a7b62422ed0b9c38dbe022ee958640b7c614.json | move some uninstall tests to new file | Library/Homebrew/test/uninstall_spec.rb | @@ -0,0 +1,62 @@
+# typed: false
+# frozen_string_literal: true
+
+require "uninstall"
+
+describe Homebrew::Uninstall do
+ let(:dependency) { formula("dependency") { url "f-1" } }
+ let(:dependent) do
+ formula("dependent") do
+ url "f-1"
+ depends_on "dependency"
+ end
+ end
+
+ let(:kegs_by_rack)... | true |
Other | Homebrew | brew | 30a35614484f422c78a6328bcae2504b8ec35fb2.json | move uninstall logic to new file | Library/Homebrew/cmd/uninstall.rb | @@ -8,8 +8,11 @@
require "cli/parser"
require "cask/cmd"
require "cask/cask_loader"
+require "uninstall"
module Homebrew
+ extend Uninstall
+
module_function
def uninstall_args
@@ -54,76 +57,10 @@ def uninstall
kegs_by_rack = all_kegs.group_by(&:rack)
end
- handle_unsatisfied_dependents(... | true |
Other | Homebrew | brew | 30a35614484f422c78a6328bcae2504b8ec35fb2.json | move uninstall logic to new file | Library/Homebrew/uninstall.rb | @@ -0,0 +1,215 @@
+# typed: true
+# frozen_string_literal: true
+
+require "keg"
+require "formula"
+
+module Homebrew
+ # Helper module for uninstalling kegs.
+ #
+ # @api private
+ module Uninstall
+ module_function
+
+ def uninstall_kegs(kegs_by_rack, force: false, ignore_dependencies: false, named_args: [... | true |
Other | Homebrew | brew | f95e1729a2d95d8dc80dadc8c05851d534a72f74.json | move logic from leaves to formula | Library/Homebrew/cmd/leaves.rb | @@ -2,7 +2,6 @@
# frozen_string_literal: true
require "formula"
-require "tab"
require "cli/parser"
module Homebrew
@@ -23,9 +22,7 @@ def leaves_args
def leaves
leaves_args.parse
- installed = Formula.installed.sort
- deps_of_installed = installed.flat_map(&:runtime_formula_dependencies)
- le... | true |
Other | Homebrew | brew | f95e1729a2d95d8dc80dadc8c05851d534a72f74.json | move logic from leaves to formula | Library/Homebrew/formula.rb | @@ -1515,6 +1515,18 @@ def self.installed
end.uniq(&:name)
end
+ # An array of installed {Formula} that are dependencies of other installed {Formula}
+ # @private
+ def self.installed_deps(formulae=installed)
+ formulae.flat_map(&:runtime_formula_dependencies).uniq(&:name)
+ end
+
+ # An array of all ... | true |
Other | Homebrew | brew | f95e1729a2d95d8dc80dadc8c05851d534a72f74.json | move logic from leaves to formula | Library/Homebrew/test/cmd/leaves_spec.rb | @@ -8,14 +8,42 @@
end
describe "brew leaves", :integration_test do
- it "prints all Formulae that are not dependencies of other Formulae" do
- setup_test_formula "foo"
- setup_test_formula "bar"
- (HOMEBREW_CELLAR/"foo/0.1/somedir").mkpath
+ context "when there are no installed Formulae" do
+ it "prin... | true |
Other | Homebrew | brew | f95e1729a2d95d8dc80dadc8c05851d534a72f74.json | move logic from leaves to formula | Library/Homebrew/test/formula_spec.rb | @@ -440,6 +440,80 @@
end
end
+ describe "::installed_deps" do
+ let(:formula_is_dep) do
+ formula "foo" do
+ url "foo-1.1"
+ end
+ end
+
+ let(:formula_with_deps) do
+ formula "bar" do
+ url "bar-1.0"
+ end
+ end
+
+ let(:formulae) do
+ [
+ formula... | true |
Other | Homebrew | brew | 7e2b228460e87ad247b73859da2576d5f782315c.json | diagnostic: improve deleted message.
Raised in #9036. | Library/Homebrew/diagnostic.rb | @@ -851,7 +851,8 @@ def check_deleted_formula
return if deleted_formulae.blank?
<<~EOS
- Some installed formulae were deleted!
+ Some installed kegs have no formulae!
+ This means they were either deleted or installed with `brew diy`.
You should find replacement... | false |
Other | Homebrew | brew | 1f971ba2a0575523300df2f4e63c03769ed3ad2a.json | link: link kegs without formulae.
Needed for `brew diy`.
Fixes #9036 | Library/Homebrew/cmd/link.rb | @@ -67,10 +67,15 @@ def link
next
end
- formula = keg.to_formula
+ formula = begin
+ keg.to_formula
+ rescue FormulaUnavailableError
+ # Not all kegs may belong to formulae e.g. with `brew diy`
+ nil
+ end
if keg_only
- if Homebrew.default_prefi... | false |
Other | Homebrew | brew | 8b85ef2e8851b32eaac3f3094c7a6044eceb20e3.json | formula: add on_linux and on_macos blocks
for install and others | Library/Homebrew/extend/os/linux/formula.rb | @@ -2,6 +2,14 @@
# frozen_string_literal: true
class Formula
+ undef on_linux
+
+ def on_linux(&_block)
+ raise "No block content defined for on_linux block" unless block_given?
+
+ yield
+ end
+
undef shared_library
def shared_library(name, version = nil)
@@ -12,6 +20,8 @@ class << self
undef... | true |
Other | Homebrew | brew | 8b85ef2e8851b32eaac3f3094c7a6044eceb20e3.json | formula: add on_linux and on_macos blocks
for install and others | Library/Homebrew/extend/os/mac/formula.rb | @@ -2,10 +2,20 @@
# frozen_string_literal: true
class Formula
+ undef on_macos
+
+ def on_macos(&_block)
+ raise "No block content defined for on_macos block" unless block_given?
+
+ yield
+ end
+
class << self
undef on_macos
def on_macos(&_block)
+ raise "No block content defined for o... | true |
Other | Homebrew | brew | 8b85ef2e8851b32eaac3f3094c7a6044eceb20e3.json | formula: add on_linux and on_macos blocks
for install and others | Library/Homebrew/formula.rb | @@ -1366,6 +1366,22 @@ def inspect
"#<Formula #{name} (#{active_spec_sym}) #{path}>"
end
+ # Block only executed on macOS. No-op on Linux.
+ # <pre>on_macos do
+ # Do something mac specific
+ # end</pre>
+ def on_macos(&_block)
+ raise "No block content defined for on_macos block" unless block_given... | true |
Other | Homebrew | brew | 8b85ef2e8851b32eaac3f3094c7a6044eceb20e3.json | formula: add on_linux and on_macos blocks
for install and others | Library/Homebrew/test/formula_spec.rb | @@ -1363,4 +1363,50 @@ def setup_tab_for_prefix(prefix, options = {})
expect(f.any_installed_version).to eq(PkgVersion.parse("1.0_1"))
end
end
+
+ describe "#on_macos", :needs_macos do
+ let(:f) do
+ Class.new(Testball) do
+ @test = 0
+ attr_reader :test
+
+ def install
+ ... | true |
Other | Homebrew | brew | 5adb76a5babdccd2c4edfb8752ac979ed14716ca.json | list: fix flag handling.
Fix `-1` and other flags so they're handled correctly with casks. Use
the "right" exceptions for declaring invalid combinations and change
their parent class so that `--help` is printed nicely too.
Fixes #9033 | Library/Homebrew/cli/parser.rb | @@ -506,7 +506,7 @@ def formulae(argv)
end
end
- class OptionConstraintError < RuntimeError
+ class OptionConstraintError < UsageError
def initialize(arg1, arg2, missing: false)
message = if !missing
"`#{arg1}` and `#{arg2}` should be passed together."
@@ -517,15 +517,15 @... | true |
Other | Homebrew | brew | 5adb76a5babdccd2c4edfb8752ac979ed14716ca.json | list: fix flag handling.
Fix `-1` and other flags so they're handled correctly with casks. Use
the "right" exceptions for declaring invalid combinations and change
their parent class so that `--help` is printed nicely too.
Fixes #9033 | Library/Homebrew/cmd/list.rb | @@ -18,38 +18,51 @@ def list_args
If <formula> is provided, summarise the paths within its current keg.
EOS
+ switch "--formula", "--formulae",
+ description: "List only formulae. `This is the default action on non TTY.`"
+ switch "--cask", "--casks",
+ description: "... | true |
Other | Homebrew | brew | 5adb76a5babdccd2c4edfb8752ac979ed14716ca.json | list: fix flag handling.
Fix `-1` and other flags so they're handled correctly with casks. Use
the "right" exceptions for declaring invalid combinations and change
their parent class so that `--help` is printed nicely too.
Fixes #9033 | docs/Manpage.md | @@ -353,28 +353,28 @@ List all installed formulae or casks
If *`formula`* is provided, summarise the paths within its current keg.
-* `--full-name`:
- Print formulae with fully-qualified names. If `--full-name` is not passed, other options (i.e. `-1`, `-l`, `-r` and `-t`) are passed to `ls`(1) which produces the ... | true |
Other | Homebrew | brew | 5adb76a5babdccd2c4edfb8752ac979ed14716ca.json | list: fix flag handling.
Fix `-1` and other flags so they're handled correctly with casks. Use
the "right" exceptions for declaring invalid combinations and change
their parent class so that `--help` is printed nicely too.
Fixes #9033 | manpages/brew.1 | @@ -1,7 +1,7 @@
.\" generated with Ronn/v0.7.3
.\" http://github.com/rtomayko/ronn/tree/0.7.3
.
-.TH "BREW" "1" "October 2020" "Homebrew" "brew"
+.TH "BREW" "1" "November 2020" "Homebrew" "brew"
.
.SH "NAME"
\fBbrew\fR \- The Missing Package Manager for macOS
@@ -512,14 +512,22 @@ List all installed formulae or c... | true |
Other | Homebrew | brew | f41afe6256995d34c2b189cb951dc4dc2cd6e1b8.json | audit: use the specific url for vifm allowlist
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com> | Library/Homebrew/rubocops/urls.rb | @@ -22,7 +22,7 @@ class Urls < FormulaCop
https://osxbook.com/book/bonus/chapter8/core/download/gcore
https://naif.jpl.nasa.gov/pub/naif/toolkit/C/MacIntel_OSX_AppleC_64bit/packages/
https://artifacts.videolan.org/x264/release-macos/
- https://github.com/vifm/vifm/releases/down... | false |
Other | Homebrew | brew | b54b022f73628360e109586013b6b22aacd92f5d.json | Keg.for: handle non-existent path.
Otherwise `path.realpath` will raise `Errno::ENOENT` rather than the
expected `NotAKegError`.
Fixes https://github.com/Homebrew/brew/issues/9015 | Library/Homebrew/keg.rb | @@ -183,13 +183,15 @@ def self.find_some_installed_dependents(kegs)
# if path is a file in a keg then this will return the containing Keg object
def self.for(path)
- path = path.realpath
- until path.root?
- return Keg.new(path) if path.parent.parent == HOMEBREW_CELLAR.realpath
+ original_path = p... | false |
Other | Homebrew | brew | 249088038c1bc410068ce53d8d0b804d38289bda.json | shared_audits: add lidarr to GITHUB_PRERELEASE_ALLOWLIST | Library/Homebrew/utils/shared_audits.rb | @@ -38,6 +38,7 @@ def github_release_data(user, repo, tag)
"freetube" => :all,
"gitless" => "0.8.8",
"home-assistant" => :all,
+ "lidarr" => :all,
"nuclear" => :all,
"pock" => :all,
"riff" => "0.5.0", | false |
Other | Homebrew | brew | 62984b956e4e2fc1dced4998dc913421babde8bf.json | relocate requirement tests | Library/Homebrew/test/java_requirement_spec.rb | @@ -1,131 +0,0 @@
-# typed: false
-# frozen_string_literal: true
-
-require "cli/args"
-require "requirements/java_requirement"
-
-describe JavaRequirement do
- subject { described_class.new([]) }
-
- before do
- ENV["JAVA_HOME"] = nil
- end
-
- describe "#message" do
- its(:message) { is_expected.to match(/J... | true |
Other | Homebrew | brew | 62984b956e4e2fc1dced4998dc913421babde8bf.json | relocate requirement tests | Library/Homebrew/test/requirements/java_requirement_spec.rb | @@ -1,10 +1,17 @@
# typed: false
# frozen_string_literal: true
+require "cli/args"
require "requirements/java_requirement"
describe JavaRequirement do
- describe "initialize" do
+ subject { described_class.new([]) }
+
+ before do
+ ENV["JAVA_HOME"] = nil
+ end
+
+ describe "#initialize" do
it "pars... | true |
Other | Homebrew | brew | 62984b956e4e2fc1dced4998dc913421babde8bf.json | relocate requirement tests | Library/Homebrew/test/requirements/x11_requirement_spec.rb | @@ -5,39 +5,41 @@
require "requirements/x11_requirement"
describe X11Requirement do
+ subject(:requirement) { described_class.new([]) }
+
let(:default_name) { "x11" }
describe "#name" do
it "defaults to x11" do
- expect(subject.name).to eq(default_name)
+ expect(requirement.name).to eq(defau... | true |
Other | Homebrew | brew | a232ac8b1e451aa1345206f8f5043f183b1e6988.json | requirements: improve display in `brew info` | Library/Homebrew/requirement.rb | @@ -126,7 +126,7 @@ def inspect
end
def display_s
- name
+ name.capitalize
end
def mktemp(&block) | true |
Other | Homebrew | brew | a232ac8b1e451aa1345206f8f5043f183b1e6988.json | requirements: improve display in `brew info` | Library/Homebrew/requirements/java_requirement.rb | @@ -55,9 +55,9 @@ def display_s
else
">="
end
- "#{name} #{op} #{version_without_plus}"
+ "#{name.capitalize} #{op} #{version_without_plus}"
else
- name
+ name.capitalize
end
end
| true |
Other | Homebrew | brew | a232ac8b1e451aa1345206f8f5043f183b1e6988.json | requirements: improve display in `brew info` | Library/Homebrew/requirements/macos_requirement.rb | @@ -71,7 +71,7 @@ def inspect
end
def display_s
- return "macOS is required" unless version_specified?
+ return "macOS" unless version_specified?
"macOS #{@comparator} #{@version}"
end | true |
Other | Homebrew | brew | a232ac8b1e451aa1345206f8f5043f183b1e6988.json | requirements: improve display in `brew info` | Library/Homebrew/requirements/osxfuse_requirement.rb | @@ -7,8 +7,14 @@
#
# @api private
class OsxfuseRequirement < Requirement
+ extend T::Sig
cask "osxfuse"
fatal true
+
+ sig { returns(String) }
+ def display_s
+ "FUSE"
+ end
end
require "extend/os/requirements/osxfuse_requirement" | true |
Other | Homebrew | brew | a232ac8b1e451aa1345206f8f5043f183b1e6988.json | requirements: improve display in `brew info` | Library/Homebrew/requirements/xcode_requirement.rb | @@ -48,6 +48,12 @@ def message
def inspect
"#<#{self.class.name}: #{tags.inspect} version=#{@version.inspect}>"
end
+
+ def display_s
+ return name.capitalize unless @version
+
+ "#{name.capitalize} >= #{@version}"
+ end
end
require "extend/os/requirements/xcode_requirement" | true |
Other | Homebrew | brew | a232ac8b1e451aa1345206f8f5043f183b1e6988.json | requirements: improve display in `brew info` | Library/Homebrew/test/java_requirement_spec.rb | @@ -23,19 +23,19 @@
describe "#display_s" do
context "without specific version" do
- its(:display_s) { is_expected.to eq("java") }
+ its(:display_s) { is_expected.to eq("Java") }
end
context "with version 1.8" do
subject { described_class.new(%w[1.8]) }
- its(:display_s) { ... | true |
Other | Homebrew | brew | a232ac8b1e451aa1345206f8f5043f183b1e6988.json | requirements: improve display in `brew info` | Library/Homebrew/test/requirements/java_requirement_spec.rb | @@ -7,27 +7,27 @@
describe "initialize" do
it "parses '1.8' tag correctly" do
req = described_class.new(["1.8"])
- expect(req.display_s).to eq("java = 1.8")
+ expect(req.display_s).to eq("Java = 1.8")
end
it "parses '9' tag correctly" do
req = described_class.new(["9"])
- ... | true |
Other | Homebrew | brew | 849034c368ba5be6de0b0f9d5e4eb4d1917dc42c.json | Improve @-versioned formulae linking.
The way we currently handle @-versioned formulae linking is pretty
labourius:
- it requires extensive use of `link_overwrite` to avoid the `link`
stage failing on certain install/upgrade scenarios
- we teach people to use `brew link --force` whenever they wish to
link a versio... | Library/Homebrew/cmd/link.rb | @@ -4,6 +4,7 @@
require "ostruct"
require "caveats"
require "cli/parser"
+require "unlink"
module Homebrew
module_function
@@ -66,26 +67,27 @@ def link
next
end
+ formula = keg.to_formula
+
if keg_only
- if Homebrew.default_prefix?
- f = keg.to_formula
- i... | true |
Other | Homebrew | brew | 849034c368ba5be6de0b0f9d5e4eb4d1917dc42c.json | Improve @-versioned formulae linking.
The way we currently handle @-versioned formulae linking is pretty
labourius:
- it requires extensive use of `link_overwrite` to avoid the `link`
stage failing on certain install/upgrade scenarios
- we teach people to use `brew link --force` whenever they wish to
link a versio... | Library/Homebrew/cmd/switch.rb | @@ -17,6 +17,7 @@ def switch_args
EOS
named 2
+ hide_from_man_page!
end
end
@@ -28,6 +29,8 @@ def switch
odie "#{name} not found in the Cellar." unless rack.directory?
+ # odeprecated "`brew switch`", "`brew link` @-versioned formulae"
+
versions = rack.subdirs
... | true |
Other | Homebrew | brew | 849034c368ba5be6de0b0f9d5e4eb4d1917dc42c.json | Improve @-versioned formulae linking.
The way we currently handle @-versioned formulae linking is pretty
labourius:
- it requires extensive use of `link_overwrite` to avoid the `link`
stage failing on certain install/upgrade scenarios
- we teach people to use `brew link --force` whenever they wish to
link a versio... | Library/Homebrew/cmd/unlink.rb | @@ -3,6 +3,7 @@
require "ostruct"
require "cli/parser"
+require "unlink"
module Homebrew
module_function
@@ -36,11 +37,7 @@ def unlink
next
end
- keg.lock do
- print "Unlinking #{keg}... "
- puts if args.verbose?
- puts "#{keg.unlink(**options)} symlinks removed"
- ... | true |
Other | Homebrew | brew | 849034c368ba5be6de0b0f9d5e4eb4d1917dc42c.json | Improve @-versioned formulae linking.
The way we currently handle @-versioned formulae linking is pretty
labourius:
- it requires extensive use of `link_overwrite` to avoid the `link`
stage failing on certain install/upgrade scenarios
- we teach people to use `brew link --force` whenever they wish to
link a versio... | Library/Homebrew/formula.rb | @@ -414,12 +414,12 @@ def versioned_formula?
name.include?("@")
end
- # Returns any `@`-versioned formulae for an non-`@`-versioned formula.
+ # Returns any `@`-versioned formulae for any formula (including versioned formulae).
def versioned_formulae
- return [] if versioned_formula?
+ Pathname.glo... | true |
Other | Homebrew | brew | 849034c368ba5be6de0b0f9d5e4eb4d1917dc42c.json | Improve @-versioned formulae linking.
The way we currently handle @-versioned formulae linking is pretty
labourius:
- it requires extensive use of `link_overwrite` to avoid the `link`
stage failing on certain install/upgrade scenarios
- we teach people to use `brew link --force` whenever they wish to
link a versio... | Library/Homebrew/formula_installer.rb | @@ -22,6 +22,7 @@
require "find"
require "utils/spdx"
require "deprecate_disable"
+require "unlink"
# Installer for a formula.
#
@@ -884,6 +885,8 @@ def link(keg)
keg.remove_linked_keg_record
end
+ Homebrew::Unlink.unlink_versioned_formulae(formula, verbose: verbose?)
+
link_overwrite_backu... | true |
Other | Homebrew | brew | 849034c368ba5be6de0b0f9d5e4eb4d1917dc42c.json | Improve @-versioned formulae linking.
The way we currently handle @-versioned formulae linking is pretty
labourius:
- it requires extensive use of `link_overwrite` to avoid the `link`
stage failing on certain install/upgrade scenarios
- we teach people to use `brew link --force` whenever they wish to
link a versio... | Library/Homebrew/keg.rb | @@ -335,6 +335,7 @@ def uninstall
EOS
end
+ # TODO: refactor to use keyword arguments.
def unlink(**options)
ObserverPathnameExtension.reset_counts!
@@ -448,6 +449,7 @@ def oldname_opt_record
end
end
+ # TODO: refactor to use keyword arguments.
def link(**options)
raise AlreadyLi... | true |
Other | Homebrew | brew | 849034c368ba5be6de0b0f9d5e4eb4d1917dc42c.json | Improve @-versioned formulae linking.
The way we currently handle @-versioned formulae linking is pretty
labourius:
- it requires extensive use of `link_overwrite` to avoid the `link`
stage failing on certain install/upgrade scenarios
- we teach people to use `brew link --force` whenever they wish to
link a versio... | Library/Homebrew/unlink.rb | @@ -0,0 +1,30 @@
+# typed: false
+# frozen_string_literal: true
+
+module Homebrew
+ # Provides helper methods for unlinking formulae and kegs with consistent output.
+ module Unlink
+ module_function
+
+ def unlink_versioned_formulae(formula, verbose: false)
+ formula.versioned_formulae
+ .sel... | true |
Other | Homebrew | brew | 849034c368ba5be6de0b0f9d5e4eb4d1917dc42c.json | Improve @-versioned formulae linking.
The way we currently handle @-versioned formulae linking is pretty
labourius:
- it requires extensive use of `link_overwrite` to avoid the `link`
stage failing on certain install/upgrade scenarios
- we teach people to use `brew link --force` whenever they wish to
link a versio... | docs/Manpage.md | @@ -537,10 +537,6 @@ Print export statements. When run in a shell, this installation of Homebrew will
The variables `HOMEBREW_PREFIX`, `HOMEBREW_CELLAR` and `HOMEBREW_REPOSITORY` are also exported to avoid querying them multiple times.
Consider adding evaluation of this command's output to your dotfiles (e.g. `~/.pro... | true |
Other | Homebrew | brew | 849034c368ba5be6de0b0f9d5e4eb4d1917dc42c.json | Improve @-versioned formulae linking.
The way we currently handle @-versioned formulae linking is pretty
labourius:
- it requires extensive use of `link_overwrite` to avoid the `link`
stage failing on certain install/upgrade scenarios
- we teach people to use `brew link --force` whenever they wish to
link a versio... | manpages/brew.1 | @@ -773,9 +773,6 @@ Print export statements\. When run in a shell, this installation of Homebrew wil
.P
The variables \fBHOMEBREW_PREFIX\fR, \fBHOMEBREW_CELLAR\fR and \fBHOMEBREW_REPOSITORY\fR are also exported to avoid querying them multiple times\. Consider adding evaluation of this command\'s output to your dotfil... | true |
Other | Homebrew | brew | 55dc8bbada63593bc5d4a8cdde6509ccd587f438.json | Fix strict typecheck errors. | Library/Homebrew/extend/os/linux/cleaner.rb | @@ -4,6 +4,8 @@
class Cleaner
private
+ extend T::Sig
+ sig { params(path: Pathname).returns(T.nilable(T::Boolean)) }
def executable_path?(path)
path.elf? || path.text_executable?
end | true |
Other | Homebrew | brew | 55dc8bbada63593bc5d4a8cdde6509ccd587f438.json | Fix strict typecheck errors. | Library/Homebrew/extend/os/linux/formula_cellar_checks.rb | @@ -2,6 +2,8 @@
# frozen_string_literal: true
module FormulaCellarChecks
+ extend T::Sig
+ sig { params(filename: Pathname).returns(T::Boolean) }
def valid_library_extension?(filename)
generic_valid_library_extension?(filename) || filename.basename.to_s.include?(".so.")
end | true |
Other | Homebrew | brew | 55dc8bbada63593bc5d4a8cdde6509ccd587f438.json | Fix strict typecheck errors. | Library/Homebrew/extend/os/linux/software_spec.rb | @@ -2,6 +2,8 @@
# frozen_string_literal: true
class BottleSpecification
+ extend T::Sig
+ sig { returns(T::Boolean) }
def skip_relocation?
false
end | true |
Other | Homebrew | brew | 55dc8bbada63593bc5d4a8cdde6509ccd587f438.json | Fix strict typecheck errors. | Library/Homebrew/extend/os/linux/utils/analytics.rb | @@ -4,12 +4,15 @@
module Utils
module Analytics
class << self
+ extend T::Sig
+ sig { returns(String) }
def formula_path
return generic_formula_path if Homebrew::EnvConfig.force_homebrew_on_linux?
"formula-linux"
end
+ sig { returns(String) }
def analyt... | true |
Other | Homebrew | brew | 55dc8bbada63593bc5d4a8cdde6509ccd587f438.json | Fix strict typecheck errors. | Library/Homebrew/extend/os/mac/formula_support.rb | @@ -2,6 +2,8 @@
# frozen_string_literal: true
class KegOnlyReason
+ extend T::Sig
+ sig { returns(T::Boolean) }
def applicable?
true
end | true |
Other | Homebrew | brew | 55dc8bbada63593bc5d4a8cdde6509ccd587f438.json | Fix strict typecheck errors. | Library/Homebrew/extend/os/mac/hardware.rb | @@ -2,6 +2,8 @@
# frozen_string_literal: true
module Hardware
+ extend T::Sig
+ sig { params(version: T.nilable(Version)).returns(Symbol) }
def self.oldest_cpu(version = MacOS.version)
if CPU.arch == :arm64
:arm_vortex_tempest | true |
Other | Homebrew | brew | 55dc8bbada63593bc5d4a8cdde6509ccd587f438.json | Fix strict typecheck errors. | Library/Homebrew/extend/os/mac/missing_formula.rb | @@ -8,7 +8,10 @@
module Homebrew
module MissingFormula
+ extend T::Sig
class << self
+ extend T::Sig
+ sig { params(name: String).returns(T.nilable(String)) }
def disallowed_reason(name)
case name.downcase
when "xcode"
@@ -33,12 +36,14 @@ def disallowed_reason(name)
... | true |
Other | Homebrew | brew | 55dc8bbada63593bc5d4a8cdde6509ccd587f438.json | Fix strict typecheck errors. | Library/Homebrew/extend/os/mac/utils/analytics.rb | @@ -4,6 +4,8 @@
module Utils
module Analytics
class << self
+ extend T::Sig
+ sig { returns(String) }
def custom_prefix_label
"non-/usr/local"
end | true |
Other | Homebrew | brew | ffe827ad0e63dfbeed357b50916fe404409176a4.json | Fix upgrading dependents on missing keg
Ensure that we don't try to check for broken linkage in a keg that
doesn't exist. Furthermore, fix the reason we checked for the keg that
doesn't exist by `Formula.clear_cache`.
While here, I noticed that there was other methods of caching at use in
`Formula` so consolidate the... | Library/Homebrew/formula.rb | @@ -1477,21 +1477,10 @@ def self.each(&block)
end
end
- # Clear cache of .racks
- def self.clear_racks_cache
- @racks = nil
- end
-
- # Clear caches of .racks and .installed.
- def self.clear_installed_formulae_cache
- clear_racks_cache
- @installed = nil
- end
-
# An array of all racks curr... | true |
Other | Homebrew | brew | ffe827ad0e63dfbeed357b50916fe404409176a4.json | Fix upgrading dependents on missing keg
Ensure that we don't try to check for broken linkage in a keg that
doesn't exist. Furthermore, fix the reason we checked for the keg that
doesn't exist by `Formula.clear_cache`.
While here, I noticed that there was other methods of caching at use in
`Formula` so consolidate the... | Library/Homebrew/formula_installer.rb | @@ -854,10 +854,11 @@ def build
end
def link(keg)
+ Formula.clear_cache
+
unless link_keg
begin
keg.optlink(verbose: verbose?)
- Formula.clear_cache
rescue Keg::LinkError => e
onoe "Failed to create #{formula.opt_prefix}"
puts "Things that depend on #{form... | true |
Other | Homebrew | brew | ffe827ad0e63dfbeed357b50916fe404409176a4.json | Fix upgrading dependents on missing keg
Ensure that we don't try to check for broken linkage in a keg that
doesn't exist. Furthermore, fix the reason we checked for the keg that
doesn't exist by `Formula.clear_cache`.
While here, I noticed that there was other methods of caching at use in
`Formula` so consolidate the... | Library/Homebrew/tab.rb | @@ -355,7 +355,7 @@ def to_json(options = nil)
def write
# If this is a new installation, the cache of installed formulae
# will no longer be valid.
- Formula.clear_installed_formulae_cache unless tabfile.exist?
+ Formula.clear_cache unless tabfile.exist?
self.class.cache[tabfile] = self
... | true |
Other | Homebrew | brew | ffe827ad0e63dfbeed357b50916fe404409176a4.json | Fix upgrading dependents on missing keg
Ensure that we don't try to check for broken linkage in a keg that
doesn't exist. Furthermore, fix the reason we checked for the keg that
doesn't exist by `Formula.clear_cache`.
While here, I noticed that there was other methods of caching at use in
`Formula` so consolidate the... | Library/Homebrew/test/keg_spec.rb | @@ -36,7 +36,6 @@ def setup_test_keg(name, version)
end
specify "::all" do
- Formula.clear_racks_cache
expect(described_class.all).to eq([keg])
end
| true |
Other | Homebrew | brew | ffe827ad0e63dfbeed357b50916fe404409176a4.json | Fix upgrading dependents on missing keg
Ensure that we don't try to check for broken linkage in a keg that
doesn't exist. Furthermore, fix the reason we checked for the keg that
doesn't exist by `Formula.clear_cache`.
While here, I noticed that there was other methods of caching at use in
`Formula` so consolidate the... | Library/Homebrew/upgrade.rb | @@ -128,6 +128,7 @@ def check_broken_dependents(installed_formulae)
.select do |f|
keg = f.any_installed_keg
next unless keg
+ next unless keg.directory?
LinkageChecker.new(keg, cache_db: db)
.broken_library_linkage?
@@ -186... | true |
Other | Homebrew | brew | 75e2f1a2a9cd3d09aeae7a5fbbae81c1edc2045e.json | sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/simplecov@0.19.0.rbi | @@ -1,7 +0,0 @@
-# DO NOT EDIT MANUALLY
-# This is an autogenerated file for types exported from the `simplecov` gem.
-# Please instead update this file by running `tapioca sync --exclude json`.
-
-# typed: true
-
- | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.