language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 255bd2860a5968484b3891a0e1c822da5643a634.json | remove debug stack | packages/@ember/-internals/glimmer/lib/component-managers/mount.ts | @@ -80,10 +80,6 @@ class MountManager extends AbstractManager<EngineState, EngineDefinitionState>
}
create(environment: Environment, { name }: EngineDefinitionState, args: Arguments) {
- if (DEBUG) {
- environment.debugStack.pushEngine(`engine:${name}`);
- }
-
// TODO
// mount is a runtime ... | true |
Other | emberjs | ember.js | 255bd2860a5968484b3891a0e1c822da5643a634.json | remove debug stack | packages/@ember/-internals/glimmer/lib/component-managers/outlet.ts | @@ -5,7 +5,6 @@ import { assert } from '@ember/debug';
import EngineInstance from '@ember/engine/instance';
import { _instrumentStart } from '@ember/instrumentation';
import { assign } from '@ember/polyfills';
-import { DEBUG } from '@glimmer/env';
import { ComponentCapabilities, Option, Simple } from '@glimmer/int... | true |
Other | emberjs | ember.js | 255bd2860a5968484b3891a0e1c822da5643a634.json | remove debug stack | packages/@ember/-internals/glimmer/lib/component-managers/root.ts | @@ -40,10 +40,6 @@ class RootComponentManager extends CurlyComponentManager {
) {
let component = this.component;
- if (DEBUG) {
- environment.debugStack.push((component as any)._debugContainerKey);
- }
-
let finalizer = _instrumentStart('render.component', initialRenderInstrumentDetails, comp... | true |
Other | emberjs | ember.js | 255bd2860a5968484b3891a0e1c822da5643a634.json | remove debug stack | packages/@ember/-internals/glimmer/lib/environment.ts | @@ -10,7 +10,6 @@ import {
SimpleDynamicAttribute,
} from '@glimmer/runtime';
import { Destroyable, Opaque } from '@glimmer/util';
-import getDebugStack, { DebugStack } from './utils/debug-stack';
import createIterable from './utils/iterable';
import { ConditionalReference, UpdatableReference } from './utils/ref... | true |
Other | emberjs | ember.js | 255bd2860a5968484b3891a0e1c822da5643a634.json | remove debug stack | packages/@ember/-internals/glimmer/lib/utils/debug-stack.ts | @@ -1,75 +0,0 @@
-// @ts-check
-
-import { DEBUG } from '@glimmer/env';
-
-export interface DebugStack {
- push(name: string): void;
- pushEngine(name: string): void;
- pop(): string | void;
- peek(): string | void;
-}
-
-let getDebugStack: () => DebugStack = () => {
- throw new Error("Can't access the DebugStack ... | true |
Other | emberjs | ember.js | 255bd2860a5968484b3891a0e1c822da5643a634.json | remove debug stack | packages/@ember/-internals/glimmer/lib/utils/references.ts | @@ -136,6 +136,9 @@ export class RootPropertyReference extends PropertyReference
super();
if (DEBUG) {
+ // Capture the stack when this reference is created, as that is the
+ // component/context that the component was created _in_. Later, it could
+ // be accessed from any number of componen... | true |
Other | emberjs | ember.js | 255bd2860a5968484b3891a0e1c822da5643a634.json | remove debug stack | packages/@ember/-internals/glimmer/tests/unit/utils/debug-stack-test.js | @@ -1,39 +0,0 @@
-import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
-
-import { getDebugStack } from '@ember/-internals/glimmer';
-import { DEBUG } from '@glimmer/env';
-
-moduleFor(
- 'Glimmer DebugStack',
- class extends AbstractTestCase {
- ['@test pushing and popping'](assert) {
- if (D... | true |
Other | emberjs | ember.js | fbae785fefebc8935e33315e23e76682a42fbd75.json | Add v3.15.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit 7583e14df41a44d8b85487e8862a8016c8e1563e) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.15.0-beta.3 (November 18, 2019)
+
+- [#18549](https://github.com/emberjs/ember.js/pull/18549) [BUGFIX] Add component reference to the mouse event handler deprecation warnings
+
### v3.15.0-beta.2 (November 11, 2019)
- [#18539](https://github.com/emberjs/ember.js/pull/185... | false |
Other | emberjs | ember.js | e7b2c13be897e3af9df4af7aa7885b9d0529d465.json | Correct version number.
Co-Authored-By: Robert Jackson <me@rwjblue.com> | packages/@ember/deprecated-features/index.ts | @@ -16,4 +16,4 @@ export const FUNCTION_PROTOTYPE_EXTENSIONS = !!'3.11.0-beta.1';
export const MOUSE_ENTER_LEAVE_MOVE_EVENTS = !!'3.13.0-beta.1';
export const EMBER_COMPONENT_IS_VISIBLE = !!'3.15.0-beta.1';
export const PARTIALS = !!'3.15.0-beta.1';
-export const GLOBALS_RESOLVER = !!'3.16.0';
+export const GLOBALS_... | false |
Other | emberjs | ember.js | cb39f507fc8ce2dcb840d3e845d90a9a2e677400.json | remove test entries | tests/docs/expected.js | @@ -83,7 +83,6 @@ module.exports = {
'appendTo',
'application',
'apply',
- 'args',
'ariaRole',
'arrangedContent',
'array',
@@ -136,7 +135,6 @@ module.exports = {
'computed',
'concat',
'concatenatedProperties',
- 'constructor',
'container',
'containerDebugAdap... | false |
Other | emberjs | ember.js | c7e5fdbc6cbfeb04de12b88f833aed4719330502.json | CHANGELOG: Fix broken link syntax | CHANGELOG.md | @@ -16,7 +16,7 @@
### v3.14.0 (October 29, 2019)
-- [#18345](https://github.com/emberjs/ember.js/pull/18345) / [#18363](https://github.com/emberjs/ember.js/pull/18363) [FEATURE] Implement the [Provide @model named argument to route templates](https://github.com/emberjs/rfcs/blob/master/text/0523-model-argument-for... | false |
Other | emberjs | ember.js | 05adb58132238ddf73149f35bbb4a93c53be943a.json | remove unreachable code (#18483)
remove unreachable code | packages/@ember/-internals/glimmer/lib/utils/references.ts | @@ -37,7 +37,7 @@ import {
PrimitiveReference,
UNDEFINED_REFERENCE,
} from '@glimmer/runtime';
-import { Option, unreachable } from '@glimmer/util';
+import { Option } from '@glimmer/util';
import { HelperFunction, HelperInstance, RECOMPUTE_TAG } from '../helper';
import emberToBool from './to-bool';
@@ -505... | false |
Other | emberjs | ember.js | 7cf8f50e11cbd1c2e975e9f77bb84847511fd314.json | Add v3.15.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit d17a783a504536e24736b9cc9ee7973bbc60687c) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.15.0-beta.2 (November 11, 2019)
+
+- [#18539](https://github.com/emberjs/ember.js/pull/18539) [BUGFIX] Add ID to `CapturedRenderNode`
+
### v3.15.0-beta.1 (October 31, 2019)
- [#17948](https://github.com/emberjs/ember.js/pull/17948) [DEPRECATION] Deprecate `Component#isV... | false |
Other | emberjs | ember.js | 1a1c1e703f65454c5626dfe0902129fdd6ff7646.json | Add v3.15.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit 197e21530bdd2864c8e4e9b08996bd9dc4a50982) | CHANGELOG.md | @@ -1,5 +1,11 @@
# Ember Changelog
+### v3.15.0-beta.1 (October 31, 2019)
+
+- [#17948](https://github.com/emberjs/ember.js/pull/17948) [DEPRECATION] Deprecate `Component#isVisible` per [RFC #324](https://github.com/emberjs/rfcs/blob/master/text/0324-deprecate-component-isvisible.md).
+- [#18491](https://github.com/... | false |
Other | emberjs | ember.js | 7e22ae3ced97db1b37596d40ca25f2f26fd61042.json | Apply suggestions from code review
Co-Authored-By: Ricardo Mendes <rokusu@gmail.com> | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -664,15 +664,19 @@ const ArrayMixin = Mixin.create(Enumerable, {
let foods = [
{ name: 'apple', eaten: false },
{ name: 'banana', eaten: false },
- { name: carrot': eaten: false }
+ { name: 'carrot', eaten: false }
];
foods.forEach((food) => food.eaten = true);
let out... | false |
Other | emberjs | ember.js | b8ebef5d0a14f1f4a67436e6a46699266e81c635.json | Add v3.14.1 to CHANGELOG.md
[ci skip] | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.14.1 (October 30, 2019)
+
+- [#18244](https://github.com/emberjs/ember.js/pull/18244) [BUGFIX] Fix query param assertion when using the router services `transitionTo` to redirect _during_ an existing transition.
+
### v3.14.0 (October 29, 2019)
- [#18345](https://github.... | false |
Other | emberjs | ember.js | 1ffa71d499e4a5dce7370304accae473936695c1.json | Add v3.14.0 to CHANGELOG
[ci skip]
(cherry picked from commit a1d8e395b0b0879c0983d3da9f3b7721b9883c32) | CHANGELOG.md | @@ -1,29 +1,12 @@
# Ember Changelog
-### v3.14.0-beta.5 (October 14, 2019)
+### v3.14.0 (October 29, 2019)
-- [#18476](https://github.com/emberjs/ember.js/pull/18476) [BUGFIX] Ensure model can be observed by sync observers
+- [#18345](https://github.com/emberjs/ember.js/pull/18345) / [#18363](https://github.com/em... | false |
Other | emberjs | ember.js | 93b2e873acd01347b5f792e233d6417a2670003d.json | Add v3.13.4 to CHANGELOG
[ci skip]
(cherry picked from commit 4d02f86ab30c94c4d4c9b2ae15663214865ff134) | CHANGELOG.md | @@ -27,6 +27,12 @@
- [#18381](https://github.com/emberjs/ember.js/pull/18381) Drop Node 6 and 11 support.
- [#18410](https://github.com/emberjs/ember.js/pull/18410) Use ember-cli-htmlbars for inline precompilation if possible.
+### v3.13.4 (October 29,2019)
+
+- [#18476](https://github.com/emberjs/ember.js/pull/184... | false |
Other | emberjs | ember.js | 2b158170a20d0ca6c8d26c2a54ff50c00747388a.json | Apply suggestions from code review
Co-Authored-By: Ricardo Mendes <rokusu@gmail.com> | packages/@ember/-internals/owner/index.ts | @@ -52,15 +52,15 @@ export const OWNER = symbol('OWNER');
into the owner.
For example, this component dynamically looks up a service based on the
- `audioType` passed as an attribute:
+ `audioType` passed as an argument:
```app/components/play-audio.js
import Component from '@glimmer/component';
im... | false |
Other | emberjs | ember.js | bc31e34d9c492941ba369b2424df419cf98b3a4c.json | add code example for EmberArray isAny | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -1123,6 +1123,18 @@ const ArrayMixin = Mixin.create(Enumerable, {
argument for any item in the array. This method is often simpler/faster
than using a callback.
+ Example usage:
+
+ ```javascript
+ const food = [
+ { food: 'apple', isFruit: true},
+ { food: 'bread', isFruit: false },
+... | false |
Other | emberjs | ember.js | ed2fe07eac1f94efd5e849233ceeeba95776c9b3.json | fix return value in reject code example | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -863,7 +863,7 @@ const ArrayMixin = Mixin.create(Enumerable, {
];
const nonFruits = food.reject(function(thing) {
return thing.isFruit;
- }); // [{food: 'beans', isFruit: false}]
+ }); // [{food: 'bread', isFruit: false}]
```
@method reject | false |
Other | emberjs | ember.js | 016b00eeea1693eee35f7922858ea53d9a6fb0fa.json | fix glimmer tracking example | packages/@ember/-internals/glimmer/lib/glimmer-tracking-docs.ts | @@ -23,12 +23,7 @@ a component's properties are expected to be static,
meaning you are not able to update them and have the template update
accordingly. Marking a property as tracked means that when that
property changes, a rerender of the component is scheduled so the
-template is kept up to date.
-
-@method track... | false |
Other | emberjs | ember.js | 474d0498abd607b017eb7dc36b3417ab37e28b6e.json | fix package namespace | packages/@ember/-internals/glimmer/lib/glimmer-tracking-docs.ts | @@ -7,7 +7,7 @@ Trackable values are values that:
We can do this by marking the field with the @tracked decorator.
-@module @glimmer/component
+@module @glimmer/tracking
@public
*/
| false |
Other | emberjs | ember.js | 2642328a70d580a54f6d94d15d1ef3704fc794bb.json | Add docs for @glimmer/tracking | packages/@ember/-internals/glimmer/lib/glimmer-tracking-docs.ts | @@ -0,0 +1,47 @@
+/**
+In order to tell Ember a value might change, we need to mark it as trackable.
+Trackable values are values that:
+
+- Can change over their component’s lifetime and
+- Should cause Ember to rerender if and when they change
+
+We can do this by marking the field with the @tracked decorator.
+
+@mo... | false |
Other | emberjs | ember.js | 1f3da9312c2febcc7fca6a3aa3a7420955d4c2ab.json | Add example for constructor | packages/@ember/-internals/glimmer/lib/glimmer-component-docs.ts | @@ -40,6 +40,19 @@ Constructs a new component and assigns itself the passed properties.
@static
@for @glimmer/component
@public
+
+```javascript
+import Component from '@glimmer/component';
+
+export default class SomeComponent extends Component {
+ constructor(owner, args) {
+ super(...arguments);
+ if (this... | false |
Other | emberjs | ember.js | 73f6fa9a2b2ed7d808cacfdd769835fd987f565f.json | Correct the type of `test` for `assert`
Fixes #18516. | packages/@ember/debug/index.ts | @@ -157,7 +157,7 @@ if (DEBUG) {
@for @ember/debug
@param {String} description Describes the expectation. This will become the
text of the Error thrown if the assertion fails.
- @param {Boolean} condition Must be truthy for the assertion to pass. If
+ @param {any} condition Must be truthy for the... | false |
Other | emberjs | ember.js | 5dc7e606de27ad38440b685f733bf71f77e2705c.json | Fix the module names | packages/@ember/-internals/glimmer/lib/glimmer-component-docs.ts | @@ -24,7 +24,7 @@ export default class SomeComponent extends Component {
}
```
-@module @glimmer/something
+@module @glimmer/component
@public
*/
@@ -38,7 +38,7 @@ export default class SomeComponent extends Component {
Constructs a new component and assigns itself the passed properties.
@method constructor
@... | false |
Other | emberjs | ember.js | 5d2269fd34cf646bae4224d8a977e169625055e2.json | add glimmer namespace, not working | packages/@ember/-internals/glimmer/lib/glimmer-component-docs.ts | @@ -24,7 +24,7 @@ export default class SomeComponent extends Component {
}
```
-@module @ember/something
+@module @glimmer/something
@public
*/
@@ -38,7 +38,7 @@ export default class SomeComponent extends Component {
Constructs a new component and assigns itself the passed properties.
@method constructor
@st... | false |
Other | emberjs | ember.js | 8955e1c994ef9def71586335513a78a8697d444e.json | Add static to functions | packages/@ember/-internals/glimmer/lib/glimmer-component-docs.ts | @@ -46,6 +46,7 @@ Constructs a new component and assigns itself the passed properties.
`didInsertElement` is called when the component has been inserted into the DOM.
Override this function to do any set up that requires an element in the document body.
@method didInsertElement
+@static
@for @ember/something
@publ... | false |
Other | emberjs | ember.js | b873c7ff3b6f7286d3505ffc783018809b25656f.json | use testing name | packages/@ember/-internals/glimmer/lib/glimmer-component-docs.ts | @@ -24,7 +24,7 @@ export default class SomeComponent extends Component {
}
```
-@module @glimmer/component
+@module @ember/something
@public
*/
@@ -37,26 +37,30 @@ export default class SomeComponent extends Component {
/**
Constructs a new component and assigns itself the passed properties.
@method construct... | false |
Other | emberjs | ember.js | 568fdeb1be4666bc51acc9bee074af402b84632c.json | Add example for EmberArray#isEvery | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -1041,6 +1041,29 @@ const ArrayMixin = Mixin.create(Enumerable, {
Note that like the native `Array.every`, `isEvery` will return true when called
on any empty array.
+ ```javascript
+ class Language {
+ constructor(name, isProgrammingLanguage) {
+ this.name = name;
+ this.program... | false |
Other | emberjs | ember.js | fe400156e6ece41739e6dfbb6992fd35b3179a1d.json | Update EmberArray invoke docs to use native class | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -1183,14 +1183,19 @@ const ArrayMixin = Mixin.create(Enumerable, {
Prototype 1.6.
```javascript
- const Person = EmberObject.extend({
- name: null,
+ class Person {
+ name = null;
+
+ constructor(name) {
+ this.name = name;
+ }
+
greet(prefix='Hello') {
re... | false |
Other | emberjs | ember.js | c20639593b23463cb5ca48446335bd4eb80045da.json | add code example for EmberArray reject | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -278,7 +278,7 @@ const ArrayMixin = Mixin.create(Enumerable, {
```javascript
let peopleToMoon = ['Armstrong', 'Aldrin'];
-
+
peopleToMoon.get('[]'); // ['Armstrong', 'Aldrin']
peopleToMoon.set('[]', ['Collins']); // ['Collins']
@@ -311,7 +311,7 @@ const ArrayMixin = Mixin.create(Enumerabl... | false |
Other | emberjs | ember.js | acc2e37274dc398fe38713fe27b3fa97fcddece9.json | Add v3.14.0-beta.5 to CHANGELOG
[ci skip]
(cherry picked from commit 7e28edc17abc3db47da6ab72ed198e89fc4fbe2c) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v3.14.0-beta.5 (October 14, 2019)
+
+- [#18476](https://github.com/emberjs/ember.js/pull/18476) [BUGFIX] Ensure model can be observed by sync observers
+- [#18458](https://github.com/emberjs/ember.js/pull/18458) [BUGFIX] Using query params helper outside of link-to
+
### v3.1... | false |
Other | emberjs | ember.js | 05594308c5684408961e389cfbc1e1749b340152.json | remove unreachable code | packages/@ember/-internals/glimmer/lib/utils/references.ts | @@ -37,7 +37,7 @@ import {
PrimitiveReference,
UNDEFINED_REFERENCE,
} from '@glimmer/runtime';
-import { Option, unreachable } from '@glimmer/util';
+import { Option } from '@glimmer/util';
import { HelperFunction, HelperInstance, RECOMPUTE_TAG } from '../helper';
import emberToBool from './to-bool';
@@ -505... | false |
Other | emberjs | ember.js | 72553a0a51b24b392d5619d445cc3f1c3bab1448.json | Add v3.14.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 369235c286326e4db11b7eee81d6a5c12cefa25b) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.14.0-beta.4 (October 7, 2019)
+
+- [#18462](https://github.com/emberjs/ember.js/pull/18462) [BUGFIX] Prevents observer re-entry
+
### v3.14.0-beta.3 (October 1, 2019)
- [#18429](https://github.com/emberjs/ember.js/pull/18429) [BUGFIX] Fix incorrect error message for octa... | false |
Other | emberjs | ember.js | f2412282271df9b94cff63be9853ebdec047c8f9.json | #18228 update forEach example to include side effects | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -661,10 +661,18 @@ const ArrayMixin = Mixin.create(Enumerable, {
Example Usage:
```javascript
- let foods = ['apple', 'banana', carrot'];
+ let foods = [
+ { name: 'apple', eaten: false },
+ { name: 'banana', eaten: false },
+ { name: carrot': eaten: false }
+ ];
+
+ foods.fo... | false |
Other | emberjs | ember.js | 076ffe9ecdfc800f26e46ddab05b01604f312384.json | #18228 Update documentation for EmberArray.includes | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -1225,20 +1225,25 @@ const ArrayMixin = Mixin.create(Enumerable, {
},
/**
- Returns `true` if the passed object can be found in the array.
+ Used to determine if the array contains the passed object.
+ Returns `true` if found, `false` otherwise.
+
+ The optional `startAt` argument can be used to ... | false |
Other | emberjs | ember.js | 11126b705eda0d4369a3de5ae8613ef86197f37a.json | #18228 Add example to EmberArray.forEach documentation | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -658,6 +658,15 @@ const ArrayMixin = Mixin.create(Enumerable, {
object that will be set as `this` on the context. This is a good way
to give your iterator function access to the current object.
+ Example Usage:
+
+ ```javascript
+ let foods = ['apple', 'banana', carrot'];
+
+ foods.forEac... | false |
Other | emberjs | ember.js | 8c567f53acf0921dfcf73c4f34e44214ba46f98a.json | tests: Add failing test for QP helper with let
Using (query-params) helper outside of a link-to is incorrectly failing | packages/@ember/-internals/glimmer/tests/integration/components/link-to/query-params-curly-test.js | @@ -76,13 +76,16 @@ moduleFor(
this.addTemplate(
'index',
- `{{#let (query-params foo='456' bar='NAW') as |qp|}}{{link-to 'Index' 'index' qp}}{{/let}}`
+ `{{#let (query-params foo='456' alon='BUKAI') as |qp|}}{{link-to 'Index' 'index' qp}}{{/let}}`
);
- return assert.reject... | false |
Other | emberjs | ember.js | bc435eb0a11868f7e0f8381f9a4bb2ba7728d9e8.json | Add v3.13.2 to CHANGELOG.
(cherry picked from commit 17838f0779f54659b838e020c87efdfa979d2664) | CHANGELOG.md | @@ -18,6 +18,10 @@
- [#18381](https://github.com/emberjs/ember.js/pull/18381) Drop Node 6 and 11 support.
- [#18410](https://github.com/emberjs/ember.js/pull/18410) Use ember-cli-htmlbars for inline precompilation if possible.
+### v3.13.2 (September 25, 2019)
+
+- [#18429](https://github.com/emberjs/ember.js/pull/... | false |
Other | emberjs | ember.js | 1db41748d5563538add872084d8ebedd2eb420e2.json | Add v3.14.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit 2f15e4a80580ed1552175687cccae70bbba44ec6) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.14.0-beta.3 (October 1, 2019)
+
+- [#18429](https://github.com/emberjs/ember.js/pull/18429) [BUGFIX] Fix incorrect error message for octane features.
+
### v3.14.0-beta.2 (September 24, 2019)
- [#18273](https://github.com/emberjs/ember.js/pull/18273) [BUGFIX] Fix issues ... | false |
Other | emberjs | ember.js | f6f9f5210754155c8d081a65d78f37a561d928f7.json | improve fn & on undefined callback message | packages/@ember/-internals/glimmer/lib/helpers/fn.ts | @@ -86,8 +86,9 @@ function fnHelper({ positional }: ICapturedArguments) {
if (DEBUG && typeof callbackRef[INVOKE] !== 'function') {
let callback = callbackRef.value();
+ const debug = (<any>callbackRef).debug && (<any>callbackRef).debug();
assert(
- `You must pass a function as the \`fn\` helpers... | true |
Other | emberjs | ember.js | f6f9f5210754155c8d081a65d78f37a561d928f7.json | improve fn & on undefined callback message | packages/@ember/-internals/glimmer/lib/modifiers/on.ts | @@ -101,11 +101,15 @@ export class OnModifierState {
this.eventName = eventName;
this.shouldUpdate = true;
}
+ if (DEBUG) {
+ const debug = args.positional.at(1) && (<any>args.positional.at(1)).debug();
+ const value = args.positional.at(1) && args.positional.at(1).value();
+ assert... | true |
Other | emberjs | ember.js | f6f9f5210754155c8d081a65d78f37a561d928f7.json | improve fn & on undefined callback message | packages/@ember/-internals/glimmer/tests/integration/helpers/fn-test.js | @@ -127,7 +127,7 @@ moduleFor(
arg1: 'foo',
arg2: 'bar',
});
- }, /You must pass a function as the `fn` helpers first argument, you passed null/);
+ }, /You must pass a function as the `fn` helpers first argument, you passed this.myFunc to `fn` but it was null/);
}
'... | true |
Other | emberjs | ember.js | 1b9349622c4c96f909e22d07474f79ebf1848084.json | Add v3.14.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit da9520671790fd6cf14304647c9fb9803a1b6f4b) | CHANGELOG.md | @@ -1,5 +1,11 @@
# Ember Changelog
+### v3.14.0-beta.2 (September 24, 2019)
+
+- [#18273](https://github.com/emberjs/ember.js/pull/18273) [BUGFIX] Fix issues with SSR rehydration of <title>.
+- [#18415](https://github.com/emberjs/ember.js/pull/18415) [BUGFIX] Fix hbs import path in test blueprint.
+- [#18418](https:... | false |
Other | emberjs | ember.js | af661414bf9ee5e8ac5565e15a280e330ce69510.json | Add v3.13.1 to CHANGELOG.md.
[ci skip]
(cherry picked from commit d9df4ed57260de3f5e30d47286b012764177d793) | CHANGELOG.md | @@ -8,6 +8,11 @@
- [#18381](https://github.com/emberjs/ember.js/pull/18381) Drop Node 6 and 11 support.
- [#18410](https://github.com/emberjs/ember.js/pull/18410) Use ember-cli-htmlbars for inline precompilation if possible.
+### v3.13.1 (September 23, 2019)
+
+- [#18273](https://github.com/emberjs/ember.js/pull/18... | false |
Other | emberjs | ember.js | 6a7e8f536f9f1bafc40db008f2eb7dd72f340b35.json | Add v3.14.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit c5705c71067a443b80cc5a3f7161429c0a40a586) | CHANGELOG.md | @@ -1,5 +1,13 @@
# Ember Changelog
+### v3.14.0-beta.1 (September 19, 2019)
+
+- [#18345](https://github.com/emberjs/ember.js/pull/18345) / [#18363](https://github.com/emberjs/ember.js/pull/18363) [FEATURE] Implement the [Provide @model named argument to route templates](https://github.com/emberjs/rfcs/blob/master/t... | false |
Other | emberjs | ember.js | eb4c26fa6f473dd813797a2ae3f3381725d300c6.json | Add v3.13.0 to CHANGELOG
[ci skip]
(cherry picked from commit d96d88ddc1f5b6f7f9dd734890268370cd35f0f6) | CHANGELOG.md | @@ -1,38 +1,28 @@
# Ember Changelog
-### v3.13.0-beta.5 (September 3, 2019)
-
+### v3.13.0 (September 19, 2019)
+
+- [#16366](https://github.com/emberjs/ember.js/pull/16366) / [#16903](https://github.com/emberjs/ember.js/pull/16903) / [#17572](https://github.com/emberjs/ember.js/pull/17572) / [#17682](https://github... | false |
Other | emberjs | ember.js | 4427edd2db29b4fda0a246ac695315f10e23f0eb.json | Remove MU support in component blueprints | blueprints/component-test/index.js | @@ -6,7 +6,6 @@ const isPackageMissing = require('ember-cli-is-package-missing');
const getPathOption = require('ember-cli-get-component-path-option');
const useTestFrameworkDetector = require('../test-framework-detector');
-const isModuleUnificationProject = require('../module-unification').isModuleUnificationProj... | true |
Other | emberjs | ember.js | 4427edd2db29b4fda0a246ac695315f10e23f0eb.json | Remove MU support in component blueprints | blueprints/component/index.js | @@ -6,7 +6,6 @@ const stringUtil = require('ember-cli-string-utils');
const pathUtil = require('ember-cli-path-utils');
const getPathOption = require('ember-cli-get-component-path-option');
const normalizeEntityName = require('ember-cli-normalize-entity-name');
-const { isModuleUnificationProject } = require('../mod... | true |
Other | emberjs | ember.js | 4427edd2db29b4fda0a246ac695315f10e23f0eb.json | Remove MU support in component blueprints | node-tests/blueprints/component-test-test.js | @@ -5,20 +5,15 @@ const fs = require('fs-extra');
const blueprintHelpers = require('ember-cli-blueprint-test-helpers/helpers');
const setupTestHooks = blueprintHelpers.setupTestHooks;
const emberNew = blueprintHelpers.emberNew;
-const emberGenerate = blueprintHelpers.emberGenerate;
const emberGenerateDestroy = blue... | true |
Other | emberjs | ember.js | 4427edd2db29b4fda0a246ac695315f10e23f0eb.json | Remove MU support in component blueprints | node-tests/blueprints/component-test.js | @@ -15,7 +15,6 @@ const generateFakePackageManifest = require('../helpers/generate-fake-package-ma
const fixture = require('../helpers/fixture');
const setupTestEnvironment = require('../helpers/setup-test-environment');
-const enableModuleUnification = setupTestEnvironment.enableModuleUnification;
const enableOct... | true |
Other | emberjs | ember.js | c2ca5e80e969f4e04a2f6044a3b87cd171cec7a2.json | add async to Observable methods | packages/@ember/-internals/runtime/lib/mixins/observable.js | @@ -294,7 +294,7 @@ export default Mixin.create({
observer should be prepared to handle that.
There are two common invocation patterns for `.addObserver()`:
-
+
- Passing two arguments:
- the name of the property to observe (as a string)
- the function to invoke (an actual function)
@... | false |
Other | emberjs | ember.js | 492ad6ac9ef0dc03d3950a866bb067698eeb3f30.json | remove unused feature flag | packages/@ember/canary-features/index.ts | @@ -72,9 +72,6 @@ export const EMBER_LIBRARIES_ISREGISTERED = featureValue(FEATURES.EMBER_LIBRARIE
export const EMBER_IMPROVED_INSTRUMENTATION = featureValue(FEATURES.EMBER_IMPROVED_INSTRUMENTATION);
export const EMBER_MODULE_UNIFICATION = featureValue(FEATURES.EMBER_MODULE_UNIFICATION);
export const EMBER_METAL_TRA... | false |
Other | emberjs | ember.js | 7ae73e69fcf9c0a5ae18bc25f98460f0c5270bca.json | Add v3.13.0-beta.5 to CHANGELOG
[ci skip]
(cherry picked from commit 4b25250940989b7858e4b9ba3cbb94538a7c7f38) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v3.13.0-beta.5 (September 3, 2019)
+
+- [#18314](https://github.com/emberjs/ember.js/pull/18314) [BUGFIX] Use class inheritance for getters and setters
+- [#18329](https://github.com/emberjs/ember.js/pull/18329) [BUGFIX] Eagerly consume aliases
+
### v3.13.0-beta.4 (August 26... | false |
Other | emberjs | ember.js | 59d21e4d9869b040474a0df879a37564cc4911f8.json | Add a few targeted tests
This ensures `{{this.model}}` and the implicit `{{model}}` contunue
to be tested, to prevent any future regressions. It also tests the
behavior described in the RFC where `this.model` and `@model` could
diverge. | packages/@ember/-internals/glimmer/tests/integration/application/rendering-test.js | @@ -4,6 +4,8 @@ import { ENV } from '@ember/-internals/environment';
import Controller from '@ember/controller';
import { Route } from '@ember/-internals/routing';
import { Component } from '@ember/-internals/glimmer';
+import { set, tracked } from '@ember/-internals/metal';
+import { runTask } from '../../../../../... | true |
Other | emberjs | ember.js | 59d21e4d9869b040474a0df879a37564cc4911f8.json | Add a few targeted tests
This ensures `{{this.model}}` and the implicit `{{model}}` contunue
to be tested, to prevent any future regressions. It also tests the
behavior described in the RFC where `this.model` and `@model` could
diverge. | packages/ember/tests/routing/decoupled_basic_test.js | @@ -75,10 +75,6 @@ moduleFor(
return currentPath;
}
- get currentURL() {
- return this.appRouter.get('currentURL');
- }
-
handleURLRejectsWith(context, assert, path, expectedReason) {
return context
.visit(path) | true |
Other | emberjs | ember.js | 59d21e4d9869b040474a0df879a37564cc4911f8.json | Add a few targeted tests
This ensures `{{this.model}}` and the implicit `{{model}}` contunue
to be tested, to prevent any future regressions. It also tests the
behavior described in the RFC where `this.model` and `@model` could
diverge. | packages/internal-test-helpers/lib/module-for.js | @@ -79,7 +79,7 @@ export function setupTestClass(hooks, TestClass, ...mixins) {
return this.instance[name](assert);
});
} else {
- let match = /^@feature\(([A-Z_a-z-!]+)\) /.exec(name);
+ let match = /^@feature\(([A-Z_a-z-! ,]+)\) /.exec(name);
if (match) {
let features ... | true |
Other | emberjs | ember.js | 59d21e4d9869b040474a0df879a37564cc4911f8.json | Add a few targeted tests
This ensures `{{this.model}}` and the implicit `{{model}}` contunue
to be tested, to prevent any future regressions. It also tests the
behavior described in the RFC where `this.model` and `@model` could
diverge. | packages/internal-test-helpers/lib/test-cases/application.js | @@ -33,9 +33,16 @@ export default class ApplicationTestCase extends TestResolverApplicationTestCase
return this.applicationInstance.lookup('router:main');
}
+ get currentURL() {
+ return this.appRouter.get('currentURL');
+ }
+
async transitionTo() {
await this.appRouter.transitionTo(...arguments)... | true |
Other | emberjs | ember.js | 2522a99d539119b6307dcc712f549649b7a4814e.json | fix code fence | packages/@ember/-internals/routing/lib/services/router.ts | @@ -197,6 +197,7 @@ export default class RouterService extends Service {
}
}
}
+ ```
Just like with `transitionTo` and `replaceWith`, `urlFor` can also handle
query parameters. | false |
Other | emberjs | ember.js | 9f6bece75648d11222c54b828c18b47477bcdb1a.json | Update documentation for EmberArray.find
Add code examples for `EmberArray.find` method.
Issue #18228 | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -778,6 +778,20 @@ const ArrayMixin = Mixin.create(Enumerable, {
Note that in addition to a callback, you can also pass an optional target
object that will be set as `this` on the context. This is a good way
to give your iterator function access to the current object.
+
+ Example Usage:
+
+ `... | false |
Other | emberjs | ember.js | 92dcebf8ccea4f2ff53d4138b5a8b3c935e9b503.json | Add v3.13.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 29d67b93df69cb57a94e16c0d9c082ba363fae16) | CHANGELOG.md | @@ -1,5 +1,12 @@
# Ember Changelog
+### v3.13.0-beta.4 (August 26, 2019)
+
+- [#18278](https://github.com/emberjs/ember.js/pull/18278) [BUGFIX] Bump ember-router-generator from v1.2.3 to v2.0.0 to support parsing `app/router.js` with native class.
+- [#18291](https://github.com/emberjs/ember.js/pull/18291) [BUGFIX] ... | false |
Other | emberjs | ember.js | 86c1a48a735bab9a0130ee4463efa40a9d118634.json | Add v3.13.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit f4650a010f532e7d8c4f95bfdc7ab009f274bc25) | CHANGELOG.md | @@ -1,5 +1,16 @@
# Ember Changelog
+### v3.13.0-beta.3 (August 19, 2019)
+
+- [#18223](https://github.com/emberjs/ember.js/pull/18223) [FEATURE] Tracked Props Performance Tuning
+- [#18208](https://github.com/emberjs/ember.js/pull/18208) [BUGFIX] Compile Ember dynamically in consuming applications
+- [#18266](https:... | false |
Other | emberjs | ember.js | 1d6bff0d18670e7655b65d80eb4938430aa467b0.json | Update documentation for EmberArray.findBy | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -790,6 +790,21 @@ const ArrayMixin = Mixin.create(Enumerable, {
This method works much like the more generic `find()` method.
+ Usage Example:
+
+ ```javascript
+ let users = [
+ { id: 1, name: 'Yehuda', isTom: false },
+ { id: 2, name: 'Tom', isTom: true },
+ { id: 3, name: 'Melanie... | false |
Other | emberjs | ember.js | 1787f810d530e2707f68526f192668fbec873ce5.json | Add code example for EmberArray.filter | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -637,12 +637,10 @@ const ArrayMixin = Mixin.create(Enumerable, {
mapBy,
/**
- Returns an array with all of the items in the enumeration that the passed
- function returns true for. This method corresponds to `filter()` defined in
- JavaScript 1.6.
+ Returns a new array with all of the items in th... | false |
Other | emberjs | ember.js | f4ba42ab54ef660e62565b05b3556b560b79d72b.json | Add code example for EmberArray.addArrayObserver | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -452,6 +452,29 @@ const ArrayMixin = Mixin.create(Enumerable, {
`willChange` and `didChange` option.
@return {EmberArray} receiver
@public
+ @example
+ import Service from '@ember/service';
+
+ export default Service.extend({
+ data: Ember.A(),
+
+ init() {
+ ... | false |
Other | emberjs | ember.js | 4ac76231331f444c78ecba99461f9ded016d3a6c.json | Fix typos and simplify EmberArray definition | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -186,10 +186,10 @@ function mapBy(key) {
concrete implementation, but it can be used up by other classes that want
to appear like arrays.
- For example, ArrayProxy is a concrete classes that can
- be instantiated to implement array-like behavior. Both of these classes use
- the Array Mixin by way of the M... | false |
Other | emberjs | ember.js | 786ad9b6f5387a6e818244110b8c8e2377040cb9.json | Write test for _optionsForQueryParam | packages/@ember/-internals/routing/tests/system/route_test.js | @@ -163,6 +163,34 @@ moduleFor(
runDestroy(owner);
}
+ ["@test _optionsForQueryParam should work with nested properties"](assert) {
+ let route = EmberRoute.extend({
+ queryParams: {
+ 'nested.foo': {
+ // By default, controller query param properties don't
+ ... | false |
Other | emberjs | ember.js | bd7f49282a489663cccdb7a2a948a60c62a51f29.json | Add test for 18253 | packages/@ember/-internals/glimmer/tests/integration/components/tracked-test.js | @@ -245,6 +245,10 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
runTask(() => this.$('button').click());
this.assertText('1');
+
+ runTask(() => this.$('button').click());
+
+ this.assertText('2');
}
'@test nested getters update when dependent properties are invalidated'() { | false |
Other | emberjs | ember.js | f4eb13b345afdfea9e0bc041d1aae2426be085e0.json | fix prod tests | packages/@ember/-internals/glimmer/tests/integration/components/link-to/query-params-curly-test.js | @@ -69,17 +69,20 @@ moduleFor(
}
['@test `(query-params)` must be used in conjunction with `{{link-to}}'](assert) {
- if (DEBUG) {
- this.addTemplate(
- 'index',
- `{{#let (query-params foo='456' bar='NAW') as |qp|}}{{link-to 'Index' 'index' qp}}{{/let}}`
- );
-
- ... | true |
Other | emberjs | ember.js | f4eb13b345afdfea9e0bc041d1aae2426be085e0.json | fix prod tests | packages/@ember/-internals/glimmer/tests/integration/components/link-to/routing-angle-test.js | @@ -5,6 +5,7 @@ import { alias } from '@ember/-internals/metal';
import { subscribe, reset } from '@ember/instrumentation';
import { Route, NoneLocation } from '@ember/-internals/routing';
import { EMBER_IMPROVED_INSTRUMENTATION } from '@ember/canary-features';
+import { DEBUG } from '@glimmer/env';
// IE include... | true |
Other | emberjs | ember.js | f4eb13b345afdfea9e0bc041d1aae2426be085e0.json | fix prod tests | packages/@ember/-internals/glimmer/tests/integration/components/link-to/routing-curly-test.js | @@ -5,6 +5,7 @@ import { alias } from '@ember/-internals/metal';
import { subscribe, reset } from '@ember/instrumentation';
import { Route, NoneLocation } from '@ember/-internals/routing';
import { EMBER_IMPROVED_INSTRUMENTATION } from '@ember/canary-features';
+import { DEBUG } from '@glimmer/env';
// IE include... | true |
Other | emberjs | ember.js | 2ee24e149401b3907ea96513a88d1b8516f8835e.json | Update documentation for EmberArray.any
Prior to this change, the wording was inaccurate. It was describing
filtering not the short circuit behaviour of `any()`.
This change attempts to fix that discrepancy and expand on the example
to include both context option and arrow function use.
Issue #18228 | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -860,11 +860,10 @@ const ArrayMixin = Mixin.create(Enumerable, {
},
/**
- Returns `true` if the passed function returns true for any item in the
- enumeration.
-
- The callback method you provide should have the following signature (all
- parameters are optional):
+ The any() method executes t... | false |
Other | emberjs | ember.js | 1cc23ff1beebb252840a163410ee9b9e6c8c6eff.json | Add code example for EmberArray.every | packages/@ember/-internals/runtime/lib/mixins/array.js | @@ -802,10 +802,9 @@ const ArrayMixin = Mixin.create(Enumerable, {
/**
Returns `true` if the passed function returns true for every item in the
- enumeration. This corresponds with the `every()` method in JavaScript 1.6.
+ enumeration. This corresponds with the `Array.prototype.every()` method defined i... | false |
Other | emberjs | ember.js | 2a5e2c7bf99755a0b270f36b8181e0dda3943ccc.json | Add missing runTask | packages/internal-test-helpers/lib/test-cases/abstract-application.js | @@ -18,7 +18,9 @@ export default class AbstractApplicationTestCase extends AbstractTestCase {
async visit(url, options) {
// Create the instance
- let instance = await this._ensureInstance(options).then(instance => instance.visit(url));
+ let instance = await this._ensureInstance(options).then(instance ... | false |
Other | emberjs | ember.js | 1f5eee0f762a808d38ed1c466b5fa013fe0e6688.json | Add v3.13.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit 3e9e51811586f7aa50ced5780e224bb488a262a7) | CHANGELOG.md | @@ -1,5 +1,13 @@
# Ember Changelog
+### v3.13.0-beta.1 (August 6, 2019)
+
+- [#16366](https://github.com/emberjs/ember.js/pull/16366) / [#16903](https://github.com/emberjs/ember.js/pull/16903) / [#17572](https://github.com/emberjs/ember.js/pull/17572) / [#17682](https://github.com/emberjs/ember.js/pull/17682) / [#17... | false |
Other | emberjs | ember.js | 1479f4aa2b101ce94314527fa096eed74cff2126.json | Add v3.12.0 to CHANGELOG
[ci skip]
(cherry picked from commit e374285bc3c1c615bf35db66afc157cd80420790) | CHANGELOG.md | @@ -1,7 +1,9 @@
# Ember Changelog
-# v3.12.0-beta.1 (June 27, 2019)
+### v3.12.0 (August 5, 2019)
+- [#18159](https://github.com/emberjs/ember.js/pull/18159) [BUGFIX] Update router.js to ensure buildRouteInfoMetadata does not eagerly cache routes in lazy Engines
+- [#18226](https://github.com/emberjs/ember.js/pull... | false |
Other | emberjs | ember.js | 77b4bc6c14f603de7d2ff1a8b2d8d5f901a8edd4.json | Avoid assertions for Symbol when not present.
Co-authored-by: Godfrey Chan <godfreykfc@gmail.com> | packages/@ember/-internals/glimmer/tests/integration/components/component-template-test.js | @@ -4,6 +4,7 @@ import {
EMBER_GLIMMER_SET_COMPONENT_TEMPLATE,
EMBER_MODULE_UNIFICATION,
} from '@ember/canary-features';
+import { HAS_NATIVE_SYMBOL } from '@ember/-internals/utils';
import { Component, compile } from '../../utils/helpers';
import { setComponentTemplate, getComponentTemplate } from '../../.... | false |
Other | emberjs | ember.js | c4cdae990ce827d8e143b95c6fcd0331b967c7aa.json | Implement component co-location blueprints (#18203)
Implement component co-location blueprints
Co-authored-by: Robert Jackson <rjackson@linkedin.com> | blueprints/component-addon/native-files/__root__/__templatepath__/__templatename__.js | @@ -1 +0,0 @@
-export { default } from '<%= templatePath %>'; | true |
Other | emberjs | ember.js | c4cdae990ce827d8e143b95c6fcd0331b967c7aa.json | Implement component co-location blueprints (#18203)
Implement component co-location blueprints
Co-authored-by: Robert Jackson <rjackson@linkedin.com> | blueprints/component/files/__root__/__path__/__name__.js | @@ -1,4 +1,3 @@
-import Component from '@ember/component';
+<%= importComponent %>
<%= importTemplate %>
-export default Component.extend({<%= contents %>
-});
+export default <%= defaultExport %> | true |
Other | emberjs | ember.js | c4cdae990ce827d8e143b95c6fcd0331b967c7aa.json | Implement component co-location blueprints (#18203)
Implement component co-location blueprints
Co-authored-by: Robert Jackson <rjackson@linkedin.com> | blueprints/component/index.js | @@ -1,15 +1,25 @@
'use strict';
const path = require('path');
+const SilentError = require('silent-error');
const stringUtil = require('ember-cli-string-utils');
const pathUtil = require('ember-cli-path-utils');
const getPathOption = require('ember-cli-get-component-path-option');
const normalizeEntityName = re... | true |
Other | emberjs | ember.js | c4cdae990ce827d8e143b95c6fcd0331b967c7aa.json | Implement component co-location blueprints (#18203)
Implement component co-location blueprints
Co-authored-by: Robert Jackson <rjackson@linkedin.com> | blueprints/component/native-files/__root__/__path__/__name__.js | @@ -1,4 +0,0 @@
-import Component from '@glimmer/component';
-
-export default class <%= classifiedModuleName %>Component extends Component {
-} | true |
Other | emberjs | ember.js | c4cdae990ce827d8e143b95c6fcd0331b967c7aa.json | Implement component co-location blueprints (#18203)
Implement component co-location blueprints
Co-authored-by: Robert Jackson <rjackson@linkedin.com> | blueprints/component/native-files/__root__/__templatepath__/__templatename__.hbs | @@ -1 +0,0 @@
-{{yield}}
\ No newline at end of file | true |
Other | emberjs | ember.js | c4cdae990ce827d8e143b95c6fcd0331b967c7aa.json | Implement component co-location blueprints (#18203)
Implement component co-location blueprints
Co-authored-by: Robert Jackson <rjackson@linkedin.com> | node-tests/blueprints/component-test.js | @@ -1,5 +1,6 @@
'use strict';
+const fs = require('fs');
const blueprintHelpers = require('ember-cli-blueprint-test-helpers/helpers');
const setupTestHooks = blueprintHelpers.setupTestHooks;
const emberNew = blueprintHelpers.emberNew;
@@ -17,6 +18,25 @@ const setupTestEnvironment = require('../helpers/setup-test-... | true |
Other | emberjs | ember.js | c4cdae990ce827d8e143b95c6fcd0331b967c7aa.json | Implement component co-location blueprints (#18203)
Implement component co-location blueprints
Co-authored-by: Robert Jackson <rjackson@linkedin.com> | package.json | @@ -73,7 +73,8 @@
"ember-router-generator": "^1.2.3",
"inflection": "^1.12.0",
"jquery": "^3.4.1",
- "resolve": "^1.11.1"
+ "resolve": "^1.11.1",
+ "silent-error": "^1.1.1"
},
"devDependencies": {
"@babel/helper-module-imports": "^7.0.0", | true |
Other | emberjs | ember.js | d922666b2d0383e59cdbdaa5af9bb836dbc2390b.json | Fix linting errors | packages/@ember/-internals/glimmer/lib/component.ts | @@ -754,7 +754,7 @@ const Component = CoreView.extend(
id: 'ember-views.event-dispatcher.mouseenter-leave-move',
until: '4.0.0',
url: 'https://emberjs.com/deprecations/v3.x#toc_component-mouseenter-leave-move',
- },
+ }
);
deprecate(
`Using \`mouseLe... | true |
Other | emberjs | ember.js | d922666b2d0383e59cdbdaa5af9bb836dbc2390b.json | Fix linting errors | packages/@ember/-internals/glimmer/lib/modifiers/action.ts | @@ -244,12 +244,14 @@ export default class ActionModifierManager implements ModifierManager<ActionStat
deprecate(
`Using the \`{{action}}\` modifier with \`${actionState.eventName}\` events has been deprecated.`,
- actionState.eventName !== 'mouseEnter' && actionState.eventName !== 'mouseLeave' && ac... | true |
Other | emberjs | ember.js | d922666b2d0383e59cdbdaa5af9bb836dbc2390b.json | Fix linting errors | packages/@ember/-internals/glimmer/tests/integration/event-dispatcher-test.js | @@ -292,7 +292,9 @@ moduleFor(
assert.strictEqual(receivedLeaveEvents[0].target, outer);
}
- ['@test [DEPRECATED] delegated event listeners work for mouseEnter/Leave with skipped events'](assert) {
+ ['@test [DEPRECATED] delegated event listeners work for mouseEnter/Leave with skipped events'](
+ ... | true |
Other | emberjs | ember.js | d922666b2d0383e59cdbdaa5af9bb836dbc2390b.json | Fix linting errors | packages/@ember/-internals/glimmer/tests/integration/helpers/element-action-test.js | @@ -1680,7 +1680,8 @@ moduleFor(
template: '<div id="inner" {{action "show" on="mouseEnter"}}></div>',
});
- expectDeprecation(() => this.render('{{example-component id="outer"}}'),
+ expectDeprecation(
+ () => this.render('{{example-component id="outer"}}'),
'Using the `{{ac... | true |
Other | emberjs | ember.js | d922666b2d0383e59cdbdaa5af9bb836dbc2390b.json | Fix linting errors | packages/@ember/-internals/views/lib/system/event_dispatcher.js | @@ -94,11 +94,14 @@ export default EmberObject.extend({
drop: 'drop',
dragend: 'dragEnd',
},
- MOUSE_ENTER_LEAVE_MOVE_EVENTS ? {
- mouseenter: 'mouseEnter',
- mouseleave: 'mouseLeave',
- mousemove: 'mouseMove',
- } : {}),
+ MOUSE_ENTER_LEAVE_MOVE_EVENTS
+ ? {
+ m... | true |
Other | emberjs | ember.js | 50fb52c6e44668c244473e4b8f977cd0b0573ecc.json | Remove deprecated events from docs | packages/@ember/-internals/glimmer/lib/component.ts | @@ -642,11 +642,8 @@ export const BOUNDS = symbol('BOUNDS');
* `contextMenu`
* `click`
* `doubleClick`
- * `mouseMove`
* `focusIn`
* `focusOut`
- * `mouseEnter`
- * `mouseLeave`
Form events:
| false |
Other | emberjs | ember.js | d3330598f0fec81d6700448daeef8768483d31df.json | Add code example for recognize | packages/@ember/-internals/routing/lib/services/router.ts | @@ -277,6 +277,27 @@ export default class RouterService extends Service {
by the URL. Returns `null` if the URL is not recognized. This method expects to
receive the actual URL as seen by the browser including the app's `rootURL`.
+ See [RouteInfo](/ember/release/classes/RouteInfo) for more info.
+
+ ... | false |
Other | emberjs | ember.js | 1717a2ff363694dc33b58a41c204f41efc591118.json | Correct property name in @union cp example
The example usage of `@union` defines `ediblePlants` but uses `hamster.uniqueFruits` instead.
Change `ediblePlants` to `uniqueFruits`. | packages/@ember/object/lib/computed/reduce_computed_macros.js | @@ -948,7 +948,7 @@ export function uniqBy(dependentKey, propertyKey) {
set(this, 'vegetables', vegetables);
}
- @union('fruits', 'vegetables') ediblePlants;
+ @union('fruits', 'vegetables') uniqueFruits;
});
let hamster = new, Hamster( | false |
Other | emberjs | ember.js | 84ab4ea5a6ce6780f5166efaef648308609b76ee.json | Add code example for replaceWith | packages/@ember/-internals/routing/lib/services/router.ts | @@ -141,6 +141,20 @@ export default class RouterService extends Service {
This behavior is different from calling `replaceWith` on a route.
See the [Router Service RFC](https://github.com/emberjs/rfcs/blob/master/text/0095-router-service.md#query-parameter-semantics) for more info.
+ Usage example:
+
... | false |
Other | emberjs | ember.js | 5e40cbdac4eac70bf0999d94d5cea4f3a46f7de2.json | Add code example for transitionTo | packages/@ember/-internals/routing/lib/services/router.ts | @@ -90,6 +90,24 @@ export default class RouterService extends Service {
This behavior is different from calling `transitionTo` on a route or `transitionToRoute` on a controller.
See the [Router Service RFC](https://github.com/emberjs/rfcs/blob/master/text/0095-router-service.md#query-parameter-semantics) fo... | false |
Other | emberjs | ember.js | 32bac7b4c751f4f5bc774ea05d0a85b8087de7c7.json | Add more tests for inherited listeners. (#18160)
Add more tests for inherited listeners. | packages/@ember/-internals/meta/tests/listeners_test.js | @@ -18,24 +18,52 @@ moduleFor(
}
['@test inheritance'](assert) {
+ let matching;
let target = {};
let parent = {};
let parentMeta = meta(parent);
parentMeta.addToListeners('hello', target, 'm', 0);
- let child = Object.create(parent);
- let m = meta(child);
+ ... | false |
Other | emberjs | ember.js | 1e00da7922598523bbf7af0052d508b8051df275.json | Add v3.8.3 to CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -66,6 +66,12 @@
- [#17874](https://github.com/emberjs/ember.js/pull/17874) [BUGFIX] Fix issue with `event.stopPropagation()` in component event handlers when jQuery is disabled.
- [#17876](https://github.com/emberjs/ember.js/pull/17876) [BUGFIX] Fix issue with multiple `{{action}}` modifiers on the same element wh... | false |
Other | emberjs | ember.js | d97d74ddff1a2407c5012777cfe185f85db0495d.json | Add v3.11.1 to CHANGELOG.
[ci skip] | CHANGELOG.md | @@ -6,6 +6,11 @@
- [#18150](https://github.com/emberjs/ember.js/pull/18150) [BUGFIX] Fix a memory retention issue with string-based event listeners
- [#18124](https://github.com/emberjs/ember.js/pull/18124) [CLEANUP] Remove deprecated `NAME_KEY`
+### v3.11.1 (June 27, 2019)
+
+- [#18159](https://github.com/emberjs/... | false |
Other | emberjs | ember.js | 6a877c80255294821d07c47231c65dc8b336f8cd.json | Add more tests for inherited listeners.
Added a test to confirm that removing from one child does not affect
the other children. This case was not previously covered. | packages/@ember/-internals/meta/tests/listeners_test.js | @@ -18,24 +18,52 @@ moduleFor(
}
['@test inheritance'](assert) {
+ let matching;
let target = {};
let parent = {};
let parentMeta = meta(parent);
parentMeta.addToListeners('hello', target, 'm', 0);
- let child = Object.create(parent);
- let m = meta(child);
+ ... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.