language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | Homebrew | brew | 3a9f585ebbd1893a034575b49f64a200c5385365.json | Move more code to utils/analytics. | Library/Homebrew/extend/os/cmd/info.rb | @@ -1,3 +0,0 @@
-# frozen_string_literal: true
-
-require "extend/os/linux/info" if OS.linux? | true |
Other | Homebrew | brew | 3a9f585ebbd1893a034575b49f64a200c5385365.json | Move more code to utils/analytics. | Library/Homebrew/extend/os/linux/info.rb | @@ -1,17 +0,0 @@
-# frozen_string_literal: true
-
-module Homebrew
- module_function
-
- def formula_path
- return generic_formula_path if ENV["HOMEBREW_FORCE_HOMEBREW_ON_LINUX"]
-
- "formula-linux"
- end
-
- def analytics_path
- return generic_analytics_path if ENV["HOMEBREW_FORCE_HOMEBREW_ON_LINUX"]
-
- ... | true |
Other | Homebrew | brew | 3a9f585ebbd1893a034575b49f64a200c5385365.json | Move more code to utils/analytics. | Library/Homebrew/extend/os/linux/utils/analytics.rb | @@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module Utils
+ module Analytics
+ class << self
+ def formula_path
+ return generic_formula_path if ENV["HOMEBREW_FORCE_HOMEBREW_ON_LINUX"]
+
+ "formula-linux"
+ end
+
+ def analytics_path
+ return generic_analytics_path if ENV["... | true |
Other | Homebrew | brew | 3a9f585ebbd1893a034575b49f64a200c5385365.json | Move more code to utils/analytics. | Library/Homebrew/extend/os/utils/analytics.rb | @@ -1,3 +1,4 @@
# frozen_string_literal: true
+require "extend/os/linux/utils/analytics" if OS.linux?
require "extend/os/mac/utils/analytics" if OS.mac? | true |
Other | Homebrew | brew | 3a9f585ebbd1893a034575b49f64a200c5385365.json | Move more code to utils/analytics. | Library/Homebrew/test/cmd/analytics_spec.rb | @@ -14,7 +14,7 @@
brew "analytics", "off"
expect { brew "analytics", "HOMEBREW_NO_ANALYTICS" => nil }
- .to output(/Analytics is disabled/).to_stdout
+ .to output(/Analytics are disabled/).to_stdout
.and not_to_output.to_stderr
.and be_a_success
end | true |
Other | Homebrew | brew | 3a9f585ebbd1893a034575b49f64a200c5385365.json | Move more code to utils/analytics. | Library/Homebrew/test/cmd/info_spec.rb | @@ -22,13 +22,6 @@
describe Homebrew do
let(:remote) { "https://github.com/Homebrew/homebrew-core" }
- specify "::analytics_table" do
- results = { ack: 10, wget: 100 }
- expect { subject.analytics_table("install", "30", results) }
- .to output(/110 | 100.00%/).to_stdout
- .and not_to_output.to_... | true |
Other | Homebrew | brew | 3a9f585ebbd1893a034575b49f64a200c5385365.json | Move more code to utils/analytics. | Library/Homebrew/test/utils/analytics_spec.rb | @@ -86,4 +86,11 @@
end
end
end
+
+ specify "::table_output" do
+ results = { ack: 10, wget: 100 }
+ expect { described_class.table_output("install", "30", results) }
+ .to output(/110 | 100.00%/).to_stdout
+ .and not_to_output.to_stderr
+ end
end | true |
Other | Homebrew | brew | 3a9f585ebbd1893a034575b49f64a200c5385365.json | Move more code to utils/analytics. | Library/Homebrew/utils/analytics.rb | @@ -5,27 +5,8 @@
module Utils
module Analytics
class << self
- def custom_prefix_label
- "custom-prefix"
- end
-
- def clear_os_prefix_ci
- return unless instance_variable_defined?(:@os_prefix_ci)
-
- remove_instance_variable(:@os_prefix_ci)
- end
-
- def os_prefix... | true |
Other | Homebrew | brew | 727f9671c7a7ef0644b931fda17c1d4467cd4eb6.json | info: show Linux formulae details and analytics
- This makes use of the new /api/formula-linux and /api/analytics-linux
endpoints in formulae.brew.sh to give Linux users up to date formula and
analytics info for their installed core formulae.
Before, on Linux, the macOS stats for the `ack` formula:
```
$ brew in... | Library/Homebrew/cmd/info.rb | @@ -368,7 +368,7 @@ def output_analytics(filter: nil)
end
def output_formula_analytics(f)
- json = formulae_api_json("formula/#{f}.json")
+ json = formulae_api_json("#{formula_path}/#{f}.json")
return if json.blank? || json["analytics"].blank?
full_analytics = args.analytics? || args.verbose?
... | true |
Other | Homebrew | brew | 727f9671c7a7ef0644b931fda17c1d4467cd4eb6.json | info: show Linux formulae details and analytics
- This makes use of the new /api/formula-linux and /api/analytics-linux
endpoints in formulae.brew.sh to give Linux users up to date formula and
analytics info for their installed core formulae.
Before, on Linux, the macOS stats for the `ack` formula:
```
$ brew in... | Library/Homebrew/extend/os/cmd/info.rb | @@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require "extend/os/linux/info" if OS.linux? | true |
Other | Homebrew | brew | 727f9671c7a7ef0644b931fda17c1d4467cd4eb6.json | info: show Linux formulae details and analytics
- This makes use of the new /api/formula-linux and /api/analytics-linux
endpoints in formulae.brew.sh to give Linux users up to date formula and
analytics info for their installed core formulae.
Before, on Linux, the macOS stats for the `ack` formula:
```
$ brew in... | Library/Homebrew/extend/os/linux/info.rb | @@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module Homebrew
+ module_function
+
+ def formula_path
+ return generic_formula_path if ENV["HOMEBREW_FORCE_HOMEBREW_ON_LINUX"]
+
+ "formula-linux"
+ end
+
+ def analytics_path
+ return generic_analytics_path if ENV["HOMEBREW_FORCE_HOMEBREW_ON_LINUX"]
+
+ ... | true |
Other | Homebrew | brew | fbf4b0432d18e48b3b611b135e9b2e177e4e958d.json | Rescue more errors during `cask upgrade`. | Library/Homebrew/cask/cmd/upgrade.rb | @@ -46,7 +46,7 @@ def run
upgradable_casks.each do |(old_cask, new_cask)|
upgrade_cask(old_cask, new_cask)
- rescue CaskError => e
+ rescue => e
caught_exceptions << e
next
end
@@ -103,7 +103,7 @@ def upgrade_cask(old_cask, new_cask)
# If s... | false |
Other | Homebrew | brew | c7f065b8da7a0da65bc5a39a156a6a14eb28f834.json | utils/github.rb: use parallel assignments rather than indices
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com> | Library/Homebrew/utils/github.rb | @@ -341,8 +341,8 @@ def create_fork(repo)
end
def check_fork_exists(repo)
- username = api_credentials[1]
- reponame = repo.split("/")[1]
+ _, username = api_credentials
+ _, reponame = repo.split("/")
json = open_api(url_to("repos", username, reponame))
return false if json["message"] == ... | false |
Other | Homebrew | brew | ba7a05a9194458604d0feaad5c15e2565b61930f.json | bump-formula-pr.rb: Apply suggestions from code review
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com> | Library/Homebrew/dev-cmd/bump-formula-pr.rb | @@ -388,10 +388,10 @@ def forked_repo_info(tap_full_name)
else
# GitHub API responds immediately but fork takes a few seconds to be ready.
sleep 1 until GitHub.check_fork_exists(tap_full_name)
- if system("git", "config", "--local", "--get-regexp", "remote\..*\.url", "git@github.com:.*")
- remote_u... | false |
Other | Homebrew | brew | b4ff330ac1dc9d6ee60fdbcd1b3e0542c7416457.json | shims/super/cc: remove isysroot space to fix cpp
Fixes #5153 | Library/Homebrew/shims/super/cc | @@ -114,7 +114,7 @@ class Cmd
if tool == "ld"
args << "-syslibroot" << sysroot
else
- args << "-isysroot" << sysroot << "--sysroot=#{sysroot}"
+ args << "-isysroot#{sysroot}" << "--sysroot=#{sysroot}"
end
end
@@ -213,7 +213,7 @@ class Cmd
if mac?
sdk = ... | false |
Other | Homebrew | brew | 3cb2d62a1b13d4e71c8c5deeb6250fc594f14ec8.json | formula: copy hidden files from bottles. | Library/Homebrew/formula.rb | @@ -20,6 +20,7 @@
require "language/python"
require "tab"
require "mktemp"
+require "find"
# A formula provides instructions and metadata for Homebrew to install a piece
# of software. Every Homebrew formula is a {Formula}.
@@ -998,7 +999,9 @@ def run_post_install
with_env(new_env) do
ENV.clear_sensi... | false |
Other | Homebrew | brew | 1ab86acb0fb13bb9f52189a2ca410c461ce084fc.json | move methods to analytics_table function | Library/Homebrew/cmd/info.rb | @@ -231,6 +231,18 @@ def formulae_api_json(endpoint)
end
def analytics_table(category, days, results, os_version: false, cask_install: false)
+ valid_days = %w[30 90 365]
+ if days.present?
+ raise UsageError, "day must be one of #{valid_days.join(", ")}" unless valid_days.include?(days.to_s)
+ en... | false |
Other | Homebrew | brew | d6d857c154fb9cdb7dc1f81a1cc8a2302b9a3996.json | cmd/upgrade: fix exit logic.
Fixes #6739 | Library/Homebrew/cmd/upgrade.rb | @@ -81,7 +81,7 @@ def upgrade
opoo "#{f.full_specified_name} #{version} already installed"
end
end
- exit
+ return if outdated.empty?
end
pinned = outdated.select(&:pinned?) | false |
Other | Homebrew | brew | 38f9e6b0442ded3f28630825b97c5b4972c36206.json | README: add GitHub Sponsors link.
Let people know we support this now. Don't need a dedicated link because we have one at the top of the page. | README.md | @@ -57,7 +57,7 @@ Documentation is under the [Creative Commons Attribution license](https://creati
## Donations
Homebrew is a non-profit project run entirely by unpaid volunteers. We need your funds to pay for software, hardware and hosting around continuous integration and future improvements to the project. Every d... | false |
Other | Homebrew | brew | 8244a869f63f7d10e8533df7705a7fec5d596315.json | add empty line after guard clause | Library/Homebrew/cmd/info.rb | @@ -371,6 +371,7 @@ def output_formula_analytics(f)
if full_analytics
next if args.days.present? && args.days&.to_i != days
next if args.category.present? && args.category != category
+
analytics_table(category, days, results)
else
total_count = results.valu... | false |
Other | Homebrew | brew | b4f8671849e7bdac249c0d220cf25d054b956eaa.json | formula_installer: copy hidden files into bottles. | Library/Homebrew/formula_installer.rb | @@ -18,6 +18,7 @@
require "install"
require "messages"
require "cask/cask_loader"
+require "find"
class FormulaInstaller
include FormulaCellarChecks
@@ -201,12 +202,12 @@ def check_install_sanity
end
def build_bottle_preinstall
- @etc_var_glob ||= "#{HOMEBREW_PREFIX}/{etc,var}/**/*"
- @etc_var_pr... | false |
Other | Homebrew | brew | f3afedb4ff2c43d6840dfbdc5dc6a8c157c9489e.json | utils#system: improve verbose output.
This previously output the hilarious long and unnecessary LOAD_PATH. | Library/Homebrew/dev-cmd/ruby.rb | @@ -26,7 +26,7 @@ def ruby
ruby_args.parse
begin
- safe_system ENV["HOMEBREW_RUBY_PATH"],
+ safe_system RUBY_PATH,
"-I", $LOAD_PATH.join(File::PATH_SEPARATOR),
"-rglobal", "-rdev-cmd/irb",
*ARGV | true |
Other | Homebrew | brew | f3afedb4ff2c43d6840dfbdc5dc6a8c157c9489e.json | utils#system: improve verbose output.
This previously output the hilarious long and unnecessary LOAD_PATH. | Library/Homebrew/utils.rb | @@ -35,7 +35,10 @@ def _system(cmd, *args, **options)
end
def system(cmd, *args, **options)
- puts "#{cmd} #{args * " "}" if ARGV.verbose?
+ if ARGV.verbose?
+ puts "#{cmd} #{args * " "}".gsub(RUBY_PATH, "ruby")
+ .gsub($LOAD_PATH.join(File::PATH_SEPARATOR).to_s, "$LOA... | true |
Other | Homebrew | brew | 176297d361e68ae3deeacb76c20245dfb08998e5.json | Handle 2.2.0 deprecations/disableds
- Make all `odeprecated` from 2.1.0 `odisabled` instead
- Remove dead code that won't be run now
- Remove (unused) `or_later` handling for bottles | Library/Homebrew/cmd/tap-pin.rb | @@ -7,29 +7,12 @@ module Homebrew
def tap_pin_args
Homebrew::CLI::Parser.new do
- usage_banner <<~EOS
- `tap-pin` <tap>
-
- Pin <tap>, prioritising its formulae over core when formula names are supplied
- by the user. See also `tap-unpin`.
- EOS
- switch :debug
hide_... | true |
Other | Homebrew | brew | 176297d361e68ae3deeacb76c20245dfb08998e5.json | Handle 2.2.0 deprecations/disableds
- Make all `odeprecated` from 2.1.0 `odisabled` instead
- Remove dead code that won't be run now
- Remove (unused) `or_later` handling for bottles | Library/Homebrew/cmd/tap-unpin.rb | @@ -7,28 +7,12 @@ module Homebrew
def tap_unpin_args
Homebrew::CLI::Parser.new do
- usage_banner <<~EOS
- `tap-unpin` <tap>
-
- Unpin <tap> so its formulae are no longer prioritised. See also `tap-pin`.
- EOS
- switch :debug
hide_from_man_page!
end
end
def tap_... | true |
Other | Homebrew | brew | 176297d361e68ae3deeacb76c20245dfb08998e5.json | Handle 2.2.0 deprecations/disableds
- Make all `odeprecated` from 2.1.0 `odisabled` instead
- Remove dead code that won't be run now
- Remove (unused) `or_later` handling for bottles | Library/Homebrew/compat/cask/dsl/version.rb | @@ -5,18 +5,15 @@ class DSL
class Version < ::String
module Compat
def dots_to_slashes
- odeprecated "#dots_to_slashes"
- version { tr(".", "/") }
+ odisabled "#dots_to_slashes"
end
def hyphens_to_slashes
- odeprecated "#hyphens_to_slashes"
- ... | true |
Other | Homebrew | brew | 176297d361e68ae3deeacb76c20245dfb08998e5.json | Handle 2.2.0 deprecations/disableds
- Make all `odeprecated` from 2.1.0 `odisabled` instead
- Remove dead code that won't be run now
- Remove (unused) `or_later` handling for bottles | Library/Homebrew/compat/requirements/macos_requirement.rb | @@ -11,9 +11,8 @@ def initialize(tags = [], comparator: ">=")
sym = MacOS::Version.new(v).to_sym
- odeprecated "depends_on macos: #{v.inspect}", "depends_on macos: #{sym.inspect}",
- disable_on: Time.parse("2019-10-15")
-
+ odisabled "depends_on macos: #{v.inspect}"... | true |
Other | Homebrew | brew | 176297d361e68ae3deeacb76c20245dfb08998e5.json | Handle 2.2.0 deprecations/disableds
- Make all `odeprecated` from 2.1.0 `odisabled` instead
- Remove dead code that won't be run now
- Remove (unused) `or_later` handling for bottles | Library/Homebrew/dev-cmd/bottle.rb | @@ -28,7 +28,7 @@
<% checksums.each do |checksum_type, checksum_values| %>
<% checksum_values.each do |checksum_value| %>
<% checksum, macos = checksum_value.shift %>
- <%= checksum_type %> "<%= checksum %>" => :<%= macos %><%= "_or_later" if Homebrew.args.or_later? %>
+ <%= checksum_type %> "<%= c... | true |
Other | Homebrew | brew | 176297d361e68ae3deeacb76c20245dfb08998e5.json | Handle 2.2.0 deprecations/disableds
- Make all `odeprecated` from 2.1.0 `odisabled` instead
- Remove dead code that won't be run now
- Remove (unused) `or_later` handling for bottles | Library/Homebrew/extend/os/mac/utils/bottles.rb | @@ -25,25 +25,18 @@ def find_matching_tag(tag)
end
end
- def tag_without_or_later(tag)
- tag
- end
-
# Find a bottle built for a previous version of macOS.
def find_older_compatible_tag(tag)
- begin
- tag_version = MacOS::Version.from_symbol(tag)
+ ... | true |
Other | Homebrew | brew | 176297d361e68ae3deeacb76c20245dfb08998e5.json | Handle 2.2.0 deprecations/disableds
- Make all `odeprecated` from 2.1.0 `odisabled` instead
- Remove dead code that won't be run now
- Remove (unused) `or_later` handling for bottles | Library/Homebrew/formulary.rb | @@ -490,14 +490,8 @@ def self.find_with_priority(ref, spec = :stable)
if possible_pinned_tap_formulae.size == 1
selected_formula = factory(possible_pinned_tap_formulae.first, spec)
if core_path(ref).file?
- odeprecated "brew tap-pin user/tap",
- "fully-scoped user/tap/formul... | true |
Other | Homebrew | brew | 176297d361e68ae3deeacb76c20245dfb08998e5.json | Handle 2.2.0 deprecations/disableds
- Make all `odeprecated` from 2.1.0 `odisabled` instead
- Remove dead code that won't be run now
- Remove (unused) `or_later` handling for bottles | Library/Homebrew/software_spec.rb | @@ -261,7 +261,7 @@ def self.create(formula, tag, rebuild)
def initialize(name, version, tag, rebuild)
@name = File.basename name
@version = version
- @tag = tag.to_s.gsub(/_or_later$/, "")
+ @tag = tag.to_s
@rebuild = rebuild
end
| true |
Other | Homebrew | brew | 176297d361e68ae3deeacb76c20245dfb08998e5.json | Handle 2.2.0 deprecations/disableds
- Make all `odeprecated` from 2.1.0 `odisabled` instead
- Remove dead code that won't be run now
- Remove (unused) `or_later` handling for bottles | docs/Manpage.md | @@ -717,8 +717,6 @@ at its original value, while `--no-rebuild` will remove it.
* `--skip-relocation`:
Do not check if the bottle can be marked as relocatable.
-* `--or-later`:
- Append `_or_later` to the bottle tag.
* `--force-core-tap`:
Build a bottle even if *`formula`* is not in `homebrew/core` or any in... | true |
Other | Homebrew | brew | 176297d361e68ae3deeacb76c20245dfb08998e5.json | Handle 2.2.0 deprecations/disableds
- Make all `odeprecated` from 2.1.0 `odisabled` instead
- Remove dead code that won't be run now
- Remove (unused) `or_later` handling for bottles | manpages/brew-cask.1 | @@ -1,7 +1,7 @@
.\" generated with Ronn/v0.7.3
.\" http://github.com/rtomayko/ronn/tree/0.7.3
.
-.TH "BREW\-CASK" "1" "October 2019" "Homebrew" "brew-cask"
+.TH "BREW\-CASK" "1" "November 2019" "Homebrew" "brew-cask"
.
.SH "NAME"
\fBbrew\-cask\fR \- a friendly binary installer for macOS | true |
Other | Homebrew | brew | 176297d361e68ae3deeacb76c20245dfb08998e5.json | Handle 2.2.0 deprecations/disableds
- Make all `odeprecated` from 2.1.0 `odisabled` instead
- Remove dead code that won't be run now
- Remove (unused) `or_later` handling for bottles | manpages/brew.1 | @@ -1,7 +1,7 @@
.\" generated with Ronn/v0.7.3
.\" http://github.com/rtomayko/ronn/tree/0.7.3
.
-.TH "BREW" "1" "October 2019" "Homebrew" "brew"
+.TH "BREW" "1" "November 2019" "Homebrew" "brew"
.
.SH "NAME"
\fBbrew\fR \- The missing package manager for macOS
@@ -898,10 +898,6 @@ Generate a bottle (binary package... | true |
Other | Homebrew | brew | 95a1c8570a28ac98ff1266e45b00122a025b22cf.json | cleanup: rescue more cask errors.
This will avoid a wider degree of failures. | Library/Homebrew/cleanup.rb | @@ -97,7 +97,7 @@ def stale_cask?(scrub)
cask = begin
Cask::CaskLoader.load(name)
- rescue Cask::CaskUnavailableError
+ rescue Cask::CaskError
return false
end
@@ -196,7 +196,7 @@ def clean!(quiet: false, periodic: false)
cask = begin
Cask::CaskLoa... | false |
Other | Homebrew | brew | 6a3395988831a4fab8a187c292738af2e82b5d2c.json | test/subversion: fix subversion paths/detection. | Library/Homebrew/test/spec_helper.rb | @@ -124,8 +124,19 @@
end
config.before(:each, :needs_svn) do
- homebrew_bin = File.dirname HOMEBREW_BREW_FILE
- skip "subversion not installed." unless %W[/usr/bin/svn #{homebrew_bin}/svn].map { |x| File.executable?(x) }.any?
+ svn_paths = PATH.new(ENV["PATH"])
+ if OS.mac?
+ xcrun_svn = Utils.... | true |
Other | Homebrew | brew | 6a3395988831a4fab8a187c292738af2e82b5d2c.json | test/subversion: fix subversion paths/detection. | Library/Homebrew/test/unpack_strategy/subversion_spec.rb | @@ -8,9 +8,7 @@
let(:path) { working_copy }
before do
- svnadmin = ["svnadmin"]
- svnadmin = ["xcrun", *svnadmin] if OS.mac? && MacOS.version >= :catalina
- safe_system(*svnadmin, "create", repo)
+ safe_system "svnadmin", "create", repo
safe_system "svn", "checkout", "file://#{repo}", working_c... | true |
Other | Homebrew | brew | 924af100b73d24dffb2199fa46ae118e8b3bbb29.json | cask/pkg_spec: remove flaky test. | Library/Homebrew/test/cask/pkg_spec.rb | @@ -6,34 +6,6 @@
let(:empty_response) { double(stdout: "", plist: { "volume" => "/", "install-location" => "", "paths" => {} }) }
let(:pkg) { described_class.new("my.fake.pkg", fake_system_command) }
- it "removes files and dirs referenced by the pkg" do
- some_files = Array.new(3) { Pathname.new(Te... | false |
Other | Homebrew | brew | 6670ae620229d7030b0e0feee96cd550c686e117.json | global: require rubygems for activesupport. | Library/Homebrew/cask/dsl/depends_on.rb | @@ -1,7 +1,5 @@
# frozen_string_literal: true
-require "rubygems"
-
module Cask
class DSL
class DependsOn < DelegateClass(Hash) | true |
Other | Homebrew | brew | 6670ae620229d7030b0e0feee96cd550c686e117.json | global: require rubygems for activesupport. | Library/Homebrew/cask/installer.rb | @@ -1,7 +1,5 @@
# frozen_string_literal: true
-require "rubygems"
-
require "formula_installer"
require "unpack_strategy"
| true |
Other | Homebrew | brew | 6670ae620229d7030b0e0feee96cd550c686e117.json | global: require rubygems for activesupport. | Library/Homebrew/formula_assertions.rb | @@ -2,7 +2,6 @@
module Homebrew
module Assertions
- require "rubygems"
require "test/unit/assertions"
include ::Test::Unit::Assertions
| true |
Other | Homebrew | brew | 6670ae620229d7030b0e0feee96cd550c686e117.json | global: require rubygems for activesupport. | Library/Homebrew/global.rb | @@ -9,6 +9,7 @@
require_relative "load_path"
+require "rubygems"
require "active_support/core_ext/object/blank"
require "active_support/core_ext/numeric/time"
require "active_support/core_ext/array/access" | true |
Other | Homebrew | brew | 6670ae620229d7030b0e0feee96cd550c686e117.json | global: require rubygems for activesupport. | Library/Homebrew/test/cask/cmd/style_spec.rb | @@ -1,7 +1,6 @@
# frozen_string_literal: true
require "open3"
-require "rubygems"
require_relative "shared_examples/invalid_option"
| true |
Other | Homebrew | brew | 6670ae620229d7030b0e0feee96cd550c686e117.json | global: require rubygems for activesupport. | Library/Homebrew/test/support/helper/spec/shared_context/integration_test.rb | @@ -88,7 +88,6 @@ def brew(*args)
"-I", $LOAD_PATH.join(File::PATH_SEPARATOR)
]
if ENV["HOMEBREW_TESTS_COVERAGE"]
- require "rubygems"
simplecov_spec = Gem.loaded_specs["simplecov"]
specs = [simplecov_spec]
simplecov_spec.runtime_dependencies.each do |dep| | true |
Other | Homebrew | brew | b6116c5a0323c61bd49ce19919f667b5b41bedd5.json | deps: use Formulary factory cache. | Library/Homebrew/cmd/deps.rb | @@ -58,6 +58,9 @@ def deps_args
def deps
deps_args.parse
+
+ Formulary.enable_factory_cache!
+
mode = OpenStruct.new(
installed?: args.installed?,
tree?: args.tree?, | false |
Other | Homebrew | brew | 22795d7e306704527137d3c1920bae358b00ab03.json | spec_helper: do cache clearing in single location. | Library/Homebrew/test/dependency_collector_spec.rb | @@ -13,10 +13,6 @@ def find_requirement(klass)
subject.requirements.find { |req| req.is_a? klass }
end
- after do
- described_class.clear_cache
- end
-
describe "#add" do
specify "dependency creation" do
subject.add "foo" => :build | true |
Other | Homebrew | brew | 22795d7e306704527137d3c1920bae358b00ab03.json | spec_helper: do cache clearing in single location. | Library/Homebrew/test/missing_formula_spec.rb | @@ -38,7 +38,6 @@
subject { described_class.tap_migration_reason(formula) }
before do
- Tap.clear_cache
tap_path = Tap::TAP_DIRECTORY/"homebrew/homebrew-foo"
tap_path.mkpath
(tap_path/"tap_migrations.json").write <<~JSON
@@ -63,7 +62,6 @@
subject { described_class.deleted_reas... | true |
Other | Homebrew | brew | 22795d7e306704527137d3c1920bae358b00ab03.json | spec_helper: do cache clearing in single location. | Library/Homebrew/test/os/linux/dependency_collector_spec.rb | @@ -5,10 +5,6 @@
describe DependencyCollector do
alias_matcher :be_a_build_requirement, :be_build
- after do
- described_class.clear_cache
- end
-
describe "#add" do
resource = Resource.new
| true |
Other | Homebrew | brew | 22795d7e306704527137d3c1920bae358b00ab03.json | spec_helper: do cache clearing in single location. | Library/Homebrew/test/os/mac/dependency_collector_spec.rb | @@ -5,10 +5,6 @@
describe DependencyCollector do
alias_matcher :need_tar_xz_dependency, :be_tar_needs_xz_dependency
- after do
- described_class.clear_cache
- end
-
specify "Resource dependency from a '.xz' URL" do
resource = Resource.new
resource.url("https://brew.sh/foo.tar.xz") | true |
Other | Homebrew | brew | 22795d7e306704527137d3c1920bae358b00ab03.json | spec_helper: do cache clearing in single location. | Library/Homebrew/test/spec_helper.rb | @@ -145,9 +145,13 @@ def find_files
begin
Homebrew.raise_deprecation_exceptions = true
+
+ Formulary.clear_cache
+ Tap.clear_cache
+ DependencyCollector.clear_cache
Formula.clear_cache
Keg.clear_cache
- Tap.clear_cache
+ Tab.clear_cache
FormulaInstaller.clear_... | true |
Other | Homebrew | brew | 22795d7e306704527137d3c1920bae358b00ab03.json | spec_helper: do cache clearing in single location. | Library/Homebrew/test/tap_spec.rb | @@ -78,8 +78,6 @@ def setup_git_repo
expect {
described_class.fetch("homebrew", "homebrew/baz")
}.to raise_error(/Invalid tap name/)
- ensure
- described_class.clear_cache
end
describe "::from_path" do | true |
Other | Homebrew | brew | 893474d0374125c832f06e3d4e90c847095e62e7.json | formulary: add cache to factory. | Library/Homebrew/formulary.rb | @@ -9,6 +9,14 @@
module Formulary
extend Cachable
+ def self.enable_factory_cache!
+ @factory_cache = true
+ end
+
+ def self.factory_cached?
+ !@factory_cache.nil?
+ end
+
def self.formula_class_defined?(path)
cache.key?(path)
end
@@ -314,7 +322,18 @@ def klass
def self.factory(ref, spec ... | false |
Other | Homebrew | brew | 7d77a9e97d43ee5bda273277da093078e00325b5.json | formula: add runtime_installed_formula_dependents method. | Library/Homebrew/formula.rb | @@ -1570,6 +1570,23 @@ def runtime_formula_dependencies(read_from_tab: true, undeclared: true)
end.compact
end
+ def runtime_installed_formula_dependents
+ # `opt_or_installed_prefix_keg` and `runtime_dependencies` `select`s ensure
+ # that we don't end up with something `Formula#runtime_dependencies` ... | false |
Other | Homebrew | brew | add10c64f12d65e7d1950633c991c1c78ca59b27.json | Linux Maintainer Guide: Reflect recent changes to tap commands
- We recently changed the name of the Linux commands tap from
Linuxbrew/homebrew-developer to Homebrew/homebrew-linux-dev in our
continual efforts to move away from the Linuxbrew name. Related to
this, we changed the comment produced by `brew build-b... | docs/Homebrew-linuxbrew-core-Maintainer-Guide.md | @@ -219,7 +219,7 @@ running `git push your-fork master`
After merging changes, we must rebuild bottles for all the PRs that
had conflicts.
-To do this, tap `Linuxbrew/homebrew-developer` and run the following
+To do this, tap `Homebrew/homebrew-linux-dev` and run the following
command where the merge commit is `HE... | false |
Other | Homebrew | brew | 7349178adcd32d0ebc301d7683a8353babfab37d.json | move comments outside the 'for cmd' loop | bin/brew | @@ -19,10 +19,12 @@ symlink_target_directory() {
quiet_cd "$directory" && quiet_cd "$target_dirname" && pwd -P
}
+# Unset functions that override Bash builtins
+# Enable all Bash builtins
for cmd in $(compgen -A builtin)
do
- unset -f $cmd # Unset functions that override Bash builtins
- enable $cmd # Enable ... | false |
Other | Homebrew | brew | 81db0e9551f213b6ddc94d7bbad1128cc8591a51.json | dev-cmd: enable frozen string literals
Now that we use Ruby 2.6 we can fix these last two files. | Library/Homebrew/dev-cmd/bottle.rb | @@ -1,6 +1,4 @@
-# Uses ERB so can't use Frozen String Literals until >=Ruby 2.4:
-# https://bugs.ruby-lang.org/issues/12031
-# frozen_string_literal: false
+# frozen_string_literal: true
require "formula"
require "utils/bottles"
@@ -11,7 +9,7 @@
require "utils/inreplace"
require "erb"
-BOTTLE_ERB = <<-EOS.free... | true |
Other | Homebrew | brew | 81db0e9551f213b6ddc94d7bbad1128cc8591a51.json | dev-cmd: enable frozen string literals
Now that we use Ruby 2.6 we can fix these last two files. | Library/Homebrew/dev-cmd/man.rb | @@ -1,6 +1,4 @@
-# Uses ERB so can't use Frozen String Literals until >=Ruby 2.4:
-# https://bugs.ruby-lang.org/issues/12031
-# frozen_string_literal: false
+# frozen_string_literal: true
require "formula"
require "erb"
@@ -18,7 +16,7 @@ module Homebrew
def man_args
Homebrew::CLI::Parser.new do
- usa... | true |
Other | Homebrew | brew | a6b08ecaede8f0670c4364b8bcc43c67e977b6f2.json | rubocops: add go@1.12 to BINARY_FORMULA_URLS_WHITELIST | Library/Homebrew/rubocops/urls.rb | @@ -17,6 +17,7 @@ class Urls < FormulaCop
go@1.9
go@1.10
go@1.11
+ go@1.12
haskell-stack
ldc
mlton | false |
Other | Homebrew | brew | 5ffc7e9d668c8be4bc9bd40ab45f3e1c6a9bd2fe.json | Change spelling of [Ss]ummarize to British english | Library/Homebrew/cmd/--env.rb | @@ -13,7 +13,7 @@ def __env_args
usage_banner <<~EOS
`--env` [<options>]
- Summarize Homebrew's build environment as a plain list.
+ Summarise Homebrew's build environment as a plain list.
If the command's output is sent through a pipe and no shell is specified,
the l... | true |
Other | Homebrew | brew | 5ffc7e9d668c8be4bc9bd40ab45f3e1c6a9bd2fe.json | Change spelling of [Ss]ummarize to British english | Library/Homebrew/cmd/list.rb | @@ -14,7 +14,7 @@ def list_args
List all installed formulae.
- If <formula> is provided, summarize the paths within its current keg.
+ If <formula> is provided, summarise the paths within its current keg.
EOS
switch "--full-name",
description: "Print formulae with ... | true |
Other | Homebrew | brew | 5ffc7e9d668c8be4bc9bd40ab45f3e1c6a9bd2fe.json | Change spelling of [Ss]ummarize to British english | docs/Manpage.md | @@ -292,7 +292,7 @@ automatically when you install formulae but can be useful for DIY installations.
List all installed formulae.
-If *`formula`* is provided, summarize the paths within its current keg.
+If *`formula`* is provided, summarise the paths within its current keg.
* `--full-name`:
Print formulae w... | true |
Other | Homebrew | brew | 5ffc7e9d668c8be4bc9bd40ab45f3e1c6a9bd2fe.json | Change spelling of [Ss]ummarize to British english | manpages/brew.1 | @@ -381,7 +381,7 @@ Allow keg\-only formulae to be linked\.
List all installed formulae\.
.
.P
-If \fIformula\fR is provided, summarize the paths within its current keg\.
+If \fIformula\fR is provided, summarise the paths within its current keg\.
.
.TP
\fB\-\-full\-name\fR
@@ -813,7 +813,7 @@ Display Homebrew\'s ... | true |
Other | Homebrew | brew | 1e57ca70d34ed2504aadbbb2b40bef88a5f781df.json | Replace American spelling with British spelling | docs/Bottles.md | @@ -10,7 +10,7 @@ Bottles will not be used if the user requests it (see above), if the formula req
## Creation
Bottles are created using the [Brew Test Bot](Brew-Test-Bot.md). This happens mostly when people submit pull requests to Homebrew and the `bottle do` block is updated by maintainers when they `brew pull --bo... | true |
Other | Homebrew | brew | 1e57ca70d34ed2504aadbbb2b40bef88a5f781df.json | Replace American spelling with British spelling | docs/Formula-Cookbook.md | @@ -84,7 +84,7 @@ so you can override this with `brew create <URL> --set-name <name>`.
An SSL/TLS (https) [`homepage`](https://rubydoc.brew.sh/Formula#homepage%3D-class_method) is preferred, if one is available.
-Try to summarize from the [`homepage`](https://rubydoc.brew.sh/Formula#homepage%3D-class_method) what ... | true |
Other | Homebrew | brew | 1e57ca70d34ed2504aadbbb2b40bef88a5f781df.json | Replace American spelling with British spelling | docs/Homebrew-and-Python.md | @@ -11,7 +11,7 @@ Homebrew provides formulae to brew Python 3.x and a more up-to-date Python 2.7.x
## Python 3.x or Python 2.x
Homebrew provides one formula for Python 3.x (`python`) and another for Python 2.7.x (`python@2`).
-The executables are organized as follows so that Python 2 and Python 3 can both be instal... | true |
Other | Homebrew | brew | 1e57ca70d34ed2504aadbbb2b40bef88a5f781df.json | Replace American spelling with British spelling | docs/Homebrew-linuxbrew-core-Maintainer-Guide.md | @@ -203,7 +203,7 @@ This is due to a bug with Azure Pipelines and its handling of merge
commits. Master branch builds also fail for the same reason. This is
OK.
-Once the PR is approved by other Homebrew developers, you can finalize
+Once the PR is approved by other Homebrew developers, you can finalise
the merge ... | true |
Other | Homebrew | brew | 1e57ca70d34ed2504aadbbb2b40bef88a5f781df.json | Replace American spelling with British spelling | docs/Manpage.md | @@ -292,7 +292,7 @@ automatically when you install formulae but can be useful for DIY installations.
List all installed formulae.
-If *`formula`* is provided, summarize the paths within its current keg.
+If *`formula`* is provided, summarise the paths within its current keg.
* `--full-name`:
Print formulae w... | true |
Other | Homebrew | brew | eda0220e5f807482e4feb327e34375de308ea0fc.json | Fix two typos | docs/Homebrew-linuxbrew-core-Maintainer-Guide.md | @@ -74,7 +74,7 @@ brew merge-homebrew --core
```
Merging all the changes from upstream in one go is usually
-undesireable since our build servers will time out. Instead, attempt
+undesirable since our build servers will time out. Instead, attempt
to only merge 8-10 modified formulae.
`git log --oneline master..... | true |
Other | Homebrew | brew | eda0220e5f807482e4feb327e34375de308ea0fc.json | Fix two typos | docs/Prose-Style-Guidelines.md | @@ -16,7 +16,7 @@ Homebrew's audience includes users with a wide range of education and experience
We strive for "correct" but not "fancy" usage. Think newspaper article, not academic paper.
-This is a set of guidelines to be applied using human judgment, not a set of hard and fast rules. It is like [The Economist... | true |
Other | Homebrew | brew | 77531166d695aa27fa9aafac732df9ff50246cfc.json | Use bundler from Ruby 2.6
Now Ruby comes with its own bundler let's favour using it when we can
over requiring a system one be installed.
This avoids needing to have anything in `~/.gem` again.
I am somewhat optimistic this may help with #6579 but it's useful
by itself. | Library/Homebrew/Gemfile.lock | @@ -132,4 +132,4 @@ DEPENDENCIES
simplecov
BUNDLED WITH
- 2.0.2
+ 1.17.2 | true |
Other | Homebrew | brew | 77531166d695aa27fa9aafac732df9ff50246cfc.json | Use bundler from Ruby 2.6
Now Ruby comes with its own bundler let's favour using it when we can
over requiring a system one be installed.
This avoids needing to have anything in `~/.gem` again.
I am somewhat optimistic this may help with #6579 but it's useful
by itself. | Library/Homebrew/utils/gems.rb | @@ -69,28 +69,32 @@ def install_gem!(name, version: nil, setup_gem_environment: true)
def install_gem_setup_path!(name, version: nil, executable: name, setup_gem_environment: true)
install_gem!(name, version: version, setup_gem_environment: setup_gem_environment)
- return if ENV["PATH"].split(":").any? do ... | true |
Other | Homebrew | brew | 77531166d695aa27fa9aafac732df9ff50246cfc.json | Use bundler from Ruby 2.6
Now Ruby comes with its own bundler let's favour using it when we can
over requiring a system one be installed.
This avoids needing to have anything in `~/.gem` again.
I am somewhat optimistic this may help with #6579 but it's useful
by itself. | docs/.ruby-version | @@ -1 +0,0 @@
-2.6.1 | true |
Other | Homebrew | brew | 77531166d695aa27fa9aafac732df9ff50246cfc.json | Use bundler from Ruby 2.6
Now Ruby comes with its own bundler let's favour using it when we can
over requiring a system one be installed.
This avoids needing to have anything in `~/.gem` again.
I am somewhat optimistic this may help with #6579 but it's useful
by itself. | docs/Gemfile.lock | @@ -260,4 +260,4 @@ DEPENDENCIES
rake
BUNDLED WITH
- 2.0.1
+ 1.17.2 | true |
Other | Homebrew | brew | d37831219df2c4976eddeba3076cfba6f3486d1d.json | Use temp file for calculating hash. | Library/Homebrew/utils/curl.rb | @@ -184,9 +184,12 @@ def curl_check_http_content(url, user_agents: [:default], check_content: false,
end
def curl_http_content_headers_and_checksum(url, hash_needed: false, user_agent: :default)
+ file = Tempfile.new.tap(&:close)
+
max_time = hash_needed ? "600" : "25"
output, = curl_output(
- "--connect-... | false |
Other | Homebrew | brew | df3bbd0299b964e5bc759130a10fce93422a08f8.json | Reduce need for interpolating `appdir` in casks. | Library/Homebrew/cask/artifact/moved.rb | @@ -54,10 +54,14 @@ def move(force: false, command: nil, **options)
command.run!("/bin/mv", args: [source, target], sudo: true)
end
+ FileUtils.ln_sf target, source
+
add_altname_metadata(target, source.basename, command: command)
end
def move_back(skip: false, forc... | true |
Other | Homebrew | brew | df3bbd0299b964e5bc759130a10fce93422a08f8.json | Reduce need for interpolating `appdir` in casks. | Library/Homebrew/cask/installer.rb | @@ -94,6 +94,8 @@ def install
fetch
uninstall_existing_cask if reinstall?
+ backup if force? && @cask.staged_path.exist? && @cask.metadata_versioned_path.exist?
+
oh1 "Installing Cask #{Formatter.identifier(@cask)}"
opoo "macOS's Gatekeeper has been disabled for this Cask" unless quar... | true |
Other | Homebrew | brew | df3bbd0299b964e5bc759130a10fce93422a08f8.json | Reduce need for interpolating `appdir` in casks. | Library/Homebrew/test/cask/artifact/alt_target_spec.rb | @@ -24,7 +24,7 @@
install_phase
expect(target_path).to be_a_directory
- expect(source_path).not_to exist
+ expect(source_path).to be_a_symlink
end
describe "when app is in a subdirectory" do
@@ -45,7 +45,7 @@
install_phase
expect(target_path).to be_a_directory
-... | true |
Other | Homebrew | brew | df3bbd0299b964e5bc759130a10fce93422a08f8.json | Reduce need for interpolating `appdir` in casks. | Library/Homebrew/test/cask/artifact/app_spec.rb | @@ -21,7 +21,7 @@
install_phase
expect(target_path).to be_a_directory
- expect(source_path).not_to exist
+ expect(source_path).to be_a_symlink
end
describe "when app is in a subdirectory" do
@@ -42,7 +42,7 @@
install_phase
expect(target_path).to be_a_directory
-... | true |
Other | Homebrew | brew | df3bbd0299b964e5bc759130a10fce93422a08f8.json | Reduce need for interpolating `appdir` in casks. | Library/Homebrew/test/cask/artifact/generic_artifact_spec.rb | @@ -30,7 +30,7 @@
install_phase.call
expect(target_path).to be_a_directory
- expect(source_path).not_to exist
+ expect(source_path).to be_a_symlink
end
it "avoids clobbering an existing artifact" do | true |
Other | Homebrew | brew | df3bbd0299b964e5bc759130a10fce93422a08f8.json | Reduce need for interpolating `appdir` in casks. | Library/Homebrew/test/cask/artifact/two_apps_correct_spec.rb | @@ -24,23 +24,26 @@
install_phase
expect(target_path_mini).to be_a_directory
- expect(source_path_mini).not_to exist
+ expect(source_path_mini).to be_a_symlink
expect(target_path_pro).to be_a_directory
- expect(source_path_pro).not_to exist
+ expect(source_path_pro).to be_a_... | true |
Other | Homebrew | brew | ecf8324c828c12d3d3adbf8a28d1af6c34a6e3da.json | Fix a typo | docs/Homebrew-on-Linux.md | @@ -78,7 +78,7 @@ Homebrew does not currently support 32-bit x86 platforms. It would be possible f
## Alternative Installation
-Extract or `git clone` Homebrew wherever you want. Use `/home/linuxbrew/.linuxbrew` if possible (to enabled the use of binary packages).
+Extract or `git clone` Homebrew wherever you want... | false |
Other | Homebrew | brew | 87f29857f0d5a8c862ed90b1740e192d5312c0db.json | Pass section to the constructor | Library/Homebrew/cask/artifact/manpage.rb | @@ -5,26 +5,26 @@
module Cask
module Artifact
class Manpage < Symlinked
+ attr_reader :section
+
def self.from_args(cask, source)
- section = source.split(".").last
+ section = source.to_s[/\.([1-8]|n|l)$/, 1]
- raise CaskInvalidError, "section should be a positive number" un... | true |
Other | Homebrew | brew | 87f29857f0d5a8c862ed90b1740e192d5312c0db.json | Pass section to the constructor | Library/Homebrew/test/cask/artifact/manpage_spec.rb | @@ -8,7 +8,7 @@
let(:cask_token) { "invalid/invalid-manpage-no-section" }
it "fails to load a cask without section" do
- expect { cask }.to raise_error(Cask::CaskInvalidError, /section should be a positive number/)
+ expect { cask }.to raise_error(Cask::CaskInvalidError, /is not a valid man page n... | true |
Other | Homebrew | brew | 023f0b59a25bea0e6cd4cad47f3a5b390c4ce41d.json | vendor-install: Change double hyphen to single | Library/Homebrew/cmd/vendor-install.sh | @@ -17,16 +17,16 @@ if [[ -n "$HOMEBREW_MACOS" ]]
then
if [[ "$HOMEBREW_PROCESSOR" = "Intel" ]]
then
- ruby_URL="$HOMEBREW_BOTTLE_DOMAIN/bottles-portable-ruby/portable-ruby--2.6.3.mavericks.bottle.tar.gz"
- ruby_URL2="https://github.com/Homebrew/homebrew-portable-ruby/releases/download/2.6.3/portable-ruby-... | false |
Other | Homebrew | brew | 5dddbf1e8c27e2cc258201ff3651a61945cf8e7c.json | Update unmaintained ffmpeg tap to current | docs/Interesting-Taps-and-Forks.md | @@ -6,7 +6,7 @@ Homebrew has the capability to add (and remove) multiple taps to your local inst
Your taps are Git repositories located at `$(brew --repository)/Library/Taps`.
## Unsupported interesting taps
-* [varenc/ffmpeg](https://github.com/varenc/homebrew-ffmpeg): A tap for FFmpeg with additional options, i... | false |
Other | Homebrew | brew | f0e848b3e095bb58cab8554ba547d3607ad0dc8f.json | fixtures: add testball bottle for ARM
Also fix the absolute link used by testball_bottle-0.1.intel_macintosh.bottle.tar.gz | Library/Homebrew/test/support/fixtures/bottles/testball_bottle-0.1.aarch64_linux.bottle.tar.gz | @@ -0,0 +1 @@
+testball_bottle-0.1.yosemite.bottle.tar.gz
\ No newline at end of file | true |
Other | Homebrew | brew | f0e848b3e095bb58cab8554ba547d3607ad0dc8f.json | fixtures: add testball bottle for ARM
Also fix the absolute link used by testball_bottle-0.1.intel_macintosh.bottle.tar.gz | Library/Homebrew/test/support/fixtures/bottles/testball_bottle-0.1.armv6_linux.bottle.tar.gz | @@ -0,0 +1 @@
+testball_bottle-0.1.yosemite.bottle.tar.gz
\ No newline at end of file | true |
Other | Homebrew | brew | f0e848b3e095bb58cab8554ba547d3607ad0dc8f.json | fixtures: add testball bottle for ARM
Also fix the absolute link used by testball_bottle-0.1.intel_macintosh.bottle.tar.gz | Library/Homebrew/test/support/fixtures/bottles/testball_bottle-0.1.armv7_linux.bottle.tar.gz | @@ -0,0 +1 @@
+testball_bottle-0.1.yosemite.bottle.tar.gz
\ No newline at end of file | true |
Other | Homebrew | brew | f0e848b3e095bb58cab8554ba547d3607ad0dc8f.json | fixtures: add testball bottle for ARM
Also fix the absolute link used by testball_bottle-0.1.intel_macintosh.bottle.tar.gz | Library/Homebrew/test/support/fixtures/bottles/testball_bottle-0.1.intel_macintosh.bottle.tar.gz | @@ -1 +1 @@
-/usr/local/Homebrew/Library/Homebrew/test/support/fixtures/bottles/testball_bottle-0.1.yosemite.bottle.tar.gz
\ No newline at end of file
+testball_bottle-0.1.yosemite.bottle.tar.gz
\ No newline at end of file | true |
Other | Homebrew | brew | 6bc1785c88e49e43b5ac2cd809349d53745d4a83.json | doctor: list any uncommitted modified files | Library/Homebrew/diagnostic.rb | @@ -663,17 +663,28 @@ def check_missing_deps
def check_git_status
return unless Utils.git_available?
+ modified = []
HOMEBREW_REPOSITORY.cd do
- return if `git status --untracked-files=all --porcelain -- Library/Homebrew/ 2>/dev/null`.chomp.empty?
+ modified.concat `g... | false |
Other | Homebrew | brew | 40a0b8b10ab6ba1ef8e3b0acc2eeef7c8dd494b6.json | Fix missing `command` method. | Library/Homebrew/cask/cmd.rb | @@ -214,7 +214,7 @@ def initialize(command, *args)
@args = args
end
- def run(*_args)
+ def run(*)
purpose
usage
@@ -226,7 +226,7 @@ def run(*_args)
raise ArgumentError, "help does not take arguments." if @args.length
end
- raise ArgumentError... | false |
Other | Homebrew | brew | e3f8939cff48dd59f267792077282110a0616c66.json | zip: overwrite existing files
Fixes homebrew/homebrew-cask#69879 | Library/Homebrew/unpack_strategy/zip.rb | @@ -23,7 +23,7 @@ def contains_extended_attributes?(path)
def extract_to_dir(unpack_dir, basename:, verbose:)
quiet_flags = verbose ? [] : ["-qq"]
result = system_command! "unzip",
- args: [*quiet_flags, path, "-d", unpack_dir],
+ ar... | false |
Other | Homebrew | brew | 8a93230c1546bb172a81e1aa27083b98e2e3b5d0.json | test/cask: remove disabled functionality tests. | Library/Homebrew/test/cask/depends_on_spec.rb | @@ -47,14 +47,6 @@
end
end
- context "given a string", :needs_compat do
- let(:cask) { Cask::CaskLoader.load(cask_path("compat/with-depends-on-macos-string")) }
-
- it "does not raise an error" do
- expect { install }.not_to raise_error
- end
- end
-
context "given a symbo... | true |
Other | Homebrew | brew | 8a93230c1546bb172a81e1aa27083b98e2e3b5d0.json | test/cask: remove disabled functionality tests. | Library/Homebrew/test/cask/dsl_spec.rb | @@ -335,14 +335,6 @@ def caveats
end
describe "depends_on macos" do
- context "string disabled", :needs_compat do
- let(:token) { "compat/with-depends-on-macos-string" }
-
- it "allows depends_on macos to be specified" do
- expect { cask }.to raise_error(Cask::CaskInvalidError)
- end
- ... | true |
Other | Homebrew | brew | 1b4fdc17f4afa716ded74949c1e06ecce838e919.json | Raise deprecation exceptions in tests
Previously tests which hit `odeprecated` would print warnings but not
always raise exceptions or fail. Combine this with the ability to have
`odeprecated` to turn into `odisabled` on certain dates and you have
tests that may fail just on the clock changing (this is bad).
Instead,... | Library/Homebrew/test/cask/dsl_spec.rb | @@ -335,11 +335,11 @@ def caveats
end
describe "depends_on macos" do
- context "valid", :needs_compat do
+ context "string disabled", :needs_compat do
let(:token) { "compat/with-depends-on-macos-string" }
it "allows depends_on macos to be specified" do
- expect(cask.depends_on.macos... | true |
Other | Homebrew | brew | 1b4fdc17f4afa716ded74949c1e06ecce838e919.json | Raise deprecation exceptions in tests
Previously tests which hit `odeprecated` would print warnings but not
always raise exceptions or fail. Combine this with the ability to have
`odeprecated` to turn into `odisabled` on certain dates and you have
tests that may fail just on the clock changing (this is bad).
Instead,... | Library/Homebrew/test/spec_helper.rb | @@ -144,6 +144,7 @@ def find_files
end
begin
+ Homebrew.raise_deprecation_exceptions = true
Tap.clear_cache
FormulaInstaller.clear_attempted
| true |
Other | Homebrew | brew | f762033a57be271b778be6e39fe7d5b9d068ec64.json | Move condition to nested `if` statement. | Library/Homebrew/cmd/search.rb | @@ -100,10 +100,10 @@ def search
puts Formatter.columns(all_casks)
end
- if $stdout.tty? && !local_casks.include?(query)
+ if $stdout.tty?
count = all_formulae.count + all_casks.count
- if reason = MissingFormula.reason(query, silent: true)
+ if reason = MissingFormu... | false |
Other | Homebrew | brew | cbf458ea9c6dfeca2bf9e2cc3027969958dc33db.json | Lint/ElseAlignment: ignore some bugged autocorrections. | Library/Homebrew/formula_installer.rb | @@ -369,8 +369,8 @@ def check_conflicts
$stderr.puts "Please report this to the #{formula.tap} tap!"
false
- else
- f.linked_keg.exist? && f.opt_prefix.exist?
+ else # rubocop:disable Lint/ElseAlignment
+ f.linked_keg.exist? && f.opt_prefix.exist?
end
... | true |
Other | Homebrew | brew | cbf458ea9c6dfeca2bf9e2cc3027969958dc33db.json | Lint/ElseAlignment: ignore some bugged autocorrections. | Library/Homebrew/utils/fork.rb | @@ -53,8 +53,8 @@ def self.safe_fork(&_block)
write.close
exit!
- else
- exit!(true)
+ else # rubocop:disable Lint/ElseAlignment
+ exit!(true)
end
ignore_interrupts(:quietly) do # the child will receive the interrupt and marshal it ... | true |
Other | Homebrew | brew | c71b540ea6806afb80cdf906035d6b298ac1f769.json | vendor-install: Add ruby bottle for aarch64 | Library/Homebrew/cmd/vendor-install.sh | @@ -29,6 +29,11 @@ then
ruby_URL2="https://github.com/Homebrew/homebrew-portable-ruby/releases/download/2.6.3/portable-ruby--2.6.3.x86_64_linux.bottle.tar.gz"
ruby_SHA="e8c9b6d3dc5f40844e07b4b694897b8b7cb5a7dab1013b3b8712a22868f98c98"
;;
+ aarch64)
+ ruby_URL="$HOMEBREW_BOTTLE_DOMAIN/bottle... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.