language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
Homebrew
brew
77f2d01739ba6738697bd834e6965023ae36eff6.json
Add hash support
Library/Homebrew/extend/os/mac/software_spec.rb
@@ -2,6 +2,11 @@ class SoftwareSpec def uses_from_macos(deps, **args) + if deps.is_a?(Hash) + args = deps + deps = Hash[*args.shift] + end + depends_on(deps) if add_mac_dependency?(args) end @@ -14,6 +19,6 @@ def add_mac_dependency?(args) return false if args[:before] && OS::Mac.version >= args[:before] - true + args.present? end end
false
Other
Homebrew
brew
332acbbfc3bc5c8e129c236c3e98580a4a36183a.json
Add more spec cases
Library/Homebrew/test/os/mac/software_spec_spec.rb
@@ -13,11 +13,10 @@ allow(OS::Mac).to receive(:version).and_return(OS::Mac::Version.new(sierra_os_version)) end - it "doesn't adds a dependency if it doesn't meet OS version requirements" do - spec.uses_from_macos("foo", after: :high_sierra) - spec.uses_from_macos("bar", before: :el_capitan) + it "allows specifying dependencies before certain version" do + spec.uses_from_macos("foo", before: :high_sierra) - expect(spec.deps).to be_empty + expect(spec.deps.first.name).to eq("foo") end it "allows specifying dependencies after certain version" do @@ -26,6 +25,13 @@ expect(spec.deps.first.name).to eq("foo") end + it "doesn't adds a dependency if it doesn't meet OS version requirements" do + spec.uses_from_macos("foo", after: :high_sierra) + spec.uses_from_macos("bar", before: :el_capitan) + + expect(spec.deps).to be_empty + end + it "works with tags" do spec.uses_from_macos("foo" => :head, :after => :el_capitan) @@ -35,10 +41,17 @@ expect(dep.tags).to include(:head) end - it "allows specifying dependencies before certain version" do - spec.uses_from_macos("foo", before: :high_sierra) + it "doesn't adds the dependency without OS version requirements" do + spec.uses_from_macos("foo") + spec.uses_from_macos("bar" => :head) - expect(spec.deps.first.name).to eq("foo") + expect(spec.deps).to be_empty + end + + it "respects OS version requirements with tags" do + spec.uses_from_macos("foo" => :head, :after => :mojave) + + expect(spec.deps).to be_empty end it "raises an error if passing invalid OS versions" do
false
Other
Homebrew
brew
848b3380e5e25cb12dc20422e91db5c51574fb50.json
Increase readability with early returns
Library/Homebrew/extend/os/mac/formula.rb
@@ -11,9 +11,9 @@ def uses_from_macos(dep, **args) def add_mac_dependency?(args) args.each { |key, version| args[key] = OS::Mac::Version.from_symbol(version) } - args.blank? || - args[:before] && OS::Mac.version < args[:before] || - args[:after] && OS::Mac.version >= args[:after] + return false if args[:after] && OS::Mac.version < args[:after] + return false if args[:before] && OS::Mac.version >= args[:before] + return true end end end
false
Other
Homebrew
brew
0c1da29d0c8a57e861b87627a19eaa73ccd4bba8.json
Add _ to unused args
Library/Homebrew/formula.rb
@@ -2360,7 +2360,7 @@ def depends_on(dep) specs.each { |spec| spec.depends_on(dep) } end - def uses_from_macos(dep, **args) + def uses_from_macos(dep, **_args) depends_on(dep) end
false
Other
Homebrew
brew
01c5bc48d250025241ccbbbb476a50df2856ca8e.json
Create extended os formula specs
Library/Homebrew/test/formula_spec.rb
@@ -1387,92 +1387,4 @@ def reset_outdated_kegs end end end - - describe "#uses_from_macos" do - context 'on Linux' do - before do - allow(OS).to receive(:mac?).and_return(false) - end - - it "acts like #depends_on" do - f = formula "foo" do - url "foo-1.0" - - uses_from_macos("foo") - end - - expect(f.class.stable.deps.first.name).to eq("foo") - expect(f.class.devel.deps.first.name).to eq("foo") - expect(f.class.head.deps.first.name).to eq("foo") - end - - it "ignores MacOS specifications" do - f = formula "foo" do - url "foo-1.0" - - uses_from_macos("foo", after: :mojave) - end - - expect(f.class.stable.deps.first.name).to eq("foo") - expect(f.class.devel.deps.first.name).to eq("foo") - expect(f.class.head.deps.first.name).to eq("foo") - end - end - - context 'on MacOS' do - before do - sierra_os_version = OS::Mac::Version.from_symbol(:sierra) - - allow(OS).to receive(:mac?).and_return(true) - allow(OS::Mac).to receive(:version).and_return(OS::Mac::Version.new(sierra_os_version)) - end - - it "doesn't adds a dependency if it doesn't meet OS version requirements" do - f = formula 'foo' do - url 'foo-1.0' - - uses_from_macos('foo', after: :high_sierra) - uses_from_macos('bar', before: :el_capitan) - end - - expect(f.class.stable.deps).to be_empty - expect(f.class.devel.deps).to be_empty - expect(f.class.head.deps).to be_empty - end - - it 'allows specifying dependencies after certain version' do - f = formula 'foo' do - url 'foo-1.0' - - uses_from_macos('foo', after: :el_capitan) - end - - expect(f.class.stable.deps.first.name).to eq('foo') - expect(f.class.devel.deps.first.name).to eq('foo') - expect(f.class.head.deps.first.name).to eq('foo') - end - - it 'allows specifying dependencies before certain version' do - f = formula 'foo' do - url 'foo-1.0' - - uses_from_macos('foo', before: :high_sierra) - end - - expect(f.class.stable.deps.first.name).to eq('foo') - expect(f.class.devel.deps.first.name).to eq('foo') - expect(f.class.head.deps.first.name).to eq('foo') - end - - it 'raises an error if passing invalid OS versions' do - expect { - formula 'foo' do - url 'foo-1.0' - - uses_from_macos('foo', after: 'bar', before: :mojave) - end - }.to raise_error(ArgumentError, 'unknown version "bar"') - end - end - end end
true
Other
Homebrew
brew
01c5bc48d250025241ccbbbb476a50df2856ca8e.json
Create extended os formula specs
Library/Homebrew/test/os/linux/formula_spec.rb
@@ -0,0 +1,35 @@ +# frozen_string_literal: true + +require "formula" + +describe Formula do + describe "#uses_from_macos" do + before do + allow(OS).to receive(:mac?).and_return(false) + end + + it "acts like #depends_on" do + f = formula "foo" do + url "foo-1.0" + + uses_from_macos("foo") + end + + expect(f.class.stable.deps.first.name).to eq("foo") + expect(f.class.devel.deps.first.name).to eq("foo") + expect(f.class.head.deps.first.name).to eq("foo") + end + + it "ignores OS version specifications" do + f = formula "foo" do + url "foo-1.0" + + uses_from_macos("foo", after: :mojave) + end + + expect(f.class.stable.deps.first.name).to eq("foo") + expect(f.class.devel.deps.first.name).to eq("foo") + expect(f.class.head.deps.first.name).to eq("foo") + end + end +end
true
Other
Homebrew
brew
01c5bc48d250025241ccbbbb476a50df2856ca8e.json
Create extended os formula specs
Library/Homebrew/test/os/mac/formula_spec.rb
@@ -0,0 +1,61 @@ +# frozen_string_literal: true + +require "formula" + +describe Formula do + describe "#uses_from_macos" do + before do + sierra_os_version = OS::Mac::Version.from_symbol(:sierra) + + allow(OS).to receive(:mac?).and_return(true) + allow(OS::Mac).to receive(:version).and_return(OS::Mac::Version.new(sierra_os_version)) + end + + it "doesn't adds a dependency if it doesn't meet OS version requirements" do + f = formula "foo" do + url "foo-1.0" + + uses_from_macos("foo", after: :high_sierra) + uses_from_macos("bar", before: :el_capitan) + end + + expect(f.class.stable.deps).to be_empty + expect(f.class.devel.deps).to be_empty + expect(f.class.head.deps).to be_empty + end + + it "allows specifying dependencies after certain version" do + f = formula "foo" do + url "foo-1.0" + + uses_from_macos("foo", after: :el_capitan) + end + + expect(f.class.stable.deps.first.name).to eq("foo") + expect(f.class.devel.deps.first.name).to eq("foo") + expect(f.class.head.deps.first.name).to eq("foo") + end + + it "allows specifying dependencies before certain version" do + f = formula "foo" do + url "foo-1.0" + + uses_from_macos("foo", before: :high_sierra) + end + + expect(f.class.stable.deps.first.name).to eq("foo") + expect(f.class.devel.deps.first.name).to eq("foo") + expect(f.class.head.deps.first.name).to eq("foo") + end + + it "raises an error if passing invalid OS versions" do + expect { + formula "foo" do + url "foo-1.0" + + uses_from_macos("foo", after: "bar", before: :mojave) + end + }.to raise_error(ArgumentError, 'unknown version "bar"') + end + end +end
true
Other
Homebrew
brew
5a657a7068efcd32b2147b773562fc9a0d1754ee.json
New Maintainer Checklist: add "real" name, meetup. We've had problems in the past with Homebrew maintainers being unwilling to disclose their identity or meet other maintainers so here are some very light-touch suggestions to address this in future. These ideas were run past the PLC and agreed there but I still welcome input from maintainers.
docs/New-Maintainer-Checklist.md
@@ -58,7 +58,7 @@ If they accept, follow a few steps to get them set up: - Add them to the [Jenkins' GitHub Authorization Settings admin user names](https://jenkins.brew.sh/configureSecurity/) so they can adjust settings and restart jobs. - Add them to the [Jenkins' GitHub Pull Request Builder admin list](https://jenkins.brew.sh/configure) to enable `@BrewTestBot test this please` for them. - Invite them to the [`homebrew-maintainers` private maintainers mailing list](https://lists.sfconservancy.org/mailman/admin/homebrew-maintainers/members/add). -- Invite them to the [`machomebrew` private maintainers Slack](https://machomebrew.slack.com/admin/invites) (and ensure they've read the [communication guidelines](Maintainer-Guidelines.md#communication)). +- Invite them to the [`machomebrew` private maintainers Slack](https://machomebrew.slack.com/admin/invites) (and ensure they've read the [communication guidelines](Maintainer-Guidelines.md#communication)) and ask them to use their real name there (rather than a pseudonym they may use on e.g. GitHub). - Ask them to disable SMS as a 2FA device or fallback on their GitHub account in favour of using one of the other authentication methods. - Ask them to (regularly) review remove any unneeded [GitHub personal access tokens](https://github.com/settings/tokens). - Add them to Homebrew/brew's README, run `brew man` and commit the changes. @@ -79,6 +79,8 @@ If they are elected to the Homebrew's [Project Leadership Committee](https://doc If there are problems, ask them to step down as a maintainer and revoke their access to all of the above. +In interests of loosely verifying maintainer identity and building camaraderie, if you find yourself in the same town (e.g living, visiting or at a conference) as another Homebrew maintainer you should make the effort to meet up. If you do so, you can expense your meal (within SFC policies). This is a more relaxed version of e.g. the Debian system to meet in person to sign keys with a legal ID verification. + Now sit back, relax and let the new maintainers handle more of our contributions. ## Members
false
Other
Homebrew
brew
dde029a5965d6b0eb834f64f6eeedb781586b765.json
issue-close-app.yml: fix YAML syntax (again) Use the correct multiline syntax.
.github/issue-close-app.yml
@@ -1,10 +1,10 @@ # Comment that will be sent if an issue is judged to be closed -comment: > -From the issue template: +comment: | + From the issue template: -\> **Please note that we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.** + > **Please note that we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.** -If you add the necessary information to this issue (don't create a new one, please) then this issue may be reopened. + If you add the necessary information to this issue (don't create a new one, please) then this issue may be reopened. issueConfigs: # There can be several configs for different kind of issues. - content:
false
Other
Homebrew
brew
0516c78e1349c6e2927f98003928122d04c0f98c.json
Fix issue close bot's config file - According to the [README](https://github.com/offu/close-issue-app#usage) it was missing an `issueConfigs` key. This was causing errors to be posted to new issues rather than the despired text.
.github/issue-close-app.yml
@@ -6,6 +6,7 @@ From the issue template: If you add the necessary information to this issue (don't create a new one, please) then this issue may be reopened. # There can be several configs for different kind of issues. +issueConfigs: - content: # new feature suggestion - "A detailed description of the proposed feature"
false
Other
Homebrew
brew
8908dc51d610f2ce3b2c086b25e04cb9322a66d1.json
keg: tell people what command will remove keg. This will work regardless of permissions.
Library/Homebrew/keg.rb
@@ -311,7 +311,10 @@ def uninstall remove_old_aliases remove_oldname_opt_record rescue Errno::ENOTEMPTY - ofail "Could not remove #{path}! Check its permissions." + odie <<~EOS + Could not remove #{name} keg! Do so manually: + sudo rm -rf #{path} + EOS end def unlink(mode = OpenStruct.new)
false
Other
Homebrew
brew
8ad48f56e85682c5223aabc1d484f32e569f2ca8.json
add test for `brew cask --cache`
Library/Homebrew/test/cask/cmd/--cache_spec.rb
@@ -0,0 +1,38 @@ +# frozen_string_literal: true + +require_relative "shared_examples/requires_cask_token" +require_relative "shared_examples/invalid_option" + +describe Cask::Cmd::Cache, :cask do + let(:local_transmission) { + Cask::CaskLoader.load(cask_path("local-transmission")) + } + + let(:local_caffeine) { + Cask::CaskLoader.load(cask_path("local-caffeine")) + } + + it_behaves_like "a command that requires a Cask token" + it_behaves_like "a command that handles invalid options" + + it "prints the file used to cache the Cask" do + transmission_location = CurlDownloadStrategy.new( + local_transmission.url.to_s, local_transmission.token, local_transmission.version, + cache: Cask::Cache.path, **local_transmission.url.specs + ).cached_location + caffeine_location = CurlDownloadStrategy.new( + local_caffeine.url.to_s, local_caffeine.token, local_caffeine.version, + cache: Cask::Cache.path, **local_caffeine.url.specs + ).cached_location + + expect do + described_class.run("local-transmission", "local-caffeine") + end.to output("#{transmission_location}\n#{caffeine_location}\n").to_stdout + end + + it "properly handles Casks that are not present" do + expect { + described_class.run("notacask") + }.to raise_error(Cask::CaskUnavailableError) + end +end
false
Other
Homebrew
brew
169ac2d413d1a354e1a273759fac61faa2357c17.json
cask: add new --cache command It prints the file used to cache Casks. This can be used to help users to install casks with their files downloaded from outside brew. See #6157.
Library/Homebrew/cask/cmd.rb
@@ -10,6 +10,7 @@ require "cask/cmd/options" require "cask/cmd/abstract_command" +require "cask/cmd/--cache" require "cask/cmd/audit" require "cask/cmd/automerge" require "cask/cmd/cat"
true
Other
Homebrew
brew
169ac2d413d1a354e1a273759fac61faa2357c17.json
cask: add new --cache command It prints the file used to cache Casks. This can be used to help users to install casks with their files downloaded from outside brew. See #6157.
Library/Homebrew/cask/cmd/--cache.rb
@@ -0,0 +1,28 @@ +# frozen_string_literal: true + +require "cask/download" + +module Cask + class Cmd + class Cache < AbstractCommand + def self.command_name + "--cache" + end + + def initialize(*) + super + raise CaskUnspecifiedError if args.empty? + end + + def run + casks.each do |cask| + puts Download.new(cask).downloader.cached_location + end + end + + def self.help + "display the file used to cache the Cask" + end + end + end +end
true
Other
Homebrew
brew
0939c8832d9a12b436bc570240ab29e9f26a0298.json
Add configuration to new appcast check
Library/Homebrew/cask/audit.rb
@@ -301,11 +301,16 @@ def check_download def check_appcast_contains_version return unless check_appcast? return if cask.appcast.to_s.empty? + return if cask.appcast.configuration == :no_check appcast_stanza = cask.appcast.to_s - appcast_contents, = curl_output("--max-time", "5", appcast_stanza) + appcast_contents, = curl_output("-L", "--max-time", "5", appcast_stanza) version_stanza = cask.version.to_s - adjusted_version_stanza = version_stanza.split(",")[0].split("-")[0].split("_")[0] + if cask.appcast.configuration.to_s.empty? + adjusted_version_stanza = version_stanza.split(",")[0].split("-")[0].split("_")[0] + else + adjusted_version_stanza = cask.appcast.configuration + end return if appcast_contents.include? adjusted_version_stanza add_warning "appcast at URL '#{appcast_stanza}' does not contain"\
true
Other
Homebrew
brew
0939c8832d9a12b436bc570240ab29e9f26a0298.json
Add configuration to new appcast check
Library/Homebrew/cask/dsl/appcast.rb
@@ -3,11 +3,21 @@ module Cask class DSL class Appcast + ATTRIBUTES = [ + :configuration, + ].freeze attr_reader :uri, :parameters + attr_reader(*ATTRIBUTES) def initialize(uri, **parameters) @uri = URI(uri) @parameters = parameters + + ATTRIBUTES.each do |attribute| + next unless parameters.key?(attribute) + + instance_variable_set("@#{attribute}", parameters[attribute]) + end end def to_yaml
true
Other
Homebrew
brew
816fdd0f5aeaa5b862204476afdb947ac1cf863d.json
bump-revision: raise an error when no formula
Library/Homebrew/dev-cmd/bump-revision.rb
@@ -33,6 +33,7 @@ def bump_revision # user path, too. ENV["PATH"] = ENV["HOMEBREW_PATH"] + raise FormulaUnspecifiedError if ARGV.formulae.empty? raise "Multiple formulae given, only one is allowed." if ARGV.formulae.length > 1 formula = ARGV.formulae.first
false
Other
Homebrew
brew
820ee847ac141910d9eddab02dceb3ca93dfd84e.json
Homebrew-on-Linux.md: update minimal requirements These are needed to build patchelf 0.10 with debian wheezy.
docs/Homebrew-on-Linux.md
@@ -47,9 +47,9 @@ If you're using an older distribution of Linux, installing your first package wi ## Linux/WSL Requirements -+ **GCC** 4.4 or newer ++ **GCC** 4.7.0 or newer + **Linux** 2.6.32 or newer -+ **Glibc** 2.12 or newer ++ **Glibc** 2.13 or newer + **64-bit x86_64** CPU Paste at a terminal prompt:
false
Other
Homebrew
brew
0bb29e82533ceba1fa3bdc4b4c38d4201928f53d.json
python_virtualenv_constants: upgrade virtualenv to 16.6.0
Library/Homebrew/language/python_virtualenv_constants.rb
@@ -1,8 +1,8 @@ # frozen_string_literal: true PYTHON_VIRTUALENV_URL = - "https://files.pythonhosted.org/packages/6a/56" \ - "/74dce1fdeeabbcc0a3fcf299115f6814bd9c39fc4161658b513240a75ea7" \ - "/virtualenv-16.5.0.tar.gz" + "https://files.pythonhosted.org/packages/53/c0" \ + "/c7819f0bb2cf83e1b4b0d96c901b85191f598a7b534d297c2ef6dc80e2d3" \ + "/virtualenv-16.6.0.tar.gz" PYTHON_VIRTUALENV_SHA256 = - "15ee248d13e4001a691d9583948ad3947bcb8a289775102e4c4aa98a8b7a6d73" + "99acaf1e35c7ccf9763db9ba2accbca2f4254d61d1912c5ee364f9cc4a8942a0"
false
Other
Homebrew
brew
056a2d41fd05a8a7b724e890f4718466aa1173cb.json
Add exception for veclibfort linking to Accelerate - veclibfort exists soley to wrap Apple's accelerate and provide BLAS/LAPACK access to Accelerate - Improve the help message for that audit to mention veclibfort
Library/Homebrew/extend/os/mac/formula_cellar_checks.rb
@@ -51,6 +51,7 @@ def check_openssl_links def check_accelerate_framework_links return unless @core_tap return unless formula.prefix.directory? + return if formula.name == "veclibfort" # veclibfort exists to wrap accelerate keg = Keg.new(formula.prefix) system_accelerate = keg.mach_o_files.select do |obj| @@ -63,7 +64,8 @@ def check_accelerate_framework_links object files were linked against system Accelerate These object files were linked against the outdated system Accelerate framework. Core tap formulae should link against OpenBLAS instead. - Adding `depends_on "openblas"` to the formula may help. + Removing `depends_on "veclibfort" and/or adding `depends_on "openblas"` to the + formula may help. #{system_accelerate * "\n "} EOS end
false
Other
Homebrew
brew
b52e23c3ff0c5eae96410e7642afab187a56e788.json
Fix audit errors in dev-cmd/bump-revision.rb - Method alignment was bad across line break in 3 places.
Library/Homebrew/dev-cmd/bump-revision.rb
@@ -15,9 +15,9 @@ def bump_revision_args present, "revision 1" will be added. EOS switch "-n", "--dry-run", - description: "Print what would be done rather than doing it." + description: "Print what would be done rather than doing it." flag "--message=", - description: "Append the provided <message> to the default commit message." + description: "Append the provided <message> to the default commit message." switch :force switch :quiet @@ -76,7 +76,7 @@ def bump_revision else formula.path.parent.cd do safe_system "git", "commit", "--no-edit", "--verbose", - "--message=#{message}", "--", formula.path + "--message=#{message}", "--", formula.path end end end
false
Other
Homebrew
brew
6e691320f8a87b50c0f25c284fdc89aefc3332d6.json
teach brew about mksh
Library/Homebrew/utils/shell.rb
@@ -11,7 +11,7 @@ def from_path(path) shell_name = File.basename(path) # handle possible version suffix like `zsh-5.2` shell_name.sub!(/-.*\z/m, "") - shell_name.to_sym if %w[bash csh fish ksh sh tcsh zsh].include?(shell_name) + shell_name.to_sym if %w[bash csh fish ksh mksh sh tcsh zsh].include?(shell_name) end def preferred @@ -25,7 +25,7 @@ def parent # quote values. quoting keys is overkill def export_value(key, value, shell = preferred) case shell - when :bash, :ksh, :sh, :zsh + when :bash, :ksh, :mksh, :sh, :zsh "export #{key}=\"#{sh_quote(value)}\"" when :fish # fish quoting is mostly Bourne compatible except that @@ -55,7 +55,7 @@ def set_variable_in_profile(variable, value) def prepend_path_in_profile(path) case preferred - when :bash, :ksh, :sh, :zsh, nil + when :bash, :ksh, :mksh, :sh, :zsh, nil "echo 'export PATH=\"#{sh_quote(path)}:$PATH\"' >> #{profile}" when :csh, :tcsh "echo 'setenv PATH #{csh_quote(path)}:$PATH' >> #{profile}" @@ -69,6 +69,7 @@ def prepend_path_in_profile(path) csh: "~/.cshrc", fish: "~/.config/fish/config.fish", ksh: "~/.kshrc", + mksh: "~/.kshrc", sh: "~/.bash_profile", tcsh: "~/.tcshrc", zsh: "~/.zshrc",
false
Other
Homebrew
brew
b181328ac24395a291582aa38220fdbe54d98194.json
formula_creator: fix meson template * meson-internal should not be used for new formulas anymore, as the latest releases of meson have proper support for macOS now. * make ninja commands verbose
Library/Homebrew/formula_creator.rb
@@ -99,7 +99,7 @@ class #{Formulary.class_s(name)} < Formula <% if mode == :cmake %> depends_on "cmake" => :build <% elsif mode == :meson %> - depends_on "meson-internal" => :build + depends_on "meson" => :build depends_on "ninja" => :build depends_on "python" => :build <% elsif mode.nil? %> @@ -117,12 +117,10 @@ def install "--disable-silent-rules", "--prefix=\#{prefix}" <% elsif mode == :meson %> - ENV.refurbish_args - mkdir "build" do system "meson", "--prefix=\#{prefix}", ".." - system "ninja" - system "ninja", "install" + system "ninja", "-v" + system "ninja", "install", "-v" end <% else %> # Remove unrecognized options if warned by configure
false
Other
Homebrew
brew
9050d0a7b1f4f2126beb152212be34fe419c5297.json
Use Xcode 10.2 for new taps too See https://github.com/Homebrew/brew/pull/6083
Library/Homebrew/dev-cmd/tap-new.rb
@@ -58,7 +58,7 @@ def tap_new steps: - bash: | set -e - sudo xcode-select --switch /Applications/Xcode_10.1.app/Contents/Developer + sudo xcode-select --switch /Applications/Xcode_10.2.app/Contents/Developer brew update HOMEBREW_TAP_DIR="/usr/local/Homebrew/Library/Taps/#{tap.full_name}" mkdir -p "$HOMEBREW_TAP_DIR"
false
Other
Homebrew
brew
9875f3a464d1591b21ac8655c13d1a0adefb2ad5.json
Use Xcode 10.2 for CI See https://github.com/Homebrew/brew/pull/6083
azure-pipelines.yml
@@ -5,7 +5,7 @@ jobs: steps: - bash: | set -e - sudo xcode-select --switch /Applications/Xcode_10.1.app/Contents/Developer + sudo xcode-select --switch /Applications/Xcode_10.2.app/Contents/Developer HOMEBREW_REPOSITORY="$(brew --repo)" mv "$HOMEBREW_REPOSITORY/Library/Taps" "$PWD/Library" sudo rm -rf "$HOMEBREW_REPOSITORY"
false
Other
Homebrew
brew
1406ee7eac845069cc4fefac0820b0d0248691bc.json
abstract_uninstall: add timeout to trash_paths
Library/Homebrew/cask/artifact/abstract_uninstall.rb
@@ -324,20 +324,27 @@ def trash_paths(*paths, command: nil, **_) set item i of argv to (item i of argv as POSIX file) end repeat - tell application "Finder" - set trashedItems to (move argv to trash) - set output to "" - - repeat with i from 1 to (count trashedItems) - set trashedItem to POSIX path of (item i of trashedItems as string) - set output to output & trashedItem - if i < count trashedItems then - set output to output & character id 0 - end if - end repeat - - return output - end tell + try + with timeout of 30 seconds + tell application "Finder" + set trashedItems to (move argv to trash) + set output to "" + + repeat with i from 1 to (count trashedItems) + set trashedItem to POSIX path of (item i of trashedItems as string) + set output to output & trashedItem + if i < count trashedItems then + set output to output & character id 0 + end if + end repeat + + return output + end tell + end timeout + on error + -- Ignore errors (probably running under Azure) + return 0 + end try end run APPLESCRIPT
false
Other
Homebrew
brew
d666b8554d8f59d06cfb6c284c220b6e3254f4bc.json
Taps: remove references to pinning. Addresses https://github.com/Homebrew/brew/issues/6110
docs/Taps.md
@@ -53,42 +53,28 @@ dunn/emacs version: `brew tap username/homebrew-foobar`. `brew` will automatically add back the 'homebrew-' prefix whenever it's necessary. -## Formula duplicate names +## Formula with duplicate names If your tap contains a formula that is also present in [homebrew/core](https://github.com/Homebrew/homebrew-core), that's fine, but it means that you must install it explicitly by default. -If you would like to prioritise a tap over `homebrew/core`, you can use -`brew tap-pin username/repo` to pin the tap, -and use `brew tap-unpin username/repo` to revert the pin. - Whenever a `brew install foo` command is issued, `brew` will find which formula to use by searching in the following order: -* pinned taps * core formulae * other taps If you need a formula to be installed from a particular tap, you can use fully qualified names to refer to them. -For example, you can create a tap for an alternative `vim` formula. Without -pinning it, the behaviour will be: +You can create a tap for an alternative `vim` formula. The behaviour will be: ```sh brew install vim # installs from homebrew/core brew install username/repo/vim # installs from your custom repository ``` -However if you pin the tap with `brew tap-pin username/repo`, you will need to -use `homebrew/core` to refer to the core formula. - -```sh -brew install vim # installs from your custom repository -brew install homebrew/core/vim # installs from homebrew/core -``` - -Note that pinned taps are prioritized only when the formula name is directly -given by you, i.e. it will not influence formulae automatically installed as -dependencies. +As a result, we recommend you give formulae a different name if you want to make +them easier to install. Note that there is (intentionally) no way of replacing +dependencies of core formulae with those from taps.
false
Other
Homebrew
brew
9d4e1a53f5cdf5061febbb8d4aa10127c7bb6995.json
Add doc of HOMEBREW_ARCH
Library/Homebrew/manpages/brew.1.md.erb
@@ -115,6 +115,10 @@ Note that environment variables must have a value set to be detected. For exampl `export HOMEBREW_NO_INSECURE_REDIRECT=1` rather than just `export HOMEBREW_NO_INSECURE_REDIRECT`. + * `HOMEBREW_ARCH`: + If set, Homebrew will pass cpu type name to compiler by `-march` option instead of + `-march=native`. This is affected on Linux only. + * `HOMEBREW_ARTIFACT_DOMAIN`: If set, instructs Homebrew to prefix all download URLs, including those for bottles, with this variable. For example, `HOMEBREW_ARTIFACT_DOMAIN=http://localhost:8080`
true
Other
Homebrew
brew
9d4e1a53f5cdf5061febbb8d4aa10127c7bb6995.json
Add doc of HOMEBREW_ARCH
docs/Manpage.md
@@ -992,6 +992,10 @@ Note that environment variables must have a value set to be detected. For exampl `export HOMEBREW_NO_INSECURE_REDIRECT=1` rather than just `export HOMEBREW_NO_INSECURE_REDIRECT`. + * `HOMEBREW_ARCH`: + If set, Homebrew will pass cpu type name to compiler by `-march` option instead of + `-march=native`. This is affected on Linux only. + * `HOMEBREW_ARTIFACT_DOMAIN`: If set, instructs Homebrew to prefix all download URLs, including those for bottles, with this variable. For example, `HOMEBREW_ARTIFACT_DOMAIN=http://localhost:8080`
true
Other
Homebrew
brew
9d4e1a53f5cdf5061febbb8d4aa10127c7bb6995.json
Add doc of HOMEBREW_ARCH
manpages/brew-cask.1
@@ -1,7 +1,7 @@ .\" generated with Ronn/v0.7.3 .\" http://github.com/rtomayko/ronn/tree/0.7.3 . -.TH "BREW\-CASK" "1" "April 2019" "Homebrew" "brew-cask" +.TH "BREW\-CASK" "1" "May 2019" "Homebrew" "brew-cask" . .SH "NAME" \fBbrew\-cask\fR \- a friendly binary installer for macOS
true
Other
Homebrew
brew
9d4e1a53f5cdf5061febbb8d4aa10127c7bb6995.json
Add doc of HOMEBREW_ARCH
manpages/brew.1
@@ -1,7 +1,7 @@ .\" generated with Ronn/v0.7.3 .\" http://github.com/rtomayko/ronn/tree/0.7.3 . -.TH "BREW" "1" "April 2019" "Homebrew" "brew" +.TH "BREW" "1" "May 2019" "Homebrew" "brew" . .SH "NAME" \fBbrew\fR \- The missing package manager for macOS @@ -1225,6 +1225,10 @@ Homebrew can install formulae via URL, e\.g\. \fBhttps://raw\.githubusercontent\ Note that environment variables must have a value set to be detected\. For example, \fBexport HOMEBREW_NO_INSECURE_REDIRECT=1\fR rather than just \fBexport HOMEBREW_NO_INSECURE_REDIRECT\fR\. . .TP +\fBHOMEBREW_ARCH\fR +If set, Homebrew will pass cpu type name to compiler by \fB\-march\fR option instead of \fB\-march=native\fR\. This is affected on Linux only\. +. +.TP \fBHOMEBREW_ARTIFACT_DOMAIN\fR If set, instructs Homebrew to prefix all download URLs, including those for bottles, with this variable\. For example, \fBHOMEBREW_ARTIFACT_DOMAIN=http://localhost:8080\fR will cause a formula with the URL \fBhttps://example\.com/foo\.tar\.gz\fR to instead download from \fBhttp://localhost:8080/example\.com/foo\.tar\.gz\fR\. .
true
Other
Homebrew
brew
9f616b6fe977b6e6709c17b7df26cdfb4cbfd5f4.json
cmd/tap-info: fix frozen pathname usage
Library/Homebrew/cmd/tap-info.rb
@@ -62,7 +62,7 @@ def print_tap_info(taps) info += ", #{private_count} private" info += ", #{formula_count} #{"formula".pluralize(formula_count)}" info += ", #{command_count} #{"command".pluralize(command_count)}" - info += ", #{Tap::TAP_DIRECTORY.abv}" if Tap::TAP_DIRECTORY.directory? + info += ", #{Tap::TAP_DIRECTORY.dup.abv}" if Tap::TAP_DIRECTORY.directory? puts info else taps.each_with_index do |tap, i|
false
Other
Homebrew
brew
cd40af2c5842e83b8dde68dc16ef4e0985b51f52.json
ARGV: fix build_head? call. Fixes #6087.
Library/Homebrew/extend/ARGV.rb
@@ -185,7 +185,7 @@ def env def collect_build_flags build_flags = [] - build_flags << "--HEAD" if build_head? + build_flags << "--HEAD" if include?("--HEAD") build_flags << "--universal" if build_universal? build_flags << "--build-bottle" if build_bottle? build_flags << "--build-from-source" if build_from_source?
false
Other
Homebrew
brew
01a342550285a92d8eef84e27721389c40029f76.json
Require Xcode 10.2 on macOS 10.14 Xcode >=10.2 is required to build all Swift formulae on macOS >=10.14.4. Rather than requiring per-formula workarounds (e.g. Homebrew/homebrew-core#39446) this provides a more stable platform Homebrew can rely on for building Swift formulae.
Library/Homebrew/os/mac/xcode.rb
@@ -27,7 +27,7 @@ def latest_version def minimum_version case MacOS.version - when "10.14" then "10.0" + when "10.14" then "10.2" when "10.13" then "9.0" when "10.12" then "8.0" else "2.0"
true
Other
Homebrew
brew
01a342550285a92d8eef84e27721389c40029f76.json
Require Xcode 10.2 on macOS 10.14 Xcode >=10.2 is required to build all Swift formulae on macOS >=10.14.4. Rather than requiring per-formula workarounds (e.g. Homebrew/homebrew-core#39446) this provides a more stable platform Homebrew can rely on for building Swift formulae.
Library/Homebrew/requirements/xcode_requirement.rb
@@ -14,7 +14,6 @@ def initialize(tags = []) def xcode_installed_version return false unless MacOS::Xcode.installed? - return false unless xcode_swift_compatability? return true unless @version MacOS::Xcode.version >= @version @@ -26,12 +25,6 @@ def message A full installation of Xcode.app#{version} is required to compile this software. Installing just the Command Line Tools is not sufficient. EOS - unless xcode_swift_compatability? - message += <<~EOS - - Xcode >=10.2 requires macOS >=10.14.4 to build many formulae. - EOS - end if @version && Version.new(MacOS::Xcode.latest_version) < Version.new(@version) message + <<~EOS @@ -49,15 +42,4 @@ def message def inspect "#<#{self.class.name}: #{tags.inspect} version=#{@version.inspect}>" end - - private - - # TODO: when 10.14.4 and 10.2 have been around for long enough remove this - # method in favour of requiring 10.14.4 and 10.2. - def xcode_swift_compatability? - return true if MacOS::Xcode.version < "10.2" - return true if MacOS.full_version >= "10.14.4" - - MacOS.full_version < "10.14" - end end
true
Other
Homebrew
brew
2f21de596fa11e6a6113d367393d734ce08208a9.json
Fix bad mutable call on a frozen string.
Library/Homebrew/build_environment.rb
@@ -59,7 +59,7 @@ def dump_build_env(env, f = $stdout) s = "#{key}: #{value}" case key when "CC", "CXX", "LD" - s << " => #{Pathname.new(value).realpath}" if File.symlink?(value) + s += " => #{Pathname.new(value).realpath}" if File.symlink?(value) end f.puts s end
false
Other
Homebrew
brew
73528b6a08cb26e326300a1cb4b6743b6d25719c.json
Freeze more strings Freeze the results changed in #6072.
Library/Homebrew/cask/exceptions.rb
@@ -182,7 +182,7 @@ def to_s s << "\n" unless reason.end_with?("\n") end - s + s.freeze end end @@ -196,7 +196,7 @@ def to_s s << "\n" unless reason.end_with?("\n") end - s + s.freeze end end @@ -210,7 +210,7 @@ def to_s s << "\n" unless reason.end_with?("\n") end - s + s.freeze end end end
true
Other
Homebrew
brew
73528b6a08cb26e326300a1cb4b6743b6d25719c.json
Freeze more strings Freeze the results changed in #6072.
Library/Homebrew/cmd/gist-logs.rb
@@ -90,7 +90,7 @@ def brief_build_info(f) s << "Host: #{hostname}\n" end s << "Build date: #{build_time_str}\n" - s + s.freeze end # Causes some terminals to display secure password entry indicators
true
Other
Homebrew
brew
85c3b55e2b77975370dcd0c07b953d281a9c8d07.json
Fix exception in exception.
Library/Homebrew/cask/exceptions.rb
@@ -174,7 +174,7 @@ def initialize(path, reason) end def to_s - s = "Failed to quarantine #{path}." + s = +"Failed to quarantine #{path}." unless reason.empty? s << " Here's the reason:\n" @@ -188,7 +188,7 @@ def to_s class CaskQuarantinePropagationError < CaskQuarantineError def to_s - s = "Failed to quarantine one or more files within #{path}." + s = +"Failed to quarantine one or more files within #{path}." unless reason.empty? s << " Here's the reason:\n" @@ -202,7 +202,7 @@ def to_s class CaskQuarantineReleaseError < CaskQuarantineError def to_s - s = "Failed to release #{path} from quarantine." + s = +"Failed to release #{path} from quarantine." unless reason.empty? s << " Here's the reason:\n"
false
Other
Homebrew
brew
5c83729be96a852927fe7c44cd089ce243f01c7f.json
Fix mutable string syntax
Library/Homebrew/utils/github.rb
@@ -47,7 +47,7 @@ def pretty_ratelimit_reset(reset) class AuthenticationFailedError < Error def initialize(github_message) @github_message = github_message - message += "GitHub #{github_message}:" + message = +"GitHub #{github_message}:" if ENV["HOMEBREW_GITHUB_API_TOKEN"] message << <<~EOS HOMEBREW_GITHUB_API_TOKEN may be invalid or expired; check:
false
Other
Homebrew
brew
261e2e79262337aaad504dfc5240cd2d2d77d71b.json
utils/github: fix frozen string usage. See https://discourse.brew.sh/t/error-cant-modify-frozen-string/4691/4
Library/Homebrew/utils/github.rb
@@ -47,7 +47,7 @@ def pretty_ratelimit_reset(reset) class AuthenticationFailedError < Error def initialize(github_message) @github_message = github_message - message = "GitHub #{github_message}:" + message += "GitHub #{github_message}:" if ENV["HOMEBREW_GITHUB_API_TOKEN"] message << <<~EOS HOMEBREW_GITHUB_API_TOKEN may be invalid or expired; check: @@ -63,7 +63,7 @@ def initialize(github_message) #{Utils::Shell.set_variable_in_profile("HOMEBREW_GITHUB_API_TOKEN", "your_token_here")} EOS end - super message + super message.freeze end end
false
Other
Homebrew
brew
70b07a914fa5d7c713f517111ffe490775b11b71.json
cmd/info: fix frozen pathname usage. Fixes #6055.
Library/Homebrew/cmd/info.rb
@@ -73,7 +73,7 @@ def print_info output_analytics elsif HOMEBREW_CELLAR.exist? count = Formula.racks.length - puts "#{count} #{"keg".pluralize(count)}, #{HOMEBREW_CELLAR.abv}" + puts "#{count} #{"keg".pluralize(count)}, #{HOMEBREW_CELLAR.dup.abv}" end else ARGV.named.each_with_index do |f, i|
false
Other
Homebrew
brew
e3615add8c8289e3baa99d6b316ab78b54b3edc4.json
python_virtualenv_constants: upgrade virtualenv to 16.5.0
Library/Homebrew/language/python_virtualenv_constants.rb
@@ -1,8 +1,8 @@ # frozen_string_literal: true PYTHON_VIRTUALENV_URL = - "https://files.pythonhosted.org/packages/37/db" \ - "/89d6b043b22052109da35416abc3c397655e4bd3cff031446ba02b9654fa" \ - "/virtualenv-16.4.3.tar.gz" + "https://files.pythonhosted.org/packages/6a/56" \ + "/74dce1fdeeabbcc0a3fcf299115f6814bd9c39fc4161658b513240a75ea7" \ + "/virtualenv-16.5.0.tar.gz" PYTHON_VIRTUALENV_SHA256 = - "984d7e607b0a5d1329425dd8845bd971b957424b5ba664729fab51ab8c11bc39" + "15ee248d13e4001a691d9583948ad3947bcb8a289775102e4c4aa98a8b7a6d73"
false
Other
Homebrew
brew
6325db9e37c4ea55ea82a8e6be767b119e403e87.json
utils: fix frozen string usage in odeprecated. Fixes https://github.com/Homebrew/brew/issues/6053
Library/Homebrew/utils.rb
@@ -107,7 +107,7 @@ def odeprecated(method, replacement = nil, disable: false, disable_on: nil, call next unless match = line.match(HOMEBREW_TAP_PATH_REGEX) tap = Tap.fetch(match[:user], match[:repo]) - tap_message = "\nPlease report this to the #{tap} tap" + tap_message = +"\nPlease report this to the #{tap} tap" tap_message += ", or even better, submit a PR to fix it" if replacement tap_message << ":\n #{line.sub(/^(.*\:\d+)\:.*$/, '\1')}\n\n" break
false
Other
Homebrew
brew
7a8a3a30d7e42984b0c8eb2667d993496b8ec980.json
docs/Formula-Cookbook: add more details to tests
docs/Formula-Cookbook.md
@@ -257,7 +257,25 @@ function. The environment variable `HOME` is set to [`testpath`](https://rubydoc We want tests that don't require any user input and test the basic functionality of the application. For example `foo build-foo input.foo` is a good test and (despite their widespread use) `foo --version` and `foo --help` are bad tests. However, a bad test is better than no test at all. -See [`cmake`](https://github.com/Homebrew/homebrew-core/blob/master/Formula/cmake.rb) for an example of a formula with a good test. The formula writes a basic `CMakeLists.txt` file into the test directory then calls CMake to generate Makefiles. This test checks that CMake doesn't e.g. segfault during basic operation. Another good example is [`tinyxml2`](https://github.com/Homebrew/homebrew-core/blob/master/Formula/tinyxml2.rb), which writes a small C++ source file into the test directory, compiles and links it against the tinyxml2 library and finally checks that the resulting program runs successfully. +See [`cmake`](https://github.com/Homebrew/homebrew-core/blob/master/Formula/cmake.rb) for an example of a formula with a good test. The formula writes a basic `CMakeLists.txt` file into the test directory then calls CMake to generate Makefiles. This test checks that CMake doesn't e.g. segfault during basic operation. + +You can check that the output is as expected with `assert_equal` or `assert_match` on the output of shell_output such as in this example from the [envv formula](https://github.com/Homebrew/homebrew-core/blob/master/Formula/envv.rb): + +```ruby +assert_equal "mylist=A:C; export mylist", shell_output("#{bin}/envv del mylist B").strip +``` + +You can also check that an output file was created: + +```ruby +assert_predicate testpath/"output.txt", :exist? +``` + +Some advice for specific cases: +* If the formula is a library, compile and run some simple code that links against it. It could be taken from upstream's documentation / source examples. +A good example is [`tinyxml2`](https://github.com/Homebrew/homebrew-core/blob/master/Formula/tinyxml2.rb), which writes a small C++ source file into the test directory, compiles and links it against the tinyxml2 library and finally checks that the resulting program runs successfully. +* If the formula is for a GUI program, try to find some function that runs as command-line only, like a format conversion, reading or displaying a config file, etc. +* If the software cannot function without credentials or requires a virtual machine, docker instance, etc. to run, a test could be to try to connect with invalid credentials (or without credentials) and confirm that it fails as expected. ### Manuals
false
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/Gemfile
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + source "https://rubygems.org" # installed gems
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/PATH.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + class PATH include Enumerable extend Forwardable
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/brew.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + raise "HOMEBREW_BREW_FILE was not exported! Please call bin/brew directly!" unless ENV["HOMEBREW_BREW_FILE"] std_trap = trap("INT") { exit! 130 } # no backtrace thanks
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/build.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + # This script is loaded by formula_installer as a separate instance. # Thrown exceptions are propagated back to the parent process over a pipe
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/build_environment.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + class BuildEnvironment def initialize(*settings) @settings = Set.new(*settings)
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/build_options.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + class BuildOptions # @private def initialize(args, options)
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cache_store.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "json" #
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/all.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "hardware" require "cask/artifact"
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/app" require "cask/artifact/artifact" # generic 'artifact' stanza require "cask/artifact/binary"
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/abstract_artifact.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + module Cask module Artifact class AbstractArtifact
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/abstract_flight_block.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/abstract_artifact" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/abstract_uninstall.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "timeout" require "utils/user"
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/app.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/artifact.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" require "extend/hash_validator"
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/audio_unit_plugin.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/binary.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/symlinked" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/colorpicker.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/dictionary.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/font.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/input_method.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/installer.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/abstract_artifact" require "extend/hash_validator"
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/internet_plugin.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/moved.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/relocated" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/pkg.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "plist" require "utils/user"
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/postflight_block.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/abstract_flight_block" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/preflight_block.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/abstract_flight_block" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/prefpane.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/qlplugin.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/relocated.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/abstract_artifact" require "extend/hash_validator" @@ -50,7 +52,7 @@ def summarize private - ALT_NAME_ATTRIBUTE = "com.apple.metadata:kMDItemAlternateNames".freeze + ALT_NAME_ATTRIBUTE = "com.apple.metadata:kMDItemAlternateNames" # Try to make the asset searchable under the target name. Spotlight # respects this attribute for many filetypes, but ignores it for App
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/screen_saver.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/service.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/stage_only.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/abstract_artifact" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/suite.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/symlinked.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/relocated" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/uninstall.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/abstract_uninstall" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/vst3_plugin.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/vst_plugin.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/moved" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/artifact/zap.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/artifact/abstract_uninstall" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/audit.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/checkable" require "cask/download" require "digest"
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/auditor.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/download" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/cache.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + module Cask module Cache module_function
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/cask.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/cask_loader" require "cask/config" require "cask/dsl"
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/cask_dependencies.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "delegate" require "cask/topological_hash"
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/cask_loader.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/cask" require "uri"
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/caskroom.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "utils/user" module Cask
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/checkable.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + module Cask module Checkable def errors
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/cmd.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "optparse" require "shellwords"
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/cmd/abstract_command.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require_relative "options" require "search"
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/cmd/abstract_internal_command.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + module Cask class Cmd class AbstractInternalCommand < AbstractCommand
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/cmd/audit.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + module Cask class Cmd class Audit < AbstractCommand
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/cmd/cat.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + module Cask class Cmd class Cat < AbstractCommand
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/cmd/create.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + module Cask class Cmd class Create < AbstractCommand
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/cmd/doctor.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "system_config" require "cask/checkable"
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/cmd/edit.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + module Cask class Cmd class Edit < AbstractCommand
true
Other
Homebrew
brew
36dbad3922ad984f7c396a9757fe8ae9750c44b0.json
Add frozen_string_literal to all files.
Library/Homebrew/cask/cmd/fetch.rb
@@ -1,3 +1,5 @@ +# frozen_string_literal: true + require "cask/download" module Cask
true