language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | Homebrew | brew | 363355ae47d323a6f2328d0776d9b4091b5d93e1.json | CompilerSelector: prefer the gcc verion offered by the gcc formula
When GCC is used (default for Linux), we should prefer the gcc offered
by the gcc formula. As such even if users install a gcc with higher
version from `gcc@*` formula, it will not be picked up to build other
formulae. This would also allow users to sa... | Library/Homebrew/compilers.rb | @@ -105,11 +105,19 @@ def compiler
private
+ def gnu_gcc_versions
+ # prioritize gcc version provided by gcc formula.
+ v = Formulary.factory("gcc").version.to_s.slice(/\d/)
+ GNU_GCC_VERSIONS - [v] + [v] # move the version to the end of the list
+ rescue FormulaUnavailableError
+ GNU_GCC_VERSIONS
... | true |
Other | Homebrew | brew | 363355ae47d323a6f2328d0776d9b4091b5d93e1.json | CompilerSelector: prefer the gcc verion offered by the gcc formula
When GCC is used (default for Linux), we should prefer the gcc offered
by the gcc formula. As such even if users install a gcc with higher
version from `gcc@*` formula, it will not be picked up to build other
formulae. This would also allow users to sa... | Library/Homebrew/test/compiler_selector_spec.rb | @@ -39,6 +39,12 @@
expect(subject.compiler).to eq("gcc-7")
end
+ it "returns gcc-6 if gcc formula offers gcc-6" do
+ software_spec.fails_with(:clang)
+ allow(Formulary).to receive(:factory).with("gcc").and_return(double(version: "6.0"))
+ expect(subject.compiler).to eq("gcc-6")
+ end
... | true |
Other | Homebrew | brew | c59c03e2f873201fbe5344eb0e02281e0e1df745.json | Remove search from brew-cask man page
`brew cask` no longer supports the `search` command and was removed from
the `homebrew/brew-cask` documentation. However, it's still in the
`brew` man page for `brew-cask`.
Remove search from the man page. | Library/Homebrew/manpages/brew-cask.1.md | @@ -19,13 +19,6 @@ graphical user interface.
* `uninstall` [--force] <token> [ <token> ... ]:
Uninstall Cask identified by <token>.
- * `search` <text> | /<regexp>/:
- Perform a substring search of known Cask tokens for <text>. If the text
- is delimited by slashes, it is interpreted as a Ruby regular ... | true |
Other | Homebrew | brew | c59c03e2f873201fbe5344eb0e02281e0e1df745.json | Remove search from brew-cask man page
`brew cask` no longer supports the `search` command and was removed from
the `homebrew/brew-cask` documentation. However, it's still in the
`brew` man page for `brew-cask`.
Remove search from the man page. | manpages/brew-cask.1 | @@ -22,13 +22,6 @@ Install Cask identified by \fItoken\fR\.
\fBuninstall\fR [\-\-force] \fItoken\fR [ \fItoken\fR \.\.\. ]
Uninstall Cask identified by \fItoken\fR\.
.
-.TP
-\fBsearch\fR \fItext\fR | /\fIregexp\fR/
-Perform a substring search of known Cask tokens for \fItext\fR\. If the text is delimited by slashes,... | true |
Other | Homebrew | brew | 774adaf43537c536ccdaaf0ffe0b208d737d44cc.json | exceptions: remove unused scp exception.
The code was removed but the exception was not. | Library/Homebrew/exceptions.rb | @@ -512,13 +512,6 @@ def initialize(url)
end
end
-# Raised in {ScpDownloadStrategy#fetch}.
-class ScpDownloadStrategyError < RuntimeError
- def initialize(cause)
- super "Download failed: #{cause}"
- end
-end
-
# Raised by {#safe_system} in `utils.rb`.
class ErrorDuringExecution < RuntimeError
attr_read... | false |
Other | Homebrew | brew | 9f33a9b1be1ea6d135205ecbd25f7fb21b49181c.json | brew.sh: improve Docker whitelist on Azure pipelines. | Library/Homebrew/brew.sh | @@ -355,8 +355,8 @@ fi
check-run-command-as-root() {
[[ "$(id -u)" = 0 ]] || return
- # Allow Docker to do everything as root (as it's normal there)
- [[ -f /proc/1/cgroup ]] && grep docker -q /proc/1/cgroup && return
+ # Allow Azure Pipelines/Docker to do everything as root (as it's normal there)
+ [[ -f /pr... | false |
Other | Homebrew | brew | 028b8b408dd959bb4ade72cf2365f92a68e3df6d.json | Remove use of bash | Library/Homebrew/dev-cmd/extract.rb | @@ -81,7 +81,8 @@ def extract_args
Look through repository history to find the most recent version of <formula> and
create a copy in <tap>`/Formula/`<formula>`@`<version>`.rb`. If the tap is not
- installed yet, attempt to install/clone the tap before continuing.
+ installed yet, attem... | true |
Other | Homebrew | brew | 028b8b408dd959bb4ade72cf2365f92a68e3df6d.json | Remove use of bash | Library/Homebrew/test/dev-cmd/extract_spec.rb | @@ -1,5 +1,5 @@
describe "brew extract", :integration_test do
- it "retrieves the specified version of formula from core tap, defaulting to most recent" do
+ it "retrieves the specified version of formula, defaulting to most recent" do
path = Tap::TAP_DIRECTORY/"homebrew/homebrew-foo"
(path/"Formula").mkpa... | true |
Other | Homebrew | brew | 028b8b408dd959bb4ade72cf2365f92a68e3df6d.json | Remove use of bash | Library/Homebrew/utils/git.rb | @@ -4,7 +4,11 @@ module Git
module_function
def last_revision_commit_of_file(repo, file, before_commit: nil)
- args = [before_commit.nil? ? "--skip=1" : before_commit.split("..").first]
+ args = if before_commit.nil?
+ ["--skip=1"]
+ else
+ [before_commit.split("..").first]
+ end
ou... | true |
Other | Homebrew | brew | 028b8b408dd959bb4ade72cf2365f92a68e3df6d.json | Remove use of bash | docs/Manpage.md | @@ -785,7 +785,8 @@ Homebrew repository for editing if no *`formula`* is provided.
Look through repository history to find the most recent version of *`formula`* and
create a copy in *`tap`*`/Formula/`*`formula`*`@`*`version`*`.rb`. If the tap is not
-installed yet, attempt to install/clone the tap before continuin... | true |
Other | Homebrew | brew | 028b8b408dd959bb4ade72cf2365f92a68e3df6d.json | Remove use of bash | manpages/brew.1 | @@ -985,7 +985,7 @@ Generate the new formula in the provided tap, specified as \fIuser\fR\fB/\fR\fIr
Open a formula in the editor set by \fBEDITOR\fR or \fBHOMEBREW_EDITOR\fR, or open the Homebrew repository for editing if no \fIformula\fR is provided\.
.
.SS "\fBextract\fR [\fIoptions\fR] \fIformula\fR \fItap\fR"
-... | true |
Other | Homebrew | brew | 021468c8c0b5d587d6102535be2d4dc66d3b5863.json | bump-formula-pr: improve no formula output.
This means the help text will be output. | Library/Homebrew/dev-cmd/bump-formula-pr.rb | @@ -109,7 +109,7 @@ def bump_formula_pr
odie "Couldn't guess formula for sure: could be one of these:\n#{guesses}"
end
end
- odie "No formula found!" unless formula
+ raise FormulaUnspecifiedError unless formula
check_for_duplicate_pull_requests(formula) unless checked_for_duplicates
| false |
Other | Homebrew | brew | fbaa0c35a6668b31b74af3a890d5449a446bb93a.json | bump-formula-pr: move auto-update to brew.sh
It’s always run anyway but this at least means Homebrew/brew and tap code is all up to date before we start querying any objects.
Fixes #5876. | Library/Homebrew/brew.sh | @@ -420,6 +420,7 @@ update-preinstall() {
[[ -z "$HOMEBREW_UPDATE_PREINSTALL" ]] || return
if [[ "$HOMEBREW_COMMAND" = "install" || "$HOMEBREW_COMMAND" = "upgrade" ||
+ "$HOMEBREW_COMMAND" = "bump-formula-pr" ||
"$HOMEBREW_COMMAND" = "tap" && $HOMEBREW_ARG_COUNT -gt 1 ||
"$HOMEBREW_CASK... | true |
Other | Homebrew | brew | fbaa0c35a6668b31b74af3a890d5449a446bb93a.json | bump-formula-pr: move auto-update to brew.sh
It’s always run anyway but this at least means Homebrew/brew and tap code is all up to date before we start querying any objects.
Fixes #5876. | Library/Homebrew/dev-cmd/bump-formula-pr.rb | @@ -166,12 +166,6 @@ def bump_formula_pr
end
end
- if args.dry_run?
- ohai "brew update"
- else
- safe_system "brew", "update"
- end
-
old_formula_version = formula_version(formula, requested_spec)
replacement_pairs = [] | true |
Other | Homebrew | brew | 803ea4ed1a8d7c4710f7b0e91f393c2ec1970ba1.json | tab#to_json: allow zero parameters. | Library/Homebrew/tab.rb | @@ -324,7 +324,7 @@ def source_modified_time
Time.at(super)
end
- def to_json(_opts)
+ def to_json(options = nil)
attributes = {
"homebrew_version" => homebrew_version,
"used_options" => used_options.as_flags,
@@ -344,7 +344,7 @@ def to_json(_opts)
"source" ... | false |
Other | Homebrew | brew | 56ac7ed58b0aa3ed7e05a62b6a18f8e6f6624bfe.json | man: omit global options from shell command usage
When reading the comment header of a shell command, omit options that
are in Homebrew::CLI::Parser.global_options, since they are documented
separately for all commands. | Library/Homebrew/dev-cmd/man.rb | @@ -195,6 +195,9 @@ def cmd_comment_manpage_lines(cmd_path)
line = line.slice(4..-1)
next unless line
+ # Omit the common global_options documented separately in the man page.
+ next if line =~ /--(debug|force|help|quiet|verbose) /
+
# Format one option or a comma-separated pair of shor... | true |
Other | Homebrew | brew | 56ac7ed58b0aa3ed7e05a62b6a18f8e6f6624bfe.json | man: omit global options from shell command usage
When reading the comment header of a shell command, omit options that
are in Homebrew::CLI::Parser.global_options, since they are documented
separately for all commands. | docs/Manpage.md | @@ -540,9 +540,6 @@ Fetch the newest version of Homebrew and all formulae from GitHub using `git`(1)
* `--merge`:
`git merge` is used to include updates (rather than `git rebase`).
-* `--force`:
- Always do a slower, full update check (even if unnecessary).
-
### `update-reset` [*`repository`*]
Fetches and res... | true |
Other | Homebrew | brew | 56ac7ed58b0aa3ed7e05a62b6a18f8e6f6624bfe.json | man: omit global options from shell command usage
When reading the comment header of a shell command, omit options that
are in Homebrew::CLI::Parser.global_options, since they are documented
separately for all commands. | manpages/brew.1 | @@ -660,10 +660,6 @@ Fetch the newest version of Homebrew and all formulae from GitHub using \fBgit\f
\fB\-\-merge\fR
\fBgit merge\fR is used to include updates (rather than \fBgit rebase\fR)\.
.
-.TP
-\fB\-\-force\fR
-Always do a slower, full update check (even if unnecessary)\.
-.
.SS "\fBupdate\-reset\fR [\fIrep... | true |
Other | Homebrew | brew | 705f03ef9f8576016853bdc34c63a053e9bce986.json | info: support analytics for cask-install | Library/Homebrew/cmd/info.rb | @@ -26,7 +26,7 @@ def info_args
flag "--category",
depends_on: "--analytics",
description: "The value for `category` must be `install`, `install-on-request`, "\
- "`build-error` or `os-version`. The default is `install`."
+ "`cask-install`, `build-erro... | true |
Other | Homebrew | brew | 705f03ef9f8576016853bdc34c63a053e9bce986.json | info: support analytics for cask-install | docs/Manpage.md | @@ -203,7 +203,7 @@ Display brief statistics for your Homebrew installation.
* `--days`:
The value for `days` must be `30`, `90` or `365`. The default is `30`.
* `--category`:
- The value for `category` must be `install`, `install-on-request`, `build-error` or `os-version`. The default is `install`.
+ The value ... | true |
Other | Homebrew | brew | 705f03ef9f8576016853bdc34c63a053e9bce986.json | info: support analytics for cask-install | manpages/brew.1 | @@ -243,7 +243,7 @@ The value for \fBdays\fR must be \fB30\fR, \fB90\fR or \fB365\fR\. The default i
.
.TP
\fB\-\-category\fR
-The value for \fBcategory\fR must be \fBinstall\fR, \fBinstall\-on\-request\fR, \fBbuild\-error\fR or \fBos\-version\fR\. The default is \fBinstall\fR\.
+The value for \fBcategory\fR must be... | true |
Other | Homebrew | brew | fbb28175d8220ea89556f0275238387f4dfe386a.json | info: use UsageError, extend timeout | Library/Homebrew/cmd/info.rb | @@ -214,7 +214,7 @@ def info_formula(f)
def formulae_api_json(endpoint)
return if ENV["HOMEBREW_NO_ANALYTICS"] || ENV["HOMEBREW_NO_GITHUB_API"]
- output, = curl_output("--max-time", "3",
+ output, = curl_output("--max-time", "5",
"https://formulae.brew.sh/api/#{endpoint}")
return if output.b... | false |
Other | Homebrew | brew | 330015ffbdd766b1af260ae4eb3efa41e6e8c19b.json | Fix incorrect formula name from file name | Library/Homebrew/dev-cmd/extract.rb | @@ -142,7 +142,7 @@ def extract
# The class name has to be renamed to match the new filename,
# e.g. Foo version 1.2.3 becomes FooAT123 and resides in Foo@1.2.3.rb.
- class_name = name.capitalize
+ class_name = Formulary.class_s(name.to_s)
versioned_name = Formulary.class_s("#{class_name}@#{versi... | false |
Other | Homebrew | brew | a8c4136e9edb02e6b637b53357af7a921538c149.json | os/mac: Use delegation for Mach-O methods | Library/Homebrew/os/mac/mach.rb | @@ -2,6 +2,10 @@
require "os/mac/architecture_list"
module MachOShim
+ extend Forwardable
+
+ delegate [:dylib_id, :rpaths, :delete_rpath] => :macho
+
# @private
def macho
@macho ||= begin
@@ -56,18 +60,6 @@ def dynamically_linked_libraries(except: :none)
lcs.map(&:name).map(&:to_s).uniq
end
... | false |
Other | Homebrew | brew | d2dc4e559982774b8e7d1e3eb0cdf40c97180778.json | mac/keg_relocate: Drop unnecessary parens | Library/Homebrew/extend/os/mac/keg_relocate.rb | @@ -79,7 +79,7 @@ def expand_rpath(file, bad_name)
suffix = bad_name.sub(/^@rpath/, "")
file.rpaths.each do |rpath|
- return (rpath/suffix) if (rpath/suffix).exist?
+ return rpath/suffix if (rpath/suffix).exist?
end
opoo "Could not find library #{bad_name} for #{file}" | false |
Other | Homebrew | brew | 27d6cfb12e0a5cac753ab1b1157ebfb9d371f4f3.json | [WIP] mac/keg_relocate: Emulate dylinker behavior
Instead of assuming that #{lib} is the correct RPATH expansion,
test all RPATHS and substitute the first one that works. | Library/Homebrew/extend/os/mac/keg_relocate.rb | @@ -75,6 +75,20 @@ def fix_dynamic_linkage
generic_fix_dynamic_linkage
end
+ def expand_rpath(file, bad_name)
+ suffix = bad_name.sub(/^@rpath/, "")
+
+ # short circuit: we expect lib to be usually correct, so we try it first
+ return (lib + suffix) if (lib + suffix).exist?
+
+ file.rpaths.each d... | false |
Other | Homebrew | brew | 54e6cbb34347a7f03844eae98aa7f856d6e5ac07.json | mac/keg_relocate: Rewrite rpaths in install names | Library/Homebrew/extend/os/mac/keg_relocate.rb | @@ -87,6 +87,8 @@ def fixed_name(file, bad_name)
"@loader_path/#{bad_name}"
elsif file.mach_o_executable? && (lib + bad_name).exist?
"#{lib}/#{bad_name}"
+ elsif bad_name.start_with? "@rpath"
+ bad_name.sub("@rpath", lib)
elsif (abs_name = find_dylib(bad_name)) && abs_name.exist?
... | false |
Other | Homebrew | brew | 5c068ef82cfb3344f10d7ab3c42003069dd000bb.json | elf.rb: avoid corrupted elf files
Some elf files like unittest files or memory dumps may not be completely
readable by readelf.
Readelf will fail after the following message:
readelf: Warning: possibly corrupt ELF header - it has a non-zero program header offset, but no program headers
This patches avoid these files... | Library/Homebrew/os/linux/elf.rb | @@ -133,8 +133,10 @@ def needed_libraries_using_readelf(path)
soname = nil
needed = []
command = ["readelf", "-d", path.expand_path.to_s]
- lines = Utils.safe_popen_read(*command).split("\n")
+ lines = Utils.popen_read(*command, err: :out).split("\n")
lines.each do |s|
+ nex... | false |
Other | Homebrew | brew | e0db3a214ae5601c8158c8a4a41c14bd146f0828.json | docs/_config.yml: shorten search placeholder.
Current one is truncated on macOS. | docs/_config.yml | @@ -22,7 +22,7 @@ defaults:
path: ""
values:
image: /assets/img/homebrew-256x256.png
- search_name: Homebrew Documentation
+ search_name: Documentation
search_site: docs
logo: /assets/img/homebrew-256x256.png | false |
Other | Homebrew | brew | 2ac9242562bb52ca1abbd550aa53a1b6f9897d26.json | docs/_config.yml: enable documentation search.
Set the search placeholder badge, the index and trigger a new GitHub
Pages build (by merging this). | docs/_config.yml | @@ -22,6 +22,8 @@ defaults:
path: ""
values:
image: /assets/img/homebrew-256x256.png
+ search_name: Homebrew Documentation
+ search_site: docs
logo: /assets/img/homebrew-256x256.png
| false |
Other | Homebrew | brew | adb3a17fef865882bdc7a5bd48c2491f99240439.json | Brew: remove prune completion for Bash | completions/bash/brew | @@ -384,16 +384,6 @@ _brew_postinstall() {
__brew_complete_installed
}
-_brew_prune() {
- local cur="${COMP_WORDS[COMP_CWORD]}"
- case "$cur" in
- --*)
- __brewcomp "--dry-run --verbose"
- return
- ;;
- esac
-}
-
_brew_pull() {
local cur="${COMP_WORDS[COMP_CWORD]}"
case "$cur" in | false |
Other | Homebrew | brew | 95c1c8eb615c879f76ea587262f7e586f280bf80.json | completions/zsh: Improve caching behaviour
Fixes #5839
- Eliminate reliance on external utility calls for cache invalidation
- Update cache policy to also invalidate if cache file is >=2 weeks old or if
tap indexes are non-existent
- Do not override any cache policy the user might already have set
- Handle default ... | completions/zsh/_brew | @@ -41,18 +41,19 @@ __brew_formulae_or_ruby_files() {
# completions remain in cache until any tap has new commits
__brew_completion_caching_policy() {
- # rebuild cache if no cache file exists (anyway we cannot proceed further down)
- ! [[ -f "$1" ]] && return 0
- # cache file modification date (seconds since ep... | false |
Other | Homebrew | brew | 141db031933eec278ff6815226fd97de5ac6f3cc.json | vendor-gems: fix output location, also run pristine.
This means the output is consistent and ensures that we get rid of any local cruft when installing. | Library/Homebrew/dev-cmd/vendor-gems.rb | @@ -20,8 +20,11 @@ def vendor_gems
Homebrew.install_bundler!
- ohai "cd #{HOMEBREW_LIBRARY_PATH}/vendor"
+ ohai "cd #{HOMEBREW_LIBRARY_PATH}"
HOMEBREW_LIBRARY_PATH.cd do
+ ohai "bundle pristine"
+ safe_system "bundle", "pristine"
+
ohai "bundle install --standalone"
safe_syst... | false |
Other | Homebrew | brew | aead4a720df0b52725cf0f0eab1f01001df30d77.json | outdated & tap-info: set default value for --json
Matching what's already been done for `brew info`. | Library/Homebrew/cmd/outdated.rb | @@ -19,15 +19,16 @@ def outdated_args
description: "List only the names of outdated brews (takes precedence over `--verbose`)."
switch :verbose,
description: "Display detailed version information."
- flag "--json=",
- description: "Show output in JSON format for provided <version>. ... | true |
Other | Homebrew | brew | aead4a720df0b52725cf0f0eab1f01001df30d77.json | outdated & tap-info: set default value for --json
Matching what's already been done for `brew info`. | Library/Homebrew/cmd/tap-info.rb | @@ -13,10 +13,10 @@ def tap_info_args
EOS
switch "--installed",
description: "Display information on all installed taps."
- flag "--json=",
- description: "Print a JSON representation of <taps>. Currently the only accepted value for "\
- "<version> is `v1`. See the... | true |
Other | Homebrew | brew | aead4a720df0b52725cf0f0eab1f01001df30d77.json | outdated & tap-info: set default value for --json
Matching what's already been done for `brew info`. | docs/Manpage.md | @@ -339,7 +339,7 @@ By default, version information is displayed in interactive shells, and
suppressed otherwise.
* `--json`:
- Show output in JSON format for provided *`version`*. Currently the only accepted value of *`version`* is `v1`.
+ Print output in JSON format. Currently the default and only accepted valu... | true |
Other | Homebrew | brew | aead4a720df0b52725cf0f0eab1f01001df30d77.json | outdated & tap-info: set default value for --json
Matching what's already been done for `brew info`. | manpages/brew-cask.1 | @@ -1,7 +1,7 @@
.\" generated with Ronn/v0.7.3
.\" http://github.com/rtomayko/ronn/tree/0.7.3
.
-.TH "BREW\-CASK" "1" "February 2019" "Homebrew" "brew-cask"
+.TH "BREW\-CASK" "1" "March 2019" "Homebrew" "brew-cask"
.
.SH "NAME"
\fBbrew\-cask\fR \- a friendly binary installer for macOS | true |
Other | Homebrew | brew | aead4a720df0b52725cf0f0eab1f01001df30d77.json | outdated & tap-info: set default value for --json
Matching what's already been done for `brew info`. | manpages/brew.1 | @@ -1,7 +1,7 @@
.\" generated with Ronn/v0.7.3
.\" http://github.com/rtomayko/ronn/tree/0.7.3
.
-.TH "BREW" "1" "February 2019" "Homebrew" "brew"
+.TH "BREW" "1" "March 2019" "Homebrew" "brew"
.
.SH "NAME"
\fBbrew\fR \- The missing package manager for macOS
@@ -438,7 +438,7 @@ By default, version information is d... | true |
Other | Homebrew | brew | b6cbe1afa250fe7f717033f5e25b9c5f7557dcc8.json | docs: linkify some links | docs/Releases.md | @@ -22,14 +22,14 @@ If this is a major or minor release (e.g. X.0.0 or X.Y.0) then there are a few m
1. Before creating the tag you should delete any `odisabled` code, make any
`odeprecated` code `odisabled` and add any new `odeprecations` that are
desired.
-2. Write up a release notes blog post to https://bre... | false |
Other | Homebrew | brew | b796174d2cfb6d912f7d349d800f5a9a77899d36.json | Allow head in new formulas | Library/Homebrew/dev-cmd/audit.rb | @@ -640,18 +640,14 @@ def audit_specs
problem "Formulae should not have a `devel` spec" if formula.devel
- if formula.head
+ if formula.head && @versioned_formula
head_spec_message = "Formulae should not have a `HEAD` spec"
- if @new_formula
- new_formula_problem head_spec_... | false |
Other | Homebrew | brew | 9dbd04ac094c8b47aeba242165fbb810c79de9ed.json | python_virtualenv_constants: upgrade virtualenv to 16.4.3 | Library/Homebrew/language/python_virtualenv_constants.rb | @@ -1,6 +1,6 @@
PYTHON_VIRTUALENV_URL =
- "https://files.pythonhosted.org/packages/51/aa" \
- "/c395a6e6eaaedfa5a04723b6446a1df783b16cca6fec66e671cede514688" \
- "/virtualenv-16.4.0.tar.gz".freeze
+ "https://files.pythonhosted.org/packages/37/db" \
+ "/89d6b043b22052109da35416abc3c397655e4bd3cff031446ba02b9654fa"... | false |
Other | Homebrew | brew | e295570f00536f65375b74ef732a28b9c76d3997.json | Add varenc/ffmpeg to list of interesting taps | docs/Interesting-Taps-and-Forks.md | @@ -6,6 +6,7 @@ Homebrew has the capability to add (and remove) multiple taps to your local inst
Your taps are Git repositories located at `$(brew --repository)/Library/Taps`.
## Unsupported interesting taps
+* [varenc/ffmpeg](https://github.com/varenc/homebrew-ffmpeg): A tap for FFmpeg with additional options, i... | false |
Other | Homebrew | brew | 128300a754eb1539691ce868efbc51b268b9e802.json | utils/gems: install Bundler 2.
Our Gemfile requires it and it will result in a more consistent configuration. | Library/Homebrew/utils/gems.rb | @@ -50,7 +50,7 @@ def setup_gem_environment!(gem_home: nil, gem_bindir: nil)
ENV["PATH"] = paths.compact.join(":")
end
- def install_gem!(name, version = nil, setup_gem_environment: true)
+ def install_gem!(name, version: nil, setup_gem_environment: true)
setup_gem_environment! if setup_gem_environment... | false |
Other | Homebrew | brew | 45c61cdcdbe182d2ed2d8deb8dab2b3ab2507095.json | pull: fix tap name for linuxbrew | Library/Homebrew/dev-cmd/pull.rb | @@ -109,10 +109,10 @@ def pull
elsif (api_match = arg.match HOMEBREW_PULL_API_REGEX)
_, user, repo, issue = *api_match
url = "https://github.com/#{user}/#{repo}/pull/#{issue}"
- tap = Tap.fetch(user, repo) if repo.start_with?("homebrew-")
+ tap = Tap.fetch(user, repo) if repo.matc... | true |
Other | Homebrew | brew | 45c61cdcdbe182d2ed2d8deb8dab2b3ab2507095.json | pull: fix tap name for linuxbrew | Library/Homebrew/tap.rb | @@ -26,7 +26,7 @@ def self.fetch(*args)
# We special case homebrew and linuxbrew so that users don't have to shift in a terminal.
user = user.capitalize if ["homebrew", "linuxbrew"].include? user
- repo = repo.delete_prefix "homebrew-"
+ repo = repo.sub(HOMEBREW_OFFICIAL_REPO_PREFIXES_REGEX, "")
... | true |
Other | Homebrew | brew | 45c61cdcdbe182d2ed2d8deb8dab2b3ab2507095.json | pull: fix tap name for linuxbrew | Library/Homebrew/tap_constants.rb | @@ -8,3 +8,4 @@
HOMEBREW_TAP_PATH_REGEX = Regexp.new(HOMEBREW_TAP_DIR_REGEX.source + %r{(?:/.*)?$}.source)
# match official taps' casks, e.g. homebrew/cask/somecask or homebrew/cask-versions/somecask
HOMEBREW_CASK_TAP_CASK_REGEX = %r{^(?:([Cc]askroom)/(cask|versions)|(homebrew)/(cask|cask-[\w-]+))/([\w+-.]+)$}.freez... | true |
Other | Homebrew | brew | 97958410f453eca9332330a873947e64d4d90f8d.json | dev-cmd/tests: improve parallel args naming. | Library/Homebrew/dev-cmd/tests.rb | @@ -44,6 +44,7 @@ def tests
ENV.delete("HOMEBREW_NO_GITHUB_API")
ENV.delete("HOMEBREW_NO_EMOJI")
ENV.delete("HOMEBREW_DEVELOPER")
+ ENV.delete("HOMEBREW_PRY")
ENV["HOMEBREW_NO_ANALYTICS_THIS_RUN"] = "1"
ENV["HOMEBREW_NO_COMPAT"] = "1" if args.no_compat?
ENV["HOMEBREW_TEST_... | false |
Other | Homebrew | brew | 0c7c45a131251aaef24dfe5e6b803d136d51fbde.json | missing_formula: add message for Asymptote
Per Homebrew/legacy-homebrew#23029, there is no formula for Asymptote
because you may well already have it installed via MacTeX anyway. | Library/Homebrew/missing_formula.rb | @@ -26,6 +26,10 @@ def blacklisted_reason(name)
Minimal installation:
brew cask install basictex
EOS
+ when "asymptote" then <<~EOS
+ Asymptote is bundled with MacTeX. Install it via TeX Live Utility or:
+ tlmgr install asymptote
+ EOS
when "pi... | false |
Other | Homebrew | brew | d959a780d43ba2aa119f557b8750447b295c5e3c.json | use python flock firstly | Library/Homebrew/utils/lock.sh | @@ -45,12 +45,12 @@ _create_lock() {
if [[ -x "$ruby" ]] && "$ruby" -e "exit(RUBY_VERSION >= '1.8.7')"
then
"$ruby" -e "File.new($lock_fd).flock(File::LOCK_EX | File::LOCK_NB) || exit(1)"
- elif [[ -x "$(type -P flock)" ]]
- then
- flock -n "$lock_fd"
elif [[ -x "$python" ]]
then
"$python" -c... | false |
Other | Homebrew | brew | 8abc67a414f6361e9a7ef5d521aab7d951d1c30d.json | vendor-install: Add portable-ruby for aarch64 (ARM64) | Library/Homebrew/cmd/vendor-install.sh | @@ -29,6 +29,11 @@ then
ruby_URL2="https://github.com/Homebrew/homebrew-portable-ruby/releases/download/2.3.7/portable-ruby-2.3.7.x86_64_linux.bottle.tar.gz"
ruby_SHA="9df214085a0e566a580eea3dd9eab14a2a94930ff74fbf97fb1284e905c8921d"
;;
+ aarch64)
+ ruby_URL="$HOMEBREW_BOTTLE_DOMAIN/bottles... | false |
Other | Homebrew | brew | 5e42f6778357f9509f2335c7fe34c5fd5bf5c43a.json | Dockerfile: install zlib headers (for nokogiri gem). | Dockerfile | @@ -13,6 +13,7 @@ RUN apt-get update \
fonts-dejavu-core \
g++ \
git \
+ libz-dev \
locales \
make \
openssh-client \ | false |
Other | Homebrew | brew | aff57599205212b348d3cd0504b53d9d58163b39.json | diagnostic: check cask git origin | Library/Homebrew/diagnostic.rb | @@ -562,6 +562,9 @@ def check_coretap_git_origin
examine_git_origin(CoreTap.instance.path, CoreTap.instance.full_name)
end
+ def check_casktap_git_origin
+ cask = Tap.default_cask_tap
+ examine_git_origin(cask.path, cask.full_name) if cask.installed?
end
def check_co... | false |
Other | Homebrew | brew | 19f6915868cf6c34c822e2f0383a058690e8bf2c.json | .editorconfig: extend rules to non-homebrew taps | .editorconfig | @@ -12,7 +12,7 @@ insert_final_newline = true
[{Library/Homebrew/**.rb,.simplecov}]
trim_trailing_whitespace = true
-[Library/Taps/homebrew/**.rb]
+[Library/Taps/**.rb]
# trailing whitespace is crucial for patches
trim_trailing_whitespace = false
| false |
Other | Homebrew | brew | eeed04fdad87c62efb87079406741a56cf316945.json | diagnostic: Fix check_xdg_data_dirs for Linux
Fix Error: undefined method prepend_variable_in_profile'
for Utils::Shell:Module Did you mean? prepend_path_in_profile | Library/Homebrew/extend/os/linux/diagnostic.rb | @@ -54,7 +54,7 @@ def check_xdg_data_dirs
this variable set to include other locations.
Some programs like `vapigen` may not work correctly.
Consider adding Homebrew's share directory to XDG_DATA_DIRS like so:
- #{Utils::Shell.prepend_variable_in_profile("XDG_DATA_DIRS", HOME... | false |
Other | Homebrew | brew | b3c33d6d5172e6538f1e6388c09bf0cf437cf9c7.json | brew.*: run Bundler immediately when needed.
This is needed to avoid gem conflicts when `global.rb` is loaded for some commands. | Library/Homebrew/brew.rb | @@ -8,6 +8,12 @@
raise "Homebrew must be run under Ruby 2.3! You're running #{RUBY_VERSION}."
end
+# Load Bundler first of all if it's needed to avoid Gem version conflicts.
+if ENV["HOMEBREW_INSTALL_BUNDLER_GEMS_FIRST"]
+ require_relative "utils/gems"
+ Homebrew.install_bundler_gems!
+end
+
# Also define here... | true |
Other | Homebrew | brew | b3c33d6d5172e6538f1e6388c09bf0cf437cf9c7.json | brew.*: run Bundler immediately when needed.
This is needed to avoid gem conflicts when `global.rb` is loaded for some commands. | Library/Homebrew/brew.sh | @@ -309,6 +309,11 @@ then
esac
fi
+if [[ "$HOMEBREW_COMMAND" = "audit" || "$HOMEBREW_COMMAND" = "style" ]]
+then
+ export HOMEBREW_INSTALL_BUNDLER_GEMS_FIRST="1"
+fi
+
# Set HOMEBREW_DEV_CMD_RUN for users who have run a development command.
# This makes them behave like HOMEBREW_DEVELOPERs for brew update.
if... | true |
Other | Homebrew | brew | c16e60ef1eb2d43286300224b4aab5c9a0c4c4f1.json | gitignore: ignore 2.6.0 backports. | .gitignore | @@ -61,6 +61,7 @@
**/vendor/bundle-standalone/ruby/*/gems/backports-*/lib/backports/2.1*
**/vendor/bundle-standalone/ruby/*/gems/backports-*/lib/backports/2.2*
**/vendor/bundle-standalone/ruby/*/gems/backports-*/lib/backports/2.3*
+**/vendor/bundle-standalone/ruby/*/gems/backports-*/lib/backports/2.6*
**/vendor/bun... | false |
Other | Homebrew | brew | bcc92258bda50fad565aa58c8629804acfe25861.json | gitignore: ignore psych gem. | .gitignore | @@ -109,6 +109,7 @@
**/vendor/bundle-standalone/ruby/*/gems/parallel-*/
**/vendor/bundle-standalone/ruby/*/gems/parser-*/
**/vendor/bundle-standalone/ruby/*/gems/powerpack-*/
+**/vendor/bundle-standalone/ruby/*/gems/psych-*/
**/vendor/bundle-standalone/ruby/*/gems/rainbow-*/
**/vendor/bundle-standalone/ruby/*/gems... | false |
Other | Homebrew | brew | f9fda0ffcccccd40dce72f01be8239e2b66266c4.json | Formula.installed: handle more exceptions.
Regardless of the exception we don't want this method to blow up.
Fixes #5770. | Library/Homebrew/formula.rb | @@ -1430,7 +1430,7 @@ def self.installed
@installed ||= racks.flat_map do |rack|
begin
Formulary.from_rack(rack)
- rescue FormulaUnavailableError, TapFormulaAmbiguityError, TapFormulaWithOldnameAmbiguityError
+ rescue
[]
end
end.uniq(&:name) | false |
Other | Homebrew | brew | 50ba2ad93f7b09a653492bcd1c09fb96f5802dfd.json | Support different shells for `brew shellenv` | Library/Homebrew/cmd/shellenv.sh | @@ -7,10 +7,30 @@
#: Consider adding evaluating the output in your dotfiles (e.g. `~/.profile`) with `eval $(brew shellenv)`
homebrew-shellenv() {
- echo "export HOMEBREW_PREFIX=\"$HOMEBREW_PREFIX\""
- echo "export HOMEBREW_CELLAR=\"$HOMEBREW_CELLAR\""
- echo "export HOMEBREW_REPOSITORY=\"$HOMEBREW_REPOSITORY\"... | false |
Other | Homebrew | brew | d4e3fb45cbcab862fa8fd023a9955d5be5058d75.json | missing_formula.rb: add help message for uconv | Library/Homebrew/missing_formula.rb | @@ -95,6 +95,10 @@ def blacklisted_reason(name)
cargo is part of the rust formula:
brew install rust
EOS
+ when "uconv" then <<~EOS
+ uconv is part of the icu4c formula:
+ brew install icu4c
+ EOS
end
end
alias generic_blacklisted... | false |
Other | Homebrew | brew | 67cbb129ffa5b6519be668fe0e61508b1b2d721c.json | diagnostic: warn people about tapped, deprecated taps. | Library/Homebrew/diagnostic.rb | @@ -604,6 +604,18 @@ def check_coretap_git_branch
EOS
end
+ def check_deprecated_official_taps
+ tapped_deprecated_taps =
+ Tap.select(&:official?).map(&:repo) & DEPRECATED_OFFICIAL_TAPS
+ return if tapped_deprecated_taps.empty?
+
+ <<~EOS
+ You have the fol... | false |
Other | Homebrew | brew | c7831a457d738d9723231cae77b30b1b22b39dbc.json | Get brew style to pass | Library/Homebrew/test/cli_parser_spec.rb | @@ -183,8 +183,8 @@
allow(ENV).to receive(:[]).with("HOMEBREW_SWITCH_B").and_return("0")
allow(ENV).to receive(:[])
parser.parse(["--switch-b"])
- expect(Homebrew.args.switch_a?).to be_falsy
- expect(Homebrew.args.switch_b?).to be true
+ expect(Homebrew.args.switch_a).to be_falsy
+ ... | false |
Other | Homebrew | brew | e9c45ff17b406bed50677b5b5eb04d9422343f27.json | Pass additional options to `GitHub.pull_requests`. | Library/Homebrew/utils/github.rb | @@ -287,8 +287,8 @@ def write_access?(repo, user = nil)
["admin", "write"].include?(permission(repo, user)["permission"])
end
- def pull_requests(repo, base:, state: :open, **_options)
- url = "#{API_URL}/repos/#{repo}/pulls?#{URI.encode_www_form(base: base, state: state)}"
+ def pull_requests(repo, **op... | false |
Other | Homebrew | brew | d5f6e4cd34ba2550499876ed4c8988e183b3465c.json | Add info on env variables for Formula Cookbook
This explains the levels of environment variable filtering present in Homebrew, explaining how and why variables without a `HOMEBREW_` prefix or those which contain `TOKEN` etc are made unavailable to a Formula. | docs/Formula-Cookbook.md | @@ -696,6 +696,16 @@ Homebrew provides two formula DSL methods for launchd plist files:
* [`plist_name`](https://www.rubydoc.info/github/Homebrew/brew/master/Formula#plist_name-instance_method) will return e.g. `homebrew.mxcl.<formula>`
* [`plist_path`](https://www.rubydoc.info/github/Homebrew/brew/master/Formula#pli... | false |
Other | Homebrew | brew | b39c5a4e84ce9efa08d19a711d20d72fb5e97acc.json | Dockerfile: Remove environment variable USER | Dockerfile | @@ -34,8 +34,7 @@ RUN cd /home/linuxbrew/.linuxbrew \
WORKDIR /home/linuxbrew
ENV PATH=/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:$PATH \
- SHELL=/bin/bash \
- USER=linuxbrew
+ SHELL=/bin/bash
# Install portable-ruby and tap homebrew/core.
RUN HOMEBREW_NO_ANALYTICS=1 HOMEBREW_NO_AUTO_UPDATE=... | false |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/cask/cask.rb | @@ -11,7 +11,7 @@ class Cask
extend Searchable
include Metadata
- attr_reader :token, :sourcefile_path, :config
+ attr_reader :token, :sourcefile_path
def self.each
return to_enum unless block_given?
@@ -31,7 +31,7 @@ def tap
@tap
end
- def initialize(token, sourcefile_p... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/cask/config.rb | @@ -1,12 +1,8 @@
-module Cask
- class Config
- def self.global
- @global ||= new
- end
-
- attr_reader :binarydir
+require "json"
- def initialize(
+module Cask
+ class Config < DelegateClass(Hash)
+ DEFAULT_DIRS = {
appdir: "/Applications",
prefpanedir: "~/L... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/cask/installer.rb | @@ -39,7 +39,7 @@ def initialize(cask, command: SystemCommand, force: false,
end
attr_predicate :binaries?, :force?, :skip_cask_deps?, :require_sha?,
- :upgrade?, :verbose?, :installed_as_dependency?,
+ :reinstall?, :upgrade?, :verbose?, :installed_as_dependency?,
... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/artifact/alt_target_spec.rb | @@ -11,7 +11,7 @@
}
let(:source_path) { cask.staged_path.join("Caffeine.app") }
- let(:target_path) { Cask::Config.global.appdir.join("AnotherName.app") }
+ let(:target_path) { cask.config.appdir.join("AnotherName.app") }
before do
InstallHelper.install_without_artifacts(cask)
@@ -58,7 +... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/artifact/app_spec.rb | @@ -5,7 +5,7 @@
let(:app) { cask.artifacts.find { |a| a.is_a?(described_class) } }
let(:source_path) { cask.staged_path.join("Caffeine.app") }
- let(:target_path) { Cask::Config.global.appdir.join("Caffeine.app") }
+ let(:target_path) { cask.config.appdir.join("Caffeine.app") }
let(:install_phase) { app.... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/artifact/binary_spec.rb | @@ -5,7 +5,7 @@
end
}
let(:artifacts) { cask.artifacts.select { |a| a.is_a?(described_class) } }
- let(:expected_path) { Cask::Config.global.binarydir.join("binary") }
+ let(:expected_path) { cask.config.binarydir.join("binary") }
after do
FileUtils.rm expected_path if expected_path.exist?
@@ -38... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/artifact/generic_artifact_spec.rb | @@ -10,7 +10,7 @@
}
let(:source_path) { cask.staged_path.join("Caffeine.app") }
- let(:target_path) { Cask::Config.global.appdir.join("Caffeine.app") }
+ let(:target_path) { cask.config.appdir.join("Caffeine.app") }
before do
InstallHelper.install_without_artifacts(cask) | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/artifact/suite_spec.rb | @@ -9,7 +9,7 @@
end
}
- let(:target_path) { Cask::Config.global.appdir.join("Caffeine") }
+ let(:target_path) { cask.config.appdir.join("Caffeine") }
let(:source_path) { cask.staged_path.join("Caffeine") }
before do | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/artifact/two_apps_correct_spec.rb | @@ -11,10 +11,10 @@
}
let(:source_path_mini) { cask.staged_path.join("Caffeine Mini.app") }
- let(:target_path_mini) { Cask::Config.global.appdir.join("Caffeine Mini.app") }
+ let(:target_path_mini) { cask.config.appdir.join("Caffeine Mini.app") }
let(:source_path_pro) { cask.staged_path.join("... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/cmd/install_spec.rb | @@ -21,11 +21,12 @@
it "allows staging and activation of multiple Casks at once" do
described_class.run("local-transmission", "local-caffeine")
-
- expect(Cask::CaskLoader.load(cask_path("local-transmission"))).to be_installed
- expect(Cask::Config.global.appdir.join("Transmission.app")).to be_a_directo... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/cmd/list_spec.rb | @@ -80,9 +80,9 @@
described_class.run("local-transmission", "local-caffeine")
}.to output(<<~EOS).to_stdout
==> Apps
- #{Cask::Config.global.appdir.join("Transmission.app")} (#{Cask::Config.global.appdir.join("Transmission.app").abv})
+ #{transmission.config.appdir.join("Transmiss... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/cmd/uninstall_spec.rb | @@ -51,9 +51,9 @@
described_class.run("local-caffeine", "local-transmission")
expect(caffeine).not_to be_installed
- expect(Cask::Config.global.appdir.join("Transmission.app")).not_to exist
+ expect(caffeine.config.appdir.join("Transmission.app")).not_to exist
expect(transmission).not_to be_insta... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/cmd/upgrade_spec.rb | @@ -147,7 +147,7 @@
it 'does not include the Casks with "auto_updates true" when the version did not change' do
cask = Cask::CaskLoader.load("auto-updates")
- cask_path = Cask::Config.global.appdir.join("MyFancyApp.app")
+ cask_path = cask.config.appdir.join("MyFancyApp.app")
... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/cmd/zap_spec.rb | @@ -23,8 +23,8 @@
described_class.run("local-caffeine", "local-transmission")
expect(caffeine).not_to be_installed
- expect(Cask::Config.global.appdir.join("Caffeine.app")).not_to be_a_symlink
+ expect(caffeine.config.appdir.join("Caffeine.app")).not_to be_a_symlink
expect(transmission).not_to be... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/dsl_spec.rb | @@ -468,7 +468,7 @@ def caveats
let(:token) { "appdir-interpolation" }
it "is allowed" do
- expect(cask.artifacts.first.source).to eq(Cask::Config.global.appdir/"some/path")
+ expect(cask.artifacts.first.source).to eq(cask.config.appdir/"some/path")
end
end
| true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/installer_spec.rb | @@ -10,7 +10,7 @@
Cask::Installer.new(caffeine).install
expect(Cask::Caskroom.path.join("local-caffeine", caffeine.version)).to be_a_directory
- expect(Cask::Config.global.appdir.join("Caffeine.app")).to be_a_directory
+ expect(caffeine.config.appdir.join("Caffeine.app")).to be_a_directory
... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/cask/quarantine_spec.rb | @@ -11,13 +11,11 @@
it "quarantines a nice fresh Cask" do
Cask::Cmd::Install.run("local-transmission")
- expect(
- Cask::CaskLoader.load(cask_path("local-transmission")),
- ).to be_installed
+ cask = Cask::CaskLoader.load(cask_path("local-transmission"))
- expect(
- Cas... | true |
Other | Homebrew | brew | 1e1ce1c471dfaf83c8b3349a29bcb61d20ec8920.json | Save config file for casks. | Library/Homebrew/test/support/helper/spec/shared_context/homebrew_cask.rb | @@ -14,7 +14,7 @@
RSpec.shared_context "Homebrew Cask", :needs_macos do
before do
HOMEBREW_CASK_DIRS.each do |method, path|
- allow(Cask::Config.global).to receive(method).and_return(path)
+ Cask::Config.global.send("#{method}=", path)
end
end
| true |
Other | Homebrew | brew | bf873783d20bfe170d442157c08d615c42fa80af.json | Apply suggestions from code review
Co-Authored-By: MikeMcQuaid <mike@mikemcquaid.com> | docs/New-Maintainer-Checklist.md | @@ -17,7 +17,7 @@ changes (e.g. version updates), triaging, fixing and debugging user-reported
issues, or reviewing user pull requests. You should also be making contributions
to Homebrew at least once per quarter.
-You will should watch or regularly check Homebrew/brew and/or
+You should watch or regularly check H... | true |
Other | Homebrew | brew | bf873783d20bfe170d442157c08d615c42fa80af.json | Apply suggestions from code review
Co-Authored-By: MikeMcQuaid <mike@mikemcquaid.com> | docs/Releases.md | @@ -14,7 +14,7 @@ Homebrew release:
branch you can create a new Git tag. Ideally this should be signed with your
GPG key. This can then be pushed to GitHub.
3. Use `brew release-notes --markdown $PREVIOUS_TAG` to generate the release
- notes for the release. [Create a new release on GitHub](https://github.co... | true |
Other | Homebrew | brew | 1b609ceeb344512319edc50ff72e0d0026f702a7.json | Update maintainer documentation.
- Fix Markdown format
- Note Linux in the mission statement
- Update the maintainer guidelines based on current state
- Loosen the new maintainer expectations
- Clarify what things the PLC should be added to
- Add documentation for making a new Homebrew release | docs/Maintainer-Guidelines.md | @@ -11,7 +11,7 @@ This document is current practice. If you wish to change or discuss any of the b
## Mission
-Homebrew aims to be the missing package manager for macOS. Its primary goal is to be useful to as many people as possible, while remaining maintainable to a professional, high standard by a small group of... | true |
Other | Homebrew | brew | 1b609ceeb344512319edc50ff72e0d0026f702a7.json | Update maintainer documentation.
- Fix Markdown format
- Note Linux in the mission statement
- Update the maintainer guidelines based on current state
- Loosen the new maintainer expectations
- Clarify what things the PLC should be added to
- Add documentation for making a new Homebrew release | docs/New-Maintainer-Checklist.md | @@ -2,24 +2,24 @@
**This is a guide used by existing maintainers to invite new maintainers. You might find it interesting but there's nothing here users should have to know.**
-There's someone who has been making consistently high-quality contributions to Homebrew for a long time and shown themselves able to make ... | true |
Other | Homebrew | brew | 1b609ceeb344512319edc50ff72e0d0026f702a7.json | Update maintainer documentation.
- Fix Markdown format
- Note Linux in the mission statement
- Update the maintainer guidelines based on current state
- Loosen the new maintainer expectations
- Clarify what things the PLC should be added to
- Add documentation for making a new Homebrew release | docs/README.md | @@ -1,6 +1,7 @@
# Documentation
## Users
+
- [`brew` man-page (command documentation)](Manpage.md)
- [Troubleshooting](Troubleshooting.md)
- [Installation](Installation.md)
@@ -27,6 +28,7 @@
- [Kickstarter Supporters](Kickstarter-Supporters.md)
## Contributors
+
- [How To Open A Pull Request (and get it mer... | true |
Other | Homebrew | brew | 1b609ceeb344512319edc50ff72e0d0026f702a7.json | Update maintainer documentation.
- Fix Markdown format
- Note Linux in the mission statement
- Update the maintainer guidelines based on current state
- Loosen the new maintainer expectations
- Clarify what things the PLC should be added to
- Add documentation for making a new Homebrew release | docs/Releases.md | @@ -0,0 +1,39 @@
+# Releases
+
+Since Homebrew 1.0.0 most Homebrew users (those who haven't run a `dev-cmd` or
+set `HOMEBREW_DEVELOPER=1`) require tags on the [Homebrew/brew repository](https://github.com/homebrew/brew)
+in order to get new versions of Homebrew. There are a few steps in making a new
+Homebrew release:... | true |
Other | Homebrew | brew | ea9977f3c3ee45925debd032fdd373440a2c92d1.json | formula_installer: handle attempts to load invalid casks
Certain casks in the main cask repository may be invalid, for whatever
reason. Without handling this exception, the user will get a cask-related
exception while the formula of the same name is installed, and their
installation will abort half-completed.
Fixes #... | Library/Homebrew/formula_installer.rb | @@ -790,7 +790,7 @@ def link(keg)
cask_installed_with_formula_name = begin
Cask::CaskLoader.load(formula.name).installed?
- rescue Cask::CaskUnavailableError
+ rescue Cask::CaskUnavailableError, Cask::CaskInvalidError
false
end
| false |
Other | Homebrew | brew | c44c8da5e0becf02ef6d6180fadb8efa8df69714.json | exceptions.rb: remove unnecessary chomps
remove `chomp!` from method 'initialize' in class 'BuildFlagsError' | Library/Homebrew/exceptions.rb | @@ -463,15 +463,15 @@ def initialize(flags, bottled: true)
require_text = "requires"
end
- message = <<~EOS.chomp!
+ message = <<~EOS
The following #{flag_text}:
#{flags.join(", ")}
#{require_text} building tools, but none are installed.
#{DevelopmentTools.installation_... | false |
Other | Homebrew | brew | db7997e1a0acde9f11ee9ae0b91833f493eff2ef.json | exceptions.rb: move alternative solution to a new line | Library/Homebrew/exceptions.rb | @@ -471,7 +471,7 @@ def initialize(flags, bottled: true)
EOS
message << <<~EOS.chomp! if bottled
- Alternatively, remove the #{flag_text} to attempt bottle installation.
+ \nAlternatively, remove the #{flag_text} to attempt bottle installation.
EOS
super message | false |
Other | Homebrew | brew | 6cac67bcd0850f3c1ec26008ba54c24c1d26d762.json | python_virtualenv_constants: upgrade virtualenv to 16.4.0 | Library/Homebrew/language/python_virtualenv_constants.rb | @@ -1,6 +1,6 @@
PYTHON_VIRTUALENV_URL =
- "https://files.pythonhosted.org/packages/8b/f4" \
- "/360aa656ddb0f4168aeaa1057d8784b95d1ce12f34332c1cf52420b6db4e" \
- "/virtualenv-16.3.0.tar.gz".freeze
+ "https://files.pythonhosted.org/packages/51/aa" \
+ "/c395a6e6eaaedfa5a04723b6446a1df783b16cca6fec66e671cede514688"... | false |
Other | Homebrew | brew | f20319a516befac13947a3e6384f699dc87b97d8.json | cmd/repository: Fix man pages and help | Library/Homebrew/cmd/--repository.rb | @@ -6,7 +6,7 @@ module Homebrew
def __repository_args
Homebrew::CLI::Parser.new do
usage_banner <<~EOS
- `--repository` [<formula>]
+ `--repository` [<user>`/`<repo>]
Display where Homebrew's `.git` directory is located.
| true |
Other | Homebrew | brew | f20319a516befac13947a3e6384f699dc87b97d8.json | cmd/repository: Fix man pages and help | docs/Manpage.md | @@ -624,7 +624,7 @@ Display Homebrew's install path. *Default:* `/usr/local` on macOS and
If *`formula`* is provided, display the location in the cellar where *`formula`*
is or would be installed.
-### `--repository` [*`formula`*]
+### `--repository` [*`user`*`/`*`repo`*]
Display where Homebrew's `.git` director... | true |
Other | Homebrew | brew | f20319a516befac13947a3e6384f699dc87b97d8.json | cmd/repository: Fix man pages and help | manpages/brew.1 | @@ -766,7 +766,7 @@ Display Homebrew\'s install path\. \fIDefault:\fR \fB/usr/local\fR on macOS and
.P
If \fIformula\fR is provided, display the location in the cellar where \fIformula\fR is or would be installed\.
.
-.SS "\fB\-\-repository\fR [\fIformula\fR]"
+.SS "\fB\-\-repository\fR [\fIuser\fR\fB/\fR\fIrepo\fR]... | true |
Other | Homebrew | brew | 8a6a46da36a1bd2b4e4d6d5527a0d657a7cb0495.json | Add additional support for java minor versions > 9. | Library/Homebrew/requirements/java_requirement.rb | @@ -129,7 +129,7 @@ def oracle_java_os
end
def satisfies_version(java)
- java_version_s = system_command(java, args: ["-version"], print_stderr: false).stderr[/\d+(\.\d)?/]
+ java_version_s = system_command(java, args: ["-version"], print_stderr: false).stderr[/\d+(\.\d+)?/]
return false unless java_... | false |
Other | Homebrew | brew | 9abd7d31bd1db07e572a5f2dbc864ab538e811bc.json | Fix dry run | Library/Homebrew/cleanup.rb | @@ -316,12 +316,13 @@ def cleanup_path(path)
if dry_run?
puts "Would remove: #{path} (#{path.abv})"
+ @disk_cleanup_size += disk_usage
else
puts "Removing: #{path}... (#{path.abv})"
yield
+ @disk_cleanup_size += disk_usage - path.disk_usage
end
- @d... | false |
Other | Homebrew | brew | b9b1b24e4e0c607bd27137f3a1928e1b6ee97908.json | Calculate actual delta in usage | Library/Homebrew/cleanup.rb | @@ -321,7 +321,7 @@ def cleanup_path(path)
yield
end
- @disk_cleanup_size += disk_usage
+ @disk_cleanup_size += disk_usage - path.disk_usage
end
def cleanup_lockfiles(*lockfiles) | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.