language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | Homebrew | brew | 2020f382cb6cc51d58f7cf6c2895361129f11b5a.json | docs: add two taps, update CI info
and fix some wording. | docs/Brew-Test-Bot.md | @@ -3,7 +3,7 @@
`brew test-bot` is the name for the automated review and testing system funded
by [our Kickstarter in 2013](https://www.kickstarter.com/projects/homebrew/brew-test-bot).
-It comprises four Mac Minis running in a data centre in England which host
+It comprises four Mac Minis and three Xserves running... | true |
Other | Homebrew | brew | 2020f382cb6cc51d58f7cf6c2895361129f11b5a.json | docs: add two taps, update CI info
and fix some wording. | docs/Interesting-Taps-and-Forks.md | @@ -33,11 +33,15 @@ You can be added as a maintainer for one of the Homebrew organization taps and a
* [brewsci/science](https://github.com/brewsci/homebrew-science): Software tailored to scientific endeavours.
+* [davidchall/hep](https://github.com/davidchall/homebrew-hep): High energy physics formulae.
+
+* ... | true |
Other | Homebrew | brew | 1373441e53d838264c70690e9612009f0e9735d8.json | xcode_requirement: inform users of macOS upgrade.
If you need a newer Xcode than the latest version provided by your
version of macOS then you need to upgrade your OS to install the
software. | Library/Homebrew/requirements/xcode_requirement.rb | @@ -22,7 +22,12 @@ def message
A full installation of Xcode.app#{version} is required to compile this software.
Installing just the Command Line Tools is not sufficient.
EOS
- if MacOS.version >= :lion
+ if Version.new(MacOS::Xcode.latest_version) < Version.new(@version)
+ message + <<~EOS... | false |
Other | Homebrew | brew | edd1c76d409e224e329131bbd635d944cdf6fe1f.json | bump-formula-pr: detect download strategy from url.
Previously, CurlDownloadStrategy was hard coded. | Library/Homebrew/dev-cmd/bump-formula-pr.rb | @@ -198,7 +198,7 @@ def bump_formula_pr
new_url.sub "mirrors.ocf.berkeley.edu/debian", "mirrorservice.org/sites/ftp.debian.org/debian"
end
resource = Resource.new { @url = new_url }
- resource.download_strategy = CurlDownloadStrategy
+ resource.download_strategy = DownloadStrategyDetect... | false |
Other | Homebrew | brew | 99bb068ca734c7096bf82c72730f1babc7f72431.json | bump-formula-pr: improve formula name guessing. | Library/Homebrew/dev-cmd/bump-formula-pr.rb | @@ -137,9 +137,16 @@ def bump_formula_pr
new_url = ARGV.value("url")
if new_url && !formula
- is_devel = ARGV.include?("--devel")
- base_url = new_url.split("/")[0..4].join("/")
+ # Split the new URL on / and find any formulae that have the same URL
+ # except for the last component, but... | false |
Other | Homebrew | brew | 78933b3ee91a9bfd71128bd7e7e46b9af9ef30e2.json | ruby.sh: fix version check.
- Rather than checking for the absence of a failure check for an actual success in the check
- Fix the check to work on Ruby 1.9 (where `RUBY_VERSION.to_s.dup` is required to avoid modifying a frozen string). | Library/Homebrew/utils/ruby.sh | @@ -2,7 +2,7 @@ setup-ruby-path() {
local vendor_dir
local vendor_ruby_current_version
local vendor_ruby_path
- local ruby_old_version
+ local ruby_version_new_enough
local minimum_ruby_version="2.3.3"
vendor_dir="$HOMEBREW_LIBRARY/Homebrew/vendor"
@@ -35,12 +35,12 @@ setup-ruby-path() {
HOM... | false |
Other | Homebrew | brew | 4b231e793d25b3d30940a44e6f2dde0a8f34ff94.json | Fix Travis deprecation error. | .travis.yml | @@ -23,7 +23,10 @@ before_install:
- if [ "${TRAVIS_OS_NAME}" = "osx" ]; then
HOMEBREW_REPOSITORY="$(brew --repo)";
sudo chown -R "$USER" "$HOMEBREW_REPOSITORY/Library/Taps";
- mv "$HOMEBREW_REPOSITORY/Library/Taps" "$PWD/Library";
+ mkdir -p "$PWD/Library/Taps/homebrew"
+ mv "$HOMEBREW_... | false |
Other | Homebrew | brew | 4a1a8b86ac094621a50eff1526b53f62758ad1be.json | bump-formula-pr: use "resource" not "rsrc" | Library/Homebrew/dev-cmd/bump-formula-pr.rb | @@ -184,23 +184,23 @@ def bump_formula_pr
elsif !new_url
odie "#{formula}: no --url= argument specified!"
else
- rsrc_url = if requested_spec != :devel && new_url =~ /.*ftpmirror.gnu.*/
+ resource_url = if requested_spec != :devel && new_url =~ /.*ftpmirror.gnu.*/
new_mirror = new_ur... | false |
Other | Homebrew | brew | 459b113e28cab57cde94625b3f284e54986c2167.json | utils: reduce odeprecated warnings.
Fix the code so we don't actually output `odeprecated` warnings for
`HOMEBREW_CACHE`d or `.brew`d formulae. | Library/Homebrew/utils.rb | @@ -82,16 +82,19 @@ def odeprecated(method, replacement = nil, disable: false, disable_on: nil, call
# - Location of caller of deprecated method (if all else fails).
backtrace = caller
tap_message = nil
+
+ # Don't throw deprecations at all for cached or .brew formulae.
+ return if backtrace.any? do |line|
+... | false |
Other | Homebrew | brew | 2844b0748da7d18fa9dca30a5ebbb00617493b66.json | build: remove req satisfied calls. | Library/Homebrew/build.rb | @@ -81,12 +81,10 @@ def install
ENV.x11 = reqs.any? { |rq| rq.is_a?(X11Requirement) }
ENV.setup_build_environment(formula)
post_superenv_hacks
- reqs.each(&:satisfied?)
reqs.each(&:modify_build_environment)
deps.each(&:modify_build_environment)
else
ENV.setup_build_en... | false |
Other | Homebrew | brew | 480a25aef9ea5ae0e1a0e206b60522bc79003908.json | Add doctor and style to checklist.
Ensures that contributors know about `brew doctor` and `brew style` before submitting a PR, since CI fails on `brew style` breaches. | .github/PULL_REQUEST_TEMPLATE.md | @@ -2,6 +2,8 @@
- [ ] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?
- [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
- [ ] Have you written new tests for your changes? [Here's an exampl... | false |
Other | Homebrew | brew | ab00c0f719a5646060a9fbd15fbecb1b2a9eb16d.json | compat/requirements: fix dependency names. | Library/Homebrew/compat/requirements.rb | @@ -12,111 +12,111 @@ class CVSRequirement < Requirement
class EmacsRequirement < Requirement
fatal true
satisfy do
- odeprecated("EmacsRequirement", "'depends_on \"cvs\"'")
+ odeprecated("EmacsRequirement", "'depends_on \"emacs\"'")
which "emacs"
end
end
class FortranRequirement < Requirement
... | false |
Other | Homebrew | brew | 53d87d3b58845b8778e214e2b4e4632029d24b07.json | fix broken sentence | Library/Homebrew/diagnostic.rb | @@ -339,8 +339,7 @@ def check_access_prefix_directories
by Homebrew. If a formula tries to write a file to this directory, the
install will fail during the link step.
- You should change the ownership and permissions of these directories.
- back to your user account.
+ ... | false |
Other | Homebrew | brew | f818f0e68139fd1e7b2665f0cd415936aa8cc63d.json | formula: reject dot dirs as racks
Dot directories are not racks because formulae names do not start with
"." so avoid attempting to descend into dot directories, which may not
always be possible (e.g. .Trashes). | Library/Homebrew/formula.rb | @@ -1371,7 +1371,7 @@ def self.clear_installed_formulae_cache
def self.racks
@racks ||= if HOMEBREW_CELLAR.directory?
HOMEBREW_CELLAR.subdirs.reject do |rack|
- rack.symlink? || rack.subdirs.empty?
+ rack.symlink? || rack.basename.to_s.start_with?(".") || rack.subdirs.empty?
end
... | false |
Other | Homebrew | brew | 67fc68afaf264c55af484d3e6f7ec8141605ebfd.json | README.md: secure two URLs | README.md | @@ -72,7 +72,7 @@ Alternatively, if you'd rather make a one-off payment:
BROOKLYN, NY 11201 USA
- Donate by wire transfer: contact accounting@sfconservancy.org for wire transfer details.
-Homebrew is a member of the [Software Freedom Conservancy](http://sfconservancy.org) which provides us with an... | false |
Other | Homebrew | brew | 78c829790d990b324320c3089c74eaec95c5ec31.json | Improve deprecation message for dependency tags
It took me a while to figure out what this deprecation actually did,
because the message wasn't accurate. | Library/Homebrew/compat/dependency_collector.rb | @@ -9,7 +9,7 @@ module Compat
def parse_string_spec(spec, tags)
if (tag = tags.first) && LANGUAGE_MODULES.include?(tag)
- odeprecated "'depends_on :#{tag}'"
+ odeprecated "'depends_on ... => #{tag.inspect}'"
LanguageModuleRequirement.new(tag, spec, tags[1])
else
supe... | false |
Other | Homebrew | brew | 65695885b68a69d6104b0661a2293a2783748a19.json | Update other Homebrew maintainers. | Library/Homebrew/dev-cmd/man.rb | @@ -64,8 +64,10 @@ def build_man_page
.gsub(/\[([^\]]+)\]\([^)]+\)/, '\1')
variables[:core_maintainer] = readme.read[%r{(Homebrew/homebrew-core's lead maintainer .*\.)}, 1]
.gsub(/\[([^\]]+)\]\([^)]+\)/, '\1')
- variables[:maintai... | true |
Other | Homebrew | brew | 65695885b68a69d6104b0661a2293a2783748a19.json | Update other Homebrew maintainers. | Library/Homebrew/manpages/brew.1.md.erb | @@ -278,7 +278,9 @@ Homebrew Documentation: <https://docs.brew.sh>
<%= core_maintainer.concat("\n") %>
-<%= maintainers.concat("\n") %>
+<%= brew_maintainers.concat("\n") %>
+
+<%= core_maintainers.concat("\n") %>
<%= former_maintainers.concat("\n") %>
| true |
Other | Homebrew | brew | 65695885b68a69d6104b0661a2293a2783748a19.json | Update other Homebrew maintainers. | README.md | @@ -40,9 +40,11 @@ Homebrew's lead maintainer is [Mike McQuaid](https://github.com/mikemcquaid).
Homebrew/homebrew-core's lead maintainer is [ilovezfs](https://github.com/ilovezfs).
-Homebrew's other current maintainers are [Alyssa Ross](https://github.com/alyssais), [Alex Dunn](https://github.com/dunn), [FX Coude... | true |
Other | Homebrew | brew | 65695885b68a69d6104b0661a2293a2783748a19.json | Update other Homebrew maintainers. | docs/Manpage.md | @@ -1123,9 +1123,11 @@ Homebrew's lead maintainer is Mike McQuaid.
Homebrew/homebrew-core's lead maintainer is ilovezfs.
-Homebrew's other current maintainers are Alyssa Ross, Andrew Janke, Alex Dunn, FX Coudert, Josh Hagins, JCount, Misty De Meo, neutric, Tomasz Pajor, Markus Reiter, Tom Schoonjans, Uladzislau Sh... | true |
Other | Homebrew | brew | 65695885b68a69d6104b0661a2293a2783748a19.json | Update other Homebrew maintainers. | manpages/brew-cask.1 | @@ -1,7 +1,7 @@
.\" generated with Ronn/v0.7.3
.\" http://github.com/rtomayko/ronn/tree/0.7.3
.
-.TH "BREW\-CASK" "1" "December 2017" "Homebrew" "brew-cask"
+.TH "BREW\-CASK" "1" "January 2018" "Homebrew" "brew-cask"
.
.SH "NAME"
\fBbrew\-cask\fR \- a friendly binary installer for macOS | true |
Other | Homebrew | brew | 65695885b68a69d6104b0661a2293a2783748a19.json | Update other Homebrew maintainers. | manpages/brew.1 | @@ -1,7 +1,7 @@
.\" generated with Ronn/v0.7.3
.\" http://github.com/rtomayko/ronn/tree/0.7.3
.
-.TH "BREW" "1" "December 2017" "Homebrew" "brew"
+.TH "BREW" "1" "January 2018" "Homebrew" "brew"
.
.SH "NAME"
\fBbrew\fR \- The missing package manager for macOS
@@ -1166,10 +1166,13 @@ Homebrew\'s lead maintainer is... | true |
Other | Homebrew | brew | ebd50d136f40b3795e9feecd7de0177f6067a61d.json | info: show spec options for optionless formulae
Previsiouly, info would not display --HEAD or --devel for formulae that
had no options other than those spec options. | Library/Homebrew/cmd/info.rb | @@ -164,7 +164,7 @@ def info_formula(f)
end
end
- unless f.options.empty?
+ if !f.options.empty? || f.head || f.devel
ohai "Options"
Homebrew.dump_options_for_formula f
end | false |
Other | Homebrew | brew | 17c24d040bc2a488b9bd70546cf0ef4f6d81d3bc.json | utils: tell developers to submit odeprecated PRs.
Rather than just telling them to submit an issue as it's likely that
as these folks will be able to submit a PR. | Library/Homebrew/utils.rb | @@ -101,7 +101,8 @@ def odeprecated(method, replacement = nil, disable: false, disable_on: nil, call
if ARGV.homebrew_developer? || disable ||
Homebrew.raise_deprecation_exceptions?
- raise MethodDeprecatedError, message
+ developer_message = message + "Or, even better, submit a PR to fix it!"
+ rai... | false |
Other | Homebrew | brew | 8bf948482325bdc10ab7d0eff75ce0da4d5daf1c.json | cask moved: check target writable for move_back | Library/Homebrew/cask/lib/hbc/artifact/moved.rb | @@ -65,7 +65,7 @@ def move_back(skip: false, force: false, command: nil, **options)
ohai "Moving #{self.class.english_name} '#{target.basename}' back to '#{source}'."
source.dirname.mkpath
- if source.parent.writable?
+ if target.parent.writable?
FileUtils.move(target, sourc... | false |
Other | Homebrew | brew | 0306eff958a8d4b749b9d4d344d47498dc9e7a7f.json | brew unlink: fix short option | completions/zsh/_brew | @@ -711,15 +711,15 @@ _brew_uninstall() {
# brew unlink [--dry-run] formula:
_brew_unlink() {
_arguments \
- '(--dry-run =n)'{--dry-run,=n}'[don''t unlink or delete any files]' \
+ '(--dry-run -n)'{--dry-run,-n}'[don''t unlink or delete any files]' \
':formula:__brew_installed_formulae'
}
# brew unl... | false |
Other | Homebrew | brew | 9be416e3c88a1ac9e6781fba3c792a33d2f5e4c9.json | Suppress alias expansion in bash completion script | completions/bash/brew | @@ -51,7 +51,7 @@ __brewcomp() {
__brew_complete_formulae() {
local cur="${COMP_WORDS[COMP_CWORD]}"
local formulas="$(brew search)"
- local shortnames="$(echo "$formulas" | grep / | cut -d / -f 3)"
+ local shortnames="$(echo "$formulas" | \grep / | \cut -d / -f 3)"
COMPREPLY=($(compgen -W "$formulas $shortn... | false |
Other | Homebrew | brew | 924865ec7f18078650be87ca31b6c0a434b0a78d.json | curl: handle more non-executable curl edge-cases.
Address some additional issues mentioned in #3624. | Library/Homebrew/utils/curl.rb | @@ -2,10 +2,13 @@
require "open3"
def curl_executable
- curl = Pathname.new ENV["HOMEBREW_CURL"]
- curl = which("curl") unless curl.exist?
- return curl if curl.executable?
- raise "#{curl} is not executable"
+ @curl ||= [
+ ENV["HOMEBREW_CURL"],
+ which("curl"),
+ "/usr/bin/curl",
+ ].map { |c| Path... | false |
Other | Homebrew | brew | fa763216200a2ae1c36f5ec4cbf3d4f17d5053ff.json | Interesting-Taps-and-Forks: add brewsci org taps.
From the artist known as homebrew-science. | docs/Interesting-Taps-and-Forks.md | @@ -29,6 +29,10 @@ You can be added as a maintainer for one of the Homebrew organization taps and a
* [osrf/simulation](https://github.com/osrf/homebrew-simulation): Tools for robotics simulation.
+* [brewsci/bio](https://github.com/brewsci/homebrew-bio): Bioinformatics formulae.
+
+* [brewsci/science](https... | false |
Other | Homebrew | brew | f5e8b2680e9a94d57666fc8b5e2ff324fb1bd143.json | docs: Fix depends_on examples in Formula page
example:
Error: depends_on :mysql
Correct: depends_on "mysql" | Library/Homebrew/formula.rb | @@ -2207,19 +2207,19 @@ def go_resource(name, &block)
# depends_on :x11 # X11/XQuartz components.
# depends_on :osxfuse # Permits the use of the upstream signed binary or our source package.
# depends_on :tuntap # Does the same thing as above. This is vital for Yosemite and above.
- # depends_on :mysq... | false |
Other | Homebrew | brew | 7f2fda104a47b696b4333e424d078b28860cb5c3.json | formula_cop: match any values in hash match.
e.g. match an array or symbol or string. | Library/Homebrew/rubocops/extend/formula_cop.rb | @@ -214,7 +214,7 @@ def find_const(node, const_name)
EOS
def_node_search :dependency_name_hash_match?, <<~EOS
- (hash (pair ({str sym} %1) ({str sym array} _)))
+ (hash (pair ({str sym} %1) (...)))
EOS
# To compare node with appropriate Ruby variable | false |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/ARGV.rb | @@ -1,6 +1,5 @@
module HomebrewArgvExtension
def build_32_bit?
- odeprecated "ARGV.build_32_bit?"
- include? "--32-bit"
+ odisabled "ARGV.build_32_bit?"
end
end | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/ENV/shared.rb | @@ -5,6 +5,6 @@ def j1
end
def java_cache
- # odeprecated "ENV.java_cache"
+ odeprecated "ENV.java_cache"
end
end | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/build_options.rb | @@ -1,11 +1,9 @@
class BuildOptions
def build_32_bit?
- odeprecated "build.build_32_bit?"
- include?("32-bit") && option_defined?("32-bit")
+ odisabled "build.build_32_bit?"
end
def build_bottle?
- odeprecated "build.build_bottle?", "build.bottle?"
- bottle?
+ odisabled "build.build_bottle... | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/dependency_collector.rb | @@ -10,6 +10,7 @@ class DependencyCollector
def parse_string_spec(spec, tags)
if (tag = tags.first) && LANGUAGE_MODULES.include?(tag)
+ odeprecated "'depends_on :#{tag}'"
LanguageModuleRequirement.new(tag, spec, tags[1])
else
_parse_string_spec(spec, tags)
@@ -23,7 +24,7 @@ def parse_s... | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/fails_with_llvm.rb | @@ -1,9 +1,9 @@
class Formula
def fails_with_llvm(_msg = nil, _data = nil)
- odeprecated "Formula#fails_with_llvm in install"
+ odisabled "Formula#fails_with_llvm in install"
end
def self.fails_with_llvm(_msg = nil, _data = {})
- odeprecated "Formula.fails_with_llvm"
+ odisabled "Formula.fails_w... | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/formula.rb | @@ -1,12 +1,10 @@
module FormulaCompat
def x11_installed?
- odeprecated "Formula#x11_installed?", "MacOS::X11.installed?"
- MacOS::X11.installed?
+ odisabled "Formula#x11_installed?", "MacOS::X11.installed?"
end
def snow_leopard_64?
- odeprecated "Formula#snow_leopard_64?", "MacOS.prefer_64_bit?... | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/formula_specialties.rb | @@ -1,47 +1,23 @@
class ScriptFileFormula < Formula
def install
- odeprecated "ScriptFileFormula#install", "Formula#install"
- bin.install Dir["*"]
+ odisabled "ScriptFileFormula#install", "Formula#install"
end
end
class GithubGistFormula < ScriptFileFormula
- def self.url(val)
- odeprecated "Gi... | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/global.rb | @@ -3,8 +3,7 @@ module Homebrew
def method_missing(method, *args, &block)
if instance_methods.include?(method)
- odeprecated "#{self}##{method}", "'module_function' or 'def self.#{method}' to convert it to a class method"
- return instance_method(method).bind(self).call(*args, &block)
+ odisabl... | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/gpg.rb | @@ -4,46 +4,24 @@ module Gpg
module_function
def executable
+ odeprecated "Gpg.executable", 'which "gpg"'
which "gpg"
end
def available?
+ odeprecated "Gpg.available?", 'which "gpg"'
File.executable?(executable.to_s)
end
- def create_test_key(path)
- odie "No GPG present to test... | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/hardware.rb | @@ -1,43 +1,35 @@
module Hardware
class << self
def is_32_bit?
- odeprecated "Hardware.is_32_bit?", "Hardware::CPU.is_32_bit?"
- !CPU.is_64_bit?
+ odisabled "Hardware.is_32_bit?", "Hardware::CPU.is_32_bit?"
end
def is_64_bit?
- odeprecated "Hardware.is_64_bit?", "Hardware::CPU.i... | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/json.rb | @@ -4,34 +4,16 @@ module Utils
module JSON
module_function
- Error = Class.new(StandardError)
-
- def load(str)
- odeprecated "Utils::JSON.load", "JSON.parse"
- ::JSON.parse(str)
- rescue ::JSON::ParserError => e
- raise Error, e.message
+ def load(_)
+ odisabled "Utils::JSON.l... | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/keg.rb | @@ -1,6 +1,5 @@
class Keg
def fname
- odeprecated "Keg#fname", "Keg#name"
- name
+ odisabled "Keg#fname", "Keg#name"
end
end | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/macos.rb | @@ -10,142 +10,115 @@ module Mac
module_function
def xcode_folder
- odeprecated "MacOS.xcode_folder", "MacOS::Xcode.folder"
- Xcode.folder
+ odisabled "MacOS.xcode_folder", "MacOS::Xcode.folder"
end
def xcode_prefix
- odeprecated "MacOS.xcode_prefix", "MacOS::Xcode.prefix"
- ... | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/pathname.rb | @@ -1,17 +1,9 @@
class Pathname
- def cp(dst)
- odeprecated "Pathname#cp", "FileUtils.cp"
- if file?
- FileUtils.cp to_s, dst
- else
- FileUtils.cp_r to_s, dst
- end
- dst
+ def cp(_)
+ odisabled "Pathname#cp", "FileUtils.cp"
end
- def chmod_R(perms)
- odeprecated "Pathname#chmod... | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/software_spec.rb | @@ -1,6 +1,5 @@
class BottleSpecification
- def revision(*args)
- odeprecated "BottleSpecification.revision", "BottleSpecification.rebuild"
- rebuild(*args)
+ def revision(*)
+ odisabled "BottleSpecification.revision", "BottleSpecification.rebuild"
end
end | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/tab.rb | @@ -1,6 +1,5 @@
class Tab < OpenStruct
def build_32_bit?
- odeprecated "Tab.build_32_bit?"
- include?("32-bit")
+ odisabled "Tab.build_32_bit?"
end
end | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/tap.rb | @@ -2,7 +2,6 @@
class Tap
def core_formula_repository?
- odeprecated "Tap#core_formula_repository?", "Tap#core_tap?"
- core_tap?
+ odisabled "Tap#core_formula_repository?", "Tap#core_tap?"
end
end | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/utils.rb | @@ -2,17 +2,14 @@ module Tty
module_function
def white
- odeprecated "Tty.white", "Tty.reset.bold"
- reset.bold
+ odisabled "Tty.white", "Tty.reset.bold"
end
end
-def puts_columns(items)
- odeprecated "puts_columns", "puts Formatter.columns"
- puts Formatter.columns(items)
+def puts_columns(_)
... | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/version.rb | @@ -1,6 +1,5 @@
class Version
- def slice(*args)
- odeprecated "Version#slice", "Version#to_s.slice"
- to_s.slice(*args)
+ def slice(*)
+ odisabled "Version#slice", "Version#to_s.slice"
end
end | true |
Other | Homebrew | brew | 2cbce1fbf0a7a361f2be8b3545998f1a36ab3588.json | Add more deprecations, disable some existing ones.
Add more `odeprecated` calls to places that have been deprecated for a
while in the wild and move some of the existing `odeprecated` calls to
be `odisabled` to allow deleting the compatibility code. | Library/Homebrew/compat/xcode.rb | @@ -4,8 +4,7 @@ module Xcode
module_function
def provides_autotools?
- odeprecated "OS::Mac::Xcode.provides_autotools?"
- version < "4.3"
+ odisabled "OS::Mac::Xcode.provides_autotools?"
end
end
end | true |
Other | Homebrew | brew | ef82b188f2a3977b56db463ef2f0cb0c8f5727e9.json | Preserve installed_on_request for dependencies
Fixes https://github.com/Homebrew/brew/issues/3642. | Library/Homebrew/formula_installer.rb | @@ -553,18 +553,18 @@ def install_dependency(dep, inherited_options)
end
fi = FormulaInstaller.new(df)
- fi.options |= tab.used_options
- fi.options |= Tab.remap_deprecated_options(df.deprecated_options, dep.options)
- fi.options |= inherited_options
- fi.options ... | false |
Other | Homebrew | brew | cb3410245960383291e2e81eb5f2406c306e83cf.json | bash completion: add null completion where appropriate | completions/bash/brew | @@ -1,5 +1,10 @@
# Bash completion script for brew(1)
+# Indicates there are no completions
+__brewcomp_null() {
+ COMPREPLY=""
+}
+
__brewcomp_words_include() {
local i=1
while [[ "$i" -lt "$COMP_CWORD" ]]
@@ -399,6 +404,7 @@ _brew_search() {
return
;;
esac
+ __brewcomp_null
}
_brew_st... | false |
Other | Homebrew | brew | 913ff483f0223f9423798c379375b7972de45f7c.json | Use hgpath instead of "hg" to fix --HEAD hg builds
Fixes #3628.
With environment filtering, hg was no longer in the path,
so make sure to provide the path when calling hg commands.
last_commit was the source of the problem in #3628
but I fixed source_modified_time as well.
I didn't see any others with this problem. | Library/Homebrew/download_strategy.rb | @@ -1005,11 +1005,11 @@ def stage
end
def source_modified_time
- Time.parse Utils.popen_read("hg", "tip", "--template", "{date|isodate}", "-R", cached_location.to_s)
+ Time.parse Utils.popen_read(hgpath, "tip", "--template", "{date|isodate}", "-R", cached_location.to_s)
end
def last_commit
- Ut... | false |
Other | Homebrew | brew | 1bd7d7df04321ebf39cc39d06486768df7245650.json | Use parser 2.4.0.0
This matches the version that supports Ruby 2.3.3 syntax (which is the
version we use). | Library/Homebrew/cmd/style.rb | @@ -70,6 +70,7 @@ def check_style_json(files, options = {})
def check_style_impl(files, output_type, options = {})
fix = options[:fix]
+ Homebrew.install_gem_setup_path! "parser", HOMEBREW_RUBOCOP_PARSER_VERSION, "ruby-parse"
Homebrew.install_gem_setup_path! "rubocop", HOMEBREW_RUBOCOP_VERSION
re... | true |
Other | Homebrew | brew | 1bd7d7df04321ebf39cc39d06486768df7245650.json | Use parser 2.4.0.0
This matches the version that supports Ruby 2.3.3 syntax (which is the
version we use). | Library/Homebrew/constants.rb | @@ -2,4 +2,5 @@
# RuboCop version used for `brew style` and `brew cask style`
HOMEBREW_RUBOCOP_VERSION = "0.51.0"
+HOMEBREW_RUBOCOP_PARSER_VERSION = "2.4.0.0" # for Ruby 2.3.3
HOMEBREW_RUBOCOP_CASK_VERSION = "~> 0.15.1" # has to be updated when RuboCop version changes | true |
Other | Homebrew | brew | 1bd7d7df04321ebf39cc39d06486768df7245650.json | Use parser 2.4.0.0
This matches the version that supports Ruby 2.3.3 syntax (which is the
version we use). | Library/Homebrew/test/Gemfile | @@ -3,6 +3,7 @@ source "https://rubygems.org"
require_relative "../constants"
gem "parallel_tests"
+gem "parser", HOMEBREW_RUBOCOP_PARSER_VERSION
gem "rspec"
gem "rspec-its", require: false
gem "rspec-wait", require: false | true |
Other | Homebrew | brew | 1bd7d7df04321ebf39cc39d06486768df7245650.json | Use parser 2.4.0.0
This matches the version that supports Ruby 2.3.3 syntax (which is the
version we use). | Library/Homebrew/test/Gemfile.lock | @@ -58,11 +58,12 @@ PLATFORMS
DEPENDENCIES
codecov
parallel_tests
+ parser (= 2.4.0.0)
rspec
rspec-its
rspec-wait
rubocop (= 0.51.0)
simplecov
BUNDLED WITH
- 1.15.4
+ 1.16.0 | true |
Other | Homebrew | brew | 4e29152603ed192e90b83b66f0ad92a676549c43.json | formula_cop: use undeprecated add_offense form. | Library/Homebrew/rubocops/extend/formula_cop.rb | @@ -467,7 +467,7 @@ def formula_tap
end
def problem(msg)
- add_offense(@offensive_node, @offense_source_range, msg)
+ add_offense(@offensive_node, location: @offense_source_range, message: msg)
end
private | false |
Other | Homebrew | brew | 8a419b47426728c03c3835c1aafa72b5ecf56f4f.json | audit: pass explicit sort to handle APFS | Library/Homebrew/dev-cmd/audit.rb | @@ -102,7 +102,7 @@ def audit
# Check style in a single batch run up front for performance
style_results = check_style_json(files, options)
- ff.each do |f|
+ ff.sort.each do |f|
options = { new_formula: new_formula, strict: strict, online: online }
options[:style_offenses] = style_resul... | false |
Other | Homebrew | brew | 60362605dee22d863ade2788650f26ef41d75473.json | scm/git: hide prefix cd failure warning.
This may happen with certain checkout configurations (such as on our CI
boxes).
Also, rename the variables to be clearer about what they reference. | Library/Homebrew/shims/scm/git | @@ -92,11 +92,11 @@ case "$(lowercase "$SCM_FILE")" in
;;
esac
-brew_version="$(quiet_safe_cd "$SCM_DIR/../../../../../bin" && pwd -P)/$SCM_FILE"
-safe_exec "$brew_version" "$@"
+brew_prefix_version="$(quiet_safe_cd "$SCM_DIR/../../../../../bin" 2>/dev/null && pwd -P)/$SCM_FILE"
+safe_exec "$brew_prefix_version... | false |
Other | Homebrew | brew | 7f54c83911a494b592e412d2f99119530cebf458.json | audit: remove unneeded mercurial check. | Library/Homebrew/dev-cmd/audit.rb | @@ -380,8 +380,6 @@ def audit_deps
case dep.name
when "git"
problem "Don't use git as a dependency"
- when "mercurial"
- problem "Use `depends_on :hg` instead of `depends_on 'mercurial'`"
when "gfortran"
problem "Use `depends_on :fortran` instead of `depe... | false |
Other | Homebrew | brew | 51114139e1c6b442890adec620ffc42975e8fd30.json | formula: require gpg and make it a module. | Library/Homebrew/formula.rb | @@ -13,6 +13,7 @@
require "tap"
require "keg"
require "migrator"
+require "gpg"
require "extend/ENV"
# A formula provides instructions and metadata for Homebrew to install a piece | true |
Other | Homebrew | brew | 51114139e1c6b442890adec620ffc42975e8fd30.json | formula: require gpg and make it a module. | Library/Homebrew/gpg.rb | @@ -1,6 +1,6 @@
require "utils"
-class Gpg
+module Gpg
module_function
def executable | true |
Other | Homebrew | brew | 6fe261bc5c1da9cd3629c03fd47810f743d532a4.json | utils: stop debug exploding when zsh is used | Library/Homebrew/utils.rb | @@ -154,6 +154,7 @@ def interactive_shell(f = nil)
end
if ENV["SHELL"].include?("zsh") && ENV["HOME"].start_with?(HOMEBREW_TEMP.resolved_path.to_s)
+ FileUtils.mkdir_p ENV["HOME"]
FileUtils.touch "#{ENV["HOME"]}/.zshrc"
end
| false |
Other | Homebrew | brew | b40484e87cdf184e8d835dbc589c6f9efbdf2778.json | Revert "Revert "shims/scm/git: Fix the search for brewed git"" | Library/Homebrew/shims/scm/git | @@ -92,6 +92,9 @@ case "$(lowercase "$SCM_FILE")" in
;;
esac
+brew_version="$(quiet_safe_cd "$SCM_DIR/../../../../../bin" && pwd -P)/$SCM_FILE"
+safe_exec "$brew_version" "$@"
+
brew_version="$(quiet_safe_cd "$SCM_DIR/../../../../bin" && pwd -P)/$SCM_FILE"
safe_exec "$brew_version" "$@"
| false |
Other | Homebrew | brew | 0dabb464dd082e6df264bc0654e6e32973467893.json | Revert "shims/scm/git: Fix the search for brewed git" | Library/Homebrew/shims/scm/git | @@ -92,9 +92,6 @@ case "$(lowercase "$SCM_FILE")" in
;;
esac
-brew_version="$(quiet_safe_cd "$SCM_DIR/../../../../../bin" && pwd -P)/$SCM_FILE"
-safe_exec "$brew_version" "$@"
-
brew_version="$(quiet_safe_cd "$SCM_DIR/../../../../bin" && pwd -P)/$SCM_FILE"
safe_exec "$brew_version" "$@"
| false |
Other | Homebrew | brew | 5c7d2d0bb5ac51b6d089f96b974d530fe814a678.json | shims/scm/git: Fix the search for brewed git
Search for brewed git in both locations:
$HOMEBREW_PREFIX/Homebrew/Library/Homebrew/shims/scm/../../../../../bin/git
$HOMEBREW_PREFIX/Library/Homebrew/shims/scm/../../../../bin/git | Library/Homebrew/shims/scm/git | @@ -92,6 +92,9 @@ case "$(lowercase "$SCM_FILE")" in
;;
esac
+brew_version="$(quiet_safe_cd "$SCM_DIR/../../../../../bin" && pwd -P)/$SCM_FILE"
+safe_exec "$brew_version" "$@"
+
brew_version="$(quiet_safe_cd "$SCM_DIR/../../../../bin" && pwd -P)/$SCM_FILE"
safe_exec "$brew_version" "$@"
| false |
Other | Homebrew | brew | cf27117c4638ff37b0803a15500d742fb5edad75.json | brew.sh: Use shims/scm/git for HOMEBREW_VERSION
Move the use of git to determine HOMEBREW_VERSION below the
definition of the function git. | Library/Homebrew/brew.sh | @@ -19,14 +19,6 @@ case "$*" in
--repository|--repo) echo "$HOMEBREW_REPOSITORY"; exit 0 ;;
esac
-HOMEBREW_VERSION="$(git -C "$HOMEBREW_REPOSITORY" describe --tags --dirty --abbrev=7 2>/dev/null)"
-HOMEBREW_USER_AGENT_VERSION="$HOMEBREW_VERSION"
-if [[ -z "$HOMEBREW_VERSION" ]]
-then
- HOMEBREW_VERSION=">=1.4.0 ... | false |
Other | Homebrew | brew | 67c4402634e24400accdb59fa81cde9020dd0386.json | README: add tdsmith to significant contribution list. | README.md | @@ -42,7 +42,7 @@ Homebrew/homebrew-core's lead maintainer is [ilovezfs](https://github.com/ilovez
Homebrew's other current maintainers are [Alyssa Ross](https://github.com/alyssais), [Andrew Janke](https://github.com/apjanke), [Alex Dunn](https://github.com/dunn), [FX Coudert](https://github.com/fxcoudert), [Josh H... | true |
Other | Homebrew | brew | 67c4402634e24400accdb59fa81cde9020dd0386.json | README: add tdsmith to significant contribution list. | docs/Manpage.md | @@ -1119,7 +1119,7 @@ Homebrew/homebrew-core's lead maintainer is ilovezfs.
Homebrew's other current maintainers are Alyssa Ross, Andrew Janke, Alex Dunn, FX Coudert, Josh Hagins, JCount, Misty De Meo, neutric, Tomasz Pajor, Markus Reiter, Tom Schoonjans, Uladzislau Shablinski and William Woodruff.
-Former maintai... | true |
Other | Homebrew | brew | 67c4402634e24400accdb59fa81cde9020dd0386.json | README: add tdsmith to significant contribution list. | manpages/brew.1 | @@ -1162,7 +1162,7 @@ Homebrew/homebrew\-core\'s lead maintainer is ilovezfs\.
Homebrew\'s other current maintainers are Alyssa Ross, Andrew Janke, Alex Dunn, FX Coudert, Josh Hagins, JCount, Misty De Meo, neutric, Tomasz Pajor, Markus Reiter, Tom Schoonjans, Uladzislau Shablinski and William Woodruff\.
.
.P
-Former... | true |
Other | Homebrew | brew | e504caa5a367ffa48321aa1f599aed951bde50bf.json | README: remove tdsmith from maintainers. | README.md | @@ -40,7 +40,7 @@ Homebrew's lead maintainer is [Mike McQuaid](https://github.com/mikemcquaid).
Homebrew/homebrew-core's lead maintainer is [ilovezfs](https://github.com/ilovezfs).
-Homebrew's other current maintainers are [Alyssa Ross](https://github.com/alyssais), [Andrew Janke](https://github.com/apjanke), [Ale... | true |
Other | Homebrew | brew | e504caa5a367ffa48321aa1f599aed951bde50bf.json | README: remove tdsmith from maintainers. | docs/Manpage.md | @@ -1117,7 +1117,7 @@ Homebrew's lead maintainer is Mike McQuaid.
Homebrew/homebrew-core's lead maintainer is ilovezfs.
-Homebrew's other current maintainers are Alyssa Ross, Andrew Janke, Alex Dunn, FX Coudert, Josh Hagins, JCount, Misty De Meo, neutric, Tomasz Pajor, Markus Reiter, Tim Smith, Tom Schoonjans, Ula... | true |
Other | Homebrew | brew | e504caa5a367ffa48321aa1f599aed951bde50bf.json | README: remove tdsmith from maintainers. | manpages/brew.1 | @@ -1159,7 +1159,7 @@ Homebrew\'s lead maintainer is Mike McQuaid\.
Homebrew/homebrew\-core\'s lead maintainer is ilovezfs\.
.
.P
-Homebrew\'s other current maintainers are Alyssa Ross, Andrew Janke, Alex Dunn, FX Coudert, Josh Hagins, JCount, Misty De Meo, neutric, Tomasz Pajor, Markus Reiter, Tim Smith, Tom Schoon... | true |
Other | Homebrew | brew | 7a8f61c28cb55a1b170c585c2e76e71619999662.json | gist-logs: use full path to brew.
This fixes the command with environment filtering enabled. | Library/Homebrew/cmd/gist-logs.rb | @@ -27,7 +27,7 @@ def gistify_logs(f)
# Dummy summary file, asciibetically first, to control display title of gist
files["# #{f.name} - #{timestamp}.txt"] = { content: brief_build_info(f) }
files["00.config.out"] = { content: s.string }
- files["00.doctor.out"] = { content: `brew doctor 2>&1` }
+ f... | false |
Other | Homebrew | brew | b085da91c37e3002f6c5eea8e97d5ce0eabb97bf.json | postinstall: add HOMEBREW_PREFIX/{,s}bin to PATH.
This avoids the need for workarounds such as:
https://github.com/Homebrew/homebrew-core/pull/21688 | Library/Homebrew/formula.rb | @@ -956,12 +956,16 @@ def run_post_install
@prefix_returns_versioned_prefix = true
build = self.build
self.build = Tab.for_formula(self)
+ path_with_prefix = PATH.new(ENV["PATH"])
+ .append(HOMEBREW_PREFIX/"bin")
+ .append(HOMEBREW_PREFIX/"sbin")
... | false |
Other | Homebrew | brew | e5853f4eaac8f4fb64b36f4d7c6ef0de80b53a83.json | New-Maintainer-Checklist: make some tweaks.
- there are obligations on becoming a maintainer so firm these up a bit
- make clear there's a trial period after being invited to be a
maintainer. | docs/New-Maintainer-Checklist.md | @@ -2,19 +2,24 @@
**This is a guide used by existing maintainers to invite new maintainers. You might find it interesting but there's nothing here users should have to know.**
-So, there's someone who has been making consistently high-quality contributions to Homebrew for a long time and shown themselves able to m... | false |
Other | Homebrew | brew | d6ebdf1e6253a76cbbe38588a1a16e497afbbfa2.json | python: handle env filtering on pth check
Since ENV filtering became the default this has been chucking
erroneous warnings from both `brew doctor` and things like `brew install pygobject`
about needing to run:
```
echo 'import site; site.addsitedir("/usr/local/lib/python2.7/site-packages")' >> /Users/xyz/Library/Pytho... | Library/Homebrew/language/python.rb | @@ -35,7 +35,7 @@ def self.reads_brewed_pth_files?(python)
probe_file = homebrew_site_packages(version)/"homebrew-pth-probe.pth"
begin
probe_file.atomic_write("import site; site.homebrew_was_here = True")
- quiet_system python, "-c", "import site; assert(site.homebrew_was_here)"
+ w... | false |
Other | Homebrew | brew | 5f471ee289ae9db2f20b42160a80233f556004e1.json | doctor: tell people not to file issues.
This stuff doesn't matter. | Library/Homebrew/cmd/doctor.rb | @@ -1,6 +1,9 @@
#: * `doctor`:
#: Check your system for potential problems. Doctor exits with a non-zero status
-#: if any problems are found.
+#: if any potential problems are found. Please note that these warnings are just
+#: used to help the Homebrew maintainers with debugging if you file an issue. I... | true |
Other | Homebrew | brew | 5f471ee289ae9db2f20b42160a80233f556004e1.json | doctor: tell people not to file issues.
This stuff doesn't matter. | docs/Manpage.md | @@ -144,7 +144,10 @@ With `--verbose` or `-v`, many commands print extra debugging information. Note
* `doctor`:
Check your system for potential problems. Doctor exits with a non-zero status
- if any problems are found.
+ if any potential problems are found. Please note that these warnings are just
+ ... | true |
Other | Homebrew | brew | 5f471ee289ae9db2f20b42160a80233f556004e1.json | doctor: tell people not to file issues.
This stuff doesn't matter. | manpages/brew.1 | @@ -152,7 +152,7 @@ The options \fB\-\-name=\fR\fIname\fR and \fB\-\-version=\fR\fIversion\fR each t
.
.TP
\fBdoctor\fR
-Check your system for potential problems\. Doctor exits with a non\-zero status if any problems are found\.
+Check your system for potential problems\. Doctor exits with a non\-zero status if any ... | true |
Other | Homebrew | brew | 55d97500565c02a70feb68dc747d9e4ef673068e.json | caveats: fix fish caveats under env filtering | Library/Homebrew/caveats.rb | @@ -76,7 +76,7 @@ def keg_only_text
def function_completion_caveats(shell)
return unless keg
- return unless which(shell.to_s)
+ return unless which(shell.to_s, ENV["HOMEBREW_PATH"])
completion_installed = keg.completion_installed?(shell)
functions_installed = keg.functions_installed?(shell) | false |
Other | Homebrew | brew | 1babfb679d1ff94acc778a0588418ae2ae6f3f74.json | bump-formula-pr: improve error messages.
- Be clearer about how URLs/tags/revisions/versions are specified in
error messages.
- Give a better error message if `hub` isn't configured. | Library/Homebrew/dev-cmd/bump-formula-pr.rb | @@ -180,9 +180,9 @@ def bump_formula_pr
elsif new_tag && new_revision
false
elsif !hash_type
- odie "#{formula}: no tag/revision specified!"
+ odie "#{formula}: no --tag=/--revision= arguments specified!"
elsif !new_url
- odie "#{formula}: no url specified!"
+ odie "#{formula}:... | false |
Other | Homebrew | brew | 4fa16c942845c86160264416b451d2d289a1cb17.json | formula_assertions: remove Ruby 2.0 compatibility.
We only support Ruby 2.3, now. | Library/Homebrew/formula_assertions.rb | @@ -3,11 +3,6 @@ module Assertions
require "test/unit/assertions"
include ::Test::Unit::Assertions
- # TODO: remove this when we no longer support Ruby 2.0.
- unless defined?(Test::Unit::AssertionFailedError)
- Test::Unit::AssertionFailedError = MiniTest::Assertion
- end
-
# Returns the o... | false |
Other | Homebrew | brew | 301bb1d5dd55415f154271fd8c9fc520b6974c85.json | .simplecov: filter more filters/folders.
This is stuff that can never be exercised by our test suite but is
exercised by `brew test-bot` so remove it from the coverage checks. | Library/Homebrew/.simplecov | @@ -38,11 +38,22 @@ SimpleCov.start do
track_files "#{SimpleCov.root}/{#{subdirs},*.rb}"
end
+ add_filter %r{^/build.rb$}
+ add_filter %r{^/config.rb$}
+ add_filter %r{^/constants.rb$}
+ add_filter %r{^/postinstall.rb$}
+ add_filter %r{^/test.rb$}
add_filter %r{^/compat/}
add_filter %r{^/dev-cmd/te... | false |
Other | Homebrew | brew | 804393efc466e72ea07b3e38b09d39a5a64d1b78.json | Implement X11Requirement for Linux
Move the XQuartz implementation to extend/os/mac/requirements. | Library/Homebrew/extend/os/mac/requirements/x11_requirement.rb | @@ -0,0 +1,42 @@
+require "requirement"
+
+class XQuartzRequirement < Requirement
+ include Comparable
+
+ fatal true
+ cask "xquartz"
+ download "https://xquartz.macosforge.org"
+
+ env { ENV.x11 }
+
+ def initialize(name = "x11", tags = [])
+ @name = name
+ # no-op on version specified as a tag argument
+... | true |
Other | Homebrew | brew | 804393efc466e72ea07b3e38b09d39a5a64d1b78.json | Implement X11Requirement for Linux
Move the XQuartz implementation to extend/os/mac/requirements. | Library/Homebrew/extend/os/requirements/x11_requirement.rb | @@ -0,0 +1 @@
+require "extend/os/mac/requirements/x11_requirement" if OS.mac? | true |
Other | Homebrew | brew | 804393efc466e72ea07b3e38b09d39a5a64d1b78.json | Implement X11Requirement for Linux
Move the XQuartz implementation to extend/os/mac/requirements. | Library/Homebrew/requirements/x11_requirement.rb | @@ -4,8 +4,6 @@ class X11Requirement < Requirement
include Comparable
fatal true
- cask "xquartz"
- download "https://xquartz.macosforge.org"
env { ENV.x11 }
@@ -17,24 +15,33 @@ def initialize(name = "x11", tags = [])
end
def min_version
- # TODO: remove in https://github.com/Homebrew/brew/p... | true |
Other | Homebrew | brew | 4ca9831da6c1b16f7ea28e32c7c21cf37845c26d.json | formula_installer: handle nil req_dependency.
Closes #3538. | Library/Homebrew/formula_installer.rb | @@ -449,7 +449,7 @@ def expand_requirements
if (req.optional? || req.recommended?) && build.without?(req)
Requirement.prune
- elsif req.build? && use_default_formula && req_dependency.installed?
+ elsif req.build? && use_default_formula && req_dependency&.installed?
Requir... | false |
Other | Homebrew | brew | b9cf7b2bbc9439080ad397574381b1e8bf1e1f9a.json | formula_installer: avoid irrelevant build deps.
If dependents are already installed ensure their build dependencies (and
requirements) don't end up in the dependency/requirement tree.
Fixes #3033. | Library/Homebrew/formula_installer.rb | @@ -417,8 +417,9 @@ def check_requirements(req_map)
raise UnsatisfiedRequirements, fatals
end
- def install_requirement_formula?(req_dependency, req, install_bottle_for_dependent)
+ def install_requirement_formula?(req_dependency, req, dependent, install_bottle_for_dependent)
return false unless req_de... | true |
Other | Homebrew | brew | b9cf7b2bbc9439080ad397574381b1e8bf1e1f9a.json | formula_installer: avoid irrelevant build deps.
If dependents are already installed ensure their build dependencies (and
requirements) don't end up in the dependency/requirement tree.
Fixes #3033. | Library/Homebrew/test/formula_installer_spec.rb | @@ -140,40 +140,54 @@ class #{Formulary.class_s(dep_name)} < Formula
@install_bottle_for_dependent = false
allow(@requirement).to receive(:satisfied?).and_return(satisfied?)
allow(@requirement).to receive(:satisfied_by_formula?).and_return(satisfied_by_formula?)
+ allow(@requirement).to receiv... | true |
Other | Homebrew | brew | 0245b2cfea973c849f3bd7a8d4ab973dc466fe5f.json | formula_installer: fix default formula prune.
Only prune it if it's not already installed.
Fixes bug with https://github.com/Homebrew/brew/pull/3479
Closes https://github.com/Homebrew/brew/pull/3535. | Library/Homebrew/formula_installer.rb | @@ -449,7 +449,7 @@ def expand_requirements
if (req.optional? || req.recommended?) && build.without?(req)
Requirement.prune
- elsif req.build? && use_default_formula
+ elsif req.build? && use_default_formula && req_dependency.installed?
Requirement.prune
elsif ins... | false |
Other | Homebrew | brew | b1328adaa9030a3a7ed6127fe0662b0ae51f270b.json | Use cask.url.user_agent when available | Library/Homebrew/cask/lib/hbc/audit.rb | @@ -278,13 +278,13 @@ def core_formula_url
end
def check_https_availability
- check_url_for_https_availability(cask.url) unless cask.url.to_s.empty?
+ check_url_for_https_availability(cask.url, user_agents: [cask.url.user_agent]) unless cask.url.to_s.empty?
check_url_for_https_availability(... | false |
Other | Homebrew | brew | d79c5ade1abaad0fb1ea88f2b949def8dcfddb81.json | Implement linkage for Linux | Library/Homebrew/extend/pathname.rb | @@ -470,6 +470,10 @@ def inspect
end
}
end
+
+ def mach_o_bundle?
+ false
+ end
end
require "extend/os/pathname" | true |
Other | Homebrew | brew | d79c5ade1abaad0fb1ea88f2b949def8dcfddb81.json | Implement linkage for Linux | Library/Homebrew/os/mac/linkage_checker.rb | @@ -23,7 +23,7 @@ def initialize(keg, formula = nil)
def check_dylibs
@keg.find do |file|
next if file.symlink? || file.directory?
- next unless file.dylib? || file.mach_o_executable? || file.mach_o_bundle?
+ next unless file.dylib? || file.binary_executable? || file.mach_o_bundle?
# w... | true |
Other | Homebrew | brew | d79c5ade1abaad0fb1ea88f2b949def8dcfddb81.json | Implement linkage for Linux | Library/Homebrew/os/mac/mach.rb | @@ -103,6 +103,8 @@ def mach_o_executable?
mach_data.any? { |m| m.fetch(:type) == :executable }
end
+ alias binary_executable? mach_o_executable?
+
# @private
def mach_o_bundle?
mach_data.any? { |m| m.fetch(:type) == :bundle } | true |
Other | Homebrew | brew | 8b9ac2b2e030a70bd6ee99ac8b0c9b9f92fd621b.json | x11_requirement: remove custom minimum version.
This isn't desired or needed. Ensure older code still works, though. | Library/Homebrew/os/mac/xquartz.rb | @@ -51,6 +51,15 @@ def detect_version
end
end
+ def minimum_version
+ version = guess_system_version
+ return version unless version == "dunno"
+
+ # Update this a little later than latest_version to give people
+ # time to upgrade.
+ "2.7.11"
+ end
+
... | true |
Other | Homebrew | brew | 8b9ac2b2e030a70bd6ee99ac8b0c9b9f92fd621b.json | x11_requirement: remove custom minimum version.
This isn't desired or needed. Ensure older code still works, though. | Library/Homebrew/requirements/x11_requirement.rb | @@ -2,7 +2,6 @@
class X11Requirement < Requirement
include Comparable
- attr_reader :min_version
fatal true
cask "xquartz"
@@ -12,36 +11,38 @@ class X11Requirement < Requirement
def initialize(name = "x11", tags = [])
@name = name
- if /(\d\.)+\d/ =~ tags.first
- @min_version = Version.... | true |
Other | Homebrew | brew | 8b9ac2b2e030a70bd6ee99ac8b0c9b9f92fd621b.json | x11_requirement: remove custom minimum version.
This isn't desired or needed. Ensure older code still works, though. | Library/Homebrew/test/dependency_collector_spec.rb | @@ -49,20 +49,20 @@ def find_requirement(klass)
expect(find_requirement(X11Requirement).tags).to be_empty
end
- specify "x11 with minimum version" do
+ specify "x11 with (ignored) minimum version" do
subject.add x11: "2.5.1"
- expect(find_requirement(X11Requirement).min_version.to_s).to ... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.