language stringclasses 1 value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2 classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 4842f036a330a39c57147898ca074c8a66946783.json | remove `router.router` deprecation | packages/ember-routing/lib/system/router.js | @@ -1356,8 +1356,6 @@ function updatePaths(router) {
}
EmberRouter.reopenClass({
- router: null,
-
/**
The `Router.map` function allows you to define mappings from URLs to routes
in your application. These mappings are defined within the
@@ -1583,10 +1581,4 @@ function representEmptyRoute(liveRoutes, defaultParentState, route) {
}
}
-deprecateProperty(EmberRouter.prototype, 'router', '_routerMicrolib', {
- id: 'ember-router.router',
- until: '2.16',
- url: 'https://emberjs.com/deprecations/v2.x/#toc_ember-router-router-renamed-to-ember-router-_routermicrolib'
-});
-
export default EmberRouter; | true |
Other | emberjs | ember.js | 4842f036a330a39c57147898ca074c8a66946783.json | remove `router.router` deprecation | packages/ember-routing/tests/system/router_test.js | @@ -262,21 +262,3 @@ QUnit.test('Router#triggerEvent ignores handlers that have not loaded yet', func
triggerEvent(handlerInfos, false, ['loading']);
});
-
-QUnit.test('Router#router deprecates when called', function(assert) {
- assert.expect(2);
-
- let router = createRouter();
-
- expectDeprecation(function() {
- assert.equal(router.router, router._routerMicrolib);
- }, 'Usage of `router` is deprecated, use `_routerMicrolib` instead.');
-});
-
-QUnit.test('Router#_routerMicrolib can be used without deprecation', function(assert) {
- assert.expect(1);
-
- let router = createRouter();
-
- assert.ok(router._routerMicrolib, 'Router._routerMicrolib can be used without deprecation');
-}); | true |
Other | emberjs | ember.js | acdd288d1ea52cee19587eb3be30857069233fb8.json | add fs-extra to deps | package.json | @@ -55,6 +55,7 @@
"ember-cli-valid-component-name": "^1.0.0",
"ember-cli-version-checker": "^1.3.1",
"ember-router-generator": "^1.2.3",
+ "fs-extra": "^4.0.1",
"inflection": "^1.12.0",
"jquery": "^3.2.1",
"resolve": "^1.3.3", | true |
Other | emberjs | ember.js | acdd288d1ea52cee19587eb3be30857069233fb8.json | add fs-extra to deps | yarn.lock | @@ -2905,6 +2905,14 @@ fs-extra@^2.0.0:
graceful-fs "^4.1.2"
jsonfile "^2.1.0"
+fs-extra@^4.0.1:
+ version "4.0.1"
+ resolved "https://registry.yarnpkg.com/fs-extra/-/fs-extra-4.0.1.tgz#7fc0c6c8957f983f57f306a24e5b9ddd8d0dd880"
+ dependencies:
+ graceful-fs "^4.1.2"
+ jsonfile "^3.0.0"
+ universalify "^0.1.0"
+
fs-readdir-recursive@^0.1.0:
version "0.1.2"
resolved "https://registry.yarnpkg.com/fs-readdir-recursive/-/fs-readdir-recursive-0.1.2.tgz#315b4fb8c1ca5b8c47defef319d073dad3568059"
@@ -3747,6 +3755,12 @@ jsonfile@^2.1.0:
optionalDependencies:
graceful-fs "^4.1.6"
+jsonfile@^3.0.0:
+ version "3.0.1"
+ resolved "https://registry.yarnpkg.com/jsonfile/-/jsonfile-3.0.1.tgz#a5ecc6f65f53f662c4415c7675a0331d0992ec66"
+ optionalDependencies:
+ graceful-fs "^4.1.6"
+
jsonify@~0.0.0:
version "0.0.0"
resolved "https://registry.yarnpkg.com/jsonify/-/jsonify-0.0.0.tgz#2c74b6ee41d93ca51b7b5aaee8f503631d252a73"
@@ -6056,6 +6070,10 @@ unique-slug@^2.0.0:
dependencies:
imurmurhash "^0.1.4"
+universalify@^0.1.0:
+ version "0.1.1"
+ resolved "https://registry.yarnpkg.com/universalify/-/universalify-0.1.1.tgz#fa71badd4437af4c148841e3b3b165f9e9e590b7"
+
unpipe@~1.0.0:
version "1.0.0"
resolved "https://registry.yarnpkg.com/unpipe/-/unpipe-1.0.0.tgz#b2bf4ee8514aae6165b4817829d21b2ef49904ec" | true |
Other | emberjs | ember.js | 15e1d153b8198776df51915459cd12b1e8d67f1d.json | Fix script that publishes to Rubygems
Apparently a brilliant young man tacked a `.strip` to the end of a bash command in hopes that it would strip whitespace.
Of course, what ended up happening was that a gem with `.strip` tacked on to the end of the name would not be found in the filesystem by the publish command. | bin/publish_npm_and_bower | @@ -88,7 +88,7 @@ if [[ "$TRAVIS_TAG" =~ ^v[0-9.]+ ]]; then
chmod 0600 ~/.gem/credentials
gem build ember-source.gemspec
- gem push `echo *.gem`.strip
+ gem push `echo *.gem`
fi
#### BOWER PUBLISHING | false |
Other | emberjs | ember.js | 922aed6f70b6daae16a0c0c5a351d9e243916c77.json | Add 2.15.3 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 53cfa5995c79fcf5892fd4910b43882a50240b46) | CHANGELOG.md | @@ -30,6 +30,10 @@
- [#15528](https://github.com/emberjs/ember.js/pull/15528) [DEPRECATION] Deprecate `Controller#content` alias.
- [#15552](https://github.com/emberjs/ember.js/pull/15552) [FEATURE] Update blueprints and tests to RFC #176.
+### 2.15.3 (October 9, 2017)
+
+- [#15718](https://github.com/emberjs/ember.js/pull/15718) [BUGFIX] bump backburner (fixes clock + autorun interop)
+
### 2.15.2 (October 4, 2017)
- [#15604](https://github.com/emberjs/ember.js/pull/15604) [BUGFIX] Ember Inspector Data Adapter: Only trigger model type update if the record live array count actually changed. | false |
Other | emberjs | ember.js | 8bfa2013de2c15108b123f41b6a407a56f64108e.json | Add 2.17.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit 99d993cf529ee19e0ce29779eaf5524255d8f999) | CHANGELOG.md | @@ -1,5 +1,11 @@
# Ember Changelog
+### 2.17.0-beta.2 (October 17, 2017)
+- [#15613](https://github.com/emberjs/ember.js/pull/15613) [BUGFIX] Don't throw an error, when not all query params are passed to routerService.transitionTo
+- [#15707](https://github.com/emberjs/ember.js/pull/15707) [BUGFIX] Fix `canInvoke` for edge cases
+- [#15722](https://github.com/emberjs/ember.js/pull/15722) [BUGFIX] empty path in `get` helper should not throw assertion
+- [#15733](https://github.com/emberjs/ember.js/pull/15733) [BUGFIX] Fix computed sort regression when array prop initially null
+
### 2.17.0-beta.1 (October 9, 2017)
- [#15265](https://github.com/emberjs/ember.js/pull/15265) [BUGFIX] fixed issue when passing `false` to `activeClass` for `{{link-to}}` | false |
Other | emberjs | ember.js | 70a3d879b8b7a64b7bf11da5479fd3dfc6191241.json | Add v2.17.0-beta.1 to CHANGELOG.
[ci skip]
(cherry picked from commit 07d4236bd94604d9392f50dbf0941f168e2ee9de) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### 2.17.0-beta.1 (October 9, 2017)
+
+- [#15265](https://github.com/emberjs/ember.js/pull/15265) [BUGFIX] fixed issue when passing `false` to `activeClass` for `{{link-to}}`
+- [#15672](https://github.com/emberjs/ember.js/pull/15672) Update router_js to 2.0.0.
+
### 2.16.0 (October 9, 2017)
- [#15604](https://github.com/emberjs/ember.js/pull/15604) Data Adapter: Only trigger model type update if the record live array count actually changed | false |
Other | emberjs | ember.js | 64dfd70b4e875c8b5b0fe0def3da5b358fdea904.json | Add 2.16.0 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 3576aee3e04970d25a1470ad784c14d504516c1d) | CHANGELOG.md | @@ -1,19 +1,20 @@
# Ember Changelog
-### 2.16.0-beta.2 (October, 2, 2017)
+### 2.16.0 (October 9, 2017)
+- [#15604](https://github.com/emberjs/ember.js/pull/15604) Data Adapter: Only trigger model type update if the record live array count actually changed
+- [#15610](https://github.com/emberjs/ember.js/pull/15610) [BUGFIX] add inflection to dependencies
+- [#15695](https://github.com/emberjs/ember.js/pull/15695) [BUGFIX] Avoid creating event dispatcher in FastBoot with Engines
+- [#15702](https://github.com/emberjs/ember.js/pull/15702) [BUGFIX] Correctly escape values in `Ember.CoreObject` assertions
+- [#15718](https://github.com/emberjs/ember.js/pull/15718) [BUGFIX] bump backburner (fixes clock + autorun interop)
- [#15577](https://github.com/emberjs/ember.js/pull/15577) [BUGFIX] Include missing sourcemaps in vendorTree.
- [#15552](https://github.com/emberjs/ember.js/pull/15552) [FEATURE] Update blueprints and tests to RFC #176.
- [#15600](https://github.com/emberjs/ember.js/pull/15600) [BUGFIX] ensure “pause on exception” pauses in the right place.
- [#15616](https://github.com/emberjs/ember.js/pull/15616) [DOC release] Improve documentation for RouterService and mount helper.
-- [#15600](https://github.com/emberjs/ember.js/pull/15600) [BUGFIX LTS] ensure “pause on exception” pauses in the right place.
+- [#15600](https://github.com/emberjs/ember.js/pull/15600) [BUGFIX] ensure “pause on exception” pauses in the right place.
- [#15667](https://github.com/emberjs/ember.js/pull/15667) [BUGFIX] Allow `0` to work with `get` helper.
- [#15676](https://github.com/emberjs/ember.js/pull/15676) [BUGFIX] Fix `<input type="range">` so that it can properly bind `min`, `max`, and `value`.
- [#15689](https://github.com/emberjs/ember.js/pull/15689) [BUGFIX] Mark error as handled before transition for error routes and substates.
-
-
-### 2.16.0-beta.1 (August 31, 2017)
-
- [#14764](https://github.com/emberjs/ember.js/pull/14764) Fixed string capitalize for accented characters.
- [#15528](https://github.com/emberjs/ember.js/pull/15528) [DEPRECATION] Deprecate `Controller#content` alias.
- [#15552](https://github.com/emberjs/ember.js/pull/15552) [FEATURE] Update blueprints and tests to RFC #176. | false |
Other | emberjs | ember.js | c46c19dbc6cc2c6bf9bb033400a818fcbfcebe99.json | Add 2.15.2 to CHANGELOG.
[ci skip] | CHANGELOG.md | @@ -18,6 +18,11 @@
- [#15528](https://github.com/emberjs/ember.js/pull/15528) [DEPRECATION] Deprecate `Controller#content` alias.
- [#15552](https://github.com/emberjs/ember.js/pull/15552) [FEATURE] Update blueprints and tests to RFC #176.
+### 2.15.2 (October 4, 2017)
+
+- [#15604](https://github.com/emberjs/ember.js/pull/15604) [BUGFIX] Ember Inspector Data Adapter: Only trigger model type update if the record live array count actually changed.
+- [#15695](https://github.com/emberjs/ember.js/pull/15695) [BUGFIX] Avoid creating event dispatcher in FastBoot with Engines.
+
### 2.15.1 (October 2, 2017)
- [#15600](https://github.com/emberjs/ember.js/pull/15600) [BUGFIX] ensure “pause on exception” pauses in the right place. | false |
Other | emberjs | ember.js | 9a6b038d303ade2f643ad0499054457403f86294.json | Add 2.15.1 to CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -18,6 +18,11 @@
- [#15528](https://github.com/emberjs/ember.js/pull/15528) [DEPRECATION] Deprecate `Controller#content` alias.
- [#15552](https://github.com/emberjs/ember.js/pull/15552) [FEATURE] Update blueprints and tests to RFC #176.
+### 2.15.1 (October 2, 2017)
+
+- [#15600](https://github.com/emberjs/ember.js/pull/15600) [BUGFIX] ensure “pause on exception” pauses in the right place.
+- [#15689](https://github.com/emberjs/ember.js/pull/15689) [BUGFIX] Mark error as handled before transition for error routes and substates.
+
### 2.15.0 (August 31, 2017)
- [#15577](https://github.com/emberjs/ember.js/pull/15577) [BUGFIX] Include missing sourcemaps in vendorTree. | false |
Other | emberjs | ember.js | a9a36f4f8931488de40c64f4f190c0c3ce5be035.json | Update CHANGELOG for 2.16.0-beta.2.
[ci skip] | CHANGELOG.md | @@ -1,5 +1,17 @@
# Ember Changelog
+### 2.16.0-beta.2 (October, 2, 2017)
+
+- [#15577](https://github.com/emberjs/ember.js/pull/15577) [BUGFIX] Include missing sourcemaps in vendorTree.
+- [#15552](https://github.com/emberjs/ember.js/pull/15552) [FEATURE] Update blueprints and tests to RFC #176.
+- [#15600](https://github.com/emberjs/ember.js/pull/15600) [BUGFIX] ensure “pause on exception” pauses in the right place.
+- [#15616](https://github.com/emberjs/ember.js/pull/15616) [DOC release] Improve documentation for RouterService and mount helper.
+- [#15600](https://github.com/emberjs/ember.js/pull/15600) [BUGFIX LTS] ensure “pause on exception” pauses in the right place.
+- [#15667](https://github.com/emberjs/ember.js/pull/15667) [BUGFIX] Allow `0` to work with `get` helper.
+- [#15676](https://github.com/emberjs/ember.js/pull/15676) [BUGFIX] Fix `<input type="range">` so that it can properly bind `min`, `max`, and `value`.
+- [#15689](https://github.com/emberjs/ember.js/pull/15689) [BUGFIX] Mark error as handled before transition for error routes and substates.
+
+
### 2.16.0-beta.1 (August 31, 2017)
- [#14764](https://github.com/emberjs/ember.js/pull/14764) Fixed string capitalize for accented characters. | false |
Other | emberjs | ember.js | 774a192ece628d08a3fcd877f8395f858aa33972.json | move `normalizeInjectionsHash` definition to debug | packages/container/lib/container.js | @@ -404,7 +404,7 @@ class FactoryManager {
}
toString() {
- if (!this.madeToString) {
+ if (this.madeToString === undefined) {
this.madeToString = this.container.registry.makeToString(this.class, this.fullName);
}
| true |
Other | emberjs | ember.js | 774a192ece628d08a3fcd877f8395f858aa33972.json | move `normalizeInjectionsHash` definition to debug | packages/container/lib/registry.js | @@ -568,23 +568,6 @@ Registry.prototype = {
return VALID_FULL_NAME_REGEXP.test(fullName);
},
- normalizeInjectionsHash(hash) {
- let injections = [];
-
- for (let key in hash) {
- if (hash.hasOwnProperty(key)) {
- assert(`Expected a proper full name, given '${hash[key]}'`, this.validateFullName(hash[key]));
-
- injections.push({
- property: key,
- fullName: hash[key]
- });
- }
- }
-
- return injections;
- },
-
getInjections(fullName) {
let injections = this._injections[fullName] || [];
if (this.fallback) {
@@ -655,6 +638,23 @@ function deprecateResolverFunction(registry) {
}
if (DEBUG) {
+ Registry.prototype.normalizeInjectionsHash = function(hash) {
+ let injections = [];
+
+ for (let key in hash) {
+ if (hash.hasOwnProperty(key)) {
+ assert(`Expected a proper full name, given '${hash[key]}'`, this.validateFullName(hash[key]));
+
+ injections.push({
+ property: key,
+ fullName: hash[key]
+ });
+ }
+ }
+
+ return injections;
+ }
+
Registry.prototype.validateInjections = function(injections) {
if (!injections) { return; }
| true |
Other | emberjs | ember.js | 6aab203232c633486ef42189eaf66261550c9168.json | reuse meta for `didUnwatch` and `willWatch` | packages/ember-metal/lib/alias.js | @@ -41,12 +41,12 @@ export class AliasedProperty extends Descriptor {
}
}
- willWatch(obj, keyName) {
- addDependentKeys(this, obj, keyName, metaFor(obj));
+ willWatch(obj, keyName, meta) {
+ addDependentKeys(this, obj, keyName, meta);
}
- didUnwatch(obj, keyName) {
- removeDependentKeys(this, obj, keyName, metaFor(obj));
+ didUnwatch(obj, keyName, meta) {
+ removeDependentKeys(this, obj, keyName, meta);
}
get(obj, keyName) { | true |
Other | emberjs | ember.js | 6aab203232c633486ef42189eaf66261550c9168.json | reuse meta for `didUnwatch` and `willWatch` | packages/ember-metal/lib/watch_key.js | @@ -13,34 +13,33 @@ import {
let handleMandatorySetter;
-export function watchKey(obj, keyName, meta) {
+export function watchKey(obj, keyName, _meta) {
if (typeof obj !== 'object' || obj === null) { return; }
- let m = meta === undefined ? metaFor(obj) : meta;
- let count = m.peekWatching(keyName) || 0;
- m.writeWatching(keyName, count + 1);
+ let meta = _meta === undefined ? metaFor(obj) : _meta;
+ let count = meta.peekWatching(keyName) || 0;
+ meta.writeWatching(keyName, count + 1);
if (count === 0) { // activate watching first time
let possibleDesc = obj[keyName];
let isDescriptor = possibleDesc !== null &&
typeof possibleDesc === 'object' && possibleDesc.isDescriptor;
- if (isDescriptor && possibleDesc.willWatch) { possibleDesc.willWatch(obj, keyName); }
+ if (isDescriptor && possibleDesc.willWatch) { possibleDesc.willWatch(obj, keyName, meta); }
- if ('function' === typeof obj.willWatchProperty) {
+ if (typeof obj.willWatchProperty === 'function') {
obj.willWatchProperty(keyName);
}
if (MANDATORY_SETTER) {
// NOTE: this is dropped for prod + minified builds
- handleMandatorySetter(m, obj, keyName);
+ handleMandatorySetter(meta, obj, keyName);
}
}
}
if (MANDATORY_SETTER) {
let hasOwnProperty = (obj, key) => Object.prototype.hasOwnProperty.call(obj, key);
-
let propertyIsEnumerable = (obj, key) => Object.prototype.propertyIsEnumerable.call(obj, key);
// Future traveler, although this code looks scary. It merely exists in
@@ -97,9 +96,9 @@ export function unwatchKey(obj, keyName, _meta) {
let isDescriptor = possibleDesc !== null &&
typeof possibleDesc === 'object' && possibleDesc.isDescriptor;
- if (isDescriptor && possibleDesc.didUnwatch) { possibleDesc.didUnwatch(obj, keyName); }
+ if (isDescriptor && possibleDesc.didUnwatch) { possibleDesc.didUnwatch(obj, keyName, meta); }
- if ('function' === typeof obj.didUnwatchProperty) {
+ if (typeof obj.didUnwatchProperty === 'function') {
obj.didUnwatchProperty(keyName);
}
| true |
Other | emberjs | ember.js | e9399bfdcea7c0580ae6e24ec5cef372af4d6086.json | Update router_js to 2.0.0.
The diff of the changes is pretty noisey (due to lots of general
cleanup work that was done), but for the most part the changes are:
* Drop support for non ES5 browsers (use `Array.isArray`,
`Object.create`, etc directly)
* Refactor the dist output to emit `module` entry point.
* Update to use classes throughout the repo.
* Ensure `Route.prototype.serialize` is called bound to the route
instance. | broccoli/packages.js | @@ -16,24 +16,10 @@ const { stripIndent } = require('common-tags');
const toES5 = require('./to-es5');
module.exports.routerES = function _routerES() {
- return new Rollup(findLib('router_js', 'lib'), {
+ return new Rollup(findLib('router_js'), {
rollup: {
external: ['route-recognizer', 'rsvp'],
- entry: 'router.js',
- plugins: [{
- transform(code, id) {
- if (/[^t][^e][^r]\/router\.js$/.test(id)) {
- code += 'export { Transition } from \'./router/transition\';\n'
- } else if (/\/router\/handler-info\/[^\/]+\.js$/.test(id)) {
- code = code.replace(/\'router\//g, '\'../');
- }
- code = code.replace(/import\ Promise\ from \'rsvp\/promise\'/g, 'import { Promise } from \'rsvp\'')
- return {
- code: code,
- map: { mappings: '' }
- };
- }
- }],
+ entry: 'index.js',
targets: [{
dest: 'router.js',
format: 'es' | true |
Other | emberjs | ember.js | e9399bfdcea7c0580ae6e24ec5cef372af4d6086.json | Update router_js to 2.0.0.
The diff of the changes is pretty noisey (due to lots of general
cleanup work that was done), but for the most part the changes are:
* Drop support for non ES5 browsers (use `Array.isArray`,
`Object.create`, etc directly)
* Refactor the dist output to emit `module` entry point.
* Update to use classes throughout the repo.
* Ensure `Route.prototype.serialize` is called bound to the route
instance. | package.json | @@ -112,7 +112,7 @@
"qunit-phantomjs-runner": "^2.2.0",
"qunitjs": "^1.22.0",
"route-recognizer": "^0.3.3",
- "router_js": "^1.2.8",
+ "router_js": "^2.0.0-beta.1",
"semver": "^5.3.0",
"serve-static": "^1.12.2",
"simple-dom": "^0.3.0", | true |
Other | emberjs | ember.js | e9399bfdcea7c0580ae6e24ec5cef372af4d6086.json | Update router_js to 2.0.0.
The diff of the changes is pretty noisey (due to lots of general
cleanup work that was done), but for the most part the changes are:
* Drop support for non ES5 browsers (use `Array.isArray`,
`Object.create`, etc directly)
* Refactor the dist output to emit `module` entry point.
* Update to use classes throughout the repo.
* Ensure `Route.prototype.serialize` is called bound to the route
instance. | yarn.lock | @@ -5322,9 +5322,9 @@ route-recognizer@^0.3.3:
version "0.3.3"
resolved "https://registry.yarnpkg.com/route-recognizer/-/route-recognizer-0.3.3.tgz#1d365e27fa6995e091675f7dc940a8c00353bd29"
-router_js@^1.2.8:
- version "1.2.8"
- resolved "https://registry.yarnpkg.com/router_js/-/router_js-1.2.8.tgz#d2ea5d00726e1fd6494d20ae3ebeb99ce86cf0b3"
+router_js@^2.0.0-beta.1:
+ version "2.0.0-beta.1"
+ resolved "https://registry.yarnpkg.com/router_js/-/router_js-2.0.0-beta.1.tgz#6f267b5171bbe1e92729db3e8be447e6a9d63f5a"
rsvp@3.0.14:
version "3.0.14" | true |
Other | emberjs | ember.js | a66d9a5369108a43263b445aa9316af66e64b7c1.json | move method definition to es6 class `Mixin` | packages/ember-metal/lib/mixin.js | @@ -521,76 +521,106 @@ export default class Mixin {
return ret;
}
-}
-Mixin._apply = applyMixin;
+ /**
+ @method reopen
+ @param arguments*
+ @private
+ */
+ reopen() {
+ let currentMixin;
+
+ if (this.properties) {
+ currentMixin = new Mixin(undefined, this.properties);
+ this.properties = undefined;
+ this.mixins = [currentMixin];
+ } else if (!this.mixins) {
+ this.mixins = [];
+ }
-Mixin.finishPartial = finishPartial;
+ let mixins = this.mixins;
+ let idx;
+
+ for (idx = 0; idx < arguments.length; idx++) {
+ currentMixin = arguments[idx];
+ assert(
+ `Expected hash or Mixin instance, got ${Object.prototype.toString.call(currentMixin)}`,
+ typeof currentMixin === 'object' && currentMixin !== null &&
+ Object.prototype.toString.call(currentMixin) !== '[object Array]'
+ );
+
+ if (currentMixin instanceof Mixin) {
+ mixins.push(currentMixin);
+ } else {
+ mixins.push(new Mixin(undefined, currentMixin));
+ }
+ }
-let unprocessedFlag = false;
+ return this;
+ }
-export function hasUnprocessedMixins() {
- return unprocessedFlag;
-}
+ /**
+ @method apply
+ @param obj
+ @return applied object
+ @private
+ */
+ apply(obj) {
+ return applyMixin(obj, [this], false);
+ }
-export function clearUnprocessedMixins() {
- unprocessedFlag = false;
-}
+ applyPartial(obj) {
+ return applyMixin(obj, [this], true);
+ }
-let MixinPrototype = Mixin.prototype;
+ /**
+ @method detect
+ @param obj
+ @return {Boolean}
+ @private
+ */
+ detect(obj) {
+ if (typeof obj !== 'object' || obj === null) { return false; }
+ if (obj instanceof Mixin) { return _detect(obj, this, {}); }
+ let meta = peekMeta(obj);
+ if (meta === undefined) { return false; }
+ return !!meta.peekMixins(guidFor(this));
+ }
-/**
- @method reopen
- @param arguments*
- @private
-*/
-MixinPrototype.reopen = function() {
- let currentMixin;
+ without(...args) {
+ let ret = new Mixin([this]);
+ ret._without = args;
+ return ret;
+ }
+
+ keys() {
+ let keys = {};
+ let seen = {};
- if (this.properties) {
- currentMixin = new Mixin(undefined, this.properties);
- this.properties = undefined;
- this.mixins = [currentMixin];
- } else if (!this.mixins) {
- this.mixins = [];
+ _keys(keys, this, seen);
+ let ret = Object.keys(keys);
+ return ret;
}
- let mixins = this.mixins;
- let idx;
+}
- for (idx = 0; idx < arguments.length; idx++) {
- currentMixin = arguments[idx];
- assert(
- `Expected hash or Mixin instance, got ${Object.prototype.toString.call(currentMixin)}`,
- typeof currentMixin === 'object' && currentMixin !== null &&
- Object.prototype.toString.call(currentMixin) !== '[object Array]'
- );
+Mixin._apply = applyMixin;
+Mixin.finishPartial = finishPartial;
- if (currentMixin instanceof Mixin) {
- mixins.push(currentMixin);
- } else {
- mixins.push(new Mixin(undefined, currentMixin));
- }
- }
+let MixinPrototype = Mixin.prototype;
+MixinPrototype.toString = Object.toString;
- return this;
-};
+debugSeal(MixinPrototype);
-/**
- @method apply
- @param obj
- @return applied object
- @private
-*/
-MixinPrototype.apply = function(obj) {
- return applyMixin(obj, [this], false);
-};
+let unprocessedFlag = false;
-MixinPrototype.applyPartial = function(obj) {
- return applyMixin(obj, [this], true);
-};
+export function hasUnprocessedMixins() {
+ return unprocessedFlag;
+}
-MixinPrototype.toString = Object.toString;
+export function clearUnprocessedMixins() {
+ unprocessedFlag = false;
+}
function _detect(curMixin, targetMixin, seen) {
let guid = guidFor(curMixin);
@@ -607,26 +637,6 @@ function _detect(curMixin, targetMixin, seen) {
return false;
}
-/**
- @method detect
- @param obj
- @return {Boolean}
- @private
-*/
-MixinPrototype.detect = function(obj) {
- if (typeof obj !== 'object' || obj === null) { return false; }
- if (obj instanceof Mixin) { return _detect(obj, this, {}); }
- let meta = peekMeta(obj);
- if (meta === undefined) { return false; }
- return !!meta.peekMixins(guidFor(this));
-};
-
-MixinPrototype.without = function(...args) {
- let ret = new Mixin([this]);
- ret._without = args;
- return ret;
-};
-
function _keys(ret, mixin, seen) {
if (seen[guidFor(mixin)]) { return; }
seen[guidFor(mixin)] = true;
@@ -642,17 +652,6 @@ function _keys(ret, mixin, seen) {
}
}
-MixinPrototype.keys = function() {
- let keys = {};
- let seen = {};
-
- _keys(keys, this, seen);
- let ret = Object.keys(keys);
- return ret;
-};
-
-debugSeal(MixinPrototype);
-
const REQUIRED = new Descriptor();
REQUIRED.toString = () => '(Required Property)';
| false |
Other | emberjs | ember.js | 55031ce070aa38edbc4ba6eda166d316a9fd4860.json | avoid boolean coercion when checking for object | packages/ember-metal/lib/merge.js | @@ -16,7 +16,7 @@
@public
*/
export default function merge(original, updates) {
- if (!updates || typeof updates !== 'object') {
+ if (updates === null || typeof updates !== 'object') {
return original;
}
| true |
Other | emberjs | ember.js | 55031ce070aa38edbc4ba6eda166d316a9fd4860.json | avoid boolean coercion when checking for object | packages/ember-metal/lib/set_properties.js | @@ -23,7 +23,7 @@ import { set } from './property_set';
@public
*/
export default function setProperties(obj, properties) {
- if (!properties || typeof properties !== 'object') { return properties; }
+ if (properties === null || typeof properties !== 'object') { return properties; }
changeProperties(() => {
let props = Object.keys(properties);
let propertyName; | true |
Other | emberjs | ember.js | b3bbb86ad71e1a1ba26a8cffa856deaca7b1e7e3.json | remove unused things in `helpers/component` | packages/ember-glimmer/lib/helpers/component.js | @@ -6,14 +6,12 @@ import { assign } from 'ember-utils';
import { CachedReference } from '../utils/references';
import {
CurlyComponentDefinition,
- validatePositionalParameters,
- PositionalArgumentsReference
+ validatePositionalParameters
} from '../component-managers/curly';
import {
isComponentDefinition
} from '@glimmer/runtime';
import { assert } from 'ember-debug';
-import { DEBUG } from 'ember-env-flags';
/**
The `{{component}}` helper lets you add instances of `Ember.Component` to a
@@ -212,15 +210,6 @@ function createCurriedDefinition(definition, args) {
);
}
-let EMPTY_BLOCKS = {
- default: null,
- inverse: null
-};
-
-if (DEBUG) {
- EMPTY_BLOCKS = Object.freeze(EMPTY_BLOCKS);
-}
-
function curryArgs(definition, newArgs) {
let { args, ComponentClass } = definition;
let positionalParams = ComponentClass.class.positionalParams; | false |
Other | emberjs | ember.js | 76930018d95954d8a5bab1972f5c8b57eee96081.json | run Travis on tagged builds | .travis.yml | @@ -36,6 +36,8 @@ branches:
- master
- beta
- stable
+ # npm version tags
+ - /^v\d+\.\d+\.\d+$/
env:
global: | false |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/alias.js | @@ -36,7 +36,7 @@ export class AliasedProperty extends Descriptor {
}
teardown(obj, keyName, meta) {
- if (meta && meta.peekWatching(keyName)) {
+ if (meta.peekWatching(keyName)) {
removeDependentKeys(this, obj, keyName, meta);
}
} | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/computed.js | @@ -547,8 +547,8 @@ export default function computed(...args) {
*/
function cacheFor(obj, key) {
let meta = peekMeta(obj);
- let cache = meta && meta.source === obj && meta.readableCache();
- let ret = cache && cache[key];
+ let cache = meta !== undefined ? meta.source === obj && meta.readableCache() : undefined;
+ let ret = cache !== undefined ? cache[key] : undefined;
if (ret === UNDEFINED) {
return undefined; | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/events.js | @@ -146,7 +146,7 @@ export function suspendListeners(obj, eventNames, target, method, callback) {
*/
export function watchedEvents(obj) {
let meta = peekMeta(obj);
- return meta && meta.watchedEvents() || [];
+ return meta !== undefined ? meta.watchedEvents() : [];
}
/**
@@ -167,7 +167,7 @@ export function watchedEvents(obj) {
*/
export function sendEvent(obj, eventName, params, actions, _meta) {
if (actions === undefined) {
- let meta = _meta || peekMeta(obj);
+ let meta = _meta === undefined ? peekMeta(obj) : _meta;
actions = typeof meta === 'object' &&
meta !== null &&
meta.matchingListeners(eventName);
@@ -225,9 +225,9 @@ export function hasListeners(obj, eventName) {
export function listenersFor(obj, eventName) {
let ret = [];
let meta = peekMeta(obj);
- let actions = meta && meta.matchingListeners(eventName);
+ let actions = meta !== undefined ? meta.matchingListeners(eventName) : undefined;
- if (!actions) { return ret; }
+ if (actions === undefined) { return ret; }
for (let i = 0; i < actions.length; i += 3) {
let target = actions[i]; | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/mixin.js | @@ -291,7 +291,7 @@ function connectBindings(obj, meta) {
}
function finishPartial(obj, meta) {
- connectBindings(obj, meta || metaFor(obj));
+ connectBindings(obj, meta === undefined ? metaFor(obj) : meta);
return obj;
}
| true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/property_events.js | @@ -42,10 +42,10 @@ let deferred = 0;
@private
*/
function propertyWillChange(obj, keyName, _meta) {
- let meta = _meta || peekMeta(obj);
- if (meta && !meta.isInitialized(obj)) { return; }
+ let meta = _meta === undefined ? peekMeta(obj) : _meta;
+ if (meta !== undefined && !meta.isInitialized(obj)) { return; }
- let watching = meta && meta.peekWatching(keyName) > 0;
+ let watching = meta !== undefined && meta.peekWatching(keyName) > 0;
let possibleDesc = obj[keyName];
let isDescriptor = possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor;
@@ -78,8 +78,8 @@ function propertyWillChange(obj, keyName, _meta) {
@private
*/
function propertyDidChange(obj, keyName, _meta) {
- let meta = _meta || peekMeta(obj);
- let hasMeta = !!meta;
+ let meta = _meta === undefined ? peekMeta(obj) : _meta;
+ let hasMeta = meta !== undefined;
if (hasMeta && !meta.isInitialized(obj)) { return; }
| true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/property_set.js | @@ -73,7 +73,7 @@ export function set(obj, keyName, value, tolerant) {
if (MANDATORY_SETTER) {
var setWithMandatorySetter = (meta, obj, keyName, value) => {
- if (meta && meta.peekWatching(keyName) > 0) {
+ if (meta !== undefined && meta.peekWatching(keyName) > 0) {
makeEnumerable(obj, keyName);
meta.writeValue(obj, keyName, value);
} else { | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/tags.js | @@ -15,7 +15,7 @@ function makeTag() {
export function tagForProperty(object, propertyKey, _meta) {
if (typeof object !== 'object' || object === null) { return CONSTANT_TAG; }
- let meta = _meta || metaFor(object);
+ let meta = _meta === undefined ? metaFor(object) : _meta;
if (meta.isProxy()) {
return tagFor(object, meta);
}
@@ -29,7 +29,7 @@ export function tagForProperty(object, propertyKey, _meta) {
export function tagFor(object, _meta) {
if (typeof object === 'object' && object !== null) {
- let meta = _meta || metaFor(object);
+ let meta = _meta === undefined ? metaFor(object) : _meta;
return meta.writableTag(makeTag);
} else {
return CONSTANT_TAG; | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/watch_key.js | @@ -16,7 +16,7 @@ let handleMandatorySetter;
export function watchKey(obj, keyName, meta) {
if (typeof obj !== 'object' || obj === null) { return; }
- let m = meta || metaFor(obj);
+ let m = meta === undefined ? metaFor(obj) : meta;
let count = m.peekWatching(keyName) || 0;
m.writeWatching(keyName, count + 1);
@@ -84,7 +84,7 @@ export function unwatchKey(obj, keyName, _meta) {
if (typeof obj !== 'object' || obj === null) {
return;
}
- let meta = _meta || peekMeta(obj);
+ let meta = _meta === undefined ? peekMeta(obj) : _meta;
// do nothing of this object has already been destroyed
if (meta === undefined || meta.isSourceDestroyed()) { return; } | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/watch_path.js | @@ -11,7 +11,7 @@ export function makeChainNode(obj) {
export function watchPath(obj, keyPath, meta) {
if (typeof obj !== 'object' || obj === null) { return; }
- let m = meta || metaFor(obj);
+ let m = meta === undefined ? metaFor(obj) : meta;
let counter = m.peekWatching(keyPath) || 0;
m.writeWatching(keyPath, counter + 1);
@@ -22,7 +22,8 @@ export function watchPath(obj, keyPath, meta) {
export function unwatchPath(obj, keyPath, meta) {
if (typeof obj !== 'object' || obj === null) { return; }
- let m = meta || peekMeta(obj);
+ let m = meta === undefined ? peekMeta(obj) : meta;
+
if (m === undefined) { return; }
let counter = m.peekWatching(keyPath) || 0;
| true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/watching.js | @@ -44,7 +44,7 @@ export function isWatching(obj, key) {
export function watcherCount(obj, key) {
let meta = peekMeta(obj);
- return (meta && meta.peekWatching(key)) || 0;
+ return (meta !== undefined && meta.peekWatching(key)) || 0;
}
export function unwatch(obj, _keyPath, m) { | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-runtime/lib/mixins/array.js | @@ -657,7 +657,7 @@ EachProxy.prototype = {
let lim = removedCnt > 0 ? idx + removedCnt : -1;
let meta;
for (let key in keys) {
- meta = meta || peekMeta(this);
+ meta = meta === undefined ? peekMeta(this) : meta;
if (lim > 0) {
removeObserverForContentKey(content, key, this, idx, lim);
}
@@ -670,7 +670,7 @@ EachProxy.prototype = {
let lim = addedCnt > 0 ? idx + addedCnt : -1;
let meta;
for (let key in keys) {
- meta = meta || peekMeta(this);
+ meta = meta === undefined ? peekMeta(this) : meta;
if (lim > 0) {
addObserverForContentKey(content, key, this, idx, lim);
} | true |
Other | emberjs | ember.js | cb2cadf9912e1b4616aea1e090b8c2b920b3db77.json | use a fixture to test `helper-test` blueprint | node-tests/blueprints/helper-test.js | @@ -1,5 +1,6 @@
'use strict';
+const file = require('../helpers/file');
var blueprintHelpers = require('ember-cli-blueprint-test-helpers/helpers');
var setupTestHooks = blueprintHelpers.setupTestHooks;
var emberNew = blueprintHelpers.emberNew;
@@ -28,26 +29,26 @@ describe('Acceptance: ember generate and destroy helper', function() {
"export default helper(fooBarBaz);");
expect(_file('tests/integration/helpers/foo/bar-baz-test.js'))
- .to.contain("moduleForComponent('foo/bar-baz', 'helper:foo/bar-baz', {");
+ .to.equal(file('helper-test/integration.js'));
}));
});
- it('in-addon helper foo-bar', function() {
- var args = ['helper', 'foo-bar'];
+ it('in-addon helper foo/bar-baz', function() {
+ var args = ['helper', 'foo/bar-baz'];
return emberNew({ target: 'addon' })
.then(() => emberGenerateDestroy(args, _file => {
- expect(_file('addon/helpers/foo-bar.js'))
+ expect(_file('addon/helpers/foo/bar-baz.js'))
.to.contain("import { helper } from '@ember/component/helper';\n\n" +
- "export function fooBar(params/*, hash*/) {\n" +
+ "export function fooBarBaz(params/*, hash*/) {\n" +
" return params;\n" +
"}\n\n" +
- "export default helper(fooBar);");
+ "export default helper(fooBarBaz);");
- expect(_file('app/helpers/foo-bar.js'))
- .to.contain("export { default, fooBar } from 'my-addon/helpers/foo-bar';");
- expect(_file('tests/integration/helpers/foo-bar-test.js'))
- .to.contain("moduleForComponent('foo-bar', 'helper:foo-bar', {");
+ expect(_file('app/helpers/foo/bar-baz.js'))
+ .to.contain("export { default, fooBarBaz } from 'my-addon/helpers/foo/bar-baz';");
+ expect(_file('tests/integration/helpers/foo/bar-baz-test.js'))
+ .to.equal(file('helper-test/integration.js'));
}));
});
@@ -66,7 +67,7 @@ describe('Acceptance: ember generate and destroy helper', function() {
expect(_file('app/helpers/foo/bar-baz.js'))
.to.contain("export { default, fooBarBaz } from 'my-addon/helpers/foo/bar-baz';");
expect(_file('tests/integration/helpers/foo/bar-baz-test.js'))
- .to.contain("moduleForComponent('foo/bar-baz', 'helper:foo/bar-baz', {");
+ .to.equal(file('helper-test/integration.js'));
}));
});
@@ -108,22 +109,22 @@ describe('Acceptance: ember generate and destroy helper', function() {
}));
});
- it('in-repo-addon helper foo-bar', function() {
- var args = ['helper', 'foo-bar', '--in-repo-addon=my-addon'];
+ it('in-repo-addon helper foo/bar-baz', function() {
+ var args = ['helper', 'foo/bar-baz', '--in-repo-addon=my-addon'];
return emberNew({ target: 'in-repo-addon' })
.then(() => emberGenerateDestroy(args, _file => {
- expect(_file('lib/my-addon/addon/helpers/foo-bar.js'))
+ expect(_file('lib/my-addon/addon/helpers/foo/bar-baz.js'))
.to.contain("import { helper } from '@ember/component/helper';\n\n" +
- "export function fooBar(params/*, hash*/) {\n" +
+ "export function fooBarBaz(params/*, hash*/) {\n" +
" return params;\n" +
"}\n\n" +
- "export default helper(fooBar);");
+ "export default helper(fooBarBaz);");
- expect(_file('lib/my-addon/app/helpers/foo-bar.js'))
- .to.contain("export { default, fooBar } from 'my-addon/helpers/foo-bar';");
- expect(_file('tests/integration/helpers/foo-bar-test.js'))
- .to.contain("moduleForComponent('foo-bar', 'helper:foo-bar', {");
+ expect(_file('lib/my-addon/app/helpers/foo/bar-baz.js'))
+ .to.contain("export { default, fooBarBaz } from 'my-addon/helpers/foo/bar-baz';");
+ expect(_file('tests/integration/helpers/foo/bar-baz-test.js'))
+ .to.equal(file('helper-test/integration.js'));
}));
});
@@ -142,42 +143,42 @@ describe('Acceptance: ember generate and destroy helper', function() {
expect(_file('lib/my-addon/app/helpers/foo/bar-baz.js'))
.to.contain("export { default, fooBarBaz } from 'my-addon/helpers/foo/bar-baz';");
expect(_file('tests/integration/helpers/foo/bar-baz-test.js'))
- .to.contain("moduleForComponent('foo/bar-baz', 'helper:foo/bar-baz', {");
+ .to.equal(file('helper-test/integration.js'));
}));
});
- it('helper foo-bar --pod', function() {
- var args = ['helper', 'foo-bar', '--pod'];
+ it('helper foo/bar-baz --pod', function() {
+ var args = ['helper', 'foo/bar-baz', '--pod'];
return emberNew()
.then(() => emberGenerateDestroy(args, _file => {
- expect(_file('app/helpers/foo-bar.js'))
+ expect(_file('app/helpers/foo/bar-baz.js'))
.to.contain("import { helper } from '@ember/component/helper';\n\n" +
- "export function fooBar(params/*, hash*/) {\n" +
+ "export function fooBarBaz(params/*, hash*/) {\n" +
" return params;\n" +
"}\n\n" +
- "export default helper(fooBar);");
+ "export default helper(fooBarBaz);");
- expect(_file('tests/integration/helpers/foo-bar-test.js'))
- .to.contain("moduleForComponent('foo-bar', 'helper:foo-bar', {");
+ expect(_file('tests/integration/helpers/foo/bar-baz-test.js'))
+ .to.equal(file('helper-test/integration.js'));
}));
});
- it('helper foo-bar --pod podModulePrefix', function() {
- var args = ['helper', 'foo-bar', '--pod'];
+ it('helper foo/bar-baz --pod podModulePrefix', function() {
+ var args = ['helper', 'foo/bar-baz', '--pod'];
return emberNew()
.then(() => setupPodConfig({ podModulePrefix: true }))
.then(() => emberGenerateDestroy(args, _file => {
- expect(_file('app/helpers/foo-bar.js'))
+ expect(_file('app/helpers/foo/bar-baz.js'))
.to.contain("import { helper } from '@ember/component/helper';\n\n" +
- "export function fooBar(params/*, hash*/) {\n" +
+ "export function fooBarBaz(params/*, hash*/) {\n" +
" return params;\n" +
"}\n\n" +
- "export default helper(fooBar);");
+ "export default helper(fooBarBaz);");
- expect(_file('tests/integration/helpers/foo-bar-test.js'))
- .to.contain("moduleForComponent('foo-bar', 'helper:foo-bar', {");
+ expect(_file('tests/integration/helpers/foo/bar-baz-test.js'))
+ .to.equal(file('helper-test/integration.js'));
}));
});
@@ -194,7 +195,7 @@ describe('Acceptance: ember generate and destroy helper', function() {
"export default helper(fooBarBaz);");
expect(_file('tests/integration/helpers/foo/bar-baz-test.js'))
- .to.contain("moduleForComponent('foo/bar-baz', 'helper:foo/bar-baz', {");
+ .to.equal(file('helper-test/integration.js'));
}));
});
@@ -212,7 +213,7 @@ describe('Acceptance: ember generate and destroy helper', function() {
"export default helper(fooBarBaz);");
expect(_file('tests/integration/helpers/foo/bar-baz-test.js'))
- .to.contain("moduleForComponent('foo/bar-baz', 'helper:foo/bar-baz', {");
+ .to.equal(file('helper-test/integration.js'));
}));
});
@@ -222,7 +223,7 @@ describe('Acceptance: ember generate and destroy helper', function() {
return emberNew()
.then(() => emberGenerateDestroy(args, _file => {
expect(_file('tests/integration/helpers/foo/bar-baz-test.js'))
- .to.contain("moduleForComponent('foo/bar-baz', 'helper:foo/bar-baz', {");
+ .to.equal(file('helper-test/integration.js'));
}));
});
@@ -232,17 +233,17 @@ describe('Acceptance: ember generate and destroy helper', function() {
return emberNew()
.then(() => emberGenerateDestroy(args, _file => {
expect(_file('tests/integration/helpers/foo/bar-baz-test.js'))
- .to.contain("moduleForComponent('foo/bar-baz', 'helper:foo/bar-baz', {");
+ .to.equal(file('helper-test/integration.js'));
}));
});
- it('in-addon helper-test foo-bar', function() {
- var args = ['helper-test', 'foo-bar'];
+ it('in-addon helper-test foo/bar-baz', function() {
+ var args = ['helper-test', 'foo/bar-baz'];
return emberNew({ target: 'addon' })
.then(() => emberGenerateDestroy(args, _file => {
- expect(_file('tests/integration/helpers/foo-bar-test.js'))
- .to.contain("moduleForComponent('foo-bar', 'helper:foo-bar', {");
+ expect(_file('tests/integration/helpers/foo/bar-baz-test.js'))
+ .to.equal(file('helper-test/integration.js'));
}));
});
| true |
Other | emberjs | ember.js | cb2cadf9912e1b4616aea1e090b8c2b920b3db77.json | use a fixture to test `helper-test` blueprint | node-tests/fixtures/helper-test/integration.js | @@ -0,0 +1,17 @@
+
+import { moduleForComponent, test } from 'ember-qunit';
+import hbs from 'htmlbars-inline-precompile';
+
+moduleForComponent('foo/bar-baz', 'helper:foo/bar-baz', {
+ integration: true
+});
+
+// Replace this with your real tests.
+test('it renders', function(assert) {
+ this.set('inputValue', '1234');
+
+ this.render(hbs`{{foo/bar-baz inputValue}}`);
+
+ assert.equal(this.$().text().trim(), '1234');
+});
+ | true |
Other | emberjs | ember.js | cb2cadf9912e1b4616aea1e090b8c2b920b3db77.json | use a fixture to test `helper-test` blueprint | node-tests/helpers/file.js | @@ -0,0 +1,8 @@
+'use strict';
+
+const path = require('path');
+const file = require('ember-cli-blueprint-test-helpers/chai').file;
+
+module.exports = function(filePath) {
+ return file(path.join(__dirname, '../fixtures', filePath));
+}; | true |
Other | emberjs | ember.js | 21ab4894123b8ff69fe09422120dc0ee5b92d10c.json | Update CHANGELOG.md for 2.16.0-beta.1.
[ci skip]
(cherry picked from commit 8903e1cb2c8e7ab1457eef9261f27359a046104f) | CHANGELOG.md | @@ -1,5 +1,11 @@
# Ember Changelog
+### 2.16.0-beta.1 (August 31, 2017)
+
+- [#14764](https://github.com/emberjs/ember.js/pull/14764) Fixed string capitalize for accented characters.
+- [#15528](https://github.com/emberjs/ember.js/pull/15528) [DEPRECATION] Deprecate `Controller#content` alias.
+- [#15552](https://github.com/emberjs/ember.js/pull/15552) [FEATURE] Update blueprints and tests to RFC #176.
+
### 2.15.0 (August 31, 2017)
- [#15577](https://github.com/emberjs/ember.js/pull/15577) [BUGFIX] Include missing sourcemaps in vendorTree. | false |
Other | emberjs | ember.js | defdd1e27472a99875ce928bc138d46b3d2a770b.json | Update CHANGELOG for 2.15.0.
[ci skip] | CHANGELOG.md | @@ -1,22 +1,17 @@
# Ember Changelog
-### 2.15.0-beta.3 (August 8, 2017)
+### 2.15.0 (August 31, 2017)
+- [#15577](https://github.com/emberjs/ember.js/pull/15577) [BUGFIX] Include missing sourcemaps in vendorTree.
- [#14848](https://github.com/emberjs/ember.js/pull/14848) [BUGFIX] Allow boolean values for current-when
- [#15572](https://github.com/emberjs/ember.js/pull/15572) [BUGFIX] Fix issue with using negative numbers as an argument passed in from the template.
- [#15535](https://github.com/emberjs/ember.js/pull/15535) [BUGFIX] Ensure that properties of functions are able to be rendered.
- [#14753](https://github.com/emberjs/ember.js/pull/14753) [BUGFIX] Fix `<input type=XXX>` feature detect issue affecting Safari.
- [#15176](https://github.com/emberjs/ember.js/pull/15176) [BUGFIX] Ensure `Controller.prototype.replaceRoute` considers engine's mount point.
- [#15513](https://github.com/emberjs/ember.js/pull/15513) [BUGFIX] Release root components after they are destroyed.
-
-### 2.15.0-beta.2 (July 20, 2017)
-
- [#15511](https://github.com/emberjs/ember.js/pull/15511) [BUGFIX] Fixes `onFulfillment` being `undefined` when stepping through RSVP code.
- [#15510](https://github.com/emberjs/ember.js/pull/15510) [BUGFIX] Make sure notification changes are properly triggered for firstObject/lastObject.
- [#15502](https://github.com/emberjs/ember.js/pull/15502) [BUGFIX] Work around a browser bug that causes `getOwner` to sometimes return `undefined`.
-
-### 2.15.0-beta.1 (July 5, 2017)
-
- [#14338](https://github.com/emberjs/ember.js/pull/14338) [FEATURE] Remove explicit names from initializers.
- [#15325](https://github.com/emberjs/ember.js/pull/15325) / [#15326](https://github.com/emberjs/ember.js/pull/15326) [FEATURE ember-engines-mount-params] Allow `{{mount` to accept a `model` named parameter.
- [#15347](https://github.com/emberjs/ember.js/pull/15347) [BUGFIX] Make better errors for meta updates after object destruction. | false |
Other | emberjs | ember.js | 979190c8f6b0023f4672508d0be3d8d53b585019.json | Update CHANGELOG for v2.15.0-beta.3.
[ci skip] | CHANGELOG.md | @@ -1,5 +1,14 @@
# Ember Changelog
+### 2.15.0-beta.3 (August 8, 2017)
+
+- [#14848](https://github.com/emberjs/ember.js/pull/14848) [BUGFIX] Allow boolean values for current-when
+- [#15572](https://github.com/emberjs/ember.js/pull/15572) [BUGFIX] Fix issue with using negative numbers as an argument passed in from the template.
+- [#15535](https://github.com/emberjs/ember.js/pull/15535) [BUGFIX] Ensure that properties of functions are able to be rendered.
+- [#14753](https://github.com/emberjs/ember.js/pull/14753) [BUGFIX] Fix `<input type=XXX>` feature detect issue affecting Safari.
+- [#15176](https://github.com/emberjs/ember.js/pull/15176) [BUGFIX] Ensure `Controller.prototype.replaceRoute` considers engine's mount point.
+- [#15513](https://github.com/emberjs/ember.js/pull/15513) [BUGFIX] Release root components after they are destroyed.
+
### 2.15.0-beta.2 (July 20, 2017)
- [#15511](https://github.com/emberjs/ember.js/pull/15511) [BUGFIX] Fixes `onFulfillment` being `undefined` when stepping through RSVP code. | false |
Other | emberjs | ember.js | 19ae330fd582ca3a9b97b70d16aceceb40f94261.json | Bring query params fix up to date. | packages/ember-routing/lib/system/route.js | @@ -848,7 +848,10 @@ let Route = EmberObject.extend(ActionHandler, Evented, {
} else {
if (presentKey) {
svalue = params[presentKey];
- value = route.deserializeQueryParam(svalue, qp.urlKey, qp.type);
+
+ if (svalue !== undefined) {
+ value = route.deserializeQueryParam(svalue, qp.urlKey, qp.type);
+ }
} else {
// No QP provided; use default value.
svalue = qp.serializedDefaultValue;
@@ -2127,7 +2130,7 @@ let Route = EmberObject.extend(ActionHandler, Evented, {
}
});
```
-
+
@method disconnectOutlet
@param {Object|String} options the options hash or outlet name
@since 1.0.0 | true |
Other | emberjs | ember.js | 19ae330fd582ca3a9b97b70d16aceceb40f94261.json | Bring query params fix up to date. | packages/ember-routing/lib/system/router.js | @@ -702,7 +702,7 @@ const EmberRouter = EmberObject.extend(Evented, {
*/
_serializeQueryParam(value, type) {
if (value === null || value === undefined) {
- return null;
+ return value;
} else if (type === 'array') {
return JSON.stringify(value);
}
@@ -739,7 +739,9 @@ const EmberRouter = EmberObject.extend(Evented, {
@param {String} defaultType
*/
_deserializeQueryParam(value, defaultType) {
- if (defaultType === 'boolean') {
+ if (value === null || value === undefined) {
+ return value;
+ } else if (defaultType === 'boolean') {
return value === 'true';
} else if (defaultType === 'number') {
return (Number(value)).valueOf(); | true |
Other | emberjs | ember.js | 19ae330fd582ca3a9b97b70d16aceceb40f94261.json | Bring query params fix up to date. | packages/ember/tests/routing/query_params_test.js | @@ -1153,62 +1153,59 @@ moduleFor('Query Params - main', class extends QueryParamTestCase {
});
}
- test("Setting bound query pram property to null or undefined do not seralize to url", function() {
- Router.map(function() {
- this.route("home", { path: '/home' });
- });
+ ['@test Setting bound query param property to null or undefined does not serialize to url'](assert) {
+ assert.expect(9);
- App.HomeController = Ember.Controller.extend({
- queryParams: ['foo'],
- foo: [1, 2]
+ this.router.map(function() {
+ this.route('home');
});
- startingURL = '/home';
- bootApplication();
+ this.setSingleQPController('home', 'foo', [1, 2]);
- var controller = container.lookup('controller:home');
+ return this.visitAndAssert('/home').then(() => {
+ var controller = this.getController('home');
- deepEqual(controller.get('foo'), [1,2]);
- equal(router.get('location.path'), "/home");
+ assert.deepEqual(controller.get('foo'), [1,2]);
+ this.assertCurrentPath('/home');
- Ember.run(controller, 'set', 'foo', [1,3]);
- equal(router.get('location.path'), "/home?foo=%5B1%2C3%5D");
+ this.setAndFlush(controller, 'foo', emberA([1,3]));
+ this.assertCurrentPath('/home?foo=%5B1%2C3%5D');
- Ember.run(router, 'transitionTo', '/home');
- deepEqual(controller.get('foo'), [1,2]);
+ return this.transitionTo('/home').then(() => {
+ assert.deepEqual(controller.get('foo'), [1,2]);
+ this.assertCurrentPath('/home');
- Ember.run(controller, 'set', 'foo', null);
- equal(router.get('location.path'), "/home", "Setting property to null");
+ this.setAndFlush(controller, 'foo', null);
+ this.assertCurrentPath('/home', 'Setting property to null');
- Ember.run(controller, 'set', 'foo', [1,3]);
- equal(router.get('location.path'), "/home?foo=%5B1%2C3%5D");
+ this.setAndFlush(controller, 'foo', emberA([1,3]));
+ this.assertCurrentPath('/home?foo=%5B1%2C3%5D');
- Ember.run(controller, 'set', 'foo', undefined);
- equal(router.get('location.path'), "/home", "Setting property to undefined");
- });
+ this.setAndFlush(controller, 'foo', undefined);
+ this.assertCurrentPath('/home', 'Setting property to undefined');
+ });
+ });
+ }
- test("{{link-to}} with null or undefined qps do not get serialized into url", function() {
- Ember.TEMPLATES.home = Ember.Handlebars.compile(
- "{{link-to 'Home' 'home' (query-params foo=nullValue) id='null-link'}}" +
- "{{link-to 'Home' 'home' (query-params foo=undefinedValue) id='undefined-link'}}");
- Router.map(function() {
- this.route("home", { path: '/home' });
+ ['@test {{link-to}} with null or undefined QPs does not get serialized into url'](assert) {
+ assert.expect(3);
+
+ this.addTemplate('home', '{{link-to \'Home\' \'home\' (query-params foo=nullValue) id=\'null-link\'}}{{link-to \'Home\' \'home\' (query-params foo=undefinedValue) id=\'undefined-link\'}}');
+
+ this.router.map(function() {
+ this.route('home');
});
- App.HomeController = Ember.Controller.extend({
- queryParams: ['foo'],
- foo: [],
+ this.setSingleQPController('home', 'foo', [], {
nullValue: null,
undefinedValue: undefined
});
- startingURL = '/home';
- bootApplication();
-
- var controller = container.lookup('controller:home');
- equal(Ember.$('#null-link').attr('href'), "/home");
- equal(Ember.$('#undefined-link').attr('href'), "/home");
- });
+ return this.visitAndAssert('/home').then(() => {
+ assert.equal(this.$('#null-link').attr('href'), '/home');
+ assert.equal(this.$('#undefined-link').attr('href'), '/home');
+ });
+ }
['@test A child of a resource route still defaults to parent route\'s model even if the child route has a query param'](assert) {
assert.expect(2); | true |
Other | emberjs | ember.js | bc633b24cd8d699a288b36615253a78e79ce6a1d.json | add inflection to dependencies | package.json | @@ -54,6 +54,7 @@
"ember-cli-valid-component-name": "^1.0.0",
"ember-cli-version-checker": "^1.3.1",
"ember-router-generator": "^1.2.3",
+ "inflection": "^1.12.0",
"jquery": "^3.2.1",
"resolve": "^1.3.3",
"rsvp": "^3.6.1", | false |
Other | emberjs | ember.js | 846227b17eeca2b4500508f92fd1c831ffcf7ba7.json | remove unused imports | packages/ember-glimmer/lib/component-managers/outlet.js | @@ -4,8 +4,7 @@
*/
import { generateGuid, guidFor } from 'ember-utils';
import {
- ComponentDefinition,
- CompiledArgs
+ ComponentDefinition
} from '@glimmer/runtime';
import { DEBUG } from 'ember-env-flags';
import { _instrumentStart } from 'ember-metal'; | true |
Other | emberjs | ember.js | 846227b17eeca2b4500508f92fd1c831ffcf7ba7.json | remove unused imports | packages/ember-glimmer/lib/component-managers/root.js | @@ -2,7 +2,6 @@ import {
ComponentDefinition
} from '@glimmer/runtime';
import {
- get,
_instrumentStart
} from 'ember-metal';
import {
@@ -12,8 +11,6 @@ import { DEBUG } from 'ember-env-flags';
import ComponentStateBucket from '../utils/curly-component-state-bucket';
import CurlyComponentManager, {
initialRenderInstrumentDetails,
- rerenderInstrumentDetails,
- validatePositionalParameters,
processComponentInitializationAssertions
} from './curly';
| true |
Other | emberjs | ember.js | dac942a86eedc8f71727ae1bed7abfaac9aee935.json | Remove outdated {{with}} documentation
`{{with}}` no longer changes the scope of `this` so this note no longer applies | packages/ember-glimmer/lib/index.js | @@ -95,9 +95,7 @@
{{/each}}
{{/with}}
```
-
- Without the `as` operator, it would be impossible to reference `user.name` in the example above.
-
+
NOTE: The alias should not reuse a name from the bound property path.
For example: `{{#with foo.bar as |foo|}}` is not supported because it attempts to alias using | false |
Other | emberjs | ember.js | 282185535b7bde56437d6d3a78d89a201dac0e53.json | Fix casing of JavaScript in README | README.md | @@ -12,10 +12,10 @@
<a href="https://saucelabs.com/u/ember-ci"><img src="https://saucelabs.com/browser-matrix/ember-ci.svg" alt="Sauce Test Status"></a>
</p>
-Ember.js is a Javascript framework that greatly reduces the time, effort and resources needed
+Ember.js is a JavaScript framework that greatly reduces the time, effort and resources needed
to build any web application. It is focused on making you, the developer, as productive as possible by doing all the common, repetitive, yet essential, tasks involved in most web development projects.
-Ember.js also provides access to the most advanced features of Javascript, HTML and the Browser giving you everything you need to create your next killer web app.
+Ember.js also provides access to the most advanced features of JavaScript, HTML and the Browser giving you everything you need to create your next killer web app.
- [Website](https://emberjs.com)
- [Guides](https://guides.emberjs.com) | false |
Other | emberjs | ember.js | 5a7356fe741455e171093369838fa18745fc5fd2.json | remove unused deps | package.json | @@ -43,7 +43,6 @@
"@glimmer/node": "^0.25.3",
"@glimmer/reference": "^0.25.3",
"@glimmer/runtime": "^0.25.3",
- "@glimmer/util": "^0.25.3",
"broccoli-funnel": "^1.2.0",
"broccoli-merge-trees": "^2.0.0",
"ember-cli-get-component-path-option": "^1.0.0",
@@ -55,7 +54,6 @@
"ember-cli-valid-component-name": "^1.0.0",
"ember-cli-version-checker": "^1.3.1",
"ember-router-generator": "^1.2.3",
- "handlebars": "^4.0.6",
"jquery": "^3.2.1",
"resolve": "^1.3.3",
"rsvp": "^3.6.1", | false |
Other | emberjs | ember.js | 56dcb2f360709fe9fdd52aac6e1de29b72079468.json | Update @glimmer packages to 0.25.3. | package.json | @@ -39,11 +39,11 @@
"link:glimmer": "node bin/yarn-link-glimmer.js"
},
"dependencies": {
- "@glimmer/compiler": "^0.25.1",
- "@glimmer/node": "^0.25.1",
- "@glimmer/reference": "^0.25.1",
- "@glimmer/runtime": "^0.25.1",
- "@glimmer/util": "^0.25.1",
+ "@glimmer/compiler": "^0.25.3",
+ "@glimmer/node": "^0.25.3",
+ "@glimmer/reference": "^0.25.3",
+ "@glimmer/runtime": "^0.25.3",
+ "@glimmer/util": "^0.25.3",
"broccoli-funnel": "^1.2.0",
"broccoli-merge-trees": "^2.0.0",
"ember-cli-get-component-path-option": "^1.0.0", | true |
Other | emberjs | ember.js | 56dcb2f360709fe9fdd52aac6e1de29b72079468.json | Update @glimmer packages to 0.25.3. | yarn.lock | @@ -2,78 +2,78 @@
# yarn lockfile v1
-"@glimmer/compiler@^0.25.1":
- version "0.25.1"
- resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.25.1.tgz#81fb9f51349f819525da737ae953a5f8461fdef1"
- dependencies:
- "@glimmer/interfaces" "^0.25.1"
- "@glimmer/syntax" "^0.25.1"
- "@glimmer/util" "^0.25.1"
- "@glimmer/wire-format" "^0.25.1"
+"@glimmer/compiler@^0.25.3":
+ version "0.25.3"
+ resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.25.3.tgz#25eb06394f3ba1c1fae5af25c9cf7deb2c11ef4e"
+ dependencies:
+ "@glimmer/interfaces" "^0.25.3"
+ "@glimmer/syntax" "^0.25.3"
+ "@glimmer/util" "^0.25.3"
+ "@glimmer/wire-format" "^0.25.3"
simple-html-tokenizer "^0.3.0"
-"@glimmer/interfaces@^0.25.1":
- version "0.25.1"
- resolved "https://registry.yarnpkg.com/@glimmer/interfaces/-/interfaces-0.25.1.tgz#234abbbf7021a73ec576943443768d0e2801ad13"
+"@glimmer/interfaces@^0.25.3":
+ version "0.25.3"
+ resolved "https://registry.yarnpkg.com/@glimmer/interfaces/-/interfaces-0.25.3.tgz#8c460b28ad5a17eaa1712e6aa7b8ebb49738c38f"
dependencies:
- "@glimmer/wire-format" "^0.25.1"
+ "@glimmer/wire-format" "^0.25.3"
-"@glimmer/node@^0.25.1":
- version "0.25.1"
- resolved "https://registry.yarnpkg.com/@glimmer/node/-/node-0.25.1.tgz#0f5301d7a100cbb37e8252f8e5f28ce4afa470db"
+"@glimmer/node@^0.25.3":
+ version "0.25.3"
+ resolved "https://registry.yarnpkg.com/@glimmer/node/-/node-0.25.3.tgz#301828e8455be141d5384b01980ed9be02984059"
dependencies:
- "@glimmer/runtime" "^0.25.1"
+ "@glimmer/runtime" "^0.25.3"
simple-dom "^0.3.0"
-"@glimmer/object-reference@^0.25.1":
- version "0.25.1"
- resolved "https://registry.yarnpkg.com/@glimmer/object-reference/-/object-reference-0.25.1.tgz#6393deb8d24c6ead90437998eb988207d674142e"
+"@glimmer/object-reference@^0.25.3":
+ version "0.25.3"
+ resolved "https://registry.yarnpkg.com/@glimmer/object-reference/-/object-reference-0.25.3.tgz#e0d1fa874f912e7d1232d487fcd2096e6b31b620"
dependencies:
- "@glimmer/reference" "^0.25.1"
- "@glimmer/util" "^0.25.1"
+ "@glimmer/reference" "^0.25.3"
+ "@glimmer/util" "^0.25.3"
-"@glimmer/object@^0.25.1":
- version "0.25.1"
- resolved "https://registry.yarnpkg.com/@glimmer/object/-/object-0.25.1.tgz#2611f9deb88d4d33c24d1e8dc57d4ae5c224fc24"
+"@glimmer/object@^0.25.3":
+ version "0.25.3"
+ resolved "https://registry.yarnpkg.com/@glimmer/object/-/object-0.25.3.tgz#451eb208dadba1ede9c0c038a90dfe32637493fe"
dependencies:
- "@glimmer/object-reference" "^0.25.1"
- "@glimmer/util" "^0.25.1"
+ "@glimmer/object-reference" "^0.25.3"
+ "@glimmer/util" "^0.25.3"
-"@glimmer/reference@^0.25.1":
- version "0.25.1"
- resolved "https://registry.yarnpkg.com/@glimmer/reference/-/reference-0.25.1.tgz#5c5a148a7e1f33c3ed425999b8b45d0f7a88aeac"
+"@glimmer/reference@^0.25.3":
+ version "0.25.3"
+ resolved "https://registry.yarnpkg.com/@glimmer/reference/-/reference-0.25.3.tgz#a09ddc397bee0223de73ea5044a304a30935104f"
dependencies:
- "@glimmer/util" "^0.25.1"
+ "@glimmer/util" "^0.25.3"
-"@glimmer/runtime@^0.25.1":
- version "0.25.1"
- resolved "https://registry.yarnpkg.com/@glimmer/runtime/-/runtime-0.25.1.tgz#ead91cc51a44ff9777fee0a786d32aeb8b8e993a"
+"@glimmer/runtime@^0.25.3":
+ version "0.25.3"
+ resolved "https://registry.yarnpkg.com/@glimmer/runtime/-/runtime-0.25.3.tgz#ae2101a1e4de3330d08f20806c18327dbfa86d78"
dependencies:
- "@glimmer/interfaces" "^0.25.1"
- "@glimmer/object" "^0.25.1"
- "@glimmer/object-reference" "^0.25.1"
- "@glimmer/reference" "^0.25.1"
- "@glimmer/util" "^0.25.1"
- "@glimmer/wire-format" "^0.25.1"
+ "@glimmer/interfaces" "^0.25.3"
+ "@glimmer/object" "^0.25.3"
+ "@glimmer/object-reference" "^0.25.3"
+ "@glimmer/reference" "^0.25.3"
+ "@glimmer/util" "^0.25.3"
+ "@glimmer/wire-format" "^0.25.3"
-"@glimmer/syntax@^0.25.1":
- version "0.25.1"
- resolved "https://registry.yarnpkg.com/@glimmer/syntax/-/syntax-0.25.1.tgz#05bbc219af98adc447195d4d74bba6fb9f5fd3d5"
+"@glimmer/syntax@^0.25.3":
+ version "0.25.3"
+ resolved "https://registry.yarnpkg.com/@glimmer/syntax/-/syntax-0.25.3.tgz#b3f8a59bee616fd600301d778de3b649bf77036e"
dependencies:
- "@glimmer/interfaces" "^0.25.1"
- "@glimmer/util" "^0.25.1"
+ "@glimmer/interfaces" "^0.25.3"
+ "@glimmer/util" "^0.25.3"
handlebars "^4.0.6"
simple-html-tokenizer "^0.3.0"
-"@glimmer/util@^0.25.1":
- version "0.25.2"
- resolved "https://registry.yarnpkg.com/@glimmer/util/-/util-0.25.2.tgz#a79e7100f7c38181be026dddf2d3b4ce8a8c8421"
+"@glimmer/util@^0.25.3":
+ version "0.25.3"
+ resolved "https://registry.yarnpkg.com/@glimmer/util/-/util-0.25.3.tgz#7cedf72947137b519658c8be34d0d5965cebe3a1"
-"@glimmer/wire-format@^0.25.1":
- version "0.25.1"
- resolved "https://registry.yarnpkg.com/@glimmer/wire-format/-/wire-format-0.25.1.tgz#cd69f3595a08954fa68a3f1df4feafffa1c3f3de"
+"@glimmer/wire-format@^0.25.3":
+ version "0.25.3"
+ resolved "https://registry.yarnpkg.com/@glimmer/wire-format/-/wire-format-0.25.3.tgz#046692b3a26a30a498712266cd0bdb47d7710f37"
dependencies:
- "@glimmer/util" "^0.25.1"
+ "@glimmer/util" "^0.25.3"
abbrev@1:
version "1.1.0" | true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/chains.js | @@ -113,13 +113,11 @@ function addChainWatcher(obj, keyName, node) {
}
function removeChainWatcher(obj, keyName, node, _meta) {
- if (!isObject(obj)) {
- return;
- }
+ if (!isObject(obj)) { return; }
- let meta = _meta || peekMeta(obj);
+ let meta = _meta === undefined ? peekMeta(obj) : _meta;
- if (!meta || !meta.readableChainWatchers()) {
+ if (meta === undefined || meta.readableChainWatchers() === undefined) {
return;
}
| true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/computed.js | @@ -299,7 +299,7 @@ ComputedPropertyPrototype.didChange = function(obj, keyName) {
// don't create objects just to invalidate
let meta = peekMeta(obj);
- if (!meta || meta.source !== obj) {
+ if (meta === undefined || meta.source !== obj) {
return;
}
| true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/events.js | @@ -210,7 +210,7 @@ export function sendEvent(obj, eventName, params, actions, _meta) {
*/
export function hasListeners(obj, eventName) {
let meta = peekMeta(obj);
- if (!meta) { return false; }
+ if (meta === undefined) { return false; }
let matched = meta.matchingListeners(eventName);
return matched !== undefined && matched.length > 0;
} | true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/is_proxy.js | @@ -3,7 +3,7 @@ import { peekMeta } from './meta';
export function isProxy(value) {
if (typeof value === 'object' && value !== null) {
let meta = peekMeta(value);
- return meta && meta.isProxy();
+ return meta === undefined ? false : meta.isProxy();
}
return false; | true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/mixin.js | @@ -516,7 +516,7 @@ export default class Mixin {
static mixins(obj) {
let meta = peekMeta(obj);
let ret = [];
- if (!meta) { return ret; }
+ if (meta === undefined) { return ret; }
meta.forEachMixins((key, currentMixin) => {
// skip primitive mixins since these are always anonymous
@@ -621,7 +621,7 @@ MixinPrototype.detect = function(obj) {
if (typeof obj !== 'object' || obj === null) { return false; }
if (obj instanceof Mixin) { return _detect(obj, this, {}); }
let meta = peekMeta(obj);
- if (!meta) { return false; }
+ if (meta === undefined) { return false; }
return !!meta.peekMixins(guidFor(this));
};
| true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/properties.js | @@ -58,7 +58,7 @@ export function MANDATORY_SETTER_FUNCTION(name) {
export function DEFAULT_GETTER_FUNCTION(name) {
return function GETTER_FUNCTION() {
let meta = peekMeta(this);
- if (meta !== null && meta !== undefined) {
+ if (meta !== undefined) {
return meta.peekValues(name);
}
};
@@ -68,7 +68,7 @@ export function INHERITING_GETTER_FUNCTION(name) {
function IGETTER_FUNCTION() {
let meta = peekMeta(this);
let val;
- if (meta !== null && meta !== undefined) {
+ if (meta !== undefined) {
val = meta.readInheritedValue('values', name);
}
@@ -130,9 +130,7 @@ export function INHERITING_GETTER_FUNCTION(name) {
become the explicit value of this property.
*/
export function defineProperty(obj, keyName, desc, data, meta) {
- if (meta === null || meta === undefined) {
- meta = metaFor(obj);
- }
+ if (meta === undefined) { meta = metaFor(obj); }
let watchEntry = meta.peekWatching(keyName);
let watching = watchEntry !== undefined && watchEntry > 0; | true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/watch_key.js | @@ -87,7 +87,7 @@ export function unwatchKey(obj, keyName, _meta) {
let meta = _meta || peekMeta(obj);
// do nothing of this object has already been destroyed
- if (!meta || meta.isSourceDestroyed()) { return; }
+ if (meta === undefined || meta.isSourceDestroyed()) { return; }
let count = meta.peekWatching(keyName);
if (count === 1) { | true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-runtime/lib/mixins/array.js | @@ -139,7 +139,7 @@ export function arrayContentDidChange(array, startIdx, removeAmt, addAmt) {
sendEvent(array, '@array:change', [array, startIdx, removeAmt, addAmt]);
let meta = peekMeta(array);
- let cache = meta && meta.readableCache();
+ let cache = meta !== undefined ? meta.readableCache() : undefined;
if (cache !== undefined) {
let length = get(array, 'length');
let addedAmount = (addAmt === -1 ? 0 : addAmt); | true |
Other | emberjs | ember.js | dc60f97e9dab2479ff78d696ca6a0b4acf486d01.json | remove unused imports | packages/ember-routing/lib/services/router.js | @@ -7,9 +7,7 @@ import {
Service,
readOnly
} from 'ember-runtime';
-import { assign } from 'ember-utils';
import { shallowEqual } from '../utils';
-import RouterDSL from '../system/dsl';
/**
The Router service is the public API that provides component/view layer | false |
Other | emberjs | ember.js | e2f4d058a4e766b49c5917c3f32f951e842c3557.json | avoid boolean coarsion in `computed` | packages/ember-metal/lib/computed.js | @@ -142,7 +142,7 @@ function ComputedProperty(config, opts) {
this._meta = undefined;
this._volatile = false;
this._dependentKeys = opts && opts.dependentKeys;
- this._readOnly = false;
+ this._readOnly = false;
}
ComputedProperty.prototype = new Descriptor();
@@ -304,7 +304,7 @@ ComputedPropertyPrototype.didChange = function(obj, keyName) {
}
let cache = meta.readableCache();
- if (cache && cache[keyName] !== undefined) {
+ if (cache !== undefined && cache[keyName] !== undefined) {
cache[keyName] = undefined;
removeDependentKeys(this, obj, keyName, meta);
}
@@ -326,14 +326,10 @@ ComputedPropertyPrototype.get = function(obj, keyName) {
}
let ret = this._getter.call(obj, keyName);
- if (ret === undefined) {
- cache[keyName] = UNDEFINED;
- } else {
- cache[keyName] = ret;
- }
+ cache[keyName] = ret === undefined ? UNDEFINED : ret;
let chainWatchers = meta.readableChainWatchers();
- if (chainWatchers) {
+ if (chainWatchers !== undefined) {
chainWatchers.revalidate(keyName);
}
addDependentKeys(this, obj, keyName, meta);
@@ -383,15 +379,14 @@ ComputedPropertyPrototype.setWithSuspend = function computedPropertySetWithSuspe
};
ComputedPropertyPrototype._set = function computedPropertySet(obj, keyName, value) {
- // cache requires own meta
- let meta = metaFor(obj);
- // either there is a writable cache or we need one to update
- let cache = meta.writableCache();
+ let meta = metaFor(obj);
+ let cache = meta.writableCache();
let hadCachedValue = false;
let cachedValue;
- if (cache[keyName] !== undefined) {
- if (cache[keyName] !== UNDEFINED) {
- cachedValue = cache[keyName];
+ let val = cache[keyName];
+ if (val !== undefined) {
+ if (val !== UNDEFINED) {
+ cachedValue = val;
}
hadCachedValue = true;
} | false |
Other | emberjs | ember.js | 2b0918303ce33256b5ae8505193b6e490c161251.json | avoid boolean coarsion in weak_map | packages/ember-metal/lib/weak_map.js | @@ -57,12 +57,12 @@ WeakMap.prototype.get = function(obj) {
let meta = peekMeta(obj);
if (meta) {
let map = meta.readableWeak();
- if (map) {
- if (map[this._id] === UNDEFINED) {
+ if (map !== undefined) {
+ let val = map[this._id];
+ if (val === UNDEFINED) {
return undefined;
}
-
- return map[this._id];
+ return val;
}
}
};
@@ -100,7 +100,7 @@ WeakMap.prototype.has = function(obj) {
let meta = peekMeta(obj);
if (meta) {
let map = meta.readableWeak();
- if (map) {
+ if (map !== undefined) {
return map[this._id] !== undefined;
}
} | false |
Other | emberjs | ember.js | 49f01699a9c209c3134ac85895cba4456a58b935.json | reuse meta `arrayContentDidChange` | packages/ember-runtime/lib/mixins/array.js | @@ -149,16 +149,16 @@ export function arrayContentDidChange(array, startIdx, removeAmt, addAmt) {
let normalStartIdx = startIdx < 0 ? previousLength + startIdx : startIdx;
if (cache.firstObject !== undefined && normalStartIdx === 0) {
- propertyWillChange(array, 'firstObject');
- propertyDidChange(array, 'firstObject');
+ propertyWillChange(array, 'firstObject', meta);
+ propertyDidChange(array, 'firstObject', meta);
}
if (cache.lastObject !== undefined) {
let previousLastIndex = previousLength - 1;
let lastAffectedIndex = normalStartIdx + removedAmount;
if (previousLastIndex < lastAffectedIndex) {
- propertyWillChange(array, 'lastObject');
- propertyDidChange(array, 'lastObject');
+ propertyWillChange(array, 'lastObject', meta);
+ propertyDidChange(array, 'lastObject', meta);
}
}
} | false |
Other | emberjs | ember.js | ba3d6f467cf8c7e3752b613fcdd850412e275ece.json | avoid boolean coarsion | packages/ember-metal/lib/weak_map.js | @@ -52,12 +52,12 @@ export class WeakMapPolyfill {
let meta = peekMeta(obj);
if (meta) {
let map = meta.readableWeak();
- if (map) {
- if (map[this._id] === UNDEFINED) {
+ if (map !== undefined) {
+ let val = map[this._id];
+ if (val === UNDEFINED) {
return undefined;
}
-
- return map[this._id];
+ return val;
}
}
}
@@ -93,7 +93,7 @@ export class WeakMapPolyfill {
let meta = peekMeta(obj);
if (meta) {
let map = meta.readableWeak();
- if (map) {
+ if (map !== undefined) {
return map[this._id] !== undefined;
}
} | false |
Other | emberjs | ember.js | cd150fa456a160e534a474683c844524b1d3dfb6.json | remove extra type check | packages/ember-metal/lib/watching.js | @@ -1,7 +1,6 @@
/**
@module ember-metal
*/
-
import {
watchKey,
unwatchKey
@@ -40,11 +39,7 @@ export function watch(obj, _keyPath, m) {
}
export function isWatching(obj, key) {
- if (typeof obj !== 'object' || obj === null) {
- return false;
- }
- let meta = peekMeta(obj);
- return (meta && meta.peekWatching(key)) > 0;
+ return watcherCount(obj, key) > 0;
}
export function watcherCount(obj, key) { | true |
Other | emberjs | ember.js | cd150fa456a160e534a474683c844524b1d3dfb6.json | remove extra type check | packages/ember-runtime/lib/computed/computed_macros.js | @@ -251,8 +251,7 @@ export function bool(dependentKey) {
export function match(dependentKey, regexp) {
return computed(dependentKey, function() {
let value = get(this, dependentKey);
-
- return typeof value === 'string' ? regexp.test(value) : false;
+ return regexp.test(value);
});
}
| true |
Other | emberjs | ember.js | 14243438756b908b4557f9f3e296d3af89bcda81.json | remove unnecessary check | packages/ember-metal/lib/property_set.js | @@ -95,9 +95,9 @@ function setPath(root, path, value, tolerant) {
let parts = path.split('.');
let keyName = parts.pop();
- assert('Property set failed: You passed an empty path', keyName && keyName.length > 0)
+ assert('Property set failed: You passed an empty path', keyName.trim().length > 0)
- let newPath = parts.length > 0 ? parts.join('.') : keyName;
+ let newPath = parts.join('.');
let newRoot = getPath(root, newPath);
| true |
Other | emberjs | ember.js | 14243438756b908b4557f9f3e296d3af89bcda81.json | remove unnecessary check | packages/ember-metal/lib/weak_map.js | @@ -115,7 +115,7 @@ WeakMap.prototype.has = function(obj) {
*/
WeakMap.prototype.delete = function(obj) {
if (this.has(obj)) {
- delete metaFor(obj).writableWeak()[this._id];
+ delete peekMeta(obj).writableWeak()[this._id];
return true;
} else {
return false; | true |
Other | emberjs | ember.js | bd60d853d76252e379dc4876b24475cb3c5d3a10.json | Release reference to root components after destroy | packages/ember-glimmer/lib/renderer.js | @@ -241,6 +241,7 @@ class Renderer {
let root = roots[i];
if (root.isFor(view)) {
root.destroy();
+ roots.splice(i, 1);
}
}
} | true |
Other | emberjs | ember.js | bd60d853d76252e379dc4876b24475cb3c5d3a10.json | Release reference to root components after destroy | packages/ember-glimmer/tests/integration/components/append-test.js | @@ -323,6 +323,23 @@ class AbstractAppendTest extends RenderingTest {
this.assert.equal(willDestroyCalled, 1);
}
+ ['@test releasing a root component after it has been destroy'](assert) {
+ let renderer = this.owner.lookup('renderer:-dom');
+
+ this.registerComponent('x-component', {
+ ComponentClass: Component.extend()
+ });
+
+ this.component = this.owner.factoryFor('component:x-component').create();
+ this.append(this.component);
+
+ assert.equal(renderer._roots.length, 1, 'added a root component');
+
+ this.runTask(() => this.component.destroy());
+
+ assert.equal(renderer._roots.length, 0, 'released the root component');
+ }
+
['@test appending, updating and destroying multiple components'](assert) {
let willDestroyCalled = 0;
| true |
Other | emberjs | ember.js | 6721c736edb2395497d61f3c53eab69868706f42.json | remove unnecessary binding | packages/ember-metal/lib/observer_set.js | @@ -29,12 +29,12 @@ export default class ObserverSet {
let observers = this.observers;
let senderGuid = guidFor(sender);
let keySet = observerSet[senderGuid];
- let index;
- if (!keySet) {
+ if (keySet === undefined) {
observerSet[senderGuid] = keySet = {};
}
- index = keySet[keyName];
+
+ let index = keySet[keyName];
if (index === undefined) {
index = observers.push({
sender,
@@ -49,9 +49,9 @@ export default class ObserverSet {
flush() {
let observers = this.observers;
- let i, observer, sender;
+ let observer, sender;
this.clear();
- for (i = 0; i < observers.length; ++i) {
+ for (let i = 0; i < observers.length; ++i) {
observer = observers[i];
sender = observer.sender;
if (sender.isDestroying || sender.isDestroyed) { continue; } | true |
Other | emberjs | ember.js | 6721c736edb2395497d61f3c53eab69868706f42.json | remove unnecessary binding | packages/ember-metal/lib/property_events.js | @@ -15,7 +15,7 @@ import {
} from 'ember/features';
import { assertNotRendered } from './transaction';
-export let PROPERTY_DID_CHANGE = symbol('PROPERTY_DID_CHANGE');
+export const PROPERTY_DID_CHANGE = symbol('PROPERTY_DID_CHANGE');
const beforeObserverSet = new ObserverSet();
const observerSet = new ObserverSet();
@@ -97,10 +97,7 @@ function propertyDidChange(obj, keyName, _meta) {
}
if (hasMeta && meta.peekWatching(keyName) > 0) {
- if (meta.hasDeps(keyName) && !meta.isSourceDestroying()) {
- dependentKeysDidChange(obj, keyName, meta);
- }
-
+ dependentKeysDidChange(obj, keyName, meta);
chainsDidChange(obj, keyName, meta);
notifyObservers(obj, keyName, meta);
}
@@ -122,25 +119,24 @@ function propertyDidChange(obj, keyName, _meta) {
let WILL_SEEN, DID_SEEN;
// called whenever a property is about to change to clear the cache of any dependent keys (and notify those properties of changes, etc...)
function dependentKeysWillChange(obj, depKey, meta) {
- if (meta.isSourceDestroying()) { return; }
- if (meta.hasDeps(depKey)) {
- let seen = WILL_SEEN;
- let top = !seen;
+ if (meta.isSourceDestroying() || !meta.hasDeps(depKey)) { return; }
+ let seen = WILL_SEEN;
+ let top = !seen;
- if (top) {
- seen = WILL_SEEN = {};
- }
+ if (top) {
+ seen = WILL_SEEN = {};
+ }
- iterDeps(propertyWillChange, obj, depKey, seen, meta);
+ iterDeps(propertyWillChange, obj, depKey, seen, meta);
- if (top) {
- WILL_SEEN = null;
- }
+ if (top) {
+ WILL_SEEN = null;
}
}
// called whenever a property has just changed to update dependent keys
function dependentKeysDidChange(obj, depKey, meta) {
+ if (meta.isSourceDestroying() || !meta.hasDeps(depKey)) { return; }
let seen = DID_SEEN;
let top = !seen;
@@ -247,7 +243,7 @@ function changeProperties(callback, binding) {
try {
callback.call(binding);
} finally {
- endPropertyChanges.call(binding);
+ endPropertyChanges();
}
}
@@ -293,10 +289,8 @@ function notifyBeforeObservers(obj, keyName, meta) {
if (deferred) {
listeners = beforeObserverSet.add(obj, keyName, eventName);
added = accumulateListeners(obj, eventName, listeners, meta);
- sendEvent(obj, eventName, [obj, keyName], added);
- } else {
- sendEvent(obj, eventName, [obj, keyName]);
}
+ sendEvent(obj, eventName, [obj, keyName], added);
}
function notifyObservers(obj, keyName, meta) { | true |
Other | emberjs | ember.js | aeff86a8314795197e5daa3168d41cd2aeaee2df.json | Remove meta check | packages/ember-metal/lib/property_events.js | @@ -266,7 +266,6 @@ function indexOf(array, target, method) {
}
function accumulateListeners(obj, eventName, otherActions, meta) {
- if (meta === null || meta === undefined) { return; }
let actions = meta.matchingListeners(eventName);
if (actions === undefined) { return; }
let newActions = []; | false |
Other | emberjs | ember.js | c6a52be3da2d035c149ef65ebc6ca92baab56fb9.json | correct function extensions | packages/ember-runtime/lib/ext/function.js | @@ -5,12 +5,12 @@
import { ENV } from 'ember-environment';
import {
+ on,
computed,
observer
} from 'ember-metal';
import { assert, deprecateFunc } from 'ember-debug';
-const a_slice = Array.prototype.slice;
const FunctionPrototype = Function.prototype;
if (ENV.EXTEND_PROTOTYPES.Function) {
@@ -74,10 +74,7 @@ if (ENV.EXTEND_PROTOTYPES.Function) {
@public
*/
FunctionPrototype.property = function () {
- let ret = computed(this);
- // ComputedProperty.prototype.property expands properties; no need for us to
- // do so here.
- return ret.property(...arguments);
+ return computed(...arguments, this);
};
/**
@@ -105,9 +102,8 @@ if (ENV.EXTEND_PROTOTYPES.Function) {
@for Function
@public
*/
- FunctionPrototype.observes = function(...args) {
- args.push(this);
- return observer.apply(this, args);
+ FunctionPrototype.observes = function() {
+ return observer(...arguments, this);
};
@@ -184,9 +180,6 @@ if (ENV.EXTEND_PROTOTYPES.Function) {
@public
*/
FunctionPrototype.on = function () {
- let events = a_slice.call(arguments);
- this.__ember_listens__ = events;
-
- return this;
+ return on(...arguments, this);
};
} | false |
Other | emberjs | ember.js | 6ccb09546ecc300148b737eaed653b0361c16311.json | Add 2.15.0-beta.1 to CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -1,5 +1,15 @@
# Ember Changelog
+### 2.15.0-beta.1 (July 5, 2017)
+
+- [#14338](https://github.com/emberjs/ember.js/pull/14338) [FEATURE] Remove explicit names from initializers.
+- [#15325](https://github.com/emberjs/ember.js/pull/15325) / [#15326](https://github.com/emberjs/ember.js/pull/15326) [FEATURE ember-engines-mount-params] Allow `{{mount` to accept a `model` named parameter.
+- [#15347](https://github.com/emberjs/ember.js/pull/15347) [BUGFIX] Make better errors for meta updates after object destruction.
+- [#15411](https://github.com/emberjs/ember.js/pull/15411) [CLEANUP] Remove deprecated `Ember.Backburner`.
+- [#15366](https://github.com/emberjs/ember.js/pull/15366) [BUGFIX] Allow numeric keys for the `get` helper.
+- [#14805](https://github.com/emberjs/ember.js/pull/14805) / [#14861](https://github.com/emberjs/ember.js/pull/14861) / [#14979](https://github.com/emberjs/ember.js/pull/14979) / [#15414](https://github.com/emberjs/ember.js/pull/15414) / [#15415](https://github.com/emberjs/ember.js/pull/15415) [FEATURE ember-routing-router-service] Enable by default.
+- [#15193](https://github.com/emberjs/ember.js/pull/15193) [CLEANUP] Remove `owner._lookupFactory` support.
+
### 2.14.0 (July 5, 2017)
- [#15312](https://github.com/emberjs/ember.js/pull/15312) [BUGFIX] Avoid re-freezing already frozen objects. | false |
Other | emberjs | ember.js | 2e45c053542f92ed363162b5d27f3da070310c62.json | Add 2.13.4 to CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -24,6 +24,10 @@
- [#15178](https://github.com/emberjs/ember.js/pull/15178) Refactor route to lookup controller for QPs.
- [#15129](https://github.com/emberjs/ember.js/pull/15129) Fix access to service:-document in ember-engines
+### 2.13.4 (July 5, 2017)
+
+- [#15321](https://github.com/emberjs/ember.js/pull/15321) [BUGFIX] Improve fastboot debugger/repl experience.
+
### 2.13.3 (May 31, 2017)
- [#15284](https://github.com/emberjs/ember.js/pull/15284) [BUGFIX] remove nested transaction assertion from glimmer. | false |
Other | emberjs | ember.js | f20ef314db6e26751014acf21a62e6fe6503490d.json | Update CHANGELOG to 2.14.0.
[ci skip] | CHANGELOG.md | @@ -1,22 +1,20 @@
# Ember Changelog
-### 2.14.0-beta.3 (May 30, 2017)
+### 2.14.0 (July 5, 2017)
+- [#15312](https://github.com/emberjs/ember.js/pull/15312) [BUGFIX] Avoid re-freezing already frozen objects.
+- [#15315](https://github.com/emberjs/ember.js/pull/15315) [FEATURE] Add minlength to TextSupport
+- [#15321](https://github.com/emberjs/ember.js/pull/15321) [BUGFIX] Improve fastboot debugger/repl experience
+- [#15366](https://github.com/emberjs/ember.js/pull/15366) [BUGFIX] Allow numeric keys for the `get` helper.
- [#15242](https://github.com/emberjs/ember.js/pull/15242) [BUGFIX] Fix EmberError import in system/router
- [#15204](https://github.com/emberjs/ember.js/pull/15204) [DEPRECATION] `Ember.MODEL_FACTORY_INJECTIONS` is now always false, and issues a deprecation if set.
- [#15239](https://github.com/emberjs/ember.js/pull/15239) [BUGFIX] Ensure `Ember.deprecate` is exported properly.
- [glimmerjs/glimmer-vm#529](https://github.com/glimmerjs/glimmer-vm/pull/529) [BUGFIX] Fix issues identified with custom element support.
- [#15277](https://github.com/emberjs/ember.js/pull/15277) [BUGFIX] Fix issues with retrying an initial transition.
-
-### 2.14.0-beta.2 (May 10, 2017)
-
- [#15138](https://github.com/emberjs/ember.js/pull/15138) [BUGFIX] Fix mocha blueprint service test filename
- [#15193](https://github.com/emberjs/ember.js/pull/15193) [BUGFIX] Ensure `factoryFor` does validation.
- [#15207](https://github.com/emberjs/ember.js/pull/15207) [BUGFIX] Ensure that an engines container is only destroyed once.
- [#15218](https://github.com/emberjs/ember.js/pull/15218) [BUGFIX] Update route-recognizer to v0.3.3.
-
-### 2.14.0-beta.1 (April 27, 2017)
-
- [#15015](https://github.com/emberjs/ember.js/pull/15015) Allow mounting routeless engines with a bound engine name
- [#15078](https://github.com/emberjs/ember.js/pull/15078) [DEPRECATION] Deprecate `EventManager#canDispatchToEventManager`.
- [#15085](https://github.com/emberjs/ember.js/pull/15085) Add missing instrumentation for compilation/lookup phase | false |
Other | emberjs | ember.js | 44eb0488467cf4ea7cd84f8f4ba5b6dbf47edd8b.json | Add deprecated annotation to API docs | packages/ember/lib/index.js | @@ -232,6 +232,7 @@ Object.defineProperty(Ember, 'onerror', {
@method K
@return {Object}
@public
+ @deprecated
*/
function deprecatedEmberK() { return this; }
| false |
Other | emberjs | ember.js | 4ce419565db027fa7fb8e0821fe74f353c3ea402.json | reuse empty func in `ember-debug` | packages/ember-debug/lib/index.js | @@ -6,30 +6,31 @@ import EmberError from './error';
import { default as isFeatureEnabled } from './features';
import * as FLAGS from 'ember/features';
let { DEFAULT_FEATURES, FEATURES } = FLAGS;
-
import _deprecate from './deprecate';
import _warn from './warn';
+
export { registerHandler as registerWarnHandler } from './warn';
export { registerHandler as registerDeprecationHandler } from './deprecate';
export { default as isFeatureEnabled } from './features';
export { default as Error } from './error';
export { isTesting, setTesting } from './testing';
// These are the default production build versions:
-let assert = () => {};
-let info = () => {};
-let warn = () => {};
-let debug = () => {};
-let deprecate = () => {};
-let debugSeal = () => {};
-let debugFreeze = () => {};
-let runInDebug = () => {};
+const noop = () => {};
+
+let assert = noop;
+let info = noop;
+let warn = noop;
+let debug = noop;
+let deprecate = noop;
+let debugSeal = noop;
+let debugFreeze = noop;
+let runInDebug = noop;
+let setDebugFunction = noop;
+let getDebugFunction = noop;
let deprecateFunc = function() { return arguments[arguments.length - 1]; };
-let setDebugFunction = () => {};
-let getDebugFunction = () => {};
-
if (DEBUG) {
setDebugFunction = function(type, callback) {
switch (type) { | false |
Other | emberjs | ember.js | 71de1162c7e20f04eb61339a1aee1fa7b3b02dc0.json | remove unused vars | packages/ember-metal/lib/mixin.js | @@ -37,19 +37,18 @@ import {
removeListener
} from './events';
-const a_slice = Array.prototype.slice;
const a_concat = Array.prototype.concat;
const { isArray } = Array;
function isMethod(obj) {
return 'function' === typeof obj &&
- obj.isMethod !== false &&
- obj !== Boolean &&
- obj !== Object &&
- obj !== Number &&
- obj !== Array &&
- obj !== Date &&
- obj !== String;
+ obj.isMethod !== false &&
+ obj !== Boolean &&
+ obj !== Object &&
+ obj !== Number &&
+ obj !== Array &&
+ obj !== Date &&
+ obj !== String;
}
const CONTINUE = {};
@@ -213,8 +212,8 @@ function addNormalizedProperty(base, key, value, meta, descs, values, concats, m
values[key] = undefined;
} else {
if ((concats && concats.indexOf(key) >= 0) ||
- key === 'concatenatedProperties' ||
- key === 'mergedProperties') {
+ key === 'concatenatedProperties' ||
+ key === 'mergedProperties') {
value = applyConcatenatedProperties(base, key, value, values);
} else if ((mergings && mergings.indexOf(key) >= 0)) {
value = applyMergedProperties(base, key, value, values);
@@ -736,7 +735,7 @@ export function aliasMethod(methodName) {
@public
*/
export function observer(...args) {
- let func = args.slice(-1)[0];
+ let func = args[args.length - 1];
let paths;
let addWatchedProperty = path => {
@@ -822,7 +821,7 @@ export function _immediateObserver() {
@private
*/
export function _beforeObserver(...args) {
- let func = args.slice(-1)[0];
+ let func = args[args.length - 1];
let paths;
let addWatchedProperty = path => { paths.push(path); }; | true |
Other | emberjs | ember.js | 71de1162c7e20f04eb61339a1aee1fa7b3b02dc0.json | remove unused vars | packages/ember-runtime/lib/system/core_object.js | @@ -854,11 +854,10 @@ let ClassMixinProps = {
metaForProperty(key) {
let proto = this.proto();
let possibleDesc = proto[key];
- let isDescriptor = possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor;
assert(
`metaForProperty() could not find a computed property with key '${key}'.`,
- isDescriptor && possibleDesc instanceof ComputedProperty
+ possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor
);
return possibleDesc._meta || {};
}, | true |
Other | emberjs | ember.js | 662e76dfe834dafa1a8c519896438bfcd5e723ab.json | use inheritance for iterators in `iterable` | packages/ember-glimmer/lib/utils/iterable.js | @@ -68,7 +68,7 @@ function identity(item) {
function ensureUniqueKey(seen, key) {
let seenCount = seen[key];
- if (seenCount) {
+ if (seenCount > 0) {
seen[key]++;
return `${key}${ITERATOR_KEY_GUID}${seenCount}`;
} else {
@@ -91,13 +91,21 @@ class ArrayIterator {
return false;
}
+ getMemo(position) {
+ return position;
+ }
+
+ getValue(position) {
+ return this.array[position];
+ }
+
next() {
- let { array, length, keyFor, position, seen } = this;
+ let { length, keyFor, position, seen } = this;
if (position >= length) { return null; }
- let value = array[position];
- let memo = position;
+ let value = this.getValue(position);
+ let memo = this.getMemo(position);
let key = ensureUniqueKey(seen, keyFor(value, memo));
this.position++;
@@ -106,59 +114,30 @@ class ArrayIterator {
}
}
-class EmberArrayIterator {
+class EmberArrayIterator extends ArrayIterator {
constructor(array, keyFor) {
- this.array = array;
+ super(array, keyFor);
this.length = get(array, 'length');
- this.keyFor = keyFor;
- this.position = 0;
- this.seen = Object.create(null);
}
- isEmpty() {
- return this.length === 0;
- }
-
- next() {
- let { array, length, keyFor, position, seen } = this;
-
- if (position >= length) { return null; }
-
- let value = objectAt(array, position);
- let memo = position;
- let key = ensureUniqueKey(seen, keyFor(value, memo));
-
- this.position++;
-
- return { key, value, memo };
+ getValue(position) {
+ return objectAt(this.array, position);
}
}
-class ObjectKeysIterator {
+class ObjectKeysIterator extends ArrayIterator {
constructor(keys, values, keyFor) {
+ super(values, keyFor);
this.keys = keys;
- this.values = values;
- this.keyFor = keyFor;
- this.position = 0;
- this.seen = Object.create(null);
+ this.length = keys.length;
}
- isEmpty() {
- return this.keys.length === 0;
+ getMemo(position) {
+ return this.keys[position];
}
- next() {
- let { keys, values, keyFor, position, seen } = this;
-
- if (position >= keys.length) { return null; }
-
- let value = values[position];
- let memo = keys[position];
- let key = ensureUniqueKey(seen, keyFor(value, memo));
-
- this.position++;
-
- return { key, value, memo };
+ getValue(position) {
+ return this.array[position];
}
}
| false |
Other | emberjs | ember.js | eea8c112213138a47a53547fc15fb37300e747b9.json | avoid toboolean coercion in `meta_listeners` | packages/ember-metal/lib/is_proxy.js | @@ -1,7 +1,7 @@
import { peekMeta } from './meta';
export function isProxy(value) {
- if (typeof value === 'object' && value) {
+ if (typeof value === 'object' && value !== null) {
let meta = peekMeta(value);
return meta && meta.isProxy();
} | true |
Other | emberjs | ember.js | eea8c112213138a47a53547fc15fb37300e747b9.json | avoid toboolean coercion in `meta_listeners` | packages/ember-metal/lib/meta_listeners.js | @@ -17,19 +17,19 @@ export const SUSPENDED = 2;
export const protoMethods = {
addToListeners(eventName, target, method, flags) {
- if (!this._listeners) {
+ if (this._listeners === undefined) {
this._listeners = [];
}
this._listeners.push(eventName, target, method, flags);
},
_finalizeListeners() {
if (this._listenersFinalized) { return; }
- if (!this._listeners) { this._listeners = []; }
+ if (this._listeners === undefined) { this._listeners = []; }
let pointer = this.parent;
- while (pointer) {
+ while (pointer !== undefined) {
let listeners = pointer._listeners;
- if (listeners) {
+ if (listeners !== undefined) {
this._listeners = this._listeners.concat(listeners);
}
if (pointer._listenersFinalized) { break; }
@@ -40,9 +40,9 @@ export const protoMethods = {
removeFromListeners(eventName, target, method, didRemove) {
let pointer = this;
- while (pointer) {
+ while (pointer !== undefined) {
let listeners = pointer._listeners;
- if (listeners) {
+ if (listeners !== undefined) {
for (let index = listeners.length - 4; index >= 0; index -= 4) {
if (listeners[index] === eventName && (!method || (listeners[index + 1] === target && listeners[index + 2] === method))) {
if (pointer === this) {
@@ -123,9 +123,9 @@ export const protoMethods = {
watchedEvents() {
let pointer = this;
let names = {};
- while (pointer) {
+ while (pointer !== undefined) {
let listeners = pointer._listeners;
- if (listeners) {
+ if (listeners !== undefined) {
for (let index = 0; index < listeners.length - 3; index += 4) {
names[listeners[index]] = true;
}
@@ -141,7 +141,7 @@ function pushUniqueListener(destination, source, index) {
let target = source[index + 1];
let method = source[index + 2];
for (let destinationIndex = 0; destinationIndex < destination.length - 2; destinationIndex += 3) {
- if (destination[destinationIndex] === target && destination[destinationIndex + 1] === method) {
+ if (destination[destinationIndex] === target && destination[destinationIndex + 1] === method) {
return;
}
} | true |
Other | emberjs | ember.js | eea8c112213138a47a53547fc15fb37300e747b9.json | avoid toboolean coercion in `meta_listeners` | packages/ember-metal/lib/tags.js | @@ -28,7 +28,7 @@ export function tagForProperty(object, propertyKey, _meta) {
}
export function tagFor(object, _meta) {
- if (typeof object === 'object' && object) {
+ if (typeof object === 'object' && object !== null) {
let meta = _meta || metaFor(object);
return meta.writableTag(makeTag);
} else { | true |
Other | emberjs | ember.js | 5d7ae49a64600d1e107dbbbac37b4ca901cd7ef9.json | helpers/current_route_name: Fix example rendering | packages/ember-testing/lib/helpers/current_route_name.js | @@ -5,13 +5,16 @@
import { get } from 'ember-metal';
/**
Returns the currently active route name.
+
Example:
+
```javascript
function validateRouteName() {
equal(currentRouteName(), 'some.path', "correct route was transitioned into.");
}
visit('/some/path').then(validateRouteName)
```
+
@method currentRouteName
@return {Object} The name of the currently active route.
@since 1.5.0 | false |
Other | emberjs | ember.js | 974155e35d23785a6ddcd0a4a2f131a41c7cffd5.json | avoid bool conversion | packages/ember-metal/lib/property_events.js | @@ -51,10 +51,10 @@ function propertyWillChange(obj, keyName, _meta) {
let watching = meta && meta.peekWatching(keyName) > 0;
let possibleDesc = obj[keyName];
- let desc = (possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor) ? possibleDesc : undefined;
+ let isDescriptor = possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor;
- if (desc && desc.willChange) {
- desc.willChange(obj, keyName);
+ if (isDescriptor && possibleDesc.willChange) {
+ possibleDesc.willChange(obj, keyName);
}
if (watching) {
@@ -90,11 +90,11 @@ function propertyDidChange(obj, keyName, _meta) {
}
let possibleDesc = obj[keyName];
- let desc = (possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor) ? possibleDesc : undefined;
+ let isDescriptor = possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor;
// shouldn't this mean that we're watching this key?
- if (desc && desc.didChange) {
- desc.didChange(obj, keyName);
+ if (isDescriptor && possibleDesc.didChange) {
+ possibleDesc.didChange(obj, keyName);
}
if (hasMeta && meta.peekWatching(keyName) > 0) {
@@ -157,7 +157,7 @@ function dependentKeysDidChange(obj, depKey, meta) {
}
function iterDeps(method, obj, depKey, seen, meta) {
- let possibleDesc, desc;
+ let possibleDesc, isDescriptor;
let guid = guidFor(obj);
let current = seen[guid];
@@ -175,9 +175,9 @@ function iterDeps(method, obj, depKey, seen, meta) {
if (!value) { return; }
possibleDesc = obj[key];
- desc = (possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor) ? possibleDesc : undefined;
+ isDescriptor = possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor;
- if (desc && desc._suspended === obj) {
+ if (isDescriptor && possibleDesc._suspended === obj) {
return;
}
| true |
Other | emberjs | ember.js | 974155e35d23785a6ddcd0a4a2f131a41c7cffd5.json | avoid bool conversion | packages/ember-metal/lib/watch_key.js | @@ -22,10 +22,9 @@ export function watchKey(obj, keyName, meta) {
m.writeWatching(keyName, 1);
let possibleDesc = obj[keyName];
- let desc = (possibleDesc !== null &&
- typeof possibleDesc === 'object' &&
- possibleDesc.isDescriptor) ? possibleDesc : undefined;
- if (desc && desc.willWatch) { desc.willWatch(obj, keyName); }
+ let isDescriptor = possibleDesc !== null &&
+ typeof possibleDesc === 'object' && possibleDesc.isDescriptor;
+ if (isDescriptor && possibleDesc.willWatch) { possibleDesc.willWatch(obj, keyName); }
if ('function' === typeof obj.willWatchProperty) {
obj.willWatchProperty(keyName);
@@ -98,11 +97,10 @@ export function unwatchKey(obj, keyName, _meta) {
meta.writeWatching(keyName, 0);
let possibleDesc = obj[keyName];
- let desc = (possibleDesc !== null &&
- typeof possibleDesc === 'object' &&
- possibleDesc.isDescriptor) ? possibleDesc : undefined;
+ let isDescriptor = possibleDesc !== null &&
+ typeof possibleDesc === 'object' && possibleDesc.isDescriptor;
- if (desc && desc.didUnwatch) { desc.didUnwatch(obj, keyName); }
+ if (isDescriptor && possibleDesc.didUnwatch) { possibleDesc.didUnwatch(obj, keyName); }
if ('function' === typeof obj.didUnwatchProperty) {
obj.didUnwatchProperty(keyName);
@@ -117,7 +115,7 @@ export function unwatchKey(obj, keyName, _meta) {
// for mutation, will bypass observation. This code exists to assert when
// that occurs, and attempt to provide more helpful feedback. The alternative
// is tricky to debug partially observable properties.
- if (!desc && keyName in obj) {
+ if (!isDescriptor && keyName in obj) {
let maybeMandatoryDescriptor = lookupDescriptor(obj, keyName);
if (maybeMandatoryDescriptor.set && maybeMandatoryDescriptor.set.isMandatorySetter) { | true |
Other | emberjs | ember.js | 974155e35d23785a6ddcd0a4a2f131a41c7cffd5.json | avoid bool conversion | packages/ember-runtime/lib/system/core_object.js | @@ -107,9 +107,6 @@ function makeCtor() {
m.writeBindings(keyName, value);
}
- let possibleDesc = this[keyName];
- let desc = (possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor) ? possibleDesc : undefined;
-
assert(
'Ember.Object.create no longer supports defining computed ' +
'properties. Define computed properties using extend() or reopen() ' +
@@ -146,8 +143,11 @@ function makeCtor() {
value = assign({}, originalValue, value);
}
- if (desc) {
- desc.set(this, keyName, value);
+ let possibleDesc = this[keyName];
+ let isDescriptor = possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor;
+
+ if (isDescriptor) {
+ possibleDesc.set(this, keyName, value);
} else {
if (typeof this.setUnknownProperty === 'function' && !(keyName in this)) {
this.setUnknownProperty(keyName, value); | true |
Other | emberjs | ember.js | 5f386095aa9ba6ee3b193e0d7ddc74d7ff27a5f9.json | remove dead code | packages/ember-metal/lib/meta.js | @@ -506,14 +506,6 @@ if (HAS_NATIVE_WEAKMAP) {
metaStore.set(obj, meta);
};
- peekMeta = function WeakMap_peekMeta(obj) {
- if (DEBUG) {
- counters.peekCalls++
- }
-
- return metaStore.get(obj);
- };
-
peekMeta = function WeakMap_peekParentMeta(obj) {
let pointer = obj;
let meta; | false |
Other | emberjs | ember.js | 6d9a9735eeb04182589ff9bd98569288667cb8d8.json | use flat array in `dsl` | packages/ember-routing/lib/system/dsl.js | @@ -68,7 +68,7 @@ class DSL {
if (url === '' || url === '/' || parts[parts.length - 1] === 'index') { this.explicitIndex = true; }
- this.matches.push([url, name, callback]);
+ this.matches.push(url, name, callback);
}
resource(name, options = {}, callback) {
@@ -90,9 +90,8 @@ class DSL {
}
return match => {
- for (let i = 0; i < dslMatches.length; i++) {
- let dslMatch = dslMatches[i];
- match(dslMatch[0]).to(dslMatch[1], dslMatch[2]);
+ for (let i = 0; i < dslMatches.length; i += 3) {
+ match(dslMatches[i]).to(dslMatches[i + 1], dslMatches[i + 2]);
}
};
}
@@ -136,7 +135,6 @@ class DSL {
createRoute(childDSL, 'loading');
createRoute(childDSL, 'error', { path: dummyErrorRoute });
-
engineRouteMap.class.call(childDSL);
callback = childDSL.generate();
@@ -174,7 +172,7 @@ class DSL {
export default DSL;
function canNest(dsl) {
- return dsl.parent && dsl.parent !== 'application';
+ return dsl.parent !== 'application';
}
function getFullName(dsl, name, resetNamespace) { | false |
Other | emberjs | ember.js | 9208dd1ae96fc23b52e55f656981cc6d99b59e0d.json | Remove runloop from abstract click helper.
In #15358, we discovered that not returning visit functions was
causing us to use unecessary run loops. A click event shouldn't
need to be scheduled in the run loop, and when that is something
else is going wrong. | packages/internal-test-helpers/lib/test-cases/abstract.js | @@ -88,7 +88,7 @@ export default class AbstractTestCase {
}
click(selector) {
- this.runTask(() => this.$(selector).click());
+ return this.$(selector).click();
}
textValue() { | false |
Other | emberjs | ember.js | 6899ef4799b921c30ca1c6ff8a1011a4ba821cd9.json | sync .editorconfig with default new app | .editorconfig | @@ -3,9 +3,15 @@
root = true
[*]
+end_of_line = lf
charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
indent_style = space
indent_size = 2
-end_of_line = lf
-insert_final_newline = true
-trim_trailing_whitespace = true
+
+[*.hbs]
+insert_final_newline = false
+
+[*.{diff,md}]
+trim_trailing_whitespace = false | false |
Other | emberjs | ember.js | e5f9748cc9598854395f967858af5ef379b0cc8b.json | Remove unused Meta methods.
These methods have existed since we started with the current meta system,
but they were added via meta-programming (which meant that all of the
similar types of things ended up with all of the methods).
Now that the meta-programming is unrolled, these methods are not used any
longer. | packages/ember-metal/lib/meta.js | @@ -353,38 +353,6 @@ export class Meta {
return this._findInherited('_watching', subkey);
}
- forEachWatching(fn) {
- let pointer = this;
- let seen;
- while (pointer !== undefined) {
- let map = pointer._watching;
- if (map !== undefined) {
- for (let key in map) {
- seen = seen || Object.create(null);
- if (seen[key] === undefined) {
- seen[key] = true;
- fn(key, map[key]);
- }
- }
- }
- pointer = pointer.parent;
- }
- }
-
- clearWatching() {
- assert(`Cannot clear watchers on \`${toString(this.source)}\` after it has been destroyed.`, !this.isMetaDestroyed());
-
- this._watching = undefined;
- }
-
- deleteFromWatching(subkey) {
- delete this._getOrCreateOwnMap('_watching')[subkey];
- }
-
- hasInWatching(subkey) {
- return this._findInherited('_watching', subkey) !== undefined;
- }
-
writeMixins(subkey, value) {
assert(`Cannot add mixins for \`${subkey}\` on \`${toString(this.source)}\` call writeMixins after it has been destroyed.`, !this.isMetaDestroyed());
let map = this._getOrCreateOwnMap('_mixins');
@@ -413,20 +381,6 @@ export class Meta {
}
}
- clearMixins() {
- assert(`Cannot clear mixins on \`${toString(this.source)}\` after it has been destroyed.`, !this.isMetaDestroyed());
-
- this._mixins = undefined;
- }
-
- deleteFromMixins(subkey) {
- delete this._getOrCreateOwnMap('_mixins')[subkey];
- }
-
- hasInMixins(subkey) {
- return this._findInherited('_mixins', subkey) !== undefined;
- }
-
writeBindings(subkey, value) {
assert(`Cannot add a binding for \`${subkey}\` on \`${toString(this.source)}\` after it has been destroyed.`, !this.isMetaDestroyed());
@@ -461,14 +415,6 @@ export class Meta {
this._bindings = undefined;
}
- deleteFromBindings(subkey) {
- delete this._getOrCreateOwnMap('_bindings')[subkey];
- }
-
- hasInBindings(subkey) {
- return this._findInherited('_bindings', subkey) !== undefined;
- }
-
writeValues(subkey, value) {
assert(`Cannot set the value of \`${subkey}\` on \`${toString(this.source)}\` after it has been destroyed.`, !this.isMetaDestroyed());
@@ -480,38 +426,9 @@ export class Meta {
return this._findInherited('_values', subkey);
}
- forEachValues(fn) {
- let pointer = this;
- let seen;
- while (pointer !== undefined) {
- let map = pointer._values;
- if (map !== undefined) {
- for (let key in map) {
- seen = seen || Object.create(null);
- if (seen[key] === undefined) {
- seen[key] = true;
- fn(key, map[key]);
- }
- }
- }
- pointer = pointer.parent;
- }
- }
-
- clearValues() {
- assert(`Cannot call clearValues after the object is destroyed.`, !this.isMetaDestroyed());
-
- this._values = undefined;
- }
-
deleteFromValues(subkey) {
delete this._getOrCreateOwnMap('_values')[subkey];
}
-
- hasInValues(subkey) {
- return this._findInherited('_values', subkey) !== undefined;
- }
-
}
if (EMBER_GLIMMER_DETECT_BACKTRACKING_RERENDER || EMBER_GLIMMER_ALLOW_BACKTRACKING_RERENDER) { | true |
Other | emberjs | ember.js | e5f9748cc9598854395f967858af5ef379b0cc8b.json | Remove unused Meta methods.
These methods have existed since we started with the current meta system,
but they were added via meta-programming (which meant that all of the
similar types of things ended up with all of the methods).
Now that the meta-programming is unrolled, these methods are not used any
longer. | packages/ember-metal/tests/accessors/mandatory_setters_test.js | @@ -18,7 +18,7 @@ function hasMandatorySetter(object, property) {
}
function hasMetaValue(object, property) {
- return metaFor(object).hasInValues(property);
+ return metaFor(object).peekValues(property) !== undefined;
}
if (MANDATORY_SETTER) { | true |
Other | emberjs | ember.js | e5f9748cc9598854395f967858af5ef379b0cc8b.json | Remove unused Meta methods.
These methods have existed since we started with the current meta system,
but they were added via meta-programming (which meant that all of the
similar types of things ended up with all of the methods).
Now that the meta-programming is unrolled, these methods are not used any
longer. | packages/ember-metal/tests/meta_test.js | @@ -89,18 +89,6 @@ QUnit.test('meta.writeWatching issues useful error after destroy', function(asse
}, 'Cannot update watchers for `hello` on `<special-sauce:123>` after it has been destroyed.');
});
-QUnit.test('meta.clearWatching issues useful error after destroy', function(assert) {
- let target = {
- toString() { return '<special-sauce:123>'; }
- };
- let targetMeta = meta(target);
-
- targetMeta.destroy();
-
- expectAssertion(() => {
- targetMeta.clearWatching();
- }, 'Cannot clear watchers on `<special-sauce:123>` after it has been destroyed.');
-});
QUnit.test('meta.writableTag issues useful error after destroy', function(assert) {
let target = {
toString() { return '<special-sauce:123>'; } | true |
Other | emberjs | ember.js | 271d8cd7b6987f177318081925a5e3c74abe9762.json | use flat array in `meta/_forEachIn` | packages/ember-metal/lib/meta.js | @@ -305,17 +305,17 @@ export class Meta {
if (seen[innerKey] === undefined) {
seen[innerKey] = true;
calls = calls || [];
- calls.push([innerKey, innerMap[innerKey]]);
+ calls.push(innerKey, innerMap[innerKey]);
}
}
}
}
pointer = pointer.parent;
}
+
if (calls !== undefined) {
- for (let i = 0; i < calls.length; i++) {
- let [innerKey, value] = calls[i];
- fn(innerKey, value);
+ for (let i = 0; i < calls.length; i+=2) {
+ fn(calls[i], calls[i + 1]);
}
}
}
@@ -341,7 +341,7 @@ export class Meta {
writeValue(obj, key, value) {
let descriptor = lookupDescriptor(obj, key);
- let isMandatorySetter = descriptor !== undefined&& descriptor.set && descriptor.set.isMandatorySetter;
+ let isMandatorySetter = descriptor !== undefined && descriptor.set && descriptor.set.isMandatorySetter;
if (isMandatorySetter) {
this.writeValues(key, value); | false |
Other | emberjs | ember.js | eb2559f96e9e5300807e976702111fa27836bfa2.json | Change Object to any | packages/ember-testing/lib/helpers/wait.js | @@ -30,7 +30,7 @@ import { pendingRequests } from '../test/pending_requests';
@method wait
@param {Object} value The value to be returned.
- @return {RSVP.Promise<Object>} Promise that resolves to the passed value.
+ @return {RSVP.Promise<any>} Promise that resolves to the passed value.
@public
@since 1.0.0
*/ | false |
Other | emberjs | ember.js | 2e01276c2a4c0eee51669f3e12092dcf720fb46a.json | Add 2.14.0-beta.3 to CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -1,13 +1,20 @@
# Ember Changelog
+### 2.14.0-beta.3 (May 30, 2017)
+
+- [#15242](https://github.com/emberjs/ember.js/pull/15242) [BUGFIX] Fix EmberError import in system/router
+- [#15204](https://github.com/emberjs/ember.js/pull/15204) [DEPRECATION] `Ember.MODEL_FACTORY_INJECTIONS` is now always false, and issues a deprecation if set.
+- [#15239](https://github.com/emberjs/ember.js/pull/15239) [BUGFIX] Ensure `Ember.deprecate` is exported properly.
+- [glimmerjs/glimmer-vm#529](https://github.com/glimmerjs/glimmer-vm/pull/529) [BUGFIX] Fix issues identified with custom element support.
+- [#15277](https://github.com/emberjs/ember.js/pull/15277) [BUGFIX] Fix issues with retrying an initial transition.
+
### 2.14.0-beta.2 (May 10, 2017)
- [#15138](https://github.com/emberjs/ember.js/pull/15138) [BUGFIX] Fix mocha blueprint service test filename
- [#15193](https://github.com/emberjs/ember.js/pull/15193) [BUGFIX] Ensure `factoryFor` does validation.
- [#15207](https://github.com/emberjs/ember.js/pull/15207) [BUGFIX] Ensure that an engines container is only destroyed once.
- [#15218](https://github.com/emberjs/ember.js/pull/15218) [BUGFIX] Update route-recognizer to v0.3.3.
-
### 2.14.0-beta.1 (April 27, 2017)
- [#15015](https://github.com/emberjs/ember.js/pull/15015) Allow mounting routeless engines with a bound engine name | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.