language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | vercel | next.js | 683db9a8ad2660c0de12dfb44ef6808a9726cb20.json | Support tsconfig paths without baseurl (#34926)
tsconfig behaves differently with `tsc` vs. Next.js. When `baseurl` is omitted, `paths` should be resolved against the tsconfig location. Consequentially, in this case the paths must start with `./`. This PR aligns Next.js behavior with `tsc` around `paths` without `base... | test/integration/jsconfig-paths/test/index.test.js | @@ -3,14 +3,17 @@
import fs from 'fs-extra'
import { join } from 'path'
import cheerio from 'cheerio'
+import * as path from 'path'
import {
renderViaHTTP,
findPort,
launchApp,
nextBuild,
killApp,
check,
+ File,
} from 'next-test-utils'
+import * as JSON5 from 'json5'
const appDir = join(__di... | true |
Other | vercel | next.js | 683db9a8ad2660c0de12dfb44ef6808a9726cb20.json | Support tsconfig paths without baseurl (#34926)
tsconfig behaves differently with `tsc` vs. Next.js. When `baseurl` is omitted, `paths` should be resolved against the tsconfig location. Consequentially, in this case the paths must start with `./`. This PR aligns Next.js behavior with `tsc` around `paths` without `base... | test/integration/typescript-paths/test/index.test.js | @@ -2,7 +2,15 @@
import { join } from 'path'
import cheerio from 'cheerio'
-import { renderViaHTTP, findPort, launchApp, killApp } from 'next-test-utils'
+import * as path from 'path'
+import {
+ renderViaHTTP,
+ findPort,
+ launchApp,
+ killApp,
+ File,
+} from 'next-test-utils'
+import * as JSON5 from 'json5... | true |
Other | vercel | next.js | e0d7ee01df95aa07fbe42bf1a37e09228409a255.json | Fix Edge SSR routes (#39594)
Currently Edge SSR routes are added to both `routedPages` (catch-all page render routes) and `edgeRoutesSet` (catch-all edge function routes). This causes the request to be handled by both and results in an error (the Node server can't execute the Edge SSR route as a regular page).
Anoth... | packages/next/server/dev/next-dev-server.ts | @@ -382,12 +382,13 @@ export default class DevServer extends Server {
page: pageName,
pageRuntime: staticInfo.runtime,
onClient: () => {},
- onServer: () => {},
+ onServer: () => {
+ routedPages.push(pageName)
+ },
onEdgeS... | true |
Other | vercel | next.js | e0d7ee01df95aa07fbe42bf1a37e09228409a255.json | Fix Edge SSR routes (#39594)
Currently Edge SSR routes are added to both `routedPages` (catch-all page render routes) and `edgeRoutesSet` (catch-all edge function routes). This causes the request to be handled by both and results in an error (the Node server can't execute the Edge SSR route as a regular page).
Anoth... | packages/next/server/next-server.ts | @@ -84,10 +84,10 @@ import { removeTrailingSlash } from '../shared/lib/router/utils/remove-trailing-
import { getNextPathnameInfo } from '../shared/lib/router/utils/get-next-pathname-info'
import { bodyStreamToNodeStream, getClonableBody } from './body-streams'
import { checkIsManualRevalidate } from './api-utils'
-... | true |
Other | vercel | next.js | e0d7ee01df95aa07fbe42bf1a37e09228409a255.json | Fix Edge SSR routes (#39594)
Currently Edge SSR routes are added to both `routedPages` (catch-all page render routes) and `edgeRoutesSet` (catch-all edge function routes). This causes the request to be handled by both and results in an error (the Node server can't execute the Edge SSR route as a regular page).
Anoth... | test/e2e/switchable-runtime/index.test.ts | @@ -70,6 +70,43 @@ describe('Switchable runtime', () => {
expect(devMiddlewareManifest).toEqual({})
})
+ it('should sort edge SSR routes correctly', async () => {
+ const res = await fetchViaHTTP(next.url, `/edge/foo`)
+ const html = await res.text()
+
+ // /edge/foo should b... | true |
Other | vercel | next.js | e0d7ee01df95aa07fbe42bf1a37e09228409a255.json | Fix Edge SSR routes (#39594)
Currently Edge SSR routes are added to both `routedPages` (catch-all page render routes) and `edgeRoutesSet` (catch-all edge function routes). This causes the request to be handled by both and results in an error (the Node server can't execute the Edge SSR route as a regular page).
Anoth... | test/e2e/switchable-runtime/pages/edge/[id].js | @@ -0,0 +1,13 @@
+import Link from 'next/link'
+
+export default function Page() {
+ return (
+ <div>
+ <Link href="/edge/foo">to /edge/foo</Link>
+ </div>
+ )
+}
+
+export const config = {
+ runtime: 'experimental-edge',
+} | true |
Other | vercel | next.js | e0d7ee01df95aa07fbe42bf1a37e09228409a255.json | Fix Edge SSR routes (#39594)
Currently Edge SSR routes are added to both `routedPages` (catch-all page render routes) and `edgeRoutesSet` (catch-all edge function routes). This causes the request to be handled by both and results in an error (the Node server can't execute the Edge SSR route as a regular page).
Anoth... | test/e2e/switchable-runtime/pages/edge/foo.js | @@ -0,0 +1,13 @@
+import Link from 'next/link'
+
+export default function Page() {
+ return (
+ <div>
+ <Link href="/edge/123">to /edge/[id]</Link>
+ </div>
+ )
+}
+
+export const config = {
+ runtime: 'experimental-edge',
+} | true |
Other | vercel | next.js | 2fa3edccc9c5b6f623a820da91c9ca062b895ef2.json | Clarify dismissal message (#12624) | packages/react-dev-overlay/src/internal/container/BuildError.tsx | @@ -32,8 +32,8 @@ export const BuildError: React.FC<BuildErrorProps> = function BuildError({
<footer>
<p id="nextjs__container_build_error_desc">
<small>
- This error occured during the build process and cannot be
- dismissed.
+ ... | false |
Other | vercel | next.js | d5d3c60489d71f0fbd4b15b06b9ed340e1b5065d.json | Fix error toast pluralization (#12622) | packages/react-dev-overlay/src/internal/container/Errors.tsx | @@ -202,7 +202,9 @@ export const Errors: React.FC<ErrorsProps> = function Errors({ errors }) {
<line x1="12" y1="8" x2="12" y2="12"></line>
<line x1="12" y1="16" x2="12.01" y2="16"></line>
</svg>
- <span>{readyErrors.length} errors</span>
+ <span>
+ {rea... | false |
Other | vercel | next.js | dac715e8f7314d626c63eb49a5e9728ec2665fa7.json | Add flag to disable API warning (#11380)
* Add flag to disable API warning
This flag is useful when you are using an external API resolver like express when defining an API route, since the native functionality doesn't realize that the API actually sent a response.
A very simple use case example https://github.c... | docs/api-routes/api-middlewares.md | @@ -56,6 +56,16 @@ export const config = {
}
```
+`externalResolver` is an explicit flag that tells the server that this route is being handled by an external resolver like _express_ or _connect_. Enabling this option disables warnings for unresolved requests.
+
+```js
+export const config = {
+ api: {
+ extern... | true |
Other | vercel | next.js | dac715e8f7314d626c63eb49a5e9728ec2665fa7.json | Add flag to disable API warning (#11380)
* Add flag to disable API warning
This flag is useful when you are using an external API resolver like express when defining an API route, since the native functionality doesn't realize that the API actually sent a response.
A very simple use case example https://github.c... | packages/next/next-server/server/api-utils.ts | @@ -37,6 +37,7 @@ export async function apiResolver(
}
const config: PageConfig = resolverModule.config || {}
const bodyParser = config.api?.bodyParser !== false
+ const externalResolver = config.api?.externalResolver || false
// Parsing of cookies
setLazyProp({ req: apiReq }, 'cookies', g... | true |
Other | vercel | next.js | dac715e8f7314d626c63eb49a5e9728ec2665fa7.json | Add flag to disable API warning (#11380)
* Add flag to disable API warning
This flag is useful when you are using an external API resolver like express when defining an API route, since the native functionality doesn't realize that the API actually sent a response.
A very simple use case example https://github.c... | packages/next/types/index.d.ts | @@ -53,6 +53,12 @@ export type PageConfig = {
* format supported by `bytes`, for example `1000`, `'500kb'` or `'3mb'`.
*/
bodyParser?: { sizeLimit?: number | string } | false
+ /**
+ * Flag to disable warning "API page resolved
+ * without sending a response", due to explicitly
+ * using... | true |
Other | vercel | next.js | dac715e8f7314d626c63eb49a5e9728ec2665fa7.json | Add flag to disable API warning (#11380)
* Add flag to disable API warning
This flag is useful when you are using an external API resolver like express when defining an API route, since the native functionality doesn't realize that the API actually sent a response.
A very simple use case example https://github.c... | test/integration/api-support/pages/api/external-resolver-false-positive.js | @@ -0,0 +1,5 @@
+export default (_req, res) => {
+ setTimeout(() => {
+ res.send('hello world')
+ }, 0)
+}
| true |
Other | vercel | next.js | dac715e8f7314d626c63eb49a5e9728ec2665fa7.json | Add flag to disable API warning (#11380)
* Add flag to disable API warning
This flag is useful when you are using an external API resolver like express when defining an API route, since the native functionality doesn't realize that the API actually sent a response.
A very simple use case example https://github.c... | test/integration/api-support/pages/api/external-resolver.js | @@ -0,0 +1,11 @@
+export default (_req, res) => {
+ setTimeout(() => {
+ res.send('hello world')
+ }, 0)
+}
+
+export const config = {
+ api: {
+ externalResolver: true,
+ },
+}
| true |
Other | vercel | next.js | dac715e8f7314d626c63eb49a5e9728ec2665fa7.json | Add flag to disable API warning (#11380)
* Add flag to disable API warning
This flag is useful when you are using an external API resolver like express when defining an API route, since the native functionality doesn't realize that the API actually sent a response.
A very simple use case example https://github.c... | test/integration/api-support/test/index.test.js | @@ -377,6 +377,25 @@ function runTests(dev = false) {
`API resolved without sending a response for /api/test-res-pipe`
)
})
+
+ it('should show false positive warning if not using externalResolver flag', async () => {
+ const apiURL = '/api/external-resolver-false-positive'
+ const req... | true |
Other | vercel | next.js | 63bfbfff542af2b49cb916fe31e50c6cdbc57157.json | Add cross-env package (#12581)
* add notes
* add cross-env package, for stability in different SO
* fix: move cross-env package from Dependencies at devDependicies | examples/with-firebase-authentication-serverless/package.json | @@ -2,9 +2,9 @@
"name": "with-firebase-auth-serverless",
"version": "1.0.0",
"scripts": {
- "dev": "NODE_ENV=development next dev",
- "build": "NODE_ENV=production next build",
- "start": "NODE_ENV=production next start"
+ "dev": "cross-env NODE_ENV=development next dev",
+ "build": "cross-env N... | false |
Other | vercel | next.js | 960368eed5899abf99fa728dafe8ca858e217cdd.json | Resolve bug with Prismic Locales (#12132)
* Resolve bug with Prismic Locales
add configuration for not default locale
* Resolve bug with Prismic Locales
Add configuration for Prismic locale.
More information about bug:
* Fixes and removed unrequired changes
Co-authored-by: Luis Alvarez <luis@zeit.co> | examples/cms-prismic/.env.example | @@ -1,2 +1,3 @@
NEXT_EXAMPLE_CMS_PRISMIC_API_TOKEN=
-NEXT_EXAMPLE_CMS_PRISMIC_REPOSITORY_NAME=
\ No newline at end of file
+NEXT_EXAMPLE_CMS_PRISMIC_REPOSITORY_NAME=
+NEXT_EXAMPLE_CMS_PRISMIC_REPOSITORY_LOCALE="en-us"
\ No newline at end of file | true |
Other | vercel | next.js | 960368eed5899abf99fa728dafe8ca858e217cdd.json | Resolve bug with Prismic Locales (#12132)
* Resolve bug with Prismic Locales
add configuration for not default locale
* Resolve bug with Prismic Locales
Add configuration for Prismic locale.
More information about bug:
* Fixes and removed unrequired changes
Co-authored-by: Luis Alvarez <luis@zeit.co> | examples/cms-prismic/README.md | @@ -109,12 +109,14 @@ Then set each variable on `.env`:
- `NEXT_EXAMPLE_CMS_PRISMIC_API_TOKEN` should be the **Permanent access token** you just created
- `NEXT_EXAMPLE_CMS_PRISMIC_REPOSITORY_NAME` is the name of your repository (the one in the URL)
+- `NEXT_EXAMPLE_CMS_PRISMIC_REPOSITORY_LOCALE` is the locale of y... | true |
Other | vercel | next.js | 960368eed5899abf99fa728dafe8ca858e217cdd.json | Resolve bug with Prismic Locales (#12132)
* Resolve bug with Prismic Locales
add configuration for not default locale
* Resolve bug with Prismic Locales
Add configuration for Prismic locale.
More information about bug:
* Fixes and removed unrequired changes
Co-authored-by: Luis Alvarez <luis@zeit.co> | examples/cms-prismic/lib/api.js | @@ -6,6 +6,7 @@ const REF_API_URL = `https://${REPOSITORY}.prismic.io/api/v2`
const GRAPHQL_API_URL = `https://${REPOSITORY}.prismic.io/graphql`
// export const API_URL = 'https://your-repo-name.cdn.prismic.io/api/v2'
export const API_TOKEN = process.env.NEXT_EXAMPLE_CMS_PRISMIC_API_TOKEN
+export const API_LOCALE = ... | true |
Other | vercel | next.js | 960368eed5899abf99fa728dafe8ca858e217cdd.json | Resolve bug with Prismic Locales (#12132)
* Resolve bug with Prismic Locales
add configuration for not default locale
* Resolve bug with Prismic Locales
Add configuration for Prismic locale.
More information about bug:
* Fixes and removed unrequired changes
Co-authored-by: Luis Alvarez <luis@zeit.co> | examples/cms-prismic/next.config.js | @@ -6,5 +6,7 @@ module.exports = {
process.env.NEXT_EXAMPLE_CMS_PRISMIC_API_TOKEN,
NEXT_EXAMPLE_CMS_PRISMIC_REPOSITORY_NAME:
process.env.NEXT_EXAMPLE_CMS_PRISMIC_REPOSITORY_NAME,
+ NEXT_EXAMPLE_CMS_PRISMIC_REPOSITORY_LOCALE:
+ process.env.NEXT_EXAMPLE_CMS_PRISMIC_REPOSITORY_LOCALE || 'en-us',... | true |
Other | vercel | next.js | 5dfb2e40d1bf5f0e100a92ebab1301877f3d23f6.json | Update AMP dependencies (#12536) | packages/next/compiled/amphtml-validator/index.js | @@ -1,2 +1 @@
-#!/usr/bin/env node
-module.exports=function(e,t){"use strict";var n={};function __webpack_require__(t){if(n[t]){return n[t].exports}var r=n[t]={i:t,l:false,exports:{}};e[t].call(r.exports,r,r.exports,__webpack_require__);r.l=true;return r.exports}__webpack_require__.ab=__dirname+"/";function startup(){r... | true |
Other | vercel | next.js | 5dfb2e40d1bf5f0e100a92ebab1301877f3d23f6.json | Update AMP dependencies (#12536) | packages/next/package.json | @@ -58,7 +58,7 @@
]
},
"dependencies": {
- "@ampproject/toolbox-optimizer": "2.3.0",
+ "@ampproject/toolbox-optimizer": "2.3.1",
"@babel/core": "7.7.2",
"@babel/plugin-proposal-class-properties": "7.7.0",
"@babel/plugin-proposal-nullish-coalescing-operator": "7.7.4",
@@ -151,7 +151,7 @@
... | true |
Other | vercel | next.js | 5dfb2e40d1bf5f0e100a92ebab1301877f3d23f6.json | Update AMP dependencies (#12536) | test/integration/amphtml-custom-optimizer/next.config.js | @@ -3,6 +3,7 @@ module.exports = {
amp: {
optimizer: {
ampRuntimeVersion: '001515617716922',
+ rtv: true,
verbose: true,
},
skipValidation: true, | true |
Other | vercel | next.js | 5dfb2e40d1bf5f0e100a92ebab1301877f3d23f6.json | Update AMP dependencies (#12536) | yarn.lock | @@ -9,13 +9,13 @@
dependencies:
cross-fetch "3.0.4"
-"@ampproject/toolbox-optimizer@2.3.0":
- version "2.3.0"
- resolved "https://registry.yarnpkg.com/@ampproject/toolbox-optimizer/-/toolbox-optimizer-2.3.0.tgz#504341aa75f81b42d17406d323a71b961e5fa062"
- integrity sha512-g2I7qNK6G1UWGFgw7BaHy9fUW8866vyieZe... | true |
Other | vercel | next.js | 467b65a889cc8d40d38910bdfdb28c756086a926.json | Add note about HoC possibly adding GIP to _app (#12491) | errors/opt-out-auto-static-optimization.md | @@ -11,6 +11,8 @@ This causes **all non-getStaticProps pages** to be executed on the server -- dis
Be sure you meant to use `getInitialProps` in `pages/_app`!
There are some valid use cases for this, but it is often better to handle `getInitialProps` on a _per-page_ basis.
+Check for any [higher-order components](h... | false |
Other | vercel | next.js | 0d4707d69c39aab471c932c275c40e180f97c28b.json | next/client/link: improve internal type annotation (#12468) | packages/next/client/link.tsx | @@ -55,9 +55,9 @@ export type LinkProps = {
}
let observer: IntersectionObserver
-const listeners = new Map()
+const listeners = new Map<Element, () => void>()
const IntersectionObserver =
- typeof window !== 'undefined' ? (window as any).IntersectionObserver : null
+ typeof window !== 'undefined' ? window.Inter... | false |
Other | vercel | next.js | ba30381c99948c50da6997196b1455bf1beb2f1c.json | Use fs.promises in test files (#12432) | test/integration/amp-export-validation/test/index.test.js | @@ -1,14 +1,12 @@
/* eslint-env jest */
/* global jasmine */
-import fs from 'fs'
+import { promises } from 'fs'
import { join } from 'path'
-import { promisify } from 'util'
import { validateAMP } from 'amp-test-utils'
import { File, nextBuild, nextExport, runNextCommand } from 'next-test-utils'
jasmine.DEFAUL... | true |
Other | vercel | next.js | ba30381c99948c50da6997196b1455bf1beb2f1c.json | Use fs.promises in test files (#12432) | test/integration/export-default-map-serverless/test/index.test.js | @@ -1,14 +1,12 @@
/* eslint-env jest */
/* global jasmine */
-import fs from 'fs'
+import { promises } from 'fs'
import { join } from 'path'
import cheerio from 'cheerio'
-import { promisify } from 'util'
import { nextBuild, nextExport } from 'next-test-utils'
jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000 * 60 * 5
-c... | true |
Other | vercel | next.js | ba30381c99948c50da6997196b1455bf1beb2f1c.json | Use fs.promises in test files (#12432) | test/integration/export-default-map/test/index.test.js | @@ -1,14 +1,12 @@
/* eslint-env jest */
/* global jasmine */
-import fs from 'fs'
+import { promises } from 'fs'
import { join } from 'path'
import cheerio from 'cheerio'
-import { promisify } from 'util'
import { nextBuild, nextExport } from 'next-test-utils'
jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000 * 60 * 5
-c... | true |
Other | vercel | next.js | ba30381c99948c50da6997196b1455bf1beb2f1c.json | Use fs.promises in test files (#12432) | test/integration/export-override-404/test/index.test.js | @@ -1,12 +1,11 @@
/* eslint-env jest */
/* global jasmine */
-import fs from 'fs'
+import { promises } from 'fs'
import { join } from 'path'
-import { promisify } from 'util'
import { nextBuild, nextExport } from 'next-test-utils'
jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000 * 60 * 5
-const readFile = promisify(fs.re... | true |
Other | vercel | next.js | ba30381c99948c50da6997196b1455bf1beb2f1c.json | Use fs.promises in test files (#12432) | test/integration/export-serverless/test/index.test.js | @@ -1,6 +1,7 @@
/* eslint-env jest */
/* global jasmine */
import { join } from 'path'
+import { promises } from 'fs'
import {
nextBuild,
nextExport,
@@ -16,16 +17,12 @@ import {
import ssr from './ssr'
import browser from './browser'
import dev from './dev'
-import { promisify } from 'util'
-import fs fro... | true |
Other | vercel | next.js | ba30381c99948c50da6997196b1455bf1beb2f1c.json | Use fs.promises in test files (#12432) | test/integration/export-subfolders-serverless/test/index.test.js | @@ -1,14 +1,12 @@
/* eslint-env jest */
/* global jasmine */
-import fs from 'fs'
+import { promises } from 'fs'
import { join } from 'path'
import cheerio from 'cheerio'
-import { promisify } from 'util'
import { nextBuild, nextExport } from 'next-test-utils'
jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000 * 60 * 5
-c... | true |
Other | vercel | next.js | ba30381c99948c50da6997196b1455bf1beb2f1c.json | Use fs.promises in test files (#12432) | test/integration/export-subfolders/test/index.test.js | @@ -1,14 +1,12 @@
/* eslint-env jest */
/* global jasmine */
-import fs from 'fs'
+import { promises } from 'fs'
import { join } from 'path'
import cheerio from 'cheerio'
-import { promisify } from 'util'
import { nextBuild, nextExport } from 'next-test-utils'
jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000 * 60 * 5
-c... | true |
Other | vercel | next.js | ba30381c99948c50da6997196b1455bf1beb2f1c.json | Use fs.promises in test files (#12432) | test/integration/export/test/index.test.js | @@ -16,16 +16,13 @@ import {
import ssr from './ssr'
import browser from './browser'
import dev from './dev'
-import { promisify } from 'util'
-import fs from 'fs'
+import { promises } from 'fs'
import dynamic from './dynamic'
import apiRoutes from './api-routes'
jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000 * 60 * 5... | true |
Other | vercel | next.js | ba30381c99948c50da6997196b1455bf1beb2f1c.json | Use fs.promises in test files (#12432) | test/integration/production/test/process-env.js | @@ -1,12 +1,10 @@
/* eslint-env jest */
import webdriver from 'next-webdriver'
-import { readFile } from 'fs'
-import { promisify } from 'util'
+import { promises } from 'fs'
import { join } from 'path'
-const readFileAsync = promisify(readFile)
const readNextBuildFile = relativePath =>
- readFileAsync(join(__di... | true |
Other | vercel | next.js | 96f8455a03b7d4832929909396ebcb2e8bb5169f.json | Add names to components in amp example (#12415) | examples/amp/components/Byline.js | @@ -1,11 +1,13 @@
-export default ({ author }) => (
- <>
- <div className="byline">By {author}</div>
- <style jsx>{`
- .byline {
- color: green;
- font-weight: bolder;
- }
- `}</style>
- </>
-)
+export default function Byline({ author }) {
+ return (
+ <>
+ <div className="by... | true |
Other | vercel | next.js | 96f8455a03b7d4832929909396ebcb2e8bb5169f.json | Add names to components in amp example (#12415) | examples/amp/pages/dog.js | @@ -6,7 +6,7 @@ export const config = {
amp: 'hybrid',
}
-export default () => {
+export default function DogPage() {
const isAmp = useAmp()
return ( | true |
Other | vercel | next.js | 96f8455a03b7d4832929909396ebcb2e8bb5169f.json | Add names to components in amp example (#12415) | examples/amp/pages/index.js | @@ -7,7 +7,7 @@ export const config = {
amp: true,
}
-export default () => {
+export default function IndexPage() {
const isAmp = useAmp()
return ( | true |
Other | vercel | next.js | 96f8455a03b7d4832929909396ebcb2e8bb5169f.json | Add names to components in amp example (#12415) | examples/amp/pages/normal.js | @@ -1 +1,3 @@
-export default () => <p>I'm just a normal old page, no AMP for me</p>
+export default function NormalPage() {
+ return <p>I'm just a normal old page, no AMP for me</p>
+} | true |
Other | vercel | next.js | f13ca3055ca31fc5c03d8e9fc187c0fba15a2245.json | Add names to components in hello-world example (#12416) | examples/hello-world/pages/about.js | @@ -1 +1,3 @@
-export default () => <div>About us</div>
+export default function AboutPage() {
+ return <div>About us</div>
+} | true |
Other | vercel | next.js | f13ca3055ca31fc5c03d8e9fc187c0fba15a2245.json | Add names to components in hello-world example (#12416) | examples/hello-world/pages/day/index.js | @@ -1 +1,3 @@
-export default () => <div>Hello Day</div>
+export default function DayPage() {
+ return <div>Hello Day</div>
+} | true |
Other | vercel | next.js | f13ca3055ca31fc5c03d8e9fc187c0fba15a2245.json | Add names to components in hello-world example (#12416) | examples/hello-world/pages/index.js | @@ -1,9 +1,12 @@
import Link from 'next/link'
-export default () => (
- <div>
- Hello World.{' '}
- <Link href="/about">
- <a>About</a>
- </Link>
- </div>
-)
+
+export function IndexPage() {
+ return (
+ <div>
+ Hello World.{' '}
+ <Link href="/about">
+ <a>About</a>
+ </Link>... | true |
Other | vercel | next.js | a59a15dd78f448ef6db09b348e2a1faf08cfc547.json | Add name to component in with-tailwindcss example (#12417) | examples/with-tailwindcss/pages/index.js | @@ -1,10 +1,12 @@
import Nav from '../components/nav'
-export default () => (
- <div>
- <Nav />
- <div className="hero">
- <h1 className="title">Next.js + Tailwind CSS</h1>
+export default function IndexPage() {
+ return (
+ <div>
+ <Nav />
+ <div className="hero">
+ <h1 className="t... | false |
Other | vercel | next.js | 18549e065d50b1c4a3908266ee49eb398f254502.json | Scroll entire content instead of only header (#12881) | packages/react-dev-overlay/src/internal/components/Dialog/styles.ts | @@ -46,6 +46,7 @@ const styles = css`
}
[data-nextjs-dialog-banner]::after {
+ z-index: 2;
content: '';
position: absolute;
top: 0;
@@ -61,6 +62,7 @@ const styles = css`
}
[data-nextjs-dialog-content] {
+ overflow-y: auto;
border: none;
margin: 0;
/* calc(padding + ba... | false |
Other | vercel | next.js | 5da1dcf669cff474eb6521008173158a5d8f6ebe.json | Warn users about migrating to 9.4 from dotenv (#12859) | docs/basic-features/environment-variables.md | @@ -47,6 +47,7 @@ npx cross-env NEXT_PUBLIC_EXAMPLE_KEY=my-value next dev
- Trying to destructure `process.env` variables won't work due to the limitations of webpack's [DefinePlugin](https://webpack.js.org/plugins/define-plugin/).
- To avoid exposing secrets, do not use the `NEXT_PUBLIC_` prefix for them. Instead,... | false |
Other | vercel | next.js | e35c6534e7a5c2238caad5dc45036216518c5ecd.json | Eliminate 404s from internal requests (#12871) | packages/react-dev-overlay/src/internal/helpers/stack-frame.ts | @@ -52,7 +52,7 @@ export function getOriginalStackFrame(
.finally(() => {
clearTimeout(tm)
})
- if (!res.ok) {
+ if (!res.ok || res.status === 204) {
return Promise.reject(new Error(await res.text()))
}
| true |
Other | vercel | next.js | e35c6534e7a5c2238caad5dc45036216518c5ecd.json | Eliminate 404s from internal requests (#12871) | packages/react-dev-overlay/src/middleware.ts | @@ -100,8 +100,8 @@ function getOverlayMiddleware(options: OverlayMiddlewareOptions) {
}
if (source == null) {
- res.statusCode = 404
- res.write('Not Found')
+ res.statusCode = 204
+ res.write('No Content')
return res.end()
}
@@ -130,8 +130,8 @@ function ge... | true |
Other | vercel | next.js | b931cbecbf2ae936b14b481a62992a0ba88dd039.json | Simplify CSS Errors (#12852) | packages/next/build/webpack/plugins/wellknown-errors-plugin/parseCss.ts | @@ -0,0 +1,38 @@
+import Chalk from 'next/dist/compiled/chalk'
+import { SimpleWebpackError } from './simpleWebpackError'
+
+const chalk = new Chalk.constructor({ enabled: true })
+const regexCssError = /^(?:CssSyntaxError|SyntaxError)\n\n\((\d+):(\d*)\) (.*)$/s
+
+export function getCssError(
+ fileName: string,
+ e... | true |
Other | vercel | next.js | b931cbecbf2ae936b14b481a62992a0ba88dd039.json | Simplify CSS Errors (#12852) | packages/next/build/webpack/plugins/wellknown-errors-plugin/webpackModuleError.ts | @@ -2,19 +2,23 @@ import * as path from 'path'
// eslint-disable-next-line @typescript-eslint/no-unused-vars
import { compilation } from 'webpack'
import { getBabelError } from './parseBabel'
+import { getCssError } from './parseCss'
import { SimpleWebpackError } from './simpleWebpackError'
function getFilename(... | true |
Other | vercel | next.js | b931cbecbf2ae936b14b481a62992a0ba88dd039.json | Simplify CSS Errors (#12852) | test/acceptance/ReactRefreshLogBox.test.js | @@ -713,3 +713,50 @@ test('conversion to class component (1)', async () => {
await cleanup()
})
+
+test('css syntax errors', async () => {
+ const [session, cleanup] = await sandbox()
+
+ await session.write('index.module.css', `.button {}`)
+ await session.patch(
+ 'index.js',
+ `
+ import './index... | true |
Other | vercel | next.js | b931cbecbf2ae936b14b481a62992a0ba88dd039.json | Simplify CSS Errors (#12852) | test/integration/css-features/test/index.test.js | @@ -150,7 +150,7 @@ describe('Custom Properties: Fail for :root {} in CSS Modules', () => {
expect(code).not.toBe(0)
expect(stderr).toContain('Failed to compile')
expect(stderr).toContain('pages/styles.module.css')
- expect(stderr).toContain('CssSyntax error: Selector ":root" is not pure')
+ expect... | true |
Other | vercel | next.js | 64c7571e01d85190ff2ca1225b7b072466a66403.json | Fix edge case in fetch polyfill (#12832)
* Add tests for getStaticPaths
* Fix edge case in fetch polyfill
Fixes #12794
* Correct typo in tests | packages/next/build/index.ts | @@ -1,3 +1,4 @@
+import '../next-server/server/node-polyfill-fetch'
import crypto from 'crypto'
import { promises, writeFileSync } from 'fs'
import Worker from 'jest-worker' | true |
Other | vercel | next.js | 64c7571e01d85190ff2ca1225b7b072466a66403.json | Fix edge case in fetch polyfill (#12832)
* Add tests for getStaticPaths
* Fix edge case in fetch polyfill
Fixes #12794
* Correct typo in tests | packages/next/build/utils.ts | @@ -1,3 +1,4 @@
+import '../next-server/server/node-polyfill-fetch'
import chalk from 'next/dist/compiled/chalk'
import gzipSize from 'next/dist/compiled/gzip-size'
import textTable from 'next/dist/compiled/text-table' | true |
Other | vercel | next.js | 64c7571e01d85190ff2ca1225b7b072466a66403.json | Fix edge case in fetch polyfill (#12832)
* Add tests for getStaticPaths
* Fix edge case in fetch polyfill
Fixes #12794
* Correct typo in tests | test/integration/fetch-polyfill/api-server.js | @@ -2,6 +2,30 @@ const http = require('http')
const port = process.env.PORT || 3000
const server = new http.Server(async (req, res) => {
+ if (req.url === '/usernames') {
+ return res.end(
+ JSON.stringify({
+ usernames: ['a', 'b'],
+ })
+ )
+ }
+
+ if (req.url === '/usernames/a') {
+ r... | true |
Other | vercel | next.js | 64c7571e01d85190ff2ca1225b7b072466a66403.json | Fix edge case in fetch polyfill (#12832)
* Add tests for getStaticPaths
* Fix edge case in fetch polyfill
Fixes #12794
* Correct typo in tests | test/integration/fetch-polyfill/pages/user/[username].js | @@ -0,0 +1,33 @@
+export default function StaticPage({ data }) {
+ return <div id="username">{data.from}</div>
+}
+
+const port = process.env.NEXT_PUBLIC_API_PORT
+
+export async function getStaticPaths() {
+ const res = await fetch(`http://localhost:${port}/usernames`)
+ const { usernames } = await res.json()
+
+ ... | true |
Other | vercel | next.js | 64c7571e01d85190ff2ca1225b7b072466a66403.json | Fix edge case in fetch polyfill (#12832)
* Add tests for getStaticPaths
* Fix edge case in fetch polyfill
Fixes #12794
* Correct typo in tests | test/integration/fetch-polyfill/serverless-server.js | @@ -24,6 +24,20 @@ const server = http.createServer((req, res) => {
)
}
+ if (req.url === '/user/a') {
+ return send(
+ req,
+ path.join(__dirname, '.next/serverless/pages/user/a.html')
+ ).pipe(res)
+ }
+
+ if (req.url === '/user/b') {
+ return send(
+ req,
+ path.join(__dirna... | true |
Other | vercel | next.js | 64c7571e01d85190ff2ca1225b7b072466a66403.json | Fix edge case in fetch polyfill (#12832)
* Add tests for getStaticPaths
* Fix edge case in fetch polyfill
Fixes #12794
* Correct typo in tests | test/integration/fetch-polyfill/test/index.test.js | @@ -13,6 +13,7 @@ import {
nextStart,
} from 'next-test-utils'
import clone from 'clone'
+import cheerio from 'cheerio'
jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000 * 60 * 2
const appDir = join(__dirname, '../')
@@ -80,6 +81,16 @@ function runTests() {
expect(json.foo).toBe('bar')
})
+
+ it('includes pol... | true |
Other | vercel | next.js | 59ea81adb95e068f93231b22d0a91a5435be31d6.json | Run all logbox tests (#12825) | test/acceptance/ReactRefreshLogBox.test.js | @@ -606,7 +606,7 @@ test('unterminated JSX', async () => {
await cleanup()
})
-test.only('conversion to class component (1)', async () => {
+test('conversion to class component (1)', async () => {
const [session, cleanup] = await sandbox()
await session.write( | false |
Other | vercel | next.js | 5d201dce9bef7a2ce3746bbe264fb4e71e7abe82.json | docs(ssr-caching): remove link to react-esi example (#12789) | examples/ssr-caching/README.md | @@ -5,8 +5,6 @@ That's what this example demonstrate.
This app uses Next's [custom server and routing](https://github.com/zeit/next.js#custom-server-and-routing) mode. It also uses [express](https://expressjs.com/) to handle routing and page serving.
-Alternatively, see [the example using React ESI](../with-react-... | false |
Other | vercel | next.js | fc08fa0c0e2116a493b85c8226760829a4ded0f0.json | docs: redirect error to the correct url (#12813) | packages/next/export/worker.js | @@ -276,7 +276,7 @@ export default async function({
return results
} catch (error) {
console.error(
- `\nError occurred prerendering page "${path}". Read more: https://err.sh/next.js/prerender-error:\n` +
+ `\nError occurred prerendering page "${path}". Read more: https://err.sh/next.js/prerender... | false |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | package.json | @@ -77,6 +77,8 @@
"get-port": "5.1.1",
"isomorphic-unfetch": "3.0.0",
"jest-cli": "24.9.0",
+ "ky": "0.19.1",
+ "ky-universal": "0.6.0",
"lerna": "3.14.1",
"lint-staged": "10.1.7",
"moment": "^2.24.0", | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | packages/next/build/webpack/loaders/next-serverless-loader.ts | @@ -139,11 +139,8 @@ const nextServerlessLoader: loader.Loader = function() {
return `
import initServer from 'next-plugin-loader?middleware=on-init-server!'
import onError from 'next-plugin-loader?middleware=on-error-server!'
- import fetch from 'next/dist/compiled/node-fetch'
-
- if(!... | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | packages/next/export/worker.js | @@ -9,14 +9,7 @@ import { getRouteMatcher } from '../next-server/lib/router/utils/route-matcher'
import { getRouteRegex } from '../next-server/lib/router/utils/route-regex'
import { normalizePagePath } from '../next-server/server/normalize-page-path'
import { SERVER_PROPS_EXPORT_ERROR } from '../lib/constants'
-impo... | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | packages/next/next-server/server/next-server.ts | @@ -64,14 +64,7 @@ import { execOnce } from '../lib/utils'
import { isBlockedPage } from './utils'
import { compile as compilePathToRegex } from 'next/dist/compiled/path-to-regexp'
import { loadEnvConfig } from '../../lib/load-env-config'
-import fetch from 'next/dist/compiled/node-fetch'
-
-// @ts-ignore fetch exis... | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | packages/next/next-server/server/node-polyfill-fetch.js | @@ -0,0 +1,13 @@
+import fetch, {
+ Headers,
+ Request,
+ Response,
+} from 'next/dist/compiled/node-fetch'
+
+// Polyfill fetch() in the Node.js environment
+if (!global.fetch) {
+ global.fetch = fetch
+ global.Headers = Headers
+ global.Request = Request
+ global.Response = Response
+} | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | packages/next/server/static-paths-worker.ts | @@ -1,13 +1,6 @@
import { buildStaticPaths } from '../build/utils'
import { loadComponents } from '../next-server/server/load-components'
-import fetch from 'next/dist/compiled/node-fetch'
-
-// @ts-ignore fetch exists globally
-if (!global.fetch) {
- // Polyfill fetch() in the Node.js environment
- // @ts-ignore f... | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | test/integration/fetch-polyfill-ky-universal/api-server.js | @@ -0,0 +1,14 @@
+const http = require('http')
+const port = process.env.PORT || 3000
+
+const server = new http.Server(async (req, res) => {
+ res.end(JSON.stringify({ foo: 'bar' }))
+})
+
+server.listen(port, err => {
+ if (err) {
+ throw err
+ }
+
+ console.log(`> Ready on http://localhost:${port}`)
+}) | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | test/integration/fetch-polyfill-ky-universal/api/api-route.js | @@ -0,0 +1,7 @@
+import ky from 'ky-universal'
+
+export default async function ApiRoute(_req, res) {
+ const port = process.env.NEXT_PUBLIC_API_PORT
+ const json = await ky.get(`http://localhost:${port}/`).json()
+ res.json(json)
+} | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | test/integration/fetch-polyfill-ky-universal/pages/getinitialprops.js | @@ -0,0 +1,13 @@
+import ky from 'ky-universal'
+
+export default function SSRPageWithGetInitialProps({ data }) {
+ return <div>{data.foo}</div>
+}
+
+SSRPageWithGetInitialProps.getInitialProps = async () => {
+ const port = process.env.NEXT_PUBLIC_API_PORT
+ const json = await ky.get(`http://localhost:${port}/`).js... | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | test/integration/fetch-polyfill-ky-universal/pages/ssr.js | @@ -0,0 +1,15 @@
+import ky from 'ky-universal'
+
+export default function SSRPage({ data }) {
+ return <div>{data.foo}</div>
+}
+
+export async function getServerSideProps() {
+ const port = process.env.NEXT_PUBLIC_API_PORT
+ const json = await ky.get(`http://localhost:${port}/`).json()
+ return {
+ props: {
+ ... | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | test/integration/fetch-polyfill-ky-universal/pages/static.js | @@ -0,0 +1,15 @@
+import ky from 'ky-universal'
+
+export default function StaticPage({ data }) {
+ return <div>{data.foo}</div>
+}
+
+export async function getStaticProps() {
+ const port = process.env.NEXT_PUBLIC_API_PORT
+ const json = await ky.get(`http://localhost:${port}/`).json()
+ return {
+ props: {
+ ... | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | test/integration/fetch-polyfill-ky-universal/serverless-server.js | @@ -0,0 +1,44 @@
+// This is not the correct way to implement the Next.js serverless target for production traffic
+// It is only used for testing cases of rendering specific pages in the integration test suite
+
+const path = require('path')
+const http = require('http')
+const send = require('send')
+
+const server =... | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | test/integration/fetch-polyfill-ky-universal/test/index.test.js | @@ -0,0 +1,138 @@
+/* eslint-env jest */
+/* global jasmine */
+import fs from 'fs-extra'
+import { join } from 'path'
+import {
+ killApp,
+ findPort,
+ launchApp,
+ initNextServerScript,
+ renderViaHTTP,
+ nextBuild,
+ nextStart,
+} from 'next-test-utils'
+import clone from 'clone'
+
+jasmine.DEFAULT_TIMEOUT_I... | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | test/integration/fetch-polyfill/serverless-server.js | @@ -1,3 +1,6 @@
+// This is not the correct way to implement the Next.js serverless target for production traffic
+// It is only used for testing cases of rendering specific pages in the integration test suite
+
const path = require('path')
const http = require('http')
const send = require('send') | true |
Other | vercel | next.js | 93c81494c64d193bbae017549defd646e7f0e0da.json | Make fetch polyfill work with ky-universal (#12804) | yarn.lock | @@ -3353,7 +3353,7 @@ abbrev@1:
resolved "https://registry.yarnpkg.com/abbrev/-/abbrev-1.1.1.tgz#f8f2c887ad10bf67f634f005b6987fed3179aac8"
integrity sha512-nne9/IiQ/hzIhY6pdDnbBtz7DjPTKrY00P/zvPSm5pOFkl6xuGrGnXn/VtTNNfNtAfZ9/1RtehkszU9qcTii0Q==
-abort-controller@3.0.0:
+abort-controller@3.0.0, abort-controller@... | true |
Other | vercel | next.js | 7cca2b0d93bf6d806d7c6ca3faf21bf7548acc42.json | Add test for API route with fetch polyfill (#12680) | test/integration/fetch-polyfill/pages/api/api-route.js | @@ -0,0 +1,6 @@
+export default async function ApiRoute(_req, res) {
+ const port = process.env.NEXT_PUBLIC_API_PORT
+ const response = await fetch(`http://localhost:${port}/`)
+ const json = await response.json()
+ res.json(json)
+} | true |
Other | vercel | next.js | 7cca2b0d93bf6d806d7c6ca3faf21bf7548acc42.json | Add test for API route with fetch polyfill (#12680) | test/integration/fetch-polyfill/serverless-server.js | @@ -14,6 +14,13 @@ const server = http.createServer((req, res) => {
)
}
+ if (req.url === '/api/api-route') {
+ return require('./.next/serverless/pages/api/api-route.js').default(
+ req,
+ res
+ )
+ }
+
if (req.url === '/static') {
return send(
req, | true |
Other | vercel | next.js | 7cca2b0d93bf6d806d7c6ca3faf21bf7548acc42.json | Add test for API route with fetch polyfill (#12680) | test/integration/fetch-polyfill/test/index.test.js | @@ -7,6 +7,7 @@ import {
findPort,
launchApp,
initNextServerScript,
+ fetchViaHTTP,
renderViaHTTP,
nextBuild,
nextStart,
@@ -72,9 +73,16 @@ function runTests() {
const html = await renderViaHTTP(appPort, '/getinitialprops')
expect(html).toMatch(/bar/)
})
+
+ it('includes polyfilled fetc... | true |
Other | vercel | next.js | 29b110009a25da70ddaa488d3c964842c4f693ee.json | fix logout in with-iron-session example (#12704) | examples/with-iron-session/pages/api/logout.js | @@ -2,6 +2,5 @@ import withSession from '../../lib/session'
export default withSession(async (req, res) => {
req.session.destroy()
- await req.session.save()
res.json({ isLoggedIn: false })
}) | false |
Other | vercel | next.js | 653098d397c86ed51f702cfb2ac8b00d1d101348.json | Use @/ to show module alias instead of @ prefixed (#12600)
* docs: controversial '@' prefix aliases should not be used
* Update docs/advanced-features/module-path-aliases.md
Co-authored-by: Joe Haddad <timer150@gmail.com>
* Update docs/advanced-features/module-path-aliases.md
Co-authored-by: Joe Haddad <ti... | docs/advanced-features/module-path-aliases.md | @@ -58,7 +58,7 @@ An example of this configuration:
"compilerOptions": {
"baseUrl": ".",
"paths": {
- "@components/*": ["components/*"]
+ "@/components/*": ["components/*"]
}
}
}
@@ -73,7 +73,7 @@ export default function Button() {
```jsx
// pages/index.js
-import Button from '@compo... | false |
Other | vercel | next.js | e3aeb2f768e683103f3dbbbbb60dc2af61d9700f.json | Update code sample in performance measurement docs (#12690) | docs/advanced-features/measuring-performance.md | @@ -11,13 +11,16 @@ To measure any of the supported metrics, you will need to create a [custom
App](/docs/advanced-features/custom-app.md) component and define a `reportWebVitals` function:
```js
-import App from 'next/app'
-
-export default MyApp
-
+// pages/_app.js
export function reportWebVitals(metric) {
co... | false |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | packages/next/client/dev/error-overlay/hot-dev-client.js | @@ -94,6 +94,9 @@ export default function connect(options) {
subscribeToHmrEvent(handler) {
customHmrEventHandler = handler
},
+ onUnrecoverableError() {
+ hadRuntimeError = true
+ },
reportRuntimeError(err) {
if (process.env.__NEXT_FAST_REFRESH) {
return | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | packages/next/client/index.js | @@ -96,7 +96,7 @@ class Container extends React.Component {
(isFallback ||
(data.nextExport &&
(isDynamicRoute(router.pathname) || location.search)) ||
- (props.__N_SSG && location.search))
+ (props && props.__N_SSG && location.search))
) {
// update query on mount f... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | packages/next/next-server/server/config.ts | @@ -52,7 +52,7 @@ const defaultConfig: { [key: string]: any } = {
basePath: '',
sassOptions: {},
pageEnv: false,
- reactRefresh: false,
+ reactRefresh: true,
},
future: {
excludeDefaultMomentLocales: false, | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | packages/next/pages/_document.tsx | @@ -1,11 +1,11 @@
import PropTypes from 'prop-types'
import React, { Component } from 'react'
import flush from 'styled-jsx/server'
-
import {
+ AMP_RENDER_TARGET,
CLIENT_STATIC_FILES_RUNTIME_AMP,
+ CLIENT_STATIC_FILES_RUNTIME_REACT_REFRESH,
CLIENT_STATIC_FILES_RUNTIME_WEBPACK,
- AMP_RENDER_TARGET,
} from... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | packages/react-refresh-utils/internal/ReactRefreshModule.runtime.ts | @@ -20,7 +20,11 @@ export default function() {
// Legacy CSS implementations will `eval` browser code in a Node.js context
// to extract CSS. For backwards compatibility, we need to check we're in a
// browser context before continuing.
- if (typeof self !== 'undefined') {
+ if (
+ typeof self !== 'undefi... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | packages/react-refresh-utils/internal/helpers.ts | @@ -43,6 +43,10 @@ declare const module: {
}
}
+function isSafeExport(key: string): boolean {
+ return key === '__esModule' || key === '__N_SSG' || key === '__N_SSP'
+}
+
function registerExportsForReactRefresh(
moduleExports: unknown,
moduleID: string
@@ -54,6 +58,9 @@ function registerExportsForReactRef... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | test/integration/amphtml/test/index.test.js | @@ -392,7 +392,7 @@ describe('AMP Usage', () => {
const html = await renderViaHTTP(dynamicAppPort, '/only-amp')
const $ = cheerio.load(html)
expect($('html').attr('data-ampdevmode')).toBe('')
- expect($('script[data-ampdevmode]').length).toBe(3)
+ expect($('script[data-ampdevmode]').lengt... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | test/integration/basic/test/error-recovery.js | @@ -1,13 +1,15 @@
/* eslint-env jest */
-import webdriver from 'next-webdriver'
-import { join } from 'path'
import {
check,
File,
- waitFor,
- getReactErrorOverlayContent,
getBrowserBodyText,
+ getRedboxHeader,
+ getRedboxSource,
+ hasRedbox,
+ waitFor,
} from 'next-test-utils'
+import webdriver from... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | test/integration/client-navigation/test/index.test.js | @@ -1,17 +1,19 @@
/* eslint-env jest */
/* global jasmine */
-import { join } from 'path'
-import webdriver from 'next-webdriver'
-import renderingSuite from './rendering'
import {
- waitFor,
+ fetchViaHTTP,
findPort,
+ getRedboxSource,
+ hasRedbox,
killApp,
+ getRedboxHeader,
launchApp,
- fetchViaHTT... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | test/integration/client-navigation/test/rendering.js | @@ -204,9 +204,9 @@ export default function(render, fetch) {
test('getInitialProps circular structure', async () => {
const $ = await get$('/circular-json-error')
const expectedErrorMessage =
- 'Circular structure in "getInitialProps" result of page "/circular-json-error".'
+ 'Circular ... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | test/integration/getserversideprops/test/index.test.js | @@ -8,6 +8,7 @@ import {
fetchViaHTTP,
findPort,
getBrowserBodyText,
+ getRedboxHeader,
killApp,
launchApp,
nextBuild,
@@ -471,7 +472,7 @@ const runTests = (dev = false) => {
await browser.elementByCss('#non-json').click()
await check(
- () => getBrowserBodyText(browser),
+ ... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | test/integration/invalid-href/test/index.test.js | @@ -1,16 +1,17 @@
/* eslint-env jest */
/* global jasmine */
-import { join } from 'path'
-import webdriver from 'next-webdriver'
import {
findPort,
- launchApp,
+ getRedboxHeader,
+ hasRedbox,
killApp,
- nextStart,
+ launchApp,
nextBuild,
- getReactErrorOverlayContent,
+ nextStart,
waitFor,
} fr... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | test/integration/prerender/test/index.test.js | @@ -9,7 +9,8 @@ import {
File,
findPort,
getBrowserBodyText,
- getReactErrorOverlayContent,
+ getRedboxHeader,
+ hasRedbox,
initNextServerScript,
killApp,
launchApp,
@@ -569,7 +570,8 @@ const runTests = (dev = false, looseMode = false) => {
// we need to reload the page to trigger getStaticP... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | test/integration/typescript-hmr/test/index.test.js | @@ -1,16 +1,16 @@
/* eslint-env jest */
/* global jasmine */
import fs from 'fs-extra'
-import { join } from 'path'
-import webdriver from 'next-webdriver'
import {
- findPort,
- launchApp,
- killApp,
check,
+ findPort,
getBrowserBodyText,
- getReactErrorOverlayContent,
+ getRedboxHeader,
+ killApp,
+ ... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | test/integration/typescript-ignore-errors/test/index.test.js | @@ -16,7 +16,9 @@ const appDir = join(__dirname, '..')
const nextConfigFile = new File(join(appDir, 'next.config.js'))
describe('TypeScript with error handling options', () => {
- for (const ignoreDevErrors of [false, true]) {
+ // Dev can no longer show errors (for now), logbox will cover this in the
+ // futur... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | test/integration/typescript/test/index.test.js | @@ -51,7 +51,8 @@ describe('TypeScript Features', () => {
expect($('#imported-value').text()).toBe('OK')
})
- it('should report type checking to stdout', async () => {
+ // old behavior:
+ it.skip('should report type checking to stdout', async () => {
expect(output).toContain('waiting for ... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | test/integration/with-router/test/index.test.js | @@ -1,17 +1,18 @@
/* eslint-env jest */
/* global jasmine */
-import webdriver from 'next-webdriver'
-import { join } from 'path'
import {
- getReactErrorOverlayContent,
- nextServer,
- launchApp,
findPort,
+ getRedboxHeader,
+ hasRedbox,
killApp,
+ launchApp,
nextBuild,
+ nextServer,
startApp,
... | true |
Other | vercel | next.js | ae1daea355475d63ddaae6b2e8bea8370d6b91a4.json | Enable Fast Refresh by Default (#12640) | test/lib/next-test-utils.js | @@ -394,36 +394,65 @@ export class File {
}
}
-// react-error-overlay uses an iframe so we have to read the contents from the frame
-export async function getReactErrorOverlayContent(browser) {
- let found = false
- setTimeout(() => {
- if (found) {
- return
+export async function evaluate(browser, inpu... | true |
Other | vercel | next.js | ce830af202be415e943876d74a743ceaec6549ce.json | chore(create-next-app): add missing types (#12691) | packages/create-next-app/create-app.ts | @@ -29,7 +29,7 @@ export async function createApp({
useNpm: boolean
example?: string
examplePath?: string
-}) {
+}): Promise<void> {
let repoInfo: RepoInfo | undefined
if (example) { | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.