language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/external-assets/pages/about/history.js | @@ -0,0 +1,19 @@
+import firebase from 'firebase/app'
+import 'firebase/firestore'
+
+if (!firebase.apps.length) {
+ firebase.initializeApp({ projectId: 'noop' })
+}
+
+const store = firebase.firestore()
+
+const Comp = ({ results }) => {
+ return <div>Hello Firebase: {results}</div>
+}
+
+Comp.getInitialProps = asyn... | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/external-assets/test/index.test.js | @@ -0,0 +1,29 @@
+/* eslint-env jest */
+/* global jasmine */
+import { join } from 'path'
+import {
+ killApp,
+ findPort,
+ nextBuild,
+ nextStart,
+ renderViaHTTP
+} from 'next-test-utils'
+
+const appDir = join(__dirname, '../')
+let appPort
+let app
+jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000 * 60 * 5
+
+describ... | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/serverless-trace/components/hello.js | @@ -0,0 +1 @@
+export default () => <h1>Hello!</h1> | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/serverless-trace/next.config.js | @@ -0,0 +1,12 @@
+module.exports = {
+ target: 'experimental-serverless-trace',
+ onDemandEntries: {
+ // Make sure entries are not getting disposed.
+ maxInactiveAge: 1000 * 60 * 60
+ },
+ experimental: {
+ publicDirectory: true
+ },
+ // make sure error isn't thrown from empty publicRuntimeConfig
+ pu... | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/serverless-trace/pages/abc.js | @@ -0,0 +1 @@
+export default () => <div>test</div> | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/serverless-trace/pages/api/hello.js | @@ -0,0 +1,3 @@
+export default (req, res) => {
+ res.send('hello world')
+} | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/serverless-trace/pages/api/posts/[id].js | @@ -0,0 +1,3 @@
+export default (req, res) => {
+ res.json({ post: req.query.id })
+} | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/serverless-trace/pages/dynamic-two.js | @@ -0,0 +1,9 @@
+import dynamic from 'next/dynamic'
+
+const Hello = dynamic(() => import('../components/hello'))
+
+export default () => (
+ <div>
+ <Hello />
+ </div>
+) | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/serverless-trace/pages/dynamic.js | @@ -0,0 +1,9 @@
+import dynamic from 'next/dynamic'
+
+const Hello = dynamic(() => import('../components/hello'))
+
+export default () => (
+ <div>
+ <Hello />
+ </div>
+) | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/serverless-trace/pages/fetch.js | @@ -0,0 +1,29 @@
+import fetch from 'isomorphic-unfetch'
+import React from 'react'
+
+export default class extends React.Component {
+ static async getInitialProps () {
+ try {
+ const res = await fetch('')
+ const text = await res.text()
+ console.log(text)
+ return { text }
+ } catch (err)... | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/serverless-trace/pages/index.js | @@ -0,0 +1,11 @@
+import Link from 'next/link'
+export default () => {
+ return (
+ <div>
+ Hello World
+ <Link href='/fetch'>
+ <a id='fetchlink'>fetch page</a>
+ </Link>
+ </div>
+ )
+} | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/serverless-trace/pages/some-amp.js | @@ -0,0 +1,2 @@
+export default () => `Hi Im an AMP page!`
+export const config = { amp: 'hybrid' } | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/serverless-trace/public/hello.txt | @@ -0,0 +1 @@
+hello world | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | test/integration/serverless-trace/test/index.test.js | @@ -0,0 +1,149 @@
+/* eslint-env jest */
+/* global jasmine */
+import webdriver from 'next-webdriver'
+import { join } from 'path'
+import { existsSync } from 'fs'
+import {
+ killApp,
+ findPort,
+ nextBuild,
+ nextStart,
+ fetchViaHTTP,
+ renderViaHTTP
+} from 'next-test-utils'
+import fetch from 'node-fetch'
... | true |
Other | vercel | next.js | b31c29673019da75fa8beec097282c1446c8d197.json | Experimental: Serverless Trace target (#8246)
* Experimental: Serverless Trace target
The Serverless Trace target produces Serverless-handler wrapped entrypoints, but does not bundle all of `node_modules`.
This behavior increases bundling performance to be more akin to `target: 'server'`.
This mode is expected ... | yarn.lock | @@ -782,6 +782,177 @@
exec-sh "^0.3.2"
minimist "^1.2.0"
+"@firebase/app-types@0.4.3":
+ version "0.4.3"
+ resolved "https://registry.yarnpkg.com/@firebase/app-types/-/app-types-0.4.3.tgz#80d2b6e5ee43ac99892329ab02301ee7ed82da45"
+ integrity sha512-VU5c+ZjejvefLVH4cjiX3Hy1w9HYMv7TtZ1tF9ZmOqT4DSIU1a3VISWo... | true |
Other | vercel | next.js | 91b06c752a223d17c69b6fc7d145954ac08ec085.json | Add Create Next App instructions (#8224) | packages/create-next-app/README.md | @@ -0,0 +1,8 @@
+# create-next-app
+
+This package includes the global command for creating [Next.js](https://github.com/zeit/next.js) applications.
+
+Please refer to its documentation:
+
+- [Setup](https://nextjs.org/docs#setup) – How to create a new Next.js application.
+- [Documentation](https://nextjs.org/docs) – ... | true |
Other | vercel | next.js | 91b06c752a223d17c69b6fc7d145954ac08ec085.json | Add Create Next App instructions (#8224) | packages/next/README.md | @@ -110,7 +110,17 @@
### Setup
-Install it:
+#### Quick Start
+
+```bash
+npx create-next-app
+```
+
+_([npx](https://medium.com/@maybekatz/introducing-npx-an-npm-package-runner-55f7d4bd282b) comes with npm 5.2+ and higher, see [instructions for older npm versions](https://gist.github.com/timer/833d9946fa8a05ba855... | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | packages/next-server/lib/router/router.ts | @@ -402,10 +402,6 @@ export default class Router implements BaseRouter {
return new Promise((resolve, reject) => {
const ctx = { pathname, query, asPath: as }
this.getInitialProps(Component, ctx).then(props => {
- // if data is inlined during prerender it is a string
- ... | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | packages/next-server/server/render.tsx | @@ -148,8 +148,6 @@ type RenderOpts = {
App: AppType
ErrorDebug?: React.ComponentType<{ error: Error }>
ampValidator?: (html: string, pathname: string) => Promise<void>
- isPrerender?: boolean
- pageData?: any
}
function renderDocument(
@@ -257,7 +255,7 @@ export async function renderToHTML(
} = rende... | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | packages/next-server/types/index.d.ts | @@ -10,5 +10,4 @@ export type PageConfig = {
*/
bodyParser?: { sizeLimit?: number | string } | false
}
- experimentalPrerender?: boolean | 'inline' | 'legacy'
} | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | packages/next/build/babel/plugins/next-page-config.ts | @@ -3,8 +3,7 @@ import { NodePath } from '@babel/traverse'
import * as BabelTypes from '@babel/types'
import { PageConfig } from 'next-server/types'
-const configKeys = new Set(['amp', 'experimentalPrerender'])
-export const inlineGipIdentifier = '__NEXT_GIP_INLINE__'
+const configKeys = new Set(['amp'])
export co... | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | packages/next/build/index.ts | @@ -361,10 +361,7 @@ export default async function build(dir: string, conf = null): Promise<void> {
})
staticCheckSema.release()
- if (
- (result.static && customAppGetInitialProps === false) ||
- result.prerender
- ) {
+ if (result.static && cust... | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | packages/next/build/utils.ts | @@ -265,7 +265,7 @@ export async function getPageSizeInKb(
export function isPageStatic(
serverBundle: string,
runtimeEnvConfig: any
-): { static?: boolean; prerender?: boolean } {
+): { static?: boolean } {
try {
require('next-server/config').setConfig(runtimeEnvConfig)
const mod = require(serverBu... | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | packages/next/export/worker.js | @@ -2,19 +2,17 @@ import mkdirpModule from 'mkdirp'
import { promisify } from 'util'
import { extname, join, dirname, sep } from 'path'
import { renderToHTML } from 'next-server/dist/server/render'
-import { writeFile, access, readFile } from 'fs'
+import { writeFile, access } from 'fs'
import { Sema } from 'async-... | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | test/integration/prerender/next.config.js | @@ -1,5 +0,0 @@
-module.exports = {
- experimental: {
- autoExport: true
- }
-} | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | test/integration/prerender/pages/another.js | @@ -1,7 +0,0 @@
-const Page = ({ name }) => <p>Prerender page {name}</p>
-
-Page.getInitialProps = async () => ({ name: 'John Deux' })
-
-export const config = { experimentalPrerender: true }
-
-export default Page | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | test/integration/prerender/pages/index.js | @@ -1 +0,0 @@
-export default () => <p>An autoExported page</p> | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | test/integration/prerender/pages/nested/hello.js | @@ -1,7 +0,0 @@
-export const config = { experimentalPrerender: true }
-
-const Page = ({ title }) => <p>{title}</p>
-
-Page.getInitialProps = async () => ({ title: 'something' })
-
-export default Page | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | test/integration/prerender/pages/nested/old-school.js | @@ -1,5 +0,0 @@
-const Page = () => <p>I'm just an old SSR page</p>
-
-Page.getInitialProps = () => ({})
-
-export default Page | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | test/integration/prerender/pages/old-school.js | @@ -1,5 +0,0 @@
-const Page = () => <p>I'm just an old SSR page</p>
-
-Page.getInitialProps = () => ({})
-
-export default Page | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | test/integration/prerender/test/index.test.js | @@ -1,85 +0,0 @@
-/* eslint-env jest */
-/* global jasmine */
-import fs from 'fs-extra'
-import path from 'path'
-import {
- nextBuild,
- nextStart,
- findPort,
- killApp,
- renderViaHTTP
-} from 'next-test-utils'
-
-jasmine.DEFAULT_TIMEOUT_INTERVAL = 1000 * 60 * 3
-
-const appDir = path.join(__dirname, '../')
-l... | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | test/integration/production/pages/something.js | @@ -1,27 +0,0 @@
-import Link from 'next/link'
-
-export const config = {
- experimentalPrerender: 'inline'
-}
-
-const Page = ({ data }) => {
- return (
- <>
- <h3>{data}</h3>
- <Link href='/to-something'>
- <a id='to-something'>Click to to-something</a>
- </Link>
- </>
- )
-}
-
-Page.ge... | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | test/integration/production/pages/to-something.js | @@ -1,30 +0,0 @@
-import React from 'react'
-import Link from 'next/link'
-
-export const config = {
- experimentalPrerender: true
-}
-
-class Page extends React.Component {
- static async getInitialProps () {
- if (typeof window !== 'undefined') {
- throw new Error(`this shouldn't be called`)
- }
- ret... | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | test/integration/production/test/index.test.js | @@ -546,26 +546,6 @@ describe('Production Usage', () => {
}
})
- it('should prerender pages with data correctly', async () => {
- const toSomething = await renderViaHTTP(appPort, '/to-something')
- expect(toSomething).toMatch(/some interesting title/)
-
- const something = await renderViaHTTP(appPor... | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | test/integration/serverless/pages/something.js | @@ -1,27 +0,0 @@
-import Link from 'next/link'
-
-export const config = {
- experimentalPrerender: 'inline'
-}
-
-const Page = ({ data }) => {
- return (
- <>
- <h3>{data}</h3>
- <Link href='/to-something'>
- <a id='to-something'>Click to to-something</a>
- </Link>
- </>
- )
-}
-
-Page.ge... | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | test/integration/serverless/pages/to-something.js | @@ -1,30 +0,0 @@
-import React from 'react'
-import Link from 'next/link'
-
-export const config = {
- experimentalPrerender: true
-}
-
-class Page extends React.Component {
- static async getInitialProps () {
- if (typeof window !== 'undefined') {
- throw new Error(`this shouldn't be called`)
- }
- ret... | true |
Other | vercel | next.js | 2ab300dd81f1d2750c4127e2a2f990271f28c509.json | Remove Old Prerender Implementation (#8218)
* Remove Prerender Implementation
* Fix PageConfig
* Fix next server
* Fix two more files
* Fix render
* Fix render
* Try to fix up page config
* Correct build file
* Switch back static checker
* Turn stuff back
* Add missing newline
* Revert... | test/integration/serverless/test/index.test.js | @@ -114,26 +114,6 @@ describe('Serverless', () => {
}
})
- it('should prerender pages with data correctly', async () => {
- const toSomething = await renderViaHTTP(appPort, '/to-something')
- expect(toSomething).toMatch(/some interesting title/)
-
- const something = await renderViaHTTP(appPort, '/s... | true |
Other | vercel | next.js | 6468b6c9bf929bb2bd8177b491d642ebfc7e5f03.json | Remove useless code block in docs | packages/next/README.md | @@ -2733,7 +2733,3 @@ Please see our [contributing.md](/contributing.md).
- Tony Kovanen ([@tonykovanen](https://twitter.com/tonykovanen)) – [ZEIT](https://zeit.co)
- Guillermo Rauch ([@rauchg](https://twitter.com/rauchg)) – [ZEIT](https://zeit.co)
- Dan Zajdband ([@impronunciable](https://twitter.com/impronunciable... | false |
Other | vercel | next.js | e7d96f77bd29ac06a7d57ca289b00c291ff2b17d.json | Add test for dynamic routing/webpack HMR bug (#8061)
* Add failing test for dynamic routing/webpack HMR bug
* Remove un-used args from onDemandEntryHandler
* update to latest webpack with escaping | packages/next/package.json | @@ -98,7 +98,7 @@
"unfetch": "4.1.0",
"url": "0.11.0",
"watchpack": "2.0.0-beta.5",
- "webpack": "4.38.0",
+ "webpack": "4.39.0",
"webpack-dev-middleware": "3.7.0",
"webpack-hot-middleware": "2.25.0",
"webpack-sources": "1.3.0", | true |
Other | vercel | next.js | e7d96f77bd29ac06a7d57ca289b00c291ff2b17d.json | Add test for dynamic routing/webpack HMR bug (#8061)
* Add failing test for dynamic routing/webpack HMR bug
* Remove un-used args from onDemandEntryHandler
* update to latest webpack with escaping | packages/next/server/on-demand-entry-handler.js | @@ -29,17 +29,7 @@ function addEntry (compilation, context, name, entry) {
export default function onDemandEntryHandler (
devMiddleware,
multiCompiler,
- {
- buildId,
- dir,
- distDir,
- reload,
- pageExtensions,
- maxInactiveAge,
- pagesBufferLength,
- publicRuntimeConfig,
- serverRu... | true |
Other | vercel | next.js | e7d96f77bd29ac06a7d57ca289b00c291ff2b17d.json | Add test for dynamic routing/webpack HMR bug (#8061)
* Add failing test for dynamic routing/webpack HMR bug
* Remove un-used args from onDemandEntryHandler
* update to latest webpack with escaping | test/integration/dynamic-routing/pages/[name]/[comment].js | @@ -7,9 +7,9 @@ const $comment = ({ gipQuery }) => {
return (
<>
<p>
- I am {query.comment} on {query.post}
+ I am {query.comment} on {query.name}
</p>
- <span>gip {gipQuery && gipQuery.post}</span>
+ <span>gip {gipQuery && gipQuery.name}</span>
</>
)
} | true |
Other | vercel | next.js | e7d96f77bd29ac06a7d57ca289b00c291ff2b17d.json | Add test for dynamic routing/webpack HMR bug (#8061)
* Add failing test for dynamic routing/webpack HMR bug
* Remove un-used args from onDemandEntryHandler
* update to latest webpack with escaping | test/integration/dynamic-routing/pages/[name]/comments.js | @@ -3,7 +3,7 @@ import { useRouter } from 'next/router'
const Page = () => {
const router = useRouter()
const { query } = router
- return <p>Show comments for {query.post} here</p>
+ return <p>Show comments for {query.name} here</p>
}
Page.getInitialProps = () => ({}) | true |
Other | vercel | next.js | e7d96f77bd29ac06a7d57ca289b00c291ff2b17d.json | Add test for dynamic routing/webpack HMR bug (#8061)
* Add failing test for dynamic routing/webpack HMR bug
* Remove un-used args from onDemandEntryHandler
* update to latest webpack with escaping | test/integration/dynamic-routing/pages/[name]/index.js | @@ -3,7 +3,7 @@ import { useRouter } from 'next/router'
const Page = () => {
const router = useRouter()
const { query } = router
- return <p>This is {query.post}</p>
+ return <p>This is {query.name}</p>
}
Page.getInitialProps = () => ({}) | true |
Other | vercel | next.js | e7d96f77bd29ac06a7d57ca289b00c291ff2b17d.json | Add test for dynamic routing/webpack HMR bug (#8061)
* Add failing test for dynamic routing/webpack HMR bug
* Remove un-used args from onDemandEntryHandler
* update to latest webpack with escaping | test/integration/dynamic-routing/pages/blog/[name]/comment/[id].js | @@ -2,12 +2,12 @@ import { useRouter } from 'next/router'
const Page = () => {
const router = useRouter()
- const { post, id } = router.query
+ const { name, id } = router.query
return (
<>
<p>
- Blog post {post} comment {id || '(all)'}
+ Blog post {name} comment {id || '(all)'}
... | true |
Other | vercel | next.js | e7d96f77bd29ac06a7d57ca289b00c291ff2b17d.json | Add test for dynamic routing/webpack HMR bug (#8061)
* Add failing test for dynamic routing/webpack HMR bug
* Remove un-used args from onDemandEntryHandler
* update to latest webpack with escaping | test/integration/dynamic-routing/test/index.test.js | @@ -22,7 +22,7 @@ let appPort
let server
const appDir = join(__dirname, '../')
-function runTests () {
+function runTests (dev) {
it('should render normal route', async () => {
const html = await renderViaHTTP(appPort, '/')
expect(html).toMatch(/my blog/i)
@@ -187,6 +187,29 @@ function runTests () {
... | true |
Other | vercel | next.js | e7d96f77bd29ac06a7d57ca289b00c291ff2b17d.json | Add test for dynamic routing/webpack HMR bug (#8061)
* Add failing test for dynamic routing/webpack HMR bug
* Remove un-used args from onDemandEntryHandler
* update to latest webpack with escaping | yarn.lock | @@ -2403,10 +2403,10 @@ acorn@^6.0.1, acorn@^6.0.2, acorn@^6.0.7:
resolved "https://registry.yarnpkg.com/acorn/-/acorn-6.1.1.tgz#7d25ae05bb8ad1f9b699108e1094ecd7884adc1f"
integrity sha512-jPTiwtOxaHNaAPg/dmrJ/beuzLRnXtB0kQPQ8JpotKJgTB6rX6c8mlf315941pyjBSaPg8NHXS9fhP4u17DpGA==
-acorn@^6.2.0:
- version "6.2.0"
-... | true |
Other | vercel | next.js | ac31f1636ee15daad983d6d801a1e35764c7fe79.json | Add some notes about Now deployment (#8205) | UPGRADING.md | @@ -1,5 +1,15 @@
# Migrating from v8 to v9
+## Preamble
+
+#### Production Deployment on ZEIT Now v2
+
+If you previously configured `routes` in your `now.json` file for dynamic routes, these rules can be removed when leveraging Next.js 9's new [Dynamic Routing feature](https://github.com/zeit/next.js#dynamic-routin... | true |
Other | vercel | next.js | ac31f1636ee15daad983d6d801a1e35764c7fe79.json | Add some notes about Now deployment (#8205) | packages/next/README.md | @@ -340,6 +340,11 @@ For example, `/post/abc?pid=bcd` will have the `query` object: `{ pid: 'abc' }`.
> After hydration, Next.js will trigger an update to your application to provide the route parameters in the `query` object.
> If your application cannot tolerate this behavior, you can opt-out of static optimization... | true |
Other | vercel | next.js | 3f2027d58376bb9bb0db069603b50fae2619a4c9.json | Update TypeScript Instructions (#8200)
* Update TypeScript Instructions
* next dev => npm run dev
* Break line | packages/next/README.md | @@ -318,12 +318,14 @@ As `href` is a filesystem path, it shouldn't change at runtime, instead, you wil
dynamically according to your needs. Here's an example to create a list of links:
```jsx
-const pids = ['id1', 'id2', 'id3'];
-{pids.map(pid => (
- <Link href="/post/[pid]" as={`/post/${pid}`}>
- <a>Post {pid}... | false |
Other | vercel | next.js | dc9e2708984bc6bc7e87724fb5193e7f788c89a3.json | Update examples for Apollo with AppTree (#8180)
* Update examples for Apollo with AppTree
* Fix apolloClient being overwritten when rendering AppTree | examples/with-apollo-auth/lib/withApollo.js | @@ -19,8 +19,7 @@ export default App => {
static async getInitialProps (ctx) {
const {
- Component,
- router,
+ AppTree,
ctx: { req, res }
} = ctx
const apollo = initApollo(
@@ -48,14 +47,7 @@ export default App => {
// and extract the resulting data
... | true |
Other | vercel | next.js | dc9e2708984bc6bc7e87724fb5193e7f788c89a3.json | Update examples for Apollo with AppTree (#8180)
* Update examples for Apollo with AppTree
* Fix apolloClient being overwritten when rendering AppTree | examples/with-apollo/lib/with-apollo-client.js | @@ -7,7 +7,7 @@ export default App => {
return class Apollo extends React.Component {
static displayName = 'withApollo(App)'
static async getInitialProps (ctx) {
- const { Component, router } = ctx
+ const { AppTree } = ctx
let appProps = {}
if (App.getInitialProps) {
@@ -20,14 +2... | true |
Other | vercel | next.js | 6c2534362e3e77830be9af2ace9b72b008eae947.json | Fix typo within blog-starter example (#8182) | examples/blog-starter/pages/posts/syntax-highlighting.mdx | @@ -4,7 +4,7 @@ import BlogPost from '../../components/layouts/blog-post'
export const meta = {
published: true,
publishedAt: '2018-05-19',
- title: 'Sintax highlighting',
+ title: 'Syntax highlighting',
summary:
'Here are some code snippets to show you how syntax highlighting works',
image: '/stati... | false |
Other | vercel | next.js | b8aee7af77288554d36841148da2f0f65416364a.json | fix: Add error message for duplicate route param name (#8047)
* Add error message for duplicate slug name within a dynamic path
* Update based on feedback
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
* WIP - committed with no-verify - progress
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
* Rem... | packages/next-server/lib/router/utils/sorted-routes.ts | @@ -3,7 +3,7 @@ class UrlNode {
children: Map<string, UrlNode> = new Map()
slugName: string | null = null
- get hasSlug() {
+ hasSlug() {
return this.slugName != null
}
@@ -17,15 +17,15 @@ class UrlNode {
private _smoosh(prefix: string = '/'): string[] {
const childrenPaths = [...this.chil... | true |
Other | vercel | next.js | b8aee7af77288554d36841148da2f0f65416364a.json | fix: Add error message for duplicate route param name (#8047)
* Add error message for duplicate slug name within a dynamic path
* Update based on feedback
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
* WIP - committed with no-verify - progress
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
* Rem... | test/unit/page-route-sorter.test.js | @@ -42,4 +42,10 @@ describe('getSortedRoutes', () => {
])
).toThrowError(/different slug names/)
})
+
+ it('catches reused param names', () => {
+ expect(() =>
+ getSortedRoutes(['/', '/blog', '/blog/[id]/comments/[id]', '/blog/[id]'])
+ ).toThrowError(/the same slug name/)
+ })
}) | true |
Other | vercel | next.js | 72098328cfcc36dcadb0fbc7848f5020c5939213.json | Fix a typo in README (#8177) | packages/next/README.md | @@ -2063,7 +2063,7 @@ module.exports = {
## Automatic Prerendering
-Next.js automatically determines that a page is static (can be prerendered) if it has no has blocking data requirements.
+Next.js automatically determines that a page is static (can be prerendered) if it has no blocking data requirements.
This de... | false |
Other | vercel | next.js | 25fd3f86a3f7b7ad9075563f6f4a5dddf3079f00.json | Update missed lockfile | yarn.lock | @@ -13438,10 +13438,10 @@ webpack-sources@1.3.0, webpack-sources@^1.0.1, webpack-sources@^1.1.0, webpack-s
source-list-map "^2.0.0"
source-map "~0.6.1"
-webpack@4.35.3:
- version "4.35.3"
- resolved "https://registry.yarnpkg.com/webpack/-/webpack-4.35.3.tgz#66bc35ef215a7b75e8790f84d560013ffecf0ca3"
- int... | false |
Other | vercel | next.js | 722d5d7703b4ac3ee0a9f426b3726e7e90dd9096.json | Improve docs for API (#8155)
* Move API types to API section
* Improve wording | packages/next/README.md | @@ -1077,6 +1077,16 @@ export default (req, res) => {
- `res` refers to [NextApiResponse](https://github.com/zeit/next.js/blob/v9.0.0/packages/next-server/lib/utils.ts#L168-L178) which extends [http.ServerResponse](https://nodejs.org/api/http.html#http_class_http_serverresponse)
+For [API routes](#api-routes) ther... | false |
Other | vercel | next.js | c4704fbd9e69c6c5ac14b3ebf6d0f07abc5221f0.json | fix spelling in tsconfig.js of readme.md (#8138) | packages/next/README.md | @@ -2202,7 +2202,7 @@ TypeScript is supported out of the box in Next.js. To get started using it creat
"noFallthroughCasesInSwitch": true, /* Report errors for fallthrough cases in switch statement. */
"noUnusedLocals": true, /* Report errors on unused locals. */
"noUnusedParameters": true, /* Report err... | false |
Other | vercel | next.js | 68e3223cd8f2166d4d15846285142288b0ba5187.json | Improve type definitions (#8117) | packages/next-server/lib/utils.ts | @@ -215,7 +215,7 @@ export async function loadGetInitialProps<
C extends BaseContext,
IP = {},
P = {}
->(Component: NextComponentType<C, IP, P>, ctx: C): Promise<IP | null> {
+>(Component: NextComponentType<C, IP, P>, ctx: C): Promise<IP> {
if (process.env.NODE_ENV !== 'production') {
if (Component.pro... | true |
Other | vercel | next.js | 68e3223cd8f2166d4d15846285142288b0ba5187.json | Improve type definitions (#8117) | packages/next/types/index.d.ts | @@ -38,7 +38,9 @@ declare module 'react' {
* `Page` type, use it as a guide to create `pages`.
*/
export type NextPage<P = {}, IP = P> = {
- (props: P): JSX.Element
+ (props: P): JSX.Element | null
+ defaultProps?: Partial<P>
+ displayName?: string
/**
* Used for initial page load data population. Data ... | true |
Other | vercel | next.js | c02d86ec52b1fca4a4869833c66fd6cf18de138e.json | Docs: Add supported browsers and features (#13741)
[ch1981]
Add the “Supported Browsers and Features” page. The content is taken mostly from the blog posts: [9.4](https://nextjs.org/blog/next-9-4), [9.3](https://nextjs.org/blog/next-9-3), and [9.1.7](https://nextjs.org/blog/next-9-1-7).
- This page is added under “B... | docs/advanced-features/customizing-babel-config.md | @@ -24,15 +24,7 @@ Here's an example `.babelrc` file:
}
```
-The `next/babel` presets includes:
-
-- preset-env
-- preset-react
-- preset-typescript
-- plugin-proposal-class-properties
-- plugin-proposal-object-rest-spread
-- plugin-transform-runtime
-- styled-jsx
+You can [take a look at this file](https://github.... | true |
Other | vercel | next.js | c02d86ec52b1fca4a4869833c66fd6cf18de138e.json | Docs: Add supported browsers and features (#13741)
[ch1981]
Add the “Supported Browsers and Features” page. The content is taken mostly from the blog posts: [9.4](https://nextjs.org/blog/next-9-4), [9.3](https://nextjs.org/blog/next-9-3), and [9.1.7](https://nextjs.org/blog/next-9-1-7).
- This page is added under “B... | docs/basic-features/supported-browsers-features.md | @@ -0,0 +1,47 @@
+---
+description: Browser support and which JavaScript features are supported by Next.js.
+---
+
+# Supported Browsers and Features
+
+Next.js supports **IE11 and all modern browsers** (Edge, Firefox, Chrome, Safari, Opera, et al) with no required configuration.
+
+## Polyfills
+
+We transparently inj... | true |
Other | vercel | next.js | c02d86ec52b1fca4a4869833c66fd6cf18de138e.json | Docs: Add supported browsers and features (#13741)
[ch1981]
Add the “Supported Browsers and Features” page. The content is taken mostly from the blog posts: [9.4](https://nextjs.org/blog/next-9-4), [9.3](https://nextjs.org/blog/next-9-3), and [9.1.7](https://nextjs.org/blog/next-9-1-7).
- This page is added under “B... | docs/faq.md | @@ -4,13 +4,6 @@ description: Get to know more about Next.js with the frequently asked questions.
# Frequently Asked Questions
-<details>
- <summary>What browsers are supported?</summary>
- <p>Next.js supports IE11 and all modern browsers out of the box using <a href="https://new.babeljs.io/docs/en/next/babel-pr... | true |
Other | vercel | next.js | c02d86ec52b1fca4a4869833c66fd6cf18de138e.json | Docs: Add supported browsers and features (#13741)
[ch1981]
Add the “Supported Browsers and Features” page. The content is taken mostly from the blog posts: [9.4](https://nextjs.org/blog/next-9-4), [9.3](https://nextjs.org/blog/next-9-3), and [9.1.7](https://nextjs.org/blog/next-9-1-7).
- This page is added under “B... | docs/manifest.json | @@ -32,6 +32,10 @@
{
"title": "Environment Variables",
"path": "/docs/basic-features/environment-variables.md"
+ },
+ {
+ "title": "Supported Browsers and Features",
+ "path": "/docs/basic-features/supported-browsers-features.md"... | true |
Other | vercel | next.js | c02d86ec52b1fca4a4869833c66fd6cf18de138e.json | Docs: Add supported browsers and features (#13741)
[ch1981]
Add the “Supported Browsers and Features” page. The content is taken mostly from the blog posts: [9.4](https://nextjs.org/blog/next-9-4), [9.3](https://nextjs.org/blog/next-9-3), and [9.1.7](https://nextjs.org/blog/next-9-1-7).
- This page is added under “B... | examples/with-polyfills/README.md | @@ -1,8 +1,6 @@
# Example app with polyfills
-Next.js supports browsers from IE10 to the latest. It adds polyfills as they need. But Next.js cannot add polyfills for code inside NPM modules. So sometimes, you need to add polyfills by yourself.
-
-This how you can do it easily with Next.js's custom webpack config fea... | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | .eslintrc.json | @@ -22,16 +22,6 @@
"import/internal-regex": "^next/"
},
"overrides": [
- {
- "files": ["packages/**"],
- "rules": {
- "no-shadow": ["warn", { "builtinGlobals": false }],
- "import/no-extraneous-dependencies": [
- "error",
- { "devDependencies": false }
- ]
... | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/build/babel/plugins/jsx-pragma.ts | @@ -8,13 +8,13 @@ export default function ({
return {
inherits: require('babel-plugin-syntax-jsx'),
visitor: {
- JSXElement(path, state) {
+ JSXElement(_path, state) {
state.set('jsx', true)
},
// Fragment syntax is still JSX since it compiles to createElement(),
/... | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/build/entries.ts | @@ -62,7 +62,6 @@ type Entrypoints = {
}
export function createEntrypoints(
- dev: boolean,
pages: PagesMapping,
target: 'server' | 'serverless' | 'experimental-serverless-trace',
buildId: string, | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/build/index.ts | @@ -213,7 +213,6 @@ export default async function build(dir: string, conf = null): Promise<void> {
const mappedPages = createPagesMapping(pagePaths, config.pageExtensions)
const entrypoints = createEntrypoints(
- /* dev */ false,
mappedPages,
target,
buildId, | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/build/webpack/loaders/next-data-loader.ts | @@ -1,7 +1,7 @@
import { loader } from 'webpack'
import hash from 'next/dist/compiled/string-hash'
import { basename } from 'path'
-const nextDataLoader: loader.Loader = function (source) {
+const nextDataLoader: loader.Loader = function () {
const filename = this.resourcePath
return `
import {createHook} f... | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/build/webpack/loaders/next-plugin-loader.ts | @@ -12,7 +12,7 @@ export const pluginLoaderOptions: {
plugins: [],
}
-const nextPluginLoader: loader.Loader = function (source) {
+const nextPluginLoader: loader.Loader = function () {
const { middleware }: NextPluginLoaderQuery =
typeof this.query === 'string' ? parse(this.query.substr(1)) : this.query
| true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/build/webpack/plugins/next-esm-plugin.ts | @@ -368,7 +368,7 @@ export default class NextEsmPlugin implements Plugin {
setTimeout(() => {
this.updateOptions(childCompiler)
- childCompiler.runAsChild((err, entries, childCompilation) => {
+ childCompiler.runAsChild((err, _entries, childCompilation) => {
... | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/build/webpack/plugins/profiling-plugin.ts | @@ -137,13 +137,15 @@ const interceptAllParserHooks = (moduleFactory: any, tracer: any) => {
moduleTypes.forEach((moduleType) => {
moduleFactory.hooks.parser
.for(moduleType)
- .tap('ProfilingPlugin', (parser: any, parserOpts: any) => {
+ .tap('ProfilingPlugin', (parser: any) => {
inte... | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/build/webpack/plugins/webpack-conformance-plugin/checks/duplicate-polyfills-conformance-check.ts | @@ -154,7 +154,7 @@ export class DuplicatePolyfillsConformanceCheck
},
{
visitor: 'visitCallExpression',
- inspectNode: (path: NodePath, { request }: IParsedModuleDetails) => {
+ inspectNode: (path: NodePath) => {
const { node }: { node: types.namedTypes.CallExpression } ... | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/build/webpack/plugins/webpack-conformance-plugin/index.ts | @@ -49,7 +49,7 @@ export default class WebpackConformancePlugin {
}
private buildStartedHandler = (
- compilation: CompilationType.Compilation,
+ _compilation: CompilationType.Compilation,
callback: () => void
) => {
const buildStartedResults: IConformanceTestResult[] = this.tests.map( | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/client/dev/on-demand-entries-client.js | @@ -13,7 +13,7 @@ export default async ({ assetPrefix }) => {
// prevent HMR connection from being closed when running tests
if (!process.env.__NEXT_TEST_MODE) {
- document.addEventListener('visibilitychange', (event) => {
+ document.addEventListener('visibilitychange', (_event) => {
const state = ... | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/client/next-dev.js | @@ -28,7 +28,7 @@ const webpackHMR = initWebpackHMR({ assetPrefix: prefix })
window.next = next
initNext({ webpackHMR })
- .then(({ emitter, renderCtx, render }) => {
+ .then(({ renderCtx, render }) => {
initOnDemandEntries({ assetPrefix: prefix })
if (process.env.__NEXT_BUILD_INDICATOR) initializeBuild... | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/next-server/lib/loadable.js | @@ -252,8 +252,7 @@ class LoadableSubscription {
this._update({})
this._clearTimeouts()
})
- // eslint-disable-next-line handle-callback-err
- .catch((err) => {
+ .catch((_err) => {
this._update({})
this._clearTimeouts()
}) | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/next-server/server/next-server.ts | @@ -475,7 +475,7 @@ export default class Server {
type,
match: getCustomRouteMatcher(r.source),
name: type,
- fn: async (req, res, params, parsedUrl) => ({ finished: false }),
+ fn: async (_req, _res, _params, _parsedUrl) => ({ finished: false }),
} as Route &... | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/server/hot-reloader.ts | @@ -265,7 +265,6 @@ export default class HotReloader {
this.config.pageExtensions
)
const entrypoints = createEntrypoints(
- /* dev */ true,
pages,
'server',
this.buildId, | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/server/next-dev-server.ts | @@ -135,7 +135,7 @@ export default class DevServer extends Server {
match: route(path),
type: 'route',
name: `${path} exportpathmap route`,
- fn: async (req, res, params, parsedUrl) => {
+ fn: async (req, res, _params, parsedUrl) => {
const { query: urlQue... | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/next/taskfile.js | @@ -681,7 +681,7 @@ export async function pages_document(task) {
await task.source('pages/_document.tsx').babel('server').target('dist/pages')
}
-export async function pages(task, opts) {
+export async function pages(task, _opts) {
await task.parallel(['pages_app', 'pages_error', 'pages_document'])
}
| true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/react-dev-overlay/src/internal/ReactDevOverlay.tsx | @@ -54,7 +54,7 @@ function ReactDevOverlay({ children }) {
}, [dispatch])
const onComponentError = React.useCallback(
- (error: Error, componentStack: string | null) => {
+ (_error: Error, _componentStack: string | null) => {
// TODO: special handling
},
[] | true |
Other | vercel | next.js | 0fc344e6a3ae5a9321b654da95d7d3bec1ac1897.json | Remove unused variable (#13716)
Co-authored-by: Joe Haddad <joe.haddad@zeit.co> | packages/react-refresh-utils/ReactRefreshWebpackPlugin.ts | @@ -11,7 +11,7 @@ function webpack4(compiler: Compiler) {
const hookRequire: typeof compilation['mainTemplate']['hooks']['requireExtensions'] = (compilation
.mainTemplate.hooks as any).require
- hookRequire.tap('ReactFreshWebpackPlugin', (source, chunk, hash) => {
+ hookRequire.tap('ReactFreshWebpac... | true |
Other | vercel | next.js | cfa00c9fcd7032db1b3cabbd9629167baa305b5a.json | chore(docs): use proper Jamstack casing (#13697)
`JAMstack` is now `Jamstack`. | docs/deployment.md | @@ -6,7 +6,7 @@ description: Deploy your Next.js app to production with Vercel and other hosting
## Vercel (Recommended)
-The easiest way to deploy Next.js to production is to use the **[Vercel platform](https://vercel.com)** from the creators of Next.js. [Vercel](https://vercel.com) is an all-in-one platform with... | false |
Other | vercel | next.js | d650da0623f57b899a7fc89b10d6632daf2058dd.json | Remove refs to old css experiment (#13673)
Removes some dangling references to non-existent experimental options. | examples/with-react-md/next.config.js | @@ -1,3 +0,0 @@
-module.exports = {
- experimental: { css: true },
-} | true |
Other | vercel | next.js | d650da0623f57b899a7fc89b10d6632daf2058dd.json | Remove refs to old css experiment (#13673)
Removes some dangling references to non-existent experimental options. | examples/z-experimental-refresh/next.config.js | @@ -1,5 +0,0 @@
-module.exports = {
- experimental: {
- reactRefresh: true,
- },
-} | true |
Other | vercel | next.js | d650da0623f57b899a7fc89b10d6632daf2058dd.json | Remove refs to old css experiment (#13673)
Removes some dangling references to non-existent experimental options. | test/acceptance/next.config.js | @@ -1,5 +0,0 @@
-module.exports = {
- experimental: {
- reactRefresh: true,
- },
-} | true |
Other | vercel | next.js | d650da0623f57b899a7fc89b10d6632daf2058dd.json | Remove refs to old css experiment (#13673)
Removes some dangling references to non-existent experimental options. | test/integration/config/next.config.js | @@ -7,7 +7,6 @@ module.exports = withCSS(
// Make sure entries are not getting disposed.
maxInactiveAge: 1000 * 60 * 60,
},
- experimental: { css: true },
poweredByHeader: false,
cssModules: true,
serverRuntimeConfig: { | true |
Other | vercel | next.js | d650da0623f57b899a7fc89b10d6632daf2058dd.json | Remove refs to old css experiment (#13673)
Removes some dangling references to non-existent experimental options. | test/integration/css-features/fixtures/next.config.js | @@ -1 +0,0 @@
-module.exports = { experimental: { css: true } } | true |
Other | vercel | next.js | d650da0623f57b899a7fc89b10d6632daf2058dd.json | Remove refs to old css experiment (#13673)
Removes some dangling references to non-existent experimental options. | test/integration/css-fixtures/custom-configuration-legacy/next.config.js | @@ -5,9 +5,6 @@ module.exports = withCSS({
// Make sure entries are not getting disposed.
maxInactiveAge: 1000 * 60 * 60,
},
- experimental: {
- css: true,
- },
webpack(cfg) {
cfg.devtool = 'source-map'
return cfg | true |
Other | vercel | next.js | d650da0623f57b899a7fc89b10d6632daf2058dd.json | Remove refs to old css experiment (#13673)
Removes some dangling references to non-existent experimental options. | test/integration/legacy-sass/next.config.js | @@ -1,2 +1,2 @@
const withSass = require('@zeit/next-sass')
-module.exports = withSass({ experimental: { reactRefresh: true } })
+module.exports = withSass() | true |
Other | vercel | next.js | d650da0623f57b899a7fc89b10d6632daf2058dd.json | Remove refs to old css experiment (#13673)
Removes some dangling references to non-existent experimental options. | test/integration/production-config/next.config.js | @@ -24,7 +24,6 @@ module.exports = withCSS(
// Make sure entries are not getting disposed.
maxInactiveAge: 1000 * 60 * 60,
},
- experimental: { css: true },
webpack(config) {
// When next-css is `npm link`ed we have to solve loaders from the project root
const nextLocation = pat... | true |
Other | vercel | next.js | 31b3e46b8f08f3ae8c16d95f4379f3129324a9be.json | Use inclusive naming for variables / examples (#13657)
https://twitter.com/vercel/status/1267650234236252161
The variables for the launchEditor feature were kept consistent with Create React App so it's probably a good idea for them to change them too: https://github.com/facebook/create-react-app/search?q=WINDOWS_FIL... | examples/custom-server-actionhero/config/api.js | @@ -24,7 +24,7 @@ exports['default'] = {
simultaneousActions: 5,
// allow connections to be created without remoteIp and remotePort (they will be set to 0)
enforceConnectionProperties: true,
- // disables the whitelisting of client params
+ // disables the access list of client params
... | true |
Other | vercel | next.js | 31b3e46b8f08f3ae8c16d95f4379f3129324a9be.json | Use inclusive naming for variables / examples (#13657)
https://twitter.com/vercel/status/1267650234236252161
The variables for the launchEditor feature were kept consistent with Create React App so it's probably a good idea for them to change them too: https://github.com/facebook/create-react-app/search?q=WINDOWS_FIL... | examples/with-redux-persist/README.md | @@ -47,8 +47,8 @@ Deploy it to the cloud with [Vercel](https://vercel.com/import?filter=next.js&ut
In this example, we are going to use the Next.js example [with-redux](https://github.com/vercel/next.js/tree/master/examples/with-redux-persist) to see how you can add a layer of persistence for one of the state from g... | true |
Other | vercel | next.js | 31b3e46b8f08f3ae8c16d95f4379f3129324a9be.json | Use inclusive naming for variables / examples (#13657)
https://twitter.com/vercel/status/1267650234236252161
The variables for the launchEditor feature were kept consistent with Create React App so it's probably a good idea for them to change them too: https://github.com/facebook/create-react-app/search?q=WINDOWS_FIL... | packages/next/build/webpack/loaders/next-babel-loader.js | @@ -21,7 +21,7 @@ const getModernOptions = (babelOptions = {}) => {
}
presetEnvOptions.exclude = [
...(presetEnvOptions.exclude || []),
- // Blacklist accidental inclusions
+ // Block accidental inclusions
'transform-regenerator',
'transform-async-to-generator',
] | true |
Other | vercel | next.js | 31b3e46b8f08f3ae8c16d95f4379f3129324a9be.json | Use inclusive naming for variables / examples (#13657)
https://twitter.com/vercel/status/1267650234236252161
The variables for the launchEditor feature were kept consistent with Create React App so it's probably a good idea for them to change them too: https://github.com/facebook/create-react-app/search?q=WINDOWS_FIL... | packages/react-dev-overlay/src/internal/helpers/launchEditor.ts | @@ -133,7 +133,7 @@ const COMMON_EDITORS_WIN = [
// Transpiled version of: /^([A-Za-z]:[/\\])?[\p{L}0-9/.\-_\\]+$/u
// Non-transpiled version requires support for Unicode property regex. Allows
// alphanumeric characters, periods, dashes, slashes, and underscores.
-const WINDOWS_FILE_NAME_WHITELIST = /^([A-Za-z]:[/\... | true |
Other | vercel | next.js | f49309a92ee29110ab686943024916c9ea5aee06.json | docs([[...rest]]): add experimental banner (#13641)
This feature is still experimental. | docs/api-routes/dynamic-api-routes.md | @@ -82,6 +82,9 @@ Now, a request to `/api/post/a/b/c` will respond with the text: `Post: a, b, c`.
### Optional catch all API routes
+> **Warning**: This feature is **experimental and may not work as expected**.
+> You must enable the `optionalCatchAll` experimental option to try it.
+
Catch all routes can be mad... | true |
Other | vercel | next.js | f49309a92ee29110ab686943024916c9ea5aee06.json | docs([[...rest]]): add experimental banner (#13641)
This feature is still experimental. | docs/routing/dynamic-routes.md | @@ -87,6 +87,9 @@ And in the case of `/post/a/b`, and any other matching path, new parameters will
### Optional catch all routes
+> **Warning**: This feature is **experimental and may not work as expected**.
+> You must enable the `optionalCatchAll` experimental option to try it.
+
Catch all routes can be made op... | true |
Other | vercel | next.js | 6f8ef70cb0dee66518678e044344c1768e1ffe8b.json | Remove middleware function that is never called (#13642)
Follow-up to #12218, missed this bit of code. | packages/next/pages/_document.tsx | @@ -23,8 +23,6 @@ export type OriginProps = {
crossOrigin?: string
}
-export async function middleware({ req, res }: DocumentContext) {}
-
function dedupe(bundles: any[]): any[] {
const files = new Set()
const kept = [] | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.