language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | 7902ae4c1f87b4d8c26fd729c054bab4d072c4b5.json | Change Gradle publication name for artifactory
This commit switches to the default publication name considered by the
artifactory plugin when it comes to publishing artifacts to the
artifactory repository.
See gh-23282 | gradle/publications.gradle | @@ -2,7 +2,7 @@ apply plugin: "maven-publish"
publishing {
publications {
- springFramework(MavenPublication) {
+ mavenJava(MavenPublication) {
pom {
name = project.description
description = project.description | true |
Other | spring-projects | spring-framework | 7902ae4c1f87b4d8c26fd729c054bab4d072c4b5.json | Change Gradle publication name for artifactory
This commit switches to the default publication name considered by the
artifactory plugin when it comes to publishing artifacts to the
artifactory repository.
See gh-23282 | gradle/spring-module.gradle | @@ -49,7 +49,7 @@ task javadocJar(type: Jar) {
publishing {
publications {
- springFramework(MavenPublication) {
+ mavenJava(MavenPublication) {
from components.java
artifact sourcesJar
artifact javadocJar | true |
Other | spring-projects | spring-framework | 53f523001e4df6b84a2ff7e9c3ae360308bc32fa.json | Focus examples in Testing chapter on JUnit Jupiter | src/docs/asciidoc/testing.adoc | @@ -450,7 +450,7 @@ file:
[subs="verbatim,quotes"]
----
@ContextConfiguration("/test-config.xml") <1>
- public class XmlApplicationContextTests {
+ class XmlApplicationContextTests {
// class body...
}
----
@@ -463,7 +463,7 @@ The following example shows a `@ContextConfiguration` annotation that refers to
[s... | false |
Other | spring-projects | spring-framework | a7bb5ca473e55cd7fe1aaddfb30c4ec1ee913054.json | Remove unnecessary iteration over headers
The use of LinkedCaseInsensitiveMap, going back to 3.0, makes it
unnecessary to iterate over keys which can cause
ConcurrentModificationException.
Closes gh-23460 | spring-test/src/main/java/org/springframework/mock/web/HeaderValueHolder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -91,8 +91,11 @@ public String toString() {
... | true |
Other | spring-projects | spring-framework | a7bb5ca473e55cd7fe1aaddfb30c4ec1ee913054.json | Remove unnecessary iteration over headers
The use of LinkedCaseInsensitiveMap, going back to 3.0, makes it
unnecessary to iterate over keys which can cause
ConcurrentModificationException.
Closes gh-23460 | spring-test/src/main/java/org/springframework/mock/web/MockHttpServletRequest.java | @@ -1038,7 +1038,7 @@ else if (HttpHeaders.ACCEPT_LANGUAGE.equalsIgnoreCase(name) &&
}
private void doAddHeaderValue(String name, @Nullable Object value, boolean replace) {
- HeaderValueHolder header = HeaderValueHolder.getByName(this.headers, name);
+ HeaderValueHolder header = this.headers.get(name);
Asser... | true |
Other | spring-projects | spring-framework | a7bb5ca473e55cd7fe1aaddfb30c4ec1ee913054.json | Remove unnecessary iteration over headers
The use of LinkedCaseInsensitiveMap, going back to 3.0, makes it
unnecessary to iterate over keys which can cause
ConcurrentModificationException.
Closes gh-23460 | spring-test/src/main/java/org/springframework/mock/web/MockHttpServletResponse.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -380,7 +380,7 @@ public Cookie getCookie(Str... | true |
Other | spring-projects | spring-framework | a7bb5ca473e55cd7fe1aaddfb30c4ec1ee913054.json | Remove unnecessary iteration over headers
The use of LinkedCaseInsensitiveMap, going back to 3.0, makes it
unnecessary to iterate over keys which can cause
ConcurrentModificationException.
Closes gh-23460 | spring-web/src/test/java/org/springframework/mock/web/test/MockHttpServletRequest.java | @@ -1038,7 +1038,7 @@ else if (HttpHeaders.ACCEPT_LANGUAGE.equalsIgnoreCase(name) &&
}
private void doAddHeaderValue(String name, @Nullable Object value, boolean replace) {
- HeaderValueHolder header = HeaderValueHolder.getByName(this.headers, name);
+ HeaderValueHolder header = this.headers.get(name);
Asser... | true |
Other | spring-projects | spring-framework | a7bb5ca473e55cd7fe1aaddfb30c4ec1ee913054.json | Remove unnecessary iteration over headers
The use of LinkedCaseInsensitiveMap, going back to 3.0, makes it
unnecessary to iterate over keys which can cause
ConcurrentModificationException.
Closes gh-23460 | spring-web/src/test/java/org/springframework/mock/web/test/MockHttpServletResponse.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -380,7 +380,7 @@ public Cookie getCookie(Str... | true |
Other | spring-projects | spring-framework | 0a7fdb380f78321a943f070fb89485f039265b96.json | Fix checkstyle error | spring-web/src/test/java/org/springframework/http/server/reactive/HttpHeadResponseDecoratorTests.java | @@ -18,7 +18,7 @@
import java.nio.charset.StandardCharsets;
import io.netty.buffer.PooledByteBufAllocator;
-import org.junit.After;
+import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;
import reactor.core.publisher.Flux;
@@ -42,7 +42,7 @@ public class HttpHeadResponseDecoratorTests {
... | false |
Other | spring-projects | spring-framework | ff6ccd0d0433ff5f192d74590a63e3b8929220b5.json | Adapt tests changed in 5.1.x to master | spring-web/src/test/java/org/springframework/http/server/reactive/HttpHeadResponseDecoratorTests.java | @@ -19,15 +19,15 @@
import io.netty.buffer.PooledByteBufAllocator;
import org.junit.After;
-import org.junit.Test;
+import org.junit.jupiter.api.Test;
import reactor.core.publisher.Flux;
import org.springframework.core.io.buffer.DataBuffer;
import org.springframework.core.io.buffer.LeakAwareDataBufferFactory;
... | true |
Other | spring-projects | spring-framework | ff6ccd0d0433ff5f192d74590a63e3b8929220b5.json | Adapt tests changed in 5.1.x to master | spring-webflux/src/test/java/org/springframework/web/reactive/resource/PathResourceResolverTests.java | @@ -110,7 +110,7 @@ private void testCheckResource(Resource location, String requestPath) throws IOE
public void ignoreInvalidEscapeSequence() throws IOException {
UrlResource location = new UrlResource(getClass().getResource("./test/"));
Resource resource = location.createRelative("test%file.txt");
- assertTr... | true |
Other | spring-projects | spring-framework | ff6ccd0d0433ff5f192d74590a63e3b8929220b5.json | Adapt tests changed in 5.1.x to master | spring-webmvc/src/test/java/org/springframework/web/servlet/resource/PathResourceResolverTests.java | @@ -95,7 +95,7 @@ private void testCheckResource(Resource location, String requestPath) throws IOE
public void ignoreInvalidEscapeSequence() throws IOException {
UrlResource location = new UrlResource(getClass().getResource("./test/"));
Resource resource = location.createRelative("test%file.txt");
- assertTrue... | true |
Other | spring-projects | spring-framework | b86c11cc9b00693fc3446724ffd37ae379189b7f.json | Respect existing content-length for HTTP HEAD
Closes gh-23484 | spring-web/src/main/java/org/springframework/http/server/reactive/HttpHeadResponseDecorator.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -24,6 +24,7 @@
import org.springframework... | true |
Other | spring-projects | spring-framework | b86c11cc9b00693fc3446724ffd37ae379189b7f.json | Respect existing content-length for HTTP HEAD
Closes gh-23484 | spring-web/src/test/java/org/springframework/http/server/reactive/HttpHeadResponseDecoratorTests.java | @@ -0,0 +1,73 @@
+/*
+ * Copyright 2002-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 5053df55b6d23d3ef66de741fa77c1a3ccdba907.json | Add LICENSE.txt file
Closes gh-23492 | LICENSE.txt | @@ -0,0 +1,202 @@
+
+ Apache License
+ Version 2.0, January 2004
+ https://www.apache.org/licenses/
+
+ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+ 1. Definitions.
+
+ "License" shall mean the terms and condit... | false |
Other | spring-projects | spring-framework | 19ed439e4bab269400a1dd585bcb947e61cda45e.json | Avoid Hamcrest 2.x deprecation warnings
See gh-23467 | spring-test/src/test/java/org/springframework/test/web/client/samples/matchers/JsonPathRequestMatchersIntegrationTests.java | @@ -34,7 +34,8 @@
import static org.hamcrest.Matchers.endsWith;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.hasItem;
-import static org.hamcrest.Matchers.isIn;
+import static org.hamcrest.Matchers.in;
+import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.s... | true |
Other | spring-projects | spring-framework | 19ed439e4bab269400a1dd585bcb947e61cda45e.json | Avoid Hamcrest 2.x deprecation warnings
See gh-23467 | spring-test/src/test/java/org/springframework/test/web/servlet/samples/standalone/resultmatchers/JsonPathAssertionTests.java | @@ -32,7 +32,8 @@
import static org.hamcrest.Matchers.containsString;
import static org.hamcrest.Matchers.endsWith;
import static org.hamcrest.Matchers.equalTo;
-import static org.hamcrest.Matchers.isIn;
+import static org.hamcrest.Matchers.in;
+import static org.hamcrest.Matchers.is;
import static org.hamcrest.Mat... | true |
Other | spring-projects | spring-framework | ceaf6f46ac71d6cbf3ffdb57da0e0acc2a4d96c3.json | Remove test dependencies from spring-build-src
The spring-build-src module does not contain any tests. Thus, we do not
need any test dependencies. | buildSrc/build.gradle | @@ -6,11 +6,6 @@ repositories {
mavenCentral()
}
-dependencies {
- testImplementation 'junit:junit:4.12'
- testImplementation 'org.assertj:assertj-core:3.11.1'
-}
-
gradlePlugin {
plugins {
compileConventionsPlugin { | false |
Other | spring-projects | spring-framework | b4c0537fa5a4c6f888be4bb9d1e2d1fde6e3d8d1.json | Remove unused Gradle configuration
This commit removes unused parts of the Gradle build:
* Gradle wrapper customization which should not be needed in recent
versions of Gradle (or can be replaced with options in the
gradle.properties file)
* the branch strategy configuration
See gh-23282 | build.gradle | @@ -59,7 +59,6 @@ ext {
configure(allprojects) { project ->
group = "org.springframework"
- version = qualifyVersionIfNecessary(version)
apply plugin: "java"
apply plugin: "kotlin"
@@ -288,33 +287,5 @@ configure(rootProject) {
archives distZip
}
- wrapper {
- doLast() {
- def gradleOpts = "-XX:MaxM... | false |
Other | spring-projects | spring-framework | db02d38c89f4c8df2ee9f0c0c40d3308a3232b05.json | Restore annotated code samples
See gh-21778 | src/docs/asciidoc/core/core-aop.adoc | @@ -481,33 +481,38 @@ pointcut expressions by name. The following example shows three pointcut express
[source,java,indent=0,subs="verbatim,quotes",role="primary"]
.Java
----
- // matches if a method execution join point represents the execution of any public method
@Pointcut("execution(public * *(..))")
- private... | true |
Other | spring-projects | spring-framework | db02d38c89f4c8df2ee9f0c0c40d3308a3232b05.json | Restore annotated code samples
See gh-21778 | src/docs/asciidoc/core/core-appendix.adoc | @@ -860,14 +860,10 @@ we can parse our custom XML content, as you can see in the following example:
import java.text.SimpleDateFormat;
- // We use the Spring-provided AbstractSingleBeanDefinitionParser to handle a lot of
- // the basic grunt work of creating a single BeanDefinition.
- public class SimpleDateForma... | true |
Other | spring-projects | spring-framework | db02d38c89f4c8df2ee9f0c0c40d3308a3232b05.json | Restore annotated code samples
See gh-21778 | src/docs/asciidoc/core/core-beans.adoc | @@ -5599,24 +5599,27 @@ following example:
public class MovieRecommender {
@Autowired
- @Offline
+ @Offline // <1>
private MovieCatalog offlineCatalog;
// ...
}
----
+<1> This line adds the `@Offline` annotation.
+
[source,kotlin,indent=0,subs="verbatim,quotes",role="secondary"]
.Kotlin
----
cla... | true |
Other | spring-projects | spring-framework | db02d38c89f4c8df2ee9f0c0c40d3308a3232b05.json | Restore annotated code samples
See gh-21778 | src/docs/asciidoc/core/core-expressions.adoc | @@ -69,16 +69,19 @@ The following code introduces the SpEL API to evaluate the literal string expres
.Java
----
ExpressionParser parser = new SpelExpressionParser();
- Expression exp = parser.parseExpression("'Hello World'"); // The value of the message variable is 'Hello World'
+ Expression exp = parser.parseExpre... | true |
Other | spring-projects | spring-framework | 561af5f8f936ed4608fff67e0af2a5872031df24.json | Replace propdeps plugin with custom plugin
Prior to this commit, the Spring Framework build would be using the
propdeps Gradle plugin to introduce two new configurations to the build:
"optional" and "provided". This would also configure related conventions
for IDEs, adding those configurations to published POMs.
This... | build.gradle | @@ -3,7 +3,6 @@ buildscript {
maven { url "https://repo.spring.io/plugins-release" }
}
dependencies {
- classpath("io.spring.gradle:propdeps-plugin:0.0.9.RELEASE")
classpath("io.spring.nohttp:nohttp-gradle:0.0.3.RELEASE")
classpath("org.asciidoctor:asciidoctorj-pdf:1.5.0-alpha.16")
classpath("io.spring... | true |
Other | spring-projects | spring-framework | 561af5f8f936ed4608fff67e0af2a5872031df24.json | Replace propdeps plugin with custom plugin
Prior to this commit, the Spring Framework build would be using the
propdeps Gradle plugin to introduce two new configurations to the build:
"optional" and "provided". This would also configure related conventions
for IDEs, adding those configurations to published POMs.
This... | buildSrc/build.gradle | @@ -13,6 +13,10 @@ dependencies {
gradlePlugin {
plugins {
+ optionalDependenciesPlugin {
+ id = "org.springframework.build.optional-dependencies"
+ implementationClass = "org.springframework.build.optional.OptionalDependenciesPlugin"
+ }
testSourcesPlugin {
id = "org.springframework.build.test-source... | true |
Other | spring-projects | spring-framework | 561af5f8f936ed4608fff67e0af2a5872031df24.json | Replace propdeps plugin with custom plugin
Prior to this commit, the Spring Framework build would be using the
propdeps Gradle plugin to introduce two new configurations to the build:
"optional" and "provided". This would also configure related conventions
for IDEs, adding those configurations to published POMs.
This... | buildSrc/src/main/java/org/springframework/build/optional/OptionalDependenciesPlugin.java | @@ -0,0 +1,64 @@
+/*
+ * Copyright 2002-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 561af5f8f936ed4608fff67e0af2a5872031df24.json | Replace propdeps plugin with custom plugin
Prior to this commit, the Spring Framework build would be using the
propdeps Gradle plugin to introduce two new configurations to the build:
"optional" and "provided". This would also configure related conventions
for IDEs, adding those configurations to published POMs.
This... | buildSrc/src/main/java/org/springframework/build/testsources/TestSourcesPlugin.java | @@ -30,6 +30,8 @@
import org.gradle.api.tasks.SourceSet;
import org.gradle.api.tasks.SourceSetOutput;
+import org.springframework.build.optional.OptionalDependenciesPlugin;
+
/**
* {@link Plugin} that automatically updates testCompile dependencies to include
* the test source sets of {@code project()} dependen... | true |
Other | spring-projects | spring-framework | 561af5f8f936ed4608fff67e0af2a5872031df24.json | Replace propdeps plugin with custom plugin
Prior to this commit, the Spring Framework build would be using the
propdeps Gradle plugin to introduce two new configurations to the build:
"optional" and "provided". This would also configure related conventions
for IDEs, adding those configurations to published POMs.
This... | gradle/ide.gradle | @@ -1,9 +1,7 @@
import org.gradle.plugins.ide.eclipse.model.ProjectDependency
import org.gradle.plugins.ide.eclipse.model.SourceFolder
-
-apply plugin: "propdeps-eclipse"
-apply plugin: "propdeps-idea"
+apply plugin: "eclipse"
eclipse.jdt {
sourceCompatibility = 1.8 | true |
Other | spring-projects | spring-framework | 561af5f8f936ed4608fff67e0af2a5872031df24.json | Replace propdeps plugin with custom plugin
Prior to this commit, the Spring Framework build would be using the
propdeps Gradle plugin to introduce two new configurations to the build:
"optional" and "provided". This would also configure related conventions
for IDEs, adding those configurations to published POMs.
This... | gradle/publish-maven.gradle | @@ -1,4 +1,4 @@
-apply plugin: "propdeps-maven"
+apply plugin: "maven"
install {
repositories.mavenInstaller { | true |
Other | spring-projects | spring-framework | 561af5f8f936ed4608fff67e0af2a5872031df24.json | Replace propdeps plugin with custom plugin
Prior to this commit, the Spring Framework build would be using the
propdeps Gradle plugin to introduce two new configurations to the build:
"optional" and "provided". This would also configure related conventions
for IDEs, adding those configurations to published POMs.
This... | spring-core-coroutines/spring-core-coroutines.gradle | @@ -20,5 +20,3 @@ eclipse {
containers "org.jetbrains.kotlin.core.KOTLIN_CONTAINER"
}
}
-
-configurations.archives.artifacts.clear() | true |
Other | spring-projects | spring-framework | 561af5f8f936ed4608fff67e0af2a5872031df24.json | Replace propdeps plugin with custom plugin
Prior to this commit, the Spring Framework build would be using the
propdeps Gradle plugin to introduce two new configurations to the build:
"optional" and "provided". This would also configure related conventions
for IDEs, adding those configurations to published POMs.
This... | spring-jms/spring-jms.gradle | @@ -1,15 +1,16 @@
description = "Spring JMS"
dependencies {
- provided("javax.jms:javax.jms-api:2.0.1")
compile(project(":spring-beans"))
compile(project(":spring-core"))
compile(project(":spring-messaging"))
compile(project(":spring-tx"))
+ compileOnly("javax.jms:javax.jms-api:2.0.1")
optional(project(":... | true |
Other | spring-projects | spring-framework | 561af5f8f936ed4608fff67e0af2a5872031df24.json | Replace propdeps plugin with custom plugin
Prior to this commit, the Spring Framework build would be using the
propdeps Gradle plugin to introduce two new configurations to the build:
"optional" and "provided". This would also configure related conventions
for IDEs, adding those configurations to published POMs.
This... | spring-webmvc/spring-webmvc.gradle | @@ -8,13 +8,13 @@ dependencyManagement {
}
dependencies {
- provided("javax.servlet:javax.servlet-api:4.0.1")
compile(project(":spring-aop"))
compile(project(":spring-beans"))
compile(project(":spring-context"))
compile(project(":spring-core"))
compile(project(":spring-expression"))
compile(project(":sp... | true |
Other | spring-projects | spring-framework | 593928a9f35832926736ffa053d38e5a26ecb861.json | Upgrade JDK 15 CI image to JDK 15 build 24 | ci/images/get-jdk-url.sh | @@ -12,7 +12,7 @@ case "$1" in
echo "https://github.com/AdoptOpenJDK/openjdk14-binaries/releases/download/jdk-14.0.1%2B7/OpenJDK14U-jdk_x64_linux_hotspot_14.0.1_7.tar.gz"
;;
java15)
- echo "https://download.java.net/java/early_access/jdk15/23/GPL/openjdk-15-ea+23_linux-x64_bin.tar.gz"
+ echo "https://downl... | false |
Other | spring-projects | spring-framework | da071c1fceb48ac32ebab105d04a204d1ac8642e.json | Remove unused code | spring-web/src/main/java/org/springframework/web/util/UrlPathHelper.java | @@ -675,10 +675,4 @@ public void setDefaultEncoding(String defaultEncoding) {
}
};
-
- private static class HttpServletMappingHelper {
-
-
-
- }
} | false |
Other | spring-projects | spring-framework | 5ca79281535fc62f5c2ffc7b432e5322b6e7366e.json | Use Servlet 4 mapping type if available
See gh-25100 | spring-web/spring-web.gradle | @@ -8,7 +8,7 @@ dependencies {
optional(project(":spring-aop"))
optional(project(":spring-context"))
optional(project(":spring-oxm"))
- optional("javax.servlet:javax.servlet-api:3.1.0")
+ optional("javax.servlet:javax.servlet-api") // Servlet 4 for mapping type
optional("javax.servlet.jsp:javax.servlet.jsp-api"... | true |
Other | spring-projects | spring-framework | 5ca79281535fc62f5c2ffc7b432e5322b6e7366e.json | Use Servlet 4 mapping type if available
See gh-25100 | spring-web/src/main/java/org/springframework/web/util/UrlPathHelper.java | @@ -23,11 +23,13 @@
import java.util.Properties;
import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.MappingMatch;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.springframework.lang.Nullable;
+import org.springframework.util.ClassUtils;
... | true |
Other | spring-projects | spring-framework | 9d429e30de7c118115fe898ac108e151fc54bd9b.json | Fix SpelEvaluationException with example code
org.springframework.expression.spel.SpelEvaluationException: EL1007E: Property or field 'name' cannot be found on null | src/docs/asciidoc/core/core-expressions.adoc | @@ -1675,15 +1675,15 @@ The following example shows how to use the Elvis operator:
----
ExpressionParser parser = new SpelExpressionParser();
- String name = parser.parseExpression("name?:'Unknown'").getValue(String.class);
+ String name = parser.parseExpression("name?:'Unknown'").getValue(new Inventor(), String.c... | false |
Other | spring-projects | spring-framework | 212bb7fef65a21fc367f5ee341d5f9f52c112d46.json | Add GenericConversionService JMH benchmark
This commit removes some of the deprecated "PERFORMANCE" tests and turns
them into JMH benchmarks.
See gh-24830 | spring-core/src/jmh/java/org/springframework/core/convert/support/GenericConversionServiceBenchmark.java | @@ -0,0 +1,112 @@
+/*
+ * Copyright 2002-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
... | true |
Other | spring-projects | spring-framework | 212bb7fef65a21fc367f5ee341d5f9f52c112d46.json | Add GenericConversionService JMH benchmark
This commit removes some of the deprecated "PERFORMANCE" tests and turns
them into JMH benchmarks.
See gh-24830 | spring-core/src/test/java/org/springframework/core/convert/support/GenericConversionServiceTests.java | @@ -27,7 +27,6 @@
import java.util.HashMap;
import java.util.HashSet;
import java.util.LinkedHashMap;
-import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.Set;
@@ -43,9 +42,7 @@
import org.springframework.core.convert.converter.GenericConverter;
import org.springframework.... | true |
Other | spring-projects | spring-framework | 703d54677e94463f773c0b25a764c2a368c3d517.json | Avoid unnecessary boxing/unboxing of primitives
Closes gh-25080 | spring-beans/src/main/java/org/springframework/beans/propertyeditors/CharacterEditor.java | @@ -82,7 +82,7 @@ else if (isUnicodeCharacterSequence(text)) {
setAsUnicode(text);
}
else if (text.length() == 1) {
- setValue(Character.valueOf(text.charAt(0)));
+ setValue(text.charAt(0));
}
else {
throw new IllegalArgumentException("String [" + text + "] with length " +
@@ -103,7 +103,7 @@ pr... | true |
Other | spring-projects | spring-framework | 703d54677e94463f773c0b25a764c2a368c3d517.json | Avoid unnecessary boxing/unboxing of primitives
Closes gh-25080 | spring-context/src/main/java/org/springframework/scheduling/config/TaskExecutorFactoryBean.java | @@ -128,7 +128,7 @@ private void determinePoolSizeRange(ThreadPoolTaskExecutor executor) {
}
}
else {
- Integer value = Integer.valueOf(this.poolSize);
+ int value = Integer.parseInt(this.poolSize);
corePoolSize = value;
maxPoolSize = value;
} | true |
Other | spring-projects | spring-framework | 703d54677e94463f773c0b25a764c2a368c3d517.json | Avoid unnecessary boxing/unboxing of primitives
Closes gh-25080 | spring-web/src/main/java/org/springframework/http/converter/ResourceRegionHttpMessageConverter.java | @@ -148,7 +148,7 @@ protected void writeResourceRegion(ResourceRegion region, HttpOutputMessage outp
long start = region.getPosition();
long end = start + region.getCount() - 1;
- Long resourceLength = region.getResource().contentLength();
+ long resourceLength = region.getResource().contentLength();
end =... | true |
Other | spring-projects | spring-framework | 703d54677e94463f773c0b25a764c2a368c3d517.json | Avoid unnecessary boxing/unboxing of primitives
Closes gh-25080 | spring-webmvc/src/main/java/org/springframework/web/servlet/config/AnnotationDrivenBeanDefinitionParser.java | @@ -208,7 +208,7 @@ public BeanDefinition parse(Element element, ParserContext context) {
handlerMappingDef.getPropertyValues().add("contentNegotiationManager", contentNegotiationManager);
if (element.hasAttribute("enable-matrix-variables")) {
- Boolean enableMatrixVariables = Boolean.valueOf(element.getAttri... | true |
Other | spring-projects | spring-framework | b1224835be7e591fc784c565a7efdb7f09d29d26.json | Add metadataPush support to RSocketRequester
Closes gh-24322 | spring-messaging/src/main/java/org/springframework/messaging/rsocket/DefaultRSocketRequester.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -248,6 +248,11 @@ private Mono<Payload> firs... | true |
Other | spring-projects | spring-framework | b1224835be7e591fc784c565a7efdb7f09d29d26.json | Add metadataPush support to RSocketRequester
Closes gh-24322 | spring-messaging/src/main/java/org/springframework/messaging/rsocket/RSocketRequester.java | @@ -276,6 +276,12 @@ interface RequestSpec extends MetadataSpec<RequestSpec>, RetrieveSpec {
*/
RequestSpec metadata(Consumer<MetadataSpec<?>> configurer);
+ /**
+ * Perform a {@link RSocket#metadataPush(Payload) metadataPush}.
+ * @since 5.3
+ */
+ Mono<Void> sendMetadata();
+
/**
* Provide pay... | true |
Other | spring-projects | spring-framework | b1224835be7e591fc784c565a7efdb7f09d29d26.json | Add metadataPush support to RSocketRequester
Closes gh-24322 | spring-messaging/src/test/java/org/springframework/messaging/rsocket/FireAndForgetCountingInterceptor.java | @@ -1,77 +0,0 @@
-/*
- * Copyright 2002-2019 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * https://www.apache.org/licenses/LICENSE-2.0
-... | true |
Other | spring-projects | spring-framework | b1224835be7e591fc784c565a7efdb7f09d29d26.json | Add metadataPush support to RSocketRequester
Closes gh-24322 | spring-messaging/src/test/java/org/springframework/messaging/rsocket/RSocketClientToServerIntegrationTests.java | @@ -17,16 +17,21 @@
package org.springframework.messaging.rsocket;
import java.time.Duration;
+import java.util.concurrent.atomic.AtomicInteger;
+import io.rsocket.Payload;
+import io.rsocket.RSocket;
import io.rsocket.SocketAcceptor;
import io.rsocket.core.RSocketServer;
import io.rsocket.frame.decoder.Payloa... | true |
Other | spring-projects | spring-framework | b1224835be7e591fc784c565a7efdb7f09d29d26.json | Add metadataPush support to RSocketRequester
Closes gh-24322 | src/docs/asciidoc/rsocket.adoc | @@ -582,6 +582,8 @@ values are supported by a registered `Encoder`. For example:
For `Fire-and-Forget` use the `send()` method that returns `Mono<Void>`. Note that the `Mono`
indicates only that the message was successfully sent, and not that it was handled.
+For `Metadata-Push` use the `sendMetadata()` method with... | true |
Other | spring-projects | spring-framework | de378599d348ff33acd91f98c976a89b686bb14f.json | Provide access to CloseStatus in WebSocketSession
Closes gh-22079 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/CloseStatus.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -19,6 +19,7 @@
import org.springframework.l... | true |
Other | spring-projects | spring-framework | de378599d348ff33acd91f98c976a89b686bb14f.json | Provide access to CloseStatus in WebSocketSession
Closes gh-22079 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/WebSocketSession.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -95,6 +95,13 @@ default Mono<Void> close() {... | true |
Other | spring-projects | spring-framework | de378599d348ff33acd91f98c976a89b686bb14f.json | Provide access to CloseStatus in WebSocketSession
Closes gh-22079 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/AbstractListenerWebSocketSession.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -35,6 +35,7 @@
import org.springframework.u... | true |
Other | spring-projects | spring-framework | de378599d348ff33acd91f98c976a89b686bb14f.json | Provide access to CloseStatus in WebSocketSession
Closes gh-22079 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/JettyWebSocketHandlerAdapter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -131,7 +131,7 @@ else if (Type.PONG.equals(t... | true |
Other | spring-projects | spring-framework | de378599d348ff33acd91f98c976a89b686bb14f.json | Provide access to CloseStatus in WebSocketSession
Closes gh-22079 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/ReactorNettyWebSocketSession.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -95,9 +95,15 @@ public Mono<Void> send(Publi... | true |
Other | spring-projects | spring-framework | de378599d348ff33acd91f98c976a89b686bb14f.json | Provide access to CloseStatus in WebSocketSession
Closes gh-22079 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/StandardWebSocketHandlerAdapter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -110,7 +110,7 @@ else if (message instanceof... | true |
Other | spring-projects | spring-framework | de378599d348ff33acd91f98c976a89b686bb14f.json | Provide access to CloseStatus in WebSocketSession
Closes gh-22079 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/adapter/UndertowWebSocketHandlerAdapter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -72,7 +72,7 @@ protected void onFullPongMess... | true |
Other | spring-projects | spring-framework | de378599d348ff33acd91f98c976a89b686bb14f.json | Provide access to CloseStatus in WebSocketSession
Closes gh-22079 | spring-webflux/src/test/java/org/springframework/web/reactive/socket/WebSocketIntegrationTests.java | @@ -147,9 +147,11 @@ void customHeader(WebSocketClient client, HttpServer server, Class<?> serverConf
void sessionClosing(WebSocketClient client, HttpServer server, Class<?> serverConfigClass) throws Exception {
startServer(client, server, serverConfigClass);
+ MonoProcessor<CloseStatus> statusProcessor = MonoP... | true |
Other | spring-projects | spring-framework | 6403a9f10e45db0eea40c6bd7361a5fe9ad0c04b.json | Defer decision on BindingResult type until access
Closes gh-24347 | spring-context/src/main/java/org/springframework/validation/DataBinder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -129,6 +129,8 @@ public class DataBinder imp... | true |
Other | spring-projects | spring-framework | 6403a9f10e45db0eea40c6bd7361a5fe9ad0c04b.json | Defer decision on BindingResult type until access
Closes gh-24347 | spring-context/src/test/java/org/springframework/validation/DataBinderTests.java | @@ -2050,9 +2050,18 @@ public void testCallSetMessageCodesResolverTwice() {
assertThatIllegalStateException().isThrownBy(() ->
binder.setMessageCodesResolver(new DefaultMessageCodesResolver()))
.withMessageContaining("DataBinder is already initialized with MessageCodesResolver");
+ }
+ @Test // gh-24347
+... | true |
Other | spring-projects | spring-framework | 875e7f8630bfa3410bb10849a4d3e298ece32d74.json | Match multiple values in HeaderAssertions
Closes gh-23878 | spring-test/src/main/java/org/springframework/test/web/reactive/server/HeaderAssertions.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -17,6 +17,7 @@
package org.springframework.... | true |
Other | spring-projects | spring-framework | 875e7f8630bfa3410bb10849a4d3e298ece32d74.json | Match multiple values in HeaderAssertions
Closes gh-23878 | spring-test/src/test/java/org/springframework/test/web/reactive/server/HeaderAssertionTests.java | @@ -36,6 +36,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
import static org.hamcrest.Matchers.containsString;
+import static org.hamcrest.Matchers.hasItems;
import static org.mockito.Mockito.mock;
/**
@@ -97,11 +98,33 @@ p... | true |
Other | spring-projects | spring-framework | e881d4b1441b4ade35806b6f06d5b7ebe1828e92.json | Allow use of JsonInclude.Value
Closes gh-24824 | spring-web/src/main/java/org/springframework/http/converter/json/Jackson2ObjectMapperBuilder.java | @@ -143,7 +143,7 @@ public class Jackson2ObjectMapperBuilder {
private TypeResolverBuilder<?> defaultTyping;
@Nullable
- private JsonInclude.Include serializationInclusion;
+ private JsonInclude.Value serializationInclusion;
@Nullable
private FilterProvider filters;
@@ -301,7 +301,16 @@ public Jackson2Objec... | false |
Other | spring-projects | spring-framework | 3809d885b6e5825368705d00a3d63f0ab7cd0128.json | Fix Checkstyle violation | spring-web/src/main/java/org/springframework/http/ContentDisposition.java | @@ -439,7 +439,8 @@ private static String escapeQuotationsInFilename(String filename) {
for (char c : filename.toCharArray()) {
if (!escaped && c == '"') {
sb.append("\\\"");
- } else {
+ }
+ else {
sb.append(c);
}
escaped = (!escaped && c == '\\'); | false |
Other | spring-projects | spring-framework | 311b3338145038ea92c693bb2a8babec9580deda.json | Use computeIfAbsent in ResourceBundleMessageSource
This commit optimizes code in ResourceBundleMessageSource
by using computeIfAbsent instead of putIfAbsent.
In addition, the content of some Javadoc has been adjusted.
Closes gh-25054 | spring-context/src/main/java/org/springframework/context/support/ResourceBundleMessageSource.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -183,8 +183,8 @@ protected MessageFormat res... | false |
Other | spring-projects | spring-framework | d54b903d28c176c20abde6134a302092b3107daf.json | Fix typo in RmiSupportTests
Closes gh-25051 | spring-context/src/test/java/org/springframework/remoting/rmi/RmiSupportTests.java | @@ -293,8 +293,8 @@ private void doTestRmiProxyFactoryBeanWithBusinessInterfaceAndExceptionAndRefres
assertThat(condition1).isFalse();
assertThatExceptionOfType(springExceptionClass).isThrownBy(() ->
proxy.setName(rmiExceptionClass.getName()));
- boolean isRemoteConnectFaiure = RemoteConnectFailureException... | false |
Other | spring-projects | spring-framework | e8335c94d5e7ab57b2b43dd6b809c81c1e997fbd.json | Update Javadoc for LazyInitTargetSourceCreator
See gh-24915 | spring-aop/src/main/java/org/springframework/aop/framework/autoproxy/target/LazyInitTargetSourceCreator.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -23,30 +23,32 @@
import org.springframework... | false |
Other | spring-projects | spring-framework | d587a660fc3fdd0f0a80ec930c24353134fb10c3.json | Fix a warning in Kotlin tests | spring-messaging/src/test/kotlin/org/springframework/messaging/rsocket/RSocketRequesterExtensionsTests.kt | @@ -18,6 +18,7 @@ package org.springframework.messaging.rsocket
import io.mockk.every
import io.mockk.mockk
+import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.toList
import kotlinx.coroutines.runBlocking
@@ -125,6 +126,7 @@ class RSocketRequest... | false |
Other | spring-projects | spring-framework | 2b4eb610a7c8059e5b35c0e3807fc1335162c379.json | Add support for Coroutines transactions
This commit adds Coroutines extensions for
TransactionalOperator.transactional that accept suspending lambda or
Kotlin Flow parameters.
@Transactional on suspending functions is not supported yet, gh-23575
has been created for that purpose.
Closes gh-22915 | spring-tx/spring-tx.gradle | @@ -1,17 +1,24 @@
description = "Spring Transaction"
+apply plugin: "kotlin"
+
dependencies {
compile(project(":spring-beans"))
compile(project(":spring-core"))
optional(project(":spring-aop"))
optional(project(":spring-context")) // for JCA, @EnableTransactionManagement
+ optional(project(":kotlin-corouti... | true |
Other | spring-projects | spring-framework | 2b4eb610a7c8059e5b35c0e3807fc1335162c379.json | Add support for Coroutines transactions
This commit adds Coroutines extensions for
TransactionalOperator.transactional that accept suspending lambda or
Kotlin Flow parameters.
@Transactional on suspending functions is not supported yet, gh-23575
has been created for that purpose.
Closes gh-22915 | spring-tx/src/main/java/org/springframework/transaction/interceptor/TransactionAspectSupport.java | @@ -21,6 +21,8 @@
import java.util.concurrent.ConcurrentMap;
import io.vavr.control.Try;
+import kotlin.reflect.KFunction;
+import kotlin.reflect.jvm.ReflectJvmMapping;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import reactor.core.publisher.Flux;
@@ -30,6 +32,7 @@
impo... | true |
Other | spring-projects | spring-framework | 2b4eb610a7c8059e5b35c0e3807fc1335162c379.json | Add support for Coroutines transactions
This commit adds Coroutines extensions for
TransactionalOperator.transactional that accept suspending lambda or
Kotlin Flow parameters.
@Transactional on suspending functions is not supported yet, gh-23575
has been created for that purpose.
Closes gh-22915 | spring-tx/src/main/kotlin/org/springframework/transaction/reactive/TransactionalOperatorExtensions.kt | @@ -0,0 +1,29 @@
+package org.springframework.transaction.reactive
+
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.ExperimentalCoroutinesApi
+import kotlinx.coroutines.flow.Flow
+import kotlinx.coroutines.reactive.asFlow
+import kotlinx.coroutines.reactive.awaitFirstOrNull
+import kotlinx.coroutines... | true |
Other | spring-projects | spring-framework | 2b4eb610a7c8059e5b35c0e3807fc1335162c379.json | Add support for Coroutines transactions
This commit adds Coroutines extensions for
TransactionalOperator.transactional that accept suspending lambda or
Kotlin Flow parameters.
@Transactional on suspending functions is not supported yet, gh-23575
has been created for that purpose.
Closes gh-22915 | spring-tx/src/test/kotlin/org/springframework/transaction/reactive/TransactionalOperatorExtensionsTests.kt | @@ -0,0 +1,100 @@
+/*
+ * Copyright 2002-2019 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
... | true |
Other | spring-projects | spring-framework | 2b4eb610a7c8059e5b35c0e3807fc1335162c379.json | Add support for Coroutines transactions
This commit adds Coroutines extensions for
TransactionalOperator.transactional that accept suspending lambda or
Kotlin Flow parameters.
@Transactional on suspending functions is not supported yet, gh-23575
has been created for that purpose.
Closes gh-22915 | src/docs/asciidoc/languages/kotlin.adoc | @@ -574,6 +574,12 @@ class UserHandler(builder: WebClient.Builder) {
}
----
+=== Transactions
+
+Transactions on Coroutines are supported via the programmatic variant of the Reactive
+transaction management provided as of Spring Framework 5.2. `TransactionalOperator.transactional`
+extensions with suspending lambda... | true |
Other | spring-projects | spring-framework | 1b6814402cc6d348eb7884f9a5b75fd060a4623e.json | Publish Gradle metadata
This commit enables the publishing of Gradle metadata with Spring
Framework artifacts. This feature will be enabled by default with Gradle
6.0, so Spring Framework will consistently push this information in the
5.2.x generation.
Fixes gh-23503 | settings.gradle | @@ -5,6 +5,8 @@ pluginManagement {
}
}
+enableFeaturePreview("GRADLE_METADATA")
+
include "spring-aop"
include "spring-aspects"
include "spring-beans" | false |
Other | spring-projects | spring-framework | d927d31e135bcbc8b4a69ac3b3b3aab354d1670b.json | Remove reflection from ContentDispositionTests
Also minor refactoring in decoding in order to tolerate the absence of
a charset and treat as US_ASCII.
See gh-23485 | spring-web/src/main/java/org/springframework/http/ContentDisposition.java | @@ -208,7 +208,7 @@ public String toString() {
}
else {
sb.append("; filename*=");
- sb.append(encodeHeaderFieldParam(this.filename, this.charset));
+ sb.append(encodeFilename(this.filename, this.charset));
}
}
if (this.size != null) {
@@ -274,15 +274,23 @@ public static ContentDisposition ... | true |
Other | spring-projects | spring-framework | d927d31e135bcbc8b4a69ac3b3b3aab354d1670b.json | Remove reflection from ContentDispositionTests
Also minor refactoring in decoding in order to tolerate the absence of
a charset and treat as US_ASCII.
See gh-23485 | spring-web/src/test/java/org/springframework/http/ContentDispositionTests.java | @@ -16,16 +16,12 @@
package org.springframework.http;
-import java.lang.reflect.Method;
-import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
import java.time.ZonedDateTime;
import java.time.format.DateTimeFormatter;
import org.junit.jupiter.api.Test;
-import org.springframework.util.... | true |
Other | spring-projects | spring-framework | 280a1b8880d400af5f4fc958296e53e2e308f4a5.json | Make AbstractWebRequestMatcherTests abstract | spring-test/src/test/java/org/springframework/test/web/servlet/htmlunit/AbstractWebRequestMatcherTests.java | @@ -29,7 +29,7 @@
* @author Sam Brannen
* @since 4.2
*/
-public class AbstractWebRequestMatcherTests {
+abstract class AbstractWebRequestMatcherTests {
protected void assertMatches(WebRequestMatcher matcher, String url) throws MalformedURLException {
assertThat(matcher.matches(new WebRequest(new URL(url)))... | false |
Other | spring-projects | spring-framework | bb03cdf5d0c22179af4633b32100bef266f531f6.json | Remove global test dependency on Hamcrest
Hamcrest is now only used within spring-test for MockMvc support. | build.gradle | @@ -340,7 +340,6 @@ configure([rootProject] + javaProjects) { project ->
testCompile("org.mockito:mockito-core")
testCompile("org.mockito:mockito-junit-jupiter")
testCompile("io.mockk:mockk")
- testCompile("org.hamcrest:hamcrest")
testCompile("org.assertj:assertj-core")
// Pull in the latest JUnit 5 Lau... | false |
Other | spring-projects | spring-framework | be93d373307ba43bd85bfb3acda85947fecff714.json | Fix missing findbugs dependency for Dokka task | build.gradle | @@ -24,7 +24,7 @@ ext {
}
}
-configure(subprojects) { project ->
+configure(allprojects) { project ->
apply plugin: "io.spring.dependency-management"
dependencyManagement { | false |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | build.gradle | @@ -5,80 +5,299 @@ buildscript {
}
}
plugins {
- id 'io.spring.dependency-management' version '1.0.7.RELEASE' apply false
+ id 'io.spring.dependency-management' version '1.0.8.RELEASE' apply false
id 'org.jetbrains.kotlin.jvm' version '1.3.50' apply false
id 'org.jetbrains.dokka' version '0.9.18' apply false
... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | integration-tests/integration-tests.gradle | @@ -13,10 +13,10 @@ dependencies {
testCompile(project(":spring-test"))
testCompile(project(":spring-tx"))
testCompile(project(":spring-web"))
- testCompile("javax.inject:javax.inject:1")
- testCompile("javax.resource:javax.resource-api:1.7.1")
- testCompile("javax.servlet:javax.servlet-api:4.0.1")
- testCompile(... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-aop/spring-aop.gradle | @@ -3,7 +3,7 @@ description = "Spring AOP"
dependencies {
compile(project(":spring-beans"))
compile(project(":spring-core"))
- optional("org.aspectj:aspectjweaver:${aspectjVersion}")
- optional("org.apache.commons:commons-pool2:2.6.0")
- optional("com.jamonapi:jamon:2.81")
+ optional("org.aspectj:aspectjweaver")
+... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-aspects/spring-aspects.gradle | @@ -8,24 +8,24 @@ sourceSets.main.java.srcDirs = files()
sourceSets.test.aspectj.srcDir "src/test/java"
sourceSets.test.java.srcDirs = files()
-aspectj.version = aspectjVersion
+aspectj.version = dependencyManagement.managedVersions['org.aspectj:aspectjweaver']
dependencies {
aspect(project(":spring-orm"))
- c... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-beans/spring-beans.gradle | @@ -5,12 +5,12 @@ apply plugin: "kotlin"
dependencies {
compile(project(":spring-core"))
- optional("javax.inject:javax.inject:1")
+ optional("javax.inject:javax.inject")
optional("org.yaml:snakeyaml:1.24")
- optional("org.codehaus.groovy:groovy-xml:${groovyVersion}")
+ optional("org.codehaus.groovy:groovy-xml")... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-context-indexer/spring-context-indexer.gradle | @@ -2,8 +2,8 @@ description = "Spring Context Indexer"
dependencies {
testCompile(project(":spring-context"))
- testCompile("javax.inject:javax.inject:1")
- testCompile("javax.annotation:javax.annotation-api:1.3.2")
- testCompile("javax.transaction:javax.transaction-api:1.3")
- testCompile("org.eclipse.persistence... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-context-support/spring-context-support.gradle | @@ -6,20 +6,20 @@ dependencies {
compile(project(":spring-core"))
optional(project(":spring-jdbc")) // for Quartz support
optional(project(":spring-tx")) // for Quartz support
- optional("javax.activation:javax.activation-api:1.2.0")
- optional("javax.mail:javax.mail-api:1.6.2")
- optional("javax.cache:cache-ap... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-context/spring-context.gradle | @@ -3,45 +3,40 @@ description = "Spring Context"
apply plugin: "groovy"
apply plugin: "kotlin"
-dependencyManagement {
- imports {
- mavenBom "io.projectreactor:reactor-bom:${reactorVersion}"
- }
-}
-
dependencies {
compile(project(":spring-aop"))
compile(project(":spring-beans"))
compile(project(":spring-c... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-core/spring-core.gradle | @@ -2,13 +2,6 @@ description = "Spring Core"
apply plugin: "kotlin"
-dependencyManagement {
- imports {
- mavenBom "io.projectreactor:reactor-bom:${reactorVersion}"
- mavenBom "io.netty:netty-bom:${nettyVersion}"
- }
-}
-
// spring-core includes asm and repackages cglib, inlining both into the spring-core jar.
... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-jcl/spring-jcl.gradle | @@ -1,6 +1,6 @@
description = "Spring Commons Logging Bridge"
dependencies {
- optional("org.apache.logging.log4j:log4j-api:${log4jVersion}")
- optional("org.slf4j:slf4j-api:${slf4jVersion}")
+ optional("org.apache.logging.log4j:log4j-api")
+ optional("org.slf4j:slf4j-api")
} | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-jdbc/spring-jdbc.gradle | @@ -7,11 +7,11 @@ dependencies {
compile(project(":spring-core"))
compile(project(":spring-tx"))
optional(project(":spring-context")) // for JndiDataSourceLookup
- optional("javax.transaction:javax.transaction-api:1.3")
- optional("org.hsqldb:hsqldb:${hsqldbVersion}")
- optional("com.h2database:h2:1.4.199")
- op... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-jms/spring-jms.gradle | @@ -5,12 +5,12 @@ dependencies {
compile(project(":spring-core"))
compile(project(":spring-messaging"))
compile(project(":spring-tx"))
- compileOnly("javax.jms:javax.jms-api:2.0.1")
+ compileOnly("javax.jms:javax.jms-api")
optional(project(":spring-aop"))
optional(project(":spring-context"))
optional(projec... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-messaging/spring-messaging.gradle | @@ -2,43 +2,34 @@ description = "Spring Messaging"
apply plugin: "kotlin"
-dependencyManagement {
- imports {
- mavenBom "io.projectreactor:reactor-bom:${reactorVersion}"
- mavenBom "io.netty:netty-bom:${nettyVersion}"
- }
-}
-
dependencies {
compile(project(":spring-beans"))
compile(project(":spring-core")... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-orm/spring-orm.gradle | @@ -8,10 +8,10 @@ dependencies {
optional(project(":spring-aop"))
optional(project(":spring-context"))
optional(project(":spring-web"))
- optional("org.eclipse.persistence:org.eclipse.persistence.jpa:2.7.4")
- optional("org.hibernate:hibernate-core:5.4.4.Final")
+ optional("org.eclipse.persistence:org.eclipse.per... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-oxm/spring-oxm.gradle | @@ -57,23 +57,20 @@ task genJaxb {
dependencies {
compile(project(":spring-beans"))
compile(project(":spring-core"))
- optional("javax.xml.bind:jaxb-api:2.3.1")
- optional("javax.activation:javax.activation-api:1.2.0")
- optional("com.thoughtworks.xstream:xstream:1.4.11.1") {
- exclude group: "xpp3", module: "xpp... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-test/spring-test.gradle | @@ -2,13 +2,6 @@ description = "Spring TestContext Framework"
apply plugin: "kotlin"
-dependencyManagement {
- imports {
- mavenBom "io.projectreactor:reactor-bom:${reactorVersion}"
- mavenBom "io.netty:netty-bom:${nettyVersion}"
- }
-}
-
dependencies {
compile(project(":spring-core"))
optional(project(":sp... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-tx/spring-tx.gradle | @@ -1,25 +1,19 @@
description = "Spring Transaction"
-dependencyManagement {
- imports {
- mavenBom "io.projectreactor:reactor-bom:${reactorVersion}"
- }
-}
-
dependencies {
compile(project(":spring-beans"))
compile(project(":spring-core"))
optional(project(":spring-aop"))
optional(project(":spring-context... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-web/spring-web.gradle | @@ -2,89 +2,73 @@ description = "Spring Web"
apply plugin: "kotlin"
-dependencyManagement {
- imports {
- mavenBom "io.projectreactor:reactor-bom:${reactorVersion}"
- mavenBom "io.netty:netty-bom:${nettyVersion}"
- mavenBom "org.eclipse.jetty:jetty-bom:${jettyVersion}"
- }
-}
-
dependencies {
compile(project... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-webflux/spring-webflux.gradle | @@ -2,14 +2,6 @@ description = "Spring WebFlux"
apply plugin: "kotlin"
-dependencyManagement {
- imports {
- mavenBom "io.projectreactor:reactor-bom:${reactorVersion}"
- mavenBom "io.netty:netty-bom:${nettyVersion}"
- mavenBom "org.eclipse.jetty:jetty-bom:${jettyVersion}"
- }
-}
-
dependencies {
compile(proj... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-webmvc/spring-webmvc.gradle | @@ -2,85 +2,68 @@ description = "Spring Web MVC"
apply plugin: "kotlin"
-dependencyManagement {
- imports {
- mavenBom "io.projectreactor:reactor-bom:${reactorVersion}"
- mavenBom "org.eclipse.jetty:jetty-bom:${jettyVersion}"
- }
-}
-
dependencies {
compile(project(":spring-aop"))
compile(project(":spring-b... | true |
Other | spring-projects | spring-framework | d4089747b8e1f4d79497916286c581b8eb69d67f.json | Use dependency management in Framework build
Prior to this commit, the Spring Framework build would partially use the
dependency management plugin to import and enforce BOMs.
This commit applies the dependency management plugin to all Java
projects and regroups all version management declaration in the root
`build.gr... | spring-websocket/spring-websocket.gradle | @@ -1,26 +1,15 @@
description = "Spring WebSocket"
-dependencyManagement {
- imports {
- mavenBom "io.projectreactor:reactor-bom:${reactorVersion}"
- mavenBom "io.netty:netty-bom:${nettyVersion}"
- mavenBom "org.eclipse.jetty:jetty-bom:${jettyVersion}"
- }
-}
-
dependencies {
compile(project(":spring-context")... | true |
Other | spring-projects | spring-framework | c13941821a0aa5cacab68c4ab15f6c0dc19c9095.json | Treat Kotlin warnings as errors
Closes gh-23566 | build.gradle | @@ -86,6 +86,7 @@ configure(allprojects.findAll { (it.name != "framework-bom") } ) { project ->
kotlinOptions {
jvmTarget = "1.8"
freeCompilerArgs = ["-Xjsr305=strict"]
+ allWarningsAsErrors = true
}
}
compileTestKotlin { | true |
Other | spring-projects | spring-framework | c13941821a0aa5cacab68c4ab15f6c0dc19c9095.json | Treat Kotlin warnings as errors
Closes gh-23566 | spring-messaging/src/main/kotlin/org/springframework/messaging/rsocket/RSocketRequesterExtensions.kt | @@ -17,6 +17,7 @@
package org.springframework.messaging.rsocket
import io.rsocket.transport.ClientTransport
+import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.reactive.awaitFirstOrNull
import kotlinx.coroutines.reactive.awaitSingle
@@ -118,6 +119,7 ... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.