language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | 3b12beb1b8eb996ed43f73a10092bedc181b9ea4.json | Simplify if-statements with instanceof checks
Closes gh-25449 | spring-beans/src/testFixtures/java/org/springframework/beans/testfixture/beans/TestBean.java | @@ -469,7 +469,7 @@ public boolean equals(Object other) {
if (this == other) {
return true;
}
- if (other == null || !(other instanceof TestBean)) {
+ if (!(other instanceof TestBean)) {
return false;
}
TestBean tb2 = (TestBean) other; | true |
Other | spring-projects | spring-framework | 3b12beb1b8eb996ed43f73a10092bedc181b9ea4.json | Simplify if-statements with instanceof checks
Closes gh-25449 | spring-context-indexer/src/main/java/org/springframework/context/index/processor/TypeHelper.java | @@ -63,7 +63,7 @@ public String getType(TypeMirror type) {
if (type instanceof DeclaredType) {
DeclaredType declaredType = (DeclaredType) type;
Element enclosingElement = declaredType.asElement().getEnclosingElement();
- if (enclosingElement != null && enclosingElement instanceof TypeElement) {
+ if (enc... | true |
Other | spring-projects | spring-framework | 3b12beb1b8eb996ed43f73a10092bedc181b9ea4.json | Simplify if-statements with instanceof checks
Closes gh-25449 | spring-context/src/main/java/org/springframework/cache/annotation/SpringCacheAnnotationParser.java | @@ -223,7 +223,7 @@ private void validateCacheOperation(AnnotatedElement ae, CacheOperation operatio
@Override
public boolean equals(@Nullable Object other) {
- return (this == other || other instanceof SpringCacheAnnotationParser);
+ return (other instanceof SpringCacheAnnotationParser);
}
@Override | true |
Other | spring-projects | spring-framework | 3b12beb1b8eb996ed43f73a10092bedc181b9ea4.json | Simplify if-statements with instanceof checks
Closes gh-25449 | spring-expression/src/main/java/org/springframework/expression/spel/ast/OperatorInstanceof.java | @@ -62,7 +62,7 @@ public BooleanTypedValue getValueInternal(ExpressionState state) throws Evaluati
Object leftValue = left.getValue();
Object rightValue = right.getValue();
BooleanTypedValue result;
- if (rightValue == null || !(rightValue instanceof Class)) {
+ if (!(rightValue instanceof Class)) {
thro... | true |
Other | spring-projects | spring-framework | 3b12beb1b8eb996ed43f73a10092bedc181b9ea4.json | Simplify if-statements with instanceof checks
Closes gh-25449 | spring-test/src/main/java/org/springframework/test/context/web/AbstractGenericWebContextLoader.java | @@ -181,7 +181,7 @@ protected void configureWebResources(GenericWebApplicationContext context,
// If the WebApplicationContext has no parent or the parent is not a WebApplicationContext,
// set the current context as the root WebApplicationContext:
- if (parent == null || (!(parent instanceof WebApplicationCon... | true |
Other | spring-projects | spring-framework | 3b12beb1b8eb996ed43f73a10092bedc181b9ea4.json | Simplify if-statements with instanceof checks
Closes gh-25449 | spring-tx/src/main/java/org/springframework/transaction/annotation/Ejb3TransactionAnnotationParser.java | @@ -61,7 +61,7 @@ public TransactionAttribute parseTransactionAnnotation(javax.ejb.TransactionAttr
@Override
public boolean equals(@Nullable Object other) {
- return (this == other || other instanceof Ejb3TransactionAnnotationParser);
+ return (other instanceof Ejb3TransactionAnnotationParser);
}
@Overrid... | true |
Other | spring-projects | spring-framework | 3b12beb1b8eb996ed43f73a10092bedc181b9ea4.json | Simplify if-statements with instanceof checks
Closes gh-25449 | spring-tx/src/main/java/org/springframework/transaction/annotation/JtaTransactionAnnotationParser.java | @@ -82,7 +82,7 @@ protected TransactionAttribute parseTransactionAnnotation(AnnotationAttributes a
@Override
public boolean equals(@Nullable Object other) {
- return (this == other || other instanceof JtaTransactionAnnotationParser);
+ return (other instanceof JtaTransactionAnnotationParser);
}
@Override | true |
Other | spring-projects | spring-framework | 3b12beb1b8eb996ed43f73a10092bedc181b9ea4.json | Simplify if-statements with instanceof checks
Closes gh-25449 | spring-tx/src/main/java/org/springframework/transaction/annotation/SpringTransactionAnnotationParser.java | @@ -104,7 +104,7 @@ protected TransactionAttribute parseTransactionAnnotation(AnnotationAttributes a
@Override
public boolean equals(@Nullable Object other) {
- return (this == other || other instanceof SpringTransactionAnnotationParser);
+ return (other instanceof SpringTransactionAnnotationParser);
}
@O... | true |
Other | spring-projects | spring-framework | 3b12beb1b8eb996ed43f73a10092bedc181b9ea4.json | Simplify if-statements with instanceof checks
Closes gh-25449 | spring-web/src/main/java/org/springframework/web/util/pattern/PathPattern.java | @@ -167,8 +167,7 @@ public class PathPattern implements Comparable<PathPattern> {
if (elem instanceof CaptureTheRestPathElement || elem instanceof WildcardTheRestPathElement) {
this.catchAll = true;
}
- if (elem instanceof SeparatorPathElement && elem.next != null &&
- elem.next instanceof WildcardPa... | true |
Other | spring-projects | spring-framework | 3b12beb1b8eb996ed43f73a10092bedc181b9ea4.json | Simplify if-statements with instanceof checks
Closes gh-25449 | spring-websocket/src/main/java/org/springframework/web/socket/config/WebSocketMessageBrokerStats.java | @@ -96,7 +96,7 @@ private StompSubProtocolHandler initStompSubProtocolHandler() {
}
}
SubProtocolHandler defaultHandler = this.webSocketHandler.getDefaultProtocolHandler();
- if (defaultHandler != null && defaultHandler instanceof StompSubProtocolHandler) {
+ if (defaultHandler instanceof StompSubProtocolHa... | true |
Other | spring-projects | spring-framework | c7f44ff671fe13e8474316ebe074fdde8d413326.json | Fix links in Javadoc
Closes gh-25448 | spring-beans/src/test/java/org/springframework/beans/factory/xml/DuplicateBeanIdTests.java | @@ -37,8 +37,8 @@
*
* @author Chris Beams
* @since 3.1
- * @see org.springframework.beans.factory.xml.XmlBeanFactoryTests#testWithDuplicateName
- * @see org.springframework.beans.factory.xml.XmlBeanFactoryTests#testWithDuplicateNameInAlias
+ * @see org.springframework.beans.factory.xml.XmlBeanFactoryTests#withDup... | true |
Other | spring-projects | spring-framework | c7f44ff671fe13e8474316ebe074fdde8d413326.json | Fix links in Javadoc
Closes gh-25448 | spring-context/src/test/java/org/springframework/aop/framework/AbstractAopProxyTests.java | @@ -765,7 +765,7 @@ public void testIntroductionThrowsUncheckedException() throws Throwable {
@SuppressWarnings("serial")
class MyDi extends DelegatingIntroductionInterceptor implements TimeStamped {
/**
- * @see org.springframework.core.testfixture.util.TimeStamped#getTimeStamp()
+ * @see org.springfra... | true |
Other | spring-projects | spring-framework | c7f44ff671fe13e8474316ebe074fdde8d413326.json | Fix links in Javadoc
Closes gh-25448 | spring-core/src/main/java/org/springframework/core/env/ReadOnlySystemAttributesMap.java | @@ -27,7 +27,7 @@
* Read-only {@code Map<String, String>} implementation that is backed by system
* properties or environment variables.
*
- * <p>Used by {@link AbstractApplicationContext} when a {@link SecurityManager} prohibits
+ * <p>Used by {@link AbstractEnvironment} when a {@link SecurityManager} prohibits
... | true |
Other | spring-projects | spring-framework | c7f44ff671fe13e8474316ebe074fdde8d413326.json | Fix links in Javadoc
Closes gh-25448 | spring-core/src/test/java/org/springframework/core/annotation/AnnotatedElementUtilsTests.java | @@ -611,7 +611,7 @@ void findMergedAnnotationAttributesInheritedFromBridgedMethod() throws NoSuchMet
/**
* Bridge/bridged method setup code copied from
- * {@link org.springframework.core.BridgeMethodResolverTests#testWithGenericParameter()}.
+ * {@link org.springframework.core.BridgeMethodResolverTests#withGe... | true |
Other | spring-projects | spring-framework | c7f44ff671fe13e8474316ebe074fdde8d413326.json | Fix links in Javadoc
Closes gh-25448 | spring-core/src/test/java/org/springframework/core/annotation/MultipleComposedAnnotationsOnSingleAnnotatedElementTests.java | @@ -184,7 +184,7 @@ void findMultipleComposedAnnotationsOnBridgeMethod() throws Exception {
/**
* Bridge/bridged method setup code copied from
- * {@link org.springframework.core.BridgeMethodResolverTests#testWithGenericParameter()}.
+ * {@link org.springframework.core.BridgeMethodResolverTests#withGenericPara... | true |
Other | spring-projects | spring-framework | c7f44ff671fe13e8474316ebe074fdde8d413326.json | Fix links in Javadoc
Closes gh-25448 | spring-web/src/main/java/org/springframework/http/codec/protobuf/ProtobufDecoder.java | @@ -268,7 +268,7 @@ public Iterable<? extends Message> apply(DataBuffer input) {
*
* @return {code true} when the message size is parsed successfully, {code false} when the message size is
* truncated
- * @see <a href ="https://developers.google.com/protocol-buffers/docs/encoding#varints">Base 128 Varints... | true |
Other | spring-projects | spring-framework | c7f44ff671fe13e8474316ebe074fdde8d413326.json | Fix links in Javadoc
Closes gh-25448 | spring-webmvc/src/main/java/org/springframework/web/servlet/view/tiles3/AbstractSpringPreparerFactory.java | @@ -25,7 +25,7 @@
import org.springframework.web.servlet.DispatcherServlet;
/**
- * Abstract implementation of the Tiles {@link org.apache.tiles.preparer.PreparerFactory}
+ * Abstract implementation of the Tiles {@link org.apache.tiles.preparer.factory.PreparerFactory}
* interface, obtaining the current Spring We... | true |
Other | spring-projects | spring-framework | c7f44ff671fe13e8474316ebe074fdde8d413326.json | Fix links in Javadoc
Closes gh-25448 | spring-webmvc/src/main/java/org/springframework/web/servlet/view/tiles3/SimpleSpringPreparerFactory.java | @@ -28,7 +28,7 @@
import org.springframework.web.context.WebApplicationContext;
/**
- * Tiles {@link org.apache.tiles.preparer.PreparerFactory} implementation
+ * Tiles {@link org.apache.tiles.preparer.factory.PreparerFactory} implementation
* that expects preparer class names and builds preparer instances for th... | true |
Other | spring-projects | spring-framework | c7f44ff671fe13e8474316ebe074fdde8d413326.json | Fix links in Javadoc
Closes gh-25448 | spring-webmvc/src/main/java/org/springframework/web/servlet/view/tiles3/SpringBeanPreparerFactory.java | @@ -22,7 +22,7 @@
import org.springframework.web.context.WebApplicationContext;
/**
- * Tiles {@link org.apache.tiles.preparer.PreparerFactory} implementation
+ * Tiles {@link org.apache.tiles.preparer.factory.PreparerFactory} implementation
* that expects preparer bean names and obtains preparer beans from the
... | true |
Other | spring-projects | spring-framework | 2522fe029208b857e7b50c6621c12bfad1fd3dd0.json | Fix typos in Javadoc
Closes gh-25458 | spring-r2dbc/src/main/java/org/springframework/r2dbc/core/DatabaseClient.java | @@ -69,7 +69,7 @@ public interface DatabaseClient extends ConnectionAccessor {
/**
* Specify a {@link Supplier SQL supplier} that provides SQL to run.
- * Contract for specifying a SQL call along with options leading to
+ * Contract for specifying an SQL call along with options leading to
* the execution. T... | true |
Other | spring-projects | spring-framework | 2522fe029208b857e7b50c6621c12bfad1fd3dd0.json | Fix typos in Javadoc
Closes gh-25458 | spring-r2dbc/src/main/java/org/springframework/r2dbc/core/QueryOperation.java | @@ -21,7 +21,7 @@
/**
* Interface declaring a query operation that can be represented
* with a query string. This interface is typically implemented
- * by classes representing a SQL operation such as {@code SELECT},
+ * by classes representing an SQL operation such as {@code SELECT},
* {@code INSERT}, and such.... | true |
Other | spring-projects | spring-framework | 2719dcb29b871ec24d6f10028dce76e440691d20.json | Delete unused imports | spring-context-indexer/src/test/java/org/springframework/context/index/test/TestCompiler.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -21,8 +21,6 @@
import java.nio.file.Path;
... | false |
Other | spring-projects | spring-framework | b6c463676afac813d078681a6b5ab48cf24b8c39.json | Use Stream#toArray in TestCompiler
Closes gh-25453 | spring-context-indexer/src/test/java/org/springframework/context/index/test/TestCompiler.java | @@ -63,8 +63,7 @@ public TestCompiler(JavaCompiler compiler, Path tempDir) throws IOException {
public TestCompilationTask getTask(Class<?>... types) {
- List<String> names = Arrays.stream(types).map(Class::getName).collect(Collectors.toList());
- return getTask(names.toArray(new String[names.size()]));
+ retu... | false |
Other | spring-projects | spring-framework | 273812f9c5122014260a854d81c27fb2e0a017ac.json | Remove unnecessary escapes in regular expressions
See gh-24470 | spring-aop/src/main/java/org/springframework/aop/interceptor/CustomizableTraceInterceptor.java | @@ -147,7 +147,7 @@ public class CustomizableTraceInterceptor extends AbstractTraceInterceptor {
/**
* The {@code Pattern} used to match placeholders.
*/
- private static final Pattern PATTERN = Pattern.compile("\\$\\[\\p{Alpha}+\\]");
+ private static final Pattern PATTERN = Pattern.compile("\\$\\[\\p{Alpha}+]... | true |
Other | spring-projects | spring-framework | 273812f9c5122014260a854d81c27fb2e0a017ac.json | Remove unnecessary escapes in regular expressions
See gh-24470 | spring-core/src/main/java/org/springframework/util/AntPathMatcher.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -77,7 +77,7 @@ public class AntPathMatcher i... | true |
Other | spring-projects | spring-framework | 273812f9c5122014260a854d81c27fb2e0a017ac.json | Remove unnecessary escapes in regular expressions
See gh-24470 | spring-core/src/test/java/org/springframework/core/io/ClassPathResourceTests.java | @@ -43,7 +43,7 @@ class ClassPathResourceTests {
*/
private static final String FQ_RESOURCE_PATH_WITH_LEADING_SLASH = '/' + FQ_RESOURCE_PATH;
- private static final Pattern DESCRIPTION_PATTERN = Pattern.compile("^class path resource \\[(.+?)\\]$");
+ private static final Pattern DESCRIPTION_PATTERN = Pattern.com... | true |
Other | spring-projects | spring-framework | 273812f9c5122014260a854d81c27fb2e0a017ac.json | Remove unnecessary escapes in regular expressions
See gh-24470 | spring-test/src/main/java/org/springframework/test/context/util/TestContextResourceUtils.java | @@ -47,7 +47,7 @@ public abstract class TestContextResourceUtils {
private static final String SLASH = "/";
- private static final Pattern PLACEHOLDER_PATTERN = Pattern.compile(".*\\$\\{[^\\}]+\\}.*");
+ private static final Pattern PLACEHOLDER_PATTERN = Pattern.compile(".*\\$\\{[^}]+}.*");
/** | true |
Other | spring-projects | spring-framework | 273812f9c5122014260a854d81c27fb2e0a017ac.json | Remove unnecessary escapes in regular expressions
See gh-24470 | spring-web/src/main/java/org/springframework/web/util/UriComponents.java | @@ -48,7 +48,7 @@
public abstract class UriComponents implements Serializable {
/** Captures URI template variable names. */
- private static final Pattern NAMES_PATTERN = Pattern.compile("\\{([^/]+?)\\}");
+ private static final Pattern NAMES_PATTERN = Pattern.compile("\\{([^/]+?)}");
@Nullable | true |
Other | spring-projects | spring-framework | 273812f9c5122014260a854d81c27fb2e0a017ac.json | Remove unnecessary escapes in regular expressions
See gh-24470 | spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java | @@ -76,11 +76,11 @@ public class UriComponentsBuilder implements UriBuilder, Cloneable {
private static final String HOST_IPV4_PATTERN = "[^\\[/?#:]*";
- private static final String HOST_IPV6_PATTERN = "\\[[\\p{XDigit}\\:\\.]*[%\\p{Alnum}]*\\]";
+ private static final String HOST_IPV6_PATTERN = "\\[[\\p{XDigit}:.... | true |
Other | spring-projects | spring-framework | 273812f9c5122014260a854d81c27fb2e0a017ac.json | Remove unnecessary escapes in regular expressions
See gh-24470 | spring-web/src/main/java/org/springframework/web/util/pattern/RegexPathElement.java | @@ -35,7 +35,7 @@
*/
class RegexPathElement extends PathElement {
- private static final Pattern GLOB_PATTERN = Pattern.compile("\\?|\\*|\\{((?:\\{[^/]+?\\}|[^/{}]|\\\\[{}])+?)\\}");
+ private static final Pattern GLOB_PATTERN = Pattern.compile("\\?|\\*|\\{((?:\\{[^/]+?}|[^/{}]|\\\\[{}])+?)}");
private static ... | true |
Other | spring-projects | spring-framework | 273812f9c5122014260a854d81c27fb2e0a017ac.json | Remove unnecessary escapes in regular expressions
See gh-24470 | spring-webflux/src/main/java/org/springframework/web/reactive/result/view/RedirectView.java | @@ -53,7 +53,7 @@
*/
public class RedirectView extends AbstractUrlBasedView {
- private static final Pattern URI_TEMPLATE_VARIABLE_PATTERN = Pattern.compile("\\{([^/]+?)\\}");
+ private static final Pattern URI_TEMPLATE_VARIABLE_PATTERN = Pattern.compile("\\{([^/]+?)}");
private HttpStatus statusCode = HttpS... | true |
Other | spring-projects | spring-framework | 273812f9c5122014260a854d81c27fb2e0a017ac.json | Remove unnecessary escapes in regular expressions
See gh-24470 | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/transport/handler/AbstractHttpSendingTransportHandler.java | @@ -48,7 +48,7 @@ public abstract class AbstractHttpSendingTransportHandler extends AbstractTransp
/**
* Pattern for validating callback parameter values.
*/
- private static final Pattern CALLBACK_PARAM_PATTERN = Pattern.compile("[0-9A-Za-z_\\.]*");
+ private static final Pattern CALLBACK_PARAM_PATTERN = Patte... | true |
Other | spring-projects | spring-framework | 273812f9c5122014260a854d81c27fb2e0a017ac.json | Remove unnecessary escapes in regular expressions
See gh-24470 | spring-websocket/src/test/java/org/springframework/web/socket/config/MessageBrokerBeanDefinitionParserTests.java | @@ -303,16 +303,16 @@ public void stompBrokerRelay() {
WebSocketMessageBrokerStats stats = this.appContext.getBean(name, WebSocketMessageBrokerStats.class);
String actual = stats.toString();
String expected = "WebSocketSession\\[0 current WS\\(0\\)-HttpStream\\(0\\)-HttpPoll\\(0\\), " +
- "0 total, 0 closed... | true |
Other | spring-projects | spring-framework | 273812f9c5122014260a854d81c27fb2e0a017ac.json | Remove unnecessary escapes in regular expressions
See gh-24470 | spring-websocket/src/test/java/org/springframework/web/socket/config/annotation/WebSocketMessageBrokerConfigurationSupportTests.java | @@ -168,12 +168,12 @@ public void webSocketMessageBrokerStats() {
WebSocketMessageBrokerStats stats = config.getBean(name, WebSocketMessageBrokerStats.class);
String actual = stats.toString();
String expected = "WebSocketSession\\[0 current WS\\(0\\)-HttpStream\\(0\\)-HttpPoll\\(0\\), " +
- "0 total, 0 clos... | true |
Other | spring-projects | spring-framework | 14a32d13d0e4cc58c0a2446236fa343ce9f0a130.json | Fix typo in StringUtils class
Closes gh-24471 | spring-core/src/main/java/org/springframework/util/StringUtils.java | @@ -79,7 +79,7 @@ public abstract class StringUtils {
/**
* Check whether the given object (possibly a {@code String}) is empty.
- * This is effectly a shortcut for {@code !hasLength(String)}.
+ * This is effectively a shortcut for {@code !hasLength(String)}.
* <p>This method accepts any Object as an argume... | false |
Other | spring-projects | spring-framework | eeaae16b1792debe9aa942b16c8fec0acd543162.json | Remove dated mention of "local" bean attribute
Closes gh-24430 | src/docs/asciidoc/core/core-beans.adoc | @@ -1565,7 +1565,7 @@ is a dependency of the bean whose property is to be set, and it is initialized o
as needed before the property is set. (If the collaborator is a singleton bean, it may
already be initialized by the container.) All references are ultimately a reference to
another object. Scoping and validation d... | false |
Other | spring-projects | spring-framework | 2fcee5ae58e61c9c999606c9ff6ad3424644b4b5.json | Append unique number to WebFlux server log prefix
Closes gh-22039 | spring-web/src/main/java/org/springframework/http/server/reactive/ReactorServerHttpRequest.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -19,6 +19,7 @@
import java.net.InetSocketAd... | false |
Other | spring-projects | spring-framework | b142f8e66000bbf4ff86866fa47a6941bf06b453.json | Remove no-op code in URI encoding
Closes gh-24413 | spring-web/src/main/java/org/springframework/web/util/HierarchicalUriComponents.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -337,9 +337,6 @@ static String encodeUriComp... | false |
Other | spring-projects | spring-framework | ab70acb3256c8913996ee394240a43c9d02fae0b.json | Fix Additional Asciidoctor Warnings
Fix "unknown style for example block: INFO"
Issue gh-24427 | src/docs/asciidoc/web/webmvc.adoc | @@ -1683,7 +1683,7 @@ the issues that come with file extensions. Alternatively, if you must use file e
restricting them to a list of explicitly registered extensions through the
`mediaTypes` property of <<mvc-config-content-negotiation,ContentNegotiationConfigurer>>.
-[INFO]
+[NOTE]
====
Starting in 5.2.4, path e... | false |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/core/core-aop.adoc | @@ -3956,7 +3956,7 @@ for AspectJ LTW:
* `spring-aop.jar`
* `aspectjweaver.jar`
-If you use the <<aop-aj-ltw-environment-generic, Spring-provided agent to enable
+If you use the <<aop-aj-ltw-environments-generic, Spring-provided agent to enable
instrumentation>>, you also need:
* `spring-instrument.jar` | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/core/core-appendix.adoc | @@ -666,7 +666,7 @@ integrate such parsers into the Spring IoC container.
To facilitate authoring configuration files that use a schema-aware XML editor,
Spring's extensible XML configuration mechanism is based on XML Schema. If you are not
familiar with Spring's current XML configuration extensions that come with t... | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/core/core-beans.adoc | @@ -543,7 +543,7 @@ enforced by the container, though no longer by XML parsers.
You are not required to supply a `name` or an `id` for a bean. If you do not supply a
`name` or `id` explicitly, the container generates a unique name for that bean. However,
if you want to refer to that bean by name, through the use of ... | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/data-access.adoc | @@ -1314,7 +1314,7 @@ NOTE: The `proxy-target-class` attribute controls what type of transactional pro
created for classes annotated with the `@Transactional` annotation. If
`proxy-target-class` is set to `true`, class-based proxies are created. If
`proxy-target-class` is `false` or if the attribute is omitted, stan... | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/languages/dynamic-languages.adoc | @@ -589,7 +589,7 @@ in the same place as Spring's `GroovyObjectCustomizer`.
This section describes how to use BeanShell beans in Spring.
-The BeanShell homepage includes the following description: {JB}
+The BeanShell homepage includes the following description:
"`BeanShell is a small, free, embeddable Java sour... | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/languages/kotlin.adoc | @@ -748,12 +748,12 @@ as the following example shows:
=== Injecting Configuration Properties
-In Java, you can inject configuration properties by using annotations (such as `@Value("${property}")`).
+In Java, you can inject configuration properties by using annotations (such as pass:q[`@Value("${property}")`)].
H... | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/rsocket.adoc | @@ -781,7 +781,7 @@ use the following method arguments:
| `@DestinationVariable`
| Value extracted from the route based on variables in the mapping pattern, e.g.
- `@MessageMapping("find.radar.{id}")`.
+ pass:q[`@MessageMapping("find.radar.{id}")`].
| `@Header`
| Metadata value registered for extraction as de... | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/testing-webtestclient.adoc | @@ -1,5 +1,7 @@
[[webtestclient]]
= WebTestClient
+:doc-root: https://docs.spring.io
+:api-spring-framework: {doc-root}/spring-framework/docs/{spring-version}/javadoc-api/org/springframework
`WebTestClient` is a thin shell around <<web-reactive.adoc#webflux-client, WebClient>>,
using it to perform requests and ex... | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/web-reactive.adoc | @@ -10,7 +10,7 @@
This part of the documentation covers support for reactive-stack web applications built
on a https://www.reactive-streams.org/[Reactive Streams] API to run on non-blocking
servers, such as Netty, Undertow, and Servlet 3.1+ containers. Individual chapters cover
-the <<webflux, Spring WebFlux>> frame... | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/web/integration.adoc | @@ -9,7 +9,7 @@ particular architecture, technology, or methodology (although it certainly recom
some over others). This freedom to pick and choose the architecture, technology, or
methodology that is most relevant to a developer and their development team is
arguably most evident in the web area, where Spring provi... | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/web/webflux-functional.adoc | @@ -538,7 +538,7 @@ RouterFunction<ServerResponse> route = route()
.add(otherRoute) // <4>
.build();
----
-<1> `GET /person/{id}` with an `Accept` header that matches JSON is routed to
+<1> pass:q[`GET /person/{id}`] with an `Accept` header that matches JSON is routed to
`PersonHandler.getPerson`
<2> `GET /perso... | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/web/webflux.adoc | @@ -674,7 +674,7 @@ Spring WebFlux provides fine-grained support for CORS configuration through anno
controllers. However, when you use it with Spring Security, we advise relying on the built-in
`CorsFilter`, which must be ordered ahead of Spring Security's chain of filters.
-See the section on <<webflux-cors>> and... | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/web/webmvc-cors.adoc | @@ -325,7 +325,7 @@ as the following example shows:
[[mvc-cors-filter]]
== CORS Filter
-[.small]#<<web-reactive.adoc#webflux-cors-webfilter, WebFlux>>#
+[.small]#<<webflux-cors.adoc#webflux-cors-webfilter, WebFlux>>#
You can apply CORS support through the built-in
{api-spring-framework}/web/filter/CorsFilter.ht... | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/web/webmvc-functional.adoc | @@ -475,7 +475,7 @@ The following example shows the composition of four routes:
.add(otherRoute) // <4>
.build();
----
-<1> `GET /person/{id}` with an `Accept` header that matches JSON is routed to
+<1> pass:q[`GET /person/{id}`] with an `Accept` header that matches JSON is routed to
`PersonHandler.getPerson`
... | true |
Other | spring-projects | spring-framework | 754a8ca05ad4a9693961e308c9449c3e066aa35c.json | Fix Asciidoctor Warnings
- Fix "possible invalid reference" errors
- Add <filename>.adoc where necessary
- Remove invalid link to beans-servicelocator This section no longer exists
- Fix "skipping reference to missing attribute" errors
- Add pass macro to escape literals interpreted as attributes
- Add missing... | src/docs/asciidoc/web/websocket.adoc | @@ -512,9 +512,9 @@ https://host:port/myApp/myEndpoint/{server-id}/{session-id}/{transport}
where:
-* `{server-id}` is useful for routing requests in a cluster but is not used otherwise.
-* `{session-id}` correlates HTTP requests belonging to a SockJS session.
-* `{transport}` indicates the transport type (for exa... | true |
Other | spring-projects | spring-framework | 5a0b768a3d81c7f3190b64162f96f69f91ee90c6.json | Fix typo in Javadoc | spring-web/src/main/java/org/springframework/web/server/adapter/HttpWebHandlerAdapter.java | @@ -247,7 +247,7 @@ protected ServerWebExchange createExchange(ServerHttpRequest request, ServerHttp
* Format the request for logging purposes including HTTP method and URL.
* <p>By default this prints the HTTP method, the URL path, and the query.
* @param request the request to format
- * @return the String ... | false |
Other | spring-projects | spring-framework | 992e75303d598a4f3ef7ab912de588f9748961ac.json | Improve support for generics in Jackson codecs
Closes gh-23791 | spring-web/src/main/java/org/springframework/http/codec/json/AbstractJackson2Decoder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -153,15 +153,23 @@ public Object decode(Data... | true |
Other | spring-projects | spring-framework | 992e75303d598a4f3ef7ab912de588f9748961ac.json | Improve support for generics in Jackson codecs
Closes gh-23791 | spring-web/src/main/java/org/springframework/http/codec/json/Jackson2CodecSupport.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -20,6 +20,7 @@
import java.lang.reflect.Typ... | true |
Other | spring-projects | spring-framework | 992e75303d598a4f3ef7ab912de588f9748961ac.json | Improve support for generics in Jackson codecs
Closes gh-23791 | spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestMappingMessageConversionIntegrationTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -28,7 +28,6 @@
import io.reactivex.Flowab... | true |
Other | spring-projects | spring-framework | 54669c51c927cda27a80fb4a3e56a3207942bb66.json | Use Jackson SequenceWriter for streaming
Before this commit, the AbstractJackson2Encoder instantiated a
ObjectWriter per value. This is not an issue for single values or
non-streaming scenarios (which effectively are the same, because in the
latter values are collected into a list until offered to Jackson).
However, t... | spring-web/src/main/java/org/springframework/http/codec/json/AbstractJackson2Encoder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -17,7 +17,6 @@
package org.springframework.... | true |
Other | spring-projects | spring-framework | 54669c51c927cda27a80fb4a3e56a3207942bb66.json | Use Jackson SequenceWriter for streaming
Before this commit, the AbstractJackson2Encoder instantiated a
ObjectWriter per value. This is not an issue for single values or
non-streaming scenarios (which effectively are the same, because in the
latter values are collected into a list until offered to Jackson).
However, t... | spring-web/src/test/java/org/springframework/http/codec/json/Jackson2SmileEncoderTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -20,17 +20,18 @@
import java.io.UncheckedIO... | true |
Other | spring-projects | spring-framework | 5d8c5b0d9bf1ecb3b902ed55c320a4ea4fae0b38.json | Avoid NPE on comment SSE event
Closes gh-24389 | spring-web/src/main/java/org/springframework/http/codec/ServerSentEventHttpMessageReader.java | @@ -135,7 +135,10 @@ public Flux<Object> read(
return this.lineDecoder.decode(message.getBody(), STRING_TYPE, null, hints)
.doOnNext(limitTracker::afterLineParsed)
.bufferUntil(String::isEmpty)
- .map(lines -> buildEvent(lines, valueType, shouldWrap, hints));
+ .concatMap(lines -> {
+ Object even... | true |
Other | spring-projects | spring-framework | 5d8c5b0d9bf1ecb3b902ed55c320a4ea4fae0b38.json | Avoid NPE on comment SSE event
Closes gh-24389 | spring-web/src/test/java/org/springframework/http/codec/ServerSentEventHttpMessageReaderTests.java | @@ -161,6 +161,17 @@ public void readPojo() {
.verify();
}
+ @Test // gh-24389
+ void readPojoWithCommentOnly() {
+ MockServerHttpRequest request = MockServerHttpRequest.post("/")
+ .body(Flux.just(stringBuffer(":ping\n"), stringBuffer("\n")));
+
+ Flux<Object> data = this.reader.read(
+ ResolvableType... | true |
Other | spring-projects | spring-framework | b34404916a6640e2b30ca030db61186313b7a957.json | Update copyright date | spring-beans/src/main/java/org/springframework/beans/factory/support/PropertiesBeanDefinitionReader.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | true |
Other | spring-projects | spring-framework | b34404916a6640e2b30ca030db61186313b7a957.json | Update copyright date | spring-core/src/main/java/org/springframework/core/type/classreading/AnnotationMetadataReadingVisitor.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | true |
Other | spring-projects | spring-framework | 984f9de191b6efad763bf64168ddf40c6377b000.json | Fix Checkstyle violation
See gh-24375 | spring-context/src/test/java/example/gh24375/B.java | @@ -26,4 +26,4 @@
public @interface B {
String name() default "";
-}
\ No newline at end of file
+} | false |
Other | spring-projects | spring-framework | 2a2efbe6119621f3ac3667820ef28e9d9a90692b.json | Introduce @Disabled regression test for gh-24375 | spring-context/src/test/java/example/gh24375/A.java | @@ -0,0 +1,35 @@
+/*
+ * Copyright 2002-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 2a2efbe6119621f3ac3667820ef28e9d9a90692b.json | Introduce @Disabled regression test for gh-24375 | spring-context/src/test/java/example/gh24375/B.java | @@ -0,0 +1,29 @@
+/*
+ * Copyright 2002-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 2a2efbe6119621f3ac3667820ef28e9d9a90692b.json | Introduce @Disabled regression test for gh-24375 | spring-context/src/test/java/example/gh24375/MyComponent.java | @@ -0,0 +1,24 @@
+/*
+ * Copyright 2002-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | 2a2efbe6119621f3ac3667820ef28e9d9a90692b.json | Introduce @Disabled regression test for gh-24375 | spring-context/src/test/java/org/springframework/context/annotation/ClassPathScanningCandidateComponentProviderTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -21,6 +21,7 @@
import java.util.Set;
impor... | true |
Other | spring-projects | spring-framework | 3c0c0c0597e19b66d6cfebbf93b42f1c1fb2b4e5.json | Fix issue with new line handling in StompDecoder
Closes gh-23713 | spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompDecoder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -114,6 +114,10 @@ public List<Message<byte[]... | true |
Other | spring-projects | spring-framework | 3c0c0c0597e19b66d6cfebbf93b42f1c1fb2b4e5.json | Fix issue with new line handling in StompDecoder
Closes gh-23713 | spring-messaging/src/test/java/org/springframework/messaging/simp/stomp/StompDecoderTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -16,7 +16,6 @@
package org.springframewor... | true |
Other | spring-projects | spring-framework | 61d9787b984a573a7a22a9f86321572506082485.json | Publish a build scan only if authenticated
Previously, anyone could publish a scan and publishing was performed
if the GRADLE_ENTERPRISE_URL environment variable was set.
ge.spring.io has now been locked down to prohibit anonymous build scan
publishing. This commit aligns with this change by only attempting to
p... | build.gradle | @@ -17,7 +17,8 @@ buildScan {
obfuscation {
ipAddresses { addresses -> addresses.collect { address -> '0.0.0.0'} }
}
- publishAlwaysIf(System.getenv('GRADLE_ENTERPRISE_URL') != null)
+ publishAlways()
+ publishIfAuthenticated()
server = 'https://ge.spring.io'
}
| false |
Other | spring-projects | spring-framework | e864409c5faeaaa59130e81474cf337cad870cc2.json | Update Artifactory plugin to 4.12.0
Closes gh-24250 | build.gradle | @@ -6,7 +6,7 @@ plugins {
id 'io.spring.nohttp' version '0.0.4.RELEASE'
id 'de.undercouch.download' version '4.0.0'
id 'com.gradle.build-scan' version '3.1.1'
- id "com.jfrog.artifactory" version '4.11.0' apply false
+ id "com.jfrog.artifactory" version '4.12.0' apply false
id "io.freefair.aspectj" version "4.1... | false |
Other | spring-projects | spring-framework | 734db23f4eb99e4489a9349dd77de78e53f7f33d.json | Fix Checkstyle violation
See gh-gh-24358 | spring-jdbc/src/main/java/org/springframework/jdbc/core/namedparam/NamedParameterJdbcTemplate.java | @@ -430,7 +430,7 @@ protected ParsedSql getParsedSql(String sql) {
return NamedParameterUtils.parseSqlStatement(sql);
}
synchronized (this.parsedSqlCache) {
- return parsedSqlCache.computeIfAbsent(sql, NamedParameterUtils::parseSqlStatement);
+ return this.parsedSqlCache.computeIfAbsent(sql, NamedParamete... | false |
Other | spring-projects | spring-framework | f527ca7515dce934594235861e6361405d551f96.json | Update copyright date | spring-jdbc/src/main/java/org/springframework/jdbc/core/namedparam/NamedParameterJdbcTemplate.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | false |
Other | spring-projects | spring-framework | f1827cb1f94b365f31531002a6bf1aa43c51fe9e.json | Add tests for StringUtils split() method
Closes gh-24351 | spring-core/src/test/java/org/springframework/util/StringUtilsTests.java | @@ -745,4 +745,20 @@ void invalidLocaleWithLanguageTag() {
assertThat(StringUtils.parseLocale("")).isNull();
}
+ @Test
+ void split() {
+ assertThat(StringUtils.split("Hello, world", ",")).isEqualTo(new String[]{"Hello", " world"});
+ assertThat(StringUtils.split(",Hello world", ",")).isEqualTo(new String[]{""... | false |
Other | spring-projects | spring-framework | 8265db0ae1d83a1e204e602fa96e542c2677977f.json | Avoid synthesizing annotations unnecessarily
Commit 31fa1569c5 introduced initial support for avoiding unnecessary
annotation synthesis in the MergedAnnotation API; however, it only
avoided synthesis for annotations that do not declare any attributes.
This commit reworks this support to avoid unnecessary annotation
s... | spring-core/src/main/java/org/springframework/core/annotation/AnnotationTypeMapping.java | @@ -77,6 +77,8 @@ final class AnnotationTypeMapping {
private final Map<Method, List<Method>> aliasedBy;
+ private final boolean synthesizable;
+
private final Set<Method> claimedAliases = new HashSet<>();
@@ -101,6 +103,7 @@ final class AnnotationTypeMapping {
processAliases();
addConventionMappings(... | true |
Other | spring-projects | spring-framework | 8265db0ae1d83a1e204e602fa96e542c2677977f.json | Avoid synthesizing annotations unnecessarily
Commit 31fa1569c5 introduced initial support for avoiding unnecessary
annotation synthesis in the MergedAnnotation API; however, it only
avoided synthesis for annotations that do not declare any attributes.
This commit reworks this support to avoid unnecessary annotation
s... | spring-core/src/main/java/org/springframework/core/annotation/MergedAnnotation.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -479,11 +479,23 @@ <T extends Annotation> Me... | true |
Other | spring-projects | spring-framework | 8265db0ae1d83a1e204e602fa96e542c2677977f.json | Avoid synthesizing annotations unnecessarily
Commit 31fa1569c5 introduced initial support for avoiding unnecessary
annotation synthesis in the MergedAnnotation API; however, it only
avoided synthesis for annotations that do not declare any attributes.
This commit reworks this support to avoid unnecessary annotation
s... | spring-core/src/main/java/org/springframework/core/annotation/TypeMappedAnnotation.java | @@ -331,19 +331,20 @@ private <T extends Map<String, Object>> Object adaptValueForMapOptions(Method at
@Override
@SuppressWarnings("unchecked")
protected A createSynthesized() {
- if (this.rootAttributes instanceof Annotation) {
- // Nothing to synthesize?
- if (this.resolvedRootMirrors.length == 0 && this.r... | true |
Other | spring-projects | spring-framework | 8265db0ae1d83a1e204e602fa96e542c2677977f.json | Avoid synthesizing annotations unnecessarily
Commit 31fa1569c5 introduced initial support for avoiding unnecessary
annotation synthesis in the MergedAnnotation API; however, it only
avoided synthesis for annotations that do not declare any attributes.
This commit reworks this support to avoid unnecessary annotation
s... | spring-core/src/test/java/org/springframework/core/annotation/MergedAnnotationsTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -1380,14 +1380,22 @@ void synthesizeAlreadyS... | true |
Other | spring-projects | spring-framework | 0520ee0fb62464687b74e7ad3bc234c30baa3732.json | Use the Reactor Netty WebsocketServerSpec
Closes gh-24959 | spring-webflux/src/main/java/org/springframework/web/reactive/socket/server/upgrade/ReactorNettyRequestUpgradeStrategy.java | @@ -21,15 +21,16 @@
import reactor.core.publisher.Mono;
import reactor.netty.http.server.HttpServerResponse;
+import reactor.netty.http.server.WebsocketServerSpec;
import org.springframework.core.io.buffer.NettyDataBufferFactory;
import org.springframework.http.server.reactive.AbstractServerHttpResponse;
impor... | false |
Other | spring-projects | spring-framework | a9cc7b3edc59d5855dad75ffbf22bb5604162968.json | Improve tests for synthesized array of annotations | spring-core/src/test/java/org/springframework/core/annotation/MergedAnnotationsTests.java | @@ -1956,41 +1956,25 @@ void synthesizeNonPublicWithAttributeAliasesFromDifferentPackage() throws Except
}
@Test
- void synthesizeWithAttributeAliasesInNestedAnnotations() throws Exception {
+ void synthesizeWithArrayOfAnnotations() throws Exception {
Hierarchy hierarchy = HierarchyClass.class.getAnnotation(Hi... | false |
Other | spring-projects | spring-framework | 31fa1569c54649c7f3cbf7ec330e2a7232c7cd3a.json | Avoid synthesizing annotations unnecessarily
Prior to Spring Framework 5.2, some of our annotation utilities would
not synthesize an annotation if it was already synthesized or not
synthesizable (i.e., did not declare local aliases via @AliasFor and
did not declare attributes that could override attributes in the
meta... | spring-core/src/main/java/org/springframework/core/annotation/TypeMappedAnnotation.java | @@ -329,7 +329,18 @@ private <T extends Map<String, Object>> Object adaptValueForMapOptions(Method at
}
@Override
+ @SuppressWarnings("unchecked")
protected A createSynthesized() {
+ if (this.rootAttributes instanceof Annotation) {
+ // Nothing to synthesize?
+ if (this.resolvedRootMirrors.length == 0 && t... | true |
Other | spring-projects | spring-framework | 31fa1569c54649c7f3cbf7ec330e2a7232c7cd3a.json | Avoid synthesizing annotations unnecessarily
Prior to Spring Framework 5.2, some of our annotation utilities would
not synthesize an annotation if it was already synthesized or not
synthesizable (i.e., did not declare local aliases via @AliasFor and
did not declare attributes that could override attributes in the
meta... | spring-core/src/test/java/org/springframework/core/annotation/MergedAnnotationsTests.java | @@ -50,6 +50,7 @@
import org.springframework.util.MultiValueMap;
import org.springframework.util.ReflectionUtils;
+import static java.lang.annotation.RetentionPolicy.RUNTIME;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
import ... | true |
Other | spring-projects | spring-framework | fa5e8485abcc1a85af04aae42fd1045baeaeeb97.json | Update StackOverflow link | CONTRIBUTING.md | @@ -25,7 +25,7 @@ Please report unacceptable behavior to spring-code-of-conduct@pivotal.io.
#### Discuss
If you have a question, check Stack Overflow using
-[this list of tags](https://spring.io/questions), organized by Spring project.
+[this list of tags](https://stackoverflow.com/questions/tagged/spring+or+spring... | false |
Other | spring-projects | spring-framework | 87f28ce48ebc672ffaea31f9524a6e770a01aa1f.json | Simplify some control flow code
Closes gh-24925 | spring-web/src/main/java/org/springframework/web/bind/support/WebRequestDataBinder.java | @@ -130,7 +130,7 @@ public void bind(WebRequest request) {
*/
private boolean isMultipartRequest(WebRequest request) {
String contentType = request.getHeader("Content-Type");
- return (contentType != null && StringUtils.startsWithIgnoreCase(contentType, "multipart"));
+ return StringUtils.startsWithIgnoreCase... | true |
Other | spring-projects | spring-framework | 87f28ce48ebc672ffaea31f9524a6e770a01aa1f.json | Simplify some control flow code
Closes gh-24925 | spring-web/src/main/java/org/springframework/web/util/pattern/RegexPathElement.java | @@ -136,7 +136,7 @@ public boolean matches(int pathIndex, MatchingContext matchingContext) {
if (matches) {
if (isNoMorePattern()) {
if (matchingContext.determineRemainingPath &&
- (this.variableNames.isEmpty() ? true : textToMatch.length() > 0)) {
+ (this.variableNames.isEmpty() || textToMatch.leng... | true |
Other | spring-projects | spring-framework | df291a39b1f857846f870772772809d0a63c4d26.json | Fix Javadoc link in DefaultCorsProcessor
Closes gh-24921 | spring-web/src/main/java/org/springframework/web/cors/DefaultCorsProcessor.java | @@ -177,7 +177,7 @@ protected String checkOrigin(CorsConfiguration config, @Nullable String requestO
/**
* Check the HTTP method and determine the methods for the response of a
* pre-flight request. The default implementation simply delegates to
- * {@link org.springframework.web.cors.CorsConfiguration#checkOr... | true |
Other | spring-projects | spring-framework | df291a39b1f857846f870772772809d0a63c4d26.json | Fix Javadoc link in DefaultCorsProcessor
Closes gh-24921 | spring-web/src/main/java/org/springframework/web/cors/reactive/DefaultCorsProcessor.java | @@ -175,7 +175,7 @@ protected String checkOrigin(CorsConfiguration config, @Nullable String requestO
/**
* Check the HTTP method and determine the methods for the response of a
* pre-flight request. The default implementation simply delegates to
- * {@link CorsConfiguration#checkOrigin(String)}.
+ * {@link Co... | true |
Other | spring-projects | spring-framework | 1e1ea34e876bf15c804245b712332e53f1962496.json | Fix typo in Javadoc
See gh-24908 | spring-beans/src/main/java/org/springframework/beans/factory/ListableBeanFactory.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -39,7 +39,7 @@
* They will ignore any sing... | true |
Other | spring-projects | spring-framework | 1e1ea34e876bf15c804245b712332e53f1962496.json | Fix typo in Javadoc
See gh-24908 | spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -625,7 +625,7 @@ else if (!this.allowRawInje... | true |
Other | spring-projects | spring-framework | 75457c440c803f50ec74f7fbbae2cb1de51d4202.json | Fix typo in webflux-functional.adoc
Closes gh-24906 | src/docs/asciidoc/web/webflux-functional.adoc | @@ -16,7 +16,7 @@ the same <<web-reactive.adoc#webflux-reactive-spring-web>> foundation.
In WebFlux.fn, an HTTP request is handled with a `HandlerFunction`: a function that takes
`ServerRequest` and returns a delayed `ServerResponse` (i.e. `Mono<ServerResponse>`).
-Both the request as the response object have immut... | false |
Other | spring-projects | spring-framework | 39536acf9f28ddcae59bf89ae2c31b8e6a615494.json | Fix potential leak in MimeTypeUtils LRUCache
Prior to this commit, the `MimeTypeUtils` LRUCache would maintain a
queue to track least recently used cached values. In some cases,
concurrent access could create more entries in that unbounded queue than
expected and spend a significant amount of time removing entries in ... | spring-core/src/main/java/org/springframework/util/MimeTypeUtils.java | @@ -29,7 +29,7 @@
import java.util.Map;
import java.util.Random;
import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.ConcurrentLinkedQueue;
+import java.util.concurrent.ConcurrentLinkedDeque;
import java.util.concurrent.locks.ReadWriteLock;
import java.util.concurrent.locks.ReentrantReadWri... | false |
Other | spring-projects | spring-framework | e1951a098b6e732a5919e60dcd48375426ab801b.json | Improve performance of StringUtils.deleteAny() | spring-core/src/main/java/org/springframework/util/StringUtils.java | @@ -453,17 +453,17 @@ public static String deleteAny(String inString, @Nullable String charsToDelete)
return inString;
}
- StringBuilder sb = new StringBuilder(inString.length());
+ int lastCharIndex = 0;
+ char[] result = new char[inString.length()];
for (int i = 0; i < inString.length(); i++) {
cha... | true |
Other | spring-projects | spring-framework | e1951a098b6e732a5919e60dcd48375426ab801b.json | Improve performance of StringUtils.deleteAny() | spring-core/src/test/java/org/springframework/util/StringUtilsTests.java | @@ -306,7 +306,7 @@ void quote() {
void quoteIfString() {
assertThat(StringUtils.quoteIfString("myString")).isEqualTo("'myString'");
assertThat(StringUtils.quoteIfString("")).isEqualTo("''");
- assertThat(StringUtils.quoteIfString(5)).isEqualTo(Integer.valueOf(5));
+ assertThat(StringUtils.quoteIfString(5)).i... | true |
Other | spring-projects | spring-framework | a42944d3644e7b3100445b463574b2a52e37aa1e.json | Consolidate TxMgr lookup tests in the TCF
This commit consolidates TransactionManager lookup tests in the Spring
TestContext Framework (TCF), migrates some to JUnit Jupiter, simplifies
their implementations, and removes duplicated test cases. | spring-test/src/test/java/org/springframework/test/context/junit4/spr9645/LookUpTxMgrByTypeAndDefaultNameTests.java | @@ -1,85 +0,0 @@
-/*
- * Copyright 2002-2019 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * https://www.apache.org/licenses/LICENSE-2.0
-... | true |
Other | spring-projects | spring-framework | a42944d3644e7b3100445b463574b2a52e37aa1e.json | Consolidate TxMgr lookup tests in the TCF
This commit consolidates TransactionManager lookup tests in the Spring
TestContext Framework (TCF), migrates some to JUnit Jupiter, simplifies
their implementations, and removes duplicated test cases. | spring-test/src/test/java/org/springframework/test/context/junit4/spr9645/LookUpTxMgrByTypeAndNameTests.java | @@ -1,85 +0,0 @@
-/*
- * Copyright 2002-2019 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * https://www.apache.org/licenses/LICENSE-2.0
-... | true |
Other | spring-projects | spring-framework | a42944d3644e7b3100445b463574b2a52e37aa1e.json | Consolidate TxMgr lookup tests in the TCF
This commit consolidates TransactionManager lookup tests in the Spring
TestContext Framework (TCF), migrates some to JUnit Jupiter, simplifies
their implementations, and removes duplicated test cases. | spring-test/src/test/java/org/springframework/test/context/transaction/manager/LookUpTxMgrByTypeAndDefaultNameTests.java | @@ -0,0 +1,92 @@
+/*
+ * Copyright 2002-2020 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+... | true |
Other | spring-projects | spring-framework | a42944d3644e7b3100445b463574b2a52e37aa1e.json | Consolidate TxMgr lookup tests in the TCF
This commit consolidates TransactionManager lookup tests in the Spring
TestContext Framework (TCF), migrates some to JUnit Jupiter, simplifies
their implementations, and removes duplicated test cases. | spring-test/src/test/java/org/springframework/test/context/transaction/manager/LookUpTxMgrByTypeAndQualifierAtClassLevelTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -14,17 +14,15 @@
* limitations under the L... | true |
Other | spring-projects | spring-framework | a42944d3644e7b3100445b463574b2a52e37aa1e.json | Consolidate TxMgr lookup tests in the TCF
This commit consolidates TransactionManager lookup tests in the Spring
TestContext Framework (TCF), migrates some to JUnit Jupiter, simplifies
their implementations, and removes duplicated test cases. | spring-test/src/test/java/org/springframework/test/context/transaction/manager/LookUpTxMgrByTypeAndQualifierAtMethodLevelTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2019 the original author or authors.
+ * Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -14,17 +14,15 @@
* limitations under the L... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.