language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | cd0b517abfa7c4053297159ccf3fc9b29a7046c9.json | Improve Kotlin documentation | spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/server/CoRouterFunctionDsl.kt | @@ -27,16 +27,38 @@ import org.springframework.web.reactive.function.server.RouterFunctions.nest
import java.net.URI
/**
- * Coroutines variant of [router].
+ * Allow to create easily a WebFlux.fn [RouterFunction] with a [Coroutines router Kotlin DSL][CoRouterFunctionDsl].
+ *
+ * Example:
+ *
+ * ```
+ * @Configur... | true |
Other | spring-projects | spring-framework | cd0b517abfa7c4053297159ccf3fc9b29a7046c9.json | Improve Kotlin documentation | spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/server/RouterFunctionDsl.kt | @@ -26,18 +26,16 @@ import java.net.URI
import java.util.function.Supplier
/**
- * Allow to create easily a WebFlux.fn `RouterFunction<ServerResponse>` from a Kotlin
- * router DSL leveraging WebFlux.fn Java API ([RouterFunction], [RequestPredicate],
- * [HandlerFunction]).
+ * Allow to create easily a WebFlux.fn [... | true |
Other | spring-projects | spring-framework | cd0b517abfa7c4053297159ccf3fc9b29a7046c9.json | Improve Kotlin documentation | spring-webmvc/src/main/kotlin/org/springframework/web/servlet/function/RouterFunctionDsl.kt | @@ -25,18 +25,16 @@ import java.util.*
import java.util.function.Supplier
/**
- * Allow to create easily a WebMvc.fn `RouterFunction<ServerResponse>` from a Kotlin router
- * DSL leveraging WebMvc.fn the Java API ([RouterFunction], [RequestPredicate],
- * [HandlerFunction]).
+ * Allow to create easily a WebMvc.fn [... | true |
Other | spring-projects | spring-framework | cd0b517abfa7c4053297159ccf3fc9b29a7046c9.json | Improve Kotlin documentation | src/docs/asciidoc/languages/kotlin.adoc | @@ -229,10 +229,11 @@ which lets you deal with profiles and `Environment` for customizing
how beans are registered.
In the following example notice that:
- - Type inference usually allows to avoid specifying the type for bean references like `ref("bazBean")`
- - It is possible to use Kotlin top level functions to d... | true |
Other | spring-projects | spring-framework | 80ad60e91ba2492889cd689f576b4e5902c95048.json | Fix Javadoc for @Value | spring-beans/src/main/java/org/springframework/beans/factory/annotation/Value.java | @@ -30,7 +30,7 @@
* for dynamic resolution of handler method parameters, e.g. in Spring MVC.
*
* <p>A common use case is to assign default field values using
- * {@code #{systemProperties.myProp}} style expressions.
+ * <code>#{systemProperties.myProp}</code> style expressions.
*
* <p>Note that actual process... | false |
Other | spring-projects | spring-framework | bd414df9443f0bdda7681f32a1141b8041c8518d.json | Remove JMXMP from TestGroup
Due to the changes in a7425c81c000cd385417f0626759b3efc070c10b, we no
longer need to execute tests using the JMXMP protocol in PERFORMANCE
builds.
This commit removes the JMXMP constant from the TestGroup enum and
updates affected tests, thereby effectively including such tests in
the stan... | spring-context/src/test/java/org/springframework/jmx/AbstractMBeanServerTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -27,20 +27,11 @@
import org.springframework... | true |
Other | spring-projects | spring-framework | bd414df9443f0bdda7681f32a1141b8041c8518d.json | Remove JMXMP from TestGroup
Due to the changes in a7425c81c000cd385417f0626759b3efc070c10b, we no
longer need to execute tests using the JMXMP protocol in PERFORMANCE
builds.
This commit removes the JMXMP constant from the TestGroup enum and
updates affected tests, thereby effectively including such tests in
the stan... | spring-context/src/test/java/org/springframework/jmx/access/MBeanClientInterceptorTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -36,17 +36,12 @@
import org.springframework... | true |
Other | spring-projects | spring-framework | bd414df9443f0bdda7681f32a1141b8041c8518d.json | Remove JMXMP from TestGroup
Due to the changes in a7425c81c000cd385417f0626759b3efc070c10b, we no
longer need to execute tests using the JMXMP protocol in PERFORMANCE
builds.
This commit removes the JMXMP constant from the TestGroup enum and
updates affected tests, thereby effectively including such tests in
the stan... | spring-context/src/test/java/org/springframework/jmx/access/RemoteMBeanClientInterceptorTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -27,14 +27,9 @@
import org.junit.After;
... | true |
Other | spring-projects | spring-framework | bd414df9443f0bdda7681f32a1141b8041c8518d.json | Remove JMXMP from TestGroup
Due to the changes in a7425c81c000cd385417f0626759b3efc070c10b, we no
longer need to execute tests using the JMXMP protocol in PERFORMANCE
builds.
This commit removes the JMXMP constant from the TestGroup enum and
updates affected tests, thereby effectively including such tests in
the stan... | spring-context/src/test/java/org/springframework/jmx/support/ConnectorServerFactoryBeanTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -27,19 +27,13 @@
import javax.management.re... | true |
Other | spring-projects | spring-framework | bd414df9443f0bdda7681f32a1141b8041c8518d.json | Remove JMXMP from TestGroup
Due to the changes in a7425c81c000cd385417f0626759b3efc070c10b, we no
longer need to execute tests using the JMXMP protocol in PERFORMANCE
builds.
This commit removes the JMXMP constant from the TestGroup enum and
updates affected tests, thereby effectively including such tests in
the stan... | spring-context/src/test/java/org/springframework/jmx/support/MBeanServerConnectionFactoryBeanTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -26,28 +26,19 @@
import org.springframewo... | true |
Other | spring-projects | spring-framework | bd414df9443f0bdda7681f32a1141b8041c8518d.json | Remove JMXMP from TestGroup
Due to the changes in a7425c81c000cd385417f0626759b3efc070c10b, we no
longer need to execute tests using the JMXMP protocol in PERFORMANCE
builds.
This commit removes the JMXMP constant from the TestGroup enum and
updates affected tests, thereby effectively including such tests in
the stan... | spring-core/src/test/java/org/springframework/tests/AssumeTests.java | @@ -58,22 +58,22 @@ public void restoreOriginalTestGroups() {
@Test
public void assumeGroupWithNoActiveTestGroups() {
setTestGroups("");
- Assume.group(JMXMP);
+ Assume.group(LONG_RUNNING);
fail("assumption should have failed");
}
@Test
public void assumeGroupWithNoMatchingActiveTestGroup() {
set... | true |
Other | spring-projects | spring-framework | bd414df9443f0bdda7681f32a1141b8041c8518d.json | Remove JMXMP from TestGroup
Due to the changes in a7425c81c000cd385417f0626759b3efc070c10b, we no
longer need to execute tests using the JMXMP protocol in PERFORMANCE
builds.
This commit removes the JMXMP constant from the TestGroup enum and
updates affected tests, thereby effectively including such tests in
the stan... | spring-core/src/test/java/org/springframework/tests/TestGroup.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -50,12 +50,6 @@ public enum TestGroup {
*... | true |
Other | spring-projects | spring-framework | bd414df9443f0bdda7681f32a1141b8041c8518d.json | Remove JMXMP from TestGroup
Due to the changes in a7425c81c000cd385417f0626759b3efc070c10b, we no
longer need to execute tests using the JMXMP protocol in PERFORMANCE
builds.
This commit removes the JMXMP constant from the TestGroup enum and
updates affected tests, thereby effectively including such tests in
the stan... | spring-core/src/test/java/org/springframework/tests/TestGroupTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -71,7 +71,7 @@ public void parseMissing() {
... | true |
Other | spring-projects | spring-framework | ab1b8dee58532f704bd7cc41365a63226f6e5fd3.json | Ensure XmlEventDecoder compiles on JDK 9 and 11 | spring-web/src/main/java/org/springframework/http/codec/xml/XmlEventDecoder.java | @@ -18,6 +18,7 @@
import java.io.InputStream;
import java.util.ArrayList;
+import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.function.Function;
@@ -76,6 +77,7 @@
* by other decoders which are registered by default.
*
* @author Arjen Poutsma
+ * @author Sam Brannen
*... | false |
Other | spring-projects | spring-framework | 55b764bac323da88dedb55cbec290408ed0badf0.json | Remove unused import
See gh-22543 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestMappingHandlerMapping.java | @@ -23,7 +23,6 @@
import java.util.Map;
import java.util.Set;
import java.util.function.Predicate;
-import java.util.stream.Collectors;
import org.springframework.context.EmbeddedValueResolverAware;
import org.springframework.core.annotation.AnnotatedElementUtils; | false |
Other | spring-projects | spring-framework | a1668ad1c2b0a2b7209a244bc1c4483ad63f64e0.json | Fix Javadoc for PathPattern | spring-web/src/main/java/org/springframework/web/util/pattern/PathPattern.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -40,16 +40,16 @@
* <li>{@code ?} matches o... | false |
Other | spring-projects | spring-framework | 1221b0650b3e8b8a034faeaf09bfcb8916b961e2.json | Add MissingMergedAnnotation Tests
Add tests for `MissingMergedAnnotation`
See gh-21697 | spring-core/src/test/java/org/springframework/core/annotation/MissingMergedAnnotationTests.java | @@ -0,0 +1,292 @@
+/*
+ * Copyright 2002-2018 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+... | false |
Other | spring-projects | spring-framework | da557e741519f6d110bccd6f10e1f808c40d661b.json | Avoid expensive assertions in HttpRange
Closes gh-22742 | spring-web/src/main/java/org/springframework/http/HttpRange.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -68,18 +68,6 @@ public ResourceRegion toReso... | true |
Other | spring-projects | spring-framework | da557e741519f6d110bccd6f10e1f808c40d661b.json | Avoid expensive assertions in HttpRange
Closes gh-22742 | spring-web/src/main/java/org/springframework/http/codec/ResourceHttpMessageWriter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -53,9 +53,8 @@
/**
* {@code HttpMessageWr... | true |
Other | spring-projects | spring-framework | 4955d08f2891810627961ac4df660b9bed64a30b.json | Use DataBuffer.write in CharSequenceEncoder
Since SPR-17558, `DataBuffer` now offers a new method to write Strings
to them. This commit makes `CharSequenceEncoder` use that.
Issue: SPR-17558 | spring-core/src/main/java/org/springframework/core/codec/CharSequenceEncoder.java | @@ -16,9 +16,8 @@
package org.springframework.core.codec;
-import java.nio.ByteBuffer;
-import java.nio.CharBuffer;
import java.nio.charset.Charset;
+import java.nio.charset.CoderMalfunctionError;
import java.nio.charset.StandardCharsets;
import java.util.Map;
@@ -28,6 +27,7 @@
import org.springframework.cor... | true |
Other | spring-projects | spring-framework | 4955d08f2891810627961ac4df660b9bed64a30b.json | Use DataBuffer.write in CharSequenceEncoder
Since SPR-17558, `DataBuffer` now offers a new method to write Strings
to them. This commit makes `CharSequenceEncoder` use that.
Issue: SPR-17558 | spring-core/src/test/java/org/springframework/core/codec/CharSequenceEncoderTests.java | @@ -63,8 +63,6 @@ public void encode() {
.consumeNextWith(expectString(this.foo))
.consumeNextWith(expectString(this.bar))
.verifyComplete());
-
-
}
} | true |
Other | spring-projects | spring-framework | 6361b0cb236e62b24a07af5d0a20f42d78d4efaa.json | Write CharSequence instances to DataBuffers
Prior to this commit, one could write a `CharSequence` to an existing
`DataBuffer` instance by turning it into a byte array or `ByteBuffer`
first. This had the following disadvantages:
1. Memory allocation was not efficient (not leveraging pooled memory
when available)
2. D... | spring-core/src/main/java/org/springframework/core/io/buffer/DataBuffer.java | @@ -19,8 +19,15 @@
import java.io.InputStream;
import java.io.OutputStream;
import java.nio.ByteBuffer;
+import java.nio.CharBuffer;
+import java.nio.charset.Charset;
+import java.nio.charset.CharsetEncoder;
+import java.nio.charset.CoderResult;
+import java.nio.charset.CodingErrorAction;
import java.util.function.... | true |
Other | spring-projects | spring-framework | 6361b0cb236e62b24a07af5d0a20f42d78d4efaa.json | Write CharSequence instances to DataBuffers
Prior to this commit, one could write a `CharSequence` to an existing
`DataBuffer` instance by turning it into a byte array or `ByteBuffer`
first. This had the following disadvantages:
1. Memory allocation was not efficient (not leveraging pooled memory
when available)
2. D... | spring-core/src/main/java/org/springframework/core/io/buffer/DefaultDataBuffer.java | @@ -215,6 +215,15 @@ else if (newCapacity < oldCapacity) {
return this;
}
+ @Override
+ public DataBuffer ensureCapacity(int length) {
+ if (length > writableByteCount()) {
+ int newCapacity = calculateCapacity(this.writePosition + length);
+ capacity(newCapacity);
+ }
+ return this;
+ }
+
private stati... | true |
Other | spring-projects | spring-framework | 6361b0cb236e62b24a07af5d0a20f42d78d4efaa.json | Write CharSequence instances to DataBuffers
Prior to this commit, one could write a `CharSequence` to an existing
`DataBuffer` instance by turning it into a byte array or `ByteBuffer`
first. This had the following disadvantages:
1. Memory allocation was not efficient (not leveraging pooled memory
when available)
2. D... | spring-core/src/main/java/org/springframework/core/io/buffer/NettyDataBuffer.java | @@ -19,11 +19,14 @@
import java.io.InputStream;
import java.io.OutputStream;
import java.nio.ByteBuffer;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
import java.util.function.IntPredicate;
import io.netty.buffer.ByteBuf;
import io.netty.buffer.ByteBufInputStream;
import io.nett... | true |
Other | spring-projects | spring-framework | 6361b0cb236e62b24a07af5d0a20f42d78d4efaa.json | Write CharSequence instances to DataBuffers
Prior to this commit, one could write a `CharSequence` to an existing
`DataBuffer` instance by turning it into a byte array or `ByteBuffer`
first. This had the following disadvantages:
1. Memory allocation was not efficient (not leveraging pooled memory
when available)
2. D... | spring-core/src/test/java/org/springframework/core/io/buffer/DataBufferTests.java | @@ -20,6 +20,7 @@
import java.io.InputStream;
import java.io.OutputStream;
import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
import java.util.Arrays;
import org.junit.Test;
@@ -150,6 +151,70 @@ public void writeAndRead() {
release(buffer);
}
+ @Test
+ public void writeNullString() {
+... | true |
Other | spring-projects | spring-framework | 6361b0cb236e62b24a07af5d0a20f42d78d4efaa.json | Write CharSequence instances to DataBuffers
Prior to this commit, one could write a `CharSequence` to an existing
`DataBuffer` instance by turning it into a byte array or `ByteBuffer`
first. This had the following disadvantages:
1. Memory allocation was not efficient (not leveraging pooled memory
when available)
2. D... | spring-core/src/test/java/org/springframework/core/io/buffer/LeakAwareDataBuffer.java | @@ -19,6 +19,7 @@
import java.io.InputStream;
import java.io.OutputStream;
import java.nio.ByteBuffer;
+import java.nio.charset.Charset;
import java.util.function.IntPredicate;
import org.springframework.util.Assert;
@@ -139,6 +140,11 @@ public DataBuffer capacity(int newCapacity) {
return this.delegate.capac... | true |
Other | spring-projects | spring-framework | 6361b0cb236e62b24a07af5d0a20f42d78d4efaa.json | Write CharSequence instances to DataBuffers
Prior to this commit, one could write a `CharSequence` to an existing
`DataBuffer` instance by turning it into a byte array or `ByteBuffer`
first. This had the following disadvantages:
1. Memory allocation was not efficient (not leveraging pooled memory
when available)
2. D... | spring-web/src/main/java/org/springframework/http/server/reactive/UndertowServerHttpRequest.java | @@ -23,6 +23,7 @@
import java.net.URI;
import java.net.URISyntaxException;
import java.nio.ByteBuffer;
+import java.nio.charset.Charset;
import java.util.function.IntPredicate;
import javax.net.ssl.SSLSession;
@@ -294,6 +295,11 @@ public DataBuffer capacity(int newCapacity) {
return this.dataBuffer.capacity(... | true |
Other | spring-projects | spring-framework | 6361b0cb236e62b24a07af5d0a20f42d78d4efaa.json | Write CharSequence instances to DataBuffers
Prior to this commit, one could write a `CharSequence` to an existing
`DataBuffer` instance by turning it into a byte array or `ByteBuffer`
first. This had the following disadvantages:
1. Memory allocation was not efficient (not leveraging pooled memory
when available)
2. D... | spring-webflux/src/test/java/org/springframework/web/reactive/function/BodyInsertersTests.java | @@ -30,6 +30,7 @@
import java.util.Optional;
import com.fasterxml.jackson.annotation.JsonView;
+import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
import reactor.core.publisher.Flux;
@@ -44,6 +45,7 @@
import org.springframework.core.io.buffer.DataBufferUtils;
import org.springframework.co... | true |
Other | spring-projects | spring-framework | 09da10cc6c585995f4623793aa2b2f6a38b5284d.json | Propagate the cancel signal to the downstream
Issue: SPR-17609 | spring-web/src/main/java/org/springframework/http/server/reactive/ChannelSendOperator.java | @@ -338,6 +338,9 @@ private class WriteCompletionBarrier implements CoreSubscriber<Void>, Subscripti
private final WriteBarrier writeBarrier;
+ @Nullable
+ private Subscription subscription;
+
public WriteCompletionBarrier(CoreSubscriber<? super Void> subscriber, WriteBarrier writeBarrier) {
this.comp... | false |
Other | spring-projects | spring-framework | 44f39d4ce022398da9dfc5242bb28cb9abc558ed.json | Fix Java comment in Reference Manual | src/docs/asciidoc/core/core-beans.adoc | @@ -7366,7 +7366,7 @@ the abstract `createCommand()` method is overridden in such a way that it looks
@Bean
public CommandManager commandManager() {
// return new anonymous implementation of CommandManager with createCommand()
- overridden to return a new prototype Command object
+ // overridden to return a... | false |
Other | spring-projects | spring-framework | 65cb935333f2906be195b417df510afa19481c3a.json | Fix method name in comment
See gh-2057 | src/docs/asciidoc/core/core-beans.adoc | @@ -7365,7 +7365,7 @@ the abstract `createCommand()` method is overridden in such a way that it looks
@Bean
public CommandManager commandManager() {
- // return new anonymous implementation of CommandManager with command() overridden
+ // return new anonymous implementation of CommandManager with createCommand(... | false |
Other | spring-projects | spring-framework | 270099383be3020948967d9615143ad6d30675a7.json | Add protected method in StandaloneMockMvcBuilder
To allow sub-classes to register additional MVC infrastructure.
Issue: SPR-17520 | spring-test/src/main/java/org/springframework/test/web/servlet/setup/StandaloneMockMvcBuilder.java | @@ -399,6 +399,8 @@ private void registerMvcSingletons(StubWebApplicationContext wac) {
this.flashMapManager = new SessionFlashMapManager();
wac.addBean(DispatcherServlet.FLASH_MAP_MANAGER_BEAN_NAME, this.flashMapManager);
+
+ extendMvcSingletons(sc).forEach(wac::addBean);
}
private List<ViewResolver> in... | false |
Other | spring-projects | spring-framework | 9a13d93a6b12562ce62a2aaf53501463e487da64.json | Fix typo in javadoc
Closes gh-2049 | spring-web/src/main/java/org/springframework/web/method/HandlerTypePredicate.java | @@ -40,7 +40,7 @@
* <p>Composability methods on {@link Predicate} can be used :
* <pre class="code">
* Predicate<Class<?>> predicate =
- * HandlerTypePredicate.forAnnotation(RestController)
+ * HandlerTypePredicate.forAnnotation(RestController.class)
* .and(HandlerTypePredicate.forBasePackag... | false |
Other | spring-projects | spring-framework | 62f2a6352f237de3aa32a197df7f79afb2a9ed1b.json | Fix typo in webflux.adoc
Closes gh-2043 | src/docs/asciidoc/web/webflux.adoc | @@ -309,7 +309,7 @@ controllers and functional endpoints are built.
* For the client side, there is a basic `ClientHttpConnector` contract to perform HTTP
requests with non-blocking I/O and Reactive Streams back pressure, along with adapters for
https://github.com/reactor/reactor-netty[Reactor Netty] and for the rea... | false |
Other | spring-projects | spring-framework | 31318652ea6f1e4296289593b832c3648926092e.json | Fix typo in websocket.adoc
Closes gh-2046 | src/docs/asciidoc/web/websocket.adoc | @@ -1783,7 +1783,7 @@ as the following example shows:
[subs="verbatim,quotes"]
----
@Controller
- @MessageMapping("erd")
+ @MessageMapping("red")
public class RedController {
@MessageMapping("blue.{green}") | false |
Other | spring-projects | spring-framework | 18ac86ae16c57df4c18f4ae9156c51c185fc10d5.json | Fix typo in core-beans.adoc
Closes gh-2042 | src/docs/asciidoc/core/core-beans.adoc | @@ -6268,7 +6268,7 @@ of large applications by creating a static list of candidates at compilation tim
mode, all modules that are target of component scan must use this mechanism.
NOTE: Your existing `@ComponentScan` or `<context:component-scan` directives must stay as
-is to request the context to scan candidates ... | false |
Other | spring-projects | spring-framework | 3258ac1ec4159b3fe69cc9daad4ab054b90d0e6c.json | Expose request in WebClientResponseException
This commit exposes the request that lead to it in
WebClientResponseException, as a HttpRequest object.
Issue: SPR-17087 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClient.java | @@ -27,9 +27,11 @@
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
+import java.util.function.BiFunction;
import java.util.function.Consumer;
import java.util.function.Function;
import java.util.function.Predicate;
+import java.util.function.Supplier;
import org.reactivestreams.Pub... | true |
Other | spring-projects | spring-framework | 3258ac1ec4159b3fe69cc9daad4ab054b90d0e6c.json | Expose request in WebClientResponseException
This commit exposes the request that lead to it in
WebClientResponseException, as a HttpRequest object.
Issue: SPR-17087 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/UnknownHttpStatusCodeException.java | @@ -19,6 +19,8 @@
import java.nio.charset.Charset;
import org.springframework.http.HttpHeaders;
+import org.springframework.http.HttpRequest;
+import org.springframework.lang.Nullable;
/**
* Exception thrown when an unknown (or custom) HTTP status code is received.
@@ -31,11 +33,28 @@ public class UnknownHttpS... | true |
Other | spring-projects | spring-framework | 3258ac1ec4159b3fe69cc9daad4ab054b90d0e6c.json | Expose request in WebClientResponseException
This commit exposes the request that lead to it in
WebClientResponseException, as a HttpRequest object.
Issue: SPR-17087 | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClientResponseException.java | @@ -20,6 +20,7 @@
import java.nio.charset.StandardCharsets;
import org.springframework.http.HttpHeaders;
+import org.springframework.http.HttpRequest;
import org.springframework.http.HttpStatus;
import org.springframework.lang.Nullable;
@@ -44,6 +45,9 @@ public class WebClientResponseException extends WebClient... | true |
Other | spring-projects | spring-framework | 3258ac1ec4159b3fe69cc9daad4ab054b90d0e6c.json | Expose request in WebClientResponseException
This commit exposes the request that lead to it in
WebClientResponseException, as a HttpRequest object.
Issue: SPR-17087 | spring-webflux/src/test/java/org/springframework/web/reactive/function/client/WebClientIntegrationTests.java | @@ -18,6 +18,7 @@
import java.io.ByteArrayOutputStream;
import java.io.IOException;
+import java.net.URI;
import java.nio.file.Files;
import java.time.Duration;
import java.util.Arrays;
@@ -45,6 +46,8 @@
import org.springframework.core.io.buffer.DataBufferUtils;
import org.springframework.core.io.buffer.Defaul... | true |
Other | spring-projects | spring-framework | 7a5f8e03bc53ad78f76be82ecdd5fc8b8e86797a.json | Refine check for multiple subscribers
Commit #c187cb2 introduced proactive rejection of multiple subscribers
in ReactorClientHttpResponse, instead of hanging indefinitely as per
https://github.com/reactor/reactor-netty/issues/503.
However FluxReceive also rejects subsequent subscribers if the response
is consumed ful... | spring-web/src/main/java/org/springframework/http/client/reactive/ReactorClientHttpResponse.java | @@ -29,7 +29,6 @@
import org.springframework.http.HttpHeaders;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseCookie;
-import org.springframework.util.Assert;
import org.springframework.util.CollectionUtils;
import org.springframework.util.LinkedMultiValueMap;
import org.sprin... | true |
Other | spring-projects | spring-framework | 7a5f8e03bc53ad78f76be82ecdd5fc8b8e86797a.json | Refine check for multiple subscribers
Commit #c187cb2 introduced proactive rejection of multiple subscribers
in ReactorClientHttpResponse, instead of hanging indefinitely as per
https://github.com/reactor/reactor-netty/issues/503.
However FluxReceive also rejects subsequent subscribers if the response
is consumed ful... | spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClient.java | @@ -447,8 +447,9 @@ private <T extends Publisher<?>> T handleBody(ClientResponse response,
@SuppressWarnings("unchecked")
private <T> Mono<T> drainBody(ClientResponse response, Throwable ex) {
// Ensure the body is drained, even if the StatusHandler didn't consume it,
- // but ignore errors in case it did c... | true |
Other | spring-projects | spring-framework | 26b1c848b828baf80d535d88e946be3c66b64582.json | Fix typo in core-beans.adoc (Obvious Fix) | src/docs/asciidoc/core/core-beans.adoc | @@ -4034,7 +4034,7 @@ explicit ordering.
Classes that implement the `BeanPostProcessor` interface are special and are treated
differently by the container. All `BeanPostProcessor` instances and beans that they
directly reference are instantiated on startup, as part of the special startup phase
-of the `ApplicationCo... | false |
Other | spring-projects | spring-framework | 516c01c43853f52a03c53fd4046ffedf07dceb2d.json | Upgrade javadoc links to Jackson 2.9
Includes rollback to Hibernate ORM 5.1.16 for integration tests. | build.gradle | @@ -185,9 +185,9 @@ configure(allprojects) { project ->
"http://www.eclipse.org/aspectj/doc/released/aspectj5rt-api/",
"http://ehcache.org/apidocs/2.10.4",
"http://quartz-scheduler.org/api/2.2.1/",
- "http://fasterxml.github.io/jackson-core/javadoc/2.8/",
- "http://fasterxml.github.io/jackson-databind/javado... | false |
Other | spring-projects | spring-framework | b3aad549c9abfb04ea54346b4ce5690acf098025.json | Fix @since tag | spring-test/src/test/java/org/springframework/test/context/junit/jupiter/nested/NestedTestsWithSqlScriptsAndJUnitJupiterTests.java | @@ -40,7 +40,7 @@
* {@link Transactional @Transactional} in a JUnit Jupiter environment.
*
* @author Sam Brannen
- * @since 5.1.2
+ * @since 5.1.3
*/
@SpringJUnitConfig(PopulatedSchemaDatabaseConfig.class)
@Transactional | false |
Other | spring-projects | spring-framework | 3232825a5550742e8ab91ee540e731d341112ba0.json | Clarify @Async documentation
Issue: SPR-17458 | src/docs/asciidoc/integration.adoc | @@ -6681,10 +6681,11 @@ in combination with a custom pointcut.
==== Executor Qualification with `@Async`
By default, when specifying `@Async` on a method, the executor that is used is the
-one supplied to the "`annotation-driven`" element, as described earlier. However, you can use the `value`
-attribute of the `@A... | false |
Other | spring-projects | spring-framework | 86846507e2196ec8dbd7ea14bd9ee0f218761ddc.json | Remove trailing whitespace | src/docs/asciidoc/integration.adoc | @@ -3413,7 +3413,7 @@ The following table summarizes these registration behaviors:
previous instance).
|===
-The values in the preceding table are defined as enums on the `RegistrationPolicy` class.
+The values in the preceding table are defined as enums on the `RegistrationPolicy` class.
If you want to change ... | false |
Other | spring-projects | spring-framework | c2b55e60cd6d802114b8ea07de54c28b0873f65c.json | Fix failing test
After the fix #658c7f for lenient parsing of dates, the error message
raised uses an HttpHeaders-formatted date. As a result the test
verifying the error message fails in the beginning of the month between
1-9 because it's formatted slightly differently. | spring-test/src/test/java/org/springframework/test/web/servlet/samples/standalone/resultmatchers/HeaderAssertionTests.java | @@ -24,6 +24,7 @@
import org.junit.Before;
import org.junit.Test;
+import org.springframework.http.HttpHeaders;
import org.springframework.http.ResponseEntity;
import org.springframework.stereotype.Controller;
import org.springframework.test.web.Person;
@@ -56,20 +57,19 @@ public class HeaderAssertionTests {
... | false |
Other | spring-projects | spring-framework | 2a41067a17e0acfc5098cc4cfba2399746f92d15.json | Update reactive streams spec URL in ref docs | src/docs/asciidoc/web/webflux.adoc | @@ -58,7 +58,7 @@ code, it becomes important to control the rate of events so that a fast producer
overwhelm its destination.
Reactive Streams is a
-https://github.com/reactive-streams/reactive-streams-jvm/blob/v1.0.1/README.md#specification[small spec]
+https://github.com/reactive-streams/reactive-streams-jvm/blob... | false |
Other | spring-projects | spring-framework | 42a95b8f35708612e40ad3b2ecd215da3216b6c1.json | Fix typo and polish | spring-test/src/main/java/org/springframework/test/web/reactive/server/WiretapConnector.java | @@ -192,8 +192,8 @@ public Mono<byte[]> getContent() {
//noinspection ConstantConditions
(this.publisher != null ? this.publisher : this.publisherNested)
.onErrorMap(ex -> new IllegalStateException(
- "Content was not been consumed and " +
- "an error was raised on attempt to produ... | false |
Other | spring-projects | spring-framework | 8df3fd3f1dfb20d649ec7300d5c1840cc53f7575.json | Remove unnecessary null check | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/RequestMappingInfo.java | @@ -201,7 +201,7 @@ else if (this.name != null) {
return this.name;
}
else {
- return (other.name != null ? other.name : null);
+ return other.name;
}
}
| false |
Other | spring-projects | spring-framework | 2146e137873f51cddcff9b1d01bd6c229778098c.json | Fix absolute paths when transforming resources
Prior to this commit, `ResourceTransformerSupport.toAbsolutePath`
would call `StringUtils.applyRelativePath` in all cases. But this
implementation is prepending the given path even if the relative path
starts with `"/"`.
This commit skips the entire operation if the give... | spring-webflux/src/main/java/org/springframework/web/reactive/resource/ResourceTransformerSupport.java | @@ -96,7 +96,7 @@ protected Mono<String> resolveUrlPath(String resourcePath, ServerWebExchange exc
*/
protected String toAbsolutePath(String path, ServerWebExchange exchange) {
String requestPath = exchange.getRequest().getURI().getPath();
- String absolutePath = StringUtils.applyRelativePath(requestPath, path... | true |
Other | spring-projects | spring-framework | 2146e137873f51cddcff9b1d01bd6c229778098c.json | Fix absolute paths when transforming resources
Prior to this commit, `ResourceTransformerSupport.toAbsolutePath`
would call `StringUtils.applyRelativePath` in all cases. But this
implementation is prepending the given path even if the relative path
starts with `"/"`.
This commit skips the entire operation if the give... | spring-webflux/src/test/java/org/springframework/web/reactive/resource/ResourceTransformerSupportTests.java | @@ -106,6 +106,16 @@ public void resolveUrlPathWithRelativePathInParentDirectory() {
assertEquals("../bar-11e16cf79faee7ac698c805cf28248d2.css", actual);
}
+ @Test
+ public void toAbsolutePath() {
+ MockServerWebExchange exchange = MockServerWebExchange.from(MockServerHttpRequest.get("/resources/main.css"));
+ ... | true |
Other | spring-projects | spring-framework | 2146e137873f51cddcff9b1d01bd6c229778098c.json | Fix absolute paths when transforming resources
Prior to this commit, `ResourceTransformerSupport.toAbsolutePath`
would call `StringUtils.applyRelativePath` in all cases. But this
implementation is prepending the given path even if the relative path
starts with `"/"`.
This commit skips the entire operation if the give... | spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceTransformerSupport.java | @@ -94,10 +94,13 @@ protected String resolveUrlPath(String resourcePath, HttpServletRequest request,
* @return the absolute request path for the given resource path
*/
protected String toAbsolutePath(String path, HttpServletRequest request) {
- ResourceUrlProvider urlProvider = findResourceUrlProvider(request)... | true |
Other | spring-projects | spring-framework | 2146e137873f51cddcff9b1d01bd6c229778098c.json | Fix absolute paths when transforming resources
Prior to this commit, `ResourceTransformerSupport.toAbsolutePath`
would call `StringUtils.applyRelativePath` in all cases. But this
implementation is prepending the given path even if the relative path
starts with `"/"`.
This commit skips the entire operation if the give... | spring-webmvc/src/test/java/org/springframework/web/servlet/resource/ResourceTransformerSupportTests.java | @@ -41,7 +41,7 @@ public class ResourceTransformerSupportTests {
private TestResourceTransformerSupport transformer;
- private final MockHttpServletRequest request = new MockHttpServletRequest("GET", "");
+ private final MockHttpServletRequest request = new MockHttpServletRequest("GET", "/");
@Before
@@ -98... | true |
Other | spring-projects | spring-framework | 7a8a2d96080188838c135ed409e50e2467cd9f05.json | Fix HttpMessageWriter tests
Issue: SPR-17419 | spring-web/src/test/java/org/springframework/http/codec/FormHttpMessageWriterTests.java | @@ -20,22 +20,22 @@
import org.junit.Test;
import reactor.core.publisher.Mono;
+import reactor.test.StepVerifier;
import org.springframework.core.ResolvableType;
+import org.springframework.core.io.buffer.AbstractDataBufferAllocatingTestCase;
import org.springframework.http.HttpHeaders;
import org.springframew... | true |
Other | spring-projects | spring-framework | 7a8a2d96080188838c135ed409e50e2467cd9f05.json | Fix HttpMessageWriter tests
Issue: SPR-17419 | spring-web/src/test/java/org/springframework/http/codec/ServerSentEventHttpMessageWriterTests.java | @@ -23,6 +23,7 @@
import java.util.Map;
import com.fasterxml.jackson.databind.ObjectMapper;
+import org.junit.Before;
import org.junit.Test;
import org.reactivestreams.Publisher;
import reactor.core.publisher.Flux;
@@ -31,6 +32,8 @@
import org.springframework.core.ResolvableType;
import org.springframework.c... | true |
Other | spring-projects | spring-framework | 7a8a2d96080188838c135ed409e50e2467cd9f05.json | Fix HttpMessageWriter tests
Issue: SPR-17419 | spring-web/src/test/java/org/springframework/mock/http/server/reactive/test/MockServerHttpResponse.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -27,6 +27,7 @@
import reactor.core.publishe... | true |
Other | spring-projects | spring-framework | 65b46079a2d58899b1d1c146cd347d3701be6d13.json | Replace stream with loop in RequestCondition's | spring-webflux/src/main/java/org/springframework/web/reactive/result/condition/HeadersRequestCondition.java | @@ -142,7 +142,13 @@ public int compareTo(HeadersRequestCondition other, ServerWebExchange exchange)
}
private long getValueMatchCount(Set<HeaderExpression> expressions) {
- return expressions.stream().filter(e -> e.getValue() != null && !e.isNegated()).count();
+ long count = 0;
+ for (HeaderExpression e : ex... | true |
Other | spring-projects | spring-framework | 65b46079a2d58899b1d1c146cd347d3701be6d13.json | Replace stream with loop in RequestCondition's | spring-webflux/src/main/java/org/springframework/web/reactive/result/condition/ParamsRequestCondition.java | @@ -124,7 +124,13 @@ public int compareTo(ParamsRequestCondition other, ServerWebExchange exchange) {
}
private long getValueMatchCount(Set<ParamExpression> expressions) {
- return expressions.stream().filter(e -> e.getValue() != null && !e.isNegated()).count();
+ long count = 0;
+ for (ParamExpression e : exp... | true |
Other | spring-projects | spring-framework | 65b46079a2d58899b1d1c146cd347d3701be6d13.json | Replace stream with loop in RequestCondition's | spring-webflux/src/main/java/org/springframework/web/reactive/result/condition/PatternsRequestCondition.java | @@ -24,7 +24,6 @@
import java.util.Set;
import java.util.SortedSet;
import java.util.TreeSet;
-import java.util.stream.Collectors;
import org.springframework.http.server.PathContainer;
import org.springframework.lang.Nullable;
@@ -53,7 +52,7 @@ public PatternsRequestCondition(PathPattern... patterns) {
}
/... | true |
Other | spring-projects | spring-framework | 65b46079a2d58899b1d1c146cd347d3701be6d13.json | Replace stream with loop in RequestCondition's | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/condition/HeadersRequestCondition.java | @@ -142,7 +142,13 @@ public int compareTo(HeadersRequestCondition other, HttpServletRequest request)
}
private long getValueMatchCount(Set<HeaderExpression> expressions) {
- return expressions.stream().filter(e -> e.getValue() != null && !e.isNegated()).count();
+ long count = 0;
+ for (HeaderExpression e : ex... | true |
Other | spring-projects | spring-framework | 65b46079a2d58899b1d1c146cd347d3701be6d13.json | Replace stream with loop in RequestCondition's | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/condition/ParamsRequestCondition.java | @@ -127,7 +127,13 @@ public int compareTo(ParamsRequestCondition other, HttpServletRequest request) {
}
private long getValueMatchCount(Set<ParamExpression> expressions) {
- return expressions.stream().filter(e -> e.getValue() != null && !e.isNegated()).count();
+ long count = 0;
+ for (ParamExpression e : exp... | true |
Other | spring-projects | spring-framework | 4ca27db0ccc35b31ac7a9fdfd66a9a6fd91d13ca.json | Copy cookies to ServerResponse builders
See gh-22351 | spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultEntityResponseBuilder.java | @@ -126,8 +126,8 @@ public EntityResponse.Builder<T> header(String headerName, String... headerValue
}
@Override
- public EntityResponse.Builder<T> headers(HttpHeaders headers) {
- this.headers.putAll(headers);
+ public EntityResponse.Builder<T> headers(Consumer<HttpHeaders> headersConsumer) {
+ headersConsumer... | true |
Other | spring-projects | spring-framework | 4ca27db0ccc35b31ac7a9fdfd66a9a6fd91d13ca.json | Copy cookies to ServerResponse builders
See gh-22351 | spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultRenderingResponseBuilder.java | @@ -138,8 +138,8 @@ public RenderingResponse.Builder header(String headerName, String... headerValue
}
@Override
- public RenderingResponse.Builder headers(HttpHeaders headers) {
- this.headers.putAll(headers);
+ public RenderingResponse.Builder headers(Consumer<HttpHeaders> headersConsumer) {
+ headersConsumer... | true |
Other | spring-projects | spring-framework | 4ca27db0ccc35b31ac7a9fdfd66a9a6fd91d13ca.json | Copy cookies to ServerResponse builders
See gh-22351 | spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultServerResponseBuilder.java | @@ -189,33 +189,37 @@ public ServerResponse build(
@Override
public ServerResponse body(Object body) {
return DefaultEntityResponseBuilder.fromObject(body)
- .headers(this.headers)
.status(this.statusCode)
+ .headers(headers -> headers.putAll(this.headers))
+ .cookies(cookies -> cookies.addAll(this... | true |
Other | spring-projects | spring-framework | 4ca27db0ccc35b31ac7a9fdfd66a9a6fd91d13ca.json | Copy cookies to ServerResponse builders
See gh-22351 | spring-webmvc/src/main/java/org/springframework/web/servlet/function/EntityResponse.java | @@ -86,12 +86,15 @@ static <T> Builder<T> fromObject(T t, ParameterizedTypeReference<T> entityType)
Builder<T> header(String headerName, String... headerValues);
/**
- * Copy the given headers into the entity's headers map.
- * @param headers the existing HttpHeaders to copy from
+ * Manipulate this respo... | true |
Other | spring-projects | spring-framework | 4ca27db0ccc35b31ac7a9fdfd66a9a6fd91d13ca.json | Copy cookies to ServerResponse builders
See gh-22351 | spring-webmvc/src/main/java/org/springframework/web/servlet/function/RenderingResponse.java | @@ -119,12 +119,15 @@ interface Builder {
Builder header(String headerName, String... headerValues);
/**
- * Copy the given headers into the entity's headers map.
- * @param headers the existing HttpHeaders to copy from
+ * Manipulate this response's headers with the given consumer. The
+ * headers prov... | true |
Other | spring-projects | spring-framework | 4ca27db0ccc35b31ac7a9fdfd66a9a6fd91d13ca.json | Copy cookies to ServerResponse builders
See gh-22351 | spring-webmvc/src/test/java/org/springframework/web/servlet/function/DefaultEntityResponseBuilderTests.java | @@ -154,7 +154,9 @@ public void headers() {
String body = "foo";
HttpHeaders headers = new HttpHeaders();
headers.set("foo", "bar");
- EntityResponse<String> result = EntityResponse.fromObject(body).headers(headers).build();
+ EntityResponse<String> result = EntityResponse.fromObject(body)
+ .headers(h ->... | true |
Other | spring-projects | spring-framework | 4ca27db0ccc35b31ac7a9fdfd66a9a6fd91d13ca.json | Copy cookies to ServerResponse builders
See gh-22351 | spring-webmvc/src/test/java/org/springframework/web/servlet/function/DefaultRenderingResponseTests.java | @@ -78,7 +78,9 @@ public void status() throws Exception {
public void headers() throws Exception {
HttpHeaders headers = new HttpHeaders();
headers.set("foo", "bar");
- RenderingResponse result = RenderingResponse.create("foo").headers(headers).build();
+ RenderingResponse result = RenderingResponse.create("f... | true |
Other | spring-projects | spring-framework | c152d246a8ce99628ea5b28f91e96cfbeb434186.json | Copy cookies and hints to ServerResponse builders
Closes gh-22351 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultEntityResponseBuilder.java | @@ -157,6 +157,12 @@ public EntityResponse.Builder<T> hint(String key, Object value) {
return this;
}
+ @Override
+ public EntityResponse.Builder<T> hints(Consumer<Map<String, Object>> hintsConsumer) {
+ hintsConsumer.accept(this.hints);
+ return this;
+ }
+
@Override
public EntityResponse.Builder<T> lastM... | true |
Other | spring-projects | spring-framework | c152d246a8ce99628ea5b28f91e96cfbeb434186.json | Copy cookies and hints to ServerResponse builders
Closes gh-22351 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultServerResponseBuilder.java | @@ -165,6 +165,12 @@ public ServerResponse.BodyBuilder hint(String key, Object value) {
return this;
}
+ @Override
+ public ServerResponse.BodyBuilder hints(Consumer<Map<String, Object>> hintsConsumer) {
+ hintsConsumer.accept(this.hints);
+ return this;
+ }
+
@Override
public ServerResponse.BodyBuilder la... | true |
Other | spring-projects | spring-framework | c152d246a8ce99628ea5b28f91e96cfbeb434186.json | Copy cookies and hints to ServerResponse builders
Closes gh-22351 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/EntityResponse.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -19,6 +19,7 @@
import java.net.URI;
import... | true |
Other | spring-projects | spring-framework | c152d246a8ce99628ea5b28f91e96cfbeb434186.json | Copy cookies and hints to ServerResponse builders
Closes gh-22351 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/ServerResponse.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -376,6 +376,15 @@ interface BodyBuilder exte... | true |
Other | spring-projects | spring-framework | c152d246a8ce99628ea5b28f91e96cfbeb434186.json | Copy cookies and hints to ServerResponse builders
Closes gh-22351 | spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultServerResponseBuilderTests.java | @@ -41,6 +41,7 @@
import org.springframework.mock.web.test.server.MockServerWebExchange;
import org.springframework.util.LinkedMultiValueMap;
import org.springframework.util.MultiValueMap;
+import org.springframework.web.reactive.function.BodyInserters;
import org.springframework.web.reactive.result.view.ViewResolv... | true |
Other | spring-projects | spring-framework | 6324a1b3fab1b797211ab01a3939caaef521dda5.json | Copy cookies and hints in built ServerResponse
Closes gh-22481 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultEntityResponseBuilder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -202,16 +202,14 @@ public Mono<EntityRespons... | true |
Other | spring-projects | spring-framework | 6324a1b3fab1b797211ab01a3939caaef521dda5.json | Copy cookies and hints in built ServerResponse
Closes gh-22481 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultRenderingResponseBuilder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -168,7 +168,7 @@ private static final class ... | true |
Other | spring-projects | spring-framework | 6324a1b3fab1b797211ab01a3939caaef521dda5.json | Copy cookies and hints in built ServerResponse
Closes gh-22481 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultServerResponseBuilder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -20,6 +20,7 @@
import java.time.Instant;
i... | true |
Other | spring-projects | spring-framework | 6324a1b3fab1b797211ab01a3939caaef521dda5.json | Copy cookies and hints in built ServerResponse
Closes gh-22481 | spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultServerResponseBuilderTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -65,11 +65,17 @@ public List<ViewResolver> v... | true |
Other | spring-projects | spring-framework | 0db317575b5eead35896530338ace74f9354574f.json | Copy cookies in built ServerResponse
Closes gh-22481 | spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultServerResponseBuilder.java | @@ -70,6 +70,7 @@ public DefaultServerResponseBuilder(ServerResponse other) {
this.statusCode = (other instanceof AbstractServerResponse ?
((AbstractServerResponse) other).statusCode : other.statusCode().value());
this.headers.addAll(other.headers());
+ this.cookies.addAll(other.cookies());
}
public D... | true |
Other | spring-projects | spring-framework | 0db317575b5eead35896530338ace74f9354574f.json | Copy cookies in built ServerResponse
Closes gh-22481 | spring-webmvc/src/test/java/org/springframework/web/servlet/function/DefaultServerResponseBuilderTests.java | @@ -71,10 +71,15 @@ public void status() {
@Test
public void from() {
- ServerResponse other = ServerResponse.ok().header("foo", "bar").build();
+ Cookie cookie = new Cookie("foo", "bar");
+ ServerResponse other = ServerResponse.ok()
+ .header("foo", "bar")
+ .cookie(cookie)
+ .build();
ServerRespo... | true |
Other | spring-projects | spring-framework | d8215e7c79d7734da06f724e56d4e6a3d3d04c0d.json | Copy cookies and hints in built ServerResponse
Closes gh-22481 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultEntityResponseBuilder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -202,16 +202,14 @@ public Mono<EntityRespons... | true |
Other | spring-projects | spring-framework | d8215e7c79d7734da06f724e56d4e6a3d3d04c0d.json | Copy cookies and hints in built ServerResponse
Closes gh-22481 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultRenderingResponseBuilder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -168,7 +168,7 @@ private static final class ... | true |
Other | spring-projects | spring-framework | d8215e7c79d7734da06f724e56d4e6a3d3d04c0d.json | Copy cookies and hints in built ServerResponse
Closes gh-22481 | spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultServerResponseBuilder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -20,6 +20,7 @@
import java.time.Instant;
i... | true |
Other | spring-projects | spring-framework | d8215e7c79d7734da06f724e56d4e6a3d3d04c0d.json | Copy cookies and hints in built ServerResponse
Closes gh-22481 | spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultServerResponseBuilderTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -65,11 +65,17 @@ public List<ViewResolver> v... | true |
Other | spring-projects | spring-framework | f66362a01cccd8f55681beb399988649c0935bd8.json | Update license.txt file
Closes gh-22659 | src/docs/dist/license.txt | @@ -255,25 +255,21 @@ CGLIB 3.0 is licensed under the Apache License, version 2.0, the text of which
is included above.
-=======================================================================
+===============================================================================
-To the extent any open source subcompo... | false |
Other | spring-projects | spring-framework | 94c14c469e6cc7a7b568a08589b159dc27489411.json | Fix checkstyle issue | spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultEntityResponseBuilder.java | @@ -5,7 +5,7 @@
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* di... | false |
Other | spring-projects | spring-framework | 78fd8821419159ad7f5560db301c3376b5606f5c.json | Remove superfluous empty lines after code blocks | src/docs/asciidoc/core/core-aop.adoc | @@ -471,7 +471,6 @@ of any public method.
<3> `tradingOperation` matches if a method execution represents any public method in the
trading module.
-
It is a best practice to build more complex pointcut expressions out of smaller named
components, as shown earlier. When referring to pointcuts by name, normal Java ... | true |
Other | spring-projects | spring-framework | 78fd8821419159ad7f5560db301c3376b5606f5c.json | Remove superfluous empty lines after code blocks | src/docs/asciidoc/web/webmvc.adoc | @@ -1483,7 +1483,6 @@ as the following example shows:
----
<1> Using a `consumes` attribute to narrow the mapping by the content type.
-
The `consumes` attribute also supports negation expressions -- for example, `!text/plain` means any
content type other than `text/plain`.
@@ -1513,7 +1512,6 @@ content types t... | true |
Other | spring-projects | spring-framework | 8494c7a75a0e5fcc1410b4ee335a8776a180de1b.json | Add missing KDoc comments | spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/server/CoRouterFunctionDsl.kt | @@ -395,6 +395,9 @@ open class CoRouterFunctionDsl(private val init: (CoRouterFunctionDsl.() -> Unit
}
}
+ /**
+ * Return a composed routing function created from all the registered routes.
+ */
override fun invoke(): RouterFunction<ServerResponse> {
init()
return builder.build(... | false |
Other | spring-projects | spring-framework | 4517f40f57df6ee5ef339d21b135ba4b79ffa4e9.json | Remove redundant 'String.substring()' call | spring-web/src/main/java/org/springframework/web/util/HtmlCharacterEntityDecoder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -95,7 +95,7 @@ private void copyCharactersTi... | false |
Other | spring-projects | spring-framework | 860ec44c5096d16bedeef45a4e29b1156f44b4b9.json | Fix typo on MergedAnnotations
Closes gh-22649 | spring-core/src/main/java/org/springframework/core/annotation/MergedAnnotations.java | @@ -26,8 +26,8 @@
import org.springframework.lang.Nullable;
/**
- * Provides access to a collection of merged annotations, usually obtained from
- * a from a source such as a {@link Class} or {@link Method}. Each merged
+ * Provides access to a collection of merged annotations, usually obtained
+ * from a source su... | false |
Other | spring-projects | spring-framework | 7bb66c4f496771ad5d9e288b1c4984ff6a63127f.json | Replace bit.ly links with real links | spring-context/src/main/java/org/springframework/jmx/support/WebSphereMBeanServerFactoryBean.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -31,12 +31,14 @@
* available on WebSphere ... | true |
Other | spring-projects | spring-framework | 7bb66c4f496771ad5d9e288b1c4984ff6a63127f.json | Replace bit.ly links with real links | spring-tx/src/main/java/org/springframework/transaction/interceptor/TransactionProxyFactoryBean.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2018 the original author or authors.
+ * Copyright 2002-2019 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -39,10 +39,10 @@
* typical case of declara... | true |
Other | spring-projects | spring-framework | a07245caf8a5ba9debd11d3ace3b47e0b68d8422.json | Exclude jdk package in ShadowingClassLoader
Many Java 11 internal classes are located in the jdk package. ShadowingClassLoader should not load them, because it can cause errors, e.g. java.lang.IllegalAccessError: class jdk.internal.reflect.ConstructorAccessorImpl loaded by org.springframework.instrument.classloading.S... | spring-context/src/main/java/org/springframework/instrument/classloading/ShadowingClassLoader.java | @@ -48,7 +48,7 @@ public class ShadowingClassLoader extends DecoratingClassLoader {
/** Packages that are excluded by default. */
public static final String[] DEFAULT_EXCLUDED_PACKAGES =
- new String[] {"java.", "javax.", "sun.", "oracle.", "com.sun.", "com.ibm.", "COM.ibm.",
+ new String[] {"java.", "javax."... | false |
Other | spring-projects | spring-framework | f2a541511185dd960852d15b87fd18524dfc312b.json | Fix CheckStyle violations
See gh-2060 | spring-beans/src/main/java/org/springframework/beans/factory/support/AutowireUtils.java | @@ -304,8 +304,8 @@ else if (arg instanceof TypedStringValue) {
* {@code null})
* @param parameterIndex the index of the parameter in the constructor or method
* that declares the parameter
- * @see #resolveDependency
* @since 5.2
+ * @see #resolveDependency
*/
public static boolean isAutowirable(Par... | false |
Other | spring-projects | spring-framework | 1c24dc1f27fda6736c5a7b123f0476a1bc124a94.json | Simplify String concatenation | spring-test/src/main/java/org/springframework/mock/web/MockHttpServletResponse.java | @@ -168,11 +168,11 @@ public void setCharacterEncoding(String characterEncoding) {
private void updateContentTypeHeader() {
if (this.contentType != null) {
- StringBuilder sb = new StringBuilder(this.contentType);
- if (!this.contentType.toLowerCase().contains(CHARSET_PREFIX) && this.charset) {
- sb.appen... | false |
Other | spring-projects | spring-framework | e47f7ef7b51b8197d4c9b41c3a5b33e7cb62ef45.json | Remove response content-type before error handling
Prior to this commit, the negotiated content-type during the request
mapping phase would be kept as the response content-type header; this
information is used when rendering the error response and prevents a new
round of content negotiation to choose the media type th... | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestMappingHandlerAdapter.java | @@ -29,6 +29,7 @@
import org.springframework.context.ApplicationContextAware;
import org.springframework.context.ConfigurableApplicationContext;
import org.springframework.core.ReactiveAdapterRegistry;
+import org.springframework.http.HttpHeaders;
import org.springframework.http.codec.HttpMessageReader;
import org... | true |
Other | spring-projects | spring-framework | e47f7ef7b51b8197d4c9b41c3a5b33e7cb62ef45.json | Remove response content-type before error handling
Prior to this commit, the negotiated content-type during the request
mapping phase would be kept as the response content-type header; this
information is used when rendering the error response and prevents a new
round of content negotiation to choose the media type th... | spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestMappingExceptionHandlingIntegrationTests.java | @@ -93,7 +93,7 @@ public void exceptionAfterSeveralItems() {
public void exceptionFromMethodWithProducesCondition() throws Exception {
try {
HttpHeaders headers = new HttpHeaders();
- headers.add("Accept", "text/csv, application/problem+json");
+ headers.add("Accept", "text/plain, application/problem+json"... | true |
Other | spring-projects | spring-framework | 6e7c3f2893db75d935ff80895f2def3ac687bb9a.json | Fix a typo in RouterFunctionDsl Javadoc
Closes gh-22419 | spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/server/RouterFunctionDsl.kt | @@ -26,7 +26,7 @@ import java.net.URI
/**
* Allow to create easily a `RouterFunction<ServerResponse>` from a Kotlin router DSL based
- * on the same building blocks than the Java one ([RouterFunction], [RequestPredicate],
+ * on the same building blocks as the Java one ([RouterFunction], [RequestPredicate],
* [H... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.