language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-expression/src/main/java/org/springframework/expression/spel/standard/SpelCompiler.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -64,7 +64,7 @@
* @author Andy Clement
* ... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-expression/src/main/java/org/springframework/expression/spel/support/BooleanTypedValue.java | @@ -24,7 +24,7 @@
* @author Andy Clement
* @since 3.0
*/
-public class BooleanTypedValue extends TypedValue {
+public final class BooleanTypedValue extends TypedValue {
/**
* True. | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-expression/src/main/java/org/springframework/expression/spel/support/DataBindingMethodResolver.java | @@ -39,7 +39,7 @@
* @see #forInstanceMethodInvocation()
* @see DataBindingPropertyAccessor
*/
-public class DataBindingMethodResolver extends ReflectiveMethodResolver {
+public final class DataBindingMethodResolver extends ReflectiveMethodResolver {
private DataBindingMethodResolver() {
super(); | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-expression/src/main/java/org/springframework/expression/spel/support/DataBindingPropertyAccessor.java | @@ -37,7 +37,7 @@
* @see StandardEvaluationContext
* @see ReflectivePropertyAccessor
*/
-public class DataBindingPropertyAccessor extends ReflectivePropertyAccessor {
+public final class DataBindingPropertyAccessor extends ReflectivePropertyAccessor {
/**
* Create a new property accessor for reading and po... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-expression/src/main/java/org/springframework/expression/spel/support/SimpleEvaluationContext.java | @@ -86,7 +86,7 @@
* @see StandardTypeConverter
* @see DataBindingPropertyAccessor
*/
-public class SimpleEvaluationContext implements EvaluationContext {
+public final class SimpleEvaluationContext implements EvaluationContext {
private static final TypeLocator typeNotFoundTypeLocator = typeName -> {
throw... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-instrument/src/main/java/org/springframework/instrument/InstrumentationSavingAgent.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -27,11 +27,15 @@
* @since 2.0
* @see org... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-jdbc/src/main/java/org/springframework/jdbc/BadSqlGrammarException.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -34,7 +34,7 @@
@SuppressWarnings("serial")
... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-jdbc/src/main/java/org/springframework/jdbc/IncorrectResultSetColumnCountException.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -29,9 +29,9 @@
@SuppressWarnings("serial")
... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-jdbc/src/main/java/org/springframework/jdbc/InvalidResultSetAccessException.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -37,7 +37,7 @@
public class InvalidResultSe... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-jdbc/src/main/java/org/springframework/jdbc/JdbcUpdateAffectedIncorrectNumberOfRowsException.java | @@ -30,10 +30,10 @@
public class JdbcUpdateAffectedIncorrectNumberOfRowsException extends IncorrectUpdateSemanticsDataAccessException {
/** Number of rows that should have been affected. */
- private int expected;
+ private final int expected;
/** Number of rows that actually were affected. */
- private int ac... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-jdbc/src/main/java/org/springframework/jdbc/config/DatabasePopulatorConfigUtils.java | @@ -38,7 +38,12 @@
* @author Stephane Nicoll
* @since 3.1
*/
-class DatabasePopulatorConfigUtils {
+final class DatabasePopulatorConfigUtils {
+
+
+ private DatabasePopulatorConfigUtils() {
+ }
+
public static void setDatabasePopulator(Element element, BeanDefinitionBuilder builder) {
List<Element> scripts... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/CallMetaDataProviderFactory.java | @@ -35,7 +35,7 @@
* @author Juergen Hoeller
* @since 2.5
*/
-public class CallMetaDataProviderFactory {
+public final class CallMetaDataProviderFactory {
/** List of supported database products for procedure calls. */
public static final List<String> supportedDatabaseProductsForProcedures = Arrays.asList(
@... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/TableMetaDataProviderFactory.java | @@ -32,11 +32,15 @@
* @author Thomas Risberg
* @since 2.5
*/
-public class TableMetaDataProviderFactory {
+public final class TableMetaDataProviderFactory {
private static final Log logger = LogFactory.getLog(TableMetaDataProviderFactory.class);
+ private TableMetaDataProviderFactory() {
+ }
+
+
/**
... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-jdbc/src/main/java/org/springframework/jdbc/datasource/UserCredentialsDataSourceAdapter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -202,7 +202,7 @@ protected Connection doGetC... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-jdbc/src/main/java/org/springframework/jdbc/datasource/embedded/EmbeddedDatabaseConfigurerFactory.java | @@ -29,6 +29,11 @@
*/
final class EmbeddedDatabaseConfigurerFactory {
+
+ private EmbeddedDatabaseConfigurerFactory() {
+ }
+
+
/**
* Return a configurer instance for the given embedded database type.
* @param type the embedded database type (HSQL, H2 or Derby) | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-jdbc/src/main/java/org/springframework/jdbc/datasource/embedded/OutputStreamFactory.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -26,7 +26,12 @@
* @author Juergen Hoeller
... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-jdbc/src/main/java/org/springframework/jdbc/support/CustomSQLExceptionTranslatorRegistry.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -33,7 +33,7 @@
* @since 3.1.1
* @see SQL... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-jms/src/main/java/org/springframework/jms/connection/UserCredentialsConnectionFactoryAdapter.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -320,17 +320,19 @@ private ConnectionFactory... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-messaging/src/main/java/org/springframework/messaging/handler/annotation/support/DestinationVariableMethodArgumentResolver.java | @@ -78,7 +78,7 @@ protected void handleMissingValue(String name, MethodParameter parameter, Messag
}
- private static class DestinationVariableNamedValueInfo extends NamedValueInfo {
+ private static final class DestinationVariableNamedValueInfo extends NamedValueInfo {
private DestinationVariableNamedValueI... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-messaging/src/main/java/org/springframework/messaging/handler/annotation/support/HeaderMethodArgumentResolver.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -106,7 +106,7 @@ protected void handleMissin... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-messaging/src/main/java/org/springframework/messaging/handler/annotation/support/MethodArgumentNotValidException.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -34,14 +34,15 @@
@SuppressWarnings("serial"... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompBrokerRelayMessageHandler.java | @@ -577,7 +577,7 @@ private class StompConnectionHandler implements TcpConnectionHandler<byte[]> {
private volatile boolean isStompConnected;
- private StompConnectionHandler(String sessionId, StompHeaderAccessor connectHeaders) {
+ protected StompConnectionHandler(String sessionId, StompHeaderAccessor connect... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-orm/src/main/java/org/springframework/orm/ObjectOptimisticLockingFailureException.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -30,10 +30,10 @@
public class ObjectOptimis... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-orm/src/main/java/org/springframework/orm/ObjectRetrievalFailureException.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -30,10 +30,10 @@
public class ObjectRetriev... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-orm/src/main/java/org/springframework/orm/hibernate5/HibernateTransactionManager.java | @@ -890,7 +890,7 @@ public void flush() {
* Holder for suspended resources.
* Used internally by {@code doSuspend} and {@code doResume}.
*/
- private static class SuspendedResourcesHolder {
+ private static final class SuspendedResourcesHolder {
private final SessionHolder sessionHolder;
| true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-orm/src/main/java/org/springframework/orm/jpa/ExtendedEntityManagerCreator.java | @@ -242,7 +242,7 @@ private static EntityManager createProxy(
* InvocationHandler for extended EntityManagers as defined in the JPA spec.
*/
@SuppressWarnings("serial")
- private static class ExtendedEntityManagerInvocationHandler implements InvocationHandler, Serializable {
+ private static final class Extende... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-orm/src/main/java/org/springframework/orm/jpa/JpaTransactionManager.java | @@ -745,7 +745,7 @@ private SavepointManager getSavepointManager() {
* Holder for suspended resources.
* Used internally by {@code doSuspend} and {@code doResume}.
*/
- private static class SuspendedResourcesHolder {
+ private static final class SuspendedResourcesHolder {
private final EntityManagerHolder... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-oxm/src/main/java/org/springframework/oxm/jaxb/Jaxb2Marshaller.java | @@ -127,6 +127,9 @@ public class Jaxb2Marshaller implements MimeMarshaller, MimeUnmarshaller, Generi
private static final String CID = "cid:";
+ private static final EntityResolver NO_OP_ENTITY_RESOLVER =
+ (publicId, systemId) -> new InputSource(new StringReader(""));
+
/** Logger available to subclasses. ... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-oxm/src/main/java/org/springframework/oxm/support/MarshallingSource.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -102,7 +102,7 @@ public void setXMLReader(XM... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-test/src/main/java/org/springframework/mock/http/server/reactive/MockServerHttpRequest.java | @@ -52,7 +52,7 @@
* @author Rossen Stoyanchev
* @since 5.0
*/
-public class MockServerHttpRequest extends AbstractServerHttpRequest {
+public final class MockServerHttpRequest extends AbstractServerHttpRequest {
private final HttpMethod httpMethod;
| true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-test/src/main/java/org/springframework/mock/jndi/SimpleNamingContext.java | @@ -357,7 +357,7 @@ public void close() {
}
- private static class NameClassPairEnumeration extends AbstractNamingEnumeration<NameClassPair> {
+ private static final class NameClassPairEnumeration extends AbstractNamingEnumeration<NameClassPair> {
private NameClassPairEnumeration(SimpleNamingContext context,... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-test/src/main/java/org/springframework/mock/web/MockFilterChain.java | @@ -150,7 +150,7 @@ public void reset() {
/**
* A filter that simply delegates to a Servlet.
*/
- private static class ServletFilterProxy implements Filter {
+ private static final class ServletFilterProxy implements Filter {
private final Servlet delegateServlet;
| true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-test/src/main/java/org/springframework/mock/web/reactive/function/server/MockServerRequest.java | @@ -63,7 +63,7 @@
* @author Arjen Poutsma
* @since 5.0
*/
-public class MockServerRequest implements ServerRequest {
+public final class MockServerRequest implements ServerRequest {
private final HttpMethod method;
| true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-test/src/main/java/org/springframework/test/annotation/SystemProfileValueSource.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -26,7 +26,7 @@
* @author Sam Brannen
* @... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-test/src/main/java/org/springframework/test/annotation/TestAnnotationUtils.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2016 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -26,7 +26,12 @@
* @author Sam Brannen
* ... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-test/src/main/java/org/springframework/test/context/transaction/TestTransaction.java | @@ -38,7 +38,12 @@
* @since 4.1
* @see TransactionalTestExecutionListener
*/
-public class TestTransaction {
+public final class TestTransaction {
+
+
+ private TestTransaction() {
+ }
+
/**
* Determine whether a test-managed transaction is currently <em>active</em>. | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-test/src/main/java/org/springframework/test/context/transaction/TransactionContextHolder.java | @@ -25,12 +25,16 @@
* @author Sam Brannen
* @since 4.1
*/
-class TransactionContextHolder {
+final class TransactionContextHolder {
private static final ThreadLocal<TransactionContext> currentTransactionContext =
new NamedInheritableThreadLocal<>("Test Transaction Context");
+ private TransactionConte... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-test/src/main/java/org/springframework/test/jdbc/JdbcTestUtils.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -38,11 +38,15 @@
* @see org.springframewor... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-test/src/main/java/org/springframework/test/web/client/ExpectedCount.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -38,7 +38,7 @@
* @author Rossen Stoyanchev... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-test/src/main/java/org/springframework/test/web/client/MockRestServiceServer.java | @@ -64,7 +64,7 @@
* @since 3.2
*/
@SuppressWarnings("deprecation")
-public class MockRestServiceServer {
+public final class MockRestServiceServer {
private final RequestExpectationManager expectationManager;
| true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-test/src/main/java/org/springframework/test/web/servlet/setup/MockMvcBuilders.java | @@ -33,7 +33,12 @@
* @see #webAppContextSetup(WebApplicationContext)
* @see #standaloneSetup(Object...)
*/
-public class MockMvcBuilders {
+public final class MockMvcBuilders {
+
+
+ private MockMvcBuilders() {
+ }
+
/**
* Build a {@link MockMvc} instance using the given, fully initialized | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-tx/src/main/java/org/springframework/dao/IncorrectResultSizeDataAccessException.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -28,9 +28,9 @@
@SuppressWarnings("serial")
... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-tx/src/main/java/org/springframework/jca/cci/connection/SingleConnectionFactory.java | @@ -225,7 +225,7 @@ protected Connection getCloseSuppressingConnectionProxy(Connection target) {
/**
* Invocation handler that suppresses close calls on CCI Connections.
*/
- private static class CloseSuppressingInvocationHandler implements InvocationHandler {
+ private static final class CloseSuppressingInvoca... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-tx/src/main/java/org/springframework/transaction/HeuristicCompletionException.java | @@ -65,7 +65,7 @@ public static String getStateString(int state) {
/**
* The outcome state of the transaction: have some or all resources been committed?
*/
- private int outcomeState = STATE_UNKNOWN;
+ private final int outcomeState;
/** | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-tx/src/main/java/org/springframework/transaction/InvalidTimeoutException.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -27,7 +27,7 @@
@SuppressWarnings("serial")
... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-tx/src/main/java/org/springframework/transaction/support/AbstractPlatformTransactionManager.java | @@ -1273,7 +1273,7 @@ private void readObject(ObjectInputStream ois) throws IOException, ClassNotFound
* Holder for suspended resources.
* Used internally by {@code suspend} and {@code resume}.
*/
- protected static class SuspendedResourcesHolder {
+ protected static final class SuspendedResourcesHolder {
... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/http/ContentDisposition.java | @@ -39,7 +39,7 @@
* @since 5.0
* @see <a href="https://tools.ietf.org/html/rfc2183">RFC 2183</a>
*/
-public class ContentDisposition {
+public final class ContentDisposition {
@Nullable
private final String type; | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/http/InvalidMediaTypeException.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2013 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -28,7 +28,7 @@
@SuppressWarnings("serial")
... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/http/MediaTypeFactory.java | @@ -40,13 +40,17 @@
* @author Arjen Poutsma
* @since 5.0
*/
-public class MediaTypeFactory {
+public final class MediaTypeFactory {
private static final String MIME_TYPES_FILE_NAME = "/org/springframework/http/mime.types";
private static final MultiValueMap<String, MediaType> fileExtensionToMediaTypes = p... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/http/codec/CodecConfigurerFactory.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -36,7 +36,7 @@
* @see ClientCodecConfigure... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/http/codec/ServerSentEvent.java | @@ -32,7 +32,7 @@
* @see ServerSentEventHttpMessageWriter
* @see <a href="https://www.w3.org/TR/eventsource/">Server-Sent Events W3C recommendation</a>
*/
-public class ServerSentEvent<T> {
+public final class ServerSentEvent<T> {
@Nullable
private final String id; | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/http/codec/json/Jackson2Tokenizer.java | @@ -42,7 +42,7 @@
* @author Arjen Poutsma
* @since 5.0
*/
-class Jackson2Tokenizer {
+final class Jackson2Tokenizer {
private final JsonParser parser;
| true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/http/server/DefaultPathContainer.java | @@ -36,7 +36,7 @@
* @author Rossen Stoyanchev
* @since 5.0
*/
-class DefaultPathContainer implements PathContainer {
+final class DefaultPathContainer implements PathContainer {
private static final MultiValueMap<String, String> EMPTY_MAP = new LinkedMultiValueMap<>(0);
| true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/web/HttpRequestMethodNotSupportedException.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -37,10 +37,10 @@
@SuppressWarnings("serial"... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/web/HttpSessionRequiredException.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -30,7 +30,7 @@
public class HttpSessionRequ... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/web/filter/RelativeRedirectResponseWrapper.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -30,7 +30,7 @@
* @author Rossen Stoyanchev... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/web/method/HandlerTypePredicate.java | @@ -46,7 +46,7 @@
* @author Rossen Stoyanchev
* @since 5.1
*/
-public class HandlerTypePredicate implements Predicate<Class<?>> {
+public final class HandlerTypePredicate implements Predicate<Class<?>> {
private final Set<String> basePackages;
| true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/web/method/annotation/AbstractCookieValueMethodArgumentResolver.java | @@ -71,7 +71,7 @@ protected void handleMissingValue(String name, MethodParameter parameter) throws
}
- private static class CookieValueNamedValueInfo extends NamedValueInfo {
+ private static final class CookieValueNamedValueInfo extends NamedValueInfo {
private CookieValueNamedValueInfo(CookieValue annotati... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/web/method/annotation/ExpressionValueMethodArgumentResolver.java | @@ -77,7 +77,7 @@ protected void handleMissingValue(String name, MethodParameter parameter) throws
}
- private static class ExpressionValueNamedValueInfo extends NamedValueInfo {
+ private static final class ExpressionValueNamedValueInfo extends NamedValueInfo {
private ExpressionValueNamedValueInfo(Value an... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/web/method/annotation/RequestHeaderMethodArgumentResolver.java | @@ -88,7 +88,7 @@ protected void handleMissingValue(String name, MethodParameter parameter) throws
}
- private static class RequestHeaderNamedValueInfo extends NamedValueInfo {
+ private static final class RequestHeaderNamedValueInfo extends NamedValueInfo {
private RequestHeaderNamedValueInfo(RequestHeader ... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/web/server/adapter/WebHttpHandlerBuilder.java | @@ -62,7 +62,7 @@
* @since 5.0
* @see HttpWebHandlerAdapter
*/
-public class WebHttpHandlerBuilder {
+public final class WebHttpHandlerBuilder {
/** Well-known name for the target WebHandler in the bean factory. */
public static final String WEB_HANDLER_BEAN_NAME = "webHandler"; | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/web/util/HierarchicalUriComponents.java | @@ -53,6 +53,50 @@ final class HierarchicalUriComponents extends UriComponents {
private static final String PATH_DELIMITER_STRING = "/";
+ /**
+ * Represents an empty path.
+ */
+ static final PathComponent NULL_PATH_COMPONENT = new PathComponent() {
+
+ @Override
+ public String getPath() {
+ return "";
+... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/web/util/JavaScriptUtils.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -29,7 +29,12 @@
* @author Rossen Stoyanche... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/web/util/UriTemplate.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -170,7 +170,7 @@ public String toString() {
... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/web/util/pattern/PathPattern.java | @@ -73,6 +73,25 @@ public class PathPattern implements Comparable<PathPattern> {
private static final PathContainer EMPTY_PATH = PathContainer.parsePath("");
+ /**
+ * Comparator that sorts patterns by specificity as follows:
+ * <ol>
+ * <li>Null instances are last.
+ * <li>Catch-all patterns are last.
+ * ... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/CookieValueMethodArgumentResolver.java | @@ -82,7 +82,7 @@ protected void handleMissingValue(String name, MethodParameter parameter) {
}
- private static class CookieValueNamedValueInfo extends NamedValueInfo {
+ private static final class CookieValueNamedValueInfo extends NamedValueInfo {
private CookieValueNamedValueInfo(CookieValue annotation) {... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ExpressionValueMethodArgumentResolver.java | @@ -74,7 +74,7 @@ protected void handleMissingValue(String name, MethodParameter parameter) {
}
- private static class ExpressionValueNamedValueInfo extends NamedValueInfo {
+ private static final class ExpressionValueNamedValueInfo extends NamedValueInfo {
private ExpressionValueNamedValueInfo(Value annotat... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/MatrixVariableMethodArgumentResolver.java | @@ -125,7 +125,7 @@ protected void handleMissingValue(String name, MethodParameter parameter) throws
}
- private static class MatrixVariableNamedValueInfo extends NamedValueInfo {
+ private static final class MatrixVariableNamedValueInfo extends NamedValueInfo {
private MatrixVariableNamedValueInfo(MatrixVar... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestHeaderMethodArgumentResolver.java | @@ -95,7 +95,7 @@ protected void handleMissingValue(String name, MethodParameter parameter) {
}
- private static class RequestHeaderNamedValueInfo extends NamedValueInfo {
+ private static final class RequestHeaderNamedValueInfo extends NamedValueInfo {
private RequestHeaderNamedValueInfo(RequestHeader annot... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-webmvc/src/main/java/org/springframework/web/servlet/ModelAndViewDefiningException.java | @@ -35,7 +35,7 @@
@SuppressWarnings("serial")
public class ModelAndViewDefiningException extends ServletException {
- private ModelAndView modelAndView;
+ private final ModelAndView modelAndView;
/** | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/MatrixVariableMethodArgumentResolver.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -127,7 +127,7 @@ protected void handleMissin... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-websocket/src/main/java/org/springframework/web/socket/config/MessageBrokerBeanDefinitionParser.java | @@ -663,7 +663,7 @@ private static void registerBeanDefByName(
context.registerComponent(new BeanComponentDefinition(beanDef, name));
}
- private static class DecoratingFactoryBean implements FactoryBean<WebSocketHandler> {
+ private static final class DecoratingFactoryBean implements FactoryBean<WebSocketHandle... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-websocket/src/main/java/org/springframework/web/socket/config/WebSocketNamespaceUtils.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -44,7 +44,12 @@
* @author Rossen Stoyanche... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-websocket/src/main/java/org/springframework/web/socket/messaging/WebSocketAnnotationMethodMessageHandler.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -86,7 +86,7 @@ private void initMessagingAdv... | true |
Other | spring-projects | spring-framework | eeebd51f57f452c57bc159fa8a2ad9746c4c2f8c.json | Use consistent class design
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968 | spring-websocket/src/main/java/org/springframework/web/socket/sockjs/support/AbstractSockJsService.java | @@ -74,7 +74,6 @@ public abstract class AbstractSockJsService implements SockJsService, CorsConfig
private static final String XFRAME_OPTIONS_HEADER = "X-Frame-Options";
-
protected final Log logger = LogFactory.getLog(getClass());
private final TaskScheduler taskScheduler;
@@ -99,6 +98,10 @@ public abstrac... | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-aop/src/main/java/org/springframework/aop/interceptor/ExposeInvocationInterceptor.java | @@ -69,11 +69,12 @@ public String toString() {
*/
public static MethodInvocation currentInvocation() throws IllegalStateException {
MethodInvocation mi = invocation.get();
- if (mi == null)
+ if (mi == null) {
throw new IllegalStateException(
"No MethodInvocation found: Check that an AOP invocation ... | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-beans/src/main/java/org/springframework/beans/factory/groovy/GroovyBeanDefinitionReader.java | @@ -371,8 +371,9 @@ public Object invokeMethod(String name, Object arg) {
}
else if ("ref".equals(name)) {
String refName;
- if (args[0] == null)
+ if (args[0] == null) {
throw new IllegalArgumentException("Argument to ref() is not a valid bean or was not found");
+ }
if (args[0] instanceof R... | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-beans/src/main/java/org/springframework/beans/factory/groovy/GroovyBeanDefinitionWrapper.java | @@ -211,8 +211,9 @@ else if (FACTORY_BEAN.equals(property)) {
}
// factoryMethod
else if (FACTORY_METHOD.equals(property)) {
- if (newValue != null)
+ if (newValue != null) {
bd.setFactoryMethodName(newValue.toString());
+ }
}
// initMethod
else if (INIT_METHOD.equals(property)) { | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanDefinition.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -1124,33 +1124,79 @@ public boolean equals(O... | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-context-indexer/src/main/java/org/springframework/context/index/CandidateComponentsIndexer.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -137,8 +137,9 @@ private static List<TypeEle... | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-context/src/main/java/org/springframework/context/support/AbstractRefreshableApplicationContext.java | @@ -143,8 +143,9 @@ protected final void refreshBeanFactory() throws BeansException {
@Override
protected void cancelRefresh(BeansException ex) {
synchronized (this.beanFactoryMonitor) {
- if (this.beanFactory != null)
+ if (this.beanFactory != null) {
this.beanFactory.setSerializationId(null);
+ }
... | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-expression/src/main/java/org/springframework/expression/spel/CodeFlow.java | @@ -951,7 +951,9 @@ public static boolean isReferenceTypeArray(String arraytype) {
int length = arraytype.length();
for (int i = 0; i < length; i++) {
char ch = arraytype.charAt(i);
- if (ch == '[') continue;
+ if (ch == '[') {
+ continue;
+ }
return ch=='L';
}
return false; | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-jdbc/src/main/java/org/springframework/jdbc/support/GeneratedKeyHolder.java | @@ -92,10 +92,11 @@ public Map<String, Object> getKeys() throws InvalidDataAccessApiUsageException {
if (this.keyList.isEmpty()) {
return null;
}
- if (this.keyList.size() > 1)
+ if (this.keyList.size() > 1) {
throw new InvalidDataAccessApiUsageException(
"The getKeys method should only be used wh... | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-orm/src/main/java/org/springframework/orm/jpa/persistenceunit/PersistenceUnitReader.java | @@ -276,8 +276,9 @@ protected void parseManagedClasses(Element persistenceUnit, SpringPersistenceUni
List<Element> classes = DomUtils.getChildElementsByTagName(persistenceUnit, MANAGED_CLASS_NAME);
for (Element element : classes) {
String value = DomUtils.getTextValue(element).trim();
- if (StringUtils.hasT... | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-tx/src/main/java/org/springframework/transaction/annotation/Isolation.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -81,8 +81,12 @@ public enum Isolation {
pr... | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-tx/src/main/java/org/springframework/transaction/annotation/Propagation.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2015 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -100,8 +100,12 @@ public enum Propagation {
... | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-tx/src/main/java/org/springframework/transaction/interceptor/TransactionAspectSupport.java | @@ -507,9 +507,10 @@ protected TransactionInfo prepareTransactionInfo(@Nullable PlatformTransactionMa
else {
// The TransactionInfo.hasTransaction() method will return false. We created it only
// to preserve the integrity of the ThreadLocal stack maintained in this class.
- if (logger.isTraceEnabled())
+ ... | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/http/server/reactive/UndertowServerHttpRequest.java | @@ -187,7 +187,8 @@ else if (read == -1) {
onAllDataRead();
}
return null;
- } finally {
+ }
+ finally {
if (release && pooledByteBuffer.isOpen()) {
pooledByteBuffer.close();
} | true |
Other | spring-projects | spring-framework | 866e9d702e1db09a61fd814ae5cbb5c9b593723f.json | Use consistent block style
Update all code to use a consistent block style.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/web/util/HtmlCharacterEntityDecoder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -66,8 +66,9 @@ private void findNextPotentia... | true |
Other | spring-projects | spring-framework | e9d1b39aff5fd912ec692ca594d7e02e42318789.json | Apply consistent copyright header
Add copyright header to `package-info.java` files and fix a few
malformed headers on existing java files.
Issue: SPR-16968 | spring-aop/src/main/java/org/springframework/aop/TargetSource.java | @@ -1,5 +1,5 @@
-/*<
- * Copyright 2002-2017 the original author or authors.
+/*
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | true |
Other | spring-projects | spring-framework | e9d1b39aff5fd912ec692ca594d7e02e42318789.json | Apply consistent copyright header
Add copyright header to `package-info.java` files and fix a few
malformed headers on existing java files.
Issue: SPR-16968 | spring-core/src/main/java/org/springframework/core/ParameterizedTypeReference.java | @@ -5,7 +5,7 @@
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* dist... | true |
Other | spring-projects | spring-framework | e9d1b39aff5fd912ec692ca594d7e02e42318789.json | Apply consistent copyright header
Add copyright header to `package-info.java` files and fix a few
malformed headers on existing java files.
Issue: SPR-16968 | spring-core/src/main/java/org/springframework/core/env/PropertySourcesPropertyResolver.java | @@ -1,11 +1,11 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
... | true |
Other | spring-projects | spring-framework | e9d1b39aff5fd912ec692ca594d7e02e42318789.json | Apply consistent copyright header
Add copyright header to `package-info.java` files and fix a few
malformed headers on existing java files.
Issue: SPR-16968 | spring-messaging/src/main/java/org/springframework/messaging/handler/annotation/MessageExceptionHandler.java | @@ -1,7 +1,6 @@
/*
- * Copyright 2002-2014 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
-
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at | true |
Other | spring-projects | spring-framework | e9d1b39aff5fd912ec692ca594d7e02e42318789.json | Apply consistent copyright header
Add copyright header to `package-info.java` files and fix a few
malformed headers on existing java files.
Issue: SPR-16968 | spring-messaging/src/main/java/org/springframework/messaging/handler/invocation/HandlerMethodReturnValueHandlerComposite.java | @@ -1,4 +1,3 @@
-/*
/*
* Copyright 2002-2018 the original author or authors.
* | true |
Other | spring-projects | spring-framework | e9d1b39aff5fd912ec692ca594d7e02e42318789.json | Apply consistent copyright header
Add copyright header to `package-info.java` files and fix a few
malformed headers on existing java files.
Issue: SPR-16968 | spring-messaging/src/main/java/org/springframework/messaging/simp/config/ChannelRegistration.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.7
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. | true |
Other | spring-projects | spring-framework | e9d1b39aff5fd912ec692ca594d7e02e42318789.json | Apply consistent copyright header
Add copyright header to `package-info.java` files and fix a few
malformed headers on existing java files.
Issue: SPR-16968 | spring-test/src/main/java/org/springframework/test/web/servlet/MvcResult.java | @@ -1,15 +1,15 @@
/*
* Copyright 2002-2018 the original author or authors.
*
- * Licensed under the Apache License; Version 2.0 (the "License");
+ * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the ... | true |
Other | spring-projects | spring-framework | e9d1b39aff5fd912ec692ca594d7e02e42318789.json | Apply consistent copyright header
Add copyright header to `package-info.java` files and fix a few
malformed headers on existing java files.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/http/codec/xml/Jaxb2XmlEncoder.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2017 the original author or authors.
+ * Copyright 2002-2018 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -11,7 +11,7 @@
* distributed under the Lic... | true |
Other | spring-projects | spring-framework | e9d1b39aff5fd912ec692ca594d7e02e42318789.json | Apply consistent copyright header
Add copyright header to `package-info.java` files and fix a few
malformed headers on existing java files.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/http/converter/GenericHttpMessageConverter.java | @@ -5,7 +5,7 @@
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* dist... | true |
Other | spring-projects | spring-framework | e9d1b39aff5fd912ec692ca594d7e02e42318789.json | Apply consistent copyright header
Add copyright header to `package-info.java` files and fix a few
malformed headers on existing java files.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/http/converter/protobuf/ExtensionRegistryInitializer.java | @@ -5,7 +5,7 @@
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distrib... | true |
Other | spring-projects | spring-framework | e9d1b39aff5fd912ec692ca594d7e02e42318789.json | Apply consistent copyright header
Add copyright header to `package-info.java` files and fix a few
malformed headers on existing java files.
Issue: SPR-16968 | spring-web/src/main/java/org/springframework/http/converter/xml/Jaxb2CollectionHttpMessageConverter.java | @@ -5,7 +5,7 @@
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* dist... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.