language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
31d1e26c95ebaf179a20ffe9b1328a21857954c3.json
Use List<T> instead of Supplier<Stream<T>> This commit changes all methods that return `Supplier<Stream<T>` to return `List<T>` instead. This includes the HandlerStrategies, but also BodyInserter.Context, BodyExtractor.Context, and ServerResponse.Context. The reason for this change is that most of the strategies have...
spring-webflux/src/test/java/org/springframework/web/reactive/function/BodyInsertersTests.java
@@ -26,8 +26,6 @@ import java.util.List; import java.util.Map; import java.util.Optional; -import java.util.function.Supplier; -import java.util.stream.Stream; import com.fasterxml.jackson.annotation.JsonView; import org.junit.Before; @@ -93,8 +91,8 @@ public void createContext() { this.context = new BodyIn...
true
Other
spring-projects
spring-framework
31d1e26c95ebaf179a20ffe9b1328a21857954c3.json
Use List<T> instead of Supplier<Stream<T>> This commit changes all methods that return `Supplier<Stream<T>` to return `List<T>` instead. This includes the HandlerStrategies, but also BodyInserter.Context, BodyExtractor.Context, and ServerResponse.Context. The reason for this change is that most of the strategies have...
spring-webflux/src/test/java/org/springframework/web/reactive/function/client/DefaultClientRequestBuilderTests.java
@@ -34,10 +34,12 @@ import org.springframework.mock.http.client.reactive.test.MockClientHttpRequest; import org.springframework.web.reactive.function.BodyInserter; -import static java.nio.charset.StandardCharsets.*; +import static java.nio.charset.StandardCharsets.UTF_8; import static org.junit.Assert.*; import s...
true
Other
spring-projects
spring-framework
31d1e26c95ebaf179a20ffe9b1328a21857954c3.json
Use List<T> instead of Supplier<Stream<T>> This commit changes all methods that return `Supplier<Stream<T>` to return `List<T>` instead. This includes the HandlerStrategies, but also BodyInserter.Context, BodyExtractor.Context, and ServerResponse.Context. The reason for this change is that most of the strategies have...
spring-webflux/src/test/java/org/springframework/web/reactive/function/client/DefaultClientResponseTests.java
@@ -23,7 +23,6 @@ import java.util.List; import java.util.Optional; import java.util.OptionalLong; -import java.util.Set; import org.junit.Before; import org.junit.Test; @@ -121,9 +120,9 @@ public void body() throws Exception { when(mockResponse.getHeaders()).thenReturn(httpHeaders); when(mockResponse.getB...
true
Other
spring-projects
spring-framework
31d1e26c95ebaf179a20ffe9b1328a21857954c3.json
Use List<T> instead of Supplier<Stream<T>> This commit changes all methods that return `Supplier<Stream<T>` to return `List<T>` instead. This includes the HandlerStrategies, but also BodyInserter.Context, BodyExtractor.Context, and ServerResponse.Context. The reason for this change is that most of the strategies have...
spring-webflux/src/test/java/org/springframework/web/reactive/function/client/ExchangeStrategiesTests.java
@@ -16,8 +16,6 @@ package org.springframework.web.reactive.function.client; -import java.util.Optional; - import org.junit.Test; import static org.junit.Assert.*; @@ -30,15 +28,15 @@ public class ExchangeStrategiesTests { @Test public void empty() { ExchangeStrategies strategies = ExchangeStrategies.emp...
true
Other
spring-projects
spring-framework
31d1e26c95ebaf179a20ffe9b1328a21857954c3.json
Use List<T> instead of Supplier<Stream<T>> This commit changes all methods that return `Supplier<Stream<T>` to return `List<T>` instead. This includes the HandlerStrategies, but also BodyInserter.Context, BodyExtractor.Context, and ServerResponse.Context. The reason for this change is that most of the strategies have...
spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultEntityResponseBuilderTests.java
@@ -23,8 +23,6 @@ import java.util.List; import java.util.Set; import java.util.function.BiFunction; -import java.util.function.Supplier; -import java.util.stream.Stream; import org.junit.Test; import org.reactivestreams.Publisher; @@ -196,13 +194,13 @@ public void bodyInserter() throws Exception { ServerRe...
true
Other
spring-projects
spring-framework
31d1e26c95ebaf179a20ffe9b1328a21857954c3.json
Use List<T> instead of Supplier<Stream<T>> This commit changes all methods that return `Supplier<Stream<T>` to return `List<T>` instead. This includes the HandlerStrategies, but also BodyInserter.Context, BodyExtractor.Context, and ServerResponse.Context. The reason for this change is that most of the strategies have...
spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultRenderingResponseTests.java
@@ -33,8 +33,7 @@ import org.springframework.web.reactive.result.view.View; import org.springframework.web.reactive.result.view.ViewResolver; -import static org.mockito.Mockito.mock; -import static org.mockito.Mockito.when; +import static org.mockito.Mockito.*; /** * @author Arjen Poutsma @@ -119,7 +118,7 @@ p...
true
Other
spring-projects
spring-framework
31d1e26c95ebaf179a20ffe9b1328a21857954c3.json
Use List<T> instead of Supplier<Stream<T>> This commit changes all methods that return `Supplier<Stream<T>` to return `List<T>` instead. This includes the HandlerStrategies, but also BodyInserter.Context, BodyExtractor.Context, and ServerResponse.Context. The reason for this change is that most of the strategies have...
spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultServerRequestTests.java
@@ -26,8 +26,6 @@ import java.util.Map; import java.util.Optional; import java.util.OptionalLong; -import java.util.function.Supplier; -import java.util.stream.Stream; import org.junit.Before; import org.junit.Test; @@ -66,7 +64,7 @@ public class DefaultServerRequestTests { private ServerWebExchange mockExch...
true
Other
spring-projects
spring-framework
31d1e26c95ebaf179a20ffe9b1328a21857954c3.json
Use List<T> instead of Supplier<Stream<T>> This commit changes all methods that return `Supplier<Stream<T>` to return `List<T>` instead. This includes the HandlerStrategies, but also BodyInserter.Context, BodyExtractor.Context, and ServerResponse.Context. The reason for this change is that most of the strategies have...
spring-webflux/src/test/java/org/springframework/web/reactive/function/server/HandlerStrategiesTests.java
@@ -16,8 +16,6 @@ package org.springframework.web.reactive.function.server; -import java.util.Optional; - import org.junit.Test; import static org.junit.Assert.*; @@ -30,17 +28,17 @@ public class HandlerStrategiesTests { @Test public void empty() { HandlerStrategies strategies = HandlerStrategies.empty(...
true
Other
spring-projects
spring-framework
31d1e26c95ebaf179a20ffe9b1328a21857954c3.json
Use List<T> instead of Supplier<Stream<T>> This commit changes all methods that return `Supplier<Stream<T>` to return `List<T>` instead. This includes the HandlerStrategies, but also BodyInserter.Context, BodyExtractor.Context, and ServerResponse.Context. The reason for this change is that most of the strategies have...
spring-webflux/src/test/java/org/springframework/web/reactive/function/server/ResourceHandlerFunctionTests.java
@@ -19,8 +19,7 @@ import java.io.IOException; import java.nio.file.Files; import java.util.EnumSet; -import java.util.function.Supplier; -import java.util.stream.Stream; +import java.util.List; import org.junit.Before; import org.junit.Test; @@ -56,12 +55,12 @@ public void createContext() { HandlerStrategies ...
true
Other
spring-projects
spring-framework
3d290165fb6b37544d23755f5182fac3478210f4.json
Find exact matches in WebJarsResourceResolver Prior to this commit, resolving resources from webjars using the `WebJarAssetLocator.getFullPath` could lead to multiple candidates, since this method is trying to find *any* resource matching that path under the given webjar location. This commit replaces that call with ...
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/WebJarsResourceResolver.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -17,9 +17,9 @@ package org.springframework....
false
Other
spring-projects
spring-framework
bf83e4e8612512ef51272d8a7dd8533686e8a4e4.json
Use original query string of forwarded request Prior to this commit, the AbstractFlashMapManager has used the originating URI but the query string of the forwarded request. That resulted to FlashMap not being matched even when both originating URI and query string matched the FlashMap attributes. The originating query...
spring-webmvc/src/main/java/org/springframework/web/servlet/support/AbstractFlashMapManager.java
@@ -167,13 +167,14 @@ private FlashMap getMatchingFlashMap(List<FlashMap> allMaps, HttpServletRequest */ protected boolean isFlashMapForRequest(FlashMap flashMap, HttpServletRequest request) { String expectedPath = flashMap.getTargetRequestPath(); + String requestUri = getUrlPathHelper().getOriginatingRequestU...
true
Other
spring-projects
spring-framework
bf83e4e8612512ef51272d8a7dd8533686e8a4e4.json
Use original query string of forwarded request Prior to this commit, the AbstractFlashMapManager has used the originating URI but the query string of the forwarded request. That resulted to FlashMap not being matched even when both originating URI and query string matched the FlashMap attributes. The originating query...
spring-webmvc/src/test/java/org/springframework/web/servlet/support/FlashMapManagerTests.java
@@ -318,6 +318,26 @@ public void flashAttributesWithQueryParamsWithSpace() throws Exception { assertEquals("value", flashMap.get("key")); } + // SPR-15505 + + @Test + public void retrieveAndUpdateMatchByOriginatingPathAndQueryString() { + FlashMap flashMap = new FlashMap(); + flashMap.put("key", "value"); + f...
true
Other
spring-projects
spring-framework
ba39697f2e568b27a97b2bf195b6b8c99ae1ce95.json
Expose Principal in ServerRequest This commit exposes the Principal in ServerRequest. Issue: SPR-15552
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultServerRequest.java
@@ -19,6 +19,7 @@ import java.net.InetSocketAddress; import java.net.URI; import java.nio.charset.Charset; +import java.security.Principal; import java.util.Collections; import java.util.List; import java.util.Locale; @@ -157,6 +158,11 @@ public Mono<WebSession> session() { return this.exchange.getSession(); ...
true
Other
spring-projects
spring-framework
ba39697f2e568b27a97b2bf195b6b8c99ae1ce95.json
Expose Principal in ServerRequest This commit exposes the Principal in ServerRequest. Issue: SPR-15552
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RequestPredicates.java
@@ -17,6 +17,7 @@ package org.springframework.web.reactive.function.server; import java.net.URI; +import java.security.Principal; import java.util.Arrays; import java.util.Collections; import java.util.HashSet; @@ -543,6 +544,11 @@ public Mono<WebSession> session() { return this.request.session(); } + ...
true
Other
spring-projects
spring-framework
ba39697f2e568b27a97b2bf195b6b8c99ae1ce95.json
Expose Principal in ServerRequest This commit exposes the Principal in ServerRequest. Issue: SPR-15552
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/ServerRequest.java
@@ -19,6 +19,7 @@ import java.net.InetSocketAddress; import java.net.URI; import java.nio.charset.Charset; +import java.security.Principal; import java.util.List; import java.util.Locale; import java.util.Map; @@ -168,6 +169,11 @@ default String pathVariable(String name) { */ Mono<WebSession> session(); + ...
true
Other
spring-projects
spring-framework
ba39697f2e568b27a97b2bf195b6b8c99ae1ce95.json
Expose Principal in ServerRequest This commit exposes the Principal in ServerRequest. Issue: SPR-15552
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/support/ServerRequestWrapper.java
@@ -19,6 +19,7 @@ import java.net.InetSocketAddress; import java.net.URI; import java.nio.charset.Charset; +import java.security.Principal; import java.util.List; import java.util.Locale; import java.util.Map; @@ -144,6 +145,10 @@ public Mono<WebSession> session() { return this.delegate.session(); } + @Ove...
true
Other
spring-projects
spring-framework
ba39697f2e568b27a97b2bf195b6b8c99ae1ce95.json
Expose Principal in ServerRequest This commit exposes the Principal in ServerRequest. Issue: SPR-15552
spring-webflux/src/test/java/org/springframework/web/reactive/function/server/MockServerRequest.java
@@ -19,6 +19,7 @@ import java.net.InetSocketAddress; import java.net.URI; import java.nio.charset.Charset; +import java.security.Principal; import java.time.Instant; import java.time.ZoneId; import java.time.ZonedDateTime; @@ -66,11 +67,12 @@ public class MockServerRequest implements ServerRequest { private f...
true
Other
spring-projects
spring-framework
f4cf55cb2b189d0071eff6834a3f7080ce0b000a.json
Add support for WebFilter and WebExceptionHandler This commit adds support for configuring `WebFilter` and `WebExceptionHandler` instances in HandlerStrategies. It also drops the "native" support for `ResponseStatusException`s, in favor of the `ResponseStatusExceptionHandler`, which is registered by default. Issue: S...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultHandlerStrategiesBuilder.java
@@ -32,6 +32,9 @@ import org.springframework.http.codec.ServerCodecConfigurer; import org.springframework.util.Assert; import org.springframework.web.reactive.result.view.ViewResolver; +import org.springframework.web.server.WebExceptionHandler; +import org.springframework.web.server.WebFilter; +import org.springfram...
true
Other
spring-projects
spring-framework
f4cf55cb2b189d0071eff6834a3f7080ce0b000a.json
Add support for WebFilter and WebExceptionHandler This commit adds support for configuring `WebFilter` and `WebExceptionHandler` instances in HandlerStrategies. It also drops the "native" support for `ResponseStatusException`s, in favor of the `ResponseStatusExceptionHandler`, which is registered by default. Issue: S...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultServerRequest.java
@@ -65,12 +65,13 @@ class DefaultServerRequest implements ServerRequest { private final Headers headers; - private final HandlerStrategies strategies; + private final Supplier<Stream<HttpMessageReader<?>>> messageReaders; - DefaultServerRequest(ServerWebExchange exchange, HandlerStrategies strategies) { + Def...
true
Other
spring-projects
spring-framework
f4cf55cb2b189d0071eff6834a3f7080ce0b000a.json
Add support for WebFilter and WebExceptionHandler This commit adds support for configuring `WebFilter` and `WebExceptionHandler` instances in HandlerStrategies. It also drops the "native" support for `ResponseStatusException`s, in favor of the `ResponseStatusExceptionHandler`, which is registered by default. Issue: S...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/HandlerStrategies.java
@@ -27,6 +27,8 @@ import org.springframework.http.codec.HttpMessageWriter; import org.springframework.http.codec.ServerCodecConfigurer; import org.springframework.web.reactive.result.view.ViewResolver; +import org.springframework.web.server.WebExceptionHandler; +import org.springframework.web.server.WebFilter; /*...
true
Other
spring-projects
spring-framework
f4cf55cb2b189d0071eff6834a3f7080ce0b000a.json
Add support for WebFilter and WebExceptionHandler This commit adds support for configuring `WebFilter` and `WebExceptionHandler` instances in HandlerStrategies. It also drops the "native" support for `ResponseStatusException`s, in favor of the `ResponseStatusExceptionHandler`, which is registered by default. Issue: S...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RouterFunctions.java
@@ -30,10 +30,8 @@ import org.springframework.web.reactive.HandlerMapping; import org.springframework.web.reactive.function.server.support.HandlerFunctionAdapter; import org.springframework.web.reactive.function.server.support.ServerResponseResultHandler; -import org.springframework.web.server.ResponseStatusExceptio...
true
Other
spring-projects
spring-framework
f4cf55cb2b189d0071eff6834a3f7080ce0b000a.json
Add support for WebFilter and WebExceptionHandler This commit adds support for configuring `WebFilter` and `WebExceptionHandler` instances in HandlerStrategies. It also drops the "native" support for `ResponseStatusException`s, in favor of the `ResponseStatusExceptionHandler`, which is registered by default. Issue: S...
spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultServerRequestTests.java
@@ -26,7 +26,8 @@ import java.util.Map; import java.util.Optional; import java.util.OptionalLong; -import java.util.Set; +import java.util.function.Supplier; +import java.util.stream.Stream; import org.junit.Before; import org.junit.Test; @@ -52,9 +53,8 @@ import org.springframework.web.server.UnsupportedMediaT...
true
Other
spring-projects
spring-framework
f4cf55cb2b189d0071eff6834a3f7080ce0b000a.json
Add support for WebFilter and WebExceptionHandler This commit adds support for configuring `WebFilter` and `WebExceptionHandler` instances in HandlerStrategies. It also drops the "native" support for `ResponseStatusException`s, in favor of the `ResponseStatusExceptionHandler`, which is registered by default. Issue: S...
spring-webflux/src/test/java/org/springframework/web/reactive/function/server/ResourceHandlerFunctionTests.java
@@ -33,8 +33,7 @@ import org.springframework.mock.http.server.reactive.test.MockServerHttpResponse; import org.springframework.mock.http.server.reactive.test.MockServerWebExchange; -import static org.junit.Assert.assertArrayEquals; -import static org.junit.Assert.assertEquals; +import static org.junit.Assert.*; ...
true
Other
spring-projects
spring-framework
f4cf55cb2b189d0071eff6834a3f7080ce0b000a.json
Add support for WebFilter and WebExceptionHandler This commit adds support for configuring `WebFilter` and `WebExceptionHandler` instances in HandlerStrategies. It also drops the "native" support for `ResponseStatusException`s, in favor of the `ResponseStatusExceptionHandler`, which is registered by default. Issue: S...
spring-webflux/src/test/java/org/springframework/web/reactive/function/server/RouterFunctionsTests.java
@@ -17,6 +17,7 @@ package org.springframework.web.reactive.function.server; import java.util.Optional; +import java.util.concurrent.atomic.AtomicBoolean; import org.junit.Test; import reactor.core.publisher.Mono; @@ -29,6 +30,8 @@ import org.springframework.mock.http.server.reactive.test.MockServerHttpResponse...
true
Other
spring-projects
spring-framework
8db4b2f7ed4b3a8efb8eadf630ae8693048a641b.json
Remove synchronized block around PathPatternParser Removed the synchronized block around PathPatternParser, since it is now thread-safe.
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RequestPredicates.java
@@ -95,11 +95,7 @@ public static RequestPredicate path(String pattern) { */ public static Function<String, RequestPredicate> pathPredicates(PathPatternParser patternParser) { Assert.notNull(patternParser, "'patternParser' must not be null"); - return pattern -> { - synchronized (patternParser) { - return ...
false
Other
spring-projects
spring-framework
285fa1cc2cf2b911e407167e75ab76b5b27bd764.json
Fix typos in Kotlin extensions documentation
spring-web/src/main/kotlin/org/springframework/web/client/RestOperationsExtensions.kt
@@ -8,7 +8,7 @@ import java.net.URI /** - * Extension for [RestOperations.getForObject] avoiding specifying thanks to Kotlin reified type parameters. + * Extension for [RestOperations.getForObject] avoiding specifying the type parameter thanks to Kotlin reified type parameters. * * @author Jon Schneider * @a...
false
Other
spring-projects
spring-framework
f0f3df5cc05be50335498fece59fbfc53fe825f7.json
Use PathPattern in PathResourceLookupFunction
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/PathResourceLookupFunction.java
@@ -26,10 +26,10 @@ import org.springframework.core.io.ClassPathResource; import org.springframework.core.io.Resource; import org.springframework.core.io.UrlResource; -import org.springframework.util.AntPathMatcher; -import org.springframework.util.PathMatcher; import org.springframework.util.ResourceUtils; import...
false
Other
spring-projects
spring-framework
ba3a12e4ccadb561603869dd208629296d6a6473.json
Use fixed GMT time-zone for WebSession Clock Issue: SPR-15675
spring-web/src/main/java/org/springframework/web/server/session/DefaultWebSessionManager.java
@@ -17,6 +17,7 @@ import java.time.Clock; import java.time.Instant; +import java.time.ZoneId; import java.util.List; import java.util.UUID; @@ -41,7 +42,7 @@ public class DefaultWebSessionManager implements WebSessionManager { private WebSessionStore sessionStore = new InMemoryWebSessionStore(); - private...
false
Other
spring-projects
spring-framework
8ac29c8ce7055e1421ba5995ebb44f0aecc92223.json
Add cloneBuilder method on WebClient.Builder This commit adds a new `cloneBuilder()` method on `WebClient.Builder`; we can now reuse the customizations of an existing builder without sharing its state across several `WebClient` building code paths. Issue: SPR-15690
spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClientBuilder.java
@@ -92,6 +92,11 @@ public WebClient.Builder baseUrl(String baseUrl) { return this; } + @Override + public WebClient.Builder cloneBuilder() { + return new DefaultWebClientBuilder(this); + } + @Override public WebClient.Builder defaultUriVariables(Map<String, ?> defaultUriVariables) { this.defaultUriVariab...
true
Other
spring-projects
spring-framework
8ac29c8ce7055e1421ba5995ebb44f0aecc92223.json
Add cloneBuilder method on WebClient.Builder This commit adds a new `cloneBuilder()` method on `WebClient.Builder`; we can now reuse the customizations of an existing builder without sharing its state across several `WebClient` building code paths. Issue: SPR-15690
spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClient.java
@@ -192,6 +192,11 @@ interface Builder { */ Builder baseUrl(String baseUrl); + /** + * Clone this {@code WebClient.Builder} + */ + Builder cloneBuilder(); + /** * Configure default URI variable values that will be used when expanding * URI templates using a {@link Map}.
true
Other
spring-projects
spring-framework
4db0ce12e1df049d651a03894b1307bd002833cf.json
Add MockServerConfigurer to WebTestClient Issue: SPR-15674
spring-test/src/main/java/org/springframework/test/web/reactive/server/AbstractMockServerSpec.java
@@ -35,27 +35,32 @@ private final List<WebFilter> filters = new ArrayList<>(4); + private final List<MockServerConfigurer> configurers = new ArrayList<>(4); + @Override public <T extends B> T webFilter(WebFilter... filter) { this.filters.addAll(Arrays.asList(filter)); return self(); } + @Override ...
true
Other
spring-projects
spring-framework
4db0ce12e1df049d651a03894b1307bd002833cf.json
Add MockServerConfigurer to WebTestClient Issue: SPR-15674
spring-test/src/main/java/org/springframework/test/web/reactive/server/MockServerConfigurer.java
@@ -0,0 +1,60 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
4db0ce12e1df049d651a03894b1307bd002833cf.json
Add MockServerConfigurer to WebTestClient Issue: SPR-15674
spring-test/src/main/java/org/springframework/test/web/reactive/server/WebTestClient.java
@@ -203,6 +203,12 @@ static Builder bindToServer() { */ <T extends B> T webFilter(WebFilter... filter); + /** + * Shortcut for pre-packaged customizations to the mock server setup. + * @param configurer the configurer to apply + */ + <T extends B> T apply(MockServerConfigurer configurer); + /** ...
true
Other
spring-projects
spring-framework
4db0ce12e1df049d651a03894b1307bd002833cf.json
Add MockServerConfigurer to WebTestClient Issue: SPR-15674
spring-test/src/test/java/org/springframework/test/web/reactive/server/MockServerSpecTests.java
@@ -0,0 +1,108 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4a0597d612d68d6e948c748da8d36621639d1b7f.json
Replace WebClient.filter with Builder.filter This commit replaces the WebClient.filter method with WebClient.Builder.filter. The reason for this change is that filters added via WebClient.filter would be applied in the opposite order of their declaration, due to the compositional nature of the method, combined with th...
spring-test/src/main/java/org/springframework/test/web/reactive/server/DefaultWebTestClient.java
@@ -48,13 +48,14 @@ import org.springframework.web.reactive.function.BodyExtractor; import org.springframework.web.reactive.function.BodyInserter; import org.springframework.web.reactive.function.client.ClientResponse; -import org.springframework.web.reactive.function.client.ExchangeFilterFunction; import org.sprin...
true
Other
spring-projects
spring-framework
4a0597d612d68d6e948c748da8d36621639d1b7f.json
Replace WebClient.filter with Builder.filter This commit replaces the WebClient.filter method with WebClient.Builder.filter. The reason for this change is that filters added via WebClient.filter would be applied in the opposite order of their declaration, due to the compositional nature of the method, combined with th...
spring-test/src/main/java/org/springframework/test/web/reactive/server/DefaultWebTestClientBuilder.java
@@ -17,10 +17,15 @@ package org.springframework.test.web.reactive.server; import java.time.Duration; +import java.util.List; +import java.util.function.Consumer; +import org.springframework.http.HttpHeaders; import org.springframework.http.client.reactive.ClientHttpConnector; import org.springframework.http.cli...
true
Other
spring-projects
spring-framework
4a0597d612d68d6e948c748da8d36621639d1b7f.json
Replace WebClient.filter with Builder.filter This commit replaces the WebClient.filter method with WebClient.Builder.filter. The reason for this change is that filters added via WebClient.filter would be applied in the opposite order of their declaration, due to the compositional nature of the method, combined with th...
spring-test/src/main/java/org/springframework/test/web/reactive/server/WebTestClient.java
@@ -43,7 +43,6 @@ import org.springframework.web.reactive.config.WebFluxConfigurer; import org.springframework.web.reactive.function.BodyInserter; import org.springframework.web.reactive.function.client.ExchangeFilterFunction; -import org.springframework.web.reactive.function.client.ExchangeFunction; import org.spr...
true
Other
spring-projects
spring-framework
4a0597d612d68d6e948c748da8d36621639d1b7f.json
Replace WebClient.filter with Builder.filter This commit replaces the WebClient.filter method with WebClient.Builder.filter. The reason for this change is that filters added via WebClient.filter would be applied in the opposite order of their declaration, due to the compositional nature of the method, combined with th...
spring-test/src/test/java/org/springframework/test/web/reactive/server/samples/ExchangeMutatorWebFilterTests.java
@@ -59,8 +59,14 @@ public void globalMutator() throws Exception { @Test public void perRequestMutators() throws Exception { - this.webTestClient + + this.webTestClient = WebTestClient.bindToController(new TestController()) + .webFilter(this.exchangeMutator) + .configureClient() .filter(this.exchangeM...
true
Other
spring-projects
spring-framework
4a0597d612d68d6e948c748da8d36621639d1b7f.json
Replace WebClient.filter with Builder.filter This commit replaces the WebClient.filter method with WebClient.Builder.filter. The reason for this change is that filters added via WebClient.filter would be applied in the opposite order of their declaration, due to the compositional nature of the method, combined with th...
spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClient.java
@@ -24,6 +24,7 @@ import java.util.Arrays; import java.util.List; import java.util.Map; +import java.util.function.Consumer; import java.util.function.Function; import org.reactivestreams.Publisher; @@ -66,16 +67,18 @@ class DefaultWebClient implements WebClient { private final MultiValueMap<String, String> ...
true
Other
spring-projects
spring-framework
4a0597d612d68d6e948c748da8d36621639d1b7f.json
Replace WebClient.filter with Builder.filter This commit replaces the WebClient.filter method with WebClient.Builder.filter. The reason for this change is that filters added via WebClient.filter would be applied in the opposite order of their declaration, due to the compositional nature of the method, combined with th...
spring-webflux/src/main/java/org/springframework/web/reactive/function/client/DefaultWebClientBuilder.java
@@ -16,13 +16,20 @@ package org.springframework.web.reactive.function.client; +import java.util.ArrayList; import java.util.Arrays; +import java.util.Collections; +import java.util.LinkedHashMap; +import java.util.List; import java.util.Map; +import java.util.function.Consumer; import org.springframework.http...
true
Other
spring-projects
spring-framework
4a0597d612d68d6e948c748da8d36621639d1b7f.json
Replace WebClient.filter with Builder.filter This commit replaces the WebClient.filter method with WebClient.Builder.filter. The reason for this change is that filters added via WebClient.filter would be applied in the opposite order of their declaration, due to the compositional nature of the method, combined with th...
spring-webflux/src/main/java/org/springframework/web/reactive/function/client/WebClient.java
@@ -21,6 +21,7 @@ import java.time.ZonedDateTime; import java.util.List; import java.util.Map; +import java.util.function.Consumer; import java.util.function.Function; import org.reactivestreams.Publisher; @@ -108,12 +109,9 @@ public interface WebClient { /** - * Filter the client with the given {@code Ex...
true
Other
spring-projects
spring-framework
4a0597d612d68d6e948c748da8d36621639d1b7f.json
Replace WebClient.filter with Builder.filter This commit replaces the WebClient.filter method with WebClient.Builder.filter. The reason for this change is that filters added via WebClient.filter would be applied in the opposite order of their declaration, due to the compositional nature of the method, combined with th...
spring-webflux/src/test/java/org/springframework/web/reactive/function/client/DefaultWebClientTests.java
@@ -124,6 +124,28 @@ public void bodyObjectPublisher() throws Exception { client.post().uri("http://example.com").syncBody(mono); } + @Test + public void mutateDoesCopy() throws Exception { + + WebClient.Builder builder = WebClient.builder(); + builder.filter((request, next) -> next.exchange(request)); + buil...
true
Other
spring-projects
spring-framework
4a0597d612d68d6e948c748da8d36621639d1b7f.json
Replace WebClient.filter with Builder.filter This commit replaces the WebClient.filter method with WebClient.Builder.filter. The reason for this change is that filters added via WebClient.filter would be applied in the opposite order of their declaration, due to the compositional nature of the method, combined with th...
spring-webflux/src/test/java/org/springframework/web/reactive/function/client/WebClientIntegrationTests.java
@@ -52,11 +52,12 @@ public class WebClientIntegrationTests { private WebClient webClient; + private String baseUrl; @Before public void setup() { this.server = new MockWebServer(); - String baseUrl = this.server.url("/").toString(); + baseUrl = this.server.url("/").toString(); this.webClient = WebCl...
true
Other
spring-projects
spring-framework
b14df2b6ea3dd5e6227e217379f0998492bce3a7.json
Fix a missing line of xml fragment Closes gh-1461
src/docs/asciidoc/web/web-mvc.adoc
@@ -2578,6 +2578,7 @@ For applications configured with a `web.xml` be sure to update to version 3.0: ---- <web-app xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:schemaLocation=" http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/w...
false
Other
spring-projects
spring-framework
67e482aaf898876080c1b36634ed711c0a41267d.json
Fix ROOT_PATH constant to match recent changes "/" should be 0 segments, isAbsolute=true, hasTrailingSlash=false
spring-web/src/main/java/org/springframework/http/server/reactive/DefaultPathSegmentContainer.java
@@ -43,7 +43,7 @@ class DefaultPathSegmentContainer implements PathSegmentContainer { new DefaultPathSegmentContainer("", Collections.emptyList()); private static final PathSegmentContainer ROOT_PATH = - new DefaultPathSegmentContainer("/", Collections.singletonList(EMPTY_PATH_SEGMENT)); + new DefaultPathSe...
true
Other
spring-projects
spring-framework
67e482aaf898876080c1b36634ed711c0a41267d.json
Fix ROOT_PATH constant to match recent changes "/" should be 0 segments, isAbsolute=true, hasTrailingSlash=false
spring-web/src/test/java/org/springframework/http/server/reactive/DefaultPathSegmentContainerTests.java
@@ -92,7 +92,7 @@ public void path() throws Exception { testPath("/a/b/c", "/a/b/c", false, true, Arrays.asList("a", "b", "c"), false); // root path - testPath("/", "/", false, true, Collections.singletonList(""), false); + testPath("/", "/", false, true, Collections.emptyList(), false); // empty path ...
true
Other
spring-projects
spring-framework
53e8ebe6a66e71f2565c496861a0baa0db80359e.json
Fix failing test (after previous commit)
spring-web/src/main/java/org/springframework/http/server/reactive/DefaultPathSegmentContainer.java
@@ -190,10 +190,14 @@ private static void parseParamValues(String input, Charset charset, MultiValueMa } static PathSegmentContainer subPath(PathSegmentContainer container, int fromIndex, int toIndex) { + if (fromIndex == toIndex) { + return EMPTY_PATH; + } List<PathSegment> segments = container.pathSegmen...
true
Other
spring-projects
spring-framework
53e8ebe6a66e71f2565c496861a0baa0db80359e.json
Fix failing test (after previous commit)
spring-web/src/test/java/org/springframework/http/server/reactive/DefaultRequestPathTests.java
@@ -36,6 +36,9 @@ public void requestPath() throws Exception { // no context path testRequestPath("/a/b/c", "", "/a/b/c", false, true, false); + // context path only + testRequestPath("/a/b", "/a/b", "", false, true, false); + // empty path testRequestPath("", "", "", true, false, false); testRequest...
true
Other
spring-projects
spring-framework
97917aa57d898e3e085beb0d17d26728813bb10c.json
Add PathSegmentContainer subPath extracting method
spring-web/src/main/java/org/springframework/http/server/reactive/DefaultPathSegmentContainer.java
@@ -19,6 +19,7 @@ import java.util.ArrayList; import java.util.Collections; import java.util.List; +import java.util.stream.Collectors; import org.springframework.util.Assert; import org.springframework.util.CollectionUtils; @@ -56,7 +57,7 @@ class DefaultPathSegmentContainer implements PathSegmentContainer { ...
true
Other
spring-projects
spring-framework
97917aa57d898e3e085beb0d17d26728813bb10c.json
Add PathSegmentContainer subPath extracting method
spring-web/src/main/java/org/springframework/http/server/reactive/DefaultRequestPath.java
@@ -17,7 +17,6 @@ import java.net.URI; import java.nio.charset.Charset; -import java.util.ArrayList; import java.util.List; import org.springframework.util.Assert; @@ -41,16 +40,15 @@ class DefaultRequestPath implements RequestPath { DefaultRequestPath(URI uri, String contextPath, Charset charset) { this.f...
true
Other
spring-projects
spring-framework
97917aa57d898e3e085beb0d17d26728813bb10c.json
Add PathSegmentContainer subPath extracting method
spring-web/src/main/java/org/springframework/http/server/reactive/PathSegmentContainer.java
@@ -67,4 +67,14 @@ static PathSegmentContainer parse(String path, Charset encoding) { return DefaultPathSegmentContainer.parsePath(path, encoding); } + /** + * Extract a sub-path starting at the given offset into the path segment list. + * @param path the path to extract from + * @param pathSegmentIndex the s...
true
Other
spring-projects
spring-framework
97917aa57d898e3e085beb0d17d26728813bb10c.json
Add PathSegmentContainer subPath extracting method
spring-web/src/test/java/org/springframework/http/server/reactive/DefaultPathSegmentContainerTests.java
@@ -27,6 +27,7 @@ import static java.nio.charset.StandardCharsets.UTF_8; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertSame; /** * Unit tests for {@link DefaultPathSegmentContainer}. @@ -121,4 +122,17 @@ private void testPath(String input, String value, boolean empty, boole...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-beans/src/main/kotlin/org/springframework/beans/factory/BeanFactoryExtensions.kt
@@ -1,15 +1,5 @@ package org.springframework.beans.factory -import kotlin.reflect.KClass - - -/** - * Extension for [BeanFactory.getBean] providing a [KClass] based variant. - * - * @author Sebastien Deleuze - * @since 5.0 - */ -fun <T : Any> BeanFactory.getBean(requiredType: KClass<T>): T = getBean(requiredType.jav...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-beans/src/main/kotlin/org/springframework/beans/factory/ListableBeanFactoryExtensions.kt
@@ -1,18 +1,5 @@ package org.springframework.beans.factory -import kotlin.reflect.KClass - - -/** - * Extension for [ListableBeanFactory.getBeanNamesForType] providing a [KClass] based variant. - * - * @author Sebastien Deleuze - * @since 5.0 - */ -fun <T : Any> ListableBeanFactory.getBeanNamesForType(type: KClass<T...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-beans/src/test/kotlin/org/springframework/beans/factory/BeanFactoryExtensionsTests.kt
@@ -18,12 +18,6 @@ class BeanFactoryExtensionsTests { @Mock(answer = Answers.RETURNS_MOCKS) lateinit var bf: BeanFactory - @Test - fun `getBean with KClass`() { - bf.getBean(Foo::class) - verify(bf, times(1)).getBean(Foo::class.java) - } - @Test fun `getBean with reified type parameters`() { bf.getBean<F...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-beans/src/test/kotlin/org/springframework/beans/factory/ListableBeanFactoryExtensionsTests.kt
@@ -18,24 +18,6 @@ class ListableBeanFactoryExtensionsTests { @Mock(answer = Answers.RETURNS_MOCKS) lateinit var lbf: ListableBeanFactory - @Test - fun `getBeanNamesForType with KClass`() { - lbf.getBeanNamesForType(Foo::class) - verify(lbf, times(1)).getBeanNamesForType(Foo::class.java, true , true) - } - - @T...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-context/src/main/kotlin/org/springframework/context/support/GenericApplicationContextExtensions.kt
@@ -3,19 +3,8 @@ package org.springframework.context.support import org.springframework.beans.factory.config.BeanDefinitionCustomizer import org.springframework.context.ApplicationContext import java.util.function.Supplier -import kotlin.reflect.KClass -/** - * Extension for [GenericApplicationContext.registerBe...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-context/src/test/kotlin/org/springframework/context/support/GenericApplicationContextExtensionsTests.kt
@@ -14,15 +14,15 @@ class GenericApplicationContextExtensionsTests { @Test fun registerBeanWithClass() { val context = GenericApplicationContext() - context.registerBean(BeanA::class) + context.registerBean<BeanA>() context.refresh() - assertNotNull(context.getBean(BeanA::class)) + assertNotNull(context.g...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-jdbc/src/main/kotlin/org/springframework/jdbc/core/JdbcOperationsExtensions.kt
@@ -17,17 +17,8 @@ package org.springframework.jdbc.core import java.sql.ResultSet -import kotlin.reflect.KClass -/** - * Extension for [JdbcOperations.queryForObject] providing a [KClass] based variant - * - * @author Mario Arias - * @since 5.0 - */ -fun <T : Any> JdbcOperations.queryForObject(sql: String, ele...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-jdbc/src/test/kotlin/org/springframework/jdbc/core/JdbcOperationsExtensionsTests.kt
@@ -38,14 +38,6 @@ class JdbcOperationsExtensionsTests { @Mock(answer = Answers.RETURNS_MOCKS) lateinit var template: JdbcTemplate - @Test - fun `queryForObject with KClass`() { - val sql = "select age from customer where id = 3" - val requiredType = Int::class - template.queryForObject(sql, requiredType) - v...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-test/src/main/kotlin/org/springframework/test/web/reactive/server/WebTestClientExtensions.kt
@@ -17,7 +17,6 @@ package org.springframework.test.web.reactive.server import org.reactivestreams.Publisher -import kotlin.reflect.KClass /** * Extension for [WebTestClient.RequestBodySpec.body] providing a variant without explicit class @@ -29,15 +28,6 @@ import kotlin.reflect.KClass inline fun <reified T : ...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-test/src/test/kotlin/org/springframework/test/web/reactive/server/WebTestClientExtensionsTests.kt
@@ -33,36 +33,18 @@ class WebTestClientExtensionsTests { verify(requestBodySpec, times(1)).body(body, Foo::class.java) } - @Test - fun `ResponseSpec#expectBody with KClass`() { - responseSpec.expectBody(Foo::class) - verify(responseSpec, times(1)).expectBody(Foo::class.java) - } - @Test fun `ResponseSpec#e...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/BodyExtractorsExtensions.kt
@@ -3,7 +3,6 @@ package org.springframework.web.reactive.function import org.springframework.http.ReactiveHttpInputMessage import reactor.core.publisher.Flux import reactor.core.publisher.Mono -import kotlin.reflect.KClass /** * Function for providing a `bodyToMono()` alternative to `BodyExtractors.toMono(Foo::...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/client/ClientResponseExtensions.kt
@@ -2,17 +2,8 @@ package org.springframework.web.reactive.function.client import reactor.core.publisher.Flux import reactor.core.publisher.Mono -import kotlin.reflect.KClass -/** - * Extension for [ClientResponse.bodyToMono] providing a [KClass] based variant. - * - * @author Sebastien Deleuze - * @since 5.0 - ...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/client/WebClientExtensions.kt
@@ -20,7 +20,7 @@ import org.reactivestreams.Publisher import org.springframework.http.ResponseEntity import reactor.core.publisher.Flux import reactor.core.publisher.Mono -import kotlin.reflect.KClass + /** * Extension for [WebClient.RequestBodySpec.body] providing a variant without explicit class @@ -33,14 +3...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/server/ServerRequestExtensions.kt
@@ -2,17 +2,8 @@ package org.springframework.web.reactive.function.server import reactor.core.publisher.Flux import reactor.core.publisher.Mono -import kotlin.reflect.KClass -/** - * Extension for [ServerRequest.bodyToMono] providing a [KClass] based variant. - * - * @author Sebastien Deleuze - * @since 5.0 - *...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/BodyExtractorsExtensionsTests.kt
@@ -14,21 +14,11 @@ import org.mockito.junit.MockitoJUnitRunner @RunWith(MockitoJUnitRunner::class) class BodyExtractorsExtensionsTests { - @Test - fun `bodyToMono with KClass`() { - assertNotNull(bodyToMono(Foo::class)) - } - @Test fun `bodyToMono with reified type parameter`() { assertNotNull(bodyToMono<F...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/client/ClientResponseExtensionsTests.kt
@@ -18,24 +18,12 @@ class ClientResponseExtensionsTests { @Mock(answer = Answers.RETURNS_MOCKS) lateinit var response: ClientResponse - @Test - fun `bodyToMono with KClass`() { - response.bodyToMono(Foo::class) - verify(response, times(1)).bodyToMono(Foo::class.java) - } - @Test fun `bodyToMono with reified...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/client/WebClientExtensionsTests.kt
@@ -31,48 +31,24 @@ class WebClientExtensionsTests { verify(requestBodySpec, times(1)).body(body, Foo::class.java) } - @Test - fun `ResponseSpec#bodyToMono with KClass`() { - responseSpec.bodyToMono(Foo::class) - verify(responseSpec, times(1)).bodyToMono(Foo::class.java) - } - @Test fun `ResponseSpec#bodyT...
true
Other
spring-projects
spring-framework
04d5a2951c36bf52f0b6e0eb23fe45ecfacfdb25.json
Remove KClass based Kotlin extensions Issue: SPR-15660
spring-webflux/src/test/kotlin/org/springframework/web/reactive/function/server/ServerRequestExtensionsTests.kt
@@ -21,24 +21,12 @@ class ServerRequestExtensionsTests { @Mock(answer = Answers.RETURNS_MOCKS) lateinit var request: ServerRequest - @Test - fun `bodyToMono with KClass`() { - request.bodyToMono(Foo::class) - verify(request, times(1)).bodyToMono(Foo::class.java) - } - @Test fun `bodyToMono with reified type...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-context/src/main/java/org/springframework/context/i18n/SimpleTimeZoneAwareLocaleContext.java
@@ -52,6 +52,7 @@ public SimpleTimeZoneAwareLocaleContext(@Nullable Locale locale, @Nullable TimeZ } + @Override public TimeZone getTimeZone() { return this.timeZone; }
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-test/src/main/java/org/springframework/mock/http/server/reactive/MockServerWebExchange.java
@@ -18,6 +18,7 @@ import org.springframework.http.codec.ServerCodecConfigurer; import org.springframework.web.server.ServerWebExchangeDecorator; import org.springframework.web.server.adapter.DefaultServerWebExchange; +import org.springframework.web.server.i18n.AcceptHeaderLocaleContextResolver; import org.springfra...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/main/java/org/springframework/web/server/ServerWebExchange.java
@@ -24,11 +24,13 @@ import reactor.core.publisher.Mono; +import org.springframework.context.i18n.LocaleContext; import org.springframework.http.codec.multipart.Part; import org.springframework.http.server.reactive.ServerHttpRequest; import org.springframework.http.server.reactive.ServerHttpResponse; import org...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/main/java/org/springframework/web/server/ServerWebExchangeDecorator.java
@@ -22,6 +22,7 @@ import reactor.core.publisher.Mono; +import org.springframework.context.i18n.LocaleContext; import org.springframework.http.codec.multipart.Part; import org.springframework.http.server.reactive.ServerHttpRequest; import org.springframework.http.server.reactive.ServerHttpResponse; @@ -90,6 +91,...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/main/java/org/springframework/web/server/adapter/DefaultServerWebExchange.java
@@ -28,6 +28,7 @@ import reactor.core.publisher.Mono; +import org.springframework.context.i18n.LocaleContext; import org.springframework.core.ResolvableType; import org.springframework.http.HttpHeaders; import org.springframework.http.HttpMethod; @@ -45,6 +46,7 @@ import org.springframework.util.LinkedMultiVal...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/main/java/org/springframework/web/server/adapter/HttpWebHandlerAdapter.java
@@ -31,9 +31,11 @@ import org.springframework.http.server.reactive.ServerHttpRequest; import org.springframework.http.server.reactive.ServerHttpResponse; import org.springframework.util.Assert; +import org.springframework.web.server.i18n.LocaleContextResolver; import org.springframework.web.server.ServerWebExchange...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/main/java/org/springframework/web/server/adapter/WebHttpHandlerBuilder.java
@@ -27,6 +27,7 @@ import org.springframework.http.server.reactive.HttpHandler; import org.springframework.util.Assert; import org.springframework.util.ObjectUtils; +import org.springframework.web.server.i18n.LocaleContextResolver; import org.springframework.web.server.ServerWebExchange; import org.springframework....
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/main/java/org/springframework/web/server/i18n/AcceptHeaderLocaleContextResolver.java
@@ -0,0 +1,127 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/main/java/org/springframework/web/server/i18n/FixedLocaleContextResolver.java
@@ -0,0 +1,92 @@ +/* + * Copyright 2002-2013 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/main/java/org/springframework/web/server/i18n/LocaleContextResolver.java
@@ -0,0 +1,63 @@ +/* + * Copyright 2002-2013 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/main/java/org/springframework/web/server/i18n/package-info.java
@@ -0,0 +1,8 @@ +/** + * Locale related support classes. + * Provides standard LocaleContextResolver implementations. + */ +@NonNullApi +package org.springframework.web.server.i18n; + +import org.springframework.lang.NonNullApi;
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/test/java/org/springframework/mock/http/server/reactive/test/MockServerHttpRequest.java
@@ -23,6 +23,7 @@ import java.util.Arrays; import java.util.Collection; import java.util.List; +import java.util.Locale; import java.util.Optional; import org.reactivestreams.Publisher; @@ -260,6 +261,13 @@ public static BaseBuilder<?> options(String urlTemplate, Object... uriVars) { */ B acceptCharset(Ch...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/test/java/org/springframework/mock/http/server/reactive/test/MockServerWebExchange.java
@@ -18,6 +18,7 @@ import org.springframework.http.codec.ServerCodecConfigurer; import org.springframework.web.server.ServerWebExchangeDecorator; import org.springframework.web.server.adapter.DefaultServerWebExchange; +import org.springframework.web.server.i18n.AcceptHeaderLocaleContextResolver; import org.springfra...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/test/java/org/springframework/web/server/i18n/AcceptHeaderLocaleContextResolverTests.java
@@ -0,0 +1,95 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/test/java/org/springframework/web/server/i18n/FixedLocaleContextResolverTests.java
@@ -0,0 +1,64 @@ +package org.springframework.web.server.i18n; + +import java.time.ZoneId; +import java.util.Locale; +import java.util.TimeZone; + +import org.junit.Before; +import org.junit.Test; + +import org.springframework.context.i18n.TimeZoneAwareLocaleContext; +import org.springframework.mock.http.server.reactiv...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-web/src/test/java/org/springframework/web/server/session/DefaultWebSessionManagerTests.java
@@ -32,6 +32,7 @@ import org.springframework.web.server.ServerWebExchange; import org.springframework.web.server.WebSession; import org.springframework.web.server.adapter.DefaultServerWebExchange; +import org.springframework.web.server.i18n.AcceptHeaderLocaleContextResolver; import static org.junit.Assert.assertE...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-webflux/src/main/java/org/springframework/web/reactive/config/WebFluxConfigurationSupport.java
@@ -58,9 +58,11 @@ import org.springframework.web.reactive.result.method.annotation.ResponseEntityResultHandler; import org.springframework.web.reactive.result.view.ViewResolutionResultHandler; import org.springframework.web.reactive.result.view.ViewResolver; +import org.springframework.web.server.i18n.LocaleContext...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultHandlerStrategiesBuilder.java
@@ -27,9 +27,11 @@ import org.springframework.http.codec.ServerCodecConfigurer; import org.springframework.util.Assert; import org.springframework.web.reactive.result.view.ViewResolver; +import org.springframework.web.server.i18n.LocaleContextResolver; import org.springframework.web.server.WebExceptionHandler; imp...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultRenderingResponseBuilder.java
@@ -20,7 +20,6 @@ import java.util.Collection; import java.util.Collections; import java.util.LinkedHashMap; -import java.util.List; import java.util.Locale; import java.util.Map; import java.util.stream.Stream; @@ -156,7 +155,7 @@ public Mono<Void> writeTo(ServerWebExchange exchange, Context context) { Serve...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/HandlerStrategies.java
@@ -24,6 +24,7 @@ import org.springframework.http.codec.HttpMessageWriter; import org.springframework.http.codec.ServerCodecConfigurer; import org.springframework.web.reactive.result.view.ViewResolver; +import org.springframework.web.server.i18n.LocaleContextResolver; import org.springframework.web.server.WebExcept...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/RouterFunctions.java
@@ -199,6 +199,7 @@ public static HttpHandler toHttpHandler(RouterFunction<?> routerFunction, Handle return WebHttpHandlerBuilder.webHandler(webHandler) .filters(strategies.webFilters()) .exceptionHandlers(strategies.exceptionHandlers()) + .localeContextResolver(strategies.localeContextResolver()) ...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-webflux/src/main/java/org/springframework/web/reactive/result/view/RequestContext.java
@@ -25,6 +25,8 @@ import org.springframework.context.MessageSource; import org.springframework.context.MessageSourceResolvable; import org.springframework.context.NoSuchMessageException; +import org.springframework.context.i18n.LocaleContext; +import org.springframework.context.i18n.TimeZoneAwareLocaleContext; impo...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-webflux/src/main/java/org/springframework/web/reactive/result/view/ViewResolutionResultHandler.java
@@ -201,8 +201,7 @@ public Mono<Void> handleResult(ServerWebExchange exchange, HandlerResult result) Model model = result.getModel(); MethodParameter parameter = result.getReturnTypeSource(); - List<Locale> locales = exchange.getRequest().getHeaders().getAcceptLanguageAsLocales(); - Locale locale ...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-webflux/src/main/java/org/springframework/web/reactive/result/view/freemarker/FreeMarkerView.java
@@ -21,7 +21,6 @@ import java.io.OutputStreamWriter; import java.io.Writer; import java.nio.charset.Charset; -import java.util.List; import java.util.Locale; import java.util.Map; import java.util.Optional; @@ -189,8 +188,7 @@ protected Mono<Void> renderInternal(Map<String, Object> renderAttributes, logger.de...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-webflux/src/test/java/org/springframework/web/reactive/function/server/LocaleContextResolverIntegrationTests.java
@@ -0,0 +1,108 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/SessionAttributeMethodArgumentResolverTests.java
@@ -43,6 +43,7 @@ import org.springframework.web.server.ServerWebInputException; import org.springframework.web.server.WebSession; import org.springframework.web.server.adapter.DefaultServerWebExchange; +import org.springframework.web.server.i18n.AcceptHeaderLocaleContextResolver; import org.springframework.web.ser...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-webflux/src/test/java/org/springframework/web/reactive/result/method/annotation/WebSessionArgumentResolverTests.java
@@ -31,6 +31,7 @@ import org.springframework.web.server.ServerWebExchange; import org.springframework.web.server.WebSession; import org.springframework.web.server.adapter.DefaultServerWebExchange; +import org.springframework.web.server.i18n.AcceptHeaderLocaleContextResolver; import org.springframework.web.server.se...
true
Other
spring-projects
spring-framework
e0e6736bc58101af13a352d4aa2a6c2dc0994d72.json
Introduce LocaleContextResolver in WebFlux This commit introduces LocaleContextResolver interface, which is used at ServerWebExchange level to resolve Locale, TimeZone and other i18n related informations. It follows Spring MVC locale resolution patterns with a few differences: - Only LocaleContextResolver is support...
spring-webflux/src/test/java/org/springframework/web/reactive/result/view/LocaleContextResolverIntegrationTests.java
@@ -0,0 +1,129 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4b1478d830f3cdbc4eb0d50d84f152d7900f30c3.json
Replace relevant code with lambda See gh-1454
spring-aop/src/main/java/org/springframework/aop/aspectj/DeclareParentsAdvisor.java
@@ -76,12 +76,7 @@ private DeclareParentsAdvisor(Class<?> interfaceType, String typePattern, Class< ClassFilter typePatternFilter = new TypePatternClassFilter(typePattern); // Excludes methods implemented. - ClassFilter exclusion = new ClassFilter() { - @Override - public boolean matches(Class<?> clazz) { ...
true
Other
spring-projects
spring-framework
4b1478d830f3cdbc4eb0d50d84f152d7900f30c3.json
Replace relevant code with lambda See gh-1454
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/ReflectiveAspectJAdvisorFactory.java
@@ -76,21 +76,12 @@ public class ReflectiveAspectJAdvisorFactory extends AbstractAspectJAdvisorFacto Comparator<Method> adviceKindComparator = new ConvertingComparator<>( new InstanceComparator<>( Around.class, Before.class, After.class, AfterReturning.class, AfterThrowing.class), - new Converter<Meth...
true