language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-web/src/main/java/org/springframework/web/bind/support/WebExchangeBindException.java
@@ -98,7 +98,7 @@ public void reject(String errorCode, String defaultMessage) { } @Override - public void reject(String errorCode, @Nullable Object[] errorArgs, String defaultMessage) { + public void reject(String errorCode, @Nullable Object[] errorArgs, @Nullable String defaultMessage) { this.bindingResult.re...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-web/src/main/java/org/springframework/web/client/RestOperations.java
@@ -593,8 +593,8 @@ <T> ResponseEntity<T> exchange(RequestEntity<?> requestEntity, ParameterizedType * @return an arbitrary object, as returned by the {@link ResponseExtractor} */ @Nullable - <T> T execute(String url, HttpMethod method, RequestCallback requestCallback, - ResponseExtractor<T> responseExtractor...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-web/src/main/java/org/springframework/web/context/request/FacesWebRequest.java
@@ -23,6 +23,7 @@ import javax.faces.context.ExternalContext; import javax.faces.context.FacesContext; +import org.springframework.lang.Nullable; import org.springframework.util.StringUtils; /** @@ -151,12 +152,12 @@ public boolean checkNotModified(long lastModifiedTimestamp) { } @Override - public boolea...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-web/src/main/java/org/springframework/web/context/request/ServletWebRequest.java
@@ -35,6 +35,7 @@ import org.springframework.http.HttpMethod; import org.springframework.http.HttpStatus; +import org.springframework.lang.Nullable; import org.springframework.util.CollectionUtils; import org.springframework.util.ObjectUtils; import org.springframework.util.StringUtils; @@ -207,7 +208,7 @@ publi...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-web/src/main/java/org/springframework/web/context/request/WebRequest.java
@@ -234,7 +234,7 @@ public interface WebRequest extends RequestAttributes { * @return true if the request does not require further processing. * @since 4.2 */ - boolean checkNotModified(String etag, long lastModifiedTimestamp); + boolean checkNotModified(@Nullable String etag, long lastModifiedTimestamp); ...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-web/src/main/java/org/springframework/web/context/support/WebApplicationContextUtils.java
@@ -180,7 +180,7 @@ public static void registerWebApplicationScopes(ConfigurableListableBeanFactory * @param beanFactory the BeanFactory to configure * @param sc the ServletContext that we're running within */ - public static void registerWebApplicationScopes(ConfigurableListableBeanFactory beanFactory, Servle...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-web/src/main/java/org/springframework/web/method/support/InvocableHandlerMethod.java
@@ -123,7 +123,7 @@ public void setParameterNameDiscoverer(ParameterNameDiscoverer parameterNameDisc * @exception Exception raised if no suitable argument resolver can be found, * or if the method raised an exception */ - public Object invokeForRequest(NativeWebRequest request, ModelAndViewContainer mavContain...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-web/src/main/java/org/springframework/web/server/ServerWebExchange.java
@@ -27,6 +27,7 @@ import org.springframework.http.codec.multipart.Part; import org.springframework.http.server.reactive.ServerHttpRequest; import org.springframework.http.server.reactive.ServerHttpResponse; +import org.springframework.lang.Nullable; import org.springframework.util.MultiValueMap; /** @@ -137,7 +1...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-web/src/main/java/org/springframework/web/server/ServerWebExchangeDecorator.java
@@ -25,6 +25,7 @@ import org.springframework.http.codec.multipart.Part; import org.springframework.http.server.reactive.ServerHttpRequest; import org.springframework.http.server.reactive.ServerHttpResponse; +import org.springframework.lang.Nullable; import org.springframework.util.Assert; import org.springframewor...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-web/src/main/java/org/springframework/web/server/adapter/DefaultServerWebExchange.java
@@ -39,6 +39,7 @@ import org.springframework.http.codec.multipart.Part; import org.springframework.http.server.reactive.ServerHttpRequest; import org.springframework.http.server.reactive.ServerHttpResponse; +import org.springframework.lang.Nullable; import org.springframework.util.Assert; import org.springframewor...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java
@@ -155,7 +155,7 @@ public static UriComponentsBuilder newInstance() { * @param path the path to initialize with * @return the new {@code UriComponentsBuilder} */ - public static UriComponentsBuilder fromPath(String path) { + public static UriComponentsBuilder fromPath(@Nullable String path) { UriComponents...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-web/src/main/java/org/springframework/web/util/pattern/PathPattern.java
@@ -517,7 +517,7 @@ public static class PathRemainingMatchInfo { private final Map<String, String> matchingVariables; - PathRemainingMatchInfo(String pathRemaining) { + PathRemainingMatchInfo(@Nullable String pathRemaining) { this(pathRemaining, Collections.emptyMap()); }
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webflux/src/main/java/org/springframework/web/reactive/BindingContext.java
@@ -74,7 +74,7 @@ public Model getModel() { * @param name the name of the target object * @return the created data binder */ - public WebExchangeDataBinder createDataBinder(ServerWebExchange exchange, Object target, String name) { + public WebExchangeDataBinder createDataBinder(ServerWebExchange exchange, @Nul...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webflux/src/main/java/org/springframework/web/reactive/resource/AppCacheManifestTransformer.java
@@ -35,6 +35,7 @@ import reactor.core.publisher.SynchronousSink; import org.springframework.core.io.Resource; +import org.springframework.lang.Nullable; import org.springframework.util.DigestUtils; import org.springframework.util.FileCopyUtils; import org.springframework.util.StringUtils; @@ -242,7 +243,7 @@ pri...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webflux/src/main/java/org/springframework/web/reactive/resource/DefaultResourceResolverChain.java
@@ -48,7 +48,7 @@ public DefaultResourceResolverChain(List<? extends ResourceResolver> resolvers) @Override - public Mono<Resource> resolveResource(ServerWebExchange exchange, String requestPath, + public Mono<Resource> resolveResource(@Nullable ServerWebExchange exchange, String requestPath, List<? extends R...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webflux/src/main/java/org/springframework/web/reactive/resource/ResourceResolverChain.java
@@ -21,6 +21,7 @@ import reactor.core.publisher.Mono; import org.springframework.core.io.Resource; +import org.springframework.lang.Nullable; import org.springframework.web.server.ServerWebExchange; /** @@ -40,7 +41,7 @@ public interface ResourceResolverChain { * @param locations the locations to search in w...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/ControllerMethodResolver.java
@@ -38,6 +38,7 @@ import org.springframework.core.annotation.AnnotationUtils; import org.springframework.http.codec.HttpMessageReader; import org.springframework.http.codec.ServerCodecConfigurer; +import org.springframework.lang.Nullable; import org.springframework.util.Assert; import org.springframework.util.Refl...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webflux/src/main/java/org/springframework/web/reactive/result/method/annotation/HttpEntityArgumentResolver.java
@@ -26,6 +26,7 @@ import org.springframework.http.RequestEntity; import org.springframework.http.codec.HttpMessageReader; import org.springframework.http.server.reactive.ServerHttpRequest; +import org.springframework.lang.Nullable; import org.springframework.web.reactive.BindingContext; import org.springframework....
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/FrameworkServlet.java
@@ -1030,7 +1030,7 @@ protected LocaleContext buildLocaleContext(HttpServletRequest request) { */ @Nullable protected ServletRequestAttributes buildRequestAttributes( - HttpServletRequest request, HttpServletResponse response, RequestAttributes previousAttributes) { + HttpServletRequest request, HttpServletR...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/HandlerExecutionChain.java
@@ -162,7 +162,7 @@ void applyPostHandle(HttpServletRequest request, HttpServletResponse response, M * Will just invoke afterCompletion for all interceptors whose preHandle invocation * has successfully completed and returned true. */ - void triggerAfterCompletion(HttpServletRequest request, HttpServletRespons...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/config/MvcNamespaceUtils.java
@@ -69,7 +69,7 @@ public static void registerDefaultComponents(ParserContext parserContext, Object * under that well-known name, unless already registered. * @return a RuntimeBeanReference to this {@link UrlPathHelper} instance */ - public static RuntimeBeanReference registerUrlPathHelper(RuntimeBeanReference ...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/DefaultServletHandlerConfigurer.java
@@ -71,7 +71,7 @@ public void enable() { * This is useful when the default Servlet cannot be auto-detected, for example when it has been manually configured. * @see DefaultServletHttpRequestHandler */ - public void enable(String defaultServletName) { + public void enable(@Nullable String defaultServletName) { ...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/AbstractMessageConverterMethodProcessor.java
@@ -40,6 +40,7 @@ import org.springframework.http.converter.HttpMessageNotWritableException; import org.springframework.http.server.ServletServerHttpRequest; import org.springframework.http.server.ServletServerHttpResponse; +import org.springframework.lang.Nullable; import org.springframework.util.CollectionUtils; ...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/MvcUriComponentsBuilder.java
@@ -159,7 +159,7 @@ public static UriComponentsBuilder fromController(Class<?> controllerType) { * @param controllerType the controller to build a URI for * @return a UriComponentsBuilder instance (never {@code null}) */ - public static UriComponentsBuilder fromController(UriComponentsBuilder builder, + public...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ResponseBodyEmitter.java
@@ -157,7 +157,7 @@ public void send(Object object) throws IOException { * @throws IOException raised when an I/O error occurs * @throws java.lang.IllegalStateException wraps any other errors */ - public synchronized void send(Object object, MediaType mediaType) throws IOException { + public synchronized void ...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ResponseEntityExceptionHandler.java
@@ -203,7 +203,7 @@ else if (ex instanceof AsyncRequestTimeoutException) { * @param status the response status * @param request the current request */ - protected ResponseEntity<Object> handleExceptionInternal(Exception ex, Object body, + protected ResponseEntity<Object> handleExceptionInternal(Exception ex, @...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/SseEmitter.java
@@ -25,6 +25,7 @@ import org.springframework.http.HttpHeaders; import org.springframework.http.MediaType; import org.springframework.http.server.ServerHttpResponse; +import org.springframework.lang.Nullable; import org.springframework.util.ObjectUtils; import org.springframework.util.StringUtils; @@ -103,7 +104,...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/AppCacheManifestTransformer.java
@@ -31,6 +31,7 @@ import org.apache.commons.logging.LogFactory; import org.springframework.core.io.Resource; +import org.springframework.lang.Nullable; import org.springframework.util.DigestUtils; import org.springframework.util.FileCopyUtils; import org.springframework.util.StringUtils; @@ -212,7 +213,7 @@ priv...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/DefaultResourceResolverChain.java
@@ -21,6 +21,7 @@ import javax.servlet.http.HttpServletRequest; import org.springframework.core.io.Resource; +import org.springframework.lang.Nullable; import org.springframework.util.Assert; /** @@ -47,7 +48,7 @@ public DefaultResourceResolverChain(List<? extends ResourceResolver> resolvers) @Override - ...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceResolverChain.java
@@ -43,7 +43,7 @@ public interface ResourceResolverChain { * @return the resolved resource or {@code null} if unresolved */ @Nullable - Resource resolveResource(HttpServletRequest request, String requestPath, List<? extends Resource> locations); + Resource resolveResource(@Nullable HttpServletRequest request, S...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/support/RequestContext.java
@@ -222,7 +222,7 @@ protected RequestContext() { * @see org.springframework.web.servlet.DispatcherServlet#LOCALE_RESOLVER_ATTRIBUTE * @see org.springframework.web.servlet.DispatcherServlet#THEME_RESOLVER_ATTRIBUTE */ - protected void initContext(HttpServletRequest request, HttpServletResponse response, @Nullab...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/view/AbstractView.java
@@ -105,7 +105,7 @@ public String getBeanName() { * <p>May be ignored by subclasses if the view itself is assumed * to set the content type, e.g. in case of JSPs. */ - public void setContentType(String contentType) { + public void setContentType(@Nullable String contentType) { this.contentType = contentType...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-webmvc/src/main/java/org/springframework/web/servlet/view/script/ScriptTemplateView.java
@@ -178,7 +178,7 @@ public void setRenderFunction(String functionName) { * @since 4.2.1 */ @Override - public void setContentType(String contentType) { + public void setContentType(@Nullable String contentType) { super.setContentType(contentType); }
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-websocket/src/main/java/org/springframework/web/socket/WebSocketHttpHeaders.java
@@ -24,6 +24,7 @@ import java.util.Set; import org.springframework.http.HttpHeaders; +import org.springframework.lang.Nullable; import org.springframework.util.CollectionUtils; /** @@ -217,7 +218,7 @@ public String getFirst(String headerName) { * @see #set(String, String) */ @Override - public void add(...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-websocket/src/main/java/org/springframework/web/socket/client/AbstractWebSocketClient.java
@@ -27,6 +27,7 @@ import org.apache.commons.logging.LogFactory; import org.springframework.http.HttpHeaders; +import org.springframework.lang.Nullable; import org.springframework.util.Assert; import org.springframework.util.concurrent.ListenableFuture; import org.springframework.web.socket.WebSocketExtension; @@...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-websocket/src/main/java/org/springframework/web/socket/client/WebSocketClient.java
@@ -18,6 +18,7 @@ import java.net.URI; +import org.springframework.lang.Nullable; import org.springframework.util.concurrent.ListenableFuture; import org.springframework.web.socket.WebSocketHandler; import org.springframework.web.socket.WebSocketHttpHeaders; @@ -38,6 +39,6 @@ ListenableFuture<WebSocketSession> ...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-websocket/src/main/java/org/springframework/web/socket/messaging/WebSocketStompClient.java
@@ -29,6 +29,7 @@ import org.springframework.context.Lifecycle; import org.springframework.context.SmartLifecycle; +import org.springframework.lang.Nullable; import org.springframework.messaging.Message; import org.springframework.messaging.simp.stomp.BufferingStompDecoder; import org.springframework.messaging.s...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-websocket/src/main/java/org/springframework/web/socket/sockjs/SockJsException.java
@@ -17,6 +17,7 @@ package org.springframework.web.socket.sockjs; import org.springframework.core.NestedRuntimeException; +import org.springframework.lang.Nullable; /** * Base class for exceptions raised while processing SockJS HTTP requests. @@ -45,7 +46,7 @@ public SockJsException(String message, Throwable ca...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/AbstractClientSockJsSession.java
@@ -26,6 +26,7 @@ import org.apache.commons.logging.LogFactory; import org.springframework.http.HttpHeaders; +import org.springframework.lang.Nullable; import org.springframework.util.Assert; import org.springframework.util.concurrent.SettableListenableFuture; import org.springframework.web.socket.CloseStatus; @...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/DefaultTransportRequest.java
@@ -27,6 +27,7 @@ import org.apache.commons.logging.LogFactory; import org.springframework.http.HttpHeaders; +import org.springframework.lang.Nullable; import org.springframework.scheduling.TaskScheduler; import org.springframework.util.Assert; import org.springframework.util.concurrent.ListenableFutureCallback;...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/JettyXhrTransport.java
@@ -33,6 +33,7 @@ import org.springframework.http.HttpHeaders; import org.springframework.http.HttpStatus; import org.springframework.http.ResponseEntity; +import org.springframework.lang.Nullable; import org.springframework.util.Assert; import org.springframework.util.concurrent.SettableListenableFuture; import ...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-websocket/src/main/java/org/springframework/web/socket/sockjs/client/SockJsClient.java
@@ -239,7 +239,7 @@ public ListenableFuture<WebSocketSession> doHandshake( @Override public final ListenableFuture<WebSocketSession> doHandshake( - WebSocketHandler handler, WebSocketHttpHeaders headers, URI url) { + WebSocketHandler handler, @Nullable WebSocketHttpHeaders headers, URI url) { Assert.notN...
true
Other
spring-projects
spring-framework
1f28825f9da63a13aaf8940aadedcf81358dc506.json
Add more @Nullable parameters based on null usage Issue: SPR-15540
spring-websocket/src/main/java/org/springframework/web/socket/sockjs/transport/handler/DefaultSockJsService.java
@@ -26,6 +26,7 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; +import org.springframework.lang.Nullable; import org.springframework.scheduling.TaskScheduler; import org.springframework.web.context.ServletContextAware; import org.springframework.web.socket.server.support.D...
true
Other
spring-projects
spring-framework
30bd3d873682734502554a25db398906215c81f1.json
Allow use of WebFilters in RouterFunction This commit changes RouterFunctions.toHttpHandler to return HttpWebHandlerAdapter (instead of HttpHandler), so that WebFilters and WebExceptionHandler can be applied to it. Issue: SPR-14979
spring-web-reactive/src/main/java/org/springframework/web/reactive/function/RouterFunctions.java
@@ -27,7 +27,9 @@ import org.springframework.util.Assert; import org.springframework.web.reactive.HandlerMapping; import org.springframework.web.server.ServerWebExchange; +import org.springframework.web.server.WebHandler; import org.springframework.web.server.adapter.HttpWebHandlerAdapter; +import org.springframewo...
false
Other
spring-projects
spring-framework
9e720330366bafa3ebeaed3cd99e5bca710308d5.json
Add WebClient.filter method This commit introduces a new method on WebClient: filter, which takes an filter function, and returns a (filtered) WebClient. Issue: SPR-14961
spring-web/src/main/java/org/springframework/web/client/reactive/DefaultWebClientBuilder.java
@@ -95,6 +95,14 @@ private Mono<ClientResponse> exchangeInternal(ClientRequest<?> request) { this.strategies)); } + @Override + public WebClient filter(ExchangeFilterFunction filter) { + Assert.notNull(filter, "'filter' must not be null"); + + ExchangeFilterFunction composedFilter = filter.andThen(th...
true
Other
spring-projects
spring-framework
9e720330366bafa3ebeaed3cd99e5bca710308d5.json
Add WebClient.filter method This commit introduces a new method on WebClient: filter, which takes an filter function, and returns a (filtered) WebClient. Issue: SPR-14961
spring-web/src/main/java/org/springframework/web/client/reactive/WebClient.java
@@ -50,6 +50,15 @@ public interface WebClient extends ExchangeFunction { @Override Mono<ClientResponse> exchange(ClientRequest<?> request); + /** + * Filters this client with the given {@code ExchangeFilterFunction}, resulting in a filtered + * {@code WebClient}. + * @param filterFunction the filter to apply t...
true
Other
spring-projects
spring-framework
9e720330366bafa3ebeaed3cd99e5bca710308d5.json
Add WebClient.filter method This commit introduces a new method on WebClient: filter, which takes an filter function, and returns a (filtered) WebClient. Issue: SPR-14961
spring-web/src/test/java/org/springframework/web/client/reactive/WebClientIntegrationTests.java
@@ -268,7 +268,7 @@ public void notFound() throws Exception { } @Test - public void filter() throws Exception { + public void buildFilter() throws Exception { HttpUrl baseUrl = server.url("/greeting?name=Spring"); this.server.enqueue(new MockResponse().setHeader("Content-Type", "text/plain").setBody("Hello ...
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web-reactive/src/main/java/org/springframework/web/reactive/function/DefaultServerResponseBuilder.java
@@ -25,6 +25,7 @@ import java.util.LinkedHashSet; import java.util.Locale; import java.util.Map; +import java.util.Set; import java.util.function.Supplier; import java.util.stream.Collectors; import java.util.stream.Stream; @@ -55,12 +56,12 @@ */ class DefaultServerResponseBuilder implements ServerResponse.Bod...
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web-reactive/src/main/java/org/springframework/web/reactive/function/HandlerFilterFunction.java
@@ -16,6 +16,8 @@ package org.springframework.web.reactive.function; +import java.util.function.Function; + import org.springframework.util.Assert; import org.springframework.web.reactive.function.support.ServerRequestWrapper; @@ -70,4 +72,31 @@ default HandlerFunction<R> apply(HandlerFunction<T> handler) { ...
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web-reactive/src/main/java/org/springframework/web/reactive/function/PathResourceLookupFunction.java
@@ -0,0 +1,159 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web-reactive/src/main/java/org/springframework/web/reactive/function/ResourceHandlerFunction.java
@@ -0,0 +1,136 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web-reactive/src/main/java/org/springframework/web/reactive/function/RouterFunctions.java
@@ -18,9 +18,11 @@ import java.util.Map; import java.util.Optional; +import java.util.function.Function; import reactor.core.publisher.Mono; +import org.springframework.core.io.Resource; import org.springframework.http.server.reactive.HttpHandler; import org.springframework.util.Assert; import org.springfra...
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web-reactive/src/main/java/org/springframework/web/reactive/function/ServerResponse.java
@@ -82,7 +82,7 @@ */ static BodyBuilder from(ServerResponse<?> other) { Assert.notNull(other, "'other' must not be null"); - DefaultServerResponseBuilder builder = new DefaultServerResponseBuilder(other.statusCode().value()); + DefaultServerResponseBuilder builder = new DefaultServerResponseBuilder(other.stat...
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web-reactive/src/test/java/org/springframework/web/reactive/function/DefaultServerResponseBuilderTests.java
@@ -77,12 +77,6 @@ public void status() throws Exception { assertEquals(HttpStatus.CREATED, result.statusCode()); } - @Test - public void statusInt() throws Exception { - ServerResponse<Void> result = ServerResponse.status(201).build(); - assertEquals(HttpStatus.CREATED, result.statusCode()); - } - @Test p...
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web-reactive/src/test/java/org/springframework/web/reactive/function/PathResourceLookupFunctionTests.java
@@ -0,0 +1,78 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web-reactive/src/test/java/org/springframework/web/reactive/function/ResourceHandlerFunctionTests.java
@@ -0,0 +1,151 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web-reactive/src/test/resources/org/springframework/web/reactive/function/child/response.txt
@@ -0,0 +1,2 @@ +Hello World +This is a sample response text file.
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web-reactive/src/test/resources/org/springframework/web/reactive/function/response.txt
@@ -0,0 +1,2 @@ +Hello World +This is a sample response text file.
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web/src/main/java/org/springframework/http/codec/BodyInserter.java
@@ -30,6 +30,7 @@ * * @author Arjen Poutsma * @since 5.0 + * @see BodyInserters */ public interface BodyInserter<T, M extends ReactiveHttpOutputMessage> {
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web/src/main/java/org/springframework/http/codec/BodyInserters.java
@@ -48,6 +48,16 @@ public abstract class BodyInserters { private static final ResolvableType SERVER_SIDE_EVENT_TYPE = ResolvableType.forClass(ServerSentEvent.class); + /** + * Return an empty {@code BodyInserter} that writes nothing. + * @return an empty {@code BodyInserter} + */ + public static <T> BodyInse...
true
Other
spring-projects
spring-framework
136b33bc4a7ae4bf43730e9b17f35c30be30058e.json
Allow serving static files from RouterFunctions This commit adds the ability to serve Resources (static files) through a RouterFunction. Two methods have been added to RouterFunctions: one that exposes a given directory given a path pattern, and a generic method that requires a lookup function. Issue: SPR-14913
spring-web/src/main/java/org/springframework/web/util/UriUtils.java
@@ -18,6 +18,7 @@ import java.io.ByteArrayOutputStream; import java.io.UnsupportedEncodingException; +import java.nio.charset.Charset; import org.springframework.util.Assert; @@ -183,8 +184,26 @@ public static String encode(String source, String encoding) throws UnsupportedEn * @see java.net.URLDecoder#deco...
true
Other
spring-projects
spring-framework
b874692452d63c61b25ccad591662a7e1e269e56.json
Simplify ReactorNettyTcpClient input Create a ReactorNettyCodec to hold the decoding and encoding function and consumer along with a package-private sub-class that delegates to StompDecoder and StompEncoder. Issue: SPR-14531
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/ReactorNettyTcpStompClient.java
@@ -16,16 +16,9 @@ package org.springframework.messaging.simp.stomp; -import java.util.List; -import java.util.function.BiConsumer; -import java.util.function.Function; - -import io.netty.buffer.ByteBuf; -import reactor.core.scheduler.Schedulers; - -import org.springframework.messaging.Message; import org.springf...
true
Other
spring-projects
spring-framework
b874692452d63c61b25ccad591662a7e1e269e56.json
Simplify ReactorNettyTcpClient input Create a ReactorNettyCodec to hold the decoding and encoding function and consumer along with a package-private sub-class that delegates to StompDecoder and StompEncoder. Issue: SPR-14531
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompBrokerRelayMessageHandler.java
@@ -40,6 +40,7 @@ import org.springframework.messaging.tcp.TcpConnection; import org.springframework.messaging.tcp.TcpConnectionHandler; import org.springframework.messaging.tcp.TcpOperations; +import org.springframework.messaging.tcp.reactor.ReactorNettyCodec; import org.springframework.messaging.tcp.reactor.React...
true
Other
spring-projects
spring-framework
b874692452d63c61b25ccad591662a7e1e269e56.json
Simplify ReactorNettyTcpClient input Create a ReactorNettyCodec to hold the decoding and encoding function and consumer along with a package-private sub-class that delegates to StompDecoder and StompEncoder. Issue: SPR-14531
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompReactorNettyCodec.java
@@ -0,0 +1,42 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
b874692452d63c61b25ccad591662a7e1e269e56.json
Simplify ReactorNettyTcpClient input Create a ReactorNettyCodec to hold the decoding and encoding function and consumer along with a package-private sub-class that delegates to StompDecoder and StompEncoder. Issue: SPR-14531
spring-messaging/src/main/java/org/springframework/messaging/tcp/reactor/ReactorNettyCodec.java
@@ -0,0 +1,58 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
b874692452d63c61b25ccad591662a7e1e269e56.json
Simplify ReactorNettyTcpClient input Create a ReactorNettyCodec to hold the decoding and encoding function and consumer along with a package-private sub-class that delegates to StompDecoder and StompEncoder. Issue: SPR-14531
spring-messaging/src/main/java/org/springframework/messaging/tcp/reactor/ReactorNettyTcpClient.java
@@ -17,12 +17,10 @@ package org.springframework.messaging.tcp.reactor; import java.util.Collection; -import java.util.function.BiConsumer; import java.util.function.BiFunction; import java.util.function.Consumer; import java.util.function.Function; -import io.netty.buffer.ByteBuf; import io.netty.channel.grou...
true
Other
spring-projects
spring-framework
870f61fd8ea75ff46f0892c9ccff347fa6d8b6f3.json
update STOMP support to reactor-netty
build.gradle
@@ -78,7 +78,6 @@ configure(allprojects) { project -> ext.protobufVersion = "3.1.0" ext.quartzVersion = "2.2.3" ext.reactivestreamsVersion = "1.0.0" - ext.reactorVersion = "2.0.8.RELEASE" ext.reactorCoreVersion = '3.0.3.RELEASE' ext.reactorNettyVersion = '0.6.0.BUILD-SNAPSHOT' ...
true
Other
spring-projects
spring-framework
870f61fd8ea75ff46f0892c9ccff347fa6d8b6f3.json
update STOMP support to reactor-netty
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/Reactor2StompCodec.java
@@ -1,107 +0,0 @@ -/* - * Copyright 2002-2016 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 -...
true
Other
spring-projects
spring-framework
870f61fd8ea75ff46f0892c9ccff347fa6d8b6f3.json
update STOMP support to reactor-netty
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/ReactorNettyTcpStompClient.java
@@ -16,63 +16,54 @@ package org.springframework.messaging.simp.stomp; -import java.util.Collections; import java.util.List; -import java.util.Properties; +import java.util.function.BiConsumer; +import java.util.function.Function; -import reactor.Environment; -import reactor.core.config.ConfigurationReader; -imp...
true
Other
spring-projects
spring-framework
870f61fd8ea75ff46f0892c9ccff347fa6d8b6f3.json
update STOMP support to reactor-netty
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompBrokerRelayMessageHandler.java
@@ -40,7 +40,7 @@ import org.springframework.messaging.tcp.TcpConnection; import org.springframework.messaging.tcp.TcpConnectionHandler; import org.springframework.messaging.tcp.TcpOperations; -import org.springframework.messaging.tcp.reactor.Reactor2TcpClient; +import org.springframework.messaging.tcp.reactor.React...
true
Other
spring-projects
spring-framework
870f61fd8ea75ff46f0892c9ccff347fa6d8b6f3.json
update STOMP support to reactor-netty
spring-messaging/src/main/java/org/springframework/messaging/tcp/reactor/AbstractMonoToListenableFutureAdapter.java
@@ -16,12 +16,14 @@ package org.springframework.messaging.tcp.reactor; +import java.time.Duration; +import java.util.Objects; import java.util.concurrent.ExecutionException; import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeoutException; -import reactor.fn.Consumer; -import reactor.rx.Prom...
true
Other
spring-projects
spring-framework
870f61fd8ea75ff46f0892c9ccff347fa6d8b6f3.json
update STOMP support to reactor-netty
spring-messaging/src/main/java/org/springframework/messaging/tcp/reactor/MonoToListenableFutureAdapter.java
@@ -16,20 +16,22 @@ package org.springframework.messaging.tcp.reactor; -import reactor.rx.Promise; +import reactor.core.publisher.Mono; /** - * A Promise-to-ListenableFutureAdapter where the source and the target from + * A Mono-to-ListenableFutureAdapter where the source and the target from * the Promise and...
true
Other
spring-projects
spring-framework
870f61fd8ea75ff46f0892c9ccff347fa6d8b6f3.json
update STOMP support to reactor-netty
spring-messaging/src/main/java/org/springframework/messaging/tcp/reactor/Reactor2TcpClient.java
@@ -1,362 +0,0 @@ -/* - * Copyright 2002-2016 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 -...
true
Other
spring-projects
spring-framework
870f61fd8ea75ff46f0892c9ccff347fa6d8b6f3.json
update STOMP support to reactor-netty
spring-messaging/src/main/java/org/springframework/messaging/tcp/reactor/ReactorNettyTcpClient.java
@@ -0,0 +1,264 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
870f61fd8ea75ff46f0892c9ccff347fa6d8b6f3.json
update STOMP support to reactor-netty
spring-messaging/src/main/java/org/springframework/messaging/tcp/reactor/ReactorNettyTcpConnection.java
@@ -16,10 +16,13 @@ package org.springframework.messaging.tcp.reactor; -import reactor.io.net.ChannelStream; -import reactor.rx.Promise; -import reactor.rx.Promises; -import reactor.rx.Streams; +import java.util.function.BiConsumer; + +import io.netty.buffer.ByteBuf; +import reactor.core.publisher.DirectProcessor;...
true
Other
spring-projects
spring-framework
870f61fd8ea75ff46f0892c9ccff347fa6d8b6f3.json
update STOMP support to reactor-netty
spring-messaging/src/test/java/org/springframework/messaging/simp/stomp/ReactorNettyTcpStompClientTests.java
@@ -43,20 +43,20 @@ import static org.junit.Assert.*; /** - * Integration tests for {@link Reactor2TcpStompClient}. + * Integration tests for {@link ReactorNettyTcpStompClient}. * * @author Rossen Stoyanchev */ -public class Reactor2TcpStompClientTests { +public class ReactorNettyTcpStompClientTests { - pri...
true
Other
spring-projects
spring-framework
870f61fd8ea75ff46f0892c9ccff347fa6d8b6f3.json
update STOMP support to reactor-netty
spring-messaging/src/test/java/org/springframework/messaging/simp/stomp/StompDecoderTests.java
@@ -17,7 +17,7 @@ package org.springframework.messaging.simp.stomp; import java.io.UnsupportedEncodingException; -import java.util.ArrayList; +import java.nio.ByteBuffer; import java.util.List; import org.junit.Test; @@ -26,22 +26,18 @@ import org.springframework.messaging.simp.SimpMessageType; import org.spr...
true
Other
spring-projects
spring-framework
870f61fd8ea75ff46f0892c9ccff347fa6d8b6f3.json
update STOMP support to reactor-netty
spring-messaging/src/test/java/org/springframework/messaging/simp/stomp/StompEncoderTests.java
@@ -0,0 +1,93 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
729551f375a2fb9675c337873ae6cf4341735139.json
Use full package names in ReactiveAdapterRegistry The recent refactoring lead to java.lang.NoClassDefFoundError: io/reactivex/Completable where only RxJava 1 is in the classpath. Most likely due to the lack of prefix in Completable::complete with rx package to avoid the RxJava 2 reference.
spring-core/src/main/java/org/springframework/core/ReactiveAdapterRegistry.java
@@ -23,17 +23,18 @@ import java.util.function.Function; import io.reactivex.BackpressureStrategy; -import io.reactivex.Completable; -import io.reactivex.Flowable; -import io.reactivex.Maybe; -import io.reactivex.Observable; import org.reactivestreams.Publisher; import reactor.core.publisher.Flux; import reactor....
false
Other
spring-projects
spring-framework
2e994f7dc38b5520555720dac215064949ccfabf.json
Add RedirectView to Spring Web Reactive Main differences with the Spring MVC original implementation: - Default redirect HTTP code is 303 See Other since we can assume all HTTP clients support HTTP 1.1 in 2016 - No more http10Compatible property, use statusCode instead - By default the redirect is relative to th...
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/view/RedirectView.java
@@ -0,0 +1,365 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
2e994f7dc38b5520555720dac215064949ccfabf.json
Add RedirectView to Spring Web Reactive Main differences with the Spring MVC original implementation: - Default redirect HTTP code is 303 See Other since we can assume all HTTP clients support HTTP 1.1 in 2016 - No more http10Compatible property, use statusCode instead - By default the redirect is relative to th...
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/view/UrlBasedViewResolver.java
@@ -17,6 +17,7 @@ package org.springframework.web.reactive.result.view; import java.util.Locale; +import java.util.function.Function; import reactor.core.publisher.Mono; @@ -56,6 +57,15 @@ */ public class UrlBasedViewResolver extends ViewResolverSupport implements ViewResolver, InitializingBean { + /** + ...
true
Other
spring-projects
spring-framework
2e994f7dc38b5520555720dac215064949ccfabf.json
Add RedirectView to Spring Web Reactive Main differences with the Spring MVC original implementation: - Default redirect HTTP code is 303 See Other since we can assume all HTTP clients support HTTP 1.1 in 2016 - No more http10Compatible property, use statusCode instead - By default the redirect is relative to th...
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/view/RedirectViewTests.java
@@ -0,0 +1,150 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
2e994f7dc38b5520555720dac215064949ccfabf.json
Add RedirectView to Spring Web Reactive Main differences with the Spring MVC original implementation: - Default redirect HTTP code is 303 See Other since we can assume all HTTP clients support HTTP 1.1 in 2016 - No more http10Compatible property, use statusCode instead - By default the redirect is relative to th...
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/view/UrlBasedViewResolverTests.java
@@ -19,33 +19,40 @@ import java.util.Locale; import java.util.Map; +import static org.junit.Assert.*; +import org.junit.Before; import org.junit.Test; import reactor.core.publisher.Mono; import org.springframework.context.support.StaticApplicationContext; +import org.springframework.http.HttpStatus; import or...
true
Other
spring-projects
spring-framework
fada91e538590e2eab0b05230a8a449ca41af695.json
Treat Kotlin nullable as non-required Where `isOptional` is used, also check for `isNullable` i.e. values are not considered required if they are Kotlin nullables: - spring-messaging: named value method arguments - spring-web: named value method arguments - spring-webmvc: request parts This means that Kotlin client c...
build.gradle
@@ -5,6 +5,7 @@ buildscript { dependencies { classpath("org.springframework.build.gradle:propdeps-plugin:0.0.7") classpath("org.asciidoctor:asciidoctor-gradle-plugin:1.5.3") + classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:1.0.4" classpath("io.spring.gradle:docbook-reference-plugin:0.3.1") } } @@ -...
true
Other
spring-projects
spring-framework
fada91e538590e2eab0b05230a8a449ca41af695.json
Treat Kotlin nullable as non-required Where `isOptional` is used, also check for `isNullable` i.e. values are not considered required if they are Kotlin nullables: - spring-messaging: named value method arguments - spring-web: named value method arguments - spring-webmvc: request parts This means that Kotlin client c...
spring-core/src/main/java/org/springframework/core/MethodParameter.java
@@ -30,6 +30,7 @@ import java.util.Optional; import org.springframework.util.Assert; +import org.springframework.util.KotlinUtils; /** * Helper class that encapsulates the specification of a method parameter, i.e. a {@link Method} @@ -329,6 +330,16 @@ public MethodParameter nestedIfOptional() { return (isOp...
true
Other
spring-projects
spring-framework
fada91e538590e2eab0b05230a8a449ca41af695.json
Treat Kotlin nullable as non-required Where `isOptional` is used, also check for `isNullable` i.e. values are not considered required if they are Kotlin nullables: - spring-messaging: named value method arguments - spring-web: named value method arguments - spring-webmvc: request parts This means that Kotlin client c...
spring-core/src/main/java/org/springframework/util/KotlinUtils.java
@@ -0,0 +1,74 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
fada91e538590e2eab0b05230a8a449ca41af695.json
Treat Kotlin nullable as non-required Where `isOptional` is used, also check for `isNullable` i.e. values are not considered required if they are Kotlin nullables: - spring-messaging: named value method arguments - spring-web: named value method arguments - spring-webmvc: request parts This means that Kotlin client c...
spring-core/src/test/kotlin/org/springframework/util/KotlinUtilsTests.kt
@@ -0,0 +1,60 @@ +package org.springframework.util + +import org.junit.Before +import org.junit.Test + +import java.lang.reflect.Method + +import org.junit.Assert.assertFalse +import org.junit.Assert.assertTrue +import org.springframework.core.MethodParameter +import org.springframework.util.KotlinUtils.* + +/** + * Un...
true
Other
spring-projects
spring-framework
fada91e538590e2eab0b05230a8a449ca41af695.json
Treat Kotlin nullable as non-required Where `isOptional` is used, also check for `isNullable` i.e. values are not considered required if they are Kotlin nullables: - spring-messaging: named value method arguments - spring-web: named value method arguments - spring-webmvc: request parts This means that Kotlin client c...
spring-messaging/src/main/java/org/springframework/messaging/handler/annotation/support/AbstractNamedValueMethodArgumentResolver.java
@@ -98,7 +98,7 @@ public Object resolveArgument(MethodParameter parameter, Message<?> message) thr if (namedValueInfo.defaultValue != null) { arg = resolveStringValue(namedValueInfo.defaultValue); } - else if (namedValueInfo.required && !nestedParameter.isOptional()) { + else if (namedValueInfo.require...
true
Other
spring-projects
spring-framework
fada91e538590e2eab0b05230a8a449ca41af695.json
Treat Kotlin nullable as non-required Where `isOptional` is used, also check for `isNullable` i.e. values are not considered required if they are Kotlin nullables: - spring-messaging: named value method arguments - spring-web: named value method arguments - spring-webmvc: request parts This means that Kotlin client c...
spring-web/src/main/java/org/springframework/web/method/annotation/AbstractNamedValueMethodArgumentResolver.java
@@ -100,7 +100,7 @@ public final Object resolveArgument(MethodParameter parameter, ModelAndViewConta if (namedValueInfo.defaultValue != null) { arg = resolveStringValue(namedValueInfo.defaultValue); } - else if (namedValueInfo.required && !nestedParameter.isOptional()) { + else if (namedValueInfo.requi...
true
Other
spring-projects
spring-framework
fada91e538590e2eab0b05230a8a449ca41af695.json
Treat Kotlin nullable as non-required Where `isOptional` is used, also check for `isNullable` i.e. values are not considered required if they are Kotlin nullables: - spring-messaging: named value method arguments - spring-web: named value method arguments - spring-webmvc: request parts This means that Kotlin client c...
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/RequestPartMethodArgumentResolver.java
@@ -113,7 +113,8 @@ public Object resolveArgument(MethodParameter parameter, ModelAndViewContainer m HttpServletRequest servletRequest = request.getNativeRequest(HttpServletRequest.class); RequestPart requestPart = parameter.getParameterAnnotation(RequestPart.class); - boolean isRequired = ((requestPart == nul...
true
Other
spring-projects
spring-framework
735e288d465ca36ae1eeccbd8a4d044d7bd3ad50.json
Add DataBuffer BodyInserter/BodyExtractor Added a BodyExtractor for Flux<DataBuffer>, and a BodyInserter for Publisher<DataBuffer> Issue: SPR-14918
spring-web/src/main/java/org/springframework/http/codec/BodyExtractors.java
@@ -28,6 +28,7 @@ import reactor.core.publisher.Mono; import org.springframework.core.ResolvableType; +import org.springframework.core.io.buffer.DataBuffer; import org.springframework.http.HttpMessage; import org.springframework.http.MediaType; import org.springframework.http.ReactiveHttpInputMessage; @@ -85,12 ...
true
Other
spring-projects
spring-framework
735e288d465ca36ae1eeccbd8a4d044d7bd3ad50.json
Add DataBuffer BodyInserter/BodyExtractor Added a BodyExtractor for Flux<DataBuffer>, and a BodyInserter for Publisher<DataBuffer> Issue: SPR-14918
spring-web/src/main/java/org/springframework/http/codec/BodyInserters.java
@@ -28,6 +28,7 @@ import org.springframework.core.ResolvableType; import org.springframework.core.io.Resource; +import org.springframework.core.io.buffer.DataBuffer; import org.springframework.http.MediaType; import org.springframework.http.ReactiveHttpOutputMessage; import org.springframework.http.server.reacti...
true
Other
spring-projects
spring-framework
735e288d465ca36ae1eeccbd8a4d044d7bd3ad50.json
Add DataBuffer BodyInserter/BodyExtractor Added a BodyExtractor for Flux<DataBuffer>, and a BodyInserter for Publisher<DataBuffer> Issue: SPR-14918
spring-web/src/test/java/org/springframework/http/codec/BodyExtractorsTests.java
@@ -19,7 +19,6 @@ import java.nio.ByteBuffer; import java.nio.charset.StandardCharsets; import java.util.ArrayList; -import java.util.Collections; import java.util.List; import java.util.function.Supplier; import java.util.stream.Stream; @@ -40,7 +39,6 @@ import org.springframework.http.codec.json.Jackson2JsonDe...
true
Other
spring-projects
spring-framework
735e288d465ca36ae1eeccbd8a4d044d7bd3ad50.json
Add DataBuffer BodyInserter/BodyExtractor Added a BodyExtractor for Flux<DataBuffer>, and a BodyInserter for Publisher<DataBuffer> Issue: SPR-14918
spring-web/src/test/java/org/springframework/http/codec/BodyInsertersTests.java
@@ -17,6 +17,7 @@ package org.springframework.http.codec; import java.nio.ByteBuffer; +import java.nio.charset.StandardCharsets; import java.nio.file.Files; import java.util.ArrayList; import java.util.Collections; @@ -35,6 +36,7 @@ import org.springframework.core.io.ClassPathResource; import org.springframewo...
true
Other
spring-projects
spring-framework
9bcc7c3b06f0e693269cbd37726ea6b27af952ec.json
Remove ResourceServlet (deprecated in 4.3)
spring-webmvc/src/main/java/org/springframework/web/servlet/ResourceServlet.java
@@ -1,347 +0,0 @@ -/* - * Copyright 2002-2016 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 -...
false
Other
spring-projects
spring-framework
3eb2432ced0cba56ddb8fefac6da88f173a98703.json
Fix TODO in ReactorHttpServer
spring-web/src/test/java/org/springframework/http/server/reactive/bootstrap/ReactorHttpServer.java
@@ -16,6 +16,8 @@ package org.springframework.http.server.reactive.bootstrap; +import java.util.concurrent.atomic.AtomicReference; + import reactor.core.Loopback; import reactor.ipc.netty.NettyContext; @@ -31,7 +33,7 @@ public class ReactorHttpServer extends HttpServerSupport implements HttpServer, private...
false
Other
spring-projects
spring-framework
478b4149f78a47b00fed64b70e14a834f5f7a009.json
Add netty-buffer as a compile dependency This is a temporary measure for M1 as the dependency will go away once issue #116 is addressed.
spring-web-reactive/build.gradle
@@ -95,6 +95,7 @@ dependencies { compile "org.reactivestreams:reactive-streams:1.0.0" compile "io.projectreactor:reactor-core:${reactorVersion}" compile "commons-logging:commons-logging:1.2" + compile "io.netty:netty-buffer:${nettyVersion}" // Temporarily for JsonObjectDecoder (GH #116) optional "org.springfr...
false
Other
spring-projects
spring-framework
64628dc8cb78f9a23137a308b8cd2f973d326569.json
Add CorsFilter documentation
src/asciidoc/web-cors.adoc
@@ -203,4 +203,42 @@ It can be provided in various ways: * Handlers can implement the {api-spring-framework}/web/cors/CorsConfigurationSource.html[`CorsConfigurationSource`] interface (like https://github.com/spring-projects/spring-framework/blob/master/spring-webmvc/src/main/java/org/springframework/web/servlet/...
false
Other
spring-projects
spring-framework
565728307126936bd93aaf90bdae9001ea95a744.json
Fix typo in asciidoc Closes gh-1092
src/asciidoc/core-beans.adoc
@@ -3169,7 +3169,7 @@ You configure destroy method callbacks similarly (in XML, that is) by using the Where existing bean classes already have callback methods that are named at variance with the convention, you can override the default by specifying (in XML, that is) the -method name using the `init-method` and `d...
false
Other
spring-projects
spring-framework
13b6f4fee47c89f9602710ab1298722fe87504b3.json
Add SseEventEncoder to WebReactiveConfiguration
spring-web-reactive/src/main/java/org/springframework/web/reactive/config/WebReactiveConfiguration.java
@@ -46,6 +46,7 @@ import org.springframework.core.convert.support.ReactiveStreamsToRxJava1Converter; import org.springframework.format.Formatter; import org.springframework.http.MediaType; +import org.springframework.http.codec.SseEventEncoder; import org.springframework.http.converter.reactive.CodecHttpMessageConv...
true