language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
e31a2f778bf401f59cb6ae5124bf2d8b70e8606f.json
Add Reactive CORS support This is a port of Spring MVC CORS support for Spring Web Reactive: - CORS classes keep the same name but are in the web.cors.reactive package - CorsConfiguration is reused because not tied to Servlet API - CORS HandlerMapping integration is done at AbstractHandlerMapping level - Abs...
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/AbstractRequestMappingIntegrationTests.java
@@ -27,6 +27,7 @@ import org.springframework.web.client.RestTemplate; import org.springframework.web.reactive.DispatcherHandler; import org.springframework.web.server.adapter.WebHttpHandlerBuilder; +import org.springframework.web.server.handler.ResponseStatusExceptionHandler; import static org.springframework.htt...
true
Other
spring-projects
spring-framework
e31a2f778bf401f59cb6ae5124bf2d8b70e8606f.json
Add Reactive CORS support This is a port of Spring MVC CORS support for Spring Web Reactive: - CORS classes keep the same name but are in the web.cors.reactive package - CorsConfiguration is reused because not tied to Servlet API - CORS HandlerMapping integration is done at AbstractHandlerMapping level - Abs...
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/CorsConfigurationIntegrationTests.java
@@ -0,0 +1,183 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
e31a2f778bf401f59cb6ae5124bf2d8b70e8606f.json
Add Reactive CORS support This is a port of Spring MVC CORS support for Spring Web Reactive: - CORS classes keep the same name but are in the web.cors.reactive package - CorsConfiguration is reused because not tied to Servlet API - CORS HandlerMapping integration is done at AbstractHandlerMapping level - Abs...
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/CrossOriginAnnotationIntegrationTests.java
@@ -0,0 +1,345 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
e31a2f778bf401f59cb6ae5124bf2d8b70e8606f.json
Add Reactive CORS support This is a port of Spring MVC CORS support for Spring Web Reactive: - CORS classes keep the same name but are in the web.cors.reactive package - CorsConfiguration is reused because not tied to Servlet API - CORS HandlerMapping integration is done at AbstractHandlerMapping level - Abs...
spring-web/src/main/java/org/springframework/web/cors/reactive/CorsConfigurationSource.java
@@ -0,0 +1,37 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
e31a2f778bf401f59cb6ae5124bf2d8b70e8606f.json
Add Reactive CORS support This is a port of Spring MVC CORS support for Spring Web Reactive: - CORS classes keep the same name but are in the web.cors.reactive package - CorsConfiguration is reused because not tied to Servlet API - CORS HandlerMapping integration is done at AbstractHandlerMapping level - Abs...
spring-web/src/main/java/org/springframework/web/cors/reactive/CorsProcessor.java
@@ -0,0 +1,48 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
e31a2f778bf401f59cb6ae5124bf2d8b70e8606f.json
Add Reactive CORS support This is a port of Spring MVC CORS support for Spring Web Reactive: - CORS classes keep the same name but are in the web.cors.reactive package - CorsConfiguration is reused because not tied to Servlet API - CORS HandlerMapping integration is done at AbstractHandlerMapping level - Abs...
spring-web/src/main/java/org/springframework/web/cors/reactive/CorsUtils.java
@@ -0,0 +1,86 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
e31a2f778bf401f59cb6ae5124bf2d8b70e8606f.json
Add Reactive CORS support This is a port of Spring MVC CORS support for Spring Web Reactive: - CORS classes keep the same name but are in the web.cors.reactive package - CorsConfiguration is reused because not tied to Servlet API - CORS HandlerMapping integration is done at AbstractHandlerMapping level - Abs...
spring-web/src/main/java/org/springframework/web/cors/reactive/DefaultCorsProcessor.java
@@ -0,0 +1,187 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
e31a2f778bf401f59cb6ae5124bf2d8b70e8606f.json
Add Reactive CORS support This is a port of Spring MVC CORS support for Spring Web Reactive: - CORS classes keep the same name but are in the web.cors.reactive package - CorsConfiguration is reused because not tied to Servlet API - CORS HandlerMapping integration is done at AbstractHandlerMapping level - Abs...
spring-web/src/main/java/org/springframework/web/cors/reactive/UrlBasedCorsConfigurationSource.java
@@ -0,0 +1,115 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
e31a2f778bf401f59cb6ae5124bf2d8b70e8606f.json
Add Reactive CORS support This is a port of Spring MVC CORS support for Spring Web Reactive: - CORS classes keep the same name but are in the web.cors.reactive package - CorsConfiguration is reused because not tied to Servlet API - CORS HandlerMapping integration is done at AbstractHandlerMapping level - Abs...
spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java
@@ -710,8 +710,8 @@ UriComponentsBuilder adaptFromForwardedHeaders(HttpHeaders headers) { } } - if ((this.scheme.equals("http") && "80".equals(this.port)) || - (this.scheme.equals("https") && "443".equals(this.port))) { + if ((this.scheme != null) && ((this.scheme.equals("http") && "80".equals(this.port))...
true
Other
spring-projects
spring-framework
e31a2f778bf401f59cb6ae5124bf2d8b70e8606f.json
Add Reactive CORS support This is a port of Spring MVC CORS support for Spring Web Reactive: - CORS classes keep the same name but are in the web.cors.reactive package - CorsConfiguration is reused because not tied to Servlet API - CORS HandlerMapping integration is done at AbstractHandlerMapping level - Abs...
spring-web/src/test/java/org/springframework/web/cors/reactive/CorsUtilsTests.java
@@ -0,0 +1,73 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
e31a2f778bf401f59cb6ae5124bf2d8b70e8606f.json
Add Reactive CORS support This is a port of Spring MVC CORS support for Spring Web Reactive: - CORS classes keep the same name but are in the web.cors.reactive package - CorsConfiguration is reused because not tied to Servlet API - CORS HandlerMapping integration is done at AbstractHandlerMapping level - Abs...
spring-web/src/test/java/org/springframework/web/cors/reactive/DefaultCorsProcessorTests.java
@@ -0,0 +1,351 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
e31a2f778bf401f59cb6ae5124bf2d8b70e8606f.json
Add Reactive CORS support This is a port of Spring MVC CORS support for Spring Web Reactive: - CORS classes keep the same name but are in the web.cors.reactive package - CorsConfiguration is reused because not tied to Servlet API - CORS HandlerMapping integration is done at AbstractHandlerMapping level - Abs...
spring-web/src/test/java/org/springframework/web/cors/reactive/UrlBasedCorsConfigurationSourceTests.java
@@ -0,0 +1,68 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
0cc330e8fc8b29790af7c220e828cfe393094e6b.json
Fix HttpRequest#getURI() with Netty based engines Host and port are now properly retrieved from Reactor Netty and RxNetty (the scheme is not available). Issue: SPR-14794
spring-web/src/main/java/org/springframework/http/server/reactive/ReactorServerHttpRequest.java
@@ -16,6 +16,7 @@ package org.springframework.http.server.reactive; +import java.net.InetSocketAddress; import java.net.URI; import java.net.URISyntaxException; @@ -64,7 +65,16 @@ public HttpMethod getMethod() { @Override protected URI initUri() throws URISyntaxException { - return new URI(this.channel....
true
Other
spring-projects
spring-framework
0cc330e8fc8b29790af7c220e828cfe393094e6b.json
Fix HttpRequest#getURI() with Netty based engines Host and port are now properly retrieved from Reactor Netty and RxNetty (the scheme is not available). Issue: SPR-14794
spring-web/src/main/java/org/springframework/http/server/reactive/RxNettyServerHttpRequest.java
@@ -16,6 +16,7 @@ package org.springframework.http.server.reactive; +import java.net.InetSocketAddress; import java.net.URI; import java.net.URISyntaxException; @@ -68,7 +69,17 @@ public HttpMethod getMethod() { @Override protected URI initUri() throws URISyntaxException { - return new URI(this.request....
true
Other
spring-projects
spring-framework
0cc330e8fc8b29790af7c220e828cfe393094e6b.json
Fix HttpRequest#getURI() with Netty based engines Host and port are now properly retrieved from Reactor Netty and RxNetty (the scheme is not available). Issue: SPR-14794
spring-web/src/test/java/org/springframework/http/server/reactive/ServerHttpRequestIntegrationTests.java
@@ -0,0 +1,58 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
ea5ff87f8ec8d34871aaf3bcc49a165e2db076e5.json
Fix NumberFormatException with X-Forwarded-Host This commit fixes `NumberFormatException`s that were thrown when parsing IPv6 host values in `X-Forwarded-Host` request headers. Issue: SPR-14761
spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java
@@ -51,6 +51,7 @@ * @author Rossen Stoyanchev * @author Phillip Webb * @author Oliver Gierke + * @author Brian Clozel * @since 3.1 * @see #newInstance() * @see #fromPath(String) @@ -687,10 +688,10 @@ UriComponentsBuilder adaptFromForwardedHeaders(HttpHeaders headers) { String hostHeader = headers.getFir...
true
Other
spring-projects
spring-framework
ea5ff87f8ec8d34871aaf3bcc49a165e2db076e5.json
Fix NumberFormatException with X-Forwarded-Host This commit fixes `NumberFormatException`s that were thrown when parsing IPv6 host values in `X-Forwarded-Host` request headers. Issue: SPR-14761
spring-web/src/test/java/org/springframework/web/util/UriComponentsBuilderTests.java
@@ -125,9 +125,7 @@ public void fromOpaqueUri() throws URISyntaxException { assertEquals("Invalid result URI", uri, result.toUri()); } - // SPR-9317 - - @Test + @Test // SPR-9317 public void fromUriEncodedQuery() throws URISyntaxException { URI uri = new URI("http://www.example.org/?param=aGVsbG9Xb3JsZA%3D%...
true
Other
spring-projects
spring-framework
715006d5df415b799ca3b22b7db7efc93c6a90f1.json
Fix table layout
src/asciidoc/web-mvc.adoc
@@ -3991,8 +3991,7 @@ config). Listed below are some of the exceptions handled by this resolver and th corresponding status codes: |=== -| Exception -| HTTP Status Code +| Exception| HTTP Status Code | `BindException` | 400 (Bad Request)
false
Other
spring-projects
spring-framework
324c310cbd3a95da73d36a6f868a538742a10c4f.json
Log unresolved exceptions at error level
spring-web/src/main/java/org/springframework/http/server/reactive/ReactorHttpHandlerAdapter.java
@@ -54,7 +54,7 @@ public Mono<Void> apply(HttpChannel channel) { return this.delegate.handle(adaptedRequest, adaptedResponse) .otherwise(ex -> { - logger.debug("Could not complete request", ex); + logger.error("Could not complete request", ex); channel.status(HttpResponseStatus.INTERNAL_SERVER_E...
true
Other
spring-projects
spring-framework
324c310cbd3a95da73d36a6f868a538742a10c4f.json
Log unresolved exceptions at error level
spring-web/src/main/java/org/springframework/http/server/reactive/RxNettyHttpHandlerAdapter.java
@@ -58,7 +58,7 @@ public Observable<Void> handle(HttpServerRequest<ByteBuf> request, HttpServerRes Publisher<Void> result = this.delegate.handle(adaptedRequest, adaptedResponse) .otherwise(ex -> { - logger.debug("Could not complete request", ex); + logger.error("Could not complete request", ex); ...
true
Other
spring-projects
spring-framework
324c310cbd3a95da73d36a6f868a538742a10c4f.json
Log unresolved exceptions at error level
spring-web/src/main/java/org/springframework/http/server/reactive/ServletHttpHandlerAdapter.java
@@ -114,7 +114,7 @@ public void onNext(Void aVoid) { @Override public void onError(Throwable ex) { - logger.debug("Could not complete request", ex); + logger.error("Could not complete request", ex); HttpServletResponse response = (HttpServletResponse) this.asyncContext.getResponse(); response.setSta...
true
Other
spring-projects
spring-framework
324c310cbd3a95da73d36a6f868a538742a10c4f.json
Log unresolved exceptions at error level
spring-web/src/main/java/org/springframework/http/server/reactive/UndertowHttpHandlerAdapter.java
@@ -72,7 +72,7 @@ public void onNext(Void aVoid) { } @Override public void onError(Throwable ex) { - logger.debug("Could not complete request", ex); + logger.error("Could not complete request", ex); if (!exchange.isResponseStarted() && exchange.getStatusCode() <= 500) { exchange.setStatusCo...
true
Other
spring-projects
spring-framework
324c310cbd3a95da73d36a6f868a538742a10c4f.json
Log unresolved exceptions at error level
spring-web/src/main/java/org/springframework/web/server/adapter/WebHttpHandlerBuilder.java
@@ -123,10 +123,8 @@ public HttpHandler build() { WebFilter[] array = new WebFilter[this.filters.size()]; webHandler = new FilteringWebHandler(webHandler, this.filters.toArray(array)); } - if (!this.exceptionHandlers.isEmpty()) { - WebExceptionHandler[] array = new WebExceptionHandler[this.exceptionHandle...
true
Other
spring-projects
spring-framework
324c310cbd3a95da73d36a6f868a538742a10c4f.json
Log unresolved exceptions at error level
spring-web/src/main/java/org/springframework/web/server/handler/ExceptionHandlingWebHandler.java
@@ -128,7 +128,7 @@ else if (disconnectedClientLogger.isDebugEnabled()) { } } else { - logger.debug("Could not complete request", ex); + logger.error("Could not complete request", ex); } }
true
Other
spring-projects
spring-framework
11aa920785151c76c381f482e8b3810ccf59929f.json
Remove RxJava 1.x variants of WebClient adapters Issue: SPR-14743
spring-web/src/main/java/org/springframework/web/client/reactive/support/RxJava1ClientWebRequestBuilder.java
@@ -1,169 +0,0 @@ -/* - * Copyright 2002-2016 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 -...
true
Other
spring-projects
spring-framework
11aa920785151c76c381f482e8b3810ccf59929f.json
Remove RxJava 1.x variants of WebClient adapters Issue: SPR-14743
spring-web/src/main/java/org/springframework/web/client/reactive/support/RxJava1ClientWebRequestBuilders.java
@@ -1,110 +0,0 @@ -/* - * Copyright 2002-2016 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 -...
true
Other
spring-projects
spring-framework
11aa920785151c76c381f482e8b3810ccf59929f.json
Remove RxJava 1.x variants of WebClient adapters Issue: SPR-14743
spring-web/src/main/java/org/springframework/web/client/reactive/support/RxJava1ResponseExtractors.java
@@ -1,221 +0,0 @@ -/* - * Copyright 2002-2016 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 -...
true
Other
spring-projects
spring-framework
11aa920785151c76c381f482e8b3810ccf59929f.json
Remove RxJava 1.x variants of WebClient adapters Issue: SPR-14743
spring-web/src/main/java/org/springframework/web/client/reactive/support/package-info.java
@@ -1,4 +0,0 @@ -/** - * Support classes for the reactive WebClient. - */ -package org.springframework.web.client.reactive.support;
true
Other
spring-projects
spring-framework
11aa920785151c76c381f482e8b3810ccf59929f.json
Remove RxJava 1.x variants of WebClient adapters Issue: SPR-14743
spring-web/src/test/java/org/springframework/web/client/reactive/RxJava1WebClientIntegrationTests.java
@@ -1,341 +0,0 @@ -/* - * Copyright 2002-2016 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 -...
true
Other
spring-projects
spring-framework
b91c0b3a1a0e21d37e3296d6e5a96bb50141a922.json
Fix JSON and SSE writer registration Issue: SPR-14748
spring-web-reactive/src/main/java/org/springframework/web/reactive/config/WebReactiveConfiguration.java
@@ -405,11 +405,14 @@ protected final void addDefaultHttpMessageWriters(List<HttpMessageWriter<?>> wri if (jaxb2Present) { writers.add(new EncoderHttpMessageWriter<>(new Jaxb2XmlEncoder())); } - writers.add(new Jackson2ServerHttpMessageWriter(new ServerSentEventHttpMessageWriter(sseDataEncoders))); if (ja...
true
Other
spring-projects
spring-framework
b91c0b3a1a0e21d37e3296d6e5a96bb50141a922.json
Fix JSON and SSE writer registration Issue: SPR-14748
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestMappingIntegrationTests.java
@@ -24,6 +24,7 @@ import org.springframework.context.annotation.AnnotationConfigApplicationContext; import org.springframework.context.annotation.ComponentScan; import org.springframework.context.annotation.Configuration; +import org.springframework.http.MediaType; import org.springframework.web.bind.annotation.Get...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-context/src/main/java/org/springframework/cache/interceptor/CacheAspectSupport.java
@@ -555,7 +555,7 @@ public CacheOperationContexts(Collection<? extends CacheOperation> operations, M public Collection<CacheOperationContext> get(Class<? extends CacheOperation> operationClass) { Collection<CacheOperationContext> result = this.contexts.get(operationClass); - return (result != null ? result :...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-context/src/main/java/org/springframework/scheduling/config/ScheduledTaskRegistrar.java
@@ -134,7 +134,7 @@ public void setTriggerTasksList(List<TriggerTask> triggerTasks) { */ public List<TriggerTask> getTriggerTaskList() { return (this.triggerTasks != null? Collections.unmodifiableList(this.triggerTasks) : - Collections.<TriggerTask>emptyList()); + Collections.emptyList()); } /** @@ ...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-core/src/main/java/org/springframework/core/Conventions.java
@@ -50,13 +50,10 @@ public abstract class Conventions { * when searching for the 'primary' interface of a proxy. */ private static final Set<Class<?>> IGNORED_INTERFACES; + static { - IGNORED_INTERFACES = Collections.unmodifiableSet( - new HashSet<>(Arrays.<Class<?>>asList( - Serializable.class, - ...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-core/src/main/java/org/springframework/core/env/JOptCommandLinePropertySource.java
@@ -101,7 +101,7 @@ public List<String> getOptionValues(String name) { stringArgValues.add(argValue instanceof String ? (String) argValue : argValue.toString()); } if (stringArgValues.isEmpty()) { - return (this.source.has(name) ? Collections.<String>emptyList() : null); + return (this.source.has(name) ? ...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-core/src/main/java/org/springframework/util/InstanceFilter.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -54,8 +54,8 @@ public InstanceFilter(Colle...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-core/src/main/java/org/springframework/util/MimeType.java
@@ -120,7 +120,7 @@ public MimeType(String type) { * @throws IllegalArgumentException if any of the parameters contains illegal characters */ public MimeType(String type, String subtype) { - this(type, subtype, Collections.<String, String>emptyMap()); + this(type, subtype, Collections.emptyMap()); } /**
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-core/src/main/java/org/springframework/util/xml/SimpleNamespaceContext.java
@@ -87,7 +87,7 @@ else if (XMLConstants.XMLNS_ATTRIBUTE_NS_URI.equals(namespaceUri)) { } else { Set<String> prefixes = this.namespaceUriToPrefixes.get(namespaceUri); - return (prefixes != null ? Collections.unmodifiableSet(prefixes) : Collections.<String>emptySet()); + return (prefixes != null ? Collect...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-expression/src/main/java/org/springframework/expression/spel/ExpressionState.java
@@ -183,7 +183,7 @@ public void enterScope(Map<String, Object> argMap) { public void enterScope() { ensureVariableScopesInitialized(); - this.variableScopes.push(new VariableScope(Collections.<String,Object>emptyMap())); + this.variableScopes.push(new VariableScope(Collections.emptyMap())); this.scopeRootOb...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-messaging/src/main/java/org/springframework/messaging/handler/DestinationPatternsMessageCondition.java
@@ -73,7 +73,7 @@ private DestinationPatternsMessageCondition(Collection<String> patterns, PathMat private static List<String> asList(String... patterns) { - return (patterns != null ? Arrays.asList(patterns) : Collections.<String>emptyList()); + return (patterns != null ? Arrays.asList(patterns) : Collections....
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-messaging/src/main/java/org/springframework/messaging/simp/broker/AbstractBrokerMessageHandler.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -84,7 +84,7 @@ public AbstractBrokerMessag...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-messaging/src/main/java/org/springframework/messaging/simp/config/AbstractBrokerRegistration.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2013 the original author or authors. + * Copyright 2002-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -50,8 +50,8 @@ public AbstractBrokerRegistra...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompHeaderAccessor.java
@@ -182,7 +182,7 @@ protected MessageHeaderAccessor createAccessor(Message<?> message) { Map<String, List<String>> getNativeHeaders() { @SuppressWarnings("unchecked") Map<String, List<String>> map = (Map<String, List<String>>) getHeader(NATIVE_HEADERS); - return (map != null ? map : Collections.<String, List<S...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-messaging/src/main/java/org/springframework/messaging/simp/user/DefaultUserDestinationResolver.java
@@ -188,7 +188,7 @@ else if (SimpMessageType.MESSAGE.equals(messageType)) { } } else { - sessionIds = Collections.<String>emptySet(); + sessionIds = Collections.emptySet(); } } if (!this.keepLeadingSlash) {
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-messaging/src/main/java/org/springframework/messaging/support/NativeMessageHeaderAccessor.java
@@ -94,7 +94,7 @@ private Map<String, List<String>> getNativeHeaders() { */ public Map<String, List<String>> toNativeHeaderMap() { Map<String, List<String>> map = getNativeHeaders(); - return (map != null ? new LinkedMultiValueMap<>(map) : Collections.<String, List<String>>emptyMap()); + return (map != null ?...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-messaging/src/main/java/org/springframework/messaging/tcp/reactor/Reactor2TcpClient.java
@@ -299,8 +299,7 @@ private static class SynchronousDispatcherConfigReader implements ConfigurationR @Override public ReactorConfiguration read() { - return new ReactorConfiguration( - Collections.<DispatcherConfiguration>emptyList(), "sync", new Properties()); + return new ReactorConfiguration(Collecti...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-test/src/main/java/org/springframework/mock/web/MockServletContext.java
@@ -425,13 +425,13 @@ public Servlet getServlet(String name) { @Override @Deprecated public Enumeration<Servlet> getServlets() { - return Collections.enumeration(Collections.<Servlet>emptySet()); + return Collections.enumeration(Collections.emptySet()); } @Override @Deprecated public Enumeration<Strin...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-test/src/main/java/org/springframework/test/context/support/TestPropertySourceUtils.java
@@ -132,7 +132,7 @@ private static String[] mergeProperties(List<TestPropertySourceAttributes> attri if (logger.isTraceEnabled()) { logger.trace(String.format("Processing inlined properties for TestPropertySource attributes %s", attrs)); } - properties.addAll(0, Arrays.<String>asList(attrs.getProperties(...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-web/src/main/java/org/springframework/http/MediaType.java
@@ -269,7 +269,7 @@ public MediaType(String type) { * @throws IllegalArgumentException if any of the parameters contain illegal characters */ public MediaType(String type, String subtype) { - super(type, subtype, Collections.<String, String>emptyMap()); + super(type, subtype, Collections.emptyMap()); } ...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-web/src/main/java/org/springframework/http/client/InterceptingAsyncClientHttpRequestFactory.java
@@ -47,7 +47,7 @@ public InterceptingAsyncClientHttpRequestFactory(AsyncClientHttpRequestFactory d List<AsyncClientHttpRequestInterceptor> interceptors) { this.delegate = delegate; - this.interceptors = (interceptors != null ? interceptors : Collections.<AsyncClientHttpRequestInterceptor>emptyList()); + this...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-web/src/main/java/org/springframework/http/client/InterceptingClientHttpRequestFactory.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -42,7 +42,7 @@ public InterceptingClientHttp...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-web/src/main/java/org/springframework/web/accept/HeaderContentNegotiationStrategy.java
@@ -45,7 +45,7 @@ public List<MediaType> resolveMediaTypes(NativeWebRequest request) String[] headerValueArray = request.getHeaderValues(HttpHeaders.ACCEPT); if (headerValueArray == null) { - return Collections.<MediaType>emptyList(); + return Collections.emptyList(); } List<String> headerValues = A...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-web/src/main/java/org/springframework/web/accept/MappingMediaTypeFileExtensionResolver.java
@@ -90,7 +90,7 @@ protected void addMapping(String extension, MediaType mediaType) { @Override public List<String> resolveFileExtensions(MediaType mediaType) { List<String> fileExtensions = this.fileExtensions.get(mediaType); - return (fileExtensions != null) ? fileExtensions : Collections.<String>emptyList(); ...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-web/src/main/java/org/springframework/web/filter/ForwardedHeaderFilter.java
@@ -213,7 +213,7 @@ public String getHeader(String name) { @Override public Enumeration<String> getHeaders(String name) { List<String> value = this.headers.get(name); - return (Collections.enumeration(value != null ? value : Collections.<String>emptySet())); + return (Collections.enumeration(value != null...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-webmvc/src/main/java/org/springframework/web/servlet/handler/AbstractHandlerMethodMapping.java
@@ -590,7 +590,7 @@ private List<String> getDirectUrls(T mapping) { private void addMappingName(String name, HandlerMethod handlerMethod) { List<HandlerMethod> oldList = this.nameLookup.get(name); if (oldList == null) { - oldList = Collections.<HandlerMethod>emptyList(); + oldList = Collections.emptyLi...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-webmvc/src/main/java/org/springframework/web/servlet/handler/SimpleServletPostProcessor.java
@@ -163,7 +163,7 @@ public String getInitParameter(String paramName) { @Override public Enumeration<String> getInitParameterNames() { - return Collections.enumeration(Collections.<String>emptySet()); + return Collections.enumeration(Collections.emptySet()); } }
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/condition/PatternsRequestCondition.java
@@ -119,7 +119,7 @@ private PatternsRequestCondition(Collection<String> patterns, UrlPathHelper urlP private static List<String> asList(String... patterns) { - return (patterns != null ? Arrays.asList(patterns) : Collections.<String>emptyList()); + return (patterns != null ? Arrays.asList(patterns) : Collection...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/condition/RequestMethodsRequestCondition.java
@@ -62,7 +62,7 @@ private RequestMethodsRequestCondition(Collection<RequestMethod> requestMethods) private static List<RequestMethod> asList(RequestMethod... requestMethods) { - return (requestMethods != null ? Arrays.asList(requestMethods) : Collections.<RequestMethod>emptyList()); + return (requestMethods != ...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ServletModelAttributeMethodProcessor.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -106,7 +106,7 @@ else if (StringUtils.hasTex...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/SseEmitter.java
@@ -235,7 +235,7 @@ SseEventBuilderImpl append(String text) { @Override public Set<DataWithMediaType> build() { if ((this.sb == null || this.sb.length() == 0) && this.dataToSend.isEmpty()) { - return Collections.<DataWithMediaType>emptySet(); + return Collections.emptySet(); } append("\n"); ...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-webmvc/src/main/java/org/springframework/web/servlet/view/freemarker/FreeMarkerView.java
@@ -405,7 +405,7 @@ public String getInitParameter(String paramName) { @Override public Enumeration<String> getInitParameterNames() { - return Collections.enumeration(Collections.<String>emptySet()); + return Collections.enumeration(Collections.emptySet()); } }
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-websocket/src/main/java/org/springframework/web/socket/client/AbstractWebSocketClient.java
@@ -43,8 +43,6 @@ */ public abstract class AbstractWebSocketClient implements WebSocketClient { - protected final Log logger = LogFactory.getLog(getClass()); - private static final Set<String> specialHeaders = new HashSet<>(); static { @@ -60,11 +58,14 @@ public abstract class AbstractWebSocketClient impleme...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-websocket/src/main/java/org/springframework/web/socket/messaging/WebSocketStompClient.java
@@ -468,7 +468,7 @@ public StompWebSocketMessageCodec(int messageSizeLimit) { } public List<Message<byte[]>> decode(WebSocketMessage<?> webSocketMessage) { - List<Message<byte[]>> result = Collections.<Message<byte[]>>emptyList(); + List<Message<byte[]>> result = Collections.emptyList(); ByteBuffer byte...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-websocket/src/main/java/org/springframework/web/socket/server/standard/UndertowRequestUpgradeStrategy.java
@@ -66,7 +66,7 @@ protected void upgradeInternal(ServerHttpRequest request, ServerHttpResponse res StringBuffer requestUrl = servletRequest.getRequestURL(); String path = servletRequest.getRequestURI(); // shouldn't matter - Map<String, String> pathParams = Collections.<String, String>emptyMap(); + Map<Strin...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-websocket/src/main/java/org/springframework/web/socket/server/support/AbstractHandshakeHandler.java
@@ -367,7 +367,7 @@ protected final List<String> determineHandlerSupportedProtocols(WebSocketHandler if (handlerToCheck instanceof SubProtocolCapable) { subProtocols = ((SubProtocolCapable) handlerToCheck).getSubProtocols(); } - return (subProtocols != null ? subProtocols : Collections.<String>emptyList()); ...
true
Other
spring-projects
spring-framework
fb7ae010c867ae48ab51f48cce97fe2c07f44115.json
Avoid unnecessary generics on emptyMap/Set/List
spring-websocket/src/main/java/org/springframework/web/socket/server/support/HandshakeInterceptorChain.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -46,7 +46,7 @@ public class HandshakeInterce...
true
Other
spring-projects
spring-framework
774e4c3dc10035448d12e5f883823c260569f891.json
Improve performance of StompEncoder Fixes SPR-14747
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompEncoder.java
@@ -81,7 +81,10 @@ public byte[] encode(Map<String, Object> headers, byte[] payload) { } else { StompCommand command = StompHeaderAccessor.getCommand(headers); - Assert.notNull(command, "Missing STOMP command: " + headers); + if (command == null) { + throw new IllegalStateException("Missing STOMP...
false
Other
spring-projects
spring-framework
9b87ea017bc58c0921c0ba20cc1ff099c42eea67.json
fix spelling of word 'recommendation' this PR fixes the spelling error for the word 'recommendation'
spring-web/src/main/java/org/springframework/http/HttpHeaders.java
@@ -61,6 +61,7 @@ * @author Sebastien Deleuze * @author Brian Clozel * @author Juergen Hoeller + * @author Josh Long * @since 3.0 */ public class HttpHeaders implements MultiValueMap<String, String>, Serializable { @@ -94,42 +95,42 @@ public class HttpHeaders implements MultiValueMap<String, String>, Seriali...
false
Other
spring-projects
spring-framework
5b33e02fb441357f0160f24be89a7f61bbbad1a4.json
Add ClientHttpRequestInterceptor in WebClient This commit adds a new chain-based, interception contract to be used with `WebClient`. This is the HTTP client equivalent of the `WebFilter` contract already implemented in web reactive server. A `ClientHttpRequestInterceptor` implementation can transform the outgoing HTT...
spring-web/src/main/java/org/springframework/web/client/reactive/ClientHttpRequestInterceptionChain.java
@@ -0,0 +1,47 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
5b33e02fb441357f0160f24be89a7f61bbbad1a4.json
Add ClientHttpRequestInterceptor in WebClient This commit adds a new chain-based, interception contract to be used with `WebClient`. This is the HTTP client equivalent of the `WebFilter` contract already implemented in web reactive server. A `ClientHttpRequestInterceptor` implementation can transform the outgoing HTT...
spring-web/src/main/java/org/springframework/web/client/reactive/ClientHttpRequestInterceptor.java
@@ -0,0 +1,66 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
5b33e02fb441357f0160f24be89a7f61bbbad1a4.json
Add ClientHttpRequestInterceptor in WebClient This commit adds a new chain-based, interception contract to be used with `WebClient`. This is the HTTP client equivalent of the `WebFilter` contract already implemented in web reactive server. A `ClientHttpRequestInterceptor` implementation can transform the outgoing HTT...
spring-web/src/main/java/org/springframework/web/client/reactive/WebClient.java
@@ -16,6 +16,7 @@ package org.springframework.web.client.reactive; +import java.net.URI; import java.util.ArrayList; import java.util.Collections; import java.util.List; @@ -33,6 +34,8 @@ import org.springframework.core.codec.CharSequenceEncoder; import org.springframework.core.codec.ResourceDecoder; import ...
true
Other
spring-projects
spring-framework
5b33e02fb441357f0160f24be89a7f61bbbad1a4.json
Add ClientHttpRequestInterceptor in WebClient This commit adds a new chain-based, interception contract to be used with `WebClient`. This is the HTTP client equivalent of the `WebFilter` contract already implemented in web reactive server. A `ClientHttpRequestInterceptor` implementation can transform the outgoing HTT...
spring-web/src/test/java/org/springframework/web/client/reactive/ClientHttpRequestInterceptorTests.java
@@ -0,0 +1,165 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
c6081031400ddaf1424751ca75c17d572ff808aa.json
Add client HTTP request and response Mocks
spring-web/src/test/java/org/springframework/web/client/reactive/test/MockClientHttpRequest.java
@@ -0,0 +1,122 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
c6081031400ddaf1424751ca75c17d572ff808aa.json
Add client HTTP request and response Mocks
spring-web/src/test/java/org/springframework/web/client/reactive/test/MockClientHttpResponse.java
@@ -0,0 +1,105 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
deac8e556e10f8ec352f5dae36e54e897fea2b2e.json
Improve Kotlin extensions doc about type erasure Since type erasure can be fixed only when using ParameterizedTypeReference based Java methods, RestOperations and WebFlux API documentation should be updated to specify which extensions are subject to type erasure, and which are not. Issue: SPR-16273
spring-web/src/main/kotlin/org/springframework/web/client/RestOperationsExtensions.kt
@@ -24,8 +24,10 @@ import org.springframework.http.ResponseEntity import java.net.URI /** - * Extension for [RestOperations.getForObject] avoiding specifying the type - * parameter thanks to Kotlin reified type parameters. + * Extension for [RestOperations.getForObject] providing a `getForObject<Foo>(...)` + * vari...
true
Other
spring-projects
spring-framework
deac8e556e10f8ec352f5dae36e54e897fea2b2e.json
Improve Kotlin extensions doc about type erasure Since type erasure can be fixed only when using ParameterizedTypeReference based Java methods, RestOperations and WebFlux API documentation should be updated to specify which extensions are subject to type erasure, and which are not. Issue: SPR-16273
spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/client/ClientResponseExtensions.kt
@@ -23,7 +23,8 @@ import reactor.core.publisher.Mono /** * Extension for [ClientResponse.bodyToMono] providing a `bodyToMono<Foo>()` variant - * leveraging Kotlin reified type parameters. + * leveraging Kotlin reified type parameters. This extension is not subject to type + * erasure and retains actual generic typ...
true
Other
spring-projects
spring-framework
deac8e556e10f8ec352f5dae36e54e897fea2b2e.json
Improve Kotlin extensions doc about type erasure Since type erasure can be fixed only when using ParameterizedTypeReference based Java methods, RestOperations and WebFlux API documentation should be updated to specify which extensions are subject to type erasure, and which are not. Issue: SPR-16273
spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/client/WebClientExtensions.kt
@@ -25,7 +25,8 @@ import reactor.core.publisher.Mono /** * Extension for [WebClient.RequestBodySpec.body] providing a `body<Foo>()` variant - * leveraging Kotlin reified type parameters. + * leveraging Kotlin reified type parameters. This extension is not subject to type + * erasure and retains actual generic type...
true
Other
spring-projects
spring-framework
deac8e556e10f8ec352f5dae36e54e897fea2b2e.json
Improve Kotlin extensions doc about type erasure Since type erasure can be fixed only when using ParameterizedTypeReference based Java methods, RestOperations and WebFlux API documentation should be updated to specify which extensions are subject to type erasure, and which are not. Issue: SPR-16273
spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/server/ServerRequestExtensions.kt
@@ -22,7 +22,8 @@ import reactor.core.publisher.Mono /** * Extension for [ServerRequest.bodyToMono] providing a `bodyToMono<Foo>()` variant - * leveraging Kotlin reified type parameters. + * leveraging Kotlin reified type parameters. This extension is not subject to type + * erasure and retains actual generic type...
true
Other
spring-projects
spring-framework
deac8e556e10f8ec352f5dae36e54e897fea2b2e.json
Improve Kotlin extensions doc about type erasure Since type erasure can be fixed only when using ParameterizedTypeReference based Java methods, RestOperations and WebFlux API documentation should be updated to specify which extensions are subject to type erasure, and which are not. Issue: SPR-16273
spring-webflux/src/main/kotlin/org/springframework/web/reactive/function/server/ServerResponseExtensions.kt
@@ -22,7 +22,9 @@ import org.springframework.http.MediaType import reactor.core.publisher.Mono /** - * Extension for [ServerResponse.BodyBuilder.body] providing a `body(Publisher<T>)` variant. + * Extension for [ServerResponse.BodyBuilder.body] providing a `body(Publisher<T>)` + * variant. This extension is not sub...
true
Other
spring-projects
spring-framework
3aee3182ac3859e5b6c2db90f05041c55dd63f40.json
Restore milestone repo for AspectJ
build.gradle
@@ -131,7 +131,8 @@ configure(allprojects) { project -> repositories { maven { url "https://repo.spring.io/libs-release" } - maven { url "https://repo.spring.io/snapshot" } // for AspectJ 1.9 beta and Reactor snapshots + maven { url "https://repo.spring.io/milestone" } // for AspectJ 1.9 beta + maven { url ...
false
Other
spring-projects
spring-framework
0075f13126a8837716ee47ccdfad2ed7482c8a0f.json
Improve CORS list properties combination logic This commit allows CorsConfiguration#combine() to differentiate permit default values set by CorsConfiguration#applyPermitDefaultValues() from values configured explicitly by the user. Those permit default values will be overridden by any user-provided ones while user-pr...
spring-web/src/main/java/org/springframework/web/bind/annotation/CrossOrigin.java
@@ -36,6 +36,12 @@ * {@link CorsConfiguration} and then default values are applied via * {@link CorsConfiguration#applyPermitDefaultValues()}. * + * <p>The rules for combining global and local configuration are generally + * additive -- e.g. all global and all local origins. For those attributes + * where only a ...
true
Other
spring-projects
spring-framework
0075f13126a8837716ee47ccdfad2ed7482c8a0f.json
Improve CORS list properties combination logic This commit allows CorsConfiguration#combine() to differentiate permit default values set by CorsConfiguration#applyPermitDefaultValues() from values configured explicitly by the user. Those permit default values will be overridden by any user-provided ones while user-pr...
spring-web/src/main/java/org/springframework/web/cors/CorsConfiguration.java
@@ -22,6 +22,7 @@ import java.util.LinkedHashSet; import java.util.List; import java.util.Set; +import java.util.stream.Collectors; import org.springframework.http.HttpMethod; import org.springframework.lang.Nullable; @@ -51,14 +52,14 @@ public class CorsConfiguration { /** Wildcard representing <em>all</em> o...
true
Other
spring-projects
spring-framework
0075f13126a8837716ee47ccdfad2ed7482c8a0f.json
Improve CORS list properties combination logic This commit allows CorsConfiguration#combine() to differentiate permit default values set by CorsConfiguration#applyPermitDefaultValues() from values configured explicitly by the user. Those permit default values will be overridden by any user-provided ones while user-pr...
spring-web/src/test/java/org/springframework/web/cors/CorsConfigurationTests.java
@@ -108,6 +108,37 @@ public void combineWithNullProperties() { assertTrue(config.getAllowCredentials()); } + @Test // SPR-15772 + public void combineWithDefaultPermitValues() { + CorsConfiguration config = new CorsConfiguration().applyPermitDefaultValues(); + CorsConfiguration other = new CorsConfiguration();...
true
Other
spring-projects
spring-framework
0075f13126a8837716ee47ccdfad2ed7482c8a0f.json
Improve CORS list properties combination logic This commit allows CorsConfiguration#combine() to differentiate permit default values set by CorsConfiguration#applyPermitDefaultValues() from values configured explicitly by the user. Those permit default values will be overridden by any user-provided ones while user-pr...
src/docs/asciidoc/web/webflux-cors.adoc
@@ -55,9 +55,10 @@ class or method-level `@CrossOrigin` annotations (other handlers can implement `CorsConfigurationSource`). The rules for combining global and local configuration are generally additive -- e.g. -all global and all local origins. The only exception are those attributes where only a -single value ca...
true
Other
spring-projects
spring-framework
0075f13126a8837716ee47ccdfad2ed7482c8a0f.json
Improve CORS list properties combination logic This commit allows CorsConfiguration#combine() to differentiate permit default values set by CorsConfiguration#applyPermitDefaultValues() from values configured explicitly by the user. Those permit default values will be overridden by any user-provided ones while user-pr...
src/docs/asciidoc/web/webmvc-cors.adoc
@@ -55,9 +55,10 @@ class or method-level `@CrossOrigin` annotations (other handlers can implement `CorsConfigurationSource`). The rules for combining global and local configuration are generally additive -- e.g. -all global and all local origins. The only exception are those attributes where only a -single value ca...
true
Other
spring-projects
spring-framework
f4d8c7cc2b6e3add1b1b06dc487cce82dceb4a49.json
Improve decodeToMono support This commit ensures uniform support for decodeToMono across the various byte and String related decoders. Issue: SPR-16253
spring-core/src/main/java/org/springframework/core/codec/AbstractDataBufferDecoder.java
@@ -0,0 +1,76 @@ +/* + * Copyright 2002-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
f4d8c7cc2b6e3add1b1b06dc487cce82dceb4a49.json
Improve decodeToMono support This commit ensures uniform support for decodeToMono across the various byte and String related decoders. Issue: SPR-16253
spring-core/src/main/java/org/springframework/core/codec/ByteArrayDecoder.java
@@ -18,9 +18,6 @@ import java.util.Map; -import org.reactivestreams.Publisher; -import reactor.core.publisher.Flux; - import org.springframework.core.ResolvableType; import org.springframework.core.io.buffer.DataBuffer; import org.springframework.core.io.buffer.DataBufferUtils; @@ -32,9 +29,11 @@ * Decoder fo...
true
Other
spring-projects
spring-framework
f4d8c7cc2b6e3add1b1b06dc487cce82dceb4a49.json
Improve decodeToMono support This commit ensures uniform support for decodeToMono across the various byte and String related decoders. Issue: SPR-16253
spring-core/src/main/java/org/springframework/core/codec/ByteBufferDecoder.java
@@ -19,9 +19,6 @@ import java.nio.ByteBuffer; import java.util.Map; -import org.reactivestreams.Publisher; -import reactor.core.publisher.Flux; - import org.springframework.core.ResolvableType; import org.springframework.core.io.buffer.DataBuffer; import org.springframework.core.io.buffer.DataBufferUtils; @@ -34...
true
Other
spring-projects
spring-framework
f4d8c7cc2b6e3add1b1b06dc487cce82dceb4a49.json
Improve decodeToMono support This commit ensures uniform support for decodeToMono across the various byte and String related decoders. Issue: SPR-16253
spring-core/src/main/java/org/springframework/core/codec/DataBufferDecoder.java
@@ -34,9 +34,11 @@ * {@link org.springframework.core.io.buffer.DataBufferUtils#release(DataBuffer)}. * * @author Arjen Poutsma + * @author Rossen Stoyanchev * @since 5.0 */ -public class DataBufferDecoder extends AbstractDecoder<DataBuffer> { +public class DataBufferDecoder extends AbstractDataBufferDecoder<D...
true
Other
spring-projects
spring-framework
f4d8c7cc2b6e3add1b1b06dc487cce82dceb4a49.json
Improve decodeToMono support This commit ensures uniform support for decodeToMono across the various byte and String related decoders. Issue: SPR-16253
spring-core/src/main/java/org/springframework/core/codec/ResourceDecoder.java
@@ -21,7 +21,6 @@ import org.reactivestreams.Publisher; import reactor.core.publisher.Flux; -import reactor.core.publisher.Mono; import org.springframework.core.ResolvableType; import org.springframework.core.io.ByteArrayResource; @@ -38,9 +37,11 @@ * Decoder for {@link Resource}s. * * @author Arjen Pouts...
true
Other
spring-projects
spring-framework
f4d8c7cc2b6e3add1b1b06dc487cce82dceb4a49.json
Improve decodeToMono support This commit ensures uniform support for decodeToMono across the various byte and String related decoders. Issue: SPR-16253
spring-core/src/main/java/org/springframework/core/codec/StringDecoder.java
@@ -26,7 +26,6 @@ import org.reactivestreams.Publisher; import reactor.core.publisher.Flux; -import reactor.core.publisher.Mono; import org.springframework.core.ResolvableType; import org.springframework.core.io.buffer.DataBuffer; @@ -49,7 +48,7 @@ * @since 5.0 * @see CharSequenceEncoder */ -public class ...
true
Other
spring-projects
spring-framework
f4d8c7cc2b6e3add1b1b06dc487cce82dceb4a49.json
Improve decodeToMono support This commit ensures uniform support for decodeToMono across the various byte and String related decoders. Issue: SPR-16253
spring-core/src/test/java/org/springframework/core/codec/ByteArrayDecoderTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2016 the original author or authors. + * Copyright 2002-2017 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,6 +21,7 @@ import org.junit.Test; impo...
true
Other
spring-projects
spring-framework
f4d8c7cc2b6e3add1b1b06dc487cce82dceb4a49.json
Improve decodeToMono support This commit ensures uniform support for decodeToMono across the various byte and String related decoders. Issue: SPR-16253
spring-core/src/test/java/org/springframework/core/codec/ByteBufferDecoderTests.java
@@ -22,6 +22,7 @@ import org.junit.Test; import org.reactivestreams.Publisher; import reactor.core.publisher.Flux; +import reactor.core.publisher.Mono; import reactor.test.StepVerifier; import org.springframework.core.ResolvableType; @@ -63,4 +64,19 @@ public void decode() { .expectComplete() .verify()...
true
Other
spring-projects
spring-framework
f4d8c7cc2b6e3add1b1b06dc487cce82dceb4a49.json
Improve decodeToMono support This commit ensures uniform support for decodeToMono across the various byte and String related decoders. Issue: SPR-16253
spring-core/src/test/java/org/springframework/core/codec/DataBufferDecoderTests.java
@@ -17,15 +17,19 @@ package org.springframework.core.codec; import java.nio.ByteBuffer; +import java.nio.charset.StandardCharsets; +import java.time.Duration; import java.util.Collections; import org.junit.Test; import org.reactivestreams.Publisher; import reactor.core.publisher.Flux; +import reactor.core.pub...
true
Other
spring-projects
spring-framework
6a7b197af7f52568e14d53fab86a0aa44319f2ae.json
Improve Jackson codecs documentation
spring-web/src/main/java/org/springframework/http/codec/json/AbstractJackson2Decoder.java
@@ -46,12 +46,13 @@ import org.springframework.util.MimeType; /** - * Abstract base class for Jackson JSON 2.9 decoding. + * Abstract base class for Jackson 2.9 decoding, leveraging non-blocking parsing. * * @author Sebastien Deleuze * @author Rossen Stoyanchev * @author Arjen Poutsma * @since 5.0 + * @se...
true
Other
spring-projects
spring-framework
6a7b197af7f52568e14d53fab86a0aa44319f2ae.json
Improve Jackson codecs documentation
spring-web/src/main/java/org/springframework/http/codec/json/AbstractJackson2Encoder.java
@@ -48,7 +48,9 @@ import org.springframework.util.MimeType; /** - * Base class providing support methods for Jackson 2.9 encoding. + * Base class providing support methods for Jackson 2.9 encoding. For non-streaming use + * cases, {@link Flux} elements are collected into a {@link List} before serialization for + * ...
true
Other
spring-projects
spring-framework
6a7b197af7f52568e14d53fab86a0aa44319f2ae.json
Improve Jackson codecs documentation
spring-web/src/main/java/org/springframework/http/codec/json/Jackson2JsonDecoder.java
@@ -24,7 +24,8 @@ import org.springframework.util.MimeType; /** - * Decode a byte stream into JSON and convert to Object's with Jackson 2.9. + * Decode a byte stream into JSON and convert to Object's with Jackson 2.9, + * leveraging non-blocking parsing. * * @author Sebastien Deleuze * @author Rossen Stoyanch...
true
Other
spring-projects
spring-framework
6a7b197af7f52568e14d53fab86a0aa44319f2ae.json
Improve Jackson codecs documentation
spring-web/src/main/java/org/springframework/http/codec/json/Jackson2JsonEncoder.java
@@ -25,6 +25,7 @@ import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.databind.ObjectWriter; import com.fasterxml.jackson.databind.SerializationFeature; +import reactor.core.publisher.Flux; import org.springframework.core.ResolvableType; import org.springframework.http.MediaType; @@ ...
true
Other
spring-projects
spring-framework
6a7b197af7f52568e14d53fab86a0aa44319f2ae.json
Improve Jackson codecs documentation
spring-web/src/main/java/org/springframework/http/codec/json/Jackson2SmileDecoder.java
@@ -28,7 +28,8 @@ import org.springframework.util.MimeType; /** - * Decode a byte stream into Smile and convert to Object's with Jackson 2.9. + * Decode a byte stream into Smile and convert to Object's with Jackson 2.9, + * leveraging non-blocking parsing. * * @author Sebastien Deleuze * @author Rossen Stoyan...
true
Other
spring-projects
spring-framework
6a7b197af7f52568e14d53fab86a0aa44319f2ae.json
Improve Jackson codecs documentation
spring-web/src/main/java/org/springframework/http/codec/json/Jackson2SmileEncoder.java
@@ -21,6 +21,7 @@ import com.fasterxml.jackson.databind.ObjectMapper; import com.fasterxml.jackson.dataformat.smile.SmileFactory; +import reactor.core.publisher.Flux; import org.springframework.http.MediaType; import org.springframework.http.converter.json.Jackson2ObjectMapperBuilder; @@ -29,6 +30,8 @@ /** ...
true