language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
9fb8a2eb2e05b99179614a7d67a1a745e432819c.json
Add contextClass resolution to JacksonJsonDecoder Issue: SPR-14158
spring-web/src/main/java/org/springframework/http/codec/json/JacksonJsonDecoder.java
@@ -98,8 +98,8 @@ private Flux<Object> decodeInternal(JsonObjectDecoder objectDecoder, Publisher<D MethodParameter methodParameter = (elementType.getSource() instanceof MethodParameter ? (MethodParameter)elementType.getSource() : null); - // TODO Find a way to pass the real concrete controller contextClass -...
true
Other
spring-projects
spring-framework
4d035e3ab1761d003a85fc53d26b37cd1aef7b48.json
Update Google Protobuf support to 3.0.0 This commit adds support for Google Protobuf 3.0.0 and make some changes in the additional formats support: * "com.googlecode.protobuf-java-format:protobuf-java-format" is no longer required and its required version has been raised to 1.3+ (this lib adds support for JSON, XML, H...
build.gradle
@@ -69,6 +69,7 @@ configure(allprojects) { project -> ext.okhttpVersion = "2.7.5" ext.okhttp3Version = "3.4.1" ext.poiVersion = "3.14" + ext.protobufVersion = "3.0.0-beta-4" ext.reactivestreamsVersion = "1.0.0" ext.reactorVersion = "2.0.8.RELEASE" ext.reactorCoreV...
true
Other
spring-projects
spring-framework
4d035e3ab1761d003a85fc53d26b37cd1aef7b48.json
Update Google Protobuf support to 3.0.0 This commit adds support for Google Protobuf 3.0.0 and make some changes in the additional formats support: * "com.googlecode.protobuf-java-format:protobuf-java-format" is no longer required and its required version has been raised to 1.3+ (this lib adds support for JSON, XML, H...
spring-web/src/main/java/org/springframework/http/converter/protobuf/ProtobufHttpMessageConverter.java
@@ -17,39 +17,50 @@ package org.springframework.http.converter.protobuf; import java.io.IOException; +import java.io.InputStream; import java.io.InputStreamReader; +import java.io.OutputStream; import java.io.OutputStreamWriter; import java.lang.reflect.Method; import java.nio.charset.Charset; import java.nio....
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/build.gradle
@@ -27,7 +27,7 @@ repositories { } ext { - springVersion = '4.3.0.RC1' + springVersion = '4.3.0.BUILD-SNAPSHOT' reactorVersion = '2.5.0.BUILD-SNAPSHOT' reactorNettyVersion = '2.5.0.BUILD-SNAPSHOT' tomcatVersion = '8.0.33'
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/AbstractNamedValueMethodArgumentResolver.java
@@ -0,0 +1,290 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/CookieValueMethodArgumentResolver.java
@@ -0,0 +1,93 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/ExpressionValueMethodArgumentResolver.java
@@ -0,0 +1,81 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/PathVariableMapMethodArgumentResolver.java
@@ -0,0 +1,64 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/PathVariableMethodArgumentResolver.java
@@ -0,0 +1,114 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestAttributeMethodArgumentResolver.java
@@ -0,0 +1,68 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestHeaderMapMethodArgumentResolver.java
@@ -0,0 +1,62 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestHeaderMethodArgumentResolver.java
@@ -0,0 +1,97 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestMappingHandlerAdapter.java
@@ -28,7 +28,11 @@ import org.apache.commons.logging.LogFactory; import reactor.core.publisher.Mono; +import org.springframework.beans.BeansException; +import org.springframework.beans.factory.BeanFactory; +import org.springframework.beans.factory.BeanFactoryAware; import org.springframework.beans.factory.Initiali...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestParamArgumentResolver.java
@@ -1,52 +0,0 @@ -/* - * Copyright 2002-2015 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - ...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestParamMapMethodArgumentResolver.java
@@ -0,0 +1,69 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/RequestParamMethodArgumentResolver.java
@@ -0,0 +1,125 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/reactive/result/method/annotation/SessionAttributeMethodArgumentResolver.java
@@ -0,0 +1,71 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/main/java/org/springframework/web/server/ServerErrorException.java
@@ -0,0 +1,65 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/InvocableHandlerMethodTests.java
@@ -28,14 +28,16 @@ import reactor.core.publisher.Signal; import reactor.core.util.SignalKind; +import org.springframework.core.convert.support.GenericConversionService; import org.springframework.http.server.reactive.ServerHttpRequest; import org.springframework.http.server.reactive.ServerHttpResponse; import o...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/AbstractRequestAttributesArgumentResolverTests.java
@@ -0,0 +1,177 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/CookieValueMethodArgumentResolverTests.java
@@ -0,0 +1,132 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/ExpressionValueMethodArgumentResolverTests.java
@@ -0,0 +1,104 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/PathVariableMapMethodArgumentResolverTests.java
@@ -0,0 +1,112 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/PathVariableMethodArgumentResolverTests.java
@@ -0,0 +1,110 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestAttributeMethodArgumentResolverTests.java
@@ -0,0 +1,163 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestHeaderMapMethodArgumentResolverTests.java
@@ -0,0 +1,150 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestHeaderMethodArgumentResolverTests.java
@@ -0,0 +1,229 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestParamMapMethodArgumentResolverTests.java
@@ -0,0 +1,129 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/RequestParamMethodArgumentResolverTests.java
@@ -0,0 +1,232 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
4d9126a474ca9a06ce53740db509c59cc59b3f6b.json
Add support for more annotated method arguments - @PathVariable - @RequestHeader - @RequestParam - @CookieValue - @Value - @RequestAttribute - @SessionAttribute
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/SessionAttributeMethodArgumentResolverTests.java
@@ -0,0 +1,170 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
7b13311f0303ad7fb564217f2e1c539ced86f1dd.json
Delete unused imports
spring-context/src/test/java/org/springframework/beans/factory/support/QualifierAnnotationAutowireContextTests.java
@@ -21,7 +21,6 @@ import java.lang.annotation.RetentionPolicy; import java.lang.annotation.Target; -import org.junit.Ignore; import org.junit.Test; import org.springframework.aop.scope.ScopedProxyUtils; @@ -34,7 +33,6 @@ import org.springframework.beans.factory.config.ConstructorArgumentValues; import org.spr...
true
Other
spring-projects
spring-framework
7b13311f0303ad7fb564217f2e1c539ced86f1dd.json
Delete unused imports
spring-context/src/test/java/org/springframework/beans/factory/xml/XmlBeanFactoryTests.java
@@ -28,7 +28,6 @@ import java.util.concurrent.atomic.AtomicInteger; import org.apache.commons.logging.LogFactory; -import org.junit.Ignore; import org.junit.Test; import org.xml.sax.InputSource;
true
Other
spring-projects
spring-framework
7b13311f0303ad7fb564217f2e1c539ced86f1dd.json
Delete unused imports
spring-context/src/test/java/org/springframework/cache/config/EnableCachingIntegrationTests.java
@@ -1,3 +1,19 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
7b13311f0303ad7fb564217f2e1c539ced86f1dd.json
Delete unused imports
spring-context/src/test/java/org/springframework/context/annotation/ComponentScanAnnotationIntegrationTests.java
@@ -33,6 +33,7 @@ import example.scannable_implicitbasepackage.ConfigurableComponent; import example.scannable_scoped.CustomScopeAnnotationBean; import example.scannable_scoped.MyScope; + import org.junit.Test; import org.springframework.aop.support.AopUtils; @@ -42,7 +43,6 @@ import org.springframework.beans.f...
true
Other
spring-projects
spring-framework
7b13311f0303ad7fb564217f2e1c539ced86f1dd.json
Delete unused imports
spring-context/src/test/java/org/springframework/validation/beanvalidation/SpringValidatorAdapterTests.java
@@ -16,42 +16,47 @@ package org.springframework.validation.beanvalidation; +import java.lang.annotation.Documented; +import java.lang.annotation.Inherited; +import java.lang.annotation.Repeatable; +import java.lang.annotation.Retention; +import java.lang.annotation.Target; +import java.util.Locale; +import javax.v...
true
Other
spring-projects
spring-framework
7b13311f0303ad7fb564217f2e1c539ced86f1dd.json
Delete unused imports
spring-messaging/src/test/java/org/springframework/messaging/simp/config/MessageBrokerConfigurationTests.java
@@ -59,7 +59,6 @@ import org.springframework.messaging.simp.user.MultiServerUserRegistry; import org.springframework.messaging.simp.user.SimpUserRegistry; import org.springframework.messaging.simp.user.UserDestinationMessageHandler; -import org.springframework.messaging.simp.user.UserDestinationResolver; import org...
true
Other
spring-projects
spring-framework
7b13311f0303ad7fb564217f2e1c539ced86f1dd.json
Delete unused imports
spring-messaging/src/test/java/org/springframework/messaging/simp/user/DefaultUserDestinationResolverTests.java
@@ -30,7 +30,6 @@ import org.springframework.messaging.simp.TestPrincipal; import org.springframework.messaging.support.MessageBuilder; import org.springframework.util.AntPathMatcher; -import org.springframework.util.PathMatcher; import org.springframework.util.StringUtils; /**
true
Other
spring-projects
spring-framework
7b13311f0303ad7fb564217f2e1c539ced86f1dd.json
Delete unused imports
spring-web/src/main/java/org/springframework/http/converter/ResourceHttpMessageConverter.java
@@ -19,15 +19,13 @@ import java.io.FileNotFoundException; import java.io.IOException; import java.io.InputStream; - import javax.activation.FileTypeMap; import javax.activation.MimetypesFileTypeMap; import org.springframework.core.io.ByteArrayResource; import org.springframework.core.io.ClassPathResource; imp...
true
Other
spring-projects
spring-framework
7b13311f0303ad7fb564217f2e1c539ced86f1dd.json
Delete unused imports
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/RequestMappingInfo.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,12 +19,10 @@ import java.util.List; im...
true
Other
spring-projects
spring-framework
7b13311f0303ad7fb564217f2e1c539ced86f1dd.json
Delete unused imports
spring-webmvc/src/main/java/org/springframework/web/servlet/view/script/ScriptTemplateView.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,10 +19,8 @@ import java.io.IOException;...
true
Other
spring-projects
spring-framework
7b13311f0303ad7fb564217f2e1c539ced86f1dd.json
Delete unused imports
spring-webmvc/src/test/java/org/springframework/web/servlet/config/MvcNamespaceTests.java
@@ -146,7 +146,6 @@ import org.springframework.web.util.UrlPathHelper; import static org.hamcrest.CoreMatchers.*; -import static org.hamcrest.Matchers.contains; import static org.hamcrest.Matchers.containsInAnyOrder; import static org.junit.Assert.*;
true
Other
spring-projects
spring-framework
7b13311f0303ad7fb564217f2e1c539ced86f1dd.json
Delete unused imports
spring-webmvc/src/test/java/org/springframework/web/servlet/config/annotation/WebMvcConfigurationSupportExtensionTests.java
@@ -22,6 +22,7 @@ import java.util.Map; import com.fasterxml.jackson.databind.ObjectMapper; + import org.junit.Before; import org.junit.Test; @@ -62,7 +63,6 @@ import org.springframework.web.method.support.HandlerMethodReturnValueHandler; import org.springframework.web.servlet.HandlerExceptionResolver; impor...
true
Other
spring-projects
spring-framework
7b13311f0303ad7fb564217f2e1c539ced86f1dd.json
Delete unused imports
spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/RequestPartMethodArgumentResolverTests.java
@@ -26,7 +26,6 @@ import javax.validation.Valid; import javax.validation.constraints.NotNull; -import org.hamcrest.Matchers; import org.junit.Before; import org.junit.Test;
true
Other
spring-projects
spring-framework
46e41a9d94bf586e5a80f262d2eee31b9612e93f.json
Consolidate SendTo vs SendToUser detection SendTo and SendToUser are treated as mutually exclusive. The addition of type-level support in 4.3. RC1 however did not consider the possibility to mix and match of the two betwee type and method level. This commit consolidates the detection of SendTo and SendToUser annotati...
spring-messaging/src/main/java/org/springframework/messaging/simp/annotation/support/SendToMethodReturnValueHandler.java
@@ -151,9 +151,10 @@ public void handleReturnValue(Object returnValue, MethodParameter returnType, Me MessageHeaders headers = message.getHeaders(); String sessionId = SimpMessageHeaderAccessor.getSessionId(headers); PlaceholderResolver varResolver = initVarResolver(headers); - SendToUser sendToUser = getSend...
true
Other
spring-projects
spring-framework
46e41a9d94bf586e5a80f262d2eee31b9612e93f.json
Consolidate SendTo vs SendToUser detection SendTo and SendToUser are treated as mutually exclusive. The addition of type-level support in 4.3. RC1 however did not consider the possibility to mix and match of the two betwee type and method level. This commit consolidates the detection of SendTo and SendToUser annotati...
spring-messaging/src/test/java/org/springframework/messaging/simp/annotation/support/SendToMethodReturnValueHandlerTests.java
@@ -287,6 +287,39 @@ public void sendToUserClassDefaultOverride() throws Exception { assertResponse(this.userDefaultOverrideAnnotation, sessionId, 1, "/user/sess1/dest4"); } + @Test // SPR-14238 + public void sendToUserWithSendToDefaultOverride() throws Exception { + given(this.messageChannel.send(any(Message.c...
true
Other
spring-projects
spring-framework
fdb31cd715f4a8811fbbe0b541b54ee5f65fa8df.json
Check actual cache value for unwrapped Optional Issue: SPR-14230
spring-context/src/test/java/org/springframework/cache/CacheReproTests.java
@@ -137,10 +137,17 @@ public void spr13081ConfigFailIfCacheResolverReturnsNullCacheName() { public void spr14230AdaptsToOptional() { AnnotationConfigApplicationContext context = new AnnotationConfigApplicationContext(Spr14230Config.class); Spr14230Service bean = context.getBean(Spr14230Service.class); + Cache ...
false
Other
spring-projects
spring-framework
bd40a93604bbff9e41085639628114fc0c0898c2.json
Ensure Environment.shutdown() in Reactor2TcpClient Issue: SPR-14229
spring-messaging/src/main/java/org/springframework/messaging/tcp/reactor/Reactor2TcpClient.java
@@ -84,6 +84,8 @@ private final EventLoopGroup eventLoopGroup; + private final Environment environment; + private final TcpClientFactory<Message<P>, Message<P>> tcpClientSpecFactory; private final List<TcpClient<Message<P>, Message<P>>> tcpClients = @@ -108,12 +110,13 @@ public Reactor2TcpClient(final Strin...
false
Other
spring-projects
spring-framework
977840884bf9c670a88bac1aeee3b3c8f1f9bf7b.json
Allow custom instances of WebJarAssetLocator This commit allows to configure a custom WebJarAssetLocator in WebJarResourceResolvers. Issue: SPR-14092
spring-webmvc/src/main/java/org/springframework/web/servlet/config/annotation/ResourceChainRegistration.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -56,6 +56,8 @@ public class ResourceChainReg...
true
Other
spring-projects
spring-framework
977840884bf9c670a88bac1aeee3b3c8f1f9bf7b.json
Allow custom instances of WebJarAssetLocator This commit allows to configure a custom WebJarAssetLocator in WebJarResourceResolvers. Issue: SPR-14092
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/WebJarsResourceResolver.java
@@ -17,6 +17,7 @@ package org.springframework.web.servlet.resource; import java.util.List; + import javax.servlet.http.HttpServletRequest; import org.webjars.MultipleMatchesException; @@ -49,8 +50,23 @@ public class WebJarsResourceResolver extends AbstractResourceResolver { private final static int WEBJARS_...
true
Other
spring-projects
spring-framework
977840884bf9c670a88bac1aeee3b3c8f1f9bf7b.json
Allow custom instances of WebJarAssetLocator This commit allows to configure a custom WebJarAssetLocator in WebJarResourceResolvers. Issue: SPR-14092
spring-webmvc/src/test/java/org/springframework/web/servlet/config/annotation/ResourceHandlerRegistryTests.java
@@ -180,6 +180,7 @@ public void resourceChainWithVersionResolver() throws Exception { public void resourceChainWithOverrides() throws Exception { CachingResourceResolver cachingResolver = Mockito.mock(CachingResourceResolver.class); VersionResourceResolver versionResolver = Mockito.mock(VersionResourceResolver....
true
Other
spring-projects
spring-framework
a50ea80e4e5ebb6e656737a6a32967967563eaa4.json
Handle multiple conditional request headers Prior to this change, setting both "If-None-Match" and "If-Unmodified-Since" conditional request headers would check for both conditions to be met. This commit fixes this behavior to follow the RFC7232 Section 6: > entity tags are presumed to be more accurate than date vali...
spring-web/src/main/java/org/springframework/web/context/request/ServletWebRequest.java
@@ -237,7 +237,12 @@ public boolean checkNotModified(String etag, long lastModifiedTimestamp) { if (StringUtils.hasLength(etag) && !this.notModified) { if (isCompatibleWithConditionalRequests(response)) { etag = addEtagPadding(etag); - this.notModified = isEtagNotModified(etag) && isTimestampNotModified(...
true
Other
spring-projects
spring-framework
a50ea80e4e5ebb6e656737a6a32967967563eaa4.json
Handle multiple conditional request headers Prior to this change, setting both "If-None-Match" and "If-Unmodified-Since" conditional request headers would check for both conditions to be met. This commit fixes this behavior to follow the RFC7232 Section 6: > entity tags are presumed to be more accurate than date vali...
spring-web/src/test/java/org/springframework/web/context/request/ServletWebRequestHttpMethodsTests.java
@@ -204,6 +204,7 @@ public void checkNotModifiedETagAndTimestamp() { assertEquals(dateFormat.format(currentDate.getTime()), servletResponse.getHeader("Last-Modified")); } + // SPR-14224 @Test public void checkNotModifiedETagAndModifiedTimestamp() { String eTag = "\"Foo\""; @@ -212,9 +213,9 @@ public void ...
true
Other
spring-projects
spring-framework
9798912557aa9e21885f471efabd2b793ac95735.json
Add missing @since tag
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompSession.java
@@ -94,7 +94,8 @@ public interface StompSession { * "client-individual" in order ot use this. * @param messageId the id of the message * @param consumed whether the message was consumed or not - * @return a Receiptable for tracking events + * @return a Receiptable for tracking receipts + * @since 4.3 */ ...
false
Other
spring-projects
spring-framework
c84c1cfd1b5846e1ce13b8209d88df36a96085aa.json
Update Javadoc for TestContextBootstrapper @WebAppConfiguration is no longer meta-annotated with @BootstrapWith.
spring-test/src/main/java/org/springframework/test/context/TestContextBootstrapper.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2015 the original author or authors. + * Copyright 2002-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -31,13 +31,14 @@ * * <p>A custom bootstr...
false
Other
spring-projects
spring-framework
17dd5dd22d9b68bf60c302833c8c33d3cb914ed3.json
Introduce Supplier<String> support in Assert util Prior to this commit, utility methods in org.springframework.util.Assert accepted String arguments for custom error messages. Such Strings are evaluated (e.g., concatenated) eagerly, and for performance reasons, it was therefore not always possible to make use of these...
spring-core/src/main/java/org/springframework/util/Assert.java
@@ -18,6 +18,7 @@ import java.util.Collection; import java.util.Map; +import java.util.function.Supplier; /** * Assertion utility class that assists in validating arguments. @@ -56,12 +57,29 @@ public abstract class Assert { /** - * Assert a boolean expression, throwing {@code IllegalArgumentException} -...
true
Other
spring-projects
spring-framework
17dd5dd22d9b68bf60c302833c8c33d3cb914ed3.json
Introduce Supplier<String> support in Assert util Prior to this commit, utility methods in org.springframework.util.Assert accepted String arguments for custom error messages. Such Strings are evaluated (e.g., concatenated) eagerly, and for performance reasons, it was therefore not always possible to make use of these...
spring-core/src/test/java/org/springframework/util/AssertTests.java
@@ -16,18 +16,17 @@ package org.springframework.util; -import java.util.ArrayList; import java.util.Collection; -import java.util.HashMap; -import java.util.HashSet; -import java.util.List; import java.util.Map; -import java.util.Set; +import java.util.function.Supplier; import org.junit.Rule; import org.jun...
true
Other
spring-projects
spring-framework
147a35f4f1fb00d3b22e994d48aeef5c19b399cb.json
Polish AntPathMatcher.setTrimTokens javadoc Issue: SPR-14247
spring-core/src/main/java/org/springframework/util/AntPathMatcher.java
@@ -132,7 +132,7 @@ public void setCaseSensitive(boolean caseSensitive) { /** * Specify whether to trim tokenized paths and patterns. - * <p>Default is {@code true}. + * <p>Default is {@code false}. */ public void setTrimTokens(boolean trimTokens) { this.trimTokens = trimTokens;
false
Other
spring-projects
spring-framework
22345f7c259f416834eeedf4a06c8a33f66b92de.json
Upgrade tests to EhCache 2.10+ Issue: SPR-13794
spring-context-support/src/test/java/org/springframework/cache/ehcache/EhCacheSupportTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2013 the original author or authors. + * Copyright 2002-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -119,7 +119,7 @@ public void testCacheManage...
false
Other
spring-projects
spring-framework
15c3cdd48deded4e7f8c21b07b1a88a8d097fcb2.json
Fix NoOpCache handling of get(key,callable) This commit fixes the method that takes a Callable to actually always invoke it rather than returning null. Issue: SPR-14445
spring-context/src/main/java/org/springframework/cache/support/NoOpCacheManager.java
@@ -102,7 +102,12 @@ public <T> T get(Object key, Class<T> type) { @Override public <T> T get(Object key, Callable<T> valueLoader) { - return null; + try { + return valueLoader.call(); + } + catch (Exception ex) { + throw new ValueRetrievalException(key, valueLoader, ex); + } } @Override
true
Other
spring-projects
spring-framework
15c3cdd48deded4e7f8c21b07b1a88a8d097fcb2.json
Fix NoOpCache handling of get(key,callable) This commit fixes the method that takes a Callable to actually always invoke it rather than returning null. Issue: SPR-14445
spring-context/src/test/java/org/springframework/cache/NoOpCacheManagerTests.java
@@ -18,33 +18,33 @@ import java.util.UUID; -import org.junit.Before; import org.junit.Test; import org.springframework.cache.support.NoOpCacheManager; import static org.junit.Assert.*; +/** + * Tests for {@link NoOpCacheManager}. + * + * @author Costin Leau + * @author Stephane Nicoll + */ public class N...
true
Other
spring-projects
spring-framework
d6d4251550a82fc6642bd11c43664e8c0dba5294.json
Utilize default methods in TestExecutionListener Issue: SPR-14432
spring-test/src/main/java/org/springframework/test/context/TestExecutionListener.java
@@ -21,6 +21,10 @@ * test execution events published by the {@link TestContextManager} with which * the listener is registered. * + * <p>This interface provides empty {@code default} implementations for all methods. + * Concrete implementations can therefore choose to override only those methods + * suitable for ...
true
Other
spring-projects
spring-framework
d6d4251550a82fc6642bd11c43664e8c0dba5294.json
Utilize default methods in TestExecutionListener Issue: SPR-14432
spring-test/src/main/java/org/springframework/test/context/support/AbstractTestExecutionListener.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2016 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -17,65 +17,18 @@ package org.springframewor...
true
Other
spring-projects
spring-framework
e8b5374d8776f040c9133ae341b17e780b1e2323.json
Require EhCache 2.10+ Issue: SPR-13794
spring-context-support/src/main/java/org/springframework/cache/ehcache/EhCacheFactoryBean.java
@@ -50,7 +50,7 @@ * <p>Note: If the named Cache instance is found, the properties will be ignored and the * Cache instance will be retrieved from the CacheManager. * - * <p>Note: As of Spring 4.1, Spring's EhCache support requires EhCache 2.5 or higher. + * <p>Note: As of Spring 5.0, Spring's EhCache support requ...
false
Other
spring-projects
spring-framework
40b2d26bd4e15f7eefe7f07aeb733761b9e241d5.json
Avoid reflection for @Repeatable look-ups Issue: SPR-13188
spring-core/src/main/java/org/springframework/core/annotation/AnnotationUtils.java
@@ -17,6 +17,7 @@ package org.springframework.core.annotation; import java.lang.annotation.Annotation; +import java.lang.annotation.Repeatable; import java.lang.reflect.AnnotatedElement; import java.lang.reflect.Array; import java.lang.reflect.InvocationHandler; @@ -111,8 +112,6 @@ public abstract class Annotati...
false
Other
spring-projects
spring-framework
99c7917124b8f5c997046bc169ec2a97ff5e62fb.json
Reset connection before delegating to handler Resetting the connection first before invoking a failure callback on the application handler ensures that any checks to isConnected will return false. Issue: SPR-14721
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/DefaultStompSession.java
@@ -480,8 +480,8 @@ public void afterConnectionClosed() { logger.debug("Connection closed session id=" + this.sessionId); } if (!this.closing) { - handleFailure(new ConnectionLostException("Connection closed")); resetConnection(); + handleFailure(new ConnectionLostException("Connection closed")); }...
false
Other
spring-projects
spring-framework
906827ea927a1f68fc4aec72279a9b7b29124085.json
Add missing quotation mark Closes gh-1181
src/asciidoc/core-validation.adoc
@@ -136,7 +136,7 @@ and use it like so: } if (!addressValidator.supports(Address.class)) { throw new IllegalArgumentException("The supplied [Validator] must " + - support the validation of [Address] instances."); + "support the validation of [Address] instances."); } this.addressValidator =...
false
Other
spring-projects
spring-framework
9e5435e6f2b9110969af9d581d1a05c6106b8dd7.json
Check template availability in ScriptTemplateView This commit overrides the `checkResource` implementation in `ScriptTemplateView` in order to check if the template file resource is available and if the resolver can then proceed with rendering the template. Issue: SPR-14729 Cherry-picked from: 66b370e10
spring-webmvc/src/main/java/org/springframework/web/servlet/view/script/ScriptTemplateView.java
@@ -16,12 +16,14 @@ package org.springframework.web.servlet.view.script; +import java.io.FileNotFoundException; import java.io.IOException; import java.io.InputStreamReader; import java.nio.charset.Charset; import java.nio.charset.StandardCharsets; import java.util.Arrays; import java.util.HashMap; +import j...
true
Other
spring-projects
spring-framework
9e5435e6f2b9110969af9d581d1a05c6106b8dd7.json
Check template availability in ScriptTemplateView This commit overrides the `checkResource` implementation in `ScriptTemplateView` in order to check if the template file resource is available and if the resolver can then proceed with rendering the template. Issue: SPR-14729 Cherry-picked from: 66b370e10
spring-webmvc/src/test/java/org/springframework/web/servlet/view/script/ScriptTemplateViewTests.java
@@ -20,6 +20,7 @@ import java.util.ArrayList; import java.util.HashMap; import java.util.List; +import java.util.Locale; import java.util.Map; import java.util.concurrent.ExecutorService; import java.util.concurrent.Executors; @@ -28,7 +29,9 @@ import javax.script.ScriptEngine; import org.junit.Before; +impor...
true
Other
spring-projects
spring-framework
80ff5ae9c513372db37eb0dbcb19048adb09b21f.json
Improve exception handling when clients disconnect. Issue: SPR-14538
spring-web/src/main/java/org/springframework/http/server/reactive/AbstractResponseBodyFlushProcessor.java
@@ -74,8 +74,8 @@ public final void onNext(Publisher<DataBuffer> publisher) { @Override public final void onError(Throwable t) { - if (logger.isErrorEnabled()) { - logger.error(this.state + " onError: " + t, t); + if (logger.isTraceEnabled()) { + logger.trace(this.state + " onError: " + t); } this.sta...
true
Other
spring-projects
spring-framework
80ff5ae9c513372db37eb0dbcb19048adb09b21f.json
Improve exception handling when clients disconnect. Issue: SPR-14538
spring-web/src/main/java/org/springframework/http/server/reactive/AbstractResponseBodyProcessor.java
@@ -79,8 +79,8 @@ public final void onNext(DataBuffer dataBuffer) { @Override public final void onError(Throwable t) { - if (logger.isErrorEnabled()) { - logger.error(this.state + " onError: " + t, t); + if (logger.isTraceEnabled()) { + logger.trace(this.state + " onError: " + t); } this.state.get().o...
true
Other
spring-projects
spring-framework
80ff5ae9c513372db37eb0dbcb19048adb09b21f.json
Improve exception handling when clients disconnect. Issue: SPR-14538
spring-web/src/main/java/org/springframework/http/server/reactive/ReactorHttpHandlerAdapter.java
@@ -21,9 +21,12 @@ import reactor.core.publisher.Mono; import reactor.ipc.netty.http.HttpChannel; +import org.apache.commons.logging.LogFactory; import org.springframework.core.io.buffer.NettyDataBufferFactory; import org.springframework.util.Assert; +import io.netty.handler.codec.http.HttpResponseStatus; + /*...
true
Other
spring-projects
spring-framework
80ff5ae9c513372db37eb0dbcb19048adb09b21f.json
Improve exception handling when clients disconnect. Issue: SPR-14538
spring-web/src/main/java/org/springframework/http/server/reactive/RxNettyHttpHandlerAdapter.java
@@ -17,11 +17,15 @@ package org.springframework.http.server.reactive; import io.netty.buffer.ByteBuf; +import io.netty.handler.codec.http.HttpResponseStatus; import io.reactivex.netty.protocol.http.server.HttpServerRequest; import io.reactivex.netty.protocol.http.server.HttpServerResponse; import io.reactivex.ne...
true
Other
spring-projects
spring-framework
80ff5ae9c513372db37eb0dbcb19048adb09b21f.json
Improve exception handling when clients disconnect. Issue: SPR-14538
spring-web/src/main/java/org/springframework/web/server/handler/ExceptionHandlingWebHandler.java
@@ -18,12 +18,15 @@ import java.util.Arrays; import java.util.Collections; +import java.util.HashSet; import java.util.List; +import java.util.Set; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import reactor.core.publisher.Mono; +import org.springframework.core.Nested...
true
Other
spring-projects
spring-framework
b58a06208f261db26832db531eb975e1e7c7c232.json
Add HttpBasic ClientWebRequestPostProcessor Issue: SPR-14682
spring-web/src/main/java/org/springframework/web/client/reactive/ClientWebRequestPostProcessors.java
@@ -0,0 +1,68 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
b58a06208f261db26832db531eb975e1e7c7c232.json
Add HttpBasic ClientWebRequestPostProcessor Issue: SPR-14682
spring-web/src/test/java/org/springframework/web/client/reactive/ClientWebRequestPostProcessorsTests.java
@@ -0,0 +1,71 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
0bace1b0ae7aec176607a8ffdbf3497bab7755a5.json
Add getContextPath to ServerHttpRequest Issue: SPR-14726
spring-web/src/main/java/org/springframework/http/server/reactive/ServerHttpRequest.java
@@ -25,10 +25,26 @@ * Represents a reactive server-side HTTP request * * @author Arjen Poutsma + * @author Rossen Stoyanchev * @since 5.0 */ public interface ServerHttpRequest extends HttpRequest, ReactiveHttpInputMessage { + + // TODO: https://jira.spring.io/browse/SPR-14726 + + /** + * Returns the porti...
true
Other
spring-projects
spring-framework
0bace1b0ae7aec176607a8ffdbf3497bab7755a5.json
Add getContextPath to ServerHttpRequest Issue: SPR-14726
spring-web/src/main/java/org/springframework/http/server/reactive/ServletServerHttpRequest.java
@@ -81,6 +81,11 @@ public HttpMethod getMethod() { return HttpMethod.valueOf(getServletRequest().getMethod()); } + @Override + public String getContextPath() { + return getServletRequest().getContextPath(); + } + @Override protected URI initUri() throws URISyntaxException { StringBuffer url = this.reques...
true
Other
spring-projects
spring-framework
0bace1b0ae7aec176607a8ffdbf3497bab7755a5.json
Add getContextPath to ServerHttpRequest Issue: SPR-14726
spring-web/src/main/java/org/springframework/web/util/HttpRequestPathHelper.java
@@ -19,8 +19,10 @@ import java.util.LinkedHashMap; import java.util.Map; +import org.springframework.http.server.reactive.ServerHttpRequest; import org.springframework.util.LinkedMultiValueMap; import org.springframework.util.MultiValueMap; +import org.springframework.util.StringUtils; import org.springframework...
true
Other
spring-projects
spring-framework
cf2112f5398c74f1d7279fea17b4db3a4dc6f4e1.json
Update intializer for the reactive servlet adapter Move the AbstractServletHttpHandlerAdapterInitializer together with the other two base classes in spring-web-reactive. Since the interface is in the web package, this avoids a package cycle. Also add a mention in the reference. Issue: SPR-14713
spring-web-reactive/src/main/java/org/springframework/web/reactive/support/AbstractAnnotationConfigDispatcherHandlerInitializer.java
@@ -28,8 +28,7 @@ * {@link org.springframework.context.annotation.Configuration @Configuration} classes in the * servlet context, wrapping it in a {@link ServletHttpHandlerAdapter}. * - * <p>Concrete implementations are required to implement {@link #getConfigClasses()} and - * {@link #getServletMapping()}. + * <p...
true
Other
spring-projects
spring-framework
cf2112f5398c74f1d7279fea17b4db3a4dc6f4e1.json
Update intializer for the reactive servlet adapter Move the AbstractServletHttpHandlerAdapterInitializer together with the other two base classes in spring-web-reactive. Since the interface is in the web package, this avoids a package cycle. Also add a mention in the reference. Issue: SPR-14713
spring-web-reactive/src/main/java/org/springframework/web/reactive/support/AbstractDispatcherHandlerInitializer.java
@@ -130,10 +130,9 @@ protected String getServletName() { /** * Refresh the given application context, if necessary. */ - protected void refreshApplicationContext(ApplicationContext applicationContext) { - if (applicationContext instanceof ConfigurableApplicationContext) { - ConfigurableApplicationContext cac...
true
Other
spring-projects
spring-framework
cf2112f5398c74f1d7279fea17b4db3a4dc6f4e1.json
Update intializer for the reactive servlet adapter Move the AbstractServletHttpHandlerAdapterInitializer together with the other two base classes in spring-web-reactive. Since the interface is in the web package, this avoids a package cycle. Also add a mention in the reference. Issue: SPR-14713
spring-web-reactive/src/main/java/org/springframework/web/reactive/support/AbstractServletHttpHandlerAdapterInitializer.java
@@ -14,7 +14,7 @@ * limitations under the License. */ -package org.springframework.http.server.reactive.support; +package org.springframework.web.reactive.support; import javax.servlet.ServletContext; import javax.servlet.ServletException; @@ -24,7 +24,6 @@ import org.springframework.http.server.reactive.Ser...
true
Other
spring-projects
spring-framework
cf2112f5398c74f1d7279fea17b4db3a4dc6f4e1.json
Update intializer for the reactive servlet adapter Move the AbstractServletHttpHandlerAdapterInitializer together with the other two base classes in spring-web-reactive. Since the interface is in the web package, this avoids a package cycle. Also add a mention in the reference. Issue: SPR-14713
spring-web/src/main/java/org/springframework/http/server/reactive/support/package-info.java
@@ -1,21 +0,0 @@ -/* - * Copyright 2002-2016 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - ...
true
Other
spring-projects
spring-framework
cf2112f5398c74f1d7279fea17b4db3a4dc6f4e1.json
Update intializer for the reactive servlet adapter Move the AbstractServletHttpHandlerAdapterInitializer together with the other two base classes in spring-web-reactive. Since the interface is in the web package, this avoids a package cycle. Also add a mention in the reference. Issue: SPR-14713
src/asciidoc/web-reactive.adoc
@@ -198,7 +198,7 @@ An `HttpHandler` can then be installed in each supported runtime: [source,java,indent=0] [subs="verbatim,quotes"] ---- -// Tomcat and Jetty +// Tomcat and Jetty (also see notes below) HttpServlet servlet = new ServletHttpHandlerAdapter(httpHandler); ... @@ -218,6 +218,16 @@ Undertow server = ...
true
Other
spring-projects
spring-framework
2b57a4d618a1e755ee9e362208291c0cde813e8d.json
Add WebApplicationInitializers for Web Reactive This commit introduces three new WebApplicationInitializers for use with Spring Web Reactive: - The AbstractServletHttpHandlerAdapterInitializer registers a ServletHttpHandlerAdapter that wraps a user-provided HttpHandler. - The AbstractDispatcherHandlerInitializer ...
spring-web-reactive/src/main/java/org/springframework/web/reactive/support/AbstractAnnotationConfigDispatcherHandlerInitializer.java
@@ -0,0 +1,65 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
2b57a4d618a1e755ee9e362208291c0cde813e8d.json
Add WebApplicationInitializers for Web Reactive This commit introduces three new WebApplicationInitializers for use with Spring Web Reactive: - The AbstractServletHttpHandlerAdapterInitializer registers a ServletHttpHandlerAdapter that wraps a user-provided HttpHandler. - The AbstractDispatcherHandlerInitializer ...
spring-web-reactive/src/main/java/org/springframework/web/reactive/support/AbstractDispatcherHandlerInitializer.java
@@ -0,0 +1,215 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
2b57a4d618a1e755ee9e362208291c0cde813e8d.json
Add WebApplicationInitializers for Web Reactive This commit introduces three new WebApplicationInitializers for use with Spring Web Reactive: - The AbstractServletHttpHandlerAdapterInitializer registers a ServletHttpHandlerAdapter that wraps a user-provided HttpHandler. - The AbstractDispatcherHandlerInitializer ...
spring-web-reactive/src/main/java/org/springframework/web/reactive/support/package-info.java
@@ -0,0 +1,4 @@ +/** + * Support classes for Spring Web Reactive. + */ +package org.springframework.web.reactive.support; \ No newline at end of file
true
Other
spring-projects
spring-framework
2b57a4d618a1e755ee9e362208291c0cde813e8d.json
Add WebApplicationInitializers for Web Reactive This commit introduces three new WebApplicationInitializers for use with Spring Web Reactive: - The AbstractServletHttpHandlerAdapterInitializer registers a ServletHttpHandlerAdapter that wraps a user-provided HttpHandler. - The AbstractDispatcherHandlerInitializer ...
spring-web/src/main/java/org/springframework/http/server/reactive/support/AbstractServletHttpHandlerAdapterInitializer.java
@@ -0,0 +1,130 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
2b57a4d618a1e755ee9e362208291c0cde813e8d.json
Add WebApplicationInitializers for Web Reactive This commit introduces three new WebApplicationInitializers for use with Spring Web Reactive: - The AbstractServletHttpHandlerAdapterInitializer registers a ServletHttpHandlerAdapter that wraps a user-provided HttpHandler. - The AbstractDispatcherHandlerInitializer ...
spring-web/src/main/java/org/springframework/http/server/reactive/support/package-info.java
@@ -0,0 +1,21 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
de3e07b3203581242c701f86ffc49cd010d44fca.json
Move instance methods before static methods
spring-web-reactive/src/main/java/org/springframework/web/reactive/function/Configuration.java
@@ -34,6 +34,29 @@ */ public interface Configuration { + // Instance methods + + /** + * Supply a {@linkplain Stream stream} of {@link HttpMessageReader}s to be used for request + * body conversion. + * @return the stream of message readers + */ + Supplier<Stream<HttpMessageReader<?>>> messageReaders(); + + /*...
true
Other
spring-projects
spring-framework
de3e07b3203581242c701f86ffc49cd010d44fca.json
Move instance methods before static methods
spring-web-reactive/src/main/java/org/springframework/web/reactive/function/Request.java
@@ -110,6 +110,7 @@ default Optional<String> pathVariable(String name) { */ Map<String, String> pathVariables(); + /** * Represents the headers of the HTTP request. * @see Request#headers()
true
Other
spring-projects
spring-framework
de3e07b3203581242c701f86ffc49cd010d44fca.json
Move instance methods before static methods
spring-web-reactive/src/main/java/org/springframework/web/reactive/function/Response.java
@@ -46,6 +46,31 @@ */ public interface Response<T> { + // Instance methods + + /** + * Return the status code of this response. + */ + HttpStatus statusCode(); + + /** + * Return the headers of this response. + */ + HttpHeaders headers(); + + /** + * Return the body of this response. + */ + T body(); + + /**...
true
Other
spring-projects
spring-framework
aaa128180958d4b6d420cb7e4a955bb2edab0c0b.json
Remove Exception declaration in abstract Encoder
spring-core/src/main/java/org/springframework/core/codec/AbstractSingleValueEncoder.java
@@ -47,14 +47,7 @@ public final Flux<DataBuffer> encode(Publisher<? extends T> inputStream, DataBuf return Flux.from(inputStream). take(1). - concatMap(t -> { - try { - return encode(t, bufferFactory, elementType, mimeType, hints); - } - catch (Exception ex) { - return Flux.error(ex);...
true
Other
spring-projects
spring-framework
aaa128180958d4b6d420cb7e4a955bb2edab0c0b.json
Remove Exception declaration in abstract Encoder
spring-core/src/main/java/org/springframework/core/codec/ResourceEncoder.java
@@ -64,10 +64,15 @@ public boolean canEncode(ResolvableType elementType, MimeType mimeType, Map<Stri @Override protected Flux<DataBuffer> encode(Resource resource, DataBufferFactory dataBufferFactory, - ResolvableType type, MimeType mimeType, Map<String, Object> hints) throws IOException { + ResolvableType ty...
true
Other
spring-projects
spring-framework
6cda08e94b9ba72da2334733443aefd2462c8755.json
Add Jackson @JsonView support Issue: SPR-14693
spring-web-reactive/src/main/java/org/springframework/web/reactive/config/WebReactiveConfiguration.java
@@ -60,6 +60,8 @@ import org.springframework.web.reactive.handler.AbstractHandlerMapping; import org.springframework.web.reactive.result.SimpleHandlerAdapter; import org.springframework.web.reactive.result.method.HandlerMethodArgumentResolver; +import org.springframework.http.codec.Jackson2ServerHttpMessageReader; +...
true
Other
spring-projects
spring-framework
6cda08e94b9ba72da2334733443aefd2462c8755.json
Add Jackson @JsonView support Issue: SPR-14693
spring-web-reactive/src/test/java/org/springframework/web/reactive/result/method/annotation/JacksonHintsIntegrationTests.java
@@ -0,0 +1,190 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
6cda08e94b9ba72da2334733443aefd2462c8755.json
Add Jackson @JsonView support Issue: SPR-14693
spring-web/src/main/java/org/springframework/http/codec/Jackson2ServerHttpMessageReader.java
@@ -0,0 +1,66 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
6cda08e94b9ba72da2334733443aefd2462c8755.json
Add Jackson @JsonView support Issue: SPR-14693
spring-web/src/main/java/org/springframework/http/codec/Jackson2ServerHttpMessageWriter.java
@@ -0,0 +1,66 @@ +/* + * Copyright 2002-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
2b0bf9f04a62fafd9ce28da37dbeb227b82cf462.json
Add Qualified element on RootBeanDefinition Improve RootBeanDefinition to specify an AnnotatedElement that holds qualifier information. When such element is present, any qualifier that it defines will be used to find a matching candidate. Issue: SPR-14725
spring-beans/src/main/java/org/springframework/beans/factory/annotation/QualifierAnnotationAutowireCandidateResolver.java
@@ -17,6 +17,7 @@ package org.springframework.beans.factory.annotation; import java.lang.annotation.Annotation; +import java.lang.reflect.AnnotatedElement; import java.lang.reflect.Method; import java.util.LinkedHashSet; import java.util.Map; @@ -49,6 +50,7 @@ * * @author Mark Fisher * @author Juergen Hoel...
true
Other
spring-projects
spring-framework
2b0bf9f04a62fafd9ce28da37dbeb227b82cf462.json
Add Qualified element on RootBeanDefinition Improve RootBeanDefinition to specify an AnnotatedElement that holds qualifier information. When such element is present, any qualifier that it defines will be used to find a matching candidate. Issue: SPR-14725
spring-beans/src/main/java/org/springframework/beans/factory/support/RootBeanDefinition.java
@@ -16,6 +16,7 @@ package org.springframework.beans.factory.support; +import java.lang.reflect.AnnotatedElement; import java.lang.reflect.Executable; import java.lang.reflect.Member; import java.lang.reflect.Method; @@ -58,6 +59,8 @@ public class RootBeanDefinition extends AbstractBeanDefinition { boolean i...
true
Other
spring-projects
spring-framework
2b0bf9f04a62fafd9ce28da37dbeb227b82cf462.json
Add Qualified element on RootBeanDefinition Improve RootBeanDefinition to specify an AnnotatedElement that holds qualifier information. When such element is present, any qualifier that it defines will be used to find a matching candidate. Issue: SPR-14725
spring-beans/src/test/java/org/springframework/beans/factory/annotation/AutowiredAnnotationBeanPostProcessorTests.java
@@ -63,6 +63,7 @@ import org.springframework.tests.sample.beans.IndexedTestBean; import org.springframework.tests.sample.beans.NestedTestBean; import org.springframework.tests.sample.beans.TestBean; +import org.springframework.util.ReflectionUtils; import org.springframework.util.SerializationTestUtils; import s...
true