language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
85e52e59e364034f206b02bded52ebc4dd5c51b9.json
Remove duplicate test dependency on mockito-core
build.gradle
@@ -113,7 +113,6 @@ configure(allprojects) { project -> exclude group:'org.hamcrest', module:'hamcrest-core' } testCompile("org.hamcrest:hamcrest-all:1.3") - testCompile("org.mockito:mockito-core:1.9.5") sniffer("org.codehaus.mojo:animal-sniffer-ant-tasks:${snifferVersion}") javaApiSignature("org.cod...
false
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-core/src/main/java/org/springframework/core/io/support/SpringFactoriesLoader.java
@@ -27,7 +27,7 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; -import org.springframework.core.OrderComparator; +import org.springframework.core.annotation.AnnotationAwareOrderComparator; import org.springframework.core.io.UrlResource; import org.springframework.util.Asser...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/java/org/springframework/test/context/MergedContextConfiguration.java
@@ -79,6 +79,7 @@ public class MergedContextConfiguration implements Serializable { private final String[] propertySourceProperties; private final ContextLoader contextLoader; private final CacheAwareContextLoaderDelegate cacheAwareContextLoaderDelegate; + private final MergedContextConfiguration parent; @@...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/java/org/springframework/test/context/TestContextBootstrapper.java
@@ -63,8 +63,16 @@ public interface TestContextBootstrapper { * for the test class in the {@link BootstrapContext} associated with this bootstrapper. * <p>If {@link TestExecutionListeners @TestExecutionListeners} is not * <em>present</em> on the test class in the {@code BootstrapContext}, - * <em>default</em>...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/java/org/springframework/test/context/TestExecutionListener.java
@@ -23,7 +23,13 @@ * <p>Concrete implementations must provide a {@code public} no-args constructor, * so that listeners can be instantiated transparently by tools and configuration * mechanisms. - * <p>Spring provides the following out-of-the-box implementations: + * <p>Implementations may optionally declare the ...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/java/org/springframework/test/context/jdbc/SqlScriptsTestExecutionListener.java
@@ -89,6 +89,14 @@ public class SqlScriptsTestExecutionListener extends AbstractTestExecutionListen private static final Log logger = LogFactory.getLog(SqlScriptsTestExecutionListener.class); + /** + * Returns {@code 5000}. + */ + @Override + public final int getOrder() { + return 5000; + } + /** * Execut...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/java/org/springframework/test/context/support/AbstractTestContextBootstrapper.java
@@ -31,7 +31,9 @@ import org.springframework.context.ApplicationContextInitializer; import org.springframework.context.ConfigurableApplicationContext; import org.springframework.core.annotation.AnnotationAttributes; +import org.springframework.core.annotation.AnnotationAwareOrderComparator; import org.springframewo...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/java/org/springframework/test/context/support/AbstractTestExecutionListener.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2012 the original author or authors. + * Copyright 2002-2014 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,6 +16,7 @@ package org.springframewor...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/java/org/springframework/test/context/support/DefaultTestContextBootstrapper.java
@@ -16,60 +16,19 @@ package org.springframework.test.context.support; -import java.util.Arrays; -import java.util.Collections; -import java.util.List; -import java.util.Set; - -import org.springframework.context.ApplicationContextInitializer; -import org.springframework.context.ConfigurableApplicationContext; -imp...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/java/org/springframework/test/context/support/DependencyInjectionTestExecutionListener.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2012 the original author or authors. + * Copyright 2002-2014 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -18,7 +18,6 @@ import org.apache.commons....
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/java/org/springframework/test/context/support/DirtiesContextTestExecutionListener.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2013 the original author or authors. + * Copyright 2002-2014 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -48,20 +48,11 @@ public class DirtiesContext...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/java/org/springframework/test/context/transaction/TransactionalTestExecutionListener.java
@@ -144,6 +144,14 @@ public class TransactionalTestExecutionListener extends AbstractTestExecutionLis private TransactionConfigurationAttributes configurationAttributes; + /** + * Returns {@code 4000}. + */ + @Override + public final int getOrder() { + return 4000; + } + /** * If the test method of the su...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/java/org/springframework/test/context/web/ServletTestExecutionListener.java
@@ -87,6 +87,14 @@ public class ServletTestExecutionListener extends AbstractTestExecutionListener private static final Log logger = LogFactory.getLog(ServletTestExecutionListener.class); + /** + * Returns {@code 1000}. + */ + @Override + public final int getOrder() { + return 1000; + } + /** * Sets up th...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/java/org/springframework/test/context/web/WebMergedContextConfiguration.java
@@ -84,8 +84,7 @@ public WebMergedContextConfiguration( String[] activeProfiles, String resourceBasePath, ContextLoader contextLoader) { this(testClass, locations, classes, contextInitializerClasses, activeProfiles, null, null, resourceBasePath, - contextLoader, - null, null); + contextLoader, null, null...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/java/org/springframework/test/context/web/WebTestContextBootstrapper.java
@@ -16,53 +16,28 @@ package org.springframework.test.context.web; -import java.util.ArrayList; -import java.util.Collections; -import java.util.List; -import java.util.Set; - -import org.springframework.context.ApplicationContextInitializer; -import org.springframework.context.ConfigurableApplicationContext; impo...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/main/resources/META-INF/spring.factories
@@ -0,0 +1,8 @@ +# Default TestExecutionListeners for the Spring TestContext Framework +# +org.springframework.test.context.TestExecutionListener = \ + org.springframework.test.context.web.ServletTestExecutionListener,\ + org.springframework.test.context.support.DependencyInjectionTestExecutionListener,\ + org.sprin...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/test/java/org/springframework/test/context/TestExecutionListenersTests.java
@@ -45,7 +45,7 @@ public class TestExecutionListenersTests { @Test public void verifyNumDefaultListenersRegistered() throws Exception { TestContextManager testContextManager = new TestContextManager(DefaultListenersExampleTestCase.class); - assertEquals("Num registered TELs for DefaultListenersExampleTestCase."...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/test/java/org/springframework/test/context/jdbc/TransactionalSqlScriptsTests.java
@@ -16,12 +16,19 @@ package org.springframework.test.context.jdbc; +import javax.sql.DataSource; + import org.junit.FixMethodOrder; import org.junit.Test; +import org.junit.runner.RunWith; import org.junit.runners.MethodSorters; +import org.springframework.beans.factory.annotation.Autowired; +import org.springf...
true
Other
spring-projects
spring-framework
e6d16148e576fafe094c2bc1ef975c25576eeb7b.json
Support automatic discovery of default TELs Prior to this commit, there was no declarative mechanism for a custom TestExecutionListener to be registered as a default TestExecutionListener. This commit introduces support for discovering default TestExecutionListener implementations via the SpringFactoriesLoader mechan...
spring-test/src/test/resources/META-INF/spring.factories
@@ -0,0 +1,2 @@ +# Test configuration file containing a non-existent default TestExecutionListener. +org.springframework.test.context.TestExecutionListener = org.example.FooListener
true
Other
spring-projects
spring-framework
e142fd11e08261de16f79e23081e02cab3d9f628.json
Add tests for ImportSelector meta-data Issue: SPR-12059
spring-context/src/test/java/org/springframework/context/annotation/ImportSelectorTests.java
@@ -20,7 +20,11 @@ import java.lang.annotation.Retention; import java.lang.annotation.RetentionPolicy; import java.lang.annotation.Target; +import java.util.HashMap; +import java.util.Map; +import org.hamcrest.Matcher; +import org.junit.BeforeClass; import org.junit.Test; import org.mockito.InOrder; import org....
false
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/main/java/org/springframework/test/context/ContextConfiguration.java
@@ -53,22 +53,19 @@ * The term <em>annotated class</em> can refer to any of the following. * * <ul> - * <li>A class annotated with @{@link org.springframework.context.annotation.Configuration - * Configuration}</li> + * <li>A class annotated with {@link org.springframework.context.annotation.Configuration @Config...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/main/java/org/springframework/test/context/MergedContextConfiguration.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2013 the original author or authors. + * Copyright 2002-2014 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -34,15 +34,17 @@ /** * {@code MergedConte...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/main/java/org/springframework/test/context/TestPropertySource.java
@@ -0,0 +1,250 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/main/java/org/springframework/test/context/support/AbstractContextLoader.java
@@ -16,8 +16,13 @@ package org.springframework.test.context.support; +import java.io.IOException; +import java.io.StringReader; import java.util.ArrayList; +import java.util.HashMap; import java.util.List; +import java.util.Map; +import java.util.Properties; import java.util.Set; import org.apache.commons.lo...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/main/java/org/springframework/test/context/support/AbstractTestContextBootstrapper.java
@@ -26,7 +26,6 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; - import org.springframework.beans.BeanInstantiationException; import org.springframework.beans.BeanUtils; import org.springframework.context.ApplicationContextInitializer; @@ -100,13 +99,14 @@ public final Lis...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/main/java/org/springframework/test/context/support/DefaultTestContextBootstrapper.java
@@ -81,16 +81,19 @@ protected Class<? extends ContextLoader> getDefaultContextLoaderClass(Class<?> t /** * Builds a standard {@link MergedContextConfiguration}. */ + @Override protected MergedContextConfiguration buildMergedContextConfiguration( Class<?> testClass, String[] locations, Class<?>[] c...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/main/java/org/springframework/test/context/support/MergedTestPropertySources.java
@@ -0,0 +1,78 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/main/java/org/springframework/test/context/support/TestPropertySourceAttributes.java
@@ -0,0 +1,209 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/main/java/org/springframework/test/context/support/TestPropertySourceUtils.java
@@ -0,0 +1,133 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/main/java/org/springframework/test/context/web/WebMergedContextConfiguration.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2013 the original author or authors. + * Copyright 2002-2014 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -60,16 +60,9 @@ public class WebMergedContex...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/main/java/org/springframework/test/context/web/WebTestContextBootstrapper.java
@@ -89,20 +89,23 @@ protected MergedContextConfiguration buildMergedContextConfiguration( String[] locations, Class<?>[] classes, Set<Class<? extends ApplicationContextInitializer<? extends ConfigurableApplicationContext>>> initializerClasses, - String[] activeProfiles, ContextLoader contextLoader, - Ca...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/ApplicationPropertyOverridePropertiesFileTestPropertySourceTests.java
@@ -0,0 +1,64 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/ApplicationPropertyOverridePropertiesFileTestPropertySourceTests.properties
@@ -0,0 +1 @@ +explicit = test override \ No newline at end of file
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/DefaultPropertiesFileDetectionTestPropertySourceTests.java
@@ -0,0 +1,64 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/DefaultPropertiesFileDetectionTestPropertySourceTests.properties
@@ -0,0 +1 @@ +riddle = auto detected \ No newline at end of file
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/ExplicitPropertiesFileTestPropertySourceTests.java
@@ -0,0 +1,61 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/ExtendedDefaultPropertiesFileDetectionTestPropertySourceTests.java
@@ -0,0 +1,41 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/ExtendedDefaultPropertiesFileDetectionTestPropertySourceTests.properties
@@ -0,0 +1 @@ +enigma = auto detected \ No newline at end of file
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/InheritedRelativePathPropertiesFileTestPropertySourceTests.java
@@ -0,0 +1,34 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/InlinedPropertiesTestPropertySourceTests.java
@@ -0,0 +1,60 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/MergedPropertiesFilesOverriddenByInlinedPropertiesTestPropertySourceTests.java
@@ -0,0 +1,48 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/MergedPropertiesFilesTestPropertySourceTests.java
@@ -0,0 +1,40 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/SystemPropertyOverridePropertiesFileTestPropertySourceTests.java
@@ -0,0 +1,74 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/SystemPropertyOverridePropertiesFileTestPropertySourceTests.properties
@@ -0,0 +1 @@ +SystemPropertyOverridePropertiesFileTestPropertySourceTests.riddle = enigma \ No newline at end of file
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/explicit.properties
@@ -0,0 +1 @@ +explicit = enigma \ No newline at end of file
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/extended.properties
@@ -0,0 +1 @@ +extended = 42 \ No newline at end of file
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/env/subpackage/SubpackageInheritedRelativePathPropertiesFileTestPropertySourceTests.java
@@ -0,0 +1,35 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/support/TestPropertySourceUtilsTests.java
@@ -0,0 +1,157 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + ...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/web/AnnotationConfigWebContextLoaderTests.java
@@ -38,6 +38,7 @@ public class AnnotationConfigWebContextLoaderTests { @Test + @SuppressWarnings("deprecation") public void configMustNotContainLocations() throws Exception { expectedException.expect(IllegalStateException.class); expectedException.expectMessage(containsString("does not support resource lo...
true
Other
spring-projects
spring-framework
2cf4147ba81503a45922dc38444b6874f7ba6221.json
Introduce @TestPropertySource support in the TCF Spring Framework 3.1 introduced an Environment abstraction with support for hierarchical PropertySources that can be configured programmatically as well as declaratively via the @PropertySource annotation. However, prior to this commit, there was no way to declaratively...
spring-test/src/test/java/org/springframework/test/context/web/GenericXmlWebContextLoaderTests.java
@@ -37,6 +37,7 @@ public class GenericXmlWebContextLoaderTests { @Test + @SuppressWarnings("deprecation") public void configMustNotContainAnnotatedClasses() throws Exception { expectedException.expect(IllegalStateException.class); expectedException.expectMessage(containsString("does not support annotated ...
true
Other
spring-projects
spring-framework
887815f4fa15adf2ffea61c321783b54e100b924.json
Update docbook dependency and generate epub Issue: SPR-11167
build.gradle
@@ -5,7 +5,7 @@ buildscript { dependencies { classpath("org.springframework.build.gradle:propdeps-plugin:0.0.7") classpath("org.asciidoctor:asciidoctor-gradle-plugin:0.7.0") - classpath("org.springframework.build.gradle:docbook-reference-plugin:0.2.8") + classpath("io.spring.gradle:docbook-reference-plugin:0....
false
Other
spring-projects
spring-framework
f1f1c4c9803f1f7ebf9f78fd516e25cd13f256ff.json
Remove outdated IDE, JIRA and Tomcat references Issue: SPR-7521
src/asciidoc/index.adoc
@@ -824,11 +824,6 @@ Spring remains compatible with older versions of Java and the JDK: concretely, J and above are still fully supported. However, for newly started development projects based on Spring 4, we recommend the use of Java 7 or 8. -Note that the Java 8 bytecode level (`-target 1.8`, as required by `-sou...
false
Other
spring-projects
spring-framework
a99ef6d9b2ca77f60e2838ff20a7957254a80fc4.json
Extend websocket scope to event publication This change extends the "websocket" scope to ApplicationContext events published from StompSubProtocolHandler. This however will only work with ApplicationEventMulticaster that multicasts events in the same thread. Issue: SPR-12172
spring-websocket/src/main/java/org/springframework/web/socket/messaging/StompSubProtocolHandler.java
@@ -228,24 +228,26 @@ public void handleMessageFromClient(WebSocketSession session, headerAccessor.setUser(session.getPrincipal()); headerAccessor.setImmutable(); - if (this.eventPublisher != null) { - if (StompCommand.CONNECT.equals(headerAccessor.getCommand())) { - this.stats.incrementConnectC...
false
Other
spring-projects
spring-framework
e71fbb9f46cd3bd49b68ef30a156bc0715bd979e.json
Implement containsProperty on MapPropertySource Improve the performance of MapPropertySource by directly implementing the containsProperty property. Issue: SPR-12224
spring-core/src/main/java/org/springframework/core/env/MapPropertySource.java
@@ -18,6 +18,7 @@ import java.util.Map; +import org.springframework.util.Assert; import org.springframework.util.StringUtils; /** @@ -43,4 +44,15 @@ public String[] getPropertyNames() { return StringUtils.toStringArray(this.source.keySet()); } + @Override + public boolean containsProperty(String name) {...
false
Other
spring-projects
spring-framework
2077388f383c9c57fcf9473b3def51dacea3cdf3.json
Improve JNDI detection logic Update JndiLocatorDelegate.isDefaultJndiEnvironmentAvailable() to call `getEnvironment()` on the `InitialContext` in order to actually trigger a NamingException if JNDI is not available. Issue: SPR-12223
spring-context/src/main/java/org/springframework/jndi/JndiLocatorDelegate.java
@@ -58,7 +58,7 @@ public static JndiLocatorDelegate createDefaultResourceRefLocator() { */ public static boolean isDefaultJndiEnvironmentAvailable() { try { - new InitialContext(); + new InitialContext().getEnvironment(); return true; } catch (Throwable ex) {
true
Other
spring-projects
spring-framework
2077388f383c9c57fcf9473b3def51dacea3cdf3.json
Improve JNDI detection logic Update JndiLocatorDelegate.isDefaultJndiEnvironmentAvailable() to call `getEnvironment()` on the `InitialContext` in order to actually trigger a NamingException if JNDI is not available. Issue: SPR-12223
spring-context/src/test/java/org/springframework/jndi/JndiLocatorDelegateTests.java
@@ -0,0 +1,37 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
4af98515853ad7e20eb90cacfaef8aecb1a81862.json
Add user to DISCONNECT in StompSubProtocolHandler Issue: SPR-12215
spring-websocket/src/main/java/org/springframework/web/socket/messaging/StompSubProtocolHandler.java
@@ -469,6 +469,7 @@ private Message<?> createDisconnectMessage(WebSocketSession session) { } headerAccessor.setSessionId(session.getId()); headerAccessor.setSessionAttributes(session.getAttributes()); + headerAccessor.setUser(session.getPrincipal()); return MessageBuilder.createMessage(EMPTY_PAYLOAD, heade...
true
Other
spring-projects
spring-framework
4af98515853ad7e20eb90cacfaef8aecb1a81862.json
Add user to DISCONNECT in StompSubProtocolHandler Issue: SPR-12215
spring-websocket/src/test/java/org/springframework/web/socket/messaging/StompSubProtocolHandlerTests.java
@@ -207,13 +207,7 @@ public void eventPublication() { @Test public void eventPublicationWithExceptions() { - ApplicationEventPublisher publisher = new ApplicationEventPublisher() { - - @Override - public void publishEvent(ApplicationEvent event) { - throw new IllegalStateException(); - } - }; + Applic...
true
Other
spring-projects
spring-framework
70b5f319a956d2d6a89ac316c51e566a93856468.json
Support @Ordering of Conditions Update ConditionEvaluator to collect then sort Conditions before evaluation. By annotating Conditions with @Ordered expensive operations can be pushed to the back of the queue. Issue: SPR-12219
spring-context/src/main/java/org/springframework/context/annotation/ConditionEvaluator.java
@@ -16,6 +16,7 @@ package org.springframework.context.annotation; +import java.util.ArrayList; import java.util.Collections; import java.util.List; @@ -24,6 +25,7 @@ import org.springframework.beans.factory.support.BeanDefinitionRegistry; import org.springframework.context.ConfigurableApplicationContext; im...
false
Other
spring-projects
spring-framework
49b872e387cf698de653dffa1b268c0950c0c23f.json
Adjust logging following SockJS client disconnect Issue: SPR-11870
spring-websocket/src/main/java/org/springframework/web/socket/sockjs/transport/session/AbstractSockJsSession.java
@@ -82,9 +82,9 @@ public abstract class AbstractSockJsSession implements SockJsSession { private static final Set<String> disconnectedClientExceptions; static { - Set<String> set = new HashSet<String>(2); set.add("ClientAbortException"); // Tomcat + set.add("EOFException"); // Tomcat set.add("EofExcepti...
false
Other
spring-projects
spring-framework
d85c1fbdd5edb6b2ba906f8a20009317ff7faa98.json
Fix initialization issue in ResourceUrlProvider Before this change ResourceUrlProvider used getUrlMap to detect ResourceHttpRequestHandler instances, however the map may contain bean names as is the case when using <mvc:resources>. Instead it now uses getHandlerMap.
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceUrlProvider.java
@@ -143,8 +143,8 @@ protected void detectResourceHandlers(ApplicationContext appContext) { Collections.sort(handlerMappings, new OrderComparator()); for (SimpleUrlHandlerMapping hm : handlerMappings) { - for (String pattern : hm.getUrlMap().keySet()) { - Object handler = hm.getUrlMap().get(pattern); + fo...
false
Other
spring-projects
spring-framework
125ae99035653496efbf6d03270bbbdde5828d3a.json
Transform absolute links in ResourceTransformers Prior to this change, ResourceTransformers that transformed resources by updating the links to other resources, worked only if links were relative to the resource being transformed. For example, when the CssLinkResourceTransformer rewrote links within a "main.css" resou...
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/AppCacheManifestTransformer.java
@@ -58,7 +58,7 @@ * applications spec</a> * @since 4.1 */ -public class AppCacheManifestTransformer implements ResourceTransformer { +public class AppCacheManifestTransformer extends ResourceTransformerSupport { private static final String MANIFEST_HEADER = "CACHE MANIFEST"; @@ -129,7 +129,7 @@ public Resou...
true
Other
spring-projects
spring-framework
125ae99035653496efbf6d03270bbbdde5828d3a.json
Transform absolute links in ResourceTransformers Prior to this change, ResourceTransformers that transformed resources by updating the links to other resources, worked only if links were relative to the resource being transformed. For example, when the CssLinkResourceTransformer rewrote links within a "main.css" resou...
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/CssLinkResourceTransformer.java
@@ -27,7 +27,6 @@ import java.io.StringWriter; import java.nio.charset.Charset; import java.util.ArrayList; -import java.util.Arrays; import java.util.Collections; import java.util.HashSet; import java.util.List; @@ -47,7 +46,7 @@ * @author Rossen Stoyanchev * @since 4.1 */ -public class CssLinkResourceTran...
true
Other
spring-projects
spring-framework
125ae99035653496efbf6d03270bbbdde5828d3a.json
Transform absolute links in ResourceTransformers Prior to this change, ResourceTransformers that transformed resources by updating the links to other resources, worked only if links were relative to the resource being transformed. For example, when the CssLinkResourceTransformer rewrote links within a "main.css" resou...
spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceTransformerSupport.java
@@ -0,0 +1,98 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
125ae99035653496efbf6d03270bbbdde5828d3a.json
Transform absolute links in ResourceTransformers Prior to this change, ResourceTransformers that transformed resources by updating the links to other resources, worked only if links were relative to the resource being transformed. For example, when the CssLinkResourceTransformer rewrote links within a "main.css" resou...
spring-webmvc/src/test/java/org/springframework/web/servlet/resource/LinkRewriteTransformerTests.java
@@ -0,0 +1,127 @@ +/* + * Copyright 2002-2014 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + ...
true
Other
spring-projects
spring-framework
06f1f495c26bf2e6100c29fdf0c3cd6d19fa8240.json
Update reference documentation for JSONP support Issue: SPR-12113
src/asciidoc/index.adoc
@@ -1063,7 +1063,8 @@ method has been added. summary vs. detail page). This is also supported with View-based rendering by adding the serialization view type as a model attribute under a special key. See <<mvc-ann-jsonview>> for details. -* JSONP is now supported with Jackson. +* JSONP is now supported with Ja...
false
Other
spring-projects
spring-framework
51a550b27b643424c06af26fa66d6b4c40607499.json
Add mention of ResponseBodyAdvice
src/asciidoc/index.adoc
@@ -1068,6 +1068,7 @@ method has been added. methods just after the controller method returns and before the response is written. To take advantage declare an `@ControllerAdvice` bean that implements `ResponseBodyAdvice`. The built-in support for `@JsonView` and JSONP take advantage of this. + See <<mvc-handl...
false
Other
spring-projects
spring-framework
e81862eed6438c1acf1ecaf6f6d554e31300fb56.json
Allow modifying HandshakeInterceptor list The getter in TransportHandlingSockJsService now returns a mutable List. The immutable wrapper doesn't make sense since it's possible anyway to modify the list by creating a new list and calling the setter again. It's also consistent with the same field on WebSocketHttpRequest...
spring-websocket/src/main/java/org/springframework/web/socket/sockjs/transport/TransportHandlingSockJsService.java
@@ -146,7 +146,7 @@ public void setHandshakeInterceptors(List<HandshakeInterceptor> interceptors) { * Return the configured WebSocket handshake request interceptors. */ public List<HandshakeInterceptor> getHandshakeInterceptors() { - return Collections.unmodifiableList(this.interceptors); + return this.interc...
false
Other
spring-projects
spring-framework
7f845f7b5e6031aee2f1dc37f0965a5be4442a34.json
Fix failing HeaderAssertionTests Since SPR-11792, Last-Modified and ETag headers are also written in `HTTP 304 Not Modified` responses. This is expected as per https://tools.ietf.org/html/rfc7232#section-4.1 . Those tests expected "Last-Modified" to be missing in case of HTTP 304 responses, which is not the case anym...
spring-test/src/test/java/org/springframework/test/web/servlet/samples/standalone/resultmatchers/HeaderAssertionTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2013 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -84,30 +84,30 @@ public void longValueWithCo...
false
Other
spring-projects
spring-framework
953608ec49dea6dfdf1e0a2626839e84df909b69.json
Improve ETag & Last-Modifed support in WebRequest This change improves the following use cases with `WebRequest.checkNotModified(String etag)` and `WebRequest.checkNotModified(long lastModifiedTimeStamp)`: 1) Allow weak comparisons for ETags Per rfc7232 section-2.3, ETags can be strong or weak; this change allows co...
spring-web/src/main/java/org/springframework/web/context/request/FacesWebRequest.java
@@ -155,6 +155,17 @@ public boolean checkNotModified(String eTag) { return false; } + /** + * Last-modified handling not supported for portlet requests: + * As a consequence, this method always returns {@code false}. + * + * @since 4.2 + */ + @Override + public boolean checkNotModified(String etag, long las...
true
Other
spring-projects
spring-framework
953608ec49dea6dfdf1e0a2626839e84df909b69.json
Improve ETag & Last-Modifed support in WebRequest This change improves the following use cases with `WebRequest.checkNotModified(String etag)` and `WebRequest.checkNotModified(long lastModifiedTimeStamp)`: 1) Allow weak comparisons for ETags Per rfc7232 section-2.3, ETags can be strong or weak; this change allows co...
spring-web/src/main/java/org/springframework/web/context/request/ServletWebRequest.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,6 +21,7 @@ import java.util.Iterator; ...
true
Other
spring-projects
spring-framework
953608ec49dea6dfdf1e0a2626839e84df909b69.json
Improve ETag & Last-Modifed support in WebRequest This change improves the following use cases with `WebRequest.checkNotModified(String etag)` and `WebRequest.checkNotModified(long lastModifiedTimeStamp)`: 1) Allow weak comparisons for ETags Per rfc7232 section-2.3, ETags can be strong or weak; this change allows co...
spring-web/src/main/java/org/springframework/web/context/request/WebRequest.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -141,9 +141,12 @@ public interface WebReques...
true
Other
spring-projects
spring-framework
953608ec49dea6dfdf1e0a2626839e84df909b69.json
Improve ETag & Last-Modifed support in WebRequest This change improves the following use cases with `WebRequest.checkNotModified(String etag)` and `WebRequest.checkNotModified(long lastModifiedTimeStamp)`: 1) Allow weak comparisons for ETags Per rfc7232 section-2.3, ETags can be strong or weak; this change allows co...
spring-web/src/test/java/org/springframework/web/context/request/ServletWebRequestHttpMethodsTests.java
@@ -0,0 +1,258 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + ...
true
Other
spring-projects
spring-framework
953608ec49dea6dfdf1e0a2626839e84df909b69.json
Improve ETag & Last-Modifed support in WebRequest This change improves the following use cases with `WebRequest.checkNotModified(String etag)` and `WebRequest.checkNotModified(long lastModifiedTimeStamp)`: 1) Allow weak comparisons for ETags Per rfc7232 section-2.3, ETags can be strong or weak; this change allows co...
spring-web/src/test/java/org/springframework/web/context/request/ServletWebRequestTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,9 +16,11 @@ package org.springframewo...
true
Other
spring-projects
spring-framework
953608ec49dea6dfdf1e0a2626839e84df909b69.json
Improve ETag & Last-Modifed support in WebRequest This change improves the following use cases with `WebRequest.checkNotModified(String etag)` and `WebRequest.checkNotModified(long lastModifiedTimeStamp)`: 1) Allow weak comparisons for ETags Per rfc7232 section-2.3, ETags can be strong or weak; this change allows co...
spring-webmvc-portlet/src/main/java/org/springframework/web/portlet/context/PortletWebRequest.java
@@ -162,6 +162,17 @@ public boolean checkNotModified(String eTag) { return false; } + /** + * Last-modified handling not supported for portlet requests: + * As a consequence, this method always returns {@code false}. + * + * @since 4.2 + */ + @Override + public boolean checkNotModified(String etag, long las...
true
Other
spring-projects
spring-framework
9172a6d05e26a9103d0fbcc5ae1d047482319938.json
Restore proper use of CacheLoader Since Guava 11, CacheLoader is only invoked with a LoadingCache but the GuavaCache wrapper is always invoking getIfPresent(), available on the main Guava Cache interface. Update GuavaCache#get to check for the presence of a LoadingCache and call the appropriate method. Issue: SPR-12...
spring-context-support/src/main/java/org/springframework/cache/guava/GuavaCache.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -20,6 +20,9 @@ import java.util.concurrent....
true
Other
spring-projects
spring-framework
9172a6d05e26a9103d0fbcc5ae1d047482319938.json
Restore proper use of CacheLoader Since Guava 11, CacheLoader is only invoked with a LoadingCache but the GuavaCache wrapper is always invoking getIfPresent(), available on the main Guava Cache interface. Update GuavaCache#get to check for the presence of a LoadingCache and call the appropriate method. Issue: SPR-12...
spring-context-support/src/test/java/org/springframework/cache/guava/GuavaCacheManagerTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -18,7 +18,10 @@ import com.google.common....
true
Other
spring-projects
spring-framework
3d2bde7156d61e9eb3257bd9d13c3d0f6f06fa63.json
Add tests that use the new generate-name attribute This commit updates the Spr8849Tests test suite to include XML configuration that guarantees that a unique database name is always automatically generated (via the new 'generate-name' attribute that was introduced in SPR-8849) while reusing the same bean name (i.e., '...
spring-test/src/test/java/org/springframework/test/context/junit4/spr8849/Spr8849Tests.java
@@ -24,6 +24,7 @@ * Test suite to investigate claims raised in * <a href="https://jira.spring.io/browse/SPR-8849">SPR-8849</a>. * + * <h3>Work Around</h3> * <p>By using a SpEL expression to generate a random {@code database-name} * for the embedded database (see {@code datasource-config.xml}), we ensure * t...
true
Other
spring-projects
spring-framework
3d2bde7156d61e9eb3257bd9d13c3d0f6f06fa63.json
Add tests that use the new generate-name attribute This commit updates the Spr8849Tests test suite to include XML configuration that guarantees that a unique database name is always automatically generated (via the new 'generate-name' attribute that was introduced in SPR-8849) while reusing the same bean name (i.e., '...
spring-test/src/test/java/org/springframework/test/context/junit4/spr8849/TestClass3.java
@@ -0,0 +1,58 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
3d2bde7156d61e9eb3257bd9d13c3d0f6f06fa63.json
Add tests that use the new generate-name attribute This commit updates the Spr8849Tests test suite to include XML configuration that guarantees that a unique database name is always automatically generated (via the new 'generate-name' attribute that was introduced in SPR-8849) while reusing the same bean name (i.e., '...
spring-test/src/test/java/org/springframework/test/context/junit4/spr8849/TestClass4.java
@@ -0,0 +1,58 @@ +/* + * Copyright 2002-2015 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
3d2bde7156d61e9eb3257bd9d13c3d0f6f06fa63.json
Add tests that use the new generate-name attribute This commit updates the Spr8849Tests test suite to include XML configuration that guarantees that a unique database name is always automatically generated (via the new 'generate-name' attribute that was introduced in SPR-8849) while reusing the same bean name (i.e., '...
spring-test/src/test/resources/org/springframework/test/context/junit4/spr8849/datasource-config-with-auto-generated-db-name.xml
@@ -0,0 +1,12 @@ +<?xml version="1.0" encoding="UTF-8"?> +<beans xmlns="http://www.springframework.org/schema/beans" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xmlns:jdbc="http://www.springframework.org/schema/jdbc" + xsi:schemaLocation=" + http://www.springframework.org/schema/beans http://www.springfram...
true
Other
spring-projects
spring-framework
4886edd10b4df22ed4e61f24e0c11124b255687b.json
Send STOMP ERROR if external broker not available Issue: SPR-12820
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompBrokerRelayMessageHandler.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -26,6 +26,7 @@ import org.springframework.m...
true
Other
spring-projects
spring-framework
4886edd10b4df22ed4e61f24e0c11124b255687b.json
Send STOMP ERROR if external broker not available Issue: SPR-12820
spring-messaging/src/test/java/org/springframework/messaging/simp/stomp/StompBrokerRelayMessageHandlerTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -146,7 +146,7 @@ public void testDestination...
true
Other
spring-projects
spring-framework
18039785aeacc3ca76c70014b11fb30923a54941.json
Update Javadoc of AsyncHandlerInterceptor Issue: SPR-12608, SPR-12720
spring-webmvc/src/main/java/org/springframework/web/servlet/AsyncHandlerInterceptor.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2012 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -22,20 +22,34 @@ import org.springframework...
true
Other
spring-projects
spring-framework
18039785aeacc3ca76c70014b11fb30923a54941.json
Update Javadoc of AsyncHandlerInterceptor Issue: SPR-12608, SPR-12720
spring-webmvc/src/main/java/org/springframework/web/servlet/HandlerInterceptor.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -77,10 +77,16 @@ public interface HandlerInt...
true
Other
spring-projects
spring-framework
0e7eecfe348428efa9e6ab4c2cda1c83d2ca7201.json
Add copyToUriComponentsBuilder method After this change UriComponentsBuilder#uriComponents method no longer no longer copies from the given UriComponents but rather lets the UriComponents instance copy itself to the UriComponentsBuilder. This avoids the need for instanceof checks and also makes it possible to disting...
spring-web/src/main/java/org/springframework/web/util/HierarchicalUriComponents.java
@@ -417,6 +417,19 @@ public URI toUri() { } } + @Override + protected void copyToUriComponentsBuilder(UriComponentsBuilder builder) { + builder.scheme(getScheme()); + builder.userInfo(getUserInfo()); + builder.host(getHost()); + builder.port(getPort()); + builder.replacePath(""); + this.path.copyToUriCompo...
true
Other
spring-projects
spring-framework
0e7eecfe348428efa9e6ab4c2cda1c83d2ca7201.json
Add copyToUriComponentsBuilder method After this change UriComponentsBuilder#uriComponents method no longer no longer copies from the given UriComponents but rather lets the UriComponents instance copy itself to the UriComponentsBuilder. This avoids the need for instanceof checks and also makes it possible to disting...
spring-web/src/main/java/org/springframework/web/util/OpaqueUriComponents.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -135,6 +135,13 @@ public URI toUri() { } ...
true
Other
spring-projects
spring-framework
0e7eecfe348428efa9e6ab4c2cda1c83d2ca7201.json
Add copyToUriComponentsBuilder method After this change UriComponentsBuilder#uriComponents method no longer no longer copies from the given UriComponents but rather lets the UriComponents instance copy itself to the UriComponentsBuilder. This avoids the need for instanceof checks and also makes it possible to disting...
spring-web/src/main/java/org/springframework/web/util/UriComponents.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -203,6 +203,12 @@ public final String toStri...
true
Other
spring-projects
spring-framework
0e7eecfe348428efa9e6ab4c2cda1c83d2ca7201.json
Add copyToUriComponentsBuilder method After this change UriComponentsBuilder#uriComponents method no longer no longer copies from the given UriComponents but rather lets the UriComponents instance copy itself to the UriComponentsBuilder. This avoids the need for instanceof checks and also makes it possible to disting...
spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java
@@ -447,40 +447,7 @@ public UriComponentsBuilder scheme(String scheme) { */ public UriComponentsBuilder uriComponents(UriComponents uriComponents) { Assert.notNull(uriComponents, "'uriComponents' must not be null"); - this.scheme = uriComponents.getScheme(); - if (uriComponents instanceof OpaqueUriComponents)...
true
Other
spring-projects
spring-framework
0e7eecfe348428efa9e6ab4c2cda1c83d2ca7201.json
Add copyToUriComponentsBuilder method After this change UriComponentsBuilder#uriComponents method no longer no longer copies from the given UriComponents but rather lets the UriComponents instance copy itself to the UriComponentsBuilder. This avoids the need for instanceof checks and also makes it possible to disting...
spring-web/src/test/java/org/springframework/web/util/UriComponentsBuilderTests.java
@@ -436,6 +436,15 @@ public void fromHttpRequestWithForwardedProtoMultiValueHeader() { assertEquals("https://a.example.org/mvc-showcase", result.toString()); } + // SPR-12742 + + @Test + public void fromHttpRequestWithTrailingSlash() throws Exception { + UriComponents before = UriComponentsBuilder.fromPath("/fo...
true
Other
spring-projects
spring-framework
0e7eecfe348428efa9e6ab4c2cda1c83d2ca7201.json
Add copyToUriComponentsBuilder method After this change UriComponentsBuilder#uriComponents method no longer no longer copies from the given UriComponents but rather lets the UriComponents instance copy itself to the UriComponentsBuilder. This avoids the need for instanceof checks and also makes it possible to disting...
spring-web/src/test/java/org/springframework/web/util/UriComponentsTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -22,6 +22,7 @@ import java.io.ObjectOutputS...
true
Other
spring-projects
spring-framework
83ff0adc2ece396b21561c3a76c47d2413a818c8.json
Add accessors for expirationTime in FlashMap FlashMap now has a single field reflecting the expiration time and also provides accessors that can be used for serialization purposes. Issue: SPR-12757
spring-webmvc/src/main/java/org/springframework/web/servlet/FlashMap.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -23,6 +23,7 @@ import org.springframework.u...
false
Other
spring-projects
spring-framework
de9c9febc385fe07809f634cef7933b632e7141f.json
Compare encoded params in AbstractFlashMapManager AbstractFlashMapManager no longer decodes the target query parameters it needs to use to match to the request after the redirect. Instead it stores query parameters as-is adn then relies on parsing the encoded query string after the redirect. Issue: SPR-12569
spring-webmvc/src/main/java/org/springframework/web/servlet/support/AbstractFlashMapManager.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,11 +16,11 @@ package org.springframew...
true
Other
spring-projects
spring-framework
de9c9febc385fe07809f634cef7933b632e7141f.json
Compare encoded params in AbstractFlashMapManager AbstractFlashMapManager no longer decodes the target query parameters it needs to use to match to the request after the redirect. Instead it stores query parameters as-is adn then relies on parsing the encoded query string after the redirect. Issue: SPR-12569
spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ServletAnnotationControllerHandlerMethodTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2014 the original author or authors. + * Copyright 2002-2015 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,6 +16,8 @@ package org.springframewor...
true
Other
spring-projects
spring-framework
de9c9febc385fe07809f634cef7933b632e7141f.json
Compare encoded params in AbstractFlashMapManager AbstractFlashMapManager no longer decodes the target query parameters it needs to use to match to the request after the redirect. Instead it stores query parameters as-is adn then relies on parsing the encoded query string after the redirect. Issue: SPR-12569
spring-webmvc/src/test/java/org/springframework/web/servlet/support/FlashMapManagerTests.java
@@ -18,6 +18,7 @@ import static org.junit.Assert.*; +import java.net.URLEncoder; import java.util.ArrayList; import java.util.Arrays; import java.util.List; @@ -31,7 +32,6 @@ import org.springframework.mock.web.test.MockHttpServletRequest; import org.springframework.mock.web.test.MockHttpServletResponse; -i...
true
Other
spring-projects
spring-framework
bf0703e07e2c968c6d777101c10b01f4f4650a91.json
Delete unused imports in spring-messaging
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/Reactor11TcpStompClient.java
@@ -31,7 +31,6 @@ import org.springframework.messaging.tcp.TcpOperations; import org.springframework.messaging.tcp.reactor.Reactor11TcpClient; import org.springframework.util.concurrent.ListenableFuture; -import org.springframework.util.concurrent.SettableListenableFuture; /** * A STOMP over TCP client that use...
true
Other
spring-projects
spring-framework
bf0703e07e2c968c6d777101c10b01f4f4650a91.json
Delete unused imports in spring-messaging
spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompHeaders.java
@@ -16,7 +16,6 @@ package org.springframework.messaging.simp.stomp; import java.io.Serializable; -import java.util.Arrays; import java.util.Collection; import java.util.Collections; import java.util.LinkedHashMap;
true
Other
spring-projects
spring-framework
bf0703e07e2c968c6d777101c10b01f4f4650a91.json
Delete unused imports in spring-messaging
spring-messaging/src/test/java/org/springframework/messaging/simp/broker/DefaultSubscriptionRegistryTests.java
@@ -331,6 +331,7 @@ public void findSubscriptionsNoMatches() { // SPR-12665 @Test + @SuppressWarnings("rawtypes") public void findSubscriptionsReturnsMapSafeToIterate() throws Exception { this.registry.registerSubscription(subscribeMessage("sess1", "1", "/foo")); this.registry.registerSubscription(subscri...
true
Other
spring-projects
spring-framework
bf0703e07e2c968c6d777101c10b01f4f4650a91.json
Delete unused imports in spring-messaging
spring-messaging/src/test/java/org/springframework/messaging/simp/stomp/DefaultStompSessionTests.java
@@ -20,7 +20,6 @@ import static org.mockito.Matchers.any; import static org.mockito.Mockito.eq; import static org.mockito.Mockito.*; -import static org.mockito.Mockito.same; import java.nio.charset.Charset; import java.util.Date; @@ -539,8 +538,8 @@ public void receiptReceivedBeforeTaskAdded() throws Exception {...
true
Other
spring-projects
spring-framework
bf0703e07e2c968c6d777101c10b01f4f4650a91.json
Delete unused imports in spring-messaging
spring-messaging/src/test/java/org/springframework/messaging/simp/stomp/StompClientSupportTests.java
@@ -15,15 +15,10 @@ */ package org.springframework.messaging.simp.stomp; -import static org.junit.Assert.*; -import static org.mockito.Matchers.same; - import org.junit.Before; -import org.junit.Rule; import org.junit.Test; -import org.junit.rules.ExpectedException; -import org.mockito.MockitoAnnotations; +imp...
true