language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/main/java/org/springframework/messaging/simp/broker/AbstractSubscriptionRegistry.java | @@ -24,6 +24,10 @@
import org.springframework.util.MultiValueMap;
/**
+ * Abstract base class for implementations of {@link SubscriptionRegistry} that
+ * looks up information in messages but delegates to abstract methods for the
+ * actual storage and retrieval.
+ *
* @author Rossen Stoyanchev
* @since 4.0
*... | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/main/java/org/springframework/messaging/simp/broker/DefaultSubscriptionRegistry.java | @@ -31,6 +31,8 @@
import org.springframework.util.MultiValueMap;
/**
+ * A default, simple in-memory implementation of {@link SubscriptionRegistry}.
+ *
* @author Rossen Stoyanchev
* @since 4.0
*/ | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/main/java/org/springframework/messaging/simp/config/AbstractMessageBrokerConfiguration.java | @@ -30,12 +30,12 @@
import org.springframework.messaging.simp.SimpMessagingTemplate;
import org.springframework.messaging.simp.annotation.support.SimpAnnotationMethodMessageHandler;
import org.springframework.messaging.simp.broker.AbstractBrokerMessageHandler;
-import org.springframework.messaging.simp.handler.Defau... | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/main/java/org/springframework/messaging/simp/package-info.java | @@ -1,4 +1,4 @@
/**
- * Generic support for SImple Messaging Protocols such as STOMP.
+ * Generic support for SImple Messaging Protocols including protocols such as STOMP.
*/
package org.springframework.messaging.simp; | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/main/java/org/springframework/messaging/simp/user/DefaultUserDestinationResolver.java | @@ -14,7 +14,7 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.user;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/main/java/org/springframework/messaging/simp/user/DefaultUserSessionRegistry.java | @@ -14,7 +14,7 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.user;
import org.springframework.util.Assert;
| true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/main/java/org/springframework/messaging/simp/user/UserDestinationMessageHandler.java | @@ -14,7 +14,7 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.user;
import java.util.Set;
| true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/main/java/org/springframework/messaging/simp/user/UserDestinationResolver.java | @@ -14,7 +14,7 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.user;
import org.springframework.messaging.Message;
| true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/main/java/org/springframework/messaging/simp/user/UserSessionRegistry.java | @@ -1,4 +1,4 @@
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.user;
import java.util.Set;
| true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/main/java/org/springframework/messaging/simp/user/package-info.java | @@ -0,0 +1,9 @@
+/**
+ * Support for handling messages to "user" destinations (i.e. destinations that are
+ * unique to a user's sessions), primarily translating the destinations and then
+ * forwarding the updated message to the broker.
+ * <p>
+ * Also included is {@link org.springframework.messaging.simp.user.UserSe... | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/test/java/org/springframework/messaging/simp/annotation/support/SimpAnnotationMethodMessageHandlerTests.java | @@ -14,7 +14,7 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.annotation.support;
import java.util.LinkedHashMap;
import java.util.Map; | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/test/java/org/springframework/messaging/simp/config/MessageBrokerConfigurationTests.java | @@ -35,8 +35,8 @@
import org.springframework.messaging.simp.annotation.SubscribeMapping;
import org.springframework.messaging.simp.annotation.support.SimpAnnotationMethodMessageHandler;
import org.springframework.messaging.simp.broker.SimpleBrokerMessageHandler;
-import org.springframework.messaging.simp.handler.Use... | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/test/java/org/springframework/messaging/simp/user/DefaultUserDestinationResolverTests.java | @@ -14,22 +14,25 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.user;
import org.junit.Before;
import org.junit.Test;
import org.springframework.messaging.Message;
import org.springframework.messaging.simp.SimpMessageHe... | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/test/java/org/springframework/messaging/simp/user/DefaultUserSessionRegistryTests.java | @@ -14,19 +14,20 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.user;
import java.util.Arrays;
import java.util.Collections;
import java.util.LinkedHashSet;
import java.util.List;
import org.junit.Test;
+import org.s... | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-messaging/src/test/java/org/springframework/messaging/simp/user/UserDestinationMessageHandlerTests.java | @@ -14,7 +14,7 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.user;
import org.junit.Before;
import org.junit.Test;
@@ -28,13 +28,17 @@
import org.springframework.messaging.simp.SimpMessageHeaderAccessor;
import org.spr... | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-websocket/src/main/java/org/springframework/web/socket/config/MessageBrokerBeanDefinitionParser.java | @@ -39,10 +39,10 @@
import org.springframework.messaging.converter.StringMessageConverter;
import org.springframework.messaging.simp.SimpMessagingTemplate;
import org.springframework.messaging.simp.annotation.support.SimpAnnotationMethodMessageHandler;
-import org.springframework.messaging.simp.handler.DefaultUserDe... | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-websocket/src/main/java/org/springframework/web/socket/config/annotation/WebMvcStompEndpointRegistry.java | @@ -21,7 +21,7 @@
import java.util.List;
import java.util.Map;
-import org.springframework.messaging.simp.handler.UserSessionRegistry;
+import org.springframework.messaging.simp.user.UserSessionRegistry;
import org.springframework.scheduling.TaskScheduler;
import org.springframework.util.Assert;
import org.sprin... | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-websocket/src/main/java/org/springframework/web/socket/messaging/StompSubProtocolHandler.java | @@ -29,7 +29,7 @@
import org.springframework.messaging.Message;
import org.springframework.messaging.MessageChannel;
import org.springframework.messaging.simp.SimpMessageType;
-import org.springframework.messaging.simp.handler.UserSessionRegistry;
+import org.springframework.messaging.simp.user.UserSessionRegistry;
... | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-websocket/src/test/java/org/springframework/web/socket/config/MessageBrokerBeanDefinitionParserTests.java | @@ -31,11 +31,11 @@
import org.springframework.messaging.converter.MessageConverter;
import org.springframework.messaging.simp.SimpMessagingTemplate;
import org.springframework.messaging.simp.annotation.support.SimpAnnotationMethodMessageHandler;
-import org.springframework.messaging.simp.handler.DefaultUserDestinat... | true |
Other | spring-projects | spring-framework | 307bf4bede299bdc95a99f68ae51fd076d5cdca9.json | Add messaging.simp.user package | spring-websocket/src/test/java/org/springframework/web/socket/config/annotation/WebMvcStompEndpointRegistryTests.java | @@ -24,11 +24,10 @@
import org.springframework.messaging.MessageChannel;
import org.springframework.messaging.SubscribableChannel;
-import org.springframework.messaging.simp.handler.DefaultUserSessionRegistry;
-import org.springframework.messaging.simp.handler.UserSessionRegistry;
+import org.springframework.messag... | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/main/java/org/springframework/messaging/simp/broker/AbstractBrokerMessageHandler.java | @@ -14,7 +14,7 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.broker;
import java.util.Collection;
import java.util.Collections;
@@ -32,6 +32,9 @@
import org.springframework.util.CollectionUtils;
/**
+ * Abstract base... | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/main/java/org/springframework/messaging/simp/broker/AbstractSubscriptionRegistry.java | @@ -14,7 +14,7 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.broker;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory; | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/main/java/org/springframework/messaging/simp/broker/DefaultSubscriptionRegistry.java | @@ -14,7 +14,7 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.broker;
import java.util.Collection;
import java.util.HashSet; | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/main/java/org/springframework/messaging/simp/broker/SimpleBrokerMessageHandler.java | @@ -14,7 +14,7 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.broker;
import java.util.Collection;
@@ -28,6 +28,10 @@
import org.springframework.util.MultiValueMap;
/**
+ * A "simple" message broker that recognizes t... | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/main/java/org/springframework/messaging/simp/broker/SubscriptionRegistry.java | @@ -14,7 +14,7 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.broker;
import org.springframework.messaging.Message;
import org.springframework.util.MultiValueMap; | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/main/java/org/springframework/messaging/simp/broker/package-info.java | @@ -0,0 +1,5 @@
+/**
+ * Provides a "simple" message broker implementation along with an abstract base
+ * class and other supporting types such as a registry for subscriptions.
+ */
+package org.springframework.messaging.simp.broker; | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/main/java/org/springframework/messaging/simp/config/AbstractBrokerRegistration.java | @@ -23,7 +23,7 @@
import org.springframework.messaging.MessageChannel;
import org.springframework.messaging.SubscribableChannel;
-import org.springframework.messaging.simp.handler.AbstractBrokerMessageHandler;
+import org.springframework.messaging.simp.broker.AbstractBrokerMessageHandler;
import org.springframewor... | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/main/java/org/springframework/messaging/simp/config/AbstractMessageBrokerConfiguration.java | @@ -29,10 +29,10 @@
import org.springframework.messaging.converter.StringMessageConverter;
import org.springframework.messaging.simp.SimpMessagingTemplate;
import org.springframework.messaging.simp.annotation.support.SimpAnnotationMethodMessageHandler;
-import org.springframework.messaging.simp.handler.AbstractBroke... | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/main/java/org/springframework/messaging/simp/config/MessageBrokerRegistry.java | @@ -21,7 +21,7 @@
import org.springframework.messaging.MessageChannel;
import org.springframework.messaging.SubscribableChannel;
-import org.springframework.messaging.simp.handler.SimpleBrokerMessageHandler;
+import org.springframework.messaging.simp.broker.SimpleBrokerMessageHandler;
import org.springframework.me... | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/main/java/org/springframework/messaging/simp/config/SimpleBrokerRegistration.java | @@ -18,7 +18,7 @@
import org.springframework.messaging.MessageChannel;
import org.springframework.messaging.SubscribableChannel;
-import org.springframework.messaging.simp.handler.SimpleBrokerMessageHandler;
+import org.springframework.messaging.simp.broker.SimpleBrokerMessageHandler;
/**
* Registration class ... | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompBrokerRelayMessageHandler.java | @@ -27,7 +27,7 @@
import org.springframework.messaging.SubscribableChannel;
import org.springframework.messaging.simp.SimpMessageHeaderAccessor;
import org.springframework.messaging.simp.SimpMessageType;
-import org.springframework.messaging.simp.handler.AbstractBrokerMessageHandler;
+import org.springframework.mess... | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/test/java/org/springframework/messaging/simp/broker/DefaultSubscriptionRegistryTests.java | @@ -14,7 +14,7 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.broker;
import java.util.Arrays;
import java.util.Collections;
@@ -25,13 +25,14 @@
import org.springframework.messaging.Message;
import org.springframework.m... | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/test/java/org/springframework/messaging/simp/broker/SimpleBrokerMessageHandlerTests.java | @@ -14,7 +14,7 @@
* limitations under the License.
*/
-package org.springframework.messaging.simp.handler;
+package org.springframework.messaging.simp.broker;
import java.util.Collections;
@@ -29,6 +29,7 @@
import org.springframework.messaging.SubscribableChannel;
import org.springframework.messaging.simp.... | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-messaging/src/test/java/org/springframework/messaging/simp/config/MessageBrokerConfigurationTests.java | @@ -34,7 +34,7 @@
import org.springframework.messaging.simp.SimpMessageType;
import org.springframework.messaging.simp.annotation.SubscribeMapping;
import org.springframework.messaging.simp.annotation.support.SimpAnnotationMethodMessageHandler;
-import org.springframework.messaging.simp.handler.SimpleBrokerMessageHa... | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-websocket/src/main/java/org/springframework/web/socket/config/MessageBrokerBeanDefinitionParser.java | @@ -41,7 +41,7 @@
import org.springframework.messaging.simp.annotation.support.SimpAnnotationMethodMessageHandler;
import org.springframework.messaging.simp.handler.DefaultUserDestinationResolver;
import org.springframework.messaging.simp.handler.DefaultUserSessionRegistry;
-import org.springframework.messaging.simp... | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-websocket/src/main/resources/org/springframework/web/socket/config/spring-websocket-4.0.xsd | @@ -294,7 +294,7 @@
<xsd:complexType name="simple-broker">
<xsd:annotation>
- <xsd:documentation source="java:org.springframework.messaging.simp.handler.SimpleBrokerMessageHandler"><![CDATA[
+ <xsd:documentation source="java:org.springframework.messaging.simp.broker.SimpleBrokerMes... | true |
Other | spring-projects | spring-framework | 89455c00f62775ead9b7cd76398b5be2012e432c.json | Create messaging.simp.broker package | spring-websocket/src/test/java/org/springframework/web/socket/config/MessageBrokerBeanDefinitionParserTests.java | @@ -32,7 +32,7 @@
import org.springframework.messaging.simp.SimpMessagingTemplate;
import org.springframework.messaging.simp.annotation.support.SimpAnnotationMethodMessageHandler;
import org.springframework.messaging.simp.handler.DefaultUserDestinationResolver;
-import org.springframework.messaging.simp.handler.Simp... | true |
Other | spring-projects | spring-framework | 3e0b0f100c473359814ebc0450fca0e5dfc3a69d.json | Delete unused import in MockAsyncContext | spring-test/src/main/java/org/springframework/mock/web/MockAsyncContext.java | @@ -28,7 +28,6 @@
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
-import org.apache.commons.logging.Log;
import org.springframework.beans.BeanUtils;
import org.springframework.util.Assert;
import org.springframework.web.util.WebUtils; | false |
Other | spring-projects | spring-framework | 8a4b36479aab604aa38951588063f1dc7588cdb0.json | Release version 4.0.0.RC2 | gradle.properties | @@ -1 +1 @@
-version=4.0.0.BUILD-SNAPSHOT
+version=4.0.0.RC2 | false |
Other | spring-projects | spring-framework | 14468e80f36f25761a85c678789fefedf4c60f6f.json | Add principal in GlassfishRequestUpgradeStrategy | spring-websocket/src/main/java/org/springframework/web/socket/server/standard/GlassFishRequestUpgradeStrategy.java | @@ -165,6 +165,7 @@ private boolean performUpgrade(HttpServletRequest request, HttpServletResponse r
RequestContext wsRequest = RequestContext.Builder.create().
requestURI(URI.create(wsApp.getPath())).requestPath(wsApp.getPath()).
+ userPrincipal(request.getUserPrincipal()).
connection(connection).sec... | false |
Other | spring-projects | spring-framework | b1485420b689a74722ad93a78f93334b57d023f7.json | Use port scanning for JMX tests
Attempt to fix performance build by scanning for a free JMX port. | spring-context/src/test/java/org/springframework/jmx/support/MBeanServerConnectionFactoryBeanTests.java | @@ -23,11 +23,13 @@
import javax.management.remote.JMXConnectorServerFactory;
import javax.management.remote.JMXServiceURL;
+import org.junit.Before;
import org.junit.Test;
import org.springframework.aop.support.AopUtils;
import org.springframework.jmx.AbstractMBeanServerTests;
import org.springframework.tests.... | false |
Other | spring-projects | spring-framework | 62d6a43c61efd7121982c5addfff07c4f8938e1e.json | Add NoHandlerFoundException to DispatcherServlet
Prior to this commit, the DispatcherServlet would send an error
response using the HttpServlet API when no Handler was found to
handle this request.
Now the DispatcherServlet can be configured to throw a
NoHandlerFoundException, when the throwExceptionIfNoHandlerFound
... | spring-webmvc/src/main/java/org/springframework/web/servlet/DispatcherServlet.java | @@ -45,6 +45,7 @@
import org.springframework.core.OrderComparator;
import org.springframework.core.io.ClassPathResource;
import org.springframework.core.io.support.PropertiesLoaderUtils;
+import org.springframework.http.server.ServletServerHttpRequest;
import org.springframework.ui.context.ThemeSource;
import org.... | true |
Other | spring-projects | spring-framework | 62d6a43c61efd7121982c5addfff07c4f8938e1e.json | Add NoHandlerFoundException to DispatcherServlet
Prior to this commit, the DispatcherServlet would send an error
response using the HttpServlet API when no Handler was found to
handle this request.
Now the DispatcherServlet can be configured to throw a
NoHandlerFoundException, when the throwExceptionIfNoHandlerFound
... | spring-webmvc/src/main/java/org/springframework/web/servlet/NoHandlerFoundException.java | @@ -0,0 +1,67 @@
+/*
+ * Copyright 2002-2013 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ ... | true |
Other | spring-projects | spring-framework | 62d6a43c61efd7121982c5addfff07c4f8938e1e.json | Add NoHandlerFoundException to DispatcherServlet
Prior to this commit, the DispatcherServlet would send an error
response using the HttpServlet API when no Handler was found to
handle this request.
Now the DispatcherServlet can be configured to throw a
NoHandlerFoundException, when the throwExceptionIfNoHandlerFound
... | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/ResponseEntityExceptionHandler.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2013 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -42,6 +42,7 @@
import org.springframework.w... | true |
Other | spring-projects | spring-framework | 62d6a43c61efd7121982c5addfff07c4f8938e1e.json | Add NoHandlerFoundException to DispatcherServlet
Prior to this commit, the DispatcherServlet would send an error
response using the HttpServlet API when no Handler was found to
handle this request.
Now the DispatcherServlet can be configured to throw a
NoHandlerFoundException, when the throwExceptionIfNoHandlerFound
... | spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/support/DefaultHandlerExceptionResolver.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2013 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -46,6 +46,7 @@
import org.springframework.w... | true |
Other | spring-projects | spring-framework | 62d6a43c61efd7121982c5addfff07c4f8938e1e.json | Add NoHandlerFoundException to DispatcherServlet
Prior to this commit, the DispatcherServlet would send an error
response using the HttpServlet API when no Handler was found to
handle this request.
Now the DispatcherServlet can be configured to throw a
NoHandlerFoundException, when the throwExceptionIfNoHandlerFound
... | spring-webmvc/src/test/java/org/springframework/web/servlet/DispatcherServletTests.java | @@ -540,6 +540,20 @@ public void testNotDetectAllViewResolvers() throws ServletException, IOException
}
}
+ public void testThrowExceptionIfNoHandlerFound() throws ServletException, IOException {
+ DispatcherServlet complexDispatcherServlet = new DispatcherServlet();
+ complexDispatcherServlet.setContextClass(... | true |
Other | spring-projects | spring-framework | 62d6a43c61efd7121982c5addfff07c4f8938e1e.json | Add NoHandlerFoundException to DispatcherServlet
Prior to this commit, the DispatcherServlet would send an error
response using the HttpServlet API when no Handler was found to
handle this request.
Now the DispatcherServlet can be configured to throw a
NoHandlerFoundException, when the throwExceptionIfNoHandlerFound
... | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/ResponseEntityExceptionHandlerTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2012 the original author or authors.
+ * Copyright 2002-2013 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -37,6 +37,7 @@
import org.springframework.h... | true |
Other | spring-projects | spring-framework | 62d6a43c61efd7121982c5addfff07c4f8938e1e.json | Add NoHandlerFoundException to DispatcherServlet
Prior to this commit, the DispatcherServlet would send an error
response using the HttpServlet API when no Handler was found to
handle this request.
Now the DispatcherServlet can be configured to throw a
NoHandlerFoundException, when the throwExceptionIfNoHandlerFound
... | spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/support/DefaultHandlerExceptionResolverTests.java | @@ -26,6 +26,7 @@
import org.junit.Before;
import org.junit.Test;
import org.springframework.beans.ConversionNotSupportedException;
+import org.springframework.http.server.ServletServerHttpRequest;
import org.springframework.tests.sample.beans.TestBean;
import org.springframework.beans.TypeMismatchException;
impo... | true |
Other | spring-projects | spring-framework | 62d6a43c61efd7121982c5addfff07c4f8938e1e.json | Add NoHandlerFoundException to DispatcherServlet
Prior to this commit, the DispatcherServlet would send an error
response using the HttpServlet API when no Handler was found to
handle this request.
Now the DispatcherServlet can be configured to throw a
NoHandlerFoundException, when the throwExceptionIfNoHandlerFound
... | src/reference/docbook/mvc.xml | @@ -4244,6 +4244,12 @@ public class SimpleController {
<entry>400 (Bad Request)</entry>
</row>
+ <row>
+ <entry><classname>NoHandlerFoundException</classname></entry>
+
+ <entry>404 (Not Found)</entry>
+ </row>
+
<r... | true |
Other | spring-projects | spring-framework | 2dd4480103716fd1f68c56efd519cbc20210740d.json | Add IPv6 support in RestTemplate
Prior to this commit, RestTemplate would not would
not accept IPv6 raw addresses in URLs because UriComponentsBuilder
would not parse/encode the Host part correctly.
The UriComponentsBuilder now parses and encode raw IPv6 addresses
in the "[1abc:2abc:3abc::5ABC:6abc]" format and also ... | spring-web/src/main/java/org/springframework/web/util/HierarchicalUriComponents.java | @@ -182,7 +182,13 @@ public HierarchicalUriComponents encode(String encoding) throws UnsupportedEncod
}
String encodedScheme = encodeUriComponent(this.getScheme(), encoding, Type.SCHEME);
String encodedUserInfo = encodeUriComponent(this.userInfo, encoding, Type.USER_INFO);
- String encodedHost = encodeUriComp... | true |
Other | spring-projects | spring-framework | 2dd4480103716fd1f68c56efd519cbc20210740d.json | Add IPv6 support in RestTemplate
Prior to this commit, RestTemplate would not would
not accept IPv6 raw addresses in URLs because UriComponentsBuilder
would not parse/encode the Host part correctly.
The UriComponentsBuilder now parses and encode raw IPv6 addresses
in the "[1abc:2abc:3abc::5ABC:6abc]" format and also ... | spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java | @@ -64,7 +64,11 @@ public class UriComponentsBuilder {
private static final String USERINFO_PATTERN = "([^@/]*)";
- private static final String HOST_PATTERN = "([^/?#:]*)";
+ private static final String HOST_IPv4_PATTERN = "[^\\[/?#:]*";
+
+ private static final String HOST_IPV6_PATTERN = "\\[[\\p{XDigit}\\:\\.]*... | true |
Other | spring-projects | spring-framework | 2dd4480103716fd1f68c56efd519cbc20210740d.json | Add IPv6 support in RestTemplate
Prior to this commit, RestTemplate would not would
not accept IPv6 raw addresses in URLs because UriComponentsBuilder
would not parse/encode the Host part correctly.
The UriComponentsBuilder now parses and encode raw IPv6 addresses
in the "[1abc:2abc:3abc::5ABC:6abc]" format and also ... | spring-web/src/test/java/org/springframework/web/util/UriComponentsBuilderTests.java | @@ -169,6 +169,31 @@ public void fromHttpUrlStringCaseInsesitiveScheme() {
assertEquals("https", UriComponentsBuilder.fromHttpUrl("HTTPS://www.google.com").build().getScheme());
}
+ // SPR-10539
+
+ @Test(expected = IllegalArgumentException.class)
+ public void fromHttpUrlStringInvalidIPv6Host() throws URISyntax... | true |
Other | spring-projects | spring-framework | 371d25558172311f3f8e8c46271917c9a5b96331.json | Fix typo in MVC reference documentation
Fix ContentNeogitatingViewResolver typo in MVC reference documentation.
Issue: SPR-10927 | src/reference/docbook/mvc.xml | @@ -4267,7 +4267,7 @@ public class SimpleController {
response for example when providing a REST API. You can prepare a
<classname>ModelAndView</classname> and
render error content through view resolution -- i.e. by configuring a
- <classname>ContentNeogitatingViewResolver</classname>,... | false |
Other | spring-projects | spring-framework | 4abe4e9999386484803f7e9ff176f260fe39badb.json | Add IssueManagement declaration to POMs
Update POM generation to include an issueManagement section.
Issue: SPR-10929 | gradle/publish-maven.gradle | @@ -46,6 +46,10 @@ def customizePom(pom, gradleProject) {
email = "jhoeller@vmware.com"
}
}
+ issueManagement {
+ system = "Jira"
+ url = "https://jira.springsource.org/browse/SPR"
+ }
}
}
} | false |
Other | spring-projects | spring-framework | 05072e17625e8fd256c1b29a45ef7248a6cecfa8.json | Expand var-args before passing to KeyGenerator
Update `CacheAspectSupport` to expand any var-arg parameters before
calling `KeyGenerator` implementations. Prior to this commit var-args
would be passed to `KeyGenerator` implementations as a nested array,
often causing the same key to be generated regardless of the argu... | spring-aspects/src/test/java/org/springframework/cache/config/AnnotatedClassCacheableService.java | @@ -87,6 +87,12 @@ public Object key(Object arg1, Object arg2) {
return counter.getAndIncrement();
}
+ @Override
+ @Cacheable(value = "default")
+ public Object varArgsKey(Object... args) {
+ return counter.getAndIncrement();
+ }
+
@Override
@Cacheable(value = "default", key = "#root.methodName + #root.cach... | true |
Other | spring-projects | spring-framework | 05072e17625e8fd256c1b29a45ef7248a6cecfa8.json | Expand var-args before passing to KeyGenerator
Update `CacheAspectSupport` to expand any var-arg parameters before
calling `KeyGenerator` implementations. Prior to this commit var-args
would be passed to `KeyGenerator` implementations as a nested array,
often causing the same key to be generated regardless of the argu... | spring-aspects/src/test/java/org/springframework/cache/config/CacheableService.java | @@ -44,6 +44,8 @@
T key(Object arg1, Object arg2);
+ T varArgsKey(Object... args);
+
T name(Object arg1);
T nullValue(Object arg1); | true |
Other | spring-projects | spring-framework | 05072e17625e8fd256c1b29a45ef7248a6cecfa8.json | Expand var-args before passing to KeyGenerator
Update `CacheAspectSupport` to expand any var-arg parameters before
calling `KeyGenerator` implementations. Prior to this commit var-args
would be passed to `KeyGenerator` implementations as a nested array,
often causing the same key to be generated regardless of the argu... | spring-aspects/src/test/java/org/springframework/cache/config/DefaultCacheableService.java | @@ -91,6 +91,12 @@ public Long key(Object arg1, Object arg2) {
return counter.getAndIncrement();
}
+ @Override
+ @Cacheable(value = "default")
+ public Long varArgsKey(Object... args) {
+ return counter.getAndIncrement();
+ }
+
@Override
@Cacheable(value = "default", key = "#root.methodName")
public Long ... | true |
Other | spring-projects | spring-framework | 05072e17625e8fd256c1b29a45ef7248a6cecfa8.json | Expand var-args before passing to KeyGenerator
Update `CacheAspectSupport` to expand any var-arg parameters before
calling `KeyGenerator` implementations. Prior to this commit var-args
would be passed to `KeyGenerator` implementations as a nested array,
often causing the same key to be generated regardless of the argu... | spring-context/src/main/java/org/springframework/cache/interceptor/CacheAspectSupport.java | @@ -25,7 +25,6 @@
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-
import org.springframework.aop.framework.AopProxyUtils;
import org.springframework.beans.factory.InitializingBean;
import org.springframework.cache.Cache;
@@ -349,15 +348,27 @@ protected class CacheOperationC... | true |
Other | spring-projects | spring-framework | 05072e17625e8fd256c1b29a45ef7248a6cecfa8.json | Expand var-args before passing to KeyGenerator
Update `CacheAspectSupport` to expand any var-arg parameters before
calling `KeyGenerator` implementations. Prior to this commit var-args
would be passed to `KeyGenerator` implementations as a nested array,
often causing the same key to be generated regardless of the argu... | spring-context/src/main/java/org/springframework/cache/interceptor/KeyGenerator.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2002-2011 the original author or authors.
+ * Copyright 2002-2013 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -24,10 +24,18 @@
*
* @author Costin Leau... | true |
Other | spring-projects | spring-framework | 05072e17625e8fd256c1b29a45ef7248a6cecfa8.json | Expand var-args before passing to KeyGenerator
Update `CacheAspectSupport` to expand any var-arg parameters before
calling `KeyGenerator` implementations. Prior to this commit var-args
would be passed to `KeyGenerator` implementations as a nested array,
often causing the same key to be generated regardless of the argu... | spring-context/src/test/java/org/springframework/cache/config/AbstractAnnotationTests.java | @@ -1,5 +1,5 @@
/*
- * Copyright 2010-2013 the original author or authors.
+ * Copyright 2002-2013 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -211,6 +211,19 @@ public void testKeyExpress... | true |
Other | spring-projects | spring-framework | 05072e17625e8fd256c1b29a45ef7248a6cecfa8.json | Expand var-args before passing to KeyGenerator
Update `CacheAspectSupport` to expand any var-arg parameters before
calling `KeyGenerator` implementations. Prior to this commit var-args
would be passed to `KeyGenerator` implementations as a nested array,
often causing the same key to be generated regardless of the argu... | spring-context/src/test/java/org/springframework/cache/config/AnnotatedClassCacheableService.java | @@ -89,6 +89,12 @@ public Object key(Object arg1, Object arg2) {
return counter.getAndIncrement();
}
+ @Override
+ @Cacheable(value = "default")
+ public Object varArgsKey(Object... args) {
+ return counter.getAndIncrement();
+ }
+
@Override
@Cacheable(value = "default", key = "#root.methodName + #root.cach... | true |
Other | spring-projects | spring-framework | 05072e17625e8fd256c1b29a45ef7248a6cecfa8.json | Expand var-args before passing to KeyGenerator
Update `CacheAspectSupport` to expand any var-arg parameters before
calling `KeyGenerator` implementations. Prior to this commit var-args
would be passed to `KeyGenerator` implementations as a nested array,
often causing the same key to be generated regardless of the argu... | spring-context/src/test/java/org/springframework/cache/config/CacheableService.java | @@ -44,6 +44,8 @@
T key(Object arg1, Object arg2);
+ T varArgsKey(Object... args);
+
T name(Object arg1);
T nullValue(Object arg1); | true |
Other | spring-projects | spring-framework | 05072e17625e8fd256c1b29a45ef7248a6cecfa8.json | Expand var-args before passing to KeyGenerator
Update `CacheAspectSupport` to expand any var-arg parameters before
calling `KeyGenerator` implementations. Prior to this commit var-args
would be passed to `KeyGenerator` implementations as a nested array,
often causing the same key to be generated regardless of the argu... | spring-context/src/test/java/org/springframework/cache/config/DefaultCacheableService.java | @@ -91,6 +91,12 @@ public Long key(Object arg1, Object arg2) {
return counter.getAndIncrement();
}
+ @Override
+ @Cacheable(value = "default")
+ public Long varArgsKey(Object... args) {
+ return counter.getAndIncrement();
+ }
+
@Override
@Cacheable(value = "default", key = "#root.methodName")
public Long ... | true |
Other | spring-projects | spring-framework | 05072e17625e8fd256c1b29a45ef7248a6cecfa8.json | Expand var-args before passing to KeyGenerator
Update `CacheAspectSupport` to expand any var-arg parameters before
calling `KeyGenerator` implementations. Prior to this commit var-args
would be passed to `KeyGenerator` implementations as a nested array,
often causing the same key to be generated regardless of the argu... | spring-context/src/test/resources/org/springframework/cache/config/cache-advice.xml | @@ -13,6 +13,7 @@
<cache:cacheable method="conditional" condition="#classField == 3"/>
<cache:cacheable method="unless" unless="#result > 10"/>
<cache:cacheable method="key" key="#p0"/>
+ <cache:cacheable method="varArgsKey"/>
<cache:cacheable method="nam*" key="#root.methodName"/>
<cache:cacheabl... | true |
Other | spring-projects | spring-framework | 2337e763d04669a23bbc0448b03e75be8e0d7eb5.json | Fix tomcat maven repo location and use spring.io
Fix the maven repo used for tomcat 8 release candidates and update
spring repos from springsource.org to spring.io. | build.gradle | @@ -66,8 +66,10 @@ configure(allprojects) { project ->
}
repositories {
- maven { url "http://repo.springsource.org/libs-release" }
- maven { url "http://maven.springframework.org/milestone" } // for AspectJ 1.8.0.M1
+ maven { url "http://repo.spring.io/libs-release" }
+ maven { url "http://repo.spring.io/mi... | false |
Other | spring-projects | spring-framework | 1f9e8f68d445ae1d16e27ccde97403efaaa23a81.json | Add support for Objenesis proxy creation.
Extended DefaultAopProxyFactory to create Objenesis based proxies if the
library is on the classpath. This allows classes without a default
constructor being CGLib proxied. We're now falling back to original CGLib
based behavior in case the proxy creation using Objenesis fails... | build.gradle | @@ -166,10 +166,12 @@ project("spring-core") {
// further transformed by the JarJar task to depend on org.springframework.asm; this
// avoids including two different copies of asm unnecessarily.
def cglibVersion = "3.0"
+ def objenesisVersion = "2.0"
configurations {
jarjar
cglib
+ objenesis
}
ta... | true |
Other | spring-projects | spring-framework | 1f9e8f68d445ae1d16e27ccde97403efaaa23a81.json | Add support for Objenesis proxy creation.
Extended DefaultAopProxyFactory to create Objenesis based proxies if the
library is on the classpath. This allows classes without a default
constructor being CGLib proxied. We're now falling back to original CGLib
based behavior in case the proxy creation using Objenesis fails... | spring-aop/src/main/java/org/springframework/aop/framework/CglibAopProxy.java | @@ -79,7 +79,7 @@
* @see DefaultAopProxyFactory
*/
@SuppressWarnings("serial")
-final class CglibAopProxy implements AopProxy, Serializable {
+class CglibAopProxy implements AopProxy, Serializable {
// Constants for CGLIB callback array indices
private static final int AOP_PROXY = 0;
@@ -185,29 +185,20 @@ pu... | true |
Other | spring-projects | spring-framework | 1f9e8f68d445ae1d16e27ccde97403efaaa23a81.json | Add support for Objenesis proxy creation.
Extended DefaultAopProxyFactory to create Objenesis based proxies if the
library is on the classpath. This allows classes without a default
constructor being CGLib proxied. We're now falling back to original CGLib
based behavior in case the proxy creation using Objenesis fails... | spring-aop/src/main/java/org/springframework/aop/framework/DefaultAopProxyFactory.java | @@ -59,7 +59,7 @@ public AopProxy createAopProxy(AdvisedSupport config) throws AopConfigException
if (targetClass.isInterface()) {
return new JdkDynamicAopProxy(config);
}
- return CglibProxyFactory.createCglibProxy(config);
+ return new ObjenesisCglibAopProxy(config);
}
else {
return new Jdk... | true |
Other | spring-projects | spring-framework | 1f9e8f68d445ae1d16e27ccde97403efaaa23a81.json | Add support for Objenesis proxy creation.
Extended DefaultAopProxyFactory to create Objenesis based proxies if the
library is on the classpath. This allows classes without a default
constructor being CGLib proxied. We're now falling back to original CGLib
based behavior in case the proxy creation using Objenesis fails... | spring-aop/src/main/java/org/springframework/aop/framework/ObjenesisCglibAopProxy.java | @@ -0,0 +1,70 @@
+/*
+ * Copyright 2002-2013 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | 1f9e8f68d445ae1d16e27ccde97403efaaa23a81.json | Add support for Objenesis proxy creation.
Extended DefaultAopProxyFactory to create Objenesis based proxies if the
library is on the classpath. This allows classes without a default
constructor being CGLib proxied. We're now falling back to original CGLib
based behavior in case the proxy creation using Objenesis fails... | spring-aop/src/test/java/org/springframework/aop/framework/ClassWithConstructor.java | @@ -0,0 +1,28 @@
+/*
+ * Copyright 2002-2013 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | 1f9e8f68d445ae1d16e27ccde97403efaaa23a81.json | Add support for Objenesis proxy creation.
Extended DefaultAopProxyFactory to create Objenesis based proxies if the
library is on the classpath. This allows classes without a default
constructor being CGLib proxied. We're now falling back to original CGLib
based behavior in case the proxy creation using Objenesis fails... | spring-context/src/test/java/org/springframework/aop/framework/CglibProxyTests.java | @@ -16,13 +16,6 @@
package org.springframework.aop.framework;
-import static org.hamcrest.CoreMatchers.instanceOf;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertThat;
-import static org.junit.Assert.assertTrue;
-import static org.... | true |
Other | spring-projects | spring-framework | 1f9e8f68d445ae1d16e27ccde97403efaaa23a81.json | Add support for Objenesis proxy creation.
Extended DefaultAopProxyFactory to create Objenesis based proxies if the
library is on the classpath. This allows classes without a default
constructor being CGLib proxied. We're now falling back to original CGLib
based behavior in case the proxy creation using Objenesis fails... | spring-context/src/test/java/org/springframework/aop/framework/ClassWithComplexConstructor.java | @@ -0,0 +1,44 @@
+/*
+ * Copyright 2002-2013 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | 1f9e8f68d445ae1d16e27ccde97403efaaa23a81.json | Add support for Objenesis proxy creation.
Extended DefaultAopProxyFactory to create Objenesis based proxies if the
library is on the classpath. This allows classes without a default
constructor being CGLib proxied. We're now falling back to original CGLib
based behavior in case the proxy creation using Objenesis fails... | spring-context/src/test/java/org/springframework/aop/framework/Dependency.java | @@ -0,0 +1,32 @@
+/*
+ * Copyright 2002-2013 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | 1f9e8f68d445ae1d16e27ccde97403efaaa23a81.json | Add support for Objenesis proxy creation.
Extended DefaultAopProxyFactory to create Objenesis based proxies if the
library is on the classpath. This allows classes without a default
constructor being CGLib proxied. We're now falling back to original CGLib
based behavior in case the proxy creation using Objenesis fails... | spring-context/src/test/java/org/springframework/aop/framework/ObjenesisProxyTests-context.xml | @@ -0,0 +1,21 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<beans xmlns="http://www.springframework.org/schema/beans"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:util="http://www.springframework.org/schema/util"
+ xmlns:aop="http://www.springframework.org/schema/aop" xmlns:context="http://www.springfra... | true |
Other | spring-projects | spring-framework | 1f9e8f68d445ae1d16e27ccde97403efaaa23a81.json | Add support for Objenesis proxy creation.
Extended DefaultAopProxyFactory to create Objenesis based proxies if the
library is on the classpath. This allows classes without a default
constructor being CGLib proxied. We're now falling back to original CGLib
based behavior in case the proxy creation using Objenesis fails... | spring-context/src/test/java/org/springframework/aop/framework/ObjenesisProxyTests.java | @@ -0,0 +1,47 @@
+/*
+ * Copyright 2002-2013 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *... | true |
Other | spring-projects | spring-framework | ee5d6c8f839e2346f03afbf5049c42067bf04526.json | Exclude null requestURI in MHSR.getRequestURL()
This commit undoes the changes made in ec5d81e78e and ensures that the
getRequestURL() method in MockHttpServletRequest does not include the
String "null" for a null requestURI by first checking if the requestURI
contains text before including it in the composed URL.
Is... | spring-test/src/main/java/org/springframework/mock/web/MockHttpServletRequest.java | @@ -53,6 +53,7 @@
import org.springframework.util.Assert;
import org.springframework.util.LinkedCaseInsensitiveMap;
+import org.springframework.util.StringUtils;
/**
* Mock implementation of the {@link javax.servlet.http.HttpServletRequest} interface.
@@ -249,8 +250,8 @@ public MockHttpServletRequest(ServletCo... | true |
Other | spring-projects | spring-framework | ee5d6c8f839e2346f03afbf5049c42067bf04526.json | Exclude null requestURI in MHSR.getRequestURL()
This commit undoes the changes made in ec5d81e78e and ensures that the
getRequestURL() method in MockHttpServletRequest does not include the
String "null" for a null requestURI by first checking if the requestURI
contains text before including it in the composed URL.
Is... | spring-test/src/test/java/org/springframework/mock/web/MockHttpServletRequestTests.java | @@ -211,6 +211,13 @@ public void getRequestURLWithDefaults() {
assertEquals("http://localhost", requestURL.toString());
}
+ @Test
+ public void getRequestURLWithNullRequestUri() {
+ request.setRequestURI(null);
+ StringBuffer requestURL = request.getRequestURL();
+ assertEquals("http://localhost", requestURL.... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-messaging/src/test/java/org/springframework/messaging/simp/handler/AnnotationMethodIntegrationTests.java | @@ -83,7 +83,7 @@ protected Class<?>[] getAnnotatedConfigClasses() {
public void simpleController() throws Exception {
TextMessage message = create(StompCommand.SEND).headers("destination:/app/simple").build();
- WebSocketSession session = doHandshake(new TestClientWebSocketHandler(0, message), "/ws");
+ WebSo... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/main/java/org/springframework/web/socket/client/AbstractWebSocketClient.java | @@ -28,6 +28,7 @@
import org.apache.commons.logging.LogFactory;
import org.springframework.http.HttpHeaders;
import org.springframework.util.Assert;
+import org.springframework.util.concurrent.ListenableFuture;
import org.springframework.web.socket.WebSocketHandler;
import org.springframework.web.socket.WebSocketS... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/main/java/org/springframework/web/socket/client/ConnectionManagerSupport.java | @@ -21,8 +21,6 @@
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.springframework.context.SmartLifecycle;
-import org.springframework.core.task.SimpleAsyncTaskExecutor;
-import org.springframework.core.task.TaskExecutor;
import org.springframework.web.util.UriComponen... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/main/java/org/springframework/web/socket/client/WebSocketClient.java | @@ -19,6 +19,7 @@
import java.net.URI;
import org.springframework.http.HttpHeaders;
+import org.springframework.util.concurrent.ListenableFuture;
import org.springframework.web.socket.WebSocketHandler;
import org.springframework.web.socket.WebSocketSession;
@@ -34,10 +35,9 @@
*/
public interface WebSocketCli... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/main/java/org/springframework/web/socket/client/WebSocketConnectFailureException.java | @@ -1,38 +0,0 @@
-/*
- * Copyright 2002-2013 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- ... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/main/java/org/springframework/web/socket/client/WebSocketConnectionManager.java | @@ -20,6 +20,8 @@
import org.springframework.context.SmartLifecycle;
import org.springframework.http.HttpHeaders;
+import org.springframework.util.concurrent.ListenableFuture;
+import org.springframework.util.concurrent.ListenableFutureCallback;
import org.springframework.web.socket.WebSocketHandler;
import org.s... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/main/java/org/springframework/web/socket/client/endpoint/AnnotatedEndpointConnectionManager.java | @@ -24,6 +24,9 @@
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.BeanFactory;
import org.springframework.beans.factory.BeanFactoryAware;
+import org.springframework.core.task.SimpleAsyncTaskExecutor;
+import org.springframework.core.task.TaskExecutor;
+import org.springfram... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/main/java/org/springframework/web/socket/client/endpoint/EndpointConnectionManager.java | @@ -32,6 +32,8 @@
import org.springframework.beans.BeansException;
import org.springframework.beans.factory.BeanFactory;
import org.springframework.beans.factory.BeanFactoryAware;
+import org.springframework.core.task.SimpleAsyncTaskExecutor;
+import org.springframework.core.task.TaskExecutor;
import org.springfram... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/main/java/org/springframework/web/socket/client/endpoint/StandardWebSocketClient.java | @@ -23,6 +23,7 @@
import java.util.List;
import java.util.Locale;
import java.util.Map;
+import java.util.concurrent.Callable;
import javax.websocket.ClientEndpointConfig;
import javax.websocket.ClientEndpointConfig.Configurator;
@@ -31,14 +32,17 @@
import javax.websocket.HandshakeResponse;
import javax.websoc... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/main/java/org/springframework/web/socket/client/jetty/JettyWebSocketClient.java | @@ -20,19 +20,24 @@
import java.security.Principal;
import java.util.List;
import java.util.Map;
+import java.util.concurrent.Callable;
import java.util.concurrent.Future;
import org.eclipse.jetty.websocket.api.Session;
import org.eclipse.jetty.websocket.client.ClientUpgradeRequest;
import org.eclipse.jetty.we... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/test/java/org/springframework/web/socket/AbstractWebSocketIntegrationTests.java | @@ -26,6 +26,7 @@
import org.springframework.context.Lifecycle;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
+import org.springframework.util.concurrent.ListenableFuture;
import org.springframework.web.context.support.AnnotationConfigWebApplication... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/test/java/org/springframework/web/socket/TomcatWebSocketTestServer.java | @@ -25,7 +25,6 @@
import org.apache.coyote.http11.Http11NioProtocol;
import org.apache.tomcat.util.descriptor.web.ApplicationListener;
import org.apache.tomcat.websocket.server.WsListener;
-import org.springframework.core.NestedRuntimeException;
import org.springframework.util.SocketUtils;
import org.springframewo... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/test/java/org/springframework/web/socket/client/WebSocketConnectionManagerTests.java | @@ -19,19 +19,21 @@
import java.net.URI;
import java.util.Arrays;
import java.util.List;
+import java.util.concurrent.Callable;
import org.junit.Test;
-import org.mockito.ArgumentCaptor;
import org.springframework.context.SmartLifecycle;
import org.springframework.http.HttpHeaders;
+import org.springframework.u... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/test/java/org/springframework/web/socket/client/endpoint/StandardWebSocketClientTests.java | @@ -66,7 +66,7 @@ public void setup() {
@Test
public void localAddress() throws Exception {
URI uri = new URI("ws://example.com/abc");
- WebSocketSession session = this.wsClient.doHandshake(this.wsHandler, this.headers, uri);
+ WebSocketSession session = this.wsClient.doHandshake(this.wsHandler, this.headers, ... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/test/java/org/springframework/web/socket/client/jetty/JettyWebSocketClientTests.java | @@ -83,7 +83,7 @@ public void doHandshake() throws Exception {
HttpHeaders headers = new HttpHeaders();
headers.setSecWebSocketProtocol(Arrays.asList("echo"));
- this.wsSession = this.client.doHandshake(new TextWebSocketHandlerAdapter(), headers, new URI(this.wsUrl));
+ this.wsSession = this.client.doHandshak... | true |
Other | spring-projects | spring-framework | 62921683fd1b2994302c5c80c16eacd6dc419fe1.json | Introduce ListenableFuture to WebSocketClient
Issue: SPR-10888 | spring-websocket/src/test/java/org/springframework/web/socket/server/config/WebSocketConfigurationTests.java | @@ -65,8 +65,8 @@ protected Class<?>[] getAnnotatedConfigClasses() {
@Test
public void registerWebSocketHandler() throws Exception {
- WebSocketSession session =
- this.webSocketClient.doHandshake(new WebSocketHandlerAdapter(), getWsBaseUrl() + "/ws");
+ WebSocketSession session = this.webSocketClient.doHand... | true |
Other | spring-projects | spring-framework | 1c47c8f35c91b1c77b27ab5092ff01b5733ec116.json | Remove TODOs (replaced with JIRA tickets)
Issue: SPR-10703 | spring-messaging/src/main/java/org/springframework/messaging/MessageHandler.java | @@ -42,11 +42,4 @@ public interface MessageHandler {
*/
void handleMessage(Message<?> message) throws MessagingException;
- /*
- * TODO: exceptions
- * @throws org.springframework.integration.MessageRejectedException if the handler doesn't accept the message
- * @throws org.springframework.integration.Message... | true |
Other | spring-projects | spring-framework | 1c47c8f35c91b1c77b27ab5092ff01b5733ec116.json | Remove TODOs (replaced with JIRA tickets)
Issue: SPR-10703 | spring-messaging/src/main/java/org/springframework/messaging/handler/annotation/support/MessageBodyMethodArgumentResolver.java | @@ -25,7 +25,7 @@
/**
- * TODO
+ * A resolver for extracting the body of a message.
*
* <p>This {@link HandlerMethodArgumentResolver} should be ordered last as it supports all
* types and does not require the {@link MessageBody} annotation.
@@ -62,7 +62,6 @@ public Object resolveArgument(MethodParameter para... | true |
Other | spring-projects | spring-framework | 1c47c8f35c91b1c77b27ab5092ff01b5733ec116.json | Remove TODOs (replaced with JIRA tickets)
Issue: SPR-10703 | spring-messaging/src/main/java/org/springframework/messaging/handler/method/InvocableHandlerMethod.java | @@ -94,7 +94,7 @@ public void setParameterNameDiscoverer(ParameterNameDiscoverer parameterNameDisc
}
/**
- * TODO
+ * Invoke the method with the given message.
*
* @exception Exception raised if no suitable argument resolver can be found, or the
* method raised an exception | true |
Other | spring-projects | spring-framework | 1c47c8f35c91b1c77b27ab5092ff01b5733ec116.json | Remove TODOs (replaced with JIRA tickets)
Issue: SPR-10703 | spring-messaging/src/main/java/org/springframework/messaging/simp/handler/AnnotationMethodMessageHandler.java | @@ -339,8 +339,7 @@ private void handleMessageInternal(Message<?> message, Map<MappingInfo, HandlerM
invokeExceptionHandler(message, handlerMethod, ex);
}
catch (Throwable ex) {
- // TODO
- ex.printStackTrace();
+ logger.error("Error while processing message " + message, ex);
}
}
| true |
Other | spring-projects | spring-framework | 1c47c8f35c91b1c77b27ab5092ff01b5733ec116.json | Remove TODOs (replaced with JIRA tickets)
Issue: SPR-10703 | spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompHeaderAccessor.java | @@ -255,7 +255,6 @@ public long[] getHeartbeat() {
return null;
}
String[] rawValues = StringUtils.commaDelimitedListToStringArray(rawValue);
- // TODO assertions
return new long[] { Long.valueOf(rawValues[0]), Long.valueOf(rawValues[1])};
}
| true |
Other | spring-projects | spring-framework | 1c47c8f35c91b1c77b27ab5092ff01b5733ec116.json | Remove TODOs (replaced with JIRA tickets)
Issue: SPR-10703 | spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompMessageConverter.java | @@ -73,7 +73,6 @@ else if (stompContent instanceof byte[]){
String headerContent = new String(byteContent, 0, payloadIndex, STOMP_CHARSET);
Parser parser = new Parser(headerContent);
- // TODO: validate command and whether a payload is allowed
StompCommand command = StompCommand.valueOf(parser.nextToken(LF)... | true |
Other | spring-projects | spring-framework | 1c47c8f35c91b1c77b27ab5092ff01b5733ec116.json | Remove TODOs (replaced with JIRA tickets)
Issue: SPR-10703 | spring-messaging/src/main/java/org/springframework/messaging/simp/stomp/StompProtocolHandler.java | @@ -99,9 +99,6 @@ public void handleMessageFromClient(WebSocketSession session, WebSocketMessage w
String payload = ((TextMessage)webSocketMessage).getPayload();
Message<?> message = this.stompMessageConverter.toMessage(payload);
- // TODO: validate size limits
- // http://stomp.github.io/stomp-specificat... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.