language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-messaging/src/main/java/org/springframework/messaging/core/AbstractMessageSendingTemplate.java
@@ -54,7 +54,7 @@ public D getDefaultDestination() { /** * Set the {@link MessageConverter} that is to be used to convert * between Messages and objects for this template. - * <p>The default is {@link SimplePayloadMessageConverter}. + * <p>The default is {@link SimpleMessageConverter}. */ public void set...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-messaging/src/main/java/org/springframework/messaging/handler/annotation/support/AbstractNamedValueMethodArgumentResolver.java
@@ -19,6 +19,7 @@ import java.util.Map; import java.util.concurrent.ConcurrentHashMap; +import org.springframework.beans.factory.BeanFactory; import org.springframework.beans.factory.config.BeanExpressionContext; import org.springframework.beans.factory.config.BeanExpressionResolver; import org.springframework.b...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-messaging/src/main/java/org/springframework/messaging/simp/handler/DefaultUserDestinationResolver.java
@@ -29,7 +29,7 @@ import java.util.Set; /** - * A default implementation of {@link @UserDestinationResolver}. + * A default implementation of {@link UserDestinationResolver}. * <p> * Resolves messages sent to destination patterns "/user/{user-name}/**" as well as * subscriptions to destinations "/user/queue/*...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-messaging/src/main/java/org/springframework/messaging/simp/handler/DefaultUserSessionRegistry.java
@@ -25,7 +25,7 @@ import java.util.concurrent.CopyOnWriteArraySet; /** - * A default thread-safe implementation of {@link @UserSessionRegistry}. + * A default thread-safe implementation of {@link UserSessionRegistry}. * * @author Rossen Stoyanchev * @since 4.0
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-oxm/src/main/java/org/springframework/oxm/jaxb/Jaxb2Marshaller.java
@@ -36,6 +36,7 @@ import java.util.Date; import java.util.Map; import java.util.UUID; + import javax.activation.DataHandler; import javax.activation.DataSource; import javax.xml.XMLConstants; @@ -63,6 +64,7 @@ import javax.xml.transform.Source; import javax.xml.transform.dom.DOMSource; import javax.xml.transfo...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-test/src/main/java/org/springframework/mock/web/MockServletContext.java
@@ -182,7 +182,7 @@ public MockServletContext(ResourceLoader resourceLoader) { * Create a new MockServletContext using the supplied resource base path and * resource loader. * <p>Registers a {@link MockRequestDispatcher} for the Servlet named - * {@value #COMMON_DEFAULT_SERVLET_NAME}. + * {@literal 'default'...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-test/src/main/java/org/springframework/test/context/junit4/statements/RunAfterTestClassCallbacks.java
@@ -19,6 +19,7 @@ import java.util.ArrayList; import java.util.List; +import org.junit.runners.model.MultipleFailureException; import org.junit.runners.model.Statement; import org.springframework.test.context.TestContextManager;
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-test/src/main/java/org/springframework/test/context/junit4/statements/RunAfterTestMethodCallbacks.java
@@ -20,6 +20,7 @@ import java.util.ArrayList; import java.util.List; +import org.junit.runners.model.MultipleFailureException; import org.junit.runners.model.Statement; import org.springframework.test.context.TestContextManager;
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-test/src/main/java/org/springframework/test/context/support/DirtiesContextTestExecutionListener.java
@@ -72,7 +72,7 @@ protected void dirtyContext(TestContext testContext, HierarchyMode hierarchyMode * mode} is set to {@link ClassMode#AFTER_EACH_TEST_METHOD * AFTER_EACH_TEST_METHOD}, the {@linkplain ApplicationContext application * context} of the test context will be - * {@linkplain TestContext#markApplicat...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-tx/src/main/java/org/springframework/dao/support/DaoSupport.java
@@ -31,7 +31,6 @@ * @author Juergen Hoeller * @since 1.2.2 * @see org.springframework.jdbc.core.support.JdbcDaoSupport - * @see org.springframework.orm.jdo.support.JdoDaoSupport */ public abstract class DaoSupport implements InitializingBean {
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-tx/src/main/java/org/springframework/transaction/interceptor/TransactionProxyFactoryBean.java
@@ -70,8 +70,7 @@ * <p>The "preInterceptors" and "postInterceptors" properties can be set to add * additional interceptors to the mix, like * {@link org.springframework.aop.interceptor.PerformanceMonitorInterceptor} or - * {@link org.springframework.orm.hibernate3.HibernateInterceptor} / - * {@link org.springfram...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-web/src/main/java/org/springframework/http/StreamingHttpOutputMessage.java
@@ -29,21 +29,19 @@ public interface StreamingHttpOutputMessage extends HttpOutputMessage { /** * Sets the streaming body for this message. - * * @param body the streaming body */ void setBody(Body body); /** * Defines the contract for bodies that can be written directly to a - * {@link OuputStr...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-web/src/main/java/org/springframework/http/converter/FormHttpMessageConverter.java
@@ -63,7 +63,7 @@ * LinkedMultiValueMap&lt;String, Object&gt;(); parts.add("field 1", "value 1"); parts.add("file", new * ClassPathResource("myFile.jpg")); template.postForLocation("http://example.com/myFileUpload", parts); </pre> * - * <p>Some methods in this class were inspired by {@link org.apache.commons.http...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-web/src/main/java/org/springframework/remoting/httpinvoker/HttpComponentsHttpInvokerRequestExecutor.java
@@ -64,7 +64,7 @@ public class HttpComponentsHttpInvokerRequestExecutor extends AbstractHttpInvoke /** * Create a new instance of the HttpComponentsHttpInvokerRequestExecutor with a default - * {@link HttpClient} that uses a default {@link org.apache.http.impl.conn.PoolingClientConnectionManager}. + * {@link H...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-web/src/main/java/org/springframework/remoting/httpinvoker/HttpInvokerClientInterceptor.java
@@ -100,10 +100,10 @@ public String getCodebaseUrl() { * Set the HttpInvokerRequestExecutor implementation to use for executing * remote invocations. * <p>Default is {@link SimpleHttpInvokerRequestExecutor}. Alternatively, - * consider using {@link CommonsHttpInvokerRequestExecutor} for more + * consider usi...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-web/src/main/java/org/springframework/web/bind/ServletRequestDataBinder.java
@@ -31,10 +31,6 @@ * which include specifying allowed/required fields, and registering custom * property editors. * - * <p>Used by Spring Web MVC's BaseCommandController and MultiActionController. - * Note that BaseCommandController and its subclasses allow for easy customization - * of the binder instances that ...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-web/src/main/java/org/springframework/web/bind/annotation/RequestMapping.java
@@ -161,7 +161,7 @@ * * <p>The following return types are supported for handler methods: * <ul> - * <li>A {@link ModelAndView} object (Servlet MVC or Portlet MVC), + * <li>A {@code ModelAndView} object (Servlet MVC or Portlet MVC), * with the model implicitly enriched with command objects and the results * of...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-web/src/main/java/org/springframework/web/context/support/WebApplicationContextUtils.java
@@ -63,7 +63,6 @@ * @see org.springframework.web.servlet.FrameworkServlet * @see org.springframework.web.servlet.DispatcherServlet * @see org.springframework.web.jsf.FacesContextUtils - * @see org.springframework.web.jsf.SpringBeanVariableResolver * @see org.springframework.web.jsf.el.SpringBeanFacesELResolver ...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-webmvc-portlet/src/main/java/org/springframework/web/portlet/bind/PortletRequestDataBinder.java
@@ -32,10 +32,6 @@ * which include specifying allowed/required fields, and registering custom * property editors. * - * <p>Used by Spring Portlet MVC's BaseCommandController. - * Note that BaseCommandController and its subclasses allow for easy customization - * of the binder instances that they use through overr...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/MvcUriComponentsBuilder.java
@@ -205,7 +205,7 @@ public static UriComponentsBuilder fromMethod(Method method, Object... argumentV * * </pre> * - * The above supports {@codce @PathVariable} and {@code @RequestParam} method parameters. + * The above supports {@code @PathVariable} and {@code @RequestParam} method parameters. * Any oth...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-websocket/src/main/java/org/springframework/web/socket/messaging/StompSubProtocolHandler.java
@@ -66,8 +66,7 @@ public class StompSubProtocolHandler implements SubProtocolHandler { /** * Provide a registry with which to register active user session ids. - * - * @see {@link org.springframework.messaging.simp.handler.UserDestinationMessageHandler} + * @see org.springframework.messaging.simp.handler.User...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-websocket/src/main/java/org/springframework/web/socket/server/config/WebSocketConfigurationSupport.java
@@ -45,7 +45,7 @@ protected void registerWebSocketHandlers(WebSocketHandlerRegistry registry) { /** * The default TaskScheduler to use if none is configured via - * {@link SockJsServiceRegistration#setTaskScheduler()}, i.e. + * {@link SockJsServiceRegistration#setTaskScheduler}, i.e. * <pre class="code"> ...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-websocket/src/main/java/org/springframework/web/socket/server/support/WebSocketHttpRequestHandler.java
@@ -49,10 +49,6 @@ * {@link HttpServletResponse} to {@link ServerHttpRequest} and {@link ServerHttpResponse} * respectively. * - * <p>The {@link #applyDefaultDecorators(WebSocketHandler)} method decorates the given - * WebSocketHandler with a logging and exception handling decorators. This method can - * be overr...
true
Other
spring-projects
spring-framework
a31ac882c54b9a32345274b09647b7423ecf0839.json
Fix various javadoc warnings
spring-websocket/src/main/java/org/springframework/web/socket/sockjs/transport/handler/TransportHandlerSupport.java
@@ -23,7 +23,7 @@ /** * @author Rossen Stoyanchev - * @sicne 4.0 + * @since 4.0 */ public abstract class TransportHandlerSupport {
true
Other
spring-projects
spring-framework
c5779e2ed6b2235dfac8de20aa9a2faf22dfc317.json
Remove unused GlassFishLoadTimeWeaverTests Delete the unused GlassFishLoadTimeWeaverTests and in the process fix the "Unable to load JUnit4 runner to calculate Ignored test cases" Gradle error. Issue: SPR-10563
spring-context/src/test/java/org/springframework/instrument/classloading/glassfish/GlassFishLoadTimeWeaverTests.java
@@ -1,150 +0,0 @@ -/* - * Copyright 2002-2012 the original author or authors. - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 -...
false
Other
spring-projects
spring-framework
119e793994796bc4e7ebfd7d57fe3b219c07c68b.json
Fix concurrency issue in TestDispatcherServlet This change fixes a timing issue in tests using Spring MVC Tests where assertions on an async result may not wait long enough. The fix involves the use of a new callback in MockAsyncContext that allows tests to detect when an async dispatch has been invoked. Issue: SPR...
spring-test/src/main/java/org/springframework/mock/web/MockAsyncContext.java
@@ -28,7 +28,9 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; +import org.apache.commons.logging.Log; import org.springframework.beans.BeanUtils; +import org.springframework.util.Assert; import org.springframework.web.util.WebUtils; /** @@ -49,13 +51,20 @@ publi...
true
Other
spring-projects
spring-framework
119e793994796bc4e7ebfd7d57fe3b219c07c68b.json
Fix concurrency issue in TestDispatcherServlet This change fixes a timing issue in tests using Spring MVC Tests where assertions on an async result may not wait long enough. The fix involves the use of a new callback in MockAsyncContext that allows tests to detect when an async dispatch has been invoked. Issue: SPR...
spring-test/src/main/java/org/springframework/test/web/servlet/TestDispatcherServlet.java
@@ -25,13 +25,10 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; +import org.springframework.mock.web.MockAsyncContext; import org.springframework.web.context.WebApplicationContext; import org.springframework.web.context.request.NativeWebRequest; -import org.springf...
true
Other
spring-projects
spring-framework
ce3e55743f23100f0e4044320cdb1f168ca76ea3.json
Extract IdGenerator into a top-level class
spring-core/src/main/java/org/springframework/util/AlternativeJdkIdGenerator.java
@@ -0,0 +1,62 @@ +/* + * Copyright 2002-2013 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
ce3e55743f23100f0e4044320cdb1f168ca76ea3.json
Extract IdGenerator into a top-level class
spring-core/src/main/java/org/springframework/util/IdGenerator.java
@@ -0,0 +1,35 @@ +/* + * Copyright 2002-2013 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + *...
true
Other
spring-projects
spring-framework
ce3e55743f23100f0e4044320cdb1f168ca76ea3.json
Extract IdGenerator into a top-level class
spring-messaging/src/main/java/org/springframework/messaging/MessageHeaders.java
@@ -20,8 +20,6 @@ import java.io.ObjectInputStream; import java.io.ObjectOutputStream; import java.io.Serializable; -import java.math.BigInteger; -import java.security.SecureRandom; import java.util.ArrayList; import java.util.Arrays; import java.util.Collection; @@ -30,12 +28,13 @@ import java.util.LinkedHashMa...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-aop/src/main/java/org/springframework/aop/support/DelegatePerTargetObjectIntroductionInterceptor.java
@@ -67,7 +67,7 @@ public class DelegatePerTargetObjectIntroductionInterceptor extends Introduction public DelegatePerTargetObjectIntroductionInterceptor(Class<?> defaultImplType, Class<?> interfaceType) { this.defaultImplType = defaultImplType; this.interfaceType = interfaceType; - // cCeate a new delegate now...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-beans/src/main/java/org/springframework/beans/factory/xml/NamespaceHandler.java
@@ -36,7 +36,7 @@ * it encounters a custom tag directly under a {@code &lt;bean&gt;} tag. * * <p>Developers writing their own custom element extensions typically will - * not implement this interface drectly, but rather make use of the provided + * not implement this interface directly, but rather make use of the...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-core/src/main/java/org/springframework/asm/Frame.java
@@ -585,7 +585,7 @@ private void push(final int type) { } // pushes the type on the output stack outputStack[outputStackTop++] = type; - // updates the maximun height reached by the output stack, if needed + // updates the maximum height reached by the output stack, if needed ...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-core/src/main/java/org/springframework/util/AutoPopulatingList.java
@@ -276,7 +276,7 @@ public ElementInstantiationException(String msg) { private final Class<? extends E> elementClass; public ReflectiveElementFactory(Class<? extends E> elementClass) { - Assert.notNull(elementClass, "Element clas must not be null"); + Assert.notNull(elementClass, "Element class must not be ...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-core/src/main/java/org/springframework/util/CompositeIterator.java
@@ -68,7 +68,7 @@ public E next() { return iterator.next(); } } - throw new NoSuchElementException("Exhaused all iterators"); + throw new NoSuchElementException("Exhausted all iterators"); } @Override
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-core/src/main/java/org/springframework/util/StringUtils.java
@@ -208,7 +208,7 @@ public static String trimWhitespace(String str) { /** * Trim <i>all</i> whitespace from the given String: - * leading, trailing, and inbetween characters. + * leading, trailing, and in between characters. * @param str the String to check * @return the trimmed String * @see java.lan...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/CallMetaDataProvider.java
@@ -41,7 +41,7 @@ public interface CallMetaDataProvider { /** * Initialize the database specific management of procedure column meta data. - * This is only called for databases that are supported. This initalization + * This is only called for databases that are supported. This initialization * can be turne...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/CallMetaDataProviderFactory.java
@@ -61,9 +61,9 @@ public class CallMetaDataProviderFactory { ); /** - * Create a CallMetaDataProvider based on the database metedata - * @param dataSource used to retrieve metedata - * @param context the class that holds configuration and metedata + * Create a CallMetaDataProvider based on the database metad...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/GenericTableMetaDataProvider.java
@@ -340,7 +340,7 @@ private void locateTableAndProcessMetaData(DatabaseMetaData databaseMetaData, St try { tables.close(); } catch (SQLException e) { - logger.warn("Error while closing table meta data reults" + e.getMessage()); + logger.warn("Error while closing table meta data results" + e.getM...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-jdbc/src/main/java/org/springframework/jdbc/core/namedparam/ParsedSql.java
@@ -70,7 +70,7 @@ void addNamedParameter(String parameterName, int startIndex, int endIndex) { /** * Return all of the parameters (bind variables) in the parsed SQL statement. - * Repeated occurences of the same parameter name are included here. + * Repeated occurrences of the same parameter name are included ...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-jdbc/src/main/java/org/springframework/jdbc/core/simple/AbstractJdbcInsert.java
@@ -311,7 +311,7 @@ protected void checkCompiled() { } /** - * Method to check whether we are allowd to make any configuration changes at this time. + * Method to check whether we are allowed to make any configuration changes at this time. * If the class has been compiled, then no further changes to the conf...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-jdbc/src/main/java/org/springframework/jdbc/core/simple/SimpleJdbcInsertOperations.java
@@ -40,7 +40,7 @@ public interface SimpleJdbcInsertOperations { SimpleJdbcInsertOperations withTableName(String tableName); /** - * Specify the shema name, if any, to be used for the insert. + * Specify the schema name, if any, to be used for the insert. * @param schemaName the name of the schema * @retur...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-jms/src/main/java/org/springframework/jms/listener/AbstractPollingMessageListenerContainer.java
@@ -42,7 +42,7 @@ * * <p>This listener container variant is built for repeated polling attempts, * each invoking the {@link #receiveAndExecute} method. The MessageConsumer used - * may be reobtained fo reach attempt or cached inbetween attempts; this is up + * may be reobtained fo reach attempt or cached in betwe...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-messaging/src/main/java/org/springframework/messaging/simp/handler/SimpleBrokerMessageHandler.java
@@ -83,7 +83,7 @@ protected void handleMessageInternal(Message<?> message) { if (!checkDestinationPrefix(destination)) { if (logger.isTraceEnabled()) { - logger.trace("Ingoring message to destination=" + destination); + logger.trace("Ignoring message to destination=" + destination); } return; ...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-oxm/src/main/java/org/springframework/oxm/xstream/XStreamMarshaller.java
@@ -782,7 +782,7 @@ private Object doUnmarshal(HierarchicalStreamReader streamReader, DataHolder dat * {@code org.springframework.oxm} hierarchy. * <p>A boolean flag is used to indicate whether this exception occurs during marshalling or * unmarshalling, since XStream itself does not make this distinc...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-web/src/main/java/org/springframework/web/context/request/async/CallableProcessingInterceptor.java
@@ -55,7 +55,7 @@ public interface CallableProcessingInterceptor { * <p> * This is useful for capturing the state of the current thread just prior to * invoking the {@link Callable}. Once the state is captured, it can then be - * transfered to the new {@link Thread} in + * transferred to the new {@link Threa...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-web/src/main/java/org/springframework/web/context/support/ServletContextAwareProcessor.java
@@ -48,7 +48,7 @@ public class ServletContextAwareProcessor implements BeanPostProcessor { /** * Create a new ServletContextAwareProcessor without an initial context or config. * When this constructor is used the {@link #getServletContext()} and/or - * {@link #getServletConfig()} methods should be overriden. +...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-web/src/main/java/org/springframework/web/filter/OncePerRequestFilter.java
@@ -41,7 +41,7 @@ * should be involved in async dispatches. However, in some cases servlet * containers assume different default configuration. Therefore sub-classes can * override the method {@link #shouldNotFilterAsyncDispatch()} to declare - * statically if they shouuld indeed be invoked, <em>once</em>, during...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-web/src/main/java/org/springframework/web/jsf/DecoratingNavigationHandler.java
@@ -115,7 +115,7 @@ public abstract void handleNavigation( * <p>If no decorated NavigationHandler specified as constructor argument, * this instance is the last element in the chain. Hence, this method will * call the original NavigationHandler as passed into this method. If no - * original NavigantionHandler...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-web/src/main/java/org/springframework/web/util/WebAppRootListener.java
@@ -25,7 +25,7 @@ * parameter at the servlet context level (i.e. context-param in web.xml), * the default key is "webapp.root". * - * <p>Can be used for toolkits that support substition with system properties + * <p>Can be used for toolkits that support substitution with system properties * (i.e. System.getProp...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/ResourceServlet.java
@@ -295,7 +295,7 @@ private void doInclude(HttpServletRequest request, HttpServletResponse response, * to allow for message resolution etc that influences JSP contents, * assuming that those background resources might have changed on restart. * <p>Returns the startup time of this servlet if the file that corre...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/handler/AbstractHandlerExceptionResolver.java
@@ -189,7 +189,7 @@ protected void logException(Exception ex, HttpServletRequest request) { } /** - * Build a log message for the given exception, occured during processing the given request. + * Build a log message for the given exception, occurred during processing the given request. * @param ex the except...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/annotation/AnnotationMethodHandlerAdapter.java
@@ -513,7 +513,7 @@ protected HttpInputMessage createHttpInputMessage(HttpServletRequest servletRequ } /** - * Template method for creating a new HttpOuputMessage instance. + * Template method for creating a new HttpOutputMessage instance. * <p>The default implementation creates a standard {@link ServletServ...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/support/ServletUriComponentsBuilder.java
@@ -82,7 +82,7 @@ public static ServletUriComponentsBuilder fromServletMapping(HttpServletRequest /** * Prepare a builder from the host, port, scheme, and path of - * an HttpSevletRequest. + * an HttpServletRequest. */ public static ServletUriComponentsBuilder fromRequestUri(HttpServletRequest request) { ...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/support/WebContentGenerator.java
@@ -211,7 +211,7 @@ public void setAlwaysMustRevalidate(boolean mustRevalidate) { } /** - * Return whether 'must-revaliate' is added to every Cache-Control header. + * Return whether 'must-revalidate' is added to every Cache-Control header. */ public boolean isAlwaysMustRevalidate() { return alwaysMustR...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/view/BeanNameViewResolver.java
@@ -38,7 +38,7 @@ * application beans - such a separation will make this clear. * * <p>This ViewResolver does not support internationalization. - * Conside ResourceBundleViewResolver if you need to apply different + * Consider ResourceBundleViewResolver if you need to apply different * view resources per locale...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/view/ContentNegotiatingViewResolver.java
@@ -70,7 +70,7 @@ * with the view's {@linkplain View#getContentType() content type}). The most compatible view is returned. * * <p>Additionally, this view resolver exposes the {@link #setDefaultViews(List) defaultViews} property, allowing you to - * override the views provided by the view resolvers. Note that the...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/view/document/AbstractPdfStamperView.java
@@ -103,7 +103,7 @@ protected PdfReader readPdfResource() throws IOException { * e.g. setting the "formFlattening" property. * @param request in case we need locale etc. Shouldn't look at attributes. * @param response in case we need to set cookies. Shouldn't write to it. - * @throws Exception any exception t...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/view/document/AbstractPdfView.java
@@ -172,7 +172,7 @@ protected void buildPdfMetadata(Map<String, Object> model, Document document, Ht * @param writer the PdfWriter to use * @param request in case we need locale etc. Shouldn't look at attributes. * @param response in case we need to set cookies. Shouldn't write to it. - * @throws Exception an...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/view/feed/AbstractAtomFeedView.java
@@ -96,7 +96,7 @@ protected final void buildFeedEntries(Map<String, Object> model, Feed feed, * @param request in case we need locale etc. Shouldn't look at attributes. * @param response in case we need to set cookies. Shouldn't write to it. * @return the feed entries to be added to the feed - * @throws Excep...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/view/feed/AbstractFeedView.java
@@ -91,7 +91,7 @@ protected void buildFeedMetadata(Map<String, Object> model, T feed, HttpServletR * @param feed the feed to add entries to * @param request in case we need locale etc. Shouldn't look at attributes. * @param response in case we need to set cookies. Shouldn't write to it. - * @throws Exception ...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/view/feed/AbstractRssFeedView.java
@@ -79,7 +79,7 @@ protected final void buildFeedEntries(Map<String, Object> model, Channel channel * @param request in case we need locale etc. Shouldn't look at attributes. * @param response in case we need to set cookies. Shouldn't write to it. * @return the feed items to be added to the feed - * @throws E...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/view/jasperreports/AbstractJasperReportsView.java
@@ -217,7 +217,7 @@ public void setSubReportUrls(Properties subReports) { * <p>The name specified in the list should correspond to an attribute in the * model Map, and to a sub-report data source parameter in your report file. * If you pass in {@code JRDataSource} objects as model attributes, - * specifing th...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/view/velocity/VelocityToolboxView.java
@@ -73,7 +73,7 @@ public class VelocityToolboxView extends VelocityView { * to automatically load a Velocity Tools toolbox definition file and expose * all defined tools in the specified scopes. If no config location is * specified, no toolbox will be loaded and exposed. - * <p>The specfied location string ne...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/view/velocity/VelocityViewResolver.java
@@ -88,7 +88,7 @@ public void setNumberToolAttribute(String numberToolAttribute) { * to automatically load a Velocity Tools toolbox definition file and expose * all defined tools in the specified scopes. If no config location is * specified, no toolbox will be loaded and exposed. - * <p>The specfied location ...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-webmvc/src/main/java/org/springframework/web/servlet/view/xslt/XsltView.java
@@ -264,7 +264,7 @@ protected Result createResult(HttpServletResponse response) throws Exception { * an object of {@link #getSourceTypes() supported type}. * @param model the merged model Map * @return the XSLT Source object (or {@code null} if none found) - * @throws Exception if an error occured during loca...
true
Other
spring-projects
spring-framework
e9f78f6043d8391121ba93d496b66beaa13a1dca.json
Fix various typos Fix a variety of typos throughout the project, primarily in comments (javadoc or otherwise) but also in a handful of log messages and a couple exception messages. ISSUE: SPR-11123
spring-websocket/src/main/java/org/springframework/web/socket/server/endpoint/ServerEndpointRegistration.java
@@ -90,7 +90,7 @@ public ServerEndpointRegistration(String path, Class<? extends Endpoint> endpoin /** * Create a new {@link ServerEndpointRegistration} instance from an - * {@code javax.webscoket.Endpoint} instance. + * {@code javax.websocket.Endpoint} instance. * @param path the endpoint path * @param ...
true
Other
spring-projects
spring-framework
4e82416ba97abc804bd805dc4e9e10f5b3c685e7.json
Add SubProtocolCapable interface The addition of SubProtocolCapable simplifies configuration since it is no longer necessary to explicitly configure DefaultHandshakeHandler with a list of supported sub-protocols. We will not also check if the WebSocketHandler to use for the WebSocket request is an instance of SubProto...
spring-websocket/src/main/java/org/springframework/web/socket/messaging/SubProtocolWebSocketHandler.java
@@ -16,12 +16,7 @@ package org.springframework.web.socket.messaging; -import java.util.Arrays; -import java.util.HashSet; -import java.util.List; -import java.util.Map; -import java.util.Set; -import java.util.TreeMap; +import java.util.*; import java.util.concurrent.ConcurrentHashMap; import org.apache.common...
true
Other
spring-projects
spring-framework
4e82416ba97abc804bd805dc4e9e10f5b3c685e7.json
Add SubProtocolCapable interface The addition of SubProtocolCapable simplifies configuration since it is no longer necessary to explicitly configure DefaultHandshakeHandler with a list of supported sub-protocols. We will not also check if the WebSocketHandler to use for the WebSocket request is an instance of SubProto...
spring-websocket/src/main/java/org/springframework/web/socket/messaging/config/WebMvcStompEndpointRegistry.java
@@ -83,10 +83,9 @@ private static SubProtocolWebSocketHandler unwrapSubProtocolWebSocketHandler(Web public StompWebSocketEndpointRegistration addEndpoint(String... paths) { this.subProtocolWebSocketHandler.addProtocolHandler(this.stompHandler); - Set<String> subProtocols = this.subProtocolWebSocketHandler.getSu...
true
Other
spring-projects
spring-framework
4e82416ba97abc804bd805dc4e9e10f5b3c685e7.json
Add SubProtocolCapable interface The addition of SubProtocolCapable simplifies configuration since it is no longer necessary to explicitly configure DefaultHandshakeHandler with a list of supported sub-protocols. We will not also check if the WebSocketHandler to use for the WebSocket request is an instance of SubProto...
spring-websocket/src/main/java/org/springframework/web/socket/messaging/config/WebMvcStompWebSocketEndpointRegistration.java
@@ -46,8 +46,6 @@ public class WebMvcStompWebSocketEndpointRegistration implements StompWebSocketE private final WebSocketHandler webSocketHandler; - private final String[] subProtocols; - private final TaskScheduler sockJsTaskScheduler; private HandshakeHandler handshakeHandler; @@ -56,28 +54,14 @@ public ...
true
Other
spring-projects
spring-framework
4e82416ba97abc804bd805dc4e9e10f5b3c685e7.json
Add SubProtocolCapable interface The addition of SubProtocolCapable simplifies configuration since it is no longer necessary to explicitly configure DefaultHandshakeHandler with a list of supported sub-protocols. We will not also check if the WebSocketHandler to use for the WebSocket request is an instance of SubProto...
spring-websocket/src/main/java/org/springframework/web/socket/server/DefaultHandshakeHandler.java
@@ -32,8 +32,10 @@ import org.springframework.http.server.ServerHttpResponse; import org.springframework.util.ClassUtils; import org.springframework.util.StringUtils; +import org.springframework.web.socket.support.SubProtocolCapable; import org.springframework.web.socket.support.WebSocketExtension; import org.spri...
true
Other
spring-projects
spring-framework
4e82416ba97abc804bd805dc4e9e10f5b3c685e7.json
Add SubProtocolCapable interface The addition of SubProtocolCapable simplifies configuration since it is no longer necessary to explicitly configure DefaultHandshakeHandler with a list of supported sub-protocols. We will not also check if the WebSocketHandler to use for the WebSocket request is an instance of SubProto...
spring-websocket/src/main/java/org/springframework/web/socket/support/SubProtocolCapable.java
@@ -0,0 +1,19 @@ +package org.springframework.web.socket.support; + +import java.util.List; + +/** + * An interface for WebSocket handlers that support sub-protocols as defined in RFC 6455. + * + * @author Rossen Stoyanchev + * @since 4.0 + * + * @see <a href="http://tools.ietf.org/html/rfc6455#section-1.9">RFC-6455 se...
true
Other
spring-projects
spring-framework
4e82416ba97abc804bd805dc4e9e10f5b3c685e7.json
Add SubProtocolCapable interface The addition of SubProtocolCapable simplifies configuration since it is no longer necessary to explicitly configure DefaultHandshakeHandler with a list of supported sub-protocols. We will not also check if the WebSocketHandler to use for the WebSocket request is an instance of SubProto...
spring-websocket/src/test/java/org/springframework/web/socket/messaging/config/WebMvcStompEndpointRegistrationTests.java
@@ -17,7 +17,6 @@ package org.springframework.web.socket.messaging.config; import java.util.Arrays; -import java.util.Collections; import java.util.List; import java.util.Map; @@ -62,7 +61,7 @@ public void minimalRegistration() { WebMvcStompWebSocketEndpointRegistration registration = new WebMvcStompWebS...
true
Other
spring-projects
spring-framework
4e82416ba97abc804bd805dc4e9e10f5b3c685e7.json
Add SubProtocolCapable interface The addition of SubProtocolCapable simplifies configuration since it is no longer necessary to explicitly configure DefaultHandshakeHandler with a list of supported sub-protocols. We will not also check if the WebSocketHandler to use for the WebSocket request is an instance of SubProto...
spring-websocket/src/test/java/org/springframework/web/socket/server/DefaultHandshakeHandlerTests.java
@@ -16,19 +16,23 @@ package org.springframework.web.socket.server; +import java.util.Arrays; import java.util.Collections; +import java.util.List; import java.util.Map; import org.junit.Before; import org.junit.Test; import org.mockito.Mock; import org.mockito.MockitoAnnotations; import org.springframewor...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
build.gradle
@@ -26,27 +26,21 @@ configure(allprojects) { project -> apply plugin: "test-source-set-dependencies" apply from: "${gradleScriptDir}/ide.gradle" - [compileJava, compileTestJava]*.options*.compilerArgs = [ - "-Xlint:serial", - "-Xlint:varargs", - "-Xlint:cast", - "-Xlint:classfile", - "-Xlint:dep-ann", - "-X...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/IntroductionAwareMethodMatcher.java
@@ -39,6 +39,6 @@ public interface IntroductionAwareMethodMatcher extends MethodMatcher { * asking is the subject on one or more introductions; {@code false} otherwise * @return whether or not this method matches statically */ - boolean matches(Method method, Class targetClass, boolean hasIntroductions); + boo...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/IntroductionInfo.java
@@ -34,6 +34,6 @@ public interface IntroductionInfo { * Return the additional interfaces introduced by this Advisor or Advice. * @return the introduced interfaces */ - Class[] getInterfaces(); + Class<?>[] getInterfaces(); }
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/TrueClassFilter.java
@@ -35,7 +35,7 @@ private TrueClassFilter() { } @Override - public boolean matches(Class clazz) { + public boolean matches(Class<?> clazz) { return true; }
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/TrueMethodMatcher.java
@@ -41,12 +41,12 @@ public boolean isRuntime() { } @Override - public boolean matches(Method method, Class targetClass) { + public boolean matches(Method method, Class<?> targetClass) { return true; } @Override - public boolean matches(Method method, Class targetClass, Object[] args) { + public boolean m...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/AbstractAspectJAdvice.java
@@ -119,9 +119,9 @@ public static JoinPoint currentJoinPoint() { /** Non-null if after returning advice binds the return value */ private String returningName = null; - private Class discoveredReturningType = Object.class; + private Class<?> discoveredReturningType = Object.class; - private Class discoveredThro...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJAdviceParameterNameDiscoverer.java
@@ -21,15 +21,13 @@ import java.lang.reflect.Method; import java.util.ArrayList; import java.util.HashSet; -import java.util.Iterator; import java.util.List; import java.util.Set; import org.aspectj.lang.JoinPoint; import org.aspectj.lang.ProceedingJoinPoint; import org.aspectj.weaver.tools.PointcutParser; i...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJAfterThrowingAdvice.java
@@ -70,8 +70,7 @@ public Object invoke(MethodInvocation mi) throws Throwable { * is only invoked if the thrown exception is a subtype of the given throwing type. */ private boolean shouldInvokeOnThrowing(Throwable t) { - Class throwingType = getDiscoveredThrowingType(); - return throwingType.isAssignableFrom(...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJExpressionPointcut.java
@@ -98,11 +98,11 @@ public class AspectJExpressionPointcut extends AbstractExpressionPointcut private static final Log logger = LogFactory.getLog(AspectJExpressionPointcut.class); - private Class pointcutDeclarationScope; + private Class<?> pointcutDeclarationScope; private String[] pointcutParameterNames = n...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/AspectJExpressionPointcutAdvisor.java
@@ -44,7 +44,7 @@ public void setLocation(String location) { this.pointcut.setLocation(location); } - public void setParameterTypes(Class[] types) { + public void setParameterTypes(Class<?>[] types) { this.pointcut.setParameterTypes(types); }
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/DeclareParentsAdvisor.java
@@ -34,7 +34,7 @@ */ public class DeclareParentsAdvisor implements IntroductionAdvisor { - private final Class introducedInterface; + private final Class<?> introducedInterface; private final ClassFilter typePatternClassFilter; @@ -47,7 +47,7 @@ public class DeclareParentsAdvisor implements IntroductionAdvis...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/MethodInvocationProceedingJoinPoint.java
@@ -189,7 +189,7 @@ public int getModifiers() { } @Override - public Class getDeclaringType() { + public Class<?> getDeclaringType() { return methodInvocation.getMethod().getDeclaringClass(); } @@ -199,7 +199,7 @@ public String getDeclaringTypeName() { } @Override - public Class getReturnTyp...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/RuntimeTestWalker.java
@@ -87,12 +87,12 @@ public boolean testsSubtypeSensitiveVars() { new SubtypeSensitiveVarTypeTestVisitor().testsSubtypeSensitiveVars(this.runtimeTest)); } - public boolean testThisInstanceOfResidue(Class thisClass) { + public boolean testThisInstanceOfResidue(Class<?> thisClass) { return (this.runtimeTest !=...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/SimpleAspectInstanceFactory.java
@@ -29,22 +29,22 @@ */ public class SimpleAspectInstanceFactory implements AspectInstanceFactory { - private final Class aspectClass; + private final Class<?> aspectClass; /** * Create a new SimpleAspectInstanceFactory for the given aspect class. * @param aspectClass the aspect class */ - public Sim...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/TypePatternClassFilter.java
@@ -94,7 +94,7 @@ public String getTypePattern() { * @throws IllegalStateException if no {@link #setTypePattern(String)} has been set */ @Override - public boolean matches(Class clazz) { + public boolean matches(Class<?> clazz) { if (this.aspectJTypePatternMatcher == null) { throw new IllegalStateExcepti...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/AbstractAspectJAdvisorFactory.java
@@ -37,11 +37,9 @@ import org.aspectj.lang.reflect.AjType; import org.aspectj.lang.reflect.AjTypeSystem; import org.aspectj.lang.reflect.PerClauseKind; - import org.springframework.aop.aspectj.AspectJExpressionPointcut; import org.springframework.aop.framework.AopConfigException; import org.springframework.core.P...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/AnnotationAwareAspectJAutoProxyCreator.java
@@ -89,7 +89,7 @@ protected List<Advisor> findCandidateAdvisors() { } @Override - protected boolean isInfrastructureClass(Class beanClass) { + protected boolean isInfrastructureClass(Class<?> beanClass) { // Previously we setProxyTargetClass(true) in the constructor, but that has too // broad an impact. Ins...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/AspectJProxyFactory.java
@@ -50,7 +50,7 @@ public class AspectJProxyFactory extends ProxyCreatorSupport { /** Cache for singleton aspect instances */ - private static final Map<Class, Object> aspectCache = new HashMap<Class, Object>(); + private static final Map<Class<?>, Object> aspectCache = new HashMap<Class<?>, Object>(); private ...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/AspectMetadata.java
@@ -45,7 +45,7 @@ public class AspectMetadata { /** * AspectJ reflection information (AspectJ 5 / Java 5 specific). */ - private final AjType ajType; + private final AjType<?> ajType; /** * Spring AOP pointcut corresponding to the per clause of the @@ -71,9 +71,9 @@ public AspectMetadata(Class<?> aspectC...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/BeanFactoryAspectInstanceFactory.java
@@ -66,7 +66,7 @@ public BeanFactoryAspectInstanceFactory(BeanFactory beanFactory, String name) { * @param name the name of the bean * @param type the type that should be introspected by AspectJ */ - public BeanFactoryAspectInstanceFactory(BeanFactory beanFactory, String name, Class type) { + public BeanFactor...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/BeanFactoryAspectJAdvisorsBuilder.java
@@ -96,7 +96,7 @@ public List<Advisor> buildAspectJAdvisors() { // We must be careful not to instantiate beans eagerly as in this // case they would be cached by the Spring container but would not // have been weaved - Class beanType = this.beanFactory.getType(beanName); + Class<?> beanType = ...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/InstantiationModelAwarePointcutAdvisorImpl.java
@@ -249,14 +249,14 @@ private PerTargetInstantiationModelPointcut(AspectJExpressionPointcut declaredPo } @Override - public boolean matches(Method method, Class targetClass) { + public boolean matches(Method method, Class<?> targetClass) { // We're either instantiated and matching on declared pointcut, or...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/ReflectiveAspectJAdvisorFactory.java
@@ -190,7 +190,7 @@ private AspectJExpressionPointcut getPointcut(Method candidateAdviceMethod, Clas return null; } AspectJExpressionPointcut ajexp = - new AspectJExpressionPointcut(candidateAspectClass, new String[0], new Class[0]); + new AspectJExpressionPointcut(candidateAspectClass, new String[0], n...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/annotation/SimpleMetadataAwareAspectInstanceFactory.java
@@ -40,7 +40,7 @@ public class SimpleMetadataAwareAspectInstanceFactory extends SimpleAspectInstan * @param aspectClass the aspect class * @param aspectName the aspect name */ - public SimpleMetadataAwareAspectInstanceFactory(Class aspectClass, String aspectName) { + public SimpleMetadataAwareAspectInstanceFac...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/autoproxy/AspectJAwareAdvisorAutoProxyCreator.java
@@ -46,7 +46,7 @@ @SuppressWarnings("serial") public class AspectJAwareAdvisorAutoProxyCreator extends AbstractAdvisorAutoProxyCreator { - private static final Comparator DEFAULT_PRECEDENCE_COMPARATOR = new AspectJPrecedenceComparator(); + private static final Comparator<Advisor> DEFAULT_PRECEDENCE_COMPARATOR = new...
true
Other
spring-projects
spring-framework
59002f245623d758765b72d598cd78c326c6f5fa.json
Fix remaining compiler warnings Fix remaining Java compiler warnings, mainly around missing generics or deprecated code. Also add the `-Werror` compiler option to ensure that any future warnings will fail the build. Issue: SPR-11064
spring-aop/src/main/java/org/springframework/aop/aspectj/autoproxy/AspectJPrecedenceComparator.java
@@ -48,7 +48,7 @@ * @author Juergen Hoeller * @since 2.0 */ -class AspectJPrecedenceComparator implements Comparator { +class AspectJPrecedenceComparator implements Comparator<Advisor> { private static final int HIGHER_PRECEDENCE = -1; private static final int SAME_PRECEDENCE = 0; @@ -76,18 +76,10 @@ public...
true