language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | spring-projects | spring-framework | 7c3cdf82cc3bff05a61595db3bcb0a6cf644e116.json | Try a different mbean port | spring-context/src/test/java/org/springframework/jmx/support/MBeanServerConnectionFactoryBeanTests.java | @@ -37,7 +37,7 @@
*/
public class MBeanServerConnectionFactoryBeanTests extends AbstractMBeanServerTests {
- private static final String SERVICE_URL = "service:jmx:jmxmp://localhost:9876";
+ private static final String SERVICE_URL = "service:jmx:jmxmp://localhost:9878";
private JMXServiceURL getServiceUrl() throws MalformedURLException {
return new JMXServiceURL(SERVICE_URL); | false |
Other | spring-projects | spring-framework | b830d7362df24ed0953009b8172a7d67f7b73fe9.json | Support non-public anno. attr. values in AnnoUtils
Prior to this commit, the getValue(Annotation, String) method in
AnnotationUtils failed to retrieve the value of the desired annotation
attribute if the annotation itself was not public -- for example if the
annotation was declared as package private.
This commit addresses this issue by ensuring that getValue(Annotation,
String) uses reflection to make the desired annotation attribute method
accessible before attempting to invoke it to retrieve the value.
Issue: SPR-11104 | spring-core/src/main/java/org/springframework/core/annotation/AnnotationUtils.java | @@ -31,6 +31,7 @@
import org.springframework.core.BridgeMethodResolver;
import org.springframework.util.Assert;
import org.springframework.util.ObjectUtils;
+import org.springframework.util.ReflectionUtils;
/**
* General utility methods for working with annotations, handling bridge methods (which the compiler
@@ -525,6 +526,7 @@ public static Object getValue(Annotation annotation) {
public static Object getValue(Annotation annotation, String attributeName) {
try {
Method method = annotation.annotationType().getDeclaredMethod(attributeName, new Class[0]);
+ ReflectionUtils.makeAccessible(method);
return method.invoke(annotation);
}
catch (Exception ex) {
@@ -585,7 +587,6 @@ public static Object getDefaultValue(Class<? extends Annotation> annotationType,
private static class AnnotationCollector<A extends Annotation> {
-
private final Class<? extends Annotation> containerAnnotationType;
private final Class<A> annotationType;
@@ -628,6 +629,7 @@ else if (ObjectUtils.nullSafeEquals(this.containerAnnotationType, annotation.ann
private A[] getValue(Annotation annotation) {
try {
Method method = annotation.annotationType().getDeclaredMethod("value");
+ ReflectionUtils.makeAccessible(method);
return (A[]) method.invoke(annotation);
}
catch (Exception ex) { | true |
Other | spring-projects | spring-framework | b830d7362df24ed0953009b8172a7d67f7b73fe9.json | Support non-public anno. attr. values in AnnoUtils
Prior to this commit, the getValue(Annotation, String) method in
AnnotationUtils failed to retrieve the value of the desired annotation
attribute if the annotation itself was not public -- for example if the
annotation was declared as package private.
This commit addresses this issue by ensuring that getValue(Annotation,
String) uses reflection to make the desired annotation attribute method
accessible before attempting to invoke it to retrieve the value.
Issue: SPR-11104 | spring-core/src/test/java/org/springframework/core/annotation/AnnotationUtilsTests.java | @@ -29,10 +29,10 @@
import org.junit.Test;
import org.springframework.core.Ordered;
+import org.springframework.core.annotation.subpackage.NonPublicAnnotatedClass;
import org.springframework.stereotype.Component;
import static org.hamcrest.Matchers.*;
-
import static org.junit.Assert.*;
import static org.springframework.core.annotation.AnnotationUtils.*;
@@ -46,37 +46,37 @@
public class AnnotationUtilsTests {
@Test
- public void testFindMethodAnnotationOnLeaf() throws SecurityException, NoSuchMethodException {
+ public void findMethodAnnotationOnLeaf() throws Exception {
Method m = Leaf.class.getMethod("annotatedOnLeaf", (Class[]) null);
assertNotNull(m.getAnnotation(Order.class));
assertNotNull(getAnnotation(m, Order.class));
assertNotNull(findAnnotation(m, Order.class));
}
@Test
- public void testFindMethodAnnotationOnRoot() throws SecurityException, NoSuchMethodException {
+ public void findMethodAnnotationOnRoot() throws Exception {
Method m = Leaf.class.getMethod("annotatedOnRoot", (Class[]) null);
assertNotNull(m.getAnnotation(Order.class));
assertNotNull(getAnnotation(m, Order.class));
assertNotNull(findAnnotation(m, Order.class));
}
@Test
- public void testFindMethodAnnotationOnRootButOverridden() throws SecurityException, NoSuchMethodException {
+ public void findMethodAnnotationOnRootButOverridden() throws Exception {
Method m = Leaf.class.getMethod("overrideWithoutNewAnnotation", (Class[]) null);
assertNull(m.getAnnotation(Order.class));
assertNull(getAnnotation(m, Order.class));
assertNotNull(findAnnotation(m, Order.class));
}
@Test
- public void testFindMethodAnnotationNotAnnotated() throws SecurityException, NoSuchMethodException {
+ public void findMethodAnnotationNotAnnotated() throws Exception {
Method m = Leaf.class.getMethod("notAnnotated", (Class[]) null);
assertNull(findAnnotation(m, Order.class));
}
@Test
- public void testFindMethodAnnotationOnBridgeMethod() throws Exception {
+ public void findMethodAnnotationOnBridgeMethod() throws Exception {
Method m = SimpleFoo.class.getMethod("something", Object.class);
assertTrue(m.isBridge());
assertNull(m.getAnnotation(Order.class));
@@ -88,7 +88,7 @@ public void testFindMethodAnnotationOnBridgeMethod() throws Exception {
}
// TODO consider whether we want this to handle annotations on interfaces
- // public void testFindMethodAnnotationFromInterfaceImplementedByRoot()
+ // public void findMethodAnnotationFromInterfaceImplementedByRoot()
// throws Exception {
// Method m = Leaf.class.getMethod("fromInterfaceImplementedByRoot",
// (Class[]) null);
@@ -241,7 +241,7 @@ public void testIsAnnotationInherited() throws Exception {
}
@Test
- public void testGetValueFromAnnotation() throws Exception {
+ public void getValueFromAnnotation() throws Exception {
Method method = SimpleFoo.class.getMethod("something", Object.class);
Order order = findAnnotation(method, Order.class);
@@ -250,7 +250,18 @@ public void testGetValueFromAnnotation() throws Exception {
}
@Test
- public void testGetDefaultValueFromAnnotation() throws Exception {
+ public void getValueFromNonPublicAnnotation() throws Exception {
+ Annotation[] declaredAnnotations = NonPublicAnnotatedClass.class.getDeclaredAnnotations();
+ assertEquals(1, declaredAnnotations.length);
+ Annotation annotation = declaredAnnotations[0];
+ assertNotNull(annotation);
+ assertEquals("NonPublicAnnotation", annotation.annotationType().getSimpleName());
+ assertEquals(42, AnnotationUtils.getValue(annotation, AnnotationUtils.VALUE));
+ assertEquals(42, AnnotationUtils.getValue(annotation));
+ }
+
+ @Test
+ public void getDefaultValueFromAnnotation() throws Exception {
Method method = SimpleFoo.class.getMethod("something", Object.class);
Order order = findAnnotation(method, Order.class);
@@ -259,34 +270,46 @@ public void testGetDefaultValueFromAnnotation() throws Exception {
}
@Test
- public void testGetDefaultValueFromAnnotationType() throws Exception {
+ public void getDefaultValueFromNonPublicAnnotation() throws Exception {
+ Annotation[] declaredAnnotations = NonPublicAnnotatedClass.class.getDeclaredAnnotations();
+ assertEquals(1, declaredAnnotations.length);
+ Annotation annotation = declaredAnnotations[0];
+ assertNotNull(annotation);
+ assertEquals("NonPublicAnnotation", annotation.annotationType().getSimpleName());
+ assertEquals(-1, AnnotationUtils.getDefaultValue(annotation, AnnotationUtils.VALUE));
+ assertEquals(-1, AnnotationUtils.getDefaultValue(annotation));
+ }
+
+ @Test
+ public void getDefaultValueFromAnnotationType() throws Exception {
assertEquals(Ordered.LOWEST_PRECEDENCE, AnnotationUtils.getDefaultValue(Order.class, AnnotationUtils.VALUE));
assertEquals(Ordered.LOWEST_PRECEDENCE, AnnotationUtils.getDefaultValue(Order.class));
}
@Test
- public void testFindAnnotationFromInterface() throws Exception {
+ public void findAnnotationFromInterface() throws Exception {
Method method = ImplementsInterfaceWithAnnotatedMethod.class.getMethod("foo");
Order order = findAnnotation(method, Order.class);
assertNotNull(order);
}
@Test
- public void testFindAnnotationFromInterfaceOnSuper() throws Exception {
+ public void findAnnotationFromInterfaceOnSuper() throws Exception {
Method method = SubOfImplementsInterfaceWithAnnotatedMethod.class.getMethod("foo");
Order order = findAnnotation(method, Order.class);
assertNotNull(order);
}
@Test
- public void testFindAnnotationFromInterfaceWhenSuperDoesNotImplementMethod() throws Exception {
+ public void findAnnotationFromInterfaceWhenSuperDoesNotImplementMethod()
+ throws Exception {
Method method = SubOfAbstractImplementsInterfaceWithAnnotatedMethod.class.getMethod("foo");
Order order = findAnnotation(method, Order.class);
assertNotNull(order);
}
@Test
- public void testGetRepeatableFromMethod() throws Exception {
+ public void getRepeatableFromMethod() throws Exception {
Method method = InterfaceWithRepeated.class.getMethod("foo");
Set<MyRepeatable> annotions = AnnotationUtils.getRepeatableAnnotation(method,
MyRepeatableContainer.class, MyRepeatable.class);
@@ -319,6 +342,7 @@ static interface InterfaceWithMetaAnnotation {
static class ClassWithLocalMetaAnnotationAndMetaAnnotatedInterface implements InterfaceWithMetaAnnotation {
}
+
public static interface AnnotatedInterface {
@Order(0) | true |
Other | spring-projects | spring-framework | b830d7362df24ed0953009b8172a7d67f7b73fe9.json | Support non-public anno. attr. values in AnnoUtils
Prior to this commit, the getValue(Annotation, String) method in
AnnotationUtils failed to retrieve the value of the desired annotation
attribute if the annotation itself was not public -- for example if the
annotation was declared as package private.
This commit addresses this issue by ensuring that getValue(Annotation,
String) uses reflection to make the desired annotation attribute method
accessible before attempting to invoke it to retrieve the value.
Issue: SPR-11104 | spring-core/src/test/java/org/springframework/core/annotation/subpackage/NonPublicAnnotatedClass.java | @@ -0,0 +1,28 @@
+/*
+ * Copyright 2002-2013 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.core.annotation.subpackage;
+
+/**
+ * Class annotated with a non-public (i.e., package private) custom annotation.
+ *
+ * @author Sam Brannen
+ * @since 4.0
+ */
+@NonPublicAnnotation(42)
+public class NonPublicAnnotatedClass {
+
+} | true |
Other | spring-projects | spring-framework | b830d7362df24ed0953009b8172a7d67f7b73fe9.json | Support non-public anno. attr. values in AnnoUtils
Prior to this commit, the getValue(Annotation, String) method in
AnnotationUtils failed to retrieve the value of the desired annotation
attribute if the annotation itself was not public -- for example if the
annotation was declared as package private.
This commit addresses this issue by ensuring that getValue(Annotation,
String) uses reflection to make the desired annotation attribute method
accessible before attempting to invoke it to retrieve the value.
Issue: SPR-11104 | spring-core/src/test/java/org/springframework/core/annotation/subpackage/NonPublicAnnotation.java | @@ -0,0 +1,32 @@
+/*
+ * Copyright 2002-2013 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.core.annotation.subpackage;
+
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+
+/**
+ * Non-public (i.e., package private) custom annotation.
+ *
+ * @author Sam Brannen
+ * @since 4.0
+ */
+@Retention(RetentionPolicy.RUNTIME)
+@interface NonPublicAnnotation {
+
+ int value() default -1;
+} | true |
Other | spring-projects | spring-framework | 9c2046c3ee6a1c3699346bf7bdea27b483be2b86.json | Update main source and target JDK compatibility
Update source and target compatibility from 1.5 to 1.6, meaning that
@Override is now allowed on implementations of interface methods within
main classes.
Issue: SPR-10130 | build.gradle | @@ -33,8 +33,8 @@ configure(allprojects) {
group = "org.springframework"
compileJava {
- sourceCompatibility=1.5
- targetCompatibility=1.5
+ sourceCompatibility=1.6
+ targetCompatibility=1.6
}
compileTestJava {
sourceCompatibility=1.7 | false |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/aspectj/AspectJExpressionPointcutTests.java | @@ -113,6 +113,7 @@ public void testTarget() throws SecurityException, NoSuchMethodException {
public static class OtherIOther implements IOther {
+ @Override
public void absquatulate() {
// Empty
}
@@ -354,6 +355,7 @@ class CallCountingInterceptor implements MethodInterceptor {
private int count;
+ @Override
public Object invoke(MethodInvocation methodInvocation) throws Throwable {
count++;
return methodInvocation.proceed(); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/aspectj/BeanNamePointcutMatchingTests.java | @@ -90,6 +90,7 @@ private void assertMisMatch(String beanName, String pcExpression) {
private static boolean matches(final String beanName, String pcExpression) {
@SuppressWarnings("serial")
AspectJExpressionPointcut pointcut = new AspectJExpressionPointcut() {
+ @Override
protected String getCurrentProxiedBeanName() {
return beanName;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/aspectj/MethodInvocationProceedingJoinPointTests.java | @@ -79,6 +79,7 @@ public void testCanGetMethodSignatureFromJoinPoint() {
pf.addAdvice(new MethodBeforeAdvice() {
private int depth;
+ @Override
public void before(Method method, Object[] args, Object target) throws Throwable {
JoinPoint jp = AbstractAspectJAdvice.currentJoinPoint();
assertTrue("Method named in toString", jp.toString().contains(method.getName()));
@@ -135,6 +136,7 @@ public void testCanGetSourceLocationFromJoinPoint() {
ProxyFactory pf = new ProxyFactory(raw);
pf.addAdvisor(ExposeInvocationInterceptor.ADVISOR);
pf.addAdvice(new MethodBeforeAdvice() {
+ @Override
public void before(Method method, Object[] args, Object target) throws Throwable {
SourceLocation sloc = AbstractAspectJAdvice.currentJoinPoint().getSourceLocation();
assertEquals("Same source location must be returned on subsequent requests", sloc, AbstractAspectJAdvice.currentJoinPoint().getSourceLocation());
@@ -167,6 +169,7 @@ public void testCanGetStaticPartFromJoinPoint() {
ProxyFactory pf = new ProxyFactory(raw);
pf.addAdvisor(ExposeInvocationInterceptor.ADVISOR);
pf.addAdvice(new MethodBeforeAdvice() {
+ @Override
public void before(Method method, Object[] args, Object target) throws Throwable {
StaticPart staticPart = AbstractAspectJAdvice.currentJoinPoint().getStaticPart();
assertEquals("Same static part must be returned on subsequent requests", staticPart, AbstractAspectJAdvice.currentJoinPoint().getStaticPart());
@@ -186,6 +189,7 @@ public void toShortAndLongStringFormedCorrectly() throws Exception {
ProxyFactory pf = new ProxyFactory(raw);
pf.addAdvisor(ExposeInvocationInterceptor.ADVISOR);
pf.addAdvice(new MethodBeforeAdvice() {
+ @Override
public void before(Method method, Object[] args, Object target) throws Throwable {
// makeEncSJP, although meant for computing the enclosing join point,
// it serves our purpose here | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/aspectj/TrickyAspectJPointcutExpressionTests.java | @@ -137,6 +137,7 @@ public static interface TestService {
@Log
public static class TestServiceImpl implements TestService {
+ @Override
public String sayHello() {
throw new TestException("TestServiceImpl");
}
@@ -148,6 +149,7 @@ public class LogUserAdvice implements MethodBeforeAdvice, ThrowsAdvice {
private int countThrows = 0;
+ @Override
public void before(Method method, Object[] objects, Object o) throws Throwable {
countBefore++;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/aspectj/annotation/AbstractAspectJAdvisorFactoryTests.java | @@ -675,19 +675,23 @@ public int getInstantiationCount() {
return this.count;
}
+ @Override
public Object getAspectInstance() {
++this.count;
return new PerTypeWithinAspect();
}
+ @Override
public ClassLoader getAspectClassLoader() {
return PerTypeWithinAspect.class.getClassLoader();
}
+ @Override
public AspectMetadata getAspectMetadata() {
return new AspectMetadata(PerTypeWithinAspect.class, "perTypeWithin");
}
+ @Override
public int getOrder() {
return Ordered.LOWEST_PRECEDENCE;
}
@@ -897,14 +901,17 @@ public interface MutableModifable extends Modifiable {
public static class ModifiableImpl implements MutableModifable {
private boolean modified;
+ @Override
public void acceptChanges() {
modified = false;
}
+ @Override
public boolean isModified() {
return modified;
}
+ @Override
public void markDirty() {
this.modified = true;
}
@@ -1020,17 +1027,21 @@ public void checkNotLocked(
class CannotBeUnlocked implements Lockable, Comparable<Object> {
+ @Override
public void lock() {
}
+ @Override
public void unlock() {
throw new UnsupportedOperationException();
}
+ @Override
public boolean locked() {
return true;
}
+ @Override
public int compareTo(Object arg0) {
throw new UnsupportedOperationException();
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/aspectj/annotation/ArgumentBindingTests.java | @@ -84,6 +84,7 @@ public interface ITransactionalBean {
public static class TransactionalBean implements ITransactionalBean {
+ @Override
@Transactional
public void doInTransaction() {
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/aspectj/annotation/AspectProxyFactoryTests.java | @@ -111,6 +111,7 @@ public static class TestBean implements ITestBean {
private int age;
+ @Override
public int getAge() {
return age;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/aspectj/autoproxy/AspectJPrecedenceComparatorTests.java | @@ -194,6 +194,7 @@ private Advisor createAspectJAdvice(int advisorOrder, int adviceDeclarationOrder
private Advisor createSpringAOPAfterAdvice(int order) {
AfterReturningAdvice advice = new AfterReturningAdvice() {
+ @Override
public void afterReturning(Object returnValue, Method method, Object[] args, Object target) throws Throwable {
}
}; | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/framework/AopProxyUtilsTests.java | @@ -129,6 +129,7 @@ public void testProxiedUserInterfacesWithMultipleInterfaces() {
public void testProxiedUserInterfacesWithNoInterface() {
Object proxy = Proxy.newProxyInstance(getClass().getClassLoader(), new Class[0],
new InvocationHandler() {
+ @Override
public Object invoke(Object proxy, Method method, Object[] args) throws Throwable {
return null;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/framework/IntroductionBenchmarkTests.java | @@ -42,6 +42,7 @@ public final class IntroductionBenchmarkTests {
@SuppressWarnings("serial")
public static class SimpleCounterIntroduction extends DelegatingIntroductionInterceptor implements Counter {
+ @Override
public int getCount() {
return EXPECTED_COMPARE;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/framework/MethodInvocationTests.java | @@ -42,6 +42,7 @@ public void testValidInvocation() throws Throwable {
final Object returnValue = new Object();
List<Object> is = new LinkedList<Object>();
is.add(new MethodInterceptor() {
+ @Override
public Object invoke(MethodInvocation invocation) throws Throwable {
return returnValue;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/framework/NullPrimitiveTests.java | @@ -44,6 +44,7 @@ static interface Foo {
public void testNullPrimitiveWithJdkProxy() {
class SimpleFoo implements Foo {
+ @Override
public int getValue() {
return 100;
}
@@ -52,6 +53,7 @@ public int getValue() {
SimpleFoo target = new SimpleFoo();
ProxyFactory factory = new ProxyFactory(target);
factory.addAdvice(new MethodInterceptor() {
+ @Override
public Object invoke(MethodInvocation invocation) throws Throwable {
return null;
}
@@ -76,6 +78,7 @@ public void testNullPrimitiveWithCglibProxy() {
Bar target = new Bar();
ProxyFactory factory = new ProxyFactory(target);
factory.addAdvice(new MethodInterceptor() {
+ @Override
public Object invoke(MethodInvocation invocation) throws Throwable {
return null;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/framework/PrototypeTargetTests.java | @@ -73,6 +73,7 @@ public TestBeanImpl() {
constructionCount++;
}
+ @Override
public void doSomething() {
}
}
@@ -81,6 +82,7 @@ public void doSomething() {
public static class TestInterceptor implements MethodInterceptor {
private int invocationCount = 0;
+ @Override
public Object invoke(MethodInvocation methodInvocation) throws Throwable {
invocationCount++;
return methodInvocation.proceed(); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/framework/ProxyFactoryTests.java | @@ -165,6 +165,7 @@ public void testReplaceAdvisor() {
@Test
public void testAddRepeatedInterface() {
TimeStamped tst = new TimeStamped() {
+ @Override
public long getTimeStamp() {
throw new UnsupportedOperationException("getTimeStamp");
}
@@ -181,6 +182,7 @@ public long getTimeStamp() {
public void testGetsAllInterfaces() throws Exception {
// Extend to get new interface
class TestBeanSubclass extends TestBean implements Comparable<Object> {
+ @Override
public int compareTo(Object arg0) {
throw new UnsupportedOperationException("compareTo");
}
@@ -214,6 +216,7 @@ public int compareTo(Object arg0) {
@Test
public void testInterceptorInclusionMethods() {
class MyInterceptor implements MethodInterceptor {
+ @Override
public Object invoke(MethodInvocation invocation) throws Throwable {
throw new UnsupportedOperationException();
}
@@ -350,6 +353,7 @@ public void setTime(long ts) {
this.ts = ts;
}
+ @Override
public long getTimeStamp() {
return ts;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/framework/adapter/ThrowsAdviceInterceptorTests.java | @@ -125,6 +125,7 @@ public void testHandlerMethodThrowsException() throws Throwable {
@SuppressWarnings("serial")
MyThrowsHandler th = new MyThrowsHandler() {
+ @Override
public void afterThrowing(RemoteException ex) throws Throwable {
super.afterThrowing(ex);
throw t; | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/interceptor/ConcurrencyThrottleInterceptorTests.java | @@ -120,6 +120,7 @@ public ConcurrencyThread(ITestBean proxy, Throwable ex) {
this.ex = ex;
}
+ @Override
public void run() {
if (this.ex != null) {
try { | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/interceptor/CustomizableTraceInterceptorTests.java | @@ -189,6 +189,7 @@ public StubCustomizableTraceInterceptor(Log log) {
this.log = log;
}
+ @Override
protected Log getLoggerForInvocation(MethodInvocation invocation) {
return this.log;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/interceptor/DebugInterceptorTests.java | @@ -96,6 +96,7 @@ public StubDebugInterceptor(Log log) {
this.log = log;
}
+ @Override
protected Log getLoggerForInvocation(MethodInvocation invocation) {
return log;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/interceptor/ExposeBeanNameAdvisorsTests.java | @@ -38,6 +38,7 @@ public RequiresBeanNameBoundTestBean(String beanName) {
this.beanName = beanName;
}
+ @Override
public int getAge() {
assertEquals(beanName, ExposeBeanNameAdvisors.getBeanName());
return super.getAge(); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/interceptor/ExposeInvocationInterceptorTests.java | @@ -53,12 +53,14 @@ public void testXmlConfig() {
abstract class ExposedInvocationTestBean extends TestBean {
+ @Override
public String getName() {
MethodInvocation invocation = ExposeInvocationInterceptor.currentInvocation();
assertions(invocation);
return super.getName();
}
+ @Override
public void absquatulate() {
MethodInvocation invocation = ExposeInvocationInterceptor.currentInvocation();
assertions(invocation);
@@ -70,6 +72,7 @@ public void absquatulate() {
class InvocationCheckExposedInvocationTestBean extends ExposedInvocationTestBean {
+ @Override
protected void assertions(MethodInvocation invocation) {
assertTrue(invocation.getThis() == this);
assertTrue("Invocation should be on ITestBean: " + invocation.getMethod(), | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/support/AopUtilsTests.java | @@ -40,6 +40,7 @@ public final class AopUtilsTests {
@Test
public void testPointcutCanNeverApply() {
class TestPointcut extends StaticMethodMatcherPointcut {
+ @Override
public boolean matches(Method method, Class<?> clazzy) {
return false;
}
@@ -58,6 +59,7 @@ public void testPointcutAlwaysApplies() {
@Test
public void testPointcutAppliesToOneMethodOnObject() {
class TestPointcut extends StaticMethodMatcherPointcut {
+ @Override
public boolean matches(Method method, Class<?> clazz) {
return method.getName().equals("hashCode");
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/support/ComposablePointcutTests.java | @@ -35,24 +35,28 @@
public final class ComposablePointcutTests {
public static MethodMatcher GETTER_METHOD_MATCHER = new StaticMethodMatcher() {
+ @Override
public boolean matches(Method m, Class<?> targetClass) {
return m.getName().startsWith("get");
}
};
public static MethodMatcher GET_AGE_METHOD_MATCHER = new StaticMethodMatcher() {
+ @Override
public boolean matches(Method m, Class<?> targetClass) {
return m.getName().equals("getAge");
}
};
public static MethodMatcher ABSQUATULATE_METHOD_MATCHER = new StaticMethodMatcher() {
+ @Override
public boolean matches(Method m, Class<?> targetClass) {
return m.getName().equals("absquatulate");
}
};
public static MethodMatcher SETTER_METHOD_MATCHER = new StaticMethodMatcher() {
+ @Override
public boolean matches(Method m, Class<?> targetClass) {
return m.getName().startsWith("set");
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/support/DelegatingIntroductionInterceptorTests.java | @@ -112,8 +112,10 @@ public void testIntroductionInterceptorWithSuperInterface() throws Exception {
public void testAutomaticInterfaceRecognitionInDelegate() throws Exception {
final long t = 1001L;
class Tester implements TimeStamped, ITester {
+ @Override
public void foo() throws Exception {
}
+ @Override
public long getTimeStamp() {
return t;
}
@@ -141,8 +143,10 @@ public void testAutomaticInterfaceRecognitionInSubclass() throws Exception {
final long t = 1001L;
@SuppressWarnings("serial")
class TestII extends DelegatingIntroductionInterceptor implements TimeStamped, ITester {
+ @Override
public void foo() throws Exception {
}
+ @Override
public long getTimeStamp() {
return t;
}
@@ -206,6 +210,7 @@ public void testDelegateReturnsThisIsMassagedToReturnProxy() {
String company = "Interface21";
target.setCompany(company);
TestBean delegate = new TestBean() {
+ @Override
public ITestBean getSpouse() {
return this;
}
@@ -250,6 +255,7 @@ public void testIntroductionMasksTargetImplementation() throws Exception {
final long t = 1001L;
@SuppressWarnings("serial")
class TestII extends DelegatingIntroductionInterceptor implements TimeStamped {
+ @Override
public long getTimeStamp() {
return t;
}
@@ -278,6 +284,7 @@ public SerializableTimeStamped(long ts) {
this.ts = ts;
}
+ @Override
public long getTimeStamp() {
return ts;
}
@@ -292,6 +299,7 @@ public TargetClass(long t) {
this.t = t;
}
+ @Override
public long getTimeStamp() {
return t;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/support/JdkRegexpMethodPointcutTests.java | @@ -21,6 +21,7 @@
*/
public final class JdkRegexpMethodPointcutTests extends AbstractRegexpMethodPointcutTests {
+ @Override
protected AbstractRegexpMethodPointcut getRegexpMethodPointcut() {
return new JdkRegexpMethodPointcut();
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/support/MethodMatchersTests.java | @@ -107,19 +107,22 @@ public static class StartsWithMatcher extends StaticMethodMatcher {
public StartsWithMatcher(String s) {
this.prefix = s;
}
+ @Override
public boolean matches(Method m, Class<?> targetClass) {
return m.getName().startsWith(prefix);
}
}
private static class TestDynamicMethodMatcherWhichMatches extends DynamicMethodMatcher {
+ @Override
public boolean matches(Method m, Class<?> targetClass, Object[] args) {
return true;
}
}
private static class TestDynamicMethodMatcherWhichDoesNotMatch extends DynamicMethodMatcher {
+ @Override
public boolean matches(Method m, Class<?> targetClass, Object[] args) {
return false;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/support/PointcutsTests.java | @@ -53,14 +53,17 @@ public final class PointcutsTests {
* Matches only TestBean class, not subclasses
*/
public static Pointcut allTestBeanMethodsPointcut = new StaticMethodMatcherPointcut() {
+ @Override
public ClassFilter getClassFilter() {
return new ClassFilter() {
+ @Override
public boolean matches(Class<?> clazz) {
return clazz.equals(TestBean.class);
}
};
}
+ @Override
public boolean matches(Method m, Class<?> targetClass) {
return true;
}
@@ -73,21 +76,25 @@ public static class MyTestBean extends TestBean {
}
public static Pointcut myTestBeanSetterPointcut = new StaticMethodMatcherPointcut() {
+ @Override
public ClassFilter getClassFilter() {
return new RootClassFilter(MyTestBean.class);
}
+ @Override
public boolean matches(Method m, Class<?> targetClass) {
return m.getName().startsWith("set");
}
};
// Will match MyTestBeanSubclass
public static Pointcut myTestBeanGetterPointcut = new StaticMethodMatcherPointcut() {
+ @Override
public ClassFilter getClassFilter() {
return new RootClassFilter(MyTestBean.class);
}
+ @Override
public boolean matches(Method m, Class<?> targetClass) {
return m.getName().startsWith("get");
}
@@ -98,10 +105,12 @@ public static class MyTestBeanSubclass extends MyTestBean {
}
public static Pointcut myTestBeanSubclassGetterPointcut = new StaticMethodMatcherPointcut() {
+ @Override
public ClassFilter getClassFilter() {
return new RootClassFilter(MyTestBeanSubclass.class);
}
+ @Override
public boolean matches(Method m, Class<?> targetClass) {
return m.getName().startsWith("get");
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/target/LazyCreationTargetSourceTests.java | @@ -32,9 +32,11 @@ public final class LazyCreationTargetSourceTests {
@Test
public void testCreateLazy() {
TargetSource targetSource = new AbstractLazyCreationTargetSource() {
+ @Override
protected Object createObject() {
return new InitCountingBean();
}
+ @Override
public Class<?> getTargetClass() {
return InitCountingBean.class;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/target/LazyInitTargetSourceTests.java | @@ -83,6 +83,7 @@ public void testLazyInitFactoryBeanTargetSource() {
@SuppressWarnings("serial")
public static class CustomLazyInitTargetSource extends LazyInitTargetSource {
+ @Override
protected void postProcessTargetObject(Object targetObject) {
((ITestBean) targetObject).setName("Rob Harrop");
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/target/PrototypeBasedTargetSourceTests.java | @@ -70,10 +70,12 @@ private static class TestTargetSource extends AbstractPrototypeBasedTargetSource
*/
private TestBean thisFieldIsNotSerializable = new TestBean();
+ @Override
public Object getTarget() throws Exception {
return newPrototypeInstance();
}
+ @Override
public void releaseTarget(Object target) throws Exception {
// Do nothing
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/target/ThreadLocalTargetSourceTests.java | @@ -113,6 +113,7 @@ public void testNewThreadHasOwnInstance() throws InterruptedException {
class Runner implements Runnable {
public SideEffectBean mine;
+ @Override
public void run() {
this.mine = (SideEffectBean) beanFactory.getBean("apartment");
assertEquals(INITIAL_COUNT, mine.getCount() ); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/org/springframework/aop/target/dynamic/RefreshableTargetSourceTests.java | @@ -116,6 +116,7 @@ public CountingRefreshableTargetSource(boolean requiresRefresh) {
this.requiresRefresh = requiresRefresh;
}
+ @Override
protected Object freshTarget() {
this.callCount++;
return new Object();
@@ -125,6 +126,7 @@ public int getCallCount() {
return this.callCount;
}
+ @Override
protected boolean requiresRefresh() {
return this.requiresRefresh;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/test/aop/CountingBeforeAdvice.java | @@ -28,6 +28,7 @@
@SuppressWarnings("serial")
public class CountingBeforeAdvice extends MethodCounter implements MethodBeforeAdvice {
+ @Override
public void before(Method m, Object[] args, Object target) throws Throwable {
count(m);
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/test/aop/DefaultLockable.java | @@ -25,14 +25,17 @@ public class DefaultLockable implements Lockable {
private boolean locked;
+ @Override
public void lock() {
this.locked = true;
}
+ @Override
public void unlock() {
this.locked = false;
}
+ @Override
public boolean locked() {
return this.locked;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/test/aop/NopInterceptor.java | @@ -31,6 +31,7 @@ public class NopInterceptor implements MethodInterceptor {
/**
* @see org.aopalliance.intercept.MethodInterceptor#invoke(MethodInvocation)
*/
+ @Override
public Object invoke(MethodInvocation invocation) throws Throwable {
increment();
return invocation.proceed(); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/test/aop/PerTargetAspect.java | @@ -25,6 +25,7 @@ public void countSetter() {
++count;
}
+ @Override
public int getOrder() {
return this.order;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/test/aop/SerializableNopInterceptor.java | @@ -37,10 +37,12 @@ public class SerializableNopInterceptor extends NopInterceptor implements Serial
*/
private int count;
+ @Override
public int getCount() {
return this.count;
}
+ @Override
protected void increment() {
++count;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/test/beans/DerivedTestBean.java | @@ -51,12 +51,14 @@ public static DerivedTestBean create(String[] names) {
}
+ @Override
public void setBeanName(String beanName) {
if (this.beanName == null || beanName == null) {
this.beanName = beanName;
}
}
+ @Override
public String getBeanName() {
return beanName;
}
@@ -75,10 +77,12 @@ public boolean wasInitialized() {
}
+ @Override
public void destroy() {
this.destroyed = true;
}
+ @Override
public boolean wasDestroyed() {
return destroyed;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/test/beans/NestedTestBean.java | @@ -37,6 +37,7 @@ public void setCompany(String company) {
this.company = (company != null ? company : "");
}
+ @Override
public String getCompany() {
return company;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/test/beans/SerializablePerson.java | @@ -31,22 +31,27 @@ public class SerializablePerson implements Person, Serializable {
private String name;
private int age;
+ @Override
public int getAge() {
return age;
}
+ @Override
public void setAge(int age) {
this.age = age;
}
+ @Override
public String getName() {
return name;
}
+ @Override
public void setName(String name) {
this.name = name;
}
+ @Override
public Object echo(Object o) throws Throwable {
if (o instanceof Throwable) {
throw (Throwable) o; | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/test/beans/TestBean.java | @@ -146,10 +146,12 @@ public boolean isPostProcessed() {
return postProcessed;
}
+ @Override
public String getName() {
return name;
}
+ @Override
public void setName(String name) {
this.name = name;
}
@@ -165,10 +167,12 @@ public void setSex(String sex) {
}
}
+ @Override
public int getAge() {
return age;
}
+ @Override
public void setAge(int age) {
this.age = age;
}
@@ -181,14 +185,17 @@ public void setJedi(boolean jedi) {
this.jedi = jedi;
}
+ @Override
public ITestBean getSpouse() {
return (spouses != null ? spouses[0] : null);
}
+ @Override
public void setSpouse(ITestBean spouse) {
this.spouses = new ITestBean[] {spouse};
}
+ @Override
public ITestBean[] getSpouses() {
return spouses;
}
@@ -215,10 +222,12 @@ public void setCountry(String country) {
this.country = country;
}
+ @Override
public String[] getStringArray() {
return stringArray;
}
+ @Override
public void setStringArray(String[] stringArray) {
this.stringArray = stringArray;
}
@@ -287,6 +296,7 @@ public void setSomeProperties(Properties someProperties) {
this.someProperties = someProperties;
}
+ @Override
public INestedTestBean getDoctor() {
return doctor;
}
@@ -295,6 +305,7 @@ public void setDoctor(INestedTestBean doctor) {
this.doctor = doctor;
}
+ @Override
public INestedTestBean getLawyer() {
return lawyer;
}
@@ -347,28 +358,33 @@ public void setPets(List<?> pets) {
/**
* @see ITestBean#exceptional(Throwable)
*/
+ @Override
public void exceptional(Throwable t) throws Throwable {
if (t != null) {
throw t;
}
}
+ @Override
public void unreliableFileOperation() throws IOException {
throw new IOException();
}
/**
* @see ITestBean#returnsThis()
*/
+ @Override
public Object returnsThis() {
return this;
}
/**
* @see IOther#absquatulate()
*/
+ @Override
public void absquatulate() {
}
+ @Override
public int haveBirthday() {
return age++;
}
@@ -398,6 +414,7 @@ public int hashCode() {
return this.age;
}
+ @Override
public int compareTo(Object other) {
if (this.name != null && other instanceof TestBean) {
return this.name.compareTo(((TestBean) other).getName()); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-aop/src/test/java/test/parsing/CollectingReaderEventListener.java | @@ -46,6 +46,7 @@ public class CollectingReaderEventListener implements ReaderEventListener {
private final List<ImportDefinition> imports = new LinkedList<ImportDefinition>();
+ @Override
public void defaultsRegistered(DefaultsDefinition defaultsDefinition) {
this.defaults.add(defaultsDefinition);
}
@@ -54,6 +55,7 @@ public List<DefaultsDefinition> getDefaults() {
return Collections.unmodifiableList(this.defaults);
}
+ @Override
public void componentRegistered(ComponentDefinition componentDefinition) {
this.componentDefinitions.put(componentDefinition.getName(), componentDefinition);
}
@@ -67,6 +69,7 @@ public ComponentDefinition[] getComponentDefinitions() {
return collection.toArray(new ComponentDefinition[collection.size()]);
}
+ @Override
@SuppressWarnings("unchecked")
public void aliasRegistered(AliasDefinition aliasDefinition) {
List aliases = (List) this.aliasMap.get(aliasDefinition.getBeanName());
@@ -82,6 +85,7 @@ public List<?> getAliases(String beanName) {
return aliases == null ? null : Collections.unmodifiableList(aliases);
}
+ @Override
public void importProcessed(ImportDefinition importDefinition) {
this.imports.add(importDefinition);
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/com/foo/ComponentBeanDefinitionParser.java | @@ -13,6 +13,7 @@
public class ComponentBeanDefinitionParser extends AbstractBeanDefinitionParser {
+ @Override
protected AbstractBeanDefinition parseInternal(Element element,
ParserContext parserContext) {
return parseComponentElement(element); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/com/foo/ComponentFactoryBean.java | @@ -16,6 +16,7 @@ public void setChildren(List<Component> children) {
this.children = children;
}
+ @Override
public Component getObject() throws Exception {
if (this.children != null && this.children.size() > 0) {
for (Component child : children) {
@@ -25,10 +26,12 @@ public Component getObject() throws Exception {
return this.parent;
}
+ @Override
public Class<Component> getObjectType() {
return Component.class;
}
+ @Override
public boolean isSingleton() {
return true;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/com/foo/ComponentNamespaceHandler.java | @@ -3,6 +3,7 @@
import org.springframework.beans.factory.xml.NamespaceHandlerSupport;
public class ComponentNamespaceHandler extends NamespaceHandlerSupport {
+ @Override
public void init() {
registerBeanDefinitionParser("component",
new ComponentBeanDefinitionParser()); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/BeanUtilsTests.java | @@ -360,18 +360,22 @@ private static class Bean implements MapEntry<String, String> {
private String value;
+ @Override
public String getKey() {
return key;
}
+ @Override
public void setKey(String aKey) {
key = aKey;
}
+ @Override
public String getValue() {
return value;
}
+ @Override
public void setValue(String aValue) {
value = aValue;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/BeanWrapperGenericsTests.java | @@ -507,6 +507,7 @@ private static class NestedGenericCollectionBean extends BaseGenericCollectionBe
private Map<String, List<List<Integer>>> mapOfListOfListOfInteger;
+ @Override
public Map<String, Integer> getMapOfInteger() {
return mapOfInteger;
}
@@ -515,10 +516,12 @@ public void setMapOfInteger(Map<String, Integer> mapOfInteger) {
this.mapOfInteger = mapOfInteger;
}
+ @Override
public Map<String, List<Integer>> getMapOfListOfInteger() {
return mapOfListOfInteger;
}
+ @Override
public void setMapOfListOfInteger(Map<String, List<Integer>> mapOfListOfInteger) {
this.mapOfListOfInteger = mapOfListOfInteger;
}
@@ -591,6 +594,7 @@ public class Bar implements Foo {
private double version;
+ @Override
public Double getVersion() {
return this.version;
}
@@ -613,10 +617,12 @@ public class Promotion implements ObjectWithId<Long> {
private Long id;
+ @Override
public Long getId() {
return id;
}
+ @Override
public void setId(Long aId) {
this.id = aId;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/BeanWrapperTests.java | @@ -329,6 +329,7 @@ public void testConvertClassToString() {
TestBean tb = new TestBean();
BeanWrapper bw = new BeanWrapperImpl(tb);
bw.registerCustomEditor(String.class, new PropertyEditorSupport() {
+ @Override
public void setValue(Object value) {
super.setValue(value.toString());
}
@@ -500,6 +501,7 @@ public void testStringArrayPropertyWithCustomStringEditor() throws Exception {
PropsTester pt = new PropsTester();
BeanWrapper bw = new BeanWrapperImpl(pt);
bw.registerCustomEditor(String.class, "stringArray", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) {
setValue(text.substring(1));
}
@@ -559,6 +561,7 @@ public void testStringPropertyWithCustomEditor() throws Exception {
TestBean tb = new TestBean();
BeanWrapper bw = new BeanWrapperImpl(tb);
bw.registerCustomEditor(String.class, "name", new PropertyEditorSupport() {
+ @Override
public void setValue(Object value) {
if (value instanceof String[]) {
setValue(StringUtils.arrayToDelimitedString(((String[]) value), "-"));
@@ -636,6 +639,7 @@ public void testIntArrayPropertyWithCustomEditor() {
PropsTester pt = new PropsTester();
BeanWrapper bw = new BeanWrapperImpl(pt);
bw.registerCustomEditor(int.class, new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) {
setValue(new Integer(Integer.parseInt(text) + 1));
}
@@ -1022,6 +1026,7 @@ public void testMapAccessWithTypeConversion() {
IndexedTestBean bean = new IndexedTestBean();
BeanWrapper bw = new BeanWrapperImpl(bean);
bw.registerCustomEditor(TestBean.class, new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
if (!StringUtils.hasLength(text)) {
throw new IllegalArgumentException();
@@ -1055,6 +1060,7 @@ public void testMapAccessWithUnmodifiableMap() {
IndexedTestBean bean = new IndexedTestBean();
BeanWrapper bw = new BeanWrapperImpl(bean);
bw.registerCustomEditor(TestBean.class, "map", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
if (!StringUtils.hasLength(text)) {
throw new IllegalArgumentException();
@@ -1078,6 +1084,7 @@ public void testMapAccessWithCustomUnmodifiableMap() {
IndexedTestBean bean = new IndexedTestBean();
BeanWrapper bw = new BeanWrapperImpl(bean);
bw.registerCustomEditor(TestBean.class, "map", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
if (!StringUtils.hasLength(text)) {
throw new IllegalArgumentException();
@@ -1191,6 +1198,7 @@ public void testLargeMatchingPrimitiveArrayWithSpecificEditor() {
PrimitiveArrayBean tb = new PrimitiveArrayBean();
BeanWrapper bw = new BeanWrapperImpl(tb);
bw.registerCustomEditor(int.class, "array", new PropertyEditorSupport() {
+ @Override
public void setValue(Object value) {
if (value instanceof Integer) {
super.setValue(new Integer(((Integer) value).intValue() + 1));
@@ -1209,6 +1217,7 @@ public void testLargeMatchingPrimitiveArrayWithIndexSpecificEditor() {
PrimitiveArrayBean tb = new PrimitiveArrayBean();
BeanWrapper bw = new BeanWrapperImpl(tb);
bw.registerCustomEditor(int.class, "array[1]", new PropertyEditorSupport() {
+ @Override
public void setValue(Object value) {
if (value instanceof Integer) {
super.setValue(new Integer(((Integer) value).intValue() + 1));
@@ -1821,6 +1830,7 @@ public ReadOnlyMap(Map<? extends K, ? extends V> map) {
this.frozen = true;
}
+ @Override
public V put(K key, V value) {
if (this.frozen) {
throw new UnsupportedOperationException();
@@ -1830,16 +1840,19 @@ public V put(K key, V value) {
}
}
+ @Override
public Set<Map.Entry<K, V>> entrySet() {
this.accessed = true;
return super.entrySet();
}
+ @Override
public Set<K> keySet() {
this.accessed = true;
return super.keySet();
}
+ @Override
public int size() {
this.accessed = true;
return super.size(); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/ConcurrentBeanWrapperTests.java | @@ -115,6 +115,7 @@ public TestRun(ConcurrentBeanWrapperTests test) {
this.test = test;
}
+ @Override
public void run() {
try {
for (int i = 0; i < 100; i++) { | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/ExtendedBeanInfoTests.java | @@ -214,6 +214,7 @@ public Integer getProperty1() {
@Test
public void cornerSpr9453() throws IntrospectionException {
final class Bean implements Spr9453<Class<?>> {
+ @Override
public Class<?> getProp() {
return null;
}
@@ -589,7 +590,9 @@ public void subclassWriteMethodWithCovariantReturnType() throws IntrospectionExc
public Number setFoo(String foo) { return null; }
}
class C extends B {
+ @Override
public String getFoo() { return null; }
+ @Override
public Integer setFoo(String foo) { return null; }
}
@@ -861,6 +864,7 @@ interface BookOperations {
}
interface TextBookOperations extends BookOperations {
+ @Override
TextBook getBook();
}
@@ -870,6 +874,7 @@ public void setBook(Book book) { }
}
class LawLibrary extends Library implements TextBookOperations {
+ @Override
public LawBook getBook() { return null; }
}
| true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/annotation/RequiredAnnotationBeanPostProcessorTests.java | @@ -182,10 +182,12 @@ public void setJobTitle(String jobTitle) {
this.jobTitle = jobTitle;
}
+ @Override
@Required
public void setBeanName(String name) {
}
+ @Override
@Required
public void setBeanFactory(BeanFactory beanFactory) {
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/ConcurrentBeanFactoryTests.java | @@ -72,6 +72,7 @@ public final class ConcurrentBeanFactoryTests {
public void setUp() throws Exception {
XmlBeanFactory factory = new XmlBeanFactory(CONTEXT);
factory.addPropertyEditorRegistrar(new PropertyEditorRegistrar() {
+ @Override
public void registerCustomEditors(PropertyEditorRegistry registry) {
registry.registerCustomEditor(Date.class, new CustomDateEditor((DateFormat) DATE_FORMAT.clone(), false));
}
@@ -125,6 +126,7 @@ private void performTest() {
private class TestRun extends Thread {
+ @Override
public void run() {
try {
for (int i = 0; i < 10000; i++) { | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/DefaultListableBeanFactoryTests.java | @@ -836,6 +836,7 @@ public void testCanEscapeBeanReferenceSyntax() {
public void testCustomEditor() {
DefaultListableBeanFactory lbf = new DefaultListableBeanFactory();
lbf.addPropertyEditorRegistrar(new PropertyEditorRegistrar() {
+ @Override
public void registerCustomEditors(PropertyEditorRegistry registry) {
NumberFormat nf = NumberFormat.getInstance(Locale.GERMAN);
registry.registerCustomEditor(Float.class, new CustomNumberEditor(Float.class, nf, true));
@@ -853,6 +854,7 @@ public void testCustomConverter() {
DefaultListableBeanFactory lbf = new DefaultListableBeanFactory();
GenericConversionService conversionService = new DefaultConversionService();
conversionService.addConverter(new Converter<String, Float>() {
+ @Override
public Float convert(String source) {
try {
NumberFormat nf = NumberFormat.getInstance(Locale.GERMAN);
@@ -875,6 +877,7 @@ public Float convert(String source) {
public void testCustomEditorWithBeanReference() {
DefaultListableBeanFactory lbf = new DefaultListableBeanFactory();
lbf.addPropertyEditorRegistrar(new PropertyEditorRegistrar() {
+ @Override
public void registerCustomEditors(PropertyEditorRegistry registry) {
NumberFormat nf = NumberFormat.getInstance(Locale.GERMAN);
registry.registerCustomEditor(Float.class, new CustomNumberEditor(Float.class, nf, true));
@@ -1907,9 +1910,11 @@ public void testBeanPostProcessorWithWrappedObjectAndDisposableBean() {
RootBeanDefinition bd = new RootBeanDefinition(BeanWithDisposableBean.class);
lbf.registerBeanDefinition("test", bd);
lbf.addBeanPostProcessor(new BeanPostProcessor() {
+ @Override
public Object postProcessBeforeInitialization(Object bean, String beanName) {
return new TestBean();
}
+ @Override
public Object postProcessAfterInitialization(Object bean, String beanName) {
return bean;
}
@@ -1926,9 +1931,11 @@ public void testBeanPostProcessorWithWrappedObjectAndCloseable() {
RootBeanDefinition bd = new RootBeanDefinition(BeanWithCloseable.class);
lbf.registerBeanDefinition("test", bd);
lbf.addBeanPostProcessor(new BeanPostProcessor() {
+ @Override
public Object postProcessBeforeInitialization(Object bean, String beanName) {
return new TestBean();
}
+ @Override
public Object postProcessAfterInitialization(Object bean, String beanName) {
return bean;
}
@@ -1946,9 +1953,11 @@ public void testBeanPostProcessorWithWrappedObjectAndDestroyMethod() {
bd.setDestroyMethodName("close");
lbf.registerBeanDefinition("test", bd);
lbf.addBeanPostProcessor(new BeanPostProcessor() {
+ @Override
public Object postProcessBeforeInitialization(Object bean, String beanName) {
return new TestBean();
}
+ @Override
public Object postProcessAfterInitialization(Object bean, String beanName) {
return bean;
}
@@ -2117,6 +2126,7 @@ private void doTestFieldSettingWithInstantiationAwarePostProcessor(final boolean
lbf.registerBeanDefinition("test", bd);
final String nameSetOnField = "nameSetOnField";
lbf.addBeanPostProcessor(new InstantiationAwareBeanPostProcessorAdapter() {
+ @Override
public boolean postProcessAfterInstantiation(Object bean, String beanName) throws BeansException {
TestBean tb = (TestBean) bean;
try {
@@ -2156,6 +2166,7 @@ public void testInitSecurityAwarePrototypeBean() {
TestSecuredBean bean = (TestSecuredBean) Subject.doAsPrivileged(subject,
new PrivilegedAction() {
+ @Override
public Object run() {
return lbf.getBean("test");
}
@@ -2244,14 +2255,17 @@ public static class ConstructorDependencyFactoryBean implements FactoryBean<Obje
public ConstructorDependencyFactoryBean(String dependency) {
}
+ @Override
public Object getObject() {
return "test";
}
+ @Override
public Class<?> getObjectType() {
return String.class;
}
+ @Override
public boolean isSingleton() {
return true;
}
@@ -2262,6 +2276,7 @@ public static class BeanWithDisposableBean implements DisposableBean {
private static boolean closed;
+ @Override
public void destroy() {
closed = true;
}
@@ -2272,6 +2287,7 @@ public static class BeanWithCloseable implements Closeable {
private static boolean closed;
+ @Override
public void close() {
closed = true;
}
@@ -2316,14 +2332,17 @@ public Object createGeneric() {
public static class FactoryBeanThatShouldntBeCalled implements FactoryBean<Object> {
+ @Override
public Object getObject() {
throw new IllegalStateException();
}
+ @Override
public Class<?> getObjectType() {
return null;
}
+ @Override
public boolean isSingleton() {
return false;
}
@@ -2334,15 +2353,18 @@ public static class LazyInitFactory implements FactoryBean<Object> {
public boolean initialized = false;
+ @Override
public Object getObject() throws Exception {
this.initialized = true;
return "";
}
+ @Override
public Class<?> getObjectType() {
return String.class;
}
+ @Override
public boolean isSingleton() {
return true;
}
@@ -2353,23 +2375,28 @@ public static class EagerInitFactory implements SmartFactoryBean<Object> {
public boolean initialized = false;
+ @Override
public Object getObject() throws Exception {
this.initialized = true;
return "";
}
+ @Override
public Class<?> getObjectType() {
return String.class;
}
+ @Override
public boolean isSingleton() {
return true;
}
+ @Override
public boolean isPrototype() {
return false;
}
+ @Override
public boolean isEagerInit() {
return true;
}
@@ -2452,6 +2479,7 @@ public CustomTypeConverter(NumberFormat numberFormat) {
this.numberFormat = numberFormat;
}
+ @Override
@SuppressWarnings("unchecked")
public Object convertIfNecessary(Object value, Class requiredType) {
if (value instanceof String && Float.class.isAssignableFrom(requiredType)) {
@@ -2470,11 +2498,13 @@ else if (value instanceof String && int.class.isAssignableFrom(requiredType)) {
}
}
+ @Override
@SuppressWarnings("unchecked")
public Object convertIfNecessary(Object value, Class requiredType, MethodParameter methodParam) {
return convertIfNecessary(value, requiredType);
}
+ @Override
@SuppressWarnings("unchecked")
public Object convertIfNecessary(Object value, Class requiredType, Field field) {
return convertIfNecessary(value, requiredType);
@@ -2490,6 +2520,7 @@ public TestPrincipal(String name) {
this.name = name;
}
+ @Override
public String getName() {
return this.name;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/FactoryBeanTests.java | @@ -77,14 +77,17 @@ public void testFactoryBeansWithIntermediateFactoryBeanAutowiringFailure() throw
public static class NullReturningFactoryBean implements FactoryBean<Object> {
+ @Override
public Object getObject() {
return null;
}
+ @Override
public Class<?> getObjectType() {
return null;
}
+ @Override
public boolean isSingleton() {
return true;
}
@@ -103,6 +106,7 @@ public Beta getBeta() {
return beta;
}
+ @Override
public void afterPropertiesSet() {
Assert.notNull(beta, "'beta' property is required");
}
@@ -131,6 +135,7 @@ public String getName() {
return name;
}
+ @Override
public void afterPropertiesSet() {
Assert.notNull(gamma, "'gamma' property is required");
}
@@ -149,14 +154,17 @@ public void setBeta(Beta beta) {
this.beta = beta;
}
+ @Override
public Object getObject() {
return this.beta;
}
+ @Override
public Class<?> getObjectType() {
return null;
}
+ @Override
public boolean isSingleton() {
return true;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/SharedBeanRegistryTests.java | @@ -43,6 +43,7 @@ public void testSingletons() {
assertSame(tb, beanRegistry.getSingleton("tb"));
TestBean tb2 = (TestBean) beanRegistry.getSingleton("tb2", new ObjectFactory<Object>() {
+ @Override
public Object getObject() throws BeansException {
return new TestBean();
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/annotation/AutowiredAnnotationBeanPostProcessorTests.java | @@ -989,6 +989,7 @@ public TestBean getTestBean2() {
public ExtendedResourceInjectionBean() {
}
+ @Override
@Autowired @Required
public void setTestBean2(TestBean testBean2) {
super.setTestBean2(testBean2);
@@ -1068,6 +1069,7 @@ public static class OptionalResourceInjectionBean extends ResourceInjectionBean
private ITestBean testBean4;
+ @Override
@Autowired(required = false)
public void setTestBean2(TestBean testBean2) {
super.setTestBean2(testBean2);
@@ -1114,6 +1116,7 @@ public static class OptionalCollectionResourceInjectionBean extends ResourceInje
private ITestBean testBean4;
+ @Override
@Autowired(required = false)
public void setTestBean2(TestBean testBean2) {
super.setTestBean2(testBean2);
@@ -1185,6 +1188,7 @@ public ConstructorResourceInjectionBean(ITestBean testBean3, ITestBean testBean4
throw new UnsupportedOperationException();
}
+ @Override
@Autowired
public void setTestBean2(TestBean testBean2) {
super.setTestBean2(testBean2);
@@ -1447,14 +1451,17 @@ public final FactoryBean<?> getFactoryBean() {
public static class StringFactoryBean implements FactoryBean<String> {
+ @Override
public String getObject() throws Exception {
return "";
}
+ @Override
public Class<String> getObjectType() {
return String.class;
}
+ @Override
public boolean isSingleton() {
return true;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/annotation/CustomAutowireConfigurerTests.java | @@ -69,6 +69,7 @@ public String getName() {
public static class CustomResolver implements AutowireCandidateResolver {
+ @Override
public boolean isAutowireCandidate(BeanDefinitionHolder bdHolder, DependencyDescriptor descriptor) {
if (!bdHolder.getBeanDefinition().isAutowireCandidate()) {
return false;
@@ -82,6 +83,7 @@ public boolean isAutowireCandidate(BeanDefinitionHolder bdHolder, DependencyDesc
return false;
}
+ @Override
public Object getSuggestedValue(DependencyDescriptor descriptor) {
return null;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/annotation/InjectAnnotationBeanPostProcessorTests.java | @@ -609,6 +609,7 @@ public TestBean getTestBean2() {
public ExtendedResourceInjectionBean() {
}
+ @Override
@Inject @Required
public void setTestBean2(TestBean testBean2) {
super.setTestBean2(testBean2);
@@ -662,6 +663,7 @@ public static class OptionalResourceInjectionBean extends ResourceInjectionBean
private ITestBean testBean4;
+ @Override
@Inject
public void setTestBean2(TestBean testBean2) {
super.setTestBean2(testBean2);
@@ -708,6 +710,7 @@ public static class OptionalCollectionResourceInjectionBean extends ResourceInje
private ITestBean testBean4;
+ @Override
@Inject
public void setTestBean2(TestBean testBean2) {
super.setTestBean2(testBean2);
@@ -779,6 +782,7 @@ public ConstructorResourceInjectionBean(ITestBean testBean3, ITestBean testBean4
throw new UnsupportedOperationException();
}
+ @Override
@Inject
public void setTestBean2(TestBean testBean2) {
super.setTestBean2(testBean2);
@@ -1074,14 +1078,17 @@ public final FactoryBean<?> getFactoryBean() {
public static class StringFactoryBean implements FactoryBean<String> {
+ @Override
public String getObject() throws Exception {
return "";
}
+ @Override
public Class<String> getObjectType() {
return String.class;
}
+ @Override
public boolean isSingleton() {
return true;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/config/CustomEditorConfigurerTests.java | @@ -53,6 +53,7 @@ public void testCustomEditorConfigurerWithPropertyEditorRegistrar() throws Parse
final DateFormat df = DateFormat.getDateInstance(DateFormat.SHORT, Locale.GERMAN);
cec.setPropertyEditorRegistrars(new PropertyEditorRegistrar[] {
new PropertyEditorRegistrar() {
+ @Override
public void registerCustomEditors(PropertyEditorRegistry registry) {
registry.registerCustomEditor(Date.class, new CustomDateEditor(df, true));
}
@@ -189,6 +190,7 @@ public MyDateEditor() {
public static class MyTestEditor extends PropertyEditorSupport {
+ @Override
public void setAsText(String text) {
setValue(new String[] {"test"});
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/config/PropertyResourceConfigurerTests.java | @@ -812,6 +812,7 @@ public void testPreferencesPlaceholderConfigurerWithPathInPlaceholder() {
private static class ConvertingOverrideConfigurer extends PropertyOverrideConfigurer {
+ @Override
protected String convertPropertyValue(String originalValue) {
return "X" + originalValue;
}
@@ -826,10 +827,12 @@ public static class MockPreferencesFactory implements PreferencesFactory {
private Preferences userRoot = new MockPreferences();
+ @Override
public Preferences systemRoot() {
return systemRoot;
}
+ @Override
public Preferences userRoot() {
return userRoot;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/config/SimpleScopeTests.java | @@ -53,6 +53,7 @@ public void setUp() {
objects.add(new TestBean());
objects.add(new TestBean());
}
+ @Override
public Object get(String name, ObjectFactory<?> objectFactory) {
if (index >= objects.size()) {
index = 0; | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/config/TestTypes.java | @@ -30,21 +30,26 @@ final class TestTypes {}
*/
class NoOpScope implements Scope {
+ @Override
public Object get(String name, ObjectFactory<?> objectFactory) {
throw new UnsupportedOperationException();
}
+ @Override
public Object remove(String name) {
throw new UnsupportedOperationException();
}
+ @Override
public void registerDestructionCallback(String name, Runnable callback) {
}
+ @Override
public Object resolveContextualObject(String key) {
return null;
}
+ @Override
public String getConversationId() {
return null;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/parsing/CustomProblemReporterTests.java | @@ -71,10 +71,12 @@ private static class CollatingProblemReporter implements ProblemReporter {
private List<Problem> warnings = new ArrayList<Problem>();
+ @Override
public void fatal(Problem problem) {
throw new BeanDefinitionParsingException(problem);
}
+ @Override
public void error(Problem problem) {
System.out.println(problem);
this.errors.add(problem);
@@ -84,6 +86,7 @@ public Problem[] getErrors() {
return this.errors.toArray(new Problem[this.errors.size()]);
}
+ @Override
public void warning(Problem problem) {
System.out.println(problem);
this.warnings.add(problem); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/support/BeanFactoryGenericsTests.java | @@ -391,6 +391,7 @@ public void testGenericMapWithKeyTypeConstructor() throws MalformedURLException
public void testGenericMapWithCollectionValueConstructor() throws MalformedURLException {
DefaultListableBeanFactory bf = new DefaultListableBeanFactory();
bf.addPropertyEditorRegistrar(new PropertyEditorRegistrar() {
+ @Override
public void registerCustomEditors(PropertyEditorRegistry registry) {
registry.registerCustomEditor(Number.class, new CustomNumberEditor(Integer.class, false));
}
@@ -547,6 +548,7 @@ public void testGenericMapWithKeyTypeFactoryMethod() throws MalformedURLExceptio
public void testGenericMapWithCollectionValueFactoryMethod() throws MalformedURLException {
DefaultListableBeanFactory bf = new DefaultListableBeanFactory();
bf.addPropertyEditorRegistrar(new PropertyEditorRegistrar() {
+ @Override
public void registerCustomEditors(PropertyEditorRegistry registry) {
registry.registerCustomEditor(Number.class, new CustomNumberEditor(Integer.class, false));
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/support/PropertiesBeanDefinitionReaderTests.java | @@ -30,6 +30,7 @@ public class PropertiesBeanDefinitionReaderTests extends TestCase {
private PropertiesBeanDefinitionReader reader;
+ @Override
protected void setUp() throws Exception {
this.beanFactory = new DefaultListableBeanFactory();
this.reader = new PropertiesBeanDefinitionReader(beanFactory); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/support/Spr8954Tests.java | @@ -61,14 +61,17 @@ public void repro() {
static class FooFactoryBean implements FactoryBean<Foo>, AnInterface {
+ @Override
public Foo getObject() throws Exception {
return new Foo();
}
+ @Override
public Class<?> getObjectType() {
return Foo.class;
}
+ @Override
public boolean isSingleton() {
return true;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/support/security/CallbacksSecurityTests.java | @@ -129,23 +129,28 @@ public NonPrivilegedSpringCallbacksBean(String expected) {
checkCurrentContext();
}
+ @Override
public void afterPropertiesSet() {
checkCurrentContext();
}
+ @Override
public void destroy() {
checkCurrentContext();
destroyed = true;
}
+ @Override
public void setBeanName(String name) {
checkCurrentContext();
}
+ @Override
public void setBeanClassLoader(ClassLoader classLoader) {
checkCurrentContext();
}
+ @Override
public void setBeanFactory(BeanFactory beanFactory)
throws BeansException {
checkCurrentContext();
@@ -164,26 +169,31 @@ public NonPrivilegedFactoryBean(String expected) {
checkCurrentContext();
}
+ @Override
public boolean isEagerInit() {
checkCurrentContext();
return false;
}
+ @Override
public boolean isPrototype() {
checkCurrentContext();
return true;
}
+ @Override
public Object getObject() throws Exception {
checkCurrentContext();
return new Object();
}
+ @Override
public Class getObjectType() {
checkCurrentContext();
return Object.class;
}
+ @Override
public boolean isSingleton() {
checkCurrentContext();
return false;
@@ -219,6 +229,7 @@ private static String getCurrentSubjectName() {
return AccessController.doPrivileged(new PrivilegedAction<String>() {
+ @Override
public String run() {
Subject subject = Subject.getSubject(acc);
if (subject == null) {
@@ -246,6 +257,7 @@ public TestPrincipal(String name) {
this.name = name;
}
+ @Override
public String getName() {
return this.name;
}
@@ -291,6 +303,7 @@ public void setUp() throws Exception {
private final AccessControlContext acc = new AccessControlContext(
new ProtectionDomain[] { empty });
+ @Override
public AccessControlContext getAccessControlContext() {
return acc;
}
@@ -320,6 +333,7 @@ public void testSecuritySanity() throws Exception {
try {
AccessController.doPrivileged(new PrivilegedExceptionAction<Object>() {
+ @Override
public Object run() throws Exception {
method.invoke(bean);
return null;
@@ -334,6 +348,7 @@ public Object run() throws Exception {
AccessController.doPrivileged(
new PrivilegedExceptionAction<Object>() {
+ @Override
public Object run() throws Exception {
return cl.newInstance();
}
@@ -444,6 +459,7 @@ public void testContainerPrivileges() throws Exception {
AccessController.doPrivileged(new PrivilegedExceptionAction<Object>() {
+ @Override
public Object run() throws Exception {
beanFactory.getBean("working-factory-method");
beanFactory.getBean("container-execution");
@@ -478,6 +494,7 @@ public void testInitSecurityAwarePrototypeBean() {
NonPrivilegedBean bean = Subject.doAsPrivileged(
subject, new PrivilegedAction<NonPrivilegedBean>() {
+ @Override
public NonPrivilegedBean run() {
return lbf.getBean("test", NonPrivilegedBean.class);
}
@@ -502,6 +519,7 @@ public void testTrustedExecution() throws Exception {
// request the beans from non-privileged code
Subject.doAsPrivileged(subject, new PrivilegedAction<Object>() {
+ @Override
public Object run() {
// sanity check
assertEquals("user1", getCurrentSubjectName()); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/support/security/support/CustomFactoryBean.java | @@ -24,15 +24,18 @@
*/
public class CustomFactoryBean implements FactoryBean<Object> {
+ @Override
public Object getObject() throws Exception {
return System.getProperties();
}
+ @Override
public Class getObjectType() {
System.setProperty("factory.object.type", "true");
return Properties.class;
}
+ @Override
public boolean isSingleton() {
return true;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/support/security/support/DestroyBean.java | @@ -22,6 +22,7 @@
*/
public class DestroyBean implements DisposableBean {
+ @Override
public void destroy() throws Exception {
System.setProperty("security.destroy", "true");
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/support/security/support/InitBean.java | @@ -22,6 +22,7 @@
*/
public class InitBean implements InitializingBean {
+ @Override
public void afterPropertiesSet() throws Exception {
System.getProperties();
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/AbstractBeanFactoryTests.java | @@ -326,6 +326,7 @@ public void testAliasing() {
public static class TestBeanEditor extends PropertyEditorSupport {
+ @Override
public void setAsText(String text) {
TestBean tb = new TestBean();
StringTokenizer st = new StringTokenizer(text, "_");
@@ -350,6 +351,7 @@ class MustBeInitialized implements InitializingBean {
/**
* @see InitializingBean#afterPropertiesSet()
*/
+ @Override
public void afterPropertiesSet() throws Exception {
this.inited = true;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/BeanNameGenerationTests.java | @@ -30,6 +30,7 @@ public class BeanNameGenerationTests extends TestCase {
private DefaultListableBeanFactory beanFactory;
+ @Override
public void setUp() {
this.beanFactory = new DefaultListableBeanFactory();
XmlBeanDefinitionReader reader = new XmlBeanDefinitionReader(this.beanFactory); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/CollectingReaderEventListener.java | @@ -45,6 +45,7 @@ public class CollectingReaderEventListener implements ReaderEventListener {
private final List imports = new LinkedList();
+ @Override
public void defaultsRegistered(DefaultsDefinition defaultsDefinition) {
this.defaults.add(defaultsDefinition);
}
@@ -53,6 +54,7 @@ public List getDefaults() {
return Collections.unmodifiableList(this.defaults);
}
+ @Override
public void componentRegistered(ComponentDefinition componentDefinition) {
this.componentDefinitions.put(componentDefinition.getName(), componentDefinition);
}
@@ -66,6 +68,7 @@ public ComponentDefinition[] getComponentDefinitions() {
return (ComponentDefinition[]) collection.toArray(new ComponentDefinition[collection.size()]);
}
+ @Override
public void aliasRegistered(AliasDefinition aliasDefinition) {
List aliases = (List) this.aliasMap.get(aliasDefinition.getBeanName());
if(aliases == null) {
@@ -80,6 +83,7 @@ public List getAliases(String beanName) {
return aliases == null ? null : Collections.unmodifiableList(aliases);
}
+ @Override
public void importProcessed(ImportDefinition importDefinition) {
this.imports.add(importDefinition);
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/CollectionMergingTests.java | @@ -40,6 +40,7 @@ public class CollectionMergingTests extends TestCase {
private DefaultListableBeanFactory beanFactory;
+ @Override
protected void setUp() throws Exception {
this.beanFactory = new DefaultListableBeanFactory();
BeanDefinitionReader reader = new XmlBeanDefinitionReader(this.beanFactory); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/CountingFactory.java | @@ -51,14 +51,17 @@ public void setTestBean(TestBean tb) {
}
+ @Override
public Object getObject() {
return "myString";
}
+ @Override
public Class getObjectType() {
return String.class;
}
+ @Override
public boolean isSingleton() {
return true;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/DefaultLifecycleMethodsTests.java | @@ -27,6 +27,7 @@ public class DefaultLifecycleMethodsTests extends TestCase {
private XmlBeanFactory beanFactory;
+ @Override
protected void setUp() throws Exception {
this.beanFactory = new XmlBeanFactory(new ClassPathResource("defaultLifecycleMethods.xml", getClass()));
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/DelegatingEntityResolverTests.java | @@ -45,6 +45,7 @@ public void testCtorWhereEntityResolversAreBothNull() throws Exception {
private static final class NoOpEntityResolver implements EntityResolver {
+ @Override
public InputSource resolveEntity(String publicId, String systemId) {
return null;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/DependenciesBean.java | @@ -62,6 +62,7 @@ public TestBean getSpouse() {
return spouse;
}
+ @Override
public void setBeanFactory(BeanFactory beanFactory) {
this.beanFactory = beanFactory;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/EventPublicationTests.java | @@ -42,6 +42,7 @@ public class EventPublicationTests extends TestCase {
private final CollectingReaderEventListener eventListener = new CollectingReaderEventListener();
+ @Override
protected void setUp() throws Exception {
XmlBeanDefinitionReader reader = new XmlBeanDefinitionReader(this.beanFactory);
reader.setEventListener(this.eventListener); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/GeneratedNameBean.java | @@ -27,6 +27,7 @@ public class GeneratedNameBean implements BeanNameAware {
private GeneratedNameBean child;
+ @Override
public void setBeanName(String beanName) {
this.beanName = beanName;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/MetadataAttachmentTests.java | @@ -29,6 +29,7 @@ public class MetadataAttachmentTests extends TestCase {
private XmlBeanFactory beanFactory;
+ @Override
protected void setUp() throws Exception {
this.beanFactory = new XmlBeanFactory(new ClassPathResource("withMeta.xml", getClass()));
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/ProfileXmlBeanDefinitionTests.java | @@ -171,6 +171,7 @@ private BeanDefinitionRegistry beanFactoryFor(String xmlName, String... activePr
private static Matcher<BeanDefinitionRegistry> containsBeanDefinition(final String beanName) {
return new TypeSafeMatcher<BeanDefinitionRegistry>() {
+ @Override
public void describeTo(Description desc) {
desc.appendText("a BeanDefinitionRegistry containing bean named ")
.appendValue(beanName); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/ProtectedLifecycleBean.java | @@ -57,6 +57,7 @@ public boolean isInitMethodDeclared() {
return initMethodDeclared;
}
+ @Override
public void setBeanName(String name) {
this.beanName = name;
}
@@ -65,6 +66,7 @@ public String getBeanName() {
return beanName;
}
+ @Override
public void setBeanFactory(BeanFactory beanFactory) {
this.owningFactory = beanFactory;
}
@@ -79,6 +81,7 @@ public void postProcessBeforeInit() {
this.postProcessedBeforeInit = true;
}
+ @Override
public void afterPropertiesSet() {
if (this.owningFactory == null) {
throw new RuntimeException("Factory didn't call setBeanFactory before afterPropertiesSet on lifecycle bean");
@@ -130,6 +133,7 @@ public void businessMethod() {
}
}
+ @Override
public void destroy() {
if (this.destroyed) {
throw new IllegalStateException("Already destroyed");
@@ -144,13 +148,15 @@ public boolean isDestroyed() {
public static class PostProcessor implements BeanPostProcessor {
+ @Override
public Object postProcessBeforeInitialization(Object bean, String name) throws BeansException {
if (bean instanceof ProtectedLifecycleBean) {
((ProtectedLifecycleBean) bean).postProcessBeforeInit();
}
return bean;
}
+ @Override
public Object postProcessAfterInitialization(Object bean, String name) throws BeansException {
if (bean instanceof ProtectedLifecycleBean) {
((ProtectedLifecycleBean) bean).postProcessAfterInit(); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/UtilNamespaceHandlerTests.java | @@ -46,6 +46,7 @@ public class UtilNamespaceHandlerTests extends TestCase {
private CollectingReaderEventListener listener = new CollectingReaderEventListener();
+ @Override
public void setUp() {
this.beanFactory = new DefaultListableBeanFactory();
XmlBeanDefinitionReader reader = new XmlBeanDefinitionReader(this.beanFactory); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/factory/xml/XmlListableBeanFactoryTests.java | @@ -46,6 +46,7 @@ public class XmlListableBeanFactoryTests extends AbstractListableBeanFactoryTest
private XmlBeanFactory factory;
+ @Override
protected void setUp() {
parent = new DefaultListableBeanFactory();
Map m = new HashMap();
@@ -59,6 +60,7 @@ protected void setUp() {
this.factory = new XmlBeanFactory(new ClassPathResource("test.xml", getClass()), parent);
this.factory.addBeanPostProcessor(new BeanPostProcessor() {
+ @Override
public Object postProcessBeforeInitialization(Object bean, String name) throws BeansException {
if (bean instanceof TestBean) {
((TestBean) bean).setPostProcessed(true);
@@ -68,6 +70,7 @@ public Object postProcessBeforeInitialization(Object bean, String name) throws B
}
return bean;
}
+ @Override
public Object postProcessAfterInitialization(Object bean, String name) throws BeansException {
return bean;
}
@@ -77,10 +80,12 @@ public Object postProcessAfterInitialization(Object bean, String name) throws Be
//this.factory.preInstantiateSingletons();
}
+ @Override
protected BeanFactory getBeanFactory() {
return factory;
}
+ @Override
public void testCount() {
assertCount(24);
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/propertyeditors/BeanInfoTests.java | @@ -70,6 +70,7 @@ public void setValue(Integer value) {
public static class ValueBeanBeanInfo extends SimpleBeanInfo {
+ @Override
public PropertyDescriptor[] getPropertyDescriptors() {
try {
PropertyDescriptor pd = new PropertyDescriptor("value", ValueBean.class);
@@ -96,6 +97,7 @@ public MyNumberEditor(Object target) throws IllegalArgumentException {
this.target = target;
}
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
if (JdkVersion.getMajorJavaVersion() >= JdkVersion.JAVA_15) {
Assert.isTrue(this.target instanceof ValueBean, "Target must be available on JDK 1.5+"); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/propertyeditors/CustomEditorTests.java | @@ -113,6 +113,7 @@ public void testCustomEditorForSingleProperty() {
TestBean tb = new TestBean();
BeanWrapper bw = new BeanWrapperImpl(tb);
bw.registerCustomEditor(String.class, "name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("prefix" + text);
}
@@ -130,6 +131,7 @@ public void testCustomEditorForAllStringProperties() {
TestBean tb = new TestBean();
BeanWrapper bw = new BeanWrapperImpl(tb);
bw.registerCustomEditor(String.class, new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("prefix" + text);
}
@@ -148,6 +150,7 @@ public void testCustomEditorForSingleNestedProperty() {
tb.setSpouse(new TestBean());
BeanWrapper bw = new BeanWrapperImpl(tb);
bw.registerCustomEditor(String.class, "spouse.name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("prefix" + text);
}
@@ -166,6 +169,7 @@ public void testCustomEditorForAllNestedStringProperties() {
tb.setSpouse(new TestBean());
BeanWrapper bw = new BeanWrapperImpl(tb);
bw.registerCustomEditor(String.class, new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("prefix" + text);
}
@@ -853,6 +857,7 @@ public void testIndexedPropertiesWithCustomEditorForType() {
IndexedTestBean bean = new IndexedTestBean();
BeanWrapper bw = new BeanWrapperImpl(bean);
bw.registerCustomEditor(String.class, new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("prefix" + text);
}
@@ -905,16 +910,19 @@ public void testIndexedPropertiesWithCustomEditorForProperty() {
IndexedTestBean bean = new IndexedTestBean(false);
BeanWrapper bw = new BeanWrapperImpl(bean);
bw.registerCustomEditor(String.class, "array.name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("array" + text);
}
});
bw.registerCustomEditor(String.class, "list.name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("list" + text);
}
});
bw.registerCustomEditor(String.class, "map.name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("map" + text);
}
@@ -969,31 +977,37 @@ public void testIndexedPropertiesWithIndividualCustomEditorForProperty() {
IndexedTestBean bean = new IndexedTestBean(false);
BeanWrapper bw = new BeanWrapperImpl(bean);
bw.registerCustomEditor(String.class, "array[0].name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("array0" + text);
}
});
bw.registerCustomEditor(String.class, "array[1].name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("array1" + text);
}
});
bw.registerCustomEditor(String.class, "list[0].name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("list0" + text);
}
});
bw.registerCustomEditor(String.class, "list[1].name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("list1" + text);
}
});
bw.registerCustomEditor(String.class, "map[key1].name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("mapkey1" + text);
}
});
bw.registerCustomEditor(String.class, "map[key2].name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("mapkey2" + text);
}
@@ -1060,28 +1074,34 @@ public void testNestedIndexedPropertiesWithCustomEditorForProperty() {
tb5.setNestedIndexedBean(new IndexedTestBean());
BeanWrapper bw = new BeanWrapperImpl(bean);
bw.registerCustomEditor(String.class, "array.nestedIndexedBean.array.name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("array" + text);
}
+ @Override
public String getAsText() {
return ((String) getValue()).substring(5);
}
});
bw.registerCustomEditor(String.class, "list.nestedIndexedBean.list.name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("list" + text);
}
+ @Override
public String getAsText() {
return ((String) getValue()).substring(4);
}
});
bw.registerCustomEditor(String.class, "map.nestedIndexedBean.map.name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("map" + text);
}
+ @Override
public String getAsText() {
return ((String) getValue()).substring(4);
}
@@ -1138,16 +1158,19 @@ public void testNestedIndexedPropertiesWithIndexedCustomEditorForProperty() {
tb5.setNestedIndexedBean(new IndexedTestBean());
BeanWrapper bw = new BeanWrapperImpl(bean);
bw.registerCustomEditor(String.class, "array[0].nestedIndexedBean.array[0].name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("array" + text);
}
});
bw.registerCustomEditor(String.class, "list.nestedIndexedBean.list[1].name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("list" + text);
}
});
bw.registerCustomEditor(String.class, "map[key1].nestedIndexedBean.map.name", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("map" + text);
}
@@ -1174,28 +1197,34 @@ public void testIndexedPropertiesWithDirectAccessAndPropertyEditors() {
IndexedTestBean bean = new IndexedTestBean();
BeanWrapper bw = new BeanWrapperImpl(bean);
bw.registerCustomEditor(TestBean.class, "array", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue(new TestBean("array" + text, 99));
}
+ @Override
public String getAsText() {
return ((TestBean) getValue()).getName();
}
});
bw.registerCustomEditor(TestBean.class, "list", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue(new TestBean("list" + text, 99));
}
+ @Override
public String getAsText() {
return ((TestBean) getValue()).getName();
}
});
bw.registerCustomEditor(TestBean.class, "map", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue(new TestBean("map" + text, 99));
}
+ @Override
public String getAsText() {
return ((TestBean) getValue()).getName();
}
@@ -1222,55 +1251,67 @@ public void testIndexedPropertiesWithDirectAccessAndSpecificPropertyEditors() {
IndexedTestBean bean = new IndexedTestBean();
BeanWrapper bw = new BeanWrapperImpl(bean);
bw.registerCustomEditor(TestBean.class, "array[0]", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue(new TestBean("array0" + text, 99));
}
+ @Override
public String getAsText() {
return ((TestBean) getValue()).getName();
}
});
bw.registerCustomEditor(TestBean.class, "array[1]", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue(new TestBean("array1" + text, 99));
}
+ @Override
public String getAsText() {
return ((TestBean) getValue()).getName();
}
});
bw.registerCustomEditor(TestBean.class, "list[0]", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue(new TestBean("list0" + text, 99));
}
+ @Override
public String getAsText() {
return ((TestBean) getValue()).getName();
}
});
bw.registerCustomEditor(TestBean.class, "list[1]", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue(new TestBean("list1" + text, 99));
}
+ @Override
public String getAsText() {
return ((TestBean) getValue()).getName();
}
});
bw.registerCustomEditor(TestBean.class, "map[key1]", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue(new TestBean("mapkey1" + text, 99));
}
+ @Override
public String getAsText() {
return ((TestBean) getValue()).getName();
}
});
bw.registerCustomEditor(TestBean.class, "map[key2]", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue(new TestBean("mapkey2" + text, 99));
}
+ @Override
public String getAsText() {
return ((TestBean) getValue()).getName();
}
@@ -1297,6 +1338,7 @@ public void testIndexedPropertiesWithListPropertyEditor() {
IndexedTestBean bean = new IndexedTestBean();
BeanWrapper bw = new BeanWrapperImpl(bean);
bw.registerCustomEditor(List.class, "list", new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
List<TestBean> result = new ArrayList<TestBean>();
result.add(new TestBean("list" + text, 99));
@@ -1347,6 +1389,7 @@ public void testArrayToArrayConversion() throws PropertyVetoException {
IndexedTestBean tb = new IndexedTestBean();
BeanWrapper bw = new BeanWrapperImpl(tb);
bw.registerCustomEditor(TestBean.class, new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue(new TestBean(text, 99));
}
@@ -1362,6 +1405,7 @@ public void testArrayToStringConversion() throws PropertyVetoException {
TestBean tb = new TestBean();
BeanWrapper bw = new BeanWrapperImpl(tb);
bw.registerCustomEditor(String.class, new PropertyEditorSupport() {
+ @Override
public void setAsText(String text) throws IllegalArgumentException {
setValue("-" + text + "-");
}
@@ -1436,6 +1480,7 @@ public void testCharsetEditor() throws Exception {
private static class TestBeanEditor extends PropertyEditorSupport {
+ @Override
public void setAsText(String text) {
TestBean tb = new TestBean();
StringTokenizer st = new StringTokenizer(text, "_");
@@ -1448,6 +1493,7 @@ public void setAsText(String text) {
private static class OldValueAccessingTestBeanEditor extends PropertyEditorSupport {
+ @Override
public void setAsText(String text) {
TestBean tb = new TestBean();
StringTokenizer st = new StringTokenizer(text, "_"); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/org/springframework/beans/support/PropertyComparatorTests.java | @@ -104,6 +104,7 @@ private static class Dog implements Comparable<Object> {
private String lastName;
+ @Override
public int compareTo(Object o) {
return nickName.compareTo(((Dog)o).nickName);
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/test/beans/DerivedTestBean.java | @@ -51,12 +51,14 @@ public static DerivedTestBean create(String[] names) {
}
+ @Override
public void setBeanName(String beanName) {
if (this.beanName == null || beanName == null) {
this.beanName = beanName;
}
}
+ @Override
public String getBeanName() {
return beanName;
}
@@ -79,10 +81,12 @@ public boolean wasInitialized() {
}
+ @Override
public void destroy() {
this.destroyed = true;
}
+ @Override
public boolean wasDestroyed() {
return destroyed;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/test/beans/DummyFactory.java | @@ -81,6 +81,7 @@ public DummyFactory() {
* Return if the bean managed by this factory is a singleton.
* @see FactoryBean#isSingleton()
*/
+ @Override
public boolean isSingleton() {
return this.singleton;
}
@@ -92,6 +93,7 @@ public void setSingleton(boolean singleton) {
this.singleton = singleton;
}
+ @Override
public void setBeanName(String beanName) {
this.beanName = beanName;
}
@@ -100,6 +102,7 @@ public String getBeanName() {
return beanName;
}
+ @Override
public void setBeanFactory(BeanFactory beanFactory) {
this.beanFactory = (AutowireCapableBeanFactory) beanFactory;
this.beanFactory.applyBeanPostProcessorsBeforeInitialization(this.testBean, this.beanName);
@@ -126,6 +129,7 @@ public TestBean getOtherTestBean() {
return otherTestBean;
}
+ @Override
public void afterPropertiesSet() {
if (initialized) {
throw new RuntimeException("Cannot call afterPropertiesSet twice on the one bean");
@@ -151,6 +155,7 @@ public static boolean wasPrototypeCreated() {
* and prototype mode.
* @see FactoryBean#getObject()
*/
+ @Override
public Object getObject() throws BeansException {
if (isSingleton()) {
return this.testBean;
@@ -165,11 +170,13 @@ public Object getObject() throws BeansException {
}
}
+ @Override
public Class<?> getObjectType() {
return TestBean.class;
}
+ @Override
public void destroy() {
if (this.testBean != null) {
this.testBean.setName(null); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/test/beans/LifecycleBean.java | @@ -59,6 +59,7 @@ public boolean isInitMethodDeclared() {
return initMethodDeclared;
}
+ @Override
public void setBeanName(String name) {
this.beanName = name;
}
@@ -67,6 +68,7 @@ public String getBeanName() {
return beanName;
}
+ @Override
public void setBeanFactory(BeanFactory beanFactory) {
this.owningFactory = beanFactory;
}
@@ -81,6 +83,7 @@ public void postProcessBeforeInit() {
this.postProcessedBeforeInit = true;
}
+ @Override
public void afterPropertiesSet() {
if (this.owningFactory == null) {
throw new RuntimeException("Factory didn't call setBeanFactory before afterPropertiesSet on lifecycle bean");
@@ -132,6 +135,7 @@ public void businessMethod() {
}
}
+ @Override
public void destroy() {
if (this.destroyed) {
throw new IllegalStateException("Already destroyed");
@@ -146,13 +150,15 @@ public boolean isDestroyed() {
public static class PostProcessor implements BeanPostProcessor {
+ @Override
public Object postProcessBeforeInitialization(Object bean, String name) throws BeansException {
if (bean instanceof LifecycleBean) {
((LifecycleBean) bean).postProcessBeforeInit();
}
return bean;
}
+ @Override
public Object postProcessAfterInitialization(Object bean, String name) throws BeansException {
if (bean instanceof LifecycleBean) {
((LifecycleBean) bean).postProcessAfterInit(); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/test/beans/NestedTestBean.java | @@ -37,6 +37,7 @@ public void setCompany(String company) {
this.company = (company != null ? company : "");
}
+ @Override
public String getCompany() {
return company;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-beans/src/test/java/test/beans/TestBean.java | @@ -137,6 +137,7 @@ public TestBean(Properties someProperties) {
}
+ @Override
public void setBeanName(String beanName) {
this.beanName = beanName;
}
@@ -145,6 +146,7 @@ public String getBeanName() {
return beanName;
}
+ @Override
public void setBeanFactory(BeanFactory beanFactory) {
this.beanFactory = beanFactory;
}
@@ -161,10 +163,12 @@ public boolean isPostProcessed() {
return postProcessed;
}
+ @Override
public String getName() {
return name;
}
+ @Override
public void setName(String name) {
this.name = name;
}
@@ -180,10 +184,12 @@ public void setSex(String sex) {
}
}
+ @Override
public int getAge() {
return age;
}
+ @Override
public void setAge(int age) {
this.age = age;
}
@@ -196,14 +202,17 @@ public void setJedi(boolean jedi) {
this.jedi = jedi;
}
+ @Override
public void setSpouse(ITestBean spouse) {
this.spouses = new ITestBean[] {spouse};
}
+ @Override
public ITestBean getSpouse() {
return (spouses != null ? spouses[0] : null);
}
+ @Override
public ITestBean[] getSpouses() {
return spouses;
}
@@ -230,10 +239,12 @@ public void setCountry(String country) {
this.country = country;
}
+ @Override
public String[] getStringArray() {
return stringArray;
}
+ @Override
public void setStringArray(String[] stringArray) {
this.stringArray = stringArray;
}
@@ -302,6 +313,7 @@ public void setSomeProperties(Properties someProperties) {
this.someProperties = someProperties;
}
+ @Override
public INestedTestBean getDoctor() {
return doctor;
}
@@ -310,6 +322,7 @@ public void setDoctor(INestedTestBean doctor) {
this.doctor = doctor;
}
+ @Override
public INestedTestBean getLawyer() {
return lawyer;
}
@@ -342,6 +355,7 @@ public void setSomeBoolean(Boolean someBoolean) {
this.someBoolean = someBoolean;
}
+ @Override
public IndexedTestBean getNestedIndexedBean() {
return nestedIndexedBean;
}
@@ -370,28 +384,33 @@ public void setPets(List pets) {
/**
* @see ITestBean#exceptional(Throwable)
*/
+ @Override
public void exceptional(Throwable t) throws Throwable {
if (t != null) {
throw t;
}
}
+ @Override
public void unreliableFileOperation() throws IOException {
throw new IOException();
}
/**
* @see ITestBean#returnsThis()
*/
+ @Override
public Object returnsThis() {
return this;
}
/**
* @see IOther#absquatulate()
*/
+ @Override
public void absquatulate() {
}
+ @Override
public int haveBirthday() {
return age++;
}
@@ -421,6 +440,7 @@ public int hashCode() {
return this.age;
}
+ @Override
public int compareTo(Object other) {
if (this.name != null && other instanceof TestBean) {
return this.name.compareTo(((TestBean) other).getName()); | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-context-support/src/test/java/org/springframework/beans/NestedTestBean.java | @@ -37,6 +37,7 @@ public void setCompany(String company) {
this.company = (company != null ? company : "");
}
+ @Override
public String getCompany() {
return company;
} | true |
Other | spring-projects | spring-framework | 4c8cd7b0bd45bbe37ec9cc588b0f29608831b05f.json | Add @Override annotations to test sources
Issue: SPR-10129 | spring-context-support/src/test/java/org/springframework/beans/TestBean.java | @@ -137,6 +137,7 @@ public TestBean(Properties someProperties) {
}
+ @Override
public void setBeanName(String beanName) {
this.beanName = beanName;
}
@@ -145,6 +146,7 @@ public String getBeanName() {
return beanName;
}
+ @Override
public void setBeanFactory(BeanFactory beanFactory) {
this.beanFactory = beanFactory;
}
@@ -161,10 +163,12 @@ public boolean isPostProcessed() {
return postProcessed;
}
+ @Override
public String getName() {
return name;
}
+ @Override
public void setName(String name) {
this.name = name;
}
@@ -180,10 +184,12 @@ public void setSex(String sex) {
}
}
+ @Override
public int getAge() {
return age;
}
+ @Override
public void setAge(int age) {
this.age = age;
}
@@ -196,14 +202,17 @@ public void setJedi(boolean jedi) {
this.jedi = jedi;
}
+ @Override
public ITestBean getSpouse() {
return (spouses != null ? spouses[0] : null);
}
+ @Override
public void setSpouse(ITestBean spouse) {
this.spouses = new ITestBean[] {spouse};
}
+ @Override
public ITestBean[] getSpouses() {
return spouses;
}
@@ -230,10 +239,12 @@ public void setCountry(String country) {
this.country = country;
}
+ @Override
public String[] getStringArray() {
return stringArray;
}
+ @Override
public void setStringArray(String[] stringArray) {
this.stringArray = stringArray;
}
@@ -302,6 +313,7 @@ public void setSomeProperties(Properties someProperties) {
this.someProperties = someProperties;
}
+ @Override
public INestedTestBean getDoctor() {
return doctor;
}
@@ -310,6 +322,7 @@ public void setDoctor(INestedTestBean doctor) {
this.doctor = doctor;
}
+ @Override
public INestedTestBean getLawyer() {
return lawyer;
}
@@ -342,6 +355,7 @@ public void setSomeBoolean(Boolean someBoolean) {
this.someBoolean = someBoolean;
}
+ @Override
public IndexedTestBean getNestedIndexedBean() {
return nestedIndexedBean;
}
@@ -370,28 +384,33 @@ public void setPets(List pets) {
/**
* @see org.springframework.beans.ITestBean#exceptional(Throwable)
*/
+ @Override
public void exceptional(Throwable t) throws Throwable {
if (t != null) {
throw t;
}
}
+ @Override
public void unreliableFileOperation() throws IOException {
throw new IOException();
}
/**
* @see org.springframework.beans.ITestBean#returnsThis()
*/
+ @Override
public Object returnsThis() {
return this;
}
/**
* @see org.springframework.beans.IOther#absquatulate()
*/
+ @Override
public void absquatulate() {
}
+ @Override
public int haveBirthday() {
return age++;
}
@@ -421,6 +440,7 @@ public int hashCode() {
return this.age;
}
+ @Override
public int compareTo(Object other) {
if (this.name != null && other instanceof TestBean) {
return this.name.compareTo(((TestBean) other).getName()); | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.