language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
spring-projects
spring-framework
22bcb54ab66c952d1c122526729b64d77a77280b.json
Add Spring MVC Test framework This commit adds the spring-test-mvc project [1] to the Spring Framework as part of the spring-test module. The sources are added as a root-level project called "spring-test-mvc" instead of under "spring-test" because the new sources need to be compiled with Servlet 3 while the current "...
spring-test-mvc/src/test/resources/org/springframework/test/web/mock/client/samples/ludwig.json
@@ -0,0 +1,5 @@ +{ + "name" : "Ludwig van Beethoven", + "someDouble" : "1.6035", + "someBoolean" : "true" +} \ No newline at end of file
true
Other
spring-projects
spring-framework
22bcb54ab66c952d1c122526729b64d77a77280b.json
Add Spring MVC Test framework This commit adds the spring-test-mvc project [1] to the Spring Framework as part of the spring-test module. The sources are added as a root-level project called "spring-test-mvc" instead of under "spring-test" because the new sources need to be compiled with Servlet 3 while the current "...
spring-test-mvc/src/test/resources/org/springframework/test/web/mock/servlet/samples/context/TestContextTests-context.xml
@@ -0,0 +1,14 @@ +<?xml version="1.0" encoding="UTF-8"?> +<beans:beans xmlns="http://www.springframework.org/schema/mvc" + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xmlns:beans="http://www.springframework.org/schema/beans" + xsi:schemaLocation=" + http://www.springframework.org/schema/mvc http://www.spri...
true
Other
spring-projects
spring-framework
22bcb54ab66c952d1c122526729b64d77a77280b.json
Add Spring MVC Test framework This commit adds the spring-test-mvc project [1] to the Spring Framework as part of the spring-test module. The sources are added as a root-level project called "spring-test-mvc" instead of under "spring-test" because the new sources need to be compiled with Servlet 3 while the current "...
spring-test-mvc/src/test/resources/org/springframework/test/web/mock/servlet/samples/context/security.xml
@@ -0,0 +1,18 @@ +<b:beans xmlns:b="http://www.springframework.org/schema/beans" + xmlns="http://www.springframework.org/schema/security" + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:schemaLocation="http://www.springframework.org/schema/security http://www.springframework.org/schema/security/spring-sec...
true
Other
spring-projects
spring-framework
22bcb54ab66c952d1c122526729b64d77a77280b.json
Add Spring MVC Test framework This commit adds the spring-test-mvc project [1] to the Spring Framework as part of the spring-test module. The sources are added as a root-level project called "spring-test-mvc" instead of under "spring-test" because the new sources need to be compiled with Servlet 3 while the current "...
spring-test-mvc/src/test/resources/org/springframework/test/web/mock/servlet/samples/servlet-context.xml
@@ -0,0 +1,31 @@ +<?xml version="1.0" encoding="UTF-8"?> +<beans xmlns="http://www.springframework.org/schema/beans" + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:mvc="http://www.springframework.org/schema/mvc" + xsi:schemaLocation=" + http://www.springframework.org/schema/mvc http://www.springfr...
true
Other
spring-projects
spring-framework
22bcb54ab66c952d1c122526729b64d77a77280b.json
Add Spring MVC Test framework This commit adds the spring-test-mvc project [1] to the Spring Framework as part of the spring-test module. The sources are added as a root-level project called "spring-test-mvc" instead of under "spring-test" because the new sources need to be compiled with Servlet 3 while the current "...
spring-test-mvc/src/test/webapp/WEB-INF/layouts/main.jsp
@@ -0,0 +1,12 @@ +<%@ page language="java" contentType="text/html; charset=UTF-8" + pageEncoding="UTF-8"%> +<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> +<html> +<head> +<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> +<title>Fake Layout</...
true
Other
spring-projects
spring-framework
22bcb54ab66c952d1c122526729b64d77a77280b.json
Add Spring MVC Test framework This commit adds the spring-test-mvc project [1] to the Spring Framework as part of the spring-test module. The sources are added as a root-level project called "spring-test-mvc" instead of under "spring-test" because the new sources need to be compiled with Servlet 3 while the current "...
spring-test-mvc/src/test/webapp/WEB-INF/layouts/tiles.xml
@@ -0,0 +1,8 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE tiles-definitions PUBLIC "-//Apache Software Foundation//DTD Tiles Configuration 2.1//EN" "http://tiles.apache.org/dtds/tiles-config_2_1.dtd"> + +<tiles-definitions> + + <definition name="mainLayout" templateExpression="/WEB-INF/layouts/main.jsp"/> + +<...
true
Other
spring-projects
spring-framework
22bcb54ab66c952d1c122526729b64d77a77280b.json
Add Spring MVC Test framework This commit adds the spring-test-mvc project [1] to the Spring Framework as part of the spring-test module. The sources are added as a root-level project called "spring-test-mvc" instead of under "spring-test" because the new sources need to be compiled with Servlet 3 while the current "...
spring-test-mvc/src/test/webapp/WEB-INF/readme.txt
@@ -0,0 +1,2 @@ + +Dummy web application for testing purposes. \ No newline at end of file
true
Other
spring-projects
spring-framework
22bcb54ab66c952d1c122526729b64d77a77280b.json
Add Spring MVC Test framework This commit adds the spring-test-mvc project [1] to the Spring Framework as part of the spring-test module. The sources are added as a root-level project called "spring-test-mvc" instead of under "spring-test" because the new sources need to be compiled with Servlet 3 while the current "...
spring-test-mvc/src/test/webapp/WEB-INF/views/tiles.xml
@@ -0,0 +1,8 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE tiles-definitions PUBLIC "-//Apache Software Foundation//DTD Tiles Configuration 2.1//EN" "http://tiles.apache.org/dtds/tiles-config_2_1.dtd"> + +<tiles-definitions> + + <definition name="form" extends="mainLayout"/> + +</tiles-definitions>
true
Other
spring-projects
spring-framework
22bcb54ab66c952d1c122526729b64d77a77280b.json
Add Spring MVC Test framework This commit adds the spring-test-mvc project [1] to the Spring Framework as part of the spring-test module. The sources are added as a root-level project called "spring-test-mvc" instead of under "spring-test" because the new sources need to be compiled with Servlet 3 while the current "...
spring-test-mvc/src/test/webapp/resources/Spring.js
@@ -0,0 +1,16 @@ +/* + * Copyright 2004-2008 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
22bcb54ab66c952d1c122526729b64d77a77280b.json
Add Spring MVC Test framework This commit adds the spring-test-mvc project [1] to the Spring Framework as part of the spring-test module. The sources are added as a root-level project called "spring-test-mvc" instead of under "spring-test" because the new sources need to be compiled with Servlet 3 while the current "...
spring-test-mvc/test-mvc.gradle
@@ -0,0 +1,2 @@ +ext.mergeIntoProject = project(':spring-test') +apply from: "${rootProject.projectDir}/merge-dist.gradle"
true
Other
spring-projects
spring-framework
ef9d35c473f046c66b6a7780ea3d38430bc0c58c.json
Add PATCH to "Allow" header for OPTIONS requests
spring-webmvc/src/main/java/org/springframework/web/servlet/FrameworkServlet.java
@@ -785,7 +785,7 @@ protected void service(HttpServletRequest request, HttpServletResponse response) String method = request.getMethod(); if (method.equalsIgnoreCase(RequestMethod.PATCH.name())) { - doPatch(request, response); + processRequest(request, response); } else { super.service(request, re...
true
Other
spring-projects
spring-framework
ef9d35c473f046c66b6a7780ea3d38430bc0c58c.json
Add PATCH to "Allow" header for OPTIONS requests
spring-webmvc/src/test/java/org/springframework/web/servlet/DispatcherServletTests.java
@@ -16,6 +16,12 @@ package org.springframework.web.servlet; +import static org.hamcrest.CoreMatchers.equalTo; +import static org.hamcrest.CoreMatchers.instanceOf; +import static org.hamcrest.CoreMatchers.notNullValue; +import static org.hamcrest.CoreMatchers.sameInstance; +import static org.junit.Assert.assertThat...
true
Other
spring-projects
spring-framework
0baa1a56c2f200d0cbd21a1318346670a4fa14d6.json
Add URI and method name on ResourceAccess Issue: SPR-9325
spring-web/src/main/java/org/springframework/web/client/RestTemplate.java
@@ -495,7 +495,8 @@ protected <T> T doExecute(URI url, HttpMethod method, RequestCallback requestCal } } catch (IOException ex) { - throw new ResourceAccessException("I/O error: " + ex.getMessage(), ex); + throw new ResourceAccessException("I/O error on " + method.name() + + " request for \"" + url + ...
false
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-orm/src/main/java/org/springframework/orm/hibernate3/support/OpenSessionInViewFilter.java
@@ -17,6 +17,7 @@ package org.springframework.orm.hibernate3.support; import java.io.IOException; +import java.util.concurrent.Callable; import javax.servlet.FilterChain; import javax.servlet.ServletException; @@ -32,9 +33,10 @@ import org.springframework.transaction.support.TransactionSynchronizationManager; ...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-orm/src/main/java/org/springframework/orm/hibernate3/support/OpenSessionInViewInterceptor.java
@@ -16,6 +16,8 @@ package org.springframework.orm.hibernate3.support; +import java.util.concurrent.Callable; + import org.hibernate.HibernateException; import org.hibernate.Session; import org.springframework.dao.DataAccessException; @@ -25,10 +27,11 @@ import org.springframework.transaction.support.Transactio...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-orm/src/main/java/org/springframework/orm/hibernate4/support/OpenSessionInViewFilter.java
@@ -17,6 +17,7 @@ package org.springframework.orm.hibernate4.support; import java.io.IOException; +import java.util.concurrent.Callable; import javax.servlet.FilterChain; import javax.servlet.ServletException; @@ -32,9 +33,10 @@ import org.springframework.orm.hibernate4.SessionHolder; import org.springframewo...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-orm/src/main/java/org/springframework/orm/hibernate4/support/OpenSessionInViewInterceptor.java
@@ -16,6 +16,8 @@ package org.springframework.orm.hibernate4.support; +import java.util.concurrent.Callable; + import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.hibernate.FlushMode; @@ -29,10 +31,11 @@ import org.springframework.transaction.support.TransactionSynch...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-orm/src/main/java/org/springframework/orm/jpa/support/OpenEntityManagerInViewFilter.java
@@ -17,6 +17,7 @@ package org.springframework.orm.jpa.support; import java.io.IOException; +import java.util.concurrent.Callable; import javax.persistence.EntityManager; import javax.persistence.EntityManagerFactory; @@ -32,9 +33,10 @@ import org.springframework.transaction.support.TransactionSynchronizationMa...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-orm/src/main/java/org/springframework/orm/jpa/support/OpenEntityManagerInViewInterceptor.java
@@ -16,6 +16,8 @@ package org.springframework.orm.jpa.support; +import java.util.concurrent.Callable; + import javax.persistence.EntityManager; import javax.persistence.PersistenceException; @@ -27,10 +29,11 @@ import org.springframework.transaction.support.TransactionSynchronizationManager; import org.sprin...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-orm/src/test/java/org/springframework/orm/hibernate3/support/OpenSessionInViewTests.java
@@ -181,6 +181,7 @@ public void testOpenSessionInViewInterceptorAsyncScenario() throws Exception { replay(asyncWebRequest); WebAsyncManager asyncManager = WebAsyncUtils.getAsyncManager(this.request); + asyncManager.setTaskExecutor(new SyncTaskExecutor()); asyncManager.setAsyncWebRequest(asyncWebRequest); ...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-orm/src/test/java/org/springframework/orm/jpa/support/OpenEntityManagerInViewTests.java
@@ -38,6 +38,7 @@ import junit.framework.TestCase; +import org.springframework.core.task.SimpleAsyncTaskExecutor; import org.springframework.mock.web.MockFilterConfig; import org.springframework.mock.web.MockHttpServletRequest; import org.springframework.mock.web.MockHttpServletResponse; @@ -158,6 +159,7 @@ pub...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-web/src/main/java/org/springframework/web/context/request/async/AsyncWebRequest.java
@@ -41,6 +41,11 @@ public interface AsyncWebRequest extends NativeWebRequest { */ void setTimeoutHandler(Runnable runnable); + /** + * Add a Runnable to be invoked when request processing completes. + */ + void addCompletionHandler(Runnable runnable); + /** * Mark the start of asynchronous request process...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-web/src/main/java/org/springframework/web/context/request/async/CallableInterceptorChain.java
@@ -0,0 +1,64 @@ +/* + * Copyright 2002-2012 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-web/src/main/java/org/springframework/web/context/request/async/CallableProcessingInterceptor.java
@@ -0,0 +1,67 @@ +/* + * Copyright 2002-2012 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResult.java
@@ -25,9 +25,9 @@ /** * {@code DeferredResult} provides an alternative to using a {@link Callable} - * for asynchronous request processing. While a Callable is executed concurrently - * on behalf of the application, with a DeferredResult the application can produce - * the result from a thread of its choice. + * f...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResultInterceptorChain.java
@@ -0,0 +1,71 @@ +/* + * Copyright 2002-2012 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResultProcessingInterceptor.java
@@ -0,0 +1,83 @@ +/* + * Copyright 2002-2012 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + ...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-web/src/main/java/org/springframework/web/context/request/async/NoSupportAsyncWebRequest.java
@@ -49,10 +49,6 @@ public boolean isAsyncStarted() { return false; } - public boolean isDispatched() { - return false; - } - // Not supported public void startAsync() {
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-web/src/main/java/org/springframework/web/context/request/async/StandardServletAsyncWebRequest.java
@@ -24,7 +24,6 @@ import javax.servlet.AsyncContext; import javax.servlet.AsyncEvent; import javax.servlet.AsyncListener; -import javax.servlet.DispatcherType; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; @@ -94,10 +93,6 @@ public boolean isAsyncStarted() { retu...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-web/src/main/java/org/springframework/web/context/request/async/WebAsyncManager.java
@@ -15,10 +15,7 @@ */ package org.springframework.web.context.request.async; -import java.util.ArrayList; -import java.util.Collections; import java.util.LinkedHashMap; -import java.util.List; import java.util.Map; import java.util.concurrent.Callable; @@ -73,7 +70,11 @@ public final class WebAsyncManager { ...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-web/src/main/java/org/springframework/web/context/request/async/WebAsyncUtils.java
@@ -64,10 +64,11 @@ public static WebAsyncManager getAsyncManager(WebRequest webRequest) { } /** - * Create an AsyncWebRequest instance. - * <p>By default an instance of {@link StandardServletAsyncWebRequest} is created - * if running in Servlet 3.0 (or higher) environment or as a fallback option an - * insta...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-web/src/test/java/org/springframework/web/context/request/async/DeferredResultTests.java
@@ -100,7 +100,7 @@ public void setExpired() { DeferredResult<String> result = new DeferredResult<String>(); assertFalse(result.isSetOrExpired()); - result.setExpired(); + result.getAndSetExpired(); assertTrue(result.isSetOrExpired()); assertFalse(result.setResult("hello")); }
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-web/src/test/java/org/springframework/web/context/request/async/WebAsyncManagerTests.java
@@ -35,7 +35,6 @@ import org.springframework.core.task.AsyncTaskExecutor; import org.springframework.core.task.SimpleAsyncTaskExecutor; import org.springframework.mock.web.MockHttpServletRequest; -import org.springframework.web.context.request.async.WebAsyncManager.WebAsyncThreadInitializer; /** @@ -92,24 +91,2...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-webmvc/src/main/java/org/springframework/web/servlet/AsyncHandlerInterceptor.java
@@ -19,18 +19,19 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; +import org.springframework.web.method.HandlerMethod; + /** * Extends {@code HandlerInterceptor} with a callback method invoked during * asynchronous request handling. * * <p>When a handler star...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-webmvc/src/main/java/org/springframework/web/servlet/FrameworkServlet.java
@@ -20,6 +20,7 @@ import java.security.Principal; import java.util.ArrayList; import java.util.Collections; +import java.util.concurrent.Callable; import javax.servlet.ServletContext; import javax.servlet.ServletException; @@ -44,12 +45,13 @@ import org.springframework.web.bind.annotation.RequestMethod; import...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-webmvc/src/main/java/org/springframework/web/servlet/HandlerInterceptor.java
@@ -19,6 +19,8 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; +import org.springframework.web.method.HandlerMethod; + /** * Workflow interface that allows for customized handler execution chains. * Applications can register any number of existing or custom inter...
true
Other
spring-projects
spring-framework
57c36dd39500654caeea124519257696d98f9f14.json
Add interceptors for async processing This change introduces two new interceptors with callback methods for concurrent request handling. These interfaces are CallableProcessingInterceptor and DeferredResultProcessingInterceptor. Unlike a HandlerInterceptor, and its AsyncHandlerInterceptor sub-type, which intercepts t...
spring-webmvc/src/main/java/org/springframework/web/servlet/handler/HandlerInterceptorAdapter.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2006 the original author or authors. + * Copyright 2002-2012 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,7 +19,7 @@ import javax.servlet.http.Ht...
true
Other
spring-projects
spring-framework
f191a55b8f570130f751c843d034451c6a277be3.json
Preserve comments when using JibxMarshaller Prior to this commit, JibxMarshaller used a SAX ContentHandler to marshal to StAX XMLEventWriters, which inadvertently resulted in the deletion of XML comments. After this commit, JibxMarshaller adapts the XMLEventWriter into an XMLStreamWriter and comments are preserved. ...
spring-core/src/main/java/org/springframework/util/xml/StaxUtils.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2010 the original author or authors. + * Copyright 2002-2012 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -309,6 +309,15 @@ public static XMLStreamRea...
true
Other
spring-projects
spring-framework
f191a55b8f570130f751c843d034451c6a277be3.json
Preserve comments when using JibxMarshaller Prior to this commit, JibxMarshaller used a SAX ContentHandler to marshal to StAX XMLEventWriters, which inadvertently resulted in the deletion of XML comments. After this commit, JibxMarshaller adapts the XMLEventWriter into an XMLStreamWriter and comments are preserved. ...
spring-core/src/main/java/org/springframework/util/xml/XMLEventStreamWriter.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2010 the original author or authors. + * Copyright 2002-2012 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -193,7 +193,7 @@ public void close() throws ...
true
Other
spring-projects
spring-framework
f191a55b8f570130f751c843d034451c6a277be3.json
Preserve comments when using JibxMarshaller Prior to this commit, JibxMarshaller used a SAX ContentHandler to marshal to StAX XMLEventWriters, which inadvertently resulted in the deletion of XML comments. After this commit, JibxMarshaller adapts the XMLEventWriter into an XMLStreamWriter and comments are preserved. ...
spring-core/src/test/java/org/springframework/util/xml/XMLEventStreamWriterTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2011 the original author or authors. + * Copyright 2002-2012 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -29,8 +29,7 @@ public class XMLEventStreamW...
true
Other
spring-projects
spring-framework
f191a55b8f570130f751c843d034451c6a277be3.json
Preserve comments when using JibxMarshaller Prior to this commit, JibxMarshaller used a SAX ContentHandler to marshal to StAX XMLEventWriters, which inadvertently resulted in the deletion of XML comments. After this commit, JibxMarshaller adapts the XMLEventWriter into an XMLStreamWriter and comments are preserved. ...
spring-oxm/src/main/java/org/springframework/oxm/jibx/JibxMarshaller.java
@@ -338,8 +338,8 @@ private void transformAndMarshal(Object graph, Result result) throws IOException @Override protected void marshalXmlEventWriter(Object graph, XMLEventWriter eventWriter) { - ContentHandler contentHandler = StaxUtils.createContentHandler(eventWriter); - marshalSaxHandlers(graph, contentHandle...
true
Other
spring-projects
spring-framework
323ac6ad01328d1ac400d001c65ea89c7be98191.json
Release version 3.2.0.M2
gradle.properties
@@ -1 +1 @@ -version=3.2.0.BUILD-SNAPSHOT +version=3.2.0.M2
false
Other
spring-projects
spring-framework
2ff3d53962c1249dccfb493eb46f12e30612de05.json
Ignore parse errors in HttpPutFormContentFilter Errors when parsing the request content-type, in order to find out if the request has form content, are translated to false. Issue: SPR-9769
spring-web/src/main/java/org/springframework/web/filter/HttpPutFormContentFilter.java
@@ -87,14 +87,18 @@ public InputStream getBody() throws IOException { else { filterChain.doFilter(request, response); } - } private boolean isFormContentType(HttpServletRequest request) { String contentType = request.getContentType(); if (contentType != null) { - MediaType mediaType = MediaType....
true
Other
spring-projects
spring-framework
2ff3d53962c1249dccfb493eb46f12e30612de05.json
Ignore parse errors in HttpPutFormContentFilter Errors when parsing the request content-type, in order to find out if the request has form content, are translated to false. Issue: SPR-9769
spring-web/src/test/java/org/springframework/web/filter/HttpPutFormContentFilterTests.java
@@ -87,6 +87,15 @@ public void wrapFormEncodedOnly() throws Exception { } } + @Test + public void invalidMediaType() throws Exception { + request.setContent("".getBytes("ISO-8859-1")); + request.setContentType("foo"); + filterChain = new MockFilterChain(); + filter.doFilter(request, response, filterChain); +...
true
Other
spring-projects
spring-framework
fc859ffd6e0d5ca8e69b736bc93baf8081b89932.json
Update Javadoc in ExtendedBeanInfo - updated the link to the "indexed properties" section of the JavaBeans tutorial
spring-beans/src/main/java/org/springframework/beans/ExtendedBeanInfo.java
@@ -45,7 +45,7 @@ * {@link Introspector#getBeanInfo(Class)}) by including non-void returning setter * methods in the collection of {@link #getPropertyDescriptors() property descriptors}. * Both regular and - * <a href="http://download.oracle.com/javase/tutorial/javabeans/properties/indexed.html"> + * <a href="htt...
true
Other
spring-projects
spring-framework
fc859ffd6e0d5ca8e69b736bc93baf8081b89932.json
Update Javadoc in ExtendedBeanInfo - updated the link to the "indexed properties" section of the JavaBeans tutorial
spring-beans/src/main/java/org/springframework/beans/ExtendedBeanInfoFactory.java
@@ -41,7 +41,7 @@ class ExtendedBeanInfoFactory implements Ordered, BeanInfoFactory { /** * Return whether the given bean class declares or inherits any non-void returning - * JavaBeans or <em>indexed</em> setter methods. + * JavaBeans or <em>indexed property</em> setter methods. */ public boolean support...
true
Other
spring-projects
spring-framework
0721146b14e3df3bde3e6e8f2a871bb0b995ef4f.json
Improve regex for parsing query params Previously UriComponentsBuilder used a regular expression for parsing query name-value pairs where both name and value were expected to not contain neither '&', not '='. The idea is that the presence of reserved characters makes it impossible to guess correctly how to parse the q...
spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java
@@ -53,7 +53,7 @@ */ public class UriComponentsBuilder { - private static final Pattern QUERY_PARAM_PATTERN = Pattern.compile("([^&=]+)=?([^&=]+)?"); + private static final Pattern QUERY_PARAM_PATTERN = Pattern.compile("([^&=]+)=?([^&]+)?"); private static final String SCHEME_PATTERN = "([^:/?#]+):";
true
Other
spring-projects
spring-framework
0721146b14e3df3bde3e6e8f2a871bb0b995ef4f.json
Improve regex for parsing query params Previously UriComponentsBuilder used a regular expression for parsing query name-value pairs where both name and value were expected to not contain neither '&', not '='. The idea is that the presence of reserved characters makes it impossible to guess correctly how to parse the q...
spring-web/src/test/java/org/springframework/web/util/UriComponentsBuilderTests.java
@@ -146,6 +146,16 @@ public void fromUriString() { assertEquals("28", result.getFragment()); } + // SPR-9832 + + @Test + public void fromUriStringQueryParamWithReservedCharInValue() throws URISyntaxException { + String uri = "http://www.google.com/ig/calculator?q=1USD=?EUR"; + UriComponents result ...
true
Other
spring-projects
spring-framework
2f504dda3a8fe682f2ca789955818c9a5609f19e.json
Update remoting chapter (minor) Issue: SPR-9822
src/reference/docbook/new-in-3.2.xml
@@ -38,6 +38,21 @@ </section> + <section id="new-in-3.2-spring-mvc-test"> + <title>Spring MVC Test framework</title> + + <para>First-class support for testing Spring MVC applications with a + fluent API and without a servlet container. Server-side tests involve + use of the <classnam...
true
Other
spring-projects
spring-framework
2f504dda3a8fe682f2ca789955818c9a5609f19e.json
Update remoting chapter (minor) Issue: SPR-9822
src/reference/docbook/remoting.xml
@@ -1389,15 +1389,15 @@ String result = specifying an implementation of <interfacename>ClientHttpRequestFactory</interfacename>. Spring provides the implementation - <classname>CommonsClientHttpRequestFactory</classname> that uses the - Jakarta Commons <classname>HttpClient</classname> to...
true
Other
spring-projects
spring-framework
ff8a6e8fdb147e1b988c1ca5b4c8b3008b67534d.json
Remove code duplication in ModelAndViewAssert ModelAndViewAssert now uses assertion methods in the newly introduced AssertionErrors class.
spring-test/src/main/java/org/springframework/test/web/ModelAndViewAssert.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2009 the original author or authors. + * Copyright 2002-2012 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -16,6 +16,8 @@ package org.springframewor...
false
Other
spring-projects
spring-framework
dbcbdace9e83a020e35ed95f203fbbdb632f2a85.json
Parameterize AsyncTask type
spring-web/src/main/java/org/springframework/web/context/request/async/AsyncTask.java
@@ -27,9 +27,9 @@ * @author Rossen Stoyanchev * @since 3.2 */ -public class AsyncTask { +public class AsyncTask<V> { - private final Callable<?> callable; + private final Callable<V> callable; private final Long timeout; @@ -45,7 +45,7 @@ public class AsyncTask { * @param timeout timeout value in milli...
true
Other
spring-projects
spring-framework
dbcbdace9e83a020e35ed95f203fbbdb632f2a85.json
Parameterize AsyncTask type
spring-web/src/main/java/org/springframework/web/context/request/async/WebAsyncManager.java
@@ -260,7 +260,7 @@ public void run() { * @param processingContext additional context to save that can be accessed * via {@link #getConcurrentResultContext()} */ - public void startCallableProcessing(AsyncTask asyncTask, Object... processingContext) { + public void startCallableProcessing(AsyncTask<?> asyncTas...
true
Other
spring-projects
spring-framework
dbcbdace9e83a020e35ed95f203fbbdb632f2a85.json
Parameterize AsyncTask type
spring-web/src/test/java/org/springframework/web/context/request/async/WebAsyncManagerTests.java
@@ -124,7 +124,8 @@ public void startCallableProcessingAsyncTask() { this.asyncWebRequest.startAsync(); replay(this.asyncWebRequest); - AsyncTask asyncTask = new AsyncTask(1000L, executor, createMock(Callable.class)); + @SuppressWarnings("unchecked") + AsyncTask<Object> asyncTask = new AsyncTask<Object>(1000...
true
Other
spring-projects
spring-framework
dbcbdace9e83a020e35ed95f203fbbdb632f2a85.json
Parameterize AsyncTask type
spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/AsyncTaskMethodReturnValueHandler.java
@@ -52,9 +52,9 @@ public void handleReturnValue(Object returnValue, return; } - AsyncTask asyncTask = (AsyncTask) returnValue; + AsyncTask<?> asyncTask = (AsyncTask<?>) returnValue; asyncTask.setBeanFactory(this.beanFactory); - WebAsyncUtils.getAsyncManager(webRequest).startCallableProcessing(asyncTask.g...
true
Other
spring-projects
spring-framework
300ab4537bd6fdd4188057a699564759edd5da78.json
Add Spring 32 methods to StandaloneMockMvcBuilder
spring-test-mvc/src/main/java/org/springframework/test/web/mock/servlet/setup/StandaloneMockMvcBuilder.java
@@ -31,6 +31,7 @@ import org.springframework.util.Assert; import org.springframework.util.ObjectUtils; import org.springframework.validation.Validator; +import org.springframework.web.accept.ContentNegotiationManager; import org.springframework.web.context.WebApplicationContext; import org.springframework.web.cont...
false
Other
spring-projects
spring-framework
0bb24f2922c57e6ba8869a2a443044c3670e1fba.json
Update documentation TODOs Issue: SPR-9864
spring-test/src/main/java/org/springframework/test/context/support/AbstractGenericWebContextLoader.java
@@ -34,7 +34,7 @@ import org.springframework.web.context.support.GenericWebApplicationContext; /** - * TODO [SPR-5243] Document AbstractGenericWebContextLoader. + * TODO [SPR-9864] Document AbstractGenericWebContextLoader. * * @author Sam Brannen * @since 3.2 @@ -47,7 +47,7 @@ public abstract class AbstractGe...
true
Other
spring-projects
spring-framework
0bb24f2922c57e6ba8869a2a443044c3670e1fba.json
Update documentation TODOs Issue: SPR-9864
spring-test/src/main/java/org/springframework/test/context/support/AnnotationConfigContextLoaderUtils.java
@@ -26,7 +26,7 @@ import org.springframework.util.Assert; /** - * TODO [SPR-5243] Document AnnotationConfigContextLoaderUtils. + * TODO [SPR-9864] Document AnnotationConfigContextLoaderUtils. * * @author Sam Brannen * @since 3.2
true
Other
spring-projects
spring-framework
0bb24f2922c57e6ba8869a2a443044c3670e1fba.json
Update documentation TODOs Issue: SPR-9864
spring-test/src/main/java/org/springframework/test/context/support/AnnotationConfigWebContextLoader.java
@@ -25,7 +25,7 @@ import org.springframework.web.context.support.GenericWebApplicationContext; /** - * TODO [SPR-5243] Document AnnotationConfigWebContextLoader. + * TODO [SPR-9864] Document AnnotationConfigWebContextLoader. * * @author Sam Brannen * @since 3.2
true
Other
spring-projects
spring-framework
0bb24f2922c57e6ba8869a2a443044c3670e1fba.json
Update documentation TODOs Issue: SPR-9864
spring-test/src/main/java/org/springframework/test/context/support/XmlWebContextLoader.java
@@ -21,7 +21,7 @@ import org.springframework.web.context.support.GenericWebApplicationContext; /** - * TODO [SPR-5243] Document XmlWebContextLoader. + * TODO [SPR-9864] Document XmlWebContextLoader. * * @author Sam Brannen * @since 3.2 @@ -36,7 +36,7 @@ protected String getResourceSuffix() { } /** - * ...
true
Other
spring-projects
spring-framework
0bb24f2922c57e6ba8869a2a443044c3670e1fba.json
Update documentation TODOs Issue: SPR-9864
spring-test/src/main/java/org/springframework/test/context/web/WebAppConfiguration.java
@@ -24,7 +24,7 @@ import java.lang.annotation.Target; /** - * TODO [SPR-5243] Document WebAppConfiguration. + * TODO [SPR-9864] Document WebAppConfiguration. * * @author Sam Brannen * @since 3.2
true
Other
spring-projects
spring-framework
0bb24f2922c57e6ba8869a2a443044c3670e1fba.json
Update documentation TODOs Issue: SPR-9864
spring-test/src/main/java/org/springframework/test/context/web/WebMergedContextConfiguration.java
@@ -27,7 +27,7 @@ import org.springframework.util.StringUtils; /** - * TODO [SPR-5243] Document WebMergedContextConfiguration. + * TODO [SPR-9864] Document WebMergedContextConfiguration. * * @author Sam Brannen * @since 3.2 @@ -40,7 +40,7 @@ public class WebMergedContextConfiguration extends MergedContextConf...
true
Other
spring-projects
spring-framework
0bb24f2922c57e6ba8869a2a443044c3670e1fba.json
Update documentation TODOs Issue: SPR-9864
spring-test/src/main/java/org/springframework/test/context/web/WebTestExecutionListener.java
@@ -33,7 +33,7 @@ import org.springframework.web.context.request.ServletWebRequest; /** - * TODO [SPR-5243] Document WebTestExecutionListener. + * TODO [SPR-9864] Document WebTestExecutionListener. * * @author Sam Brannen * @since 3.2 @@ -44,7 +44,7 @@ public class WebTestExecutionListener extends AbstractTes...
true
Other
spring-projects
spring-framework
98808347ca4e1c0fffa3430321e701bc4c297257.json
Remove trailing whitespace
spring-expression/src/main/java/org/springframework/expression/spel/support/ReflectiveMethodResolver.java
@@ -53,7 +53,7 @@ public class ReflectiveMethodResolver implements MethodResolver { private Map<Class<?>, MethodFilter> filters = null; - // Using distance will ensure a more accurate match is discovered, + // Using distance will ensure a more accurate match is discovered, // more closely following the Java ru...
true
Other
spring-projects
spring-framework
98808347ca4e1c0fffa3430321e701bc4c297257.json
Remove trailing whitespace
spring-expression/src/main/java/org/springframework/expression/spel/support/ReflectivePropertyAccessor.java
@@ -37,8 +37,8 @@ /** * Simple PropertyAccessor that uses reflection to access properties for reading and writing. A property can be accessed - * if it is accessible as a field on the object or through a getter (if being read) or a setter (if being written). - * + * if it is accessible as a field on the object o...
true
Other
spring-projects
spring-framework
98808347ca4e1c0fffa3430321e701bc4c297257.json
Remove trailing whitespace
spring-expression/src/test/java/org/springframework/expression/spel/MethodInvocationTests.java
@@ -40,7 +40,7 @@ /** * Tests invocation of methods. - * + * * @author Andy Clement */ public class MethodInvocationTests extends ExpressionTestCase { @@ -89,15 +89,15 @@ public void testArgumentConversion01() { evaluate("new String('hello 2.0 to you').startsWith(7.0d)", false, Boolean.class); evaluate...
true
Other
spring-projects
spring-framework
98808347ca4e1c0fffa3430321e701bc4c297257.json
Remove trailing whitespace
spring-expression/src/test/java/org/springframework/expression/spel/PropertyAccessTests.java
@@ -37,7 +37,7 @@ /** * Tests accessing of properties. - * + * * @author Andy Clement */ public class PropertyAccessTests extends ExpressionTestCase { @@ -65,9 +65,9 @@ public void testNonExistentPropertiesAndMethods() { // name is ok but foobar does not exist: evaluateAndCheckError("name.foobar", Spel...
true
Other
spring-projects
spring-framework
c8061393fbe3aa20bb51606c60d01a772d3df536.json
Prevent memory leaks with @Configuration beans Refactor ConfigurationClassEnhancer to allow cglib caching of generated classes. Prior to this commit each enhanced @Configuration class would consume permgen space when created. The CallbackFilter and Callback Types are now defined as static final members so that they ...
spring-context/src/main/java/org/springframework/context/annotation/ConfigurationClassEnhancer.java
@@ -17,8 +17,6 @@ package org.springframework.context.annotation; import java.lang.reflect.Method; -import java.util.ArrayList; -import java.util.List; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -54,40 +52,40 @@ class ConfigurationClassEnhancer { private static f...
false
Other
spring-projects
spring-framework
e543ffdfd7070a4b559d724ba4ffa37c58b66bb4.json
Improve annotation methods in TypeDescriptor - Use generic typing for getAnnotation() - Add hasAnnoation() method - Update existing code and tests to make use of changes Issue: SPR-9744
spring-context/src/main/java/org/springframework/format/support/FormattingConversionService.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2011 the original author or authors. + * Copyright 2002-2012 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -211,7 +211,7 @@ public Set<ConvertiblePair>...
true
Other
spring-projects
spring-framework
e543ffdfd7070a4b559d724ba4ffa37c58b66bb4.json
Improve annotation methods in TypeDescriptor - Use generic typing for getAnnotation() - Add hasAnnoation() method - Update existing code and tests to make use of changes Issue: SPR-9744
spring-core/src/main/java/org/springframework/core/convert/TypeDescriptor.java
@@ -271,15 +271,25 @@ public Annotation[] getAnnotations() { return this.annotations; } + /** + * Determine if this type descriptor has the specified annotation. + * @param annotationType the annotation type + * @return <tt>true</tt> if the annotation is present + */ + public boolean hasAnnotation(Class<? ex...
true
Other
spring-projects
spring-framework
e543ffdfd7070a4b559d724ba4ffa37c58b66bb4.json
Improve annotation methods in TypeDescriptor - Use generic typing for getAnnotation() - Add hasAnnoation() method - Update existing code and tests to make use of changes Issue: SPR-9744
spring-core/src/test/java/org/springframework/core/convert/TypeDescriptorTests.java
@@ -1,5 +1,5 @@ /* - * Copyright 2002-2011 the original author or authors. + * Copyright 2002-2012 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -191,15 +191,17 @@ public void parameterAnno...
true
Other
spring-projects
spring-framework
2748f2b8eba22264408f2a05725810b58e80649d.json
Remove deprecated methods in spring-test-mvc
spring-test-mvc/src/main/java/org/springframework/test/web/mock/client/match/MockRestRequestMatchers.java
@@ -214,50 +214,4 @@ public static XpathRequestMatchers xpath(String expression, Map<String, String> return new XpathRequestMatchers(expression, namespaces, args); } - - // Deprecated methods .. - - /** - * Expect that the specified request header contains a subtring - * - * @deprecated in favor of {@link #he...
true
Other
spring-projects
spring-framework
2748f2b8eba22264408f2a05725810b58e80649d.json
Remove deprecated methods in spring-test-mvc
spring-test-mvc/src/main/java/org/springframework/test/web/mock/client/response/MockRestResponseCreators.java
@@ -119,71 +119,4 @@ public static DefaultResponseCreator withStatus(HttpStatus status) { return new DefaultResponseCreator(status); } - /** - * Respond with a given body, headers, status code, and status text. - * - * @param body the body of the response "UTF-8" encoded - * @param headers the response heade...
true
Other
spring-projects
spring-framework
7718936158434e0f658233f74c33ab72bea5d440.json
Recognize wildcards in media types with a suffix The "includes" and "isCompatibleWith" methods of MediaType take into account media types with suffices (e.g. application/soap+xml) including wildcards with suffices (e.g. application/*+xml). However before this change, the isWildcardSubtype() method returned true only f...
spring-web/src/main/java/org/springframework/http/MediaType.java
@@ -413,11 +413,12 @@ public String getSubtype() { } /** - * Indicates whether the {@linkplain #getSubtype() subtype} is the wildcard character <code>&#42;</code> or not. + * Indicates whether the {@linkplain #getSubtype() subtype} is the wildcard character <code>&#42;</code> + * or the wildcard character foll...
true
Other
spring-projects
spring-framework
7718936158434e0f658233f74c33ab72bea5d440.json
Recognize wildcards in media types with a suffix The "includes" and "isCompatibleWith" methods of MediaType take into account media types with suffices (e.g. application/soap+xml) including wildcards with suffices (e.g. application/*+xml). However before this change, the isWildcardSubtype() method returned true only f...
spring-web/src/test/java/org/springframework/http/MediaTypeTests.java
@@ -313,6 +313,7 @@ public void specificityComparator() throws Exception { MediaType audio07 = new MediaType("audio", "*", 0.7); MediaType audioBasicLevel = new MediaType("audio", "basic", Collections.singletonMap("level", "1")); MediaType textHtml = new MediaType("text", "html"); + MediaType allXml = new Med...
true
Other
spring-projects
spring-framework
7718936158434e0f658233f74c33ab72bea5d440.json
Recognize wildcards in media types with a suffix The "includes" and "isCompatibleWith" methods of MediaType take into account media types with suffices (e.g. application/soap+xml) including wildcards with suffices (e.g. application/*+xml). However before this change, the isWildcardSubtype() method returned true only f...
spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/RequestResponseBodyMethodProcessorMockTests.java
@@ -279,6 +279,28 @@ public void handleReturnValueNotAcceptableProduces() throws Exception { processor.handleReturnValue("Foo", returnTypeStringProduces, mavContainer, webRequest); } + // SPR-9841 + + @Test + public void handleReturnValueMediaTypeSuffix() throws Exception { + String body = "Foo"; + MediaType a...
true
Other
spring-projects
spring-framework
e16f3b95cb012cdbcf2a1310a86fe881ad8c0fb1.json
Fix typo in Javadoc
spring-web/src/main/java/org/springframework/http/converter/AbstractHttpMessageConverter.java
@@ -214,7 +214,7 @@ protected Long getContentLength(T t, MediaType contentType) throws IOException { protected abstract boolean supports(Class<?> clazz); /** - * Abstract template method that reads the actualy object. Invoked from {@link #read}. + * Abstract template method that reads the actual object. Invoked...
false
Other
spring-projects
spring-framework
a3e4f6cad4d1b625a6364fcf3564bb89c41f340e.json
Use EasyMock 2.5.2 consistently across the build This commit ensures that EasyMock version 2.5.2 is used consistently across the test suite. This applies to both the easymock and easymockclassextension artifacts. Using the same version for both of these artifacts helps to better align us for a future upgrade to EasyMo...
build.gradle
@@ -11,6 +11,7 @@ buildscript { configure(allprojects) { ext.aspectjVersion = '1.6.12' + ext.easymockVersion='2.5.2' ext.hsqldbVersion='1.8.0.10' ext.junitVersion = '4.11.20120805.1225' // temporary use of snapshot; spring-test // still builds against 4....
false
Other
spring-projects
spring-framework
d0503ab733bb9d4987e51cb76a8b2ec58c5f8468.json
Relocate web artifacts in the TCF to web package This commit relocates recently introduced web artifacts in the TestContext framework to the ~.test.context.web package and renames some classes for consistency with the existing code base. - introduced package-info.java in the web package. - ServletTestExecutionList...
spring-test/src/main/java/org/springframework/test/context/ContextLoaderUtils.java
@@ -57,7 +57,7 @@ abstract class ContextLoaderUtils { private static final Log logger = LogFactory.getLog(ContextLoaderUtils.class); private static final String DEFAULT_CONTEXT_LOADER_CLASS_NAME = "org.springframework.test.context.support.DelegatingSmartContextLoader"; - private static final String DEFAULT_WEB_CO...
true
Other
spring-projects
spring-framework
d0503ab733bb9d4987e51cb76a8b2ec58c5f8468.json
Relocate web artifacts in the TCF to web package This commit relocates recently introduced web artifacts in the TestContext framework to the ~.test.context.web package and renames some classes for consistency with the existing code base. - introduced package-info.java in the web package. - ServletTestExecutionList...
spring-test/src/main/java/org/springframework/test/context/support/AbstractDelegatingSmartContextLoader.java
@@ -63,7 +63,7 @@ * @since 3.2 * @see SmartContextLoader */ -abstract class AbstractDelegatingSmartContextLoader implements SmartContextLoader { +public abstract class AbstractDelegatingSmartContextLoader implements SmartContextLoader { private static final Log logger = LogFactory.getLog(AbstractDelegatingSma...
true
Other
spring-projects
spring-framework
d0503ab733bb9d4987e51cb76a8b2ec58c5f8468.json
Relocate web artifacts in the TCF to web package This commit relocates recently introduced web artifacts in the TestContext framework to the ~.test.context.web package and renames some classes for consistency with the existing code base. - introduced package-info.java in the web package. - ServletTestExecutionList...
spring-test/src/main/java/org/springframework/test/context/support/AnnotationConfigContextLoaderUtils.java
@@ -31,7 +31,7 @@ * @author Sam Brannen * @since 3.2 */ -abstract class AnnotationConfigContextLoaderUtils { +public abstract class AnnotationConfigContextLoaderUtils { private static final Log logger = LogFactory.getLog(AnnotationConfigContextLoaderUtils.class); @@ -86,7 +86,7 @@ private static boolean isD...
true
Other
spring-projects
spring-framework
d0503ab733bb9d4987e51cb76a8b2ec58c5f8468.json
Relocate web artifacts in the TCF to web package This commit relocates recently introduced web artifacts in the TestContext framework to the ~.test.context.web package and renames some classes for consistency with the existing code base. - introduced package-info.java in the web package. - ServletTestExecutionList...
spring-test/src/main/java/org/springframework/test/context/web/AbstractGenericWebContextLoader.java
@@ -14,7 +14,7 @@ * limitations under the License. */ -package org.springframework.test.context.support; +package org.springframework.test.context.web; import javax.servlet.ServletContext; @@ -29,7 +29,7 @@ import org.springframework.core.io.ResourceLoader; import org.springframework.mock.web.MockServletCo...
true
Other
spring-projects
spring-framework
d0503ab733bb9d4987e51cb76a8b2ec58c5f8468.json
Relocate web artifacts in the TCF to web package This commit relocates recently introduced web artifacts in the TestContext framework to the ~.test.context.web package and renames some classes for consistency with the existing code base. - introduced package-info.java in the web package. - ServletTestExecutionList...
spring-test/src/main/java/org/springframework/test/context/web/AnnotationConfigWebContextLoader.java
@@ -14,13 +14,14 @@ * limitations under the License. */ -package org.springframework.test.context.support; +package org.springframework.test.context.web; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.springframework.context.annotation.AnnotatedBeanDefinitionR...
true
Other
spring-projects
spring-framework
d0503ab733bb9d4987e51cb76a8b2ec58c5f8468.json
Relocate web artifacts in the TCF to web package This commit relocates recently introduced web artifacts in the TestContext framework to the ~.test.context.web package and renames some classes for consistency with the existing code base. - introduced package-info.java in the web package. - ServletTestExecutionList...
spring-test/src/main/java/org/springframework/test/context/web/GenericXmlWebContextLoader.java
@@ -14,36 +14,35 @@ * limitations under the License. */ -package org.springframework.test.context.support; +package org.springframework.test.context.web; import org.springframework.beans.factory.xml.XmlBeanDefinitionReader; -import org.springframework.test.context.web.WebMergedContextConfiguration; import org...
true
Other
spring-projects
spring-framework
d0503ab733bb9d4987e51cb76a8b2ec58c5f8468.json
Relocate web artifacts in the TCF to web package This commit relocates recently introduced web artifacts in the TestContext framework to the ~.test.context.web package and renames some classes for consistency with the existing code base. - introduced package-info.java in the web package. - ServletTestExecutionList...
spring-test/src/main/java/org/springframework/test/context/web/ServletTestExecutionListener.java
@@ -20,7 +20,6 @@ import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; - import org.springframework.beans.factory.config.ConfigurableListableBeanFactory; import org.springframework.context.ApplicationContext; import org.springframework.context.ConfigurableApplicationContext; @@ -2...
true
Other
spring-projects
spring-framework
d0503ab733bb9d4987e51cb76a8b2ec58c5f8468.json
Relocate web artifacts in the TCF to web package This commit relocates recently introduced web artifacts in the TestContext framework to the ~.test.context.web package and renames some classes for consistency with the existing code base. - introduced package-info.java in the web package. - ServletTestExecutionList...
spring-test/src/main/java/org/springframework/test/context/web/WebDelegatingSmartContextLoader.java
@@ -14,25 +14,26 @@ * limitations under the License. */ -package org.springframework.test.context.support; +package org.springframework.test.context.web; import org.springframework.test.context.SmartContextLoader; +import org.springframework.test.context.support.AbstractDelegatingSmartContextLoader; /** *...
true
Other
spring-projects
spring-framework
d0503ab733bb9d4987e51cb76a8b2ec58c5f8468.json
Relocate web artifacts in the TCF to web package This commit relocates recently introduced web artifacts in the TestContext framework to the ~.test.context.web package and renames some classes for consistency with the existing code base. - introduced package-info.java in the web package. - ServletTestExecutionList...
spring-test/src/main/java/org/springframework/test/context/web/package-info.java
@@ -0,0 +1,6 @@ +/** + * Web support classes for the <em>Spring TestContext Framework</em>. + */ + +package org.springframework.test.context.web; +
true
Other
spring-projects
spring-framework
e0e3143dd56b6a3693434eba8c036715d253bc8c.json
Fix Javadoc errors in TransactionalTEL This commit fixes recently introduced formatting errors in the Javadoc of TransactionalTestExecutionListener.
spring-test/src/main/java/org/springframework/test/context/transaction/TransactionalTestExecutionListener.java
@@ -64,15 +64,15 @@ * <em>rolled back</em> after completion of the test; whereas, changes to the * database during a test that is run with {@code @NotTransactional} will * <strong>not</strong> be run within a transaction. Test methods that are not - * annotated with either {@code @Transactional} (at the class or ...
false
Other
spring-projects
spring-framework
7ff964afa88da9a8b6eb8cf93b5f042f4aea9195.json
Add JSON converters to FormHttpMessageConverter The FormHttpMessageConverter now adds Jackson JSON converters (version 1.x or 2.x) if available on the classpath. Issue: SPR-10055
spring-web/src/main/java/org/springframework/http/converter/FormHttpMessageConverter.java
@@ -36,11 +36,15 @@ import org.springframework.http.HttpInputMessage; import org.springframework.http.HttpOutputMessage; import org.springframework.http.MediaType; +import org.springframework.http.converter.json.MappingJackson2HttpMessageConverter; +import org.springframework.http.converter.json.MappingJacksonHttpMe...
true
Other
spring-projects
spring-framework
7ff964afa88da9a8b6eb8cf93b5f042f4aea9195.json
Add JSON converters to FormHttpMessageConverter The FormHttpMessageConverter now adds Jackson JSON converters (version 1.x or 2.x) if available on the classpath. Issue: SPR-10055
src/dist/changelog.txt
@@ -102,7 +102,7 @@ Changes in version 3.2 RC1 (2012-11-04) * use concurrent cache to improve performance of GenericTypeResolver (SPR-8701) * cache and late resolve annotations on bean properties to improve performance (SPR-9166) * allow PropertyResolver implementations to ignore unresolvable ${placeholders} (SPR-95...
true
Other
spring-projects
spring-framework
42a928596fc3dcd2e1a5270d534da66bb9d1978f.json
Remove tiles-request-servlet-wildcard dependency The tiles-request-servlet-wildcard contained only one class that is an implementation of the tiles-request ServletApplicationContext using a Spring ApplicationContext to look up resources. It makes sense for this class to be part of the Spring Tiles 3 integration. Issu...
build.gradle
@@ -521,10 +521,6 @@ project('spring-webmvc-tiles3') { compile("javax.servlet:jstl:1.1.2", provided) compile("javax.servlet.jsp:jsp-api:2.1", provided) compile("org.apache.tiles:tiles-request-api:1.0.1", optional) - compile("org.apache.tiles:tiles-request-servlet-wildcard:1.0.1") { dep...
true
Other
spring-projects
spring-framework
42a928596fc3dcd2e1a5270d534da66bb9d1978f.json
Remove tiles-request-servlet-wildcard dependency The tiles-request-servlet-wildcard contained only one class that is an implementation of the tiles-request ServletApplicationContext using a Spring ApplicationContext to look up resources. It makes sense for this class to be part of the Spring Tiles 3 integration. Issu...
spring-webmvc-tiles3/src/main/java/org/springframework/web/servlet/view/tiles3/SpringWildcardServletTilesApplicationContext.java
@@ -0,0 +1,102 @@ +/* + * Copyright 2002-2012 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 +...
true
Other
spring-projects
spring-framework
42a928596fc3dcd2e1a5270d534da66bb9d1978f.json
Remove tiles-request-servlet-wildcard dependency The tiles-request-servlet-wildcard contained only one class that is an implementation of the tiles-request ServletApplicationContext using a Spring ApplicationContext to look up resources. It makes sense for this class to be part of the Spring Tiles 3 integration. Issu...
spring-webmvc-tiles3/src/main/java/org/springframework/web/servlet/view/tiles3/TilesConfigurer.java
@@ -51,7 +51,6 @@ import org.apache.tiles.preparer.factory.PreparerFactory; import org.apache.tiles.request.ApplicationContext; import org.apache.tiles.request.ApplicationResource; -import org.apache.tiles.request.servlet.wildcard.WildcardServletApplicationContext; import org.apache.tiles.startup.DefaultTilesInitia...
true
Other
spring-projects
spring-framework
d3c977b54b13c27bdf22747bbee8615d643c9559.json
Fix failing tests failing when debug logging is on Issue: SPR-10048
spring-web/src/test/java/org/springframework/web/client/RestTemplateTests.java
@@ -77,6 +77,7 @@ public void varArgsTemplateVariables() throws Exception { .andReturn(request); expect(request.execute()).andReturn(response); expect(errorHandler.hasError(response)).andReturn(false); + addLogResponseStatusExpectations(HttpStatus.OK); response.close(); replayMocks(); @@ -93,6 +94,7...
true
Other
spring-projects
spring-framework
d3c977b54b13c27bdf22747bbee8615d643c9559.json
Fix failing tests failing when debug logging is on Issue: SPR-10048
spring-web/src/test/java/org/springframework/web/context/request/async/WebAsyncManagerTests.java
@@ -31,6 +31,8 @@ import java.util.concurrent.Callable; +import javax.servlet.http.HttpServletRequest; + import org.easymock.EasyMock; import org.junit.Before; import org.junit.Test; @@ -49,10 +51,13 @@ public class WebAsyncManagerTests { private AsyncWebRequest asyncWebRequest; + private MockHttpServletR...
true
Other
spring-projects
spring-framework
1e62ad8665bb0f4138e140974108d693a20ee287.json
Add beforeConcurrentHandling support Previously CallableProcessingInterceptor and DeferredResultProcessingInterceptor did not have support for capturing the state of the original Thread just prior to processing. This made it difficult to transfer the state of one Thread (i.e. ThreadLocal) to the Thread used to process...
spring-web/src/main/java/org/springframework/web/context/request/async/CallableInterceptorChain.java
@@ -26,6 +26,7 @@ * Assists with the invocation of {@link CallableProcessingInterceptor}'s. * * @author Rossen Stoyanchev + * @author Rob Winch * @since 3.2 */ class CallableInterceptorChain { @@ -41,6 +42,12 @@ public CallableInterceptorChain(List<CallableProcessingInterceptor> interceptors this.intercep...
true
Other
spring-projects
spring-framework
1e62ad8665bb0f4138e140974108d693a20ee287.json
Add beforeConcurrentHandling support Previously CallableProcessingInterceptor and DeferredResultProcessingInterceptor did not have support for capturing the state of the original Thread just prior to processing. This made it difficult to transfer the state of one Thread (i.e. ThreadLocal) to the Thread used to process...
spring-web/src/main/java/org/springframework/web/context/request/async/CallableProcessingInterceptor.java
@@ -39,6 +39,7 @@ * can select a value to be used to resume processing. * * @author Rossen Stoyanchev + * @author Rob Winch * @since 3.2 */ public interface CallableProcessingInterceptor { @@ -47,6 +48,24 @@ public interface CallableProcessingInterceptor { static final Object RESPONSE_HANDLED = new Objec...
true
Other
spring-projects
spring-framework
1e62ad8665bb0f4138e140974108d693a20ee287.json
Add beforeConcurrentHandling support Previously CallableProcessingInterceptor and DeferredResultProcessingInterceptor did not have support for capturing the state of the original Thread just prior to processing. This made it difficult to transfer the state of one Thread (i.e. ThreadLocal) to the Thread used to process...
spring-web/src/main/java/org/springframework/web/context/request/async/CallableProcessingInterceptorAdapter.java
@@ -24,10 +24,17 @@ * for simplified implementation of individual methods. * * @author Rossen Stoyanchev + * @author Rob Winch * @since 3.2 */ public abstract class CallableProcessingInterceptorAdapter implements CallableProcessingInterceptor { + /** + * This implementation is empty. + */ + public <T> vo...
true
Other
spring-projects
spring-framework
1e62ad8665bb0f4138e140974108d693a20ee287.json
Add beforeConcurrentHandling support Previously CallableProcessingInterceptor and DeferredResultProcessingInterceptor did not have support for capturing the state of the original Thread just prior to processing. This made it difficult to transfer the state of one Thread (i.e. ThreadLocal) to the Thread used to process...
spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResultInterceptorChain.java
@@ -40,6 +40,12 @@ public DeferredResultInterceptorChain(List<DeferredResultProcessingInterceptor> this.interceptors = interceptors; } + public void applyBeforeConcurrentHandling(NativeWebRequest request, DeferredResult<?> deferredResult) throws Exception { + for (DeferredResultProcessingInterceptor interceptor...
true
Other
spring-projects
spring-framework
1e62ad8665bb0f4138e140974108d693a20ee287.json
Add beforeConcurrentHandling support Previously CallableProcessingInterceptor and DeferredResultProcessingInterceptor did not have support for capturing the state of the original Thread just prior to processing. This made it difficult to transfer the state of one Thread (i.e. ThreadLocal) to the Thread used to process...
spring-web/src/main/java/org/springframework/web/context/request/async/DeferredResultProcessingInterceptor.java
@@ -36,10 +36,22 @@ * method can set the {@code DeferredResult} in order to resume processing. * * @author Rossen Stoyanchev + * @author Rob Winch * @since 3.2 */ public interface DeferredResultProcessingInterceptor { + /** + * Invoked immediately before the start of concurrent handling, in the same + * ...
true