language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | chartjs | Chart.js | 1fef75d990ccdb557f19d9be5e67f217d8b5c90d.json | Skip all borders if borderSkipped === true (#10530)
* Skip all borders if borderSkipped === true
This will allow you to skip all borders (not just one side) if you set borderSkipped to boolean true and so allow you to have a consistent legend marker even for bars without borders. Reason is that even if same colored... | types/index.esm.d.ts | @@ -1984,10 +1984,10 @@ export interface BarOptions extends Omit<CommonElementOptions, 'borderWidth'> {
base: number;
/**
- * Skipped (excluded) border: 'start', 'end', 'left', 'right', 'bottom', 'top', 'middle' or false (none).
+ * Skipped (excluded) border: 'start', 'end', 'left', 'right', 'bottom', 'to... | true |
Other | chartjs | Chart.js | a31e1e59d6c33883b2932b422abaabf3a2340074.json | pass boxWidth only if pointStyleWidth presents (#10524) | src/plugins/plugin.legend.js | @@ -325,7 +325,7 @@ export class Legend extends Element {
const centerY = y + halfFontSize;
// Draw pointStyle as legend symbol
- drawPointLegend(ctx, drawOptions, centerX, centerY, boxWidth);
+ drawPointLegend(ctx, drawOptions, centerX, centerY, labelOpts.pointStyleWidth && boxWidth);... | false |
Other | chartjs | Chart.js | c6120f9e7143c66d5e7a1b4052ae3b0f1165d5da.json | Improve docs radial linear grid (#10518)
* make link work in github itself
* fix dead link on reload or new tab
* document the props for radial grid
* remove extra chart and space | docs/axes/radial/linear.md | @@ -18,7 +18,25 @@ Namespace: `options.scales[scaleId]`
| `pointLabels` | `object` | | Point label configuration. [more...](#point-label-options)
| `startAngle` | `number` | `0` | Starting angle of the scale. In degrees, 0 is at top.
-!!!include(axes/_common.md)!!!
+### Common options to all axes
+
+Namespace: `opt... | true |
Other | chartjs | Chart.js | c6120f9e7143c66d5e7a1b4052ae3b0f1165d5da.json | Improve docs radial linear grid (#10518)
* make link work in github itself
* fix dead link on reload or new tab
* document the props for radial grid
* remove extra chart and space | docs/axes/styling.md | @@ -12,7 +12,7 @@ Namespace: `options.scales[scaleId].grid`, it defines options for the grid lines
| `borderWidth` | `number` | | | `1` | The width of the border line.
| `borderDash` | `number[]` | Yes | | `[]` | Length and spacing of dashes on grid lines. See [MDN](https://developer.mozilla.org/en-US/docs/Web/API/Ca... | true |
Other | chartjs | Chart.js | a4114e84d9f1f66c3e7fa76d5d1790fa64392f9a.json | parsing: support dot(s) in object keys (#10517) | docs/general/data-structures.md | @@ -85,11 +85,27 @@ options: {
}
```
+If the key contains a dot, it needs to be escaped with a double slash:
+
+```javascript
+type: 'line',
+data: {
+ datasets: [{
+ data: [{ 'data.key': 'one', 'data.value': 20 }, { 'data.key': 'two', 'data.value': 30 }]
+ }]
+},
+options: {
+ parsing: {
+ xAx... | true |
Other | chartjs | Chart.js | a4114e84d9f1f66c3e7fa76d5d1790fa64392f9a.json | parsing: support dot(s) in object keys (#10517) | src/helpers/helpers.core.js | @@ -293,25 +293,52 @@ export function _deprecated(scope, value, previous, current) {
}
}
-const emptyString = '';
-const dot = '.';
-function indexOfDotOrLength(key, start) {
- const idx = key.indexOf(dot, start);
- return idx === -1 ? key.length : idx;
-}
+// resolveObjectKey resolver cache
+const keyResolvers... | true |
Other | chartjs | Chart.js | a4114e84d9f1f66c3e7fa76d5d1790fa64392f9a.json | parsing: support dot(s) in object keys (#10517) | test/specs/helpers.core.tests.js | @@ -456,6 +456,44 @@ describe('Chart.helpers.core', function() {
expect(() => helpers.resolveObjectKey({}, true)).toThrow();
expect(() => helpers.resolveObjectKey({}, 1)).toThrow();
});
+ it('should allow escaping dot symbol', function() {
+ expect(helpers.resolveObjectKey({'test.dot': 10}, '... | true |
Other | chartjs | Chart.js | de3596d4afbd3373d9fc0b6eeb7706e340ad2f1a.json | Fix dead link on reload or open in new tab (#10515)
* make link work in github itself
* fix dead link on reload or new tab | docs/axes/labelling.md | @@ -31,7 +31,7 @@ The call to the method is scoped to the scale. `this` inside the method is the s
If the callback returns `null` or `undefined` the associated grid line will be hidden.
:::tip
-The [category axis](../axes/cartesian/category), which is the default x-axis for line and bar charts, uses the `index` as ... | false |
Other | chartjs | Chart.js | 9ba44809745a77855485dc44af6e0c9574226446.json | Resolve plugin defaults for local plugins (#10484) | src/core/core.plugins.js | @@ -118,6 +118,7 @@ export default class PluginService {
* @param {import("./core.config").default} config
*/
function allPlugins(config) {
+ const localIds = {};
const plugins = [];
const keys = Object.keys(registry.plugins.items);
for (let i = 0; i < keys.length; i++) {
@@ -130,10 +131,11 @@ function a... | true |
Other | chartjs | Chart.js | 9ba44809745a77855485dc44af6e0c9574226446.json | Resolve plugin defaults for local plugins (#10484) | test/specs/core.plugin.tests.js | @@ -224,7 +224,7 @@ describe('Chart.plugins', function() {
Chart.unregister(plugins.a);
});
- it('should not called plugins when config.options.plugins.{id} is FALSE', function() {
+ it('should not call plugins when config.options.plugins.{id} is FALSE', function() {
var plugins = {
... | true |
Other | chartjs | Chart.js | 8ccff8cad70023f7e3d3dddc25e555cf098a6712.json | draw tooltip with object borderwidth (#10489) | src/plugins/plugin.tooltip.js | @@ -1,7 +1,7 @@
import Animations from '../core/core.animations';
import Element from '../core/core.element';
import {addRoundedRectPath} from '../helpers/helpers.canvas';
-import {each, noop, isNullOrUndef, isArray, _elementsEqual} from '../helpers/helpers.core';
+import {each, noop, isNullOrUndef, isArray, _elemen... | false |
Other | chartjs | Chart.js | eeba91e0de9e9e4df973cc51f98a5028beb04b04.json | make link work in github itself (#10497) | docs/getting-started/index.md | @@ -101,6 +101,6 @@ module.exports = {
As you can see, some of the boilerplate needed is not visible in our sample blocks, as the samples focus on the configuration options.
:::
-All our examples are [available online](/samples/).
+All our examples are [available online](../samples/).
To run the samples locally ... | false |
Other | chartjs | Chart.js | 1a1e68380f1298ccb25e6941b07e158855ac4992.json | Improve error message with id of the canvas (#10495)
* improve error message with id of the canvas
* update test | src/core/core.controller.js | @@ -111,7 +111,7 @@ class Chart {
if (existingChart) {
throw new Error(
'Canvas is already in use. Chart with ID \'' + existingChart.id + '\'' +
- ' must be destroyed before the canvas can be reused.'
+ ' must be destroyed before the canvas with ID \'' + existingChart.canvas.id + '\' can be r... | true |
Other | chartjs | Chart.js | 1a1e68380f1298ccb25e6941b07e158855ac4992.json | Improve error message with id of the canvas (#10495)
* improve error message with id of the canvas
* update test | test/specs/core.controller.tests.js | @@ -32,7 +32,7 @@ describe('Chart', function() {
expect(createChart).toThrow(new Error(
'Canvas is already in use. ' +
'Chart with ID \'' + chart.id + '\'' +
- ' must be destroyed before the canvas can be reused.'
+ ' must be destroyed before the canvas with ID \'' + chart.canvas.id + '\' can be reu... | true |
Other | chartjs | Chart.js | a7fede4f465277dd0cb6ce1675153f6e4a6472e2.json | Fix jshint error | src/scales/scale.category.js | @@ -16,7 +16,7 @@ module.exports = function(Chart) {
if (this.options.ticks.min !== undefined) {
// user specified min value
- findIndex = helpers.indexOf(this.chart.data.labels, this.options.ticks.min)
+ findIndex = helpers.indexOf(this.chart.data.labels, this.options.ticks.min);
this.startIndex ... | false |
Other | chartjs | Chart.js | 7875b0c68df08312efa76062fe5bf63dd20dc14a.json | Install latest chrome before running tests | .travis.yml | @@ -4,9 +4,13 @@ node_js:
- "4.3"
before_install:
- - "export CHROME_BIN=chromium-browser"
- "export DISPLAY=:99.0"
- "sh -e /etc/init.d/xvfb start"
+ - "sudo apt-get update"
+ - "sudo apt-get install -y libappindicator1 fonts-liberation"
+ - "wget https://dl.google.com/linux/direct/google-chrome-stable... | false |
Other | chartjs | Chart.js | 5c1f242785ffe05993b8dd04de9e16a1c938894f.json | Use latest firefox version | .travis.yml | @@ -19,4 +19,6 @@ script:
notifications:
slack: chartjs:pcfCZR6ugg5TEcaLtmIfQYuA
-sudo: false
\ No newline at end of file
+sudo: false
+addons:
+ firefox: latest
\ No newline at end of file | false |
Other | chartjs | Chart.js | ef923dfe289fc41326be58f3f6e4d991c8eb741f.json | Update package + built files to 1.1.0 version | Chart.js | @@ -1,7 +1,7 @@
/*!
* Chart.js
* http://chartjs.org/
- * Version: 1.0.2
+ * Version: 1.1.0
*
* Copyright 2015 Nick Downie
* Released under the MIT license | true |
Other | chartjs | Chart.js | ef923dfe289fc41326be58f3f6e4d991c8eb741f.json | Update package + built files to 1.1.0 version | Chart.min.js | @@ -1,7 +1,7 @@
/*!
* Chart.js
* http://chartjs.org/
- * Version: 1.0.2
+ * Version: 1.1.0
*
* Copyright 2015 Nick Downie
* Released under the MIT license | true |
Other | chartjs | Chart.js | ef923dfe289fc41326be58f3f6e4d991c8eb741f.json | Update package + built files to 1.1.0 version | bower.json | @@ -16,5 +16,6 @@
"gulpfile.js",
"package.json"
],
- "dependencies": {}
+ "dependencies": {},
+ "version": "1.1.0"
} | true |
Other | chartjs | Chart.js | ef923dfe289fc41326be58f3f6e4d991c8eb741f.json | Update package + built files to 1.1.0 version | package.json | @@ -2,13 +2,13 @@
"name": "chart.js",
"homepage": "http://www.chartjs.org",
"description": "Simple HTML5 charts using the canvas element.",
- "version": "1.0.2",
+ "version": "1.1.0",
"main": "Chart.js",
"repository": {
"type": "git",
"url": "https://github.com/nnnick/Chart.js.git"
},
- "... | true |
Other | chartjs | Chart.js | 60a429f5cb2a1985ab1e43c5c3155a0bd6ebe963.json | Update doc version | docs/00-Getting-Started.md | @@ -16,7 +16,7 @@ npm install chart.js --save
bower install Chart.js --save
```
-CDN: https://cdnjs.cloudflare.com/ajax/libs/Chart.js/2.0.0-beta/Chart.js
+CDN: https://cdnjs.cloudflare.com/ajax/libs/Chart.js/2.0.0/Chart.js
###Install Chart.js
| false |
Other | chartjs | Chart.js | bf724abe8b314c45bc706617a36f40521f3c0a83.json | Fix axis IDs in documentation | docs/02-Line-Chart.md | @@ -86,8 +86,8 @@ var data = {
// The actual data
data: [65, 59, 80, 81, 56, 55, 40],
- // String - If specified, binds the dataset to a certain y-axis. If not specified, the first y-axis is used.
- yAxisID: "y-axis-1",
+ // String - If specified, binds the dataset to a certain y-axis. If not specified,... | true |
Other | chartjs | Chart.js | bf724abe8b314c45bc706617a36f40521f3c0a83.json | Fix axis IDs in documentation | docs/03-Bar-Chart.md | @@ -50,7 +50,7 @@ var data = {
data: [65, 59, 80, 81, 56, 55, 40],
// String - If specified, binds the dataset to a certain y-axis. If not specified, the first y-axis is used.
- yAxisID: "y-axis-1",
+ yAxisID: "y-axis-0",
},
{
label: "My Second dataset", | true |
Other | chartjs | Chart.js | d7117bc79235f23832cec04568cad8a808f82737.json | Add title of license to license file. Fixes #2097 | LICENSE.md | @@ -1,3 +1,4 @@
+The MIT License (MIT)
Copyright (c) 2013-2016 Nick Downie
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, c... | false |
Other | chartjs | Chart.js | 668b532fbee9dca9b75a5981aab949e7513a9388.json | Add angleLineInterval option to radar chart | docs/03-Radar-Chart.md | @@ -76,6 +76,9 @@ These are the customisation options specific to Radar charts. These options are
//Number - Pixel width of the angle line
angleLineWidth : 1,
+ //Number - Interval at which to draw angle lines ("every Nth point")
+ angleLineInterval: 1,
+
//String - Point label font declaration
pointLab... | true |
Other | chartjs | Chart.js | 668b532fbee9dca9b75a5981aab949e7513a9388.json | Add angleLineInterval option to radar chart | src/Chart.Core.js | @@ -2058,7 +2058,7 @@
for (var i = this.valuesCount - 1; i >= 0; i--) {
var centerOffset = null, outerPosition = null;
- if (this.angleLineWidth > 0){
+ if (this.angleLineWidth > 0 && (i % this.angleLineInterval === 0)){
centerOffset = this.calculateCenterOffset(this.max);
outer... | true |
Other | chartjs | Chart.js | 668b532fbee9dca9b75a5981aab949e7513a9388.json | Add angleLineInterval option to radar chart | src/Chart.Radar.js | @@ -28,6 +28,9 @@
//Number - Pixel width of the angle line
angleLineWidth : 1,
+ //Number - Interval at which to draw angle lines ("every Nth point")
+ angleLineInterval: 1,
+
//String - Point label font declaration
pointLabelFontFamily : "'Arial'",
@@ -181,6 +184,7 @@
lineColor: this.optio... | true |
Other | chartjs | Chart.js | 5d2444a5ee1a4caf3d7b3721eab759763ec1cf12.json | Expose yAlign and xAlign as a tooltip option | src/core/core.tooltip.js | @@ -24,6 +24,8 @@ module.exports = function(Chart) {
footerAlign: "left",
yPadding: 6,
xPadding: 6,
+ yAlign : 'center',
+ xAlign : 'center',
caretSize: 5,
cornerRadius: 6,
multiKeyBackground: '#fff',
@@ -116,6 +118,8 @@ module.exports = function(Chart) {
footerMarginTop: options.tooltips.foot... | false |
Other | chartjs | Chart.js | c3f765857edf974f1136e2162e00d931bc2400bc.json | Fix some time rounding problems | docs/01-Scales.md | @@ -171,8 +171,13 @@ The time scale extends the core scale class with the following tick template:
parser: false,
// string - By default, unit will automatically be detected. Override with 'week', 'month', 'year', etc. (see supported time measurements)
unit: false,
+
+ // Number - The number of steps of the ... | true |
Other | chartjs | Chart.js | c3f765857edf974f1136e2162e00d931bc2400bc.json | Fix some time rounding problems | src/core/core.scale.js | @@ -476,10 +476,6 @@ module.exports = function(Chart) {
skipRatio = 1 + Math.floor((((longestRotatedLabel / 2) + this.options.ticks.autoSkipPadding) * this.ticks.length) / (this.width - (this.paddingLeft + this.paddingRight)));
}
- if (!useAutoskipper) {
- skipRatio = false;
- }
-
// i... | true |
Other | chartjs | Chart.js | c3f765857edf974f1136e2162e00d931bc2400bc.json | Fix some time rounding problems | src/scales/scale.time.js | @@ -138,22 +138,30 @@ module.exports = function(Chart) {
this.ticks = [];
this.unitScale = 1; // How much we scale the unit by, ie 2 means 2x unit per step
+ this.scaleSizeInUnits = 0; // How large the scale is in the base unit (seconds, minutes, etc)
// Set unit override if applicable
if (this.op... | true |
Other | chartjs | Chart.js | c3f765857edf974f1136e2162e00d931bc2400bc.json | Fix some time rounding problems | test/scale.time.tests.js | @@ -202,7 +202,7 @@ describe('Time scale tests', function() {
scale.update(400, 50);
// Counts down because the lines are drawn top to bottom
- expect(scale.ticks).toEqual(['Nov 20, 1981', 'Nov 20, 1981']);
+ expect(scale.ticks).toEqual(['Nov 19, 1981', 'Nov 19, 1981']);
});
it('should build ticks using... | true |
Other | chartjs | Chart.js | 71ede8d52c4663520d9b8bbb43ce0852b2fe54ad.json | Docs: Apply a recommendation (fixes #3046) | docs/03-Line-Chart.md | @@ -26,7 +26,7 @@ var myLineChart = Chart.Line(ctx, {
});
```
-### Data Structure
+### Dataset Structure
The following options can be included in a line chart dataset to configure options for that specific dataset.
| true |
Other | chartjs | Chart.js | 71ede8d52c4663520d9b8bbb43ce0852b2fe54ad.json | Docs: Apply a recommendation (fixes #3046) | docs/04-Bar-Chart.md | @@ -31,7 +31,7 @@ var myBarChart = new Chart(ctx, {
});
```
-### Data Structure
+### Dataset Structure
The following options can be included in a bar chart dataset to configure options for that specific dataset.
Some properties can be specified as an array. If these are set to an array value, the first value ap... | true |
Other | chartjs | Chart.js | 71ede8d52c4663520d9b8bbb43ce0852b2fe54ad.json | Docs: Apply a recommendation (fixes #3046) | docs/05-Radar-Chart.md | @@ -22,7 +22,7 @@ var myRadarChart = new Chart(ctx, {
});
```
-### Data Structure
+### Dataset Structure
The following options can be included in a radar chart dataset to configure options for that specific dataset.
| true |
Other | chartjs | Chart.js | 71ede8d52c4663520d9b8bbb43ce0852b2fe54ad.json | Docs: Apply a recommendation (fixes #3046) | docs/06-Polar-Area-Chart.md | @@ -21,7 +21,7 @@ new Chart(ctx, {
});
```
-### Data Structure
+### Dataset Structure
The following options can be included in a polar area chart dataset to configure options for that specific dataset.
| true |
Other | chartjs | Chart.js | 71ede8d52c4663520d9b8bbb43ce0852b2fe54ad.json | Docs: Apply a recommendation (fixes #3046) | docs/07-Pie-Doughnut-Chart.md | @@ -40,7 +40,7 @@ var myDoughnutChart = new Chart(ctx, {
});
```
-### Data Structure
+### Dataset Structure
Property | Type | Usage
--- | --- | --- | true |
Other | chartjs | Chart.js | 71ede8d52c4663520d9b8bbb43ce0852b2fe54ad.json | Docs: Apply a recommendation (fixes #3046) | docs/08-Bubble-Chart.md | @@ -21,7 +21,7 @@ var myBubbleChart = new Chart(ctx,{
});
```
-### Data Structure
+### Dataset Structure
Property | Type | Usage
--- | --- | --- | true |
Other | chartjs | Chart.js | 08451ce95e16224e1afba6e890e33b430d662779.json | Correct duplicate error | docs/02-Scales.md | @@ -346,7 +346,7 @@ min | Number | - | User defined minimum number for the scale, overrides minimum
max | Number | - | User defined maximum number for the scale, overrides maximum value from data.
maxTicksLimit | Number | 11 | Maximum number of ticks and gridlines to show. If not defined, it will limit to 11 ticks bu... | false |
Other | chartjs | Chart.js | f46a9472b54fdafacda6f780a197b0fce5ee46d8.json | getElementAtEvent: enforce one element limit | src/core/core.controller.js | @@ -384,7 +384,7 @@ module.exports = function(Chart) {
}
});
- return elementsArray;
+ return elementsArray.slice(0, 1);
},
getElementsAtEvent: function(e) { | false |
Other | chartjs | Chart.js | 47b5ad60ae798787bad97f2d478dab396536b752.json | Fix JSHint warnings | src/elements/element.line.js | @@ -57,15 +57,16 @@ module.exports = function(Chart) {
points.push(points[0]);
}
+ var index, current, previous, currentVM;
+
// Fill Line
if (points.length && vm.fill) {
ctx.beginPath();
- for (var index = 0; index < points.length; ++index) {
- var current = points[index];
- var ... | false |
Other | chartjs | Chart.js | 7c66b2f28cf871e1850ea9930759acada679fec7.json | Combine performance docs (#6632) | docs/SUMMARY.md | @@ -16,6 +16,7 @@
* [Options](general/options.md)
* [Colors](general/colors.md)
* [Fonts](general/fonts.md)
+ * [Performance](general/performance.md)
* [Configuration](configuration/README.md)
* [Animations](configuration/animations.md)
* [Layout](configuration/layout.md) | true |
Other | chartjs | Chart.js | 7c66b2f28cf871e1850ea9930759acada679fec7.json | Combine performance docs (#6632) | docs/charts/line.md | @@ -216,75 +216,3 @@ var stackedLine = new Chart(ctx, {
}
});
```
-
-## High Performance Line Charts
-
-When charting a lot of data, the chart render time may start to get quite large. In that case, the following strategies can be used to improve performance.
-
-### Data Decimation
-
-Decimating your data will a... | true |
Other | chartjs | Chart.js | 7c66b2f28cf871e1850ea9930759acada679fec7.json | Combine performance docs (#6632) | docs/general/performance.md | @@ -1,9 +1,84 @@
# Performance
-Chart.js charts are rendered on `canvas` elements, which makes rendering quite fast. For large datasets or performance sensitive applications, you may wish to consider the tips below:
+Chart.js charts are rendered on `canvas` elements, which makes rendering quite fast. For large datas... | true |
Other | chartjs | Chart.js | 0228776e6649c18000876e43e4d44a2317a693a5.json | Remove deprecated interaction modes (#6625)
* Remove deprecated interaction modes
* Use default modes | docs/general/interactions/modes.md | @@ -34,12 +34,6 @@ var chart = new Chart(ctx, {
});
```
-## single (deprecated)
-Finds the first item that intersects the point and returns it. Behaves like `'nearest'` mode with `intersect = true`.
-
-## label (deprecated)
-See `'index'` mode.
-
## index
Finds item at the same index. If the `intersect` setting i... | true |
Other | chartjs | Chart.js | 0228776e6649c18000876e43e4d44a2317a693a5.json | Remove deprecated interaction modes (#6625)
* Remove deprecated interaction modes
* Use default modes | src/controllers/controller.bar.js | @@ -9,7 +9,7 @@ var valueOrDefault = helpers.valueOrDefault;
defaults._set('bar', {
hover: {
- mode: 'label'
+ mode: 'index'
},
scales: { | true |
Other | chartjs | Chart.js | 0228776e6649c18000876e43e4d44a2317a693a5.json | Remove deprecated interaction modes (#6625)
* Remove deprecated interaction modes
* Use default modes | src/controllers/controller.bubble.js | @@ -9,10 +9,6 @@ var valueOrDefault = helpers.valueOrDefault;
var resolve = helpers.options.resolve;
defaults._set('bubble', {
- hover: {
- mode: 'single'
- },
-
scales: {
xAxes: [{
type: 'linear', // bubble should probably use a linear scale by default | true |
Other | chartjs | Chart.js | 0228776e6649c18000876e43e4d44a2317a693a5.json | Remove deprecated interaction modes (#6625)
* Remove deprecated interaction modes
* Use default modes | src/controllers/controller.doughnut.js | @@ -18,9 +18,6 @@ defaults._set('doughnut', {
// Boolean - Whether we animate scaling the Doughnut from the centre
animateScale: false
},
- hover: {
- mode: 'single'
- },
legendCallback: function(chart) {
var list = document.createElement('ul');
var data = chart.data; | true |
Other | chartjs | Chart.js | 0228776e6649c18000876e43e4d44a2317a693a5.json | Remove deprecated interaction modes (#6625)
* Remove deprecated interaction modes
* Use default modes | src/controllers/controller.line.js | @@ -14,7 +14,7 @@ defaults._set('line', {
spanGaps: false,
hover: {
- mode: 'label'
+ mode: 'index'
},
scales: { | true |
Other | chartjs | Chart.js | 0228776e6649c18000876e43e4d44a2317a693a5.json | Remove deprecated interaction modes (#6625)
* Remove deprecated interaction modes
* Use default modes | src/controllers/controller.scatter.js | @@ -4,10 +4,6 @@ var LineController = require('./controller.line');
var defaults = require('../core/core.defaults');
defaults._set('scatter', {
- hover: {
- mode: 'single'
- },
-
scales: {
xAxes: [{
id: 'x-axis-1', // need an ID so datasets can reference the scale | true |
Other | chartjs | Chart.js | 0228776e6649c18000876e43e4d44a2317a693a5.json | Remove deprecated interaction modes (#6625)
* Remove deprecated interaction modes
* Use default modes | src/core/core.controller.js | @@ -800,15 +800,15 @@ helpers.extend(Chart.prototype, /** @lends Chart */ {
* @return An object containing the dataset index and element index of the matching element. Also contains the rectangle that was draw
*/
getElementAtEvent: function(e) {
- return Interaction.modes.single(this, e);
+ return Interaction... | true |
Other | chartjs | Chart.js | 0228776e6649c18000876e43e4d44a2317a693a5.json | Remove deprecated interaction modes (#6625)
* Remove deprecated interaction modes
* Use default modes | src/core/core.interaction.js | @@ -144,28 +144,6 @@ function indexMode(chart, e, options) {
module.exports = {
// Helper function for different modes
modes: {
- single: function(chart, e) {
- var position = getRelativePosition(e, chart);
- var elements = [];
-
- parseVisibleItems(chart, function(element) {
- if (element.inRange(positi... | true |
Other | chartjs | Chart.js | 0228776e6649c18000876e43e4d44a2317a693a5.json | Remove deprecated interaction modes (#6625)
* Remove deprecated interaction modes
* Use default modes | test/specs/controller.line.tests.js | @@ -244,7 +244,8 @@ describe('Chart.controllers.line', function() {
legend: false,
title: false,
hover: {
- mode: 'single'
+ mode: 'nearest',
+ intersect: true
},
scales: {
xAxes: [{ | true |
Other | chartjs | Chart.js | 0228776e6649c18000876e43e4d44a2317a693a5.json | Remove deprecated interaction modes (#6625)
* Remove deprecated interaction modes
* Use default modes | test/specs/core.controller.tests.js | @@ -87,7 +87,7 @@ describe('Chart', function() {
defaults.global.responsiveAnimationDuration = 0;
defaults.global.hover.onHover = null;
defaults.line.spanGaps = false;
- defaults.line.hover.mode = 'label';
+ defaults.line.hover.mode = 'index';
});
it('should override default options', function()... | true |
Other | chartjs | Chart.js | 0228776e6649c18000876e43e4d44a2317a693a5.json | Remove deprecated interaction modes (#6625)
* Remove deprecated interaction modes
* Use default modes | test/specs/core.tooltip.tests.js | @@ -257,7 +257,8 @@ describe('Core.Tooltip', function() {
},
options: {
tooltips: {
- mode: 'single'
+ mode: 'nearest',
+ intersect: true
}
}
});
@@ -366,7 +367,7 @@ describe('Core.Tooltip', function() {
},
options: {
tooltips: {
- mode: 'label',
+ mode: 'index'... | true |
Other | chartjs | Chart.js | 39d83eeae0e1713af7152aa8af40b1cfa50f800e.json | Fix scatter sample (#6627) | samples/scales/logarithmic/scatter.html | @@ -137,7 +137,7 @@
position: 'bottom',
ticks: {
userCallback: function(tick) {
- var remain = tick / (Math.pow(10, Math.floor(Chart.helpers.log10(tick))));
+ var remain = tick / (Math.pow(10, Math.floor(Chart.helpers.math.log10(tick))));
if (remain === 1 || remain === 2 || ... | false |
Other | chartjs | Chart.js | d932f9c56e388f100e4fbc02dd968587f5583921.json | Remove deprecated code from index.js (#6623)
Remove deprecated code from index.js | src/index.js | @@ -48,103 +48,3 @@ module.exports = Chart;
if (typeof window !== 'undefined') {
window.Chart = Chart;
}
-
-// DEPRECATIONS
-
-/**
- * Provided for backward compatibility, not available anymore
- * @namespace Chart.Chart
- * @deprecated since version 2.8.0
- * @todo remove at version 3
- * @private
- */
-Chart.Char... | true |
Other | chartjs | Chart.js | d932f9c56e388f100e4fbc02dd968587f5583921.json | Remove deprecated code from index.js (#6623)
Remove deprecated code from index.js | test/.eslintrc.yml | @@ -1,5 +1,5 @@
parserOptions:
- ecmaVersion: 5 # don't rely on default, since its changed by env: es6
+ ecmaVersion: 6
env:
es6: true # also changes default ecmaVersion to 6 | true |
Other | chartjs | Chart.js | d932f9c56e388f100e4fbc02dd968587f5583921.json | Remove deprecated code from index.js (#6623)
Remove deprecated code from index.js | test/specs/plugin.title.tests.js | @@ -1,5 +1,7 @@
// Test the rectangle element
+var Title = Chart.plugins.getAll().find(p => p.id === 'title')._element;
+
describe('Title block tests', function() {
it('Should have the correct default config', function() {
expect(Chart.defaults.global.title).toEqual({
@@ -19,7 +21,7 @@ describe('Title block te... | true |
Other | chartjs | Chart.js | 5b0a0b039ce30f40a5a4a6162667f9eaf4c62f0f.json | Time scale: return time from getValueForPixel (#6616) | src/adapters/adapter.moment.js | @@ -56,17 +56,5 @@ adapters._date.override(typeof moment === 'function' ? {
endOf: function(time, unit) {
return moment(time).endOf(unit).valueOf();
- },
-
- // DEPRECATIONS
-
- /**
- * Provided for backward compatibility with scale.getValueForPixel().
- * @deprecated since version 2.8.0
- * @todo remove at v... | true |
Other | chartjs | Chart.js | 5b0a0b039ce30f40a5a4a6162667f9eaf4c62f0f.json | Time scale: return time from getValueForPixel (#6616) | src/core/core.adapters.js | @@ -98,20 +98,7 @@ helpers.extend(DateAdapter.prototype, /** @lends DateAdapter */ {
* @param {Unit} unit - the unit as string
* @function
*/
- endOf: abstract,
-
- // DEPRECATIONS
-
- /**
- * Provided for backward compatibility for scale.getValueForPixel(),
- * this method should be overridden only by the m... | true |
Other | chartjs | Chart.js | 5b0a0b039ce30f40a5a4a6162667f9eaf4c62f0f.json | Time scale: return time from getValueForPixel (#6616) | src/scales/scale.time.js | @@ -706,10 +706,7 @@ module.exports = Scale.extend({
var me = this;
var offsets = me._offsets;
var pos = me.getDecimalForPixel(pixel) / offsets.factor - offsets.end;
- var time = interpolate(me._table, 'pos', pos, 'time');
-
- // DEPRECATION, we should return time directly
- return me._adapter._create(time)... | true |
Other | chartjs | Chart.js | 5b0a0b039ce30f40a5a4a6162667f9eaf4c62f0f.json | Time scale: return time from getValueForPixel (#6616) | test/specs/scale.time.tests.js | @@ -28,9 +28,9 @@ describe('Time scale tests', function() {
jasmine.addMatchers({
toBeCloseToTime: function() {
return {
- compare: function(actual, expected) {
+ compare: function(time, expected) {
var result = false;
-
+ var actual = moment(time);
var diff = actual.diff(expected... | true |
Other | chartjs | Chart.js | 92a4654d9b2ae91683c179cbf6186b31952cfcd1.json | Remove deprecated helpers (#6607) | src/core/core.helpers.js | @@ -148,16 +148,6 @@ module.exports = function() {
return Math.sqrt(Math.pow(pt2.x - pt1.x, 2) + Math.pow(pt2.y - pt1.y, 2));
};
- /**
- * Provided for backward compatibility, not available anymore
- * @function Chart.helpers.aliasPixel
- * @deprecated since version 2.8.0
- * @todo remove at version 3
- */
... | true |
Other | chartjs | Chart.js | 92a4654d9b2ae91683c179cbf6186b31952cfcd1.json | Remove deprecated helpers (#6607) | src/core/core.ticks.js | @@ -1,6 +1,7 @@
'use strict';
var helpers = require('../helpers/index');
+var math = helpers.math;
/**
* Namespace to hold static tick generation functions
@@ -42,13 +43,13 @@ module.exports = {
}
}
- var logDelta = helpers.log10(Math.abs(delta));
+ var logDelta = math.log10(Math.abs(delta));
... | true |
Other | chartjs | Chart.js | 92a4654d9b2ae91683c179cbf6186b31952cfcd1.json | Remove deprecated helpers (#6607) | src/helpers/helpers.canvas.js | @@ -1,7 +1,5 @@
'use strict';
-var helpers = require('./helpers.core');
-
var PI = Math.PI;
var RAD_PER_DEG = PI / 180;
var DOUBLE_PI = PI * 2;
@@ -233,26 +231,3 @@ var exports = {
};
module.exports = exports;
-
-// DEPRECATIONS
-
-/**
- * Provided for backward compatibility, use Chart.helpers.canvas.clear in... | true |
Other | chartjs | Chart.js | 92a4654d9b2ae91683c179cbf6186b31952cfcd1.json | Remove deprecated helpers (#6607) | src/helpers/helpers.core.js | @@ -317,44 +317,3 @@ var helpers = {
};
module.exports = helpers;
-
-// DEPRECATIONS
-
-/**
- * Provided for backward compatibility, use Chart.helpers.callback instead.
- * @function Chart.helpers.callCallback
- * @deprecated since version 2.6.0
- * @todo remove at version 3
- * @private
- */
-helpers.callCallback ... | true |
Other | chartjs | Chart.js | 92a4654d9b2ae91683c179cbf6186b31952cfcd1.json | Remove deprecated helpers (#6607) | src/helpers/helpers.easing.js | @@ -1,10 +1,8 @@
'use strict';
-var helpers = require('./helpers.core');
-
/**
* Easing functions adapted from Robert Penner's easing equations.
- * @namespace Chart.helpers.easingEffects
+ * @namespace Chart.helpers.effects
* @see http://www.robertpenner.com/easing/
*/
var effects = {
@@ -237,14 +235,3 @@ v... | true |
Other | chartjs | Chart.js | 92a4654d9b2ae91683c179cbf6186b31952cfcd1.json | Remove deprecated helpers (#6607) | src/helpers/helpers.math.js | @@ -1,7 +1,5 @@
'use strict';
-var helpers = require('./helpers.core');
-
/**
* @alias Chart.helpers.math
* @namespace
@@ -44,14 +42,3 @@ var exports = {
};
module.exports = exports;
-
-// DEPRECATIONS
-
-/**
- * Provided for backward compatibility, use Chart.helpers.math.log10 instead.
- * @namespace Chart... | true |
Other | chartjs | Chart.js | 92a4654d9b2ae91683c179cbf6186b31952cfcd1.json | Remove deprecated helpers (#6607) | src/platforms/platform.dom.js | @@ -446,27 +446,3 @@ module.exports = {
removeListener(canvas, type, proxy);
}
};
-
-// DEPRECATIONS
-
-/**
- * Provided for backward compatibility, use EventTarget.addEventListener instead.
- * EventTarget.addEventListener compatibility: Chrome, Opera 7, Safari, FF1.5+, IE9+
- * @see https://developer.mozilla.or... | true |
Other | chartjs | Chart.js | 92a4654d9b2ae91683c179cbf6186b31952cfcd1.json | Remove deprecated helpers (#6607) | test/specs/core.helpers.tests.js | @@ -378,17 +378,6 @@ describe('Core helper tests', function() {
}]);
});
- it('count look at all the labels and return maximum number of lines', function() {
- window.createMockContext();
- var arrayOfThings1 = ['Foo', 'Bar'];
- var arrayOfThings2 = [['Foo', 'Bar'], 'Foo'];
- var arrayOfThings3 = [['Foo', 'B... | true |
Other | chartjs | Chart.js | 92a4654d9b2ae91683c179cbf6186b31952cfcd1.json | Remove deprecated helpers (#6607) | test/specs/global.deprecations.tests.js | @@ -1,469 +0,0 @@
-describe('Deprecations', function() {
- describe('Version 2.9.0', function() {
- describe('Chart.Scale.mergeTicksOptions', function() {
- it('should be defined as a function', function() {
- expect(typeof Chart.Scale.prototype.mergeTicksOptions).toBe('function');
- });
- });
- });
-
- descri... | true |
Other | chartjs | Chart.js | 0da237a31575093c1b5c964574a45ab8e6a1f88b.json | Remove undocumented "custom" feature (#6605)
Remove undocumented "custom" feature | src/controllers/controller.bar.js | @@ -179,7 +179,7 @@ module.exports = DatasetController.extend({
var me = this;
var meta = me.getMeta();
var dataset = me.getDataset();
- var options = me._resolveDataElementOptions(rectangle, index);
+ var options = me._resolveDataElementOptions(index);
rectangle._xScale = me.getScaleForId(meta.xAxisID)... | true |
Other | chartjs | Chart.js | 0da237a31575093c1b5c964574a45ab8e6a1f88b.json | Remove undocumented "custom" feature (#6605)
Remove undocumented "custom" feature | src/controllers/controller.bubble.js | @@ -83,10 +83,9 @@ module.exports = DatasetController.extend({
updateElement: function(point, index, reset) {
var me = this;
var meta = me.getMeta();
- var custom = point.custom || {};
var xScale = me.getScaleForId(meta.xAxisID);
var yScale = me.getScaleForId(meta.yAxisID);
- var options = me._resolveDa... | true |
Other | chartjs | Chart.js | 0da237a31575093c1b5c964574a45ab8e6a1f88b.json | Remove undocumented "custom" feature (#6605)
Remove undocumented "custom" feature | src/controllers/controller.doughnut.js | @@ -190,7 +190,7 @@ module.exports = DatasetController.extend({
}
for (i = 0, ilen = arcs.length; i < ilen; ++i) {
- arcs[i]._options = me._resolveDataElementOptions(arcs[i], i);
+ arcs[i]._options = me._resolveDataElementOptions(i);
}
chart.borderWidth = me.getMaxBorderWidth();
@@ -323,7 +323,7 @@ ... | true |
Other | chartjs | Chart.js | 0da237a31575093c1b5c964574a45ab8e6a1f88b.json | Remove undocumented "custom" feature (#6605)
Remove undocumented "custom" feature | src/controllers/controller.line.js | @@ -93,7 +93,7 @@ module.exports = DatasetController.extend({
// Data
line._children = points;
// Model
- line._model = me._resolveDatasetElementOptions(line);
+ line._model = me._resolveDatasetElementOptions();
line.pivot();
}
@@ -116,7 +116,6 @@ module.exports = DatasetController.extend({
u... | true |
Other | chartjs | Chart.js | 0da237a31575093c1b5c964574a45ab8e6a1f88b.json | Remove undocumented "custom" feature (#6605)
Remove undocumented "custom" feature | src/controllers/controller.polarArea.js | @@ -159,7 +159,7 @@ module.exports = DatasetController.extend({
}
for (i = 0, ilen = arcs.length; i < ilen; ++i) {
- arcs[i]._options = me._resolveDataElementOptions(arcs[i], i);
+ arcs[i]._options = me._resolveDataElementOptions(i);
me.updateElement(arcs[i], i, reset);
}
}, | true |
Other | chartjs | Chart.js | 0da237a31575093c1b5c964574a45ab8e6a1f88b.json | Remove undocumented "custom" feature (#6605)
Remove undocumented "custom" feature | src/controllers/controller.radar.js | @@ -92,7 +92,7 @@ module.exports = DatasetController.extend({
line._children = points;
line._loop = true;
// Model
- line._model = me._resolveDatasetElementOptions(line);
+ line._model = me._resolveDatasetElementOptions();
line.pivot();
@@ -112,11 +112,10 @@ module.exports = DatasetController.extend({... | true |
Other | chartjs | Chart.js | 0da237a31575093c1b5c964574a45ab8e6a1f88b.json | Remove undocumented "custom" feature (#6605)
Remove undocumented "custom" feature | src/core/core.datasetController.js | @@ -340,10 +340,10 @@ helpers.extend(DatasetController.prototype, {
me._configure();
if (dataset && index === undefined) {
- style = me._resolveDatasetElementOptions(dataset || {});
+ style = me._resolveDatasetElementOptions();
} else {
index = index || 0;
- style = me._resolveDataElementOptions(me... | true |
Other | chartjs | Chart.js | 0da237a31575093c1b5c964574a45ab8e6a1f88b.json | Remove undocumented "custom" feature (#6605)
Remove undocumented "custom" feature | test/specs/controller.bar.tests.js | @@ -1407,18 +1407,6 @@ describe('Chart.controllers.bar', function() {
expect(bar._model.backgroundColor).toBe('rgb(255, 255, 255)');
expect(bar._model.borderColor).toBe('rgb(9, 9, 9)');
expect(bar._model.borderWidth).toBe(2.5);
-
- // Should allow a custom style
- bar.custom = {
- hoverBackgroundColor: 'rg... | true |
Other | chartjs | Chart.js | 0da237a31575093c1b5c964574a45ab8e6a1f88b.json | Remove undocumented "custom" feature (#6605)
Remove undocumented "custom" feature | test/specs/controller.bubble.tests.js | @@ -180,27 +180,6 @@ describe('Chart.controllers.bubble', function() {
skip: false
}));
}
-
- // point styles
- meta.data[0].custom = {
- radius: 2.2,
- backgroundColor: 'rgb(0, 1, 3)',
- borderColor: 'rgb(4, 6, 8)',
- borderWidth: 0.787,
- tension: 0.15,
- hitRadius: 5,
- skip: true
- };
-... | true |
Other | chartjs | Chart.js | 0da237a31575093c1b5c964574a45ab8e6a1f88b.json | Remove undocumented "custom" feature (#6605)
Remove undocumented "custom" feature | test/specs/controller.doughnut.tests.js | @@ -408,28 +408,5 @@ describe('Chart.controllers.doughnut', function() {
expect(arc._model.borderColor).toBe('rgb(50, 100, 150)');
expect(arc._model.borderWidth).toBe(2);
});
-
- it ('should handle hover styles defined via element custom', function() {
- var chart = this.chart;
- var arc = chart.getData... | true |
Other | chartjs | Chart.js | 0da237a31575093c1b5c964574a45ab8e6a1f88b.json | Remove undocumented "custom" feature (#6605)
Remove undocumented "custom" feature | test/specs/controller.line.tests.js | @@ -870,32 +870,6 @@ describe('Chart.controllers.line', function() {
expect(point._model.radius).toBe(3);
});
- it ('should handle hover styles defined via element custom', function() {
- var chart = this.chart;
- var point = chart.getDatasetMeta(0).data[0];
-
- point.custom = {
- hoverBackgroundColo... | true |
Other | chartjs | Chart.js | 0da237a31575093c1b5c964574a45ab8e6a1f88b.json | Remove undocumented "custom" feature (#6605)
Remove undocumented "custom" feature | test/specs/controller.polarArea.tests.js | @@ -135,27 +135,12 @@ describe('Chart.controllers.polarArea', function() {
expect(meta.data[i]._model.borderWidth).toBe(1.123);
}
- // arc styles
- meta.data[0].custom = {
- backgroundColor: 'rgb(0, 1, 3)',
- borderColor: 'rgb(4, 6, 8)',
- borderWidth: 0.787
- };
-
chart.update();
expect(meta.... | true |
Other | chartjs | Chart.js | 0da237a31575093c1b5c964574a45ab8e6a1f88b.json | Remove undocumented "custom" feature (#6605)
Remove undocumented "custom" feature | test/specs/controller.radar.tests.js | @@ -231,59 +231,6 @@ describe('Chart.controllers.radar', function() {
tension: 0,
}));
});
-
-
- // Use custom styles for lines & first point
- meta.dataset.custom = {
- backgroundColor: 'rgb(55, 55, 54)',
- borderColor: 'rgb(8, 7, 6)',
- borderWidth: 0.3,
- borderCapStyle: 'square',
- borderDas... | true |
Other | chartjs | Chart.js | db4a0d45699dedff00c875087d9d07135a7d2e80.json | Limit onClick to chartArea (#6227)
* Limit onClick to chartArea
* Utilize helpers.canvas._isPointInArea | src/core/core.controller.js | @@ -1080,7 +1080,7 @@ helpers.extend(Chart.prototype, /** @lends Chart */ {
helpers.callback(options.onHover || options.hover.onHover, [e.native, me.active], me);
if (e.type === 'mouseup' || e.type === 'click') {
- if (options.onClick) {
+ if (options.onClick && helpers.canvas._isPointInArea(e, me.chartArea... | false |
Other | chartjs | Chart.js | ae80936f0357eac8d8d100fac1dc5af7851443bd.json | Add link to performance documentation (#6613) | docs/general/README.md | @@ -8,3 +8,4 @@ These sections describe general configuration options that can apply elsewhere i
* [Options](./options.md) scriptable and indexable options syntax.
* [Colors](./colors.md) defines acceptable color values.
* [Font](./fonts.md) defines various font options.
+* [Performance](./performance.md) gives tips... | false |
Other | chartjs | Chart.js | 21da5be3c63e69a4edfc364d040e270471d8234d.json | Fix horizontalBar deprecation warnings (#6603)
Fix horizontalBar deprecation warnings | src/controllers/controller.horizontalBar.js | @@ -18,8 +18,6 @@ defaults._set('horizontalBar', {
yAxes: [{
type: 'category',
position: 'left',
- categoryPercentage: 0.8,
- barPercentage: 0.9,
offset: true,
gridLines: {
offsetGridLines: true
@@ -39,6 +37,15 @@ defaults._set('horizontalBar', {
}
});
+defaults._set('global', {
+ datas... | true |
Other | chartjs | Chart.js | 21da5be3c63e69a4edfc364d040e270471d8234d.json | Fix horizontalBar deprecation warnings (#6603)
Fix horizontalBar deprecation warnings | test/specs/controller.bar.tests.js | @@ -1593,8 +1593,9 @@ describe('Chart.controllers.bar', function() {
var meta = chart.getDatasetMeta(0);
var yScale = chart.scales[meta.yAxisID];
- var categoryPercentage = yScale.options.categoryPercentage;
- var barPercentage = yScale.options.barPercentage;
+ var config = meta.controller._config;
+ ... | true |
Other | chartjs | Chart.js | 4d7fefcdb6bd48a078af6378fba33dbcb63cf747.json | Remove a couple calls to helpers.each (#6594) | src/core/core.controller.js | @@ -417,32 +417,35 @@ helpers.extend(Chart.prototype, /** @lends Chart */ {
buildOrUpdateControllers: function() {
var me = this;
var newControllers = [];
+ var datasets = me.data.datasets;
+ var i, ilen;
- helpers.each(me.data.datasets, function(dataset, datasetIndex) {
- var meta = me.getDatasetMeta(da... | false |
Other | chartjs | Chart.js | f606c23f2fbea2612208ffb49511b66e37ce4335.json | Fix unit determination when autoSkip is enabled (#6583) | src/scales/scale.time.js | @@ -257,7 +257,7 @@ function determineUnitForAutoTicks(minUnit, min, max, capacity) {
for (i = UNITS.indexOf(minUnit); i < ilen - 1; ++i) {
interval = INTERVALS[UNITS[i]];
- factor = interval.steps ? interval.steps / 2 : MAX_INTEGER;
+ factor = interval.steps ? interval.steps : MAX_INTEGER;
if (interval.c... | true |
Other | chartjs | Chart.js | f606c23f2fbea2612208ffb49511b66e37ce4335.json | Fix unit determination when autoSkip is enabled (#6583) | test/specs/scale.time.tests.js | @@ -128,7 +128,7 @@ describe('Time scale tests', function() {
var ticks = getTicksLabels(scale);
// `bounds === 'data'`: first and last ticks removed since outside the data range
- expect(ticks).toEqual(['Jan 2', 'Jan 3', 'Jan 4', 'Jan 5', 'Jan 6', 'Jan 7', 'Jan 8', 'Jan 9', 'Jan 10']);
+ expect(ticks.len... | true |
Other | chartjs | Chart.js | 6c9f202c6835d60fbaa220cbfab99b9946aae999.json | Fix autoskip for first segment of chart (#6584)
* Fix autoskip for first segment of chart
* Fix issue identified during review | src/core/core.scale.js | @@ -305,6 +305,12 @@ function skip(ticks, spacing, majorStart, majorEnd) {
}
next = start;
+
+ while (next < 0) {
+ count++;
+ next = Math.round(start + count * spacing);
+ }
+
for (i = Math.max(start, 0); i < end; i++) {
tick = ticks[i];
if (i === next) { | false |
Other | chartjs | Chart.js | d3860137fe236b9c8d92ef7be7147ac976b9c545.json | Fix logarighmic test to use correct scale (#6580) | test/specs/scale.logarithmic.tests.js | @@ -749,7 +749,7 @@ describe('Logarithmic Scale tests', function() {
}
});
- expect(chart.scales.yScale1.getLabelForIndex(0, 2)).toBe(150);
+ expect(chart.scales.yScale0.getLabelForIndex(0, 2)).toBe(150);
});
describe('when', function() { | false |
Other | chartjs | Chart.js | fc76610b121d71fc5b903631d21edd04b886e3e0.json | Add ticks.sampleSize option (#6508) | docs/axes/cartesian/README.md | @@ -28,6 +28,7 @@ The following options are common to all cartesian axes but do not apply to other
| ---- | ---- | ------- | -----------
| `min` | `number` | | User defined minimum value for the scale, overrides minimum value from data.
| `max` | `number` | | User defined maximum value for the scale, overrides maxim... | true |
Other | chartjs | Chart.js | fc76610b121d71fc5b903631d21edd04b886e3e0.json | Add ticks.sampleSize option (#6508) | docs/general/performance.md | @@ -0,0 +1,8 @@
+# Performance
+
+Chart.js charts are rendered on `canvas` elements, which makes rendering quite fast. For large datasets or performance sensitive applications, you may wish to consider the tips below:
+
+* Set `animation: { duration: 0 }` to disable [animations](../configuration/animations.md).
+* For ... | true |
Other | chartjs | Chart.js | fc76610b121d71fc5b903631d21edd04b886e3e0.json | Add ticks.sampleSize option (#6508) | src/core/core.scale.js | @@ -67,6 +67,19 @@ defaults._set('scale', {
}
});
+/** Returns a new array containing numItems from arr */
+function sample(arr, numItems) {
+ var result = [];
+ var increment = arr.length / numItems;
+ var i = 0;
+ var len = arr.length;
+
+ for (; i < len; i += increment) {
+ result.push(arr[Math.floor(i)]);
+ }... | true |
Other | chartjs | Chart.js | e9f341889fe2e4a43c9ef66b379ec88cf2241415.json | Add link to linear radial axis for radar chart doc (#6554) | docs/charts/radar.md | @@ -152,12 +152,18 @@ The radar chart defines the following configuration options. These options are m
## Scale Options
The radar chart supports only a single scale. The options for this scale are defined in the `scale` property.
+The options for this scale are defined in the `scale` property, which can be referenc... | false |
Other | chartjs | Chart.js | ce8ee02ccd992c062cfa734df713730c077cdb2e.json | Reduce indentation by reversing if check (#6497) | src/plugins/plugin.legend.js | @@ -250,80 +250,82 @@ var Legend = Element.extend({
}
// Increase sizes here
- if (display) {
- ctx.font = labelFont.string;
+ if (!display) {
+ me.width = minSize.width = me.height = minSize.height = 0;
+ return;
+ }
+ ctx.font = labelFont.string;
- if (isHorizontal) {
- // Labels
-
- // Wi... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.