language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | chartjs | Chart.js | c8bdca62e89b4d6d9f334cec7a8bfa673725014c.json | Move all helpers to src/helpers (#6841)
* Move all helpers into src/helpers
* Move curve helpers to their own file
* DOM helpers moved to their own file
* Update migration docs
* Remove migration docs on new functions | src/index.js | @@ -4,10 +4,6 @@
var Chart = require('./core/core.controller');
Chart.helpers = require('./helpers/index');
-
-// @todo dispatch these helpers into appropriated helpers/helpers.* file and write unit tests!
-require('./core/core.helpers')(Chart);
-
Chart._adapters = require('./core/core.adapters');
Chart.Animation... | true |
Other | chartjs | Chart.js | c8bdca62e89b4d6d9f334cec7a8bfa673725014c.json | Move all helpers to src/helpers (#6841)
* Move all helpers into src/helpers
* Move curve helpers to their own file
* DOM helpers moved to their own file
* Update migration docs
* Remove migration docs on new functions | src/platforms/platform.dom.js | @@ -41,7 +41,7 @@ var EVENT_TYPES = {
* @returns {number} Size in pixels or undefined if unknown.
*/
function readUsedSize(element, property) {
- var value = helpers.getStyle(element, property);
+ var value = helpers.dom.getStyle(element, property);
var matches = value && value.match(/^(\d+)(\.\d+)?px$/);
retu... | true |
Other | chartjs | Chart.js | c8bdca62e89b4d6d9f334cec7a8bfa673725014c.json | Move all helpers to src/helpers (#6841)
* Move all helpers into src/helpers
* Move curve helpers to their own file
* DOM helpers moved to their own file
* Update migration docs
* Remove migration docs on new functions | src/scales/scale.linearbase.js | @@ -1,6 +1,7 @@
'use strict';
import helpers from '../helpers/index';
+import {almostEquals, almostWhole, _decimalPlaces, _setMinAndMaxByKey, sign} from '../helpers/helpers.math';
import Scale from '../core/core.scale';
const isNullOrUndef = helpers.isNullOrUndef;
@@ -43,7 +44,7 @@ function generateTicks(genera... | true |
Other | chartjs | Chart.js | c8bdca62e89b4d6d9f334cec7a8bfa673725014c.json | Move all helpers to src/helpers (#6841)
* Move all helpers into src/helpers
* Move curve helpers to their own file
* DOM helpers moved to their own file
* Update migration docs
* Remove migration docs on new functions | src/scales/scale.logarithmic.js | @@ -2,6 +2,7 @@
import defaults from '../core/core.defaults';
import helpers from '../helpers/index';
+import {_setMinAndMaxByKey} from '../helpers/helpers.math';
import Scale from '../core/core.scale';
import LinearScaleBase from './scale.linearbase';
import Ticks from '../core/core.ticks';
@@ -132,7 +133,7 @@ ... | true |
Other | chartjs | Chart.js | c8bdca62e89b4d6d9f334cec7a8bfa673725014c.json | Move all helpers to src/helpers (#6841)
* Move all helpers into src/helpers
* Move curve helpers to their own file
* DOM helpers moved to their own file
* Update migration docs
* Remove migration docs on new functions | src/scales/scale.radialLinear.js | @@ -2,6 +2,7 @@
import defaults from '../core/core.defaults';
import helpers from '../helpers/index';
+import {isNumber, toDegrees} from '../helpers/helpers.math';
import LinearScaleBase from './scale.linearbase';
import Ticks from '../core/core.ticks';
@@ -156,7 +157,7 @@ function fitWithPointLabels(scale) {
... | true |
Other | chartjs | Chart.js | c8bdca62e89b4d6d9f334cec7a8bfa673725014c.json | Move all helpers to src/helpers (#6841)
* Move all helpers into src/helpers
* Move curve helpers to their own file
* DOM helpers moved to their own file
* Update migration docs
* Remove migration docs on new functions | src/scales/scale.time.js | @@ -3,6 +3,7 @@
import adapters from '../core/core.adapters';
import defaults from '../core/core.defaults';
import helpers from '../helpers/index';
+import {toRadians} from '../helpers/helpers.math';
import Scale from '../core/core.scale';
const resolve = helpers.options.resolve;
@@ -731,7 +732,7 @@ class TimeSc... | true |
Other | chartjs | Chart.js | c8bdca62e89b4d6d9f334cec7a8bfa673725014c.json | Move all helpers to src/helpers (#6841)
* Move all helpers into src/helpers
* Move curve helpers to their own file
* DOM helpers moved to their own file
* Update migration docs
* Remove migration docs on new functions | test/specs/core.helpers.tests.js | @@ -20,26 +20,6 @@ describe('Core helper tests', function() {
expect(helpers.findPreviousWhere(data, callback, 0)).toBe(undefined);
});
- it('should get the correct sign', function() {
- expect(helpers.sign(0)).toBe(0);
- expect(helpers.sign(10)).toBe(1);
- expect(helpers.sign(-5)).toBe(-1);
- });
-
- it('sho... | true |
Other | chartjs | Chart.js | c8bdca62e89b4d6d9f334cec7a8bfa673725014c.json | Move all helpers to src/helpers (#6841)
* Move all helpers into src/helpers
* Move curve helpers to their own file
* DOM helpers moved to their own file
* Update migration docs
* Remove migration docs on new functions | test/specs/helpers.curve.tests.js | @@ -0,0 +1,211 @@
+describe('Curve helper tests', function() {
+ let helpers;
+
+ beforeAll(function() {
+ helpers = window.Chart.helpers.curve;
+ });
+
+ it('should spline curves', function() {
+ expect(helpers.splineCurve({
+ x: 0,
+ y: 0
+ }, {
+ x: 1,
+ y: 1
+ }, {
+ x: 2,
+ y: 0
+ }, 0)).toEqual({... | true |
Other | chartjs | Chart.js | c8bdca62e89b4d6d9f334cec7a8bfa673725014c.json | Move all helpers to src/helpers (#6841)
* Move all helpers into src/helpers
* Move curve helpers to their own file
* DOM helpers moved to their own file
* Update migration docs
* Remove migration docs on new functions | test/specs/helpers.dom.tests.js | @@ -0,0 +1,259 @@
+describe('DOM helpers tests', function() {
+ let helpers;
+
+ beforeAll(function() {
+ helpers = window.Chart.helpers.dom;
+ });
+
+ it ('should get the maximum width and height for a node', function() {
+ // Create div with fixed size as a test bed
+ var div = document.createElement('div');
+ di... | true |
Other | chartjs | Chart.js | c8bdca62e89b4d6d9f334cec7a8bfa673725014c.json | Move all helpers to src/helpers (#6841)
* Move all helpers into src/helpers
* Move curve helpers to their own file
* DOM helpers moved to their own file
* Update migration docs
* Remove migration docs on new functions | test/specs/helpers.math.tests.js | @@ -4,6 +4,7 @@
describe('Chart.helpers.math', function() {
var math = Chart.helpers.math;
var factorize = math._factorize;
+ var decimalPlaces = math._decimalPlaces;
it('should factorize', function() {
expect(factorize(1000)).toEqual([1, 2, 4, 5, 8, 10, 20, 25, 40, 50, 100, 125, 200, 250, 500]);
@@ -25,4 +... | true |
Other | chartjs | Chart.js | dc4cff748f8ed36c29731b43aa7a9494ed1b4fc4.json | Convert line controller to use const/let (#6820) | src/controllers/controller.line.js | @@ -1,13 +1,13 @@
'use strict';
-var DatasetController = require('../core/core.datasetController');
-var defaults = require('../core/core.defaults');
-var elements = require('../elements/index');
-var helpers = require('../helpers/index');
+const DatasetController = require('../core/core.datasetController');
+const ... | false |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | docs/SUMMARY.md | @@ -8,6 +8,7 @@
* [Usage](getting-started/usage.md)
* [Migration Guide](getting-started/v3-migration.md)
* [General](general/README.md)
+ * [Data structures](general/data-structures.md)
* [Accessibility](general/accessibility.md)
* [Responsive](general/responsive.md)
* [Pixel Ratio](general/device-pixe... | true |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | docs/axes/cartesian/category.md | @@ -17,6 +17,7 @@ let chart = new Chart(ctx, {
}
});
```
+
As part of axis definition:
```javascript
@@ -41,11 +42,12 @@ The category scale provides the following options for configuring tick marks. Th
| Name | Type | Default | Description
| ---- | ---- | ------- | -----------
| `labels` | `string[]` | - ... | true |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | docs/axes/cartesian/linear.md | @@ -75,3 +75,7 @@ let options = {
}
};
```
+
+## Internal data format
+
+Internally, linear scale uses numeric data | true |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | docs/axes/cartesian/logarithmic.md | @@ -5,3 +5,7 @@ The logarithmic scale is use to chart numerical data. It can be placed on either
## Tick Configuration Options
The logarithmic scale options extend the [common tick configuration](README.md#tick-configuration). This scale does not define any options that are unique to it.
+
+## Internal data format
... | true |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | docs/axes/cartesian/time.md | @@ -155,6 +155,11 @@ The `ticks.source` property controls the ticks generation.
* `'labels'`: generates ticks from user given `labels` ONLY
### Parser
+
If this property is defined as a string, it is interpreted as a custom format to be used by Moment.js to parse the date.
If this is a function, it must return ... | true |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | docs/axes/radial/linear.md | @@ -69,6 +69,7 @@ let chart = new Chart(ctx, {
In contrast to the `suggested*` settings, the `min` and `max` settings set explicit ends to the axes. When these are set, some data points may not be visible.
## Step Size
+
If set, the scale ticks will be enumerated by multiple of `stepSize`, having one tick per incr... | true |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | docs/charts/bar.md | @@ -1,4 +1,5 @@
# Bar
+
A bar chart provides a way of showing data values represented as vertical bars. It is sometimes used to show trend data, and the comparison of multiple data sets side by side.
{% chartjs %}
@@ -114,6 +115,7 @@ that derive from a bar chart.
**Note:** for negative bars in vertical chart, `to... | true |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | docs/charts/bubble.md | @@ -115,3 +115,7 @@ Bubble chart datasets need to contain a `data` array of points, each points repr
```
**Important:** the radius property, `r` is **not** scaled by the chart, it is the raw radius in pixels of the bubble that is drawn on the canvas.
+
+## Internal data format
+
+`{x, y, _custom}` where `_custom` i... | true |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | docs/charts/line.md | @@ -1,4 +1,5 @@
# Line
+
A line chart is a way of plotting data points on a line. Often, it is used to show trend data, or the comparison of two data sets.
{% chartjs %}
@@ -29,6 +30,7 @@ A line chart is a way of plotting data points on a line. Often, it is used to sh
{% endchartjs %}
## Example Usage
+
```ja... | true |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | docs/charts/radar.md | @@ -200,3 +200,7 @@ data: {
}]
}
```
+
+## Internal data format
+
+`{x, y}` | true |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | docs/charts/scatter.md | @@ -48,3 +48,7 @@ data: [{
y: 10
}]
```
+
+## Internal data format
+
+`{x, y}` | true |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | docs/general/data-structures.md | @@ -0,0 +1,39 @@
+# Data structures
+
+The `data` property of a dataset can be passed in various formats. By default, that `data` is parsed using the associated chart type and scales.
+
+## Primitive[]
+
+```javascript
+data: [20, 10],
+labels: ['a', 'b']
+```
+
+When the `data` is an array of numbers, values from `lab... | true |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | docs/general/performance.md | @@ -59,6 +59,10 @@ new Chart(ctx, {
});
```
+## Data structure and format
+
+Provide prepared data in the internal format accepted by the dataset and scales and set `parsing: false`. See [Data structures](data-structures.md) for more information.
+
## Data Decimation
Decimating your data will achieve the best r... | true |
Other | chartjs | Chart.js | 53c6c618c6fc8b30efdb1e7e75a1c4673fe179d2.json | Allow pre-parsed data (to scale id's) (#6768)
* Allow pre-parsed data (to scale id's)
* Only update `count` references in pre-parsed mode
* Documentation | src/core/core.datasetController.js | @@ -473,18 +473,23 @@ helpers.extend(DatasetController.prototype, {
const me = this;
const {_cachedMeta: meta, _data: data} = me;
const {iScale, vScale, _stacked} = meta;
- let i, ilen, parsed;
-
- if (helpers.isArray(data[start])) {
+ const parsing = resolve([me.getDataset().parsing, me.chart.options.parsi... | true |
Other | chartjs | Chart.js | 99596b04345ab79fc2bca9016779b2671db87bd7.json | Reduce duplication in drawGrid (#8647) | src/core/core.scale.js | @@ -1617,41 +1617,46 @@ export default class Scale extends Element {
const items = me._gridLineItems || (me._gridLineItems = me._computeGridLineItems(chartArea));
let i, ilen;
+ const drawLine = (p1, p2, style) => {
+ if (!style.width || !style.color) {
+ return;
+ }
+ ctx.save();
+... | false |
Other | chartjs | Chart.js | f744c3bde63cd74e598dabf4f59ea7ff96777e79.json | Add x/y shorthand for padding options (#8637) | docs/docs/axes/labelling.md | @@ -15,7 +15,7 @@ Namespace: `options.scales[scaleId].title`, it defines options for the scale tit
| `text` | `string`\|`string[]` | `''` | The text for the title. (i.e. "# of People" or "Response Choices").
| `color` | [`Color`](../general/colors.md) | `Chart.defaults.color` | Color of label.
| `font` | `Font` | `C... | true |
Other | chartjs | Chart.js | f744c3bde63cd74e598dabf4f59ea7ff96777e79.json | Add x/y shorthand for padding options (#8637) | docs/docs/axes/radial/linear.mdx | @@ -34,11 +34,11 @@ Namespace: `options.scales[scaleId].ticks`
| Name | Type | Scriptable | Default | Description
| ---- | ---- | ------- | ------- | -----------
| `backdropColor` | [`Color`](../../general/colors.md) | Yes | `'rgba(255, 255, 255, 0.75)'` | Color of label backdrops.
-| `backdropPadding` | `number`\|`... | true |
Other | chartjs | Chart.js | f744c3bde63cd74e598dabf4f59ea7ff96777e79.json | Add x/y shorthand for padding options (#8637) | docs/docs/configuration/layout.md | @@ -6,27 +6,4 @@ Namespace: `options.layout`, the global options for the chart layout is defined
| Name | Type | Default | [Scriptable](../general/options.md#scriptable-options) | Description
| ---- | ---- | ------- | :----: | -----------
-| `padding` | `number`\|`object` | `0` | Yes | The padding to add inside the... | true |
Other | chartjs | Chart.js | f744c3bde63cd74e598dabf4f59ea7ff96777e79.json | Add x/y shorthand for padding options (#8637) | docs/docs/configuration/legend.md | @@ -73,7 +73,7 @@ Namespace: `options.plugins.legend.title`
| `color` | [`Color`](../general/colors.md) | `Chart.defaults.color` | Color of text.
| `display` | `boolean` | `false` | Is the legend title displayed.
| `font` | `Font` | `Chart.defaults.font` | See [Fonts](../general/fonts.md)
-| `padding` | `number`\|`o... | true |
Other | chartjs | Chart.js | f744c3bde63cd74e598dabf4f59ea7ff96777e79.json | Add x/y shorthand for padding options (#8637) | docs/docs/configuration/title.md | @@ -16,7 +16,7 @@ Namespace: `options.plugins.title`, the global options for the chart title is de
| `fullSize` | `boolean` | `true` | Marks that this box should take the full width/height of the canvas. If `false`, the box is sized and placed above/beside the chart area.
| `position` | `string` | `'top'` | Position ... | true |
Other | chartjs | Chart.js | f744c3bde63cd74e598dabf4f59ea7ff96777e79.json | Add x/y shorthand for padding options (#8637) | docs/docs/configuration/tooltip.md | @@ -31,7 +31,7 @@ Namespace: `options.plugins.tooltip`, the global options for the chart tooltips
| `footerAlign` | `string` | `'left'` | Horizontal alignment of the footer text lines. [more...](#alignment)
| `footerSpacing` | `number` | `2` | Spacing to add to top and bottom of each footer line.
| `footerMarginTop`... | true |
Other | chartjs | Chart.js | f744c3bde63cd74e598dabf4f59ea7ff96777e79.json | Add x/y shorthand for padding options (#8637) | docs/docs/general/padding.md | @@ -0,0 +1,68 @@
+---
+title: Padding
+---
+
+Padding values in Chart options can be supplied in couple of different formats.
+
+### Number
+
+If this value is a number, it is applied to all sides (left, top, right, bottom).
+
+For exmaple, defining a 20px padding to all sides of chart:
+
+```javascript
+let chart = ne... | true |
Other | chartjs | Chart.js | f744c3bde63cd74e598dabf4f59ea7ff96777e79.json | Add x/y shorthand for padding options (#8637) | docs/sidebars.js | @@ -17,6 +17,7 @@ module.exports = {
'general/options',
'general/colors',
'general/fonts',
+ 'general/padding',
'general/performance'
],
Configuration: [ | true |
Other | chartjs | Chart.js | f744c3bde63cd74e598dabf4f59ea7ff96777e79.json | Add x/y shorthand for padding options (#8637) | src/helpers/helpers.options.js | @@ -38,22 +38,25 @@ export function toLineHeight(value, size) {
}
const numberOrZero = v => +v || 0;
+const numberOrZero2 = (v1, v2) => numberOrZero(valueOrDefault(v1, v2));
/**
* Converts the given value into a TRBL object.
* @param {number|object} value - If a number, set the value to all TRBL component,
... | true |
Other | chartjs | Chart.js | f744c3bde63cd74e598dabf4f59ea7ff96777e79.json | Add x/y shorthand for padding options (#8637) | test/specs/helpers.options.tests.js | @@ -95,6 +95,14 @@ describe('Chart.helpers.options', function() {
expect(toPadding(undefined)).toEqual(
{top: 0, right: 0, bottom: 0, left: 0, height: 0, width: 0});
});
+ it('should support x / y shorthands', function() {
+ expect(toPadding({x: 1, y: 2})).toEqual(
+ {top: 2, right: ... | true |
Other | chartjs | Chart.js | f744c3bde63cd74e598dabf4f59ea7ff96777e79.json | Add x/y shorthand for padding options (#8637) | types/helpers/helpers.options.d.ts | @@ -28,7 +28,7 @@ export function toLineHeight(value: string, size: number): number;
* @since 2.7.0
*/
export function toPadding(
- value?: number | { top?: number; left?: number; right?: number; bottom?: number }
+ value?: number | { top?: number; left?: number; right?: number; bottom?: number; x?:number, y?: nu... | true |
Other | chartjs | Chart.js | 96f6b42c57a57e71f84c73cbaa208afb4949f736.json | Use font lineHeight for tooltip alignment (#8631)
* Use font lineHeight for tooltip alignment
* Remove toFontString usage from tooltip | src/plugins/plugin.tooltip.js | @@ -1,10 +1,10 @@
import Animations from '../core/core.animations';
import Element from '../core/core.element';
import {each, noop, isNullOrUndef, isArray, _elementsEqual} from '../helpers/helpers.core';
-import {toPadding} from '../helpers/helpers.options';
+import {toFont, toPadding} from '../helpers/helpers.optio... | true |
Other | chartjs | Chart.js | 96f6b42c57a57e71f84c73cbaa208afb4949f736.json | Use font lineHeight for tooltip alignment (#8631)
* Use font lineHeight for tooltip alignment
* Remove toFontString usage from tooltip | test/specs/plugin.tooltip.tests.js | @@ -163,8 +163,8 @@ describe('Plugin.Tooltip', function() {
}]
}));
- expect(tooltip.x).toBeCloseToPixel(267);
- expect(tooltip.y).toBeCloseToPixel(155);
+ expect(tooltip.x).toBeCloseToPixel(266);
+ expect(tooltip.y).toBeCloseToPixel(150);
});
it('Should only display if... | true |
Other | chartjs | Chart.js | a026b6065324fe8967de7789b091996a30557ed6.json | Change default autoSkipPadding to 3 (#8629) | docs/docs/axes/cartesian/_common_ticks.md | @@ -8,7 +8,7 @@ Namespace: `options.scales[scaleId].ticks`
| `crossAlign` | `string` | `'near'` | The tick alignment perpendicular to the axis. Can be `'near'`, `'center'`, or `'far'`. See [Tick Alignment](./index#tick-alignment)
| `sampleSize` | `number` | `ticks.length` | The number of ticks to examine when decidin... | true |
Other | chartjs | Chart.js | a026b6065324fe8967de7789b091996a30557ed6.json | Change default autoSkipPadding to 3 (#8629) | src/core/core.scale.js | @@ -78,7 +78,7 @@ defaults.set('scale', {
padding: 0,
display: true,
autoSkip: true,
- autoSkipPadding: 0,
+ autoSkipPadding: 3,
labelOffset: 0,
// We pass through arrays to be rendered as multiline labels, we convert Others to strings here.
callback: Ticks.formatters.values, | true |
Other | chartjs | Chart.js | a026b6065324fe8967de7789b091996a30557ed6.json | Change default autoSkipPadding to 3 (#8629) | test/specs/scale.time.tests.js | @@ -1096,6 +1096,7 @@ describe('Time scale tests', function() {
ticks: {
source: 'data',
autoSkip: true,
+ autoSkipPadding: 0,
maxRotation: 0
}
}, | true |
Other | chartjs | Chart.js | aae8a06c37c0fd9ae60ae76c50735bcdcbef77da.json | Update context documentation (#8626) | docs/docs/general/options.md | @@ -70,6 +70,8 @@ A plugin can provide `additionalOptionScopes` array of paths to additionally loo
Scriptable options also accept a function which is called for each of the underlying data values and that takes the unique argument `context` representing contextual information (see [option context](options.md#option-co... | true |
Other | chartjs | Chart.js | aae8a06c37c0fd9ae60ae76c50735bcdcbef77da.json | Update context documentation (#8626) | src/core/core.datasetController.js | @@ -158,6 +158,7 @@ function createDatasetContext(parent, index, dataset) {
dataset,
datasetIndex: index,
index,
+ mode: 'default',
type: 'dataset'
}
); | true |
Other | chartjs | Chart.js | b98974f5b2be666a6510b29e98f78994ce757704.json | Fix some animation issues (#8616)
* Fix some animation issues
* Stop animating shared options on reset
* cc | samples/advanced/progress-bar.html | @@ -6,9 +6,7 @@
<script src="../utils.js"></script>
<style>
canvas {
- -moz-user-select: none;
- -webkit-user-select: none;
- -ms-user-select: none;
+ user-select: none;
}
</style>
</head>
@@ -58,23 +56,26 @@
}]
},
options: {
- plugins: {
- title: {
- display: true,
- ... | true |
Other | chartjs | Chart.js | b98974f5b2be666a6510b29e98f78994ce757704.json | Fix some animation issues (#8616)
* Fix some animation issues
* Stop animating shared options on reset
* cc | src/core/core.animation.js | @@ -30,7 +30,7 @@ export default class Animation {
this._fn = cfg.fn || interpolators[cfg.type || typeof from];
this._easing = effects[cfg.easing] || effects.linear;
this._start = Math.floor(Date.now() + (cfg.delay || 0));
- this._duration = Math.floor(cfg.duration);
+ this._duration = this._total ... | true |
Other | chartjs | Chart.js | b98974f5b2be666a6510b29e98f78994ce757704.json | Fix some animation issues (#8616)
* Fix some animation issues
* Stop animating shared options on reset
* cc | src/core/core.animator.js | @@ -72,6 +72,11 @@ export class Animator {
item = items[i];
if (item._active) {
+ if (item._total > anims.duration) {
+ // if the animation has been updated and its duration prolonged,
+ // update to total duration of current animations run (for progress event)
+ ... | true |
Other | chartjs | Chart.js | b98974f5b2be666a6510b29e98f78994ce757704.json | Fix some animation issues (#8616)
* Fix some animation issues
* Stop animating shared options on reset
* cc | src/core/core.config.js | @@ -167,31 +167,35 @@ export default class Config {
* Returns the option scope keys for resolving dataset options.
* These keys do not include the dataset itself, because it is not under options.
* @param {string} datasetType
- * @return {string[]}
+ * @return {string[][]}
*/
datasetScopeKeys(dat... | true |
Other | chartjs | Chart.js | b98974f5b2be666a6510b29e98f78994ce757704.json | Fix some animation issues (#8616)
* Fix some animation issues
* Stop animating shared options on reset
* cc | src/core/core.datasetController.js | @@ -830,7 +830,7 @@ export default class DatasetController {
* @protected
*/
updateSharedOptions(sharedOptions, mode, newOptions) {
- if (sharedOptions) {
+ if (sharedOptions && !isDirectUpdateMode(mode)) {
this._resolveAnimations(undefined, mode).update(sharedOptions, newOptions);
}
} | true |
Other | chartjs | Chart.js | b98974f5b2be666a6510b29e98f78994ce757704.json | Fix some animation issues (#8616)
* Fix some animation issues
* Stop animating shared options on reset
* cc | src/helpers/helpers.core.js | @@ -306,11 +306,8 @@ export function resolveObjectKey(obj, key) {
}
let pos = 0;
let idx = indexOfDotOrLength(key, pos);
- while (idx > pos) {
+ while (obj && idx > pos) {
obj = obj[key.substr(pos, idx - pos)];
- if (!obj) {
- break;
- }
pos = idx + 1;
idx = indexOfDotOrLength(key, ... | true |
Other | chartjs | Chart.js | e513a904278530a08ca0995e5bd1ee8bda229f0f.json | Fix typo in animations.mdx (#8615)
transtion -> transition | docs/docs/configuration/animations.mdx | @@ -175,7 +175,7 @@ These default animations are overridden by most of the dataset controllers.
## transitions
The core transitions are `'active'`, `'hide'`, `'reset'`, `'resize'`, `'show'`.
-A custom transtion can be used by passing a custom `mode` to [update](../developers/api.md#updatemode).
+A custom transition... | false |
Other | chartjs | Chart.js | 7dce94e8203703eba02cc7dad9cb451f0e2e6e30.json | Fix typo in linear.mdx (#8605)
minumum -> minimum | docs/docs/axes/cartesian/linear.mdx | @@ -62,7 +62,7 @@ let options = {
## Grace
If the value is string ending with `%`, its treat as percentage. If number, its treat as value.
-The value is added to the maximum data value and subtracted from the minumum data. This extends the scale range as if the data values were that much greater.
+The value is adde... | false |
Other | chartjs | Chart.js | c27c27a081cc27f85f15a7f7b017fe7ef1ceb23d.json | Fix typo in auto package (#8601) | auto/auto.esm.js | @@ -1,5 +1,5 @@
-import {Chart, registrables} from '../dist/chart.esm';
+import {Chart, registerables} from '../dist/chart.esm';
-Chart.register(...registrables);
+Chart.register(...registerables);
export default Chart; | false |
Other | chartjs | Chart.js | 9a042672a74d71fb0238bfaa2310b237d106604e.json | Update scriptable tooltip context docs (#8599) | docs/docs/general/options.md | @@ -114,6 +114,7 @@ There are multiple levels of context objects:
* `data`
* `scale`
* `tick`
+ * `tooltip`
Each level inherits its parent(s) and any contextual information stored in the parent is available through the child.
@@ -162,3 +163,10 @@ In addition to [scale](#scale)
* `tick`: the associat... | false |
Other | chartjs | Chart.js | 7ec99c38c1b41b16cf7cad433569af56c2544d63.json | Move startAngle to scale options (#8593) | docs/docs/axes/radial/linear.mdx | @@ -21,6 +21,7 @@ Namespace: `options.scales[scaleId]`
| `angleLines` | `object` | | Angle line configuration. [more...](#angle-line-options)
| `beginAtZero` | `boolean` | `false` | if true, scale will include 0 if it is not already included.
| `pointLabels` | `object` | | Point label configuration. [more...](#point... | true |
Other | chartjs | Chart.js | 7ec99c38c1b41b16cf7cad433569af56c2544d63.json | Move startAngle to scale options (#8593) | docs/docs/charts/polar.mdx | @@ -112,7 +112,6 @@ These are the customisation options specific to Polar Area charts. These options
| Name | Type | Default | Description
| ---- | ---- | ------- | -----------
-| `startAngle` | `number` | `0` | Starting angle to draw arcs for the first item in a dataset. In degrees, 0 is at top.
| `animation.anim... | true |
Other | chartjs | Chart.js | 7ec99c38c1b41b16cf7cad433569af56c2544d63.json | Move startAngle to scale options (#8593) | docs/docs/getting-started/v3-migration.md | @@ -101,6 +101,7 @@ A number of changes were made to the configuration options passed to the `Chart`
* `scales.[x/y]Axes.zeroLine*` options of axes were removed. Use scriptable scale options instead.
* The dataset option `steppedLine` was removed. Use `stepped`
* The chart option `showLines` was renamed to `showLine... | true |
Other | chartjs | Chart.js | 7ec99c38c1b41b16cf7cad433569af56c2544d63.json | Move startAngle to scale options (#8593) | src/controllers/controller.polarArea.js | @@ -1,12 +1,6 @@
import DatasetController from '../core/core.datasetController';
import {toRadians, PI} from '../helpers/index';
-function getStartAngleRadians(deg) {
- // radialLinear scale draws angleLines using startAngle. 0 is expected to be at top.
- // Here we adjust to standard unit circle used in drawing,... | true |
Other | chartjs | Chart.js | 7ec99c38c1b41b16cf7cad433569af56c2544d63.json | Move startAngle to scale options (#8593) | src/scales/scale.radialLinear.js | @@ -368,11 +368,8 @@ export default class RadialLinearScale extends LinearScaleBase {
}
getIndexAngle(index) {
- const chart = this.chart;
- const angleMultiplier = TAU / chart.data.labels.length;
- const options = chart.options || {};
- const startAngle = options.startAngle || 0;
-
+ const angle... | true |
Other | chartjs | Chart.js | 7ec99c38c1b41b16cf7cad433569af56c2544d63.json | Move startAngle to scale options (#8593) | test/specs/controller.polarArea.tests.js | @@ -160,7 +160,11 @@ describe('Chart.controllers.polarArea', function() {
legend: false,
title: false,
},
- startAngle: 90, // default is 0
+ scales: {
+ r: {
+ startAngle: 90, // default is 0
+ }
+ },
elements: {
arc: ... | true |
Other | chartjs | Chart.js | 7ec99c38c1b41b16cf7cad433569af56c2544d63.json | Move startAngle to scale options (#8593) | test/specs/scale.radialLinear.tests.js | @@ -31,6 +31,8 @@ describe('Test the radial linear scale', function() {
circular: false
},
+ startAngle: 0,
+
ticks: {
color: Chart.defaults.color,
showLabelBackdrop: true,
@@ -500,14 +502,14 @@ describe('Test the radial linear scale', function() {
options: {
... | true |
Other | chartjs | Chart.js | e3cdd7323a2a0813ac8d544f71410b2a2d452e4e.json | Move niceNum to helpers.math, cleanup IE fallbacks (#8570) | src/helpers/helpers.math.js | @@ -1,5 +1,10 @@
import {isFinite as isFiniteNumber} from './helpers.core';
+/**
+ * @alias Chart.helpers.math
+ * @namespace
+ */
+
export const PI = Math.PI;
export const TAU = 2 * PI;
export const PITAU = TAU + PI;
@@ -9,10 +14,19 @@ export const HALF_PI = PI / 2;
export const QUARTER_PI = PI / 4;
export con... | true |
Other | chartjs | Chart.js | e3cdd7323a2a0813ac8d544f71410b2a2d452e4e.json | Move niceNum to helpers.math, cleanup IE fallbacks (#8570) | src/scales/scale.linearbase.js | @@ -1,30 +1,8 @@
import {isNullOrUndef} from '../helpers/helpers.core';
-import {almostEquals, almostWhole, log10, _decimalPlaces, _setMinAndMaxByKey, sign} from '../helpers/helpers.math';
+import {almostEquals, almostWhole, niceNum, _decimalPlaces, _setMinAndMaxByKey, sign} from '../helpers/helpers.math';
import Sca... | true |
Other | chartjs | Chart.js | 118cff7cfc7f4a856b99415901a824aa69bca321.json | Remove distribution option from fixtures (#8559) | test/fixtures/scale.time/bar-large-gap-between-data.js | @@ -36,7 +36,6 @@ module.exports = {
x: {
display: false,
type: 'time',
- distribution: 'linear',
ticks: {
source: 'auto'
}, | true |
Other | chartjs | Chart.js | 118cff7cfc7f4a856b99415901a824aa69bca321.json | Remove distribution option from fixtures (#8559) | test/fixtures/scale.time/source-auto-linear.js | @@ -16,8 +16,7 @@ module.exports = {
},
ticks: {
source: 'auto'
- },
- distribution: 'linear'
+ }
},
y: {
display: false | true |
Other | chartjs | Chart.js | 118cff7cfc7f4a856b99415901a824aa69bca321.json | Remove distribution option from fixtures (#8559) | test/fixtures/scale.time/source-data-linear.js | @@ -16,8 +16,7 @@ module.exports = {
},
ticks: {
source: 'data'
- },
- distribution: 'linear'
+ }
},
y: {
display: false | true |
Other | chartjs | Chart.js | 118cff7cfc7f4a856b99415901a824aa69bca321.json | Remove distribution option from fixtures (#8559) | test/fixtures/scale.time/source-labels-linear-offset-min-max.js | @@ -18,8 +18,7 @@ module.exports = {
},
ticks: {
source: 'labels'
- },
- distribution: 'linear'
+ }
},
y: {
display: false | true |
Other | chartjs | Chart.js | 118cff7cfc7f4a856b99415901a824aa69bca321.json | Remove distribution option from fixtures (#8559) | test/fixtures/scale.time/source-labels-linear.js | @@ -16,8 +16,7 @@ module.exports = {
},
ticks: {
source: 'labels'
- },
- distribution: 'linear'
+ }
},
y: {
display: false | true |
Other | chartjs | Chart.js | 118cff7cfc7f4a856b99415901a824aa69bca321.json | Remove distribution option from fixtures (#8559) | test/fixtures/scale.time/ticks-reverse-linear-min-max.js | @@ -15,7 +15,6 @@ module.exports = {
time: {
parser: 'YYYY'
},
- distribution: 'linear',
reverse: true,
ticks: {
source: 'labels' | true |
Other | chartjs | Chart.js | 118cff7cfc7f4a856b99415901a824aa69bca321.json | Remove distribution option from fixtures (#8559) | test/fixtures/scale.time/ticks-reverse-linear.js | @@ -13,7 +13,6 @@ module.exports = {
time: {
parser: 'YYYY'
},
- distribution: 'linear',
reverse: true,
ticks: {
source: 'labels' | true |
Other | chartjs | Chart.js | 118cff7cfc7f4a856b99415901a824aa69bca321.json | Remove distribution option from fixtures (#8559) | test/fixtures/scale.timeseries/normalize.js | @@ -22,7 +22,6 @@ module.exports = {
time: {
parser: 'YYYY'
},
- distribution: 'linear',
ticks: {
source: 'data'
} | true |
Other | chartjs | Chart.js | 78d3d30d5684b26773bb2c46b8a972908e110cf3.json | Add _allKeys descriptor for Object.keys behavior (#8553) | src/core/core.config.js | @@ -316,7 +316,7 @@ export default class Config {
* @param {object[]} scopes
* @param {object} [context]
* @param {string[]} [prefixes]
- * @param {{scriptable: boolean, indexable: boolean}} [descriptorDefaults]
+ * @param {{scriptable: boolean, indexable: boolean, allKeys?: boolean}} [descriptorDefault... | true |
Other | chartjs | Chart.js | 78d3d30d5684b26773bb2c46b8a972908e110cf3.json | Add _allKeys descriptor for Object.keys behavior (#8553) | src/core/core.plugins.js | @@ -166,5 +166,5 @@ function createDescriptors(chart, plugins, options, all) {
function pluginOpts(config, plugin, opts, context) {
const keys = config.pluginScopeKeys(plugin);
const scopes = config.getOptionScopes(opts, keys);
- return config.createResolver(scopes, context, [''], {scriptable: false, indexable:... | true |
Other | chartjs | Chart.js | 78d3d30d5684b26773bb2c46b8a972908e110cf3.json | Add _allKeys descriptor for Object.keys behavior (#8553) | src/helpers/helpers.config.js | @@ -86,7 +86,7 @@ export function _createResolver(scopes, prefixes = [''], rootScopes = scopes, fa
* @param {object} proxy - The Proxy returned by `_createResolver`
* @param {object} context - Context object for scriptable/indexable options
* @param {object} [subProxy] - The proxy provided for scriptable options
... | true |
Other | chartjs | Chart.js | 78d3d30d5684b26773bb2c46b8a972908e110cf3.json | Add _allKeys descriptor for Object.keys behavior (#8553) | test/specs/core.plugin.tests.js | @@ -274,7 +274,8 @@ describe('Chart.plugins', function() {
chart.notifyPlugins('hook');
expect(plugin.hook).toHaveBeenCalled();
- expect(plugin.hook.calls.first().args[2]).toEqualOptions({a: 42});
+ expect(Object.keys(plugin.hook.calls.first().args[2])).toEqual(['a']);
+ expect(plugin.hoo... | true |
Other | chartjs | Chart.js | e2a50b957ec636df795c4be56d8e792a007c6d12.json | Remove empty dependencies block from package.json (#8550) | package.json | @@ -87,6 +87,5 @@
"typedoc": "^0.20.27",
"typescript": "^4.1.5",
"yargs": "^16.2.0"
- },
- "dependencies": {}
+ }
} | false |
Other | chartjs | Chart.js | ae95a8221d0145945c42026def788dda5c171c8f.json | Fix function support on _fallback (#8545) | src/helpers/helpers.config.js | @@ -245,14 +245,15 @@ function resolveFallback(fallback, prop, value) {
return isFunction(fallback) ? fallback(prop, value) : fallback;
}
-const getScope = (key, parent) => key === true ? parent : resolveObjectKey(parent, key);
+const getScope = (key, parent) => key === true ? parent
+ : typeof key === 'string' ... | true |
Other | chartjs | Chart.js | ae95a8221d0145945c42026def788dda5c171c8f.json | Fix function support on _fallback (#8545) | test/specs/helpers.config.tests.js | @@ -128,6 +128,37 @@ describe('Chart.helpers.config', function() {
});
});
+ it('should support _fallback as function', function() {
+ const descriptors = {
+ _fallback: (prop, value) => prop === 'hover' && value.shouldFall && 'interaction',
+ };
+ const defaults = {... | true |
Other | chartjs | Chart.js | aebbb5afff8c330f53568d269e8d3518903fa828.json | fix: allow colors as array (#10075)
* fix: allow colors as array
* Revert "fix: allow colors as array"
This reverts commit 632e2ee917ad58061b4ec39dda5f43f593b0b3c1.
* fix: allow colors as array
* Update types/index.esm.d.ts
Co-authored-by: Jacco van den Berg <39033624+LeeLenaleee@users.noreply.github.co... | types/index.esm.d.ts | @@ -2902,7 +2902,7 @@ export interface TickOptions {
* Color of tick
* @see Defaults.color
*/
- color: Scriptable<Color, ScriptableScaleContext>;
+ color: ScriptableAndArray<Color, ScriptableScaleContext>;
/**
* see Fonts
*/ | false |
Other | chartjs | Chart.js | cc807b22d3dd654ee57afab1e97a5b6f9d7589dc.json | add SubTitle to ts test register (#10117) | types/tests/register.ts | @@ -22,6 +22,7 @@ import {
Filler,
Legend,
Title,
+ SubTitle,
Tooltip
} from '../index.esm';
@@ -48,5 +49,6 @@ Chart.register(
Filler,
Legend,
Title,
+ SubTitle,
Tooltip
); | false |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | docs/charts/doughnut.md | @@ -111,7 +111,7 @@ The doughnut/pie chart allows a number of properties to be specified for each da
| [`circumference`](#general) | `number` | - | - | `undefined`
| [`clip`](#general) | `number`\|`object` | - | - | `undefined`
| [`data`](#data-structure) | `number[]` | - | - | **required**
-| [`hoverBackgroundColor... | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | docs/charts/polar.md | @@ -62,7 +62,7 @@ The following options can be included in a polar area chart dataset to configure
| [`borderWidth`](#styling) | `number` | Yes | Yes | `2`
| [`clip`](#general) | `number`\|`object` | - | - | `undefined`
| [`data`](#data-structure) | `number[]` | - | - | **required**
-| [`hoverBackgroundColor`](#inte... | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | docs/configuration/animations.md | @@ -123,7 +123,7 @@ These keys can be configured in following paths:
* `datasets[type]` - dataset type options
* `overrides[type]` - chart type options
-These paths are valid under `defaults` for global confuguration and `options` for instance configuration.
+These paths are valid under `defaults` for global config... | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | docs/configuration/subtitle.md | @@ -6,7 +6,7 @@ Subtitle is a second title placed under the main title, by default. It has exact
Namespace: `options.plugins.subtitle`. The global defaults for subtitle are configured in `Chart.defaults.plugins.subtitle`.
-Excactly the same configuration options with [title](./title.md) are available for subtitle,... | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | docs/getting-started/v3-migration.md | @@ -75,7 +75,7 @@ A number of changes were made to the configuration options passed to the `Chart`
* Polar area `startAngle` option is now consistent with `Radar`, 0 is at top and value is in degrees. Default is changed from `-½π` to `0`.
* Doughnut `rotation` option is now in degrees and 0 is at top. Default is cha... | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | docs/samples/information.md | @@ -2,10 +2,10 @@
## Out of the box working samples
These samples are made for demonstration purposes only. They won't work out of the box if you copy paste them into your own website. This is because of how the docs are getting built. Some boilerplate code gets hidden.
-For a sample that can be copyed and pasted a... | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | src/helpers/helpers.config.js | @@ -203,7 +203,7 @@ function _resolveWithContext(target, prop, receiver) {
value = _resolveArray(prop, value, target, descriptors.isIndexable);
}
if (needsSubResolver(prop, value)) {
- // if the resolved value is an object, crate a sub resolver for it
+ // if the resolved value is an object, create a s... | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | src/helpers/helpers.extras.js | @@ -17,7 +17,7 @@ export const requestAnimFrame = (function() {
/**
* Throttles calling `fn` once per animation frame
- * Latest argments are used on the actual call
+ * Latest arguments are used on the actual call
* @param {function} fn
* @param {*} thisArg
* @param {function} [updateFn] | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | src/plugins/plugin.tooltip.js | @@ -1013,7 +1013,7 @@ export class Tooltip extends Element {
* Handle an event
* @param {ChartEvent} e - The event to handle
* @param {boolean} [replay] - This is a replayed event (from update)
- * @param {boolean} [inChartArea] - The event is indide chartArea
+ * @param {boolean} [inChartArea] - The event ... | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | test/specs/controller.line.tests.js | @@ -603,7 +603,7 @@ describe('Chart.controllers.line', function() {
expect(options.cubicInterpolationMode).toBe('monotone');
});
- it('should be overriden by user-supplied values', function() {
+ it('should be overridden by user-supplied values', function() {
Chart.helpers.merge(Chart.default... | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | test/specs/core.animations.tests.js | @@ -44,7 +44,7 @@ describe('Chart.animations', function() {
})).toBeUndefined();
});
- it('should assing options directly, if target does not have previous options', function() {
+ it('should assign options directly, if target does not have previous options', function() {
const chart = {};
const a... | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | test/specs/core.controller.tests.js | @@ -252,7 +252,7 @@ describe('Chart', function() {
expect(chart.options.hover).toBeFalse();
});
- it('when options.interation=false and options.hover is not defined', function() {
+ it('when options.interaction=false and options.hover is not defined', function() {
var chart = acquir... | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | test/specs/helpers.interpolation.tests.js | @@ -7,7 +7,7 @@ describe('helpers.interpolation', function() {
expect(_pointInLine({x: 10, y: 10}, {x: 20, y: 20}, 1)).toEqual({x: 20, y: 20});
});
- it('Should intepolate a point in stepped line', function() {
+ it('Should interpolate a point in stepped line', function() {
expect(_steppedInterpolation... | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | test/specs/scale.time.tests.js | @@ -286,7 +286,7 @@ describe('Time scale tests', function() {
it('should have ticks with accurate labels', function() {
var scale = this.scale;
var ticks = scale.getTicks();
- // pixelsPerTick is an aproximation which assumes same number of milliseconds per year (not true)
+ // pixelsPerTic... | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | types/helpers/helpers.extras.d.ts | @@ -7,7 +7,7 @@ export function requestAnimFrame(cb: () => void): void;
/**
* Throttles calling `fn` once per animation frame
- * Latest argments are used on the actual call
+ * Latest arguments are used on the actual call
* @param {function} fn
* @param {*} thisArg
* @param {function} [updateFn] | true |
Other | chartjs | Chart.js | a7d98fb1a0c0496cf87705351eb5995fd0e950af.json | Fix typos found by codespell (#10103) | types/index.esm.d.ts | @@ -927,7 +927,7 @@ export interface Plugin<TType extends ChartType = ChartType, O = AnyObject> exte
*/
afterDataLimits?(chart: Chart, args: { scale: Scale }, options: O): void;
/**
- * @desc Called before scale bulds its ticks. This hook is called separately for each scale in the chart.
+ * @desc Called ... | true |
Other | chartjs | Chart.js | 4d918f5afa6f3392201761c4c299bbe093bb96e8.json | add typing and docs for maxTicksLimit all scales (#10057)
* add typing and docs for maxTicksLimit time scale
* change maxTicksLimit to base instead of each scale seperatly since its done in the core.scale | docs/axes/cartesian/_common_ticks.md | @@ -15,3 +15,4 @@ Namespace: `options.scales[scaleId].ticks`
| `minRotation` | `number` | `0` | Minimum rotation for tick labels. *Note: Only applicable to horizontal scales.*
| `mirror` | `boolean` | `false` | Flips tick labels around axis, displaying the labels inside the chart instead of outside. *Note: Only appli... | true |
Other | chartjs | Chart.js | 4d918f5afa6f3392201761c4c299bbe093bb96e8.json | add typing and docs for maxTicksLimit all scales (#10057)
* add typing and docs for maxTicksLimit time scale
* change maxTicksLimit to base instead of each scale seperatly since its done in the core.scale | docs/axes/cartesian/linear.md | @@ -27,7 +27,6 @@ Namespace: `options.scales[scaleId].ticks`
| ---- | ---- | ------- | ------- | -----------
| `count` | `number` | Yes | `undefined` | The number of ticks to generate. If specified, this overrides the automatic generation.
| `format` | `object` | Yes | | The [`Intl.NumberFormat`](https://developer.m... | true |
Other | chartjs | Chart.js | 4d918f5afa6f3392201761c4c299bbe093bb96e8.json | add typing and docs for maxTicksLimit all scales (#10057)
* add typing and docs for maxTicksLimit time scale
* change maxTicksLimit to base instead of each scale seperatly since its done in the core.scale | types/index.esm.d.ts | @@ -3078,6 +3078,11 @@ export interface CartesianScaleOptions extends CoreScaleOptions {
* @default 0
*/
padding: number;
+ /**
+ * Maximum number of ticks and gridlines to show.
+ * @default 11
+ */
+ maxTicksLimit: number;
};
}
@@ -3120,11 +3125,6 @@ export type LinearScaleOpt... | true |
Other | chartjs | Chart.js | 51b051f766c309fd04fbd94556ec5c738c6d153f.json | Improve issue templates (#10038)
* Make issue templates fancier
* should be valid yml now
* remove title field
* remove reproducable sample for docs
* add example back to docs, change link for plugin and add TS link for TS issues
* wrong labels, forgot type: in front of it
* implement feedback
* g... | .github/ISSUE_TEMPLATE/BUG.md | @@ -1,50 +0,0 @@
----
-name: Bug Report
-about: Something went awry
-labels: 'type: bug'
----
-
-<!--
- Need help or support? Please don't open an issue!
- Head to https://stackoverflow.com/questions/tagged/chart.js
-
- Bug reports MUST be submitted with an interactive example:
- https://codepen.io/pen?template=Bap... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.