language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
chartjs
Chart.js
52b9793ba0c5155e599b5e03e1d66638ad68de04.json
Use HTTPS instead of HTTP for URLs supporting it
src/platforms/platform.dom.js
@@ -305,7 +305,7 @@ function removeResizeListener(node) { } function injectCSS(platform, css) { - // http://stackoverflow.com/q/3922139 + // https://stackoverflow.com/q/3922139 var style = platform._style || document.createElement('style'); if (!platform._style) { platform._style = style;
true
Other
chartjs
Chart.js
52b9793ba0c5155e599b5e03e1d66638ad68de04.json
Use HTTPS instead of HTTP for URLs supporting it
src/scales/scale.linearbase.js
@@ -12,7 +12,7 @@ var Scale = require('../core/core.scale'); function generateTicks(generationOptions, dataRange) { var ticks = []; // To get a "nice" value for the tick spacing, we will use the appropriately named - // "nice number" algorithm. See http://stackoverflow.com/questions/8506881/nice-label-algorithm-fo...
true
Other
chartjs
Chart.js
52b9793ba0c5155e599b5e03e1d66638ad68de04.json
Use HTTPS instead of HTTP for URLs supporting it
src/scales/scale.time.js
@@ -130,7 +130,7 @@ function buildLookupTable(timestamps, min, max, distribution) { return table; } -// @see adapted from http://www.anujgakhar.com/2014/03/01/binary-search-in-javascript/ +// @see adapted from https://www.anujgakhar.com/2014/03/01/binary-search-in-javascript/ function lookup(table, key, value) { ...
true
Other
chartjs
Chart.js
52b9793ba0c5155e599b5e03e1d66638ad68de04.json
Use HTTPS instead of HTTP for URLs supporting it
test/.eslintrc.yml
@@ -7,7 +7,7 @@ globals: moment: true waitForResize: true -# http://eslint.org/docs/rules/ +# https://eslint.org/docs/rules/ rules: # Best Practices complexity: 0
true
Other
chartjs
Chart.js
52b9793ba0c5155e599b5e03e1d66638ad68de04.json
Use HTTPS instead of HTTP for URLs supporting it
test/context.js
@@ -1,4 +1,4 @@ -// Code from http://stackoverflow.com/questions/4406864/html-canvas-unit-testing +// Code from https://stackoverflow.com/questions/4406864/html-canvas-unit-testing var Context = function() { this._calls = []; // names/args of recorded calls this._initMethods();
true
Other
chartjs
Chart.js
52b9793ba0c5155e599b5e03e1d66638ad68de04.json
Use HTTPS instead of HTTP for URLs supporting it
test/specs/core.layouts.tests.js
@@ -11,7 +11,7 @@ describe('Chart.layouts', function() { // Disable tests which need to be rewritten based on changes introduced by // the following changes: https://github.com/chartjs/Chart.js/pull/2346 - // using xit marks the test as pending: http://jasmine.github.io/2.0/introduction.html#section-Pending_Specs...
true
Other
chartjs
Chart.js
52b9793ba0c5155e599b5e03e1d66638ad68de04.json
Use HTTPS instead of HTTP for URLs supporting it
test/specs/plugin.legend.tests.js
@@ -217,7 +217,7 @@ describe('Legend block tests', function() { // NOTE(SB) We should get ride of the following tests and use image diff instead. // For now, as discussed with Evert Timberg, simply comment out. - // See http://humblesoftware.github.io/js-imagediff/test.html + // See https://humblesoftware.git...
true
Other
chartjs
Chart.js
52b9793ba0c5155e599b5e03e1d66638ad68de04.json
Use HTTPS instead of HTTP for URLs supporting it
test/utils.js
@@ -85,7 +85,7 @@ function releaseChart(chart) { } function injectCSS(css) { - // http://stackoverflow.com/q/3922139 + // https://stackoverflow.com/q/3922139 var head = document.getElementsByTagName('head')[0]; var style = document.createElement('style'); style.setAttribute('type', 'text/css');
true
Other
chartjs
Chart.js
3a29b99e3b24e4d7dbfcb22df5e1f98ba9a0be4b.json
Use HTTPS in documentation links where possible (#5915)
docs/README.md
@@ -58,8 +58,8 @@ var myChart = new Chart(ctx, { Before submitting an issue or a pull request to the project, please take a moment to look over the [contributing guidelines](https://github.com/chartjs/Chart.js/blob/master/docs/developers/contributing.md) first. -For support using Chart.js, please post questions wi...
true
Other
chartjs
Chart.js
3a29b99e3b24e4d7dbfcb22df5e1f98ba9a0be4b.json
Use HTTPS in documentation links where possible (#5915)
docs/axes/cartesian/time.md
@@ -19,7 +19,7 @@ The x-axis data points may additionally be specified via the `t` or `x` attribut ### Date Formats -When providing data for the time scale, Chart.js supports all of the formats that Moment.js accepts. See [Moment.js docs](http://momentjs.com/docs/#/parsing/) for details. +When providing data for t...
true
Other
chartjs
Chart.js
3a29b99e3b24e4d7dbfcb22df5e1f98ba9a0be4b.json
Use HTTPS in documentation links where possible (#5915)
docs/charts/line.md
@@ -162,7 +162,7 @@ When charting a lot of data, the chart render time may start to get quite large. Decimating your data will achieve the best results. When there is a lot of data to display on the graph, it doesn't make sense to show tens of thousands of data points on a graph that is only a few hundred pixels wid...
true
Other
chartjs
Chart.js
3a29b99e3b24e4d7dbfcb22df5e1f98ba9a0be4b.json
Use HTTPS in documentation links where possible (#5915)
docs/configuration/tooltip.md
@@ -269,7 +269,7 @@ var myPieChart = new Chart(ctx, { }); ``` -See [samples](http://www.chartjs.org/samples/) for examples on how to get started with custom tooltips. +See [samples](https://www.chartjs.org/samples/) for examples on how to get started with custom tooltips. ## Tooltip Model The tooltip model cont...
true
Other
chartjs
Chart.js
3a29b99e3b24e4d7dbfcb22df5e1f98ba9a0be4b.json
Use HTTPS in documentation links where possible (#5915)
docs/developers/README.md
@@ -6,15 +6,15 @@ Developer features allow extending and enhancing Chart.js in many different ways Latest documentation and samples, including unreleased features, are available at: - - http://www.chartjs.org/docs/master/ - - http://www.chartjs.org/samples/master/ + - https://www.chartjs.org/docs/master/ + - https...
true
Other
chartjs
Chart.js
3a29b99e3b24e4d7dbfcb22df5e1f98ba9a0be4b.json
Use HTTPS in documentation links where possible (#5915)
docs/developers/contributing.md
@@ -16,7 +16,7 @@ New contributions to the library are welcome, but we ask that you please follow # Building and Testing -Chart.js uses <a href="http://gulpjs.com/" target="_blank">gulp</a> to build the library into a single JavaScript file. +Chart.js uses <a href="https://gulpjs.com/" target="_blank">gulp</a> to ...
true
Other
chartjs
Chart.js
3a29b99e3b24e4d7dbfcb22df5e1f98ba9a0be4b.json
Use HTTPS in documentation links where possible (#5915)
docs/getting-started/installation.md
@@ -27,7 +27,7 @@ https://cdnjs.com/libraries/Chart.js ### jsDelivr [![jsdelivr](https://img.shields.io/npm/v/chart.js.svg?label=jsdelivr&style=flat-square&maxAge=600)](https://cdn.jsdelivr.net/npm/chart.js@latest/dist/) [![jsdelivr hits](https://data.jsdelivr.com/v1/package/npm/chart.js/badge)](https://www.jsdelivr....
true
Other
chartjs
Chart.js
3a29b99e3b24e4d7dbfcb22df5e1f98ba9a0be4b.json
Use HTTPS in documentation links where possible (#5915)
docs/notes/license.md
@@ -1,3 +1,3 @@ # License -Chart.js is <a href="https://github.com/chartjs/Chart.js" target="_blank">open source</a> and available under the <a href="http://opensource.org/licenses/MIT" target="_blank">MIT license</a>. \ No newline at end of file +Chart.js is <a href="https://github.com/chartjs/Chart.js" target="_bl...
true
Other
chartjs
Chart.js
69fcba029b32fd2a290f6356cd857b8c2d6809e3.json
Remove autoSkip logic to always display last tick (#5891) This changes the behavior of `autoSkip` so that it does not force the display of the last tick. If the last tick can be displayed with equal spacing to the rest of the ticks, it will be. Otherwise, it is not.
src/core/core.scale.js
@@ -644,7 +644,7 @@ module.exports = Element.extend({ var cosRotation = Math.cos(labelRotationRadians); var longestRotatedLabel = me.longestLabelWidth * cosRotation; var result = []; - var i, tick, shouldSkip; + var i, tick; // figure out the maximum number of gridlines to show var maxTicks; @@ -669,...
true
Other
chartjs
Chart.js
69fcba029b32fd2a290f6356cd857b8c2d6809e3.json
Remove autoSkip logic to always display last tick (#5891) This changes the behavior of `autoSkip` so that it does not force the display of the last tick. If the last tick can be displayed with equal spacing to the rest of the ticks, it will be. Otherwise, it is not.
test/specs/core.scale.tests.js
@@ -20,6 +20,60 @@ describe('Core.scale', function() { }); }); + describe('displaying xAxis ticks with autoSkip=true', function() { + function getChart(data) { + return window.acquireChart({ + type: 'line', + data: data, + options: { + scales: { + xAxes: [{ + ticks: { + autoSkip...
true
Other
chartjs
Chart.js
bfa635e55d6e494d9d032729c1475d6339e61d21.json
Fix docs about bar chart indexable options (#5876)
docs/charts/bar.md
@@ -73,9 +73,9 @@ the color of the bars is generally set this way. | [`borderSkipped`](#borderskipped) | `String` | Yes | Yes | `'bottom'` | [`borderWidth`](#styling) | `Number` | Yes | Yes | `0` | [`data`](#data-structure) | `Object[]` | - | - | **required** -| [`hoverBackgroundColor`](#interactions) | [`Color`](.....
false
Other
chartjs
Chart.js
3cb2d7050e0976f92383beb48bee07e5d579a2c0.json
Remove gulp-connect and add jsdelivr/unpkg paths (#5875)
.travis.yml
@@ -1,6 +1,6 @@ language: node_js node_js: - - "6" + - lts/* before_install: - "export CHROME_BIN=/usr/bin/google-chrome"
true
Other
chartjs
Chart.js
3cb2d7050e0976f92383beb48bee07e5d579a2c0.json
Remove gulp-connect and add jsdelivr/unpkg paths (#5875)
gulpfile.js
@@ -1,6 +1,5 @@ var gulp = require('gulp'); var concat = require('gulp-concat'); -var connect = require('gulp-connect'); var eslint = require('gulp-eslint'); var file = require('gulp-file'); var insert = require('gulp-insert'); @@ -26,7 +25,7 @@ var argv = yargs .option('force-output', {default: false}) .opt...
true
Other
chartjs
Chart.js
3cb2d7050e0976f92383beb48bee07e5d579a2c0.json
Remove gulp-connect and add jsdelivr/unpkg paths (#5875)
package.json
@@ -1,14 +1,27 @@ { "name": "chart.js", - "homepage": "http://www.chartjs.org", + "homepage": "https://www.chartjs.org", "description": "Simple HTML5 charts using the canvas element.", "version": "2.7.3", "license": "MIT", + "jsdelivr": "dist/Chart.min.js", + "unpkg": "dist/Chart.min.js", "main": "s...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
src/chart.js
@@ -10,6 +10,8 @@ require('./core/core.helpers')(Chart); Chart.Animation = require('./core/core.animation'); Chart.animationService = require('./core/core.animations'); +Chart.controllers = require('./controllers/index'); +Chart.DatasetController = require('./core/core.datasetController'); Chart.defaults = require...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
src/controllers/controller.bar.js
@@ -1,5 +1,6 @@ 'use strict'; +var DatasetController = require('../core/core.datasetController'); var defaults = require('../core/core.defaults'); var elements = require('../elements/index'); var helpers = require('../helpers/index'); @@ -12,15 +13,9 @@ defaults._set('bar', { scales: { xAxes: [{ type: 'c...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
src/controllers/controller.bubble.js
@@ -1,5 +1,6 @@ 'use strict'; +var DatasetController = require('../core/core.datasetController'); var defaults = require('../core/core.defaults'); var elements = require('../elements/index'); var helpers = require('../helpers/index'); @@ -37,140 +38,136 @@ defaults._set('bubble', { } }); +module.exports = Da...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
src/controllers/controller.doughnut.js
@@ -1,5 +1,6 @@ 'use strict'; +var DatasetController = require('../core/core.datasetController'); var defaults = require('../core/core.defaults'); var elements = require('../elements/index'); var helpers = require('../helpers/index'); @@ -118,184 +119,176 @@ defaults._set('doughnut', { } }); -defaults._set('...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
src/controllers/controller.horizontalBar.js
@@ -0,0 +1,79 @@ + +'use strict'; + +var BarController = require('./controller.bar'); +var defaults = require('../core/core.defaults'); + +defaults._set('horizontalBar', { + hover: { + mode: 'index', + axis: 'y' + }, + + scales: { + xAxes: [{ + type: 'linear', + position: 'bottom' + }], + + yAxes: [{ + type:...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
src/controllers/controller.line.js
@@ -1,5 +1,6 @@ 'use strict'; +var DatasetController = require('../core/core.datasetController'); var defaults = require('../core/core.defaults'); var elements = require('../elements/index'); var helpers = require('../helpers/index'); @@ -24,321 +25,318 @@ defaults._set('line', { } }); -module.exports = func...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
src/controllers/controller.pie.js
@@ -0,0 +1,13 @@ +'use strict'; + +var DoughnutController = require('./controller.doughnut'); +var defaults = require('../core/core.defaults'); +var helpers = require('../helpers/index'); + +defaults._set('pie', helpers.clone(defaults.doughnut)); +defaults._set('pie', { + cutoutPercentage: 0 +}); + +// Pie charts are D...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
src/controllers/controller.polarArea.js
@@ -1,5 +1,6 @@ 'use strict'; +var DatasetController = require('../core/core.datasetController'); var defaults = require('../core/core.defaults'); var elements = require('../elements/index'); var helpers = require('../helpers/index'); @@ -108,148 +109,145 @@ defaults._set('polarArea', { } }); -module.exports...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
src/controllers/controller.radar.js
@@ -1,5 +1,6 @@ 'use strict'; +var DatasetController = require('../core/core.datasetController'); var defaults = require('../core/core.defaults'); var elements = require('../elements/index'); var helpers = require('../helpers/index'); @@ -15,158 +16,157 @@ defaults._set('radar', { } }); -module.exports = fun...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
src/controllers/controller.scatter.js
@@ -1,5 +1,6 @@ 'use strict'; +var LineController = require('./controller.line'); var defaults = require('../core/core.defaults'); defaults._set('scatter', { @@ -34,9 +35,5 @@ defaults._set('scatter', { } }); -module.exports = function(Chart) { - - // Scatter charts use line controllers - Chart.controllers....
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
src/controllers/index.js
@@ -0,0 +1,18 @@ +'use strict'; + +// NOTE export a map in which the key represents the controller type, not +// the class, and so must be CamelCase in order to be correctly retrieved +// by the controller in core.controller.js (`controllers[meta.type]`). + +/* eslint-disable global-require */ +module.exports = { + bar...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
src/core/core.controller.js
@@ -2,6 +2,7 @@ var Animation = require('./core.animation'); var animations = require('./core.animations'); +var controllers = require('../controllers/index'); var defaults = require('./core.defaults'); var helpers = require('../helpers/index'); var Interaction = require('./core.interaction'); @@ -20,9 +21,6 @@ ...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
src/core/core.datasetController.js
@@ -2,328 +2,325 @@ var helpers = require('../helpers/index'); -module.exports = function(Chart) { - - var arrayEvents = ['push', 'pop', 'shift', 'splice', 'unshift']; +var arrayEvents = ['push', 'pop', 'shift', 'splice', 'unshift']; + +/** + * Hooks the array methods that add or remove values ('push', pop', 'shif...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
test/specs/controller.bar.tests.js
@@ -1,6 +1,11 @@ describe('Chart.controllers.bar', function() { describe('auto', jasmine.fixture.specs('controller.bar')); + it('should be registered as dataset controller', function() { + expect(typeof Chart.controllers.bar).toBe('function'); + expect(typeof Chart.controllers.horizontalBar).toBe('function'); + ...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
test/specs/controller.bubble.tests.js
@@ -1,6 +1,10 @@ describe('Chart.controllers.bubble', function() { describe('auto', jasmine.fixture.specs('controller.bubble')); + it('should be registered as dataset controller', function() { + expect(typeof Chart.controllers.bubble).toBe('function'); + }); + it('should be constructed', function() { var cha...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
test/specs/controller.doughnut.tests.js
@@ -1,4 +1,9 @@ describe('Chart.controllers.doughnut', function() { + it('should be registered as dataset controller', function() { + expect(typeof Chart.controllers.doughnut).toBe('function'); + expect(Chart.controllers.doughnut).toBe(Chart.controllers.pie); + }); + it('should be constructed', function() { var...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
test/specs/controller.line.tests.js
@@ -1,6 +1,10 @@ describe('Chart.controllers.line', function() { describe('auto', jasmine.fixture.specs('controller.line')); + it('should be registered as dataset controller', function() { + expect(typeof Chart.controllers.line).toBe('function'); + }); + it('should be constructed', function() { var chart = w...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
test/specs/controller.polarArea.tests.js
@@ -1,6 +1,10 @@ -describe('auto', jasmine.fixture.specs('controller.polarArea')); - describe('Chart.controllers.polarArea', function() { + describe('auto', jasmine.fixture.specs('controller.polarArea')); + + it('should be registered as dataset controller', function() { + expect(typeof Chart.controllers.polarArea).to...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
test/specs/controller.radar.tests.js
@@ -1,6 +1,10 @@ describe('Chart.controllers.radar', function() { describe('auto', jasmine.fixture.specs('controller.radar')); + it('should be registered as dataset controller', function() { + expect(typeof Chart.controllers.radar).toBe('function'); + }); + it('Should be constructed', function() { var chart ...
true
Other
chartjs
Chart.js
be8d78a900b560a1dbd465a29736063e4e8fa4ef.json
Make Chart.controllers.* importable (#5871) `controllers.*.js` and `core.datasetController.js` are now importable (no more function export), that's why there is so many changes mainly due to one indentation level removed. Split code for `bar/horizontalBar` and `doughnut/pie` in separate files, added a global controlle...
test/specs/controller.scatter.test.js
@@ -1,4 +1,8 @@ describe('Chart.controllers.scatter', function() { + it('should be registered as dataset controller', function() { + expect(typeof Chart.controllers.scatter).toBe('function'); + }); + describe('showLines option', function() { it('should not draw a line if undefined', function() { var chart = ...
true
Other
chartjs
Chart.js
f6d9a39cb8e8661e1d6a733d4b77fb3f3238935a.json
Fix axis line width when option is an array (#5751) When the axis lineWidth setting is set to an array, use the first item when determining the size of the axis area.
src/core/core.scale.js
@@ -708,7 +708,7 @@ module.exports = Element.extend({ var itemsToDraw = []; - var axisWidth = me.options.gridLines.lineWidth; + var axisWidth = helpers.valueAtIndexOrDefault(me.options.gridLines.lineWidth, 0); var xTickStart = options.position === 'right' ? me.left : me.right - axisWidth - tl; var xTickE...
false
Other
chartjs
Chart.js
75aa44eef677b790768262638df0de223fd01a56.json
Upgrade dev dependencies to reduce vulnerabilities (#5840)
gulpfile.js
@@ -49,19 +49,19 @@ gulp.task('bower', bowerTask); gulp.task('build', buildTask); gulp.task('package', packageTask); gulp.task('watch', watchTask); -gulp.task('lint', ['lint-html', 'lint-js']); gulp.task('lint-html', lintHtmlTask); gulp.task('lint-js', lintJsTask); +gulp.task('lint', gulp.parallel('lint-html', 'li...
true
Other
chartjs
Chart.js
75aa44eef677b790768262638df0de223fd01a56.json
Upgrade dev dependencies to reduce vulnerabilities (#5840)
package.json
@@ -10,42 +10,42 @@ "url": "https://github.com/chartjs/Chart.js.git" }, "devDependencies": { - "browserify": "^14.5.0", + "browserify": "^16.2.3", "browserify-istanbul": "^3.0.1", "bundle-collapser": "^1.3.0", "child-process-promise": "^2.2.1", "coveralls": "^3.0.0", - "eslint": ...
true
Other
chartjs
Chart.js
75aa44eef677b790768262638df0de223fd01a56.json
Upgrade dev dependencies to reduce vulnerabilities (#5840)
src/platforms/platform.dom.js
@@ -108,6 +108,7 @@ var supportsEventListenerOptions = (function() { var supports = false; try { var options = Object.defineProperty({}, 'passive', { + // eslint-disable-next-line getter-return get: function() { supports = true; } @@ -391,6 +392,7 @@ module.exports = { // we can't use save() an...
true
Other
chartjs
Chart.js
75aa44eef677b790768262638df0de223fd01a56.json
Upgrade dev dependencies to reduce vulnerabilities (#5840)
test/specs/core.controller.tests.js
@@ -949,25 +949,13 @@ describe('Chart', function() { var meta = chart.getDatasetMeta(0); var point = meta.data[1]; - var node = chart.canvas; - var rect = node.getBoundingClientRect(); - - var evt = new MouseEvent('mousemove', { - view: window, - bubbles: true, - cancelable: true, - clientX:...
true
Other
chartjs
Chart.js
75aa44eef677b790768262638df0de223fd01a56.json
Upgrade dev dependencies to reduce vulnerabilities (#5840)
test/specs/core.plugin.tests.js
@@ -323,6 +323,8 @@ describe('Chart.plugins', function() { expect(plugin.hook).toHaveBeenCalled(); expect(plugin.hook.calls.first().args[1]).toEqual({a: 42}); + + delete Chart.defaults.global.plugins.a; });
true
Other
chartjs
Chart.js
3ea93a09f2047b727891f9e13dbd3fb7ebe44adf.json
Add regression test for legend layout issue (#5776)
test/specs/plugin.legend.tests.js
@@ -525,6 +525,43 @@ describe('Legend block tests', function() { }); }); + it('should not draw legend items outside of the chart bounds', function() { + var chart = window.acquireChart( + { + type: 'line', + data: { + datasets: [1, 2, 3].map(function(n) { + return { + label: 'dataset' + n...
false
Other
chartjs
Chart.js
637c2176ecad70b674ffe8802bde070136785a45.json
Support decimal stepSize (#5786)
src/core/core.helpers.js
@@ -174,6 +174,26 @@ module.exports = function() { helpers.toDegrees = function(radians) { return radians * (180 / Math.PI); }; + + /** + * Returns the number of decimal places + * i.e. the number of digits after the decimal point, of the value of this Number. + * @param {Number} x - A number. + * @returns {...
true
Other
chartjs
Chart.js
637c2176ecad70b674ffe8802bde070136785a45.json
Support decimal stepSize (#5786)
src/scales/scale.linearbase.js
@@ -15,54 +15,55 @@ function generateTicks(generationOptions, dataRange) { // "nice number" algorithm. See http://stackoverflow.com/questions/8506881/nice-label-algorithm-for-charts-with-minimum-ticks // for details. - var factor; - var precision; - var spacing; + var stepSize = generationOptions.stepSize; + var ...
true
Other
chartjs
Chart.js
637c2176ecad70b674ffe8802bde070136785a45.json
Support decimal stepSize (#5786)
test/specs/core.helpers.tests.js
@@ -238,6 +238,17 @@ describe('Core helper tests', function() { expect(helpers.toDegrees(Math.PI * 3 / 2)).toBe(270); }); + it('should get the correct number of decimal places', function() { + expect(helpers.decimalPlaces(100)).toBe(0); + expect(helpers.decimalPlaces(1)).toBe(0); + expect(helpers.decimalPlace...
true
Other
chartjs
Chart.js
637c2176ecad70b674ffe8802bde070136785a45.json
Support decimal stepSize (#5786)
test/specs/scale.linear.tests.js
@@ -573,6 +573,35 @@ describe('Linear Scale', function() { expect(chart.scales.yScale0.ticks).toEqual(['11', '9', '7', '5', '3', '1']); }); + it('Should create decimal steps if stepSize is a decimal number', function() { + var chart = window.acquireChart({ + type: 'bar', + data: { + datasets: [{ + yA...
true
Other
chartjs
Chart.js
7e62913cfc2f97b33545cb5ffca4845aa8cd6d55.json
Change .editorconfig to include final newlines (#5827)
.editorconfig
@@ -7,7 +7,7 @@ indent_size = 4 end_of_line = lf charset = utf-8 trim_trailing_whitespace = true -insert_final_newline = false +insert_final_newline = true [gulpfile.js] indent_style = space
false
Other
chartjs
Chart.js
1ba06a26fddde17285072f3a446679e9388b382f.json
Add aspectRatio property to responsive doc (#5756)
docs/general/responsive.md
@@ -16,6 +16,7 @@ Chart.js provides a [few options](#configuration-options) to enable responsivene | `responsive` | `Boolean` | `true` | Resizes the chart canvas when its container does ([important note...](#important-note)). | `responsiveAnimationDuration` | `Number` | `0` | Duration in milliseconds it takes to anim...
false
Other
chartjs
Chart.js
9293c30d4f5727c4f64967d709f37f44d43b716f.json
Add scatter link in charts documentation (#5736)
docs/charts/README.md
@@ -4,9 +4,10 @@ Chart.js comes with built-in chart types: * [line](./line.md) * [bar](./bar.md) * [radar](./radar.md) -* [polar area](./polar.md) * [doughnut and pie](./doughnut.md) +* [polar area](./polar.md) * [bubble](./bubble.md) +* [scatter](./scatter.md) [Area charts](area.md) can be built from a line or...
false
Other
chartjs
Chart.js
a9c4e377a7f529a82fc1dbcef32ab23d40c9b158.json
Add color to financial time series sample (#5661)
samples/scales/time/financial.html
@@ -56,12 +56,16 @@ var ctx = document.getElementById('chart1').getContext('2d'); ctx.canvas.width = 1000; ctx.canvas.height = 300; + + var color = Chart.helpers.color; var cfg = { type: 'bar', data: { labels: labels, datasets: [{ label: 'CHRT - Chart.js Corporation', + backgrou...
false
Other
chartjs
Chart.js
9a295816b3ed406ff34d078746d8afd94d0b13a2.json
Replace ES6 by Webpack in the integration docs (#5555)
docs/getting-started/integration.md
@@ -2,13 +2,6 @@ Chart.js can be integrated with plain JavaScript or with different module loaders. The examples below show how to load Chart.js in different systems. -## ES6 Modules - -```javascript -import Chart from 'chart.js'; -var myChart = new Chart(ctx, {...}); -``` - ## Script Tag ```html @@ -18,6 +11,...
false
Other
chartjs
Chart.js
246b9a1a40b72e57ba256d679ca6e44f1cd82411.json
Add circular option documentation for grid lines (#5637)
docs/axes/styling.md
@@ -9,6 +9,7 @@ The grid line configuration is nested under the scale configuration in the `grid | Name | Type | Default | Description | -----| ---- | --------| ----------- | `display` | `Boolean` | `true` | If false, do not display grid lines for this axis. +| `circular` | `Boolean` | `false` | If true, gridlines a...
false
Other
chartjs
Chart.js
6dbb7e74462d5b7dedf2124a622a3e678964dd83.json
Move config handling to a dedicated script (#7939) * Split core.config.js out of core.controller.js * Remove side effects from config.js * Turn config into a class * Refactor config merging as includeDefaults
src/core/core.config.js
@@ -0,0 +1,181 @@ +/* eslint-disable import/no-namespace, import/namespace */ +import defaults from './core.defaults'; +import {mergeIf, merge, _merger} from '../helpers/helpers.core'; + +export function getIndexAxis(type, options) { + const typeDefaults = defaults[type] || {}; + const datasetDefaults = typeDefaults.da...
true
Other
chartjs
Chart.js
6dbb7e74462d5b7dedf2124a622a3e678964dd83.json
Move config handling to a dedicated script (#7939) * Split core.config.js out of core.controller.js * Remove side effects from config.js * Turn config into a class * Refactor config merging as includeDefaults
src/core/core.controller.js
@@ -6,8 +6,9 @@ import layouts from './core.layouts'; import {BasicPlatform, DomPlatform} from '../platform'; import PluginService from './core.plugins'; import registry from './core.registry'; +import Config, {determineAxis, getIndexAxis} from './core.config'; import {retinaScale} from '../helpers/helpers.dom'; -i...
true
Other
chartjs
Chart.js
6dbb7e74462d5b7dedf2124a622a3e678964dd83.json
Move config handling to a dedicated script (#7939) * Split core.config.js out of core.controller.js * Remove side effects from config.js * Turn config into a class * Refactor config merging as includeDefaults
src/core/core.plugins.js
@@ -50,7 +50,7 @@ export default class PluginService { return this._cache; } - const config = (chart && chart.config) || {}; + const config = chart && chart.config; const options = (config.options && config.options.plugins) || {}; const plugins = allPlugins(config); const descriptors = createDescrip...
true
Other
chartjs
Chart.js
58d1911d059239b52be8f309f8249f7b4e6dbb95.json
Add args.mode to before/after update plugin hooks (#7949)
docs/docs/getting-started/v3-migration.md
@@ -487,3 +487,8 @@ All helpers are now exposed in a flat hierarchy, e.g., `Chart.helpers.canvas.cli * `Chart.platforms` is an object that contains two usable platform classes, `BasicPlatform` and `DomPlatform`. It also contains `BasePlatform`, a class that all platforms must extend from. * If the canvas passed in is...
true
Other
chartjs
Chart.js
58d1911d059239b52be8f309f8249f7b4e6dbb95.json
Add args.mode to before/after update plugin hooks (#7949)
src/core/core.controller.js
@@ -587,6 +587,7 @@ class Chart { update(mode) { const me = this; + const args = {mode}; let i, ilen; me._updating = true; @@ -600,7 +601,7 @@ class Chart { // https://github.com/chartjs/Chart.js/issues/5111#issuecomment-355934167 me._plugins.invalidate(); - if (me._plugins.notify(me, 'beforeUp...
true
Other
chartjs
Chart.js
58d1911d059239b52be8f309f8249f7b4e6dbb95.json
Add args.mode to before/after update plugin hooks (#7949)
src/core/core.plugins.js
@@ -126,6 +126,8 @@ function createDescriptors(plugins, options) { * @desc Called before updating `chart`. If any plugin returns `false`, the update * is cancelled (and thus subsequent render(s)) until another `update` is triggered. * @param {Chart} chart - The chart instance. + * @param {object} args - The call ...
true
Other
chartjs
Chart.js
58d1911d059239b52be8f309f8249f7b4e6dbb95.json
Add args.mode to before/after update plugin hooks (#7949)
src/plugins/plugin.filler.js
@@ -525,7 +525,7 @@ function doFill(ctx, cfg) { export default { id: 'filler', - afterDatasetsUpdate(chart, options) { + afterDatasetsUpdate(chart, _args, options) { const count = (chart.data.datasets || []).length; const propagate = options.propagate; const sources = [];
true
Other
chartjs
Chart.js
58d1911d059239b52be8f309f8249f7b4e6dbb95.json
Add args.mode to before/after update plugin hooks (#7949)
types/core/index.d.ts
@@ -1,853 +1,859 @@ import { BasePlatform } from '../platform'; import { - Color, - EasingFunction, - IChartArea, - IChartComponent, - IFontSpec, - IPoint, - Scriptable, - TimeUnit, - IEvent, + Color, + EasingFunction, + IChartArea, + IChartComponent, + IFontSpec, + IPoint, + Scriptable, + TimeUnit, + IEvent...
true
Other
chartjs
Chart.js
f5c4f97504b6ae96f8f0592bcc15cebb2dfba8a6.json
Add interaction options (#7922) * Add interaction options * Add migration note
docs/docs/configuration/tooltip.md
@@ -10,8 +10,8 @@ The tooltip configuration is passed into the `options.tooltips` namespace. The g | ---- | ---- | ------- | ----------- | `enabled` | `boolean` | `true` | Are on-canvas tooltips enabled? | `custom` | `function` | `null` | See [custom tooltip](#external-custom-tooltips) section. -| `mode` | `string` ...
true
Other
chartjs
Chart.js
f5c4f97504b6ae96f8f0592bcc15cebb2dfba8a6.json
Add interaction options (#7922) * Add interaction options * Add migration note
docs/docs/general/interactions/index.md
@@ -2,7 +2,7 @@ title: Interactions --- -The hover configuration is passed into the `options.hover` namespace. The global hover configuration is at `Chart.defaults.hover`. To configure which events trigger chart interactions, see [events](./events.md#events). +The interaction configuration is passed into the `optio...
true
Other
chartjs
Chart.js
f5c4f97504b6ae96f8f0592bcc15cebb2dfba8a6.json
Add interaction options (#7922) * Add interaction options * Add migration note
docs/docs/general/interactions/modes.md
@@ -4,6 +4,8 @@ title: Interaction Modes When configuring interaction with the graph via hover or tooltips, a number of different modes are available. +`options.hover` and `options.tooltips` extend from `options.interaction`. So if `mode`, `intersect` or any other common settings are configured only in `options.in...
true
Other
chartjs
Chart.js
f5c4f97504b6ae96f8f0592bcc15cebb2dfba8a6.json
Add interaction options (#7922) * Add interaction options * Add migration note
docs/docs/getting-started/v3-migration.md
@@ -202,6 +202,7 @@ Animation system was completely rewritten in Chart.js v3. Each property can now #### Interactions +* To allow DRY configuration, a root options scope for common interaction options was added. `options.hover` and `options.tooltips` now both extend from `options.interaction`. Defaults are defined...
true
Other
chartjs
Chart.js
f5c4f97504b6ae96f8f0592bcc15cebb2dfba8a6.json
Add interaction options (#7922) * Add interaction options * Add migration note
samples/charts/line/multi-axis.html
@@ -62,7 +62,9 @@ data: lineChartData, options: { responsive: true, - hoverMode: 'index', + interaction: { + mode: 'index' + }, stacked: false, title: { display: true,
true
Other
chartjs
Chart.js
f5c4f97504b6ae96f8f0592bcc15cebb2dfba8a6.json
Add interaction options (#7922) * Add interaction options * Add migration note
samples/charts/scatter/multi-axis.html
@@ -88,8 +88,10 @@ data: scatterChartData, options: { responsive: true, - hoverMode: 'nearest', - intersect: true, + interaction: { + intersect: true, + mode: 'nearest' + }, title: { display: true, text: 'Chart.js Scatter Chart - Multi Axis'
true
Other
chartjs
Chart.js
f5c4f97504b6ae96f8f0592bcc15cebb2dfba8a6.json
Add interaction options (#7922) * Add interaction options * Add migration note
src/controllers/controller.bar.js
@@ -528,10 +528,12 @@ BarController.defaults = { 'maxBarThickness', 'minBarLength', ], - hover: { + interaction: { mode: 'index' }, + hover: {}, + datasets: { categoryPercentage: 0.8, barPercentage: 0.9,
true
Other
chartjs
Chart.js
f5c4f97504b6ae96f8f0592bcc15cebb2dfba8a6.json
Add interaction options (#7922) * Add interaction options * Add migration note
src/controllers/controller.line.js
@@ -164,10 +164,12 @@ LineController.defaults = { showLines: true, spanGaps: false, - hover: { + interaction: { mode: 'index' }, + hover: {}, + scales: { _index_: { type: 'category',
true
Other
chartjs
Chart.js
f5c4f97504b6ae96f8f0592bcc15cebb2dfba8a6.json
Add interaction options (#7922) * Add interaction options * Add migration note
src/core/core.controller.js
@@ -116,10 +116,25 @@ function initConfig(config) { defaults[config.type], config.options || {}); + options.hover = merge(Object.create(null), [ + defaults.interaction, + defaults.hover, + options.interaction, + options.hover + ]); + options.scales = scaleConfig; - options.title = (options.title !== fal...
true
Other
chartjs
Chart.js
f5c4f97504b6ae96f8f0592bcc15cebb2dfba8a6.json
Add interaction options (#7922) * Add interaction options * Add migration note
src/core/core.defaults.js
@@ -42,12 +42,15 @@ export class Defaults { lineWidth: 0, strokeStyle: undefined }; - this.hover = { - onHover: null, + this.interaction = { mode: 'nearest', intersect: true }; + this.hover = { + onHover: null + }; this.maintainAspectRatio = true; + this.onHover = null; this.onClick...
true
Other
chartjs
Chart.js
f5c4f97504b6ae96f8f0592bcc15cebb2dfba8a6.json
Add interaction options (#7922) * Add interaction options * Add migration note
src/plugins/plugin.tooltip.js
@@ -1066,9 +1066,7 @@ export default { defaults: { enabled: true, custom: null, - mode: 'nearest', position: 'average', - intersect: true, backgroundColor: 'rgba(0,0,0,0.8)', titleFont: { style: 'bold',
true
Other
chartjs
Chart.js
f5c4f97504b6ae96f8f0592bcc15cebb2dfba8a6.json
Add interaction options (#7922) * Add interaction options * Add migration note
test/specs/core.controller.tests.js
@@ -89,13 +89,38 @@ describe('Chart', function() { expect(chart.data.datasets[0].data).toEqual([10, 11, 12]); }); - it('should initialize config with default options', function() { + it('should initialize config with default interaction options', function() { var callback = function() {}; var default...
true
Other
chartjs
Chart.js
f5c4f97504b6ae96f8f0592bcc15cebb2dfba8a6.json
Add interaction options (#7922) * Add interaction options * Add migration note
types/core/index.d.ts
@@ -417,13 +417,18 @@ export interface Defaults { readonly color: string; readonly events: ('mousemove' | 'mouseout' | 'click' | 'touchstart' | 'touchmove')[]; readonly font: IFontSpec; - readonly hover: { - onHover?: () => void; + readonly interaction: { mode: InteractionMode | string; intersec...
true
Other
chartjs
Chart.js
41eb16a6506ce1caa699ee5ca6e1d85f01c27b63.json
Add example of event to data values (#7925)
docs/docs/general/interactions/events.md
@@ -22,3 +22,23 @@ var chart = new Chart(ctx, { } }); ``` + +## Converting Events to Data Values + +A common occurrence is taking an event, such as a click, and finding the data coordinates on the chart where the event occurred. Chart.js provides helpers that make this a straightforward process. + +```javascript...
false
Other
chartjs
Chart.js
c688c2f5430de350f27fda0081c6f1d83c0055b8.json
Fix broken urls in docs (#7912)
docs/docs/axes/radial/linear.md
@@ -133,7 +133,7 @@ The following options are used to configure the point labels that are shown on t | ---- | ---- | ------- | ------- | ----------- | `display` | `boolean` | | `true` | if true, point labels are shown. | `callback` | `function` | | | Callback function to transform data labels to point labels. The de...
true
Other
chartjs
Chart.js
c688c2f5430de350f27fda0081c6f1d83c0055b8.json
Fix broken urls in docs (#7912)
docs/docs/developers/updates.md
@@ -95,7 +95,7 @@ function updateScale(chart) { } ``` -Code sample for updating options can be found in [toggle-scale-type.html](../../samples/scales/toggle-scale-type.html). +Code sample for updating options can be found in [toggle-scale-type.html](./../../samples/latest/scales/toggle-scale-type.html). ## Preve...
true
Other
chartjs
Chart.js
c688c2f5430de350f27fda0081c6f1d83c0055b8.json
Fix broken urls in docs (#7912)
docs/docs/general/performance.md
@@ -26,11 +26,11 @@ Line charts are able to do [automatic data decimation during draw](#automatic-da ### Rotation -[Specify a rotation value](../axes/cartesian/index.md#tick-configuration) by setting `minRotation` and `maxRotation` to the same value, which avoids the chart from having to automatically determine a ...
true
Other
chartjs
Chart.js
c688c2f5430de350f27fda0081c6f1d83c0055b8.json
Fix broken urls in docs (#7912)
docs/docs/getting-started/v3-migration.md
@@ -51,7 +51,7 @@ const chart = new Chart(ctx, { ### Chart types -* `horizontalBar` chart type was removed. Horizontal bar charts can be configured using the new [`indexAxis`](../charts/bar.md#general) option +* `horizontalBar` chart type was removed. Horizontal bar charts can be configured using the new [`indexAx...
true
Other
chartjs
Chart.js
de963091d9505ca8c4b8009a97780a2db4dce670.json
Remove area inclusion check when rendering points (#7910)
src/elements/element.point.js
@@ -1,5 +1,5 @@ import Element from '../core/core.element'; -import {_isPointInArea, drawPoint} from '../helpers/helpers.canvas'; +import {drawPoint} from '../helpers/helpers.canvas'; export default class Point extends Element { @@ -46,21 +46,18 @@ export default class Point extends Element { return (radius + ...
false
Other
chartjs
Chart.js
7ce9710f336c2ad2359466dc9357979c4d562446.json
fix some typos (#7914)
docs/docs/configuration/legend.md
@@ -57,7 +57,7 @@ The legend label configuration is nested below the legend configuration using th | `generateLabels` | `function` | | Generates legend items for each thing in the legend. Default implementation returns the text + styling for the color box. See [Legend Item](#legend-item-interface) for details. | `fil...
true
Other
chartjs
Chart.js
7ce9710f336c2ad2359466dc9357979c4d562446.json
fix some typos (#7914)
docs/docs/general/performance.md
@@ -75,7 +75,7 @@ new Chart(ctx, { ## Parallel rendering with web workers (Chrome only) -Chome (in version 69) added the ability to [transfer rendering control of a canvas](https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/transferControlToOffscreen) to a web worker. Web workers can use the [Offsc...
true
Other
chartjs
Chart.js
7ce9710f336c2ad2359466dc9357979c4d562446.json
fix some typos (#7914)
docs/docs/general/responsive.md
@@ -39,7 +39,7 @@ chart.canvas.parentNode.style.width = '128px'; Note that in order for the above code to correctly resize the chart height, the [`maintainAspectRatio`](#configuration-options) option must also be set to `false`. -## Printing Resizeable Charts +## Printing Resizable Charts CSS media queries allo...
true
Other
chartjs
Chart.js
7ce9710f336c2ad2359466dc9357979c4d562446.json
fix some typos (#7914)
src/core/core.animations.js
@@ -127,7 +127,7 @@ export default class Animations { const animations = this._createAnimations(options, newOptions); if (newOptions.$shared && !options.$shared) { // Going from distinct options to shared options: - // After all animations are done, assing the shared options object to the element + // Aft...
true
Other
chartjs
Chart.js
7ce9710f336c2ad2359466dc9357979c4d562446.json
fix some typos (#7914)
src/core/core.plugins.js
@@ -214,7 +214,7 @@ function createDescriptors(plugins, options) { /** * @method IPlugin#beforeDraw * @desc Called before drawing `chart` at every animation frame. If any plugin returns `false`, - * the frame drawing is cancelled untilanother `render` is triggered. + * the frame drawing is cancelled until another ...
true
Other
chartjs
Chart.js
7ce9710f336c2ad2359466dc9357979c4d562446.json
fix some typos (#7914)
src/scales/scale.category.js
@@ -83,7 +83,7 @@ export default class CategoryScale extends Scale { return me.getPixelForDecimal((value - me._startValue) / me._valueRange); } - // Must override base implementation becuase it calls getPixelForValue + // Must override base implementation because it calls getPixelForValue // and category scale...
true
Other
chartjs
Chart.js
8e640f4c710fde95d4542abc75cb779d6bd1c737.json
Fix version numbers in Developers section of docs (#7909)
docs/docs/developers/index.md
@@ -38,9 +38,9 @@ Thanks to [BrowserStack](https://browserstack.com) for allowing our team to test ## Previous versions -To migrate from version 3 to version 2, please see [the v3 migration guide](../getting-started/v3-migration). +To migrate from version 2 to version 3, please see [the v3 migration guide](../gett...
false
Other
chartjs
Chart.js
11dc2aad0e05b80bdf9134a84bb6dd908b1f11ea.json
Fix broken url in docs
docs/docs/charts/scatter.md
@@ -35,7 +35,7 @@ var scatterChart = new Chart(ctx, { ## Dataset Properties -The scatter chart supports all of the same properties as the [line chart](./charts/line#dataset-properties). +The scatter chart supports all of the same properties as the [line chart](./charts/line.mdx#dataset-properties). ## Data Stru...
false
Other
chartjs
Chart.js
2e986852b577f4f6211d86b7a3aa291c69497412.json
Fix broken url in docs
docs/docs/charts/area.md
@@ -2,7 +2,7 @@ title: Area Chart --- -Both [line](line.md) and [radar](radar.md) charts support a `fill` option on the dataset object which can be used to create space between two datasets or a dataset and a boundary, i.e. the scale `origin`, `start,` or `end` (see [filling modes](#filling-modes)). +Both [line](./...
true
Other
chartjs
Chart.js
2e986852b577f4f6211d86b7a3aa291c69497412.json
Fix broken url in docs
docs/docs/charts/scatter.md
@@ -35,7 +35,7 @@ var scatterChart = new Chart(ctx, { ## Dataset Properties -The scatter chart supports all of the same properties as the [line chart](./line.md#dataset-properties). +The scatter chart supports all of the same properties as the [line chart](./charts/line#dataset-properties). ## Data Structure
true
Other
chartjs
Chart.js
2e986852b577f4f6211d86b7a3aa291c69497412.json
Fix broken url in docs
docs/docs/configuration/elements.md
@@ -64,7 +64,7 @@ Global line options: `Chart.defaults.elements.line`. | `borderDashOffset` | `number` | `0.0` | Line dash offset. See [MDN](https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/lineDashOffset). | `borderJoinStyle` | `string` | `'miter'` | Line join style. See [MDN](https://develo...
true
Other
chartjs
Chart.js
2e986852b577f4f6211d86b7a3aa291c69497412.json
Fix broken url in docs
docs/docs/index.md
@@ -57,7 +57,7 @@ var myChart = new Chart(ctx, { ## Contributing -Before submitting an issue or a pull request to the project, please take a moment to look over the [contributing guidelines](./developers/contributing.md) first. +Before submitting an issue or a pull request to the project, please take a moment to l...
true
Other
chartjs
Chart.js
b6c22d269a16097bc8c55d7cc01d37b7369391d4.json
Remove circular dependencies from helpers (#7898)
src/helpers/helpers.canvas.js
@@ -1,7 +1,5 @@ -import { - isArray, isNullOrUndef, PI, TAU, HALF_PI, QUARTER_PI, - TWO_THIRDS_PI, RAD_PER_DEG -} from './index'; +import {isArray, isNullOrUndef} from './helpers.core'; +import {PI, TAU, HALF_PI, QUARTER_PI, TWO_THIRDS_PI, RAD_PER_DEG} from './helpers.math'; /** * @typedef { import("../core/core.c...
true
Other
chartjs
Chart.js
b6c22d269a16097bc8c55d7cc01d37b7369391d4.json
Remove circular dependencies from helpers (#7898)
src/helpers/helpers.dom.js
@@ -1,4 +1,4 @@ -import {INFINITY} from './index'; +import {INFINITY} from './helpers.math'; /** * @private
true