language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
chartjs
Chart.js
72c3c6d0802919eb4d24a4ef19cc465e9fa8ff1b.json
Fix memory leak (#7097)
src/core/core.controller.js
@@ -893,6 +893,7 @@ class Chart { let i, ilen; me.stop(); + Animator.remove(me); // dataset controllers need to cleanup associated data for (i = 0, ilen = me.data.datasets.length; i < ilen; ++i) {
true
Other
chartjs
Chart.js
2f17dbcd701060c47818ea12d97ae6b813518277.json
Prefix private controller methods with underscore (#7081) Prefix private controller methods with underscore
docs/getting-started/v3-migration.md
@@ -176,9 +176,33 @@ Animation system was completely rewritten in Chart.js v3. Each property can now #### Renamed private APIs +* `BarController.calculateBarIndexPixels` was renamed to `BarController._calculateBarIndexPixels` +* `BarController.calculateBarValuePixels` was renamed to `BarController._calculateBarVal...
true
Other
chartjs
Chart.js
2f17dbcd701060c47818ea12d97ae6b813518277.json
Prefix private controller methods with underscore (#7081) Prefix private controller methods with underscore
src/controllers/controller.bar.js
@@ -274,7 +274,7 @@ class BarController extends DatasetController { const vscale = me._cachedMeta.vScale; const base = vscale.getBasePixel(); const horizontal = vscale.isHorizontal(); - const ruler = me.getRuler(); + const ruler = me._getRuler(); const firstOpts = me._resolveDataElementOptions(start, mode...
true
Other
chartjs
Chart.js
2f17dbcd701060c47818ea12d97ae6b813518277.json
Prefix private controller methods with underscore (#7081) Prefix private controller methods with underscore
src/core/core.animator.js
@@ -119,6 +119,9 @@ class Animator { } } + /** + * @private + */ _getAnims(chart) { const charts = this._charts; let anims = charts.get(chart);
true
Other
chartjs
Chart.js
2f17dbcd701060c47818ea12d97ae6b813518277.json
Prefix private controller methods with underscore (#7081) Prefix private controller methods with underscore
src/core/core.controller.js
@@ -208,6 +208,7 @@ class Chart { this._updating = false; this.scales = {}; this.scale = undefined; + this.$plugins = undefined; // Add the chart instance to the global namespace Chart.instances[me.id] = me; @@ -454,7 +455,7 @@ class Chart { if (numMeta > numData) { for (let i = numData; i < ...
true
Other
chartjs
Chart.js
2f17dbcd701060c47818ea12d97ae6b813518277.json
Prefix private controller methods with underscore (#7081) Prefix private controller methods with underscore
src/core/core.datasetController.js
@@ -10,7 +10,7 @@ const arrayEvents = ['push', 'pop', 'shift', 'splice', 'unshift']; /** * Hooks the array methods that add or remove values ('push', pop', 'shift', 'splice', * 'unshift') and notify the listener AFTER the array has been altered. Listeners are - * called on the 'onData*' callbacks (e.g. onDataPush,...
true
Other
chartjs
Chart.js
2f17dbcd701060c47818ea12d97ae6b813518277.json
Prefix private controller methods with underscore (#7081) Prefix private controller methods with underscore
src/core/core.plugins.js
@@ -107,7 +107,7 @@ class PluginService { * @returns {boolean} false if any of the plugins return false, else returns true. */ notify(chart, hook, args) { - var descriptors = this.descriptors(chart); + var descriptors = this._descriptors(chart); var ilen = descriptors.length; var i, descriptor, plugin, ...
true
Other
chartjs
Chart.js
2f17dbcd701060c47818ea12d97ae6b813518277.json
Prefix private controller methods with underscore (#7081) Prefix private controller methods with underscore
test/fixtures/core.tooltip/opacity.js
@@ -85,7 +85,7 @@ module.exports = { clientX: rect.left + point.x, clientY: rect.top + point.y }; - chart.handleEvent(event); + chart._handleEvent(event); chart.tooltip.handleEvent(event); chart.tooltip.opacity = j / 10; chart.tooltip.draw(chart.ctx);
true
Other
chartjs
Chart.js
2f17dbcd701060c47818ea12d97ae6b813518277.json
Prefix private controller methods with underscore (#7081) Prefix private controller methods with underscore
test/specs/controller.bar.tests.js
@@ -67,7 +67,7 @@ describe('Chart.controllers.bar', function() { }); var meta = chart.getDatasetMeta(1); - expect(meta.controller.getStackCount()).toBe(2); + expect(meta.controller._getStackCount()).toBe(2); }); }); @@ -90,7 +90,7 @@ describe('Chart.controllers.bar', function() { }); var ...
true
Other
chartjs
Chart.js
2f17dbcd701060c47818ea12d97ae6b813518277.json
Prefix private controller methods with underscore (#7081) Prefix private controller methods with underscore
test/specs/core.datasetController.tests.js
@@ -12,11 +12,11 @@ describe('Chart.DatasetController', function() { var controller = chart.getDatasetMeta(0).controller; var methods = [ - 'onDataPush', - 'onDataPop', - 'onDataShift', - 'onDataSplice', - 'onDataUnshift' + '_onDataPush', + '_onDataPop', + '_onDataShift', + '_onDataSplice', + ...
true
Other
chartjs
Chart.js
2f17dbcd701060c47818ea12d97ae6b813518277.json
Prefix private controller methods with underscore (#7081) Prefix private controller methods with underscore
test/utils.js
@@ -108,11 +108,11 @@ function waitForResize(chart, callback) { } function afterEvent(chart, type, callback) { - var override = chart.eventHandler; - chart.eventHandler = function(event) { + var override = chart._eventHandler; + chart._eventHandler = function(event) { override.call(this, event); if (event.typ...
true
Other
chartjs
Chart.js
92b2f7908e3a84c3f34f0c1574206d137284e086.json
Fix lint issues in gulpfile.js (#7076) * Fix lint issues in gulpfile.js * .eslintignore update
.eslintignore
@@ -1 +1 @@ -**/*{.,-}min.js +dist/*.js
true
Other
chartjs
Chart.js
92b2f7908e3a84c3f34f0c1574206d137284e086.json
Fix lint issues in gulpfile.js (#7076) * Fix lint issues in gulpfile.js * .eslintignore update
gulpfile.js
@@ -1,3 +1,4 @@ +/* eslint-disable no-use-before-define */ const gulp = require('gulp'); const eslint = require('gulp-eslint'); const file = require('gulp-file'); @@ -13,14 +14,14 @@ const yargs = require('yargs'); const path = require('path'); const htmllint = require('gulp-htmllint'); const typescript = require...
true
Other
chartjs
Chart.js
61aea761f487edb2796b0cea4bb836ccb49ef86c.json
Unify signature of plugin hooks (#8102)
docs/docs/getting-started/v3-migration.md
@@ -494,6 +494,7 @@ All helpers are now exposed in a flat hierarchy, e.g., `Chart.helpers.canvas.cli #### IPlugin interface +* All plugin hooks have unified signature with 3 arguments: `chart`, `args` and `options`. This means change in signature for these hooks: `beforeInit`, `afterInit`, `reset`, `beforeLayout`,...
true
Other
chartjs
Chart.js
61aea761f487edb2796b0cea4bb836ccb49ef86c.json
Unify signature of plugin hooks (#8102)
src/core/core.controller.js
@@ -33,7 +33,7 @@ function onAnimationsComplete(context) { const chart = context.chart; const animationOptions = chart.options.animation; - chart._plugins.notify(chart, 'afterRender'); + chart.notifyPlugins('afterRender'); callCallback(animationOptions && animationOptions.onComplete, [context], chart); } @@ ...
true
Other
chartjs
Chart.js
61aea761f487edb2796b0cea4bb836ccb49ef86c.json
Unify signature of plugin hooks (#8102)
src/core/core.plugins.js
@@ -15,19 +15,19 @@ export default class PluginService { * returned value can be used, for instance, to interrupt the current action. * @param {Chart} chart - The chart instance for which plugins should be called. * @param {string} hook - The name of the plugin method to call (e.g. 'beforeUpdate'). - * @param...
true
Other
chartjs
Chart.js
61aea761f487edb2796b0cea4bb836ccb49ef86c.json
Unify signature of plugin hooks (#8102)
src/plugins/plugin.legend.js
@@ -690,10 +690,10 @@ export default { }, - afterEvent(chart, e) { + afterEvent(chart, args) { const legend = chart.legend; if (legend) { - legend.handleEvent(e); + legend.handleEvent(args.event); } },
true
Other
chartjs
Chart.js
61aea761f487edb2796b0cea4bb836ccb49ef86c.json
Unify signature of plugin hooks (#8102)
src/plugins/plugin.tooltip.js
@@ -1074,22 +1074,22 @@ export default { tooltip }; - if (chart._plugins.notify(chart, 'beforeTooltipDraw', [args]) === false) { + if (chart.notifyPlugins('beforeTooltipDraw', args) === false) { return; } if (tooltip) { tooltip.draw(chart.ctx); } - chart._plugins.notify(chart, 'afterToo...
true
Other
chartjs
Chart.js
61aea761f487edb2796b0cea4bb836ccb49ef86c.json
Unify signature of plugin hooks (#8102)
test/specs/core.plugin.tests.js
@@ -1,31 +1,33 @@ describe('Chart.plugins', function() { - describe('Chart.plugins.notify', function() { + describe('Chart.notifyPlugins', function() { it('should call inline plugins with arguments', function() { var plugin = {hook: function() {}}; var chart = window.acquireChart({ plugins: [plugin] ...
true
Other
chartjs
Chart.js
61aea761f487edb2796b0cea4bb836ccb49ef86c.json
Unify signature of plugin hooks (#8102)
test/specs/platform.dom.tests.js
@@ -369,8 +369,8 @@ describe('Platform.dom', function() { it('should notify plugins about events', function(done) { var notifiedEvent; var plugin = { - afterEvent: function(chart, e) { - notifiedEvent = e; + afterEvent: function(chart, args) { + notifiedEvent = args.event; } }; var...
true
Other
chartjs
Chart.js
61aea761f487edb2796b0cea4bb836ccb49ef86c.json
Unify signature of plugin hooks (#8102)
types/core/index.d.ts
@@ -227,6 +227,8 @@ export declare class Chart< unbindEvents(): void; updateHoverStyle(items: Element, mode: 'dataset', enabled: boolean): void; + notifyPlugins(hook: string, args?: AnyObject): boolean | void; + static readonly version: string; static readonly instances: { [key: string]: Chart }; static rea...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
docs/docs/configuration/legend.md
@@ -6,7 +6,7 @@ The chart legend displays data about the datasets that are appearing on the char ## Configuration options -The legend configuration is passed into the `options.legend` namespace. The global options for the chart legend is defined in `Chart.defaults.plugins.legend`. +The legend configuration is pass...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
docs/docs/configuration/title.md
@@ -6,7 +6,7 @@ The chart title defines text to draw at the top of the chart. ## Title Configuration -The title configuration is passed into the `options.title` namespace. The global options for the chart title is defined in `Chart.defaults.plugins.title`. +The title configuration is passed into the `options.plugi...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
docs/docs/configuration/tooltip.md
@@ -4,7 +4,7 @@ title: Tooltip ## Tooltip Configuration -The tooltip configuration is passed into the `options.tooltips` namespace. The global options for the chart tooltips is defined in `Chart.defaults.plugins.tooltip`. +The tooltip configuration is passed into the `options.plugins.tooltip` namespace. The global...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
docs/docs/developers/updates.md
@@ -35,7 +35,7 @@ To update the options, mutating the options property in place or passing in a ne ```javascript function updateConfigByMutating(chart) { - chart.options.title.text = 'new title'; + chart.options.plugins.title.text = 'new title'; chart.update(); }
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
docs/docs/general/fonts.md
@@ -12,11 +12,13 @@ let chart = new Chart(ctx, { type: 'line', data: data, options: { - legend: { - labels: { - // This more specific font property overrides the global property - font: { - size: 14 + plugins: { + legend...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
docs/docs/general/interactions/events.md
@@ -41,4 +41,4 @@ const chart = new Chart(ctx, { } } }); -``` \ No newline at end of file +```
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
docs/docs/general/interactions/modes.md
@@ -4,7 +4,7 @@ title: Interaction Modes When configuring interaction with the graph via hover or tooltips, a number of different modes are available. -`options.hover` and `options.tooltips` extend from `options.interaction`. So if `mode`, `intersect` or any other common settings are configured only in `options.in...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
docs/docs/getting-started/v3-migration.md
@@ -94,6 +94,8 @@ A number of changes were made to the configuration options passed to the `Chart` * To override the platform class used in a chart instance, pass `platform: PlatformClass` in the config object. Note that the class should be passed, not an instance of the class. * `aspectRatio` defaults to 1 for dough...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/advanced/line-gradient.html
@@ -69,13 +69,15 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Chart.js Line Chart' - }, - tooltips: { - mode: 'index', - intersect: false, + plugins: { + title: { + display: true, + text: 'Chart.js Line Chart' + }, + tooltip: { + ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/advanced/radial-gradient.html
@@ -78,18 +78,22 @@ }, options: { responsive: true, - legend: { - position: 'right', - }, - title: { - display: true, - text: 'Chart.js Polar Area Chart' - }, - scale: { - ticks: { - beginAtZero: true + plugins: { + legend: { + position: 'right', }, - ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/animations/delay.html
@@ -86,13 +86,15 @@ delay }; }, - title: { - display: true, - text: 'Chart.js Bar Chart - Stacked' - }, - tooltips: { - mode: 'index', - intersect: false + plugins: { + title: { + display: true, + text: 'Chart.js Bar Chart - Stacked' + }, + ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/animations/drop.html
@@ -75,13 +75,15 @@ } }, responsive: true, - title: { - display: true, - text: 'Chart.js Line Chart' - }, - tooltips: { - mode: 'index', - intersect: false, + plugins: { + title: { + display: true, + text: 'Chart.js Line Chart' + }, + tooltip: { + m...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/animations/loop.html
@@ -78,14 +78,16 @@ } }, responsive: true, - title: { - display: true, - text: 'Chart.js Line Chart' - }, - tooltips: { - mode: 'nearest', - axis: 'x', - intersect: false, + plugins: { + title: { + display: true, + text: 'Chart.js Line Chart' + }, + ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/area/line-stacked.html
@@ -87,12 +87,14 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Chart.js Line Chart - Stacked Area' - }, - tooltips: { - mode: 'index', + plugins: { + title: { + display: true, + text: 'Chart.js Line Chart - Stacked Area' + }, + tooltip...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/bar/border-radius.html
@@ -70,12 +70,14 @@ data: barChartData, options: { responsive: true, - legend: { - position: 'top', - }, - title: { - display: true, - text: 'Chart.js Bar Chart' + plugins: { + legend: { + position: 'top', + }, + title: { + display: true, + ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/bar/float.html
@@ -67,12 +67,14 @@ data: barChartData, options: { responsive: true, - legend: { - position: 'top', - }, - title: { - display: true, - text: 'Chart.js Bar Chart' + plugins: { + legend: { + position: 'top', + }, + title: { + display: true, + ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/bar/horizontal.html
@@ -74,12 +74,14 @@ } }, responsive: true, - legend: { - position: 'right', - }, - title: { - display: true, - text: 'Chart.js Horizontal Bar Chart' + plugins: { + legend: { + position: 'right', + }, + title: { + display: true, + text: '...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/bar/multi-axis.html
@@ -66,13 +66,15 @@ data: barChartData, options: { responsive: true, - title: { - display: true, - text: 'Chart.js Bar Chart - Multi Axis' - }, - tooltips: { - mode: 'index', - intersect: true + plugins: { + title: { + display: true, + text: 'Chart.js...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/bar/stacked-group.html
@@ -70,13 +70,15 @@ type: 'bar', data: barChartData, options: { - title: { - display: true, - text: 'Chart.js Bar Chart - Stacked' - }, - tooltips: { - mode: 'index', - intersect: false + plugins: { + title: { + display: true, + text: 'Chart.js Bar Cha...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/bar/stacked.html
@@ -67,13 +67,15 @@ type: 'bar', data: barChartData, options: { - title: { - display: true, - text: 'Chart.js Bar Chart - Stacked' - }, - tooltips: { - mode: 'index', - intersect: false + plugin: { + title: { + display: true, + text: 'Chart.js Bar Char...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/bar/vertical.html
@@ -67,12 +67,14 @@ data: barChartData, options: { responsive: true, - legend: { - position: 'top', - }, - title: { - display: true, - text: 'Chart.js Bar Chart' + plugins: { + legend: { + position: 'top', + }, + title: { + display: true, + ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/bubble.html
@@ -107,12 +107,14 @@ data: bubbleChartData, options: { responsive: true, - title: { - display: true, - text: 'Chart.js Bubble Chart' - }, - tooltips: { - mode: 'point' + plugins: { + title: { + display: true, + text: 'Chart.js Bubble Chart' + }, + ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/combo-bar-line.html
@@ -75,13 +75,15 @@ data: chartData, options: { responsive: true, - title: { - display: true, - text: 'Chart.js Combo Bar Line Chart' - }, - tooltips: { - mode: 'index', - intersect: true + plugins: { + title: { + display: true, + text: 'Chart.js Comb...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/doughnut.html
@@ -59,12 +59,14 @@ }, options: { responsive: true, - legend: { - position: 'top', - }, - title: { - display: true, - text: 'Chart.js Doughnut Chart' + plugins: { + legend: { + position: 'top', + }, + title: { + display: true, + text: 'Chart.js Doughnut Ch...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/line/basic.html
@@ -63,13 +63,15 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Chart.js Line Chart' - }, - tooltips: { - mode: 'index', - intersect: false, + plugins: { + title: { + display: true, + text: 'Chart.js Line Chart' + }, + tooltip: { + ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/line/interpolation-modes.html
@@ -57,12 +57,14 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Chart.js Line Chart - Cubic interpolation mode' - }, - tooltips: { - mode: 'index' + plugins: { + title: { + display: true, + text: 'Chart.js Line Chart - Cubic interpolation mode'...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/line/line-styles.html
@@ -70,13 +70,15 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Chart.js Line Chart' - }, - tooltips: { - mode: 'index', - intersect: false, + plugins: { + title: { + display: true, + text: 'Chart.js Line Chart' + }, + tooltip: { + ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/line/point-sizes.html
@@ -90,8 +90,14 @@ }, options: { responsive: true, - legend: { - position: 'bottom', + plugins: { + legend: { + position: 'bottom', + }, + title: { + display: true, + text: 'Chart.js Line Chart - Different point sizes' + } }, hover: { mode: 'index' @...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/line/point-styles.html
@@ -48,12 +48,14 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Point Style: ' + pointStyle - }, - legend: { - display: false + plugins: { + title: { + display: true, + text: 'Point Style: ' + pointStyle + }, + legend: { ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/line/skip-points.html
@@ -56,12 +56,14 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Chart.js Line Chart - Skip Points' - }, - tooltips: { - mode: 'index', + plugins: { + title: { + display: true, + text: 'Chart.js Line Chart - Skip Points' + }, + tooltip: ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/multi-series-pie.html
@@ -43,47 +43,49 @@ ] }, options: { - legend: { - labels: { - generateLabels: function(chart) { - // Get the default label list - var original = Chart.defaults.controllers.pie.legend.labels.generateLabels; - var labels = original.call(this, chart); + plugins: { + legend...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/polar-area.html
@@ -58,12 +58,14 @@ }, options: { responsive: true, - legend: { - position: 'right', - }, - title: { - display: true, - text: 'Chart.js Polar Area Chart' + plugins: { + legend: { + position: 'right', + }, + title: { + display: true, + text: 'Chart.js Polar...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/charts/radar.html
@@ -64,12 +64,14 @@ }] }, options: { - legend: { - position: 'top', - }, - title: { - display: true, - text: 'Chart.js Radar Chart' + plugins: { + legend: { + position: 'top', + }, + title: { + display: true, + text: 'Chart.js Radar Chart' + }, },...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/legend/callbacks.html
@@ -83,20 +83,22 @@ }] }, options: { - legend: { - onHover: function(event, legendItem) { - log('onHover: ' + legendItem.text); + plugins: { + legend: { + onHover: function(event, legendItem) { + log('onHover: ' + legendItem.text); + }, + onLeave: function(event, leg...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/legend/point-style.html
@@ -62,9 +62,15 @@ }, options: { responsive: true, - legend: { - labels: { - usePointStyle: false + plugins: { + legend: { + labels: { + usePointStyle: false + } + }, + title: { + display: true, + text: 'Normal Legend' } }, ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/legend/positioning.html
@@ -65,8 +65,14 @@ }, options: { responsive: true, - legend: { - position: legendPosition, + plugins: { + legend: { + position: legendPosition, + }, + title: { + display: true, + text: 'Legend Position: ' + legendPosition + } }, scales: { ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/legend/title.html
@@ -71,13 +71,19 @@ }, options: { responsive: true, - legend: { - align: align, - position: legendPosition, + plugins: { + legend: { + align: align, + position: legendPosition, + title: { + display: true, + text: 'Legend Title', + position: t...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/scales/axes-labels.html
@@ -63,13 +63,15 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Chart.js Line Chart' - }, - tooltips: { - mode: 'index', - intersect: false, + plugins: { + title: { + display: true, + text: 'Chart.js Line Chart' + }, + tooltip: { + ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/scales/financial.html
@@ -182,17 +182,19 @@ } } }, - tooltips: { - intersect: false, - mode: 'index', - callbacks: { - label: function(context) { - let label = context.dataset.label || ''; - if (label) { - label += ': '; + plugins: { + tooltip: { + intersect: false, + ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/scales/label-text-alignment.html
@@ -80,8 +80,14 @@ }, options: { responsive: true, - legend: { - display: false, + plugins: { + legend: { + display: false, + }, + title: { + display: true, + text: 'X Tick Alignment: ' + xAlign + ', Y Tick Alignment ' + yAlign + } }, scales...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/scales/linear/step-size.html
@@ -68,13 +68,15 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Chart.js Line Chart' - }, - tooltips: { - mode: 'index', - intersect: false, + plugins: { + title: { + display: true, + text: 'Chart.js Line Chart' + }, + tooltip: { + ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/scales/toggle-scale-type.html
@@ -85,7 +85,7 @@ document.getElementById('toggleScale').addEventListener('click', function() { type = type === 'linear' ? 'logarithmic' : 'linear'; - window.myLine.options.title.text = 'Chart.js Line Chart - ' + type; + window.myLine.options.plugins.title.text = 'Chart.js Line Chart - ' + type; window...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/scriptable/bar.html
@@ -52,8 +52,10 @@ }; var options = { - legend: false, - tooltips: false, + plugins: { + legend: false, + tooltip: false, + }, elements: { bar: { backgroundColor: colorize.bind(null, false),
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/scriptable/bubble.html
@@ -69,9 +69,10 @@ var options = { aspectRatio: 1, - legend: false, - tooltips: false, - + plugins: { + legend: false, + tooltip: false, + }, elements: { point: { backgroundColor: colorize.bind(null, false),
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/scriptable/line.html
@@ -64,8 +64,10 @@ }; var options = { - legend: false, - tooltips: true, + plugins: { + legend: false, + tooltip: true, + }, elements: { line: { fill: false,
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/scriptable/pie.html
@@ -57,8 +57,10 @@ }; var options = { - legend: false, - tooltips: false, + plugins: { + legend: false, + tooltip: false, + }, elements: { arc: { backgroundColor: colorize.bind(null, false, false),
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/scriptable/polar.html
@@ -56,8 +56,10 @@ }; var options = { - legend: false, - tooltips: false, + plugins: { + legend: false, + tooltip: false, + }, elements: { arc: { backgroundColor: colorize.bind(null, false, false),
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/scriptable/radar.html
@@ -68,8 +68,10 @@ }; var options = { - legend: false, - tooltips: true, + plugins: { + legend: false, + tooltip: false, + }, elements: { line: { backgroundColor: make20PercentOpaque,
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/title/alignment.html
@@ -71,8 +71,10 @@ }, options: { responsive: true, - legend: { - display: false, + plugins: { + legend: { + display: false + }, }, scales: { x: {
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/tooltips/border.html
@@ -45,27 +45,29 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Sample tooltip with border' - }, - tooltips: { - position: 'nearest', - mode: 'index', - intersect: false, - yPadding: 10, - xPadding: 10, - caretSize: 8, - b...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/tooltips/callbacks.html
@@ -55,24 +55,26 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Chart.js Line Chart - Custom Information in Tooltip' - }, - tooltips: { - mode: 'index', - callbacks: { - // Use the footer callback to display the sum of the items showing in the tooltip ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/tooltips/custom-line.html
@@ -153,16 +153,18 @@ type: 'line', data: lineChartData, options: { - title: { - display: true, - text: 'Chart.js Line Chart - Custom Tooltips' - }, - tooltips: { - enabled: false, - mode: 'index', - intersect: false, - position: 'nearest', - custom: customT...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/tooltips/custom-pie.html
@@ -137,11 +137,9 @@ }, options: { responsive: true, - legend: { - display: false - }, - tooltips: { - enabled: false, + plugins: { + legend: false, + tooltip: false } } };
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/tooltips/custom-points.html
@@ -112,15 +112,17 @@ type: 'line', data: lineChartData, options: { - title: { - display: true, - text: 'Chart.js - Custom Tooltips using Data Points' - }, - tooltips: { - enabled: false, - mode: 'index', - intersect: false, - custom: customTooltips + plugins...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/tooltips/interactions.html
@@ -51,13 +51,15 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Mode: ' + mode + ', intersect = ' + intersect - }, - tooltips: { - mode: mode, - intersect: intersect, + plugins: { + title: { + display: true, + text: 'Mode: ' +...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/tooltips/point-style.html
@@ -83,19 +83,21 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Tooltip Point Styles' - }, - tooltips: { - mode: 'index', - intersect: false, - usePointStyle: true, - }, - legend: { - labels: { - usePointStyle: true - } + plugins: ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/tooltips/positioning-custom.html
@@ -83,10 +83,12 @@ }, options: { responsive: true, - tooltips: { - position: 'middle', - intersect: false, - }, + plugins: { + tooltip: { + position: 'middle', + intersect: false, + } + } } }); };
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
samples/tooltips/positioning.html
@@ -51,15 +51,17 @@ }, options: { responsive: true, - title: { - display: true, - text: 'Tooltip Position: ' + position - }, - tooltips: { - position: position, - mode: 'index', - intersect: false, - }, + plugins: { + title: { + display: true, + ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
src/controllers/controller.bubble.js
@@ -165,11 +165,13 @@ BubbleController.defaults = { type: 'linear' } }, - tooltips: { - callbacks: { - title() { - // Title doesn't make sense for scatter since we format the data as a point - return ''; + plugins: { + tooltip: { + callbacks: { + title() { + // Title doesn't make sense for s...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
src/controllers/controller.doughnut.js
@@ -344,36 +344,6 @@ DoughnutController.defaults = { animateScale: false }, aspectRatio: 1, - legend: { - labels: { - generateLabels(chart) { - const data = chart.data; - if (data.labels.length && data.datasets.length) { - return data.labels.map((label, i) => { - const meta = chart.getDatasetMe...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
src/controllers/controller.polarArea.js
@@ -172,46 +172,49 @@ PolarAreaController.defaults = { }, startAngle: 0, - legend: { - labels: { - generateLabels(chart) { - const data = chart.data; - if (data.labels.length && data.datasets.length) { - return data.labels.map((label, i) => { - const meta = chart.getDatasetMeta(0); - const ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
src/controllers/controller.scatter.js
@@ -24,13 +24,15 @@ ScatterController.defaults = { fill: false }, - tooltips: { - callbacks: { - title() { - return ''; // doesn't make sense for scatter since data are formatted as a point - }, - label(item) { - return '(' + item.label + ', ' + item.formattedValue + ')'; + plugins: { + tooltip...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
src/core/core.config.js
@@ -99,6 +99,21 @@ function mergeConfig(...args/* config objects ... */) { }); } +function includePluginDefaults(options) { + options.plugins = options.plugins || {}; + options.plugins.title = (options.plugins.title !== false) && merge(Object.create(null), [ + defaults.plugins.title, + options.plugins.title + ])...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
src/plugins/plugin.legend.js
@@ -654,7 +654,7 @@ export default { _element: Legend, beforeInit(chart) { - const legendOpts = resolveOptions(chart.options.legend); + const legendOpts = resolveOptions(chart.options.plugins.legend); if (legendOpts) { createNewLegendAndAttach(chart, legendOpts); @@ -665,7 +665,7 @@ export default { ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
src/plugins/plugin.title.js
@@ -230,15 +230,15 @@ export default { _element: Title, beforeInit(chart) { - const titleOpts = chart.options.title; + const titleOpts = chart.options.plugins.title; if (titleOpts) { createNewTitleBlockAndAttach(chart, titleOpts); } }, beforeUpdate(chart) { - const titleOpts = chart.options.t...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
src/plugins/plugin.tooltip.js
@@ -392,7 +392,7 @@ export class Tooltip extends Element { initialize() { const me = this; const chartOpts = me._chart.options; - me.options = resolveOptions(chartOpts.tooltips, chartOpts.font); + me.options = resolveOptions(chartOpts.plugins.tooltip, chartOpts.font); me._cachedAnimations = undefined; } ...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
test/fixtures/core.layouts/long-labels.js
@@ -8,8 +8,8 @@ module.exports = { labels: ['tick1 is very long one', 'tick2', 'tick3', 'tick4', 'tick5', 'tick6 is very long one'] }, options: { - legend: { - display: false + plugins: { + legend: false }, scales: { x: {
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
test/fixtures/core.layouts/scriptable.js
@@ -21,8 +21,8 @@ module.exports = { }; } }, - legend: { - display: false + plugins: { + legend: false }, scales: { x: {
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
test/fixtures/plugin.filler/fill-radar-boundary-start.json
@@ -20,8 +20,10 @@ "options": { "responsive": false, "spanGaps": false, - "legend": false, - "title": false, + "plugins": { + "legend": false, + "title": false + }, "scale": { "display"...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
test/fixtures/plugin.filler/fill-radar-dataset-spline.json
@@ -28,8 +28,10 @@ "options": { "responsive": false, "spanGaps": false, - "legend": false, - "title": false, + "plugins": { + "legend": false, + "title": false + }, "scale": { "display"...
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
test/fixtures/plugin.legend/legend-doughnut-bottom-center-mulitiline.json
@@ -10,9 +10,11 @@ }] }, "options": { - "legend": { - "position": "bottom", - "align": "center" + "plugins": { + "legend": { + "position": "bottom", + "align": "center" + } } } },
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
test/fixtures/plugin.legend/legend-doughnut-bottom-center-single.json
@@ -10,9 +10,11 @@ }] }, "options": { - "legend": { - "position": "bottom", - "align": "center" + "plugins": { + "legend": { + "position": "bottom", + "align": "center" + } } } },
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
test/fixtures/plugin.legend/legend-doughnut-bottom-end-mulitiline.json
@@ -10,9 +10,11 @@ }] }, "options": { - "legend": { - "position": "bottom", - "align": "end" + "plugins": { + "legend": { + "position": "bottom", + "align": "end" + } } } },
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
test/fixtures/plugin.legend/legend-doughnut-bottom-start-mulitiline.json
@@ -10,9 +10,11 @@ }] }, "options": { - "legend": { - "position": "bottom", - "align": "start" + "plugins": { + "legend": { + "position": "bottom", + "align": "start" + } } } },
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
test/fixtures/plugin.legend/legend-doughnut-left-center-mulitiline.json
@@ -10,9 +10,11 @@ }] }, "options": { - "legend": { - "position": "left", - "align": "center" + "plugins": { + "legend": { + "position": "left", + "align": "center" + } } } },
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
test/fixtures/plugin.legend/legend-doughnut-left-center-single.json
@@ -10,9 +10,11 @@ }] }, "options": { - "legend": { - "position": "left", - "align": "center" + "plugins": { + "legend": { + "position": "left", + "align": "center" + } } } },
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
test/fixtures/plugin.legend/legend-doughnut-left-default-center.json
@@ -10,8 +10,10 @@ }] }, "options": { - "legend": { - "position": "left" + "plugins": { + "legend": { + "position": "left" + } } } },
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
test/fixtures/plugin.legend/legend-doughnut-left-end-mulitiline.json
@@ -10,9 +10,11 @@ }] }, "options": { - "legend": { - "position": "left", - "align": "end" + "plugins": { + "legend": { + "position": "left", + "align": "end" + } } } },
true
Other
chartjs
Chart.js
913a01a3a629c5249850c66857ca5f7c76b9f322.json
Move title, tooltip and legend to options.plugins (#8089) * Move title, tooltip and legend to options.plugins * Update tooltip.md * Update legend.md and title.md * Add migration notes * typo * Types * Restore plurals * One more s, restore tabs * All plugins disabled * lint * cc
test/fixtures/plugin.legend/legend-doughnut-left-start-mulitiline.json
@@ -10,9 +10,11 @@ }] }, "options": { - "legend": { - "position": "left", - "align": "start" + "plugins": { + "legend": { + "position": "left", + "align": "start" + } } } },
true