language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
laravel
framework
66bfbd5cbb2ea482312d098aa3b9b1c27ce521e7.json
Apply fixes from StyleCI
src/Illuminate/Container/Container.php
@@ -462,6 +462,7 @@ public function extend($abstract, Closure $closure) * Register an existing instance as shared in the container. * * @template T + * * @param string $abstract * @param T $instance * @return T @@ -685,6 +686,7 @@ public function makeWith($abstract, array $pa...
true
Other
laravel
framework
66bfbd5cbb2ea482312d098aa3b9b1c27ce521e7.json
Apply fixes from StyleCI
src/Illuminate/Contracts/Container/Container.php
@@ -114,6 +114,7 @@ public function extend($abstract, Closure $closure); * Register an existing instance as shared in the container. * * @template T + * * @param string $abstract * @param T $instance * @return T @@ -157,6 +158,7 @@ public function flush(); * Resolve the...
true
Other
laravel
framework
66bfbd5cbb2ea482312d098aa3b9b1c27ce521e7.json
Apply fixes from StyleCI
src/Illuminate/Foundation/Application.php
@@ -830,6 +830,7 @@ public function registerDeferredProvider($provider, $service = null) * Resolve the given type from the container. * * @template T + * * @param class-string<T> $abstract * @param array $parameters * @return T|mixed
true
Other
laravel
framework
66bfbd5cbb2ea482312d098aa3b9b1c27ce521e7.json
Apply fixes from StyleCI
src/Illuminate/Foundation/helpers.php
@@ -107,6 +107,7 @@ function action($name, $parameters = [], $absolute = true) * Get the available container instance. * * @template T + * * @param class-string<T>|mixed $abstract * @param array $parameters * @return mixed|T|\Illuminate\Contracts\Foundation\Application
true
Other
laravel
framework
b722497e08ebf55b667b6b17808bc01907f8e62f.json
Use str_replace() instead of Str::replace().
src/Illuminate/Console/Scheduling/ScheduleTestCommand.php
@@ -4,7 +4,6 @@ use Illuminate\Console\Application; use Illuminate\Console\Command; -use Illuminate\Support\Str; class ScheduleTestCommand extends Command { @@ -55,7 +54,7 @@ public function handle(Schedule $schedule) $commandBinary = Application::phpBinary().' '.Application::artisanBinary(); ...
false
Other
laravel
framework
6cc602456ff3652a9b6178c4347e7f113965607b.json
use arrow functions for Database (#41532)
src/Illuminate/Database/Connectors/ConnectionFactory.php
@@ -177,7 +177,7 @@ protected function createPdoResolver(array $config) protected function createPdoResolverWithHosts(array $config) { return function () use ($config) { - foreach (Arr::shuffle($hosts = $this->parseHosts($config)) as $key => $host) { + foreach (Arr::shuffle($thi...
true
Other
laravel
framework
6cc602456ff3652a9b6178c4347e7f113965607b.json
use arrow functions for Database (#41532)
src/Illuminate/Database/DatabaseTransactionsManager.php
@@ -44,10 +44,9 @@ public function begin($connection, $level) */ public function rollback($connection, $level) { - $this->transactions = $this->transactions->reject(function ($transaction) use ($connection, $level) { - return $transaction->connection == $connection && - ...
true
Other
laravel
framework
91e517370e1700629f7f2be252da0f0fe62cce0e.json
Fix Style CI.
src/Illuminate/Console/Scheduling/ScheduleTestCommand.php
@@ -55,7 +55,7 @@ public function handle(Schedule $schedule) $commandBinary = Application::phpBinary().' '.Application::artisanBinary(); $matches = array_filter($commandNames, function ($commandName) use ($commandBinary, $name) { - return trim(Str::replace($commandBinary, '',...
false
Other
laravel
framework
650ca875d3bd7e876ed89f803c705d5d6c121d90.json
Add tests for ucsplit in stringable (#41499)
tests/Support/SupportStringableTest.php
@@ -150,6 +150,13 @@ public function testWhenContainsAll() })); } + public function testUcsplitOnStringable() + { + $this->assertSame(['Taylor', 'Otwell'], $this->stringable('TaylorOtwell')->ucsplit()->toArray()); + $this->assertSame(['Hello', 'From', 'Laravel'], $this->stringable('H...
false
Other
laravel
framework
d39d92df9b3c509d40b971207f03eb7f04087370.json
fix deprecation warning
src/Illuminate/Collections/Arr.php
@@ -169,6 +169,10 @@ public static function exists($array, $key) return $array->offsetExists($key); } + if (is_float($key)) { + $key = (string) $key; + } + return array_key_exists($key, $array); }
false
Other
laravel
framework
2d53f70fa20df3b72d996304db2d631fd2fefa6a.json
fix a typo (#41498)
CHANGELOG.md
@@ -19,7 +19,7 @@ - Added callable support to operatorForWhere on Collection ([#41414](https://github.com/laravel/framework/pull/41414), [#41424](https://github.com/laravel/framework/pull/41424)) - Added partial queue faking ([#41425](https://github.com/laravel/framework/pull/41425)) - Added --name option to schedul...
false
Other
laravel
framework
31e6062c552993cca958d9b71901bf6e05a2bc1e.json
fix method doctypes of Arr Support class (#41488)
src/Illuminate/Collections/Arr.php
@@ -25,7 +25,7 @@ public static function accessible($value) * Add an element to an array using "dot" notation if it doesn't exist. * * @param array $array - * @param string $key + * @param string|int|float $key * @param mixed $value * @return array */ @@ -599,7 +599,7...
true
Other
laravel
framework
31e6062c552993cca958d9b71901bf6e05a2bc1e.json
fix method doctypes of Arr Support class (#41488)
tests/Support/SupportArrTest.php
@@ -32,6 +32,8 @@ public function testAdd() $this->assertEquals(['surname' => 'Mövsümov'], Arr::add([], 'surname', 'Mövsümov')); $this->assertEquals(['developer' => ['name' => 'Ferid']], Arr::add([], 'developer.name', 'Ferid')); + $this->assertEquals([1 => 'hAz'], Arr::add([], 1, 'hAz')); + ...
true
Other
laravel
framework
a075753ad0385d755140b8c748e17cc3f95a8914.json
fix return type (#41457)
src/Illuminate/Routing/Route.php
@@ -1100,7 +1100,7 @@ public function excludedMiddleware() /** * Indicate that the route should enforce scoping of multiple implicit Eloquent bindings. * - * @return bool + * @return $this */ public function scopeBindings() {
false
Other
laravel
framework
a7b21b84732e8d1139003d30f72a5cc20a2f726d.json
Update AuthenticateSession.php (#41447)
src/Illuminate/Session/Middleware/AuthenticateSession.php
@@ -48,11 +48,11 @@ public function handle($request, Closure $next) } } - if (! $request->session()->has('password_hash_'.$this->auth->getDefaultDriver())) { + if (! $request->session()->has('password_hash_'.$this->guard()->getDefaultDriver())) { $this->storePasswordHa...
false
Other
laravel
framework
b71144ac57865b7e4a53fb23c7a901fc28362cbe.json
Update RouteListCommand.php (#41448)
src/Illuminate/Foundation/Console/RouteListCommand.php
@@ -452,7 +452,7 @@ protected function getOptions() ['path', null, InputOption::VALUE_OPTIONAL, 'Only show routes matching the given path pattern'], ['except-path', null, InputOption::VALUE_OPTIONAL, 'Do not display the routes matching the given path pattern'], ['reverse', 'r', In...
false
Other
laravel
framework
56831cb58b4da2801be55fca4ccc9a4c561eac82.json
define a new method to create a through model
src/Illuminate/Database/Eloquent/Concerns/HasRelationships.php
@@ -115,7 +115,7 @@ protected function newHasOne(Builder $query, Model $parent, $foreignKey, $localK */ public function hasOneThrough($related, $through, $firstKey = null, $secondKey = null, $localKey = null, $secondLocalKey = null) { - $through = new $through; + $through = $this->newThrou...
false
Other
laravel
framework
6a05d150eb828c852960517f9d15d99ea42f0f41.json
Update reserved names in GeneratorCommand (#41441) Since PHP 8.0 there are new keywords, which should be reserved in GeneratorCommand class.
src/Illuminate/Console/GeneratorCommand.php
@@ -56,6 +56,7 @@ abstract class GeneratorCommand extends Command 'endif', 'endswitch', 'endwhile', + 'enum', 'eval', 'exit', 'extends', @@ -76,13 +77,15 @@ abstract class GeneratorCommand extends Command 'interface', 'isset', 'list...
false
Other
laravel
framework
5319ddba567b3ccd94a21371a7ec760e4059e8a2.json
add string to docblocks
src/Illuminate/Collections/Enumerable.php
@@ -757,7 +757,7 @@ public function nth($step, $offset = 0); /** * Get the items with the specified keys. * - * @param \Illuminate\Support\Enumerable<array-key, TKey>|array<array-key, TKey> $keys + * @param \Illuminate\Support\Enumerable<array-key, TKey>|array<array-key, TKey>|string $keys ...
true
Other
laravel
framework
5319ddba567b3ccd94a21371a7ec760e4059e8a2.json
add string to docblocks
src/Illuminate/Collections/LazyCollection.php
@@ -861,7 +861,7 @@ public function nth($step, $offset = 0) /** * Get the items with the specified keys. * - * @param \Illuminate\Support\Enumerable<array-key, TKey>|array<array-key, TKey> $keys + * @param \Illuminate\Support\Enumerable<array-key, TKey>|array<array-key, TKey>|string $keys ...
true
Other
laravel
framework
352a6f173071d0ce8cb5659563a56dfca3891bfc.json
Update Collection.php (#41438)
src/Illuminate/Collections/Collection.php
@@ -856,7 +856,7 @@ public function nth($step, $offset = 0) /** * Get the items with the specified keys. * - * @param \Illuminate\Support\Enumerable<array-key, TKey>|array<array-key, TKey> $keys + * @param \Illuminate\Support\Enumerable<array-key, TKey>|array<array-key, TKey>|string $keys ...
false
Other
laravel
framework
9684a047dd9d29654a200d194a0f34ea390bb987.json
Add partial queue faking (#41425) * add partial queue faking * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <bot@styleci.io>
src/Illuminate/Support/Facades/Queue.php
@@ -42,11 +42,12 @@ public static function popUsing($workerName, $callback) /** * Replace the bound instance with a fake. * + * @param array|string $jobsToFake * @return \Illuminate\Support\Testing\Fakes\QueueFake */ - public static function fake() + public static function fake(...
true
Other
laravel
framework
9684a047dd9d29654a200d194a0f34ea390bb987.json
Add partial queue faking (#41425) * add partial queue faking * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <bot@styleci.io>
src/Illuminate/Support/Testing/Fakes/QueueFake.php
@@ -6,20 +6,51 @@ use Closure; use Illuminate\Contracts\Queue\Queue; use Illuminate\Queue\QueueManager; +use Illuminate\Support\Collection; use Illuminate\Support\Traits\ReflectsClosures; use PHPUnit\Framework\Assert as PHPUnit; class QueueFake extends QueueManager implements Queue { use ReflectsClosures;...
true
Other
laravel
framework
9684a047dd9d29654a200d194a0f34ea390bb987.json
Add partial queue faking (#41425) * add partial queue faking * Apply fixes from StyleCI Co-authored-by: StyleCI Bot <bot@styleci.io>
tests/Support/SupportTestingQueueFakeTest.php
@@ -5,7 +5,9 @@ use BadMethodCallException; use Illuminate\Bus\Queueable; use Illuminate\Foundation\Application; +use Illuminate\Queue\QueueManager; use Illuminate\Support\Testing\Fakes\QueueFake; +use Mockery as m; use PHPUnit\Framework\Constraint\ExceptionMessage; use PHPUnit\Framework\ExpectationFailedExceptio...
true
Other
laravel
framework
bf9f8f702f8f8847d95e7a6c79771ccf93370344.json
fix doc block
src/Illuminate/Filesystem/FilesystemAdapter.php
@@ -149,7 +149,7 @@ public function assertMissing($path) } /** - * Determine if a directory is empty. + * Assert that the given directory is empty. * * @param string $path * @return $this
false
Other
laravel
framework
e98ceae1f49029ec5e9be1e9a98c1546ae2b8f8d.json
Add empty directory assertion (#41398)
src/Illuminate/Filesystem/FilesystemAdapter.php
@@ -148,6 +148,21 @@ public function assertMissing($path) return $this; } + /** + * Determine if a directory is empty. + * + * @param string $path + * @return $this + */ + public function assertDirectoryEmpty($path) + { + PHPUnit::assertEmpty( + $this->al...
false
Other
laravel
framework
b7625b3f699a8b116b2bebbb917cab0f9f5127cf.json
Allow nested markdown files for mailables (#41366)
src/Illuminate/Foundation/Console/MailMakeCommand.php
@@ -102,7 +102,11 @@ protected function getView() $view = $this->option('markdown'); if (! $view) { - $view = 'mail.'.Str::kebab(class_basename($this->argument('name'))); + $name = str_replace('\\', '/', $this->argument('name')); + + $view = 'mail.'.collect(explode('...
false
Other
laravel
framework
aac0da02132d38cff8fe9ff6aee5f9b0ca689a18.json
Fix LazyCollection#takeUntilTimeout (#41370)
src/Illuminate/Collections/LazyCollection.php
@@ -1414,18 +1414,16 @@ public function takeUntilTimeout(DateTimeInterface $timeout) $timeout = $timeout->getTimestamp(); return new static(function () use ($timeout) { - $iterator = $this->getIterator(); - - if (! $iterator->valid() || $this->now() > $timeout) { + i...
true
Other
laravel
framework
aac0da02132d38cff8fe9ff6aee5f9b0ca689a18.json
Fix LazyCollection#takeUntilTimeout (#41370)
tests/Support/SupportLazyCollectionIsLazyTest.php
@@ -3,9 +3,11 @@ namespace Illuminate\Tests\Support; use Exception; +use Illuminate\Support\Carbon; use Illuminate\Support\ItemNotFoundException; use Illuminate\Support\LazyCollection; use Illuminate\Support\MultipleItemsFoundException; +use Mockery as m; use PHPUnit\Framework\TestCase; use stdClass; @@ -121...
true
Other
laravel
framework
aac0da02132d38cff8fe9ff6aee5f9b0ca689a18.json
Fix LazyCollection#takeUntilTimeout (#41370)
tests/Support/SupportLazyCollectionTest.php
@@ -196,32 +196,6 @@ public function testTakeUntilTimeout() m::close(); } - public function testTakeUntilTimeoutWithPastTimeout() - { - $timeout = Carbon::now()->subMinute(); - - $mock = m::mock(LazyCollection::class.'[now]'); - - $results = $mock - ->times(10) - ...
true
Other
laravel
framework
1846fb3e88818cfd3ec78150666a51295feddf7d.json
Add soleValue method to query builders
src/Illuminate/Database/Eloquent/Builder.php
@@ -614,6 +614,20 @@ public function value($column) } } + /** + * Get a single column's value from the first result of a query if it's the sole matching record. + * + * @param string|\Illuminate\Database\Query\Expression $column + * @return mixed + * + * @throws \Illuminate\...
true
Other
laravel
framework
1846fb3e88818cfd3ec78150666a51295feddf7d.json
Add soleValue method to query builders
src/Illuminate/Database/Query/Builder.php
@@ -2516,6 +2516,22 @@ public function value($column) return count($result) > 0 ? reset($result) : null; } + /** + * Get a single column's value from the first result of a query if it's the sole matching record. + * + * @param string $column + * @return mixed + * + * @throws...
true
Other
laravel
framework
8ce9c834f9f9124af425c27795853efaa2c6aaad.json
Fix typehint template
src/Illuminate/Collections/Collection.php
@@ -231,7 +231,7 @@ public function diff($items) * Get the items in the collection that are not present in the given items, using the callback. * * @param \Illuminate\Contracts\Support\Arrayable<array-key, TValue>|iterable<array-key, TValue> $items - * @param callable(TValue): int $callback + ...
true
Other
laravel
framework
8ce9c834f9f9124af425c27795853efaa2c6aaad.json
Fix typehint template
src/Illuminate/Collections/Enumerable.php
@@ -200,7 +200,7 @@ public function diff($items); * Get the items that are not present in the given items, using the callback. * * @param \Illuminate\Contracts\Support\Arrayable<array-key, TValue>|iterable<array-key, TValue> $items - * @param callable(TValue): int $callback + * @param cal...
true
Other
laravel
framework
8ce9c834f9f9124af425c27795853efaa2c6aaad.json
Fix typehint template
src/Illuminate/Collections/LazyCollection.php
@@ -307,7 +307,7 @@ public function diff($items) * Get the items that are not present in the given items, using the callback. * * @param \Illuminate\Contracts\Support\Arrayable<array-key, TValue>|iterable<array-key, TValue> $items - * @param callable(TValue): int $callback + * @param call...
true
Other
laravel
framework
0dc884a15a82c209c6a90c29a195c3b2f61d3521.json
remove constructor (#41325) I don't believe there's really any reason a constructor would be used in 99% of console commands. Any dependencies can be injected directly into the `handle()` method.
src/Illuminate/Foundation/Console/stubs/console.stub
@@ -20,16 +20,6 @@ class {{ class }} extends Command */ protected $description = 'Command description'; - /** - * Create a new command instance. - * - * @return void - */ - public function __construct() - { - parent::__construct(); - } - /** * Execute the conso...
false
Other
laravel
framework
03b673db7f3505d81ce737b2019133a250317bc8.json
Apply fixes from StyleCI
src/Illuminate/Console/Concerns/InteractsWithIO.php
@@ -377,7 +377,7 @@ public function alert($string) public function newLine($count = 1) { $this->output->newLine($count); - + return $this; }
false
Other
laravel
framework
5c77dac3ec8d397f73bb6dcd2d4b1bae010e9592.json
allow chaining of `->newLine()` (#41327) ```php $this->newLine(); $this->info('Success!'); ``` can now be shortened to ```php $this->newLine()->info('Success'); ```
src/Illuminate/Console/Concerns/InteractsWithIO.php
@@ -372,11 +372,13 @@ public function alert($string) * Write a blank line. * * @param int $count - * @return void + * @return $this */ public function newLine($count = 1) { $this->output->newLine($count); + + return $this; } /**
false
Other
laravel
framework
ecec6ca33280f3d9e93e294824cf5bd04424c255.json
remove `static` return types (#41276) these methods only return the Builder
src/Illuminate/Database/Eloquent/SoftDeletes.php
@@ -3,9 +3,9 @@ namespace Illuminate\Database\Eloquent; /** - * @method static static|\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder withTrashed(bool $withTrashed = true) - * @method static static|\Illuminate\Database\Eloquent\Builder|\Illuminate\Database\Query\Builder onlyTrashed() - * @m...
false
Other
laravel
framework
356b1221321be41f0721b29d03a35e1535929643.json
Use FQCN in docblocks
src/Illuminate/Conditionable/Traits/Conditionable.php
@@ -13,7 +13,7 @@ trait Conditionable * @template TWhenParameter * @template TWhenReturnType * - * @param (Closure($this): TWhenParameter)|TWhenParameter $value + * @param (\Closure($this): TWhenParameter)|TWhenParameter $value * @param (callable($this, TWhenParameter): TWhenReturnT...
false
Other
laravel
framework
aee3fc2bffe935ce238e0a733cbde098e931b24b.json
Fix typos in type hints (#41238)
src/Illuminate/Collections/Enumerable.php
@@ -1074,7 +1074,7 @@ public function pipe(callable $callback); /** * Pass the collection into a new class. * - * @param string-class $class + * @param class-string $class * @return mixed */ public function pipeInto($class);
true
Other
laravel
framework
aee3fc2bffe935ce238e0a733cbde098e931b24b.json
Fix typos in type hints (#41238)
src/Illuminate/Collections/Traits/EnumeratesValues.php
@@ -715,7 +715,7 @@ public function pipe(callable $callback) /** * Pass the collection into a new class. * - * @param string-class $class + * @param class-string $class * @return mixed */ public function pipeInto($class)
true
Other
laravel
framework
3f2162a8ca7ca29e48a6457568e4459a33f08974.json
Apply fixes from StyleCI
tests/Validation/ValidationValidatorTest.php
@@ -611,8 +611,8 @@ public function testIndexValuesAreReplaced() 'foo', 1, ], - ] - ] + ], + ], ], ['input.*.attributes.*' => 'string'], ['input.*.attributes.*.string' => 'Attribute (:firs...
false
Other
laravel
framework
972e4928a9eec8be4f45bc9257ac8ebe1e2c5400.json
Apply fixes from StyleCI
src/Illuminate/Database/DatabaseManager.php
@@ -404,7 +404,7 @@ public function extend($name, callable $resolver) */ public function forgetExtension($name) { - unset($this->extensions[$name]); + unset($this->extensions[$name]); } /**
false
Other
laravel
framework
9820e484d0d01bd9f0d4a194e1a614c8ead5541f.json
Remove useless imports. (#41220)
src/Illuminate/Translation/Translator.php
@@ -2,7 +2,6 @@ namespace Illuminate\Translation; -use Countable; use Illuminate\Contracts\Translation\Loader; use Illuminate\Contracts\Translation\Translator as TranslatorContract; use Illuminate\Support\Arr;
false
Other
laravel
framework
3ed70e93460c903b1a860d0d0572f2dcfdbfeb43.json
Pass listener arguments to middleware method
src/Illuminate/Events/Dispatcher.php
@@ -612,7 +612,7 @@ protected function createListenerAndJob($class, $method, $arguments) * Propagate listener options to the job. * * @param mixed $listener - * @param mixed $job + * @param \Illuminate\Events\CallQueuedListener $job * @return mixed */ protected function ...
true
Other
laravel
framework
3ed70e93460c903b1a860d0d0572f2dcfdbfeb43.json
Pass listener arguments to middleware method
tests/Events/QueuedEventsTest.php
@@ -116,7 +116,10 @@ public function testQueuePropagateMiddleware() $d->dispatch('some.event', ['foo', 'bar']); $fakeQueue->assertPushed(CallQueuedListener::class, function ($job) { - return count($job->middleware) === 1 && $job->middleware[0] instanceof TestMiddleware; + retur...
true
Other
laravel
framework
dabef8ae8bf74e0720301beabb46236d4c2d1b86.json
Fix typos (#41191)
CHANGELOG.md
@@ -6,16 +6,16 @@ ## [v9.2.0 (2022-02-22)](https://github.com/laravel/framework/compare/v9.1.0...v9.2.0) ### Added -- Added `Illuminate/Database/Eloquent/Casts/Attribute::make()` ([#41014](https://github.com/laravel/framework/pull/41014)) -- Added `Illuminate/Collections/Arr::keyBy()` ([#41029](https://github.com/l...
false
Other
laravel
framework
03e3a807fd8d5c2524800dcd8f7a57753330be67.json
Fix migrations $connection property (#41161) Despite being documented as allowing `Schema` queries to run on the given secondary connection, `Schema::connection()` must also be explicitly called to avoid `up()` and `down()` queries to be run on the default database connection. Instead this property is only used ...
src/Illuminate/Database/Migrations/Migrator.php
@@ -387,11 +387,11 @@ protected function runMigration($migration, $method) $migration->getConnection() ); - $callback = function () use ($migration, $method) { + $callback = function () use ($connection, $migration, $method) { if (method_exists($migration, $method)) { ...
true
Other
laravel
framework
03e3a807fd8d5c2524800dcd8f7a57753330be67.json
Fix migrations $connection property (#41161) Despite being documented as allowing `Schema` queries to run on the given secondary connection, `Schema::connection()` must also be explicitly called to avoid `up()` and `down()` queries to be run on the default database connection. Instead this property is only used ...
tests/Database/DatabaseMigratorIntegrationTest.php
@@ -37,6 +37,11 @@ protected function setUp(): void 'database' => ':memory:', ], 'sqlite2'); + $db->addConnection([ + 'driver' => 'sqlite', + 'database' => ':memory:', + ], 'sqlite3'); + $db->setAsGlobal(); $container = new Container; @@ -8...
true
Other
laravel
framework
03e3a807fd8d5c2524800dcd8f7a57753330be67.json
Fix migrations $connection property (#41161) Despite being documented as allowing `Schema` queries to run on the given secondary connection, `Schema::connection()` must also be explicitly called to avoid `up()` and `down()` queries to be run on the default database connection. Instead this property is only used ...
tests/Database/migrations/connection_configured/2022_02_21_000000_create_failed_jobs_table.php
@@ -0,0 +1,42 @@ +<?php + +use Illuminate\Database\Migrations\Migration; +use Illuminate\Database\Schema\Blueprint; +use Illuminate\Support\Facades\Schema; + +return new class extends Migration +{ + /** + * The database connection that should be used by the migration. + * + * @var string + */ + pr...
true
Other
laravel
framework
03e3a807fd8d5c2524800dcd8f7a57753330be67.json
Fix migrations $connection property (#41161) Despite being documented as allowing `Schema` queries to run on the given secondary connection, `Schema::connection()` must also be explicitly called to avoid `up()` and `down()` queries to be run on the default database connection. Instead this property is only used ...
tests/Database/migrations/connection_configured/2022_02_21_120000_create_jobs_table.php
@@ -0,0 +1,36 @@ +<?php + +use Illuminate\Database\Migrations\Migration; +use Illuminate\Database\Schema\Blueprint; +use Illuminate\Support\Facades\Schema; + +return new class extends Migration +{ + /** + * Run the migrations. + * + * @return void + */ + public function up() + { + Schema...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Cache/CacheManagerTest.php
@@ -56,7 +56,7 @@ public function testCustomDriverOverridesInternalDrivers() $driver = $cacheManager->store('my_store'); - $this->assertEquals('mm(u_u)mm', $driver->flag); + $this->assertSame('mm(u_u)mm', $driver->flag); } public function testItMakesRepositoryWhenContainerHasNoDis...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Cache/CacheRateLimiterTest.php
@@ -105,7 +105,7 @@ public function testAttemptsCallbackReturnsCallbackReturn() $rateLimiter = new RateLimiter($cache); - $this->assertEquals('foo', $rateLimiter->attempt('key', 1, function () { + $this->assertSame('foo', $rateLimiter->attempt('key', 1, function () { return 'foo'...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Console/ConsoleEventSchedulerTest.php
@@ -124,15 +124,15 @@ public function testItUsesCommandDescriptionAsEventDescription() { $schedule = $this->schedule; $event = $schedule->command(ConsoleCommandStub::class); - $this->assertEquals('This is a description about the command', $event->description); + $this->assertSame('T...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Cookie/CookieTest.php
@@ -120,10 +120,10 @@ public function testExpire() $cookieJar->expire('foobar', '/path', '/domain'); $cookie = $cookieJar->queued('foobar'); - $this->assertEquals('foobar', $cookie->getName()); + $this->assertSame('foobar', $cookie->getName()); $this->assertEquals(null, $cooki...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Database/DatabaseEloquentBelongsToManySyncReturnValueTypeTest.php
@@ -90,7 +90,7 @@ public function testSyncReturnValueType() }); $user->articles->each(function (BelongsToManySyncTestTestArticle $article) { - $this->assertEquals('0', $article->pivot->visible); + $this->assertSame('0', (string) $article->pivot->visible); }); } ...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Database/DatabaseEloquentBelongsToManySyncTouchesParentTest.php
@@ -89,7 +89,7 @@ public function testSyncWithDetachedValuesShouldTouch() Carbon::setTestNow('2021-07-20 19:13:14'); $result = $article->users()->sync([1, 2]); $this->assertCount(1, collect($result['detached'])); - $this->assertSame('3', collect($result['detached'])->first()); + ...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Database/DatabaseEloquentBelongsToTest.php
@@ -127,7 +127,7 @@ public function __toString() $this->assertEquals(1, $models[0]->foo->getAttribute('id')); $this->assertEquals(2, $models[1]->foo->getAttribute('id')); - $this->assertEquals('3', $models[2]->foo->getAttribute('id')); + $this->assertSame('3', (string) $models[2]->foo-...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Database/DatabaseEloquentHasOneTest.php
@@ -183,7 +183,7 @@ public function __toString() $this->assertEquals(1, $models[0]->foo->foreign_key); $this->assertEquals(2, $models[1]->foo->foreign_key); $this->assertNull($models[2]->foo); - $this->assertEquals('4', $models[3]->foo->foreign_key); + $this->assertSame('4', (st...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Database/DatabaseEloquentStrictMorphsTest.php
@@ -34,7 +34,7 @@ public function testStrictModeDoesNotThrowExceptionWhenMorphMap() ]); $morphName = $model->getMorphClass(); - $this->assertEquals('test', $morphName); + $this->assertSame('test', $morphName); } public function testMapsCanBeEnforcedInOneMethod() @@ -48,7 +4...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Foundation/FoundationFormRequestTest.php
@@ -135,7 +135,7 @@ public function testValidatedMethodReturnsOnlyRequestedValidatedData() $request->validateResolved(); - $this->assertEquals('specified', $request->validated('name')); + $this->assertSame('specified', $request->validated('name')); } public function testValidatedM...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Foundation/Testing/Concerns/InteractsWithViewsTest.php
@@ -14,7 +14,7 @@ public function testBladeCorrectlyRendersString() { $string = (string) $this->blade('@if(true)test @endif'); - $this->assertEquals('test ', $string); + $this->assertSame('test ', $string); } public function testComponentCanAccessPublicProperties() @@ -36,8 +36...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Http/Middleware/TrustProxiesTest.php
@@ -26,9 +26,9 @@ public function test_request_does_not_trust() { $req = $this->createProxiedRequest(); - $this->assertEquals('192.168.10.10', $req->getClientIp(), 'Assert untrusted proxy x-forwarded-for header not used'); - $this->assertEquals('http', $req->getScheme(), 'Assert untrusted ...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Integration/Database/DatabaseCustomCastsTest.php
@@ -37,7 +37,7 @@ public function test_custom_casting() $this->assertEquals(['name' => 'Taylor'], $model->array_object->toArray()); $this->assertEquals(['name' => 'Taylor'], $model->collection->toArray()); - $this->assertEquals('Taylor', (string) $model->stringable); + $this->assertSam...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Integration/Database/DatabaseEloquentBroadcastingTest.php
@@ -47,7 +47,7 @@ public function testChannelRouteFormatting() { $model = new TestEloquentBroadcastUser; - $this->assertEquals('Illuminate.Tests.Integration.Database.TestEloquentBroadcastUser.{testEloquentBroadcastUser}', $model->broadcastChannelRoute()); + $this->assertSame('Illuminate.Te...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Integration/Database/EloquentBelongsToManyTest.php
@@ -138,7 +138,7 @@ public function testCustomPivotClass() $post->tagsWithCustomPivot()->attach($tag->id); $this->assertInstanceOf(PostTagPivot::class, $post->tagsWithCustomPivot[0]->pivot); - $this->assertEquals('1507630210', $post->tagsWithCustomPivot[0]->pivot->created_at); + $this-...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Integration/Database/EloquentCollectionLoadCountTest.php
@@ -47,9 +47,9 @@ public function testLoadCount() $posts->loadCount('comments'); $this->assertCount(1, DB::getQueryLog()); - $this->assertEquals('2', $posts[0]->comments_count); - $this->assertEquals('0', $posts[1]->comments_count); - $this->assertEquals('2', $posts[0]->getOrigi...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Integration/Database/QueryingWithEnumsTest.php
@@ -38,7 +38,7 @@ public function testCanQueryWithEnums() $this->assertNotNull($record); $this->assertNotNull($record2); $this->assertNotNull($record3); - $this->assertEquals('pending', $record->string_status); + $this->assertSame('pending', $record->string_status); $th...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Integration/Http/Middleware/HandleCorsTest.php
@@ -47,7 +47,7 @@ public function testShouldReturnHeaderAssessControlAllowOriginWhenDontHaveHttpOr 'HTTP_ACCESS_CONTROL_REQUEST_METHOD' => 'POST', ]); - $this->assertEquals('http://localhost', $crawler->headers->get('Access-Control-Allow-Origin')); + $this->assertSame('http://local...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Integration/Support/MultipleInstanceManagerTest.php
@@ -12,10 +12,10 @@ public function test_configurable_instances_can_be_resolved() $manager = new MultipleInstanceManager($this->app); $fooInstance = $manager->instance('foo'); - $this->assertEquals('option-value', $fooInstance->config['foo-option']); + $this->assertSame('option-value',...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Mail/MailMessageTest.php
@@ -75,7 +75,7 @@ public function testReplyToMethod() public function testSubjectMethod() { $this->assertInstanceOf(Message::class, $message = $this->message->subject('foo')); - $this->assertEquals('foo', $message->getSymfonyMessage()->getSubject()); + $this->assertSame('foo', $message-...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Queue/QueueSyncQueueTest.php
@@ -74,7 +74,7 @@ public function testCreatesPayloadObject() try { $sync->push(new SyncQueueJob()); } catch (LogicException $e) { - $this->assertEquals('extraValue', $e->getMessage()); + $this->assertSame('extraValue', $e->getMessage()); } } }
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Routing/RoutingRouteTest.php
@@ -549,7 +549,7 @@ public function testNonGreedyMatches() $route->bind($request1); $this->assertTrue($route->hasParameter('id')); $this->assertFalse($route->hasParameter('foo')); - $this->assertSame('1', $route->parameter('id')); + $this->assertSame('1', (string) $route->parame...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Support/SupportArrTest.php
@@ -861,7 +861,7 @@ public function testToCssClasses() 'mt-4', ]); - $this->assertEquals('font-bold mt-4', $classes); + $this->assertSame('font-bold mt-4', $classes); $classes = Arr::toCssClasses([ 'font-bold', @@ -870,7 +870,7 @@ public function testToCssCl...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Support/SupportCollectionTest.php
@@ -2152,31 +2152,31 @@ public function testGetOrPut() { $data = new Collection(['name' => 'taylor', 'email' => 'foo']); - $this->assertEquals('taylor', $data->getOrPut('name', null)); - $this->assertEquals('foo', $data->getOrPut('email', null)); - $this->assertEquals('male', $data-...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Support/SupportJsTest.php
@@ -12,10 +12,10 @@ class SupportJsTest extends TestCase { public function testScalars() { - $this->assertEquals('false', (string) Js::from(false)); - $this->assertEquals('true', (string) Js::from(true)); - $this->assertEquals('1', (string) Js::from(1)); - $this->assertEquals('1.1...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Support/SupportStringableTest.php
@@ -910,23 +910,23 @@ public function testMarkdown() public function testMask() { - $this->assertEquals('tay*************', $this->stringable('taylor@email.com')->mask('*', 3)); - $this->assertEquals('******@email.com', $this->stringable('taylor@email.com')->mask('*', 0, 6)); - $this->a...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Support/ValidatedInputTest.php
@@ -11,8 +11,8 @@ public function test_can_access_input() { $input = new ValidatedInput(['name' => 'Taylor', 'votes' => 100]); - $this->assertEquals('Taylor', $input->name); - $this->assertEquals('Taylor', $input['name']); + $this->assertSame('Taylor', $input->name); + $this-...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Testing/ParallelTestingTest.php
@@ -36,7 +36,7 @@ public function testCallbacks($callback) $this->assertNull($testCase); } - $this->assertSame('1', $token); + $this->assertSame('1', (string) $token); $state = true; }); @@ -83,7 +83,7 @@ public function testToken() ...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Testing/TestResponseTest.php
@@ -1627,8 +1627,8 @@ public function testGetDecryptedCookie() $cookie = $response->getCookie('cookie-name', false); $this->assertInstanceOf(Cookie::class, $cookie); - $this->assertEquals('cookie-name', $cookie->getName()); - $this->assertEquals('cookie-value', $cookie->getValue()); + ...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Validation/ValidationExceptionTest.php
@@ -14,21 +14,21 @@ public function testExceptionSummarizesZeroErrors() { $exception = $this->getException([], []); - $this->assertEquals('The given data was invalid.', $exception->getMessage()); + $this->assertSame('The given data was invalid.', $exception->getMessage()); } pu...
true
Other
laravel
framework
4c95784ed7de0ec8809072f3c8e16d8b9847fc28.json
Enforce stricter assertions. (#41165)
tests/Validation/ValidationRuleParserTest.php
@@ -97,7 +97,7 @@ public function testExplodeProperlyParsesSingleRegexRule() ['items.*.type' => 'regex:/^(foo|bar)$/i'] ); - $this->assertEquals('regex:/^(foo|bar)$/i', $exploded->rules['items.0.type'][0]); + $this->assertSame('regex:/^(foo|bar)$/i', $exploded->rules['items.0.type'...
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Bus/Queueable.php
@@ -127,7 +127,7 @@ public function allOnQueue($queue) } /** - * Set the desired delay for the job. + * Set the desired delay in seconds for the job. * * @param \DateTimeInterface|\DateInterval|int|null $delay * @return $this
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Contracts/Mail/Mailable.php
@@ -23,7 +23,7 @@ public function send($mailer); public function queue(Queue $queue); /** - * Deliver the queued message after the given delay. + * Deliver the queued message after (n) seconds. * * @param \DateTimeInterface|\DateInterval|int $delay * @param \Illuminate\Contracts...
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Contracts/Queue/Job.php
@@ -33,9 +33,7 @@ public function payload(); public function fire(); /** - * Release the job back into the queue. - * - * Accepts a delay specified in seconds. + * Release the job back into the queue after (n) seconds. * * @param int $delay * @return void
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Contracts/Queue/Queue.php
@@ -43,7 +43,7 @@ public function pushOn($queue, $job, $data = ''); public function pushRaw($payload, $queue = null, array $options = []); /** - * Push a new job onto the queue after a delay. + * Push a new job onto the queue after (n) seconds. * * @param \DateTimeInterface|\DateInterva...
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Events/QueuedClosure.php
@@ -80,7 +80,7 @@ public function onQueue($queue) } /** - * Set the desired delay for the job. + * Set the desired delay in seconds for the job. * * @param \DateTimeInterface|\DateInterval|int|null $delay * @return $this
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Foundation/Bus/PendingChain.php
@@ -91,7 +91,7 @@ public function onQueue($queue) } /** - * Set the desired delay for the chain. + * Set the desired delay in seconds for the chain. * * @param \DateTimeInterface|\DateInterval|int|null $delay * @return $this
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Foundation/Bus/PendingDispatch.php
@@ -88,7 +88,7 @@ public function allOnQueue($queue) } /** - * Set the desired delay for the job. + * Set the desired delay in seconds for the job. * * @param \DateTimeInterface|\DateInterval|int|null $delay * @return $this
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Mail/Mailable.php
@@ -233,7 +233,7 @@ public function queue(Queue $queue) } /** - * Deliver the queued message after the given delay. + * Deliver the queued message after (n) seconds. * * @param \DateTimeInterface|\DateInterval|int $delay * @param \Illuminate\Contracts\Queue\Factory $queue
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Mail/PendingMail.php
@@ -136,7 +136,7 @@ public function queue(MailableContract $mailable) } /** - * Deliver the queued message after the given delay. + * Deliver the queued message after (n) seconds. * * @param \DateTimeInterface|\DateInterval|int $delay * @param \Illuminate\Contracts\Mail\Mailable...
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Queue/BeanstalkdQueue.php
@@ -110,7 +110,7 @@ public function pushRaw($payload, $queue = null, array $options = []) } /** - * Push a new job onto the queue after a delay. + * Push a new job onto the queue after (n) seconds. * * @param \DateTimeInterface|\DateInterval|int $delay * @param string $job
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Queue/Capsule/Manager.php
@@ -114,7 +114,7 @@ public static function bulk($jobs, $data = '', $queue = null, $connection = null } /** - * Push a new job onto the queue after a delay. + * Push a new job onto the queue after (n) seconds. * * @param \DateTimeInterface|\DateInterval|int $delay * @param string...
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Queue/DatabaseQueue.php
@@ -112,7 +112,7 @@ public function pushRaw($payload, $queue = null, array $options = []) } /** - * Push a new job onto the queue after a delay. + * Push a new job onto the queue after (n) seconds. * * @param \DateTimeInterface|\DateInterval|int $delay * @param string $job @@ -...
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Queue/InteractsWithQueue.php
@@ -49,7 +49,7 @@ public function fail($exception = null) } /** - * Release the job back into the queue. + * Release the job back into the queue after (n) seconds. * * @param int $delay * @return void
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Queue/Jobs/BeanstalkdJob.php
@@ -43,7 +43,7 @@ public function __construct(Container $container, Pheanstalk $pheanstalk, Pheans } /** - * Release the job back into the queue. + * Release the job back into the queue after (n) seconds. * * @param int $delay * @return void
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Queue/Jobs/DatabaseJob.php
@@ -42,7 +42,7 @@ public function __construct(Container $container, DatabaseQueue $database, $job, } /** - * Release the job back into the queue. + * Release the job back into the queue after (n) seconds. * * @param int $delay * @return void
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Queue/Jobs/Job.php
@@ -119,7 +119,7 @@ public function isDeleted() } /** - * Release the job back into the queue. + * Release the job back into the queue after (n) seconds. * * @param int $delay * @return void
true
Other
laravel
framework
ed8d75bfa193415986495016e89aac5f9ef0d96b.json
Clarify delay time (#41167)
src/Illuminate/Queue/Jobs/RedisJob.php
@@ -85,7 +85,7 @@ public function delete() } /** - * Release the job back into the queue. + * Release the job back into the queue after (n) seconds. * * @param int $delay * @return void
true