language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
laravel
framework
8c16891c6e7a4738d63788f4447614056ab5136e.json
add isCallable helper
tests/Support/SupportReflectorTest.php
@@ -57,6 +57,16 @@ public function testUnionTypeName() $this->assertNull(Reflector::getParameterClassName($method->getParameters()[0])); } + + public function testIsCallable() + { + $this->assertTrue(Reflector::isCallable(function () {})); + $this->assertTrue(Reflector::isCallable([B...
true
Other
laravel
framework
826a90f660016bd66326ae823a077ae10a868b28.json
Remove throw in BoundMethod (#34970)
src/Illuminate/Container/BoundMethod.php
@@ -3,7 +3,6 @@ namespace Illuminate\Container; use Closure; -use Illuminate\Contracts\Container\BindingResolutionException; use InvalidArgumentException; use ReflectionFunction; use ReflectionMethod; @@ -174,10 +173,6 @@ protected static function addDependencyForCallParameter($container, $parameter, ...
true
Other
laravel
framework
826a90f660016bd66326ae823a077ae10a868b28.json
Remove throw in BoundMethod (#34970)
tests/Container/ContainerCallTest.php
@@ -91,6 +91,13 @@ public function testCallWithBoundMethod() $this->assertSame('taylor', $result[1]); } + public function testCallWithUnnamedParameters() + { + $container = new Container; + $result = $container->call([new ContainerTestCallStub, 'unresolvable'], ['foo', 'bar']); + ...
true
Other
laravel
framework
3f0645cf38f51b235ec280b35922e3fe84f0be96.json
Add docblock for `Storage::extend()` (#34961)
src/Illuminate/Support/Facades/Storage.php
@@ -18,6 +18,7 @@ * @method static bool delete(string|array $paths) * @method static bool deleteDirectory(string $directory) * @method static bool exists(string $path) + * @method static \Illuminate\Filesystem\FilesystemManager extend(string $driver, \Closure $callback) * @method static bool makeDirectory(strin...
false
Other
laravel
framework
d5172d47326714a564b786e61800f8083f9d3d20.json
Remove unused use statement
src/Illuminate/Database/Console/Migrations/FreshCommand.php
@@ -6,7 +6,6 @@ use Illuminate\Console\ConfirmableTrait; use Illuminate\Contracts\Events\Dispatcher; use Illuminate\Database\Events\DatabaseRefreshed; -use Illuminate\Database\Migrations\Migrator; use Symfony\Component\Console\Input\InputOption; class FreshCommand extends Command
false
Other
laravel
framework
1cf55138ac28989a4a8f0f2d6d63784a54dd1061.json
Add types for casting encrypted strings to objects
src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php
@@ -72,6 +72,10 @@ trait HasAttributes 'decimal', 'double', 'encrypted', + 'encrypted:array', + 'encrypted:collection', + 'encrypted:json', + 'encrypted:object', 'float', 'int', 'integer', @@ -525,6 +529,14 @@ protected function castAttri...
true
Other
laravel
framework
1cf55138ac28989a4a8f0f2d6d63784a54dd1061.json
Add types for casting encrypted strings to objects
tests/Integration/Database/EloquentModelEncryptedCastingTest.php
@@ -5,6 +5,7 @@ use Illuminate\Contracts\Encryption\Encrypter; use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Schema\Blueprint; +use Illuminate\Support\Collection; use Illuminate\Support\Facades\Crypt; use Illuminate\Support\Facades\Schema; @@ -25,6 +26,10 @@ protected function setUp(): void ...
true
Other
laravel
framework
dae0cb962dbf6f48f9b5bd7dccd932b7833f41bc.json
add tests to dispatcher (#34940)
tests/Events/EventsDispatcherTest.php
@@ -26,6 +26,14 @@ public function testBasicEventExecution() $this->assertEquals([null], $response); $this->assertSame('bar', $_SERVER['__event.test']); + + // we can still add listeners after the event has fired + $d->listen('foo', function ($foo) { + $_SERVER['__event.test...
false
Other
laravel
framework
f22333a7c0bb550a9bc9463f26695c256cbfb10e.json
Remove trailing comma (#34945)
src/Illuminate/Bus/BusServiceProvider.php
@@ -47,7 +47,7 @@ protected function registerBatchServices() return new DatabaseBatchRepository( $app->make(BatchFactory::class), $app->make('db')->connection(config('queue.batching.database')), - config('queue.batching.table', 'job_batches'), + ...
false
Other
laravel
framework
b14367393e59e1d7f1a91cb889a988d5b684c54a.json
Fix higher order messaging annotations (#34929)
src/Illuminate/Collections/Traits/EnumeratesValues.php
@@ -35,7 +35,11 @@ * @property-read HigherOrderCollectionProxy $some * @property-read HigherOrderCollectionProxy $sortBy * @property-read HigherOrderCollectionProxy $sortByDesc + * @property-read HigherOrderCollectionProxy $skipUntil + * @property-read HigherOrderCollectionProxy $skipWhile * @property-read High...
false
Other
laravel
framework
0e33004fee1df5574bcc28ea95f2ada16f5ad8ae.json
Fix undefined variable error for id (#34878)
src/Illuminate/Queue/Console/RetryBatchCommand.php
@@ -28,7 +28,7 @@ class RetryBatchCommand extends Command */ public function handle() { - $batch = $this->laravel[BatchRepository::class]->find($this->argument('id')); + $batch = $this->laravel[BatchRepository::class]->find($id = $this->argument('id')); if (! $batch) { ...
false
Other
laravel
framework
f857dd2248df3b909cb7dd0bd47c9117f8a38a39.json
Improve Bus::batch() doc block (#34888)
src/Illuminate/Bus/Dispatcher.php
@@ -146,7 +146,7 @@ public function findBatch(string $batchId) /** * Create a new batch of queueable jobs. * - * @param \Illuminate\Support\Collection|array $jobs + * @param \Illuminate\Support\Collection|array|mixed $jobs * @return \Illuminate\Bus\PendingBatch */ public fu...
true
Other
laravel
framework
f857dd2248df3b909cb7dd0bd47c9117f8a38a39.json
Improve Bus::batch() doc block (#34888)
src/Illuminate/Support/Facades/Bus.php
@@ -8,7 +8,7 @@ /** * @method static \Illuminate\Bus\Batch|null findBatch(string $batchId) - * @method static \Illuminate\Bus\PendingBatch batch(array $jobs) + * @method static \Illuminate\Bus\PendingBatch batch(array|mixed $jobs) * @method static \Illuminate\Contracts\Bus\Dispatcher map(array $map) * @method ...
true
Other
laravel
framework
3e4f5f4b771fbdc12a10db1694d55c7c91441161.json
Fix config item referenced. (#34852)
src/Illuminate/Queue/Console/BatchesTableCommand.php
@@ -57,7 +57,7 @@ public function __construct(Filesystem $files, Composer $composer) */ public function handle() { - $table = $this->laravel['config']['queue.batches.table'] ?? 'job_batches'; + $table = $this->laravel['config']['queue.batching.table'] ?? 'job_batches'; $this->re...
false
Other
laravel
framework
11d747064030963c906412012ac8f6581711022e.json
add multiple_of custom replacer (#34858)
src/Illuminate/Validation/Concerns/ReplacesAttributes.php
@@ -104,6 +104,20 @@ protected function replaceMax($message, $attribute, $rule, $parameters) return str_replace(':max', $parameters[0], $message); } + /** + * Replace all place-holders for the multiple_of rule. + * + * @param string $message + * @param string $attribute + * @p...
true
Other
laravel
framework
11d747064030963c906412012ac8f6581711022e.json
add multiple_of custom replacer (#34858)
tests/Validation/ValidationValidatorTest.php
@@ -1857,9 +1857,16 @@ public function testValidateMax() public function testValidateMutlpleOf($input, $allowed, $passes) { $trans = $this->getIlluminateArrayTranslator(); + $trans->addLines(['validation.multiple_of' => 'The :attribute must be a multiple of :value'], 'en'); $v = new...
true
Other
laravel
framework
de94375ece99b258dc71ab905283cf09636a464d.json
Add Redis rate limiting job middleware
src/Illuminate/Queue/Middleware/RateLimitsJobsWithRedis.php
@@ -0,0 +1,90 @@ +<?php + +namespace Illuminate\Queue\Middleware; + +use Illuminate\Container\Container; +use Illuminate\Contracts\Redis\Factory as Redis; +use Illuminate\Redis\Limiters\DurationLimiter; +use Illuminate\Support\InteractsWithTime; + +class RateLimitsJobsWithRedis extends RateLimitsJobs +{ + use Intera...
true
Other
laravel
framework
de94375ece99b258dc71ab905283cf09636a464d.json
Add Redis rate limiting job middleware
tests/Integration/Queue/RateLimitsJobsWithRedisTest.php
@@ -0,0 +1,176 @@ +<?php + +namespace Illuminate\Tests\Integration\Queue; + +use Illuminate\Bus\Dispatcher; +use Illuminate\Bus\Queueable; +use Illuminate\Cache\RateLimiter; +use Illuminate\Cache\RateLimiting\Limit; +use Illuminate\Contracts\Queue\Job; +use Illuminate\Foundation\Testing\Concerns\InteractsWithRedis; +us...
true
Other
laravel
framework
673b35051892debc514fe752dc965e5a3d2bf6ae.json
fix docblock typo
src/Illuminate/Queue/Middleware/PreventOverlappingJobs.php
@@ -33,7 +33,6 @@ class PreventOverlappingJobs * @param string $key * @param string $prefix * @param int $expiresAt - * @param string $prefix * * @return void */
false
Other
laravel
framework
86d08e4b743a37269790482a516936e63f4e881b.json
add `dropConstrainedForeignId` method (#34806)
src/Illuminate/Database/Schema/Blueprint.php
@@ -383,6 +383,19 @@ public function dropForeign($index) return $this->dropIndexCommand('dropForeign', 'foreign', $index); } + /** + * Indicate that the given column and foreign key should be dropped. + * + * @param string $column + * @return \Illuminate\Support\Fluent + */ + ...
true
Other
laravel
framework
86d08e4b743a37269790482a516936e63f4e881b.json
add `dropConstrainedForeignId` method (#34806)
tests/Database/DatabaseSqlServerSchemaGrammarTest.php
@@ -176,6 +176,17 @@ public function testDropForeign() $this->assertSame('alter table "users" drop constraint "foo"', $statements[0]); } + public function testdropConstrainedForeignId() + { + $blueprint = new Blueprint('users'); + $blueprint->dropConstrainedForeignId('foo'); + ...
true
Other
laravel
framework
aa31b9c00fae5e08c25f150d92ccd6cd8f1b7130.json
Add expiry option for the lock
src/Illuminate/Queue/Middleware/PreventOverlappingJobs.php
@@ -6,6 +6,13 @@ class PreventOverlappingJobs { + /** + * The amount of time (in seconds) to expire the lock. + * + * @var int + */ + public $expiresAt; + /** * The key of the job. * @@ -24,15 +31,17 @@ class PreventOverlappingJobs * Create a new overlapping jobs middlew...
false
Other
laravel
framework
b960fd0d3d9e498219e21a88edc0fe18537c28ab.json
Update docblock and include strings (#34779)
src/Illuminate/Console/Scheduling/ManagesFrequencies.php
@@ -473,7 +473,7 @@ public function yearly() * Schedule the event to run yearly on a given month, day, and time. * * @param int $month - * @param int $dayOfMonth + * @param int|string $dayOfMonth * @param string $time * @return $this */
true
Other
laravel
framework
b960fd0d3d9e498219e21a88edc0fe18537c28ab.json
Update docblock and include strings (#34779)
tests/Console/Scheduling/FrequencyTest.php
@@ -169,7 +169,12 @@ public function testYearlyOn() $this->assertSame('8 15 5 4 *', $this->event->yearlyOn(4, 5, '15:08')->getExpression()); } - public function testYearlyOnTuesdays() + public function testYearlyOnMondaysOnly() + { + $this->assertSame('1 9 * 7 1', $this->event->mondays()...
true
Other
laravel
framework
4c6fa9c6b5b92c13415e89bfebf11818fca315a1.json
Apply fixes from StyleCI (#34751)
src/Illuminate/Console/Scheduling/ScheduleWorkCommand.php
@@ -4,7 +4,6 @@ use Illuminate\Console\Command; use Illuminate\Support\Carbon; -use Illuminate\Support\Str; use Symfony\Component\Process\Process; class ScheduleWorkCommand extends Command
false
Other
laravel
framework
278db36b876c0be206bf40cf66176a8cf562dcd8.json
Update param type (#34748)
src/Illuminate/Foundation/Console/stubs/cast.stub
@@ -25,7 +25,7 @@ class DummyClass implements CastsAttributes * * @param \Illuminate\Database\Eloquent\Model $model * @param string $key - * @param array $value + * @param mixed $value * @param array $attributes * @return mixed */
false
Other
laravel
framework
9245807f8a1132a30ce669513cf0e99e9e078267.json
fix collection wrapping
src/Illuminate/Database/Eloquent/Factories/BelongsToManyRelationship.php
@@ -3,6 +3,7 @@ namespace Illuminate\Database\Eloquent\Factories; use Illuminate\Database\Eloquent\Model; +use Illuminate\Support\Collection; class BelongsToManyRelationship { @@ -50,7 +51,7 @@ public function __construct(Factory $factory, $pivot, $relationship) */ public function createFor(Model $mo...
false
Other
laravel
framework
41305c1dd152824c3b48f7efae5f65a5a768ef2a.json
Apply fixes from StyleCI (#34732)
src/Illuminate/Database/Eloquent/Builder.php
@@ -906,7 +906,7 @@ protected function addTimestampsToUpsertValues(array $values) $columns = array_filter([ $this->model->getCreatedAtColumn(), - $this->model->getUpdatedAtColumn() + $this->model->getUpdatedAtColumn(), ]); foreach ($columns as $column) {
false
Other
laravel
framework
ec98e98f8609b3e56400829e5ebe108c45517037.json
Add missing Scheduler tests (#34723)
tests/Console/Scheduling/FrequencyTest.php
@@ -34,18 +34,36 @@ public function testEveryXMinutes() $this->assertSame('*/3 * * * *', $this->event->everyThreeMinutes()->getExpression()); $this->assertSame('*/4 * * * *', $this->event->everyFourMinutes()->getExpression()); $this->assertSame('*/5 * * * *', $this->event->everyFiveMinutes()-...
false
Other
laravel
framework
12d6a4e12ca23f63ab7852bfb052ba5c257f1fb1.json
add dropColumns method on the schema class
src/Illuminate/Database/Schema/Builder.php
@@ -415,7 +415,7 @@ public function blueprintResolver(Closure $resolver) */ public function dropColumns($table, $columns) { - $this->table($table, function (Blueprint $blueprint) use ($table, $columns) { + $this->table($table, function (Blueprint $blueprint) use ($columns) { $...
false
Other
laravel
framework
fc600c4594f0122be5f455cbeb908d1af8373ffd.json
add dropColumns method on the schema class
src/Illuminate/Database/Schema/Builder.php
@@ -405,4 +405,18 @@ public function blueprintResolver(Closure $resolver) { $this->resolver = $resolver; } + + /** + * Drop columns from a table schema. + * + * @param string $table + * @param string|array $columns + * @return void + */ + public function dropColumns(...
true
Other
laravel
framework
fc600c4594f0122be5f455cbeb908d1af8373ffd.json
add dropColumns method on the schema class
src/Illuminate/Support/Facades/Schema.php
@@ -12,6 +12,7 @@ * @method static \Illuminate\Database\Schema\Builder table(string $table, \Closure $callback) * @method static bool hasColumn(string $table, string $column) * @method static bool hasColumns(string $table, array $columns) + * @method static bool dropColumns(string $table, array $columns) * @met...
true
Other
laravel
framework
338ffa625e4b16ccd3d3481371c9312a245fdc30.json
Add tests for upserts with update columns
tests/Database/DatabaseQueryBuilderTest.php
@@ -2211,6 +2211,29 @@ public function testUpsertMethod() $this->assertEquals(2, $result); } + public function testUpsertMethodWithUpdateColumns() + { + $builder = $this->getMySqlBuilder(); + $builder->getConnection()->shouldReceive('affectingStatement')->once()->with('insert into `u...
false
Other
laravel
framework
3722acdf4f53e27812fccce3596d6691efd47d0d.json
use FQN for throws tag
src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php
@@ -1112,7 +1112,8 @@ protected function isClassCastable($key) * * @param string $key * @return bool - * @throws InvalidCastException + * + * @throws \Illuminate\Database\Eloquent\InvalidCastException */ protected function isClassSerializable($key) {
false
Other
laravel
framework
524cf5b9c3700a5d50121f4e6448e08d81c62c1c.json
Update ListFailedCommand.php (#34696)
src/Illuminate/Queue/Console/ListFailedCommand.php
@@ -66,7 +66,7 @@ protected function parseFailedJob(array $failed) { $row = array_values(Arr::except($failed, ['payload', 'exception'])); - array_splice($row, 3, 0, $this->extractJobName($failed['payload'])); + array_splice($row, 3, 0, $this->extractJobName($failed['payload']) ?: ''); ...
false
Other
laravel
framework
884dd4ab56848949fc25d15c3036981446953bd1.json
Add attachMany method to the PendingRequest.php With this method, we can attach multiple files instead of using `attach` for each file.
src/Illuminate/Http/Client/PendingRequest.php
@@ -200,6 +200,21 @@ public function attach($name, $contents, $filename = null, array $headers = []) return $this; } + + /** + * Attach multiple files to the request. Accepts an array containing arrays of files + * + * @param array $files + * @return $this + */ + public f...
false
Other
laravel
framework
f00248acf69c35570326ba9a6870d8750ff6f23d.json
remove extra line
src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php
@@ -1107,7 +1107,6 @@ protected function isClassCastable($key) throw new InvalidCastException($this->getModel(), $key, $castType); } - /** * Determine if the key is serializable using a custom class. *
false
Other
laravel
framework
bd02d3df746d635cbe120a243083d98ac950ca60.json
Add attachMany method to the PendingRequest.php With this method, we can attach multiple files instead of using `attach` for each file.
src/Illuminate/Http/Client/PendingRequest.php
@@ -200,6 +200,21 @@ public function attach($name, $contents, $filename = null, array $headers = []) return $this; } + + /** + * Attach multiple files to the request. Accepts an array containing arrays of files + * + * @param array $files + * @return $this + */ + public f...
false
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Auth/AuthAccessGateTest.php
@@ -672,7 +672,7 @@ public function testResponseReturnsResponseWhenAbilityDenied() $this->assertSame('Not allowed to view as it is not published.', $response->message()); $this->assertFalse($response->allowed()); $this->assertTrue($response->denied()); - $this->assertEquals($response->...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Auth/AuthorizeMiddlewareTest.php
@@ -87,7 +87,7 @@ public function testSimpleAbilityAuthorized() $response = $this->router->dispatch(Request::create('dashboard', 'GET')); - $this->assertEquals($response->content(), 'success'); + $this->assertEquals('success', $response->content()); } public function testSimpleAbi...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Cache/CacheRepositoryTest.php
@@ -240,7 +240,7 @@ public function testRegisterMacroWithNonStaticCall() $repo::macro(__CLASS__, function () { return 'Taylor'; }); - $this->assertEquals($repo->{__CLASS__}(), 'Taylor'); + $this->assertEquals('Taylor', $repo->{__CLASS__}()); } public function tes...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Container/ContainerTest.php
@@ -398,7 +398,7 @@ public function testGetAlias() { $container = new Container; $container->alias('ConcreteStub', 'foo'); - $this->assertEquals($container->getAlias('foo'), 'ConcreteStub'); + $this->assertEquals('ConcreteStub', $container->getAlias('foo')); } public fun...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Database/DatabaseEloquentIntegrationTest.php
@@ -352,7 +352,7 @@ public function testUpdateOrCreate() ); $this->assertSame('Mohamed Said', $user3->name); - $this->assertEquals(EloquentTestUser::count(), 2); + $this->assertEquals(2, EloquentTestUser::count()); } public function testUpdateOrCreateOnDifferentConnection()...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Database/DatabaseSchemaBuilderTest.php
@@ -53,6 +53,6 @@ public function testGetColumnTypeAddsPrefix() $column->shouldReceive('getType')->once()->andReturn($type); $type->shouldReceive('getName')->once()->andReturn('integer'); - $this->assertEquals($builder->getColumnType('users', 'id'), 'integer'); + $this->assertEquals('i...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Events/EventsSubscriberTest.php
@@ -41,10 +41,10 @@ public function testEventSubscribeCanReturnMappings() $d->subscribe(DeclarativeSubscriber::class); $d->dispatch('myEvent1'); - $this->assertEquals(DeclarativeSubscriber::$string, 'L1_L2_'); + $this->assertEquals('L1_L2_', DeclarativeSubscriber::$string); ...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Foundation/FoundationApplicationTest.php
@@ -145,7 +145,7 @@ public function testDeferredServiceDontRunWhenInstanceSet() $app->setDeferredServices(['foo' => ApplicationDeferredServiceProviderStub::class]); $app->instance('foo', 'bar'); $instance = $app->make('foo'); - $this->assertEquals($instance, 'bar'); + $this->ass...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Http/HttpRequestTest.php
@@ -1022,19 +1022,19 @@ public function testMagicMethods() $request = Request::create('/', 'GET', ['foo' => 'bar', 'empty' => '']); // Parameter 'foo' is 'bar', then it ISSET and is NOT EMPTY. - $this->assertEquals($request->foo, 'bar'); - $this->assertEquals(isset($request->foo), true...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Integration/Foundation/FoundationHelpersTest.php
@@ -15,19 +15,28 @@ class FoundationHelpersTest extends TestCase { public function testRescue() { - $this->assertEquals(rescue(function () { - throw new Exception; - }, 'rescued!'), 'rescued!'); - - $this->assertEquals(rescue(function () { - throw new Exception; - ...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Queue/QueueSqsQueueTest.php
@@ -127,7 +127,7 @@ public function testSizeProperlyReadsSqsQueueSize() $queue->expects($this->once())->method('getQueue')->with($this->queueName)->willReturn($this->queueUrl); $this->sqs->shouldReceive('getQueueAttributes')->once()->with(['QueueUrl' => $this->queueUrl, 'AttributeNames' => ['Approxima...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Session/SessionStoreTest.php
@@ -433,7 +433,7 @@ public function testName() $session = $this->getSession(); $this->assertEquals($session->getName(), $this->getSessionName()); $session->setName('foo'); - $this->assertEquals($session->getName(), 'foo'); + $this->assertEquals('foo', $session->getName()); ...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Support/SupportArrTest.php
@@ -110,7 +110,7 @@ public function testDot() $this->assertEquals(['foo.bar' => []], $array); $array = Arr::dot(['name' => 'taylor', 'languages' => ['php' => true]]); - $this->assertEquals($array, ['name' => 'taylor', 'languages.php' => true]); + $this->assertEquals(['name' => 'taylor'...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Support/SupportFluentTest.php
@@ -64,7 +64,7 @@ public function testArrayAccessToAttributes() $fluent = new Fluent(['attributes' => '1']); $this->assertTrue(isset($fluent['attributes'])); - $this->assertEquals($fluent['attributes'], 1); + $this->assertEquals(1, $fluent['attributes']); $fluent->attributes...
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Validation/ValidationFactoryTest.php
@@ -73,7 +73,7 @@ public function testValidateCallsValidateOnTheValidator() ['foo' => 'required'] ); - $this->assertEquals($validated, ['foo' => 'bar']); + $this->assertEquals(['foo' => 'bar'], $validated); } public function testCustomResolverIsCalled()
true
Other
laravel
framework
093a6f8628d15914ebc0c3af8d0fc1dabe9373f6.json
Fix misordered assertEquals arguments (#34688)
tests/Validation/ValidationValidatorTest.php
@@ -4665,10 +4665,13 @@ public function testInvalidMethod() '*.name' => 'required', ]); - $this->assertEquals($v->invalid(), [ - 1 => ['name' => null], - 2 => ['name' => ''], - ]); + $this->assertEquals( + [ + 1 => ['na...
true
Other
laravel
framework
0612709ac926414342a4d982fdfd8dca024d4abb.json
Apply fixes from StyleCI (#34684)
src/Illuminate/View/Compilers/Concerns/CompilesLayouts.php
@@ -29,7 +29,7 @@ protected function compileExtends($expression) return ''; } - + /** * Compile the extends-first statements into valid PHP. *
false
Other
laravel
framework
ea3f1e3e456843fb5b0c5cc67c86c2fe3d87b861.json
Apply fixes from StyleCI (#34682)
src/Illuminate/Pagination/AbstractPaginator.php
@@ -346,7 +346,7 @@ public function through(callable $callback) $this->items->transform($callback); return $this; - } + } /** * Get the number of items shown per page.
false
Other
laravel
framework
b2a36411a774dba218fa312b8fd3bcf4be44a4e5.json
Fix breaking change
src/Illuminate/Database/Console/Migrations/MigrateCommand.php
@@ -164,6 +164,14 @@ protected function loadSchemaState() */ protected function schemaPath($connection) { - return $this->option('schema-path') ?: database_path('schema/'.$connection->getName().'-schema.dump'); + if ($this->option('schema-path')) { + return $this->option('schema...
false
Other
laravel
framework
eb4f30763780089289f54aad916b79bfb53d7a50.json
Remove unused use statements Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
tests/Bus/BusBatchTest.php
@@ -16,8 +16,6 @@ use Illuminate\Database\Eloquent\Model; use Illuminate\Foundation\Bus\Dispatchable; use Illuminate\Queue\CallQueuedClosure; -use Illuminate\Queue\InteractsWithQueue; -use Illuminate\Queue\SerializesModels; use Mockery as m; use PHPUnit\Framework\TestCase; use RuntimeException;
false
Other
laravel
framework
71745f4f9d3e14f240a32ebffcddf379f807926e.json
Use test job classes to fix seralization issue Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
tests/Bus/BusBatchTest.php
@@ -311,17 +311,11 @@ public function test_chain_can_be_added_to_batch() $batch = $this->createTestBatch($queue); - $chainHeadJob = new class implements ShouldQueue { - use Dispatchable, InteractsWithQueue, Queueable, SerializesModels, Batchable; - }; + $chainHeadJob = new C...
false
Other
laravel
framework
d590d78dc286c88fcf38588f3e0f1d4fbcc45989.json
add doc blocks
src/Illuminate/View/AppendableAttributeValue.php
@@ -4,8 +4,19 @@ class AppendableAttributeValue { + /** + * The attribute value. + * + * @var mixed + */ public $value; + /** + * Create a new appendable attribute value. + * + * @param mixed $value + * @return void + */ public function __construct($value) ...
false
Other
laravel
framework
09b887b85614d3e2539e74f40d7aa9c1c9f903d3.json
add support for appendable component attributes
src/Illuminate/View/AppendableAttributeValue.php
@@ -0,0 +1,13 @@ +<?php + +namespace Illuminate\View; + +class AppendableAttributeValue +{ + public $value; + + public function __construct($value) + { + $this->value = $value; + } +}
true
Other
laravel
framework
09b887b85614d3e2539e74f40d7aa9c1c9f903d3.json
add support for appendable component attributes
src/Illuminate/View/ComponentAttributeBag.php
@@ -171,31 +171,76 @@ public function exceptProps($keys) */ public function merge(array $attributeDefaults = [], $escape = true) { - $attributes = []; - $attributeDefaults = array_map(function ($value) use ($escape) { - if (! $escape || is_object($value) || is_null($value) || ...
true
Other
laravel
framework
09b887b85614d3e2539e74f40d7aa9c1c9f903d3.json
add support for appendable component attributes
tests/Integration/View/BladeTest.php
@@ -48,6 +48,15 @@ public function test_rendering_the_same_dynamic_component_with_different_attribu </span>', trim($view)); } + public function test_appendable_attributes() + { + $view = View::make('uses-appendable-panel', ['name' => 'Taylor'])->render(); + + $this->assertEquals('<div class=...
true
Other
laravel
framework
09b887b85614d3e2539e74f40d7aa9c1c9f903d3.json
add support for appendable component attributes
tests/Integration/View/templates/components/appendable-panel.blade.php
@@ -0,0 +1,5 @@ +@props(['name']) + +<div {{ $attributes->merge(['class' => 'mt-4', 'data-controller' => $attributes->appends('inside-controller')]) }}> + Hello {{ $name }} +</div>
true
Other
laravel
framework
09b887b85614d3e2539e74f40d7aa9c1c9f903d3.json
add support for appendable component attributes
tests/Integration/View/templates/uses-appendable-panel.blade.php
@@ -0,0 +1,3 @@ +<x-appendable-panel class="bg-gray-100" :name="$name" data-controller="outside-controller" foo="bar"> + Panel contents +</x-appendable-panel>
true
Other
laravel
framework
77676a28826edb3a748ee8981ea9cf8499d4fd75.json
Create a test that a chain can be added Signed-off-by: Kevin Ullyott <ullyott.kevin@gmail.com>
tests/Bus/BusBatchTest.php
@@ -8,11 +8,16 @@ use Illuminate\Bus\BatchFactory; use Illuminate\Bus\DatabaseBatchRepository; use Illuminate\Bus\PendingBatch; +use Illuminate\Bus\Queueable; use Illuminate\Container\Container; use Illuminate\Contracts\Queue\Factory; +use Illuminate\Contracts\Queue\ShouldQueue; use Illuminate\Database\Capsule\Ma...
false
Other
laravel
framework
adbaf16c2ecea1ed7be657e3f1c4c9f8d77849ca.json
Add withUserAgent to HTTP client (#34611)
src/Illuminate/Http/Client/PendingRequest.php
@@ -341,6 +341,17 @@ public function withoutRedirecting() }); } + /** + * Specify the user agent for the request. + * + * @param string $userAgent + * @return $this + */ + public function withUserAgent($userAgent) + { + return $this->withHeaders(['User-Agent' => $us...
true
Other
laravel
framework
adbaf16c2ecea1ed7be657e3f1c4c9f8d77849ca.json
Add withUserAgent to HTTP client (#34611)
tests/Http/HttpClientTest.php
@@ -237,6 +237,18 @@ public function testItCanSendToken() }); } + public function testItCanSendUserAgent() + { + $this->factory->fake(); + + $this->factory->withUserAgent('Laravel')->post('http://foo.com/json'); + + $this->factory->assertSent(function (Request $request) { + ...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Bus/BusBatchTest.php
@@ -198,7 +198,7 @@ public function test_failed_jobs_can_be_recorded_while_not_allowing_failures() $this->assertTrue($batch->cancelled()); $this->assertEquals(1, $_SERVER['__finally.count']); $this->assertEquals(1, $_SERVER['__catch.count']); - $this->assertEquals('Something went wrong...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Bus/BusBatchableTest.php
@@ -22,15 +22,15 @@ public function test_batch_may_be_retrieved() }; $this->assertSame($class, $class->withBatchId('test-batch-id')); - $this->assertEquals('test-batch-id', $class->batchId); + $this->assertSame('test-batch-id', $class->batchId); Container::setInstance($conta...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Bus/BusPendingBatchTest.php
@@ -40,8 +40,8 @@ public function test_pending_batch_may_be_configured_and_dispatched() // })->allowFailures()->onConnection('test-connection')->onQueue('test-queue'); - $this->assertEquals('test-connection', $pendingBatch->connection()); - $this->assertEquals('test-queue', $pendin...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Database/DatabaseEloquentFactoryTest.php
@@ -94,7 +94,7 @@ public function test_basic_model_can_be_created() $user = FactoryTestUserFactory::new()->create(['name' => 'Taylor Otwell']); $this->assertInstanceOf(Eloquent::class, $user); - $this->assertEquals('Taylor Otwell', $user->name); + $this->assertSame('Taylor Otwell', $us...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Database/DatabaseEloquentModelTest.php
@@ -67,7 +67,7 @@ public function testAttributeManipulation() $model->list_items = ['name' => 'taylor']; $this->assertEquals(['name' => 'taylor'], $model->list_items); $attributes = $model->getAttributes(); - $this->assertEquals(json_encode(['name' => 'taylor']), $attributes['list_item...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Database/DatabaseEloquentPivotTest.php
@@ -161,13 +161,13 @@ public function testWithoutRelations() $original->pivotParent = 'foo'; $original->setRelation('bar', 'baz'); - $this->assertEquals('baz', $original->getRelation('bar')); + $this->assertSame('baz', $original->getRelation('bar')); $pivot = $original->with...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Database/DatabaseQueryBuilderTest.php
@@ -3077,12 +3077,12 @@ public function testSubSelectResetBindings() $query->from('two')->select('baz')->where('subkey', '=', 'subval'); }, 'sub'); - $this->assertEquals('select (select "baz" from "two" where "subkey" = ?) as "sub" from "one"', $builder->toSql()); + $this->assertSa...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Integration/Database/DatabaseEloquentModelCustomCastingTest.php
@@ -31,15 +31,15 @@ public function testBasicCustomCasting() $model->syncOriginal(); $model->uppercase = 'dries'; - $this->assertEquals('TAYLOR', $model->getOriginal('uppercase')); + $this->assertSame('TAYLOR', $model->getOriginal('uppercase')); $model = new TestEloquentMode...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Integration/Database/DatabaseSchemaBuilderAlterTableWithEnumTest.php
@@ -22,7 +22,7 @@ public function testChangeColumnOnTableWithEnum() $table->unsignedInteger('age')->charset('')->change(); }); - $this->assertEquals('integer', Schema::getColumnType('users', 'age')); + $this->assertSame('integer', Schema::getColumnType('users', 'age')); } ...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Integration/Database/EloquentModelWithoutEventsTest.php
@@ -31,7 +31,7 @@ public function testWithoutEventsRegistersBootedListenersForLater() $model->save(); - $this->assertEquals('Laravel', $model->project); + $this->assertSame('Laravel', $model->project); } }
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Integration/Foundation/MaintenanceModeTest.php
@@ -67,7 +67,7 @@ public function testMaintenanceModeCanHaveCustomTemplate() $response->assertStatus(503); $response->assertHeader('Retry-After', '60'); - $this->assertEquals('Rendered Content', $response->original); + $this->assertSame('Rendered Content', $response->original); } ...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Integration/View/BladeTest.php
@@ -14,7 +14,7 @@ public function test_basic_blade_rendering() { $view = View::make('hello', ['name' => 'Taylor'])->render(); - $this->assertEquals('Hello Taylor', trim($view)); + $this->assertSame('Hello Taylor', trim($view)); } public function test_rendering_a_component() @@ ...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Queue/QueueDatabaseQueueUnitTest.php
@@ -31,7 +31,7 @@ public function testPushProperlyPushesJobOntoDatabase() $database->shouldReceive('table')->with('table')->andReturn($query = m::mock(stdClass::class)); $query->shouldReceive('insertGetId')->once()->andReturnUsing(function ($array) use ($uuid) { $this->assertSame('default...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Redis/RedisConnectorTest.php
@@ -34,7 +34,7 @@ public function testDefaultConfiguration() $predisClient = $this->redis['predis']->connection()->client(); $parameters = $predisClient->getConnection()->getParameters(); - $this->assertEquals('tcp', $parameters->scheme); + $this->assertSame('tcp', $parameters->scheme)...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Routing/RoutingRouteTest.php
@@ -202,7 +202,7 @@ public function testMiddlewareCanBeSkipped() return 'hello'; }])->withoutMiddleware(RoutingTestMiddlewareGroupTwo::class); - $this->assertEquals('hello', $router->dispatch(Request::create('foo/bar', 'GET'))->getContent()); + $this->assertSame('hello', $router->d...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/Validation/ValidationValidatorTest.php
@@ -61,7 +61,7 @@ public function testNestedErrorMessagesAreRetrievedFromLocalArray() ]); $this->assertFalse($v->passes()); - $this->assertEquals('post name is required', $v->errors()->all()[0]); + $this->assertSame('post name is required', $v->errors()->all()[0]); } public...
true
Other
laravel
framework
cfef0246e490b86289893833f0e15cb6f2ec240a.json
Use stricter assertions. (#34595)
tests/View/ViewComponentTest.php
@@ -25,7 +25,7 @@ public function testAttributeParentInheritance() $component->withAttributes(['class' => 'foo', 'attributes' => new ComponentAttributeBag(['class' => 'bar', 'type' => 'button'])]); - $this->assertEquals('class="foo bar" type="button"', (string) $component->attributes); + $thi...
true
Other
laravel
framework
277e3c353235b58dfbe7f6035720b0ca328c9095.json
Fix many docblocks in Illuminate\Bus. (#34596)
src/Illuminate/Bus/Batch.php
@@ -81,21 +81,21 @@ class Batch implements Arrayable, JsonSerializable /** * The date indicating when the batch was created. * - * @var \Illuminate\Support\CarbonImmutable + * @var \Carbon\CarbonImmutable */ public $createdAt; /** * The date indicating when the batch was...
true
Other
laravel
framework
277e3c353235b58dfbe7f6035720b0ca328c9095.json
Fix many docblocks in Illuminate\Bus. (#34596)
src/Illuminate/Bus/BatchFactory.php
@@ -36,9 +36,9 @@ public function __construct(QueueFactory $queue) * @param int $failedJobs * @param array $failedJobIds * @param array $options - * @param \Illuminate\Support\CarbonImmutable $createdAt - * @param \Illuminate\Support\CarbonImmutable|null $cancelledAt - * @param ...
true
Other
laravel
framework
277e3c353235b58dfbe7f6035720b0ca328c9095.json
Fix many docblocks in Illuminate\Bus. (#34596)
src/Illuminate/Bus/PendingBatch.php
@@ -215,6 +215,7 @@ public function queue() * Dispatch the batch. * * @return \Illuminate\Bus\Batch + * @throws \Throwable */ public function dispatch() {
true
Other
laravel
framework
b5f74acc37c9b0372c094afa28b39cb4d64ea0d9.json
Fix Client\Response `throw` method (#34597)
src/Illuminate/Http/Client/Response.php
@@ -225,14 +225,14 @@ public function toPsrResponse() */ public function throw() { - $callback = func_get_arg(0); + $callback = func_get_args()[0] ?? null; if ($this->serverError() || $this->clientError()) { - if ($callback && is_callable($callback)) { - ...
false
Other
laravel
framework
89d9cd46e6cf764171cae2c762872aacf87d65dd.json
Apply fixes from StyleCI (#34579)
src/Illuminate/Database/Eloquent/Relations/MorphPivot.php
@@ -2,7 +2,6 @@ namespace Illuminate\Database\Eloquent\Relations; -use Illuminate\Database\Eloquent\Builder; use Illuminate\Support\Str; class MorphPivot extends Pivot
false
Other
laravel
framework
1b3f62aaeced2c9761a6052a7f0d3c1a046851c9.json
remove type hint
src/Illuminate/Database/Eloquent/Relations/Concerns/AsPivot.php
@@ -88,7 +88,7 @@ public static function fromRawAttributes(Model $parent, $attributes, $table, $ex * @param \Illuminate\Database\Eloquent\Builder $query * @return \Illuminate\Database\Eloquent\Builder */ - protected function setKeysForSaveQuery(Builder $query) + protected function setKeysForSa...
true
Other
laravel
framework
1b3f62aaeced2c9761a6052a7f0d3c1a046851c9.json
remove type hint
src/Illuminate/Database/Eloquent/Relations/MorphPivot.php
@@ -31,7 +31,7 @@ class MorphPivot extends Pivot * @param \Illuminate\Database\Eloquent\Builder $query * @return \Illuminate\Database\Eloquent\Builder */ - protected function setKeysForSaveQuery(Builder $query) + protected function setKeysForSaveQuery($query) { $query->where($thi...
true
Other
laravel
framework
c131f471af6e3a45593adbe0ed3bbea074f85500.json
Add throwWith to the HTTP client response Because: - There is a repeated pattern where you want to perform a particular action if the response has failed, such as logging the error. ```php // before... $response = $client->withHeaders($headers)->post($url, $payload); if ($response->failed()) { Log::error('Twi...
src/Illuminate/Http/Client/Response.php
@@ -208,8 +208,25 @@ public function toPsrResponse() * @throws \Illuminate\Http\Client\RequestException */ public function throw() + { + return $this->throwWith(function () { + // + }); + } + + /** + * Execute the callback and throw an exception if a server of clie...
true
Other
laravel
framework
c131f471af6e3a45593adbe0ed3bbea074f85500.json
Add throwWith to the HTTP client response Because: - There is a repeated pattern where you want to perform a particular action if the response has failed, such as logging the error. ```php // before... $response = $client->withHeaders($headers)->post($url, $payload); if ($response->failed()) { Log::error('Twi...
tests/Http/HttpClientTest.php
@@ -476,6 +476,42 @@ public function testRequestExceptionEmptyBody() throw new RequestException(new Response($response)); } + public function testThrowWithCallsClosureOnError() + { + $status = 0; + $client = $this->factory->fake([ + 'laravel.com' => $this->factory::respons...
true
Other
laravel
framework
2ec773802f75c20926a27b8b308b3ea2f13b8d7c.json
set no timeout
src/Illuminate/Database/Schema/MySqlSchemaState.php
@@ -116,7 +116,7 @@ protected function baseVariables(array $config) protected function executeDumpProcess(Process $process, $output, array $variables) { try { - $process->mustRun($output, $variables); + $process->setTimeout(null)->mustRun($output, $variables); } catch (...
true
Other
laravel
framework
2ec773802f75c20926a27b8b308b3ea2f13b8d7c.json
set no timeout
src/Illuminate/Database/Schema/PostgresSchemaState.php
@@ -31,7 +31,7 @@ protected function appendMigrationData(string $path) { with($process = $this->makeProcess( $this->baseDumpCommand().' --table=migrations --data-only --inserts' - ))->mustRun(null, array_merge($this->baseVariables($this->connection->getConfig()), [ + ))->setTime...
true
Other
laravel
framework
2ec773802f75c20926a27b8b308b3ea2f13b8d7c.json
set no timeout
src/Illuminate/Database/Schema/SqliteSchemaState.php
@@ -15,7 +15,7 @@ public function dump($path) { with($process = $this->makeProcess( $this->baseCommand().' .schema' - ))->mustRun(null, array_merge($this->baseVariables($this->connection->getConfig()), [ + ))->setTimeout(null)->mustRun(null, array_merge($this->baseVariables($thi...
true
Other
laravel
framework
20ff6a5db22f6cc8f971a715f09ee65e11bf4adc.json
Fix small issues with CHANGELOG-7.xmd Capitalize first word in sentence, 2 times Change dont -> don't, 3 times
CHANGELOG-7.x.md
@@ -44,7 +44,7 @@ - RefreshDatabase migration commands parameters moved to methods ([#34007](https://github.com/laravel/framework/pull/34007), [8b35c8e](https://github.com/laravel/framework/commit/8b35c8e6ba5879e71fd81fd03b5687ee2b46c55a), [256f71c](https://github.com/laravel/framework/commit/256f71c1f81da2d4bb3e327b1...
false
Other
laravel
framework
f3707046a65f6390f5f19047f8693ac58b9e0c28.json
Fix 2 small issues in change log Change word: dont -> don't Capitalize first word in sentence
CHANGELOG-8.x.md
@@ -27,7 +27,7 @@ - Added `Illuminate\Session\Store::passwordConfirmed()` ([fb3f45a](https://github.com/laravel/framework/commit/fb3f45aa0142764c5c29b97e8bcf8328091986e9)) ### Changed -- check for view existence first in `Illuminate\Mail\Markdown::render()` ([5f78c90](https://github.com/laravel/framework/commit/5f7...
false
Other
laravel
framework
3e66eb75ae379f14eb760a19071a07134de797e3.json
use related model for methods
src/Illuminate/Database/Eloquent/Relations/BelongsToMany.php
@@ -585,7 +585,7 @@ public function findOrNew($id, $columns = ['*']) */ public function firstOrNew(array $attributes) { - if (is_null($instance = $this->where($attributes)->first())) { + if (is_null($instance = $this->related->where($attributes)->first())) { $instance = $this-...
false